[jira] [Commented] (MRELEASE-798) Commit additional files with release plugin

2018-04-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443346#comment-16443346
 ] 

ASF GitHub Bot commented on MRELEASE-798:
-

jgangemi commented on issue #4: [MRELEASE-798] Commit additional files with 
release plugin
URL: https://github.com/apache/maven-release/pull/4#issuecomment-382561957
 
 
   a new pull request has been created with these changes against what is 
currently in `master`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Commit additional files with release plugin
> ---
>
> Key: MRELEASE-798
> URL: https://issues.apache.org/jira/browse/MRELEASE-798
> Project: Maven Release Plugin
>  Issue Type: Improvement
>  Components: prepare, scm
>Affects Versions: 2.3.2
>Reporter: Thorsten Hoeger
>Priority: Major
>  Labels: github-pullrequest
> Attachments: maven-release-2.4.1-additionalCommitted.patch
>
>
> Hi,
> is there any possibility to have the release-plugin commit additional files 
> which were
> generated/modified in the preparationGoals.
> Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks 
> in this
> situation.
> If it is not possible at the moment, is there any chance to get this in the 
> future. Maybe
> there could be a parameter additionalCommitFiles with a list of files to 
> commit along with
> pom.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jgangemi commented on issue #4: [MRELEASE-798] Commit additional files with release plugin

2018-04-18 Thread GitBox
jgangemi commented on issue #4: [MRELEASE-798] Commit additional files with 
release plugin
URL: https://github.com/apache/maven-release/pull/4#issuecomment-382561957
 
 
   a new pull request has been created with these changes against what is 
currently in `master`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] jgangemi opened a new pull request #20: - allow additional files to be commited at release

2018-04-18 Thread GitBox
jgangemi opened a new pull request #20: - allow additional files to be commited 
at release
URL: https://github.com/apache/maven-release/pull/20
 
 
   replaces pull-request #4 which currently has merge conflicts.
   
   @emenaceb is given credit for the work in the commit history but i wasn't 
about to deal w/ all the merge conflicts of rebasing 2.5/3 years worth of 
changes, so i just made them against what is currently in `master` and also 
added some tests where i could using existing functionality (`completionGoals`) 
as the example.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MSITE-812) Missing '/' in log when deploying documentation by site:stage

2018-04-18 Thread JIRA

[ 
https://issues.apache.org/jira/browse/MSITE-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443294#comment-16443294
 ] 

Hervé Boutemy commented on MSITE-812:
-

sorry, I was busy on many things
I had a look: with your patch, what happens to "mvn site:stage 
-DstagingDirectory=/Users/ajisaka/YARN-7736/" ?
I imagine it's not just about adding a / but adding it *if necessary*: I 
suppose we have utilities to add a directory to an url with every cases taken 
care of

> Missing '/' in log when deploying documentation by site:stage
> -
>
> Key: MSITE-812
> URL: https://issues.apache.org/jira/browse/MSITE-812
> Project: Maven Site Plugin
>  Issue Type: Bug
>  Components: site:stage(-deploy)
>Affects Versions: 3.7
>Reporter: Akira Ajisaka
>Priority: Major
>
> When running {{mvn site:stage -DstagingDirectory=/Users/ajisaka/YARN-7736}} 
> {noformat}
> [INFO] 
> 
> [INFO] Building Apache Hadoop Project POM 3.2.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-site-plugin:3.7:stage (default-cli) @ hadoop-project ---
> [INFO] Using this base directory for staging: /Users/ajisaka/YARN-7736
> [INFO] Pushing /Users/ajisaka/git/hadoop/hadoop-project/target/site
> [INFO]>>> to file:///Users/ajisaka/YARN-7736hadoop-project
> {noformat}
> '/' is missing between YARN-7736 and hadoop-project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MRELEASE-798) Commit additional files with release plugin

2018-04-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443045#comment-16443045
 ] 

ASF GitHub Bot commented on MRELEASE-798:
-

ctubbsii commented on issue #4: [MRELEASE-798] Commit additional files with 
release plugin
URL: https://github.com/apache/maven-release/pull/4#issuecomment-382495065
 
 
   If it helps anybody, I've been able to work around this missing feature 
[using a release profile][1].
   
   [1]: 
https://stackoverflow.com/questions/48947392/commit-multiple-files-with-maven-scm-plugin/49124982#49124982


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Commit additional files with release plugin
> ---
>
> Key: MRELEASE-798
> URL: https://issues.apache.org/jira/browse/MRELEASE-798
> Project: Maven Release Plugin
>  Issue Type: Improvement
>  Components: prepare, scm
>Affects Versions: 2.3.2
>Reporter: Thorsten Hoeger
>Priority: Major
>  Labels: github-pullrequest
> Attachments: maven-release-2.4.1-additionalCommitted.patch
>
>
> Hi,
> is there any possibility to have the release-plugin commit additional files 
> which were
> generated/modified in the preparationGoals.
> Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks 
> in this
> situation.
> If it is not possible at the moment, is there any chance to get this in the 
> future. Maybe
> there could be a parameter additionalCommitFiles with a list of files to 
> commit along with
> pom.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] ctubbsii commented on issue #4: [MRELEASE-798] Commit additional files with release plugin

2018-04-18 Thread GitBox
ctubbsii commented on issue #4: [MRELEASE-798] Commit additional files with 
release plugin
URL: https://github.com/apache/maven-release/pull/4#issuecomment-382495065
 
 
   If it helps anybody, I've been able to work around this missing feature 
[using a release profile][1].
   
   [1]: 
https://stackoverflow.com/questions/48947392/commit-multiple-files-with-maven-scm-plugin/49124982#49124982


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[GitHub] marcphilipp commented on issue #183: junit5

2018-04-18 Thread GitBox
marcphilipp commented on issue #183: junit5
URL: https://github.com/apache/maven-surefire/pull/183#issuecomment-382488665
 
 
   Since a picture is sometimes worth a thousand words:
   
   https://user-images.githubusercontent.com/214207/38951423-e2d5c82c-4348-11e8-94f0-840a0c78b617.png;>
   
   @Tibor17 Does that make it clearer?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MRELEASE-798) Commit additional files with release plugin

2018-04-18 Thread ASF GitHub Bot (JIRA)

[ 
https://issues.apache.org/jira/browse/MRELEASE-798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16443007#comment-16443007
 ] 

ASF GitHub Bot commented on MRELEASE-798:
-

jgangemi commented on issue #4: [MRELEASE-798] Commit additional files with 
release plugin
URL: https://github.com/apache/maven-release/pull/4#issuecomment-382485427
 
 
   it's now 2018 and this is still open. i'd really like to see this 
functionality committed and released.
   
   can anyone comment on this?!!!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Commit additional files with release plugin
> ---
>
> Key: MRELEASE-798
> URL: https://issues.apache.org/jira/browse/MRELEASE-798
> Project: Maven Release Plugin
>  Issue Type: Improvement
>  Components: prepare, scm
>Affects Versions: 2.3.2
>Reporter: Thorsten Hoeger
>Priority: Major
>  Labels: github-pullrequest
> Attachments: maven-release-2.4.1-additionalCommitted.patch
>
>
> Hi,
> is there any possibility to have the release-plugin commit additional files 
> which were
> generated/modified in the preparationGoals.
> Now only the pom.xml is commited. Using scm-plugin has some serious drawbacks 
> in this
> situation.
> If it is not possible at the moment, is there any chance to get this in the 
> future. Maybe
> there could be a parameter additionalCommitFiles with a list of files to 
> commit along with
> pom.xml.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] jgangemi commented on issue #4: [MRELEASE-798] Commit additional files with release plugin

2018-04-18 Thread GitBox
jgangemi commented on issue #4: [MRELEASE-798] Commit additional files with 
release plugin
URL: https://github.com/apache/maven-release/pull/4#issuecomment-382485427
 
 
   it's now 2018 and this is still open. i'd really like to see this 
functionality committed and released.
   
   can anyone comment on this?!!!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Updated] (MSHADE-250) Allow prefixing relocated classes

2018-04-18 Thread David Phillips (JIRA)

 [ 
https://issues.apache.org/jira/browse/MSHADE-250?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

David Phillips updated MSHADE-250:
--
Description: I would like to prefix all of the relocated classes with a 
{{$}}. This prevents them from accidentally being used, imported by IDEs, etc. 
For example, {{com.google.common.collect.ImmutableList}} would become 
{{guava.collect.$ImmutableList}}.  (was: I would like to prefix all of the 
relocated classes with a {{$}}. This prevents them from accidentally being 
used, imported by IDEs, etc. For example, 
{{com.google.common.collect.ImmutableList}} would become 
{{com.example.guava.collect.$ImmutableList}}.)

> Allow prefixing relocated classes
> -
>
> Key: MSHADE-250
> URL: https://issues.apache.org/jira/browse/MSHADE-250
> Project: Maven Shade Plugin
>  Issue Type: New Feature
>Reporter: David Phillips
>Priority: Major
>
> I would like to prefix all of the relocated classes with a {{$}}. This 
> prevents them from accidentally being used, imported by IDEs, etc. For 
> example, {{com.google.common.collect.ImmutableList}} would become 
> {{guava.collect.$ImmutableList}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Closed] (MACR-44) Upgrade mave-surefire/failsafe-plugin 2.21.0

2018-04-18 Thread Karl Heinz Marbaise (JIRA)

 [ 
https://issues.apache.org/jira/browse/MACR-44?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Karl Heinz Marbaise closed MACR-44.
---
Resolution: Done

Done in 
[fc1d886641b7055a776afb75364f5325ef50ecbe|https://gitbox.apache.org/repos/asf?p=maven-acr-plugin.git;a=commitdiff;h=fc1d886641b7055a776afb75364f5325ef50ecbe]

> Upgrade mave-surefire/failsafe-plugin 2.21.0
> 
>
> Key: MACR-44
> URL: https://issues.apache.org/jira/browse/MACR-44
> Project: Maven ACR Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Blocker
> Fix For: 3.0.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MACR-44) Upgrade mave-surefire/failsafe-plugin 2.21.0

2018-04-18 Thread Hudson (JIRA)

[ 
https://issues.apache.org/jira/browse/MACR-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442889#comment-16442889
 ] 

Hudson commented on MACR-44:


Build succeeded in Jenkins: Maven TLP » maven-acr-plugin » master #6

See https://builds.apache.org/job/maven-box/job/maven-acr-plugin/job/master/6/

> Upgrade mave-surefire/failsafe-plugin 2.21.0
> 
>
> Key: MACR-44
> URL: https://issues.apache.org/jira/browse/MACR-44
> Project: Maven ACR Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Blocker
> Fix For: 3.0.1
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MCHANGES-386) Upgrade parent to 31

2018-04-18 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created MCHANGES-386:


 Summary: Upgrade parent to 31
 Key: MCHANGES-386
 URL: https://issues.apache.org/jira/browse/MCHANGES-386
 Project: Maven Changes Plugin
  Issue Type: Dependency upgrade
Affects Versions: 3.0.0
Reporter: Karl Heinz Marbaise
Assignee: Karl Heinz Marbaise
 Fix For: 3.0.0






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (MACR-44) Upgrade mave-surefire/failsafe-plugin 2.21.0

2018-04-18 Thread Karl Heinz Marbaise (JIRA)
Karl Heinz Marbaise created MACR-44:
---

 Summary: Upgrade mave-surefire/failsafe-plugin 2.21.0
 Key: MACR-44
 URL: https://issues.apache.org/jira/browse/MACR-44
 Project: Maven ACR Plugin
  Issue Type: Bug
Affects Versions: 3.0.1
Reporter: Karl Heinz Marbaise
Assignee: Karl Heinz Marbaise
 Fix For: 3.0.1






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build

2018-04-18 Thread Alexander Griesbaum (JIRA)

[ 
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16442680#comment-16442680
 ] 

Alexander Griesbaum commented on MNG-6391:
--

Hi [~michael-o],

The order has nothing to do with this visual misleading information. I mixed it 
up because I did not understand that the reactor build changes order to resolve 
dependencies and so I assumed that it could correlate with the visual "bug" I 
started the discussion about.

I am also fine with deleting the information at the end completly but I think 
it is pretty obvious that the actual solution is not that good.

> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
>  Issue Type: Improvement
>  Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.5.4
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version 
> printout but also the last built module.
> {code:java}
> [INFO] 
> 
> [INFO] Reactor Summary:
> [INFO] 
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib  SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO] 
> 
> [INFO] BUILD SUCCESS
> [INFO] 
> 
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the 
> version printout.
> Also this is not the order I configured the modules in the parent pom but I 
> think this could be something on my side.
> {code:java}
> 
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
> 
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Created] (SCM-883) ScmFileSet DEFAULT_EXCLUDES too restrictive

2018-04-18 Thread JIRA
Fabian Köntopp created SCM-883:
--

 Summary: ScmFileSet DEFAULT_EXCLUDES too restrictive
 Key: SCM-883
 URL: https://issues.apache.org/jira/browse/SCM-883
 Project: Maven SCM
  Issue Type: Bug
  Components: maven-scm-api
Affects Versions: 1.9.5
Reporter: Fabian Köntopp


We are trying to automate a process in which a default *.gitignore* file *only* 
(ignoring the current state of the repository) is added to a repository at the 
root level. Because of the DEFAULT_EXCLUDES in the ScmFileSet-Class this is 
impossible because .gitignore is listed there and the default excludes are 
always added to the final exlude list.

In my opinion the .gitignore file should not be listed there because such files 
are part of a git repository. At least it should be possible to override the 
excludes completely without the DEFAULT_EXCLUDES always being added.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[GitHub] crewmanmud opened a new pull request #2: Update index.apt.vm

2018-04-18 Thread GitBox
crewmanmud opened a new pull request #2: Update index.apt.vm
URL: https://github.com/apache/maven-deploy-plugin/pull/2
 
 
   Remove link to 'Disable timestamps suffix in an artifact' examples page that 
was removed in commit bb00fae8bc656e63ac54560307e4cbb0ad1a8025.
   
   As an aside, is the 'https://maven.apache.org/plugins/maven-deploy-plugin/' 
still the home page for this plugin?  Plans to maintain that site, or unpublish 
it and transition to Markdown documentation on GutHub?  Just curious!  It seems 
like 'https://maven.apache.org/plugins/' does not link to the individual plugin 
sites.
   
   Thanks!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services


[jira] [Commented] (MSITE-812) Missing '/' in log when deploying documentation by site:stage

2018-04-18 Thread Akira Ajisaka (JIRA)

[ 
https://issues.apache.org/jira/browse/MSITE-812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441986#comment-16441986
 ] 

Akira Ajisaka commented on MSITE-812:
-

Hi [~hboutemy], would you review this pull request?

> Missing '/' in log when deploying documentation by site:stage
> -
>
> Key: MSITE-812
> URL: https://issues.apache.org/jira/browse/MSITE-812
> Project: Maven Site Plugin
>  Issue Type: Bug
>  Components: site:stage(-deploy)
>Affects Versions: 3.7
>Reporter: Akira Ajisaka
>Priority: Major
>
> When running {{mvn site:stage -DstagingDirectory=/Users/ajisaka/YARN-7736}} 
> {noformat}
> [INFO] 
> 
> [INFO] Building Apache Hadoop Project POM 3.2.0-SNAPSHOT
> [INFO] 
> 
> [INFO] 
> [INFO] --- maven-site-plugin:3.7:stage (default-cli) @ hadoop-project ---
> [INFO] Using this base directory for staging: /Users/ajisaka/YARN-7736
> [INFO] Pushing /Users/ajisaka/git/hadoop/hadoop-project/target/site
> [INFO]>>> to file:///Users/ajisaka/YARN-7736hadoop-project
> {noformat}
> '/' is missing between YARN-7736 and hadoop-project.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)


[jira] [Commented] (MJAR-138) jar:test-jar is skipped when maven.test.skip=true

2018-04-18 Thread Leonid Rozenblyum (JIRA)

[ 
https://issues.apache.org/jira/browse/MJAR-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16441985#comment-16441985
 ] 

Leonid Rozenblyum commented on MJAR-138:


I believe the issue should be solved in Maven core.

In case maven.test.skip = true, Maven shouldn't even try to resolve 
test dependencies

> jar:test-jar is skipped when maven.test.skip=true
> -
>
> Key: MJAR-138
> URL: https://issues.apache.org/jira/browse/MJAR-138
> Project: Maven JAR Plugin
>  Issue Type: Improvement
>Affects Versions: 2.3.1
> Environment: jar:test-jar
>Reporter: Andrew Hughes
>Priority: Major
> Fix For: more-investigation
>
> Attachments: MJAR-138-maven-jar-plugin.patch
>
>
> Not sure if this is a bug or improvement...
> Example:
> * ./pom.xml
> * ./moduleA/pom.xml
> * ./moduleB/pom.xml
> Situation:
> * moduleA produces moduleA-1.2.3-test.jar with the jar:test-jar goal
> * moduleB consumes moduleA-1.2.3-test.jar as a 
> ...test
> Problem:
> * When -Dmaven.test.skip=true the moduleA-1.2.3-test.jar is never built.
> * Then when moduleB tries to build, it's moduleA-1.2.3-test.jar dependency is 
> unresolved. FAIL! Even with -Dmaven.test.skip=true this will fail.
> You might argue that this is a bug with dependency resolution with 
> -Dmaven.test.skip=true - should a missing dependency @ test scope really fail 
> the build??? It probably should - which is why the bug is submitted here :)
> I've no idea what could be done to fix this either?
> ---
> p.s. for anyone with this bug the only workaround I can suggest is running 
> another module...
> ./moduleA-test/pom.xml
> and have 
> ...moduleA-test...test



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)