[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464986#comment-16464986
 ] 

ASF GitHub Bot commented on MNG-6401:
-

jkatada commented on issue #163: [MNG-6401] - Cannot interpolate property in 
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-386855007
 
 
   > As far as I understand this PR, you are interpolating the settings before 
it is fead to SettingsXpp3Reader?
   
   Yes, you are right.
   
   > Can you also provide an IT for that?
   
   I added the test to maven-integration-testing project. The PR is 
[here](https://github.com/apache/maven-integration-testing/pull/31).
   It tests not only int field (proxy.port) but also boolean field 
(proxy.active).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not 
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is 
> [here|https://github.com/jkatada/maven-property-demo]. 
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
> 
>     my_proxy
>     true
>     http
>     ${env.MAVEN_PROXY_HOST_STRING}
>     ${env.MAVEN_PROXY_PORT_INT}
>     local.net|some.host.com
>  
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
> 
>     0
>     proxy.foo.com
>     local.net|some.host.com
>     my_proxy
> 
>  {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`, 
>  but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position: 
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused 
> by: java.lang.NumberFormatException: For input string: 
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before 
> interpolation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jkatada commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

[GitBox]

jkatada commented on issue #163: [MNG-6401] - Cannot interpolate property in 
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-386855007
 
 
   > As far as I understand this PR, you are interpolating the settings before 
it is fead to SettingsXpp3Reader?
   
   Yes, you are right.
   
   > Can you also provide an IT for that?
   
   I added the test to maven-integration-testing project. The PR is 
[here](https://github.com/apache/maven-integration-testing/pull/31).
   It tests not only int field (proxy.port) but also boolean field 
(proxy.active).


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464985#comment-16464985
 ] 

ASF GitHub Bot commented on MNG-6401:
-

jkatada opened a new pull request #31: [MNG-6401] Add IT for interpolation in 
settings.xml
URL: https://github.com/apache/maven-integration-testing/pull/31
 
 
   [Corresponding Maven pull request.](https://github.com/apache/maven/pull/163)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not 
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is 
> [here|https://github.com/jkatada/maven-property-demo]. 
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
> 
>     my_proxy
>     true
>     http
>     ${env.MAVEN_PROXY_HOST_STRING}
>     ${env.MAVEN_PROXY_PORT_INT}
>     local.net|some.host.com
>  
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
> 
>     0
>     proxy.foo.com
>     local.net|some.host.com
>     my_proxy
> 
>  {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`, 
>  but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position: 
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused 
> by: java.lang.NumberFormatException: For input string: 
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before 
> interpolation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] jkatada opened a new pull request #31: [MNG-6401] Add IT for interpolation in settings.xml

[GitBox]

jkatada opened a new pull request #31: [MNG-6401] Add IT for interpolation in 
settings.xml
URL: https://github.com/apache/maven-integration-testing/pull/31
 
 
   [Corresponding Maven pull request.](https://github.com/apache/maven/pull/163)


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464940#comment-16464940
 ] 

Michael Osipov commented on MNG-6401:
-

Same applies to all boolean fields. It is even worse, you don't see a failure, 
you it just sets value to {{false}}.

> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not 
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is 
> [here|https://github.com/jkatada/maven-property-demo]. 
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
> 
>     my_proxy
>     true
>     http
>     ${env.MAVEN_PROXY_HOST_STRING}
>     ${env.MAVEN_PROXY_PORT_INT}
>     local.net|some.host.com
>  
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
> 
>     0
>     proxy.foo.com
>     local.net|some.host.com
>     my_proxy
> 
>  {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`, 
>  but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position: 
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused 
> by: java.lang.NumberFormatException: For input string: 
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before 
> interpolation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464935#comment-16464935
 ] 

ASF GitHub Bot commented on MNG-6401:
-

michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in 
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-386842019
 
 
   Can you also provide an IT for that?
   @hboutemy, @rfscholte This is a very interesting case and I can confirm that 
our approach is incorrect. We need to interpolate the XML first and then 
unmarshal to objects and not the other way around. Everything, but `String` 
will be killed otherwise.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not 
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is 
> [here|https://github.com/jkatada/maven-property-demo]. 
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
> 
>     my_proxy
>     true
>     http
>     ${env.MAVEN_PROXY_HOST_STRING}
>     ${env.MAVEN_PROXY_PORT_INT}
>     local.net|some.host.com
>  
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
> 
>     0
>     proxy.foo.com
>     local.net|some.host.com
>     my_proxy
> 
>  {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`, 
>  but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position: 
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused 
> by: java.lang.NumberFormatException: For input string: 
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before 
> interpolation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464936#comment-16464936
 ] 

Michael Osipov commented on MNG-6401:
-

Issue confirmed.

> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not 
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is 
> [here|https://github.com/jkatada/maven-property-demo]. 
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
> 
>     my_proxy
>     true
>     http
>     ${env.MAVEN_PROXY_HOST_STRING}
>     ${env.MAVEN_PROXY_PORT_INT}
>     local.net|some.host.com
>  
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
> 
>     0
>     proxy.foo.com
>     local.net|some.host.com
>     my_proxy
> 
>  {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`, 
>  but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position: 
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused 
> by: java.lang.NumberFormatException: For input string: 
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before 
> interpolation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

[GitBox]

michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in 
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-386842019
 
 
   Can you also provide an IT for that?
   @hboutemy, @rfscholte This is a very interesting case and I can confirm that 
our approach is incorrect. We need to interpolate the XML first and then 
unmarshal to objects and not the other way around. Everything, but `String` 
will be killed otherwise.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464933#comment-16464933
 ] 

ASF GitHub Bot commented on MNG-6401:
-

michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in 
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-386841740
 
 
   As far as I understand this PR, you are interpolating the settings before it 
is fead to `SettingsXpp3Reader`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not 
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is 
> [here|https://github.com/jkatada/maven-property-demo]. 
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
> 
>     my_proxy
>     true
>     http
>     ${env.MAVEN_PROXY_HOST_STRING}
>     ${env.MAVEN_PROXY_PORT_INT}
>     local.net|some.host.com
>  
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
> 
>     0
>     proxy.foo.com
>     local.net|some.host.com
>     my_proxy
> 
>  {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`, 
>  but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position: 
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused 
> by: java.lang.NumberFormatException: For input string: 
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before 
> interpolation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml

[GitBox]

michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in 
proxy port of settings.xml
URL: https://github.com/apache/maven/pull/163#issuecomment-386841740
 
 
   As far as I understand this PR, you are interpolating the settings before it 
is fead to `SettingsXpp3Reader`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841297
 
 
   Now I see, you used the build process JDK
   `${java.home}/bin/java`
   Very well!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841327
 
 
   That's exactly why we have two JDKs.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841297
 
 
   Noe I see, you used the build process JDK
   `${java.home}/bin/java`
   Very well!


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386841131
 
 
   @sormuras 
   How did you skip tests on `surefire-junit-platform` with JDK 1.7?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386840975
 
 
   @sormuras 
   Did you also have a problem with JaCoCO:0.7.9 on JDK10?
   Do we need to have `scope=compile` on the dependency 
`junit-platform-launcher` in our provider POM? What 
will happen if it would be scope `provided`?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[KATADA Junya (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464925#comment-16464925
 ] 

KATADA Junya commented on MNG-6401:
---

Sorry, 3.5.3 is also affected.
I updated "Affects Version/s" field.

> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not 
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is 
> [here|https://github.com/jkatada/maven-property-demo]. 
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
> 
>     my_proxy
>     true
>     http
>     ${env.MAVEN_PROXY_HOST_STRING}
>     ${env.MAVEN_PROXY_PORT_INT}
>     local.net|some.host.com
>  
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
> 
>     0
>     proxy.foo.com
>     local.net|some.host.com
>     my_proxy
> 
>  {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`, 
>  but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position: 
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused 
> by: java.lang.NumberFormatException: For input string: 
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before 
> interpolation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1004) Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464926#comment-16464926
 ] 

ASF GitHub Bot commented on SUREFIRE-1004:
--

Tibor17 commented on issue #173: [SUREFIRE-1004] Support full gavtc format for 
dependenciesToScan
URL: https://github.com/apache/maven-surefire/pull/173#issuecomment-386840313
 
 
   @bindul 
   I think we can merge this to master but this PR will have a merge conflict 
soon because I will merge the branch `1383`. The dependency scanner was changed 
a bit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enhance pattern/wildcard capabilities for dependenciesToScan to GAVT
> 
>
> Key: SUREFIRE-1004
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1004
> Project: Maven Surefire
>  Issue Type: Improvement
>  Components: Maven Failsafe Plugin, Maven Surefire Plugin
>Affects Versions: 2.15
>Reporter: Andreas Gudian
>Priority: Major
>
> * Enhance what has been built with SUREFIRE-569 to support patterns as in 
> maven-shade-plugin. Use maven-common-artifact-filters for that.
> * Add/Adapt documentation and examples.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] Tibor17 commented on issue #173: [SUREFIRE-1004] Support full gavtc format for dependenciesToScan

[GitBox]

Tibor17 commented on issue #173: [SUREFIRE-1004] Support full gavtc format for 
dependenciesToScan
URL: https://github.com/apache/maven-surefire/pull/173#issuecomment-386840313
 
 
   @bindul 
   I think we can merge this to master but this PR will have a merge conflict 
soon because I will merge the branch `1383`. The dependency scanner was changed 
a bit.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[KATADA Junya (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

KATADA Junya updated MNG-6401:
--
Affects Version/s: 3.5.3

> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.0, 3.5.3
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not 
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is 
> [here|https://github.com/jkatada/maven-property-demo]. 
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
> 
>     my_proxy
>     true
>     http
>     ${env.MAVEN_PROXY_HOST_STRING}
>     ${env.MAVEN_PROXY_PORT_INT}
>     local.net|some.host.com
>  
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
> 
>     0
>     proxy.foo.com
>     local.net|some.host.com
>     my_proxy
> 
>  {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`, 
>  but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position: 
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused 
> by: java.lang.NumberFormatException: For input string: 
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before 
> interpolation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1422) Forking fails on Linux if /bin/ps isn't available

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464924#comment-16464924
 ] 

ASF GitHub Bot commented on SUREFIRE-1422:
--

Tibor17 commented on issue #178: SUREFIRE-1422
URL: https://github.com/apache/maven-surefire/pull/178#issuecomment-386840236
 
 
   Already pushed from the branch `SUREFIRE-1503`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Forking fails on Linux if /bin/ps isn't available
> -
>
> Key: SUREFIRE-1422
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1422
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: process forking
>Affects Versions: 2.20.1
> Environment: Linux (Debian 9 with OpenJDK 8)
>Reporter: Emmanuel Bourg
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.21.0
>
>
> Hi,
> With the changes introduced by SUREFIRE-1302 I'm now experiencing a failure 
> on Linux when the fork mode is enabled:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on 
> project foo: There are test failures.
> [ERROR]
> [ERROR] Please refer to /foo/target/surefire-reports for the individual test 
> results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] The forked VM terminated without properly saying goodbye. VM crash or 
> System.exit called?
> {code}
> I traced the issue back to the PpidChecker class, the code assumes that 
> {{/bin/ps}} or {{/usr/bin/ps}} exist but this isn't guaranteed (especially on 
> trimmed down containers commonly used for continuous integration).
> It would be nice to have a fallback mechanism when ps isn't available, or at 
> least check its existence and display an explicit message stating that it 
> must be installed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (SUREFIRE-1422) Forking fails on Linux if /bin/ps isn't available

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464923#comment-16464923
 ] 

ASF GitHub Bot commented on SUREFIRE-1422:
--

Tibor17 closed pull request #178: SUREFIRE-1422
URL: https://github.com/apache/maven-surefire/pull/178
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Forking fails on Linux if /bin/ps isn't available
> -
>
> Key: SUREFIRE-1422
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1422
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: process forking
>Affects Versions: 2.20.1
> Environment: Linux (Debian 9 with OpenJDK 8)
>Reporter: Emmanuel Bourg
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 2.21.0
>
>
> Hi,
> With the changes introduced by SUREFIRE-1302 I'm now experiencing a failure 
> on Linux when the fork mode is enabled:
> {code}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on 
> project foo: There are test failures.
> [ERROR]
> [ERROR] Please refer to /foo/target/surefire-reports for the individual test 
> results.
> [ERROR] Please refer to dump files (if any exist) [date]-jvmRun[N].dump, 
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> [ERROR] The forked VM terminated without properly saying goodbye. VM crash or 
> System.exit called?
> {code}
> I traced the issue back to the PpidChecker class, the code assumes that 
> {{/bin/ps}} or {{/usr/bin/ps}} exist but this isn't guaranteed (especially on 
> trimmed down containers commonly used for continuous integration).
> It would be nice to have a fallback mechanism when ps isn't available, or at 
> least check its existence and display an explicit message stating that it 
> must be installed.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] Tibor17 closed pull request #178: SUREFIRE-1422

[GitBox]

Tibor17 closed pull request #178: SUREFIRE-1422
URL: https://github.com/apache/maven-surefire/pull/178
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #178: SUREFIRE-1422

[GitBox]

Tibor17 commented on issue #178: SUREFIRE-1422
URL: https://github.com/apache/maven-surefire/pull/178#issuecomment-386840236
 
 
   Already pushed from the branch `SUREFIRE-1503`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SUREFIRE-1383) dependenciesToScan Does Not Leverage Classpath Elements

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464921#comment-16464921
 ] 

ASF GitHub Bot commented on SUREFIRE-1383:
--

Tibor17 commented on issue #157: SUREFIRE-1383 dependenciesToScan Does Not 
Leverage Classpath Elements
URL: https://github.com/apache/maven-surefire/pull/157#issuecomment-386839993
 
 
   @owenfarrell 
   @paulduffin 
   I have finished the implementation in the branch `1383` but I changed the 
algorithm in `AbstractSurefireMojo`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> dependenciesToScan Does Not Leverage Classpath Elements 
> 
>
> Key: SUREFIRE-1383
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1383
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.20
>Reporter: Owen Farrell
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M1
>
> Attachments: scanned-dependencies-sample.zip
>
>  Time Spent: 48h
>  Remaining Estimate: 24h
>
> The  configuration attribute relies solely on installed 
> artifacts. This is an issue when the targeted dependencies were built as part 
> of the current session. The net result is that stale artifacts are used (i.e. 
> if the dependency has changed since it was last installed) or the tests are 
> not executed at all (if the dependency has not been previously installed.
> Attached is a sample project that illustrates this issue:
> Given I have a multi-module project
>And the first module built includes test classes as part of the project 
> artifact
>And subsequent modules scan the first for unit tests to execute
> When I execute the _*test*_ goal (prior to any install)
> Then the build should succeed
>And tests should be executed with each module



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] Tibor17 commented on issue #157: SUREFIRE-1383 dependenciesToScan Does Not Leverage Classpath Elements

[GitBox]

Tibor17 commented on issue #157: SUREFIRE-1383 dependenciesToScan Does Not 
Leverage Classpath Elements
URL: https://github.com/apache/maven-surefire/pull/157#issuecomment-386839993
 
 
   @owenfarrell 
   @paulduffin 
   I have finished the implementation in the branch `1383` but I changed the 
algorithm in `AbstractSurefireMojo`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (SUREFIRE-1383) dependenciesToScan Does Not Leverage Classpath Elements

[Tibor Digana (JIRA)]

[ 
https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464920#comment-16464920
 ] 

Tibor Digana commented on SUREFIRE-1383:


Created branch 
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/1383
CI running in 
https://builds.apache.org/job/maven-box/job/maven-surefire/job/1383/

> dependenciesToScan Does Not Leverage Classpath Elements 
> 
>
> Key: SUREFIRE-1383
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1383
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.20
>Reporter: Owen Farrell
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M1
>
> Attachments: scanned-dependencies-sample.zip
>
>  Time Spent: 48h
>  Remaining Estimate: 24h
>
> The  configuration attribute relies solely on installed 
> artifacts. This is an issue when the targeted dependencies were built as part 
> of the current session. The net result is that stale artifacts are used (i.e. 
> if the dependency has changed since it was last installed) or the tests are 
> not executed at all (if the dependency has not been previously installed.
> Attached is a sample project that illustrates this issue:
> Given I have a multi-module project
>And the first module built includes test classes as part of the project 
> artifact
>And subsequent modules scan the first for unit tests to execute
> When I execute the _*test*_ goal (prior to any install)
> Then the build should succeed
>And tests should be executed with each module



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (SUREFIRE-1383) dependenciesToScan Does Not Leverage Classpath Elements

[Tibor Digana (JIRA)]

 [ 
https://issues.apache.org/jira/browse/SUREFIRE-1383?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Tibor Digana updated SUREFIRE-1383:
---
Fix Version/s: (was: 2.21.1)
   3.0.0-M1

> dependenciesToScan Does Not Leverage Classpath Elements 
> 
>
> Key: SUREFIRE-1383
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1383
> Project: Maven Surefire
>  Issue Type: Bug
>  Components: Maven Surefire Plugin
>Affects Versions: 2.20
>Reporter: Owen Farrell
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M1
>
> Attachments: scanned-dependencies-sample.zip
>
>  Time Spent: 48h
>  Remaining Estimate: 24h
>
> The  configuration attribute relies solely on installed 
> artifacts. This is an issue when the targeted dependencies were built as part 
> of the current session. The net result is that stale artifacts are used (i.e. 
> if the dependency has changed since it was last installed) or the tests are 
> not executed at all (if the dependency has not been previously installed.
> Attached is a sample project that illustrates this issue:
> Given I have a multi-module project
>And the first module built includes test classes as part of the project 
> artifact
>And subsequent modules scan the first for unit tests to execute
> When I execute the _*test*_ goal (prior to any install)
> Then the build should succeed
>And tests should be executed with each module



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (MNG-6403) Artifact#VERSION_FILE_PATTERN does not escape period between date and time

[Michael Osipov (JIRA)]

Michael Osipov created MNG-6403:
---

 Summary: Artifact#VERSION_FILE_PATTERN does not escape period 
between date and time
 Key: MNG-6403
 URL: https://issues.apache.org/jira/browse/MNG-6403
 Project: Maven
  Issue Type: Bug
  Components: Artifacts and Repositories
Affects Versions: 3.5.3
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 3.5.4-candidate


The pattern  {{^(.*)-([0-9]{8}.[0-9]{6})-([0-9]+)$}} accepts everything between 
date and time. This is wrong. It shall be a period only.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] clambertus closed pull request #126: Update code style quikstart-arhetype

[GitBox]

clambertus closed pull request #126: Update code style quikstart-arhetype
URL: https://github.com/apache/maven/pull/126
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-embedder/src/test/embedder-test-project/src/main/java/org/apache/maven/App.java
 
b/maven-embedder/src/test/embedder-test-project/src/main/java/org/apache/maven/App.java
index 3902bac58e..7ea7473584 100644
--- 
a/maven-embedder/src/test/embedder-test-project/src/main/java/org/apache/maven/App.java
+++ 
b/maven-embedder/src/test/embedder-test-project/src/main/java/org/apache/maven/App.java
@@ -4,10 +4,8 @@
  * Hello world!
  *
  */
-public class App
-{
-public static void main( String[] args )
-{
-System.out.println( "Hello World!" );
+public class App {
+public static void main(String[] args) {
+System.out.println("Hello, World!");
 }
 }


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-6296) New option -Dstyle.color is not working

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464913#comment-16464913
 ] 

ASF GitHub Bot commented on MNG-6296:
-

clambertus closed pull request #135: [MNG-6296] Parse properties before 
configuring the logging settings
URL: https://github.com/apache/maven/pull/135
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java 
b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
index 3474fabbd5..977f174934 100644
--- a/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
+++ b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
@@ -277,9 +277,9 @@ public int doMain( CliRequest cliRequest )
 {
 initialize( cliRequest );
 cli( cliRequest );
+properties( cliRequest );
 logging( cliRequest );
 version( cliRequest );
-properties( cliRequest );
 localContainer = container( cliRequest );
 commands( cliRequest );
 configure( cliRequest );


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> New option -Dstyle.color is not working
> ---
>
> Key: MNG-6296
> URL: https://issues.apache.org/jira/browse/MNG-6296
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.5.2
>Reporter: Robin Müller
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.5.3
>
>
> The new option {{-Dstyle.color=(auto|always|never)}} is not working. This 
> happens as the corresponding code accesses the {{UserProperties}} of the 
> {{CliRequest}} before they are set. I'll provide a quick fix for this by 
> changing the order of the methods in the {{doMain}} method so the properties 
> will be set at the right time.
> But I'd suggest to refactor the whole stuff so the code will become easier to 
> understand and maintain. IMHO the functionality of the {{properties}} method 
> in the {{MavenCli}} should be moved to the constructor of the {{CliRequest}}. 
> The {{CliRequest}} itself should be immutable so all fields will have the 
> correct content all the time.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] clambertus closed pull request #118: Upgrade SLF4J to 1.7.25

[GitBox]

clambertus closed pull request #118: Upgrade SLF4J to 1.7.25
URL: https://github.com/apache/maven/pull/118
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/maven-slf4j-provider/pom.xml b/maven-slf4j-provider/pom.xml
index 315b9a7386..5aa5592008 100644
--- a/maven-slf4j-provider/pom.xml
+++ b/maven-slf4j-provider/pom.xml
@@ -32,8 +32,7 @@ under the License.
 
   Maven SLF4J Simple Provider
   
-Maven SLF4J provider based on SLF4J's simple provider, monkey-patched to 
support Maven styled colors
-for levels and stacktraces rendering.
+Maven SLF4J provider based on SLF4J's simple provider.
   
 
   
@@ -41,6 +40,11 @@ under the License.
   org.slf4j
   slf4j-api
 
+
+  org.slf4j
+  slf4j-simple
+  ${slf4jVersion}
+
 
   org.apache.maven.shared
   maven-shared-utils
@@ -49,68 +53,36 @@ under the License.
 
   
 
+  
   
 org.apache.maven.plugins
-maven-dependency-plugin
-
-  
-
-  org.slf4j
-  slf4j-simple
-  ${slf4jVersion}
-  jar
-  sources
-  false
-  
${project.build.directory}/generated-sources/slf4j-simple
-  org/slf4j/impl/*.java
-
-  
-
-
-  
-unzip-slf4j-simple
-
-  unpack
-
-  
-
-  
-  
-org.codehaus.mojo
-build-helper-maven-plugin
-1.12
+maven-shade-plugin
+3.0.0
 
   
-add-slf4j-simple
-generate-sources
+package
 
-  add-source
+  shade
 
 
-  
-
${project.build.directory}/generated-sources/slf4j-simple
-  
-
-  
-
-  
-  
-org.codehaus.gmaven
-groovy-maven-plugin
-2.0
-
-  
-patch-slf4j-simple
-process-sources
-
-  execute
-
-
-  
${project.basedir}/src/main/script/patch-slf4j-simple.groovy
+  
+
+  org.slf4j:slf4j-simple
+
+  
+  
+
+  org.slf4j:slf4j-simple
+  
+org/slf4j/impl/StaticLoggerBinder*
+  
+
+  
 
   
 
   
 
   
-
\ No newline at end of file
+
+
diff --git 
a/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java 
b/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java
index 17f1f484c3..af05ba9077 100644
--- a/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java
+++ b/maven-slf4j-provider/src/main/java/org/slf4j/impl/MavenSimpleLogger.java
@@ -56,8 +56,13 @@ protected String renderLevel( int level )
 }
 
 @Override
-protected void renderThrowable( Throwable t, PrintStream stream )
+protected void writeThrowable( Throwable t, PrintStream stream )
 {
+if ( t == null )
+{
+return;
+}
+
 stream.print( buffer().failure( t.getClass().getName() ) );
 if ( t.getMessage() != null )
 {
diff --git 
a/maven-slf4j-provider/src/main/java/org/slf4j/impl/StaticLoggerBinder.java 
b/maven-slf4j-provider/src/main/java/org/slf4j/impl/StaticLoggerBinder.java
new file mode 100644
index 00..e613a470ff
--- /dev/null
+++ b/maven-slf4j-provider/src/main/java/org/slf4j/impl/StaticLoggerBinder.java
@@ -0,0 +1,87 @@
+package org.slf4j.impl;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.slf4j.ILoggerFactory;
+import org.slf4j.spi.LoggerFactoryBinder;
+
+/**
+ * SLF4J LoggerFactoryBinder implementation using MavenSimpleLogger.
+ * This class is part of 

[GitHub] clambertus closed pull request #135: [MNG-6296] Parse properties before configuring the logging settings

[GitBox]

clambertus closed pull request #135: [MNG-6296] Parse properties before 
configuring the logging settings
URL: https://github.com/apache/maven/pull/135
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java 
b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
index 3474fabbd5..977f174934 100644
--- a/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
+++ b/maven-embedder/src/main/java/org/apache/maven/cli/MavenCli.java
@@ -277,9 +277,9 @@ public int doMain( CliRequest cliRequest )
 {
 initialize( cliRequest );
 cli( cliRequest );
+properties( cliRequest );
 logging( cliRequest );
 version( cliRequest );
-properties( cliRequest );
 localContainer = container( cliRequest );
 commands( cliRequest );
 configure( cliRequest );


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-5756) Java home output in mvn -v is misleading

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464912#comment-16464912
 ] 

Michael Osipov commented on MNG-5756:
-

So I pushed a test branch for this. The solution is a reduced version of both 
PRs because I see no reason to print out {{JAVA_HOME}} any more. From Java 9 it 
will correspond to {{java.home}}. The output does not say "Java home" anymore, 
but solely references "JRE used". In fact, you don't even need to set 
{{JAVA_HOME}} because your default installation in {{/usr/bin/}} or 
{{/usr/local/bin}} shall be enough.

> Java home output in mvn -v is misleading
> 
>
> Key: MNG-5756
> URL: https://issues.apache.org/jira/browse/MNG-5756
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.2.5, 3.3.3
> Environment: any
>Reporter: Jarkko Rantavuori
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> For example on my windows box, mvn -v prints the following:
> {code}
> Java home: C:\Program Files (x86)\Java\jdk1.7.0_51\jre
> {code}
> But my JAVA_HOME is actually
> {code}
> > echo %JAVA_HOME%
> C:\Program Files (x86)\Java\jdk1.7.0_51
> {code}
> In the source code, the line comes from:
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blob;f=maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java#l63
> {code}
> version.append( "Java home: " ).append( System.getProperty( "java.home", 
> "" ) ).append( ls );
> {code}
> which is using property "java.home" to fetch java home. However, "java.home" 
> property is not JAVA_HOME! This is explained in detail in here: 
> http://javahowto.blogspot.fi/2006/05/javahome-vs-javahome.html
> To quote:
> {quote}
> What's the difference between JAVA_HOME and java.home?
> JAVA_HOME is the JDK install directory, e.g., C:\jdk5. It's meant to be 
> set as an environment variable and referenced in Windows batch files or Unix 
> scripts. I always have it in my Windows Control Panel and .tcsh files,along 
> with other common environment variables. Some Java applications use the name 
> jdk.home for this purpose, which I think is a better name. But JAVA_HOME has 
> been used since the beginning and is now a convention.
> java.home is the JRE install directory, e.g., C:\jdk5\jre, or C:\Program 
> Files\Java\jre1.5.0_06. Unlike JAVA_HOME, I never seen java.home as an 
> environment variable. java.home is a build-in Java system property, whose 
> value is the JRE install directory. Since all Java system properties are also 
> exposed as Ant build properties, you can also use $java.home in 
> build files.
> Would jre.home be a better name? Maybe, but I don't think Sun will change 
> it.
> {quote}
> This is a source of constant confusion. Some stackoverflow threads to 
> illustrate:
> http://stackoverflow.com/questions/15279586/java-home-in-maven
> http://stackoverflow.com/questions/17620531/maven-pointing-to-jre-instead-of-jdk
> The correct way to print JAVA_HOME would be to use 
> System.getenv("JAVA_HOME"). Either that should be used or current output 
> should be changed so it wouldn't be so misleading.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MNG-5756) Java home output in mvn -v is misleading

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-5756:

Fix Version/s: 3.5.4-candidate

> Java home output in mvn -v is misleading
> 
>
> Key: MNG-5756
> URL: https://issues.apache.org/jira/browse/MNG-5756
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.2.5, 3.3.3
> Environment: any
>Reporter: Jarkko Rantavuori
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> For example on my windows box, mvn -v prints the following:
> {code}
> Java home: C:\Program Files (x86)\Java\jdk1.7.0_51\jre
> {code}
> But my JAVA_HOME is actually
> {code}
> > echo %JAVA_HOME%
> C:\Program Files (x86)\Java\jdk1.7.0_51
> {code}
> In the source code, the line comes from:
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blob;f=maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java#l63
> {code}
> version.append( "Java home: " ).append( System.getProperty( "java.home", 
> "" ) ).append( ls );
> {code}
> which is using property "java.home" to fetch java home. However, "java.home" 
> property is not JAVA_HOME! This is explained in detail in here: 
> http://javahowto.blogspot.fi/2006/05/javahome-vs-javahome.html
> To quote:
> {quote}
> What's the difference between JAVA_HOME and java.home?
> JAVA_HOME is the JDK install directory, e.g., C:\jdk5. It's meant to be 
> set as an environment variable and referenced in Windows batch files or Unix 
> scripts. I always have it in my Windows Control Panel and .tcsh files,along 
> with other common environment variables. Some Java applications use the name 
> jdk.home for this purpose, which I think is a better name. But JAVA_HOME has 
> been used since the beginning and is now a convention.
> java.home is the JRE install directory, e.g., C:\jdk5\jre, or C:\Program 
> Files\Java\jre1.5.0_06. Unlike JAVA_HOME, I never seen java.home as an 
> environment variable. java.home is a build-in Java system property, whose 
> value is the JRE install directory. Since all Java system properties are also 
> exposed as Ant build properties, you can also use $java.home in 
> build files.
> Would jre.home be a better name? Maybe, but I don't think Sun will change 
> it.
> {quote}
> This is a source of constant confusion. Some stackoverflow threads to 
> illustrate:
> http://stackoverflow.com/questions/15279586/java-home-in-maven
> http://stackoverflow.com/questions/17620531/maven-pointing-to-jre-instead-of-jdk
> The correct way to print JAVA_HOME would be to use 
> System.getenv("JAVA_HOME"). Either that should be used or current output 
> should be changed so it wouldn't be so misleading.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (MNG-5756) Java home output in mvn -v is misleading

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-5756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MNG-5756:
---

Assignee: Michael Osipov

> Java home output in mvn -v is misleading
> 
>
> Key: MNG-5756
> URL: https://issues.apache.org/jira/browse/MNG-5756
> Project: Maven
>  Issue Type: Improvement
>  Components: Command Line
>Affects Versions: 3.2.5, 3.3.3
> Environment: any
>Reporter: Jarkko Rantavuori
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> For example on my windows box, mvn -v prints the following:
> {code}
> Java home: C:\Program Files (x86)\Java\jdk1.7.0_51\jre
> {code}
> But my JAVA_HOME is actually
> {code}
> > echo %JAVA_HOME%
> C:\Program Files (x86)\Java\jdk1.7.0_51
> {code}
> In the source code, the line comes from:
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=blob;f=maven-embedder/src/main/java/org/apache/maven/cli/CLIReportingUtils.java#l63
> {code}
> version.append( "Java home: " ).append( System.getProperty( "java.home", 
> "" ) ).append( ls );
> {code}
> which is using property "java.home" to fetch java home. However, "java.home" 
> property is not JAVA_HOME! This is explained in detail in here: 
> http://javahowto.blogspot.fi/2006/05/javahome-vs-javahome.html
> To quote:
> {quote}
> What's the difference between JAVA_HOME and java.home?
> JAVA_HOME is the JDK install directory, e.g., C:\jdk5. It's meant to be 
> set as an environment variable and referenced in Windows batch files or Unix 
> scripts. I always have it in my Windows Control Panel and .tcsh files,along 
> with other common environment variables. Some Java applications use the name 
> jdk.home for this purpose, which I think is a better name. But JAVA_HOME has 
> been used since the beginning and is now a convention.
> java.home is the JRE install directory, e.g., C:\jdk5\jre, or C:\Program 
> Files\Java\jre1.5.0_06. Unlike JAVA_HOME, I never seen java.home as an 
> environment variable. java.home is a build-in Java system property, whose 
> value is the JRE install directory. Since all Java system properties are also 
> exposed as Ant build properties, you can also use $java.home in 
> build files.
> Would jre.home be a better name? Maybe, but I don't think Sun will change 
> it.
> {quote}
> This is a source of constant confusion. Some stackoverflow threads to 
> illustrate:
> http://stackoverflow.com/questions/15279586/java-home-in-maven
> http://stackoverflow.com/questions/17620531/maven-pointing-to-jre-instead-of-jdk
> The correct way to print JAVA_HOME would be to use 
> System.getenv("JAVA_HOME"). Either that should be used or current output 
> should be changed so it wouldn't be so misleading.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on a change in pull request #160: Fix links to Apache/CDDL/MIT licenses

[GitBox]

michael-o commented on a change in pull request #160: Fix links to 
Apache/CDDL/MIT licenses
URL: https://github.com/apache/maven/pull/160#discussion_r186272200
 
 

 ##
 File path: apache-maven/src/main/appended-resources/META-INF/LICENSE.vm
 ##
 @@ -21,19 +21,23 @@ Apache Maven includes a number of components and libraries 
with separate
 copyright notices and license terms. Your use of those components are 
 subject to the terms and conditions of the following licenses. 
 
-#set ( $apacheTxt = "The Apache Software License, Version 2.0" )
-
+#set ( $apacheLicTexts = [ "Apache License, Version 2.0", "The Apache Software 
License, Version 2.0",
+"ASLv2", "Apache Public License 2.0" ] )
 #foreach ( $project in $projects )
 #foreach ( $license in $project.licenses)
-#if ( ! ($apacheTxt == $license.name) ) 
+#if ( !($apacheLicTexts.contains( $license.name)) )
 #set ( $artId = $project.artifact.artifactId)
 #set ( $lf = $locator )
 #set ( $url = $license.url )
 ## glass fish URL is now invalid, use a fixed one
 #if ($url == "https://glassfish.dev.java.net/public/CDDLv1.0.html;)
-#set ( $url = 'https://glassfish.java.net/public/CDDLv1.0.html' )
+#set ( $url = 'https://spdx.org/licenses/CDDL-1.0.txt' )
+#end
+## jcr-over-slf4j - redirect
 
 Review comment:
   I think it is JCL and nor JCR.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464898#comment-16464898
 ] 

ASF GitHub Bot commented on MNG-6360:
-

rmannibucau closed pull request #157: [MNG-6360] adding org.slf4j.event in 
exported packages
URL: https://github.com/apache/maven/pull/157
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/maven-core/src/main/resources/META-INF/maven/extension.xml 
b/maven-core/src/main/resources/META-INF/maven/extension.xml
index 6329aaa096..6bd8369273 100644
--- a/maven-core/src/main/resources/META-INF/maven/extension.xml
+++ b/maven-core/src/main/resources/META-INF/maven/extension.xml
@@ -120,6 +120,7 @@ under the License.
 org.slf4j.*
 org.slf4j.spi.*
 org.slf4j.helpers.*
+org.slf4j.event.*
 
 
 org.fusesource.jansi.*


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464897#comment-16464897
 ] 

ASF GitHub Bot commented on MNG-6360:
-

rmannibucau commented on issue #157: [MNG-6360] adding org.slf4j.event in 
exported packages
URL: https://github.com/apache/maven/pull/157#issuecomment-386835055
 
 
   No more blocking


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] rmannibucau commented on issue #157: [MNG-6360] adding org.slf4j.event in exported packages

[GitBox]

rmannibucau commented on issue #157: [MNG-6360] adding org.slf4j.event in 
exported packages
URL: https://github.com/apache/maven/pull/157#issuecomment-386835055
 
 
   No more blocking


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] rmannibucau closed pull request #157: [MNG-6360] adding org.slf4j.event in exported packages

[GitBox]

rmannibucau closed pull request #157: [MNG-6360] adding org.slf4j.event in 
exported packages
URL: https://github.com/apache/maven/pull/157
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/maven-core/src/main/resources/META-INF/maven/extension.xml 
b/maven-core/src/main/resources/META-INF/maven/extension.xml
index 6329aaa096..6bd8369273 100644
--- a/maven-core/src/main/resources/META-INF/maven/extension.xml
+++ b/maven-core/src/main/resources/META-INF/maven/extension.xml
@@ -120,6 +120,7 @@ under the License.
 org.slf4j.*
 org.slf4j.spi.*
 org.slf4j.helpers.*
+org.slf4j.event.*
 
 
 org.fusesource.jansi.*


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] asfgit closed pull request #132: Fix the Javadoc to use a proper @link tag when pointing to ProjectBuilder

[GitBox]

asfgit closed pull request #132: Fix the Javadoc to use a proper @link tag when 
pointing to ProjectBuilder
URL: https://github.com/apache/maven/pull/132
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-core/src/main/java/org/apache/maven/project/MavenProject.java 
b/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
index 80a51935ea..420a2c1e5f 100644
--- a/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
+++ b/maven-core/src/main/java/org/apache/maven/project/MavenProject.java
@@ -81,7 +81,7 @@
  * 
  * 
  * With changes during 3.2.2 release MavenProject is closer to being immutable 
after construction with the removal of
- * all components from this class, and the upfront construction taken care of 
entirely by the @{ProjectBuilder}. There
+ * all components from this class, and the upfront construction taken care of 
entirely by the {@link ProjectBuilder}. There
  * is still the issue of having to run the lifecycle in order to find all the 
compile source roots and resource
  * directories but I hope to take care of this during the Maven 4.0 release 
(jvz).
  * 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-6360) Maven doesn't export org.slf4j.event.Level

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464892#comment-16464892
 ] 

ASF GitHub Bot commented on MNG-6360:
-

michael-o commented on issue #157: [MNG-6360] adding org.slf4j.event in 
exported packages
URL: https://github.com/apache/maven/pull/157#issuecomment-386833261
 
 
   @rmannibucau As discussed on JIRA, this can be closed. Do you agree?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6360
> URL: https://issues.apache.org/jira/browse/MNG-6360
> Project: Maven
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Blocker
>
> Hi
> maven doesn't export org.slf4j.event package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so this package 
> from slf4j is not usable in mojos/extensions which lead to a weird 
> classloading for slf4j users.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] michael-o commented on issue #140: Add org.slf4j.event to exported packages

[GitBox]

michael-o commented on issue #140: Add org.slf4j.event to exported packages
URL: https://github.com/apache/maven/pull/140#issuecomment-386833306
 
 
   @dconneely Please see MNG-6360. This seems to be overcome already. Can you 
confirm?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michael-o commented on issue #157: [MNG-6360] adding org.slf4j.event in exported packages

[GitBox]

michael-o commented on issue #157: [MNG-6360] adding org.slf4j.event in 
exported packages
URL: https://github.com/apache/maven/pull/157#issuecomment-386833261
 
 
   @rmannibucau As discussed on JIRA, this can be closed. Do you agree?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] michael-o commented on issue #126: Update code style quikstart-arhetype

[GitBox]

michael-o commented on issue #126: Update code style quikstart-arhetype
URL: https://github.com/apache/maven/pull/126#issuecomment-386833015
 
 
   Please close.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

sormuras commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386828650
 
 
   JDK 10 seems okay now. JDK 7 still chokes on "--target 1.8" options...
   
   https://builds.apache.org/job/maven-box/job/maven-surefire/job/1330/8/


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

sormuras commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386828650
 
 
   JDK 10 seems okay now. JDK 7 still chokes on "--target 1.8" options...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

sormuras commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386827017
 
 
   Why are they banned?
   
   [linux-jdk10-maven3.5.x] Found Banned Dependency: 
org.apache.commons:commons-lang3:jar:3.7
   [linux-jdk10-maven3.5.x] Found Banned Dependency: 
commons-io:commons-io:jar:2.6
   
   Reverting to old versions...


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

sormuras commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386825239
 
 
   > ... You have to squash all commits ...
   
   Losing history and reasoning is okay?
   
   Done. 
   
   
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=fb1188b6b45e7a2d71e9d9807c67775a9595031d


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

sormuras commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386825239
 
 
   > ... You have to squash all commits ...
   
   Losing history and reasoning is okay?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386822137
 
 
   I will have a look to the sniffer plugin in the evening and I will try to 
run the build.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on a change in pull request #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186267506
 
 

 ##
 File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
 ##
 @@ -1022,9 +1029,9 @@ private void createDependencyResolver()
 Artifact junitDepArtifact = getJunitDepArtifact();
 return new ProviderList( new DynamicProviderInfo( null ),
   new TestNgProviderInfo( getTestNgArtifact() ),
+  new JUnitPlatformProviderInfo( 
getJunitPlatformArtifact() ),
 
 Review comment:
   AFAIK the found providers are run separately in a loop, see 
`AbstractSurefireMojo.java` in method `execute`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386821219
 
 
   @sormuras 
   Did you override the branch `1330`? Because I squashed last cca 5 commits to 
one.
   You have to squash all commits b83121..0633293 in one commit with this 
command
   `git rebase -i HEAD~11` amend the resulting commit message to
   `[SUREFIRE-1330] JUnit 5 surefire-provider code donation`
   and then force push itself branch
   `git push origin +1330:1330`


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (MNG-6386) ${project.baseUri} is not a valid URI (according to RFC 3986)

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MNG-6386:

Fix Version/s: (was: 3.6.0-candidate)
   3.5.4-candidate

> ${project.baseUri} is not a valid URI (according to RFC 3986)
> -
>
> Key: MNG-6386
> URL: https://issues.apache.org/jira/browse/MNG-6386
> Project: Maven
>  Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.5.4-candidate
>
>
> {{File#toURI}} produces an invalid URI on Windows:
> {noformat}
> file:/C:/path/to/basedir{noformat}
> A valid URI has to be:
> {noformat}
> file:///C:/path/to/basedir{noformat}
> Same issue for Unix-like OSes:
> {noformat}
> file:/path/to/basedir{noformat}
> A valid URI has to be:
> {noformat}
> file:///path/to/basedir{noformat}
> Using {{Path#toUri}} we can easily solve that problem because it creates 
> compliant URIs. The failure occurs when interacting with local Git and 
> Subversion repos:
> {noformat}
> PS D:\Entwicklung\Projekte\maven-scm> svn ls 
> file:/D:/Entwicklung/svn-repos/scm-svn-test-at-sign
> svn: E020024: Error resolving case of 
> 'file:\D:\Entwicklung\svn-repos\scm-svn-test-at-sign'
> while the proper (new) havior will produce a valid URI:
> PS D:\Entwicklung\Projekte\maven-scm> svn ls 
> file:///D:/Entwicklung/svn-repos/scm-svn-test-at-sign
> branches/
> tags/
> trunk/ 
> {noformat}
> {noformat}
> PS D:\Entwicklung\Projekte> git clone file:///D:/Entwicklung/git-repos/toll 
> tlll2
> Cloning into 'tlll2'...
> warning: You appear to have cloned an empty repository.
> PS D:\Entwicklung\Projekte> git clone file:/D:/Entwicklung/git-repos/toll 
> tlll2
> Cloning into 'tlll2'...
> ssh: Could not resolve hostname file: Name or service not known
> fatal: Could not read from remote repository.
> {noformat}
> or Subversion repo at: {{D:\Entwicklung\svn-repos\это по-русский}}:
> {noformat}
> PS D:\Entwicklung\Projekte> svn ls 
> file:/D:/Entwicklung/svn-repos/это%20по-русский/
> svn: E020024: Error resolving case of 
> 'file:\D:\Entwicklung\svn-repos\???%20??-???\'
> {noformat}
> proper URI gives:
> {noformat}
> PS D:\Entwicklung\Projekte> svn ls 
> file:///D:/Entwicklung/svn-repos/%D1%8D%D1%82%D0%BE%20%D0%BF%D0%BE-%D1%80%D1%83%D1%81%D1%81%D0%BA%D0%B8%D0%B9/
> branches/
> tags/
> trunk/
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

sormuras commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386799705
 
 
   I think, we may get rid of integration test class `JUnit5IT` as it refers to 
the soon deprecated `org.junit.platform:junit-platform-surefire-provider`. Or 
should we keep it for the sake of completeness?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

sormuras commented on a change in pull request #184: Donate current sources 
from junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186260157
 
 

 ##
 File path: 
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
 ##
 @@ -58,6 +58,11 @@
 import org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder;
 import org.junit.platform.launcher.core.LauncherFactory;
 
+/**
+ * JUnitPlatformProvider.
+ *
+ * @since 1.0
 
 Review comment:
   Fixing all JUnit-related versions to `2.22.0`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

sormuras commented on a change in pull request #184: Donate current sources 
from junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186260157
 
 

 ##
 File path: 
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
 ##
 @@ -58,6 +58,11 @@
 import org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder;
 import org.junit.platform.launcher.core.LauncherFactory;
 
+/**
+ * JUnitPlatformProvider.
+ *
+ * @since 1.0
 
 Review comment:
   Fixing all JUnit-related version to `2.22.0`.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

sormuras commented on a change in pull request #184: Donate current sources 
from junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186260085
 
 

 ##
 File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
 ##
 @@ -1022,9 +1029,9 @@ private void createDependencyResolver()
 Artifact junitDepArtifact = getJunitDepArtifact();
 return new ProviderList( new DynamicProviderInfo( null ),
   new TestNgProviderInfo( getTestNgArtifact() ),
+  new JUnitPlatformProviderInfo( 
getJunitPlatformArtifact() ),
 
 Review comment:
   Are the built-in providers documented somewhere? I couldn't find any 
external information.
   
   The first auto-detected provider wins, right?
   
   If I understand the `isApplicable()` logic correctly, the `platform` info 
needs to checked before the legacy JUnit (3 + 4) infos. This is due to fact, 
that a legacy "junit-4.12.jar" is present in both cases: the users is on 4 and 
wants to run JUnit 4 test cases. Or the user is on "5" and wants to Vintage 
Engine to execute JUnit 4 or 3 test cases.
   
   So, when we find `org.junit.platform:junit-platform-engine` as a dependency 
the uses wants to launch the JUnit Platform -- perhaps with the Vintage Engine 
which brings along JUnit 4.x jar.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-6401) Cannot interpolate property in proxy port of settings.xml

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6401?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464741#comment-16464741
 ] 

Michael Osipov commented on MNG-6401:
-

Only 3.0 is affected? What about 3.5.3?

> Cannot interpolate property in proxy port of settings.xml
> -
>
> Key: MNG-6401
> URL: https://issues.apache.org/jira/browse/MNG-6401
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.0
>Reporter: KATADA Junya
>Priority: Minor
>
> If you use a property in proxy port of settings.xml, the property is not 
> replaced and the port number is "0" instead of property value.
> My minimal demo about this problem is 
> [here|https://github.com/jkatada/maven-property-demo]. 
> In my demo, export two environment variables as follows.
> {code}
> export MAVEN_PROXY_HOST_STRING=proxy.foo.com
> export MAVEN_PROXY_PORT_INT=18080
> {code}
> These variables are used in settings.xml for proxy settings.
> {code:xml}
> 
>     my_proxy
>     true
>     http
>     ${env.MAVEN_PROXY_HOST_STRING}
>     ${env.MAVEN_PROXY_PORT_INT}
>     local.net|some.host.com
>  
> {code}
> Execute maven-help-plugin to show effective settings.xml.
> {code}
> mvn help:effective-settings -X
> {code}
> The result is as follows.
> {code:xml}
> 
>     0
>     proxy.foo.com
>     local.net|some.host.com
>     my_proxy
> 
>  {code}
> `*${env.MAVEN_PROXY_HOST_STRING}*` is replaced with `*proxy.foo.com*`, 
>  but `*${env.MAVEN_PROXY_PORT_INT}*` is not replaced with `*18080*`.
> I found the following WARNING message in console.
> {code:java}
> [WARNING] Some problems were encountered while building the effective settings
> [WARNING] Unable to parse element 'port', must be an integer (position: 
> END_TAG seen ...${env.MAVEN_PROXY_PORT_INT}... @12:47) caused 
> by: java.lang.NumberFormatException: For input string: 
> "${env.MAVEN_PROXY_PORT_INT}" @ /root/.m2/settings.xml, line 12, column 47
> {code}
> I think that the cause of this problem is to parse settings.xml before 
> interpolation.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on a change in pull request #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186258276
 
 

 ##
 File path: 
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
 ##
 @@ -58,6 +58,11 @@
 import org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder;
 import org.junit.platform.launcher.core.LauncherFactory;
 
+/**
+ * JUnitPlatformProvider.
+ *
+ * @since 1.0
 
 Review comment:
   Pls put here another version. We can make release of the provider in e.g. 
2.22.0.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on a change in pull request #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186258477
 
 

 ##
 File path: 
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
 ##
 @@ -1022,9 +1029,9 @@ private void createDependencyResolver()
 Artifact junitDepArtifact = getJunitDepArtifact();
 return new ProviderList( new DynamicProviderInfo( null ),
   new TestNgProviderInfo( getTestNgArtifact() ),
+  new JUnitPlatformProviderInfo( 
getJunitPlatformArtifact() ),
 
 Review comment:
   Here the order of provider-info was changed. Does it mean something 
important for functionality?


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

Tibor17 commented on a change in pull request #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r186258276
 
 

 ##
 File path: 
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/JUnitPlatformProvider.java
 ##
 @@ -58,6 +58,11 @@
 import org.junit.platform.launcher.core.LauncherDiscoveryRequestBuilder;
 import org.junit.platform.launcher.core.LauncherFactory;
 
+/**
+ * JUnitPlatformProvider.
+ *
+ * @since 1.0
 
 Review comment:
   Pls put here another version. We can make release the provider in e.g. 
2.22.0.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] sormuras commented on issue #184: Donate current sources from junit-platform-surefire-provider

[GitBox]

sormuras commented on issue #184: Donate current sources from 
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-386793374
 
 
   Make it three commits.  


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MPLUGIN-335) Support JDK 10 for plugin generation

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPLUGIN-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464715#comment-16464715
 ] 

Hudson commented on MPLUGIN-335:


Build failed in Jenkins: Maven TLP » maven-plugin-tools » master #23

See 
https://builds.apache.org/job/maven-box/job/maven-plugin-tools/job/master/23/

> Support JDK 10 for plugin generation
> 
>
> Key: MPLUGIN-335
> URL: https://issues.apache.org/jira/browse/MPLUGIN-335
> Project: Maven Plugin Tools
>  Issue Type: Dependency upgrade
>  Components: Plugin Plugin
>Affects Versions: 3.5.1
>Reporter: Peter Major
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Major
> Fix For: 3.6
>
>
> The Maven Plugin Plugin currently does not support JDK 10, because the ASM 
> dependency is currently on 6.0_ALPHA, which does not support class version 
> 54.0. By upgrading ASM to the latest version, the plugin would be able to 
> process class files compiled with JDK10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MPLUGIN-335) Support JDK 10 for plugin generation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPLUGIN-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464712#comment-16464712
 ] 

ASF GitHub Bot commented on MPLUGIN-335:


olamy closed pull request #13: [MPLUGIN-335] - Fix build and tests
URL: https://github.com/apache/maven-plugin-tools/pull/13
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java
 
b/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java
index f5450977..66c846c5 100644
--- 
a/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java
+++ 
b/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java
@@ -224,6 +224,19 @@ private void analyzeClassStream( Map mojoAnnotatedCl
   getLogger().isDebugEnabled() ? aiooe : null );
 return;
 }
+catch ( IllegalArgumentException iae )
+{
+if ( iae.getMessage() == null )
+{
+getLogger().warn( "Error analyzing class " + file + " in " + 
source + ": ignoring class",
+getLogger().isDebugEnabled() ? iae : null );
+return;
+}
+else
+{
+throw iae;
+}
+}
 
 analyzeVisitors( mojoClassVisitor );
 
diff --git a/pom.xml b/pom.xml
index 29d043b8..145276b2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -96,6 +96,7 @@
 1.7.1
 3.0.1
 
plugin-tools-archives/plugin-tools-LATEST
+5.0.2
   
 
   
@@ -217,10 +218,12 @@
   
 org.ow2.asm
 asm
+${asmVersion}
   
   
 org.ow2.asm
 asm-commons
+${asmVersion}
   
 
   
@@ -426,20 +429,9 @@
   
 
   
-  
-
-  
-org.ow2.asm
-asm
-6.1.1
-  
-  
-org.ow2.asm
-asm-commons
-6.1.1
-  
-
-  
+  
+6.1.1
+  
 
   
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support JDK 10 for plugin generation
> 
>
> Key: MPLUGIN-335
> URL: https://issues.apache.org/jira/browse/MPLUGIN-335
> Project: Maven Plugin Tools
>  Issue Type: Dependency upgrade
>  Components: Plugin Plugin
>Affects Versions: 3.5.1
>Reporter: Peter Major
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Major
> Fix For: 3.6
>
>
> The Maven Plugin Plugin currently does not support JDK 10, because the ASM 
> dependency is currently on 6.0_ALPHA, which does not support class version 
> 54.0. By upgrading ASM to the latest version, the plugin would be able to 
> process class files compiled with JDK10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] olamy closed pull request #13: [MPLUGIN-335] - Fix build and tests

[GitBox]

olamy closed pull request #13: [MPLUGIN-335] - Fix build and tests
URL: https://github.com/apache/maven-plugin-tools/pull/13
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git 
a/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java
 
b/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java
index f5450977..66c846c5 100644
--- 
a/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java
+++ 
b/maven-plugin-tools-annotations/src/main/java/org/apache/maven/tools/plugin/extractor/annotations/scanner/DefaultMojoAnnotationsScanner.java
@@ -224,6 +224,19 @@ private void analyzeClassStream( Map mojoAnnotatedCl
   getLogger().isDebugEnabled() ? aiooe : null );
 return;
 }
+catch ( IllegalArgumentException iae )
+{
+if ( iae.getMessage() == null )
+{
+getLogger().warn( "Error analyzing class " + file + " in " + 
source + ": ignoring class",
+getLogger().isDebugEnabled() ? iae : null );
+return;
+}
+else
+{
+throw iae;
+}
+}
 
 analyzeVisitors( mojoClassVisitor );
 
diff --git a/pom.xml b/pom.xml
index 29d043b8..145276b2 100644
--- a/pom.xml
+++ b/pom.xml
@@ -96,6 +96,7 @@
 1.7.1
 3.0.1
 
plugin-tools-archives/plugin-tools-LATEST
+5.0.2
   
 
   
@@ -217,10 +218,12 @@
   
 org.ow2.asm
 asm
+${asmVersion}
   
   
 org.ow2.asm
 asm-commons
+${asmVersion}
   
 
   
@@ -426,20 +429,9 @@
   
 
   
-  
-
-  
-org.ow2.asm
-asm
-6.1.1
-  
-  
-org.ow2.asm
-asm-commons
-6.1.1
-  
-
-  
+  
+6.1.1
+  
 
   
 


 


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MPLUGIN-335) Support JDK 10 for plugin generation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPLUGIN-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16464710#comment-16464710
 ] 

ASF GitHub Bot commented on MPLUGIN-335:


aldaris opened a new pull request #13: [MPLUGIN-335] - Fix build and tests
URL: https://github.com/apache/maven-plugin-tools/pull/13
 
 
   The previous PR ignored JDK<9 builds and caused test failures on JDK9+. This 
PR should address these.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Support JDK 10 for plugin generation
> 
>
> Key: MPLUGIN-335
> URL: https://issues.apache.org/jira/browse/MPLUGIN-335
> Project: Maven Plugin Tools
>  Issue Type: Dependency upgrade
>  Components: Plugin Plugin
>Affects Versions: 3.5.1
>Reporter: Peter Major
>Assignee: Olivier Lamy (*$^¨%`£)
>Priority: Major
> Fix For: 3.6
>
>
> The Maven Plugin Plugin currently does not support JDK 10, because the ASM 
> dependency is currently on 6.0_ALPHA, which does not support class version 
> 54.0. By upgrading ASM to the latest version, the plugin would be able to 
> process class files compiled with JDK10.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] aldaris opened a new pull request #13: [MPLUGIN-335] - Fix build and tests

[GitBox]

aldaris opened a new pull request #13: [MPLUGIN-335] - Fix build and tests
URL: https://github.com/apache/maven-plugin-tools/pull/13
 
 
   The previous PR ignored JDK<9 builds and caused test failures on JDK9+. This 
PR should address these.


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services