[GitHub] timdvail commented on issue #43: Fix for Windows by changing literal newlines to backslash followed by n.
timdvail commented on issue #43: Fix for Windows by changing literal newlines to backslash followed by n. URL: https://github.com/apache/maven-scm/pull/43#issuecomment-388701208 Finally got to setting up a JIRA issue. SCM-888 has been created referencing this. Thanks a bunch! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SCM-888) Changelog generation fails on Windows with Mercurial SCM
Tim Vail created SCM-888: Summary: Changelog generation fails on Windows with Mercurial SCM Key: SCM-888 URL: https://issues.apache.org/jira/browse/SCM-888 Project: Maven SCM Issue Type: Bug Components: maven-scm-provider-mercurial (hg) Affects Versions: 1.9.5 Environment: Windows Reporter: Tim Vail When you do 'mvn scm:changelog' on Windows with a project that is backed by mercurial it only finds revision -1 because literal newline in the Mercurial template is terminating the command for cmd.exe. There is a fix for this in my github pull request: https://github.com/apache/maven-scm/pull/43 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MGPG-65) https transfer hangs indefinitly sometimes
[ https://issues.apache.org/jira/browse/MGPG-65?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gruust updated MGPG-65: --- Description: I recommend upgrading wagon dependencies because older versions are known to produce that issue. (was: I recommend upgrading wagon dependencies.) > https transfer hangs indefinitly sometimes > -- > > Key: MGPG-65 > URL: https://issues.apache.org/jira/browse/MGPG-65 > Project: Maven GPG Plugin > Issue Type: Bug >Affects Versions: 1.6 >Reporter: Gruust >Priority: Major > > I recommend upgrading wagon dependencies because older versions are known to > produce that issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MGPG-65) https transfer hangs indefinitly sometimes
Gruust created MGPG-65: -- Summary: https transfer hangs indefinitly sometimes Key: MGPG-65 URL: https://issues.apache.org/jira/browse/MGPG-65 Project: Maven GPG Plugin Issue Type: Bug Affects Versions: 1.6 Reporter: Gruust I recommend upgrading wagon dependencies. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6382) JANSI fails frequently with NumberFormatException when building in parallel
[
https://issues.apache.org/jira/browse/MNG-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473660#comment-16473660
]
Hudson commented on MNG-6382:
-
Build failed in Jenkins: Maven TLP » maven » master #13
See https://builds.apache.org/job/maven-box/job/maven/job/master/13/
> JANSI fails frequently with NumberFormatException when building in parallel
> ---
>
> Key: MNG-6382
> URL: https://issues.apache.org/jira/browse/MNG-6382
> Project: Maven
> Issue Type: Bug
> Components: Logging
>Affects Versions: 3.5.3
> Environment: Apache Maven 3.5.3
> (3383c37e1f9e9b3bc3df5050c29c8aff9f295297; 2018-02-24T20:49:05+01:00)
> Maven home: C:\Develop\_tools\apache-maven-3.5.3\bin\..
> Java version: 10, vendor: Oracle Corporation
> Java home: C:\Develop\_tools\jdk-10.0.0
> Default locale: de_DE, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Falko Modler
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.5.4-candidate
>
>
> After upgrading from 3.3.9 to 3.5.4 my parallel Maven build fail frequently
> with:
> {noformat}
> java.lang.NumberFormatException: For input string: "34m"
> at
> java.base/java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)
> at java.base/java.lang.Integer.parseInt(Integer.java:652)
> at java.base/java.lang.Integer.(Integer.java:1096)
> at
> org.fusesource.jansi.AnsiPrintStream.filter(AnsiPrintStream.java:129)
> at
> org.fusesource.jansi.FilterPrintStream.write(FilterPrintStream.java:97)
> at
> org.fusesource.jansi.FilterPrintStream.write(FilterPrintStream.java:107)
> at
> org.fusesource.jansi.FilterPrintStream.print(FilterPrintStream.java:161)
> at
> org.slf4j.impl.MavenSimpleLogger.writeThrowable(MavenSimpleLogger.java:81)
> at org.slf4j.impl.SimpleLogger.write(SimpleLogger.java:319)
> at org.slf4j.impl.SimpleLogger.log(SimpleLogger.java:295)
> at org.slf4j.impl.SimpleLogger.error(SimpleLogger.java:593)
> at
> org.apache.maven.cli.CLIReportingUtils.showError(CLIReportingUtils.java:138)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:309)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:194)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:564)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> {noformat}
> This seems to have been [fixed in JANSI master
> branch|https://github.com/fusesource/jansi/commit/e45e4665538ba9234f5ee5d7b06d78d6a03deda3]
> but it has not yet been released. There is already a request for a bugfix
> release, see [issue 114 ("Need 1.17.1
> release")|https://github.com/fusesource/jansi/issues/114].
> Maven 3.5.4 should therefore upgrade to JANSI 1.17.1.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6372) On Windows Maven can output spurious ANSI escapes such as [0m [0m
[ https://issues.apache.org/jira/browse/MNG-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473661#comment-16473661 ] Hudson commented on MNG-6372: - Build failed in Jenkins: Maven TLP » maven » master #13 See https://builds.apache.org/job/maven-box/job/maven/job/master/13/ > On Windows Maven can output spurious ANSI escapes such as [0m [0m > - > > Key: MNG-6372 > URL: https://issues.apache.org/jira/browse/MNG-6372 > Project: Maven > Issue Type: Bug >Affects Versions: 3.5.3 >Reporter: Stephen Connolly >Assignee: Hervé Boutemy >Priority: Major > Fix For: 3.5.4-candidate > > > Found during the release vote of Maven 3.5.3 on Windows spurious ANSI partial > escape codes such as [0m > A regression introduced by the upgrade of JAnsi to 1.17. Tracked in Jansi as > issue #107 https://github.com/fusesource/jansi/issues/107, will be fixed in > 1.17.1 > notice: another issue from Jansi 1.17 exists, which is failure when run in > parallel build with NumberFormatException = see MNG-6382 for details -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6372) On Windows Maven can output spurious ANSI escapes such as [0m [0m
[ https://issues.apache.org/jira/browse/MNG-6372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy updated MNG-6372: --- Description: Found during the release vote of Maven 3.5.3 on Windows spurious ANSI partial escape codes such as [0m A regression introduced by the upgrade of JAnsi to 1.17. Tracked in Jansi as issue #107 https://github.com/fusesource/jansi/issues/107, will be fixed in 1.17.1 notice: another issue from Jansi 1.17 exists, which is failure when run in parallel build with NumberFormatException = see MNG-6382 for details was: Found during the release vote of Maven 3.5.3 on Windows spurious ANSI partial escape codes such as [0m A regression introduced by the upgrade of JAnsi to 1.17. Tracked in Jansi as issue #107 https://github.com/fusesource/jansi/issues/107, will be fixed in 1.18 notice: another issue from Jansi 1.17 exists, which is failure when run in parallel build with NumberFormatException = see MNG-6382 for details > On Windows Maven can output spurious ANSI escapes such as [0m [0m > - > > Key: MNG-6372 > URL: https://issues.apache.org/jira/browse/MNG-6372 > Project: Maven > Issue Type: Bug >Affects Versions: 3.5.3 >Reporter: Stephen Connolly >Assignee: Hervé Boutemy >Priority: Major > Fix For: 3.5.4-candidate > > > Found during the release vote of Maven 3.5.3 on Windows spurious ANSI partial > escape codes such as [0m > A regression introduced by the upgrade of JAnsi to 1.17. Tracked in Jansi as > issue #107 https://github.com/fusesource/jansi/issues/107, will be fixed in > 1.17.1 > notice: another issue from Jansi 1.17 exists, which is failure when run in > parallel build with NumberFormatException = see MNG-6382 for details -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MPLUGIN-338) Upgrade plexus-archiver to 3.6.0
[ https://issues.apache.org/jira/browse/MPLUGIN-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy closed MPLUGIN-338. - Resolution: Fixed Assignee: Hervé Boutemy https://gitbox.apache.org/repos/asf?p=maven-plugin-tools.git;a=commitdiff;h=ef44d094b52fccedbaf35e6a123ead989cf18f41 upgraded to 3.4.1 to keep Java 6 compatibility > Upgrade plexus-archiver to 3.6.0 > > > Key: MPLUGIN-338 > URL: https://issues.apache.org/jira/browse/MPLUGIN-338 > Project: Maven Plugin Tools > Issue Type: Task >Affects Versions: 3.5.1 >Reporter: Hervé Boutemy >Assignee: Hervé Boutemy >Priority: Critical > Fix For: 3.6 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MPLUGIN-333) Upgrade parent to 31
[ https://issues.apache.org/jira/browse/MPLUGIN-333?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Hervé Boutemy closed MPLUGIN-333. - Resolution: Fixed Assignee: Hervé Boutemy (was: Karl Heinz Marbaise) https://gitbox.apache.org/repos/asf?p=maven-plugin-tools.git;a=commitdiff;h=ad56a646a8c81b9e573e0e5e2def736786c5b775 > Upgrade parent to 31 > > > Key: MPLUGIN-333 > URL: https://issues.apache.org/jira/browse/MPLUGIN-333 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Affects Versions: 3.6 >Reporter: Karl Heinz Marbaise >Assignee: Hervé Boutemy >Priority: Minor > Fix For: 3.6 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6411) Improve readability of project list returned when resume from flag is invalid
[
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473654#comment-16473654
]
ASF GitHub Bot commented on MNG-6411:
-
splatch commented on a change in pull request #164: [MNG-6411] Improve
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r187815567
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty(
request.getMakeBehavior() ) )
if ( !resumed )
{
throw new MavenExecutionException( "Could not find project to
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
}
}
return result;
}
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
Review comment:
Great, will update all PRs to rely on it. Thank you very much for suggestion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve readability of project list returned when resume from flag is invalid
> -
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> When value passed for {{-rf}} option is invalid a full list of details of all
> projects in build is returned.
> This list contains too much information. For every project it includes
> groupId, artifactId, version and pom location. While it is useful for
> debugging purposes many, if not most, developers are interested in specific
> coordinate (groupId:artifactId) which should be passed to next execution, and
> which is valid {{-rf}} optiona value.
> Note tat below outputs contain new lines for ease of read. This could be also
> added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> MavenProject: com.example:foobar:1.0.0-SNAPSHOT @
> ~/sources/foobar/pom.xml,
> MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @
> ~/sources/foobar/parent/pom.xml,
> MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/api/pom.xml,
> MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/model/pom.xml,
> MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/pom.xml,
> MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/model/pom.xml,
> MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/api/pom.xml,
> MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/pom.xml,
> MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/model/pom.xml,
> MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/api/pom.xml,
> MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/core/pom.xml,
> MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/pom.xml,
> MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/api/pom.xml,
> MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/model/pom.xml,
> MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/pom.xml,
> MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/api/pom.xml,
> MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> com.example:foobar,
> com.example.foobar:parent,
> com.example.foobar:api,
>
[GitHub] splatch commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.
splatch commented on a change in pull request #164: [MNG-6411] Improve
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r187815567
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty(
request.getMakeBehavior() ) )
if ( !resumed )
{
throw new MavenExecutionException( "Could not find project to
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
}
}
return result;
}
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
Review comment:
Great, will update all PRs to rely on it. Thank you very much for suggestion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MCOMPILER-341) Compile module-info.java files located in test sources
[
https://issues.apache.org/jira/browse/MCOMPILER-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473644#comment-16473644
]
Christian Stein commented on MCOMPILER-341:
---
{quote}[...] although ideally it could be merged with that from the
src/main/java folder
{quote}
Manually merging is a good start. Granted, users need to synchronize
module-info elements carefully and correctly from main to test ... and update
it when-ever the main module descriptor changes. Automatic module-info merging
is possible and already a feature offered by [https://github.com/forax/pro]
> Compile module-info.java files located in test sources
> --
>
> Key: MCOMPILER-341
> URL: https://issues.apache.org/jira/browse/MCOMPILER-341
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Affects Versions: 3.7.0
>Reporter: Christian Stein
>Priority: Minor
> Labels: pull-request-available
>
> Support compilation of projects with test sources containing modules – along
> with explicit module descriptors ({{module-info.java}} files).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCOMPILER-341) Compile module-info.java files located in test sources
[
https://issues.apache.org/jira/browse/MCOMPILER-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473634#comment-16473634
]
Stephen Colebourne commented on MCOMPILER-341:
--
This looks like a good approach to the problem - we need module-info for
testing (although ideally it could be merged with that from the src/main/java
folder)
> Compile module-info.java files located in test sources
> --
>
> Key: MCOMPILER-341
> URL: https://issues.apache.org/jira/browse/MCOMPILER-341
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Affects Versions: 3.7.0
>Reporter: Christian Stein
>Priority: Minor
> Labels: pull-request-available
>
> Support compilation of projects with test sources containing modules – along
> with explicit module descriptors ({{module-info.java}} files).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set
[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473597#comment-16473597
]
Michael Osipov edited comment on SCM-885 at 5/13/18 8:34 PM:
-
Do you think you could modify the PR to satisfiy the first three cases of [this
spec|https://git-scm.com/docs/gitrevisions#_revision_range_summary]? I am
reluctant to change the current, correct behavior. Git offers to many
representations which cannot be covered by a generic API.
was (Author: michael-o):
Do you think you could modify the PR to satisfiy the first three cases of [this
spec|https://git-scm.com/docs/gitrevisions#_revision_range_summary]? I am
reluctant to change the current, correct behavior. Git offers to many
representations which can be covered by a generic API.
> GitChangeLogCommand is wrong when only endVersion is set
>
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set
[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473622#comment-16473622
]
Matthieu Brouillard commented on SCM-885:
-
I'll try to propose something else, perhaps a specific ScmVersion
implementation or constant.
> GitChangeLogCommand is wrong when only endVersion is set
>
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSITE-824) Generate (X)HTML5 by default
[ https://issues.apache.org/jira/browse/MSITE-824?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473598#comment-16473598 ] Graham Leggett commented on MSITE-824: -- Work-in-progress patch: https://github.com/apache/maven-site-plugin/pull/2 > Generate (X)HTML5 by default > > > Key: MSITE-824 > URL: https://issues.apache.org/jira/browse/MSITE-824 > Project: Maven Site Plugin > Issue Type: Improvement > Components: doxia integration >Affects Versions: 3.7.1 >Reporter: Graham Leggett >Priority: Major > > Once Doxia is updated to support HTML5.2 as per https://www.w3.org/TR/html52/ > in DOXIA-575, and doxia-site-renderer is updated as per > https://issues.apache.org/jira/browse/DOXIASITETOOLS-190, use XHTML5 by > default. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MSITE-824) Generate (X)HTML5 by default
Graham Leggett created MSITE-824: Summary: Generate (X)HTML5 by default Key: MSITE-824 URL: https://issues.apache.org/jira/browse/MSITE-824 Project: Maven Site Plugin Issue Type: Improvement Components: doxia integration Affects Versions: 3.7.1 Reporter: Graham Leggett Once Doxia is updated to support HTML5.2 as per https://www.w3.org/TR/html52/ in DOXIA-575, and doxia-site-renderer is updated as per https://issues.apache.org/jira/browse/DOXIASITETOOLS-190, use XHTML5 by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set
[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473597#comment-16473597
]
Michael Osipov edited comment on SCM-885 at 5/13/18 6:26 PM:
-
Do you think you could modify the PR to satisfiy the first three cases of [this
spec|https://git-scm.com/docs/gitrevisions#_revision_range_summary]? I am
reluctant to change the current, correct behavior. Git offers to many
representations which can be covered by a generic API.
was (Author: michael-o):
Do you think you could modify the PR to satisfiy the first three cases of [this
spec|https://git-scm.com/docs/gitrevisions#_revision_range_summary]?
> GitChangeLogCommand is wrong when only endVersion is set
>
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-885) GitChangeLogCommand is wrong when only endVersion is set
[
https://issues.apache.org/jira/browse/SCM-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473597#comment-16473597
]
Michael Osipov commented on SCM-885:
Do you think you could modify the PR to satisfiy the first three cases of [this
spec|https://git-scm.com/docs/gitrevisions#_revision_range_summary]?
> GitChangeLogCommand is wrong when only endVersion is set
>
>
> Key: SCM-885
> URL: https://issues.apache.org/jira/browse/SCM-885
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Invoking execution of a GitChangeLogCommand where only the end revision has
> been set produces a wrong out.
> +Actual result:+
> {{git whatchanged --date=iso ..END_REVISION_SHA1 -- PROJECT_PATH}}
> +Expected result:+ only the end revison SHA1 is used without the two dots
> {{git whatchanged --date=iso END_REVISION_SHA1 -- PROJECT_PATH}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (DOXIASITETOOLS-190) Generate (X)HTML5 by default
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-190?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473596#comment-16473596 ] Graham Leggett commented on DOXIASITETOOLS-190: --- Work-in-progress patch: https://github.com/apache/maven-doxia-sitetools/pull/5 > Generate (X)HTML5 by default > > > Key: DOXIASITETOOLS-190 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-190 > Project: Maven Doxia Sitetools > Issue Type: Improvement > Components: Site renderer >Affects Versions: 1.8.1 >Reporter: Graham Leggett >Priority: Major > > Once Doxia is updated to support HTML5.2 as per https://www.w3.org/TR/html52/ > in DOXIA-575, use XHTML5 by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] minfrin opened a new pull request #5: Switch from XhtmlSink to Xhtml5Sink as the default site renderer.
minfrin opened a new pull request #5: Switch from XhtmlSink to Xhtml5Sink as the default site renderer. URL: https://github.com/apache/maven-doxia-sitetools/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (DOXIASITETOOLS-190) Generate (X)HTML5 by default
Graham Leggett created DOXIASITETOOLS-190: - Summary: Generate (X)HTML5 by default Key: DOXIASITETOOLS-190 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-190 Project: Maven Doxia Sitetools Issue Type: Improvement Components: Site renderer Affects Versions: 1.8.1 Reporter: Graham Leggett Once Doxia is updated to support HTML5.2 as per https://www.w3.org/TR/html52/ in DOXIA-575, use XHTML5 by default. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DOXIA-575) Add support for (X)HTML5
[ https://issues.apache.org/jira/browse/DOXIA-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473591#comment-16473591 ] Graham Leggett commented on DOXIA-575: -- Work in progress patch: https://github.com/apache/maven-doxia/pull/10 > Add support for (X)HTML5 > > > Key: DOXIA-575 > URL: https://issues.apache.org/jira/browse/DOXIA-575 > Project: Maven Doxia > Issue Type: Improvement > Components: Core >Affects Versions: 1.8 >Reporter: Graham Leggett >Priority: Major > > Doxia currently generates XHTML v1.1, and does not support any of the new > HTML5 tags. > Update Doxia to support HTML5.2 as per https://www.w3.org/TR/html52/. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (DOXIA-575) Add support for (X)HTML5
Graham Leggett created DOXIA-575: Summary: Add support for (X)HTML5 Key: DOXIA-575 URL: https://issues.apache.org/jira/browse/DOXIA-575 Project: Maven Doxia Issue Type: Improvement Components: Core Affects Versions: 1.8 Reporter: Graham Leggett Doxia currently generates XHTML v1.1, and does not support any of the new HTML5 tags. Update Doxia to support HTML5.2 as per https://www.w3.org/TR/html52/. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MRAR-75) Upgrade plexus-interpolation to 1.25
Karl Heinz Marbaise created MRAR-75: --- Summary: Upgrade plexus-interpolation to 1.25 Key: MRAR-75 URL: https://issues.apache.org/jira/browse/MRAR-75 Project: Maven Rar Plugin Issue Type: Dependency upgrade Affects Versions: 3.0.0 Reporter: Karl Heinz Marbaise Assignee: Karl Heinz Marbaise Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MRAR-74) Upgrade plexus-archiver to 3.6.0
Karl Heinz Marbaise created MRAR-74: --- Summary: Upgrade plexus-archiver to 3.6.0 Key: MRAR-74 URL: https://issues.apache.org/jira/browse/MRAR-74 Project: Maven Rar Plugin Issue Type: Dependency upgrade Affects Versions: 3.0.0 Reporter: Karl Heinz Marbaise Assignee: Karl Heinz Marbaise Fix For: 3.0.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MACR-45) Upgrade plexus-archiver to 3.6.0
Karl Heinz Marbaise created MACR-45: --- Summary: Upgrade plexus-archiver to 3.6.0 Key: MACR-45 URL: https://issues.apache.org/jira/browse/MACR-45 Project: Maven ACR Plugin Issue Type: Dependency upgrade Affects Versions: 3.1.0 Reporter: Karl Heinz Marbaise Assignee: Karl Heinz Marbaise Fix For: 3.1.0 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MPLUGIN-338) Upgrade plexus-archiver to 3.6.0
Hervé Boutemy created MPLUGIN-338: - Summary: Upgrade plexus-archiver to 3.6.0 Key: MPLUGIN-338 URL: https://issues.apache.org/jira/browse/MPLUGIN-338 Project: Maven Plugin Tools Issue Type: Task Affects Versions: 3.5.1 Reporter: Hervé Boutemy Fix For: 3.6 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-885) remove unused unpack code
[ https://issues.apache.org/jira/browse/MASSEMBLY-885?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473549#comment-16473549 ] Hudson commented on MASSEMBLY-885: -- Build succeeded in Jenkins: Maven TLP » maven-assembly-plugin » MASSEMBLY-884 #4 See https://builds.apache.org/job/maven-box/job/maven-assembly-plugin/job/MASSEMBLY-884/4/ > remove unused unpack code > - > > Key: MASSEMBLY-885 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-885 > Project: Maven Assembly Plugin > Issue Type: Task >Affects Versions: 3.1.0 >Reporter: Hervé Boutemy >Assignee: Hervé Boutemy >Priority: Major > Fix For: 3.1.1 > > > unpack goal was removed in 3.0.0 with MASSEMBLY-704 > we can delete AssemblyFileUtils.unpack code -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MASSEMBLY-884) Upgrade plexus-archiver to 3.6.0
[ https://issues.apache.org/jira/browse/MASSEMBLY-884?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473550#comment-16473550 ] Hudson commented on MASSEMBLY-884: -- Build succeeded in Jenkins: Maven TLP » maven-assembly-plugin » MASSEMBLY-884 #4 See https://builds.apache.org/job/maven-box/job/maven-assembly-plugin/job/MASSEMBLY-884/4/ > Upgrade plexus-archiver to 3.6.0 > > > Key: MASSEMBLY-884 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-884 > Project: Maven Assembly Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.1.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Critical > Fix For: 3.1.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCOMPILER-341) Compile module-info.java files located in test sources
[
https://issues.apache.org/jira/browse/MCOMPILER-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473545#comment-16473545
]
Hudson commented on MCOMPILER-341:
--
Build failed in Jenkins: Maven TLP » maven-compiler-plugin » MCOMPILER-341 #5
See
https://builds.apache.org/job/maven-box/job/maven-compiler-plugin/job/MCOMPILER-341/5/
> Compile module-info.java files located in test sources
> --
>
> Key: MCOMPILER-341
> URL: https://issues.apache.org/jira/browse/MCOMPILER-341
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Affects Versions: 3.7.0
>Reporter: Christian Stein
>Priority: Minor
> Labels: pull-request-available
>
> Support compilation of projects with test sources containing modules – along
> with explicit module descriptors ({{module-info.java}} files).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCOMPILER-341) Compile module-info.java files located in test sources
[
https://issues.apache.org/jira/browse/MCOMPILER-341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473544#comment-16473544
]
ASF GitHub Bot commented on MCOMPILER-341:
--
sormuras commented on issue #4: [MCOMPILER-341] Compile module descriptors with
TestCompilerMojo
URL:
https://github.com/apache/maven-compiler-plugin/pull/4#issuecomment-388637929
2 black-box and 1 white-box integration tests implemented:
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Compile module-info.java files located in test sources
> --
>
> Key: MCOMPILER-341
> URL: https://issues.apache.org/jira/browse/MCOMPILER-341
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Affects Versions: 3.7.0
>Reporter: Christian Stein
>Priority: Minor
> Labels: pull-request-available
>
> Support compilation of projects with test sources containing modules – along
> with explicit module descriptors ({{module-info.java}} files).
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] sormuras commented on issue #4: [MCOMPILER-341] Compile module descriptors with TestCompilerMojo
sormuras commented on issue #4: [MCOMPILER-341] Compile module descriptors with TestCompilerMojo URL: https://github.com/apache/maven-compiler-plugin/pull/4#issuecomment-388637929 2 black-box and 1 white-box integration tests implemented:  This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MCHANGES-388) Add option to include issues using the -SNAPSHOT suffix for version/milestone
[ https://issues.apache.org/jira/browse/MCHANGES-388?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473498#comment-16473498 ] Michael Osipov commented on MCHANGES-388: - Have you looked at the code which part of the plugin needs to be changed? > Add option to include issues using the -SNAPSHOT suffix for version/milestone > - > > Key: MCHANGES-388 > URL: https://issues.apache.org/jira/browse/MCHANGES-388 > Project: Maven Changes Plugin > Issue Type: Wish > Components: github >Reporter: Marcelo Riss >Priority: Minor > Attachments: pom.xml > > > I have a use case where the version id/name at the issue tracking system > (GHE) will have the -SNAPSHOT suffix. Currently, when setting GHE as issue > tracking system and the parameter > *[onlyCurrentVersion|http://maven.apache.org/plugins/maven-changes-plugin/github-report-mojo.html#onlyCurrentVersion]* > to true, the -SNAPSHOT suffix is removed when filtering the issues. My > suggestion is to add a configuration parameter allowing to consider or not > the -SNAPSHOT suffix as the version id/name when searching for issues. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCOMPILER-330) Add java.* JPMS modules for testing only is hard
[ https://issues.apache.org/jira/browse/MCOMPILER-330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473484#comment-16473484 ] Christian Stein commented on MCOMPILER-330: --- Created https://issues.apache.org/jira/browse/MCOMPILER-341 to tackle `module-info.java` compilation when module descriptors are located in test scope. This will permit "black-box testing" (different test module name compared to its main module name) with a dedicated test module descriptor. You may specify all required modules your tests need to compile and run. This will also permit "white-box testing". Here, the test and main module share the same name. Merging the main and test requirements have to be done manually for now, i.e. you may specify all required modules your tests need to compile and run *in addition* to the requirements of your main module. > Add java.* JPMS modules for testing only is hard > > > Key: MCOMPILER-330 > URL: https://issues.apache.org/jira/browse/MCOMPILER-330 > Project: Maven Compiler Plugin > Issue Type: Improvement >Affects Versions: 3.7.0 > Environment: Windows 10, Maven v3.5.2 >Reporter: Stephen Colebourne >Priority: Major > Attachments: maven-issue3.zip > > > Attached is a project demonstrating this issue (which affects both compiler > and surefire). The basic problem here is where the project depends on a > java.* module for testing but not at compile time. For example, the test code > depends on `java.desktop` module, but the main code does not. > While this has similarities with MCOMPILER-320 it is different because there > is no way to refer to the `java.*` JPMS modules as dependencies. > Right now the workaround is to add both --add-modules and --add-reads, as > shown in the attachment. This is painful low-level stuff that Maven should be > hiding the user from. > NOTE: the attachment will succeed when run. Delete the compiler/surefire > plugin config to see the issue. > Rather than tackle this problem directly, my preference would be to have a > module-patch.java file that allows users to declare additional > dependencies/exports/services that only apply at testing time. This would be > interpreted whenever --patch-module is being used. (As well as the example > explained here, I've also run into the need to export packages that only > exist in tests, and this currently also requires low-level argLine > manipulation). > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6411) Improve readability of project list returned when resume from flag is invalid
[
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473483#comment-16473483
]
ASF GitHub Bot commented on MNG-6411:
-
michael-o commented on a change in pull request #164: [MNG-6411] Improve
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r187800865
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty(
request.getMakeBehavior() ) )
if ( !resumed )
{
throw new MavenExecutionException( "Could not find project to
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
}
}
return result;
}
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
Review comment:
It is. Look at your Maven installation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve readability of project list returned when resume from flag is invalid
> -
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> When value passed for {{-rf}} option is invalid a full list of details of all
> projects in build is returned.
> This list contains too much information. For every project it includes
> groupId, artifactId, version and pom location. While it is useful for
> debugging purposes many, if not most, developers are interested in specific
> coordinate (groupId:artifactId) which should be passed to next execution, and
> which is valid {{-rf}} optiona value.
> Note tat below outputs contain new lines for ease of read. This could be also
> added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> MavenProject: com.example:foobar:1.0.0-SNAPSHOT @
> ~/sources/foobar/pom.xml,
> MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @
> ~/sources/foobar/parent/pom.xml,
> MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/api/pom.xml,
> MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/model/pom.xml,
> MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/pom.xml,
> MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/model/pom.xml,
> MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/api/pom.xml,
> MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/pom.xml,
> MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/model/pom.xml,
> MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/api/pom.xml,
> MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/core/pom.xml,
> MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/pom.xml,
> MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/api/pom.xml,
> MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/model/pom.xml,
> MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/pom.xml,
> MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/api/pom.xml,
> MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> com.example:foobar,
> com.example.foobar:parent,
> com.example.foobar:api,
> com.example.foobar:model,
>
[GitHub] michael-o commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.
michael-o commented on a change in pull request #164: [MNG-6411] Improve
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r187800865
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty(
request.getMakeBehavior() ) )
if ( !resumed )
{
throw new MavenExecutionException( "Could not find project to
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
}
}
return result;
}
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
Review comment:
It is. Look at your Maven installation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MNG-6411) Improve readability of project list returned when resume from flag is invalid
[
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473475#comment-16473475
]
ASF GitHub Bot commented on MNG-6411:
-
splatch commented on a change in pull request #164: [MNG-6411] Improve
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r18787
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty(
request.getMakeBehavior() ) )
if ( !resumed )
{
throw new MavenExecutionException( "Could not find project to
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
}
}
return result;
}
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
Review comment:
It makes sense to use commons only if they are already part of core
dependencies.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve readability of project list returned when resume from flag is invalid
> -
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> When value passed for {{-rf}} option is invalid a full list of details of all
> projects in build is returned.
> This list contains too much information. For every project it includes
> groupId, artifactId, version and pom location. While it is useful for
> debugging purposes many, if not most, developers are interested in specific
> coordinate (groupId:artifactId) which should be passed to next execution, and
> which is valid {{-rf}} optiona value.
> Note tat below outputs contain new lines for ease of read. This could be also
> added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> MavenProject: com.example:foobar:1.0.0-SNAPSHOT @
> ~/sources/foobar/pom.xml,
> MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @
> ~/sources/foobar/parent/pom.xml,
> MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/api/pom.xml,
> MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/model/pom.xml,
> MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/pom.xml,
> MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/model/pom.xml,
> MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/api/pom.xml,
> MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/pom.xml,
> MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/model/pom.xml,
> MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/api/pom.xml,
> MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/core/pom.xml,
> MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/pom.xml,
> MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/api/pom.xml,
> MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/model/pom.xml,
> MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/pom.xml,
> MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/api/pom.xml,
> MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> com.example:foobar,
> com.example.foobar:parent,
> com.example.foobar:api,
>
[GitHub] splatch commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.
splatch commented on a change in pull request #164: [MNG-6411] Improve
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r18787
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty(
request.getMakeBehavior() ) )
if ( !resumed )
{
throw new MavenExecutionException( "Could not find project to
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
}
}
return result;
}
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
Review comment:
It makes sense to use commons only if they are already part of core
dependencies.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MWAR-303) filtering of ${project.developers[0].id} does not work
[
https://issues.apache.org/jira/browse/MWAR-303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473468#comment-16473468
]
Michael Osipov commented on MWAR-303:
-
Really emberassing. I completely forgot this. Sorry for that. [~khmarbaise]
will push the Plexus Interpolation release and we can hopefully fix this issue.
> filtering of ${project.developers[0].id} does not work
> --
>
> Key: MWAR-303
> URL: https://issues.apache.org/jira/browse/MWAR-303
> Project: Maven WAR Plugin
> Issue Type: Bug
> Components: filtering
>Affects Versions: 2.4, 2.5, 2.6
> Environment: tested with maven 3.0.5, 3.1.0, 3.2.1 Win XP and 7, Java
> 7.
>Reporter: Gabriel Belingueres
>Priority: Major
> Fix For: 3.2.2
>
> Attachments: modified-integ-test.patch
>
>
> An expression like {{$\{project.developers\[0\].id}} is not filtered
> in version 2.4.
> It works fine in maven war plugin version 2.3.
> I attached a patch file with a modified integration test.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SCM-886) Tests with checkin rely on global git config
[
https://issues.apache.org/jira/browse/SCM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473465#comment-16473465
]
Michael Osipov commented on SCM-886:
The clone in question is
{{D:\Entwicklung\Projekte\maven-scm\maven-scm-providers\maven-scm-providers-git\maven-scm-provider-gitexe\target\checkin-nobranch\.git\config}}.
Unfortunately, there is no {{config}} command because it is too Git specific.
The best you can do in the tests {{GitCheckInCommandNoBranchTest.java}} and
{{GitExeCheckOutCommandNoBranchTest.java}} is to issue a exe command with the
given wrappers. It won't get better.
> Tests with checkin rely on global git config
>
>
> Key: SCM-886
> URL: https://issues.apache.org/jira/browse/SCM-886
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
>
> Inside maven-scm-provider-gitexe project, the two following tests
> `GitCheckInCommandNoBranchTest.testCheckinNoBranch` and
> `GitCheckInCommandTest.testCheckinAfterRename` expect a global user.name and
> user.email to be set.
> On installations where .gitconfig contains the following:
> {{[user]}}
> {{useConfigOnly = true}}
> The tests will fail.
> It would be better after repository creation to configure a user name & email
> at project level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6411) Improve readability of project list returned when resume from flag is invalid
[
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473463#comment-16473463
]
ASF GitHub Bot commented on MNG-6411:
-
michael-o commented on a change in pull request #164: [MNG-6411] Improve
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r187798863
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty(
request.getMakeBehavior() ) )
if ( !resumed )
{
throw new MavenExecutionException( "Could not find project to
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
}
}
return result;
}
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
Review comment:
@splatch An iterator gives you that.
@slachiewicz He need custom formatting before the separator.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve readability of project list returned when resume from flag is invalid
> -
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> When value passed for {{-rf}} option is invalid a full list of details of all
> projects in build is returned.
> This list contains too much information. For every project it includes
> groupId, artifactId, version and pom location. While it is useful for
> debugging purposes many, if not most, developers are interested in specific
> coordinate (groupId:artifactId) which should be passed to next execution, and
> which is valid {{-rf}} optiona value.
> Note tat below outputs contain new lines for ease of read. This could be also
> added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> MavenProject: com.example:foobar:1.0.0-SNAPSHOT @
> ~/sources/foobar/pom.xml,
> MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @
> ~/sources/foobar/parent/pom.xml,
> MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/api/pom.xml,
> MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/model/pom.xml,
> MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/pom.xml,
> MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/model/pom.xml,
> MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/api/pom.xml,
> MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/pom.xml,
> MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/model/pom.xml,
> MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/api/pom.xml,
> MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/core/pom.xml,
> MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/pom.xml,
> MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/api/pom.xml,
> MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/model/pom.xml,
> MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/pom.xml,
> MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/api/pom.xml,
> MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> com.example:foobar,
> com.example.foobar:parent,
>
[GitHub] michael-o commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.
michael-o commented on a change in pull request #164: [MNG-6411] Improve
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r187798863
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty(
request.getMakeBehavior() ) )
if ( !resumed )
{
throw new MavenExecutionException( "Could not find project to
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
}
}
return result;
}
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
Review comment:
@splatch An iterator gives you that.
@slachiewicz He need custom formatting before the separator.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Created] (MDEP-612) Upgrade maven-dependency-analyzer to 1.10
Karl Heinz Marbaise created MDEP-612: Summary: Upgrade maven-dependency-analyzer to 1.10 Key: MDEP-612 URL: https://issues.apache.org/jira/browse/MDEP-612 Project: Maven Dependency Plugin Issue Type: Dependency upgrade Affects Versions: 3.1.1 Reporter: Karl Heinz Marbaise Fix For: 3.1.1 We have to wait for the successful VOTE for maven-dependency-analyzer 1.10 see MSHARED-718 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MENFORCER-303) Upgrade mave-surefire/failsafe-plugin 2.21.0
[ https://issues.apache.org/jira/browse/MENFORCER-303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise updated MENFORCER-303: -- Description: For JDK 10 also Mockito must be updated. > Upgrade mave-surefire/failsafe-plugin 2.21.0 > > > Key: MENFORCER-303 > URL: https://issues.apache.org/jira/browse/MENFORCER-303 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.0.0-M1 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Blocker > Fix For: 3.0.0 > > > For JDK 10 also Mockito must be updated. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MJAVADOC-524) Running javadoc plugin under JDK 10 fails with NPE
[
https://issues.apache.org/jira/browse/MJAVADOC-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473419#comment-16473419
]
Mark Raynsford edited comment on MJAVADOC-524 at 5/13/18 9:39 AM:
--
Oddly, I'm seeing this on some JDK 10 installations and not others.
On Linux:
{noformat}
openjdk version "10.0.1" 2018-04-17
OpenJDK Runtime Environment (build 10.0.1+10)
OpenJDK 64-Bit Server VM (build 10.0.1+10, mixed mode)
{noformat}
... works. On macOS:
{noformat}
openjdk version "10-internal"
OpenJDK Runtime Environment (build 10-internal+0-adhoc.jenkins.openjdk)
OpenJDK 64-Bit Server VM (build 10-internal+0-adhoc.jenkins.openjdk, mixed mode)
{noformat}
... fails! The macOS build came from the AdoptOpenJDK project. The macOS build
is actually 10+23 but doesn't identify itself as such.
was (Author: io7m):
Oddly, I'm seeing this on some JDK 10 installations and not others.
On Linux:
{noformat}
openjdk version "10.0.1" 2018-04-17
OpenJDK Runtime Environment (build 10.0.1+10)
OpenJDK 64-Bit Server VM (build 10.0.1+10, mixed mode)
{noformat}
... works. On macOS:
{noformat}
openjdk version "10-internal"
OpenJDK Runtime Environment (build 10-internal+0-adhoc.jenkins.openjdk)
OpenJDK 64-Bit Server VM (build 10-internal+0-adhoc.jenkins.openjdk, mixed mode)
{noformat}
... fails! The macOS build came from the AdoptOpenJDK project.
> Running javadoc plugin under JDK 10 fails with NPE
> --
>
> Key: MJAVADOC-524
> URL: https://issues.apache.org/jira/browse/MJAVADOC-524
> Project: Maven Javadoc Plugin
> Issue Type: Dependency upgrade
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Priority: Blocker
> Fix For: 3.0.1
>
>
> Running under JDK 10 produces the following:
> {code}
> [INFO] [INFO]
>
> [INFO] [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar (attach-javadocs) on
> project maven-dependency-analyzer: Execution attach-javadocs of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar failed.:
> NullPointerException -> [Help 1]
> [INFO] [ERROR]
> [INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with
> the -e switch.
> [INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [INFO] [ERROR]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MJAVADOC-524) Running javadoc plugin under JDK 10 fails with NPE
[
https://issues.apache.org/jira/browse/MJAVADOC-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473419#comment-16473419
]
Mark Raynsford commented on MJAVADOC-524:
-
Oddly, I'm seeing this on some JDK 10 installations and not others.
On Linux:
{noformat}
openjdk version "10.0.1" 2018-04-17
OpenJDK Runtime Environment (build 10.0.1+10)
OpenJDK 64-Bit Server VM (build 10.0.1+10, mixed mode)
{noformat}
... works. On macOS:
{noformat}
openjdk version "10-internal"
OpenJDK Runtime Environment (build 10-internal+0-adhoc.jenkins.openjdk)
OpenJDK 64-Bit Server VM (build 10-internal+0-adhoc.jenkins.openjdk, mixed mode)
{noformat}
... fails! The macOS build came from the AdoptOpenJDK project.
> Running javadoc plugin under JDK 10 fails with NPE
> --
>
> Key: MJAVADOC-524
> URL: https://issues.apache.org/jira/browse/MJAVADOC-524
> Project: Maven Javadoc Plugin
> Issue Type: Dependency upgrade
>Affects Versions: 3.0.0
>Reporter: Karl Heinz Marbaise
>Priority: Blocker
> Fix For: 3.0.1
>
>
> Running under JDK 10 produces the following:
> {code}
> [INFO] [INFO]
>
> [INFO] [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar (attach-javadocs) on
> project maven-dependency-analyzer: Execution attach-javadocs of goal
> org.apache.maven.plugins:maven-javadoc-plugin:3.0.0:jar failed.:
> NullPointerException -> [Help 1]
> [INFO] [ERROR]
> [INFO] [ERROR] To see the full stack trace of the errors, re-run Maven with
> the -e switch.
> [INFO] [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [INFO] [ERROR]
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6411) Improve readability of project list returned when resume from flag is invalid
[
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473411#comment-16473411
]
ASF GitHub Bot commented on MNG-6411:
-
slachiewicz commented on a change in pull request #164: [MNG-6411] Improve
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r187793176
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty(
request.getMakeBehavior() ) )
if ( !resumed )
{
throw new MavenExecutionException( "Could not find project to
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
}
}
return result;
}
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
Review comment:
or use StingUtils.join from Commons-lang3
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve readability of project list returned when resume from flag is invalid
> -
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> When value passed for {{-rf}} option is invalid a full list of details of all
> projects in build is returned.
> This list contains too much information. For every project it includes
> groupId, artifactId, version and pom location. While it is useful for
> debugging purposes many, if not most, developers are interested in specific
> coordinate (groupId:artifactId) which should be passed to next execution, and
> which is valid {{-rf}} optiona value.
> Note tat below outputs contain new lines for ease of read. This could be also
> added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> MavenProject: com.example:foobar:1.0.0-SNAPSHOT @
> ~/sources/foobar/pom.xml,
> MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @
> ~/sources/foobar/parent/pom.xml,
> MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/api/pom.xml,
> MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/model/pom.xml,
> MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/pom.xml,
> MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/model/pom.xml,
> MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/api/pom.xml,
> MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/pom.xml,
> MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/model/pom.xml,
> MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/api/pom.xml,
> MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/core/pom.xml,
> MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/pom.xml,
> MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/api/pom.xml,
> MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/model/pom.xml,
> MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/pom.xml,
> MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/api/pom.xml,
> MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> com.example:foobar,
> com.example.foobar:parent,
> com.example.foobar:api,
> com.example.foobar:model,
>
[GitHub] slachiewicz commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.
slachiewicz commented on a change in pull request #164: [MNG-6411] Improve
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r187793176
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty(
request.getMakeBehavior() ) )
if ( !resumed )
{
throw new MavenExecutionException( "Could not find project to
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
}
}
return result;
}
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
Review comment:
or use StingUtils.join from Commons-lang3
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (SCM-886) Tests with checkin rely on global git config
[
https://issues.apache.org/jira/browse/SCM-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473410#comment-16473410
]
Matthieu Brouillard commented on SCM-886:
-
{quote}I guess a static {{.git/config}} in the test repo shall be enough.
{quote}
No it is not because the clone command already created a config file. We could
write/append to it but it is quite ugly ; the best is to issue a git config
command on this cloned repository. But I have not seen any command allowing to
call 'config', did I miss looked?
> Tests with checkin rely on global git config
>
>
> Key: SCM-886
> URL: https://issues.apache.org/jira/browse/SCM-886
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-gitexe
>Affects Versions: 1.9.5
>Reporter: Matthieu Brouillard
>Priority: Major
>
> Inside maven-scm-provider-gitexe project, the two following tests
> `GitCheckInCommandNoBranchTest.testCheckinNoBranch` and
> `GitCheckInCommandTest.testCheckinAfterRename` expect a global user.name and
> user.email to be set.
> On installations where .gitconfig contains the following:
> {{[user]}}
> {{useConfigOnly = true}}
> The tests will fail.
> It would be better after repository creation to configure a user name & email
> at project level.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6411) Improve readability of project list returned when resume from flag is invalid
[
https://issues.apache.org/jira/browse/MNG-6411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16473408#comment-16473408
]
ASF GitHub Bot commented on MNG-6411:
-
splatch commented on a change in pull request #164: [MNG-6411] Improve
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r187792949
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty(
request.getMakeBehavior() ) )
if ( !resumed )
{
throw new MavenExecutionException( "Could not find project to
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
}
}
return result;
}
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
Review comment:
There is additional condition inside loop which appends a colon. This can’t
be done without regular for loop as foreach doesn’t give a way to check if
fetched element is actually the last one.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve readability of project list returned when resume from flag is invalid
> -
>
> Key: MNG-6411
> URL: https://issues.apache.org/jira/browse/MNG-6411
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.3
>Reporter: Łukasz Dywicki
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> When value passed for {{-rf}} option is invalid a full list of details of all
> projects in build is returned.
> This list contains too much information. For every project it includes
> groupId, artifactId, version and pom location. While it is useful for
> debugging purposes many, if not most, developers are interested in specific
> coordinate (groupId:artifactId) which should be passed to next execution, and
> which is valid {{-rf}} optiona value.
> Note tat below outputs contain new lines for ease of read. This could be also
> added to exception message to make it more readable.
> Assuming, that I've passed -rf :x Current output in case of failure:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
> MavenProject: com.example:foobar:1.0.0-SNAPSHOT @
> ~/sources/foobar/pom.xml,
> MavenProject: com.example.foobar:parent:1.0.0-SNAPSHOT @
> ~/sources/foobar/parent/pom.xml,
> MavenProject: com.example.foobar:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/api/pom.xml,
> MavenProject: com.example.foobar:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/model/pom.xml,
> MavenProject: com.example.foobar:csv:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/pom.xml,
> MavenProject: com.example.foobar.csv:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/model/pom.xml,
> MavenProject: com.example.foobar.csv:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/csv/api/pom.xml,
> MavenProject: com.example.foobar:json:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/pom.xml,
> MavenProject: com.example.foobar.json:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/model/pom.xml,
> MavenProject: com.example.foobar.json:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/api/pom.xml,
> MavenProject: com.example.foobar.json:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/json/core/pom.xml,
> MavenProject: com.example.foobar:fax:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/pom.xml,
> MavenProject: com.example.foobar.fax:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/api/pom.xml,
> MavenProject: com.example.foobar.fax:model:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/model/pom.xml,
> MavenProject: com.example.foobar.fax:web:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/pom.xml,
> MavenProject: com.example.foobar.fax.web:api:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/api/pom.xml,
> MavenProject: com.example.foobar.fax.web:core:1.0.0-SNAPSHOT @
> ~/sources/foobar/fax/web/core/pom.xml] -> [Help 1]
> {noformat}
> Additional information about pom locations is irrelevant from message point
> of view, because valid input for -rf option is presented below:
> {noformat}
> ERROR] Could not find project to resume reactor build from: :x vs [
[GitHub] splatch commented on a change in pull request #164: [MNG-6411] Improve readability of project list for resume option.
splatch commented on a change in pull request #164: [MNG-6411] Improve
readability of project list for resume option.
URL: https://github.com/apache/maven/pull/164#discussion_r187792949
##
File path:
maven-core/src/main/java/org/apache/maven/graph/DefaultGraphBuilder.java
##
@@ -311,13 +311,29 @@ else if ( StringUtils.isNotEmpty(
request.getMakeBehavior() ) )
if ( !resumed )
{
throw new MavenExecutionException( "Could not find project to
resume reactor build from: " + selector
-+ " vs " + projects, request.getPom() );
++ " vs " + formatProjects( projects ), request.getPom() );
}
}
return result;
}
+private String formatProjects( List projects )
+{
+StringBuilder projectNames = new StringBuilder();
+for ( int index = 0, size = projects.size(); index < size; index++ )
+{
+MavenProject project = projects.get( index );
Review comment:
There is additional condition inside loop which appends a colon. This can’t
be done without regular for loop as foreach doesn’t give a way to check if
fetched element is actually the last one.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
