[jira] [Commented] (MSKINS-143) Allow setting anonymizeIP and forceSSL
[ https://issues.apache.org/jira/browse/MSKINS-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494713#comment-16494713 ] Michael Osipov commented on MSKINS-143: --- [~s...@apache.org], correct. It is fully optional. > Allow setting anonymizeIP and forceSSL > -- > > Key: MSKINS-143 > URL: https://issues.apache.org/jira/browse/MSKINS-143 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Affects Versions: fluido-1.7 >Reporter: Jens Reimann >Priority: Blocker > > With the upcoming European GDPR regulations it is necessary to anonymize and > protect tracking data. Using Google Analytics this requires (at least) the > two options to be set: > forceSSL - In order to encrypt data between the browser and the google > infrastructure, whether the actual page is requested by HTTP or HTTPS doesn't > matter > anonymizeIP - In order to anonymize the IP address > Currently the Fluido Skin doesn't allow to set those two options. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MSKINS-143) Allow setting anonymizeIP and forceSSL
[ https://issues.apache.org/jira/browse/MSKINS-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494449#comment-16494449 ] Sebb commented on MSKINS-143: - I assume the Google Analytics code is optional? If it's not possible to configure the GA data collection to ensure it is GDPR-compliant, then at least it can be switched off until such time as there is a solution. > Allow setting anonymizeIP and forceSSL > -- > > Key: MSKINS-143 > URL: https://issues.apache.org/jira/browse/MSKINS-143 > Project: Maven Skins > Issue Type: Bug > Components: Fluido Skin >Affects Versions: fluido-1.7 >Reporter: Jens Reimann >Priority: Blocker > > With the upcoming European GDPR regulations it is necessary to anonymize and > protect tracking data. Using Google Analytics this requires (at least) the > two options to be set: > forceSSL - In order to encrypt data between the browser and the google > infrastructure, whether the actual page is requested by HTTP or HTTPS doesn't > matter > anonymizeIP - In order to anonymize the IP address > Currently the Fluido Skin doesn't allow to set those two options. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider
Tibor17 commented on a change in pull request #184: Donate current sources from
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r191559606
##
File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
##
@@ -0,0 +1,206 @@
+ --
+ Using JUnit Platform
+ --
+ JUnit Lambda Team
+ --
+ 2018-05-14
+ --
+
+ ~~ Licensed to the Apache Software Foundation (ASF) under one
+ ~~ or more contributor license agreements. See the NOTICE file
+ ~~ distributed with this work for additional information
+ ~~ regarding copyright ownership. The ASF licenses this file
+ ~~ to you under the Apache License, Version 2.0 (the
+ ~~ "License"); you may not use this file except in compliance
+ ~~ with the License. You may obtain a copy of the License at
+ ~~
+ ~~ http://www.apache.org/licenses/LICENSE-2.0
+ ~~
+ ~~ Unless required by applicable law or agreed to in writing,
+ ~~ software distributed under the License is distributed on an
+ ~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~~ KIND, either express or implied. See the License for the
+ ~~ specific language governing permissions and limitations
+ ~~ under the License.
+
+ ~~ NOTE: For help with the syntax of this file, see:
+ ~~ http://maven.apache.org/doxia/references/apt-format.html
+
+Using JUnit Platform
+
+* Configuring JUnit Platform
+
+ To get started with JUnit Platform, you need to add at least a single
<<>> implementation
+ to your project. For example, if you want to write tests with Jupiter, you
must add the
+ <<>> to the dependencies like:
+
++---+
+
+ [...]
+
+ org.junit.jupiter
+ junit-jupiter-engine
+ 5.2.0
+ test
+
+ [...]
+
++---+
+
+ This will pull in all required dependencies. Among those dependencies is
<<>> which contains
+ the classes and interfaces your test source requires to compile.
<<>> is also resolved and
+ added.
+
+ This is the only step that is required to get started - you can now create
tests in your test source directory
+ (e.g., <<>>).
+
+ If you want to write and execute JUnit 3 or 4 tests via the JUnit Platform
add the Vintage Engine to your projects'
+ dependencies:
+
++---+
+
+ [...]
+
+ org.junit.vintage
+ junit-vintage-engine
+ 5.2.0
+ test
+
+ [...]
+
++---+
+
+* Provider Selection
+
+ If nothing is configured, Surefire detects which JUnit version to use by
the following algorithm:
+
++---+
+if the JUnit Platform Engine is present in the project
+use junit-platform
+if the JUnit version in the project >= 4.7 and the parallel attribute has ANY
value
+use junit47 provider
+if JUnit >= 4.0 is present
+use junit4 provider
+else
+use junit3.8.1
++---+
+
+ When using this technique there is no check that the proper test-frameworks
are present on your project's
+ classpath. Failing to add the proper test-frameworks will result in a build
failure.
+
+* Running Tests in Parallel
+
+ From JUnit Platform does not support running tests in parallel.
+
+* Running a Single Test Class
+
+ The JUnit Platform Provider supports the <<>> JVM system property
supported by
+ the Maven Surefire Plugin. For example, to run only test methods in the
<<>> test class
+ you can execute <<>> from the command
line.
+
+
+* Filtering by Test Class Names
+
+ The Maven Surefire Plugin will scan for test classes whose fully qualified
names match
+ the following patterns.
+
+ * <<<**/Test*.java>>>
+
+ * <<<**/*Test.java>>>
+
+ * <<<**/*Tests.java>>>
+
+ * <<<**/*TestCase.java>>>
+
+Moreover, it will exclude all nested classes (including static member classes)
by default.
+
+Note, however, that you can override this default behavior by configuring
explicit
+`include` and `exclude` rules in your `pom.xml` file. For example, to keep
Maven Surefire
+from excluding static member classes, you can override its exclude rules.
+
+Overriding exclude rules of Maven Surefire
+
++---+
+...
+
+
+...
+
+maven-surefire-plugin
+{surefire-version}
+
+
+
+
+
+...
+
+
+
+...
++---+
+
+
+* Filtering by Tags
+
+You can filter tests by tags or tag expressions using the following
configuration properties.
+
+* to include <<>> or <<>>, use either <<>>
or <<>>.
+
+* to exclude <<>> or <<>>, use either
<<>> or <<>>.
+
++---+
+...
+
+
+...
+
+maven-surefire-plugin
+{surefire-version}
+
+
+acceptance | !feature-a
Review comment:
@sormuras
Let's go to the IRC chat.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For
[jira] [Commented] (MPMD-261) Upgrade to PMD 6.4.0
[ https://issues.apache.org/jira/browse/MPMD-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494064#comment-16494064 ] Hudson commented on MPMD-261: - Build succeeded in Jenkins: Maven TLP » maven-pmd-plugin » master #33 See https://builds.apache.org/job/maven-box/job/maven-pmd-plugin/job/master/33/ > Upgrade to PMD 6.4.0 > > > Key: MPMD-261 > URL: https://issues.apache.org/jira/browse/MPMD-261 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Affects Versions: 3.9.0 >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.10.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPMD-264) Add rule priority to HTML report
[ https://issues.apache.org/jira/browse/MPMD-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494065#comment-16494065 ] Hudson commented on MPMD-264: - Build succeeded in Jenkins: Maven TLP » maven-pmd-plugin » master #33 See https://builds.apache.org/job/maven-box/job/maven-pmd-plugin/job/master/33/ > Add rule priority to HTML report > > > Key: MPMD-264 > URL: https://issues.apache.org/jira/browse/MPMD-264 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: PMD >Affects Versions: 3.9.0 >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.10.0 > > > When the site and the PMD report is generated, the rule priorities are > missing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MPMD-264) Add rule priority to HTML report
[ https://issues.apache.org/jira/browse/MPMD-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel closed MPMD-264. --- Resolution: Fixed > Add rule priority to HTML report > > > Key: MPMD-264 > URL: https://issues.apache.org/jira/browse/MPMD-264 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: PMD >Affects Versions: 3.9.0 >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.10.0 > > > When the site and the PMD report is generated, the rule priorities are > missing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MPMD-261) Upgrade to PMD 6.4.0
[ https://issues.apache.org/jira/browse/MPMD-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-261: Summary: Upgrade to PMD 6.4.0 (was: Upgrade to PMD 6.3.0) > Upgrade to PMD 6.4.0 > > > Key: MPMD-261 > URL: https://issues.apache.org/jira/browse/MPMD-261 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: CPD, PMD >Affects Versions: 3.9.0 >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.10.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on a change in pull request #184: Donate current sources
from junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r191527237
##
File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
##
@@ -0,0 +1,206 @@
+ --
+ Using JUnit Platform
+ --
+ JUnit Lambda Team
+ --
+ 2018-05-14
+ --
+
+ ~~ Licensed to the Apache Software Foundation (ASF) under one
+ ~~ or more contributor license agreements. See the NOTICE file
+ ~~ distributed with this work for additional information
+ ~~ regarding copyright ownership. The ASF licenses this file
+ ~~ to you under the Apache License, Version 2.0 (the
+ ~~ "License"); you may not use this file except in compliance
+ ~~ with the License. You may obtain a copy of the License at
+ ~~
+ ~~ http://www.apache.org/licenses/LICENSE-2.0
+ ~~
+ ~~ Unless required by applicable law or agreed to in writing,
+ ~~ software distributed under the License is distributed on an
+ ~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~~ KIND, either express or implied. See the License for the
+ ~~ specific language governing permissions and limitations
+ ~~ under the License.
+
+ ~~ NOTE: For help with the syntax of this file, see:
+ ~~ http://maven.apache.org/doxia/references/apt-format.html
+
+Using JUnit Platform
+
+* Configuring JUnit Platform
+
+ To get started with JUnit Platform, you need to add at least a single
<<>> implementation
+ to your project. For example, if you want to write tests with Jupiter, you
must add the
+ <<>> to the dependencies like:
+
++---+
+
+ [...]
+
+ org.junit.jupiter
+ junit-jupiter-engine
+ 5.2.0
+ test
+
+ [...]
+
++---+
+
+ This will pull in all required dependencies. Among those dependencies is
<<>> which contains
+ the classes and interfaces your test source requires to compile.
<<>> is also resolved and
+ added.
+
+ This is the only step that is required to get started - you can now create
tests in your test source directory
+ (e.g., <<>>).
+
+ If you want to write and execute JUnit 3 or 4 tests via the JUnit Platform
add the Vintage Engine to your projects'
+ dependencies:
+
++---+
+
+ [...]
+
+ org.junit.vintage
+ junit-vintage-engine
+ 5.2.0
+ test
+
+ [...]
+
++---+
+
+* Provider Selection
+
+ If nothing is configured, Surefire detects which JUnit version to use by
the following algorithm:
+
++---+
+if the JUnit Platform Engine is present in the project
+use junit-platform
+if the JUnit version in the project >= 4.7 and the parallel attribute has ANY
value
+use junit47 provider
+if JUnit >= 4.0 is present
+use junit4 provider
+else
+use junit3.8.1
++---+
+
+ When using this technique there is no check that the proper test-frameworks
are present on your project's
+ classpath. Failing to add the proper test-frameworks will result in a build
failure.
+
+* Running Tests in Parallel
+
+ From JUnit Platform does not support running tests in parallel.
+
+* Running a Single Test Class
+
+ The JUnit Platform Provider supports the <<>> JVM system property
supported by
+ the Maven Surefire Plugin. For example, to run only test methods in the
<<>> test class
+ you can execute <<>> from the command
line.
+
+
+* Filtering by Test Class Names
+
+ The Maven Surefire Plugin will scan for test classes whose fully qualified
names match
+ the following patterns.
+
+ * <<<**/Test*.java>>>
+
+ * <<<**/*Test.java>>>
+
+ * <<<**/*Tests.java>>>
+
+ * <<<**/*TestCase.java>>>
+
+Moreover, it will exclude all nested classes (including static member classes)
by default.
+
+Note, however, that you can override this default behavior by configuring
explicit
+`include` and `exclude` rules in your `pom.xml` file. For example, to keep
Maven Surefire
+from excluding static member classes, you can override its exclude rules.
+
+Overriding exclude rules of Maven Surefire
+
++---+
+...
+
+
+...
+
+maven-surefire-plugin
+{surefire-version}
+
+
+
+
+
+...
+
+
+
+...
++---+
+
+
+* Filtering by Tags
+
+You can filter tests by tags or tag expressions using the following
configuration properties.
+
+* to include <<>> or <<>>, use either <<>>
or <<>>.
+
+* to exclude <<>> or <<>>, use either
<<>> or <<>>.
+
++---+
+...
+
+
+...
+
+maven-surefire-plugin
+{surefire-version}
+
+
+acceptance | !feature-a
Review comment:
The tags (include and exclude) are passed as filters to the
`org.apache.maven.surefire.junitplatform.TestPlanScannerFilter` in line:
https://github.com/apache/maven-surefire/pull/184/files#diff-b3a2904e92be87f11f2622fbfd122e31R137
The filters are generated
[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider
Tibor17 commented on a change in pull request #184: Donate current sources from
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r191524942
##
File path: maven-surefire-plugin/src/site/apt/examples/junit-platform.apt.vm
##
@@ -0,0 +1,206 @@
+ --
+ Using JUnit Platform
+ --
+ JUnit Lambda Team
+ --
+ 2018-05-14
+ --
+
+ ~~ Licensed to the Apache Software Foundation (ASF) under one
+ ~~ or more contributor license agreements. See the NOTICE file
+ ~~ distributed with this work for additional information
+ ~~ regarding copyright ownership. The ASF licenses this file
+ ~~ to you under the Apache License, Version 2.0 (the
+ ~~ "License"); you may not use this file except in compliance
+ ~~ with the License. You may obtain a copy of the License at
+ ~~
+ ~~ http://www.apache.org/licenses/LICENSE-2.0
+ ~~
+ ~~ Unless required by applicable law or agreed to in writing,
+ ~~ software distributed under the License is distributed on an
+ ~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ ~~ KIND, either express or implied. See the License for the
+ ~~ specific language governing permissions and limitations
+ ~~ under the License.
+
+ ~~ NOTE: For help with the syntax of this file, see:
+ ~~ http://maven.apache.org/doxia/references/apt-format.html
+
+Using JUnit Platform
+
+* Configuring JUnit Platform
+
+ To get started with JUnit Platform, you need to add at least a single
<<>> implementation
+ to your project. For example, if you want to write tests with Jupiter, you
must add the
+ <<>> to the dependencies like:
+
++---+
+
+ [...]
+
+ org.junit.jupiter
+ junit-jupiter-engine
+ 5.2.0
+ test
+
+ [...]
+
++---+
+
+ This will pull in all required dependencies. Among those dependencies is
<<>> which contains
+ the classes and interfaces your test source requires to compile.
<<>> is also resolved and
+ added.
+
+ This is the only step that is required to get started - you can now create
tests in your test source directory
+ (e.g., <<>>).
+
+ If you want to write and execute JUnit 3 or 4 tests via the JUnit Platform
add the Vintage Engine to your projects'
+ dependencies:
+
++---+
+
+ [...]
+
+ org.junit.vintage
+ junit-vintage-engine
+ 5.2.0
+ test
+
+ [...]
+
++---+
+
+* Provider Selection
+
+ If nothing is configured, Surefire detects which JUnit version to use by
the following algorithm:
+
++---+
+if the JUnit Platform Engine is present in the project
+use junit-platform
+if the JUnit version in the project >= 4.7 and the parallel attribute has ANY
value
+use junit47 provider
+if JUnit >= 4.0 is present
+use junit4 provider
+else
+use junit3.8.1
++---+
+
+ When using this technique there is no check that the proper test-frameworks
are present on your project's
+ classpath. Failing to add the proper test-frameworks will result in a build
failure.
+
+* Running Tests in Parallel
+
+ From JUnit Platform does not support running tests in parallel.
+
+* Running a Single Test Class
+
+ The JUnit Platform Provider supports the <<>> JVM system property
supported by
+ the Maven Surefire Plugin. For example, to run only test methods in the
<<>> test class
+ you can execute <<>> from the command
line.
+
+
+* Filtering by Test Class Names
+
+ The Maven Surefire Plugin will scan for test classes whose fully qualified
names match
+ the following patterns.
+
+ * <<<**/Test*.java>>>
+
+ * <<<**/*Test.java>>>
+
+ * <<<**/*Tests.java>>>
+
+ * <<<**/*TestCase.java>>>
+
+Moreover, it will exclude all nested classes (including static member classes)
by default.
+
+Note, however, that you can override this default behavior by configuring
explicit
+`include` and `exclude` rules in your `pom.xml` file. For example, to keep
Maven Surefire
+from excluding static member classes, you can override its exclude rules.
+
+Overriding exclude rules of Maven Surefire
+
++---+
+...
+
+
+...
+
+maven-surefire-plugin
+{surefire-version}
+
+
+
+
+
+...
+
+
+
+...
++---+
+
+
+* Filtering by Tags
+
+You can filter tests by tags or tag expressions using the following
configuration properties.
+
+* to include <<>> or <<>>, use either <<>>
or <<>>.
+
+* to exclude <<>> or <<>>, use either
<<>> or <<>>.
+
++---+
+...
+
+
+...
+
+maven-surefire-plugin
+{surefire-version}
+
+
+acceptance | !feature-a
Review comment:
Yes we have to use `groups` and `excludegroups`. I think this can be solved
fast. The `includeTags` looks like system property. The provider observes these
properties in constructor.
The only missing information is the mechanism how you can set `includeTags`
via
[jira] [Updated] (MPMD-264) Add rule priority to HTML report
[ https://issues.apache.org/jira/browse/MPMD-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-264: Fix Version/s: 3.10.0 > Add rule priority to HTML report > > > Key: MPMD-264 > URL: https://issues.apache.org/jira/browse/MPMD-264 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: PMD >Affects Versions: 3.9.0 >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.10.0 > > > When the site and the PMD report is generated, the rule priorities are > missing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPMD-264) Add rule priority to HTML report
[
https://issues.apache.org/jira/browse/MPMD-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493965#comment-16493965
]
Andreas Dangel commented on MPMD-264:
-
By default, the rule priorities are included in the report from now on.
There is a new parameter, with which the old behavior can be restored:
{{-Dpmd.renderRuleViolationPriority=false}}
> Add rule priority to HTML report
>
>
> Key: MPMD-264
> URL: https://issues.apache.org/jira/browse/MPMD-264
> Project: Maven PMD Plugin
> Issue Type: Improvement
> Components: PMD
>Affects Versions: 3.9.0
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
>
> When the site and the PMD report is generated, the rule priorities are
> missing.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MPMD-264) Add rule priority in HTML output format
[ https://issues.apache.org/jira/browse/MPMD-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel reassigned MPMD-264: --- Assignee: Andreas Dangel > Add rule priority in HTML output format > --- > > Key: MPMD-264 > URL: https://issues.apache.org/jira/browse/MPMD-264 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: PMD >Affects Versions: 3.9.0 >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > > When the site and the PMD report is generated, the rule priorities are > missing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MPMD-264) Add rule priority to HTML report
[ https://issues.apache.org/jira/browse/MPMD-264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-264: Summary: Add rule priority to HTML report (was: Add rule priority in HTML output format) > Add rule priority to HTML report > > > Key: MPMD-264 > URL: https://issues.apache.org/jira/browse/MPMD-264 > Project: Maven PMD Plugin > Issue Type: Improvement > Components: PMD >Affects Versions: 3.9.0 >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > > When the site and the PMD report is generated, the rule priorities are > missing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MPMD-264) Add rule priority in HTML output format
Andreas Dangel created MPMD-264: --- Summary: Add rule priority in HTML output format Key: MPMD-264 URL: https://issues.apache.org/jira/browse/MPMD-264 Project: Maven PMD Plugin Issue Type: Improvement Components: PMD Affects Versions: 3.9.0 Reporter: Andreas Dangel When the site and the PMD report is generated, the rule priorities are missing. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1457) trimStackTrace should be disabled by default
[
https://issues.apache.org/jira/browse/SUREFIRE-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493372#comment-16493372
]
Tibor Digana commented on SUREFIRE-1457:
We will finish version 2.22.0 where we implement JUnit5. After this release
we do not want to prolong 2.x anymore and jump to 3.0 release candidate.
There we have a chance to alter behavior.
On Tue, May 29, 2018 at 11:57 AM, Mark Struberg (JIRA)
> trimStackTrace should be disabled by default
>
>
> Key: SUREFIRE-1457
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1457
> Project: Maven Surefire
> Issue Type: Improvement
>Affects Versions: 2.21.2
>Reporter: Réda Housni Alaoui
>Assignee: Tibor Digana
>Priority: Critical
>
> We are using Jenkins at work.
> Each time we had test failures, stack trace were incomplete and therefore
> totally useless.
> I just discovered {{trimStackTrace}} option.
> IMO, the fact that this option is currently enabled by default is a total non
> sense.
> Now we have to change the pom.xml of every projects of the company to have a
> correct default.
> IMO, and I think I am not the only one here, trimStackTrace should be
> disabled by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1330) JUnit 5 surefire-provider code donation
[ https://issues.apache.org/jira/browse/SUREFIRE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493355#comment-16493355 ] Christian Stein commented on SUREFIRE-1330: --- Sounds great! Cheers! > JUnit 5 surefire-provider code donation > --- > > Key: SUREFIRE-1330 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1330 > Project: Maven Surefire > Issue Type: New Feature >Reporter: Benedikt Ritter >Assignee: Tibor Digana >Priority: Major > Labels: junit5 > Fix For: 2.22.0 > > Attachments: junit-platform-surefire-provider.zip > > > The JUnit team wishes to contribute their surefire provider implementation > for JUnit 5 to the Maven team. > The code is currently located at GitHub: > https://github.com/junit-team/junit5/tree/master/junit-platform-surefire-provider > They have recently relicensed the code under terms of Apache License 2.0: > https://github.com/junit-team/junit5/issues/541 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SUREFIRE-1330) JUnit 5 surefire-provider code donation
[ https://issues.apache.org/jira/browse/SUREFIRE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493342#comment-16493342 ] Tibor Digana edited comment on SUREFIRE-1330 at 5/29/18 10:38 AM: -- [~sor] I will come home and I will go to the PR on GitHub and I will continue. was (Author: tibor17): [~sor] I will come how and I will go to the PR on GitHub and I will continue. > JUnit 5 surefire-provider code donation > --- > > Key: SUREFIRE-1330 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1330 > Project: Maven Surefire > Issue Type: New Feature >Reporter: Benedikt Ritter >Assignee: Tibor Digana >Priority: Major > Labels: junit5 > Fix For: 2.22.0 > > Attachments: junit-platform-surefire-provider.zip > > > The JUnit team wishes to contribute their surefire provider implementation > for JUnit 5 to the Maven team. > The code is currently located at GitHub: > https://github.com/junit-team/junit5/tree/master/junit-platform-surefire-provider > They have recently relicensed the code under terms of Apache License 2.0: > https://github.com/junit-team/junit5/issues/541 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1330) JUnit 5 surefire-provider code donation
[ https://issues.apache.org/jira/browse/SUREFIRE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493342#comment-16493342 ] Tibor Digana commented on SUREFIRE-1330: [~sor] I will come how and I will go to the PR on GitHub and I will continue. > JUnit 5 surefire-provider code donation > --- > > Key: SUREFIRE-1330 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1330 > Project: Maven Surefire > Issue Type: New Feature >Reporter: Benedikt Ritter >Assignee: Tibor Digana >Priority: Major > Labels: junit5 > Fix For: 2.22.0 > > Attachments: junit-platform-surefire-provider.zip > > > The JUnit team wishes to contribute their surefire provider implementation > for JUnit 5 to the Maven team. > The code is currently located at GitHub: > https://github.com/junit-team/junit5/tree/master/junit-platform-surefire-provider > They have recently relicensed the code under terms of Apache License 2.0: > https://github.com/junit-team/junit5/issues/541 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SUREFIRE-1457) trimStackTrace should be disabled by default
[
https://issues.apache.org/jira/browse/SUREFIRE-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493318#comment-16493318
]
Mark Struberg edited comment on SUREFIRE-1457 at 5/29/18 9:56 AM:
--
+1 to disable it and go back to the original behaviour (which means to print
all the stack trace as it was in maven 1, 2 and earlier in maven 3 days).
was (Author: struberg):
+1 to disable it and go back to the original behaviour.
> trimStackTrace should be disabled by default
>
>
> Key: SUREFIRE-1457
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1457
> Project: Maven Surefire
> Issue Type: Improvement
>Affects Versions: 2.21.2
>Reporter: Réda Housni Alaoui
>Assignee: Tibor Digana
>Priority: Critical
>
> We are using Jenkins at work.
> Each time we had test failures, stack trace were incomplete and therefore
> totally useless.
> I just discovered {{trimStackTrace}} option.
> IMO, the fact that this option is currently enabled by default is a total non
> sense.
> Now we have to change the pom.xml of every projects of the company to have a
> correct default.
> IMO, and I think I am not the only one here, trimStackTrace should be
> disabled by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1457) trimStackTrace should be disabled by default
[
https://issues.apache.org/jira/browse/SUREFIRE-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493318#comment-16493318
]
Mark Struberg commented on SUREFIRE-1457:
-
+1 to disable it and go back to the original behaviour.
> trimStackTrace should be disabled by default
>
>
> Key: SUREFIRE-1457
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1457
> Project: Maven Surefire
> Issue Type: Improvement
>Affects Versions: 2.21.2
>Reporter: Réda Housni Alaoui
>Assignee: Tibor Digana
>Priority: Critical
>
> We are using Jenkins at work.
> Each time we had test failures, stack trace were incomplete and therefore
> totally useless.
> I just discovered {{trimStackTrace}} option.
> IMO, the fact that this option is currently enabled by default is a total non
> sense.
> Now we have to change the pom.xml of every projects of the company to have a
> correct default.
> IMO, and I think I am not the only one here, trimStackTrace should be
> disabled by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1457) trimStackTrace should be disabled by default
[
https://issues.apache.org/jira/browse/SUREFIRE-1457?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493220#comment-16493220
]
Arjan Tijms commented on SUREFIRE-1457:
---
+1 for disabling `trimStackTrace` by default.
How would changing the default exactly break compatibility? Are there tools out
there that parse the log and expect a trimmed stack trace?
> trimStackTrace should be disabled by default
>
>
> Key: SUREFIRE-1457
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1457
> Project: Maven Surefire
> Issue Type: Improvement
>Affects Versions: 2.21.2
>Reporter: Réda Housni Alaoui
>Assignee: Tibor Digana
>Priority: Critical
>
> We are using Jenkins at work.
> Each time we had test failures, stack trace were incomplete and therefore
> totally useless.
> I just discovered {{trimStackTrace}} option.
> IMO, the fact that this option is currently enabled by default is a total non
> sense.
> Now we have to change the pom.xml of every projects of the company to have a
> correct default.
> IMO, and I think I am not the only one here, trimStackTrace should be
> disabled by default.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
