[jira] [Commented] (MASSEMBLY-889) Maven assembly not able to handle large capacity .tar.gz packaging
[ https://issues.apache.org/jira/browse/MASSEMBLY-889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502489#comment-16502489 ] Sriram Kotni commented on MASSEMBLY-889: I will try latest version and see if it helps. Thanks, --Sriram > Maven assembly not able to handle large capacity .tar.gz packaging > -- > > Key: MASSEMBLY-889 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-889 > Project: Maven Assembly Plugin > Issue Type: Bug >Affects Versions: 2.4 > Environment: Linux >Reporter: Sriram Kotni >Priority: Major > Labels: maven > Original Estimate: 0h > Remaining Estimate: 0h > > We are using Maven assembly to tar.gz file size of 2.5 gb is not able to > handle. Because of this we are not able support multi language Knowledge Base > support. There is a big impact for our business. > Any suggestions and alternate solutions are appreciated. > > Thanks, > Sriram -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCM-805) Add SVN --pin-externals option to copy command (branch/tag)
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16502187#comment-16502187 ] ASF GitHub Bot commented on SCM-805: michael-o commented on issue #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#issuecomment-394797532 Alright, take your time. Have a look at it. I am not really firm with the tests too. The given code looks nice now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add SVN --pin-externals option to copy command (branch/tag) > --- > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn >Affects Versions: 1.9.5 > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra >Assignee: Michael Osipov >Priority: Major > Labels: externals, svn, tag > Fix For: 1.10.1 > > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] michael-o commented on issue #55: Fix for SCM-805
michael-o commented on issue #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#issuecomment-394797532 Alright, take your time. Have a look at it. I am not really firm with the tests too. The given code looks nice now. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SCM-805) Add SVN --pin-externals option to copy command (branch/tag)
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501853#comment-16501853 ] ASF GitHub Bot commented on SCM-805: theit commented on issue #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#issuecomment-394726709 The actual pull request is already based against the master repository. Concerning your second question: Sure, why not. Testing and verifying this new feature is certainly good. Although I have to admit that I haven't looked much into how the tests in `maven-scm-provider-svntest` work... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add SVN --pin-externals option to copy command (branch/tag) > --- > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn >Affects Versions: 1.9.5 > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra >Assignee: Michael Osipov >Priority: Major > Labels: externals, svn, tag > Fix For: 1.10.1 > > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] theit commented on issue #55: Fix for SCM-805
theit commented on issue #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#issuecomment-394726709 The actual pull request is already based against the master repository. Concerning your second question: Sure, why not. Testing and verifying this new feature is certainly good. Although I have to admit that I haven't looked much into how the tests in `maven-scm-provider-svntest` work... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (MDEP-609) Dependency analyzer gets confused if the same package is defined in 2 different artifacts
[
https://issues.apache.org/jira/browse/MDEP-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501643#comment-16501643
]
Seckin Onur SELAMET edited comment on MDEP-609 at 6/5/18 12:22 PM:
---
* This issue can be related with MNG-6415 under some conditions but with this
analysis it is not the case. I used a fixed maven version.
* The reported behavior is still observable. It is related with how classpath
is constructed. _*Dependency plugin is not the root cause.*_
I used a modified pom file for project 2 to have one more level ( for more
visible distance) in the dependency tree.
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
test
project2
1.0.0-SNAPSHOT
org.mockito
mockito-core
1.9.5
{code}
TREE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:tree (default-cli) @ project1 ---
[INFO] test:project1:jar:1.0.0-SNAPSHOT
[INFO] +- test:project2:jar:1.0.0-SNAPSHOT:compile
[INFO] | \- org.mockito:mockito-core:jar:1.9.5:compile
[INFO] | +- org.hamcrest:hamcrest-core:jar:1.1:compile
[INFO] | \- org.objenesis:objenesis:jar:1.0:compile
[INFO] \- org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
ANALYZE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:analyze (default-cli) @ project1 ---
[WARNING] Used undeclared dependencies found:
[WARNING]org.hamcrest:hamcrest-core:jar:1.1:compile
[WARNING] Unused declared dependencies found:
[WARNING]test:project2:jar:1.0.0-SNAPSHOT:compile
[WARNING]org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
CLASSPATH (took the testCompile classpath on purpose to see it was affected by
MNG-6415 or not)
{noformat}
[DEBUG] Classpath:
[DEBUG] C:\dev\dummy\P1\target\test-classes
[DEBUG] C:\dev\dummy\P1\target\classes
[DEBUG]
C:\dev\Java\maven_repo\test\project2\1.0.0-SNAPSHOT\project2-1.0.0-SNAPSHOT.jar
[DEBUG]
C:\dev\Java\maven_repo\org\mockito\mockito-core\1.9.5\mockito-core-1.9.5.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-core\1.1\hamcrest-core-1.1.jar
[DEBUG] C:\dev\Java\maven_repo\org\objenesis\objenesis\1.0\objenesis-1.0.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-all\1.1\hamcrest-all-1.1.jar
{noformat}
Under these conditions dependency plugin is just reporting it correctly. :)
The implementation for IsEqual class is provided by hamcrest-core-1.1.jar
because hamcrest-core-1.1.jar is the earliest entry in the classpath that has
IsEqual class.
Edit : Some typos.
was (Author: soselamet):
* This issue can be related with MNG-6415 under some conditions but with this
analysis it is not the case. I used a fixed maven version.
* The reported behavior is still observable. It is related with how classpath
constructed. _*Dependency plugin is not the root cause.*_
I used a modified pom file for project 2 to have one more level ( for more
visible distance) in the dependency tree.
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
test
project2
1.0.0-SNAPSHOT
org.mockito
mockito-core
1.9.5
{code}
TREE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:tree (default-cli) @ project1 ---
[INFO] test:project1:jar:1.0.0-SNAPSHOT
[INFO] +- test:project2:jar:1.0.0-SNAPSHOT:compile
[INFO] | \- org.mockito:mockito-core:jar:1.9.5:compile
[INFO] | +- org.hamcrest:hamcrest-core:jar:1.1:compile
[INFO] | \- org.objenesis:objenesis:jar:1.0:compile
[INFO] \- org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
ANALYZE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:analyze (default-cli) @ project1 ---
[WARNING] Used undeclared dependencies found:
[WARNING]org.hamcrest:hamcrest-core:jar:1.1:compile
[WARNING] Unused declared dependencies found:
[WARNING]test:project2:jar:1.0.0-SNAPSHOT:compile
[WARNING]org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
CLASSPATH (took the testCompile classpath on purpose to see it was affected by
MNG-6415 or not)
{noformat}
[DEBUG] Classpath:
[DEBUG] C:\dev\dummy\P1\target\test-classes
[DEBUG] C:\dev\dummy\P1\target\classes
[DEBUG]
C:\dev\Java\maven_repo\test\project2\1.0.0-SNAPSHOT\project2-1.0.0-SNAPSHOT.jar
[DEBUG]
C:\dev\Java\maven_repo\org\mockito\mockito-core\1.9.5\mockito-core-1.9.5.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-core\1.1\hamcrest-core-1.1.jar
[DEBUG] C:\dev\Java\maven_repo\org\objenesis\objenesis\1.0\objenesis-1.0.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-all\1.1\hamcrest-all-1.1.jar
{noformat}
Under these
[jira] [Comment Edited] (MDEP-609) Dependency analyzer gets confused if the same package is defined in 2 different artifacts
[
https://issues.apache.org/jira/browse/MDEP-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501643#comment-16501643
]
Seckin Onur SELAMET edited comment on MDEP-609 at 6/5/18 12:22 PM:
---
* This issue can be related with MNG-6415 under some conditions but with this
analysis it is not the case. I used a fixed maven version.
* The reported behavior is still observable. It is related with how classpath
constructed. _*Dependency plugin is not the root cause.*_
I used a modified pom file for project 2 to have one more level ( for more
visible distance) in the dependency tree.
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
test
project2
1.0.0-SNAPSHOT
org.mockito
mockito-core
1.9.5
{code}
TREE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:tree (default-cli) @ project1 ---
[INFO] test:project1:jar:1.0.0-SNAPSHOT
[INFO] +- test:project2:jar:1.0.0-SNAPSHOT:compile
[INFO] | \- org.mockito:mockito-core:jar:1.9.5:compile
[INFO] | +- org.hamcrest:hamcrest-core:jar:1.1:compile
[INFO] | \- org.objenesis:objenesis:jar:1.0:compile
[INFO] \- org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
ANALYZE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:analyze (default-cli) @ project1 ---
[WARNING] Used undeclared dependencies found:
[WARNING]org.hamcrest:hamcrest-core:jar:1.1:compile
[WARNING] Unused declared dependencies found:
[WARNING]test:project2:jar:1.0.0-SNAPSHOT:compile
[WARNING]org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
CLASSPATH (took the testCompile classpath on purpose to see it was affected by
MNG-6415 or not)
{noformat}
[DEBUG] Classpath:
[DEBUG] C:\dev\dummy\P1\target\test-classes
[DEBUG] C:\dev\dummy\P1\target\classes
[DEBUG]
C:\dev\Java\maven_repo\test\project2\1.0.0-SNAPSHOT\project2-1.0.0-SNAPSHOT.jar
[DEBUG]
C:\dev\Java\maven_repo\org\mockito\mockito-core\1.9.5\mockito-core-1.9.5.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-core\1.1\hamcrest-core-1.1.jar
[DEBUG] C:\dev\Java\maven_repo\org\objenesis\objenesis\1.0\objenesis-1.0.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-all\1.1\hamcrest-all-1.1.jar
{noformat}
Under these conditions dependency plugin is just reporting it correctly. :)
The implementation for IsEqual class is provided by hamcrest-core-1.1.jar
because hamcrest-core-1.1.jar is the earliest entry in the classpath that has
IsEqual class.
Edit : Some typos.
was (Author: soselamet):
* This issue can be related with MNG-6415 under some conditions but with this
analysis it is not the case. I used a fixed maven version.
* The reported behavior still observable. It is related with how classpath
constructed. _*Dependency plugin is not the root cause.*_
I used a modified pom file for project 2 to have one more level ( for more
visible distance) in the dependency tree.
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
test
project2
1.0.0-SNAPSHOT
org.mockito
mockito-core
1.9.5
{code}
TREE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:tree (default-cli) @ project1 ---
[INFO] test:project1:jar:1.0.0-SNAPSHOT
[INFO] +- test:project2:jar:1.0.0-SNAPSHOT:compile
[INFO] | \- org.mockito:mockito-core:jar:1.9.5:compile
[INFO] | +- org.hamcrest:hamcrest-core:jar:1.1:compile
[INFO] | \- org.objenesis:objenesis:jar:1.0:compile
[INFO] \- org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
ANALYZE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:analyze (default-cli) @ project1 ---
[WARNING] Used undeclared dependencies found:
[WARNING]org.hamcrest:hamcrest-core:jar:1.1:compile
[WARNING] Unused declared dependencies found:
[WARNING]test:project2:jar:1.0.0-SNAPSHOT:compile
[WARNING]org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
CLASSPATH (took the testCompile classpath on purpose to see it was affected by
MNG-6415 or not)
{noformat}
[DEBUG] Classpath:
[DEBUG] C:\dev\dummy\P1\target\test-classes
[DEBUG] C:\dev\dummy\P1\target\classes
[DEBUG]
C:\dev\Java\maven_repo\test\project2\1.0.0-SNAPSHOT\project2-1.0.0-SNAPSHOT.jar
[DEBUG]
C:\dev\Java\maven_repo\org\mockito\mockito-core\1.9.5\mockito-core-1.9.5.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-core\1.1\hamcrest-core-1.1.jar
[DEBUG] C:\dev\Java\maven_repo\org\objenesis\objenesis\1.0\objenesis-1.0.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-all\1.1\hamcrest-all-1.1.jar
{noformat}
Under these conditions
[jira] [Comment Edited] (MDEP-609) Dependency analyzer gets confused if the same package is defined in 2 different artifacts
[
https://issues.apache.org/jira/browse/MDEP-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501643#comment-16501643
]
Seckin Onur SELAMET edited comment on MDEP-609 at 6/5/18 11:55 AM:
---
* This issue can be related with MNG-6415 under some conditions but with this
analysis it is not the case. I used a fixed maven version.
* The reported behavior still observable. It is related with how classpath
constructed. _*Dependency plugin is not the root cause.*_
I used a modified pom file for project 2 to have one more level ( for more
visible distance) in the dependency tree.
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
test
project2
1.0.0-SNAPSHOT
org.mockito
mockito-core
1.9.5
{code}
TREE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:tree (default-cli) @ project1 ---
[INFO] test:project1:jar:1.0.0-SNAPSHOT
[INFO] +- test:project2:jar:1.0.0-SNAPSHOT:compile
[INFO] | \- org.mockito:mockito-core:jar:1.9.5:compile
[INFO] | +- org.hamcrest:hamcrest-core:jar:1.1:compile
[INFO] | \- org.objenesis:objenesis:jar:1.0:compile
[INFO] \- org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
ANALYZE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:analyze (default-cli) @ project1 ---
[WARNING] Used undeclared dependencies found:
[WARNING]org.hamcrest:hamcrest-core:jar:1.1:compile
[WARNING] Unused declared dependencies found:
[WARNING]test:project2:jar:1.0.0-SNAPSHOT:compile
[WARNING]org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
CLASSPATH (took the testCompile classpath on purpose to see it was affected by
MNG-6415 or not)
{noformat}
[DEBUG] Classpath:
[DEBUG] C:\dev\dummy\P1\target\test-classes
[DEBUG] C:\dev\dummy\P1\target\classes
[DEBUG]
C:\dev\Java\maven_repo\test\project2\1.0.0-SNAPSHOT\project2-1.0.0-SNAPSHOT.jar
[DEBUG]
C:\dev\Java\maven_repo\org\mockito\mockito-core\1.9.5\mockito-core-1.9.5.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-core\1.1\hamcrest-core-1.1.jar
[DEBUG] C:\dev\Java\maven_repo\org\objenesis\objenesis\1.0\objenesis-1.0.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-all\1.1\hamcrest-all-1.1.jar
{noformat}
Under these conditions dependency plugin is just reporting it correctly. :)
The implementation for IsEqual class is provided by hamcrest-core-1.1.jar
because hamcrest-core-1.1.jar is the earliest entry in the classpath that has
IsEqual class.
was (Author: soselamet):
* This issue can be related with MNG-6415 under some conditions but with this
analysis it is not the case. I used a fixed maven version.
* The reported behavior still observable. It is related with how classpath
constructed. _*Dependency plugin is not the root cause.*_
I used a modified pom file for project 2 to have one more level ( for more
visible distance) in the dependency tree.
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
test
project2
1.0.0-SNAPSHOT
org.mockito
mockito-core
1.9.5
{code}
TREE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:tree (default-cli) @ project1 ---
[INFO] test:project1:jar:1.0.0-SNAPSHOT
[INFO] +- test:project2:jar:1.0.0-SNAPSHOT:compile
[INFO] | \- org.mockito:mockito-core:jar:1.9.5:compile
[INFO] | +- org.hamcrest:hamcrest-core:jar:1.1:compile
[INFO] | \- org.objenesis:objenesis:jar:1.0:compile
[INFO] \- org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
ANALYZE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:analyze (default-cli) @ project1 ---
[WARNING] Used undeclared dependencies found:
[WARNING]org.hamcrest:hamcrest-core:jar:1.1:compile
[WARNING] Unused declared dependencies found:
[WARNING]test:project2:jar:1.0.0-SNAPSHOT:compile
[WARNING]org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
CLASSPATH (took the testCompile classpath on purpose to see it was affected by
MNG-6415 or not)
{noformat}
[DEBUG] Classpath:
[DEBUG] C:\dev\dummy\P1\target\test-classes
[DEBUG] C:\dev\dummy\P1\target\classes
[DEBUG]
C:\dev\Java\maven_repo\test\project2\1.0.0-SNAPSHOT\project2-1.0.0-SNAPSHOT.jar
[DEBUG]
C:\dev\Java\maven_repo\org\mockito\mockito-core\1.9.5\mockito-core-1.9.5.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-core\1.1\hamcrest-core-1.1.jar
[DEBUG] C:\dev\Java\maven_repo\org\objenesis\objenesis\1.0\objenesis-1.0.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-all\1.1\hamcrest-all-1.1.jar
{noformat}
Under this conditions dependency plugin is just
[jira] [Comment Edited] (MDEP-609) Dependency analyzer gets confused if the same package is defined in 2 different artifacts
[
https://issues.apache.org/jira/browse/MDEP-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501643#comment-16501643
]
Seckin Onur SELAMET edited comment on MDEP-609 at 6/5/18 11:55 AM:
---
* This issue can be related with MNG-6415 under some conditions but with this
analysis it is not the case. I used a fixed maven version.
* The reported behavior still observable. It is related with how classpath
constructed. _*Dependency plugin is not the root cause.*_
I used a modified pom file for project 2 to have one more level ( for more
visible distance) in the dependency tree.
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
test
project2
1.0.0-SNAPSHOT
org.mockito
mockito-core
1.9.5
{code}
TREE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:tree (default-cli) @ project1 ---
[INFO] test:project1:jar:1.0.0-SNAPSHOT
[INFO] +- test:project2:jar:1.0.0-SNAPSHOT:compile
[INFO] | \- org.mockito:mockito-core:jar:1.9.5:compile
[INFO] | +- org.hamcrest:hamcrest-core:jar:1.1:compile
[INFO] | \- org.objenesis:objenesis:jar:1.0:compile
[INFO] \- org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
ANALYZE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:analyze (default-cli) @ project1 ---
[WARNING] Used undeclared dependencies found:
[WARNING]org.hamcrest:hamcrest-core:jar:1.1:compile
[WARNING] Unused declared dependencies found:
[WARNING]test:project2:jar:1.0.0-SNAPSHOT:compile
[WARNING]org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
CLASSPATH (took the testCompile classpath on purpose to see it was affected by
MNG-6415 or not)
{noformat}
[DEBUG] Classpath:
[DEBUG] C:\dev\dummy\P1\target\test-classes
[DEBUG] C:\dev\dummy\P1\target\classes
[DEBUG]
C:\dev\Java\maven_repo\test\project2\1.0.0-SNAPSHOT\project2-1.0.0-SNAPSHOT.jar
[DEBUG]
C:\dev\Java\maven_repo\org\mockito\mockito-core\1.9.5\mockito-core-1.9.5.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-core\1.1\hamcrest-core-1.1.jar
[DEBUG] C:\dev\Java\maven_repo\org\objenesis\objenesis\1.0\objenesis-1.0.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-all\1.1\hamcrest-all-1.1.jar
{noformat}
Under this conditions dependency plugin is just reporting it correctly. :)
The implementation for IsEqual class is provided by hamcrest-core-1.1.jar
because hamcrest-core-1.1.jar is the earliest entry in the classpath that has
IsEqual class.
was (Author: soselamet):
* This issue can be related with MNG-6415 under some conditions but with this
simple example it is not the case.
* The reported behavior still observable. It is related with how classpath
constructed. _*Dependency plugin is not the root cause.*_
I used a modified pom file for project 2 to have one more level ( for more
visible distance) in the dependency tree.
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
test
project2
1.0.0-SNAPSHOT
org.mockito
mockito-core
1.9.5
{code}
TREE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:tree (default-cli) @ project1 ---
[INFO] test:project1:jar:1.0.0-SNAPSHOT
[INFO] +- test:project2:jar:1.0.0-SNAPSHOT:compile
[INFO] | \- org.mockito:mockito-core:jar:1.9.5:compile
[INFO] | +- org.hamcrest:hamcrest-core:jar:1.1:compile
[INFO] | \- org.objenesis:objenesis:jar:1.0:compile
[INFO] \- org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
ANALYZE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:analyze (default-cli) @ project1 ---
[WARNING] Used undeclared dependencies found:
[WARNING]org.hamcrest:hamcrest-core:jar:1.1:compile
[WARNING] Unused declared dependencies found:
[WARNING]test:project2:jar:1.0.0-SNAPSHOT:compile
[WARNING]org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
CLASSPATH (took the testCompile classpath on purpose to see it was affected by
MNG-6415 or not)
{noformat}
[DEBUG] Classpath:
[DEBUG] C:\dev\dummy\P1\target\test-classes
[DEBUG] C:\dev\dummy\P1\target\classes
[DEBUG]
C:\dev\Java\maven_repo\test\project2\1.0.0-SNAPSHOT\project2-1.0.0-SNAPSHOT.jar
[DEBUG]
C:\dev\Java\maven_repo\org\mockito\mockito-core\1.9.5\mockito-core-1.9.5.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-core\1.1\hamcrest-core-1.1.jar
[DEBUG] C:\dev\Java\maven_repo\org\objenesis\objenesis\1.0\objenesis-1.0.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-all\1.1\hamcrest-all-1.1.jar
{noformat}
Under this conditions dependency plugin is just reporting it correctly. :)
[jira] [Commented] (MDEP-609) Dependency analyzer gets confused if the same package is defined in 2 different artifacts
[
https://issues.apache.org/jira/browse/MDEP-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501643#comment-16501643
]
Seckin Onur SELAMET commented on MDEP-609:
--
* This issue can be related with MNG-6415 under some conditions but with this
simple example it is not the case.
* The reported behavior still observable. It is related with how classpath
constructed. _*Dependency plugin is not the root cause.*_
I used a modified pom file for project 2 to have one more level ( for more
visible distance) in the dependency tree.
{code:xml}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
test
project2
1.0.0-SNAPSHOT
org.mockito
mockito-core
1.9.5
{code}
TREE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:tree (default-cli) @ project1 ---
[INFO] test:project1:jar:1.0.0-SNAPSHOT
[INFO] +- test:project2:jar:1.0.0-SNAPSHOT:compile
[INFO] | \- org.mockito:mockito-core:jar:1.9.5:compile
[INFO] | +- org.hamcrest:hamcrest-core:jar:1.1:compile
[INFO] | \- org.objenesis:objenesis:jar:1.0:compile
[INFO] \- org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
ANALYZE
{noformat}
[INFO] --- maven-dependency-plugin:3.1.0:analyze (default-cli) @ project1 ---
[WARNING] Used undeclared dependencies found:
[WARNING]org.hamcrest:hamcrest-core:jar:1.1:compile
[WARNING] Unused declared dependencies found:
[WARNING]test:project2:jar:1.0.0-SNAPSHOT:compile
[WARNING]org.hamcrest:hamcrest-all:jar:1.1:compile
{noformat}
CLASSPATH (took the testCompile classpath on purpose to see it was affected by
MNG-6415 or not)
{noformat}
[DEBUG] Classpath:
[DEBUG] C:\dev\dummy\P1\target\test-classes
[DEBUG] C:\dev\dummy\P1\target\classes
[DEBUG]
C:\dev\Java\maven_repo\test\project2\1.0.0-SNAPSHOT\project2-1.0.0-SNAPSHOT.jar
[DEBUG]
C:\dev\Java\maven_repo\org\mockito\mockito-core\1.9.5\mockito-core-1.9.5.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-core\1.1\hamcrest-core-1.1.jar
[DEBUG] C:\dev\Java\maven_repo\org\objenesis\objenesis\1.0\objenesis-1.0.jar
[DEBUG]
C:\dev\Java\maven_repo\org\hamcrest\hamcrest-all\1.1\hamcrest-all-1.1.jar
{noformat}
Under this conditions dependency plugin is just reporting it correctly. :)
The implementation for IsEqual class is provided by hamcrest-core-1.1.jar
because hamcrest-core-1.1.jar is the earliest entry in the classpath that has
IsEqual class.
> Dependency analyzer gets confused if the same package is defined in 2
> different artifacts
> -
>
> Key: MDEP-609
> URL: https://issues.apache.org/jira/browse/MDEP-609
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: analyze
>Affects Versions: 3.1.0
>Reporter: Ahmed Hammad
>Priority: Major
>
> The issue might be related to MNG-6415
> If a certain package is defined in 2 different artifacts, and a a maven
> module declares a dependency on these 2 artifacts (once through a transitive
> dependency and once using a declared dependency), dependency analyzer reports
> the dependency as "Used Undeclared", while declared dependencies should
> always take precedence (even if they appear later in the POM)
> For example:
> Project 1 pom:
> {code:java}
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
>test
> project1
> 1.0.0-SNAPSHOT
>
>
> test
> project2
> 1.0.0-SNAPSHOT
>
>
> org.hamcrest
> hamcrest-all
> 1.1
>
>
>
> {code}
> Project 2 pom:
> {code:java}
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
>4.0.0
> test
> project2
> 1.0.0-SNAPSHOT
>
>
> org.hamcrest
> hamcrest-core
> 1.3
>
>
>
> {code}
> And Project 1 uses a package which can be found in both hamcrest-core and
> hamcrest-all:
> {code:java}
> import org.hamcrest.core.IsEqual;
> class Test {
> IsEqual isEqual;
> }
> {code}
> When doing a dependency analysis for Project 1, no "Used undeclared" are
> expected to be seen, because Project 1 declares a dependency on hamcrest-all.
> However, I get:
> [INFO] — maven-dependency-plugin:2.8:analyze (default-cli) @ project1 —
> [WARNING] Used undeclared dependencies found:
>
[jira] [Updated] (SCM-805) Add SVN --pin-externals option to copy command (branch/tag)
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SCM-805: --- Summary: Add SVN --pin-externals option to copy command (branch/tag) (was: Add SVN --pin-externals option to copy command in Tag operations) > Add SVN --pin-externals option to copy command (branch/tag) > --- > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn >Affects Versions: 1.9.5 > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra >Assignee: Michael Osipov >Priority: Major > Labels: externals, svn, tag > Fix For: 1.10.1 > > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCM-805) Add SVN --pin-externals option to copy command in Tag operations
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SCM-805: --- Fix Version/s: 1.10.1 > Add SVN --pin-externals option to copy command in Tag operations > > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn >Affects Versions: 1.9.5 > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra >Assignee: Michael Osipov >Priority: Major > Labels: externals, svn, tag > Fix For: 1.10.1 > > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (SCM-805) Add SVN --pin-externals option to copy command in Tag operations
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned SCM-805: -- Assignee: Michael Osipov > Add SVN --pin-externals option to copy command in Tag operations > > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn >Affects Versions: 1.9.5 > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra >Assignee: Michael Osipov >Priority: Major > Labels: externals, svn, tag > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SCM-805) Add SVN --pin-externals option to copy command in Tag operations
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SCM-805: --- Fix Version/s: (was: waiting-for-feedback) > Add SVN --pin-externals option to copy command in Tag operations > > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn >Affects Versions: 1.9.5 > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra >Assignee: Michael Osipov >Priority: Major > Labels: externals, svn, tag > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCM-805) Add SVN --pin-externals option to copy command in Tag operations
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501511#comment-16501511 ] ASF GitHub Bot commented on SCM-805: michael-o commented on issue #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#issuecomment-394639862 Looks good now. Just waiting for a comment about the reallife pin externals test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add SVN --pin-externals option to copy command in Tag operations > > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn >Affects Versions: 1.9.5 > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra >Priority: Major > Labels: externals, svn, tag > Fix For: waiting-for-feedback > > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] michael-o commented on issue #55: Fix for SCM-805
michael-o commented on issue #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#issuecomment-394639862 Looks good now. Just waiting for a comment about the reallife pin externals test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SCM-805) Add SVN --pin-externals option to copy command in Tag operations
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501510#comment-16501510 ] ASF GitHub Bot commented on SCM-805: michael-o commented on a change in pull request #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#discussion_r193000632 ## File path: maven-scm-api/src/main/java/org/apache/maven/scm/ScmBranchParameters.java ## @@ -34,11 +34,14 @@ private boolean remoteBranching = false; +private boolean pinExternals = false; Review comment: Granted, makes sense! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add SVN --pin-externals option to copy command in Tag operations > > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn >Affects Versions: 1.9.5 > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra >Priority: Major > Labels: externals, svn, tag > Fix For: waiting-for-feedback > > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] michael-o commented on a change in pull request #55: Fix for SCM-805
michael-o commented on a change in pull request #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#discussion_r193000632 ## File path: maven-scm-api/src/main/java/org/apache/maven/scm/ScmBranchParameters.java ## @@ -34,11 +34,14 @@ private boolean remoteBranching = false; +private boolean pinExternals = false; Review comment: Granted, makes sense! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SCM-805) Add SVN --pin-externals option to copy command in Tag operations
[
https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501509#comment-16501509
]
ASF GitHub Bot commented on SCM-805:
michael-o commented on a change in pull request #55: Fix for SCM-805
URL: https://github.com/apache/maven-scm/pull/55#discussion_r192968228
##
File path:
maven-scm-api/src/main/java/org/apache/maven/scm/ScmTagParameters.java
##
@@ -66,6 +69,16 @@ public void setRemoteTagging( boolean remoteTagging )
this.remoteTagging = remoteTagging;
}
+public boolean isPinExternals()
+{
+return pinExternals;
+}
+
+public void setPinExternals( boolean pinExternals)
Review comment:
same here
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add SVN --pin-externals option to copy command in Tag operations
>
>
> Key: SCM-805
> URL: https://issues.apache.org/jira/browse/SCM-805
> Project: Maven SCM
> Issue Type: Improvement
> Components: maven-scm-provider-svn
>Affects Versions: 1.9.5
> Environment: SVN 1.9+
>Reporter: Eduardo Hernández Guerra
>Priority: Major
> Labels: externals, svn, tag
> Fix For: waiting-for-feedback
>
>
> Starting from version 1.9, SVN client now supports the --pin-externals option
> for the copy command, which is to be used when tagging.
> I believe this should be implemented by default in SVN tag operations, and it
> optionally could be disabled via a parameter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] michael-o commented on a change in pull request #55: Fix for SCM-805
michael-o commented on a change in pull request #55: Fix for SCM-805
URL: https://github.com/apache/maven-scm/pull/55#discussion_r192968228
##
File path:
maven-scm-api/src/main/java/org/apache/maven/scm/ScmTagParameters.java
##
@@ -66,6 +69,16 @@ public void setRemoteTagging( boolean remoteTagging )
this.remoteTagging = remoteTagging;
}
+public boolean isPinExternals()
+{
+return pinExternals;
+}
+
+public void setPinExternals( boolean pinExternals)
Review comment:
same here
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on a change in pull request #184: Donate current sources
from junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r192987675
##
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##
@@ -0,0 +1,272 @@
+package org.apache.maven.surefire.junitplatform;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.apache.maven.surefire.report.SimpleReportEntry.ignored;
+import static org.junit.platform.engine.TestExecutionResult.Status.ABORTED;
+import static org.junit.platform.engine.TestExecutionResult.Status.FAILED;
+
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+import org.apache.maven.surefire.report.PojoStackTraceWriter;
+import org.apache.maven.surefire.report.RunListener;
+import org.apache.maven.surefire.report.SimpleReportEntry;
+import org.apache.maven.surefire.report.StackTraceWriter;
+import org.junit.platform.engine.TestExecutionResult;
+import org.junit.platform.engine.TestSource;
+import org.junit.platform.engine.support.descriptor.ClassSource;
+import org.junit.platform.engine.support.descriptor.MethodSource;
+import org.junit.platform.launcher.TestExecutionListener;
+import org.junit.platform.launcher.TestIdentifier;
+import org.junit.platform.launcher.TestPlan;
+import org.junit.platform.launcher.listeners.LegacyReportingUtils;
+
+/**
+ * @since 2.22.0
+ */
+final class RunListenerAdapter
+implements TestExecutionListener
+{
+
+private final RunListener runListener;
+
+private TestPlan testPlan;
+
+private Set testSetNodes = ConcurrentHashMap.newKeySet();
+
+RunListenerAdapter( RunListener runListener )
+{
+this.runListener = runListener;
+}
+
+@Override
+public void testPlanExecutionStarted( TestPlan testPlan )
+{
+updateTestPlan( testPlan );
+}
+
+@Override
+public void testPlanExecutionFinished( TestPlan testPlan )
+{
+updateTestPlan( null );
+}
+
+@Override
+public void executionStarted( TestIdentifier testIdentifier )
+{
+if ( testIdentifier.isContainer()
+&& testIdentifier.getSource().filter(
ClassSource.class::isInstance ).isPresent() )
+{
+startTestSetIfPossible( testIdentifier );
+}
+if ( testIdentifier.isTest() )
+{
+ensureTestSetStarted( testIdentifier );
+runListener.testStarting( createReportEntry( testIdentifier ) );
+}
+}
+
+@Override
+public void executionSkipped( TestIdentifier testIdentifier, String reason
)
+{
+ensureTestSetStarted( testIdentifier );
+String source = getLegacyReportingClassName( testIdentifier );
+runListener.testSkipped( ignored( source, getLegacyReportingName(
testIdentifier ), reason ) );
+completeTestSetIfNecessary( testIdentifier );
+}
+
+@Override
+public void executionFinished(
+TestIdentifier testIdentifier, TestExecutionResult
testExecutionResult )
+{
+if ( testExecutionResult.getStatus() == ABORTED )
+{
+runListener.testAssumptionFailure( createReportEntry(
testIdentifier, testExecutionResult ) );
+}
+else if ( testExecutionResult.getStatus() == FAILED )
+{
+reportFailedTest( testIdentifier, testExecutionResult );
+}
+else if ( testIdentifier.isTest() )
+{
+runListener.testSucceeded( createReportEntry( testIdentifier ) );
+}
+completeTestSetIfNecessary( testIdentifier );
+}
+
+private void updateTestPlan( TestPlan testPlan )
+{
+this.testPlan = testPlan;
+testSetNodes.clear();
+}
+
+private void ensureTestSetStarted( TestIdentifier testIdentifier )
+{
+if ( isTestSetStarted( testIdentifier ) )
+{
+return;
+}
+if ( testIdentifier.isTest() )
+{
+startTestSet( testPlan.getParent( testIdentifier ).orElse(
testIdentifier ) );
+}
+
[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on a change in pull request #184: Donate current sources
from junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r192987675
##
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##
@@ -0,0 +1,272 @@
+package org.apache.maven.surefire.junitplatform;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.apache.maven.surefire.report.SimpleReportEntry.ignored;
+import static org.junit.platform.engine.TestExecutionResult.Status.ABORTED;
+import static org.junit.platform.engine.TestExecutionResult.Status.FAILED;
+
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+import org.apache.maven.surefire.report.PojoStackTraceWriter;
+import org.apache.maven.surefire.report.RunListener;
+import org.apache.maven.surefire.report.SimpleReportEntry;
+import org.apache.maven.surefire.report.StackTraceWriter;
+import org.junit.platform.engine.TestExecutionResult;
+import org.junit.platform.engine.TestSource;
+import org.junit.platform.engine.support.descriptor.ClassSource;
+import org.junit.platform.engine.support.descriptor.MethodSource;
+import org.junit.platform.launcher.TestExecutionListener;
+import org.junit.platform.launcher.TestIdentifier;
+import org.junit.platform.launcher.TestPlan;
+import org.junit.platform.launcher.listeners.LegacyReportingUtils;
+
+/**
+ * @since 2.22.0
+ */
+final class RunListenerAdapter
+implements TestExecutionListener
+{
+
+private final RunListener runListener;
+
+private TestPlan testPlan;
+
+private Set testSetNodes = ConcurrentHashMap.newKeySet();
+
+RunListenerAdapter( RunListener runListener )
+{
+this.runListener = runListener;
+}
+
+@Override
+public void testPlanExecutionStarted( TestPlan testPlan )
+{
+updateTestPlan( testPlan );
+}
+
+@Override
+public void testPlanExecutionFinished( TestPlan testPlan )
+{
+updateTestPlan( null );
+}
+
+@Override
+public void executionStarted( TestIdentifier testIdentifier )
+{
+if ( testIdentifier.isContainer()
+&& testIdentifier.getSource().filter(
ClassSource.class::isInstance ).isPresent() )
+{
+startTestSetIfPossible( testIdentifier );
+}
+if ( testIdentifier.isTest() )
+{
+ensureTestSetStarted( testIdentifier );
+runListener.testStarting( createReportEntry( testIdentifier ) );
+}
+}
+
+@Override
+public void executionSkipped( TestIdentifier testIdentifier, String reason
)
+{
+ensureTestSetStarted( testIdentifier );
+String source = getLegacyReportingClassName( testIdentifier );
+runListener.testSkipped( ignored( source, getLegacyReportingName(
testIdentifier ), reason ) );
+completeTestSetIfNecessary( testIdentifier );
+}
+
+@Override
+public void executionFinished(
+TestIdentifier testIdentifier, TestExecutionResult
testExecutionResult )
+{
+if ( testExecutionResult.getStatus() == ABORTED )
+{
+runListener.testAssumptionFailure( createReportEntry(
testIdentifier, testExecutionResult ) );
+}
+else if ( testExecutionResult.getStatus() == FAILED )
+{
+reportFailedTest( testIdentifier, testExecutionResult );
+}
+else if ( testIdentifier.isTest() )
+{
+runListener.testSucceeded( createReportEntry( testIdentifier ) );
+}
+completeTestSetIfNecessary( testIdentifier );
+}
+
+private void updateTestPlan( TestPlan testPlan )
+{
+this.testPlan = testPlan;
+testSetNodes.clear();
+}
+
+private void ensureTestSetStarted( TestIdentifier testIdentifier )
+{
+if ( isTestSetStarted( testIdentifier ) )
+{
+return;
+}
+if ( testIdentifier.isTest() )
+{
+startTestSet( testPlan.getParent( testIdentifier ).orElse(
testIdentifier ) );
+}
+
[GitHub] theit commented on a change in pull request #55: Fix for SCM-805
theit commented on a change in pull request #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#discussion_r192977649 ## File path: maven-scm-api/src/main/java/org/apache/maven/scm/ScmBranchParameters.java ## @@ -34,11 +34,14 @@ private boolean remoteBranching = false; +private boolean pinExternals = false; Review comment: What about the following scenario: You create a branch for a release version to be able to do special release hotfixes. The externals refer to a different project's trunk that is developed / restructured / whatever in a way that is incompatible with your actual release. Without pinned externals, your branch won't work anymore. In that case, yes I think it's useful / necessary to be able to pin externals even in branches. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SCM-805) Add SVN --pin-externals option to copy command in Tag operations
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501433#comment-16501433 ] ASF GitHub Bot commented on SCM-805: theit commented on a change in pull request #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#discussion_r192977649 ## File path: maven-scm-api/src/main/java/org/apache/maven/scm/ScmBranchParameters.java ## @@ -34,11 +34,14 @@ private boolean remoteBranching = false; +private boolean pinExternals = false; Review comment: What about the following scenario: You create a branch for a release version to be able to do special release hotfixes. The externals refer to a different project's trunk that is developed / restructured / whatever in a way that is incompatible with your actual release. Without pinned externals, your branch won't work anymore. In that case, yes I think it's useful / necessary to be able to pin externals even in branches. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add SVN --pin-externals option to copy command in Tag operations > > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn >Affects Versions: 1.9.5 > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra >Priority: Major > Labels: externals, svn, tag > Fix For: waiting-for-feedback > > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MCOMPILER-344) flag is a no-op
Claude Brisson created MCOMPILER-344: Summary: flag is a no-op Key: MCOMPILER-344 URL: https://issues.apache.org/jira/browse/MCOMPILER-344 Project: Maven Compiler Plugin Issue Type: Bug Affects Versions: 3.5.1 Environment: jdk8 Reporter: Claude Brisson There's quite some time that the '-O' (optimize) option has disappeared from javac (still supported as a no-op). All the optimization work is done by the JIT. The compiler plugin should deprecate the use of the flag. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCM-805) Add SVN --pin-externals option to copy command in Tag operations
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501406#comment-16501406 ] ASF GitHub Bot commented on SCM-805: michael-o commented on issue #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#issuecomment-394607322 So far so good, can you squash and rebase? There are unrelated changes from the previous commits. Moreover, do you think it is worth adding another test with a local repo where the pinned externals are verified after tagging? One can you a SVN dump (see `tck.dump`). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add SVN --pin-externals option to copy command in Tag operations > > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn >Affects Versions: 1.9.5 > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra >Priority: Major > Labels: externals, svn, tag > Fix For: waiting-for-feedback > > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] michael-o commented on issue #55: Fix for SCM-805
michael-o commented on issue #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#issuecomment-394607322 So far so good, can you squash and rebase? There are unrelated changes from the previous commits. Moreover, do you think it is worth adding another test with a local repo where the pinned externals are verified after tagging? One can you a SVN dump (see `tck.dump`). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SCM-805) Add SVN --pin-externals option to copy command in Tag operations
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501395#comment-16501395 ] ASF GitHub Bot commented on SCM-805: michael-o commented on a change in pull request #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#discussion_r192968155 ## File path: maven-scm-api/src/main/java/org/apache/maven/scm/ScmBranchParameters.java ## @@ -34,11 +34,14 @@ private boolean remoteBranching = false; +private boolean pinExternals = false; Review comment: Is there a usecaes to pin externals with branches? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add SVN --pin-externals option to copy command in Tag operations > > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn >Affects Versions: 1.9.5 > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra >Priority: Major > Labels: externals, svn, tag > Fix For: waiting-for-feedback > > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SCM-805) Add SVN --pin-externals option to copy command in Tag operations
[
https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16501396#comment-16501396
]
ASF GitHub Bot commented on SCM-805:
michael-o commented on a change in pull request #55: Fix for SCM-805
URL: https://github.com/apache/maven-scm/pull/55#discussion_r192968210
##
File path:
maven-scm-api/src/main/java/org/apache/maven/scm/ScmBranchParameters.java
##
@@ -76,6 +79,16 @@ public void setRemoteBranching( boolean remoteBranching )
this.remoteBranching = remoteBranching;
}
+public boolean isPinExternals()
+{
+return pinExternals;
+}
+
+public void setPinExternals( boolean pinExternals)
Review comment:
whitespace after var missing
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Add SVN --pin-externals option to copy command in Tag operations
>
>
> Key: SCM-805
> URL: https://issues.apache.org/jira/browse/SCM-805
> Project: Maven SCM
> Issue Type: Improvement
> Components: maven-scm-provider-svn
>Affects Versions: 1.9.5
> Environment: SVN 1.9+
>Reporter: Eduardo Hernández Guerra
>Priority: Major
> Labels: externals, svn, tag
> Fix For: waiting-for-feedback
>
>
> Starting from version 1.9, SVN client now supports the --pin-externals option
> for the copy command, which is to be used when tagging.
> I believe this should be implemented by default in SVN tag operations, and it
> optionally could be disabled via a parameter.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] michael-o commented on a change in pull request #55: Fix for SCM-805
michael-o commented on a change in pull request #55: Fix for SCM-805
URL: https://github.com/apache/maven-scm/pull/55#discussion_r192968210
##
File path:
maven-scm-api/src/main/java/org/apache/maven/scm/ScmBranchParameters.java
##
@@ -76,6 +79,16 @@ public void setRemoteBranching( boolean remoteBranching )
this.remoteBranching = remoteBranching;
}
+public boolean isPinExternals()
+{
+return pinExternals;
+}
+
+public void setPinExternals( boolean pinExternals)
Review comment:
whitespace after var missing
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] michael-o commented on a change in pull request #55: Fix for SCM-805
michael-o commented on a change in pull request #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#discussion_r192968155 ## File path: maven-scm-api/src/main/java/org/apache/maven/scm/ScmBranchParameters.java ## @@ -34,11 +34,14 @@ private boolean remoteBranching = false; +private boolean pinExternals = false; Review comment: Is there a usecaes to pin externals with branches? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
