[jira] [Reopened] (MRELEASE-784) SNAPSHOT version in Dependency in DependencyManagement with scope import and type pom is not replaced
[ https://issues.apache.org/jira/browse/MRELEASE-784?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reopened MRELEASE-784: - > SNAPSHOT version in Dependency in DependencyManagement with scope import and > type pom is not replaced > - > > Key: MRELEASE-784 > URL: https://issues.apache.org/jira/browse/MRELEASE-784 > Project: Maven Release Plugin > Issue Type: Bug >Affects Versions: 2.3.2 > Environment: Maven 3.0.4 >Reporter: Michael Niedermaier >Priority: Major > Attachments: console.out, internal-managed-snapshot-dependency.zip, > remote-repository.zip > > > In the test case he asks for the external:artifactId version on console, but > it should only ask and change for the import dependencyManagement dependency > external:parent-artifactid-withimport-dm which's version is not changed by > the release plugin > I attached my sample repository, the project in tryed to release (including > the created pom for tag, which still contains the SNAPSHOT version) and the > console output -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MRELEASE-784) SNAPSHOT version in Dependency in DependencyManagement with scope import and type pom is not replaced
[ https://issues.apache.org/jira/browse/MRELEASE-784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505663#comment-16505663 ] Nancy Chunlan commented on MRELEASE-784: Can we re-open the issue? We tried the latest release 2.5.3, the issue is still existing. > SNAPSHOT version in Dependency in DependencyManagement with scope import and > type pom is not replaced > - > > Key: MRELEASE-784 > URL: https://issues.apache.org/jira/browse/MRELEASE-784 > Project: Maven Release Plugin > Issue Type: Bug >Affects Versions: 2.3.2 > Environment: Maven 3.0.4 >Reporter: Michael Niedermaier >Priority: Major > Attachments: console.out, internal-managed-snapshot-dependency.zip, > remote-repository.zip > > > In the test case he asks for the external:artifactId version on console, but > it should only ask and change for the import dependencyManagement dependency > external:parent-artifactid-withimport-dm which's version is not changed by > the release plugin > I attached my sample repository, the project in tryed to release (including > the created pom for tag, which still contains the SNAPSHOT version) and the > console output -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] olamy commented on issue #184: Donate current sources from junit-platform-surefire-provider
olamy commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-395565437 Awesome guys!! Good job!! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (MCOMPILER-321) Problematic Java 9 modules are silently ignored
[
https://issues.apache.org/jira/browse/MCOMPILER-321?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MCOMPILER-321.
Resolution: Fixed
Assignee: Robert Scholte
Fixed in
[ce26802e6cc93320267482cc7c3a1947bfc34be6|https://gitbox.apache.org/repos/asf?p=maven-compiler-plugin.git;a=commit;h=ce26802e6cc93320267482cc7c3a1947bfc34be6]
> Problematic Java 9 modules are silently ignored
> ---
>
> Key: MCOMPILER-321
> URL: https://issues.apache.org/jira/browse/MCOMPILER-321
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Reporter: Marcel Kolsteren
>Assignee: Robert Scholte
>Priority: Major
> Fix For: 3.7.1
>
> Attachments: maven-compiler-plugin-bug.zip
>
>
> Before the compilation starts, the compiler plugin prepares the module path
> and the class path. Unfortunately, this process is very lenient. If the
> plugin cannot find a module that is specified in the module-info file, it
> doesn't report this problem, and it just carries on. In the end, the compiler
> will give a "module not found", giving no clue about the root cause.
> As an example, I attached a simple maven project with a module info file that
> refers to an automatic module named {{jython-standalone}}. The dependencies
> contain a jar file {{jython-standalone-2.7.0.jar}}. That jar file contains no
> module information, and it would normally be resolvable as an automatic
> module. However, when building the project, the Java compiler fails with this
> error:
> {{module not found: jython.standalone}}
> The root cause of the error is that the jar file contains a class at top
> level, which is illegal for a module. So, the error message "module not
> found" is misleading.
> I think this is a bug, because the maven-compiler-plugin fails to perform its
> task of building a correct module path, but doesn't tell, and just carries
> on. Instead, it should stop, and give an informative error message.
> Relevant source code:
> * [https://github.com/apache/maven-compiler-plugin], class {{CompilerMojo}}
> * [https://github.com/codehaus-plexus/plexus-languages], class
> {{LocationManager}} and {{MainClassModuleNameExtractor}}
> *
> [https://docs.oracle.com/javase/9/docs/api/java/lang/module/ModuleFinder.html]
> The {{MainClassModuleNameExtractor}} uses the {{ModuleFinder}} class of the
> JDK to find modules. I think that these two error situations should lead to
> an error and a clear description of possible causes:
> * {{ModuleFinder#findAll}} returns an empty set.
> * {{ModuleFinder#findAll}} results in a {{FindException}}. When this happens
> is well documented in the {{ModuleFinder#of}} method. This exception is
> currently swallowed.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCOMPILER-344) Deprecate flag
[ https://issues.apache.org/jira/browse/MCOMPILER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505240#comment-16505240 ] Hudson commented on MCOMPILER-344: -- Build succeeded in Jenkins: Maven TLP » maven-compiler-plugin » master #27 See https://builds.apache.org/job/maven-box/job/maven-compiler-plugin/job/master/27/ > Deprecate flag > - > > Key: MCOMPILER-344 > URL: https://issues.apache.org/jira/browse/MCOMPILER-344 > Project: Maven Compiler Plugin > Issue Type: Task >Affects Versions: 3.5.1 > Environment: jdk8 >Reporter: Claude Brisson >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.7.1 > > > There's quite some time that the '-O' (optimize) option has disappeared from > javac (still supported as a no-op). All the optimization work is done by the > JIT. The compiler plugin should deprecate the use of the flag. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MCOMPILER-344) Deprecate flag
[ https://issues.apache.org/jira/browse/MCOMPILER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505218#comment-16505218 ] Michael Osipov edited comment on MCOMPILER-344 at 6/7/18 8:37 PM: -- Fixed with [c4d92a10a9682e5d7c4bdec1bc0644a16f073330|https://gitbox.apache.org/repos/asf?p=maven-compiler-plugin.git;a=commit;h=c4d92a10a9682e5d7c4bdec1bc0644a16f073330]. was (Author: michael-o): Fixed with [0af30c4b21ea2c618ad53b12fc92a8a295a64295|https://gitbox.apache.org/repos/asf?p=maven-compiler-plugin.git;a=commit;h=0af30c4b21ea2c618ad53b12fc92a8a295a64295]. > Deprecate flag > - > > Key: MCOMPILER-344 > URL: https://issues.apache.org/jira/browse/MCOMPILER-344 > Project: Maven Compiler Plugin > Issue Type: Task >Affects Versions: 3.5.1 > Environment: jdk8 >Reporter: Claude Brisson >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.7.1 > > > There's quite some time that the '-O' (optimize) option has disappeared from > javac (still supported as a no-op). All the optimization work is done by the > JIT. The compiler plugin should deprecate the use of the flag. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MCOMPILER-344) Deprecate flag
[ https://issues.apache.org/jira/browse/MCOMPILER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MCOMPILER-344. Resolution: Fixed Fixed with [0af30c4b21ea2c618ad53b12fc92a8a295a64295|https://gitbox.apache.org/repos/asf?p=maven-compiler-plugin.git;a=commit;h=0af30c4b21ea2c618ad53b12fc92a8a295a64295]. > Deprecate flag > - > > Key: MCOMPILER-344 > URL: https://issues.apache.org/jira/browse/MCOMPILER-344 > Project: Maven Compiler Plugin > Issue Type: Task >Affects Versions: 3.5.1 > Environment: jdk8 >Reporter: Claude Brisson >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.7.1 > > > There's quite some time that the '-O' (optimize) option has disappeared from > javac (still supported as a no-op). All the optimization work is done by the > JIT. The compiler plugin should deprecate the use of the flag. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MCOMPILER-344) Deprecate flag
[ https://issues.apache.org/jira/browse/MCOMPILER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MCOMPILER-344: - Fix Version/s: 3.7.1 > Deprecate flag > - > > Key: MCOMPILER-344 > URL: https://issues.apache.org/jira/browse/MCOMPILER-344 > Project: Maven Compiler Plugin > Issue Type: Task >Affects Versions: 3.5.1 > Environment: jdk8 >Reporter: Claude Brisson >Assignee: Michael Osipov >Priority: Minor > Fix For: 3.7.1 > > > There's quite some time that the '-O' (optimize) option has disappeared from > javac (still supported as a no-op). All the optimization work is done by the > JIT. The compiler plugin should deprecate the use of the flag. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MCOMPILER-344) Deprecate flag
[ https://issues.apache.org/jira/browse/MCOMPILER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MCOMPILER-344: Assignee: Michael Osipov > Deprecate flag > - > > Key: MCOMPILER-344 > URL: https://issues.apache.org/jira/browse/MCOMPILER-344 > Project: Maven Compiler Plugin > Issue Type: Task >Affects Versions: 3.5.1 > Environment: jdk8 >Reporter: Claude Brisson >Assignee: Michael Osipov >Priority: Minor > > There's quite some time that the '-O' (optimize) option has disappeared from > javac (still supported as a no-op). All the optimization work is done by the > JIT. The compiler plugin should deprecate the use of the flag. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MCOMPILER-344) Deprecate flag
[ https://issues.apache.org/jira/browse/MCOMPILER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MCOMPILER-344: - Summary: Deprecate flag (was: flag is a no-op) > Deprecate flag > - > > Key: MCOMPILER-344 > URL: https://issues.apache.org/jira/browse/MCOMPILER-344 > Project: Maven Compiler Plugin > Issue Type: Task >Affects Versions: 3.5.1 > Environment: jdk8 >Reporter: Claude Brisson >Priority: Minor > > There's quite some time that the '-O' (optimize) option has disappeared from > javac (still supported as a no-op). All the optimization work is done by the > JIT. The compiler plugin should deprecate the use of the flag. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-527) detectLinks may pass invalid urls to javadoc
[ https://issues.apache.org/jira/browse/MJAVADOC-527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505184#comment-16505184 ] Michael Osipov commented on MJAVADOC-527: - There are multiple redirects. But you are right, do you want to provide a PR? > detectLinks may pass invalid urls to javadoc > > > Key: MJAVADOC-527 > URL: https://issues.apache.org/jira/browse/MJAVADOC-527 > Project: Maven Javadoc Plugin > Issue Type: Bug > Components: javadoc >Affects Versions: 3.0.1 > Environment: Windows 10 > JDK 8 > Maven 3.5.2 >Reporter: Roberto Benedetti >Priority: Major > Labels: detectLinks > > The url of artifact com.sun.mail:mailapi:1.5.5 is > [http://javamail.java.net/mailapi], so the plugin tests if > [http://javamail.java.net/mailapi/apidocs/package-list] is valid. > That url redirects to [https://javaee.github.io/javamail/] which is JavaMail > home page, so the plugin thinks the url is valid and passes it to javadoc. > javadoc warns about invalid link. > Maybe checking if the effective url is still "package-list" would be safer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MCOMPILER-344) flag is a no-op
[ https://issues.apache.org/jira/browse/MCOMPILER-344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MCOMPILER-344: - Issue Type: Task (was: Bug) > flag is a no-op > -- > > Key: MCOMPILER-344 > URL: https://issues.apache.org/jira/browse/MCOMPILER-344 > Project: Maven Compiler Plugin > Issue Type: Task >Affects Versions: 3.5.1 > Environment: jdk8 >Reporter: Claude Brisson >Priority: Minor > > There's quite some time that the '-O' (optimize) option has disappeared from > javac (still supported as a no-op). All the optimization work is done by the > JIT. The compiler plugin should deprecate the use of the flag. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MJAVADOC-528) Invalid 'expires' attribute
[
https://issues.apache.org/jira/browse/MJAVADOC-528?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505179#comment-16505179
]
Michael Osipov commented on MJAVADOC-528:
-
I am inclined to drop the entire line. Have you tried that?
> Invalid 'expires' attribute
> ---
>
> Key: MJAVADOC-528
> URL: https://issues.apache.org/jira/browse/MJAVADOC-528
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: javadoc
>Affects Versions: 3.0.1
>Reporter: Roberto Benedetti
>Priority: Major
> Labels: detectLinks
> Attachments: cookie.patch
>
>
> When detectLinks is enabled and the plugin checks if the url is valid,
> warnings like this
> {code:java}
> Invalid cookie header: "Set-Cookie: logged_in=no; domain=.github.com; path=/;
> expires=Sun, 06 Jun 2038 14:02:43 -; secure; HttpOnly". Invalid 'expires'
> attribute: Sun, 06 Jun 2038 14:02:43 -
> {code}
> may appear.
> Previous warning was due to {{com.google.code.gson:gson:jar:2.5}} dependency
> and is raised by HttpClient which does not expect 'expires' values compliant
> to RFC 6265.
> The attachment is a patch which makes HttpClient ignore cookies. Maybe a
> better solution would be upgrading to the latest HttpComponents API which
> supports RFC 6265.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] michael-o commented on issue #55: Fix for SCM-805
michael-o commented on issue #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#issuecomment-395543031 Please rebase your changes on top of master. I'd like to merge and move on. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SCM-805) Add SVN --pin-externals option to copy command (branch/tag)
[ https://issues.apache.org/jira/browse/SCM-805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16505168#comment-16505168 ] ASF GitHub Bot commented on SCM-805: michael-o commented on issue #55: Fix for SCM-805 URL: https://github.com/apache/maven-scm/pull/55#issuecomment-395543031 Please rebase your changes on top of master. I'd like to merge and move on. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add SVN --pin-externals option to copy command (branch/tag) > --- > > Key: SCM-805 > URL: https://issues.apache.org/jira/browse/SCM-805 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-provider-svn >Affects Versions: 1.9.5 > Environment: SVN 1.9+ >Reporter: Eduardo Hernández Guerra >Assignee: Michael Osipov >Priority: Major > Labels: externals, svn, tag > Fix For: 1.10.1 > > > Starting from version 1.9, SVN client now supports the --pin-externals option > for the copy command, which is to be used when tagging. > I believe this should be implemented by default in SVN tag operations, and it > optionally could be disabled via a parameter. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
Re: [GitHub] marcphilipp commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider
On Thu, Jun 7, 2018 at 9:12 PM, GitBox wrote:
> marcphilipp commented on a change in pull request #184: Donate current
> sources from junit-platform-surefire-provider
> URL: https://github.com/apache/maven-surefire/pull/184#
> discussion_r193795566
>
>
>
> ##
> File path: surefire-providers/surefire-junit-platform/src/main/java/
> org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
> ##
> @@ -0,0 +1,272 @@
> +package org.apache.maven.surefire.junitplatform;
> +
> +/*
> + * Licensed to the Apache Software Foundation (ASF) under one
> + * or more contributor license agreements. See the NOTICE file
> + * distributed with this work for additional information
> + * regarding copyright ownership. The ASF licenses this file
> + * to you under the Apache License, Version 2.0 (the
> + * "License"); you may not use this file except in compliance
> + * with the License. You may obtain a copy of the License at
> + *
> + * http://www.apache.org/licenses/LICENSE-2.0
> + *
> + * Unless required by applicable law or agreed to in writing,
> + * software distributed under the License is distributed on an
> + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
> + * KIND, either express or implied. See the License for the
> + * specific language governing permissions and limitations
> + * under the License.
> + */
> +
> +import static org.apache.maven.surefire.report.SimpleReportEntry.ignored;
> +import static org.junit.platform.engine.TestExecutionResult.Status.
> ABORTED;
> +import static org.junit.platform.engine.TestExecutionResult.Status.
> FAILED;
> +
> +import java.util.Optional;
> +import java.util.Set;
> +import java.util.concurrent.ConcurrentHashMap;
> +
> +import org.apache.maven.surefire.report.PojoStackTraceWriter;
> +import org.apache.maven.surefire.report.RunListener;
> +import org.apache.maven.surefire.report.SimpleReportEntry;
> +import org.apache.maven.surefire.report.StackTraceWriter;
> +import org.junit.platform.engine.TestExecutionResult;
> +import org.junit.platform.engine.TestSource;
> +import org.junit.platform.engine.support.descriptor.ClassSource;
> +import org.junit.platform.engine.support.descriptor.MethodSource;
> +import org.junit.platform.launcher.TestExecutionListener;
> +import org.junit.platform.launcher.TestIdentifier;
> +import org.junit.platform.launcher.TestPlan;
> +import org.junit.platform.launcher.listeners.LegacyReportingUtils;
> +
> +/**
> + * @since 2.22.0
> + */
> +final class RunListenerAdapter
> +implements TestExecutionListener
> +{
> +
> +private final RunListener runListener;
> +
> +private TestPlan testPlan;
> +
> +private Set testSetNodes =
> ConcurrentHashMap.newKeySet();
> +
> +RunListenerAdapter( RunListener runListener )
> +{
> +this.runListener = runListener;
> +}
> +
> +@Override
> +public void testPlanExecutionStarted( TestPlan testPlan )
> +{
> +updateTestPlan( testPlan );
> +}
> +
> +@Override
> +public void testPlanExecutionFinished( TestPlan testPlan )
> +{
> +updateTestPlan( null );
> +}
> +
> +@Override
> +public void executionStarted( TestIdentifier testIdentifier )
> +{
> +if ( testIdentifier.isContainer()
> +&& testIdentifier.getSource().filter(
> ClassSource.class::isInstance ).isPresent() )
> +{
> +startTestSetIfPossible( testIdentifier );
> +}
> +if ( testIdentifier.isTest() )
> +{
> +ensureTestSetStarted( testIdentifier );
> +runListener.testStarting( createReportEntry( testIdentifier )
> );
> +}
> +}
> +
> +@Override
> +public void executionSkipped( TestIdentifier testIdentifier, String
> reason )
> +{
> +ensureTestSetStarted( testIdentifier );
> +String source = getLegacyReportingClassName( testIdentifier );
> +runListener.testSkipped( ignored( source, getLegacyReportingName(
> testIdentifier ), reason ) );
> +completeTestSetIfNecessary( testIdentifier );
> +}
> +
> +@Override
> +public void executionFinished(
> +TestIdentifier testIdentifier, TestExecutionResult
> testExecutionResult )
> +{
> +if ( testExecutionResult.getStatus() == ABORTED )
> +{
> +runListener.testAssumptionFailure( createReportEntry(
> testIdentifier, testExecutionResult ) );
> +}
> +else if ( testExecutionResult.getStatus() == FAILED )
> +{
> +reportFailedTest( testIdentifier, testExecutionResult );
> +}
> +else if ( testIdentifier.isTest() )
> +{
> +runListener.testSucceeded( createReportEntry( testIdentifier
> ) );
> +}
> +completeTestSetIfNecessary( testIdentifier );
> +}
> +
> +private void updateTestPlan( TestPlan testPlan )
> +{
> +this.testPlan = testPlan;
> +testSetNodes.clear();
> +}
> +
> +
[GitHub] marcphilipp commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider
marcphilipp commented on a change in pull request #184: Donate current sources
from junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r193795566
##
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##
@@ -0,0 +1,272 @@
+package org.apache.maven.surefire.junitplatform;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.apache.maven.surefire.report.SimpleReportEntry.ignored;
+import static org.junit.platform.engine.TestExecutionResult.Status.ABORTED;
+import static org.junit.platform.engine.TestExecutionResult.Status.FAILED;
+
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+import org.apache.maven.surefire.report.PojoStackTraceWriter;
+import org.apache.maven.surefire.report.RunListener;
+import org.apache.maven.surefire.report.SimpleReportEntry;
+import org.apache.maven.surefire.report.StackTraceWriter;
+import org.junit.platform.engine.TestExecutionResult;
+import org.junit.platform.engine.TestSource;
+import org.junit.platform.engine.support.descriptor.ClassSource;
+import org.junit.platform.engine.support.descriptor.MethodSource;
+import org.junit.platform.launcher.TestExecutionListener;
+import org.junit.platform.launcher.TestIdentifier;
+import org.junit.platform.launcher.TestPlan;
+import org.junit.platform.launcher.listeners.LegacyReportingUtils;
+
+/**
+ * @since 2.22.0
+ */
+final class RunListenerAdapter
+implements TestExecutionListener
+{
+
+private final RunListener runListener;
+
+private TestPlan testPlan;
+
+private Set testSetNodes = ConcurrentHashMap.newKeySet();
+
+RunListenerAdapter( RunListener runListener )
+{
+this.runListener = runListener;
+}
+
+@Override
+public void testPlanExecutionStarted( TestPlan testPlan )
+{
+updateTestPlan( testPlan );
+}
+
+@Override
+public void testPlanExecutionFinished( TestPlan testPlan )
+{
+updateTestPlan( null );
+}
+
+@Override
+public void executionStarted( TestIdentifier testIdentifier )
+{
+if ( testIdentifier.isContainer()
+&& testIdentifier.getSource().filter(
ClassSource.class::isInstance ).isPresent() )
+{
+startTestSetIfPossible( testIdentifier );
+}
+if ( testIdentifier.isTest() )
+{
+ensureTestSetStarted( testIdentifier );
+runListener.testStarting( createReportEntry( testIdentifier ) );
+}
+}
+
+@Override
+public void executionSkipped( TestIdentifier testIdentifier, String reason
)
+{
+ensureTestSetStarted( testIdentifier );
+String source = getLegacyReportingClassName( testIdentifier );
+runListener.testSkipped( ignored( source, getLegacyReportingName(
testIdentifier ), reason ) );
+completeTestSetIfNecessary( testIdentifier );
+}
+
+@Override
+public void executionFinished(
+TestIdentifier testIdentifier, TestExecutionResult
testExecutionResult )
+{
+if ( testExecutionResult.getStatus() == ABORTED )
+{
+runListener.testAssumptionFailure( createReportEntry(
testIdentifier, testExecutionResult ) );
+}
+else if ( testExecutionResult.getStatus() == FAILED )
+{
+reportFailedTest( testIdentifier, testExecutionResult );
+}
+else if ( testIdentifier.isTest() )
+{
+runListener.testSucceeded( createReportEntry( testIdentifier ) );
+}
+completeTestSetIfNecessary( testIdentifier );
+}
+
+private void updateTestPlan( TestPlan testPlan )
+{
+this.testPlan = testPlan;
+testSetNodes.clear();
+}
+
+private void ensureTestSetStarted( TestIdentifier testIdentifier )
+{
+if ( isTestSetStarted( testIdentifier ) )
+{
+return;
+}
+if ( testIdentifier.isTest() )
+{
+startTestSet( testPlan.getParent( testIdentifier ).orElse(
testIdentifier ) );
+}
+
[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider
Tibor17 commented on a change in pull request #184: Donate current sources from
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r193794997
##
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##
@@ -0,0 +1,272 @@
+package org.apache.maven.surefire.junitplatform;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.apache.maven.surefire.report.SimpleReportEntry.ignored;
+import static org.junit.platform.engine.TestExecutionResult.Status.ABORTED;
+import static org.junit.platform.engine.TestExecutionResult.Status.FAILED;
+
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+import org.apache.maven.surefire.report.PojoStackTraceWriter;
+import org.apache.maven.surefire.report.RunListener;
+import org.apache.maven.surefire.report.SimpleReportEntry;
+import org.apache.maven.surefire.report.StackTraceWriter;
+import org.junit.platform.engine.TestExecutionResult;
+import org.junit.platform.engine.TestSource;
+import org.junit.platform.engine.support.descriptor.ClassSource;
+import org.junit.platform.engine.support.descriptor.MethodSource;
+import org.junit.platform.launcher.TestExecutionListener;
+import org.junit.platform.launcher.TestIdentifier;
+import org.junit.platform.launcher.TestPlan;
+import org.junit.platform.launcher.listeners.LegacyReportingUtils;
+
+/**
+ * @since 2.22.0
+ */
+final class RunListenerAdapter
+implements TestExecutionListener
+{
+
+private final RunListener runListener;
+
+private TestPlan testPlan;
+
+private Set testSetNodes = ConcurrentHashMap.newKeySet();
+
+RunListenerAdapter( RunListener runListener )
+{
+this.runListener = runListener;
+}
+
+@Override
+public void testPlanExecutionStarted( TestPlan testPlan )
+{
+updateTestPlan( testPlan );
+}
+
+@Override
+public void testPlanExecutionFinished( TestPlan testPlan )
+{
+updateTestPlan( null );
+}
+
+@Override
+public void executionStarted( TestIdentifier testIdentifier )
+{
+if ( testIdentifier.isContainer()
+&& testIdentifier.getSource().filter(
ClassSource.class::isInstance ).isPresent() )
+{
+startTestSetIfPossible( testIdentifier );
+}
+if ( testIdentifier.isTest() )
+{
+ensureTestSetStarted( testIdentifier );
+runListener.testStarting( createReportEntry( testIdentifier ) );
+}
+}
+
+@Override
+public void executionSkipped( TestIdentifier testIdentifier, String reason
)
+{
+ensureTestSetStarted( testIdentifier );
+String source = getLegacyReportingClassName( testIdentifier );
+runListener.testSkipped( ignored( source, getLegacyReportingName(
testIdentifier ), reason ) );
+completeTestSetIfNecessary( testIdentifier );
+}
+
+@Override
+public void executionFinished(
+TestIdentifier testIdentifier, TestExecutionResult
testExecutionResult )
+{
+if ( testExecutionResult.getStatus() == ABORTED )
+{
+runListener.testAssumptionFailure( createReportEntry(
testIdentifier, testExecutionResult ) );
+}
+else if ( testExecutionResult.getStatus() == FAILED )
+{
+reportFailedTest( testIdentifier, testExecutionResult );
+}
+else if ( testIdentifier.isTest() )
+{
+runListener.testSucceeded( createReportEntry( testIdentifier ) );
+}
+completeTestSetIfNecessary( testIdentifier );
+}
+
+private void updateTestPlan( TestPlan testPlan )
+{
+this.testPlan = testPlan;
+testSetNodes.clear();
+}
+
+private void ensureTestSetStarted( TestIdentifier testIdentifier )
+{
+if ( isTestSetStarted( testIdentifier ) )
+{
+return;
+}
+if ( testIdentifier.isTest() )
+{
+startTestSet( testPlan.getParent( testIdentifier ).orElse(
testIdentifier ) );
+}
+
[GitHub] Tibor17 commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider
Tibor17 commented on a change in pull request #184: Donate current sources from
junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r193794997
##
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##
@@ -0,0 +1,272 @@
+package org.apache.maven.surefire.junitplatform;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.apache.maven.surefire.report.SimpleReportEntry.ignored;
+import static org.junit.platform.engine.TestExecutionResult.Status.ABORTED;
+import static org.junit.platform.engine.TestExecutionResult.Status.FAILED;
+
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+import org.apache.maven.surefire.report.PojoStackTraceWriter;
+import org.apache.maven.surefire.report.RunListener;
+import org.apache.maven.surefire.report.SimpleReportEntry;
+import org.apache.maven.surefire.report.StackTraceWriter;
+import org.junit.platform.engine.TestExecutionResult;
+import org.junit.platform.engine.TestSource;
+import org.junit.platform.engine.support.descriptor.ClassSource;
+import org.junit.platform.engine.support.descriptor.MethodSource;
+import org.junit.platform.launcher.TestExecutionListener;
+import org.junit.platform.launcher.TestIdentifier;
+import org.junit.platform.launcher.TestPlan;
+import org.junit.platform.launcher.listeners.LegacyReportingUtils;
+
+/**
+ * @since 2.22.0
+ */
+final class RunListenerAdapter
+implements TestExecutionListener
+{
+
+private final RunListener runListener;
+
+private TestPlan testPlan;
+
+private Set testSetNodes = ConcurrentHashMap.newKeySet();
+
+RunListenerAdapter( RunListener runListener )
+{
+this.runListener = runListener;
+}
+
+@Override
+public void testPlanExecutionStarted( TestPlan testPlan )
+{
+updateTestPlan( testPlan );
+}
+
+@Override
+public void testPlanExecutionFinished( TestPlan testPlan )
+{
+updateTestPlan( null );
+}
+
+@Override
+public void executionStarted( TestIdentifier testIdentifier )
+{
+if ( testIdentifier.isContainer()
+&& testIdentifier.getSource().filter(
ClassSource.class::isInstance ).isPresent() )
+{
+startTestSetIfPossible( testIdentifier );
+}
+if ( testIdentifier.isTest() )
+{
+ensureTestSetStarted( testIdentifier );
+runListener.testStarting( createReportEntry( testIdentifier ) );
+}
+}
+
+@Override
+public void executionSkipped( TestIdentifier testIdentifier, String reason
)
+{
+ensureTestSetStarted( testIdentifier );
+String source = getLegacyReportingClassName( testIdentifier );
+runListener.testSkipped( ignored( source, getLegacyReportingName(
testIdentifier ), reason ) );
+completeTestSetIfNecessary( testIdentifier );
+}
+
+@Override
+public void executionFinished(
+TestIdentifier testIdentifier, TestExecutionResult
testExecutionResult )
+{
+if ( testExecutionResult.getStatus() == ABORTED )
+{
+runListener.testAssumptionFailure( createReportEntry(
testIdentifier, testExecutionResult ) );
+}
+else if ( testExecutionResult.getStatus() == FAILED )
+{
+reportFailedTest( testIdentifier, testExecutionResult );
+}
+else if ( testIdentifier.isTest() )
+{
+runListener.testSucceeded( createReportEntry( testIdentifier ) );
+}
+completeTestSetIfNecessary( testIdentifier );
+}
+
+private void updateTestPlan( TestPlan testPlan )
+{
+this.testPlan = testPlan;
+testSetNodes.clear();
+}
+
+private void ensureTestSetStarted( TestIdentifier testIdentifier )
+{
+if ( isTestSetStarted( testIdentifier ) )
+{
+return;
+}
+if ( testIdentifier.isTest() )
+{
+startTestSet( testPlan.getParent( testIdentifier ).orElse(
testIdentifier ) );
+}
+
[GitHub] marcphilipp commented on issue #184: Donate current sources from junit-platform-surefire-provider
marcphilipp commented on issue #184: Donate current sources from junit-platform-surefire-provider URL: https://github.com/apache/maven-surefire/pull/184#issuecomment-395467748 Thanks @sormuras and @Tibor17 for getting this merged! I can't wait to use the released version! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] lpapazow opened a new pull request #75: add fileNamesOnly property to only show file names
lpapazow opened a new pull request #75: add fileNamesOnly property to only show file names URL: https://github.com/apache/maven-scm/pull/75 For my maven project I need to create a file that contains the relative paths of all the changed files. Instead of using a script file that calls `git diff --name-only`, I wanted to use this plugin. However, I couldn't find such an option in the documentation [here](https://maven.apache.org/scm/maven-scm-plugin/diff-mojo.html). I was able to "trick" the plugin by adding the properties `endScmVersionType=branch`, `endScmVersion="--name-only"`. However, this is not a very nice workaround so I would like to propose a `fileNamesOnly` boolean property to only show file names if true. Signed-off-by: Lyubomir V. Papazov This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MRESOURCES-132) Copying of files with permissions broken
[
https://issues.apache.org/jira/browse/MRESOURCES-132?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504445#comment-16504445
]
OLIVIER GERARDIN commented on MRESOURCES-132:
-
Issue still present in latest version (3.1.0). Must use a hack with
{{maven-antrun-plugin}} to perform a "chmod" before running a script that was
copied as a resource. The script is filtered so running the original one is not
an option.
Please reopen this issue and provide an option to preserve file permissions.
> Copying of files with permissions broken
>
>
> Key: MRESOURCES-132
> URL: https://issues.apache.org/jira/browse/MRESOURCES-132
> Project: Maven Resources Plugin
> Issue Type: Bug
> Components: copy
>Affects Versions: 2.4.3
> Environment: Apache Maven 2.2.1 (r801777; 2009-08-06 22:16:01+0300)
> Java version: 1.6.0_19
> Java home: /java/jdk1.6.0_19/jre
> Default locale: en_US, platform encoding: ISO-8859-1
> OS name: "linux" version: "2.6.28.5" arch: "i386" Family: "unix"
>Reporter: Martin Todorov
>Assignee: Karl Heinz Marbaise
>Priority: Major
>
> Files with permissions are not copied with the permissions as illustrated
> below:
> {noformat}
> root@carlspring:/java/opensource/build-force/zipper-plugin# ls -al `find .
> -name *perm*`
> -rwxr--r-- 1 root root 8 2010-12-09 20:48
> ./src/test/resources/zip/file.with.permission.sh*
> -rw-r--r-- 1 root root 8 2010-12-09 22:56
> ./target/test-classes/zip/file.with.permission.sh
> {noformat}
> Notice the 'x' permission missing from the copied file.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] sormuras commented on a change in pull request #184: Donate current sources from junit-platform-surefire-provider
sormuras commented on a change in pull request #184: Donate current sources
from junit-platform-surefire-provider
URL: https://github.com/apache/maven-surefire/pull/184#discussion_r193647689
##
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##
@@ -0,0 +1,272 @@
+package org.apache.maven.surefire.junitplatform;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import static org.apache.maven.surefire.report.SimpleReportEntry.ignored;
+import static org.junit.platform.engine.TestExecutionResult.Status.ABORTED;
+import static org.junit.platform.engine.TestExecutionResult.Status.FAILED;
+
+import java.util.Optional;
+import java.util.Set;
+import java.util.concurrent.ConcurrentHashMap;
+
+import org.apache.maven.surefire.report.PojoStackTraceWriter;
+import org.apache.maven.surefire.report.RunListener;
+import org.apache.maven.surefire.report.SimpleReportEntry;
+import org.apache.maven.surefire.report.StackTraceWriter;
+import org.junit.platform.engine.TestExecutionResult;
+import org.junit.platform.engine.TestSource;
+import org.junit.platform.engine.support.descriptor.ClassSource;
+import org.junit.platform.engine.support.descriptor.MethodSource;
+import org.junit.platform.launcher.TestExecutionListener;
+import org.junit.platform.launcher.TestIdentifier;
+import org.junit.platform.launcher.TestPlan;
+import org.junit.platform.launcher.listeners.LegacyReportingUtils;
+
+/**
+ * @since 2.22.0
+ */
+final class RunListenerAdapter
+implements TestExecutionListener
+{
+
+private final RunListener runListener;
+
+private TestPlan testPlan;
+
+private Set testSetNodes = ConcurrentHashMap.newKeySet();
+
+RunListenerAdapter( RunListener runListener )
+{
+this.runListener = runListener;
+}
+
+@Override
+public void testPlanExecutionStarted( TestPlan testPlan )
+{
+updateTestPlan( testPlan );
+}
+
+@Override
+public void testPlanExecutionFinished( TestPlan testPlan )
+{
+updateTestPlan( null );
+}
+
+@Override
+public void executionStarted( TestIdentifier testIdentifier )
+{
+if ( testIdentifier.isContainer()
+&& testIdentifier.getSource().filter(
ClassSource.class::isInstance ).isPresent() )
+{
+startTestSetIfPossible( testIdentifier );
+}
+if ( testIdentifier.isTest() )
+{
+ensureTestSetStarted( testIdentifier );
+runListener.testStarting( createReportEntry( testIdentifier ) );
+}
+}
+
+@Override
+public void executionSkipped( TestIdentifier testIdentifier, String reason
)
+{
+ensureTestSetStarted( testIdentifier );
+String source = getLegacyReportingClassName( testIdentifier );
+runListener.testSkipped( ignored( source, getLegacyReportingName(
testIdentifier ), reason ) );
+completeTestSetIfNecessary( testIdentifier );
+}
+
+@Override
+public void executionFinished(
+TestIdentifier testIdentifier, TestExecutionResult
testExecutionResult )
+{
+if ( testExecutionResult.getStatus() == ABORTED )
+{
+runListener.testAssumptionFailure( createReportEntry(
testIdentifier, testExecutionResult ) );
+}
+else if ( testExecutionResult.getStatus() == FAILED )
+{
+reportFailedTest( testIdentifier, testExecutionResult );
+}
+else if ( testIdentifier.isTest() )
+{
+runListener.testSucceeded( createReportEntry( testIdentifier ) );
+}
+completeTestSetIfNecessary( testIdentifier );
+}
+
+private void updateTestPlan( TestPlan testPlan )
+{
+this.testPlan = testPlan;
+testSetNodes.clear();
+}
+
+private void ensureTestSetStarted( TestIdentifier testIdentifier )
+{
+if ( isTestSetStarted( testIdentifier ) )
+{
+return;
+}
+if ( testIdentifier.isTest() )
+{
+startTestSet( testPlan.getParent( testIdentifier ).orElse(
testIdentifier ) );
+}
+
[jira] [Commented] (MPH-152) Enhance console output of "evaluate" goal to indicate result
[
https://issues.apache.org/jira/browse/MPH-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16504300#comment-16504300
]
Karl Heinz Marbaise commented on MPH-152:
-
The usage of evaluate related to output without creating a file is done in
MPH-144 which is part of the next release which is currently under VOTING on
dev list...
But about your point the evaluation status should be taken into account...which
sounds like a good idea...
> Enhance console output of "evaluate" goal to indicate result
>
>
> Key: MPH-152
> URL: https://issues.apache.org/jira/browse/MPH-152
> Project: Maven Help Plugin
> Issue Type: Improvement
> Components: evaluate
>Affects Versions: 3.0.1
>Reporter: Paul Benedict
>Priority: Minor
>
> I have two requirements for consideration:
> # Scripts should be able to easily get the resolution status.
> # Scripts should be able to easily get the resolved expression value.
> When evaluating an expression, the output does not have a good marker to help
> scripts identity the resolution. Current plugin behavior prints the value
> (practically buried among Maven's logging) or "null object or invalid
> expression" message.
> The {{-o}} option could be used, of course, but file creation is more
> overhead than necessary. But what is good about the {{-o}} option is that it
> prints a clear marker:
> {code:none}
> > mvn help:evaluate -Dexpression=settings.localRepository -Doutput=out.txt
> [INFO] Scanning for projects...
> . . .
> [INFO] Result of evaluation written to: c:\proj\out.txt{code}
> Can you consider something similar for the console?
> Example possible solutions:
> {code:none}
> > mvn help:evaluate -Dexpression=settings.localRepository
> [INFO] Scanning for projects...
> . . .
> [INFO] Result of evaluation: /home/joeuser/.m2/repository{code}
> And again:
> {code:none}
> > mvn help:evaluate -Dexpression=zzz
> [INFO] Scanning for projects...
> . . .
> [INFO] Result of evaluation: null{code}
> PS: If you think current behavior should be preserved, a new plugin option
> can be introduced. However, as [shown by this
> link|https://stackoverflow.com/questions/5916157/how-to-get-the-maven-local-repo-location],
> I think people have a difficult time clobbering together an answer to parse
> reliably. There are other examples on that site if you're interested. So I
> don't think any effort should be taken with introducing a new option. Just my
> 2 cents. Since the fragility already exists, just provide an "official"
> solution to remediate it.
> Thank you.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
