[jira] [Commented] (SUREFIRE-1430) Parallel parameterized JUnit test hangs on Linux
[ https://issues.apache.org/jira/browse/SUREFIRE-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507698#comment-16507698 ] Christian Beikov commented on SUREFIRE-1430: Great that you figured this out! Thanks for staying on top of this :) > Parallel parameterized JUnit test hangs on Linux > > > Key: SUREFIRE-1430 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1430 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.7+ (parallel) support >Affects Versions: 2.18, 2.18.1, 2.19, 2.19.1, 2.20, 2.20.1 > Environment: Linux/Ubuntu >Reporter: Christian Beikov >Assignee: Tibor Digana >Priority: Major > Fix For: 2.22.1 > > > This is a follow up of SUREFIRE-1264. The test case is here: > https://github.com/beikov/surefire-test > The problem is, that a simple parameterized JUnit test hangs when running in > parallel mode on Linux. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MDEP-617) Use plexus-java for showing module info during dependency:resolve
Robert Scholte created MDEP-617: --- Summary: Use plexus-java for showing module info during dependency:resolve Key: MDEP-617 URL: https://issues.apache.org/jira/browse/MDEP-617 Project: Maven Dependency Plugin Issue Type: Dependency upgrade Components: resolve Affects Versions: 3.1.1 Reporter: Robert Scholte Assignee: Robert Scholte The base for plexus-java was in this project. That library is now much stronger so the code should be replaced. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507494#comment-16507494
]
Michael Osipov commented on MNG-6391:
-
Looks good to me except this leading space:
{{[INFO] Reactor Summary (5.0.1-SNAPSHOT) :}}. It should read {{[INFO] Reactor
Summary (5.0.1-SNAPSHOT):}}.
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.5.4
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507487#comment-16507487
]
Karl Heinz Marbaise commented on MNG-6391:
--
So I have the following now for aggregator:
{code}
[INFO] --- maven-clean-plugin:2.5:clean (default-clean) @
maven-plugins-aggregator ---
[INFO]
[INFO] Reactor Summary:
[INFO]
[INFO] Apache Maven ACR Plugin 3.0.1-SNAPSHOT . SUCCESS [ 0.206 s]
[INFO] Apache Maven AntRun Plugin 3.0.0-SNAPSHOT .. SUCCESS [ 0.007 s]
[INFO] Apache Maven Changelog Plugin 2.4-SNAPSHOT . SUCCESS [ 0.006 s]
[INFO] Apache Maven Changes Plugin 3.0.0-SNAPSHOT . SUCCESS [ 0.017 s]
[INFO] Apache Maven Clean Plugin 3.0.1-SNAPSHOT ... SUCCESS [ 0.004 s]
[INFO] Apache Maven Compiler Plugin 3.7.1-SNAPSHOT SUCCESS [ 0.017 s]
[INFO] Apache Maven Deploy Plugin 3.0.0-SNAPSHOT .. SUCCESS [ 0.004 s]
[INFO] Apache Maven Documentation Checker Plugin 1.2-SNAPSHOT SUCCESS [ 0.037
s]
[INFO] Apache Maven EAR Plugin 3.0.0-SNAPSHOT . SUCCESS [ 0.003 s]
...
{code}
And the usual multi module build:
{code}
[INFO]
[INFO] Reactor Summary (5.0.1-SNAPSHOT) :
[INFO]
[INFO] parent . SUCCESS [ 0.227 s]
[INFO] domain . SUCCESS [ 0.011 s]
[INFO] service-client . SUCCESS [ 0.007 s]
[INFO] webgui . SUCCESS [ 0.013 s]
[INFO] service SUCCESS [ 0.007 s]
[INFO] app SUCCESS [ 0.006 s]
[INFO] appasm . SUCCESS [ 0.006 s]
[INFO] shade .. SUCCESS [ 0.005 s]
[INFO] assembly ... SUCCESS [ 0.005 s]
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 0.770 s
[INFO] Finished at: 2018-06-10T22:02:37+02:00
[INFO]
{code}
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.5.4
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MNG-5940) Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
[
https://issues.apache.org/jira/browse/MNG-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-5940.
---
Resolution: Fixed
Fix Version/s: (was: 3.5.4-candidate)
3.5.4
Fixed with
[5b4e173f7d7e84ebbe0a34de6f2a79559e490eb5|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=5b4e173f7d7e84ebbe0a34de6f2a79559e490eb5].
and
[dc40536effb28dea0bb481850f29dc22a8e49549|https://gitbox.apache.org/repos/asf?p=maven-site.git;a=commit;h=dc40536effb28dea0bb481850f29dc22a8e49549].
> Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
> ---
>
> Key: MNG-5940
> URL: https://issues.apache.org/jira/browse/MNG-5940
> Project: Maven
> Issue Type: Improvement
> Components: core
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> At the moment the {{maven-source-plugin:jar}} goal is defined in the Maven
> super pom:
> {code:xml}
>
> true
> maven-source-plugin
>
>
> attach-sources
>
> jar
>
>
>
>
> {code}
> where the goal of {{maven-source-plugin}} should be changed from {{jar}} into
> {{jar-no-fork}}, cause most of the time you need to override this behaviour.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSOURCES-95) When one of the source folders is empty the source jar is recreated even when sources not changed
[
https://issues.apache.org/jira/browse/MSOURCES-95?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507455#comment-16507455
]
ASF GitHub Bot commented on MSOURCES-95:
plamentotev opened a new pull request #1: [MSOURCES-95] Fix source Jar is
re-created even when sources are not changed
URL: https://github.com/apache/maven-source-plugin/pull/1
If there is an empty source directory (such as
`generated-sources/annotations` for example) the sources Jar will be re-created
even if the sources are not changed. The reason is the default include pattern
- `"**/*"`. It does not include the directory itself and if the directory is
empty there is no way for Plexus Archiver to know if the archive is up to date
(no file or directory to compare with the last modification time of the
archive), so it does the safe thing and re-creates the archive.
Change the default includes pattern to `"**/**"`. That will cause the empty
directory itself (generated-sources/annotations in our example) to be
considered when checking the last modification date so the
archive will not be re-created if it is up to date. Please note that the
change of the pattern will not change what is included in the archive - the
directory itself will not be included, only its content.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> When one of the source folders is empty the source jar is recreated even when
> sources not changed
> -
>
> Key: MSOURCES-95
> URL: https://issues.apache.org/jira/browse/MSOURCES-95
> Project: Maven Source Plugin
> Issue Type: Bug
>Reporter: Plamen Totev
>Priority: Minor
> Attachments: reproduce-project.zip
>
>
> There is issue opened in Plexus Archive project -
> https://github.com/codehaus-plexus/plexus-archiver/issues/24
> In short if you download the attached zip and build it several times you'll
> see that the source jar is build every time no matter that the source are not
> changed. That's because {{target/generated-sources/annotations}} is empty. I
> think the reason for this behavior is that the default inclusion pattern in
> {{AbstractSourceJarMojo}} is {{\*\*/\*}}. If it's {{\*\*/\*\*}} then the jar
> will not be rebuilded. Is there any reason why it's {{\*\*/\*}} and not
> {{\*\*/\*\*}} ?
> In the next paragraphs I'll try to explain why the second patter work and the
> first not.
> Let's say we have the following directory:
> {code}
> + src
> +--+ main
>+--+ java
>+--+ app
>| +--+ App.java
>|
>+--+ empty_dir
> {code}
> when added to {{JarArchiver}} with prefix "" (empty string) this is how
> Plexus Archiver "sees" them:
> {code}
> src/main/java -> "" (empty string)
> src/main/java/app -> "app"
> src/main/java/app/App.java -> "app/App.java"
> src/main/java/empty_dir -> "empty_dir"
> {code}
> To decide which entries to add Plexus Archives applies inclusion and
> exclusion patterns. Internally it uses
> {{org.codehaus.plexus.util.DirectoryScanner}}
> (https://github.com/codehaus-plexus/plexus-utils/blob/master/src/main/java/org/codehaus/plexus/util/DirectoryScanner.java).
> The JavaDoc contains nice explanation how the patterns are applied but in
> the next paragraph I'll try to explain in short what happens.
> When the pattern is set to {{\*\*/\*}} it will match all but /src/main/java
> ("app", "app/App.java", "empty_dir"). This is because the pattern matches
> zero or more path segments, followed by any path segment. src/main/java is
> mapped to "" so the pattern will not match it (it's empty path segment
> followed by nothing). So far so good. But what if the source directory is
> empty(src/main/java). Then nothing will be matched and we'll end with empty
> resource collection to add to the archive. And because it's empty there is no
> way to know when it was last modified so Plexus Archiver will do the safe
> thing and recreate the archive. After all when the archive was created the
> pattern may have matched something and the archive is not empty so it's
> outdated.
> What if the pattern is set to {{\*\*/\*\*}} it will match "", "app",
> "app/App.java" and "empty_dir". That's because it matches zero or more path
> segments, followed by zero or more path segments - in other words everything
> (my understanding is that it's the same as {{\*\*}} - match everything). So
> if /src/main/java is empty we'll end up with collection containing only "" -
> file resource with empty name. Because of the empty name it
[GitHub] plamentotev opened a new pull request #1: [MSOURCES-95] Fix source Jar is re-created even when sources are not changed
plamentotev opened a new pull request #1: [MSOURCES-95] Fix source Jar is re-created even when sources are not changed URL: https://github.com/apache/maven-source-plugin/pull/1 If there is an empty source directory (such as `generated-sources/annotations` for example) the sources Jar will be re-created even if the sources are not changed. The reason is the default include pattern - `"**/*"`. It does not include the directory itself and if the directory is empty there is no way for Plexus Archiver to know if the archive is up to date (no file or directory to compare with the last modification time of the archive), so it does the safe thing and re-creates the archive. Change the default includes pattern to `"**/**"`. That will cause the empty directory itself (generated-sources/annotations in our example) to be considered when checking the last modification date so the archive will not be re-created if it is up to date. Please note that the change of the pattern will not change what is included in the archive - the directory itself will not be included, only its content. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] slachiewicz opened a new pull request #170: Fixed typo in exception logging
slachiewicz opened a new pull request #170: Fixed typo in exception logging URL: https://github.com/apache/maven/pull/170 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6344) Upgrade Guice to 4.2.0
[
https://issues.apache.org/jira/browse/MNG-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507400#comment-16507400
]
ASF GitHub Bot commented on MNG-6344:
-
rfscholte commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP
(cglib)
URL: https://github.com/apache/maven/pull/169#issuecomment-396052607
/cc @mcculls
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade Guice to 4.2.0
> --
>
> Key: MNG-6344
> URL: https://issues.apache.org/jira/browse/MNG-6344
> Project: Maven
> Issue Type: Dependency upgrade
>Affects Versions: 3.5.2
>Reporter: Sylwester Lachiewicz
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> A new version is available from
> [https://github.com/google/guice/wiki/Guice41] (released in 2016) - we should
> consider update.
> While updating - Maven depends on Guice, but with removed AOP code.
> {code:java}
> org.apache.maven:maven-core:jar:3.5.3-SNAPSHOT
> \- com.google.inject:guice:jar:no_aop:4.0:compile
> \- aopalliance:aopalliance:jar:1.0:compile{code}
> This has impact on performance
> [https://github.com/google/guice/wiki/OptionalAOP]
> If we decide to keep no_aop version, probably dependency to aopalliance can
> be removed (4kb).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] rfscholte commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP (cglib)
rfscholte commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP (cglib) URL: https://github.com/apache/maven/pull/169#issuecomment-396052607 /cc @mcculls This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (DOXIA-576) Upgrade Http Components to 4.4.5
[ https://issues.apache.org/jira/browse/DOXIA-576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507394#comment-16507394 ] ASF GitHub Bot commented on DOXIA-576: -- slachiewicz opened a new pull request #12: DOXIA-576 Upgrade Http Components to 4.4.5 URL: https://github.com/apache/maven-doxia/pull/12 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Upgrade Http Components to 4.4.5 > > > Key: DOXIA-576 > URL: https://issues.apache.org/jira/browse/DOXIA-576 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > > Upgrade dependency version to address security improvements -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (DOXIA-576) Upgrade Http Components to 4.4.5
Sylwester Lachiewicz created DOXIA-576: -- Summary: Upgrade Http Components to 4.4.5 Key: DOXIA-576 URL: https://issues.apache.org/jira/browse/DOXIA-576 Project: Maven Doxia Issue Type: Dependency upgrade Reporter: Sylwester Lachiewicz Upgrade dependency version to address security improvements -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SUREFIRE-1430) Parallel parameterized JUnit test hangs on Linux
[ https://issues.apache.org/jira/browse/SUREFIRE-1430?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1430: --- Fix Version/s: (was: 3.0.0-M1) 2.22.1 > Parallel parameterized JUnit test hangs on Linux > > > Key: SUREFIRE-1430 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1430 > Project: Maven Surefire > Issue Type: Bug > Components: Junit 4.7+ (parallel) support >Affects Versions: 2.18, 2.18.1, 2.19, 2.19.1, 2.20, 2.20.1 > Environment: Linux/Ubuntu >Reporter: Christian Beikov >Assignee: Tibor Digana >Priority: Major > Fix For: 2.22.1 > > > This is a follow up of SUREFIRE-1264. The test case is here: > https://github.com/beikov/surefire-test > The problem is, that a simple parameterized JUnit test hangs when running in > parallel mode on Linux. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1523) Adding item to JceKeyStore fails when non-forking with JDK 8_171
[
https://issues.apache.org/jira/browse/SUREFIRE-1523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507378#comment-16507378
]
Tibor Digana commented on SUREFIRE-1523:
[~Cousjath]
I do not think Surefire is related to this issue.
The JDK 1.8 broke SSL compatibility. I am convinced subversion u171 is the root
cause and not forking mechanism.
Go to directory target/surefire-reports and open the *.XML files and you will
see {{java.home}}. It is right java home?
> Adding item to JceKeyStore fails when non-forking with JDK 8_171
>
>
> Key: SUREFIRE-1523
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1523
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.21.0
>Reporter: Jonathan Coustick
>Priority: Major
>
> When putting an item in a JceKeyStore in Java 1.8.0_171 where forkCount is 0
> it fails with InvalidSecretKeyFormat. This does not occur in Java 1.8.0_162
> or when forkCount is 1.
> The full stacktrace is:
> {{}}
> {code:java}
> java.io.IOException: Invalid secret key format
> at com.sun.crypto.provider.JceKeyStore.engineLoad(JceKeyStore.java:856)
> at java.security.KeyStore.load(KeyStore.java:1445)
> at
> fish.payara.jcekstest.PasswordAdapter.loadKeyStore(PasswordAdapter.java:116)
> at
> fish.payara.jcekstest.PasswordAdapter.writeKeyStoreSafe(PasswordAdapter.java:303)
> at
> fish.payara.jcekstest.PasswordAdapter.writeStore(PasswordAdapter.java:184)
> at
> fish.payara.jcekstest.PasswordAdapter.setPasswordForAlias(PasswordAdapter.java:202)
> at
> fish.payara.jcekstest.JCEKSPasswordAliasStore.put(JCEKSPasswordAliasStore.java:104)
> at
> fish.payara.jcekstest.PasswordAliasTest.checkStoreAndGetPWByAlias(PasswordAliasTest.java:97)
> at
> fish.payara.jcekstest.PasswordAliasTest.checkLongPW(PasswordAliasTest.java:93)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
> at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
> at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:365)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:273)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:238)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.apache.maven.surefire.util.ReflectionUtils.invokeMethodWithArray2(ReflectionUtils.java:206)
> at
> org.apache.maven.surefire.booter.ProviderFactory$ProviderProxy.invoke(ProviderFactory.java:160)
> at
> org.apache.maven.surefire.booter.ProviderFactory.invokeProvider(ProviderFactory.java:83)
> at
> org.apache.maven.plugin.surefire.InPluginVMSurefireStarter.runSuitesInProcess(InPluginVMSurefireStarter.java:87)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1132)
> at
>
[jira] [Closed] (SUREFIRE-1330) JUnit 5 surefire-provider code donation
[ https://issues.apache.org/jira/browse/SUREFIRE-1330?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1330. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=a13261467549d257bb9580847ffa7531e730b7f5 > JUnit 5 surefire-provider code donation > --- > > Key: SUREFIRE-1330 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1330 > Project: Maven Surefire > Issue Type: New Feature >Reporter: Benedikt Ritter >Assignee: Tibor Digana >Priority: Major > Labels: junit5 > Fix For: 2.22.0 > > Attachments: junit-platform-surefire-provider.zip > > > The JUnit team wishes to contribute their surefire provider implementation > for JUnit 5 to the Maven team. > The code is currently located at GitHub: > https://github.com/junit-team/junit5/tree/master/junit-platform-surefire-provider > They have recently relicensed the code under terms of Apache License 2.0: > https://github.com/junit-team/junit5/issues/541 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507364#comment-16507364
]
Michael Osipov commented on MNG-6391:
-
I agree with Robert. I don't see a need to add an extra line which will appear
or disappear. One version per parent if reactor, otherwise one version per
aggregator module.
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.5.4
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-5940) Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
[
https://issues.apache.org/jira/browse/MNG-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507363#comment-16507363
]
Hudson commented on MNG-5940:
-
Build unstable in Jenkins: Maven TLP » maven » master #23
See https://builds.apache.org/job/maven-box/job/maven/job/master/23/
> Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
> ---
>
> Key: MNG-5940
> URL: https://issues.apache.org/jira/browse/MNG-5940
> Project: Maven
> Issue Type: Improvement
> Components: core
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> At the moment the {{maven-source-plugin:jar}} goal is defined in the Maven
> super pom:
> {code:xml}
>
> true
> maven-source-plugin
>
>
> attach-sources
>
> jar
>
>
>
>
> {code}
> where the goal of {{maven-source-plugin}} should be changed from {{jar}} into
> {{jar-no-fork}}, cause most of the time you need to override this behaviour.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507359#comment-16507359
]
Robert Scholte commented on MNG-6391:
-
I thought the conclusion was: only drop the version from the last line, keep
the first one. In case the version is different compared to its parent the
version will be added to the summary too. I'd prefer to keep the version after
the module line when required.
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.5.4
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6344) Upgrade Guice to 4.2.0
[
https://issues.apache.org/jira/browse/MNG-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507350#comment-16507350
]
ASF GitHub Bot commented on MNG-6344:
-
slachiewicz commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP
(cglib)
URL: https://github.com/apache/maven/pull/169#issuecomment-396041950
Based on [Guice optional
AOP](https://github.com/google/guice/wiki/OptionalAOP#optional-aop)
> In Guice 2.0 and later, AOP is optional. If your platform doesn't support
bytecode generation, you can download a version of Guice that doesn't include
AOP support. This is most useful for mobile platforms like Android. This
version also lacks fast reflection and line numbers in error messages. For this
reason, we recommend Guice+AOP even in applications that don't use method
interceptors.
Only risk I can see is inclusion of additional dependency to CGLIB and ASM
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade Guice to 4.2.0
> --
>
> Key: MNG-6344
> URL: https://issues.apache.org/jira/browse/MNG-6344
> Project: Maven
> Issue Type: Dependency upgrade
>Affects Versions: 3.5.2
>Reporter: Sylwester Lachiewicz
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> A new version is available from
> [https://github.com/google/guice/wiki/Guice41] (released in 2016) - we should
> consider update.
> While updating - Maven depends on Guice, but with removed AOP code.
> {code:java}
> org.apache.maven:maven-core:jar:3.5.3-SNAPSHOT
> \- com.google.inject:guice:jar:no_aop:4.0:compile
> \- aopalliance:aopalliance:jar:1.0:compile{code}
> This has impact on performance
> [https://github.com/google/guice/wiki/OptionalAOP]
> If we decide to keep no_aop version, probably dependency to aopalliance can
> be removed (4kb).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] slachiewicz commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP (cglib)
slachiewicz commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP (cglib) URL: https://github.com/apache/maven/pull/169#issuecomment-396041950 Based on [Guice optional AOP](https://github.com/google/guice/wiki/OptionalAOP#optional-aop) > In Guice 2.0 and later, AOP is optional. If your platform doesn't support bytecode generation, you can download a version of Guice that doesn't include AOP support. This is most useful for mobile platforms like Android. This version also lacks fast reflection and line numbers in error messages. For this reason, we recommend Guice+AOP even in applications that don't use method interceptors. Only risk I can see is inclusion of additional dependency to CGLIB and ASM This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6386) ${project.baseUri} is not a valid URI (according to RFC 3986)
[
https://issues.apache.org/jira/browse/MNG-6386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507346#comment-16507346
]
Hudson commented on MNG-6386:
-
Build unstable in Jenkins: Maven TLP » maven » MNG-6391 #6
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6391/6/
> ${project.baseUri} is not a valid URI (according to RFC 3986)
> -
>
> Key: MNG-6386
> URL: https://issues.apache.org/jira/browse/MNG-6386
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.5.4
>
>
> {{File#toURI}} produces an invalid URI on Windows:
> {noformat}
> file:/C:/path/to/basedir{noformat}
> A valid URI has to be:
> {noformat}
> file:///C:/path/to/basedir{noformat}
> Same issue for Unix-like OSes:
> {noformat}
> file:/path/to/basedir{noformat}
> A valid URI has to be:
> {noformat}
> file:///path/to/basedir{noformat}
> Using {{Path#toUri}} we can easily solve that problem because it creates
> compliant URIs. The failure occurs when interacting with local Git and
> Subversion repos:
> {noformat}
> PS D:\Entwicklung\Projekte\maven-scm> svn ls
> file:/D:/Entwicklung/svn-repos/scm-svn-test-at-sign
> svn: E020024: Error resolving case of
> 'file:\D:\Entwicklung\svn-repos\scm-svn-test-at-sign'
> while the proper (new) havior will produce a valid URI:
> PS D:\Entwicklung\Projekte\maven-scm> svn ls
> file:///D:/Entwicklung/svn-repos/scm-svn-test-at-sign
> branches/
> tags/
> trunk/
> {noformat}
> {noformat}
> PS D:\Entwicklung\Projekte> git clone file:///D:/Entwicklung/git-repos/toll
> tlll2
> Cloning into 'tlll2'...
> warning: You appear to have cloned an empty repository.
> PS D:\Entwicklung\Projekte> git clone file:/D:/Entwicklung/git-repos/toll
> tlll2
> Cloning into 'tlll2'...
> ssh: Could not resolve hostname file: Name or service not known
> fatal: Could not read from remote repository.
> {noformat}
> or Subversion repo at: {{D:\Entwicklung\svn-repos\это по-русский}}:
> {noformat}
> PS D:\Entwicklung\Projekte> svn ls
> file:/D:/Entwicklung/svn-repos/это%20по-русский/
> svn: E020024: Error resolving case of
> 'file:\D:\Entwicklung\svn-repos\???%20??-???\'
> {noformat}
> proper URI gives:
> {noformat}
> PS D:\Entwicklung\Projekte> svn ls
> file:///D:/Entwicklung/svn-repos/%D1%8D%D1%82%D0%BE%20%D0%BF%D0%BE-%D1%80%D1%83%D1%81%D1%81%D0%BA%D0%B8%D0%B9/
> branches/
> tags/
> trunk/
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] asfgit closed pull request #168: [MNG-5940]: Super POM: jar-no-fork
asfgit closed pull request #168: [MNG-5940]: Super POM: jar-no-fork URL: https://github.com/apache/maven/pull/168 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.xml b/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.xml index 8c26f71991..b19a7d7b7a 100644 --- a/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.xml +++ b/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.xml @@ -117,7 +117,7 @@ under the License. attach-sources - jar + jar-no-fork This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-5940) Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
[
https://issues.apache.org/jira/browse/MNG-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507347#comment-16507347
]
Hudson commented on MNG-5940:
-
Build succeeded in Jenkins: Maven TLP » maven-site » master #24
See https://builds.apache.org/job/maven-box/job/maven-site/job/master/24/
> Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
> ---
>
> Key: MNG-5940
> URL: https://issues.apache.org/jira/browse/MNG-5940
> Project: Maven
> Issue Type: Improvement
> Components: core
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> At the moment the {{maven-source-plugin:jar}} goal is defined in the Maven
> super pom:
> {code:xml}
>
> true
> maven-source-plugin
>
>
> attach-sources
>
> jar
>
>
>
>
> {code}
> where the goal of {{maven-source-plugin}} should be changed from {{jar}} into
> {{jar-no-fork}}, cause most of the time you need to override this behaviour.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-5940) Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
[
https://issues.apache.org/jira/browse/MNG-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507348#comment-16507348
]
ASF GitHub Bot commented on MNG-5940:
-
asfgit closed pull request #168: [MNG-5940]: Super POM: jar-no-fork
URL: https://github.com/apache/maven/pull/168
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.xml
b/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.xml
index 8c26f71991..b19a7d7b7a 100644
---
a/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.xml
+++
b/maven-model-builder/src/main/resources/org/apache/maven/model/pom-4.0.0.xml
@@ -117,7 +117,7 @@ under the License.
attach-sources
- jar
+ jar-no-fork
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Change the maven-source-plugin jar goal into jar-no-fork in Maven Super POM
> ---
>
> Key: MNG-5940
> URL: https://issues.apache.org/jira/browse/MNG-5940
> Project: Maven
> Issue Type: Improvement
> Components: core
>Reporter: Karl Heinz Marbaise
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4-candidate
>
>
> At the moment the {{maven-source-plugin:jar}} goal is defined in the Maven
> super pom:
> {code:xml}
>
> true
> maven-source-plugin
>
>
> attach-sources
>
> jar
>
>
>
>
> {code}
> where the goal of {{maven-source-plugin}} should be changed from {{jar}} into
> {{jar-no-fork}}, cause most of the time you need to override this behaviour.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] sormuras commented on issue #165: Merge master to junit5
sormuras commented on issue #165: Merge master to junit5 URL: https://github.com/apache/maven-surefire/pull/165#issuecomment-396040504 > Thx for your excellent job! This. ⏫ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 commented on issue #165: Merge master to junit5
Tibor17 commented on issue #165: Merge master to junit5 URL: https://github.com/apache/maven-surefire/pull/165#issuecomment-396040259 @britter You can close this. We are releasing JUnit5 provider right now. Thx for your excellent job! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] Tibor17 closed pull request #183: junit5
Tibor17 closed pull request #183: junit5
URL: https://github.com/apache/maven-surefire/pull/183
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
index 34f805a8b..dcfabaec2 100644
---
a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
+++
b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
@@ -1024,6 +1024,7 @@ private void createDependencyResolver()
new TestNgProviderInfo( getTestNgArtifact() ),
new JUnitCoreProviderInfo( getJunitArtifact(),
junitDepArtifact ),
new JUnit4ProviderInfo( getJunitArtifact(),
junitDepArtifact ),
+ new JUnitPlattformProviderInfo(
getJunitArtifact() ),
new JUnit3ProviderInfo() )
.resolve();
}
@@ -1540,7 +1541,17 @@ private boolean isAnyJunit4( Artifact artifact )
return dependencyResolver.isWithinVersionSpec( artifact, "[4.0,)" );
}
-static boolean isForkModeNever( String forkMode )
+private boolean isJunitJupiter( Artifact artifact )
+{
+return dependencyResolver.isWithinVersionSpec( artifact, "[5.0.0,)" );
+}
+
+private boolean isJunitVintage( Artifact artifact )
+{
+return dependencyResolver.isWithinVersionSpec( artifact,
"[4.12.0,5.0.0)" );
+}
+
+private static boolean isForkModeNever( String forkMode )
{
return FORK_NEVER.equals( forkMode );
}
@@ -2873,6 +2884,39 @@ public Classpath getProviderClasspath()
}
+final class JUnitPlattformProviderInfo
+implements ProviderInfo
+{
+private final Artifact junitArtifact;
+
+JUnitPlattformProviderInfo( Artifact junitArtifact )
+{
+this.junitArtifact = junitArtifact;
+}
+
+@Nonnull public String getProviderName()
+{
+return
"org.apache.maven.surefire.junitplatform.JUnitPlatformProvider";
+}
+
+public boolean isApplicable()
+{
+return isJunitJupiter( junitArtifact ) || isJunitVintage(
junitArtifact );
+}
+
+public void addProviderProperties() throws MojoExecutionException
+{
+}
+
+public Classpath getProviderClasspath()
+throws ArtifactResolutionException, ArtifactNotFoundException
+{
+return dependencyResolver.getProviderClasspath(
"surefire-junit-platform",
+
surefireBooterArtifact.getBaseVersion(),
+null );
+}
+}
+
final class JUnitCoreProviderInfo
implements ProviderInfo
{
diff --git a/pom.xml b/pom.xml
index 5fdefd414..96a75a47f 100644
--- a/pom.xml
+++ b/pom.xml
@@ -97,8 +97,9 @@
surefire-archives/surefire-LATEST
${java.home}/..
-1.6
-1.6
+6
+1.${javaVersion}
+1.${javaVersion}
-server -XX:+UseG1GC -Xms128m -Xmx144m
-XX:+TieredCompilation -XX:TieredStopAtLevel=1 -XX:SoftRefLRUPolicyMSPerMB=50
-Djava.awt.headless=true
@@ -419,6 +420,7 @@
org.codehaus.plexus:plexus-java
org.ow2.asm:asm
+ org.junit.platform:junit-platform-commons
org.objectweb.asm.*
@@ -550,6 +552,7 @@
org.codehaus.plexus:plexus-java
org.ow2.asm:asm
+
org.junit.platform:junit-platform-commons
diff --git a/surefire-its/pom.xml b/surefire-its/pom.xml
index 88a487046..d4c7df4d3 100644
--- a/surefire-its/pom.xml
+++ b/surefire-its/pom.xml
@@ -104,7 +104,9 @@
once
-server -Xmx64m -XX:+UseG1GC -XX:+TieredCompilation
-XX:TieredStopAtLevel=1 -Djava.awt.headless=true
-org/apache/**/*IT*.java
+org/apache/**/JUnit4VersionsIT.java
+org/apache/**/JUnit5IT.java
+org/apache/**/JUnitPlatformIT.java
@@ -142,25 +144,6 @@
-
-maven-enforcer-plugin
-
-
-require-maven-2.1.0
-
- enforce
-
-
-
-
-
- [2.1.0,)
-
-
-
-
[jira] [Commented] (MSHARED-734) Upgrade maven-shared-utils to 3.2.1
[ https://issues.apache.org/jira/browse/MSHARED-734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507344#comment-16507344 ] Hudson commented on MSHARED-734: Build succeeded in Jenkins: Maven TLP » maven-verifier » POMCLEANUP #2 See https://builds.apache.org/job/maven-box/job/maven-verifier/job/POMCLEANUP/2/ > Upgrade maven-shared-utils to 3.2.1 > --- > > Key: MSHARED-734 > URL: https://issues.apache.org/jira/browse/MSHARED-734 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-verifier >Affects Versions: maven-verifier-3.0.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: maven-verifier-3.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507334#comment-16507334
]
Karl Heinz Marbaise commented on MNG-6391:
--
Ok we can conclude to have the version in case of a multi module build with a
single version like this:
{code}
[INFO]
[INFO] Reactor Summary (4.0.0-SNAPSHOT):
[INFO]
{code}
and in cases where we have an aggregator after each module?
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.5.4
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6344) Upgrade Guice to 4.2.0
[
https://issues.apache.org/jira/browse/MNG-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507329#comment-16507329
]
ASF GitHub Bot commented on MNG-6344:
-
michael-o commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP
(cglib)
URL: https://github.com/apache/maven/pull/169#issuecomment-396037165
What is the benefit of having it with AOP?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade Guice to 4.2.0
> --
>
> Key: MNG-6344
> URL: https://issues.apache.org/jira/browse/MNG-6344
> Project: Maven
> Issue Type: Dependency upgrade
>Affects Versions: 3.5.2
>Reporter: Sylwester Lachiewicz
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> A new version is available from
> [https://github.com/google/guice/wiki/Guice41] (released in 2016) - we should
> consider update.
> While updating - Maven depends on Guice, but with removed AOP code.
> {code:java}
> org.apache.maven:maven-core:jar:3.5.3-SNAPSHOT
> \- com.google.inject:guice:jar:no_aop:4.0:compile
> \- aopalliance:aopalliance:jar:1.0:compile{code}
> This has impact on performance
> [https://github.com/google/guice/wiki/OptionalAOP]
> If we decide to keep no_aop version, probably dependency to aopalliance can
> be removed (4kb).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] slachiewicz commented on issue #160: Fix links to Apache/CDDL/MIT licenses
slachiewicz commented on issue #160: Fix links to Apache/CDDL/MIT licenses URL: https://github.com/apache/maven/pull/160#issuecomment-396037168 MNG-6414 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michael-o commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP (cglib)
michael-o commented on issue #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP (cglib) URL: https://github.com/apache/maven/pull/169#issuecomment-396037165 What is the benefit of having it with AOP? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] slachiewicz closed pull request #160: Fix links to Apache/CDDL/MIT licenses
slachiewicz closed pull request #160: Fix links to Apache/CDDL/MIT licenses
URL: https://github.com/apache/maven/pull/160
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm
b/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm
index 390fa42530..065c613ac4 100644
--- a/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm
+++ b/apache-maven/src/main/appended-resources/META-INF/LICENSE.vm
@@ -21,19 +21,23 @@ Apache Maven includes a number of components and libraries
with separate
copyright notices and license terms. Your use of those components are
subject to the terms and conditions of the following licenses.
-#set ( $apacheTxt = "The Apache Software License, Version 2.0" )
-
+#set ( $apacheLicTexts = [ "Apache License, Version 2.0", "The Apache Software
License, Version 2.0",
+"ASLv2", "Apache Public License 2.0" ] )
#foreach ( $project in $projects )
#foreach ( $license in $project.licenses)
-#if ( ! ($apacheTxt == $license.name) )
+#if ( !($apacheLicTexts.contains( $license.name)) )
#set ( $artId = $project.artifact.artifactId)
#set ( $lf = $locator )
#set ( $url = $license.url )
## glass fish URL is now invalid, use a fixed one
#if ($url == "https://glassfish.dev.java.net/public/CDDLv1.0.html;)
-#set ( $url = 'https://glassfish.java.net/public/CDDLv1.0.html' )
+#set ( $url = 'https://spdx.org/licenses/CDDL-1.0.txt' )
+#end
+## jcl-over-slf4j - redirect
+#if ($url == "http://www.opensource.org/licenses/mit-license.php;)
+#set ( $url = 'https://spdx.org/licenses/MIT.txt' )
#end
-#if ($url)
+#if ($url)
#set ( $licFile = 'lib/' + $artId + '.license' )
#set ( $downloaded = $lf.getResourceAsFile($url, "licenses/${licFile}") )
#end
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MNG-6344) Upgrade Guice to 4.2.0
[
https://issues.apache.org/jira/browse/MNG-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507328#comment-16507328
]
ASF GitHub Bot commented on MNG-6344:
-
slachiewicz opened a new pull request #169: [MNG-6344] Upgrade Guice to 4.2 wit
AOP (cglib)
URL: https://github.com/apache/maven/pull/169
I provide it, if someone could run tests on it and check on larger projects.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Upgrade Guice to 4.2.0
> --
>
> Key: MNG-6344
> URL: https://issues.apache.org/jira/browse/MNG-6344
> Project: Maven
> Issue Type: Dependency upgrade
>Affects Versions: 3.5.2
>Reporter: Sylwester Lachiewicz
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> A new version is available from
> [https://github.com/google/guice/wiki/Guice41] (released in 2016) - we should
> consider update.
> While updating - Maven depends on Guice, but with removed AOP code.
> {code:java}
> org.apache.maven:maven-core:jar:3.5.3-SNAPSHOT
> \- com.google.inject:guice:jar:no_aop:4.0:compile
> \- aopalliance:aopalliance:jar:1.0:compile{code}
> This has impact on performance
> [https://github.com/google/guice/wiki/OptionalAOP]
> If we decide to keep no_aop version, probably dependency to aopalliance can
> be removed (4kb).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] slachiewicz opened a new pull request #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP (cglib)
slachiewicz opened a new pull request #169: [MNG-6344] Upgrade Guice to 4.2 wit AOP (cglib) URL: https://github.com/apache/maven/pull/169 I provide it, if someone could run tests on it and check on larger projects. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6344) Upgrade Guice to 4.2.0
[
https://issues.apache.org/jira/browse/MNG-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507325#comment-16507325
]
Hudson commented on MNG-6344:
-
Build succeeded in Jenkins: Maven TLP » maven » master #22
See https://builds.apache.org/job/maven-box/job/maven/job/master/22/
> Upgrade Guice to 4.2.0
> --
>
> Key: MNG-6344
> URL: https://issues.apache.org/jira/browse/MNG-6344
> Project: Maven
> Issue Type: Dependency upgrade
>Affects Versions: 3.5.2
>Reporter: Sylwester Lachiewicz
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> A new version is available from
> [https://github.com/google/guice/wiki/Guice41] (released in 2016) - we should
> consider update.
> While updating - Maven depends on Guice, but with removed AOP code.
> {code:java}
> org.apache.maven:maven-core:jar:3.5.3-SNAPSHOT
> \- com.google.inject:guice:jar:no_aop:4.0:compile
> \- aopalliance:aopalliance:jar:1.0:compile{code}
> This has impact on performance
> [https://github.com/google/guice/wiki/OptionalAOP]
> If we decide to keep no_aop version, probably dependency to aopalliance can
> be removed (4kb).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16507321#comment-16507321
]
Michael Osipov commented on MNG-6391:
-
Can we conclude this finally? Let's drop the last printed version if it part of
the reactor.
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.5.4
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MNG-6364) Enhanced Jenkinsfile to test Core with JDK 9
[ https://issues.apache.org/jira/browse/MNG-6364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6364. --- Resolution: Fixed Fixed with [3af07f898e71b1d2fdca6d617a03f7723637b799|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=3af07f898e71b1d2fdca6d617a03f7723637b799]. > Enhanced Jenkinsfile to test Core with JDK 9 > > > Key: MNG-6364 > URL: https://issues.apache.org/jira/browse/MNG-6364 > Project: Maven > Issue Type: Improvement > Components: Bootstrap Build >Affects Versions: 3.5.3 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.5.4 > > > currently, Maven core is build with one configuration OS+JDK+Maven > then it is tested (ie [Maven Core ITs|https://maven.apache.org/core-its/] > are built and executed) in misc configurations: > - Java 7 and Java 8 > - Linux and Windows > Now that Java 9 and even Java 10 are out, it would be useful to add Java 9 > and even Java 10 to the tests -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MNG-6344) Upgrade Guice to 4.2.0
[
https://issues.apache.org/jira/browse/MNG-6344?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6344.
---
Resolution: Fixed
Fix Version/s: (was: 3.5.4-candidate)
3.5.4
Fixed with
[29e9b50b8bdd6abd454ef84d3247a5fe36bc79f3|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=29e9b50b8bdd6abd454ef84d3247a5fe36bc79f3].
> Upgrade Guice to 4.2.0
> --
>
> Key: MNG-6344
> URL: https://issues.apache.org/jira/browse/MNG-6344
> Project: Maven
> Issue Type: Dependency upgrade
>Affects Versions: 3.5.2
>Reporter: Sylwester Lachiewicz
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.5.4
>
>
> A new version is available from
> [https://github.com/google/guice/wiki/Guice41] (released in 2016) - we should
> consider update.
> While updating - Maven depends on Guice, but with removed AOP code.
> {code:java}
> org.apache.maven:maven-core:jar:3.5.3-SNAPSHOT
> \- com.google.inject:guice:jar:no_aop:4.0:compile
> \- aopalliance:aopalliance:jar:1.0:compile{code}
> This has impact on performance
> [https://github.com/google/guice/wiki/OptionalAOP]
> If we decide to keep no_aop version, probably dependency to aopalliance can
> be removed (4kb).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
