[GitHub] olamy closed pull request #1: Update Maven Compiler and Surefire plugins
olamy closed pull request #1: Update Maven Compiler and Surefire plugins URL: https://github.com/apache/maven-archetypes/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/plugin-versions.properties b/plugin-versions.properties index 6252126..6688754 100644 --- a/plugin-versions.properties +++ b/plugin-versions.properties @@ -3,8 +3,8 @@ site 3.7 install 2.5.2 deploy2.8.2 resources 3.0.2 -compiler 3.7.0 -surefire 2.20.1 +compiler 3.8.0 +surefire 2.22.1 jar 3.0.2 ejb 3.0.0 plugin3.5.1 @@ -14,4 +14,4 @@ rar 2.4 archetype 3.0.1 invoker 3.0.1 pir 2.9 -javadoc 3.0.0 \ No newline at end of file +javadoc 3.0.0 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] spiritualops commented on issue #1: [MASSEMBLY-775] remove false OS-specific warnings/errors
spiritualops commented on issue #1: [MASSEMBLY-775] remove false OS-specific warnings/errors URL: https://github.com/apache/maven-assembly-plugin/pull/1#issuecomment-429575189 One last thing, don't forget to bump the patch version in the pom. ;) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MASSEMBLY-775) Emit WARNING instead of ERROR
[
https://issues.apache.org/jira/browse/MASSEMBLY-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649120#comment-16649120
]
ASF GitHub Bot commented on MASSEMBLY-775:
--
spiritualops commented on issue #1: [MASSEMBLY-775] remove false OS-specific
warnings/errors
URL:
https://github.com/apache/maven-assembly-plugin/pull/1#issuecomment-429575189
One last thing, don't forget to bump the patch version in the pom. ;)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Emit WARNING instead of ERROR
> -
>
> Key: MASSEMBLY-775
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-775
> Project: Maven Assembly Plugin
> Issue Type: Improvement
>Affects Versions: 2.5.5
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I have currently a build which creates several tar/tar.gz/zip archives etc.
> {code}
> [INFO] Reading assembly descriptor: src/main/assembly/descriptor-inner-tar.xml
> [INFO] Reading assembly descriptor: src/main/assembly/descriptor.xml
> [INFO] Building tar: C:\...\xyz-X.y.z-SNAPSHOT-dist.tar
> [ERROR] OS=Windows and the assembly descriptor contains a *nix-specific
> root-relative-reference (starting with slash) /
> [ERROR] OS=Windows and the assembly descriptor contains a *nix-specific
> root-relative-reference (starting with slash) /
> {code}
> In my opinion the message could be a WARNING instead of an error ? WDYT ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat
[
https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649066#comment-16649066
]
ASF GitHub Bot commented on MNG-5995:
-
slachiewicz commented on a change in pull request #185: [MNG-5995] Remove
dependency to maven-compat
URL: https://github.com/apache/maven/pull/185#discussion_r224968335
##
File path: pom.xml
##
@@ -545,6 +545,12 @@ under the License.
+
Review comment:
propably we need to think about proper test cases. Our CI runs with full
maven dist (including maven-compat.jar). For now manual tests with deleted
maven-compat can highlight plases where we need more work.
ok, so for merge I'll remove this plugin update.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Maven itself cannot run without maven-compat
>
>
> Key: MNG-5995
> URL: https://issues.apache.org/jira/browse/MNG-5995
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, core
>Affects Versions: 3.3.9
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Critical
> Fix For: 3.6.x-candidate
>
>
> For all the 3.0 versions of the maven-plugins we require to not depend on
> maven-compat anymore. However, the Maven distribution still requires
> maven-compat. A simple proof: remove {{lib/maven-compat-3.x.y}} and execute
> {{mvn validate}}.
> You'll get the following exception:
> {noformat}[WARNING] Error injecting:
> org.apache.maven.project.DefaultProjectBuildingHelper
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:
> 1) No implementation for org.apache.maven.repository.RepositorySystem was
> bound.
> while locating
> org.apache.maven.project.DefaultProjectBuildingHelper{noformat}
> Reason: there's only one implementation: o.a.m.r.l.LegacyRepositorySystem,
> which is part of maven-compat.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] slachiewicz commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat
slachiewicz commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat URL: https://github.com/apache/maven/pull/185#discussion_r224968335 ## File path: pom.xml ## @@ -545,6 +545,12 @@ under the License. + Review comment: propably we need to think about proper test cases. Our CI runs with full maven dist (including maven-compat.jar). For now manual tests with deleted maven-compat can highlight plases where we need more work. ok, so for merge I'll remove this plugin update. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat
[
https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649064#comment-16649064
]
ASF GitHub Bot commented on MNG-5995:
-
khmarbaise commented on a change in pull request #185: [MNG-5995] Remove
dependency to maven-compat
URL: https://github.com/apache/maven/pull/185#discussion_r224968070
##
File path: pom.xml
##
@@ -545,6 +545,12 @@ under the License.
+
Review comment:
Why does our
[CI](https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-5995/)
build work? Apart from testing locally works..
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Maven itself cannot run without maven-compat
>
>
> Key: MNG-5995
> URL: https://issues.apache.org/jira/browse/MNG-5995
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, core
>Affects Versions: 3.3.9
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Critical
> Fix For: 3.6.x-candidate
>
>
> For all the 3.0 versions of the maven-plugins we require to not depend on
> maven-compat anymore. However, the Maven distribution still requires
> maven-compat. A simple proof: remove {{lib/maven-compat-3.x.y}} and execute
> {{mvn validate}}.
> You'll get the following exception:
> {noformat}[WARNING] Error injecting:
> org.apache.maven.project.DefaultProjectBuildingHelper
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:
> 1) No implementation for org.apache.maven.repository.RepositorySystem was
> bound.
> while locating
> org.apache.maven.project.DefaultProjectBuildingHelper{noformat}
> Reason: there's only one implementation: o.a.m.r.l.LegacyRepositorySystem,
> which is part of maven-compat.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] khmarbaise commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat
khmarbaise commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat URL: https://github.com/apache/maven/pull/185#discussion_r224968070 ## File path: pom.xml ## @@ -545,6 +545,12 @@ under the License. + Review comment: Why does our [CI](https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-5995/) build work? Apart from testing locally works.. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat
[
https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649062#comment-16649062
]
ASF GitHub Bot commented on MNG-5995:
-
khmarbaise commented on a change in pull request #185: [MNG-5995] Remove
dependency to maven-compat
URL: https://github.com/apache/maven/pull/185#discussion_r224968070
##
File path: pom.xml
##
@@ -545,6 +545,12 @@ under the License.
+
Review comment:
Why does our
[CI](https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-5995/)
build work?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Maven itself cannot run without maven-compat
>
>
> Key: MNG-5995
> URL: https://issues.apache.org/jira/browse/MNG-5995
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, core
>Affects Versions: 3.3.9
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Critical
> Fix For: 3.6.x-candidate
>
>
> For all the 3.0 versions of the maven-plugins we require to not depend on
> maven-compat anymore. However, the Maven distribution still requires
> maven-compat. A simple proof: remove {{lib/maven-compat-3.x.y}} and execute
> {{mvn validate}}.
> You'll get the following exception:
> {noformat}[WARNING] Error injecting:
> org.apache.maven.project.DefaultProjectBuildingHelper
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:
> 1) No implementation for org.apache.maven.repository.RepositorySystem was
> bound.
> while locating
> org.apache.maven.project.DefaultProjectBuildingHelper{noformat}
> Reason: there's only one implementation: o.a.m.r.l.LegacyRepositorySystem,
> which is part of maven-compat.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] khmarbaise commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat
khmarbaise commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat URL: https://github.com/apache/maven/pull/185#discussion_r224968070 ## File path: pom.xml ## @@ -545,6 +545,12 @@ under the License. + Review comment: Why does our [CI](https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-5995/) build work? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat
[ https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649058#comment-16649058 ] ASF GitHub Bot commented on MNG-5995: - slachiewicz commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat URL: https://github.com/apache/maven/pull/185#discussion_r224967675 ## File path: pom.xml ## @@ -545,6 +545,12 @@ under the License. + Review comment: while try to compile maven-core, with maven-enforcer-plugin 1.4.1 ``` Caused by: org.codehaus.plexus.component.repository.exception.ComponentLookupException: com.google.inject.ProvisionException: Unable to provision, see the following errors: 1) No implementation for org.apache.maven.project.path.PathTranslator was bound. while locating org.apache.maven.plugins.enforcer.EnforceMojo at ClassRealm[plugin>org.apache.maven.plugins:maven-enforcer-plugin:1.4.1, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@4b9af9a9] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule) while locating org.apache.maven.plugin.Mojo annotated with @com.google.inject.name.Named(value="org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce") 1 error role: org.apache.maven.plugin.Mojo roleHint: org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce ``` with 3.0.0-M2 other error ``` Caused by: org.apache.maven.plugin.PluginContainerException: A required class was missing while executing org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M2:enforce: org/apache/maven/artifact/resolver/ArtifactResolver - realm =plugin>org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M2 strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy urls[0] = file:/C:/Users/.m2/repository/org/apache/maven/plugins/maven-enforcer-plugin/3.0.0-M2/maven-enforcer-plugin-3.0.0-M2.jar urls[1] = file:/C:/Users/.m2/repository/org/codehaus/mojo/extra-enforcer-rules/1.0-beta-9/extra-enforcer-rules-1.0-beta-9.jar urls[2] = file:/C:/Users/.m2/repository/org/apache/maven/shared/maven-dependency-tree/2.2/maven-dependency-tree-2.2.jar urls[3] = file:/C:/Users/.m2/repository/org/eclipse/aether/aether-util/0.9.0.M2/aether-util-0.9.0.M2.jar urls[4] = file:/C:/Users/.m2/repository/junit/junit/4.11/junit-4.11.jar urls[5] = file:/C:/Users/.m2/repository/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar urls[6] = file:/C:/Users/.m2/repository/commons-codec/commons-codec/1.6/commons-codec-1.6.jar urls[7] = file:/C:/Users/.m2/repository/org/apache/maven/shared/maven-common-artifact-filters/3.0.1/maven-common-artifact-filters-3.0.1.jar urls[8] = file:/C:/Users/.m2/repository/org/apache/maven/shared/maven-shared-utils/3.1.0/maven-shared-utils-3.1.0.jar urls[9] = file:/C:/Users/.m2/repository/commons-io/commons-io/2.5/commons-io-2.5.jar urls[10] = file:/C:/Users/.m2/repository/com/ibm/icu/icu4j/56.1/icu4j-56.1.jar urls[11] = file:/C:/Users/.m2/repository/org/sonatype/sisu/sisu-inject-bean/1.4.2/sisu-inject-bean-1.4.2.jar urls[12] = file:/C:/Users/.m2/repository/org/sonatype/sisu/sisu-guice/2.1.7/sisu-guice-2.1.7-noaop.jar urls[13] = file:/C:/Users/.m2/repository/org/sonatype/aether/aether-util/1.7/aether-util-1.7.jar urls[14] = file:/C:/Users/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar urls[15] = file:/C:/Users/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.7.1/plexus-component-annotations-1.7.1.jar urls[16] = file:/C:/Users/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar urls[17] = file:/C:/Users/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar urls[18] = file:/C:/Users/.m2/repository/org/codehaus/plexus/plexus-utils/3.1.0/plexus-utils-3.1.0.jar urls[19] = file:/C:/Users/.m2/repository/org/apache/maven/enforcer/enforcer-api/3.0.0-M2/enforcer-api-3.0.0-M2.jar urls[20] = file:/C:/Users/.m2/repository/org/apache/maven/enforcer/enforcer-rules/3.0.0-M2/enforcer-rules-3.0.0-M2.jar urls[21] = file:/C:/Users/.m2/repository/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar urls[22] = file:/C:/Users/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4.jar Caused by: java.lang.NoClassDefFoundError: org/apache/maven/artifact/resolver/ArtifactResolver at org.apache.maven.plugins.enforcer.AbstractResolveDependencies.execute (AbstractResolveDependencies.java:51) at org.apache.maven.plugins.enforcer.EnforceMojo.execute (EnforceMojo.java:194) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) ```
[GitHub] slachiewicz commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat
slachiewicz commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat URL: https://github.com/apache/maven/pull/185#discussion_r224967675 ## File path: pom.xml ## @@ -545,6 +545,12 @@ under the License. + Review comment: while try to compile maven-core, with maven-enforcer-plugin 1.4.1 ``` Caused by: org.codehaus.plexus.component.repository.exception.ComponentLookupException: com.google.inject.ProvisionException: Unable to provision, see the following errors: 1) No implementation for org.apache.maven.project.path.PathTranslator was bound. while locating org.apache.maven.plugins.enforcer.EnforceMojo at ClassRealm[plugin>org.apache.maven.plugins:maven-enforcer-plugin:1.4.1, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@4b9af9a9] (via modules: org.eclipse.sisu.wire.WireModule -> org.eclipse.sisu.plexus.PlexusBindingModule) while locating org.apache.maven.plugin.Mojo annotated with @com.google.inject.name.Named(value="org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce") 1 error role: org.apache.maven.plugin.Mojo roleHint: org.apache.maven.plugins:maven-enforcer-plugin:1.4.1:enforce ``` with 3.0.0-M2 other error ``` Caused by: org.apache.maven.plugin.PluginContainerException: A required class was missing while executing org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M2:enforce: org/apache/maven/artifact/resolver/ArtifactResolver - realm =plugin>org.apache.maven.plugins:maven-enforcer-plugin:3.0.0-M2 strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy urls[0] = file:/C:/Users/.m2/repository/org/apache/maven/plugins/maven-enforcer-plugin/3.0.0-M2/maven-enforcer-plugin-3.0.0-M2.jar urls[1] = file:/C:/Users/.m2/repository/org/codehaus/mojo/extra-enforcer-rules/1.0-beta-9/extra-enforcer-rules-1.0-beta-9.jar urls[2] = file:/C:/Users/.m2/repository/org/apache/maven/shared/maven-dependency-tree/2.2/maven-dependency-tree-2.2.jar urls[3] = file:/C:/Users/.m2/repository/org/eclipse/aether/aether-util/0.9.0.M2/aether-util-0.9.0.M2.jar urls[4] = file:/C:/Users/.m2/repository/junit/junit/4.11/junit-4.11.jar urls[5] = file:/C:/Users/.m2/repository/org/hamcrest/hamcrest-core/1.3/hamcrest-core-1.3.jar urls[6] = file:/C:/Users/.m2/repository/commons-codec/commons-codec/1.6/commons-codec-1.6.jar urls[7] = file:/C:/Users/.m2/repository/org/apache/maven/shared/maven-common-artifact-filters/3.0.1/maven-common-artifact-filters-3.0.1.jar urls[8] = file:/C:/Users/.m2/repository/org/apache/maven/shared/maven-shared-utils/3.1.0/maven-shared-utils-3.1.0.jar urls[9] = file:/C:/Users/.m2/repository/commons-io/commons-io/2.5/commons-io-2.5.jar urls[10] = file:/C:/Users/.m2/repository/com/ibm/icu/icu4j/56.1/icu4j-56.1.jar urls[11] = file:/C:/Users/.m2/repository/org/sonatype/sisu/sisu-inject-bean/1.4.2/sisu-inject-bean-1.4.2.jar urls[12] = file:/C:/Users/.m2/repository/org/sonatype/sisu/sisu-guice/2.1.7/sisu-guice-2.1.7-noaop.jar urls[13] = file:/C:/Users/.m2/repository/org/sonatype/aether/aether-util/1.7/aether-util-1.7.jar urls[14] = file:/C:/Users/.m2/repository/org/codehaus/plexus/plexus-interpolation/1.14/plexus-interpolation-1.14.jar urls[15] = file:/C:/Users/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.7.1/plexus-component-annotations-1.7.1.jar urls[16] = file:/C:/Users/.m2/repository/org/sonatype/plexus/plexus-sec-dispatcher/1.3/plexus-sec-dispatcher-1.3.jar urls[17] = file:/C:/Users/.m2/repository/org/sonatype/plexus/plexus-cipher/1.4/plexus-cipher-1.4.jar urls[18] = file:/C:/Users/.m2/repository/org/codehaus/plexus/plexus-utils/3.1.0/plexus-utils-3.1.0.jar urls[19] = file:/C:/Users/.m2/repository/org/apache/maven/enforcer/enforcer-api/3.0.0-M2/enforcer-api-3.0.0-M2.jar urls[20] = file:/C:/Users/.m2/repository/org/apache/maven/enforcer/enforcer-rules/3.0.0-M2/enforcer-rules-3.0.0-M2.jar urls[21] = file:/C:/Users/.m2/repository/org/apache/commons/commons-lang3/3.5/commons-lang3-3.5.jar urls[22] = file:/C:/Users/.m2/repository/org/beanshell/bsh/2.0b4/bsh-2.0b4.jar Caused by: java.lang.NoClassDefFoundError: org/apache/maven/artifact/resolver/ArtifactResolver at org.apache.maven.plugins.enforcer.AbstractResolveDependencies.execute (AbstractResolveDependencies.java:51) at org.apache.maven.plugins.enforcer.EnforceMojo.execute (EnforceMojo.java:194) at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo (DefaultBuildPluginManager.java:137) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please
[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat
[
https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649049#comment-16649049
]
ASF GitHub Bot commented on MNG-5995:
-
khmarbaise commented on a change in pull request #185: [MNG-5995] Remove
dependency to maven-compat
URL: https://github.com/apache/maven/pull/185#discussion_r224967259
##
File path: pom.xml
##
@@ -545,6 +545,12 @@ under the License.
+
Review comment:
Maybe I misunderstand your comment Sylwester, but why and when does it fail
by default ? (Are we talking about maven-enforcer-plugin:3.0.0-M2 ?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Maven itself cannot run without maven-compat
>
>
> Key: MNG-5995
> URL: https://issues.apache.org/jira/browse/MNG-5995
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, core
>Affects Versions: 3.3.9
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Critical
> Fix For: 3.6.x-candidate
>
>
> For all the 3.0 versions of the maven-plugins we require to not depend on
> maven-compat anymore. However, the Maven distribution still requires
> maven-compat. A simple proof: remove {{lib/maven-compat-3.x.y}} and execute
> {{mvn validate}}.
> You'll get the following exception:
> {noformat}[WARNING] Error injecting:
> org.apache.maven.project.DefaultProjectBuildingHelper
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:
> 1) No implementation for org.apache.maven.repository.RepositorySystem was
> bound.
> while locating
> org.apache.maven.project.DefaultProjectBuildingHelper{noformat}
> Reason: there's only one implementation: o.a.m.r.l.LegacyRepositorySystem,
> which is part of maven-compat.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] khmarbaise commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat
khmarbaise commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat URL: https://github.com/apache/maven/pull/185#discussion_r224967259 ## File path: pom.xml ## @@ -545,6 +545,12 @@ under the License. + Review comment: Maybe I misunderstand your comment Sylwester, but why and when does it fail by default ? (Are we talking about maven-enforcer-plugin:3.0.0-M2 ? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat
[
https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649047#comment-16649047
]
ASF GitHub Bot commented on MNG-5995:
-
slachiewicz commented on a change in pull request #185: [MNG-5995] Remove
dependency to maven-compat
URL: https://github.com/apache/maven/pull/185#discussion_r224966963
##
File path: pom.xml
##
@@ -545,6 +545,12 @@ under the License.
+
Review comment:
yes an no ;-) we use old plugin not yet migrated to Maven 3.0+ so it will
fail by default.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Maven itself cannot run without maven-compat
>
>
> Key: MNG-5995
> URL: https://issues.apache.org/jira/browse/MNG-5995
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, core
>Affects Versions: 3.3.9
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Critical
> Fix For: 3.6.x-candidate
>
>
> For all the 3.0 versions of the maven-plugins we require to not depend on
> maven-compat anymore. However, the Maven distribution still requires
> maven-compat. A simple proof: remove {{lib/maven-compat-3.x.y}} and execute
> {{mvn validate}}.
> You'll get the following exception:
> {noformat}[WARNING] Error injecting:
> org.apache.maven.project.DefaultProjectBuildingHelper
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:
> 1) No implementation for org.apache.maven.repository.RepositorySystem was
> bound.
> while locating
> org.apache.maven.project.DefaultProjectBuildingHelper{noformat}
> Reason: there's only one implementation: o.a.m.r.l.LegacyRepositorySystem,
> which is part of maven-compat.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] slachiewicz commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat
slachiewicz commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat URL: https://github.com/apache/maven/pull/185#discussion_r224966963 ## File path: pom.xml ## @@ -545,6 +545,12 @@ under the License. + Review comment: yes an no ;-) we use old plugin not yet migrated to Maven 3.0+ so it will fail by default. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (MNG-6491) Upgrade commons-lang3 to 3.8.1
[ https://issues.apache.org/jira/browse/MNG-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649043#comment-16649043 ] Sylwester Lachiewicz edited comment on MNG-6491 at 10/13/18 5:44 PM: - We have option to upgrade or completly remove dependency to commons-lang3 - for now we use only few methods to validate parameters. see https://issues.apache.org/jira/browse/MNG-6481?focusedCommentId=16635247=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16635247 and MNG-6488 alternative [https://github.com/apache/maven/commit/2611fa5849a14d426e67ecde54c451bdae5a44f7] plus other small changes to tests. was (Author: slachiewicz): We have option to upgrade or completly remove deoendency to commons-lang3 - for now we use only few methods to validate parameters. see https://issues.apache.org/jira/browse/MNG-6481?focusedCommentId=16635247=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16635247 and alternative [https://github.com/apache/maven/commit/2611fa5849a14d426e67ecde54c451bdae5a44f7] > Upgrade commons-lang3 to 3.8.1 > -- > > Key: MNG-6491 > URL: https://issues.apache.org/jira/browse/MNG-6491 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.0-candidate > > > Upgrade to latest version compatible with Java 11 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6491) Upgrade commons-lang3 to 3.8.1
[ https://issues.apache.org/jira/browse/MNG-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649043#comment-16649043 ] Sylwester Lachiewicz commented on MNG-6491: --- We have option to upgrade or completly remove deoendency to commons-lang3 - for now we use only few methods to validate parameters. see https://issues.apache.org/jira/browse/MNG-6481?focusedCommentId=16635247=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16635247 and alternative [https://github.com/apache/maven/commit/2611fa5849a14d426e67ecde54c451bdae5a44f7] > Upgrade commons-lang3 to 3.8.1 > -- > > Key: MNG-6491 > URL: https://issues.apache.org/jira/browse/MNG-6491 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.0-candidate > > > Upgrade to latest version compatible with Java 11 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-6491) Upgrade commons-lang3 to 3.8.1
[ https://issues.apache.org/jira/browse/MNG-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6491: -- Description: Upgrade to latest version compatible with Java 11 > Upgrade commons-lang3 to 3.8.1 > -- > > Key: MNG-6491 > URL: https://issues.apache.org/jira/browse/MNG-6491 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.0-candidate > > > Upgrade to latest version compatible with Java 11 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] hboutemy commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat
hboutemy commented on a change in pull request #185: [MNG-5995] Remove dependency to maven-compat URL: https://github.com/apache/maven/pull/185#discussion_r224966165 ## File path: pom.xml ## @@ -545,6 +545,12 @@ under the License. + Review comment: why upgrading this plugin? this is not related to avoiding core requiring maven-compat, isn't it? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat
[
https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649031#comment-16649031
]
ASF GitHub Bot commented on MNG-5995:
-
hboutemy commented on a change in pull request #185: [MNG-5995] Remove
dependency to maven-compat
URL: https://github.com/apache/maven/pull/185#discussion_r224966165
##
File path: pom.xml
##
@@ -545,6 +545,12 @@ under the License.
+
Review comment:
why upgrading this plugin? this is not related to avoiding core requiring
maven-compat, isn't it?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Maven itself cannot run without maven-compat
>
>
> Key: MNG-5995
> URL: https://issues.apache.org/jira/browse/MNG-5995
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, core
>Affects Versions: 3.3.9
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Critical
> Fix For: 3.6.x-candidate
>
>
> For all the 3.0 versions of the maven-plugins we require to not depend on
> maven-compat anymore. However, the Maven distribution still requires
> maven-compat. A simple proof: remove {{lib/maven-compat-3.x.y}} and execute
> {{mvn validate}}.
> You'll get the following exception:
> {noformat}[WARNING] Error injecting:
> org.apache.maven.project.DefaultProjectBuildingHelper
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:
> 1) No implementation for org.apache.maven.repository.RepositorySystem was
> bound.
> while locating
> org.apache.maven.project.DefaultProjectBuildingHelper{noformat}
> Reason: there's only one implementation: o.a.m.r.l.LegacyRepositorySystem,
> which is part of maven-compat.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 10/11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649029#comment-16649029 ] Hervé Boutemy commented on MNG-6481: +1 to testing only 7, 8 and 11 9 and 10 are now just in limbo, only 11 LTS is now important > Allow to compile and test Maven with Java 10/11 > --- > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.0-candidate > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6491) Upgrade commons-lang3 to 3.8.1
[ https://issues.apache.org/jira/browse/MNG-6491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16649026#comment-16649026 ] Hervé Boutemy commented on MNG-6491: what is the expected benefit? > Upgrade commons-lang3 to 3.8.1 > -- > > Key: MNG-6491 > URL: https://issues.apache.org/jira/browse/MNG-6491 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.0-candidate > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MNG-5995) Maven itself cannot run without maven-compat
[
https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hervé Boutemy updated MNG-5995:
---
Description:
For all the 3.0 versions of the maven-plugins we require to not depend on
maven-compat anymore. However, the Maven distribution still requires
maven-compat. A simple proof: remove {{lib/maven-compat-3.x.y}} and execute
{{mvn validate}}.
You'll get the following exception:
{noformat}[WARNING] Error injecting:
org.apache.maven.project.DefaultProjectBuildingHelper
com.google.inject.ProvisionException: Unable to provision, see the following
errors:
1) No implementation for org.apache.maven.repository.RepositorySystem was bound.
while locating org.apache.maven.project.DefaultProjectBuildingHelper{noformat}
Reason: there's only one implementation: o.a.m.r.l.LegacyRepositorySystem,
which is part of maven-compat.
was:
For all the 3.0 versions of the maven-plugins we require to not depend on
maven-compat anymore. However, the Maven distribution still requires
maven-compat. A simple proof: remove {{lib/maven-compat-3.x.y}} and execute
{{mvn validate}}.
You'll get the following exception:
{noformat}
No implementation for org.apache.maven.repository.RepositorySystem was bound.
{noformat}
Reason: there's only one implementation: o.a.m.r.l.LegacyRepositorySystem,
which is part of maven-compat.
> Maven itself cannot run without maven-compat
>
>
> Key: MNG-5995
> URL: https://issues.apache.org/jira/browse/MNG-5995
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, core
>Affects Versions: 3.3.9
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Critical
> Fix For: 3.6.x-candidate
>
>
> For all the 3.0 versions of the maven-plugins we require to not depend on
> maven-compat anymore. However, the Maven distribution still requires
> maven-compat. A simple proof: remove {{lib/maven-compat-3.x.y}} and execute
> {{mvn validate}}.
> You'll get the following exception:
> {noformat}[WARNING] Error injecting:
> org.apache.maven.project.DefaultProjectBuildingHelper
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:
> 1) No implementation for org.apache.maven.repository.RepositorySystem was
> bound.
> while locating
> org.apache.maven.project.DefaultProjectBuildingHelper{noformat}
> Reason: there's only one implementation: o.a.m.r.l.LegacyRepositorySystem,
> which is part of maven-compat.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MARCHETYPES-61) Update quickstart to use JUnit 5
[
https://issues.apache.org/jira/browse/MARCHETYPES-61?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648883#comment-16648883
]
Dmitry Timofeev commented on MARCHETYPES-61:
Surefire will need to be updated first to support junit 5 properly:
https://github.com/apache/maven-archetypes/pull/1
> Update quickstart to use JUnit 5
>
>
> Key: MARCHETYPES-61
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-61
> Project: Maven Archetype Bundles
> Issue Type: Improvement
> Components: Maven Quickstart Archetype
>Affects Versions: 1.3
>Reporter: Dmitry Timofeev
>Priority: Minor
>
> Update quickstart archetype to generate a project using JUnit 5, the next
> version of the most popular testing framework.
> Currently one has to include _at least_ two dependencies on JUnit 5 artefacts
> to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.
> Possible structure of dependencies:
> {code:java}
>
>
>
> org.junit
> junit-bom
> 5.3.1
> pom
> import
>
>
>
>
>
> org.junit.jupiter
> junit-jupiter-api
> test
>
>
> org.junit.jupiter
> junit-jupiter-engine
> test
>
>
>
> org.junit.jupiter
> junit-jupiter-params
> test
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MARCHETYPES-61) Update quickstart to use JUnit 5
[
https://issues.apache.org/jira/browse/MARCHETYPES-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Timofeev updated MARCHETYPES-61:
---
Affects Version/s: 1.3
> Update quickstart to use JUnit 5
>
>
> Key: MARCHETYPES-61
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-61
> Project: Maven Archetype Bundles
> Issue Type: Improvement
> Components: Maven Quickstart Archetype
>Affects Versions: 1.3
>Reporter: Dmitry Timofeev
>Priority: Minor
>
> Update quickstart archetype to generate a project using JUnit 5, the next
> version of the most popular testing framework.
> Currently one has to include _at least_ two dependencies on JUnit 5 artefacts
> to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.
> Possible structure of dependencies:
> {code:java}
>
>
>
> org.junit
> junit-bom
> 5.3.1
> pom
> import
>
>
>
>
>
> org.junit.jupiter
> junit-jupiter-api
> test
>
>
> org.junit.jupiter
> junit-jupiter-engine
> test
>
>
>
> org.junit.jupiter
> junit-jupiter-params
> test
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MARCHETYPES-61) Update quickstart to use JUnit 5
[
https://issues.apache.org/jira/browse/MARCHETYPES-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Timofeev updated MARCHETYPES-61:
---
Component/s: Maven Quickstart Archetype
> Update quickstart to use JUnit 5
>
>
> Key: MARCHETYPES-61
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-61
> Project: Maven Archetype Bundles
> Issue Type: Improvement
> Components: Maven Quickstart Archetype
>Affects Versions: 1.3
>Reporter: Dmitry Timofeev
>Priority: Minor
>
> Update quickstart archetype to generate a project using JUnit 5, the next
> version of the most popular testing framework.
> Currently one has to include _at least_ two dependencies on JUnit 5 artefacts
> to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.
> Possible structure of dependencies:
> {code:java}
>
>
>
> org.junit
> junit-bom
> 5.3.1
> pom
> import
>
>
>
>
>
> org.junit.jupiter
> junit-jupiter-api
> test
>
>
> org.junit.jupiter
> junit-jupiter-engine
> test
>
>
>
> org.junit.jupiter
> junit-jupiter-params
> test
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MARCHETYPES-61) Update quickstart to use JUnit 5
[
https://issues.apache.org/jira/browse/MARCHETYPES-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Timofeev updated MARCHETYPES-61:
---
Priority: Minor (was: Major)
> Update quickstart to use JUnit 5
>
>
> Key: MARCHETYPES-61
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-61
> Project: Maven Archetype Bundles
> Issue Type: Improvement
> Components: Maven Quickstart Archetype
>Affects Versions: 1.3
>Reporter: Dmitry Timofeev
>Priority: Minor
>
> Update quickstart archetype to generate a project using JUnit 5, the next
> version of the most popular testing framework.
> Currently one has to include _at least_ two dependencies on JUnit 5 artefacts
> to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.
> Possible structure of dependencies:
> {code:java}
>
>
>
> org.junit
> junit-bom
> 5.3.1
> pom
> import
>
>
>
>
>
> org.junit.jupiter
> junit-jupiter-api
> test
>
>
> org.junit.jupiter
> junit-jupiter-engine
> test
>
>
>
> org.junit.jupiter
> junit-jupiter-params
> test
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MARCHETYPES-61) Update quickstart to use JUnit 5
[
https://issues.apache.org/jira/browse/MARCHETYPES-61?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dmitry Timofeev updated MARCHETYPES-61:
---
Description:
Update quickstart archetype to generate a project using JUnit 5, the next
version of the most popular testing framework.
Currently one has to include _at least_ two dependencies on JUnit 5 artefacts
to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.
Possible structure of dependencies:
{code:java}
org.junit
junit-bom
5.3.1
pom
import
org.junit.jupiter
junit-jupiter-api
test
org.junit.jupiter
junit-jupiter-engine
test
org.junit.jupiter
junit-jupiter-params
test
{code}
> Update quickstart to use JUnit 5
>
>
> Key: MARCHETYPES-61
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-61
> Project: Maven Archetype Bundles
> Issue Type: Improvement
>Reporter: Dmitry Timofeev
>Priority: Major
>
> Update quickstart archetype to generate a project using JUnit 5, the next
> version of the most popular testing framework.
> Currently one has to include _at least_ two dependencies on JUnit 5 artefacts
> to enable surefire to run them: junit-jupiter-api and junit-jupiter-engine.
> Possible structure of dependencies:
> {code:java}
>
>
>
> org.junit
> junit-bom
> 5.3.1
> pom
> import
>
>
>
>
>
> org.junit.jupiter
> junit-jupiter-api
> test
>
>
> org.junit.jupiter
> junit-jupiter-engine
> test
>
>
>
> org.junit.jupiter
> junit-jupiter-params
> test
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MARCHETYPES-61) Update quickstart to use JUnit 5
Dmitry Timofeev created MARCHETYPES-61: -- Summary: Update quickstart to use JUnit 5 Key: MARCHETYPES-61 URL: https://issues.apache.org/jira/browse/MARCHETYPES-61 Project: Maven Archetype Bundles Issue Type: Improvement Reporter: Dmitry Timofeev -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MINVOKER-244) Upgrade maven-artifact-transfer to 0.10.0
Karl Heinz Marbaise created MINVOKER-244: Summary: Upgrade maven-artifact-transfer to 0.10.0 Key: MINVOKER-244 URL: https://issues.apache.org/jira/browse/MINVOKER-244 Project: Maven Invoker Plugin Issue Type: Dependency upgrade Affects Versions: 3.1.1 Reporter: Karl Heinz Marbaise Fix For: 3.1.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] dmitry-timofeev opened a new pull request #1: Update Maven Compiler and Surefire plugins
dmitry-timofeev opened a new pull request #1: Update Maven Compiler and Surefire plugins URL: https://github.com/apache/maven-archetypes/pull/1 Update the plugins for out-of-the-box Java 11 and JUnit 5 support in the generated projects. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MRESOLVER-60) Possible NPE when calling RepositorySystemSession.getFileTransformerManager()
[
https://issues.apache.org/jira/browse/MRESOLVER-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hervé Boutemy updated MRESOLVER-60:
---
Description:
happens in Maven Core ITs during MNG-6489 build:
{noformat}
Test Result (3 failures / +3)
org.apache.maven.it.MavenITmng4788InstallationToCustomLocalRepoTest.testit
org.apache.maven.it.MavenITmng4788InstallationToCustomLocalRepoTest.testit
org.apache.maven.it.MavenITmng4788InstallationToCustomLocalRepoTest.testit
[...]
Caused by: java.lang.NullPointerException
at org.eclipse.aether.internal.impl.DefaultInstaller.install
(DefaultInstaller.java:242)
at org.eclipse.aether.internal.impl.DefaultInstaller.install
(DefaultInstaller.java:188)
at org.eclipse.aether.internal.impl.DefaultInstaller.install
(DefaultInstaller.java:145)
at org.eclipse.aether.internal.impl.DefaultRepositorySystem.install
(DefaultRepositorySystem.java:364)
at org.apache.maven.artifact.installer.DefaultArtifactInstaller.install
(DefaultArtifactInstaller.java:107)
{noformat}
This happens when the session is created (copied) with {{new
DefaultRepositorySystemSession( session )}}
was:This will happen when the session is created (copied) with {{new
DefaultRepositorySystemSession( session )}}
> Possible NPE when calling RepositorySystemSession.getFileTransformerManager()
> -
>
> Key: MRESOLVER-60
> URL: https://issues.apache.org/jira/browse/MRESOLVER-60
> Project: Maven Resolver
> Issue Type: Bug
> Components: resolver
>Affects Versions: 1.3.0
>Reporter: Robert Scholte
>Assignee: Robert Scholte
>Priority: Blocker
> Fix For: 1.3.1
>
>
> happens in Maven Core ITs during MNG-6489 build:
> {noformat}
> Test Result (3 failures / +3)
> org.apache.maven.it.MavenITmng4788InstallationToCustomLocalRepoTest.testit
> org.apache.maven.it.MavenITmng4788InstallationToCustomLocalRepoTest.testit
> org.apache.maven.it.MavenITmng4788InstallationToCustomLocalRepoTest.testit
> [...]
> Caused by: java.lang.NullPointerException
> at org.eclipse.aether.internal.impl.DefaultInstaller.install
> (DefaultInstaller.java:242)
> at org.eclipse.aether.internal.impl.DefaultInstaller.install
> (DefaultInstaller.java:188)
> at org.eclipse.aether.internal.impl.DefaultInstaller.install
> (DefaultInstaller.java:145)
> at org.eclipse.aether.internal.impl.DefaultRepositorySystem.install
> (DefaultRepositorySystem.java:364)
> at org.apache.maven.artifact.installer.DefaultArtifactInstaller.install
> (DefaultArtifactInstaller.java:107)
> {noformat}
> This happens when the session is created (copied) with {{new
> DefaultRepositorySystemSession( session )}}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6489) Upgrade Maven Resolver to 1.3.0
[
https://issues.apache.org/jira/browse/MNG-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648875#comment-16648875
]
Hervé Boutemy commented on MNG-6489:
{noformat}Test Result (3 failures / +3)
org.apache.maven.it.MavenITmng4788InstallationToCustomLocalRepoTest.testit
org.apache.maven.it.MavenITmng4788InstallationToCustomLocalRepoTest.testit
org.apache.maven.it.MavenITmng4788InstallationToCustomLocalRepoTest.testit
[ERROR] Failed to execute goal
org.apache.maven.its.plugins:maven-it-plugin-artifact:2.1-SNAPSHOT:install-custom
(deploy) on project test: Failed to install artifacts: NullPointerException ->
[Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.its.plugins:maven-it-plugin-artifact:2.1-SNAPSHOT:install-custom
(deploy) on project test: Failed to install artifacts
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:215)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:156)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:148)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:117)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:81)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:56)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:243)
at sun.reflect.GeneratedMethodAccessor57.invoke (Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:606)
at org.apache.maven.it.Embedded3xLauncher.run (Embedded3xLauncher.java:247)
at org.apache.maven.it.Verifier.executeGoals (Verifier.java:1354)
at org.apache.maven.it.Verifier.executeGoal (Verifier.java:1254)
at org.apache.maven.it.Verifier.executeGoal (Verifier.java:1248)
at
org.apache.maven.it.MavenITmng4788InstallationToCustomLocalRepoTest.testit
(MavenITmng4788InstallationToCustomLocalRepoTest.java:52)
at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:57)
at sun.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:606)
at junit.framework.TestCase.runTest (TestCase.java:176)
at org.apache.maven.it.AbstractMavenIntegrationTestCase.runTest
(AbstractMavenIntegrationTestCase.java:222)
at junit.framework.TestCase.runBare (TestCase.java:141)
at junit.framework.TestResult$1.protect (TestResult.java:122)
at junit.framework.TestResult.runProtected (TestResult.java:142)
at junit.framework.TestResult.run (TestResult.java:125)
at junit.framework.TestCase.run (TestCase.java:129)
at junit.framework.TestSuite.runTest (TestSuite.java:252)
at junit.framework.TestSuite.run (TestSuite.java:247)
at junit.framework.TestSuite.runTest (TestSuite.java:252)
at junit.framework.TestSuite.run (TestSuite.java:247)
at org.junit.internal.runners.JUnit38ClassRunner.run
(JUnit38ClassRunner.java:86)
at org.apache.maven.surefire.junit4.JUnit4Provider.execute
(JUnit4Provider.java:365)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun
(JUnit4Provider.java:273)
at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet
(JUnit4Provider.java:238)
at org.apache.maven.surefire.junit4.JUnit4Provider.invoke
(JUnit4Provider.java:159)
at
org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader
(ForkedBooter.java:383)
at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess
(ForkedBooter.java:344)
at org.apache.maven.surefire.booter.ForkedBooter.execute
(ForkedBooter.java:125)
at org.apache.maven.surefire.booter.ForkedBooter.main
(ForkedBooter.java:417)
Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to install
artifacts
at org.apache.maven.plugin.coreit.InstallMojo.execute (InstallMojo.java:77)
at org.apache.maven.plugin.coreit.InstallCustomMojo.execute
(InstallCustomMojo.java:73)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:137)
at
[GitHub] khmarbaise commented on a change in pull request #186: better performant for some Collection operations
khmarbaise commented on a change in pull request #186: better performant for some Collection operations URL: https://github.com/apache/maven/pull/186#discussion_r224955891 ## File path: maven-core/src/main/java/org/apache/maven/project/ProjectModelResolver.java ## @@ -19,14 +19,6 @@ * under the License. */ -import java.io.File; -import java.util.ArrayList; -import java.util.Collections; -import java.util.HashSet; -import java.util.Iterator; -import java.util.List; -import java.util.Set; - import org.apache.maven.model.Dependency; Review comment: No problem. Happens from time to time..and yes it would be great to have the original so the change is better visible... This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] s50600822 commented on a change in pull request #186: better performant for some Collection operations
s50600822 commented on a change in pull request #186: better performant for some Collection operations URL: https://github.com/apache/maven/pull/186#discussion_r224955789 ## File path: maven-core/src/main/java/org/apache/maven/project/ProjectModelResolver.java ## @@ -19,14 +19,6 @@ * under the License. */ -import java.io.File; -import java.util.ArrayList; -import java.util.Collections; -import java.util.HashSet; -import java.util.Iterator; -import java.util.List; -import java.util.Set; - import org.apache.maven.model.Dependency; Review comment: my bad, I might have pressed "optimize import" to make sure no unused import is there. It resulted in this ordering due to IntelliJ default config. Should I change it back. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MPMD-273) Dependency jar with rules fails only with SNAPSHOT version
[
https://issues.apache.org/jira/browse/MPMD-273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648835#comment-16648835
]
Andreas Dangel commented on MPMD-273:
-
[~leemeador], how does your pluginRepositories section look like?
It could be (I didn't verify it),that maven is using the configuration from
pluginRepository to load the dependency, as this additional dependency is part
of a plugin.
Do you have a {{}} setting for snapshots?
See also [https://maven.apache.org/pom.html#Repositories] and
[https://maven.apache.org/pom.html#Plugin_Repositories]
> Dependency jar with rules fails only with SNAPSHOT version
> --
>
> Key: MPMD-273
> URL: https://issues.apache.org/jira/browse/MPMD-273
> Project: Maven PMD Plugin
> Issue Type: Bug
> Components: PMD
>Affects Versions: 3.10.0
> Environment: Jenkins scripted build job calls Maven running on RHEL 7
> Linux build agents controlled by Jenkins 2.73. Java 8.
>Reporter: Lee Meador
>Priority: Major
>
> One build job creates a coding-standards jar containing PMD rulesets and I
> have run that build with and without SNAPSHOT for version 0.0.2. If I go to
> my Nexus GUI and search, I see the 0.0.2 version and about 8 SNAPSHOT
> versions with different dates and times. 0.0.2 is in the releases repo and
> 0.0.2-SNAPSHOT(s) are in the snapshots repo.
> I have settings.xml set to point to our the public Nexus 3 repository which
> proxies to Maven Central and several other repos both open source and
> internal to our company. The releases repo is included in public. The
> snapshot repo is not included in public, this proxy repo.
> This is the mirrorOf tag in settings.xml.
> {{ !nexus-snapshots,*}}
> For another build job, I have a tag in the pom pointing to our
> snapshot repo with snapshot enabled and releases NOT enabled. This tag is
> there to give it an id that works with the mirroring:
> {{ nexus-snapshots}}
> Other snapshot versions of things needed when compiling the code are found by
> maven.
> I configure the maven pmd plugin thusly:
> {quote}{{}}
> {{ org.apache.maven.plugins}}
> {{ maven-pmd-plugin}}
> {{ }}
> {{ }}
> {{ }}
> {{ check}}
> {{ }}
> {{ }}
> {{ }}
> {{ }}
> {{ utf-8}}
> {{ 100}}
> {{ 1.8}}
> {{ 3}}
> {{ true}}
> {{ }}
> {{ pmd-config2.xml}}
> {{ }}
> {{ }}
> {{ }}
> {{ }}
> {{ com.aa.crewtech.tools}}
> {{ coding-standards}}
> {{ ${coding-standards.version}}}
> {{ }}
> {{ }}
> {{ }}{quote}
> If I run my build and the property coding-standards.version has the value
> 0.0.2 everything works.
> If coding-standards.version has the value 0.0.2-SNAPSHOT it fails with this
> error:
> _ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-pmd-plugin:3.10.0:pmd (pmd) on project
> SqlTool: Execution pmd of goal
> org.apache.maven.plugins:maven-pmd-plugin:3.10.0:pmd failed: Plugin
> org.apache.maven.plugins:maven-pmd-plugin:3.10.0 or one of its dependencies
> could not be resolved: Could not find artifact
> com.my.company:coding-standards:jar:0.0.2-SNAPSHOT in nexus
> ([https://nexusread.mycompany.com/repository/public/|https://nexusread.aa.com/repository/OT-public/])
> -> [Help 1]_
> All these builds actually run in my Jenkins with all the code under source
> control and its all repeatable. SNAPSHOT version for the ruleset jar fails.
> Non-SNAPSHOT version works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6489) Upgrade Maven Resolver to 1.3.0
[ https://issues.apache.org/jira/browse/MNG-6489?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648809#comment-16648809 ] Hudson commented on MNG-6489: - Build unstable in Jenkins: Maven TLP » maven » MNG-6391 #30 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6391/30/ > Upgrade Maven Resolver to 1.3.0 > --- > > Key: MNG-6489 > URL: https://issues.apache.org/jira/browse/MNG-6489 > Project: Maven > Issue Type: Dependency upgrade > Components: Artifacts and Repositories, Dependencies >Affects Versions: 3.5.4 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6164) Collections inconsistently immutable
[
https://issues.apache.org/jira/browse/MNG-6164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648808#comment-16648808
]
Hudson commented on MNG-6164:
-
Build unstable in Jenkins: Maven TLP » maven » MNG-6391 #30
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6391/30/
> Collections inconsistently immutable
>
>
> Key: MNG-6164
> URL: https://issues.apache.org/jira/browse/MNG-6164
> Project: Maven
> Issue Type: Improvement
>Affects Versions: 3.5.0
>Reporter: Christian Schulte
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: 3.6.0
>
>
> There are plenty of places where empty collections are returned from public
> API in methods written like:
> {code}
> public List getExceptions()
> {
> return exceptions == null ? Collections.emptyList() :
> exceptions;
> }
> {code}
> The issue with this is that the empty list is immutable but the collection
> returned for the nun-null case is not immutable.
> All those methods should return a collection with consistent "mutability":
> either mutable, either immutable.
> Given empty immutable collections do not cause harm until now, switching
> consistently to immutable collections is more conservative and should not be
> risky
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16648810#comment-16648810
]
Hudson commented on MNG-6391:
-
Build unstable in Jenkins: Maven TLP » maven » MNG-6391 #30
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6391/30/
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.6.0
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] khmarbaise commented on issue #186: better performant for some Collection operations
khmarbaise commented on issue #186: better performant for some Collection operations URL: https://github.com/apache/maven/pull/186#issuecomment-429519416 Would you please create JIRA issue for that...? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khmarbaise commented on a change in pull request #186: better performant for some Collection operations
khmarbaise commented on a change in pull request #186: better performant for some Collection operations URL: https://github.com/apache/maven/pull/186#discussion_r224952580 ## File path: maven-core/src/main/java/org/apache/maven/project/ProjectModelResolver.java ## @@ -19,14 +19,6 @@ * under the License. */ -import java.io.File; -import java.util.ArrayList; -import java.util.Collections; -import java.util.HashSet; -import java.util.Iterator; -import java.util.List; -import java.util.Set; - import org.apache.maven.model.Dependency; Review comment: Is there a reason why you reformat this? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] s50600822 opened a new pull request #186: better performant for some Collection operations
s50600822 opened a new pull request #186: better performant for some Collection operations URL: https://github.com/apache/maven/pull/186 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
