[jira] [Commented] (MJAVADOC-390) The detectLinks should work for aggregate also (collect dependencies from reactor)
[ https://issues.apache.org/jira/browse/MJAVADOC-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657992#comment-16657992 ] Florian Brunner commented on MJAVADOC-390: -- The issue still exists with version 3.0.1 > The detectLinks should work for aggregate also (collect dependencies from > reactor) > -- > > Key: MJAVADOC-390 > URL: https://issues.apache.org/jira/browse/MJAVADOC-390 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.9.1 >Reporter: Laszlo Varadi >Priority: Major > Attachments: AggregateWithDetectLinks.patch > > > In case of aggregate goal, the detectLinks fail to find javadoc links of > dependencies, as it only checks the dependencies of the execution root > project. Is should check the dependencies of all projects in the reactor. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 10/11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657975#comment-16657975 ] Sylwester Lachiewicz commented on MNG-6481: --- With all last fixes, Maven can be compiled with Java 11 and pass all internal tests. Unfortunately, few tests failed in ITs [failed|https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6481/] (Linux and Windows the same) [linux-jdk11] [ERROR] testBad(org.apache.maven.it.MavenITmng5958LifecyclePhaseBinaryCompat) Time elapsed: 0.202 s <<< ERROR! [linux-jdk11] org.apache.maven.it.VerificationException: Text not found in log: [ERROR] Internal error: java.lang.ClassCastException: org.apache.maven.lifecycle.mapping.LifecyclePhase cannot be cast to [linux-jdk11] at org.apache.maven.it.MavenITmng5958LifecyclePhaseBinaryCompat.testBad(MavenITmng5958LifecyclePhaseBinaryCompat.java:42) [linux-jdk11] [linux-jdk11] [ERROR] testit(org.apache.maven.it.MavenITmng4877DeployUsingPrivateKeyTest) Time elapsed: 0.214 s <<< FAILURE! [linux-jdk11] junit.framework.AssertionFailedError: expected: but was: [linux-jdk11] at org.apache.maven.it.MavenITmng4877DeployUsingPrivateKeyTest.testit(MavenITmng4877DeployUsingPrivateKeyTest.java:60) [linux-jdk11] [linux-jdk11] [ERROR] testitMNG1957(org.apache.maven.it.MavenITmng1957JdkActivationWithVersionRangeTest) Time elapsed: 0.131 s <<< FAILURE! [linux-jdk11] junit.framework.ComparisonFailure: expected: but was: [linux-jdk11] at org.apache.maven.it.MavenITmng1957JdkActivationWithVersionRangeTest.testitMNG1957(MavenITmng1957JdkActivationWithVersionRangeTest.java:64) [linux-jdk11] > Allow to compile and test Maven with Java 10/11 > --- > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.0-candidate > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MNG-6481) Allow to compile and test Maven with Java 10/11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MNG-6481: - Assignee: Sylwester Lachiewicz > Allow to compile and test Maven with Java 10/11 > --- > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.0-candidate > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6429) Integration Test site publishing requires Java 7 (or javadoc errors ignored)
[
https://issues.apache.org/jira/browse/MNG-6429?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657970#comment-16657970
]
Sylwester Lachiewicz commented on MNG-6429:
---
This will require changes in ITs to remove Plexus Javadoc tags. Can we move
this issue to next fix version 3.6.x?
> Integration Test site publishing requires Java 7 (or javadoc errors ignored)
>
>
> Key: MNG-6429
> URL: https://issues.apache.org/jira/browse/MNG-6429
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.4
>Reporter: Stephen Connolly
>Priority: Critical
> Fix For: 3.6.0-candidate
>
>
> {code:java}
> [INFO]
> 7 errors
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Maven Core ITs 2.1-SNAPSHOT SUCCESS [ 38.586
> s]
> [INFO] Maven IT Support ... SUCCESS [ 2.726 s]
> [INFO] Maven IT :: Plugins SUCCESS [ 2.693 s]
> [INFO] Maven IT Plugin :: Active Collection ... FAILURE [ 15.162
> s]
> [INFO] Maven IT Plugin :: Ant-Based ... SKIPPED
> [INFO] Maven IT Plugin :: Artifact SKIPPED
> [INFO] Maven IT Plugin :: Class Loader :: Dependency A SKIPPED
> [INFO] Maven IT Plugin :: Class Loader :: Dependency B SKIPPED
> [INFO] Maven IT Plugin :: Class Loader :: Dependency C SKIPPED
> [INFO] Maven IT Plugin :: Class Loader SKIPPED
> [INFO] Maven IT Plugin :: Class Loader :: Aggregator .. SKIPPED
> [INFO] Maven IT Plugin :: Configuration ... SKIPPED
> [INFO] Maven IT Plugin :: Context Passing . SKIPPED
> [INFO] Maven ITs :: Core Plugin Stubs . SKIPPED
> [INFO] Maven IT Clean Plugin Stub 0.1-stub-SNAPSHOT ... SKIPPED
> [INFO] Maven IT Compiler Plugin Stub 0.1-stub-SNAPSHOT SKIPPED
> [INFO] Maven IT Deploy Plugin Stub 0.1-stub-SNAPSHOT .. SKIPPED
> [INFO] Maven IT EAR Plugin Stub 0.1-stub-SNAPSHOT . SKIPPED
> [INFO] Maven IT EJB Plugin Stub 0.1-stub-SNAPSHOT . SKIPPED
> [INFO] Maven IT Install Plugin Stub 0.1-stub-SNAPSHOT . SKIPPED
> [INFO] Maven IT JAR Plugin Stub 0.1-stub-SNAPSHOT . SKIPPED
> [INFO] Maven IT Javadoc Plugin Stub 0.1-stub-SNAPSHOT . SKIPPED
> [INFO] Maven IT Plugin Plugin Stub 0.1-stub-SNAPSHOT .. SKIPPED
> [INFO] Maven IT RAR Plugin Stub 0.1-stub-SNAPSHOT . SKIPPED
> [INFO] Maven IT Resources Plugin Stub 0.1-stub-SNAPSHOT ... SKIPPED
> [INFO] Maven IT Site Plugin Stub 0.1-stub-SNAPSHOT SKIPPED
> [INFO] Maven IT Source Plugin Stub 0.1-stub-SNAPSHOT .. SKIPPED
> [INFO] Maven IT Surefire Plugin Stub 0.1-stub-SNAPSHOT SKIPPED
> [INFO] Maven IT WAR Plugin Stub 0.1-stub-SNAPSHOT . SKIPPED
> [INFO] Maven IT Plugin :: Dependency Collection ... SKIPPED
> [INFO] Maven IT Plugin :: Dependency Resolution ... SKIPPED
> [INFO] Maven IT Plugin :: Expression .. SKIPPED
> [INFO] Maven IT Plugin :: Error Mojos . SKIPPED
> [INFO] Maven IT Component . SKIPPED
> [INFO] Maven IT Plugin :: Extension Consumer .. SKIPPED
> [INFO] Maven IT Plugin :: Extension Provider .. SKIPPED
> [INFO] Maven IT Plugin :: Fork SKIPPED
> [INFO] Maven IT Plugin :: Invalid Descriptor .. SKIPPED
> [INFO] Maven IT Plugin :: Log File SKIPPED
> [INFO] Maven IT Helper Library SKIPPED
> [INFO] Maven IT Plugin :: Model Interpolation . SKIPPED
> [INFO] Maven IT Plugin :: No Default Component SKIPPED
> [INFO] Maven IT Plugin :: No Project .. SKIPPED
> [INFO] Maven IT Plugin :: Online .. SKIPPED
> [INFO] Maven IT Plugin :: Optional Mojos .. SKIPPED
> [INFO] Maven IT Plugin :: Packaging ... SKIPPED
> [INFO] Maven IT Plugin :: Parameter Implementation SKIPPED
> [INFO] Maven IT Plugin :: Plugin Dependency ... SKIPPED
> [INFO] Maven IT Plugin :: Project . SKIPPED
> [INFO] Maven IT Plugin :: Project Interpolation ... SKIPPED
> [INFO] Maven IT Plugin :: Setter .. SKIPPED
> [INFO] Maven IT Plugin :: Singleton Component . SKIPPED
> [INFO] Maven IT Plugin :: Site SKIPPED
> [INFO] Maven IT Plugin :: Toolchain ... SKIPPED
> [INFO] Maven IT Plugin :: Touch ... SKIPPED
> [INFO] Maven IT Plugin :: Uses Properties Plugin .. SKIPPED
> [INFO] Maven IT Plugin :: Uses Wagon Plugin
[jira] [Updated] (MNG-6490) Maven shall not fail reporting circular dependency when the dependency is a classified secondary artifact
[
https://issues.apache.org/jira/browse/MNG-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MNG-6490:
--
Summary: Maven shall not fail reporting circular dependency when the
dependency is a classified secondary artifact (was: maven fails reporting
circular dependency when the dependency is a classified secondary artifact)
> Maven shall not fail reporting circular dependency when the dependency is a
> classified secondary artifact
> -
>
> Key: MNG-6490
> URL: https://issues.apache.org/jira/browse/MNG-6490
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
>Affects Versions: 3.5.2, 3.5.3, 3.5.4
> Environment: Ubuntu 16.0.4 LTS, Ubuntu 18.0.4 LTS, Mac OS High
> Sierra, Oracle and OpenJDK 8, Oracle Java 11,
>Reporter: John Canny
>Assignee: Sylwester Lachiewicz
>Priority: Blocker
> Fix For: 3.6.0-candidate
>
>
> As of maven 3.5.2, 3.5.3, 3.5.4, the following pom fails with the error
> "dependencies.dependency. Main:MainJar:1' for Main:MainJar:1 is referencing
> itself"
> But the dependency is not circular, it references a classified jar (in our
> use cases its an architecture-dependent native code container jar). The pom
> below allows the main jar to be built without building the dependency every
> time (other lines conditionally build the dependency), and ensures the
> appropriate pre-built dependency is loaded. Behavior in maven 3.5.0 and
> earlier was correct (i.e. no error). This breaks several of the usage
> scenarios for classified artifacts...
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> Main
> MainJar
> jar
> 1
>
>
> ${project.groupId}
> ${project.artifactId}
> ${project.version}
> linux
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MNG-6490) maven fails reporting circular dependency when the dependency is a classified secondary artifact
[
https://issues.apache.org/jira/browse/MNG-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MNG-6490:
--
Fix Version/s: (was: 3.6.x-candidate)
3.6.0-candidate
> maven fails reporting circular dependency when the dependency is a classified
> secondary artifact
>
>
> Key: MNG-6490
> URL: https://issues.apache.org/jira/browse/MNG-6490
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
>Affects Versions: 3.5.2, 3.5.3, 3.5.4
> Environment: Ubuntu 16.0.4 LTS, Ubuntu 18.0.4 LTS, Mac OS High
> Sierra, Oracle and OpenJDK 8, Oracle Java 11,
>Reporter: John Canny
>Priority: Blocker
> Fix For: 3.6.0-candidate
>
>
> As of maven 3.5.2, 3.5.3, 3.5.4, the following pom fails with the error
> "dependencies.dependency. Main:MainJar:1' for Main:MainJar:1 is referencing
> itself"
> But the dependency is not circular, it references a classified jar (in our
> use cases its an architecture-dependent native code container jar). The pom
> below allows the main jar to be built without building the dependency every
> time (other lines conditionally build the dependency), and ensures the
> appropriate pre-built dependency is loaded. Behavior in maven 3.5.0 and
> earlier was correct (i.e. no error). This breaks several of the usage
> scenarios for classified artifacts...
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> Main
> MainJar
> jar
> 1
>
>
> ${project.groupId}
> ${project.artifactId}
> ${project.version}
> linux
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MNG-6490) maven fails reporting circular dependency when the dependency is a classified secondary artifact
[
https://issues.apache.org/jira/browse/MNG-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz reassigned MNG-6490:
-
Assignee: Sylwester Lachiewicz
> maven fails reporting circular dependency when the dependency is a classified
> secondary artifact
>
>
> Key: MNG-6490
> URL: https://issues.apache.org/jira/browse/MNG-6490
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
>Affects Versions: 3.5.2, 3.5.3, 3.5.4
> Environment: Ubuntu 16.0.4 LTS, Ubuntu 18.0.4 LTS, Mac OS High
> Sierra, Oracle and OpenJDK 8, Oracle Java 11,
>Reporter: John Canny
>Assignee: Sylwester Lachiewicz
>Priority: Blocker
> Fix For: 3.6.0-candidate
>
>
> As of maven 3.5.2, 3.5.3, 3.5.4, the following pom fails with the error
> "dependencies.dependency. Main:MainJar:1' for Main:MainJar:1 is referencing
> itself"
> But the dependency is not circular, it references a classified jar (in our
> use cases its an architecture-dependent native code container jar). The pom
> below allows the main jar to be built without building the dependency every
> time (other lines conditionally build the dependency), and ensures the
> appropriate pre-built dependency is loaded. Behavior in maven 3.5.0 and
> earlier was correct (i.e. no error). This breaks several of the usage
> scenarios for classified artifacts...
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> Main
> MainJar
> jar
> 1
>
>
> ${project.groupId}
> ${project.artifactId}
> ${project.version}
> linux
>
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (WAGON-537) Maven download speed of large artifacts is slow due to unsuitable buffer strategy for remote Artifacts in AbstractWagon
[
https://issues.apache.org/jira/browse/WAGON-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657939#comment-16657939
]
ASF GitHub Bot commented on WAGON-537:
--
olaf-otto commented on a change in pull request #50: WAGON-537 Maven download
speed of large artifacts is slow
URL: https://github.com/apache/maven-wagon/pull/50#discussion_r226835027
##
File path:
wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java
##
@@ -560,31 +564,78 @@ protected void transfer( Resource resource, InputStream
input, OutputStream outp
protected void transfer( Resource resource, InputStream input,
OutputStream output, int requestType, long maxSize )
throws IOException
{
-byte[] buffer = new byte[DEFAULT_BUFFER_SIZE];
+byte[] buffer = bufferForTransferring( resource );
TransferEvent transferEvent = new TransferEvent( this, resource,
TransferEvent.TRANSFER_PROGRESS, requestType );
transferEvent.setTimestamp( System.currentTimeMillis() );
long remaining = maxSize;
while ( remaining > 0 )
{
-// let's safely cast to int because the min value will be lower
than the buffer size.
-int n = input.read( buffer, 0, (int) Math.min( buffer.length,
remaining ) );
+// Read from the stream, block if necessary until either EOF or
buffer is filled.
+// Filling the buffer has priority since downstream processors
will significantly degrade i/o
+// performance if called to frequently (large data streams) as
they perform expensive tasks such as
+// console output or data integrity checks.
+int nextByte = input.read();
-if ( n == -1 )
+if ( nextByte == -1 )
{
break;
}
-fireTransferProgress( transferEvent, buffer, n );
+buffer[0] = ( byte ) nextByte;
+
+// let's safely cast to int because the min value will be lower
than the buffer size.
+int length = (int) min( buffer.length, remaining ),
+read = 1;
+
+for ( ; read < length ; ++read )
+{
+nextByte = input.read();
+if ( nextByte == -1 )
+{
+break;
+}
+buffer[read] = ( byte ) nextByte;
+}
+
+fireTransferProgress( transferEvent, buffer, read );
Review comment:
Hi @michael-o ,
Is there anything else that stands in the way of this getting accepted /
merged?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Maven download speed of large artifacts is slow due to unsuitable buffer
> strategy for remote Artifacts in AbstractWagon
> ---
>
> Key: WAGON-537
> URL: https://issues.apache.org/jira/browse/WAGON-537
> Project: Maven Wagon
> Issue Type: Improvement
> Components: wagon-provider-api
>Affects Versions: 3.2.0
> Environment: Windows 10, JDK 1.8, Nexus Artifact store > 100MB/s
> network connection.
>Reporter: Olaf Otto
>Assignee: Michael Osipov
>Priority: Major
> Labels: perfomance
> Attachments: wagon-issue.png
>
>
> We are using maven for build process automation with docker. This sometimes
> involves downloading images with a few gigabytes in size. Here, maven's
> download speed is consistently and reproducibly slow. For instance, an
> artifact with 7,5 GB in size took almost two hours to transfer in spite of a
> 100 MB/s connection with respective reproducible download speed from the
> remote nexus artifact repository when using a browser to download.
> I have investigated the issue using JProfiler. The result clearly shows a
> significant issue in AbstractWagon's transfer( Resource resource, InputStream
> input, OutputStream output, int requestType, long maxSize ) method used for
> remote artifacts.
> Here, the input stream is read in a loop using a 4 Kb buffer. Whenever data
> is received, the received data is pushed to downstream listeners via
> fireTransferProgress. These listeners (or rather consumers) perform
> expensive tasks such as checksumming or printing to console.
> Now, the underlying InputStream implementation used in transfer will return
> calls to read(bugger, offset, length) as soon as *some* data is available.
> That is, fireTransferProgress is invoked with an average number
[GitHub] olaf-otto commented on a change in pull request #50: WAGON-537 Maven download speed of large artifacts is slow
olaf-otto commented on a change in pull request #50: WAGON-537 Maven download
speed of large artifacts is slow
URL: https://github.com/apache/maven-wagon/pull/50#discussion_r226835027
##
File path:
wagon-provider-api/src/main/java/org/apache/maven/wagon/AbstractWagon.java
##
@@ -560,31 +564,78 @@ protected void transfer( Resource resource, InputStream
input, OutputStream outp
protected void transfer( Resource resource, InputStream input,
OutputStream output, int requestType, long maxSize )
throws IOException
{
-byte[] buffer = new byte[DEFAULT_BUFFER_SIZE];
+byte[] buffer = bufferForTransferring( resource );
TransferEvent transferEvent = new TransferEvent( this, resource,
TransferEvent.TRANSFER_PROGRESS, requestType );
transferEvent.setTimestamp( System.currentTimeMillis() );
long remaining = maxSize;
while ( remaining > 0 )
{
-// let's safely cast to int because the min value will be lower
than the buffer size.
-int n = input.read( buffer, 0, (int) Math.min( buffer.length,
remaining ) );
+// Read from the stream, block if necessary until either EOF or
buffer is filled.
+// Filling the buffer has priority since downstream processors
will significantly degrade i/o
+// performance if called to frequently (large data streams) as
they perform expensive tasks such as
+// console output or data integrity checks.
+int nextByte = input.read();
-if ( n == -1 )
+if ( nextByte == -1 )
{
break;
}
-fireTransferProgress( transferEvent, buffer, n );
+buffer[0] = ( byte ) nextByte;
+
+// let's safely cast to int because the min value will be lower
than the buffer size.
+int length = (int) min( buffer.length, remaining ),
+read = 1;
+
+for ( ; read < length ; ++read )
+{
+nextByte = input.read();
+if ( nextByte == -1 )
+{
+break;
+}
+buffer[read] = ( byte ) nextByte;
+}
+
+fireTransferProgress( transferEvent, buffer, read );
Review comment:
Hi @michael-o ,
Is there anything else that stands in the way of this getting accepted /
merged?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat
[
https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657847#comment-16657847
]
Hudson commented on MNG-5995:
-
Build failed in Jenkins: Maven TLP » maven » slach-pre-merge-master #2
See
https://builds.apache.org/job/maven-box/job/maven/job/slach-pre-merge-master/2/
> Maven itself cannot run without maven-compat
>
>
> Key: MNG-5995
> URL: https://issues.apache.org/jira/browse/MNG-5995
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, core
>Affects Versions: 3.3.9
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Critical
> Fix For: 3.6.x-candidate
>
>
> For all the 3.0 versions of the maven-plugins we require to not depend on
> maven-compat anymore. However, the Maven distribution still requires
> maven-compat. A simple proof: remove {{lib/maven-compat-3.x.y}} and execute
> {{mvn validate}}.
> You'll get the following exception:
> {noformat}[WARNING] Error injecting:
> org.apache.maven.project.DefaultProjectBuildingHelper
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:
> 1) No implementation for org.apache.maven.repository.RepositorySystem was
> bound.
> while locating
> org.apache.maven.project.DefaultProjectBuildingHelper{noformat}
> Reason: there's only one implementation: o.a.m.r.l.LegacyRepositorySystem,
> which is part of maven-compat.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657844#comment-16657844
]
Hudson commented on MNG-6391:
-
Build failed in Jenkins: Maven TLP » maven » slach-pre-merge-master #2
See
https://builds.apache.org/job/maven-box/job/maven/job/slach-pre-merge-master/2/
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.6.0
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6069) Migrate to non deprecated parts of Commons CLI
[
https://issues.apache.org/jira/browse/MNG-6069?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657846#comment-16657846
]
Hudson commented on MNG-6069:
-
Build failed in Jenkins: Maven TLP » maven » slach-pre-merge-master #2
See
https://builds.apache.org/job/maven-box/job/maven/job/slach-pre-merge-master/2/
> Migrate to non deprecated parts of Commons CLI
> --
>
> Key: MNG-6069
> URL: https://issues.apache.org/jira/browse/MNG-6069
> Project: Maven
> Issue Type: Improvement
> Components: Embedding
>Affects Versions: 3.3.9, 3.5.0-alpha-1, 3.5.0-beta-1, 3.5.0
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.6.0-candidate
>
>
> At the moment all parts of {{OptionBuilder...}} are marked deprecated in
> {{CLIManager}}. They should be migrated to:
> {code:java}
> Option.builder( HELP ).longOpt( "help" ).desc( "Display help information"
> ).build()
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6492) Minor improvement on Array construction, converson
[ https://issues.apache.org/jira/browse/MNG-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657845#comment-16657845 ] Hudson commented on MNG-6492: - Build failed in Jenkins: Maven TLP » maven » slach-pre-merge-master #2 See https://builds.apache.org/job/maven-box/job/maven/job/slach-pre-merge-master/2/ > Minor improvement on Array construction, converson > -- > > Key: MNG-6492 > URL: https://issues.apache.org/jira/browse/MNG-6492 > Project: Maven > Issue Type: Improvement >Reporter: Hoa Phan >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.0-candidate > > > See [https://shipilev.net/blog/2016/arrays-wisdom-ancients/] for benchmark. > These more performant code style are also built-in check in IntelliJ. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657838#comment-16657838
]
Hudson commented on MNG-6391:
-
Build succeeded in Jenkins: Maven TLP » maven » master #98
See https://builds.apache.org/job/maven-box/job/maven/job/master/98/
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.6.0
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657812#comment-16657812
]
Hudson commented on MNG-6391:
-
Build unstable in Jenkins: Maven TLP » maven » master #96
See https://builds.apache.org/job/maven-box/job/maven/job/master/96/
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.6.0
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MNG-6391.
Resolution: Done
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.6.0
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6391) Printout version of last built module in reactor build
[
https://issues.apache.org/jira/browse/MNG-6391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657803#comment-16657803
]
Karl Heinz Marbaise commented on MNG-6391:
--
Done in
[23f5c88d118fb06b93fc94017997d1753a0dc576|https://gitbox.apache.org/repos/asf?p=maven.git;a=commitdiff;h=23f5c88d118fb06b93fc94017997d1753a0dc576]
> Printout version of last built module in reactor build
> --
>
> Key: MNG-6391
> URL: https://issues.apache.org/jira/browse/MNG-6391
> Project: Maven
> Issue Type: Improvement
> Components: core
>Affects Versions: 3.5.3
>Reporter: Alexander Griesbaum
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.6.0
>
>
> MNG-6352 introduced printout of the version in a reactor build.
> If I build a multi-module project, not just the parent has the version
> printout but also the last built module.
> {code:java}
> [INFO]
>
> [INFO] Reactor Summary:
> [INFO]
> [INFO] parent 4.0.0-SNAPSHOT . SUCCESS [ 3.610 s]
> [INFO] parent-lib SUCCESS [ 0.492 s]
> [INFO] commons ... SUCCESS [ 25.444 s]
> [INFO] loadbalancer-starter .. SUCCESS [ 21.198 s]
> [INFO] proxy-config-starter 4.0.0-SNAPSHOT ... SUCCESS [ 7.496 s]
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> {code}
> If I remove the "proxy-config-starter" module, "loadbalancer-starter" got the
> version printout.
> Also this is not the order I configured the modules in the parent pom but I
> think this could be something on my side.
> {code:java}
>
> commons
> loadbalancer-starter
> parent-lib
> proxy-config-starter
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHADE-302) maven-shade-plugin fails to minimize JAR with Java 11
[
https://issues.apache.org/jira/browse/MSHADE-302?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16657769#comment-16657769
]
Karl Heinz Marbaise commented on MSHADE-302:
I appreciate your patch ...so I could initiate an other releasewith the
fix...great.
> maven-shade-plugin fails to minimize JAR with Java 11
> -
>
> Key: MSHADE-302
> URL: https://issues.apache.org/jira/browse/MSHADE-302
> Project: Maven Shade Plugin
> Issue Type: Bug
> Environment: maven-shade-plugin 3.2.1-SNAPSHOT or master branch.
> openjdk version "11" 2018-09-25
> OpenJDK Runtime Environment 18.9 (build 11+28)
> OpenJDK 64-Bit Server VM 18.9 (build 11+28, mixed mode)
>Reporter: Clément MATHIEU
>Priority: Major
>
> While checking whether maven-shade-plugin is Java 11 compatible or not, I
> noticed that it fails when minimizeJar is set to true and a class contains a
> nested static class.
> I was able to reproduce the issue by patching the
> shading-with-java-11-sources integration test:
> {code}
> diff --git a/src/it/shading-with-java-11-sources/pom.xml
> b/src/it/shading-with-java-11-sources/pom.xml
> index 0ea23fe..34898b7 100644
> --- a/src/it/shading-with-java-11-sources/pom.xml
> +++ b/src/it/shading-with-java-11-sources/pom.xml
> @@ -76,2 +76,3 @@ under the License.
>
> + true
>true
> diff --git
> a/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
>
> b/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
> index a92156e..c9fc298 100644
> ---
> a/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
> +++
> b/src/it/shading-with-java-11-sources/src/main/java/org/apache/maven/plugins/shade/its/App.java
> @@ -49,2 +49,5 @@ public class App
> }
> +
> +static class Foo {
> +}
> }
> {code}
>
> Running {{mvn -Prun-its -Dinvoker.test="*java-11*" verify}} leads to the
> following exception
> {code}
> Caused by: java.lang.UnsupportedOperationException: This feature requires ASM7
> at org.objectweb.asm.ClassVisitor.visitNestMember (ClassVisitor.java:236)
> at org.objectweb.asm.ClassVisitor.visitNestMember (ClassVisitor.java:239)
> at org.objectweb.asm.commons.ClassRemapper.visitNestMember
> (ClassRemapper.java:190)
> at org.objectweb.asm.ClassReader.accept (ClassReader.java:651)
> at org.objectweb.asm.ClassReader.accept (ClassReader.java:391)
> at org.vafer.jdependency.Clazzpath.addClazzpathUnit (Clazzpath.java:179)
> at org.vafer.jdependency.Clazzpath.addClazzpathUnit (Clazzpath.java:140)
> at org.apache.maven.plugins.shade.filter.MinijarFilter.
> (MinijarFilter.java:97)
> at org.apache.maven.plugins.shade.mojo.ShadeMojo.getFilters
> (ShadeMojo.java:834)
> at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute
> (ShadeMojo.java:434)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:208)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:154)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:146)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:954)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:289)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:229)
> at
