[jira] [Commented] (MNG-6261) Relative parent POM resolution failing in 3.5.0 with complex multimodule builds
[
https://issues.apache.org/jira/browse/MNG-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691137#comment-16691137
]
ASF GitHub Bot commented on MNG-6261:
-
fabcipriano commented on a change in pull request #192: [MNG-6261] - using java
File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r234469978
##
File path:
maven-model-builder/src/test/java/org/apache/maven/model/building/FileModelSourceTest.java
##
@@ -0,0 +1,52 @@
+package org.apache.maven.model.building;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import junit.framework.TestCase;
+
+/**
+ *
+ * @author fabiano
+ */
+public class FileModelSourceTest
+extends TestCase
+{
+
+public FileModelSourceTest() {
+}
+
+/**
+ * Test of equals method, of class FileModelSource.
+ */
+public void testEquals()
+throws Exception
+{
+File tempFile = File.createTempFile("pomTest-", ".xml");
+tempFile.deleteOnExit();
+FileModelSource instance = new FileModelSource( tempFile );
+
+assertFalse( instance.equals( null ) );
+assertFalse( instance.equals( new Object() ) );
+assertTrue( instance.equals( instance ) );
+assertTrue( instance.equals( new FileModelSource( tempFile ) ) );
+}
+
Review comment:
This seems simpler, thanks.
I added the test case in the original unit test
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Relative parent POM resolution failing in 3.5.0 with complex multimodule
> builds
> ---
>
> Key: MNG-6261
> URL: https://issues.apache.org/jira/browse/MNG-6261
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Dawid Weiss
>Priority: Minor
> Labels: up-for-grabs
> Fix For: 3.6.x-candidate
>
> Attachments: capture-6.png, repro.zip
>
>
> In my effort to upgrade an existing (fairly complex) Maven build to Java
> 1.9.0 I updated Maven to 3.5.0 (from 3.3.9). Unfortunately I get errors when
> the project's modules are resolved:
> {noformat}
> > mvn validate
> [FATAL] Non-resolvable parent POM for
> com.carrotsearch.lingo4g:lingo4g-public-bom:[unknown-version]: Could not find
> artifact com.carrotsearch.lingo4g:lingo4g-public:pom:1.6.0-SNAPSHOT and
> 'parent.relativePath' points at wrong local POM @ line 5, column 11
> ...
> (and many follow).
> {noformat}
> This build has a correct pom parent-structure (a tree), but is fairly complex
> -- the submodule hierarchy is not aligned with parent-child pom hierarchy
> (it's best to look at the repro code to understand how it's structured).
> However, it's been working correctly with all prior Maven versions and I
> wonder if it's a regression bug or maybe underspecified Maven requirement
> (that should be enforced with a warning and not lead to this odd runtime
> message).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] fabcipriano commented on a change in pull request #192: [MNG-6261] - using java File api to compare
fabcipriano commented on a change in pull request #192: [MNG-6261] - using java
File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r234469978
##
File path:
maven-model-builder/src/test/java/org/apache/maven/model/building/FileModelSourceTest.java
##
@@ -0,0 +1,52 @@
+package org.apache.maven.model.building;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import junit.framework.TestCase;
+
+/**
+ *
+ * @author fabiano
+ */
+public class FileModelSourceTest
+extends TestCase
+{
+
+public FileModelSourceTest() {
+}
+
+/**
+ * Test of equals method, of class FileModelSource.
+ */
+public void testEquals()
+throws Exception
+{
+File tempFile = File.createTempFile("pomTest-", ".xml");
+tempFile.deleteOnExit();
+FileModelSource instance = new FileModelSource( tempFile );
+
+assertFalse( instance.equals( null ) );
+assertFalse( instance.equals( new Object() ) );
+assertTrue( instance.equals( instance ) );
+assertTrue( instance.equals( new FileModelSource( tempFile ) ) );
+}
+
Review comment:
This seems simpler, thanks.
I added the test case in the original unit test
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat
[
https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16691132#comment-16691132
]
ASF GitHub Bot commented on MNG-5995:
-
slachiewicz commented on issue #185: [MNG-5995] Remove dependency to
maven-compat
URL: https://github.com/apache/maven/pull/185#issuecomment-439738389
ok found a problem - maven-enforcer still depends on maven-compat:
org.apache.maven.artifact.resolver.ArtifactResolver;
org.apache.maven.artifact.resolver.ArtifactCollector -> required by
maven-dependency-tree:2,2;
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Maven itself cannot run without maven-compat
>
>
> Key: MNG-5995
> URL: https://issues.apache.org/jira/browse/MNG-5995
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, core
>Affects Versions: 3.3.9
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Critical
> Fix For: 3.6.x-candidate
>
>
> For all the 3.0 versions of the maven-plugins we require to not depend on
> maven-compat anymore. However, the Maven distribution still requires
> maven-compat. A simple proof: remove {{lib/maven-compat-3.x.y}} and execute
> {{mvn validate}}.
> You'll get the following exception:
> {noformat}[WARNING] Error injecting:
> org.apache.maven.project.DefaultProjectBuildingHelper
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:
> 1) No implementation for org.apache.maven.repository.RepositorySystem was
> bound.
> while locating
> org.apache.maven.project.DefaultProjectBuildingHelper{noformat}
> Reason: there's only one implementation: o.a.m.r.l.LegacyRepositorySystem,
> which is part of maven-compat.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] slachiewicz commented on issue #185: [MNG-5995] Remove dependency to maven-compat
slachiewicz commented on issue #185: [MNG-5995] Remove dependency to maven-compat URL: https://github.com/apache/maven/pull/185#issuecomment-439738389 ok found a problem - maven-enforcer still depends on maven-compat: org.apache.maven.artifact.resolver.ArtifactResolver; org.apache.maven.artifact.resolver.ArtifactCollector -> required by maven-dependency-tree:2,2; This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (MNG-6520) Update assembly descriptors to 2.0.0
Sylwester Lachiewicz created MNG-6520: - Summary: Update assembly descriptors to 2.0.0 Key: MNG-6520 URL: https://issues.apache.org/jira/browse/MNG-6520 Project: Maven Issue Type: Improvement Reporter: Sylwester Lachiewicz Update to the version compatible with 3.0+ maven-assembly-plugin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (SUREFIRE-1600) Surefire Project using surefire:2.12.4 is not fully able to work with JDK 10+ on internal build system. Therefore surefire-shadefire should go with Surefire:3.0.0-M1.
[ https://issues.apache.org/jira/browse/SUREFIRE-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana closed SUREFIRE-1600. -- Resolution: Fixed https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=d8d03e68a566e19f4dcc3bfbc1c0f4a1d5a23575 > Surefire Project using surefire:2.12.4 is not fully able to work with JDK 10+ > on internal build system. Therefore surefire-shadefire should go with > Surefire:3.0.0-M1. > -- > > Key: SUREFIRE-1600 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1600 > Project: Maven Surefire > Issue Type: Task >Affects Versions: 3.0.0-M1 >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] sepe81 opened a new pull request #2: Update maven-compiler-plugin to 3.8.0
sepe81 opened a new pull request #2: Update maven-compiler-plugin to 3.8.0 URL: https://github.com/apache/maven-apache-parent/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6261) Relative parent POM resolution failing in 3.5.0 with complex multimodule builds
[
https://issues.apache.org/jira/browse/MNG-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690972#comment-16690972
]
ASF GitHub Bot commented on MNG-6261:
-
rfscholte commented on a change in pull request #192: [MNG-6261] - using java
File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r234453641
##
File path:
maven-model-builder/src/test/java/org/apache/maven/model/building/FileModelSourceTest.java
##
@@ -0,0 +1,52 @@
+package org.apache.maven.model.building;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import junit.framework.TestCase;
+
+/**
+ *
+ * @author fabiano
+ */
+public class FileModelSourceTest
+extends TestCase
+{
+
+public FileModelSourceTest() {
+}
+
+/**
+ * Test of equals method, of class FileModelSource.
+ */
+public void testEquals()
+throws Exception
+{
+File tempFile = File.createTempFile("pomTest-", ".xml");
+tempFile.deleteOnExit();
+FileModelSource instance = new FileModelSource( tempFile );
+
+assertFalse( instance.equals( null ) );
+assertFalse( instance.equals( new Object() ) );
+assertTrue( instance.equals( instance ) );
+assertTrue( instance.equals( new FileModelSource( tempFile ) ) );
+}
+
Review comment:
Hmm, the original unittest was already very usefull. I would expected an
extra testmethod in it, something like
public void windowsPaths() throws Exception {
assumeThat( SystemUtils.IS_OS_WINDOWS );
// here compare uppercase and lowercase paths
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Relative parent POM resolution failing in 3.5.0 with complex multimodule
> builds
> ---
>
> Key: MNG-6261
> URL: https://issues.apache.org/jira/browse/MNG-6261
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Dawid Weiss
>Priority: Minor
> Labels: up-for-grabs
> Fix For: 3.6.x-candidate
>
> Attachments: capture-6.png, repro.zip
>
>
> In my effort to upgrade an existing (fairly complex) Maven build to Java
> 1.9.0 I updated Maven to 3.5.0 (from 3.3.9). Unfortunately I get errors when
> the project's modules are resolved:
> {noformat}
> > mvn validate
> [FATAL] Non-resolvable parent POM for
> com.carrotsearch.lingo4g:lingo4g-public-bom:[unknown-version]: Could not find
> artifact com.carrotsearch.lingo4g:lingo4g-public:pom:1.6.0-SNAPSHOT and
> 'parent.relativePath' points at wrong local POM @ line 5, column 11
> ...
> (and many follow).
> {noformat}
> This build has a correct pom parent-structure (a tree), but is fairly complex
> -- the submodule hierarchy is not aligned with parent-child pom hierarchy
> (it's best to look at the repro code to understand how it's structured).
> However, it's been working correctly with all prior Maven versions and I
> wonder if it's a regression bug or maybe underspecified Maven requirement
> (that should be enforced with a warning and not lead to this odd runtime
> message).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] rfscholte commented on a change in pull request #192: [MNG-6261] - using java File api to compare
rfscholte commented on a change in pull request #192: [MNG-6261] - using java
File api to compare
URL: https://github.com/apache/maven/pull/192#discussion_r234453641
##
File path:
maven-model-builder/src/test/java/org/apache/maven/model/building/FileModelSourceTest.java
##
@@ -0,0 +1,52 @@
+package org.apache.maven.model.building;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.File;
+import junit.framework.TestCase;
+
+/**
+ *
+ * @author fabiano
+ */
+public class FileModelSourceTest
+extends TestCase
+{
+
+public FileModelSourceTest() {
+}
+
+/**
+ * Test of equals method, of class FileModelSource.
+ */
+public void testEquals()
+throws Exception
+{
+File tempFile = File.createTempFile("pomTest-", ".xml");
+tempFile.deleteOnExit();
+FileModelSource instance = new FileModelSource( tempFile );
+
+assertFalse( instance.equals( null ) );
+assertFalse( instance.equals( new Object() ) );
+assertTrue( instance.equals( instance ) );
+assertTrue( instance.equals( new FileModelSource( tempFile ) ) );
+}
+
Review comment:
Hmm, the original unittest was already very usefull. I would expected an
extra testmethod in it, something like
public void windowsPaths() throws Exception {
assumeThat( SystemUtils.IS_OS_WINDOWS );
// here compare uppercase and lowercase paths
}
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MJAVADOC-538) JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc warning, triggers failure
[
https://issues.apache.org/jira/browse/MJAVADOC-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690962#comment-16690962
]
ASF GitHub Bot commented on MJAVADOC-538:
-
rfscholte commented on a change in pull request #11: [MJAVADOC-538] Filter out
'Picked up'
URL:
https://github.com/apache/maven-javadoc-plugin/pull/11#discussion_r234453033
##
File path: pom.xml
##
@@ -441,6 +441,7 @@ under the License.
true
+<_JAVA_OPTIONS>-Dabc=def
Review comment:
Please add a comment behind it like this: ``
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc
> warning, triggers failure
> -
>
> Key: MJAVADOC-538
> URL: https://issues.apache.org/jira/browse/MJAVADOC-538
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
> Environment: Maven 3.5.4
> Java 1.8.0_181
>Reporter: Yoann Rodière
>Priority: Major
>
> When an environment variable {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is
> defined, every JVM that starts will output a message to inform users of these
> options being picked up:
> {noformat}
> $ export JAVA_TOOL_OPTIONS=-Dfoo
> $ java -version
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> java version "1.8.0_181"
> Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode){noformat}
> Apparently this message cannot be suppressed, that's on purpose an won't
> change: [https://bugs.openjdk.java.net/browse/JDK-8039152]
>
> Unfortunately, this message seems to be interpreted by the
> maven-javadoc-plugin as a warning:
> {noformat}
> [INFO] --- maven-javadoc-plugin:3.0.1:javadoc-no-fork (generate-javadoc) @
> hibernate-search-util-internal-common ---
> [INFO] The goal 'org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc'
> has not been previously called for the module:
> 'org.hibernate.search:hibernate-search-util-internal-test:jar:6.0.0-SNAPSHOT'.
> Trying to invoke it...
> [WARN] Maven will be executed in interactive mode, but no input stream has
> been configured for this MavenInvoker instance.
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> [WARNING] Creating fake javadoc directory to prevent repeated invocations:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs
> [ERROR] Error fetching link:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs/package-list.
> Ignored it.
> [WARNING] Javadoc Warnings
> [WARNING] Picked up JAVA_TOOL_OPTIONS: -Dfoo
> {noformat}
> (see the last line, the message appears in the list of warnings)
> No big deal... until you enable the
> [failOnWarnings|https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-no-fork-mojo.html#failOnWarnings]
> option. Then the whole build will fail just because some JVM detected an
> environment variable...
> I couldn't find any workaround, except disabling the {{failOnWarnings}}
> options, but that's more a surrender than a workaround.
> Note that the definition of {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is not
> exactly an exotic use case, especially on Continuous Integration platforms.
> [Travis CI uses {{_JAVA_OPTIONS}}
> |https://docs.travis-ci.com/user/build-environment-updates/2017-09-06/#added]
> to set JVM memory limits in its containerized environments, and [the Jenkins
> CI Pipeline Maven plugin uses
> {{JAVA_TOOL_OPTIONS}}|https://wiki.jenkins.io/display/JENKINS/Pipeline+Maven+Plugin#PipelineMavenPlugin-WhydoIseemessages%22[WARNING]PickedupJAVA_TOOL_OPTIONS...%22inthebuildlogs?]
> to pass options to Maven processes transparently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MJAVADOC-538) JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc warning, triggers failure
[
https://issues.apache.org/jira/browse/MJAVADOC-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690965#comment-16690965
]
ASF GitHub Bot commented on MJAVADOC-538:
-
rfscholte commented on a change in pull request #11: [MJAVADOC-538] Filter out
'Picked up'
URL:
https://github.com/apache/maven-javadoc-plugin/pull/11#discussion_r234453162
##
File path: src/it/projects/MJAVADOC-538/pom.xml
##
@@ -0,0 +1,44 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+
+ org.apache.maven.plugins.maven-javadoc-plugin.it
+ mjavadoc-538
+ 1.0-SNAPSHOT
+
+
+UTF-8
+
+
+
+
+
+
+ org.apache.maven.plugins
+ maven-javadoc-plugin
+ @pom.version@
+
Review comment:
As said, put the fialOnWarning here as configuration (and I'd prefer
project.version over pom.version)
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc
> warning, triggers failure
> -
>
> Key: MJAVADOC-538
> URL: https://issues.apache.org/jira/browse/MJAVADOC-538
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
> Environment: Maven 3.5.4
> Java 1.8.0_181
>Reporter: Yoann Rodière
>Priority: Major
>
> When an environment variable {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is
> defined, every JVM that starts will output a message to inform users of these
> options being picked up:
> {noformat}
> $ export JAVA_TOOL_OPTIONS=-Dfoo
> $ java -version
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> java version "1.8.0_181"
> Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode){noformat}
> Apparently this message cannot be suppressed, that's on purpose an won't
> change: [https://bugs.openjdk.java.net/browse/JDK-8039152]
>
> Unfortunately, this message seems to be interpreted by the
> maven-javadoc-plugin as a warning:
> {noformat}
> [INFO] --- maven-javadoc-plugin:3.0.1:javadoc-no-fork (generate-javadoc) @
> hibernate-search-util-internal-common ---
> [INFO] The goal 'org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc'
> has not been previously called for the module:
> 'org.hibernate.search:hibernate-search-util-internal-test:jar:6.0.0-SNAPSHOT'.
> Trying to invoke it...
> [WARN] Maven will be executed in interactive mode, but no input stream has
> been configured for this MavenInvoker instance.
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> [WARNING] Creating fake javadoc directory to prevent repeated invocations:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs
> [ERROR] Error fetching link:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs/package-list.
> Ignored it.
> [WARNING] Javadoc Warnings
> [WARNING] Picked up JAVA_TOOL_OPTIONS: -Dfoo
> {noformat}
> (see the last line, the message appears in the list of warnings)
> No big deal... until you enable the
> [failOnWarnings|https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-no-fork-mojo.html#failOnWarnings]
> option. Then the whole build will fail just because some JVM detected an
> environment variable...
> I couldn't find any workaround, except disabling the {{failOnWarnings}}
> options, but that's more a surrender than a workaround.
> Note that the definition of {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is not
> exactly an exotic use case, especially on Continuous Integration platforms.
> [Travis CI uses {{_JAVA_OPTIONS}}
> |https://docs.travis-ci.com/user/build-environment-updates/2017-09-06/#added]
> to set JVM memory limits in its containerized environments, and [the Jenkins
> CI Pipeline Maven plugin uses
> {{JAVA_TOOL_OPTIONS}}|https://wiki.jenkins.io/display/JENKINS/Pipeline+Maven+Plugin#PipelineMavenPlugin-WhydoIseemessages%22[WARNING]PickedupJAVA_TOOL_OPTIONS...%22inthebuildlogs?]
> to pass options to Maven processes transparently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MJAVADOC-538) JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc warning, triggers failure
[
https://issues.apache.org/jira/browse/MJAVADOC-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690964#comment-16690964
]
ASF GitHub Bot commented on MJAVADOC-538:
-
rfscholte commented on a change in pull request #11: [MJAVADOC-538] Filter out
'Picked up'
URL:
https://github.com/apache/maven-javadoc-plugin/pull/11#discussion_r234453124
##
File path: src/it/projects/MJAVADOC-538/pom.xml
##
@@ -0,0 +1,44 @@
+
+
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+ 4.0.0
+
+ org.apache.maven.plugins.maven-javadoc-plugin.it
+ mjavadoc-538
+ 1.0-SNAPSHOT
+
Review comment:
Add `https://issues.apache.org/jira/browse/MJAVADOC-538` for easy
access to original issue
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc
> warning, triggers failure
> -
>
> Key: MJAVADOC-538
> URL: https://issues.apache.org/jira/browse/MJAVADOC-538
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
> Environment: Maven 3.5.4
> Java 1.8.0_181
>Reporter: Yoann Rodière
>Priority: Major
>
> When an environment variable {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is
> defined, every JVM that starts will output a message to inform users of these
> options being picked up:
> {noformat}
> $ export JAVA_TOOL_OPTIONS=-Dfoo
> $ java -version
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> java version "1.8.0_181"
> Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode){noformat}
> Apparently this message cannot be suppressed, that's on purpose an won't
> change: [https://bugs.openjdk.java.net/browse/JDK-8039152]
>
> Unfortunately, this message seems to be interpreted by the
> maven-javadoc-plugin as a warning:
> {noformat}
> [INFO] --- maven-javadoc-plugin:3.0.1:javadoc-no-fork (generate-javadoc) @
> hibernate-search-util-internal-common ---
> [INFO] The goal 'org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc'
> has not been previously called for the module:
> 'org.hibernate.search:hibernate-search-util-internal-test:jar:6.0.0-SNAPSHOT'.
> Trying to invoke it...
> [WARN] Maven will be executed in interactive mode, but no input stream has
> been configured for this MavenInvoker instance.
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> [WARNING] Creating fake javadoc directory to prevent repeated invocations:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs
> [ERROR] Error fetching link:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs/package-list.
> Ignored it.
> [WARNING] Javadoc Warnings
> [WARNING] Picked up JAVA_TOOL_OPTIONS: -Dfoo
> {noformat}
> (see the last line, the message appears in the list of warnings)
> No big deal... until you enable the
> [failOnWarnings|https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-no-fork-mojo.html#failOnWarnings]
> option. Then the whole build will fail just because some JVM detected an
> environment variable...
> I couldn't find any workaround, except disabling the {{failOnWarnings}}
> options, but that's more a surrender than a workaround.
> Note that the definition of {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is not
> exactly an exotic use case, especially on Continuous Integration platforms.
> [Travis CI uses {{_JAVA_OPTIONS}}
> |https://docs.travis-ci.com/user/build-environment-updates/2017-09-06/#added]
> to set JVM memory limits in its containerized environments, and [the Jenkins
> CI Pipeline Maven plugin uses
> {{JAVA_TOOL_OPTIONS}}|https://wiki.jenkins.io/display/JENKINS/Pipeline+Maven+Plugin#PipelineMavenPlugin-WhydoIseemessages%22[WARNING]PickedupJAVA_TOOL_OPTIONS...%22inthebuildlogs?]
> to pass options to Maven processes transparently.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MJAVADOC-538) JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc warning, triggers failure
[
https://issues.apache.org/jira/browse/MJAVADOC-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690963#comment-16690963
]
ASF GitHub Bot commented on MJAVADOC-538:
-
rfscholte commented on a change in pull request #11: [MJAVADOC-538] Filter out
'Picked up'
URL:
https://github.com/apache/maven-javadoc-plugin/pull/11#discussion_r234453156
##
File path: src/it/projects/MJAVADOC-538/invoker.properties
##
@@ -0,0 +1,18 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+invoker.goals=clean javadoc:javadoc -Dmaven.javadoc.failOnWarnings=true
Review comment:
Make the property explicit in the plugin configuration, otherwise it could
be overwritten from commandline when executing integration tests.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> JVM "JAVA_TOOL_OPTIONS" or "_JAVA_OPTIONS" message detected as javadoc
> warning, triggers failure
> -
>
> Key: MJAVADOC-538
> URL: https://issues.apache.org/jira/browse/MJAVADOC-538
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 3.0.1
> Environment: Maven 3.5.4
> Java 1.8.0_181
>Reporter: Yoann Rodière
>Priority: Major
>
> When an environment variable {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is
> defined, every JVM that starts will output a message to inform users of these
> options being picked up:
> {noformat}
> $ export JAVA_TOOL_OPTIONS=-Dfoo
> $ java -version
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> java version "1.8.0_181"
> Java(TM) SE Runtime Environment (build 1.8.0_181-b13)
> Java HotSpot(TM) 64-Bit Server VM (build 25.181-b13, mixed mode){noformat}
> Apparently this message cannot be suppressed, that's on purpose an won't
> change: [https://bugs.openjdk.java.net/browse/JDK-8039152]
>
> Unfortunately, this message seems to be interpreted by the
> maven-javadoc-plugin as a warning:
> {noformat}
> [INFO] --- maven-javadoc-plugin:3.0.1:javadoc-no-fork (generate-javadoc) @
> hibernate-search-util-internal-common ---
> [INFO] The goal 'org.apache.maven.plugins:maven-javadoc-plugin:3.0.1:javadoc'
> has not been previously called for the module:
> 'org.hibernate.search:hibernate-search-util-internal-test:jar:6.0.0-SNAPSHOT'.
> Trying to invoke it...
> [WARN] Maven will be executed in interactive mode, but no input stream has
> been configured for this MavenInvoker instance.
> Picked up JAVA_TOOL_OPTIONS: -Dfoo
> [WARNING] Creating fake javadoc directory to prevent repeated invocations:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs
> [ERROR] Error fetching link:
> /home/yrodiere/workspaces/main/hibernate-search-parent/util/internal/test/target/site/apidocs/package-list.
> Ignored it.
> [WARNING] Javadoc Warnings
> [WARNING] Picked up JAVA_TOOL_OPTIONS: -Dfoo
> {noformat}
> (see the last line, the message appears in the list of warnings)
> No big deal... until you enable the
> [failOnWarnings|https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-no-fork-mojo.html#failOnWarnings]
> option. Then the whole build will fail just because some JVM detected an
> environment variable...
> I couldn't find any workaround, except disabling the {{failOnWarnings}}
> options, but that's more a surrender than a workaround.
> Note that the definition of {{_JAVA_OPTIONS}} or {{JAVA_TOOL_OPTIONS}} is not
> exactly an exotic use case, especially on Continuous Integration platforms.
> [Travis CI uses {{_JAVA_OPTIONS}}
> |https://docs.travis-ci.com/user/build-environment-updates/2017-09-06/#added]
> to set JVM memory limits in its containerized environments, and [the Jenkins
> CI Pipeline Maven plugin uses
>
[GitHub] rfscholte commented on a change in pull request #11: [MJAVADOC-538] Filter out 'Picked up'
rfscholte commented on a change in pull request #11: [MJAVADOC-538] Filter out 'Picked up' URL: https://github.com/apache/maven-javadoc-plugin/pull/11#discussion_r234453156 ## File path: src/it/projects/MJAVADOC-538/invoker.properties ## @@ -0,0 +1,18 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +invoker.goals=clean javadoc:javadoc -Dmaven.javadoc.failOnWarnings=true Review comment: Make the property explicit in the plugin configuration, otherwise it could be overwritten from commandline when executing integration tests. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rfscholte commented on a change in pull request #11: [MJAVADOC-538] Filter out 'Picked up'
rfscholte commented on a change in pull request #11: [MJAVADOC-538] Filter out 'Picked up' URL: https://github.com/apache/maven-javadoc-plugin/pull/11#discussion_r234453033 ## File path: pom.xml ## @@ -441,6 +441,7 @@ under the License. true +<_JAVA_OPTIONS>-Dabc=def Review comment: Please add a comment behind it like this: `` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rfscholte commented on a change in pull request #11: [MJAVADOC-538] Filter out 'Picked up'
rfscholte commented on a change in pull request #11: [MJAVADOC-538] Filter out 'Picked up' URL: https://github.com/apache/maven-javadoc-plugin/pull/11#discussion_r234453124 ## File path: src/it/projects/MJAVADOC-538/pom.xml ## @@ -0,0 +1,44 @@ + + + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + + org.apache.maven.plugins.maven-javadoc-plugin.it + mjavadoc-538 + 1.0-SNAPSHOT + Review comment: Add `https://issues.apache.org/jira/browse/MJAVADOC-538` for easy access to original issue This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rfscholte commented on a change in pull request #11: [MJAVADOC-538] Filter out 'Picked up'
rfscholte commented on a change in pull request #11: [MJAVADOC-538] Filter out 'Picked up' URL: https://github.com/apache/maven-javadoc-plugin/pull/11#discussion_r234453162 ## File path: src/it/projects/MJAVADOC-538/pom.xml ## @@ -0,0 +1,44 @@ + + + + +http://maven.apache.org/POM/4.0.0; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> + 4.0.0 + + org.apache.maven.plugins.maven-javadoc-plugin.it + mjavadoc-538 + 1.0-SNAPSHOT + + +UTF-8 + + + + + + + org.apache.maven.plugins + maven-javadoc-plugin + @pom.version@ + Review comment: As said, put the fialOnWarning here as configuration (and I'd prefer project.version over pom.version) This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690957#comment-16690957 ] Hudson commented on MNG-6481: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6294 #2 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6294/2/ > Allow to compile and test Maven with Java 11 > > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNGSITE-357) README.md: Maven user list link not working
[ https://issues.apache.org/jira/browse/MNGSITE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690958#comment-16690958 ] Hudson commented on MNGSITE-357: Build succeeded in Jenkins: Maven TLP » maven » MNG-6294 #2 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6294/2/ > README.md: Maven user list link not working > --- > > Key: MNGSITE-357 > URL: https://issues.apache.org/jira/browse/MNGSITE-357 > Project: Maven Project Web Site > Issue Type: Bug > Environment: github, homepage >Reporter: Matthias Fuchs >Assignee: Michael Osipov >Priority: Trivial > Labels: docs, github, homepage, mailing-list, readme > > The link from the github README doesn't work: > [https://maven.apache.org/mail-lists.html.] > You guys shoudl definitely enable github issues! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6294) Convert MavenPluginValidator into a plexus component
[ https://issues.apache.org/jira/browse/MNG-6294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690959#comment-16690959 ] Hudson commented on MNG-6294: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6294 #2 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6294/2/ > Convert MavenPluginValidator into a plexus component > > > Key: MNG-6294 > URL: https://issues.apache.org/jira/browse/MNG-6294 > Project: Maven > Issue Type: Improvement > Components: core >Reporter: Michael Simacek >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.6.x-candidate > > > [XMvn|https://github.com/fedora-java/xmvn] is a maven extension that helps > with creating RPM packages. In order to comply with packaging requirements, > it needs to relax some checks that maven does. One of those is plugin > validation done in MavenPluginValidator class. Currently, it overrides that > by shadowing the class on the classpath, which is a hack. It would help if > MavenPluginValidator was a plexus component and thus the implementation could > be selected by configuration. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNGSITE-357) README.md: Maven user list link not working
[ https://issues.apache.org/jira/browse/MNGSITE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690934#comment-16690934 ] Hudson commented on MNGSITE-357: Build succeeded in Jenkins: Maven TLP » maven » MNG-5995 #3 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5995/3/ > README.md: Maven user list link not working > --- > > Key: MNGSITE-357 > URL: https://issues.apache.org/jira/browse/MNGSITE-357 > Project: Maven Project Web Site > Issue Type: Bug > Environment: github, homepage >Reporter: Matthias Fuchs >Assignee: Michael Osipov >Priority: Trivial > Labels: docs, github, homepage, mailing-list, readme > > The link from the github README doesn't work: > [https://maven.apache.org/mail-lists.html.] > You guys shoudl definitely enable github issues! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-5995) Maven itself cannot run without maven-compat
[
https://issues.apache.org/jira/browse/MNG-5995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690935#comment-16690935
]
Hudson commented on MNG-5995:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5995 #3
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5995/3/
> Maven itself cannot run without maven-compat
>
>
> Key: MNG-5995
> URL: https://issues.apache.org/jira/browse/MNG-5995
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap Build, core
>Affects Versions: 3.3.9
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Critical
> Fix For: 3.6.x-candidate
>
>
> For all the 3.0 versions of the maven-plugins we require to not depend on
> maven-compat anymore. However, the Maven distribution still requires
> maven-compat. A simple proof: remove {{lib/maven-compat-3.x.y}} and execute
> {{mvn validate}}.
> You'll get the following exception:
> {noformat}[WARNING] Error injecting:
> org.apache.maven.project.DefaultProjectBuildingHelper
> com.google.inject.ProvisionException: Unable to provision, see the following
> errors:
> 1) No implementation for org.apache.maven.repository.RepositorySystem was
> bound.
> while locating
> org.apache.maven.project.DefaultProjectBuildingHelper{noformat}
> Reason: there's only one implementation: o.a.m.r.l.LegacyRepositorySystem,
> which is part of maven-compat.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690933#comment-16690933 ] Hudson commented on MNG-6481: - Build succeeded in Jenkins: Maven TLP » maven » MNG-5995 #3 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5995/3/ > Allow to compile and test Maven with Java 11 > > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6515) Fix javadoc build errors under Java 8 and 11
[ https://issues.apache.org/jira/browse/MNG-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690932#comment-16690932 ] Hudson commented on MNG-6515: - Build succeeded in Jenkins: Maven TLP » maven » MNG-5995 #3 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5995/3/ > Fix javadoc build errors under Java 8 and 11 > > > Key: MNG-6515 > URL: https://issues.apache.org/jira/browse/MNG-6515 > Project: Maven > Issue Type: Improvement > Components: General >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6505) child.(x.y).inherit.append.path value should be inherited
[ https://issues.apache.org/jira/browse/MNG-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690931#comment-16690931 ] Hudson commented on MNG-6505: - Build succeeded in Jenkins: Maven TLP » maven » MNG-5995 #3 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5995/3/ > child.(x.y).inherit.append.path value should be inherited > - > > Key: MNG-6505 > URL: https://issues.apache.org/jira/browse/MNG-6505 > Project: Maven > Issue Type: Bug > Components: Inheritance and Interpolation >Affects Versions: 3.6.0 >Reporter: Hervé Boutemy >Assignee: Hervé Boutemy >Priority: Critical > Fix For: 3.6.1 > > > in Maven 3.6.0, values of child.inherit.append.path are not inherited: they > have to be explicitely defined in every child pom of they switch to default > "true" value > these values should be inherited: once defined in a parent pom, every child > should inherit from the value (and of course be able to override) > Note: this seems to have been part of the MNG-6059 implementation that was > done for Maven dropped 3.4.0 version but was forgotten during Maven 3.6.0 > merge... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6059) Important use cases not covered, as child.inherit.append.path affects all children
[
https://issues.apache.org/jira/browse/MNG-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690930#comment-16690930
]
Hudson commented on MNG-6059:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5995 #3
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5995/3/
> Important use cases not covered, as child.inherit.append.path affects all
> children
> --
>
> Key: MNG-6059
> URL: https://issues.apache.org/jira/browse/MNG-6059
> Project: Maven
> Issue Type: Improvement
> Components: Inheritance and Interpolation
>Affects Versions: 3.6.0
> Environment: Apache Maven 3.4.0-SNAPSHOT
> (227085283b6379038ec16f4cf9ad2e8869cef694; 2016-07-06T21:29:12+02:00)
>Reporter: Andreas Sewe
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.6.1
>
>
> The {{child.inherit.append.path}} attribute introduced with MNG-5951
> unfortunately does not support the use case where the children of the element
> with the attribute should follow different inheritance rules. Take a typical
> configuration for Github, for example (taken from
> <[http://central.sonatype.org/pages/requirements.html]>):
> {noformat}
>
>
> scm:git:git://github.com/simpligility/ossrh-demo.git
>
> scm:git:ssh://github.com:simpligility/ossrh-demo.git
> http://github.com/simpligility/ossrh-demo/tree/master
>
> {noformat}
> If the {{ossrh-demo.git}} repository contains a child module called
> {{some-module}}, then that child’s {{scm/url}} should become
> {{[http://github.com/simpligility/ossrh-demo/tree/master/some-module]}} as
> per the normal inheritance rules, but both the {{scm/connection}} and
> {{scm/developerConnection}} URLs should remain unchanged.
> Unfortunately, this is not possible with {{*child*.inherit.append.path}},
> which acts on all children simultaneously.
> IMHO, this is a conceptual problem. In particular, setting
> {{child.inherit.append.path}} on the *root* element to just control a single
> child ({{project/url}}) feels wrong, as the attribute is in all likelihood
> not even located close to the {{}} element it controls.
> h1. Implemented Solution
> {code:xml}
> ...
> child.scm.developerConnection.inherit.append.path="false"
>child.scm.url.inherit.append.path="false">
> ...
> ...
> ...
>
>
>
> ...
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MNG-6519) Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec
[
https://issues.apache.org/jira/browse/MNG-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise closed MNG-6519.
Resolution: Not A Problem
Please don't use JIRA as a forum. Please ask in the user mailing list or on
Stackoverflow for such things
> Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec
> -
>
> Key: MNG-6519
> URL: https://issues.apache.org/jira/browse/MNG-6519
> Project: Maven
> Issue Type: Task
> Components: Plugin API, POM
>Reporter: Patrik Ek
>Priority: Major
>
> Hey.
> So, I'm trying to make a Web Application and a maven client that uses it.
> However, I get the "Failed to execute goal
> org.codehaus.mojo:exec-maven-plugin:1.2.1:exec" when ever I run it. Now when
> I try to do my teacher's example, I get the same problem. She doesn't seem to
> understand what the problem is, so I'm asking you all.
> This is my pom.xml file:
> {code:java}
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> com.nackademin.systemintegration
> WebApplicationClientDemo2
> 1.0-SNAPSHOT
> jar
>
> UTF-8
> 1.8
> 1.8
>
>
>
> com.sun.jersey
> jersey-client
> 1.19.4
>
>
> javax
> javaee-web-api
> 7.0
> jar
>
>
> com.sun.jersey
> jersey-json
> 1.17.1
>
>
> com.google.code.gson
> gson
> 2.8.2
>
>
>
> {code}
> This is the Web Application code I made:
> {code:java}
> BookDao bookdao = new BookDao();
> @GET
> @Path("/books")
> @Produces(MediaType.APPLICATION_XML)
> public List getBooks() {
> return bookdao.getAllBooks();
> }
> {code}
> And this is my maven client:
> {code:java}
> String xmlString = service.path("rest")
> .path("BookService/books").accept(MediaType.APPLICATION_XML).get(String.class);
> System.out.println(xmlString);
> System.out.println();
> Book[] bookArray = service.path("rest")
> .path("BookService/books").accept(MediaType.APPLICATION_XML).get(Book[].class);
> for (Book b : bookArray) {
> System.out.println("Book id: " + b.getId() + " title: " + b.getTitle() + "
> author: " + b.getAuthor());
> }
> {code}
> Do anyone know what the crap is the problem? Also, before anyone ask, yes,
> I've been on stackowerflow and search through google. I can't find anything
> that works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MNG-6519) Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec
[
https://issues.apache.org/jira/browse/MNG-6519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Patrik Ek updated MNG-6519:
---
Priority: Major (was: Critical)
> Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec
> -
>
> Key: MNG-6519
> URL: https://issues.apache.org/jira/browse/MNG-6519
> Project: Maven
> Issue Type: Task
> Components: Plugin API, POM
>Reporter: Patrik Ek
>Priority: Major
>
> Hey.
> So, I'm trying to make a Web Application and a maven client that uses it.
> However, I get the "Failed to execute goal
> org.codehaus.mojo:exec-maven-plugin:1.2.1:exec" when ever I run it. Now when
> I try to do my teacher's example, I get the same problem. She doesn't seem to
> understand what the problem is, so I'm asking you all.
> This is my pom.xml file:
> {code:java}
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
> com.nackademin.systemintegration
> WebApplicationClientDemo2
> 1.0-SNAPSHOT
> jar
>
> UTF-8
> 1.8
> 1.8
>
>
>
> com.sun.jersey
> jersey-client
> 1.19.4
>
>
> javax
> javaee-web-api
> 7.0
> jar
>
>
> com.sun.jersey
> jersey-json
> 1.17.1
>
>
> com.google.code.gson
> gson
> 2.8.2
>
>
>
> {code}
> This is the Web Application code I made:
> {code:java}
> BookDao bookdao = new BookDao();
> @GET
> @Path("/books")
> @Produces(MediaType.APPLICATION_XML)
> public List getBooks() {
> return bookdao.getAllBooks();
> }
> {code}
> And this is my maven client:
> {code:java}
> String xmlString = service.path("rest")
> .path("BookService/books").accept(MediaType.APPLICATION_XML).get(String.class);
> System.out.println(xmlString);
> System.out.println();
> Book[] bookArray = service.path("rest")
> .path("BookService/books").accept(MediaType.APPLICATION_XML).get(Book[].class);
> for (Book b : bookArray) {
> System.out.println("Book id: " + b.getId() + " title: " + b.getTitle() + "
> author: " + b.getAuthor());
> }
> {code}
> Do anyone know what the crap is the problem? Also, before anyone ask, yes,
> I've been on stackowerflow and search through google. I can't find anything
> that works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MNG-6519) Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec
Patrik Ek created MNG-6519:
--
Summary: Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:exec
Key: MNG-6519
URL: https://issues.apache.org/jira/browse/MNG-6519
Project: Maven
Issue Type: Task
Components: Plugin API, POM
Reporter: Patrik Ek
Hey.
So, I'm trying to make a Web Application and a maven client that uses it.
However, I get the "Failed to execute goal
org.codehaus.mojo:exec-maven-plugin:1.2.1:exec" when ever I run it. Now when I
try to do my teacher's example, I get the same problem. She doesn't seem to
understand what the problem is, so I'm asking you all.
This is my pom.xml file:
{code:java}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
com.nackademin.systemintegration
WebApplicationClientDemo2
1.0-SNAPSHOT
jar
UTF-8
1.8
1.8
com.sun.jersey
jersey-client
1.19.4
javax
javaee-web-api
7.0
jar
com.sun.jersey
jersey-json
1.17.1
com.google.code.gson
gson
2.8.2
{code}
This is the Web Application code I made:
{code:java}
BookDao bookdao = new BookDao();
@GET
@Path("/books")
@Produces(MediaType.APPLICATION_XML)
public List getBooks() {
return bookdao.getAllBooks();
}
{code}
And this is my maven client:
{code:java}
String xmlString = service.path("rest")
.path("BookService/books").accept(MediaType.APPLICATION_XML).get(String.class);
System.out.println(xmlString);
System.out.println();
Book[] bookArray = service.path("rest")
.path("BookService/books").accept(MediaType.APPLICATION_XML).get(Book[].class);
for (Book b : bookArray) {
System.out.println("Book id: " + b.getId() + " title: " + b.getTitle() + "
author: " + b.getAuthor());
}
{code}
Do anyone know what the crap is the problem? Also, before anyone ask, yes, I've
been on stackowerflow and search through google. I can't find anything that
works.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MNG-6518) Question about settings-security configuration
[ https://issues.apache.org/jira/browse/MNG-6518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MNG-6518. Resolution: Not A Problem JIRA is not a forum. Use for such things the user mailing list: https://maven.apache.org/guides/mini/guide-encryption.html https://maven.apache.org/settings.html > Question about settings-security configuration > -- > > Key: MNG-6518 > URL: https://issues.apache.org/jira/browse/MNG-6518 > Project: Maven > Issue Type: Bug > Components: Settings >Affects Versions: 3.5.4 >Reporter: chortels >Priority: Major > > Hi, > Is there any way in Maven to specify the location of the > settings-security.xml file in settings.xml file, or the only way to do this > is through -Dsettings.security parameter in CLI? > Thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MNG-6518) Question about settings-security configuration
chortels created MNG-6518: - Summary: Question about settings-security configuration Key: MNG-6518 URL: https://issues.apache.org/jira/browse/MNG-6518 Project: Maven Issue Type: Bug Components: Settings Affects Versions: 3.5.4 Reporter: chortels Hi, Is there any way in Maven to specify the location of the settings-security.xml file in settings.xml file, or the only way to do this is through -Dsettings.security parameter in CLI? Thanks. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (SUREFIRE-1568) Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
[
https://issues.apache.org/jira/browse/SUREFIRE-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690857#comment-16690857
]
Tibor Digana edited comment on SUREFIRE-1568 at 11/18/18 10:44 AM:
---
This is Java 9 related. I will remove the label Junit5.
Since we have solved similar issue {{SUREFIRE-1593}} in
{{JarManifestForkConfiguration}} we should complete these fork configuration
issues in one common version {{3.0.0-M2}}.
Escaping the paths as [~rfscholte] proposed seems to be simple. I will check it
out with given test project.
was (Author: tibor17):
This is Java 9 related. I will remove the label Junit5.
Since we have solved similar issue {{SUREFIRE-1593}} in
{{JarManifestForkConfiguration}} .
We should complete these fork configuration issues in one common version
{{3.0.0-M2}}.
Escaping the paths as [~rfscholte] proposed seems to be simple. I will check it
out with given test project.
> Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
> ---
>
> Key: SUREFIRE-1568
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1568
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin, process forking
>Affects Versions: 2.21.0
> Environment: Ubuntu
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Attachments: 2018-09-15T18-54-48_266.dumpstream, debug1.txt,
> debug2.txt, mavenproject19.zip, mavenproject19_target_and_debug.zip
>
>
> I have a simple JPMS module. When I use the maven-surefire-plugin 2.20.1
> everything is ok - my tests are executed:
> {code:java}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.20.1
>
>
> org.junit.platform
>
> junit-platform-surefire-provider
> 1.3.0
>
>
> {code}
> However, when I want to use newer versions of surefire (2.21.0 or 2.22.0) I
> get the following:
> {code:java}
> Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> The forked VM terminated without properly saying goodbye. VM crash or
> System.exit called?
> Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java
> '@/home/project/target/surefire/surefireargs4438382394951202560'
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
> Error occurred in starting fork, check output in log
> Process Exit Code: 1
> org.apache.maven.surefire.booter.SurefireBooterForkException: The forked
> VM terminated without properly saying goodbye. VM crash or System.exit called?
> Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java
> '@/home/project/target/surefire/surefireargs4438382394951202560'
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
> Error occurred in starting fork, check output in log
> Process Exit Code: 1
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:671)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:533)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:278)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:244)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1194)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1022)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:868)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
>
[jira] [Updated] (SUREFIRE-1568) Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
[
https://issues.apache.org/jira/browse/SUREFIRE-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1568:
---
Labels: (was: junit5)
> Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
> ---
>
> Key: SUREFIRE-1568
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1568
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin, process forking
>Affects Versions: 2.21.0
> Environment: Ubuntu
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Attachments: 2018-09-15T18-54-48_266.dumpstream, debug1.txt,
> debug2.txt, mavenproject19.zip, mavenproject19_target_and_debug.zip
>
>
> I have a simple JPMS module. When I use the maven-surefire-plugin 2.20.1
> everything is ok - my tests are executed:
> {code:java}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.20.1
>
>
> org.junit.platform
>
> junit-platform-surefire-provider
> 1.3.0
>
>
> {code}
> However, when I want to use newer versions of surefire (2.21.0 or 2.22.0) I
> get the following:
> {code:java}
> Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> The forked VM terminated without properly saying goodbye. VM crash or
> System.exit called?
> Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java
> '@/home/project/target/surefire/surefireargs4438382394951202560'
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
> Error occurred in starting fork, check output in log
> Process Exit Code: 1
> org.apache.maven.surefire.booter.SurefireBooterForkException: The forked
> VM terminated without properly saying goodbye. VM crash or System.exit called?
> Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java
> '@/home/project/target/surefire/surefireargs4438382394951202560'
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
> Error occurred in starting fork, check output in log
> Process Exit Code: 1
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:671)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:533)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:278)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:244)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1194)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1022)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:868)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
>
[jira] [Updated] (SUREFIRE-1568) Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
[
https://issues.apache.org/jira/browse/SUREFIRE-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1568:
---
Component/s: process forking
> Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
> ---
>
> Key: SUREFIRE-1568
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1568
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin, process forking
>Affects Versions: 2.21.0
> Environment: Ubuntu
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Attachments: 2018-09-15T18-54-48_266.dumpstream, debug1.txt,
> debug2.txt, mavenproject19.zip, mavenproject19_target_and_debug.zip
>
>
> I have a simple JPMS module. When I use the maven-surefire-plugin 2.20.1
> everything is ok - my tests are executed:
> {code:java}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.20.1
>
>
> org.junit.platform
>
> junit-platform-surefire-provider
> 1.3.0
>
>
> {code}
> However, when I want to use newer versions of surefire (2.21.0 or 2.22.0) I
> get the following:
> {code:java}
> Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> The forked VM terminated without properly saying goodbye. VM crash or
> System.exit called?
> Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java
> '@/home/project/target/surefire/surefireargs4438382394951202560'
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
> Error occurred in starting fork, check output in log
> Process Exit Code: 1
> org.apache.maven.surefire.booter.SurefireBooterForkException: The forked
> VM terminated without properly saying goodbye. VM crash or System.exit called?
> Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java
> '@/home/project/target/surefire/surefireargs4438382394951202560'
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
> Error occurred in starting fork, check output in log
> Process Exit Code: 1
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:671)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:533)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:278)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:244)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1194)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1022)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:868)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
>
[jira] [Commented] (SUREFIRE-1568) Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
[
https://issues.apache.org/jira/browse/SUREFIRE-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16690857#comment-16690857
]
Tibor Digana commented on SUREFIRE-1568:
This is Java 9 related. I will remove the label Junit5.
Since we have solved similar issue {{SUREFIRE-1593}} in
{{JarManifestForkConfiguration}} .
We should complete these fork configuration issues in one common version
{{3.0.0-M2}}.
Escaping the paths as [~rfscholte] proposed seems to be simple. I will check it
out with given test project.
> Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
> ---
>
> Key: SUREFIRE-1568
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1568
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.21.0
> Environment: Ubuntu
>Reporter: Pavel_K
>Priority: Major
> Labels: junit5
> Attachments: 2018-09-15T18-54-48_266.dumpstream, debug1.txt,
> debug2.txt, mavenproject19.zip, mavenproject19_target_and_debug.zip
>
>
> I have a simple JPMS module. When I use the maven-surefire-plugin 2.20.1
> everything is ok - my tests are executed:
> {code:java}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.20.1
>
>
> org.junit.platform
>
> junit-platform-surefire-provider
> 1.3.0
>
>
> {code}
> However, when I want to use newer versions of surefire (2.21.0 or 2.22.0) I
> get the following:
> {code:java}
> Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> The forked VM terminated without properly saying goodbye. VM crash or
> System.exit called?
> Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java
> '@/home/project/target/surefire/surefireargs4438382394951202560'
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
> Error occurred in starting fork, check output in log
> Process Exit Code: 1
> org.apache.maven.surefire.booter.SurefireBooterForkException: The forked
> VM terminated without properly saying goodbye. VM crash or System.exit called?
> Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java
> '@/home/project/target/surefire/surefireargs4438382394951202560'
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
> Error occurred in starting fork, check output in log
> Process Exit Code: 1
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:671)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:533)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:278)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:244)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1194)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1022)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:868)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at
[jira] [Assigned] (SUREFIRE-1568) Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
[
https://issues.apache.org/jira/browse/SUREFIRE-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reassigned SUREFIRE-1568:
--
Assignee: Tibor Digana
> Versions 2.21 and higher doesn't work with junit-platform for Java 9 module
> ---
>
> Key: SUREFIRE-1568
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1568
> Project: Maven Surefire
> Issue Type: Bug
> Components: JUnit 5.x support, Maven Surefire Plugin
>Affects Versions: 2.21.0
> Environment: Ubuntu
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Labels: junit5
> Attachments: 2018-09-15T18-54-48_266.dumpstream, debug1.txt,
> debug2.txt, mavenproject19.zip, mavenproject19_target_and_debug.zip
>
>
> I have a simple JPMS module. When I use the maven-surefire-plugin 2.20.1
> everything is ok - my tests are executed:
> {code:java}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 2.20.1
>
>
> org.junit.platform
>
> junit-platform-surefire-provider
> 1.3.0
>
>
> {code}
> However, when I want to use newer versions of surefire (2.21.0 or 2.22.0) I
> get the following:
> {code:java}
> Please refer to dump files (if any exist) [date]-jvmRun[N].dump,
> [date].dumpstream and [date]-jvmRun[N].dumpstream.
> The forked VM terminated without properly saying goodbye. VM crash or
> System.exit called?
> Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java
> '@/home/project/target/surefire/surefireargs4438382394951202560'
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
> Error occurred in starting fork, check output in log
> Process Exit Code: 1
> org.apache.maven.surefire.booter.SurefireBooterForkException: The forked
> VM terminated without properly saying goodbye. VM crash or System.exit called?
> Command was /bin/sh -c cd "/home/project" && /opt/jdk-9/bin/java
> '@/home/project/target/surefire/surefireargs4438382394951202560'
> '/home/project/target/surefire' 2018-09-13T13-42-05_435-jvmRun1
> surefire4870497011802680670tmp surefire_015850140770716473411tmp
> Error occurred in starting fork, check output in log
> Process Exit Code: 1
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:671)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:533)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:278)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:244)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeProvider(AbstractSurefireMojo.java:1194)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.executeAfterPreconditionsChecked(AbstractSurefireMojo.java:1022)
> at
> org.apache.maven.plugin.surefire.AbstractSurefireMojo.execute(AbstractSurefireMojo.java:868)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
>
[jira] [Updated] (SUREFIRE-1585) Auto-resolve "missing" JUnit 5 artifacts
[ https://issues.apache.org/jira/browse/SUREFIRE-1585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein updated SUREFIRE-1585: -- Fix Version/s: 3.0.0-M2 > Auto-resolve "missing" JUnit 5 artifacts > > > Key: SUREFIRE-1585 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1585 > Project: Maven Surefire > Issue Type: Improvement > Components: JUnit 5.x support >Affects Versions: 2.22.1 >Reporter: Christian Stein >Assignee: Christian Stein >Priority: Minor > Labels: features > Fix For: 3.0.0-M2 > > > Providers should be able to enhance the test runtime by injecting "missing" > artifacts before executing tests. > > For example, the JUnit Platform Provider should add "missing" Test Engine > artifacts for when users only depend on the API of a test framework. > * User test depends on *`junit-jupiter-api`* only? Provide > *`junit-jupiter-engine`* at test runtime -- automatically or via plugin deps. > * User test depends on *`junit-jupiter-params`* only? That pulls in > *`junit-jupiter-api`* transitively. Provide *`junit-jupiter-engine`* at test > runtime -- automatically or via plugin deps. > * User test depends on *`junit:junit:4.12`* only *AND* the JUnit Platform > Provider is forced? Provide *`junit-vintage-engine`* at test runtime -- > automatically or via plugin deps. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SUREFIRE-1546) JUnit 5 runner does not honor JUnit 5 display names
[ https://issues.apache.org/jira/browse/SUREFIRE-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christian Stein updated SUREFIRE-1546: -- Fix Version/s: (was: 3.0.0-M2) > JUnit 5 runner does not honor JUnit 5 display names > --- > > Key: SUREFIRE-1546 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1546 > Project: Maven Surefire > Issue Type: Bug > Components: JUnit 5.x support >Affects Versions: 2.22.0 >Reporter: Romain Manni-Bucau >Assignee: Christian Stein >Priority: Major > Labels: junit5 > > JUnit 5 runner should respect the test @DisplayName instead of displaying the > classname if any is defined. Seems last release doesn't support that feature > of JUnit 5 making the console output and reports not the expected ones. > > Origin: https://github.com/junit-team/junit5/issues/990 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SUREFIRE-1600) Surefire Project using surefire:2.12.4 is not fully able to work with JDK 10+ on internal build system. Therefore surefire-shadefire should go with Surefire:3.0.0-M1.
[ https://issues.apache.org/jira/browse/SUREFIRE-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1600: --- Summary: Surefire Project using surefire:2.12.4 is not fully able to work with JDK 10+ on internal build system. Therefore surefire-shadefire should go with Surefire:3.0.0-M1. (was: Surefire Project using surefire:2.12.4 is not able to fully work with JDK 10+ on internal build system. Therefore surefire-shadefire should go with Surefire:3.0.0-M1.) > Surefire Project using surefire:2.12.4 is not fully able to work with JDK 10+ > on internal build system. Therefore surefire-shadefire should go with > Surefire:3.0.0-M1. > -- > > Key: SUREFIRE-1600 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1600 > Project: Maven Surefire > Issue Type: Task >Affects Versions: 3.0.0-M1 >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (SUREFIRE-1600) Surefire Project using surefire:2.12.4 is not able to fully work with JDK 10+ on internal build system. Therefore surefire-shadefire should go with Surefire:3.0.0-M1.
Tibor Digana created SUREFIRE-1600: -- Summary: Surefire Project using surefire:2.12.4 is not able to fully work with JDK 10+ on internal build system. Therefore surefire-shadefire should go with Surefire:3.0.0-M1. Key: SUREFIRE-1600 URL: https://issues.apache.org/jira/browse/SUREFIRE-1600 Project: Maven Surefire Issue Type: Task Affects Versions: 3.0.0-M1 Reporter: Tibor Digana Assignee: Tibor Digana Fix For: 3.0.0-M2 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SUREFIRE-1592) Forked JVM should load classes in Isolated ClassLoader if useSystemClassLoader=false
[
https://issues.apache.org/jira/browse/SUREFIRE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1592:
---
Fix Version/s: (was: 3.0.0-M2)
3.0
> Forked JVM should load classes in Isolated ClassLoader if
> useSystemClassLoader=false
>
>
> Key: SUREFIRE-1592
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1592
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Failsafe Plugin, Maven Surefire Plugin, process
> forking
>Reporter: Tibor Digana
>Priority: Major
> Fix For: 3.0
>
>
> The Surefire project runs itself tests within
> {{maven-surefire-plugin:2.12.4}} which properly isolates project classes and
> plugin's classes. The current versions 2.x do not have this ability. The
> version {{3.0.0}} should load user's classes in {{IsolatedClassLoader}}
> (configured by {{useSystemClassLoader=false}}).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (SUREFIRE-1592) Forked JVM should load classes in Isolated ClassLoader if useSystemClassLoader=false
[
https://issues.apache.org/jira/browse/SUREFIRE-1592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1592:
---
Description: The Surefire project runs itself tests within
{{maven-surefire-plugin:2.12.4}} which properly isolates project classes and
plugin's classes. The current versions 2.x do not have this ability. The
version {{3.0.0}} should load user's classes in {{IsolatedClassLoader}}
(configured by {{useSystemClassLoader=false}}). (was: The Surefire project
runs itself tests within {{maven-surefire-plugin:2.12.4}} which properly
isolates project classes and plugin's classes. The current versions 2.x do not
have this ability. The version {{3.0.0-M2}} should load user's classes in
{{IsolatedClassLoader}} (configured by {{useSystemClassLoader=false}}).)
> Forked JVM should load classes in Isolated ClassLoader if
> useSystemClassLoader=false
>
>
> Key: SUREFIRE-1592
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1592
> Project: Maven Surefire
> Issue Type: Improvement
> Components: Maven Failsafe Plugin, Maven Surefire Plugin, process
> forking
>Reporter: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M2
>
>
> The Surefire project runs itself tests within
> {{maven-surefire-plugin:2.12.4}} which properly isolates project classes and
> plugin's classes. The current versions 2.x do not have this ability. The
> version {{3.0.0}} should load user's classes in {{IsolatedClassLoader}}
> (configured by {{useSystemClassLoader=false}}).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
