[GitHub] eolivelli commented on a change in pull request #229: [MNG-5693] Change logging of MojoExceptions to console
eolivelli commented on a change in pull request #229: [MNG-5693] Change logging of MojoExceptions to console URL: https://github.com/apache/maven/pull/229#discussion_r245497616 ## File path: maven-core/src/main/java/org/apache/maven/exception/DefaultExceptionHandler.java ## @@ -124,7 +115,7 @@ private ExceptionSummary handle( String message, Throwable exception ) message = getMessage( message, exception ); } -return new ExceptionSummary( exception, message, reference, children ); +return new ExceptionSummary( exception, message, null, children ); Review comment: Got it Why not dropping the field? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (WAGON-537) Maven transfer speed of large artifacts is slow due to unsuitable buffer strategy
[ https://issues.apache.org/jira/browse/WAGON-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735044#comment-16735044 ] Michael Osipov commented on WAGON-537: -- [~o.otto], the regression is actually not in your code, but a bug in JSch. My tests are on a Windows 10, Intel Skylake against an old 4 thread atom machine running FreeBSD 11.2-RELEASE. I can retry at work with my Windows 7 box against a Xeon based older FreeBSD server. In both cases, server and client are physically very close. > Maven transfer speed of large artifacts is slow due to unsuitable buffer > strategy > - > > Key: WAGON-537 > URL: https://issues.apache.org/jira/browse/WAGON-537 > Project: Maven Wagon > Issue Type: Improvement > Components: wagon-http, wagon-provider-api >Affects Versions: 3.2.0 > Environment: Windows 10, JDK 1.8, Nexus Artifact store > 100MB/s > network connection. >Reporter: Olaf Otto >Assignee: Michael Osipov >Priority: Major > Labels: perfomance > Fix For: 3.3.0, 3.3.1 > > Attachments: wagon-issue.png > > > We are using maven for build process automation with docker. This sometimes > involves uploading and downloading artifacts with a few gigabytes in size. > Here, maven's transfer speed is consistently and reproducibly slow. For > instance, an artifact with 7,5 GB in size took almost two hours to transfer > in spite of a 100 MB/s connection with respective reproducible download speed > from the remote nexus artifact repository when using a browser to download. > The same is true when uploding such an artifact. > I have investigated the issue using JProfiler. The result shows an issue in > AbstractWagon's transfer( Resource resource, InputStream input, OutputStream > output, int requestType, long maxSize ) method used for remote artifacts and > the same issue in AbstractHttpClientWagon#writeTo(OutputStream). > Here, the input stream is read in a loop using a 4 Kb buffer. Whenever data > is received, the received data is pushed to downstream listeners via > fireTransferProgress. These listeners (or rather consumers) perform expensive > tasks. > Now, the underlying InputStream implementation used in transfer will return > calls to read(buffer, offset, length) as soon as *some* data is available. > That is, fireTransferProgress may well be invoked with an average number of > bytes less than half the buffer capacity (this varies with the underlying > network and hardware architecture). Consequently, fireTransferProgress is > invoked *millions of times* for large files. As this is a blocking operation, > the time spent in fireTransferProgress dominates and drastically slows down > the transfers by at least one order of magnitude. > !wagon-issue.png! > In our case, we found download speed reduced from a theoretical optimum of > ~80 seconds to to more than 3200 seconds. > From an architectural perspective, I would not want to make the consumers / > listeners invoked via fireTransferProgress aware of their potential impact on > download speed, but rather refactor the transfer method such that it uses a > buffer strategy reducing the the number of fireTransferProgress invocations. > This should be done with regard to the expected file size of the transfer, > such that fireTransferProgress is invoked often enough but not to frequent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WAGON-537) Maven transfer speed of large artifacts is slow due to unsuitable buffer strategy
[ https://issues.apache.org/jira/browse/WAGON-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735027#comment-16735027 ] Olaf Otto commented on WAGON-537: - Hi [~dantran], thanks a lot for trying this out. So in summary, your tests show no difference between curl, the current maven release version and the version including this change, correct? If so, you are in a situation where the current implementation already provides the optimal result - this means the buffer in the copy loop is used efficiently and, most importantly, exeuction of fireTransferProgress is *very* fast. So at least we know that the change does not reduce the transfer speed in this situation. What OS are you on? [~michael-o], same question to you. I've tested Windows 10 so far. I'd assume the costs of e.g. console output might vary greatly. Regrads, Olaf > Maven transfer speed of large artifacts is slow due to unsuitable buffer > strategy > - > > Key: WAGON-537 > URL: https://issues.apache.org/jira/browse/WAGON-537 > Project: Maven Wagon > Issue Type: Improvement > Components: wagon-http, wagon-provider-api >Affects Versions: 3.2.0 > Environment: Windows 10, JDK 1.8, Nexus Artifact store > 100MB/s > network connection. >Reporter: Olaf Otto >Assignee: Michael Osipov >Priority: Major > Labels: perfomance > Fix For: 3.3.0, 3.3.1 > > Attachments: wagon-issue.png > > > We are using maven for build process automation with docker. This sometimes > involves uploading and downloading artifacts with a few gigabytes in size. > Here, maven's transfer speed is consistently and reproducibly slow. For > instance, an artifact with 7,5 GB in size took almost two hours to transfer > in spite of a 100 MB/s connection with respective reproducible download speed > from the remote nexus artifact repository when using a browser to download. > The same is true when uploding such an artifact. > I have investigated the issue using JProfiler. The result shows an issue in > AbstractWagon's transfer( Resource resource, InputStream input, OutputStream > output, int requestType, long maxSize ) method used for remote artifacts and > the same issue in AbstractHttpClientWagon#writeTo(OutputStream). > Here, the input stream is read in a loop using a 4 Kb buffer. Whenever data > is received, the received data is pushed to downstream listeners via > fireTransferProgress. These listeners (or rather consumers) perform expensive > tasks. > Now, the underlying InputStream implementation used in transfer will return > calls to read(buffer, offset, length) as soon as *some* data is available. > That is, fireTransferProgress may well be invoked with an average number of > bytes less than half the buffer capacity (this varies with the underlying > network and hardware architecture). Consequently, fireTransferProgress is > invoked *millions of times* for large files. As this is a blocking operation, > the time spent in fireTransferProgress dominates and drastically slows down > the transfers by at least one order of magnitude. > !wagon-issue.png! > In our case, we found download speed reduced from a theoretical optimum of > ~80 seconds to to more than 3200 seconds. > From an architectural perspective, I would not want to make the consumers / > listeners invoked via fireTransferProgress aware of their potential impact on > download speed, but rather refactor the transfer method such that it uses a > buffer strategy reducing the the number of fireTransferProgress invocations. > This should be done with regard to the expected file size of the transfer, > such that fireTransferProgress is invoked often enough but not to frequent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (WAGON-537) Maven transfer speed of large artifacts is slow due to unsuitable buffer strategy
[ https://issues.apache.org/jira/browse/WAGON-537?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735030#comment-16735030 ] Olaf Otto commented on WAGON-537: - Hi [~michael-o], regarding your pointer to the mailing list ([http://mail-archives.apache.org/mod_mbox/maven-dev/201812.mbox/%3CCAPCjjnGSpwPA3%2BaTgy2MHfY7wMLK6_v1ZHBi0RWP-XnjJd5r2w%40mail.gmail.com%3E]), I take it the regression (WAGON-543) is resolved? [~dantran] do you still recommend trying to isolate this change to the http implementation? > Maven transfer speed of large artifacts is slow due to unsuitable buffer > strategy > - > > Key: WAGON-537 > URL: https://issues.apache.org/jira/browse/WAGON-537 > Project: Maven Wagon > Issue Type: Improvement > Components: wagon-http, wagon-provider-api >Affects Versions: 3.2.0 > Environment: Windows 10, JDK 1.8, Nexus Artifact store > 100MB/s > network connection. >Reporter: Olaf Otto >Assignee: Michael Osipov >Priority: Major > Labels: perfomance > Fix For: 3.3.0, 3.3.1 > > Attachments: wagon-issue.png > > > We are using maven for build process automation with docker. This sometimes > involves uploading and downloading artifacts with a few gigabytes in size. > Here, maven's transfer speed is consistently and reproducibly slow. For > instance, an artifact with 7,5 GB in size took almost two hours to transfer > in spite of a 100 MB/s connection with respective reproducible download speed > from the remote nexus artifact repository when using a browser to download. > The same is true when uploding such an artifact. > I have investigated the issue using JProfiler. The result shows an issue in > AbstractWagon's transfer( Resource resource, InputStream input, OutputStream > output, int requestType, long maxSize ) method used for remote artifacts and > the same issue in AbstractHttpClientWagon#writeTo(OutputStream). > Here, the input stream is read in a loop using a 4 Kb buffer. Whenever data > is received, the received data is pushed to downstream listeners via > fireTransferProgress. These listeners (or rather consumers) perform expensive > tasks. > Now, the underlying InputStream implementation used in transfer will return > calls to read(buffer, offset, length) as soon as *some* data is available. > That is, fireTransferProgress may well be invoked with an average number of > bytes less than half the buffer capacity (this varies with the underlying > network and hardware architecture). Consequently, fireTransferProgress is > invoked *millions of times* for large files. As this is a blocking operation, > the time spent in fireTransferProgress dominates and drastically slows down > the transfers by at least one order of magnitude. > !wagon-issue.png! > In our case, we found download speed reduced from a theoretical optimum of > ~80 seconds to to more than 3200 seconds. > From an architectural perspective, I would not want to make the consumers / > listeners invoked via fireTransferProgress aware of their potential impact on > download speed, but rather refactor the transfer method such that it uses a > buffer strategy reducing the the number of fireTransferProgress invocations. > This should be done with regard to the expected file size of the transfer, > such that fireTransferProgress is invoked often enough but not to frequent. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] slachiewicz commented on a change in pull request #229: [MNG-5693] Change logging of MojoExceptions to console
slachiewicz commented on a change in pull request #229: [MNG-5693] Change logging of MojoExceptions to console URL: https://github.com/apache/maven/pull/229#discussion_r245488335 ## File path: maven-core/src/main/java/org/apache/maven/exception/DefaultExceptionHandler.java ## @@ -124,7 +115,7 @@ private ExceptionSummary handle( String message, Throwable exception ) message = getMessage( message, exception ); } -return new ExceptionSummary( exception, message, reference, children ); +return new ExceptionSummary( exception, message, null, children ); Review comment: No, in reference we store shot exception name or links to cwiki This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MNG-6346) ... was unexpected at this time when using -f option and path contains brackets
[ https://issues.apache.org/jira/browse/MNG-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6346: -- Fix Version/s: (was: 3.6.1) 3.6.x-candidate > ... was unexpected at this time when using -f option and path contains > brackets > --- > > Key: MNG-6346 > URL: https://issues.apache.org/jira/browse/MNG-6346 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.5.0, 3.5.2 > Environment: Win10 & Win Server 2012 > jdk1.8.0_151 >Reporter: Patrik Jetzer >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.6.x-candidate > > Attachments: mmm(example).zip > > Time Spent: 10m > Remaining Estimate: 0h > > Since maven version 3.50 and later when running a simple command with -f > option the command fails reporting: > "\pom.xml was unexpected at this time." > command: > mvn -f C:\mmm(example)\pom.xml clean install > This must be related to changes in 3.5.x since it works as expected with > version 3.3.9 > Removing the brackets from the folder name resolves the issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] eolivelli commented on a change in pull request #229: [MNG-5693] Change logging of MojoExceptions to console
eolivelli commented on a change in pull request #229: [MNG-5693] Change logging of MojoExceptions to console URL: https://github.com/apache/maven/pull/229#discussion_r245488169 ## File path: maven-core/src/main/java/org/apache/maven/exception/DefaultExceptionHandler.java ## @@ -124,7 +115,7 @@ private ExceptionSummary handle( String message, Throwable exception ) message = getMessage( message, exception ); } -return new ExceptionSummary( exception, message, reference, children ); +return new ExceptionSummary( exception, message, null, children ); Review comment: Are we losing the exception at all? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MNG-6385) Windows mvn.cmd fail with incorrect command syntax.
[
https://issues.apache.org/jira/browse/MNG-6385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MNG-6385:
--
Fix Version/s: 3.6.x-candidate
> Windows mvn.cmd fail with incorrect command syntax.
> ---
>
> Key: MNG-6385
> URL: https://issues.apache.org/jira/browse/MNG-6385
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 3.5.0, 3.5.2, 3.5.3
>Reporter: Eric Barboni
>Priority: Major
> Fix For: 3.6.x-candidate
>
>
> Hi, during some test using Apache Netbeans on windows it appears that some
> cli can lead to failure of executing mvn.cmd
> It was working before on 3.3.9 version.
> In the code example (below) if space are removed from path in agentpath
> section it works.
> Otherwise the arguments are cut during evaluation
> and the following syntax incorrect will happen
> if not "-agentpath:\"E:\opensource\space" == "" (
> Best Regards
> {code}
> e:\outils\apache-maven-3.5.3\bin\mvn
> -Dexec.args="-agentpath:\"E:\opensource\space
> netbeans\netbeans\profiler\lib\deployed\jdk16\windows-amd64\profilerinterface.dll\"=\"E:\opensource\space
> netbeans\netbeans\profiler\lib\",5140,10 -XX:+HeapDumpOnOutOfMemoryError
> -XX:HeapDumpPath=C:\Users\barboni\AppData\Local\NetBeans\Cache\dev\mavencachedirs\2080072884\org-netbeans-modules-profiler
> -classpath %classpath com.mycompany.mavenproject23.newClass"
> -Dexec.executable="C:\Program Files\Java\jdk1.8.0_162\bin\java.exe"
> -Dexec.classpathScope=runtime -DskipTests=true
> -Dmaven.ext.class.path="E:\opensource\space
> netbeans\netbeans\java\maven-nblib\netbeans-eventspy.jar"
> -Dfile.encoding=UTF-8 org.codehaus.mojo:exec-maven-plugin:1.5.0:exec
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6544) Replace CacheUtils#{eq,hash} with Objects
[
https://issues.apache.org/jira/browse/MNG-6544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735010#comment-16735010
]
Hudson commented on MNG-6544:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/
> Replace CacheUtils#{eq,hash} with Objects
> -
>
> Key: MNG-6544
> URL: https://issues.apache.org/jira/browse/MNG-6544
> Project: Maven
> Issue Type: Task
> Components: core
>Affects Versions: 3.6.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.1
>
>
> {{Objects}} now sports idiot-safe {{equals}} and {{hashCode}} just like
> {{CacheUtils}}. We can swap out and deprecate/delete our code.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6481) Allow to compile and test Maven with Java 11
[ https://issues.apache.org/jira/browse/MNG-6481?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735005#comment-16735005 ] Hudson commented on MNG-6481: - Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/ > Allow to compile and test Maven with Java 11 > > > Key: MNG-6481 > URL: https://issues.apache.org/jira/browse/MNG-6481 > Project: Maven > Issue Type: Improvement >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > > Java 11 is coming closer, let's prepare to use it for the development of > Maven. > A minimal requirement to run Maven - still Java 7. > * compile and pass Maven's tests with Java 11 > * adjust ITs to run under Java 11 > Do we need compile and to pass all tests with Java 9, 10 and 11? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6213) Maven doesn't check the validity of scope value
[
https://issues.apache.org/jira/browse/MNG-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735011#comment-16735011
]
Hudson commented on MNG-6213:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/
> Maven doesn't check the validity of scope value
> ---
>
> Key: MNG-6213
> URL: https://issues.apache.org/jira/browse/MNG-6213
> Project: Maven
> Issue Type: Improvement
> Components: POM
>Affects Versions: 3.3.9
> Environment: Apache Maven 3.3.9
> (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-11T01:41:47+09:00)
> Maven home: /usr/local/Cellar/maven/3.3.9/libexec
> Java version: 1.8.0_121, vendor: Oracle Corporation
> Java home:
> /Library/Java/JavaVirtualMachines/jdk1.8.0_121.jdk/Contents/Home/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "mac os x", version: "10.12.4", arch: "x86_64", family: "mac"
>Reporter: Jin Kwon
>Assignee: Michael Osipov
>Priority: Minor
> Labels: scope
> Fix For: 3.6.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I accidentally put a wrong value into the {{scope}} tag.
> {code:xml}
>
>
>
> org.glassfish.jersey
> jersey-bom
> 2.26-b03
> pom
> include
>
>
>
> {code}
> And, of course, my dependency doesn't work.
> {code:xml}
>
>
> org.glassfish.jersey.core
> jersey-common
> test
>
>
> {code}
> {code}
> 'dependencies.dependency.version' for
> org.glassfish.jersey.core:jersey-common:jar is missing.
> {code}
> Maven should complains about the wrong value of {{include}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6513) Replace depreated Plexus javadoc tags with annotations in ITs
[ https://issues.apache.org/jira/browse/MNG-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734993#comment-16734993 ] Hudson commented on MNG-6513: - Build succeeded in Jenkins: Maven TLP » maven » MNG-6520 #5 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6520/5/ > Replace depreated Plexus javadoc tags with annotations in ITs > -- > > Key: MNG-6513 > URL: https://issues.apache.org/jira/browse/MNG-6513 > Project: Maven > Issue Type: Improvement > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.1 > > > Remove Javadoc Plexus tags @plexus.component and replace with standard Java > annotations from plexus-component-annotations in Integration Tests > Guide: > [https://maven.apache.org/plugin-developers/cookbook/plexus-plugin-upgrade.html] > As effect - remove Javadoc generation warning about Taglets -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6059) Important use cases not covered, as child.inherit.append.path affects all children
[
https://issues.apache.org/jira/browse/MNG-6059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735002#comment-16735002
]
Hudson commented on MNG-6059:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/
> Important use cases not covered, as child.inherit.append.path affects all
> children
> --
>
> Key: MNG-6059
> URL: https://issues.apache.org/jira/browse/MNG-6059
> Project: Maven
> Issue Type: Improvement
> Components: Inheritance and Interpolation
>Affects Versions: 3.6.0
> Environment: Apache Maven 3.4.0-SNAPSHOT
> (227085283b6379038ec16f4cf9ad2e8869cef694; 2016-07-06T21:29:12+02:00)
>Reporter: Andreas Sewe
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.6.1
>
>
> The {{child.inherit.append.path}} attribute introduced with MNG-5951
> unfortunately does not support the use case where the children of the element
> with the attribute should follow different inheritance rules. Take a typical
> configuration for Github, for example (taken from
> <[http://central.sonatype.org/pages/requirements.html]>):
> {noformat}
>
>
> scm:git:git://github.com/simpligility/ossrh-demo.git
>
> scm:git:ssh://github.com:simpligility/ossrh-demo.git
> http://github.com/simpligility/ossrh-demo/tree/master
>
> {noformat}
> If the {{ossrh-demo.git}} repository contains a child module called
> {{some-module}}, then that child’s {{scm/url}} should become
> {{[http://github.com/simpligility/ossrh-demo/tree/master/some-module]}} as
> per the normal inheritance rules, but both the {{scm/connection}} and
> {{scm/developerConnection}} URLs should remain unchanged.
> Unfortunately, this is not possible with {{*child*.inherit.append.path}},
> which acts on all children simultaneously.
> IMHO, this is a conceptual problem. In particular, setting
> {{child.inherit.append.path}} on the *root* element to just control a single
> child ({{project/url}}) feels wrong, as the attribute is in all likelihood
> not even located close to the {{}} element it controls.
> h1. Implemented Solution
> {code:xml}
> ...
> child.scm.developerConnection.inherit.append.path="false"
>child.scm.url.inherit.append.path="false">
> ...
> ...
> ...
>
>
>
> ...
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6497) Upgrade guice to 4.2.1
[ https://issues.apache.org/jira/browse/MNG-6497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735001#comment-16735001 ] Hudson commented on MNG-6497: - Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/ > Upgrade guice to 4.2.1 > -- > > Key: MNG-6497 > URL: https://issues.apache.org/jira/browse/MNG-6497 > Project: Maven > Issue Type: Dependency upgrade >Affects Versions: 3.6.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.6.0 > > > Upgrade would be a good idea based on > https://app.snyk.io/vuln/SNYK-JAVA-COMGOOGLEGUAVA-32236 > Based on the upgrade of guice to 4.2.1 we get an upgrade of Guava to version > 25.1 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-5965) Parallel build multiplies work if multiple goals are given
[ https://issues.apache.org/jira/browse/MNG-5965?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735009#comment-16735009 ] Hudson commented on MNG-5965: - Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/ > Parallel build multiplies work if multiple goals are given > -- > > Key: MNG-5965 > URL: https://issues.apache.org/jira/browse/MNG-5965 > Project: Maven > Issue Type: Bug > Components: Bootstrap & Build >Affects Versions: 3.3.9 > Environment: Windows 7 64bit >Reporter: Matthias Schmalz >Assignee: Michael Osipov >Priority: Major > Fix For: 3.6.1 > > Attachments: parallel.test.zip > > Time Spent: 20m > Remaining Estimate: 0h > > When I run a parallel build which invokes multiple goals Maven multiplies the > work e.g. when I run > install sonar:sonar > Every phase is executed once as expected. However when I run > install sonar:sonar -T 4 > Every phase is executed twice. > The problem can be reproduced with a single simple Java project (of course > parallel builds are useless with a single module). Debugging showed that > every Mojo is really called twice per project. > Find attached a simple project and two build outputs, where you can see that > the parallel build is doing everything twice (you can ignore that Sonar fails > in the end, due to no server is up). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6261) Relative parent POM resolution failing in 3.5.0 with complex multimodule builds
[
https://issues.apache.org/jira/browse/MNG-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735007#comment-16735007
]
Hudson commented on MNG-6261:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/
> Relative parent POM resolution failing in 3.5.0 with complex multimodule
> builds
> ---
>
> Key: MNG-6261
> URL: https://issues.apache.org/jira/browse/MNG-6261
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.5.0
>Reporter: Dawid Weiss
>Assignee: Robert Scholte
>Priority: Minor
> Labels: up-for-grabs
> Fix For: 3.6.1
>
> Attachments: capture-6.png, repro.zip
>
>
> In my effort to upgrade an existing (fairly complex) Maven build to Java
> 1.9.0 I updated Maven to 3.5.0 (from 3.3.9). Unfortunately I get errors when
> the project's modules are resolved:
> {noformat}
> > mvn validate
> [FATAL] Non-resolvable parent POM for
> com.carrotsearch.lingo4g:lingo4g-public-bom:[unknown-version]: Could not find
> artifact com.carrotsearch.lingo4g:lingo4g-public:pom:1.6.0-SNAPSHOT and
> 'parent.relativePath' points at wrong local POM @ line 5, column 11
> ...
> (and many follow).
> {noformat}
> This build has a correct pom parent-structure (a tree), but is fairly complex
> -- the submodule hierarchy is not aligned with parent-child pom hierarchy
> (it's best to look at the repro code to understand how it's structured).
> However, it's been working correctly with all prior Maven versions and I
> wonder if it's a regression bug or maybe underspecified Maven requirement
> (that should be enforced with a warning and not lead to this odd runtime
> message).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6513) Replace depreated Plexus javadoc tags with annotations in ITs
[ https://issues.apache.org/jira/browse/MNG-6513?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735013#comment-16735013 ] Hudson commented on MNG-6513: - Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/ > Replace depreated Plexus javadoc tags with annotations in ITs > -- > > Key: MNG-6513 > URL: https://issues.apache.org/jira/browse/MNG-6513 > Project: Maven > Issue Type: Improvement > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Trivial > Fix For: 3.6.1 > > > Remove Javadoc Plexus tags @plexus.component and replace with standard Java > annotations from plexus-component-annotations in Integration Tests > Guide: > [https://maven.apache.org/plugin-developers/cookbook/plexus-plugin-upgrade.html] > As effect - remove Javadoc generation warning about Taglets -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6529) ProjectBuilder.build(List projects, boolean, ProjectBuildingRequest) doesn't honor ProjectBuildingRequest.isResolveDependencies()
[
https://issues.apache.org/jira/browse/MNG-6529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735008#comment-16735008
]
Hudson commented on MNG-6529:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/
> ProjectBuilder.build(List projects, boolean, ProjectBuildingRequest)
> doesn't honor ProjectBuildingRequest.isResolveDependencies()
> ---
>
> Key: MNG-6529
> URL: https://issues.apache.org/jira/browse/MNG-6529
> Project: Maven
> Issue Type: Bug
> Components: core
>Affects Versions: 3.5.3
>Reporter: Mickael Istria
>Assignee: Robert Scholte
>Priority: Critical
> Fix For: 3.6.1
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> I'm willing to update Eclipse m2e to take advantage of the
> {{ProjectBuilder.build(List project, boolean, ProjectBuildingRequest)}}
> to avoid duplication of MavenProject in the IDE caused by
> {{ProjectBuilder.build(File singleFile, ProjectBuildingRequest)}}.
> It's already measured to have drastically good impact on the IDE, as
> explained in [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c20] and
> [https://bugs.eclipse.org/bugs/show_bug.cgi?id=515668#c38].
> However, using this cause regressions because the multi-projects entry-point
> method seems to totally ignore the
> {{ProjectBuildRequest.isResolveDependencies()}} flag and never returns a
> valid list of {{MavenProject.getArtifacts()}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6490) Maven shall not fail reporting circular dependency when the dependency is a classified secondary artifact
[
https://issues.apache.org/jira/browse/MNG-6490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734999#comment-16734999
]
Hudson commented on MNG-6490:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/
> Maven shall not fail reporting circular dependency when the dependency is a
> classified secondary artifact
> -
>
> Key: MNG-6490
> URL: https://issues.apache.org/jira/browse/MNG-6490
> Project: Maven
> Issue Type: Bug
> Components: Dependencies
>Affects Versions: 3.5.2, 3.5.3, 3.5.4
> Environment: Ubuntu 16.0.4 LTS, Ubuntu 18.0.4 LTS, Mac OS High
> Sierra, Oracle and OpenJDK 8, Oracle Java 11,
>Reporter: John Canny
>Assignee: Sylwester Lachiewicz
>Priority: Blocker
> Fix For: 3.6.0
>
>
> As of maven 3.5.2, 3.5.3, 3.5.4, the following pom fails with the error
> "dependencies.dependency. Main:MainJar:1' for Main:MainJar:1 is referencing
> itself"
> But the dependency is not circular, it references a classified jar (in our
> use cases its an architecture-dependent native code container jar). The pom
> below allows the main jar to be built without building the dependency every
> time (other lines conditionally build the dependency), and ensures the
> appropriate pre-built dependency is loaded. Behavior in maven 3.5.0 and
> earlier was correct (i.e. no error). This breaks several of the usage
> scenarios for classified artifacts...
>
> {code:xml}http://maven.apache.org/POM/4.0.0";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";>
> 4.0.0
> Main
> MainJar
> jar
> 1
>
>
> ${project.groupId}
> ${project.artifactId}
> ${project.version}
> linux
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6505) child.(x.y).inherit.append.path value should be inherited
[ https://issues.apache.org/jira/browse/MNG-6505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735003#comment-16735003 ] Hudson commented on MNG-6505: - Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/ > child.(x.y).inherit.append.path value should be inherited > - > > Key: MNG-6505 > URL: https://issues.apache.org/jira/browse/MNG-6505 > Project: Maven > Issue Type: Bug > Components: Inheritance and Interpolation >Affects Versions: 3.6.0 >Reporter: Hervé Boutemy >Assignee: Hervé Boutemy >Priority: Critical > Fix For: 3.6.1 > > > in Maven 3.6.0, values of child.inherit.append.path are not inherited: they > have to be explicitely defined in every child pom of they switch to default > "true" value > these values should be inherited: once defined in a parent pom, every child > should inherit from the value (and of course be able to override) > Note: this seems to have been part of the MNG-6059 implementation that was > done for Maven dropped 3.4.0 version but was forgotten during Maven 3.6.0 > merge... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNGSITE-357) README.md: Maven user list link not working
[ https://issues.apache.org/jira/browse/MNGSITE-357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735006#comment-16735006 ] Hudson commented on MNGSITE-357: Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/ > README.md: Maven user list link not working > --- > > Key: MNGSITE-357 > URL: https://issues.apache.org/jira/browse/MNGSITE-357 > Project: Maven Project Web Site > Issue Type: Bug > Environment: github, homepage >Reporter: Matthias Fuchs >Assignee: Michael Osipov >Priority: Trivial > Labels: docs, github, homepage, mailing-list, readme > > The link from the github README doesn't work: > [https://maven.apache.org/mail-lists.html.] > You guys shoudl definitely enable github issues! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6492) Minor improvement on Array construction, converson
[ https://issues.apache.org/jira/browse/MNG-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735000#comment-16735000 ] Hudson commented on MNG-6492: - Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/ > Minor improvement on Array construction, converson > -- > > Key: MNG-6492 > URL: https://issues.apache.org/jira/browse/MNG-6492 > Project: Maven > Issue Type: Improvement >Reporter: Hoa Phan >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.0 > > > See [https://shipilev.net/blog/2016/arrays-wisdom-ancients/] for benchmark. > These more performant code style are also built-in check in IntelliJ. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6515) Fix javadoc build errors under Java 8 and 11
[ https://issues.apache.org/jira/browse/MNG-6515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735004#comment-16735004 ] Hudson commented on MNG-6515: - Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7 See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/ > Fix javadoc build errors under Java 8 and 11 > > > Key: MNG-6515 > URL: https://issues.apache.org/jira/browse/MNG-6515 > Project: Maven > Issue Type: Improvement > Components: General >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16735012#comment-16735012
]
Hudson commented on MNG-5693:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5693 #7
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5693/7/
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed.
> For new users this is very confusing. Even when we teach them to read, and
> they finally see a link, it's quite frustrating for them that they still
> don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MNG-5693) Change logging of MojoExceptions to console
[
https://issues.apache.org/jira/browse/MNG-5693?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MNG-5693:
--
Fix Version/s: (was: 3.6.x-candidate)
> Change logging of MojoExceptions to console
> ---
>
> Key: MNG-5693
> URL: https://issues.apache.org/jira/browse/MNG-5693
> Project: Maven
> Issue Type: Improvement
> Components: FDPFC, Plugin API
>Reporter: Robert Scholte
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> If a plugin fails for any reason, a general message is logged with a
> reference to a wiki page, which never contains the real reason why the plugin
> failed.
> For new users this is very confusing. Even when we teach them to read, and
> they finally see a link, it's quite frustrating for them that they still
> don't know what happened.
> {{MojoExecutionException}} and {{MojoFailureException}} should never refer to
> a wikipage anymore.
> Plugin writers should get more control over the message written to the
> console.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MNG-6522) Prepare Maven's Core Integration Test Suite to test with Java 12-ea
[ https://issues.apache.org/jira/browse/MNG-6522?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MNG-6522: -- Fix Version/s: 3.6.1 > Prepare Maven's Core Integration Test Suite to test with Java 12-ea > --- > > Key: MNG-6522 > URL: https://issues.apache.org/jira/browse/MNG-6522 > Project: Maven > Issue Type: Improvement > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] slachiewicz opened a new pull request #41: [MNG-5693] Remove check for link to cwiki
slachiewicz opened a new pull request #41: [MNG-5693] Remove check for link to cwiki URL: https://github.com/apache/maven-integration-testing/pull/41 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] slachiewicz opened a new pull request #229: [MNG-5693] Change logging of MojoExceptions to console
slachiewicz opened a new pull request #229: [MNG-5693] Change logging of MojoExceptions to console URL: https://github.com/apache/maven/pull/229 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Comment Edited] (MNG-6346) ... was unexpected at this time when using -f option and path contains brackets
[ https://issues.apache.org/jira/browse/MNG-6346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734695#comment-16734695 ] Sylwester Lachiewicz edited comment on MNG-6346 at 1/5/19 8:05 PM: --- To debug the issue set environment variable _MAVEN_BATCH_ECHO=on_ We need to add " around echo statements in mvn.cmd script was (Author: slachiewicz): To debug the issue set environment variable _MAVEN_BATCH_ECHO=on_ We need to add " around echo statements in mvn.cmd script (lines 118 and 127) PR: [https://gitbox.apache.org/repos/asf?p=maven.git;a=commitdiff;h=d2cb7e61d8106409a6d3e4af91d313c06fa97ef3;hp=9c946263facbfa851fb646b3fac62cf1d3302ded] > ... was unexpected at this time when using -f option and path contains > brackets > --- > > Key: MNG-6346 > URL: https://issues.apache.org/jira/browse/MNG-6346 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.5.0, 3.5.2 > Environment: Win10 & Win Server 2012 > jdk1.8.0_151 >Reporter: Patrik Jetzer >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.6.1 > > Attachments: mmm(example).zip > > Time Spent: 10m > Remaining Estimate: 0h > > Since maven version 3.50 and later when running a simple command with -f > option the command fails reporting: > "\pom.xml was unexpected at this time." > command: > mvn -f C:\mmm(example)\pom.xml clean install > This must be related to changes in 3.5.x since it works as expected with > version 3.3.9 > Removing the brackets from the folder name resolves the issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] slachiewicz opened a new pull request #228: [MNG-6346] Add " around echo in mvn.cmd
slachiewicz opened a new pull request #228: [MNG-6346] Add " around echo in mvn.cmd URL: https://github.com/apache/maven/pull/228 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MNG-6495) ModelResolver cannot be null
[
https://issues.apache.org/jira/browse/MNG-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MNG-6495:
--
Fix Version/s: (was: 3.6.1)
3.6.x-candidate
> ModelResolver cannot be null
>
>
> Key: MNG-6495
> URL: https://issues.apache.org/jira/browse/MNG-6495
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 3.5.4
>Reporter: Elliotte Rusty Harold
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.x-candidate
>
>
> Got this exception stacktrace while writing some of my own code today:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException:
> request.modelResolver cannot be null (parent POM
> com.google.guava:guava-parent:26.0-jre and POM
> com.google.guava:guava:[unknown-version])
> at org.apache.commons.lang3.Validate.notNull(Validate.java:225)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readParentExternally(DefaultModelBuilder.java:1046)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readParent(DefaultModelBuilder.java:830)
> at
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:332)
> at
> com.google.cloud.tools.opensource.dependencies.MetadataExplorer.main(MetadataExplorer.java:50)
> {noformat}
> No big deal except that the JavaDoc at
> [ModelBuildingRequest|http://maven.apache.org/ref/3.5.4/maven-model-builder/apidocs/org/apache/maven/model/building/ModelBuildingRequest.html]
> says "The model resolver to use, may be null."
> Not sure whether to update the docs or the code here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MNG-6495) ModelResolver cannot be null
[
https://issues.apache.org/jira/browse/MNG-6495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz reassigned MNG-6495:
-
Assignee: (was: Sylwester Lachiewicz)
> ModelResolver cannot be null
>
>
> Key: MNG-6495
> URL: https://issues.apache.org/jira/browse/MNG-6495
> Project: Maven
> Issue Type: Bug
> Components: Bootstrap & Build
>Affects Versions: 3.5.4
>Reporter: Elliotte Rusty Harold
>Priority: Major
> Fix For: 3.6.x-candidate
>
>
> Got this exception stacktrace while writing some of my own code today:
> {noformat}
> Exception in thread "main" java.lang.NullPointerException:
> request.modelResolver cannot be null (parent POM
> com.google.guava:guava-parent:26.0-jre and POM
> com.google.guava:guava:[unknown-version])
> at org.apache.commons.lang3.Validate.notNull(Validate.java:225)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readParentExternally(DefaultModelBuilder.java:1046)
> at
> org.apache.maven.model.building.DefaultModelBuilder.readParent(DefaultModelBuilder.java:830)
> at
> org.apache.maven.model.building.DefaultModelBuilder.build(DefaultModelBuilder.java:332)
> at
> com.google.cloud.tools.opensource.dependencies.MetadataExplorer.main(MetadataExplorer.java:50)
> {noformat}
> No big deal except that the JavaDoc at
> [ModelBuildingRequest|http://maven.apache.org/ref/3.5.4/maven-model-builder/apidocs/org/apache/maven/model/building/ModelBuildingRequest.html]
> says "The model resolver to use, may be null."
> Not sure whether to update the docs or the code here.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] slachiewicz opened a new pull request #227: [MNG-6520] Update namespaces for maven-assembly to 2.0.0
slachiewicz opened a new pull request #227: [MNG-6520] Update namespaces for maven-assembly to 2.0.0 URL: https://github.com/apache/maven/pull/227 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] sormuras commented on a change in pull request #212: [SUREFIRE-1546] JUnit 5 runner does not honor JUnit 5 display names
sormuras commented on a change in pull request #212: [SUREFIRE-1546] JUnit 5
runner does not honor JUnit 5 display names
URL: https://github.com/apache/maven-surefire/pull/212#discussion_r245482354
##
File path:
surefire-providers/surefire-junit-platform/src/main/java/org/apache/maven/surefire/junitplatform/RunListenerAdapter.java
##
@@ -185,88 +181,72 @@ private void reportFailedTest(
private SimpleReportEntry createTestSetReportEntry( TestIdentifier
testIdentifier )
{
-return new SimpleReportEntry(
-JUnitPlatformProvider.class.getName(),
testIdentifier.getLegacyReportingName() );
+String[] classMethodName = toClassMethodName( testIdentifier );
+String className = classMethodName[0];
+String methodName = classMethodName[1];
+return new SimpleReportEntry( className, methodName );
}
private SimpleReportEntry createReportEntry( TestIdentifier testIdentifier
)
{
return createReportEntry( testIdentifier, (StackTraceWriter) null );
}
-private SimpleReportEntry createReportEntry(
-TestIdentifier testIdentifier, TestExecutionResult
testExecutionResult )
-{
-return createReportEntry(
-testIdentifier, getStackTraceWriter( testIdentifier,
testExecutionResult ) );
-}
-
-private SimpleReportEntry createReportEntry(
-TestIdentifier testIdentifier, StackTraceWriter
stackTraceWriter )
-{
-String source = getLegacyReportingClassName( testIdentifier );
-String name = getLegacyReportingName( testIdentifier );
-
-return SimpleReportEntry.withException( source, name, stackTraceWriter
);
-}
-
-private String getLegacyReportingName( TestIdentifier testIdentifier )
+private SimpleReportEntry createReportEntry( TestIdentifier testIdentifier,
+ TestExecutionResult
testExecutionResult )
{
-// Surefire cuts off the name at the first '(' character. Thus, we
have to pick a different
-// character to represent parentheses. "()" are removed entirely to
maximize compatibility with
-// existing reporting tools because in the old days test methods used
to not have parameters.
-return testIdentifier
-.getLegacyReportingName()
-.replace( "()", "" )
-.replace( '(', '{' )
-.replace( ')', '}' );
+return createReportEntry( testIdentifier, toStackTraceWriter(
testIdentifier, testExecutionResult ) );
}
-private String getLegacyReportingClassName( TestIdentifier testIdentifier )
+private SimpleReportEntry createReportEntry( TestIdentifier
testIdentifier, StackTraceWriter stackTraceWriter )
{
-return LegacyReportingUtils.getClassName( testPlan, testIdentifier );
+String[] classMethodName = toClassMethodName( testIdentifier );
+String className = classMethodName[0];
+String methodName = classMethodName[1];
+return withException( className, methodName, stackTraceWriter );
}
-private StackTraceWriter getStackTraceWriter(
-TestIdentifier testIdentifier, TestExecutionResult
testExecutionResult )
+private StackTraceWriter toStackTraceWriter( TestIdentifier testIdentifier,
+ TestExecutionResult
testExecutionResult )
{
Optional throwable = testExecutionResult.getThrowable();
if ( testExecutionResult.getStatus() == FAILED )
{
// Failed tests must have a StackTraceWriter, otherwise Surefire
will fail
-return getStackTraceWriter( testIdentifier, throwable.orElse( null
) );
+return toStackTraceWriter( testIdentifier, throwable.orElse( null
) );
}
-return throwable.map( t -> getStackTraceWriter( testIdentifier, t )
).orElse( null );
+return throwable.map( t -> toStackTraceWriter( testIdentifier, t ) )
+.orElse( null );
}
-private StackTraceWriter getStackTraceWriter( TestIdentifier
testIdentifier, Throwable throwable )
+private StackTraceWriter toStackTraceWriter( TestIdentifier
testIdentifier, Throwable throwable )
{
-String className = getClassName( testIdentifier );
-String methodName = getMethodName( testIdentifier ).orElse( "" );
+String[] classMethodName = toClassMethodName( testIdentifier );
+String className = classMethodName[0];
+String methodName = classMethodName[1];
return new PojoStackTraceWriter( className, methodName, throwable );
}
-private String getClassName( TestIdentifier testIdentifier )
+private String[] toClassMethodName( TestIdentifier testIdentifier )
{
+String methodDisplayName = testIdentifier.getDisplayName();
Review commen
[GitHub] slachiewicz commented on issue #226: dropping deprecated OptionBuilder in CLIManager
slachiewicz commented on issue #226: dropping deprecated OptionBuilder in CLIManager URL: https://github.com/apache/maven/pull/226#issuecomment-451668914 see also #153 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dfa1 opened a new pull request #226: dropping deprecated OptionBuilder in CLIManager
dfa1 opened a new pull request #226: dropping deprecated OptionBuilder in CLIManager URL: https://github.com/apache/maven/pull/226 Since version commons-cli 1.3 `org.apache.commons.cli.OptionBuilder` is deprecated and should be replaced with `Option#builder(String)`. Please note that: - this PR changes some public fields in `CLIManager` from `char` to `String`, not sure if this would be a real problem - I tried to replace the deprecated `org.apache.commons.cli.GnuParser.GnuParser` but there are test failures (e.g. cannot parse options like "-Drevision=1.3") Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MNG-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [X] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SUREFIRE-1542) Fractional per-core thread count
[
https://issues.apache.org/jira/browse/SUREFIRE-1542?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734891#comment-16734891
]
Tibor Digana commented on SUREFIRE-1542:
[~Pr0methean]
You are talking about {{threadCount}} or {{forkCount}}?
> Fractional per-core thread count
>
>
> Key: SUREFIRE-1542
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1542
> Project: Maven Surefire
> Issue Type: Improvement
>Reporter: Chris Hennick
>Priority: Major
>
> I have a lot of tests that each use 2 threads at once, and timeouts become a
> problem when I try to run 1 test thread per core (because that amounts to 2
> actual active threads per core). Why not make the thread count
> floating-point, so that I could fix this by specifying 0.5 threads per core?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1222) ForkClient attempts to consume unrelated lines
[
https://issues.apache.org/jira/browse/SUREFIRE-1222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734871#comment-16734871
]
Tibor Digana commented on SUREFIRE-1222:
[~eolivelli]
IMHo the sockets need to have an abstraction in prior in {{ForkedStarter}}. So
there is not only one additional task as sockets but mainly abstraction. Texas
University (SUREFIRE-1516) want to run the booter jar via Shell. So. It must be
new Abstraction and this abstraction must be in Java package for Extension API
(surefire-api module) which needs to be created (extensions are part of version
3.0).
> ForkClient attempts to consume unrelated lines
> --
>
> Key: SUREFIRE-1222
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1222
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin, process forking
>Affects Versions: 2.17
> Environment: Oracle JDK7 (build 1.7.0_79-b15)
> Linux 3.13 x86_64 with default locale cs_CZ
>Reporter: Martin Kouba
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M4
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This month the [Weld
> SE|https://github.com/weld/core/tree/2.3/environments/se/tests] test suite
> suddenly started to fail on a Linux machine with Oracle JDK7 and the default
> locale {{cs_CZ}}:
> {code}
> Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
> range: -1
> at java.lang.String.substring(String.java:1911)
> at
> org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:128)
> at
> org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:67)
> at java.lang.Thread.run(Thread.java:745)
> {code}
> A {{java.util.logging.Logger}} is used in the forked process. The exception
> occurs when the following log message is written to the standard output:
> {code}
> I 29, 2016 2:01:43 ODP. org.jboss.arquillian.container.se.server.Main main
> {code}
> We have found out that the timestamp *I 29, 2016 2:01:43* (i.e. 2016-01-29
> 14:01:43) is incorrectly parsed as {{ForkingRunListener.BOOTERCODE_SYSPROPS}}
> operation.
> I think the protocol should be robust enough to avoid similar collisions.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1617) Surefire fails with bad message when path contains whitespaces and colon
[
https://issues.apache.org/jira/browse/SUREFIRE-1617?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734868#comment-16734868
]
Tibor Digana commented on SUREFIRE-1617:
[~fwilhe]
Give me a good and working example with Class-Path in MANIFEST.MF / Surefire
Booter JAR.
We did the fix for Jigsaw modularity/Java 9 and this was forgotten in Booter
JAR:
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=blobdiff;f=maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ModularClasspathForkConfiguration.java;h=48e74d9e8a2364d1a1542e887102d4100b159a00;hp=fb8c86ae6342d67a4a215fa8be106bf97e68322c;hb=9b36828cc2ba65d17d3256c4f0c738a1ae7fe89d;hpb=d8d03e68a566e19f4dcc3bfbc1c0f4a1d5a23575
> Surefire fails with bad message when path contains whitespaces and colon
>
>
> Key: SUREFIRE-1617
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1617
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M1
> Environment: Maven Docker container
>Reporter: Florian Wilhelm
>Priority: Major
>
> I noticed that surefire seems not to handle paths like {{/this is: a test}}
> well on mac and linux.
> Steps to reproduce:
> {code:java}
> docker run -it --rm maven:3-jdk-8 bash
> root@x:/# mkdir "this is: a test"
> root@x:/# cd this\ is\:\ a\ test/
> root@x:/this is: a test# mvn archetype:generate -B
> "-DarchetypeGroupId=com.sap.cloud.s4hana.archetypes"
> "-DarchetypeArtifactId=scp-cf-spring" "-DarchetypeVersion=2.8.1"
> "-DgroupId=com.sap.cloud.s4hana.examples" "-DartifactId=my-spring-project"
> "-Dversion=1.0-SNAPSHOT"
> root@x:/this is: a test/my-spring-project# mvn clean install
> {code}
>
> Result:
>
> {noformat}
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit4/3.0.0-M1/common-junit4-3.0.0-M1.jar
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit3/3.0.0-M1/common-junit3-3.0.0-M1.jar
> Downloading from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-java5/3.0.0-M1/common-java5-3.0.0-M1.jar
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit3/3.0.0-M1/common-junit3-3.0.0-M1.jar
> (12 kB at 77 kB/s)
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-junit4/3.0.0-M1/common-junit4-3.0.0-M1.jar
> (28 kB at 168 kB/s)
> Downloaded from central:
> https://repo.maven.apache.org/maven2/org/apache/maven/surefire/common-java5/3.0.0-M1/common-java5-3.0.0-M1.jar
> (32 kB at 201 kB/s)
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] Reactor Summary for my-spring-project - Root 1.0-SNAPSHOT:
> [INFO]
> [INFO] my-spring-project - Root ... SUCCESS [ 9.569
> s]
> [INFO] my-spring-project - Application SUCCESS [01:06
> min]
> [INFO] my-spring-project - Unit Tests . FAILURE [ 26.631
> s]
> [INFO] my-spring-project - Integration Tests .. SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 01:46 min
> [INFO] Finished at: 2018-12-17T12:50:32Z
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M1:test (default-test)
> on project my-spring-project-unit-tests: There are test failures.
> [ERROR]
> [ERROR] Please refer to /this is: a
> test/my-spring-project/unit-tests/target/surefire-reports for the individual
> test results.
> [ERROR] Please refer to dump files (if any exist) [date].dump,
> [date]-jvmRun[N].dump and [date].dumpstream.
> [ERROR] ExecutionException The forked VM terminated without properly saying
> goodbye. VM crash or System.exit called?
> [ERROR] Command was /bin/sh -c cd "/this is: a
> test/my-spring-project/unit-tests" &&
> /usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java
> '-javaagent:/root/.m2/repository/org/jacoco/org.jacoco.agent/0.8.2/org.jacoco.agent-0.8.2-runtime.jar=destfile=/this
> is: a test/my-spring-project/unit-tests/target/coverage-reports/jacoco.exec'
> -Xmx1024m -Dorg.slf4j.simpleLogger.defaultLogLevel=info
> -Djava.io.tmpdir=target/arquillian
[GitHub] eolivelli commented on issue #2: [MJAR-238] Allow setting of module main class
eolivelli commented on issue #2: [MJAR-238] Allow setting of module main class URL: https://github.com/apache/maven-jar-plugin/pull/2#issuecomment-451647511 take 3: https://builds.apache.org/job/maven-box/job/maven-jar-plugin/job/MJAR-238/3/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on a change in pull request #1: Allow scripting in files
eolivelli commented on a change in pull request #1: Allow scripting in files URL: https://github.com/apache/maven-scripting-plugin/pull/1#discussion_r245474960 ## File path: pom.xml ## @@ -35,7 +35,8 @@ under the License. Apache Maven Scripting Plugin -The Maven Scripting Plugin is a plugin that wrapped the Scripting API accoring to JSR223 +The Maven Scripting Plugin is a plugin that wrapped the Scripting API accoring to JSR223. Review comment: Now that you are fixing this file please fix this typo as well: "accoring" -> "according" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on a change in pull request #1: Allow scripting in files
eolivelli commented on a change in pull request #1: Allow scripting in files URL: https://github.com/apache/maven-scripting-plugin/pull/1#discussion_r245474964 ## File path: pom.xml ## @@ -92,13 +93,6 @@ under the License. provided - - Review comment: @rpopov as we never released this plugin to the public I am fine with dropping the dependency now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khmarbaise edited a comment on issue #6: removing MockArtifact, not used
khmarbaise edited a comment on issue #6: removing MockArtifact, not used URL: https://github.com/apache/maven-jar-plugin/pull/6#issuecomment-451647243 Hi, no need for a JIRA ticket. Merged to master. Thanks for the contribution. See if ci succeeds. https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-jar-plugin/ This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khmarbaise commented on issue #6: removing MockArtifact, not used
khmarbaise commented on issue #6: removing MockArtifact, not used URL: https://github.com/apache/maven-jar-plugin/pull/6#issuecomment-451647243 Hi, no need for a JIRA ticket. Merged to master. Thanks for the contribution. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khmarbaise closed pull request #6: removing MockArtifact, not used
khmarbaise closed pull request #6: removing MockArtifact, not used
URL: https://github.com/apache/maven-jar-plugin/pull/6
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/src/test/java/org/apache/maven/plugins/jar/MockArtifact.java
b/src/test/java/org/apache/maven/plugins/jar/MockArtifact.java
deleted file mode 100644
index fac8d62..000
--- a/src/test/java/org/apache/maven/plugins/jar/MockArtifact.java
+++ /dev/null
@@ -1,303 +0,0 @@
-package org.apache.maven.plugins.jar;
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- */
-
-import java.io.File;
-import java.util.Collection;
-import java.util.List;
-
-import org.apache.maven.artifact.Artifact;
-import org.apache.maven.artifact.handler.ArtifactHandler;
-import org.apache.maven.artifact.metadata.ArtifactMetadata;
-import org.apache.maven.artifact.repository.ArtifactRepository;
-import org.apache.maven.artifact.resolver.filter.ArtifactFilter;
-import org.apache.maven.artifact.versioning.ArtifactVersion;
-import org.apache.maven.artifact.versioning.OverConstrainedVersionException;
-import org.apache.maven.artifact.versioning.VersionRange;
-
-/**
- * @todo move to maven-artifact-test
- */
-class MockArtifact
-implements Artifact
-{
-private String groupId;
-
-private String artifactId;
-
-private String version;
-
-private File file;
-
-private String scope;
-
-private String type;
-
-private String classifier;
-
-private String baseVersion;
-
-public String getGroupId()
-{
-return groupId;
-}
-
-public String getArtifactId()
-{
-return artifactId;
-}
-
-public String getVersion()
-{
-return version;
-}
-
-public void setVersion( String string )
-{
-this.version = string;
-}
-
-public String getScope()
-{
-return scope;
-}
-
-public String getType()
-{
-return type;
-}
-
-public String getClassifier()
-{
-return classifier;
-}
-
-public boolean hasClassifier()
-{
-return classifier != null;
-}
-
-public File getFile()
-{
-return file;
-}
-
-public void setFile( File file )
-{
-this.file = file;
-}
-
-public String getBaseVersion()
-{
-return baseVersion;
-}
-
-public void setBaseVersion( String string )
-{
-this.baseVersion = string;
-}
-
-public String getId()
-{
-return null;
-}
-
-public String getDependencyConflictId()
-{
-return null;
-}
-
-public void addMetadata( ArtifactMetadata artifactMetadata )
-{
-// intentionally empty.
-}
-
-public Collection getMetadataList()
-{
-return null; //To change body of implemented methods use File |
Settings | File Templates.
-}
-
-public void setRepository( ArtifactRepository artifactRepository )
-{
-//To change body of implemented methods use File | Settings | File
Templates.
-}
-
-public ArtifactRepository getRepository()
-{
-return null; //To change body of implemented methods use File |
Settings | File Templates.
-}
-
-public void updateVersion( String string, ArtifactRepository
artifactRepository )
-{
-//To change body of implemented methods use File | Settings | File
Templates.
-}
-
-public String getDownloadUrl()
-{
-return null; //To change body of implemented methods use File |
Settings | File Templates.
-}
-
-public void setDownloadUrl( String string )
-{
-//To change body of implemented methods use File | Settings | File
Templates.
-}
-
-public ArtifactFilter getDependencyFilter()
-{
-return null; //To change body of implemented methods use File |
Settings | File Templates.
-}
-
-public void setDependencyFilter( ArtifactFilter artifactFilter )
-{
-//To change body of implemented methods use File | Settings | Fil
[GitHub] eolivelli commented on issue #1: Allow scripting in files
eolivelli commented on issue #1: Allow scripting in files URL: https://github.com/apache/maven-scripting-plugin/pull/1#issuecomment-451647173 This project is still very new, I found that we don't have even the JIRA project yet, I apologize for having given you bad instructions. I am setting all up in order to be able to work well. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #1: Allow scripting in files
eolivelli commented on issue #1: Allow scripting in files URL: https://github.com/apache/maven-scripting-plugin/pull/1#issuecomment-451647106 @rpopov we are enabling Travis-CI on this github project, so that you can see the results of the tests directly in Travis. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dfa1 commented on issue #6: removing MockArtifact, not used
dfa1 commented on issue #6: removing MockArtifact, not used URL: https://github.com/apache/maven-jar-plugin/pull/6#issuecomment-451647099 @khmarbaise rebased, integration tests are ok, do I need a JIRA ticket? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] rpopov opened a new pull request #1: Allow scripting in files
rpopov opened a new pull request #1: Allow scripting in files URL: https://github.com/apache/maven-scripting-plugin/pull/1 Once MSCRIPTING JIRA project is not public, I was not able to register a JIRA issue for this change. Added parameter to maven-scripting-plugin, allowing the identification of the engine to use to use the file name extension, while still allowing explicitly naming the engine by providing . Internally refactored to have a cleaner structure, allowing more extensions. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on issue #1: Allow scripting in files
eolivelli commented on issue #1: Allow scripting in files URL: https://github.com/apache/maven-scripting-plugin/pull/1#issuecomment-451647037 closing and reopening in order to trigger Travis This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli closed pull request #1: Allow scripting in files
eolivelli closed pull request #1: Allow scripting in files URL: https://github.com/apache/maven-scripting-plugin/pull/1 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/pom.xml b/pom.xml index c9e39d6..4293a0e 100644 --- a/pom.xml +++ b/pom.xml @@ -35,7 +35,8 @@ under the License. Apache Maven Scripting Plugin -The Maven Scripting Plugin is a plugin that wrapped the Scripting API accoring to JSR223 +The Maven Scripting Plugin is a plugin that wrapped the Scripting API accoring to JSR223. +Add the scripting engines as dependencies of this plugin on its use. 2016 @@ -92,13 +93,6 @@ under the License. provided - - - org.codehaus.groovy - groovy-jsr223 - 2.4.7 - - junit diff --git a/src/it/groovy-script-file-name/pom.xml b/src/it/groovy-script-file-name/pom.xml new file mode 100644 index 000..a5fdfca --- /dev/null +++ b/src/it/groovy-script-file-name/pom.xml @@ -0,0 +1,51 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + org.apache.maven.plugins.scripting.its + groovy-script + 1.0.0-SNAPSHOT + pom + + + + +org.apache.maven.plugins +maven-scripting-plugin +@project.version@ + + groovy + test.groov + + + + +org.codehaus.groovy +groovy-jsr223 +2.4.7 + + + + + + diff --git a/src/it/groovy-script-file-name/test.groov b/src/it/groovy-script-file-name/test.groov new file mode 100644 index 000..94d935c --- /dev/null +++ b/src/it/groovy-script-file-name/test.groov @@ -0,0 +1,21 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + + +(1..10).sum() + ' ' + project.artifactId \ No newline at end of file diff --git a/src/it/groovy-script-file/pom.xml b/src/it/groovy-script-file/pom.xml new file mode 100644 index 000..6093e33 --- /dev/null +++ b/src/it/groovy-script-file/pom.xml @@ -0,0 +1,51 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd";> + 4.0.0 + + org.apache.maven.plugins.scripting.its + groovy-script + 1.0.0-SNAPSHOT + pom + + + + +org.apache.maven.plugins +maven-scripting-plugin +@project.version@ + + + test.groovy + + + + +org.codehaus.groovy +groovy-jsr223 +2.4.7 + + + + + + diff --git a/src/it/groovy-script-file/test.groovy b/src/it/groovy-script-file/test.groovy new file mode 100644 index 000..94d935c --- /dev/null +++ b/src/it/groovy-script-file/test.groovy @@ -0,0 +1,21 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + + +(1..10).sum() + ' ' + project.artifactId \ No newline at end of file diff --git a/src/it/groovy-script/pom.xml b/src/it/groovy-script/pom.xml index 5098a79..0c
[GitHub] eolivelli opened a new pull request #2: test pr
eolivelli opened a new pull request #2: test pr URL: https://github.com/apache/maven-scripting-plugin/pull/2 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MSCRIPTING) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MSCRIPTING-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MSCRIPTING-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khmarbaise commented on issue #6: removing MockArtifact, not used
khmarbaise commented on issue #6: removing MockArtifact, not used URL: https://github.com/apache/maven-jar-plugin/pull/6#issuecomment-451646363 Please rebase against most recent master...apart from that I appreciate to merge that. Can you please keep the issue template and make the checkbox according to your contribution...Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khmarbaise commented on issue #5: (doc) fix broken link
khmarbaise commented on issue #5: (doc) fix broken link URL: https://github.com/apache/maven-jar-plugin/pull/5#issuecomment-451646262 Merged into master. Thanks for the fix. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] khmarbaise closed pull request #5: (doc) fix broken link
khmarbaise closed pull request #5: (doc) fix broken link URL: https://github.com/apache/maven-jar-plugin/pull/5 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 23dc884..a959f20 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -31,9 +31,9 @@ Getting Started + Make sure you have a [JIRA account](https://issues.apache.org/jira/). + Make sure you have a [GitHub account](https://github.com/signup/free). -+ If you're planning to implement a new feature, it makes sense to discuss your changes - on the [dev list](https://maven.apache.org/mail-lists.html) first. - This way you can make sure you're not wasting your time on something that isn't ++ If you're planning to implement a new feature, it makes sense to discuss your changes + on the [dev list](https://maven.apache.org/mail-lists.html) first. + This way you can make sure you're not wasting your time on something that isn't considered to be in Apache Maven's scope. + Submit a ticket for your issue, assuming one does not already exist. + Clearly describe the issue, including steps to reproduce when it is a bug. @@ -44,7 +44,7 @@ Making and Submitting Changes -- We accept Pull Requests via GitHub. The [developer mailing list][dev-ml-list] is the -main channel of communication for contributors. +main channel of communication for contributors. There are some guidelines which will make applying PRs easier for us: + Create a topic branch from where you want to base your work (this is usually the master branch). Push your changes to a topic branch in your fork of the repository. @@ -52,7 +52,7 @@ There are some guidelines which will make applying PRs easier for us: + Respect the original code style: by using the same [codestyle][code-style], patches should only highlight the actual difference, not being disturbed by any formatting issues: + Only use spaces for indentation. - + Create minimal diffs - disable on save actions like reformat source code or organize imports. + + Create minimal diffs - disable on save actions like reformat source code or organize imports. If you feel the source code should be reformatted, create a separate PR for this change. + Check for unnecessary whitespace with `git diff --check` before committing. + Make sure your commit messages are in the proper format. Your commit message should contain the key of the JIRA issue. @@ -85,7 +85,7 @@ Additional Resources + [Apache Maven Twitter Account](https://twitter.com/ASFMavenProject) + #Maven IRC channel on freenode.org -[dev-ml-list]: https://maven.apache.org/mail-lists.html +[dev-ml-list]: https://maven.apache.org/mailing-lists.html [code-style]: https://maven.apache.org/developers/conventions/code.html [cla]: https://www.apache.org/licenses/#clas [maven-wiki]: https://cwiki.apache.org/confluence/display/MAVEN/Index This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dfa1 opened a new pull request #6: removing MockArtifact, not used
dfa1 opened a new pull request #6: removing MockArtifact, not used URL: https://github.com/apache/maven-jar-plugin/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] dfa1 opened a new pull request #5: (doc) fix broken link
dfa1 opened a new pull request #5: (doc) fix broken link URL: https://github.com/apache/maven-jar-plugin/pull/5 Broken link in CONTRIBUTING.md This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MSHARED-484) Upgrade to Plexus Digest 1.1
[ https://issues.apache.org/jira/browse/MSHARED-484?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734842#comment-16734842 ] Michael Osipov commented on MSHARED-484: Still true. > Upgrade to Plexus Digest 1.1 > > > Key: MSHARED-484 > URL: https://issues.apache.org/jira/browse/MSHARED-484 > Project: Maven Shared Components > Issue Type: Task > Components: maven-shared-jar >Affects Versions: maven-shared-jar-1.1 >Reporter: Michael Osipov >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-5950) Only first active proxy considered
[
https://issues.apache.org/jira/browse/MNG-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734840#comment-16734840
]
Michael Osipov commented on MNG-5950:
-
Rescheduling because it like requires model changes in the {{settings.xml}}.
> Only first active proxy considered
> --
>
> Key: MNG-5950
> URL: https://issues.apache.org/jira/browse/MNG-5950
> Project: Maven
> Issue Type: Bug
> Components: core
>Affects Versions: 3.0.5
> Environment: windows 7 ,jdk 1.8
>Reporter: Jiahongchao
>Priority: Major
> Fix For: Issues to be reviewed for 4.x
>
>
> only http proxy or https proxy can be used at the same time,however,only one
> proxy should be used for both http and https
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MNG-5950) Only first active proxy considered
[ https://issues.apache.org/jira/browse/MNG-5950?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-5950: Fix Version/s: (was: 3.x / Backlog) Issues to be reviewed for 4.x > Only first active proxy considered > -- > > Key: MNG-5950 > URL: https://issues.apache.org/jira/browse/MNG-5950 > Project: Maven > Issue Type: Bug > Components: core >Affects Versions: 3.0.5 > Environment: windows 7 ,jdk 1.8 >Reporter: Jiahongchao >Priority: Major > Fix For: Issues to be reviewed for 4.x > > > only http proxy or https proxy can be used at the same time,however,only one > proxy should be used for both http and https -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MSHARED-486) Upgrade to Commons BCEL 6.0
[ https://issues.apache.org/jira/browse/MSHARED-486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MSHARED-486. -- Resolution: Fixed Assignee: Michael Osipov Fix Version/s: maven-shared-jar-1.2 > Upgrade to Commons BCEL 6.0 > --- > > Key: MSHARED-486 > URL: https://issues.apache.org/jira/browse/MSHARED-486 > Project: Maven Shared Components > Issue Type: Task > Components: maven-shared-jar >Affects Versions: maven-shared-jar-1.2 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: maven-shared-jar-1.2 > > > Upgrade as soon as it gets available. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6541) less restrictive "is referencing itself" check
[
https://issues.apache.org/jira/browse/MNG-6541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16734812#comment-16734812
]
Václav Haisman commented on MNG-6541:
-
[~slachiewicz] I have tested with Maven 3.6.0 and it does not manifest the
error.
> less restrictive "is referencing itself" check
> --
>
> Key: MNG-6541
> URL: https://issues.apache.org/jira/browse/MNG-6541
> Project: Maven
> Issue Type: Wish
> Components: Dependencies
>Affects Versions: 3.5.4
>Reporter: Václav Haisman
>Priority: Major
>
> I have issues when building site:site in project with OpenJFX. The
> javafx-graphics artifact sort of references itself:
> {code:xml}
>
> http://maven.apache.org/POM/4.0.0";
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/xsd/maven-4.0.0.xsd";
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance";>
> 4.0.0
> org.openjfx
> javafx-graphics
> 11.0.1
>
> org.openjfx
> javafx
> 11.0.1
>
>
>
> org.openjfx
> javafx-graphics
> 11.0.1
> ${javafx.platform}
>
>
> org.openjfx
> javafx-base
> 11.0.1
>
>
>
> {code}
> But it does so with additional classifier. When I run site:site, it gives me
> this:
> {code}
> [WARNING] Unable to create Maven project from repository.
> org.apache.maven.project.ProjectBuildingException: 1 problem was encountered
> while building the effective model for org.openjfx:javafx-graphics:11.0.1
> [FATAL] 'dependencies.dependency org.openjfx:javafx-graphics:11.0.1' for
> org.openjfx:javafx-graphics:11.0.1 is referencing itself. @ line 13, column 17
> for project org.openjfx:javafx-graphics:11.0.1
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:165)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:327)
> at
> org.apache.maven.report.projectinfo.dependencies.RepositoryUtils.getMavenProjectFromRepository
> (RepositoryUtils.java:125)
> {code}
> I was wondering if the check could not be relaxed to accommodate this
> situation that seems to be common even in core Java components?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
