[GitHub] [maven-compiler-plugin] yeroc commented on issue #3: [MCOMPILER-205] fixes incremental compilation
yeroc commented on issue #3: [MCOMPILER-205] fixes incremental compilation URL: https://github.com/apache/maven-compiler-plugin/pull/3#issuecomment-478848699 @rfscholte Thanks for the update. There's quite a bit of conflicting information on the ticket so for an outsider it's difficult to discern what's correct and what isn't. That said, I scanned through the ticket again and couldn't find a reference to a missing feature in the compiler. Can you elaborate on that or post a link to the relevant ticket for that? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MSHARED-810) Support Java 12
[ https://issues.apache.org/jira/browse/MSHARED-810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rune Flobakk updated MSHARED-810: - Issue Type: Dependency upgrade (was: Bug) > Support Java 12 > --- > > Key: MSHARED-810 > URL: https://issues.apache.org/jira/browse/MSHARED-810 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-dependency-analyzer >Affects Versions: maven-dependency-analyzer-1.11.1 >Reporter: Rune Flobakk >Priority: Minor > Labels: Java12 > > ASM 7.1 supports Java 12 (and supposedly Java 13): > [https://asm.ow2.io/versions.html] > I have upgraded to v7.1 and tested it with maven-dependency-plugin:analyze on > a Java 12 project, and it works fine with only the dependency update. > [https://github.com/runeflobakk/maven-dependency-analyzer/commit/a8f026e296109badafdd57312b5032d4f5d33fcc] > I am happy to make a pull request for it! > (or if you prefer to just make the simple change yourself, that's would of > course also be great. Just wanted to let you know of the simple change to > make it compatible with Java 12) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-resolver] tawek commented on a change in pull request #22: Introduce caching for tracking files.
tawek commented on a change in pull request #22: Introduce caching for tracking
files.
URL: https://github.com/apache/maven-resolver/pull/22#discussion_r271065809
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
##
@@ -131,52 +207,145 @@ public Properties update( File file, Map updates )
raf.seek( 0 );
raf.write( stream.toByteArray() );
raf.setLength( raf.getFilePointer() );
+
+this.entryTs = System.currentTimeMillis();
+this.lastModifiedTs = file.lastModified();
}
catch ( IOException e )
{
LOGGER.warn( "Failed to write tracking file {}", file, e );
}
finally
{
-release( lock, file );
-close( raf, file );
+release( lock );
+close( raf );
}
-}
-return props;
-}
+return props;
+}
-private void release( FileLock lock, File file )
-{
-if ( lock != null )
+private void release( FileLock lock )
{
-try
+if ( lock != null )
{
-lock.release();
+try
+{
+lock.release();
+}
+catch ( IOException e )
+{
+LOGGER.warn( "Error releasing lock for tracking file {}",
file, e );
+}
}
-catch ( IOException e )
+}
+
+private void close( Closeable closeable )
+{
+if ( closeable != null )
{
-LOGGER.warn( "Error releasing lock for tracking file {}",
file, e );
+try
+{
+closeable.close();
+}
+catch ( IOException e )
+{
+LOGGER.warn( "Error closing tracking file {}", file, e );
+}
}
}
-}
-private void close( Closeable closeable, File file )
-{
-if ( closeable != null )
+private FileLock lock( FileChannel channel, long size, boolean shared
) throws IOException
{
-try
+FileLock lock = null;
+
+for ( int attempts = 8; attempts >= 0; attempts-- )
{
-closeable.close();
+try
+{
+lock = channel.lock( 0, size, shared );
+break;
+}
+catch ( OverlappingFileLockException e )
+{
+if ( attempts <= 0 )
+{
+throw (IOException) new IOException().initCause( e );
+}
+try
+{
+Thread.sleep( 50L );
+}
+catch ( InterruptedException e1 )
+{
+Thread.currentThread().interrupt();
+}
+}
}
-catch ( IOException e )
+
+if ( lock == null )
{
-LOGGER.warn( "Error closing tracking file {}", file, e );
+throw new IOException( "Could not lock file" );
}
+
+return lock;
+}
+
+}
+
+/**
+ * Canonicalized files by their path (the same canonicalized file may be
registered under different paths). This
+ * cache is especially useful on Windows platform where canonicalization
is relatively expensive.
+ */
+private static ConcurrentHashMap canonicalizedCache = new
ConcurrentHashMap<>();
Review comment:
Glad to here there is some interest in merging either this or #29.
As to split "this and canonicalization" - I understand that we need to have
a different PR on canonicalization cache.
As to "I need JIRA" - as there is already MRESOLVER-68 so I may hijack it or
create two new JIRAs tickets (assuming there is a real need to split). Please
advise.
For the weakly reachable keys in the canonicalization cache hash map I
understand the concern for memory. But since WeakHashMap expiry is based on key
object identity it effectively means that caching for canonicalization may not
work unless there is String deduplication enabled on JVM. Please see the
javadoc for WeakHashMap. For File its even worse since those handles are not
deduplicated in any way as far as I know and the caches would be flushed clean
on gc (probably depends on collector impl and finalizer threads/reference
queues).
There is already a canonicalization cache in JVM for Windows (!) - see
'ExpiringCache.java' it is just limited to 200 entries FIFO and 30s. I've found
it to be ineffective - too small and too
[GitHub] [maven-resolver] tawek commented on a change in pull request #22: Introduce caching for tracking files.
tawek commented on a change in pull request #22: Introduce caching for tracking
files.
URL: https://github.com/apache/maven-resolver/pull/22#discussion_r271065809
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
##
@@ -131,52 +207,145 @@ public Properties update( File file, Map updates )
raf.seek( 0 );
raf.write( stream.toByteArray() );
raf.setLength( raf.getFilePointer() );
+
+this.entryTs = System.currentTimeMillis();
+this.lastModifiedTs = file.lastModified();
}
catch ( IOException e )
{
LOGGER.warn( "Failed to write tracking file {}", file, e );
}
finally
{
-release( lock, file );
-close( raf, file );
+release( lock );
+close( raf );
}
-}
-return props;
-}
+return props;
+}
-private void release( FileLock lock, File file )
-{
-if ( lock != null )
+private void release( FileLock lock )
{
-try
+if ( lock != null )
{
-lock.release();
+try
+{
+lock.release();
+}
+catch ( IOException e )
+{
+LOGGER.warn( "Error releasing lock for tracking file {}",
file, e );
+}
}
-catch ( IOException e )
+}
+
+private void close( Closeable closeable )
+{
+if ( closeable != null )
{
-LOGGER.warn( "Error releasing lock for tracking file {}",
file, e );
+try
+{
+closeable.close();
+}
+catch ( IOException e )
+{
+LOGGER.warn( "Error closing tracking file {}", file, e );
+}
}
}
-}
-private void close( Closeable closeable, File file )
-{
-if ( closeable != null )
+private FileLock lock( FileChannel channel, long size, boolean shared
) throws IOException
{
-try
+FileLock lock = null;
+
+for ( int attempts = 8; attempts >= 0; attempts-- )
{
-closeable.close();
+try
+{
+lock = channel.lock( 0, size, shared );
+break;
+}
+catch ( OverlappingFileLockException e )
+{
+if ( attempts <= 0 )
+{
+throw (IOException) new IOException().initCause( e );
+}
+try
+{
+Thread.sleep( 50L );
+}
+catch ( InterruptedException e1 )
+{
+Thread.currentThread().interrupt();
+}
+}
}
-catch ( IOException e )
+
+if ( lock == null )
{
-LOGGER.warn( "Error closing tracking file {}", file, e );
+throw new IOException( "Could not lock file" );
}
+
+return lock;
+}
+
+}
+
+/**
+ * Canonicalized files by their path (the same canonicalized file may be
registered under different paths). This
+ * cache is especially useful on Windows platform where canonicalization
is relatively expensive.
+ */
+private static ConcurrentHashMap canonicalizedCache = new
ConcurrentHashMap<>();
Review comment:
Glad to here there is some interest in merging either this or #29.
As to split "this and canonicalization" - I understand that we need to have
a different PR on canonicalization cache (not sure why this would bring any
benefit...).
As to "I need JIRA" - as there is already MRESOLVER-68 so I may hijack it or
create two new JIRAs tickets (assuming there is a real need to split). Please
advise.
For the weakly reachable keys in the canonicalization cache hash map I
understand the concern for memory. But since WeakHashMap expiry is based on key
object identity it effectively means that caching for canonicalization may not
work unless there is String deduplication enabled on JVM. Please see the
javadoc for WeakHashMap. For File its even worse since those handles are not
deduplicated in any way as far as I know and the caches would be flushed clean
on gc (probably depends on collector impl and finalizer threads/reference
queues).
There is already a canonicalization cache in JVM for Windows (!) - see
'ExpiringCache.java' it is just limited to 200 entries FIFO and 30s. I've found
[jira] [Commented] (MJAVADOC-594) aggregate-jar fails on attached artifacts created by projects in the reactor build
[
https://issues.apache.org/jira/browse/MJAVADOC-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807215#comment-16807215
]
Steinar Bang commented on MJAVADOC-594:
---
I've tried changing phases for the features.xml file generation and for the
aggregate-jar goal, to ensure that the features.xml files are built before
aggregate-jar is attempted, but changing phases had no effect on this error.
It looks like the error occurs in an initial dependency check before anything
is actually done.
> aggregate-jar fails on attached artifacts created by projects in the reactor
> build
> --
>
> Key: MJAVADOC-594
> URL: https://issues.apache.org/jira/browse/MJAVADOC-594
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.0
> Environment: debian 9.8 "stretch", amd64, openjdk 8u212-b01-1~deb9u1,
> maven 3.6.0
>Reporter: Steinar Bang
>Priority: Major
>
> I have a multi-module project that have modules with attachments of type
> "xml" and classifier "features".
> When modules in the reactor build have dependencies to xml features
> attachments of other modules like e.g. this:
> {code:xml}
>
> no.priv.bang.authservice
> authservice.definitions
> ${project.version}
> xml
> features
>
> {code}
> and an aggregate-jar configuration like this:
> {code:xml}
>
> org.apache.maven.plugins
> maven-javadoc-plugin
>
> private
>
>
>
> attach-javadocs
>
> jar
>
>
>
> aggregate-javadocs
>
> aggregate-jar
>
> prepare-package
>
>
>
>
>
> {code}
> the build fails early with the following error message:
> {noformat}
> [INFO]
>
> [INFO] Reactor Summary for Authentication webapp 1.0.0-SNAPSHOT:
> [INFO]
> [INFO] Authentication webapp .. FAILURE [ 2.753
> s]
> [INFO] Authentication webapp definitions bundle ... SKIPPED
> [INFO] Authentication webapp Liquibase DB schema .. SKIPPED
> [INFO] Authentication webapp derby database for use in development and
> testing SKIPPED
> [INFO] Authentication webapp PostgreSQL database .. SKIPPED
> [INFO] Authentication webapp DB-based Shiro realm service component SKIPPED
> [INFO] Authentication webapp memory based Shiro SessionDAO realm service
> component SKIPPED
> [INFO] Authentication webapp web whiteboard Shiro filter .. SKIPPED
> [INFO] Authentication webapp user admin service ... SKIPPED
> [INFO] Authentication webapp user admin web API ... SKIPPED
> [INFO] Authentication webapp user admin frontend .. SKIPPED
> [INFO] Authentication webapp integration tests SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.911 s
> [INFO] Finished at: 2019-04-01T23:00:10+02:00
> [INFO]
>
> [ERROR] Failed to execute goal on project authservice.db.derby.test: Could
> not resolve dependencies for project
> no.priv.bang.authservice:authservice.db.derby.test:jar:1.0.0-SNAPSHOT: The
> following artifacts could not be resolved:
> no.priv.bang.authservice:authservice.definitions:xml:features:1.0.0-SNAPSHOT,
> no.priv.bang.authservice:authservice.db.liquibase:xml:features:1.0.0-SNAPSHOT:
> Could not find artifact
> no.priv.bang.authservice:authservice.definitions:xml:features:1.0.0-SNAPSHOT
> in snapshots-repo (https://oss.sonatype.org/content/repositories/snapshots)
> -> [Help 1]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MJAVADOC-594) aggregate-jar fails on attached artifacts created by projects in the reactor build
[
https://issues.apache.org/jira/browse/MJAVADOC-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807210#comment-16807210
]
Steinar Bang commented on MJAVADOC-594:
---
I've created a branch in a project in a github repo that reproduces the
problem: https://github.com/steinarb/authservice/tree/bug/mjavadoc-594
> aggregate-jar fails on attached artifacts created by projects in the reactor
> build
> --
>
> Key: MJAVADOC-594
> URL: https://issues.apache.org/jira/browse/MJAVADOC-594
> Project: Maven Javadoc Plugin
> Issue Type: Bug
> Components: jar
>Affects Versions: 3.1.0
> Environment: debian 9.8 "stretch", amd64, openjdk 8u212-b01-1~deb9u1,
> maven 3.6.0
>Reporter: Steinar Bang
>Priority: Major
>
> I have a multi-module project that have modules with attachments of type
> "xml" and classifier "features".
> When modules in the reactor build have dependencies to xml features
> attachments of other modules like e.g. this:
> {code:xml}
>
> no.priv.bang.authservice
> authservice.definitions
> ${project.version}
> xml
> features
>
> {code}
> and an aggregate-jar configuration like this:
> {code:xml}
>
> org.apache.maven.plugins
> maven-javadoc-plugin
>
> private
>
>
>
> attach-javadocs
>
> jar
>
>
>
> aggregate-javadocs
>
> aggregate-jar
>
> prepare-package
>
>
>
>
>
> {code}
> the build fails early with the following error message:
> {noformat}
> [INFO]
>
> [INFO] Reactor Summary for Authentication webapp 1.0.0-SNAPSHOT:
> [INFO]
> [INFO] Authentication webapp .. FAILURE [ 2.753
> s]
> [INFO] Authentication webapp definitions bundle ... SKIPPED
> [INFO] Authentication webapp Liquibase DB schema .. SKIPPED
> [INFO] Authentication webapp derby database for use in development and
> testing SKIPPED
> [INFO] Authentication webapp PostgreSQL database .. SKIPPED
> [INFO] Authentication webapp DB-based Shiro realm service component SKIPPED
> [INFO] Authentication webapp memory based Shiro SessionDAO realm service
> component SKIPPED
> [INFO] Authentication webapp web whiteboard Shiro filter .. SKIPPED
> [INFO] Authentication webapp user admin service ... SKIPPED
> [INFO] Authentication webapp user admin web API ... SKIPPED
> [INFO] Authentication webapp user admin frontend .. SKIPPED
> [INFO] Authentication webapp integration tests SKIPPED
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.911 s
> [INFO] Finished at: 2019-04-01T23:00:10+02:00
> [INFO]
>
> [ERROR] Failed to execute goal on project authservice.db.derby.test: Could
> not resolve dependencies for project
> no.priv.bang.authservice:authservice.db.derby.test:jar:1.0.0-SNAPSHOT: The
> following artifacts could not be resolved:
> no.priv.bang.authservice:authservice.definitions:xml:features:1.0.0-SNAPSHOT,
> no.priv.bang.authservice:authservice.db.liquibase:xml:features:1.0.0-SNAPSHOT:
> Could not find artifact
> no.priv.bang.authservice:authservice.definitions:xml:features:1.0.0-SNAPSHOT
> in snapshots-repo (https://oss.sonatype.org/content/repositories/snapshots)
> -> [Help 1]
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MJAVADOC-594) aggregate-jar fails on attached artifacts created by projects in the reactor build
Steinar Bang created MJAVADOC-594:
-
Summary: aggregate-jar fails on attached artifacts created by
projects in the reactor build
Key: MJAVADOC-594
URL: https://issues.apache.org/jira/browse/MJAVADOC-594
Project: Maven Javadoc Plugin
Issue Type: Bug
Components: jar
Affects Versions: 3.1.0
Environment: debian 9.8 "stretch", amd64, openjdk 8u212-b01-1~deb9u1,
maven 3.6.0
Reporter: Steinar Bang
I have a multi-module project that have modules with attachments of type "xml"
and classifier "features".
When modules in the reactor build have dependencies to xml features attachments
of other modules like e.g. this:
{code:xml}
no.priv.bang.authservice
authservice.definitions
${project.version}
xml
features
{code}
and an aggregate-jar configuration like this:
{code:xml}
org.apache.maven.plugins
maven-javadoc-plugin
private
attach-javadocs
jar
aggregate-javadocs
aggregate-jar
prepare-package
{code}
the build fails early with the following error message:
{noformat}
[INFO]
[INFO] Reactor Summary for Authentication webapp 1.0.0-SNAPSHOT:
[INFO]
[INFO] Authentication webapp .. FAILURE [ 2.753 s]
[INFO] Authentication webapp definitions bundle ... SKIPPED
[INFO] Authentication webapp Liquibase DB schema .. SKIPPED
[INFO] Authentication webapp derby database for use in development and testing
SKIPPED
[INFO] Authentication webapp PostgreSQL database .. SKIPPED
[INFO] Authentication webapp DB-based Shiro realm service component SKIPPED
[INFO] Authentication webapp memory based Shiro SessionDAO realm service
component SKIPPED
[INFO] Authentication webapp web whiteboard Shiro filter .. SKIPPED
[INFO] Authentication webapp user admin service ... SKIPPED
[INFO] Authentication webapp user admin web API ... SKIPPED
[INFO] Authentication webapp user admin frontend .. SKIPPED
[INFO] Authentication webapp integration tests SKIPPED
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 3.911 s
[INFO] Finished at: 2019-04-01T23:00:10+02:00
[INFO]
[ERROR] Failed to execute goal on project authservice.db.derby.test: Could not
resolve dependencies for project
no.priv.bang.authservice:authservice.db.derby.test:jar:1.0.0-SNAPSHOT: The
following artifacts could not be resolved:
no.priv.bang.authservice:authservice.definitions:xml:features:1.0.0-SNAPSHOT,
no.priv.bang.authservice:authservice.db.liquibase:xml:features:1.0.0-SNAPSHOT:
Could not find artifact
no.priv.bang.authservice:authservice.definitions:xml:features:1.0.0-SNAPSHOT in
snapshots-repo (https://oss.sonatype.org/content/repositories/snapshots) ->
[Help 1]
{noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MRELEASE-1021) release:prepare and release:update-version sets line endings to crlf for all lines except the first and last lines of the pom.xml files
[
https://issues.apache.org/jira/browse/MRELEASE-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807206#comment-16807206
]
Michael Osipov commented on MRELEASE-1021:
--
Can we close this one then?
> release:prepare and release:update-version sets line endings to crlf for all
> lines except the first and last lines of the pom.xml files
> ---
>
> Key: MRELEASE-1021
> URL: https://issues.apache.org/jira/browse/MRELEASE-1021
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3
> Environment: debian 9.8 "stretch", amd64, openjdk 8u212-b01-1~deb9u1,
> maven 3.3.9-4
>Reporter: Steinar Bang
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> For these two projects
> * https://github.com/steinarb/authservice
> * https://github.com/steinarb/osgi-service
> line endings in the pom.xml files are messed up when I do
> {noformat}
> mvn release:prepare
> {noformat}
> or bump versions with e.g.
> {noformat}
> mvn --batch-mode release:update-versions -DdevelopmentVersion=1.0.2-SNAPSHOT
> {noformat}
> What happens to the line endings are:
> # First line stays at lf
> # Last line stays at lf
> # All of the intervening lines get crlf
> # The line endings were initially lf (at least they were meant to be)
> # I run the "mvn release:prepare" and "mvn:update-version" commands from a
> command line on Debian GNU/linux
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MSHARED-811) Improve handling of Metadata
[ https://issues.apache.org/jira/browse/MSHARED-811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807198#comment-16807198 ] Hudson commented on MSHARED-811: Build succeeded in Jenkins: Maven TLP » maven-artifact-transfer » master #8 See https://builds.apache.org/job/maven-box/job/maven-artifact-transfer/job/master/8/ > Improve handling of Metadata > > > Key: MSHARED-811 > URL: https://issues.apache.org/jira/browse/MSHARED-811 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Major > Fix For: maven-artifact-transfer-0.12.0 > > > Current implementation doesn't support install/deploy of custom metadata such > as gpg signatures. > The related code contains a comment statement which needs to be implemented. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MRELEASE-1021) release:prepare and release:update-version sets line endings to crlf for all lines except the first and last lines of the pom.xml files
[
https://issues.apache.org/jira/browse/MRELEASE-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807177#comment-16807177
]
Steinar Bang commented on MRELEASE-1021:
I have now tried with maven 3.6.0 and the problem is not present there.
> release:prepare and release:update-version sets line endings to crlf for all
> lines except the first and last lines of the pom.xml files
> ---
>
> Key: MRELEASE-1021
> URL: https://issues.apache.org/jira/browse/MRELEASE-1021
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3
> Environment: debian 9.8 "stretch", amd64, openjdk 8u212-b01-1~deb9u1,
> maven 3.3.9-4
>Reporter: Steinar Bang
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> For these two projects
> * https://github.com/steinarb/authservice
> * https://github.com/steinarb/osgi-service
> line endings in the pom.xml files are messed up when I do
> {noformat}
> mvn release:prepare
> {noformat}
> or bump versions with e.g.
> {noformat}
> mvn --batch-mode release:update-versions -DdevelopmentVersion=1.0.2-SNAPSHOT
> {noformat}
> What happens to the line endings are:
> # First line stays at lf
> # Last line stays at lf
> # All of the intervening lines get crlf
> # The line endings were initially lf (at least they were meant to be)
> # I run the "mvn release:prepare" and "mvn:update-version" commands from a
> command line on Debian GNU/linux
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MSHARED-811) Improve handling of Metadata
[ https://issues.apache.org/jira/browse/MSHARED-811?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MSHARED-811. -- Resolution: Fixed Fixed in [46660e4b972066d25d0e1009a6b2b5ada7d55694|https://gitbox.apache.org/repos/asf?p=maven-artifact-transfer.git;a=commit;h=46660e4b972066d25d0e1009a6b2b5ada7d55694] > Improve handling of Metadata > > > Key: MSHARED-811 > URL: https://issues.apache.org/jira/browse/MSHARED-811 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-artifact-transfer >Affects Versions: maven-artifact-transfer-0.11.0 >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Major > Fix For: maven-artifact-transfer-0.12.0 > > > Current implementation doesn't support install/deploy of custom metadata such > as gpg signatures. > The related code contains a comment statement which needs to be implemented. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPMD-280) maven-pmd-plugin does not support targetJdk 12
[
https://issues.apache.org/jira/browse/MPMD-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807133#comment-16807133
]
Hudson commented on MPMD-280:
-
Build succeeded in Jenkins: Maven TLP » maven-pmd-plugin » master #3
See https://builds.apache.org/job/maven-box/job/maven-pmd-plugin/job/master/3/
> maven-pmd-plugin does not support targetJdk 12
> --
>
> Key: MPMD-280
> URL: https://issues.apache.org/jira/browse/MPMD-280
> Project: Maven PMD Plugin
> Issue Type: New Feature
> Components: PMD
>Affects Versions: 3.11.0
> Environment: openjdk version "12" 2019-03-19
> OpenJDK Runtime Environment 19.3 (build 12+33)
> OpenJDK 64-Bit Server VM 19.3 (build 12+33, mixed mode, sharing)
> Fedora release 29 (Twenty Nine)
>Reporter: Steven Schlansker
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.12.0
>
>
> Attempting to use maven-pmd-plugin with the newly GA openjdk12 and
> source/target level 12 results in:
>
> {code:java}
> Caused by: org.apache.maven.reporting.MavenReportException: Unsupported
> targetJdk value '12'.
> at org.apache.maven.plugins.pmd.PmdReport.getPMDConfiguration
> (PmdReport.java:672)
> at org.apache.maven.plugins.pmd.PmdReport.executePmd (PmdReport.java:390)
> at org.apache.maven.plugins.pmd.PmdReport.executePmdWithClassloader
> (PmdReport.java:355)
> at org.apache.maven.plugins.pmd.PmdReport.canGenerateReport
> (PmdReport.java:329)
> at org.apache.maven.reporting.AbstractMavenReport.execute
> (AbstractMavenReport.java:120{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MNG-6589) Document property maven.multiModuleProjectDirectory
[ https://issues.apache.org/jira/browse/MNG-6589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MNG-6589. Resolution: Won't Fix > Document property maven.multiModuleProjectDirectory > --- > > Key: MNG-6589 > URL: https://issues.apache.org/jira/browse/MNG-6589 > Project: Maven > Issue Type: Improvement > Components: Documentation: General >Affects Versions: 3.6.0 >Reporter: Arend v. Reinersdorff >Priority: Major > > I found out about maven.multiModuleProjectDirectory [on > Stackoverflow|https://stackoverflow.com/questions/29778262/what-is-maven-multimoduleprojectdirectory-used-for/29780763]. > This looks useful, but unfortunately there seems to be no documentation. > Could maybe be added in one of these locations: > * [https://cwiki.apache.org/confluence/display/MAVEN/Maven+Properties+Guide] > * > [http://maven.apache.org/ref/3.6.0/maven-model-builder/#Model_Interpolation] > Suggestion: > maven.multiModuleProjectDirectory - "The root directory of the multi module > build. Also set for single module builds. Since Maven 3.3.1" -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MPMD-275) Upgrade to PMD 6.13.0
[ https://issues.apache.org/jira/browse/MPMD-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807132#comment-16807132 ] Hudson commented on MPMD-275: - Build succeeded in Jenkins: Maven TLP » maven-pmd-plugin » master #3 See https://builds.apache.org/job/maven-box/job/maven-pmd-plugin/job/master/3/ > Upgrade to PMD 6.13.0 > - > > Key: MPMD-275 > URL: https://issues.apache.org/jira/browse/MPMD-275 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.12.0 > > > See PR [https://github.com/apache/maven-pmd-plugin/pull/5/files] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-pmd-plugin] adangel commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0
adangel commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0 URL: https://github.com/apache/maven-pmd-plugin/pull/6#discussion_r271019278 ## File path: src/it/MPMD-268-deprecated-rules/verify.groovy ## @@ -19,4 +19,6 @@ File buildLog = new File( basedir, 'build.log' ) assert buildLog.exists() -assert buildLog.text.contains( "[WARNING] Use Rule name category/java/codestyle.xml/ControlStatementBraces instead of the deprecated" ) +// Some versions output `WARNING:` and others `[WARNING]` Review comment: I want to fix a couple of other issues first, so it'll take a few days... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (MPMD-280) maven-pmd-plugin does not support targetJdk 12
[
https://issues.apache.org/jira/browse/MPMD-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Dangel resolved MPMD-280.
-
Resolution: Fixed
> maven-pmd-plugin does not support targetJdk 12
> --
>
> Key: MPMD-280
> URL: https://issues.apache.org/jira/browse/MPMD-280
> Project: Maven PMD Plugin
> Issue Type: New Feature
> Components: PMD
>Affects Versions: 3.11.0
> Environment: openjdk version "12" 2019-03-19
> OpenJDK Runtime Environment 19.3 (build 12+33)
> OpenJDK 64-Bit Server VM 19.3 (build 12+33, mixed mode, sharing)
> Fedora release 29 (Twenty Nine)
>Reporter: Steven Schlansker
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.12.0
>
>
> Attempting to use maven-pmd-plugin with the newly GA openjdk12 and
> source/target level 12 results in:
>
> {code:java}
> Caused by: org.apache.maven.reporting.MavenReportException: Unsupported
> targetJdk value '12'.
> at org.apache.maven.plugins.pmd.PmdReport.getPMDConfiguration
> (PmdReport.java:672)
> at org.apache.maven.plugins.pmd.PmdReport.executePmd (PmdReport.java:390)
> at org.apache.maven.plugins.pmd.PmdReport.executePmdWithClassloader
> (PmdReport.java:355)
> at org.apache.maven.plugins.pmd.PmdReport.canGenerateReport
> (PmdReport.java:329)
> at org.apache.maven.reporting.AbstractMavenReport.execute
> (AbstractMavenReport.java:120{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-pmd-plugin] oss92 commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0
oss92 commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0 URL: https://github.com/apache/maven-pmd-plugin/pull/6#discussion_r271018165 ## File path: src/it/MPMD-268-deprecated-rules/verify.groovy ## @@ -19,4 +19,6 @@ File buildLog = new File( basedir, 'build.log' ) assert buildLog.exists() -assert buildLog.text.contains( "[WARNING] Use Rule name category/java/codestyle.xml/ControlStatementBraces instead of the deprecated" ) +// Some versions output `WARNING:` and others `[WARNING]` Review comment: I have ran the tests twice using JDK11 and JDK12 on macOS 10.14.1. I don't know which output what now since I am afk. Thanks for the response. When do you expect the release of 6.13.0 change to maven? Cheers! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-pmd-plugin] adangel commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0
adangel commented on a change in pull request #6: [MPMD-275] update to PMD 6.13.0 URL: https://github.com/apache/maven-pmd-plugin/pull/6#discussion_r271016731 ## File path: src/it/MPMD-268-deprecated-rules/verify.groovy ## @@ -19,4 +19,6 @@ File buildLog = new File( basedir, 'build.log' ) assert buildLog.exists() -assert buildLog.text.contains( "[WARNING] Use Rule name category/java/codestyle.xml/ControlStatementBraces instead of the deprecated" ) +// Some versions output `WARNING:` and others `[WARNING]` Review comment: Where do you see this difference? Running m-pmd-p with PMD 6.13.0 on several platforms doesn't show this problem: https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-pmd-plugin/job/MPMD-275-PMD-6.13.0/ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MPMD-275) Upgrade to PMD 6.13.0
[ https://issues.apache.org/jira/browse/MPMD-275?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16807060#comment-16807060 ] Mohamed Osama commented on MPMD-275: [https://github.com/apache/maven-pmd-plugin/pull/6] > Upgrade to PMD 6.13.0 > - > > Key: MPMD-275 > URL: https://issues.apache.org/jira/browse/MPMD-275 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.12.0 > > > See PR [https://github.com/apache/maven-pmd-plugin/pull/5/files] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-pmd-plugin] oss92 opened a new pull request #6: update to PMD 6.13.0
oss92 opened a new pull request #6: update to PMD 6.13.0 URL: https://github.com/apache/maven-pmd-plugin/pull/6 - Update to PMD 6.13.0 - Adapt integration-tests as such This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MPMD-277) plugin tries to download local submodules from repo
[ https://issues.apache.org/jira/browse/MPMD-277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-277: Summary: plugin tries to download local submodules from repo (was: plugin tries to download local subdmodules from repo) > plugin tries to download local submodules from repo > --- > > Key: MPMD-277 > URL: https://issues.apache.org/jira/browse/MPMD-277 > Project: Maven PMD Plugin > Issue Type: Bug > Components: PMD >Affects Versions: 3.11.0 >Reporter: Sylvain >Priority: Major > > My bug seems kinda related to #MPMD-273, but 3.10.0 works for me, not 3.11.0. > > I'm trying to build a multi-module maven project with OpenJDK11 and Maven > 3.5.4. > The project works fine with maven-pmd-plugin 3.10.0, but with 3.11.0, I get > this error: > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-pmd-plugin:3.11.0:pmd (pmd) on project parent: > Execution pmd of goal org.apache.maven.plugins:maven-pmd-plugin:3.11.0:pmd > failed: org.apache.maven.reporting.MavenReportException: > org.eclipse.aether.resolution.DependencyResolutionException: Could not find > artifact com.incepto.cloud:api-common:jar:0.0.1-SNAPSHOT in spring-repo > (https://repo.spring.io/release) -> [Help 1] > > pmd-plugin doesn't have a dependency on api-common, it's the first submodule > maven tries to build. The problem doesn't occur if I skip pmd first and let > maven install the submodules in the local repo, then re-run the build. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MPMD-275) Upgrade to PMD 6.13.0
[ https://issues.apache.org/jira/browse/MPMD-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel updated MPMD-275: Summary: Upgrade to PMD 6.13.0 (was: Upgrade to PMD 6.9.0) > Upgrade to PMD 6.13.0 > - > > Key: MPMD-275 > URL: https://issues.apache.org/jira/browse/MPMD-275 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.12.0 > > > See PR [https://github.com/apache/maven-pmd-plugin/pull/5/files] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (MPMD-275) Upgrade to PMD 6.9.0
[ https://issues.apache.org/jira/browse/MPMD-275?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andreas Dangel reopened MPMD-275: - Changing this to upgrade to PMD 6.13.0 This is necessary for MPMD-280 > Upgrade to PMD 6.9.0 > > > Key: MPMD-275 > URL: https://issues.apache.org/jira/browse/MPMD-275 > Project: Maven PMD Plugin > Issue Type: Dependency upgrade > Components: CPD, PMD >Reporter: Andreas Dangel >Assignee: Andreas Dangel >Priority: Major > Fix For: 3.12.0 > > > See PR [https://github.com/apache/maven-pmd-plugin/pull/5/files] > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MPMD-280) maven-pmd-plugin does not support targetJdk 12
[
https://issues.apache.org/jira/browse/MPMD-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Dangel updated MPMD-280:
Fix Version/s: 3.12.0
> maven-pmd-plugin does not support targetJdk 12
> --
>
> Key: MPMD-280
> URL: https://issues.apache.org/jira/browse/MPMD-280
> Project: Maven PMD Plugin
> Issue Type: New Feature
> Components: PMD
>Affects Versions: 3.11.0
> Environment: openjdk version "12" 2019-03-19
> OpenJDK Runtime Environment 19.3 (build 12+33)
> OpenJDK 64-Bit Server VM 19.3 (build 12+33, mixed mode, sharing)
> Fedora release 29 (Twenty Nine)
>Reporter: Steven Schlansker
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.12.0
>
>
> Attempting to use maven-pmd-plugin with the newly GA openjdk12 and
> source/target level 12 results in:
>
> {code:java}
> Caused by: org.apache.maven.reporting.MavenReportException: Unsupported
> targetJdk value '12'.
> at org.apache.maven.plugins.pmd.PmdReport.getPMDConfiguration
> (PmdReport.java:672)
> at org.apache.maven.plugins.pmd.PmdReport.executePmd (PmdReport.java:390)
> at org.apache.maven.plugins.pmd.PmdReport.executePmdWithClassloader
> (PmdReport.java:355)
> at org.apache.maven.plugins.pmd.PmdReport.canGenerateReport
> (PmdReport.java:329)
> at org.apache.maven.reporting.AbstractMavenReport.execute
> (AbstractMavenReport.java:120{code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-shade-plugin] mkarg commented on issue #17: [MSHADE-313] - Keep Services
mkarg commented on issue #17: [MSHADE-313] - Keep Services URL: https://github.com/apache/maven-shade-plugin/pull/17#issuecomment-478675008 @rfscholte Okay so I will remove the extra parameter. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-shade-plugin] rfscholte commented on issue #17: [MSHADE-313] - Keep Services
rfscholte commented on issue #17: [MSHADE-313] - Keep Services URL: https://github.com/apache/maven-shade-plugin/pull/17#issuecomment-478672785 I see no reason for an extra parameter. If an implementation of a service is provided, all its depending classes should be added, always. So I'd suggest to simplify that part of the code :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-compiler-plugin] rfscholte commented on issue #3: [MCOMPILER-205] fixes incremental compilation
rfscholte commented on issue #3: [MCOMPILER-205] fixes incremental compilation URL: https://github.com/apache/maven-compiler-plugin/pull/3#issuecomment-478671975 > What needs to be done to move this forward? Did you read the comments of https://issues.apache.org/jira/browse/MCOMPILER-205 ? So in general it works as designed. The root cause is a missing feature of https://codehaus-plexus.github.io/plexus-compiler/ where you can define is a specific compiler implementation has incremental support. Once that is available we can start applying it to this plugin. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-resolver] rfscholte commented on a change in pull request #22: Introduce caching for tracking files.
rfscholte commented on a change in pull request #22: Introduce caching for
tracking files.
URL: https://github.com/apache/maven-resolver/pull/22#discussion_r270969267
##
File path:
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/TrackingFileManager.java
##
@@ -131,52 +207,145 @@ public Properties update( File file, Map updates )
raf.seek( 0 );
raf.write( stream.toByteArray() );
raf.setLength( raf.getFilePointer() );
+
+this.entryTs = System.currentTimeMillis();
+this.lastModifiedTs = file.lastModified();
}
catch ( IOException e )
{
LOGGER.warn( "Failed to write tracking file {}", file, e );
}
finally
{
-release( lock, file );
-close( raf, file );
+release( lock );
+close( raf );
}
-}
-return props;
-}
+return props;
+}
-private void release( FileLock lock, File file )
-{
-if ( lock != null )
+private void release( FileLock lock )
{
-try
+if ( lock != null )
{
-lock.release();
+try
+{
+lock.release();
+}
+catch ( IOException e )
+{
+LOGGER.warn( "Error releasing lock for tracking file {}",
file, e );
+}
}
-catch ( IOException e )
+}
+
+private void close( Closeable closeable )
+{
+if ( closeable != null )
{
-LOGGER.warn( "Error releasing lock for tracking file {}",
file, e );
+try
+{
+closeable.close();
+}
+catch ( IOException e )
+{
+LOGGER.warn( "Error closing tracking file {}", file, e );
+}
}
}
-}
-private void close( Closeable closeable, File file )
-{
-if ( closeable != null )
+private FileLock lock( FileChannel channel, long size, boolean shared
) throws IOException
{
-try
+FileLock lock = null;
+
+for ( int attempts = 8; attempts >= 0; attempts-- )
{
-closeable.close();
+try
+{
+lock = channel.lock( 0, size, shared );
+break;
+}
+catch ( OverlappingFileLockException e )
+{
+if ( attempts <= 0 )
+{
+throw (IOException) new IOException().initCause( e );
+}
+try
+{
+Thread.sleep( 50L );
+}
+catch ( InterruptedException e1 )
+{
+Thread.currentThread().interrupt();
+}
+}
}
-catch ( IOException e )
+
+if ( lock == null )
{
-LOGGER.warn( "Error closing tracking file {}", file, e );
+throw new IOException( "Could not lock file" );
}
+
+return lock;
+}
+
+}
+
+/**
+ * Canonicalized files by their path (the same canonicalized file may be
registered under different paths). This
+ * cache is especially useful on Windows platform where canonicalization
is relatively expensive.
+ */
+private static ConcurrentHashMap canonicalizedCache = new
ConcurrentHashMap<>();
Review comment:
In case of a cache I would prefer `WeakHashMap` +
`Collections.synchronizedMap`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-javadoc-plugin] rfscholte merged pull request #24: Add missing `@since` tags to sourceFile[Includes|Excludes]
rfscholte merged pull request #24: Add missing `@since` tags to sourceFile[Includes|Excludes] URL: https://github.com/apache/maven-javadoc-plugin/pull/24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-javadoc-plugin] britter opened a new pull request #24: Add missing `@since` tags to sourceFile[Includes|Excludes]
britter opened a new pull request #24: Add missing `@since` tags to sourceFile[Includes|Excludes] URL: https://github.com/apache/maven-javadoc-plugin/pull/24 Simple doc fix. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (SUREFIRE-1427) Surefire-plugin throws NoClassDefFoundError with static initialiser
[
https://issues.apache.org/jira/browse/SUREFIRE-1427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806780#comment-16806780
]
Tibor Digana commented on SUREFIRE-1427:
[~mgai...@hotmail.com]
This stil does not help me.
I have to see the "test classpath" from the logs.
Run the build "mvn -X test" and the surefire prints classpaths. There are
several classpaths, you will see. Pls check it. And which jar is missing from
the logs?
> Surefire-plugin throws NoClassDefFoundError with static initialiser
> ---
>
> Key: SUREFIRE-1427
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1427
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 2.20
> Environment: jdk 1.8
> maven 3.3.3
>Reporter: Martin Gainty
>Assignee: Tibor Digana
>Priority: Minor
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> when maven-surefire-plugin encounters static initialiser such as
> public class AxisDescription {
> org.apache.axiom.om.OMFactory omFactory =
> org.apache.axiom.om.OMAbstractFactory.getOMFactory();
> //surefire throws NoClassDefFoundError on OMAbstractFactory ?!?!?
> //but if i remove static initialiser to wait until runtime to load
> OMAbstractFactory it loads ok
> org.apache.axis2.description.AxisDescription:
> public void setDocumentation(String documentation) {
> org.apache.axiom.om.OMFactory omFactory =
> org.apache.axiom.om.OMAbstractFactory.getOMFactory();
> if (!"".equals(documentation)) {
> this.documentation = omFactory.createOMText(documentation);
> }
> }
> why does surefire not find classes referenced by static initialiser?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path
[
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806761#comment-16806761
]
Yoann Rodière commented on SUREFIRE-1570:
-
I just experienced this bug, and investigated a little bit. Apparently the
failsafe plugin never considers the modulepath, because it is unable to detect
that a given JAR contains {{module-info.class}}.
See how the module descriptor is retrieved in
{{org.apache.maven.plugin.surefire.AbstractSurefireMojo}}:
{code:java}
private File getModuleDescriptor()
{
return new File( getClassesDirectory(), "module-info.class" );
}
{code}
For the failsafe plugin, {{getClassesDirectory()}} returns the path of the JAR,
not the path of a directory. As a result, {{getModuleDescriptor().exists()}},
called in other methods on this file, ends up being always false, because
{{File.exists()}} does not handle JAR/ZIP file traversal transparently.
> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Robert Scholte
>Priority: Major
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO]
>
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO]
>
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO]
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @
> mavenproject20 ---
> [WARNING]
>
> [WARNING] * Required filename-based automodules detected. Please don't
> publish this project to a public artifact repository! *
> [WARNING]
>
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING]
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
> module name component Mavenproject20 should avoid terminal digits
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO]
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20
> ---
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar:
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests)
> @ mavenproject20 ---
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
> module jdk.httpserver
> module java.xml
> module javafx.controls
> module java.datatransfer
> module jdk.javadoc
> module jdk.jconsole
> module java.instrument
> module jdk.packager
> module jdk.deploy
> module jdk.jfr
> module jdk.management
> module jdk.charsets
> module oracle.net
> module jdk.jdeps
> module java.sql.rowset
> module jdk.net
> module jdk.accessibility
> module jdk.attach
> module jdk.internal.le
> module jdk.snmp
> module java.base
> module jdk.plugin
> module jdk.dynalink
> module jdk.naming.rmi
> module jdk.internal.opt
> module java.management.rmi
> module jdk.management.jfr
> module javafx.swing
> module jdk.editpad
> module jdk.crypto.ec
> module jdk.javaws
> module jdk.jstatd
> module jdk.management.agent
> module
[jira] [Commented] (MNG-6618) Maven doesn't export org.slf4j.event.Level
[
https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806741#comment-16806741
]
Viacheslav Yakunin commented on MNG-6618:
-
[~michael-o], [~slachiewicz], I checked and it is working. Thanks a lot for
fast fix, I appreciate!
> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6618
> URL: https://issues.apache.org/jira/browse/MNG-6618
> Project: Maven
> Issue Type: Task
>Affects Versions: 3.6.0
>Reporter: Viacheslav Yakunin
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>
> Hi, this is the same issue as
> [MNG-6360|https://issues.apache.org/jira/browse/MNG-6360]. Unfortunately I
> was not able to reopen it so I am creating new one.
> I was able to reproduce it when I tried to create maven plugin for running
> kafka broker during integration tests. Kafka refers to org.slf4j.event.Level
> and this causes following exception during plugin execution.
> {code:java}
> [ERROR] [KafkaServer id=1] Fatal error during KafkaServer shutdown.
> java.lang.NoClassDefFoundError: org/slf4j/event/Level
> at
> kafka.utils.CoreUtils$.swallow$default$3(CoreUtils.scala:84)
> at kafka.server.KafkaServer.shutdown(KafkaServer.scala:567)
> at
> net.sla.buildtools.kafka.maven.plugin.SingletonLauncher.stop(SingletonLauncher.java:73)
> at
> net.sla.buildtools.kafka.maven.plugin.StopKafkaBrokerMojo.execute(StopKafkaBrokerMojo.java:18)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> com.intellij.rt.execution.CommandLineWrapper.main(CommandLineWrapper.java:65)
> Caused by: java.lang.ClassNotFoundException: org.slf4j.event.Level
> at
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
> ... 32 more
>
[jira] [Created] (MNGSITE-369) Improve docs about dependency resolution within Multi module build
Karl Heinz Marbaise created MNGSITE-369: --- Summary: Improve docs about dependency resolution within Multi module build Key: MNGSITE-369 URL: https://issues.apache.org/jira/browse/MNGSITE-369 Project: Maven Project Web Site Issue Type: Improvement Reporter: Karl Heinz Marbaise We should enhance the docs about how dependencies are resolved within a multi module build. See for details: https://stackoverflow.com/questions/55433668/maven-multi-module-dependency-resolution/55434795?noredirect=1#comment97621312_55434795 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MRELEASE-1021) release:prepare and release:update-version sets line endings to crlf for all lines except the first and last lines of the pom.xml files
[
https://issues.apache.org/jira/browse/MRELEASE-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MRELEASE-1021:
-
Fix Version/s: waiting-for-feedback
> release:prepare and release:update-version sets line endings to crlf for all
> lines except the first and last lines of the pom.xml files
> ---
>
> Key: MRELEASE-1021
> URL: https://issues.apache.org/jira/browse/MRELEASE-1021
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3
> Environment: debian 9.8 "stretch", amd64, openjdk 8u212-b01-1~deb9u1,
> maven 3.3.9-4
>Reporter: Steinar Bang
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> For these two projects
> * https://github.com/steinarb/authservice
> * https://github.com/steinarb/osgi-service
> line endings in the pom.xml files are messed up when I do
> {noformat}
> mvn release:prepare
> {noformat}
> or bump versions with e.g.
> {noformat}
> mvn --batch-mode release:update-versions -DdevelopmentVersion=1.0.2-SNAPSHOT
> {noformat}
> What happens to the line endings are:
> # First line stays at lf
> # Last line stays at lf
> # All of the intervening lines get crlf
> # The line endings were initially lf (at least they were meant to be)
> # I run the "mvn release:prepare" and "mvn:update-version" commands from a
> command line on Debian GNU/linux
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MRELEASE-1021) release:prepare and release:update-version sets line endings to crlf for all lines except the first and last lines of the pom.xml files
[
https://issues.apache.org/jira/browse/MRELEASE-1021?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806662#comment-16806662
]
Michael Osipov commented on MRELEASE-1021:
--
Did you try with Maven 3.6.0?
> release:prepare and release:update-version sets line endings to crlf for all
> lines except the first and last lines of the pom.xml files
> ---
>
> Key: MRELEASE-1021
> URL: https://issues.apache.org/jira/browse/MRELEASE-1021
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare, update-versions
>Affects Versions: 2.5.3
> Environment: debian 9.8 "stretch", amd64, openjdk 8u212-b01-1~deb9u1,
> maven 3.3.9-4
>Reporter: Steinar Bang
>Priority: Major
>
> For these two projects
> * https://github.com/steinarb/authservice
> * https://github.com/steinarb/osgi-service
> line endings in the pom.xml files are messed up when I do
> {noformat}
> mvn release:prepare
> {noformat}
> or bump versions with e.g.
> {noformat}
> mvn --batch-mode release:update-versions -DdevelopmentVersion=1.0.2-SNAPSHOT
> {noformat}
> What happens to the line endings are:
> # First line stays at lf
> # Last line stays at lf
> # All of the intervening lines get crlf
> # The line endings were initially lf (at least they were meant to be)
> # I run the "mvn release:prepare" and "mvn:update-version" commands from a
> command line on Debian GNU/linux
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6618) Maven doesn't export org.slf4j.event.Level
[
https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806640#comment-16806640
]
Hudson commented on MNG-6618:
-
Build succeeded in Jenkins: Maven TLP » maven » master #189
See https://builds.apache.org/job/maven-box/job/maven/job/master/189/
> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6618
> URL: https://issues.apache.org/jira/browse/MNG-6618
> Project: Maven
> Issue Type: Task
>Affects Versions: 3.6.0
>Reporter: Viacheslav Yakunin
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>
> Hi, this is the same issue as
> [MNG-6360|https://issues.apache.org/jira/browse/MNG-6360]. Unfortunately I
> was not able to reopen it so I am creating new one.
> I was able to reproduce it when I tried to create maven plugin for running
> kafka broker during integration tests. Kafka refers to org.slf4j.event.Level
> and this causes following exception during plugin execution.
> {code:java}
> [ERROR] [KafkaServer id=1] Fatal error during KafkaServer shutdown.
> java.lang.NoClassDefFoundError: org/slf4j/event/Level
> at
> kafka.utils.CoreUtils$.swallow$default$3(CoreUtils.scala:84)
> at kafka.server.KafkaServer.shutdown(KafkaServer.scala:567)
> at
> net.sla.buildtools.kafka.maven.plugin.SingletonLauncher.stop(SingletonLauncher.java:73)
> at
> net.sla.buildtools.kafka.maven.plugin.StopKafkaBrokerMojo.execute(StopKafkaBrokerMojo.java:18)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> com.intellij.rt.execution.CommandLineWrapper.main(CommandLineWrapper.java:65)
> Caused by: java.lang.ClassNotFoundException: org.slf4j.event.Level
> at
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
> ... 32 more
[jira] [Closed] (MNG-6618) Maven doesn't export org.slf4j.event.Level
[
https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz closed MNG-6618.
-
Resolution: Fixed
> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6618
> URL: https://issues.apache.org/jira/browse/MNG-6618
> Project: Maven
> Issue Type: Task
>Affects Versions: 3.6.0
>Reporter: Viacheslav Yakunin
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>
> Hi, this is the same issue as
> [MNG-6360|https://issues.apache.org/jira/browse/MNG-6360]. Unfortunately I
> was not able to reopen it so I am creating new one.
> I was able to reproduce it when I tried to create maven plugin for running
> kafka broker during integration tests. Kafka refers to org.slf4j.event.Level
> and this causes following exception during plugin execution.
> {code:java}
> [ERROR] [KafkaServer id=1] Fatal error during KafkaServer shutdown.
> java.lang.NoClassDefFoundError: org/slf4j/event/Level
> at
> kafka.utils.CoreUtils$.swallow$default$3(CoreUtils.scala:84)
> at kafka.server.KafkaServer.shutdown(KafkaServer.scala:567)
> at
> net.sla.buildtools.kafka.maven.plugin.SingletonLauncher.stop(SingletonLauncher.java:73)
> at
> net.sla.buildtools.kafka.maven.plugin.StopKafkaBrokerMojo.execute(StopKafkaBrokerMojo.java:18)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> com.intellij.rt.execution.CommandLineWrapper.main(CommandLineWrapper.java:65)
> Caused by: java.lang.ClassNotFoundException: org.slf4j.event.Level
> at
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
> ... 32 more
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6618) Maven doesn't export org.slf4j.event.Level
[
https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806594#comment-16806594
]
Sylwester Lachiewicz commented on MNG-6618:
---
Fixed with
[0ba5753c17a37b96a42df39a197e1c607a224b4d|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=0ba5753c17a37b96a42df39a197e1c607a224b4d]
> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6618
> URL: https://issues.apache.org/jira/browse/MNG-6618
> Project: Maven
> Issue Type: Task
>Affects Versions: 3.6.0
>Reporter: Viacheslav Yakunin
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>
> Hi, this is the same issue as
> [MNG-6360|https://issues.apache.org/jira/browse/MNG-6360]. Unfortunately I
> was not able to reopen it so I am creating new one.
> I was able to reproduce it when I tried to create maven plugin for running
> kafka broker during integration tests. Kafka refers to org.slf4j.event.Level
> and this causes following exception during plugin execution.
> {code:java}
> [ERROR] [KafkaServer id=1] Fatal error during KafkaServer shutdown.
> java.lang.NoClassDefFoundError: org/slf4j/event/Level
> at
> kafka.utils.CoreUtils$.swallow$default$3(CoreUtils.scala:84)
> at kafka.server.KafkaServer.shutdown(KafkaServer.scala:567)
> at
> net.sla.buildtools.kafka.maven.plugin.SingletonLauncher.stop(SingletonLauncher.java:73)
> at
> net.sla.buildtools.kafka.maven.plugin.StopKafkaBrokerMojo.execute(StopKafkaBrokerMojo.java:18)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> com.intellij.rt.execution.CommandLineWrapper.main(CommandLineWrapper.java:65)
> Caused by: java.lang.ClassNotFoundException: org.slf4j.event.Level
> at
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
> at
>
[jira] [Updated] (MNG-6618) Maven doesn't export org.slf4j.event.Level
[
https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MNG-6618:
--
Priority: Major (was: Blocker)
> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6618
> URL: https://issues.apache.org/jira/browse/MNG-6618
> Project: Maven
> Issue Type: Task
>Affects Versions: 3.6.0
>Reporter: Viacheslav Yakunin
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: 3.6.1
>
>
> Hi, this is the same issue as
> [MNG-6360|https://issues.apache.org/jira/browse/MNG-6360]. Unfortunately I
> was not able to reopen it so I am creating new one.
> I was able to reproduce it when I tried to create maven plugin for running
> kafka broker during integration tests. Kafka refers to org.slf4j.event.Level
> and this causes following exception during plugin execution.
> {code:java}
> [ERROR] [KafkaServer id=1] Fatal error during KafkaServer shutdown.
> java.lang.NoClassDefFoundError: org/slf4j/event/Level
> at
> kafka.utils.CoreUtils$.swallow$default$3(CoreUtils.scala:84)
> at kafka.server.KafkaServer.shutdown(KafkaServer.scala:567)
> at
> net.sla.buildtools.kafka.maven.plugin.SingletonLauncher.stop(SingletonLauncher.java:73)
> at
> net.sla.buildtools.kafka.maven.plugin.StopKafkaBrokerMojo.execute(StopKafkaBrokerMojo.java:18)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> com.intellij.rt.execution.CommandLineWrapper.main(CommandLineWrapper.java:65)
> Caused by: java.lang.ClassNotFoundException: org.slf4j.event.Level
> at
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
> ... 32 more
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MNG-6618) Maven doesn't export org.slf4j.event.Level
[
https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MNG-6618:
--
Fix Version/s: (was: 3.6.x-candidate)
(was: waiting-for-feedback)
3.6.1
> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6618
> URL: https://issues.apache.org/jira/browse/MNG-6618
> Project: Maven
> Issue Type: Task
>Affects Versions: 3.6.0
>Reporter: Viacheslav Yakunin
>Assignee: Sylwester Lachiewicz
>Priority: Blocker
> Fix For: 3.6.1
>
>
> Hi, this is the same issue as
> [MNG-6360|https://issues.apache.org/jira/browse/MNG-6360]. Unfortunately I
> was not able to reopen it so I am creating new one.
> I was able to reproduce it when I tried to create maven plugin for running
> kafka broker during integration tests. Kafka refers to org.slf4j.event.Level
> and this causes following exception during plugin execution.
> {code:java}
> [ERROR] [KafkaServer id=1] Fatal error during KafkaServer shutdown.
> java.lang.NoClassDefFoundError: org/slf4j/event/Level
> at
> kafka.utils.CoreUtils$.swallow$default$3(CoreUtils.scala:84)
> at kafka.server.KafkaServer.shutdown(KafkaServer.scala:567)
> at
> net.sla.buildtools.kafka.maven.plugin.SingletonLauncher.stop(SingletonLauncher.java:73)
> at
> net.sla.buildtools.kafka.maven.plugin.StopKafkaBrokerMojo.execute(StopKafkaBrokerMojo.java:18)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> com.intellij.rt.execution.CommandLineWrapper.main(CommandLineWrapper.java:65)
> Caused by: java.lang.ClassNotFoundException: org.slf4j.event.Level
> at
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:239)
> ... 32 more
> {code}
--
This
[jira] [Commented] (MNG-6618) Maven doesn't export org.slf4j.event.Level
[
https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806533#comment-16806533
]
Michael Osipov commented on MNG-6618:
-
[~slachiewicz], let's merge it and see what happens. I guess it was proven to
work earlier. Karl wants to continue on the release.
> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6618
> URL: https://issues.apache.org/jira/browse/MNG-6618
> Project: Maven
> Issue Type: Task
>Affects Versions: 3.6.0
>Reporter: Viacheslav Yakunin
>Assignee: Sylwester Lachiewicz
>Priority: Blocker
> Fix For: 3.6.x-candidate, waiting-for-feedback
>
>
> Hi, this is the same issue as
> [MNG-6360|https://issues.apache.org/jira/browse/MNG-6360]. Unfortunately I
> was not able to reopen it so I am creating new one.
> I was able to reproduce it when I tried to create maven plugin for running
> kafka broker during integration tests. Kafka refers to org.slf4j.event.Level
> and this causes following exception during plugin execution.
> {code:java}
> [ERROR] [KafkaServer id=1] Fatal error during KafkaServer shutdown.
> java.lang.NoClassDefFoundError: org/slf4j/event/Level
> at
> kafka.utils.CoreUtils$.swallow$default$3(CoreUtils.scala:84)
> at kafka.server.KafkaServer.shutdown(KafkaServer.scala:567)
> at
> net.sla.buildtools.kafka.maven.plugin.SingletonLauncher.stop(SingletonLauncher.java:73)
> at
> net.sla.buildtools.kafka.maven.plugin.StopKafkaBrokerMojo.execute(StopKafkaBrokerMojo.java:18)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> com.intellij.rt.execution.CommandLineWrapper.main(CommandLineWrapper.java:65)
> Caused by: java.lang.ClassNotFoundException: org.slf4j.event.Level
> at
> org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy.loadClass(SelfFirstStrategy.java:50)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.unsynchronizedLoadClass(ClassRealm.java:271)
> at
> org.codehaus.plexus.classworlds.realm.ClassRealm.loadClass(ClassRealm.java:247)
> at
>
[jira] [Comment Edited] (MNG-6618) Maven doesn't export org.slf4j.event.Level
[
https://issues.apache.org/jira/browse/MNG-6618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16805227#comment-16805227
]
Michael Osipov edited comment on MNG-6618 at 4/1/19 8:54 AM:
-
All existing ITs have gone well, but we do not have much that covers slf4j.
[~viacheslav.yakunin] please check and confirm if Maven build from branch
[https://github.com/apache/maven/tree/MNG-6618]
You can also try to use artifacts from our CI:
[https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6618/1/artifact/org/apache/maven/apache-maven/3.6.1-SNAPSHOT/]
was (Author: slachiewicz):
All existing ITs have gone well, but we do not have much that covers slf4j.
[~viacheslav.yakunin] please check and confirm if Maven build from brach
[https://github.com/apache/maven/tree/MNG-6618]
You can also try to use artifacts from our CI:
[https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven/job/MNG-6618/1/artifact/org/apache/maven/apache-maven/3.6.1-SNAPSHOT/]
> Maven doesn't export org.slf4j.event.Level
> --
>
> Key: MNG-6618
> URL: https://issues.apache.org/jira/browse/MNG-6618
> Project: Maven
> Issue Type: Task
>Affects Versions: 3.6.0
>Reporter: Viacheslav Yakunin
>Assignee: Sylwester Lachiewicz
>Priority: Blocker
> Fix For: 3.6.x-candidate, waiting-for-feedback
>
>
> Hi, this is the same issue as
> [MNG-6360|https://issues.apache.org/jira/browse/MNG-6360]. Unfortunately I
> was not able to reopen it so I am creating new one.
> I was able to reproduce it when I tried to create maven plugin for running
> kafka broker during integration tests. Kafka refers to org.slf4j.event.Level
> and this causes following exception during plugin execution.
> {code:java}
> [ERROR] [KafkaServer id=1] Fatal error during KafkaServer shutdown.
> java.lang.NoClassDefFoundError: org/slf4j/event/Level
> at
> kafka.utils.CoreUtils$.swallow$default$3(CoreUtils.scala:84)
> at kafka.server.KafkaServer.shutdown(KafkaServer.scala:567)
> at
> net.sla.buildtools.kafka.maven.plugin.SingletonLauncher.stop(SingletonLauncher.java:73)
> at
> net.sla.buildtools.kafka.maven.plugin.StopKafkaBrokerMojo.execute(StopKafkaBrokerMojo.java:18)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:134)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:207)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
> at
> org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
> at
> org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> at org.codehaus.classworlds.Launcher.main(Launcher.java:47)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
>
[jira] [Commented] (MNG-6605) Allow to suppress download messages in interactive mode
[
https://issues.apache.org/jira/browse/MNG-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806525#comment-16806525
]
Hudson commented on MNG-6605:
-
Build succeeded in Jenkins: Maven TLP » maven » master #188
See https://builds.apache.org/job/maven-box/job/maven/job/master/188/
> Allow to suppress download messages in interactive mode
> ---
>
> Key: MNG-6605
> URL: https://issues.apache.org/jira/browse/MNG-6605
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.6.0
>Reporter: Gunnar Wagenknecht
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.1
>
> Attachments: 2019-03-06_14-06-09.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When running Maven in batch mode (with option {{-B}}) it's possible to
> suppress download messages using
> "{{-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn}}"
> Example:
> {{mvn clean install -B
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn}}
> When leaving out the {{-B}} option this no longer works.
> *Example:*
> {noformat}
> export MAVEN_OPTS='-Xmx1g
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
> -Dorg.slf4j.simpleLogger.showDateTime=true
> -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss'
> mvn clean install
> {noformat}
> Prints out time stamps as configured but does not suppress download progress
> messages.
> *Expected:*
> Suppressing "Downloaded" messages from the console output should be possible
> without requiring the "{{--batch-mode}}" command line argument.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MNG-6577) pom.xml: Uncaught IllegalArgumentException when parsing unicode entity ref
[
https://issues.apache.org/jira/browse/MNG-6577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6577.
---
> pom.xml: Uncaught IllegalArgumentException when parsing unicode entity ref
> ---
>
> Key: MNG-6577
> URL: https://issues.apache.org/jira/browse/MNG-6577
> Project: Maven
> Issue Type: Bug
> Components: POM
>Affects Versions: 3.5.4, 3.6.0
>Reporter: Rohan Padhye
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.6.1
>
>
> Sample Maven {{pom.xml}} below:
> {code:java}
> {code}
> 0xFF is not a valid Unicode codepoint. This leads to the following
> uncaught exception arising from plexus:
> {code:java}
> Caused by: java.lang.IllegalArgumentException at
> org.codehaus.plexus.util.xml.pull.MXParser.toChars (MXParser.java:4023) at
> org.codehaus.plexus.util.xml.pull.MXParser.parseEntityRef
> (MXParser.java:2727) at
> org.codehaus.plexus.util.xml.pull.MXParser.parseAttribute
> (MXParser.java:2522) at
> org.codehaus.plexus.util.xml.pull.MXParser.parseStartTag (MXParser.java:2218)
> at org.codehaus.plexus.util.xml.pull.MXParser.parseProlog
> (MXParser.java:1801) at org.codehaus.plexus.util.xml.pull.MXParser.nextImpl
> (MXParser.java:1698) at org.codehaus.plexus.util.xml.pull.MXParser.next
> (MXParser.java:1317) at org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read
> (MavenXpp3ReaderEx.java:4417) at
> org.apache.maven.model.io.xpp3.MavenXpp3ReaderEx.read
> (MavenXpp3ReaderEx.java:598) at
> org.apache.maven.model.io.DefaultModelReader.read
> (DefaultModelReader.java:105) at
> org.apache.maven.model.io.DefaultModelReader.read (DefaultModelReader.java:82)
> ...{code}
> I'm guessing the expected behavior is to throw an {{XMLPullParserException}}
> instead, to signal an unparsable entity.
> Found using [JQF|https://github.com/rohanpadhye/jqf].
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven] asfgit closed pull request #239: MNG-6605 Unable to suppress download messages in interactive mode
asfgit closed pull request #239: MNG-6605 Unable to suppress download messages in interactive mode URL: https://github.com/apache/maven/pull/239 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (MNG-6605) Allow to suppress download messages in interactive mode
[
https://issues.apache.org/jira/browse/MNG-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MNG-6605.
---
Resolution: Fixed
Fixed with
[95401cf7a606daa0982c3fe5a5928cd466230995|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=95401cf7a606daa0982c3fe5a5928cd466230995].
> Allow to suppress download messages in interactive mode
> ---
>
> Key: MNG-6605
> URL: https://issues.apache.org/jira/browse/MNG-6605
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.6.0
>Reporter: Gunnar Wagenknecht
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.1
>
> Attachments: 2019-03-06_14-06-09.png
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> When running Maven in batch mode (with option {{-B}}) it's possible to
> suppress download messages using
> "{{-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn}}"
> Example:
> {{mvn clean install -B
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn}}
> When leaving out the {{-B}} option this no longer works.
> *Example:*
> {noformat}
> export MAVEN_OPTS='-Xmx1g
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
> -Dorg.slf4j.simpleLogger.showDateTime=true
> -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss'
> mvn clean install
> {noformat}
> Prints out time stamps as configured but does not suppress download progress
> messages.
> *Expected:*
> Suppressing "Downloaded" messages from the console output should be possible
> without requiring the "{{--batch-mode}}" command line argument.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MNG-6605) Allow to suppress download messages in interactive mode
[
https://issues.apache.org/jira/browse/MNG-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6605:
Fix Version/s: (was: waiting-for-feedback)
3.6.1
> Allow to suppress download messages in interactive mode
> ---
>
> Key: MNG-6605
> URL: https://issues.apache.org/jira/browse/MNG-6605
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.6.0
>Reporter: Gunnar Wagenknecht
>Priority: Major
> Fix For: 3.6.1
>
> Attachments: 2019-03-06_14-06-09.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When running Maven in batch mode (with option {{-B}}) it's possible to
> suppress download messages using
> "{{-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn}}"
> Example:
> {{mvn clean install -B
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn}}
> When leaving out the {{-B}} option this no longer works.
> *Example:*
> {noformat}
> export MAVEN_OPTS='-Xmx1g
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
> -Dorg.slf4j.simpleLogger.showDateTime=true
> -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss'
> mvn clean install
> {noformat}
> Prints out time stamps as configured but does not suppress download progress
> messages.
> *Expected:*
> Suppressing "Downloaded" messages from the console output should be possible
> without requiring the "{{--batch-mode}}" command line argument.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MNG-6605) Allow to suppress download messages in interactive mode
[
https://issues.apache.org/jira/browse/MNG-6605?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MNG-6605:
---
Assignee: Michael Osipov
> Allow to suppress download messages in interactive mode
> ---
>
> Key: MNG-6605
> URL: https://issues.apache.org/jira/browse/MNG-6605
> Project: Maven
> Issue Type: Improvement
> Components: Command Line
>Affects Versions: 3.6.0
>Reporter: Gunnar Wagenknecht
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.6.1
>
> Attachments: 2019-03-06_14-06-09.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> When running Maven in batch mode (with option {{-B}}) it's possible to
> suppress download messages using
> "{{-Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn}}"
> Example:
> {{mvn clean install -B
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn}}
> When leaving out the {{-B}} option this no longer works.
> *Example:*
> {noformat}
> export MAVEN_OPTS='-Xmx1g
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.cli.transfer.Slf4jMavenTransferListener=warn
> -Dorg.slf4j.simpleLogger.showDateTime=true
> -Dorg.slf4j.simpleLogger.dateTimeFormat=HH:mm:ss'
> mvn clean install
> {noformat}
> Prints out time stamps as configured but does not suppress download progress
> messages.
> *Expected:*
> Suppressing "Downloaded" messages from the console output should be possible
> without requiring the "{{--batch-mode}}" command line argument.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6255) Maven script cannot parse jvm.config with CRLF
[
https://issues.apache.org/jira/browse/MNG-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806456#comment-16806456
]
Hudson commented on MNG-6255:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5868 #26
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5868/26/
> Maven script cannot parse jvm.config with CRLF
> --
>
> Key: MNG-6255
> URL: https://issues.apache.org/jira/browse/MNG-6255
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 7 with MINGW64 environment via Git for Windows
> 0.1.1 including GNU coreutils and bash 4.4.12
>Reporter: Andrew Kennedy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.5.3
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A project with a {{.mvn/jvm.config}} file that has *CRLF* line endings will
> not parse it correctly. The script uses the {{tr}} command to change *LF* to
> space, but this leaves *CR* behind. For example, with the {{jvm.config}} file
> containing the text {{-Xmx1024m -Xms512m}} followed by *CRLF*, the following
> error message is printed:
> {code}
> $ mvn install
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> Invalid initial heap size: -Xms512m
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6506) Mojos are unable to load package annotations on Java >= 9
[
https://issues.apache.org/jira/browse/MNG-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806455#comment-16806455
]
Hudson commented on MNG-6506:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5868 #26
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5868/26/
> Mojos are unable to load package annotations on Java >= 9
> -
>
> Key: MNG-6506
> URL: https://issues.apache.org/jira/browse/MNG-6506
> Project: Maven
> Issue Type: Bug
> Components: Class Loading
>Affects Versions: 3.6.0
>Reporter: Andreas Veithen
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.6.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> On Java 9 and above, calls to {{java.lang.Package.getAnnotation(Class)}} from
> within a Mojo always return {{null}} (unless the {{package-info}} class has
> been loaded by some other means before).
> The reason appears to be an incompatibility between Java 9 and Plexus
> Classworlds:
> * Java 9 ultimately calls {{findClass}} (instead of {{loadClass}}) to get the
> {{package-info}} class.
> * The {{findClass}} implementation in {{ClassRealm}} always throws
> {{ClassNotFoundException}}:
> https://github.com/codehaus-plexus/plexus-classworlds/blob/master/src/main/java/org/codehaus/plexus/classworlds/realm/ClassRealm.java#L275.
> This in particular affects plugins that interact with the JAXB API because it
> relies on package annotations.
> A workaround is to preload the required {{package-info}} classes using
> {{loadClass}}; see e.g. http://svn.apache.org/viewvc?rev=1845026=rev.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6613) Mirror matching ignores closest/nearest definition
[
https://issues.apache.org/jira/browse/MNG-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806454#comment-16806454
]
Hudson commented on MNG-6613:
-
Build succeeded in Jenkins: Maven TLP » maven » MNG-5868 #26
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5868/26/
> Mirror matching ignores closest/nearest definition
> --
>
> Key: MNG-6613
> URL: https://issues.apache.org/jira/browse/MNG-6613
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.5.4, 3.6.1
> Environment: Java 8u202, Java11u2
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: log.txt
>
>
> Ran our IT suite in a locked down environment at work, w/o direct internet
> access. IT {{mng3461MirrorMatching(itNonGreedyWildcard)}} blocks forever
> because the mirror exclude does not work: {{*,!maven-core-it}}.
> It still tries to download via mirror instead of ignoring it. See attached
> log file. Even switching {{!maven-core-it,*}} makes no difference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6506) Mojos are unable to load package annotations on Java >= 9
[
https://issues.apache.org/jira/browse/MNG-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806421#comment-16806421
]
Hudson commented on MNG-6506:
-
Build unstable in Jenkins: Maven TLP » maven » MNG-6512-build-11 #17
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6512-build-11/17/
> Mojos are unable to load package annotations on Java >= 9
> -
>
> Key: MNG-6506
> URL: https://issues.apache.org/jira/browse/MNG-6506
> Project: Maven
> Issue Type: Bug
> Components: Class Loading
>Affects Versions: 3.6.0
>Reporter: Andreas Veithen
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Labels: up-for-grabs
> Fix For: 3.6.1
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> On Java 9 and above, calls to {{java.lang.Package.getAnnotation(Class)}} from
> within a Mojo always return {{null}} (unless the {{package-info}} class has
> been loaded by some other means before).
> The reason appears to be an incompatibility between Java 9 and Plexus
> Classworlds:
> * Java 9 ultimately calls {{findClass}} (instead of {{loadClass}}) to get the
> {{package-info}} class.
> * The {{findClass}} implementation in {{ClassRealm}} always throws
> {{ClassNotFoundException}}:
> https://github.com/codehaus-plexus/plexus-classworlds/blob/master/src/main/java/org/codehaus/plexus/classworlds/realm/ClassRealm.java#L275.
> This in particular affects plugins that interact with the JAXB API because it
> relies on package annotations.
> A workaround is to preload the required {{package-info}} classes using
> {{loadClass}}; see e.g. http://svn.apache.org/viewvc?rev=1845026=rev.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6255) Maven script cannot parse jvm.config with CRLF
[
https://issues.apache.org/jira/browse/MNG-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806422#comment-16806422
]
Hudson commented on MNG-6255:
-
Build unstable in Jenkins: Maven TLP » maven » MNG-6512-build-11 #17
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6512-build-11/17/
> Maven script cannot parse jvm.config with CRLF
> --
>
> Key: MNG-6255
> URL: https://issues.apache.org/jira/browse/MNG-6255
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 7 with MINGW64 environment via Git for Windows
> 0.1.1 including GNU coreutils and bash 4.4.12
>Reporter: Andrew Kennedy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.5.3
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> A project with a {{.mvn/jvm.config}} file that has *CRLF* line endings will
> not parse it correctly. The script uses the {{tr}} command to change *LF* to
> space, but this leaves *CR* behind. For example, with the {{jvm.config}} file
> containing the text {{-Xmx1024m -Xms512m}} followed by *CRLF*, the following
> error message is printed:
> {code}
> $ mvn install
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> Invalid initial heap size: -Xms512m
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6613) Mirror matching ignores closest/nearest definition
[
https://issues.apache.org/jira/browse/MNG-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16806420#comment-16806420
]
Hudson commented on MNG-6613:
-
Build unstable in Jenkins: Maven TLP » maven » MNG-6512-build-11 #17
See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6512-build-11/17/
> Mirror matching ignores closest/nearest definition
> --
>
> Key: MNG-6613
> URL: https://issues.apache.org/jira/browse/MNG-6613
> Project: Maven
> Issue Type: Bug
> Components: Artifacts and Repositories
>Affects Versions: 3.5.4, 3.6.1
> Environment: Java 8u202, Java11u2
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: log.txt
>
>
> Ran our IT suite in a locked down environment at work, w/o direct internet
> access. IT {{mng3461MirrorMatching(itNonGreedyWildcard)}} blocks forever
> because the mirror exclude does not work: {{*,!maven-core-it}}.
> It still tries to download via mirror instead of ignoring it. See attached
> log file. Even switching {{!maven-core-it,*}} makes no difference.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
