[GitHub] [maven-surefire] eolivelli closed pull request #225: SUREFIRE-1614 for 2.22.2

[GitBox]

eolivelli closed pull request #225: SUREFIRE-1614 for 2.22.2
URL: https://github.com/apache/maven-surefire/pull/225
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MPMD-277) Plugin tries to download local submodules from repo

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPMD-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814963#comment-16814963
 ] 

Hudson commented on MPMD-277:
-

Build succeeded in Jenkins: Maven TLP » maven-pmd-plugin » master #9

See https://builds.apache.org/job/maven-box/job/maven-pmd-plugin/job/master/9/

> Plugin tries to download local submodules from repo
> ---
>
> Key: MPMD-277
> URL: https://issues.apache.org/jira/browse/MPMD-277
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.11.0
>Reporter: Sylvain
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> My bug seems kinda related to #MPMD-273, but 3.10.0 works for me, not 3.11.0.
>  
> I'm trying to build a multi-module maven project with OpenJDK11 and Maven 
> 3.5.4.
> The project works fine with maven-pmd-plugin 3.10.0, but with 3.11.0, I get 
> this error:
>  
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-pmd-plugin:3.11.0:pmd (pmd) on project parent: 
> Execution pmd of goal org.apache.maven.plugins:maven-pmd-plugin:3.11.0:pmd 
> failed: org.apache.maven.reporting.MavenReportException: 
> org.eclipse.aether.resolution.DependencyResolutionException: Could not find 
> artifact com.incepto.cloud:api-common:jar:0.0.1-SNAPSHOT in spring-repo 
> (https://repo.spring.io/release) -> [Help 1]
>  
> pmd-plugin doesn't have a dependency on api-common, it's the first submodule 
> maven tries to build. The problem doesn't occur if I skip pmd first and let 
> maven install the submodules in the local repo, then re-run the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MPMD-281) Display found violations grouped by priority

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPMD-281?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814964#comment-16814964
 ] 

Hudson commented on MPMD-281:
-

Build succeeded in Jenkins: Maven TLP » maven-pmd-plugin » master #9

See https://builds.apache.org/job/maven-box/job/maven-pmd-plugin/job/master/9/

> Display found violations grouped by priority
> 
>
> Key: MPMD-281
> URL: https://issues.apache.org/jira/browse/MPMD-281
> Project: Maven PMD Plugin
>  Issue Type: New Feature
>  Components: PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When generating the report, the violations are currently grouped by files.
> It would be useful, if the violations were also grouped by priority, so that 
> one can concentrate on fixing the violations with the highest priority first.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (DOXIA-575) Add support for (X)HTML5

[Graham Leggett (JIRA)]

[ 
https://issues.apache.org/jira/browse/DOXIA-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814915#comment-16814915
 ] 

Graham Leggett commented on DOXIA-575:
--

Another gentle ping, is time looking any better?

> Add support for (X)HTML5
> 
>
> Key: DOXIA-575
> URL: https://issues.apache.org/jira/browse/DOXIA-575
> Project: Maven Doxia
>  Issue Type: Improvement
>  Components: Core
>Affects Versions: 1.8
>Reporter: Graham Leggett
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.9
>
> Attachments: DOXIA-575.patch
>
>
> Doxia currently generates XHTML v1.1, and does not support any of the new 
> HTML5 tags.
> Update Doxia to support HTML5.2 as per https://www.w3.org/TR/html52/.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [maven-deploy-plugin] michael-o edited a comment on issue #6: [MDEPLOY-255] altDeploymentRepositoryURL w/a for altDeploymentRepository in mingw/c…

[GitBox]

michael-o edited a comment on issue #6: [MDEPLOY-255] 
altDeploymentRepositoryURL w/a for altDeploymentRepository in mingw/c…
URL: https://github.com/apache/maven-deploy-plugin/pull/6#issuecomment-481888482
 
 
   I consider this to be a workaround rather than a solution because the root 
cause has not been found.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-deploy-plugin] michael-o commented on issue #6: [MDEPLOY-255] altDeploymentRepositoryURL w/a for altDeploymentRepository in mingw/c…

[GitBox]

michael-o commented on issue #6: [MDEPLOY-255] altDeploymentRepositoryURL w/a 
for altDeploymentRepository in mingw/c…
URL: https://github.com/apache/maven-deploy-plugin/pull/6#issuecomment-481888482
 
 
   I consider this to be a workaround rather than a solution because the root 
caues has not been found.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Updated] (MCOMPILER-380) docs claim copyright for future years

[Michael Osipov (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MCOMPILER-380?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MCOMPILER-380:
-
Fix Version/s: waiting-for-feedback

> docs claim copyright for future years
> -
>
> Key: MCOMPILER-380
> URL: https://issues.apache.org/jira/browse/MCOMPILER-380
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Bernhard M. Wiedemann
>Priority: Minor
> Fix For: waiting-for-feedback
>
>
> While working on reproducible builds for openSUSE, I found that
> building the maven-compiler-plugin package in 2034, claimed copyright for 
> future years.
> One simple fix could be to instead use the mtime of some file that is 
> unlikely to be touched during build (e.g. ChangeLog). Or just use a constant.
> A copyright 2019 will remain correct and effective even in 2050.
>  
> Diff:
>  
> {{--- 
> old//usr/share/javadoc/maven-compiler-plugin/org/apache/maven/plugin/compiler/TestCompilerMojo.html
>  2019-04-09 14:24:53.465960240 +}}
> {{+++ 
> new//usr/share/javadoc/maven-compiler-plugin/org/apache/maven/plugin/compiler/TestCompilerMojo.html
>  2019-04-09 14:24:53.473960286 +}}
> {{@@ -642,7 +642,7 @@}}
> {{ }}
> {{ }}
> {{-Copyright  20012019  href="https://www.apache.org/;>The Apache Software Foundation. All rights 
> reserved.}}
> {{+Copyright  20012034  href="https://www.apache.org/;>The Apache Software Foundation. All rights 
> reserved.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MCOMPILER-380) docs claim copyright for future years

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MCOMPILER-380?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814906#comment-16814906
 ] 

Michael Osipov commented on MCOMPILER-380:
--

What are you actually trying to achieve by changing the current date? It works 
as defined in 
[here](https://maven.apache.org/plugins/maven-javadoc-plugin/javadoc-mojo.html#bottom).

> docs claim copyright for future years
> -
>
> Key: MCOMPILER-380
> URL: https://issues.apache.org/jira/browse/MCOMPILER-380
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
>Reporter: Bernhard M. Wiedemann
>Priority: Minor
>
> While working on reproducible builds for openSUSE, I found that
> building the maven-compiler-plugin package in 2034, claimed copyright for 
> future years.
> One simple fix could be to instead use the mtime of some file that is 
> unlikely to be touched during build (e.g. ChangeLog). Or just use a constant.
> A copyright 2019 will remain correct and effective even in 2050.
>  
> Diff:
>  
> {{--- 
> old//usr/share/javadoc/maven-compiler-plugin/org/apache/maven/plugin/compiler/TestCompilerMojo.html
>  2019-04-09 14:24:53.465960240 +}}
> {{+++ 
> new//usr/share/javadoc/maven-compiler-plugin/org/apache/maven/plugin/compiler/TestCompilerMojo.html
>  2019-04-09 14:24:53.473960286 +}}
> {{@@ -642,7 +642,7 @@}}
> {{ }}
> {{ }}
> {{-Copyright  20012019  href="https://www.apache.org/;>The Apache Software Foundation. All rights 
> reserved.}}
> {{+Copyright  20012034  href="https://www.apache.org/;>The Apache Software Foundation. All rights 
> reserved.}}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (MNG-6604) Intermittent failures while downloading GAVs from Nexus

[Dan Tran (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814886#comment-16814886
 ] 

Dan Tran edited comment on MNG-6604 at 4/10/19 9:41 PM:


This is very strange,  I am very sure there are a lot of us successfully 
building maven projects with hundreds of modules using smart builder. So far I 
have not seen this issue even with the broken takari local-repo.  I am using 
artifactory thou

Could this be one of those build ordering issue at user side? This is  fixable 
via maven dependency 


was (Author: dantran):
This is very strange,  I am very sure there are a lot of us successfully 
building maven projects with hundreds of modules using smart builder. So far I 
have not seen this issue even with the broken takari local-repo.  I am using 
artifactory thou

> Intermittent failures while downloading GAVs from Nexus
> ---
>
> Key: MNG-6604
> URL: https://issues.apache.org/jira/browse/MNG-6604
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line, Toolchains
>Affects Versions: 3.6.0
> Environment: Nexus OSS 3.15.2-01
> Docker 18.09.2 on Ubuntu 18.04.2 LTS
> Gitlab runner 11.8.0
>Reporter: Ivan Rizzante
>Priority: Major
> Attachments: docker-env.txt, log.txt
>
>
> Hello
> we're running maven 3.6.0 builds in a docker container and we use Nexus OSS 
> configured as proxy for Maven Central.
> While running our builds using Gitlab CI, we're experiencing intermittent 
> build failures because Maven cannot find artifacts in Nexus which we verified 
> they are actually available.
> Error example below:
> {noformat}
> 20744 [main] [ERROR] Failed to execute goal on project EcotransitWSClient: 
> Could not resolve dependencies for project 
> it.sdb.ecotransit:EcotransitWSClient:jar:7.0.1-SNAPSHOT: Could not transfer 
> artifact commons-beanutils:commons-beanutils:jar:1.9.3 from/to nexus 
> (http://maven-repo.sdb.it:8081/repository/maven-public/): 
> /builds/sdb/webportal/.m2/repository/commons-beanutils/commons-beanutils/1.9.3/commons-beanutils-1.9.3.jar.part
>  (No such file or directory) -> [Help 1]
> {noformat}
> I attached the full maven build log and our Docker env settings.
> We tried disabling the keep alive and also disabling the connection pooling 
> but nothing seems to fix the issue.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6604) Intermittent failures while downloading GAVs from Nexus

[Dan Tran (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814886#comment-16814886
 ] 

Dan Tran commented on MNG-6604:
---

This is very strange,  I am very sure there are a lot of us successfully 
building maven projects with hundreds of modules using smart builder. So far I 
have not seen this issue even with the broken takari local-repo.  I am using 
artifactory thou

> Intermittent failures while downloading GAVs from Nexus
> ---
>
> Key: MNG-6604
> URL: https://issues.apache.org/jira/browse/MNG-6604
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line, Toolchains
>Affects Versions: 3.6.0
> Environment: Nexus OSS 3.15.2-01
> Docker 18.09.2 on Ubuntu 18.04.2 LTS
> Gitlab runner 11.8.0
>Reporter: Ivan Rizzante
>Priority: Major
> Attachments: docker-env.txt, log.txt
>
>
> Hello
> we're running maven 3.6.0 builds in a docker container and we use Nexus OSS 
> configured as proxy for Maven Central.
> While running our builds using Gitlab CI, we're experiencing intermittent 
> build failures because Maven cannot find artifacts in Nexus which we verified 
> they are actually available.
> Error example below:
> {noformat}
> 20744 [main] [ERROR] Failed to execute goal on project EcotransitWSClient: 
> Could not resolve dependencies for project 
> it.sdb.ecotransit:EcotransitWSClient:jar:7.0.1-SNAPSHOT: Could not transfer 
> artifact commons-beanutils:commons-beanutils:jar:1.9.3 from/to nexus 
> (http://maven-repo.sdb.it:8081/repository/maven-public/): 
> /builds/sdb/webportal/.m2/repository/commons-beanutils/commons-beanutils/1.9.3/commons-beanutils-1.9.3.jar.part
>  (No such file or directory) -> [Help 1]
> {noformat}
> I attached the full maven build log and our Docker env settings.
> We tried disabling the keep alive and also disabling the connection pooling 
> but nothing seems to fix the issue.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [maven] oehme commented on a change in pull request #242: Speed up project discovery

[GitBox]

oehme commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274160076
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
 ##
 @@ -163,30 +158,42 @@ public final void parseVersion( String version )
 boolean fallback = false;
 
 StringTokenizer tok = new StringTokenizer( part1, "." );
-try
+if ( tok.hasMoreTokens() )
 {
 majorVersion = getNextIntegerToken( tok );
-if ( tok.hasMoreTokens() )
-{
-minorVersion = getNextIntegerToken( tok );
-}
-if ( tok.hasMoreTokens() )
+if ( majorVersion == null )
 {
-incrementalVersion = getNextIntegerToken( tok );
+fallback = true;
 }
-if ( tok.hasMoreTokens() )
+}
+else
+{
+fallback = true;
+}
+if ( tok.hasMoreTokens() )
+{
+minorVersion = getNextIntegerToken( tok );
+if ( minorVersion == null )
 {
-qualifier = tok.nextToken();
-fallback = Pattern.compile( "\\d+" ).matcher( qualifier 
).matches();
+fallback = true;
 }
-
-// string tokenizer won't detect these and ignores them
-if ( part1.contains( ".." ) || part1.startsWith( "." ) || 
part1.endsWith( "." ) )
+}
+if ( tok.hasMoreTokens() )
+{
+incrementalVersion = getNextIntegerToken( tok );
+if ( incrementalVersion == null )
 {
 fallback = true;
 }
 }
-catch ( NumberFormatException e )
+if ( tok.hasMoreTokens() )
+{
+qualifier = tok.nextToken();
+fallback = Pattern.compile( "\\d+" ).matcher( qualifier 
).matches();
 
 Review comment:
   Because it wasn't a hotspot in my tests. I can do it for consistency, but I 
can't prove that it is a problem :) 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme commented on a change in pull request #242: Speed up project discovery

[GitBox]

oehme commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274159124
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
 ##
 @@ -204,19 +211,33 @@ public final void parseVersion( String version )
 }
 
 private static Integer getNextIntegerToken( StringTokenizer tok )
+{
+String s = tok.nextToken();
+if ( ( s.length() > 1 ) && s.startsWith( "0" ) )
+{
+return null;
 
 Review comment:
   This is a private method, the callers of this method have been changed as 
well. We don't want exceptions, we want efficient if-statements.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme commented on a change in pull request #242: Speed up project discovery

[GitBox]

oehme commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274159124
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
 ##
 @@ -204,19 +211,33 @@ public final void parseVersion( String version )
 }
 
 private static Integer getNextIntegerToken( StringTokenizer tok )
+{
+String s = tok.nextToken();
+if ( ( s.length() > 1 ) && s.startsWith( "0" ) )
+{
+return null;
 
 Review comment:
   That's intended, the callers of this method have been changed as well. We 
don't want exceptions, we want efficient if-statements.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme commented on a change in pull request #242: Speed up project discovery

[GitBox]

oehme commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274159320
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
 ##
 @@ -204,19 +211,33 @@ public final void parseVersion( String version )
 }
 
 private static Integer getNextIntegerToken( StringTokenizer tok )
+{
+String s = tok.nextToken();
+if ( ( s.length() > 1 ) && s.startsWith( "0" ) )
+{
+return null;
+}
+return tryParseInt( s );
+}
+
+private static Integer tryParseInt( String s )
 {
 try
 {
-String s = tok.nextToken();
-if ( ( s.length() > 1 ) && s.startsWith( "0" ) )
+if ( !isParsable( s ) )
+{
+return null;
+}
+long longValue = Long.parseLong( s );
+if ( longValue > Integer.MAX_VALUE )
 
 Review comment:
   Because it throws an exception internally, which is what we're trying to 
avoid in the first place here. We don't want to throw exceptions on common code 
paths. 
   
   Also, we're not changing semantics here, we are still returning an int. 
Going through long is only done for the very common case of big numbers that 
would fail with a NumberFormatException on `Integer.parseInt`


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme commented on issue #242: Speed up project discovery

[GitBox]

oehme commented on issue #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#issuecomment-481865237
 
 
   > Please create seperate JIRA tickets for each change. 
   
   Why is this overhead necessary? I wouldn't know what to write in the ticket 
besides "look at the commit message" ;)
   
   > Did you also try change by change and saw how it affects the build time? 
I'd like to see broken down numbers for your case.
   
   I did, each change removes a similar chunk of the build time. They are all 
very much worth it. I can send you the original and after profiler snapshot if 
you'd like.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme commented on a change in pull request #242: Speed up project discovery

[GitBox]

oehme commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274160076
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
 ##
 @@ -163,30 +158,42 @@ public final void parseVersion( String version )
 boolean fallback = false;
 
 StringTokenizer tok = new StringTokenizer( part1, "." );
-try
+if ( tok.hasMoreTokens() )
 {
 majorVersion = getNextIntegerToken( tok );
-if ( tok.hasMoreTokens() )
-{
-minorVersion = getNextIntegerToken( tok );
-}
-if ( tok.hasMoreTokens() )
+if ( majorVersion == null )
 {
-incrementalVersion = getNextIntegerToken( tok );
+fallback = true;
 }
-if ( tok.hasMoreTokens() )
+}
+else
+{
+fallback = true;
+}
+if ( tok.hasMoreTokens() )
+{
+minorVersion = getNextIntegerToken( tok );
+if ( minorVersion == null )
 {
-qualifier = tok.nextToken();
-fallback = Pattern.compile( "\\d+" ).matcher( qualifier 
).matches();
+fallback = true;
 }
-
-// string tokenizer won't detect these and ignores them
-if ( part1.contains( ".." ) || part1.startsWith( "." ) || 
part1.endsWith( "." ) )
+}
+if ( tok.hasMoreTokens() )
+{
+incrementalVersion = getNextIntegerToken( tok );
+if ( incrementalVersion == null )
 {
 fallback = true;
 }
 }
-catch ( NumberFormatException e )
+if ( tok.hasMoreTokens() )
+{
+qualifier = tok.nextToken();
+fallback = Pattern.compile( "\\d+" ).matcher( qualifier 
).matches();
 
 Review comment:
   Because it wasn't a hotspot in my tests.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme commented on a change in pull request #242: Speed up project discovery

[GitBox]

oehme commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274159867
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
 ##
 @@ -150,6 +150,30 @@ public int compareTo( Item item )
 }
 }
 
+@Override
+public boolean equals( Object o )
 
 Review comment:
   Because I wasn't sure about the minimum Java version of Maven.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme commented on a change in pull request #242: Speed up project discovery

[GitBox]

oehme commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274159650
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/artifact/handler/manager/DefaultArtifactHandlerManager.java
 ##
 @@ -53,6 +53,10 @@ public ArtifactHandler getArtifactHandler( String type )
 {
 handler = new DefaultArtifactHandler( type );
 }
+else
+{
+allHandlers.put( type, handler );
 
 Review comment:
   The handlers have no mutation methods, so I don't see what side effects this 
would cause. I'd say a stateful handler would be a terrible implementation.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-6604) Intermittent failures while downloading GAVs from Nexus

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814864#comment-16814864
 ] 

Michael Osipov commented on MNG-6604:
-

[~carlspring], my problem isn't information, but time which I sparely have and 
this requires a significant amount of time to fix I absolutely cannot allocate.

The property name is {{aether.connector.resumeDownloads}} or per-repo 
{{aether.connector.resumeDownloads.}}. See {{BasicRepositoryConnector}}.

> Intermittent failures while downloading GAVs from Nexus
> ---
>
> Key: MNG-6604
> URL: https://issues.apache.org/jira/browse/MNG-6604
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line, Toolchains
>Affects Versions: 3.6.0
> Environment: Nexus OSS 3.15.2-01
> Docker 18.09.2 on Ubuntu 18.04.2 LTS
> Gitlab runner 11.8.0
>Reporter: Ivan Rizzante
>Priority: Major
> Attachments: docker-env.txt, log.txt
>
>
> Hello
> we're running maven 3.6.0 builds in a docker container and we use Nexus OSS 
> configured as proxy for Maven Central.
> While running our builds using Gitlab CI, we're experiencing intermittent 
> build failures because Maven cannot find artifacts in Nexus which we verified 
> they are actually available.
> Error example below:
> {noformat}
> 20744 [main] [ERROR] Failed to execute goal on project EcotransitWSClient: 
> Could not resolve dependencies for project 
> it.sdb.ecotransit:EcotransitWSClient:jar:7.0.1-SNAPSHOT: Could not transfer 
> artifact commons-beanutils:commons-beanutils:jar:1.9.3 from/to nexus 
> (http://maven-repo.sdb.it:8081/repository/maven-public/): 
> /builds/sdb/webportal/.m2/repository/commons-beanutils/commons-beanutils/1.9.3/commons-beanutils-1.9.3.jar.part
>  (No such file or directory) -> [Help 1]
> {noformat}
> I attached the full maven build log and our Docker env settings.
> We tried disabling the keep alive and also disabling the connection pooling 
> but nothing seems to fix the issue.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [maven] oehme commented on a change in pull request #242: Speed up project discovery

[GitBox]

oehme commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274159320
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
 ##
 @@ -204,19 +211,33 @@ public final void parseVersion( String version )
 }
 
 private static Integer getNextIntegerToken( StringTokenizer tok )
+{
+String s = tok.nextToken();
+if ( ( s.length() > 1 ) && s.startsWith( "0" ) )
+{
+return null;
+}
+return tryParseInt( s );
+}
+
+private static Integer tryParseInt( String s )
 {
 try
 {
-String s = tok.nextToken();
-if ( ( s.length() > 1 ) && s.startsWith( "0" ) )
+if ( !isParsable( s ) )
+{
+return null;
+}
+long longValue = Long.parseLong( s );
+if ( longValue > Integer.MAX_VALUE )
 
 Review comment:
   Because it throws an exception internally, which is what we're trying to 
avoid in the first place here. We don't want to throw exceptions on common code 
paths.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme commented on a change in pull request #242: Speed up project discovery

[GitBox]

oehme commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274159124
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
 ##
 @@ -204,19 +211,33 @@ public final void parseVersion( String version )
 }
 
 private static Integer getNextIntegerToken( StringTokenizer tok )
+{
+String s = tok.nextToken();
+if ( ( s.length() > 1 ) && s.startsWith( "0" ) )
+{
+return null;
 
 Review comment:
   That's intended, the callers of this method has been changed as well.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-6604) Intermittent failures while downloading GAVs from Nexus

[Martin Todorov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814853#comment-16814853
 ] 

Martin Todorov commented on MNG-6604:
-

[~igorf],

Thanks for confirming that the {{takari-local-repository}} is broken (as we 
thought) and that it's not us misconfiguring something! :)
We tried using {{-Daether.connector.resumeDownload=false}}, but this, 
unfortunately, did not help.

[~michael-o],

What sort of information would help you guys further investigate this?

Do you guys have anything else you could advise that we try?


> Intermittent failures while downloading GAVs from Nexus
> ---
>
> Key: MNG-6604
> URL: https://issues.apache.org/jira/browse/MNG-6604
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line, Toolchains
>Affects Versions: 3.6.0
> Environment: Nexus OSS 3.15.2-01
> Docker 18.09.2 on Ubuntu 18.04.2 LTS
> Gitlab runner 11.8.0
>Reporter: Ivan Rizzante
>Priority: Major
> Attachments: docker-env.txt, log.txt
>
>
> Hello
> we're running maven 3.6.0 builds in a docker container and we use Nexus OSS 
> configured as proxy for Maven Central.
> While running our builds using Gitlab CI, we're experiencing intermittent 
> build failures because Maven cannot find artifacts in Nexus which we verified 
> they are actually available.
> Error example below:
> {noformat}
> 20744 [main] [ERROR] Failed to execute goal on project EcotransitWSClient: 
> Could not resolve dependencies for project 
> it.sdb.ecotransit:EcotransitWSClient:jar:7.0.1-SNAPSHOT: Could not transfer 
> artifact commons-beanutils:commons-beanutils:jar:1.9.3 from/to nexus 
> (http://maven-repo.sdb.it:8081/repository/maven-public/): 
> /builds/sdb/webportal/.m2/repository/commons-beanutils/commons-beanutils/1.9.3/commons-beanutils-1.9.3.jar.part
>  (No such file or directory) -> [Help 1]
> {noformat}
> I attached the full maven build log and our Docker env settings.
> We tried disabling the keep alive and also disabling the connection pooling 
> but nothing seems to fix the issue.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [maven] michael-o commented on a change in pull request #242: Speed up project discovery

[GitBox]

michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274133065
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
 ##
 @@ -163,30 +158,42 @@ public final void parseVersion( String version )
 boolean fallback = false;
 
 StringTokenizer tok = new StringTokenizer( part1, "." );
-try
+if ( tok.hasMoreTokens() )
 {
 majorVersion = getNextIntegerToken( tok );
-if ( tok.hasMoreTokens() )
-{
-minorVersion = getNextIntegerToken( tok );
-}
-if ( tok.hasMoreTokens() )
+if ( majorVersion == null )
 {
-incrementalVersion = getNextIntegerToken( tok );
+fallback = true;
 }
-if ( tok.hasMoreTokens() )
+}
+else
+{
+fallback = true;
+}
+if ( tok.hasMoreTokens() )
+{
+minorVersion = getNextIntegerToken( tok );
+if ( minorVersion == null )
 {
-qualifier = tok.nextToken();
-fallback = Pattern.compile( "\\d+" ).matcher( qualifier 
).matches();
+fallback = true;
 }
-
-// string tokenizer won't detect these and ignores them
-if ( part1.contains( ".." ) || part1.startsWith( "." ) || 
part1.endsWith( "." ) )
+}
+if ( tok.hasMoreTokens() )
+{
+incrementalVersion = getNextIntegerToken( tok );
+if ( incrementalVersion == null )
 {
 fallback = true;
 }
 }
-catch ( NumberFormatException e )
+if ( tok.hasMoreTokens() )
+{
+qualifier = tok.nextToken();
+fallback = Pattern.compile( "\\d+" ).matcher( qualifier 
).matches();
 
 Review comment:
   Why not use the char array approach as before?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] michael-o commented on a change in pull request #242: Speed up project discovery

[GitBox]

michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274134133
 
 

 ##
 File path: 
maven-core/src/main/java/org/apache/maven/artifact/handler/manager/DefaultArtifactHandlerManager.java
 ##
 @@ -53,6 +53,10 @@ public ArtifactHandler getArtifactHandler( String type )
 {
 handler = new DefaultArtifactHandler( type );
 }
+else
+{
+allHandlers.put( type, handler );
 
 Review comment:
   What side effects may this cause if we don't receive a new instance?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] michael-o commented on a change in pull request #242: Speed up project discovery

[GitBox]

michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274133543
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
 ##
 @@ -204,19 +211,33 @@ public final void parseVersion( String version )
 }
 
 private static Integer getNextIntegerToken( StringTokenizer tok )
+{
+String s = tok.nextToken();
+if ( ( s.length() > 1 ) && s.startsWith( "0" ) )
+{
+return null;
 
 Review comment:
   This changes the semantics of the method, no NFE thrown.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] michael-o commented on a change in pull request #242: Speed up project discovery

[GitBox]

michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274134608
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
 ##
 @@ -272,6 +320,29 @@ public int compareTo( Item item )
 }
 
 @Override
+public boolean equals( Object o )
 
 Review comment:
   same here...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] michael-o commented on a change in pull request #242: Speed up project discovery

[GitBox]

michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274134416
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
 ##
 @@ -150,6 +150,30 @@ public int compareTo( Item item )
 }
 }
 
+@Override
+public boolean equals( Object o )
+{
+if ( this == o )
+{
+return true;
+}
+if ( o == null || getClass() != o.getClass() )
+{
+return false;
+}
+
+IntItem intItem = (IntItem) o;
+
+return value == intItem.value;
+
+}
+
+@Override
+public int hashCode()
+{
+return value;
 
 Review comment:
   Why not use `Objects#hashCode()` on this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] michael-o commented on a change in pull request #242: Speed up project discovery

[GitBox]

michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274133797
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/DefaultArtifactVersion.java
 ##
 @@ -204,19 +211,33 @@ public final void parseVersion( String version )
 }
 
 private static Integer getNextIntegerToken( StringTokenizer tok )
+{
+String s = tok.nextToken();
+if ( ( s.length() > 1 ) && s.startsWith( "0" ) )
+{
+return null;
+}
+return tryParseInt( s );
+}
+
+private static Integer tryParseInt( String s )
 {
 try
 {
-String s = tok.nextToken();
-if ( ( s.length() > 1 ) && s.startsWith( "0" ) )
+if ( !isParsable( s ) )
+{
+return null;
+}
+long longValue = Long.parseLong( s );
+if ( longValue > Integer.MAX_VALUE )
 
 Review comment:
   Again, change in semantics with long. Dislike on this one. Why all the 
hassle, why not use  `NumberUtils` from Commons Lang 3?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] michael-o commented on a change in pull request #242: Speed up project discovery

[GitBox]

michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274131884
 
 

 ##
 File path: 
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
 ##
 @@ -849,13 +851,13 @@ private boolean validateIdWithWildcards( String 
fieldName, ModelProblemCollector
 }
 else
 {
-boolean match = ID_WITH_WILDCARDS_REGEX.matcher( id ).matches();
-if ( !match )
+if ( !org.apache.commons.lang3.StringUtils.containsOnly( id, 
ID_WITH_WILDCARD_CHARS ) )
 {
 addViolation( problems, severity, version, fieldName, 
sourceHint,
 
 Review comment:
   This message does not reflect the issue anymore because we don't have any 
anymore.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] michael-o commented on a change in pull request #242: Speed up project discovery

[GitBox]

michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274134530
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
 ##
 @@ -211,6 +235,30 @@ public int compareTo( Item item )
 }
 }
 
+@Override
+public boolean equals( Object o )
+{
+if ( this == o )
+{
+return true;
+}
+if ( o == null || getClass() != o.getClass() )
+{
+return false;
+}
+
+LongItem longItem = (LongItem) o;
+
+return value == longItem.value;
+
+}
+
+@Override
+public int hashCode()
 
 Review comment:
   Why not use `Objects#hashCode()` on this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] michael-o commented on a change in pull request #242: Speed up project discovery

[GitBox]

michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274134441
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
 ##
 @@ -211,6 +235,30 @@ public int compareTo( Item item )
 }
 }
 
+@Override
+public boolean equals( Object o )
 
 Review comment:
   Why not use `Objects#equals()` on this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] michael-o commented on a change in pull request #242: Speed up project discovery

[GitBox]

michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274131823
 
 

 ##
 File path: 
maven-model-builder/src/main/java/org/apache/maven/model/validation/DefaultModelValidator.java
 ##
 @@ -829,13 +831,13 @@ private boolean validateId( String fieldName, 
ModelProblemCollector problems, Se
 }
 else
 {
-boolean match = ID_REGEX.matcher( id ).matches();
-if ( !match )
+if ( !org.apache.commons.lang3.StringUtils.containsOnly( id, 
ID_CHARS ) )
 {
 addViolation( problems, severity, version, fieldName, 
sourceHint,
   "with value '" + id + "' does not match a valid 
id pattern.", tracker );
 
 Review comment:
   This message does not reflect the issue anymore because we don't have any 
anymore.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] michael-o commented on a change in pull request #242: Speed up project discovery

[GitBox]

michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274134286
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
 ##
 @@ -150,6 +150,30 @@ public int compareTo( Item item )
 }
 }
 
+@Override
+public boolean equals( Object o )
 
 Review comment:
   Why not use `Objects#equals()` on this?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] michael-o commented on a change in pull request #242: Speed up project discovery

[GitBox]

michael-o commented on a change in pull request #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#discussion_r274134677
 
 

 ##
 File path: 
maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java
 ##
 @@ -384,6 +455,29 @@ public int compareTo( Item item )
 }
 
 @Override
+public boolean equals( Object o )
 
 Review comment:
   and here...


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-6604) Intermittent failures while downloading GAVs from Nexus

[Michael Osipov (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814824#comment-16814824
 ] 

Michael Osipov commented on MNG-6604:
-

[~OleksandrG], how am I supposed to add a fix for the next release if I don't 
have any?

> Intermittent failures while downloading GAVs from Nexus
> ---
>
> Key: MNG-6604
> URL: https://issues.apache.org/jira/browse/MNG-6604
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line, Toolchains
>Affects Versions: 3.6.0
> Environment: Nexus OSS 3.15.2-01
> Docker 18.09.2 on Ubuntu 18.04.2 LTS
> Gitlab runner 11.8.0
>Reporter: Ivan Rizzante
>Priority: Major
> Attachments: docker-env.txt, log.txt
>
>
> Hello
> we're running maven 3.6.0 builds in a docker container and we use Nexus OSS 
> configured as proxy for Maven Central.
> While running our builds using Gitlab CI, we're experiencing intermittent 
> build failures because Maven cannot find artifacts in Nexus which we verified 
> they are actually available.
> Error example below:
> {noformat}
> 20744 [main] [ERROR] Failed to execute goal on project EcotransitWSClient: 
> Could not resolve dependencies for project 
> it.sdb.ecotransit:EcotransitWSClient:jar:7.0.1-SNAPSHOT: Could not transfer 
> artifact commons-beanutils:commons-beanutils:jar:1.9.3 from/to nexus 
> (http://maven-repo.sdb.it:8081/repository/maven-public/): 
> /builds/sdb/webportal/.m2/repository/commons-beanutils/commons-beanutils/1.9.3/commons-beanutils-1.9.3.jar.part
>  (No such file or directory) -> [Help 1]
> {noformat}
> I attached the full maven build log and our Docker env settings.
> We tried disabling the keep alive and also disabling the connection pooling 
> but nothing seems to fix the issue.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (MPMD-284) Upgrade parent to 33

[Andreas Dangel (JIRA)]

Andreas Dangel created MPMD-284:
---

 Summary: Upgrade parent to 33
 Key: MPMD-284
 URL: https://issues.apache.org/jira/browse/MPMD-284
 Project: Maven PMD Plugin
  Issue Type: Dependency upgrade
Reporter: Andreas Dangel
Assignee: Andreas Dangel
 Fix For: 3.12.0


Release notes for 32: 
[https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311250=12342723]

 

Release notes for 33: 
[https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12311250=12343766]

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MPMD-281) Display found violations grouped by priority

[Andreas Dangel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MPMD-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Dangel updated MPMD-281:

Issue Type: New Feature  (was: Improvement)

> Display found violations grouped by priority
> 
>
> Key: MPMD-281
> URL: https://issues.apache.org/jira/browse/MPMD-281
> Project: Maven PMD Plugin
>  Issue Type: New Feature
>  Components: PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When generating the report, the violations are currently grouped by files.
> It would be useful, if the violations were also grouped by priority, so that 
> one can concentrate on fixing the violations with the highest priority first.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MPMD-280) Support targetJdk 12

[Andreas Dangel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MPMD-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Dangel updated MPMD-280:

Summary: Support targetJdk 12  (was: maven-pmd-plugin does not support 
targetJdk 12)

> Support targetJdk 12
> 
>
> Key: MPMD-280
> URL: https://issues.apache.org/jira/browse/MPMD-280
> Project: Maven PMD Plugin
>  Issue Type: New Feature
>  Components: PMD
>Affects Versions: 3.11.0
> Environment: openjdk version "12" 2019-03-19
> OpenJDK Runtime Environment 19.3 (build 12+33)
> OpenJDK 64-Bit Server VM 19.3 (build 12+33, mixed mode, sharing)
> Fedora release 29 (Twenty Nine)
>Reporter: Steven Schlansker
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.12.0
>
>
> Attempting to use maven-pmd-plugin with the newly GA openjdk12 and 
> source/target level 12 results in:
>  
> {code:java}
> Caused by: org.apache.maven.reporting.MavenReportException: Unsupported 
> targetJdk value '12'.
> at org.apache.maven.plugins.pmd.PmdReport.getPMDConfiguration 
> (PmdReport.java:672)
> at org.apache.maven.plugins.pmd.PmdReport.executePmd (PmdReport.java:390)
> at org.apache.maven.plugins.pmd.PmdReport.executePmdWithClassloader 
> (PmdReport.java:355)
> at org.apache.maven.plugins.pmd.PmdReport.canGenerateReport 
> (PmdReport.java:329)
> at org.apache.maven.reporting.AbstractMavenReport.execute 
> (AbstractMavenReport.java:120{code}
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (MPMD-283) Create a real aggregate goal

[Andreas Dangel (JIRA)]

Andreas Dangel created MPMD-283:
---

 Summary: Create a real aggregate goal
 Key: MPMD-283
 URL: https://issues.apache.org/jira/browse/MPMD-283
 Project: Maven PMD Plugin
  Issue Type: Task
  Components: CPD, PMD
Reporter: Andreas Dangel


PMD needs to have the project compiled, before it can analyze it. This is 
required to support typeresolution.

For Multi-modules projects, you can currently set the "aggregate" parameter, to 
create an aggregated report. However, this is executed at the root project 
_before_ all other modules have been built, leading to a potentially inaccurate 
PMD result and false positives.

A separate goal should be introduced, that can execute the compile lifecycle 
prior to executing PMD (similar what javadoc:aggregate does).

 
{code:java}
@Mojo( name = "aggregate", aggregator = true, requiresDependencyResolution = 
ResolutionScope.TEST )
@Execute( phase = LifecyclePhase.COMPILE )
public class AggregatorPMDReport {
...{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (MPMD-277) Plugin tries to download local submodules from repo

[Andreas Dangel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MPMD-277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Dangel closed MPMD-277.
---

> Plugin tries to download local submodules from repo
> ---
>
> Key: MPMD-277
> URL: https://issues.apache.org/jira/browse/MPMD-277
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.11.0
>Reporter: Sylvain
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> My bug seems kinda related to #MPMD-273, but 3.10.0 works for me, not 3.11.0.
>  
> I'm trying to build a multi-module maven project with OpenJDK11 and Maven 
> 3.5.4.
> The project works fine with maven-pmd-plugin 3.10.0, but with 3.11.0, I get 
> this error:
>  
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-pmd-plugin:3.11.0:pmd (pmd) on project parent: 
> Execution pmd of goal org.apache.maven.plugins:maven-pmd-plugin:3.11.0:pmd 
> failed: org.apache.maven.reporting.MavenReportException: 
> org.eclipse.aether.resolution.DependencyResolutionException: Could not find 
> artifact com.incepto.cloud:api-common:jar:0.0.1-SNAPSHOT in spring-repo 
> (https://repo.spring.io/release) -> [Help 1]
>  
> pmd-plugin doesn't have a dependency on api-common, it's the first submodule 
> maven tries to build. The problem doesn't occur if I skip pmd first and let 
> maven install the submodules in the local repo, then re-run the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (MPMD-277) Plugin tries to download local submodules from repo

[Andreas Dangel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MPMD-277?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Dangel resolved MPMD-277.
-
Resolution: Fixed

> Plugin tries to download local submodules from repo
> ---
>
> Key: MPMD-277
> URL: https://issues.apache.org/jira/browse/MPMD-277
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.11.0
>Reporter: Sylvain
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> My bug seems kinda related to #MPMD-273, but 3.10.0 works for me, not 3.11.0.
>  
> I'm trying to build a multi-module maven project with OpenJDK11 and Maven 
> 3.5.4.
> The project works fine with maven-pmd-plugin 3.10.0, but with 3.11.0, I get 
> this error:
>  
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-pmd-plugin:3.11.0:pmd (pmd) on project parent: 
> Execution pmd of goal org.apache.maven.plugins:maven-pmd-plugin:3.11.0:pmd 
> failed: org.apache.maven.reporting.MavenReportException: 
> org.eclipse.aether.resolution.DependencyResolutionException: Could not find 
> artifact com.incepto.cloud:api-common:jar:0.0.1-SNAPSHOT in spring-repo 
> (https://repo.spring.io/release) -> [Help 1]
>  
> pmd-plugin doesn't have a dependency on api-common, it's the first submodule 
> maven tries to build. The problem doesn't occur if I skip pmd first and let 
> maven install the submodules in the local repo, then re-run the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MJAVADOC-539) Upgrading plugin from 3.0.0 to 3.0.1 and 3.1.0 breaks certain external javadoc links

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/MJAVADOC-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814720#comment-16814720
 ] 

Julian Reschke commented on MJAVADOC-539:
-

I agree that the server acts strange (and I tried to get it fixed). But fact 
is, the doctool actually works with that redirect; it's the javadoc maven 
plugin that mangles the URI right now,

> Upgrading plugin from 3.0.0 to 3.0.1 and 3.1.0 breaks certain external 
> javadoc links
> 
>
> Key: MJAVADOC-539
> URL: https://issues.apache.org/jira/browse/MJAVADOC-539
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Julian Reschke
>Assignee: Robert Scholte
>Priority: Major
> Attachments: minimal.zip
>
>
> See https://issues.apache.org/jira/browse/OAK-7789 - downgrading to 3.0.0 
> fixes the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MPMD-277) Plugin tries to download local submodules from repo

[Andreas Dangel (JIRA)]

[ 
https://issues.apache.org/jira/browse/MPMD-277?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814718#comment-16814718
 ] 

Andreas Dangel commented on MPMD-277:
-

This problem was introduced while fixing MPMD-266. When using the option 
"aggregate=true", the classpath was wrong (the modules of the multi-module 
project were missing), but unfortunately not only the compile classpath of 
these modules (e.g. .../target/classes) have been added, but the references to 
the artifacts themselves.

 

While this problem is fixed, you still need to take some care: PMD's results 
might be inaccurate, if the project is not compiled yet - and this happens, 
when "aggregate=true" is used, because then PMD is executed on the root project 
before the modules are built. To workaround this issue, you'll need to build 
your projects first (mvn clean package) and then in a second mvn execution, let 
PMD be executed (e.g. mvn verify).

 

The option "aggregate=true" is most useful for generating a aggregated site 
report (pmd:pmd) during the site lifecycle. But it is not so useful for the 
check-goal (pmd:check) during the "normal" build lifecycle.

 

> Plugin tries to download local submodules from repo
> ---
>
> Key: MPMD-277
> URL: https://issues.apache.org/jira/browse/MPMD-277
> Project: Maven PMD Plugin
>  Issue Type: Bug
>  Components: PMD
>Affects Versions: 3.11.0
>Reporter: Sylvain
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> My bug seems kinda related to #MPMD-273, but 3.10.0 works for me, not 3.11.0.
>  
> I'm trying to build a multi-module maven project with OpenJDK11 and Maven 
> 3.5.4.
> The project works fine with maven-pmd-plugin 3.10.0, but with 3.11.0, I get 
> this error:
>  
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-pmd-plugin:3.11.0:pmd (pmd) on project parent: 
> Execution pmd of goal org.apache.maven.plugins:maven-pmd-plugin:3.11.0:pmd 
> failed: org.apache.maven.reporting.MavenReportException: 
> org.eclipse.aether.resolution.DependencyResolutionException: Could not find 
> artifact com.incepto.cloud:api-common:jar:0.0.1-SNAPSHOT in spring-repo 
> (https://repo.spring.io/release) -> [Help 1]
>  
> pmd-plugin doesn't have a dependency on api-common, it's the first submodule 
> maven tries to build. The problem doesn't occur if I skip pmd first and let 
> maven install the submodules in the local repo, then re-run the build.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (MPMD-281) Display found violations grouped by priority

[Andreas Dangel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MPMD-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Dangel resolved MPMD-281.
-
Resolution: Fixed

> Display found violations grouped by priority
> 
>
> Key: MPMD-281
> URL: https://issues.apache.org/jira/browse/MPMD-281
> Project: Maven PMD Plugin
>  Issue Type: Improvement
>  Components: PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When generating the report, the violations are currently grouped by files.
> It would be useful, if the violations were also grouped by priority, so that 
> one can concentrate on fixing the violations with the highest priority first.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (MPMD-281) Display found violations grouped by priority

[Andreas Dangel (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MPMD-281?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andreas Dangel closed MPMD-281.
---

> Display found violations grouped by priority
> 
>
> Key: MPMD-281
> URL: https://issues.apache.org/jira/browse/MPMD-281
> Project: Maven PMD Plugin
>  Issue Type: Improvement
>  Components: PMD
>Reporter: Andreas Dangel
>Assignee: Andreas Dangel
>Priority: Major
> Fix For: 3.12.0
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> When generating the report, the violations are currently grouped by files.
> It would be useful, if the violations were also grouped by priority, so that 
> one can concentrate on fixing the violations with the highest priority first.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MJAVADOC-539) Upgrading plugin from 3.0.0 to 3.0.1 and 3.1.0 breaks certain external javadoc links

[Robert Scholte (JIRA)]

[ 
https://issues.apache.org/jira/browse/MJAVADOC-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814702#comment-16814702
 ] 

Robert Scholte commented on MJAVADOC-539:
-

I think this is "broken" by MJAVADOC-487, but you could also say that the adobe 
website does something strange. Instead of serving the index.html page by 
default, it sends a http 302 (Redirect) back, containing a link to the 
index.html.

{noformat}
Request URL: https://docs.adobe.com/docs/en/spec/javax.jcr/javadocs/jcr-2.0/
Request Method: GET
Status Code: 302 Found

Response Header contains
Location: 
https://docs.adobe.com/docs/en/spec/javax.jcr/javadocs/jcr-2.0/index.html
{noformat}

The code pastes a / after it to ensure it points to a directory (there were 
issues when there's no / at the end). I guess the fix is to also verify if it 
ends with {{index.html}}

> Upgrading plugin from 3.0.0 to 3.0.1 and 3.1.0 breaks certain external 
> javadoc links
> 
>
> Key: MJAVADOC-539
> URL: https://issues.apache.org/jira/browse/MJAVADOC-539
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Julian Reschke
>Assignee: Robert Scholte
>Priority: Major
> Attachments: minimal.zip
>
>
> See https://issues.apache.org/jira/browse/OAK-7789 - downgrading to 3.0.0 
> fixes the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [maven-pmd-plugin] adangel closed pull request #9: [MPMD-281] Display found violations grouped by priority

[GitBox]

adangel closed pull request #9: [MPMD-281] Display found violations grouped by 
priority
URL: https://github.com/apache/maven-pmd-plugin/pull/9
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-pmd-plugin] adangel commented on issue #9: [MPMD-281] Display found violations grouped by priority

[GitBox]

adangel commented on issue #9: [MPMD-281] Display found violations grouped by 
priority
URL: https://github.com/apache/maven-pmd-plugin/pull/9#issuecomment-481788402
 
 
   Merged as 
https://github.com/apache/maven-pmd-plugin/commit/7649a42a108c19481d22b5c8cdf2295d62cd3693


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-pmd-plugin] adangel merged pull request #10: [MPMD-277] Plugin tries to download local submodules from repo

[GitBox]

adangel merged pull request #10: [MPMD-277] Plugin tries to download local 
submodules from repo
URL: https://github.com/apache/maven-pmd-plugin/pull/10
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-pmd-plugin] adangel commented on issue #10: [MPMD-277] Plugin tries to download local submodules from repo

[GitBox]

adangel commented on issue #10: [MPMD-277] Plugin tries to download local 
submodules from repo
URL: https://github.com/apache/maven-pmd-plugin/pull/10#issuecomment-481785739
 
 
   Jenkins build is successful: 
https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-pmd-plugin/job/MPMD-277/


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Closed] (MNG-6628) Upgraded maven from 3.3.9 to 3.6.0 and my code stoped compiling

[Robert Scholte (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte closed MNG-6628.
---
Resolution: Not A Problem
  Assignee: Robert Scholte

You should contact the maintainers of the io.thorntail:thorntail-maven-plugin 
to make their plugin compatible with Maven 3.6.0

> Upgraded maven from 3.3.9 to 3.6.0 and my code stoped compiling
> ---
>
> Key: MNG-6628
> URL: https://issues.apache.org/jira/browse/MNG-6628
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.6.0
>Reporter: Peter Ivarsson
>Assignee: Robert Scholte
>Priority: Major
> Attachments: 3.6.0_bug
>
>
> After updating maven from 3.3.9 to 3.6.0 my code stoped compileing with an 
> stänge error.
> {noformat}
> Failed to execute goal 
> io.thorntail:thorntail-maven-plugin:2.2.1.Final:package (default) on project 
> events: Execution default of goal 
> io.thorntail:thorntail-maven-plugin:2.2.1.Final:package failed: An API 
> incompatibility was encountered while executing 
> io.thorntail:thorntail-maven-plugin:2.2.1.Final:package: 
> java.lang.AbstractMethodError: Receiver class 
> org.wildfly.swarm.maven.utils.RepositorySystemSessionWrapper does not define 
> or inherit an implementation of the resolved method abstract 
> getFileTransformerManager()Lorg/eclipse/aether/transform/FileTransformerManager;
>  of interface org.eclipse.aether.RepositorySystemSession.
> -
> realm = plugin>io.thorntail:thorntail-maven-plugin:2.2.1.Final
> strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> urls[0] = 
> file:/Users/piv/.m2/repository/io/thorntail/thorntail-maven-plugin/2.2.1.Final/thorntail-maven-plugin-2.2.1.Final.jar
> urls[1] = 
> file:/Users/piv/.m2/repository/io/thorntail/fraction-metadata/2.2.1.Final/fraction-metadata-2.2.1.Final.jar
> urls[2] = 
> file:/Users/piv/.m2/repository/io/thorntail/meta-spi/2.2.1.Final/meta-spi-2.2.1.Final.jar
> urls[3] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-impl-javaee/2.0.0/shrinkwrap-descriptors-impl-javaee-2.0.0.jar
> urls[4] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-impl-base/2.0.0/shrinkwrap-descriptors-impl-base-2.0.0.jar
> urls[5] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-spi/2.0.0/shrinkwrap-descriptors-spi-2.0.0.jar
> urls[6] = file:/Users/piv/.m2/repository/org/ow2/asm/asm/6.0/asm-6.0.jar
> urls[7] = 
> file:/Users/piv/.m2/repository/com/eclipsesource/minimal-json/minimal-json/0.9.4/minimal-json-0.9.4.jar
> urls[8] = 
> file:/Users/piv/.m2/repository/io/thorntail/tools/2.2.1.Final/tools-2.2.1.Final.jar
> urls[9] = 
> file:/Users/piv/.m2/repository/io/thorntail/bootstrap/2.2.1.Final/bootstrap-2.2.1.Final.jar
> urls[10] = 
> file:/Users/piv/.m2/repository/org/jboss/modules/jboss-modules/1.6.4.Final/jboss-modules-1.6.4.Final.jar
> urls[11] = 
> file:/Users/piv/.m2/repository/org/yaml/snakeyaml/1.17/snakeyaml-1.17.jar
> urls[12] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/shrinkwrap-api/1.2.6/shrinkwrap-api-1.2.6.jar
> urls[13] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/shrinkwrap-spi/1.2.6/shrinkwrap-spi-1.2.6.jar
> urls[14] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/shrinkwrap-impl-base/1.2.6/shrinkwrap-impl-base-1.2.6.jar
> urls[15] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-api-jboss/2.0.0/shrinkwrap-descriptors-api-jboss-2.0.0.jar
> urls[16] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-api-javaee/2.0.0/shrinkwrap-descriptors-api-javaee-2.0.0.jar
> urls[17] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-api-base/2.0.0/shrinkwrap-descriptors-api-base-2.0.0.jar
> urls[18] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-impl-jboss/2.0.0/shrinkwrap-descriptors-impl-jboss-2.0.0.jar
> urls[19] = 
> file:/Users/piv/.m2/repository/net/lingala/zip4j/zip4j/1.3.2/zip4j-1.3.2.jar
> urls[20] = 
> file:/Users/piv/.m2/repository/io/thorntail/spi/2.2.1.Final/spi-2.2.1.Final.jar
> urls[21] = 
> file:/Users/piv/.m2/repository/org/jboss/jandex/2.0.5.Final/jandex-2.0.5.Final.jar
> urls[22] = 
> file:/Users/piv/.m2/repository/org/codehaus/plexus/plexus-utils/3.0.20/plexus-utils-3.0.20.jar
> urls[23] = 
> file:/Users/piv/.m2/repository/org/eclipse/aether/aether-util/1.0.0.v20140518/aether-util-1.0.0.v20140518.jar
> urls[24] = 
> file:/Users/piv/.m2/repository/io/thorntail/maven-utils/2.2.1.Final/maven-utils-2.2.1.Final.jar
> urls[25] = 
> 

[jira] [Updated] (MNG-6628) Upgraded maven from 3.3.9 to 3.6.0 and my code stoped compiling

[Robert Scholte (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Scholte updated MNG-6628:

Description: 
After updating maven from 3.3.9 to 3.6.0 my code stoped compileing with an 
stänge error.
{noformat}
Failed to execute goal io.thorntail:thorntail-maven-plugin:2.2.1.Final:package 
(default) on project events: Execution default of goal 
io.thorntail:thorntail-maven-plugin:2.2.1.Final:package failed: An API 
incompatibility was encountered while executing 
io.thorntail:thorntail-maven-plugin:2.2.1.Final:package: 
java.lang.AbstractMethodError: Receiver class 
org.wildfly.swarm.maven.utils.RepositorySystemSessionWrapper does not define or 
inherit an implementation of the resolved method abstract 
getFileTransformerManager()Lorg/eclipse/aether/transform/FileTransformerManager;
 of interface org.eclipse.aether.RepositorySystemSession.
-
realm = plugin>io.thorntail:thorntail-maven-plugin:2.2.1.Final
strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
urls[0] = 
file:/Users/piv/.m2/repository/io/thorntail/thorntail-maven-plugin/2.2.1.Final/thorntail-maven-plugin-2.2.1.Final.jar
urls[1] = 
file:/Users/piv/.m2/repository/io/thorntail/fraction-metadata/2.2.1.Final/fraction-metadata-2.2.1.Final.jar
urls[2] = 
file:/Users/piv/.m2/repository/io/thorntail/meta-spi/2.2.1.Final/meta-spi-2.2.1.Final.jar
urls[3] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-impl-javaee/2.0.0/shrinkwrap-descriptors-impl-javaee-2.0.0.jar
urls[4] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-impl-base/2.0.0/shrinkwrap-descriptors-impl-base-2.0.0.jar
urls[5] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-spi/2.0.0/shrinkwrap-descriptors-spi-2.0.0.jar
urls[6] = file:/Users/piv/.m2/repository/org/ow2/asm/asm/6.0/asm-6.0.jar
urls[7] = 
file:/Users/piv/.m2/repository/com/eclipsesource/minimal-json/minimal-json/0.9.4/minimal-json-0.9.4.jar
urls[8] = 
file:/Users/piv/.m2/repository/io/thorntail/tools/2.2.1.Final/tools-2.2.1.Final.jar
urls[9] = 
file:/Users/piv/.m2/repository/io/thorntail/bootstrap/2.2.1.Final/bootstrap-2.2.1.Final.jar
urls[10] = 
file:/Users/piv/.m2/repository/org/jboss/modules/jboss-modules/1.6.4.Final/jboss-modules-1.6.4.Final.jar
urls[11] = 
file:/Users/piv/.m2/repository/org/yaml/snakeyaml/1.17/snakeyaml-1.17.jar
urls[12] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/shrinkwrap-api/1.2.6/shrinkwrap-api-1.2.6.jar
urls[13] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/shrinkwrap-spi/1.2.6/shrinkwrap-spi-1.2.6.jar
urls[14] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/shrinkwrap-impl-base/1.2.6/shrinkwrap-impl-base-1.2.6.jar
urls[15] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-api-jboss/2.0.0/shrinkwrap-descriptors-api-jboss-2.0.0.jar
urls[16] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-api-javaee/2.0.0/shrinkwrap-descriptors-api-javaee-2.0.0.jar
urls[17] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-api-base/2.0.0/shrinkwrap-descriptors-api-base-2.0.0.jar
urls[18] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-impl-jboss/2.0.0/shrinkwrap-descriptors-impl-jboss-2.0.0.jar
urls[19] = 
file:/Users/piv/.m2/repository/net/lingala/zip4j/zip4j/1.3.2/zip4j-1.3.2.jar
urls[20] = 
file:/Users/piv/.m2/repository/io/thorntail/spi/2.2.1.Final/spi-2.2.1.Final.jar
urls[21] = 
file:/Users/piv/.m2/repository/org/jboss/jandex/2.0.5.Final/jandex-2.0.5.Final.jar
urls[22] = 
file:/Users/piv/.m2/repository/org/codehaus/plexus/plexus-utils/3.0.20/plexus-utils-3.0.20.jar
urls[23] = 
file:/Users/piv/.m2/repository/org/eclipse/aether/aether-util/1.0.0.v20140518/aether-util-1.0.0.v20140518.jar
urls[24] = 
file:/Users/piv/.m2/repository/io/thorntail/maven-utils/2.2.1.Final/maven-utils-2.2.1.Final.jar
urls[25] = 
file:/Users/piv/.m2/repository/org/jooq/joox-java-6/1.6.0/joox-java-6-1.6.0.jar
urls[26] = 
file:/Users/piv/.m2/repository/javax/xml/bind/jaxb-api/2.3.0/jaxb-api-2.3.0.jar
Number of foreign imports: 1
import: Entry[import from realm ClassRealm[maven.api, parent: null]]
{noformat}
 

 

  was:
After updating maven from 3.3.9 to 3.6.0 my code stoped compileing with an 
stänge error.

Failed to execute goal io.thorntail:thorntail-maven-plugin:2.2.1.Final:package 
(default) on project events: Execution default of goal 
io.thorntail:thorntail-maven-plugin:2.2.1.Final:package failed: An API 
incompatibility was encountered while executing 
io.thorntail:thorntail-maven-plugin:2.2.1.Final:package: 
java.lang.AbstractMethodError: Receiver class 
org.wildfly.swarm.maven.utils.RepositorySystemSessionWrapper does not define or 
inherit an implementation of 

[jira] [Commented] (MNGSITE-365) EOL page surprisingly links to current M3 plugins

[Paul Benedict (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNGSITE-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814570#comment-16814570
 ] 

Paul Benedict commented on MNGSITE-365:
---

Yes.

> EOL page surprisingly links to current M3 plugins
> -
>
> Key: MNGSITE-365
> URL: https://issues.apache.org/jira/browse/MNGSITE-365
> Project: Maven Project Web Site
>  Issue Type: Improvement
>Reporter: Paul Benedict
>Assignee: Paul Benedict
>Priority: Trivial
>
> The EOL page has links on "Plugin" and "Version" columns. The former links to 
> the current plugin sites; the second links to the last M2 versions, 
> respectively.
> An unsuspecting user (like me!) was clicking through the "Plugin" column, and 
> didn't realize it was the current documentation. This is a small usability 
> issue, but one I believe should be fixed. I am supporting ancient M2 stuff so 
> I come to the page often. The links are too good of a trap.
> Recommendation:
>  # Set the "Plugin" links to their EOL versions.
>  # Amend the "Plugin" values to include the V of the GAV (to make explicit 
> the connection between the two columns). Example: {{clean:2.6.1}}
>  # Remove the "Version" links.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [maven-surefire] dfa1 commented on issue #227: defaulting trimStackTrace to false

[GitBox]

dfa1 commented on issue #227: defaulting trimStackTrace to false
URL: https://github.com/apache/maven-surefire/pull/227#issuecomment-481667770
 
 
   @Tibor17 hello again, sorry for late reply but I was in a family trip. 
   
   Do I need to push to release branches without creating a PR? I need some 
guidance here. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MNG-6604) Intermittent failures while downloading GAVs from Nexus

[Igor Fedorenko (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814378#comment-16814378
 ] 

Igor Fedorenko commented on MNG-6604:
-

I have not looked at Maven for several years now, so can't comment on the 
current state of affairs. Here is what I remember from the distant past

talari-local-repo is broken, don't use use it. 
[https://github.com/takari/takari-local-repository/issues/5] 
[https://github.com/takari/takari-local-repository/issues/4.] 

-Daether.connector.resumeDownload=false may help workaround aether local repo 
concurrency bugs.

You probably want to use [https://github.com/takari/takari-smart-builder] to 
build on multiple threads. [https://github.com/takari/concurrent-build-logger] 
maybe useful too.

Good luck.

 

> Intermittent failures while downloading GAVs from Nexus
> ---
>
> Key: MNG-6604
> URL: https://issues.apache.org/jira/browse/MNG-6604
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line, Toolchains
>Affects Versions: 3.6.0
> Environment: Nexus OSS 3.15.2-01
> Docker 18.09.2 on Ubuntu 18.04.2 LTS
> Gitlab runner 11.8.0
>Reporter: Ivan Rizzante
>Priority: Major
> Attachments: docker-env.txt, log.txt
>
>
> Hello
> we're running maven 3.6.0 builds in a docker container and we use Nexus OSS 
> configured as proxy for Maven Central.
> While running our builds using Gitlab CI, we're experiencing intermittent 
> build failures because Maven cannot find artifacts in Nexus which we verified 
> they are actually available.
> Error example below:
> {noformat}
> 20744 [main] [ERROR] Failed to execute goal on project EcotransitWSClient: 
> Could not resolve dependencies for project 
> it.sdb.ecotransit:EcotransitWSClient:jar:7.0.1-SNAPSHOT: Could not transfer 
> artifact commons-beanutils:commons-beanutils:jar:1.9.3 from/to nexus 
> (http://maven-repo.sdb.it:8081/repository/maven-public/): 
> /builds/sdb/webportal/.m2/repository/commons-beanutils/commons-beanutils/1.9.3/commons-beanutils-1.9.3.jar.part
>  (No such file or directory) -> [Help 1]
> {noformat}
> I attached the full maven build log and our Docker env settings.
> We tried disabling the keep alive and also disabling the connection pooling 
> but nothing seems to fix the issue.
>  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (MNG-6628) Upgraded maven from 3.3.9 to 3.6.0 and my code stoped compiling

[Peter Ivarsson (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MNG-6628?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Peter Ivarsson updated MNG-6628:

Attachment: 3.6.0_bug

> Upgraded maven from 3.3.9 to 3.6.0 and my code stoped compiling
> ---
>
> Key: MNG-6628
> URL: https://issues.apache.org/jira/browse/MNG-6628
> Project: Maven
>  Issue Type: Bug
>  Components: Bootstrap  Build
>Affects Versions: 3.6.0
>Reporter: Peter Ivarsson
>Priority: Major
> Attachments: 3.6.0_bug
>
>
> After updating maven from 3.3.9 to 3.6.0 my code stoped compileing with an 
> stänge error.
> Failed to execute goal 
> io.thorntail:thorntail-maven-plugin:2.2.1.Final:package (default) on project 
> events: Execution default of goal 
> io.thorntail:thorntail-maven-plugin:2.2.1.Final:package failed: An API 
> incompatibility was encountered while executing 
> io.thorntail:thorntail-maven-plugin:2.2.1.Final:package: 
> java.lang.AbstractMethodError: Receiver class 
> org.wildfly.swarm.maven.utils.RepositorySystemSessionWrapper does not define 
> or inherit an implementation of the resolved method abstract 
> getFileTransformerManager()Lorg/eclipse/aether/transform/FileTransformerManager;
>  of interface org.eclipse.aether.RepositorySystemSession.
> -
> realm = plugin>io.thorntail:thorntail-maven-plugin:2.2.1.Final
> strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> urls[0] = 
> file:/Users/piv/.m2/repository/io/thorntail/thorntail-maven-plugin/2.2.1.Final/thorntail-maven-plugin-2.2.1.Final.jar
> urls[1] = 
> file:/Users/piv/.m2/repository/io/thorntail/fraction-metadata/2.2.1.Final/fraction-metadata-2.2.1.Final.jar
> urls[2] = 
> file:/Users/piv/.m2/repository/io/thorntail/meta-spi/2.2.1.Final/meta-spi-2.2.1.Final.jar
> urls[3] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-impl-javaee/2.0.0/shrinkwrap-descriptors-impl-javaee-2.0.0.jar
> urls[4] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-impl-base/2.0.0/shrinkwrap-descriptors-impl-base-2.0.0.jar
> urls[5] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-spi/2.0.0/shrinkwrap-descriptors-spi-2.0.0.jar
> urls[6] = file:/Users/piv/.m2/repository/org/ow2/asm/asm/6.0/asm-6.0.jar
> urls[7] = 
> file:/Users/piv/.m2/repository/com/eclipsesource/minimal-json/minimal-json/0.9.4/minimal-json-0.9.4.jar
> urls[8] = 
> file:/Users/piv/.m2/repository/io/thorntail/tools/2.2.1.Final/tools-2.2.1.Final.jar
> urls[9] = 
> file:/Users/piv/.m2/repository/io/thorntail/bootstrap/2.2.1.Final/bootstrap-2.2.1.Final.jar
> urls[10] = 
> file:/Users/piv/.m2/repository/org/jboss/modules/jboss-modules/1.6.4.Final/jboss-modules-1.6.4.Final.jar
> urls[11] = 
> file:/Users/piv/.m2/repository/org/yaml/snakeyaml/1.17/snakeyaml-1.17.jar
> urls[12] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/shrinkwrap-api/1.2.6/shrinkwrap-api-1.2.6.jar
> urls[13] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/shrinkwrap-spi/1.2.6/shrinkwrap-spi-1.2.6.jar
> urls[14] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/shrinkwrap-impl-base/1.2.6/shrinkwrap-impl-base-1.2.6.jar
> urls[15] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-api-jboss/2.0.0/shrinkwrap-descriptors-api-jboss-2.0.0.jar
> urls[16] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-api-javaee/2.0.0/shrinkwrap-descriptors-api-javaee-2.0.0.jar
> urls[17] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-api-base/2.0.0/shrinkwrap-descriptors-api-base-2.0.0.jar
> urls[18] = 
> file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-impl-jboss/2.0.0/shrinkwrap-descriptors-impl-jboss-2.0.0.jar
> urls[19] = 
> file:/Users/piv/.m2/repository/net/lingala/zip4j/zip4j/1.3.2/zip4j-1.3.2.jar
> urls[20] = 
> file:/Users/piv/.m2/repository/io/thorntail/spi/2.2.1.Final/spi-2.2.1.Final.jar
> urls[21] = 
> file:/Users/piv/.m2/repository/org/jboss/jandex/2.0.5.Final/jandex-2.0.5.Final.jar
> urls[22] = 
> file:/Users/piv/.m2/repository/org/codehaus/plexus/plexus-utils/3.0.20/plexus-utils-3.0.20.jar
> urls[23] = 
> file:/Users/piv/.m2/repository/org/eclipse/aether/aether-util/1.0.0.v20140518/aether-util-1.0.0.v20140518.jar
> urls[24] = 
> file:/Users/piv/.m2/repository/io/thorntail/maven-utils/2.2.1.Final/maven-utils-2.2.1.Final.jar
> urls[25] = 
> file:/Users/piv/.m2/repository/org/jooq/joox-java-6/1.6.0/joox-java-6-1.6.0.jar
> urls[26] = 
> file:/Users/piv/.m2/repository/javax/xml/bind/jaxb-api/2.3.0/jaxb-api-2.3.0.jar
> Number of foreign imports: 1
> import: Entry[import from realm 

[jira] [Created] (MNG-6628) Upgraded maven from 3.3.9 to 3.6.0 and my code stoped compiling

[Peter Ivarsson (JIRA)]

Peter Ivarsson created MNG-6628:
---

 Summary: Upgraded maven from 3.3.9 to 3.6.0 and my code stoped 
compiling
 Key: MNG-6628
 URL: https://issues.apache.org/jira/browse/MNG-6628
 Project: Maven
  Issue Type: Bug
  Components: Bootstrap  Build
Affects Versions: 3.6.0
Reporter: Peter Ivarsson


After updating maven from 3.3.9 to 3.6.0 my code stoped compileing with an 
stänge error.

Failed to execute goal io.thorntail:thorntail-maven-plugin:2.2.1.Final:package 
(default) on project events: Execution default of goal 
io.thorntail:thorntail-maven-plugin:2.2.1.Final:package failed: An API 
incompatibility was encountered while executing 
io.thorntail:thorntail-maven-plugin:2.2.1.Final:package: 
java.lang.AbstractMethodError: Receiver class 
org.wildfly.swarm.maven.utils.RepositorySystemSessionWrapper does not define or 
inherit an implementation of the resolved method abstract 
getFileTransformerManager()Lorg/eclipse/aether/transform/FileTransformerManager;
 of interface org.eclipse.aether.RepositorySystemSession.
-
realm = plugin>io.thorntail:thorntail-maven-plugin:2.2.1.Final
strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
urls[0] = 
file:/Users/piv/.m2/repository/io/thorntail/thorntail-maven-plugin/2.2.1.Final/thorntail-maven-plugin-2.2.1.Final.jar
urls[1] = 
file:/Users/piv/.m2/repository/io/thorntail/fraction-metadata/2.2.1.Final/fraction-metadata-2.2.1.Final.jar
urls[2] = 
file:/Users/piv/.m2/repository/io/thorntail/meta-spi/2.2.1.Final/meta-spi-2.2.1.Final.jar
urls[3] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-impl-javaee/2.0.0/shrinkwrap-descriptors-impl-javaee-2.0.0.jar
urls[4] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-impl-base/2.0.0/shrinkwrap-descriptors-impl-base-2.0.0.jar
urls[5] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-spi/2.0.0/shrinkwrap-descriptors-spi-2.0.0.jar
urls[6] = file:/Users/piv/.m2/repository/org/ow2/asm/asm/6.0/asm-6.0.jar
urls[7] = 
file:/Users/piv/.m2/repository/com/eclipsesource/minimal-json/minimal-json/0.9.4/minimal-json-0.9.4.jar
urls[8] = 
file:/Users/piv/.m2/repository/io/thorntail/tools/2.2.1.Final/tools-2.2.1.Final.jar
urls[9] = 
file:/Users/piv/.m2/repository/io/thorntail/bootstrap/2.2.1.Final/bootstrap-2.2.1.Final.jar
urls[10] = 
file:/Users/piv/.m2/repository/org/jboss/modules/jboss-modules/1.6.4.Final/jboss-modules-1.6.4.Final.jar
urls[11] = 
file:/Users/piv/.m2/repository/org/yaml/snakeyaml/1.17/snakeyaml-1.17.jar
urls[12] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/shrinkwrap-api/1.2.6/shrinkwrap-api-1.2.6.jar
urls[13] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/shrinkwrap-spi/1.2.6/shrinkwrap-spi-1.2.6.jar
urls[14] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/shrinkwrap-impl-base/1.2.6/shrinkwrap-impl-base-1.2.6.jar
urls[15] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-api-jboss/2.0.0/shrinkwrap-descriptors-api-jboss-2.0.0.jar
urls[16] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-api-javaee/2.0.0/shrinkwrap-descriptors-api-javaee-2.0.0.jar
urls[17] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-api-base/2.0.0/shrinkwrap-descriptors-api-base-2.0.0.jar
urls[18] = 
file:/Users/piv/.m2/repository/org/jboss/shrinkwrap/descriptors/shrinkwrap-descriptors-impl-jboss/2.0.0/shrinkwrap-descriptors-impl-jboss-2.0.0.jar
urls[19] = 
file:/Users/piv/.m2/repository/net/lingala/zip4j/zip4j/1.3.2/zip4j-1.3.2.jar
urls[20] = 
file:/Users/piv/.m2/repository/io/thorntail/spi/2.2.1.Final/spi-2.2.1.Final.jar
urls[21] = 
file:/Users/piv/.m2/repository/org/jboss/jandex/2.0.5.Final/jandex-2.0.5.Final.jar
urls[22] = 
file:/Users/piv/.m2/repository/org/codehaus/plexus/plexus-utils/3.0.20/plexus-utils-3.0.20.jar
urls[23] = 
file:/Users/piv/.m2/repository/org/eclipse/aether/aether-util/1.0.0.v20140518/aether-util-1.0.0.v20140518.jar
urls[24] = 
file:/Users/piv/.m2/repository/io/thorntail/maven-utils/2.2.1.Final/maven-utils-2.2.1.Final.jar
urls[25] = 
file:/Users/piv/.m2/repository/org/jooq/joox-java-6/1.6.0/joox-java-6-1.6.0.jar
urls[26] = 
file:/Users/piv/.m2/repository/javax/xml/bind/jaxb-api/2.3.0/jaxb-api-2.3.0.jar
Number of foreign imports: 1
import: Entry[import from realm ClassRealm[maven.api, parent: null]]

 

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [maven] oehme edited a comment on issue #242: Speed up project discovery

[GitBox]

oehme edited a comment on issue #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#issuecomment-481630398
 
 
   ~The last commit seems to be problematic, some core-its around 
ArtifactHandler are failing. I'm not yet sure I understand why - Can the 
artifact handler for a given type change over time? I thought the idea is to 
only add additional handlers for new types?~
   
   Nevermind, I got it - We can't remember the `DefaultArtifactHandler` created 
for unknown types, as that might later be replaced with a better handler by an 
extension.
   
   All integration tests are passing now.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme edited a comment on issue #242: Speed up project discovery

[GitBox]

oehme edited a comment on issue #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#issuecomment-481630398
 
 
   ~The last commit seems to be problematic, some core-its around 
ArtifactHandler are failing. I'm not yet sure I understand why - Can the 
artifact handler for a given type change over time? I thought the idea is to 
only add additional handlers for new types?~~
   
   Nevermind, I got it - We can't remember the `DefaultArtifactHandler` created 
for unknown types, as that might later be replaced with a better handler by an 
extension.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme edited a comment on issue #242: Speed up project discovery

[GitBox]

oehme edited a comment on issue #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#issuecomment-481630398
 
 
   ~The last commit seems to be problematic, some core-its around 
ArtifactHandler are failing. I'm not yet sure I understand why - Can the 
artifact handler for a given type change over time? I thought the idea is to 
only add additional handlers for new types?~
   
   Nevermind, I got it - We can't remember the `DefaultArtifactHandler` created 
for unknown types, as that might later be replaced with a better handler by an 
extension.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme commented on issue #242: Speed up project discovery

[GitBox]

oehme commented on issue #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#issuecomment-481630398
 
 
   The last commit seems to be problematic, some core-its around 
ArtifactHandler are failing. I'm not yet sure I understand why - Can the 
artifact handler for a given type change over time? I thought the idea is to 
only add additional handlers for new types?


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme commented on issue #242: Speed up project discovery

[GitBox]

oehme commented on issue #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#issuecomment-481618896
 
 
   Project discovery on the project took ~5min before, now down to ~3min. Still 
a long way to go, but a good improvement :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-compiler-plugin] hendriks73 commented on issue #15: (doc) Fixed broken links to scm, issue tracker, and mailing list page.

[GitBox]

hendriks73 commented on issue #15: (doc) Fixed broken links to scm, issue 
tracker, and mailing list page.
URL: 
https://github.com/apache/maven-compiler-plugin/pull/15#issuecomment-481610240
 
 
   Thanks for merging!


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven-compiler-plugin] olamy merged pull request #15: (doc) Fixed broken links to scm, issue tracker, and mailing list page.

[GitBox]

olamy merged pull request #15: (doc) Fixed broken links to scm, issue tracker, 
and mailing list page.
URL: https://github.com/apache/maven-compiler-plugin/pull/15
 
 
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [maven] oehme commented on issue #242: Speed up project discovery

[GitBox]

oehme commented on issue #242: Speed up project discovery
URL: https://github.com/apache/maven/pull/242#issuecomment-481592374
 
 
   Note that 3 core-it tests were failing for me, but they also fail with Maven 
3.6.0, so they are probably environment dependent. Are there any specific 
requirements for these tests? I'd really like to see a fully green build :)


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MCOMPILER-360) NPE when calculating modulepath with invalid entries

[Hendrik Schreiber (JIRA)]

[ 
https://issues.apache.org/jira/browse/MCOMPILER-360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814166#comment-16814166
 ] 

Hendrik Schreiber commented on MCOMPILER-360:
-

Any idea when this fix will be released?

> NPE when calculating modulepath with invalid entries
> 
>
> Key: MCOMPILER-360
> URL: https://issues.apache.org/jira/browse/MCOMPILER-360
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Affects Versions: 3.8.0
> Environment: Linux 4.9.0-8-amd64 #1 SMP Debian 4.9.110-3+deb9u4 
> (2018-08-21) x86_64 GNU/Linux
> java version "10.0.2" 2018-07-17
> Apache Maven 3.5.4 
>Reporter: Rolf Schumacher
>Assignee: Robert Scholte
>Priority: Major
>  Labels: build, maven, newbie
> Fix For: 3.8.1
>
> Attachments: 2018-09-06-stacktrace.txt, MCOMPILER-360.tar.gz, 
> mvn-verify-result.txt, with-Dinvoker.txt
>
>
> Trying to migrate an saxon/fop maven project to Java 10.
> Added module-info.java, entered all required Automatic names. No compiler 
> failures in Eclipse. Running "mvn -e test" leads to 2 warnings and a 
> maven-compile-plugin error
> Failed to execute goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile 
> (default-compile) on project xslt: Execution default-compile of goal 
> org.apache.maven.plugins:maven-compiler-plugin:3.8.0:compile failed. 
> NullPointerException -> [Help 1]
> Full output is attached.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[GitHub] [maven-compiler-plugin] hendriks73 opened a new pull request #15: (doc) Fixed broken links to scm, issue tracker, and mailing list page.

[GitBox]

hendriks73 opened a new pull request #15: (doc) Fixed broken links to scm, 
issue tracker, and mailing list page.
URL: https://github.com/apache/maven-compiler-plugin/pull/15
 
 
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [x] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[jira] [Commented] (MJAVADOC-539) Upgrading plugin from 3.0.0 to 3.0.1 and 3.1.0 breaks certain external javadoc links

[Julian Reschke (JIRA)]

[ 
https://issues.apache.org/jira/browse/MJAVADOC-539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814157#comment-16814157
 ] 

Julian Reschke commented on MJAVADOC-539:
-

Attaching 
 and 
testing with jdk 8:

Testing with 3.0.0 (pass):
{noformat}
[INFO] Scanning for projects...
[INFO]
[INFO] 
[INFO] Building test 21
[INFO] 
[INFO]
[INFO] >>> maven-javadoc-plugin:3.0.0:javadoc (default-cli) > generate-sources 
@ test >>>
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ test 
---
[INFO]
[INFO] <<< maven-javadoc-plugin:3.0.0:javadoc (default-cli) < generate-sources 
@ test <<<
[INFO]
[INFO]
[INFO] --- maven-javadoc-plugin:3.0.0:javadoc (default-cli) @ test ---
[INFO]
Loading source file C:\projects\apache\minimal\src\main\java\Main.java...
Constructing Javadoc information...
Standard Doclet version 1.8.0_172
Building tree for all the packages and classes...
Generating C:\projects\apache\minimal\target\site\apidocs\Main.html...
Generating C:\projects\apache\minimal\target\site\apidocs\package-frame.html...
Generating 
C:\projects\apache\minimal\target\site\apidocs\package-summary.html...
Generating C:\projects\apache\minimal\target\site\apidocs\package-tree.html...
Generating 
C:\projects\apache\minimal\target\site\apidocs\constant-values.html...
Generating C:\projects\apache\minimal\target\site\apidocs\class-use\Main.html...
Generating C:\projects\apache\minimal\target\site\apidocs\package-use.html...
Building index for all the packages and classes...
Generating C:\projects\apache\minimal\target\site\apidocs\overview-tree.html...
Generating C:\projects\apache\minimal\target\site\apidocs\index-all.html...
Generating 
C:\projects\apache\minimal\target\site\apidocs\deprecated-list.html...
Building index for all classes...
Generating 
C:\projects\apache\minimal\target\site\apidocs\allclasses-frame.html...
Generating 
C:\projects\apache\minimal\target\site\apidocs\allclasses-noframe.html...
Generating C:\projects\apache\minimal\target\site\apidocs\index.html...
Generating C:\projects\apache\minimal\target\site\apidocs\help-doc.html...
[INFO] 
[INFO] BUILD SUCCESS
[INFO] 
[INFO] Total time: 2.838 s
[INFO] Finished at: 2019-04-10T09:38:55+02:00
[INFO] Final Memory: 18M/307M
[INFO] 
{noformat}

Testing with 3.1.0 (fail):
{noformat}
[INFO] Scanning for projects...
[INFO]
[INFO] 
[INFO] Building test 21
[INFO] 
[INFO]
[INFO] >>> maven-javadoc-plugin:3.1.0:javadoc (default-cli) > generate-sources 
@ test >>>
[INFO]
[INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven-version) @ test 
---
[INFO]
[INFO] <<< maven-javadoc-plugin:3.1.0:javadoc (default-cli) < generate-sources 
@ test <<<
[INFO]
[INFO]
[INFO] --- maven-javadoc-plugin:3.1.0:javadoc (default-cli) @ test ---
[INFO]
Loading source file C:\projects\apache\minimal\src\main\java\Main.java...
Constructing Javadoc information...
Standard Doclet version 1.8.0_172
Building tree for all the packages and classes...
Generating C:\projects\apache\minimal\target\site\apidocs\Main.html...
Generating C:\projects\apache\minimal\target\site\apidocs\package-frame.html...
Generating 
C:\projects\apache\minimal\target\site\apidocs\package-summary.html...
Generating C:\projects\apache\minimal\target\site\apidocs\package-tree.html...
Generating 
C:\projects\apache\minimal\target\site\apidocs\constant-values.html...
Generating C:\projects\apache\minimal\target\site\apidocs\class-use\Main.html...
Generating C:\projects\apache\minimal\target\site\apidocs\package-use.html...
Building index for all the packages and classes...
Generating C:\projects\apache\minimal\target\site\apidocs\overview-tree.html...
Generating C:\projects\apache\minimal\target\site\apidocs\index-all.html...
Generating 
C:\projects\apache\minimal\target\site\apidocs\deprecated-list.html...
Building index for all classes...
Generating 
C:\projects\apache\minimal\target\site\apidocs\allclasses-frame.html...
Generating 
C:\projects\apache\minimal\target\site\apidocs\allclasses-noframe.html...
Generating C:\projects\apache\minimal\target\site\apidocs\index.html...
Generating C:\projects\apache\minimal\target\site\apidocs\help-doc.html...
1 warning
[WARNING] Javadoc Warnings
[WARNING] javadoc: warning - Error fetching URL: 
https://docs.adobe.com/docs/en/spec/javax.jcr/javadocs/jcr-2.0/index.html/
[INFO] 

[jira] [Updated] (MJAVADOC-539) Upgrading plugin from 3.0.0 to 3.0.1 and 3.1.0 breaks certain external javadoc links

[Julian Reschke (JIRA)]

 [ 
https://issues.apache.org/jira/browse/MJAVADOC-539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Julian Reschke updated MJAVADOC-539:

Attachment: minimal.zip

> Upgrading plugin from 3.0.0 to 3.0.1 and 3.1.0 breaks certain external 
> javadoc links
> 
>
> Key: MJAVADOC-539
> URL: https://issues.apache.org/jira/browse/MJAVADOC-539
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Julian Reschke
>Assignee: Robert Scholte
>Priority: Major
> Attachments: minimal.zip
>
>
> See https://issues.apache.org/jira/browse/OAK-7789 - downgrading to 3.0.0 
> fixes the issue.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6613) Mirror matching ignores closest/nearest definition

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814137#comment-16814137
 ] 

Hudson commented on MNG-6613:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-5666 #18

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5666/18/

> Mirror matching ignores closest/nearest definition
> --
>
> Key: MNG-6613
> URL: https://issues.apache.org/jira/browse/MNG-6613
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.5.4, 3.6.1
> Environment: Java 8u202, Java11u2
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: log.txt
>
>
> Ran our IT suite in a locked down environment at work, w/o direct internet 
> access. IT {{mng3461MirrorMatching(itNonGreedyWildcard)}} blocks forever 
> because the mirror exclude does not work: {{*,!maven-core-it}}.
> It still tries to download via mirror instead of ignoring it. See attached 
> log file. Even switching {{!maven-core-it,*}} makes no difference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6506) Mojos are unable to load package annotations on Java >= 9

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814138#comment-16814138
 ] 

Hudson commented on MNG-6506:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-5666 #18

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5666/18/

> Mojos are unable to load package annotations on Java >= 9
> -
>
> Key: MNG-6506
> URL: https://issues.apache.org/jira/browse/MNG-6506
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.6.0
>Reporter: Andreas Veithen
>Assignee: Sylwester Lachiewicz
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> On Java 9 and above, calls to {{java.lang.Package.getAnnotation(Class)}} from 
> within a Mojo always return {{null}} (unless the {{package-info}} class has 
> been loaded by some other means before).
> The reason appears to be an incompatibility between Java 9 and Plexus 
> Classworlds:
> * Java 9 ultimately calls {{findClass}} (instead of {{loadClass}}) to get the 
> {{package-info}} class.
> * The {{findClass}} implementation in {{ClassRealm}} always throws 
> {{ClassNotFoundException}}: 
> https://github.com/codehaus-plexus/plexus-classworlds/blob/master/src/main/java/org/codehaus/plexus/classworlds/realm/ClassRealm.java#L275.
> This in particular affects plugins that interact with the JAXB API because it 
> relies on package annotations.
> A workaround is to preload the required {{package-info}} classes using 
> {{loadClass}}; see e.g. http://svn.apache.org/viewvc?rev=1845026=rev.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6255) Maven script cannot parse jvm.config with CRLF

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814139#comment-16814139
 ] 

Hudson commented on MNG-6255:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-5666 #18

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5666/18/

> Maven script cannot parse jvm.config with CRLF
> --
>
> Key: MNG-6255
> URL: https://issues.apache.org/jira/browse/MNG-6255
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 7 with MINGW64 environment via Git for Windows 
> 0.1.1 including GNU coreutils and bash 4.4.12
>Reporter: Andrew Kennedy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.5.3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> A project with a {{.mvn/jvm.config}} file that has *CRLF* line endings will 
> not parse it correctly. The script uses the {{tr}} command to change *LF* to 
> space, but this leaves *CR* behind. For example, with the {{jvm.config}} file 
> containing the text {{-Xmx1024m -Xms512m}} followed by *CRLF*, the following 
> error message is printed:
> {code}
> $ mvn install
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> Invalid initial heap size: -Xms512m
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6255) Maven script cannot parse jvm.config with CRLF

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814135#comment-16814135
 ] 

Hudson commented on MNG-6255:
-

Build unstable in Jenkins: Maven TLP » maven » MAVEN-3.6/MNG-6399 #25

See 
https://builds.apache.org/job/maven-box/job/maven/job/MAVEN-3.6%252FMNG-6399/25/

> Maven script cannot parse jvm.config with CRLF
> --
>
> Key: MNG-6255
> URL: https://issues.apache.org/jira/browse/MNG-6255
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 7 with MINGW64 environment via Git for Windows 
> 0.1.1 including GNU coreutils and bash 4.4.12
>Reporter: Andrew Kennedy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.5.3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> A project with a {{.mvn/jvm.config}} file that has *CRLF* line endings will 
> not parse it correctly. The script uses the {{tr}} command to change *LF* to 
> space, but this leaves *CR* behind. For example, with the {{jvm.config}} file 
> containing the text {{-Xmx1024m -Xms512m}} followed by *CRLF*, the following 
> error message is printed:
> {code}
> $ mvn install
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> Invalid initial heap size: -Xms512m
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6613) Mirror matching ignores closest/nearest definition

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814133#comment-16814133
 ] 

Hudson commented on MNG-6613:
-

Build unstable in Jenkins: Maven TLP » maven » MAVEN-3.6/MNG-6399 #25

See 
https://builds.apache.org/job/maven-box/job/maven/job/MAVEN-3.6%252FMNG-6399/25/

> Mirror matching ignores closest/nearest definition
> --
>
> Key: MNG-6613
> URL: https://issues.apache.org/jira/browse/MNG-6613
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.5.4, 3.6.1
> Environment: Java 8u202, Java11u2
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: log.txt
>
>
> Ran our IT suite in a locked down environment at work, w/o direct internet 
> access. IT {{mng3461MirrorMatching(itNonGreedyWildcard)}} blocks forever 
> because the mirror exclude does not work: {{*,!maven-core-it}}.
> It still tries to download via mirror instead of ignoring it. See attached 
> log file. Even switching {{!maven-core-it,*}} makes no difference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6506) Mojos are unable to load package annotations on Java >= 9

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814134#comment-16814134
 ] 

Hudson commented on MNG-6506:
-

Build unstable in Jenkins: Maven TLP » maven » MAVEN-3.6/MNG-6399 #25

See 
https://builds.apache.org/job/maven-box/job/maven/job/MAVEN-3.6%252FMNG-6399/25/

> Mojos are unable to load package annotations on Java >= 9
> -
>
> Key: MNG-6506
> URL: https://issues.apache.org/jira/browse/MNG-6506
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.6.0
>Reporter: Andreas Veithen
>Assignee: Sylwester Lachiewicz
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> On Java 9 and above, calls to {{java.lang.Package.getAnnotation(Class)}} from 
> within a Mojo always return {{null}} (unless the {{package-info}} class has 
> been loaded by some other means before).
> The reason appears to be an incompatibility between Java 9 and Plexus 
> Classworlds:
> * Java 9 ultimately calls {{findClass}} (instead of {{loadClass}}) to get the 
> {{package-info}} class.
> * The {{findClass}} implementation in {{ClassRealm}} always throws 
> {{ClassNotFoundException}}: 
> https://github.com/codehaus-plexus/plexus-classworlds/blob/master/src/main/java/org/codehaus/plexus/classworlds/realm/ClassRealm.java#L275.
> This in particular affects plugins that interact with the JAXB API because it 
> relies on package annotations.
> A workaround is to preload the required {{package-info}} classes using 
> {{loadClass}}; see e.g. http://svn.apache.org/viewvc?rev=1845026=rev.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6506) Mojos are unable to load package annotations on Java >= 9

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814117#comment-16814117
 ] 

Hudson commented on MNG-6506:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6405 #9

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6405/9/

> Mojos are unable to load package annotations on Java >= 9
> -
>
> Key: MNG-6506
> URL: https://issues.apache.org/jira/browse/MNG-6506
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.6.0
>Reporter: Andreas Veithen
>Assignee: Sylwester Lachiewicz
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> On Java 9 and above, calls to {{java.lang.Package.getAnnotation(Class)}} from 
> within a Mojo always return {{null}} (unless the {{package-info}} class has 
> been loaded by some other means before).
> The reason appears to be an incompatibility between Java 9 and Plexus 
> Classworlds:
> * Java 9 ultimately calls {{findClass}} (instead of {{loadClass}}) to get the 
> {{package-info}} class.
> * The {{findClass}} implementation in {{ClassRealm}} always throws 
> {{ClassNotFoundException}}: 
> https://github.com/codehaus-plexus/plexus-classworlds/blob/master/src/main/java/org/codehaus/plexus/classworlds/realm/ClassRealm.java#L275.
> This in particular affects plugins that interact with the JAXB API because it 
> relies on package annotations.
> A workaround is to preload the required {{package-info}} classes using 
> {{loadClass}}; see e.g. http://svn.apache.org/viewvc?rev=1845026=rev.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6613) Mirror matching ignores closest/nearest definition

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814116#comment-16814116
 ] 

Hudson commented on MNG-6613:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6405 #9

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6405/9/

> Mirror matching ignores closest/nearest definition
> --
>
> Key: MNG-6613
> URL: https://issues.apache.org/jira/browse/MNG-6613
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.5.4, 3.6.1
> Environment: Java 8u202, Java11u2
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: log.txt
>
>
> Ran our IT suite in a locked down environment at work, w/o direct internet 
> access. IT {{mng3461MirrorMatching(itNonGreedyWildcard)}} blocks forever 
> because the mirror exclude does not work: {{*,!maven-core-it}}.
> It still tries to download via mirror instead of ignoring it. See attached 
> log file. Even switching {{!maven-core-it,*}} makes no difference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6255) Maven script cannot parse jvm.config with CRLF

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814118#comment-16814118
 ] 

Hudson commented on MNG-6255:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6405 #9

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-6405/9/

> Maven script cannot parse jvm.config with CRLF
> --
>
> Key: MNG-6255
> URL: https://issues.apache.org/jira/browse/MNG-6255
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 7 with MINGW64 environment via Git for Windows 
> 0.1.1 including GNU coreutils and bash 4.4.12
>Reporter: Andrew Kennedy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.5.3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> A project with a {{.mvn/jvm.config}} file that has *CRLF* line endings will 
> not parse it correctly. The script uses the {{tr}} command to change *LF* to 
> space, but this leaves *CR* behind. For example, with the {{jvm.config}} file 
> containing the text {{-Xmx1024m -Xms512m}} followed by *CRLF*, the following 
> error message is printed:
> {code}
> $ mvn install
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> Invalid initial heap size: -Xms512m
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6506) Mojos are unable to load package annotations on Java >= 9

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814107#comment-16814107
 ] 

Hudson commented on MNG-6506:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6552 #8

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6552/8/

> Mojos are unable to load package annotations on Java >= 9
> -
>
> Key: MNG-6506
> URL: https://issues.apache.org/jira/browse/MNG-6506
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.6.0
>Reporter: Andreas Veithen
>Assignee: Sylwester Lachiewicz
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> On Java 9 and above, calls to {{java.lang.Package.getAnnotation(Class)}} from 
> within a Mojo always return {{null}} (unless the {{package-info}} class has 
> been loaded by some other means before).
> The reason appears to be an incompatibility between Java 9 and Plexus 
> Classworlds:
> * Java 9 ultimately calls {{findClass}} (instead of {{loadClass}}) to get the 
> {{package-info}} class.
> * The {{findClass}} implementation in {{ClassRealm}} always throws 
> {{ClassNotFoundException}}: 
> https://github.com/codehaus-plexus/plexus-classworlds/blob/master/src/main/java/org/codehaus/plexus/classworlds/realm/ClassRealm.java#L275.
> This in particular affects plugins that interact with the JAXB API because it 
> relies on package annotations.
> A workaround is to preload the required {{package-info}} classes using 
> {{loadClass}}; see e.g. http://svn.apache.org/viewvc?rev=1845026=rev.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6613) Mirror matching ignores closest/nearest definition

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814106#comment-16814106
 ] 

Hudson commented on MNG-6613:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6552 #8

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6552/8/

> Mirror matching ignores closest/nearest definition
> --
>
> Key: MNG-6613
> URL: https://issues.apache.org/jira/browse/MNG-6613
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.5.4, 3.6.1
> Environment: Java 8u202, Java11u2
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: log.txt
>
>
> Ran our IT suite in a locked down environment at work, w/o direct internet 
> access. IT {{mng3461MirrorMatching(itNonGreedyWildcard)}} blocks forever 
> because the mirror exclude does not work: {{*,!maven-core-it}}.
> It still tries to download via mirror instead of ignoring it. See attached 
> log file. Even switching {{!maven-core-it,*}} makes no difference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6506) Mojos are unable to load package annotations on Java >= 9

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814110#comment-16814110
 ] 

Hudson commented on MNG-6506:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6553 #8

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6553/8/

> Mojos are unable to load package annotations on Java >= 9
> -
>
> Key: MNG-6506
> URL: https://issues.apache.org/jira/browse/MNG-6506
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.6.0
>Reporter: Andreas Veithen
>Assignee: Sylwester Lachiewicz
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> On Java 9 and above, calls to {{java.lang.Package.getAnnotation(Class)}} from 
> within a Mojo always return {{null}} (unless the {{package-info}} class has 
> been loaded by some other means before).
> The reason appears to be an incompatibility between Java 9 and Plexus 
> Classworlds:
> * Java 9 ultimately calls {{findClass}} (instead of {{loadClass}}) to get the 
> {{package-info}} class.
> * The {{findClass}} implementation in {{ClassRealm}} always throws 
> {{ClassNotFoundException}}: 
> https://github.com/codehaus-plexus/plexus-classworlds/blob/master/src/main/java/org/codehaus/plexus/classworlds/realm/ClassRealm.java#L275.
> This in particular affects plugins that interact with the JAXB API because it 
> relies on package annotations.
> A workaround is to preload the required {{package-info}} classes using 
> {{loadClass}}; see e.g. http://svn.apache.org/viewvc?rev=1845026=rev.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6255) Maven script cannot parse jvm.config with CRLF

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814111#comment-16814111
 ] 

Hudson commented on MNG-6255:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6553 #8

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6553/8/

> Maven script cannot parse jvm.config with CRLF
> --
>
> Key: MNG-6255
> URL: https://issues.apache.org/jira/browse/MNG-6255
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 7 with MINGW64 environment via Git for Windows 
> 0.1.1 including GNU coreutils and bash 4.4.12
>Reporter: Andrew Kennedy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.5.3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> A project with a {{.mvn/jvm.config}} file that has *CRLF* line endings will 
> not parse it correctly. The script uses the {{tr}} command to change *LF* to 
> space, but this leaves *CR* behind. For example, with the {{jvm.config}} file 
> containing the text {{-Xmx1024m -Xms512m}} followed by *CRLF*, the following 
> error message is printed:
> {code}
> $ mvn install
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> Invalid initial heap size: -Xms512m
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6255) Maven script cannot parse jvm.config with CRLF

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814108#comment-16814108
 ] 

Hudson commented on MNG-6255:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6552 #8

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6552/8/

> Maven script cannot parse jvm.config with CRLF
> --
>
> Key: MNG-6255
> URL: https://issues.apache.org/jira/browse/MNG-6255
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 7 with MINGW64 environment via Git for Windows 
> 0.1.1 including GNU coreutils and bash 4.4.12
>Reporter: Andrew Kennedy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.5.3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> A project with a {{.mvn/jvm.config}} file that has *CRLF* line endings will 
> not parse it correctly. The script uses the {{tr}} command to change *LF* to 
> space, but this leaves *CR* behind. For example, with the {{jvm.config}} file 
> containing the text {{-Xmx1024m -Xms512m}} followed by *CRLF*, the following 
> error message is printed:
> {code}
> $ mvn install
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> Invalid initial heap size: -Xms512m
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6613) Mirror matching ignores closest/nearest definition

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814109#comment-16814109
 ] 

Hudson commented on MNG-6613:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6553 #8

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6553/8/

> Mirror matching ignores closest/nearest definition
> --
>
> Key: MNG-6613
> URL: https://issues.apache.org/jira/browse/MNG-6613
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.5.4, 3.6.1
> Environment: Java 8u202, Java11u2
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: log.txt
>
>
> Ran our IT suite in a locked down environment at work, w/o direct internet 
> access. IT {{mng3461MirrorMatching(itNonGreedyWildcard)}} blocks forever 
> because the mirror exclude does not work: {{*,!maven-core-it}}.
> It still tries to download via mirror instead of ignoring it. See attached 
> log file. Even switching {{!maven-core-it,*}} makes no difference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6255) Maven script cannot parse jvm.config with CRLF

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814101#comment-16814101
 ] 

Hudson commented on MNG-6255:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6554 #8

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6554/8/

> Maven script cannot parse jvm.config with CRLF
> --
>
> Key: MNG-6255
> URL: https://issues.apache.org/jira/browse/MNG-6255
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 7 with MINGW64 environment via Git for Windows 
> 0.1.1 including GNU coreutils and bash 4.4.12
>Reporter: Andrew Kennedy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.5.3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> A project with a {{.mvn/jvm.config}} file that has *CRLF* line endings will 
> not parse it correctly. The script uses the {{tr}} command to change *LF* to 
> space, but this leaves *CR* behind. For example, with the {{jvm.config}} file 
> containing the text {{-Xmx1024m -Xms512m}} followed by *CRLF*, the following 
> error message is printed:
> {code}
> $ mvn install
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> Invalid initial heap size: -Xms512m
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6506) Mojos are unable to load package annotations on Java >= 9

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814100#comment-16814100
 ] 

Hudson commented on MNG-6506:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6554 #8

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6554/8/

> Mojos are unable to load package annotations on Java >= 9
> -
>
> Key: MNG-6506
> URL: https://issues.apache.org/jira/browse/MNG-6506
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.6.0
>Reporter: Andreas Veithen
>Assignee: Sylwester Lachiewicz
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> On Java 9 and above, calls to {{java.lang.Package.getAnnotation(Class)}} from 
> within a Mojo always return {{null}} (unless the {{package-info}} class has 
> been loaded by some other means before).
> The reason appears to be an incompatibility between Java 9 and Plexus 
> Classworlds:
> * Java 9 ultimately calls {{findClass}} (instead of {{loadClass}}) to get the 
> {{package-info}} class.
> * The {{findClass}} implementation in {{ClassRealm}} always throws 
> {{ClassNotFoundException}}: 
> https://github.com/codehaus-plexus/plexus-classworlds/blob/master/src/main/java/org/codehaus/plexus/classworlds/realm/ClassRealm.java#L275.
> This in particular affects plugins that interact with the JAXB API because it 
> relies on package annotations.
> A workaround is to preload the required {{package-info}} classes using 
> {{loadClass}}; see e.g. http://svn.apache.org/viewvc?rev=1845026=rev.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6613) Mirror matching ignores closest/nearest definition

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814099#comment-16814099
 ] 

Hudson commented on MNG-6613:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6554 #8

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6554/8/

> Mirror matching ignores closest/nearest definition
> --
>
> Key: MNG-6613
> URL: https://issues.apache.org/jira/browse/MNG-6613
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.5.4, 3.6.1
> Environment: Java 8u202, Java11u2
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: log.txt
>
>
> Ran our IT suite in a locked down environment at work, w/o direct internet 
> access. IT {{mng3461MirrorMatching(itNonGreedyWildcard)}} blocks forever 
> because the mirror exclude does not work: {{*,!maven-core-it}}.
> It still tries to download via mirror instead of ignoring it. See attached 
> log file. Even switching {{!maven-core-it,*}} makes no difference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6255) Maven script cannot parse jvm.config with CRLF

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814093#comment-16814093
 ] 

Hudson commented on MNG-6255:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-5567 #27

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5567/27/

> Maven script cannot parse jvm.config with CRLF
> --
>
> Key: MNG-6255
> URL: https://issues.apache.org/jira/browse/MNG-6255
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 7 with MINGW64 environment via Git for Windows 
> 0.1.1 including GNU coreutils and bash 4.4.12
>Reporter: Andrew Kennedy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.5.3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> A project with a {{.mvn/jvm.config}} file that has *CRLF* line endings will 
> not parse it correctly. The script uses the {{tr}} command to change *LF* to 
> space, but this leaves *CR* behind. For example, with the {{jvm.config}} file 
> containing the text {{-Xmx1024m -Xms512m}} followed by *CRLF*, the following 
> error message is printed:
> {code}
> $ mvn install
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> Invalid initial heap size: -Xms512m
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6613) Mirror matching ignores closest/nearest definition

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814091#comment-16814091
 ] 

Hudson commented on MNG-6613:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-5567 #27

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5567/27/

> Mirror matching ignores closest/nearest definition
> --
>
> Key: MNG-6613
> URL: https://issues.apache.org/jira/browse/MNG-6613
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.5.4, 3.6.1
> Environment: Java 8u202, Java11u2
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: log.txt
>
>
> Ran our IT suite in a locked down environment at work, w/o direct internet 
> access. IT {{mng3461MirrorMatching(itNonGreedyWildcard)}} blocks forever 
> because the mirror exclude does not work: {{*,!maven-core-it}}.
> It still tries to download via mirror instead of ignoring it. See attached 
> log file. Even switching {{!maven-core-it,*}} makes no difference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6506) Mojos are unable to load package annotations on Java >= 9

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814092#comment-16814092
 ] 

Hudson commented on MNG-6506:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-5567 #27

See https://builds.apache.org/job/maven-box/job/maven/job/MNG-5567/27/

> Mojos are unable to load package annotations on Java >= 9
> -
>
> Key: MNG-6506
> URL: https://issues.apache.org/jira/browse/MNG-6506
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.6.0
>Reporter: Andreas Veithen
>Assignee: Sylwester Lachiewicz
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> On Java 9 and above, calls to {{java.lang.Package.getAnnotation(Class)}} from 
> within a Mojo always return {{null}} (unless the {{package-info}} class has 
> been loaded by some other means before).
> The reason appears to be an incompatibility between Java 9 and Plexus 
> Classworlds:
> * Java 9 ultimately calls {{findClass}} (instead of {{loadClass}}) to get the 
> {{package-info}} class.
> * The {{findClass}} implementation in {{ClassRealm}} always throws 
> {{ClassNotFoundException}}: 
> https://github.com/codehaus-plexus/plexus-classworlds/blob/master/src/main/java/org/codehaus/plexus/classworlds/realm/ClassRealm.java#L275.
> This in particular affects plugins that interact with the JAXB API because it 
> relies on package annotations.
> A workaround is to preload the required {{package-info}} classes using 
> {{loadClass}}; see e.g. http://svn.apache.org/viewvc?rev=1845026=rev.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6255) Maven script cannot parse jvm.config with CRLF

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814085#comment-16814085
 ] 

Hudson commented on MNG-6255:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6555 #15

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6555/15/

> Maven script cannot parse jvm.config with CRLF
> --
>
> Key: MNG-6255
> URL: https://issues.apache.org/jira/browse/MNG-6255
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line
>Affects Versions: 3.5.0
> Environment: Windows 7 with MINGW64 environment via Git for Windows 
> 0.1.1 including GNU coreutils and bash 4.4.12
>Reporter: Andrew Kennedy
>Assignee: Hervé Boutemy
>Priority: Major
> Fix For: 3.5.3
>
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> A project with a {{.mvn/jvm.config}} file that has *CRLF* line endings will 
> not parse it correctly. The script uses the {{tr}} command to change *LF* to 
> space, but this leaves *CR* behind. For example, with the {{jvm.config}} file 
> containing the text {{-Xmx1024m -Xms512m}} followed by *CRLF*, the following 
> error message is printed:
> {code}
> $ mvn install
> Error: Could not create the Java Virtual Machine.
> Error: A fatal exception has occurred. Program will exit.
> Invalid initial heap size: -Xms512m
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6613) Mirror matching ignores closest/nearest definition

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814083#comment-16814083
 ] 

Hudson commented on MNG-6613:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6555 #15

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6555/15/

> Mirror matching ignores closest/nearest definition
> --
>
> Key: MNG-6613
> URL: https://issues.apache.org/jira/browse/MNG-6613
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.5.4, 3.6.1
> Environment: Java 8u202, Java11u2
>Reporter: Michael Osipov
>Priority: Critical
> Attachments: log.txt
>
>
> Ran our IT suite in a locked down environment at work, w/o direct internet 
> access. IT {{mng3461MirrorMatching(itNonGreedyWildcard)}} blocks forever 
> because the mirror exclude does not work: {{*,!maven-core-it}}.
> It still tries to download via mirror instead of ignoring it. See attached 
> log file. Even switching {{!maven-core-it,*}} makes no difference.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MNG-6506) Mojos are unable to load package annotations on Java >= 9

[Hudson (JIRA)]

[ 
https://issues.apache.org/jira/browse/MNG-6506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16814084#comment-16814084
 ] 

Hudson commented on MNG-6506:
-

Build unstable in Jenkins: Maven TLP » maven » MNG-6169/MNG-6555 #15

See 
https://builds.apache.org/job/maven-box/job/maven/job/MNG-6169%252FMNG-6555/15/

> Mojos are unable to load package annotations on Java >= 9
> -
>
> Key: MNG-6506
> URL: https://issues.apache.org/jira/browse/MNG-6506
> Project: Maven
>  Issue Type: Bug
>  Components: Class Loading
>Affects Versions: 3.6.0
>Reporter: Andreas Veithen
>Assignee: Sylwester Lachiewicz
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.6.1
>
>  Time Spent: 20m
>  Remaining Estimate: 0h
>
> On Java 9 and above, calls to {{java.lang.Package.getAnnotation(Class)}} from 
> within a Mojo always return {{null}} (unless the {{package-info}} class has 
> been loaded by some other means before).
> The reason appears to be an incompatibility between Java 9 and Plexus 
> Classworlds:
> * Java 9 ultimately calls {{findClass}} (instead of {{loadClass}}) to get the 
> {{package-info}} class.
> * The {{findClass}} implementation in {{ClassRealm}} always throws 
> {{ClassNotFoundException}}: 
> https://github.com/codehaus-plexus/plexus-classworlds/blob/master/src/main/java/org/codehaus/plexus/classworlds/realm/ClassRealm.java#L275.
> This in particular affects plugins that interact with the JAXB API because it 
> relies on package annotations.
> A workaround is to preload the required {{package-info}} classes using 
> {{loadClass}}; see e.g. http://svn.apache.org/viewvc?rev=1845026=rev.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)