[GitHub] [maven-fluido-skin] slachiewicz commented on issue #8: [MSKINS-104] Remove obsolete meta tags
slachiewicz commented on issue #8: [MSKINS-104] Remove obsolete meta tags URL: https://github.com/apache/maven-fluido-skin/pull/8#issuecomment-498120356 This was just removal of language attribute but we should add lang in root html tag see: https://www.w3schools.com/tags/ref_language_codes.asp This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MSKINS-104) Remove obsolete meta tags
[ https://issues.apache.org/jira/browse/MSKINS-104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854209#comment-16854209 ] Hudson commented on MSKINS-104: --- Build succeeded in Jenkins: Maven TLP » maven-fluido-skin » master #9 See https://builds.apache.org/job/maven-box/job/maven-fluido-skin/job/master/9/ > Remove obsolete meta tags > - > > Key: MSKINS-104 > URL: https://issues.apache.org/jira/browse/MSKINS-104 > Project: Maven Skins > Issue Type: Sub-task > Components: Fluido Skin >Affects Versions: fluido-1.3.1 >Reporter: Michael Osipov >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Major > Labels: up-for-grabs > Fix For: fluido-1.8 > > Time Spent: 20m > Remaining Estimate: 0h > > Issued error: > bq. Using the meta element to specify the document-wide default language is > obsolete. Consider specifying the language on the root element instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MSKINS-104) Remove obsolete meta tags
[ https://issues.apache.org/jira/browse/MSKINS-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) updated MSKINS-104: -- Fix Version/s: fluido-1.8 > Remove obsolete meta tags > - > > Key: MSKINS-104 > URL: https://issues.apache.org/jira/browse/MSKINS-104 > Project: Maven Skins > Issue Type: Sub-task > Components: Fluido Skin >Affects Versions: fluido-1.3.1 >Reporter: Michael Osipov >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Major > Labels: up-for-grabs > Fix For: fluido-1.8 > > Time Spent: 20m > Remaining Estimate: 0h > > Issued error: > bq. Using the meta element to specify the document-wide default language is > obsolete. Consider specifying the language on the root element instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MSKINS-104) Remove obsolete meta tags
[ https://issues.apache.org/jira/browse/MSKINS-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) closed MSKINS-104. - Resolution: Fixed > Remove obsolete meta tags > - > > Key: MSKINS-104 > URL: https://issues.apache.org/jira/browse/MSKINS-104 > Project: Maven Skins > Issue Type: Sub-task > Components: Fluido Skin >Affects Versions: fluido-1.3.1 >Reporter: Michael Osipov >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Major > Labels: up-for-grabs > Fix For: fluido-1.8 > > Time Spent: 20m > Remaining Estimate: 0h > > Issued error: > bq. Using the meta element to specify the document-wide default language is > obsolete. Consider specifying the language on the root element instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Assigned] (MSKINS-104) Remove obsolete meta tags
[ https://issues.apache.org/jira/browse/MSKINS-104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy (*$^¨%`£) reassigned MSKINS-104: - Assignee: Olivier Lamy (*$^¨%`£) > Remove obsolete meta tags > - > > Key: MSKINS-104 > URL: https://issues.apache.org/jira/browse/MSKINS-104 > Project: Maven Skins > Issue Type: Sub-task > Components: Fluido Skin >Affects Versions: fluido-1.3.1 >Reporter: Michael Osipov >Assignee: Olivier Lamy (*$^¨%`£) >Priority: Major > Labels: up-for-grabs > Time Spent: 20m > Remaining Estimate: 0h > > Issued error: > bq. Using the meta element to specify the document-wide default language is > obsolete. Consider specifying the language on the root element instead. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-fluido-skin] olamy merged pull request #8: [MSKINS-104] Remove obsolete meta tags
olamy merged pull request #8: [MSKINS-104] Remove obsolete meta tags URL: https://github.com/apache/maven-fluido-skin/pull/8 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Updated] (MNG-6666) File download to 14KB is blocked
[
https://issues.apache.org/jira/browse/MNG-?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
a updated MNG-:
---
Description:
The download connection is normally fast and accessible in the browser, but
with maven it can only be downloaded to 14k and then stuck
Microsoft Windows [版本 6.1.7601]
版权所有 (c) 2009 Microsoft Corporation。保留所有权利。
F:\git-java\zhongc-knowledge-graph-web>mvn clean install -U
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model
for com.giiso:zhongc-knowledge-graph-web:jar:1.0.2
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must
be unique: org.apache.httpcomponents:httpclient:jar -> duplicate declaration of
version 4.5.3 @ line 119, column 15
[WARNING] 'build.plugins.plugin.version' for
org.apache.maven.plugins:maven-surefire-plugin is missing. @ line 361, column 12
[WARNING] The expression ${parent.version} is deprecated. Please use
${project.parent.version} instead.
[WARNING]
[WARNING] It is highly recommended to fix these problems because they threaten
the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support
building such malformed projects.
[WARNING]
[INFO]
[INFO] < com.giiso:zhongc-knowledge-graph-web >
[INFO] Building zhongc-knowledge-graph-web 1.0.2
[INFO] [ jar ]-
Downloading from nexus:
[http://maven.giiso.com/repository/maven-public/com/giiso/giiso-service-common/0.0.9-SNAPSHOT/maven-metadata.xml]
Downloaded from nexus:
[http://maven.giiso.com/repository/maven-public/com/giiso/giiso-service-common/0.0.9-SNAPSHOT/maven-metadata.xml]
(1.2 kB at 8.1 kB/s)
Downloading from nexus:
[http://maven.giiso.com/repository/maven-public/com/giiso/client/giiso-client-mongo/1.0.6-SNAPSHOT/maven-metadata.xml]
Downloaded from nexus:
[http://maven.giiso.com/repository/maven-public/com/giiso/client/giiso-client-mongo/1.0.6-SNAPSHOT/maven-metadata.xml]
(998 B at 18 kB/s)
Downloading from nexus:
[http://maven.giiso.com/repository/maven-public/com/giiso/client/giiso-client/1.0.0-SNAPSHOT/maven-metadata.xml]
Downloaded from nexus:
[http://maven.giiso.com/repository/maven-public/com/giiso/client/giiso-client/1.0.0-SNAPSHOT/maven-metadata.xml]
(605 B at 11 kB/s)
Downloading from nexus:
[http://maven.giiso.com/repository/maven-public/com/giiso/client/giiso-client-core/1.0.0-SNAPSHOT/maven-metadata.xml]
Downloaded from nexus:
[http://maven.giiso.com/repository/maven-public/com/giiso/client/giiso-client-core/1.0.0-SNAPSHOT/maven-metadata.xml]
(997 B at 18 kB/s)
Downloading from nexus:
[http://maven.giiso.com/repository/maven-public/com/google/zxing/core/3.0.0/core-3.0.0.jar]
Progress (1): 14/538 kB
{code:java}
Microsoft Windows [版本 6.1.7601]
版权所有 (c) 2009 Microsoft Corporation。保留所有权利。
F:\git-java\zhongc-knowledge-graph-web>mvn clean install -U -X
Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
2018-10-25T02:41:47+08:00)
Maven home: C:\Program Files\Java\apache-maven-3.6.0\bin\..
Java version: 1.8.0_211, vendor: Oracle Corporation, runtime: C:\Program
Files\Java\jdk1.8.0_211\jre
Default locale: zh_CN, platform encoding: GBK
OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
[DEBUG] Created new class realm maven.api
[DEBUG] Importing foreign packages into class realm maven.api
[DEBUG] Imported: javax.annotation.* < plexus.core
[DEBUG] Imported: javax.annotation.security.* < plexus.core
[DEBUG] Imported: javax.enterprise.inject.* < plexus.core
[DEBUG] Imported: javax.enterprise.util.* < plexus.core
[DEBUG] Imported: javax.inject.* < plexus.core
[DEBUG] Imported: org.apache.maven.* < plexus.core
[DEBUG] Imported: org.apache.maven.artifact < plexus.core
[DEBUG] Imported: org.apache.maven.classrealm < plexus.core
[DEBUG] Imported: org.apache.maven.cli < plexus.core
[DEBUG] Imported: org.apache.maven.configuration < plexus.core
[DEBUG] Imported: org.apache.maven.exception < plexus.core
[DEBUG] Imported: org.apache.maven.execution < plexus.core
[DEBUG] Imported: org.apache.maven.execution.scope < plexus.core
[DEBUG] Imported: org.apache.maven.lifecycle < plexus.core
[DEBUG] Imported: org.apache.maven.model < plexus.core
[DEBUG] Imported: org.apache.maven.monitor < plexus.core
[DEBUG] Imported: org.apache.maven.plugin < plexus.core
[DEBUG] Imported: org.apache.maven.profiles < plexus.core
[DEBUG] Imported: org.apache.maven.project < plexus.core
[DEBUG] Imported: org.apache.maven.reporting < plexus.core
[DEBUG] Imported: org.apache.maven.repository < plexus.core
[DEBUG] Imported: org.apache.maven.rtinfo < plexus.core
[DEBUG] Imported: org.apache.maven.settings < plexus.core
[DEBUG] Imported: org.apache.maven.toolchain < plexus.core
[DEBUG] Imported: org.apache.maven.usability < plexus.core
[DEBUG] Imported:
[GitHub] [maven-archetype] tony-- commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)
tony-- commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-498083493 @eolivelli as you mentioned "I will kick CI until I get a blue build and then commit this path" but it is very late for you, I thought I would give it a couple more tries and I got a good run: https://builds.apache.org/job/maven-box/job/maven-archetype/job/ARCHETYPE-567/9 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console
Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-498070844 @cardil The `RunOrderCalculator` is able to work with one RunOrder and not more. I think fetching multiple RunOrders was our problem in ASF. Redesigning this with max one RunOrder would simplify this PR and our code and the extension too. Is there any smart reason to accept multiple RunOrders? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console
Tibor17 commented on a change in pull request #112: Adding support for
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r289660257
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/util/DefaultRunOrderCalculator.java
##
@@ -49,30 +51,33 @@ public DefaultRunOrderCalculator( RunOrderParameters
runOrderParameters, int thr
{
this.runOrderParameters = runOrderParameters;
this.threadCount = threadCount;
-this.runOrder = runOrderParameters.getRunOrder();
-this.sortOrder = this.runOrder.length > 0 ? getSortOrderComparator(
this.runOrder[0] ) : null;
+this.runOrders = runOrderParameters.getRunOrders();
+this.sortOrder = this.runOrders.any() ? getSortOrderComparator(
this.runOrders ) : null;
}
@Override
-@SuppressWarnings( "checkstyle:magicnumber" )
public TestsToRun orderTestClasses( TestsToRun scannedClasses )
{
-List> result = new ArrayList<>( 512 );
+List> result = new ArrayList>( INITIAL_CAPACITY );
Review comment:
Pls make diamond in the constructor as well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Commented] (MNG-6667) Hint at Maven upgrade requirement when trying to build a pom.xml with a newer modelVersion
[ https://issues.apache.org/jira/browse/MNG-6667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854123#comment-16854123 ] Hudson commented on MNG-6667: - Build failed in Jenkins: Maven TLP » maven » mng-6667 #5 See https://builds.apache.org/job/maven-box/job/maven/job/mng-6667/5/ > Hint at Maven upgrade requirement when trying to build a pom.xml with a newer > modelVersion > -- > > Key: MNG-6667 > URL: https://issues.apache.org/jira/browse/MNG-6667 > Project: Maven > Issue Type: Improvement > Components: core >Reporter: Stephen Connolly >Assignee: Stephen Connolly >Priority: Major > Labels: maven-5.x-preparation > > In order to allow us to bump the modelVersion *for building* we need Maven to > alert users about the updated building requirements. > NOTE: We will always need to *deploy* a modelVersion 4.0.0 pom.xml so that > consumers can consume dependencies, but we can *build* with a newer model > version and produce the corresponding modelVersion 4.0.0 pom.xml for > deployment (this would be flattened so that it has no parent). The build pom > only needs to be deployed if it is being used as a parent, in which case: > * The pom using it as a parent will have to have a newer or same modelVersion > as its parent > On that basis we can either > * Deploy the newer modelVersion parent pom with a classifier and its 4.0.0 > (best-effort) equivalent without a classifier, then when building the child, > we look for the parent with classifier and only if missing do we fall back to > look for a modelVersion 4.0.0 parent. > * Deploy the newer modelVersion parent pom as normal, since you need to have > a newer modelVersion to be a child and we only deploy flattened 4.0.0 > compatibility poms for the children, no legacy consumer will ever have to > parse the parent > Determination of which of these two approaches to use is out of scope for > this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MJAVADOC-607) followLinks fix to get redirect target breaks for certain sites
Michiel Hendriks created MJAVADOC-607: - Summary: followLinks fix to get redirect target breaks for certain sites Key: MJAVADOC-607 URL: https://issues.apache.org/jira/browse/MJAVADOC-607 Project: Maven Javadoc Plugin Issue Type: Bug Affects Versions: 3.1.0, 3.0.1 Reporter: Michiel Hendriks The followLinks fix from MJAVADOC-427 breaks links which are valid, but do not produce a 200 or 3xx HTTP response on the base URL. For example to link to javadoc hosted by javadoc.io you would use the link: [https://static.javadoc.io/org.apache.maven.plugins/maven-javadoc-plugin/3.1.0] As this is hosted on S3 it returns a 403, but the package-list does given a 200: [https://static.javadoc.io/org.apache.maven.plugins/maven-javadoc-plugin/3.1.0/package-list] With version 3.0.0 these links work correctly. It might be better to check for redirect targets by including the /package-list part in the URL to test. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MJARSIGNER-60) Link to Plugins Wiki Page is Dead
James Gough created MJARSIGNER-60: - Summary: Link to Plugins Wiki Page is Dead Key: MJARSIGNER-60 URL: https://issues.apache.org/jira/browse/MJARSIGNER-60 Project: Maven Jar Signer Plugin Issue Type: Improvement Reporter: James Gough Link from Jarsigner Plugin's [about page|http://maven.apache.org/plugins/maven-jarsigner-plugin/] to the wiki page is dead: http://docs.codehaus.org/display/MAVENUSER/Jarsigner+Plugin -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-doxia-sitetools] michael-o commented on issue #5: Switch from XhtmlSink to Xhtml5Sink as the default site renderer.
michael-o commented on issue #5: Switch from XhtmlSink to Xhtml5Sink as the default site renderer. URL: https://github.com/apache/maven-doxia-sitetools/pull/5#issuecomment-498065138 master has been updated. Please rebase and let's continue the discussion. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Closed] (DOXIASITETOOLS-194) Upgrate Doxia to 1.9
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-194?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIASITETOOLS-194. - Resolution: Fixed Fixed with [cb0944a98978feac3a3c94674c3b1ff589a6d4a5|https://gitbox.apache.org/repos/asf?p=maven-doxia-sitetools.git;a=commit;h=cb0944a98978feac3a3c94674c3b1ff589a6d4a5]. > Upgrate Doxia to 1.9 > > > Key: DOXIASITETOOLS-194 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-194 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Affects Versions: 1.8.1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 1.9 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (DOXIASITETOOLS-195) Require Java 7
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-195?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIASITETOOLS-195. - Resolution: Fixed Fixed with [a567074ad89bd2d4f0fc32d21a8fcd12e0282876|https://gitbox.apache.org/repos/asf?p=maven-doxia-sitetools.git;a=commit;h=a567074ad89bd2d4f0fc32d21a8fcd12e0282876]. > Require Java 7 > -- > > Key: DOXIASITETOOLS-195 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-195 > Project: Maven Doxia Sitetools > Issue Type: Task >Affects Versions: 1.8.1 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 1.9 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (DOXIASITETOOLS-195) Require Java 7
Michael Osipov created DOXIASITETOOLS-195: - Summary: Require Java 7 Key: DOXIASITETOOLS-195 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-195 Project: Maven Doxia Sitetools Issue Type: Task Affects Versions: 1.8.1 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 1.9 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854110#comment-16854110 ] Hudson commented on MNG-6573: - Build failed in Jenkins: Maven TLP » maven-doxia-sitetools » master #5 See https://builds.apache.org/job/maven-box/job/maven-doxia-sitetools/job/master/5/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (DOXIASITETOOLS-194) Upgrate Doxia to 1.9
Michael Osipov created DOXIASITETOOLS-194: - Summary: Upgrate Doxia to 1.9 Key: DOXIASITETOOLS-194 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-194 Project: Maven Doxia Sitetools Issue Type: Dependency upgrade Affects Versions: 1.8.1 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 1.9 -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MTOOLCHAINS-28) Toolchain does not respect fork
[
https://issues.apache.org/jira/browse/MTOOLCHAINS-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854107#comment-16854107
]
James Gough commented on MTOOLCHAINS-28:
[~madmax25] I'm going to start trying to recreate this issue. If you have a
small project you can zip and attach to this issue that would be great,
otherwise I'll try go with what is above.
> Toolchain does not respect fork
> ---
>
> Key: MTOOLCHAINS-28
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-28
> Project: Maven Toolchains Plugin
> Issue Type: Bug
>Affects Versions: 1.1
> Environment: Java 11, JDK 1.8, Maven 3.5.0
>Reporter: Max Edmiston
>Priority: Major
>
> I am using maven-compiler-plugin with fork option, configured for Java 11
> using the toolchain plugin. I have set my local environment to use JDK 1.8 by
> default. Forked process will use JDK 1.8, not Java 11, even with toolchain. I
> have tried this with and without the jdkToolchain xml tag in
> maven-compiler-plugin configuration.
> Relevant pom.xml:
>
> {code:xml}
>
> org.apache.maven.plugins
> maven-compiler-plugin
> ${maven-compiler-plugin.version}
>
> groovy-eclipse-compiler
> true
>
> lombok.launch.Agent
>
>
>
>
> org.codehaus.groovy
> groovy-eclipse-compiler
> ${groovy-eclipse-compiler.version}
>
>
> org.codehaus.groovy
> groovy-eclipse-batch
> ${groovy-eclipse-batch.version}
>
>
> org.projectlombok
> lombok
> 1.18.6
>
>
>
>
> org.apache.maven.plugins
> maven-toolchains-plugin
> 1.1
>
>
>
> toolchain
>
>
>
>
>
>
> 11
> openjdk
>
>
>
>
> {code}
>
> toolchains.xml:
> {code:xml}
>
>
>
> jdk
>
> 11
> openjdk
>
>
>
> /Library/Java/JavaVirtualMachines/openjdk-11.0.1.jdk/Contents/Home/
>
>
>
>
> {code}
> Sample error:
> {code:java}
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) ---
> [INFO] Toolchain in maven-compiler-plugin:
> JDK[/Library/Java/JavaVirtualMachines/openjdk-11.0.1.jdk/Contents/Home/]
> [INFO] Changes detected - recompiling the module!
> [INFO] Using Groovy-Eclipse compiler to compile both Java and Groovy files
> [INFO] Compiling in a forked process using
> /Users/max.edmiston/.m2/repository/org/codehaus/groovy/groovy-eclipse-batch/2.5.4-01/groovy-eclipse-batch-2.5.4-01.jar
> [INFO] -
> [ERROR] COMPILATION ERROR :
> [INFO] -
> [ERROR] Failure executing groovy-eclipse compiler:
> --
> 1. ERROR in ***Test.java (at line 39)
> ***.stream().findFirst().orElseThrow();
> ^^^
> The method orElseThrow(Supplier) in the type Optional is
> not applicable for the arguments ()
> ...
> --
> 5 problems (5 errors)
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MTOOLCHAINS-29) Possibiliy not to fail if toolchain.xml is not available
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-29?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MTOOLCHAINS-29. - Resolution: Won't Fix Assignee: Robert Scholte This seems to be a valid reason to use profiles. By default you won't have toolchains, but when activating the ci-profile (which contains the maven-toolchain-plugin) you can/must use the preferred toolchain. If you need help for this, we could turn this into an example on the plugin webpage. > Possibiliy not to fail if toolchain.xml is not available > > > Key: MTOOLCHAINS-29 > URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-29 > Project: Maven Toolchains Plugin > Issue Type: Improvement >Affects Versions: 1.1 >Reporter: Hüseyin Kartal >Assignee: Robert Scholte >Priority: Major > > In development environment we face the problem of multiple jdk's. But also > some environments are setup for single jdk's like in CI/CD. > In these environments we don't supply a toolchain.xml. But the project > pom.xml has a toolchain plugin configuration with the needed jdk and fails > therefore. > A possibility to tell toolchain just to warn without fail in these > environments would be very convenient. Maybe like the enforcer-plugin > [https://maven.apache.org/enforcer/maven-enforcer-plugin/enforce-mojo.html#fail] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (SUREFIRE-1670) wrong "Filtering by Test Class Names" in failsafe "Using JUnit 5 Platform" page
[ https://issues.apache.org/jira/browse/SUREFIRE-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana updated SUREFIRE-1670: --- Fix Version/s: 3.0.0-M4 > wrong "Filtering by Test Class Names" in failsafe "Using JUnit 5 Platform" > page > --- > > Key: SUREFIRE-1670 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1670 > Project: Maven Surefire > Issue Type: Bug > Components: documentation, Maven Failsafe Plugin >Reporter: Masahiko Sakamoto >Assignee: Tibor Digana >Priority: Major > Fix For: 3.0.0-M4 > > > In > http://maven.apache.org/surefire/maven-failsafe-plugin/examples/junit-platform.html > , > "Filtering by Test Class Names" section says " ... Test.java". > But these are wrong because these class name patterns is for surefire-plugin. > That url is for failsafe-plugin, so that section should be "...IT.java" . > (e.g. > http://maven.apache.org/surefire/maven-failsafe-plugin/integration-test-mojo.html#includes > ) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (SUREFIRE-1670) wrong "Filtering by Test Class Names" in failsafe "Using JUnit 5 Platform" page
[
https://issues.apache.org/jira/browse/SUREFIRE-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854104#comment-16854104
]
Tibor Digana commented on SUREFIRE-1670:
[~msakamoto-sf]
You can help us and fix the page {{junit-platform.apt.vm}}.
Feel free to contribute on [GitHub
project|https://github.com/apache/maven-surefire].
> wrong "Filtering by Test Class Names" in failsafe "Using JUnit 5 Platform"
> page
> ---
>
> Key: SUREFIRE-1670
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1670
> Project: Maven Surefire
> Issue Type: Bug
> Components: documentation, Maven Failsafe Plugin
>Reporter: Masahiko Sakamoto
>Assignee: Tibor Digana
>Priority: Major
>
> In
> http://maven.apache.org/surefire/maven-failsafe-plugin/examples/junit-platform.html
> ,
> "Filtering by Test Class Names" section says " ... Test.java".
> But these are wrong because these class name patterns is for surefire-plugin.
> That url is for failsafe-plugin, so that section should be "...IT.java" .
> (e.g.
> http://maven.apache.org/surefire/maven-failsafe-plugin/integration-test-mojo.html#includes
> )
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MTOOLCHAINS-19) Use of toolchains plugin mangles compiler error output
[
https://issues.apache.org/jira/browse/MTOOLCHAINS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MTOOLCHAINS-19.
-
Resolution: Invalid
Assignee: Robert Scholte
This issue is invalid for the maven-toolchain-plugin, The real issue is in
Maven Compiler Plugin (MCOMPILER-388) which didn't parse all output correctly.
> Use of toolchains plugin mangles compiler error output
> --
>
> Key: MTOOLCHAINS-19
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-19
> Project: Maven Toolchains Plugin
> Issue Type: Bug
>Affects Versions: 1.1, 3.0.0
> Environment: Ubuntu 16.04, Maven 3.2.3
>Reporter: Wolf Geldmacher
>Assignee: Robert Scholte
>Priority: Major
> Attachments: p.zip
>
>
> The attached project results in different (and wrong!) error messages when
> compiled without or with toolchains support.
> If compiled without toolchains support (mvn clean compile) the error message
> is:
> {noformat}
>[ERROR] .../src/main/java/ch/pecunifex/x/Cls1.java:[12,5] cannot access
> ch.pecunifex.x.Cls2
> bad source file: .../src/main/java/ch/pecunifex/x/Cls2.java
>file does not contain class ch.pecunifex.x.Cls2
>Please remove or make sure it appears in the correct subdirectory of
> the sourcepath.
> {noformat}
> wĥich is correct.
> If compiled with toolchains support (mvn -Ptoolchains clean compile) the
> error is:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
> (default-compile) on project p1: Compilation failure
> [ERROR] .../src/main/java/ch/pecunifex/x/Cls1.java:[3,15] FontDesignMetrics
> is internal proprietary API and may be removed in a future release
> {noformat}
> which is (at least) misleading. The true error is not visible anymore.
> (( The attached zip file has a {{toolchains.xml}} file that needs to be
> adapted to your setup (jdk location) and either must be put in {{~/.m2}} or
> its location specified on the command line. ))
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Moved] (MCOMPILER-388) Certain errors appearing at the end of error stream are not parsed and displayed
[
https://issues.apache.org/jira/browse/MCOMPILER-388?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte moved MTOOLCHAINS-30 to MCOMPILER-388:
-
Key: MCOMPILER-388 (was: MTOOLCHAINS-30)
Project: Maven Compiler Plugin (was: Maven Toolchains Plugin)
> Certain errors appearing at the end of error stream are not parsed and
> displayed
>
>
> Key: MCOMPILER-388
> URL: https://issues.apache.org/jira/browse/MCOMPILER-388
> Project: Maven Compiler Plugin
> Issue Type: Bug
>Reporter: James Gough
>Priority: Major
>
> Whilst investigating [MTOOLCHAINS-19] I came across a bug where certain
> errors are not parsed and displayed to the user, the specific example is when
> the compiler has an error for an access/bad source file.
> Using git bisect I found the issue to be related to the upgrade of the
> plexus-compiler:
> {code:bash}
> commit db6050f06e22065f7687ae0c7cda616e4183a9b8
> Author: Robert Scholte
> Date: Sun Jun 26 14:33:13 2016 +
> [MCOMPILER-269] Support modulepath (Java9/Jigsaw)
> [MCOMPILER-270] Support release=8 on JDK 9 (with fallback on source=8 and
> target=8 on JDK 8)
> Upgrade plexus-compiler to 2.8
> {code}
> The issue only seems to manifest during a compile out of process compilation,
> which then relies on parsing the output of the forked process.
> I have provide a merged bug fix to the plexus-compiler project
> https://github.com/codehaus-plexus/plexus-compiler/pull/63 that fixes the
> issue.
> To fix this bug in the maven-compiler we will need to use the above fix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (SUREFIRE-1670) wrong "Filtering by Test Class Names" in failsafe "Using JUnit 5 Platform" page
[ https://issues.apache.org/jira/browse/SUREFIRE-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reassigned SUREFIRE-1670: -- Assignee: Tibor Digana > wrong "Filtering by Test Class Names" in failsafe "Using JUnit 5 Platform" > page > --- > > Key: SUREFIRE-1670 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1670 > Project: Maven Surefire > Issue Type: Bug > Components: documentation, Maven Failsafe Plugin >Reporter: Masahiko Sakamoto >Assignee: Tibor Digana >Priority: Major > > In > http://maven.apache.org/surefire/maven-failsafe-plugin/examples/junit-platform.html > , > "Filtering by Test Class Names" section says " ... Test.java". > But these are wrong because these class name patterns is for surefire-plugin. > That url is for failsafe-plugin, so that section should be "...IT.java" . > (e.g. > http://maven.apache.org/surefire/maven-failsafe-plugin/integration-test-mojo.html#includes > ) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (DOXIASITETOOLS-192) Change to consistency three digit numbering schema
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854101#comment-16854101
]
Michael Osipov commented on DOXIASITETOOLS-192:
---
This should start with 2.0.0 consistent with Doxia.
> Change to consistency three digit numbering schema
> --
>
> Key: DOXIASITETOOLS-192
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-192
> Project: Maven Doxia Sitetools
> Issue Type: Wish
>Affects Versions: 1.9
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> I would suggest to follow a three digit numbering schema . WDYT [~hboutemy] ?
> Instead of {{1.9}} going to {{1.9.0}} ?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854097#comment-16854097 ] Hudson commented on MNG-6573: - Build failed in Jenkins: Maven TLP » maven-ear-plugin » MEAR-277 #4 See https://builds.apache.org/job/maven-box/job/maven-ear-plugin/job/MEAR-277/4/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854099#comment-16854099 ] Hudson commented on MNG-6573: - Build succeeded in Jenkins: Maven TLP » maven-plugin-tools » master #5 See https://builds.apache.org/job/maven-box/job/maven-plugin-tools/job/master/5/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854100#comment-16854100 ] Hudson commented on MNG-6573: - Build failed in Jenkins: Maven TLP » maven-ear-plugin » JDK-TEST #4 See https://builds.apache.org/job/maven-box/job/maven-ear-plugin/job/JDK-TEST/4/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854094#comment-16854094 ] Hudson commented on MNG-6573: - Build succeeded in Jenkins: Maven TLP » maven-deploy-plugin » MDEPLOY-244 #10 See https://builds.apache.org/job/maven-box/job/maven-deploy-plugin/job/MDEPLOY-244/10/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854093#comment-16854093 ] Hudson commented on MNG-6573: - Build succeeded in Jenkins: Maven TLP » maven-help-plugin » master #10 See https://builds.apache.org/job/maven-box/job/maven-help-plugin/job/master/10/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854086#comment-16854086 ] Hudson commented on MNG-6573: - Build failed in Jenkins: Maven TLP » maven-ear-plugin » master #7 See https://builds.apache.org/job/maven-box/job/maven-ear-plugin/job/master/7/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MTOOLCHAINS-30) Certain errors appearing at the end of error stream are not parsed and displayed
James Gough created MTOOLCHAINS-30:
--
Summary: Certain errors appearing at the end of error stream are
not parsed and displayed
Key: MTOOLCHAINS-30
URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-30
Project: Maven Toolchains Plugin
Issue Type: Bug
Reporter: James Gough
Whilst investigating [MTOOLCHAINS-19] I came across a bug where certain errors
are not parsed and displayed to the user, the specific example is when the
compiler has an error for an access/bad source file.
Using git bisect I found the issue to be related to the upgrade of the
plexus-compiler:
{code:bash}
commit db6050f06e22065f7687ae0c7cda616e4183a9b8
Author: Robert Scholte
Date: Sun Jun 26 14:33:13 2016 +
[MCOMPILER-269] Support modulepath (Java9/Jigsaw)
[MCOMPILER-270] Support release=8 on JDK 9 (with fallback on source=8 and
target=8 on JDK 8)
Upgrade plexus-compiler to 2.8
{code}
The issue only seems to manifest during a compile out of process compilation,
which then relies on parsing the output of the forked process.
I have provide a merged bug fix to the plexus-compiler project
https://github.com/codehaus-plexus/plexus-compiler/pull/63 that fixes the
issue.
To fix this bug in the maven-compiler we will need to use the above fix.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854085#comment-16854085 ] Hudson commented on MNG-6573: - Build succeeded in Jenkins: Maven TLP » maven-ant-plugin » master #6 See https://builds.apache.org/job/maven-box/job/maven-ant-plugin/job/master/6/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854083#comment-16854083 ] Hudson commented on MNG-6573: - Build succeeded in Jenkins: Maven TLP » maven-resolver » MRESOLVER-67 #5 See https://builds.apache.org/job/maven-box/job/maven-resolver/job/MRESOLVER-67/5/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854082#comment-16854082 ] Hudson commented on MNG-6573: - Build failed in Jenkins: Maven TLP » maven-shared-jar » master #5 See https://builds.apache.org/job/maven-box/job/maven-shared-jar/job/master/5/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854081#comment-16854081 ] Hudson commented on MNG-6573: - Build failed in Jenkins: Maven TLP » maven-resources-plugin » master #5 See https://builds.apache.org/job/maven-box/job/maven-resources-plugin/job/master/5/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854080#comment-16854080 ] Hudson commented on MNG-6573: - Build failed in Jenkins: Maven TLP » maven-scm » SCM-777 #5 See https://builds.apache.org/job/maven-box/job/maven-scm/job/SCM-777/5/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854079#comment-16854079 ] Hudson commented on MNG-6573: - Build failed in Jenkins: Maven TLP » maven-scm » SCM-917 #5 See https://builds.apache.org/job/maven-box/job/maven-scm/job/SCM-917/5/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854077#comment-16854077 ] Hudson commented on MNG-6573: - Build unstable in Jenkins: Maven TLP » maven-scm » SCM-877 #5 See https://builds.apache.org/job/maven-box/job/maven-scm/job/SCM-877/5/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854076#comment-16854076 ] Hudson commented on MNG-6573: - Build failed in Jenkins: Maven TLP » maven-dependency-analyzer » MSHARED-674_Detect_Java_8_type_annotations #5 See https://builds.apache.org/job/maven-box/job/maven-dependency-analyzer/job/MSHARED-674_Detect_Java_8_type_annotations/5/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854075#comment-16854075 ] Hudson commented on MNG-6573: - Build succeeded in Jenkins: Maven TLP » maven-project-utils » master #6 See https://builds.apache.org/job/maven-box/job/maven-project-utils/job/master/6/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854074#comment-16854074 ] Hudson commented on MNG-6573: - Build failed in Jenkins: Maven TLP » maven-mapping » master #5 See https://builds.apache.org/job/maven-box/job/maven-mapping/job/master/5/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854070#comment-16854070 ] Hudson commented on MNG-6573: - Build succeeded in Jenkins: Maven TLP » maven-jdeprscan-plugin » MNGSITE-332 #5 See https://builds.apache.org/job/maven-box/job/maven-jdeprscan-plugin/job/MNGSITE-332/5/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6573) Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI
[ https://issues.apache.org/jira/browse/MNG-6573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854069#comment-16854069 ] Hudson commented on MNG-6573: - Build succeeded in Jenkins: Maven TLP » maven-jdeprscan-plugin » master #5 See https://builds.apache.org/job/maven-box/job/maven-jdeprscan-plugin/job/master/5/ > Use latest Maven 3.6.0 to build Maven Core and plugins with ASF CI > -- > > Key: MNG-6573 > URL: https://issues.apache.org/jira/browse/MNG-6573 > Project: Maven > Issue Type: Task > Components: Integration Tests >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: 3.6.1 > > Time Spent: 20m > Remaining Estimate: 0h > > Maven Core Integration Test passed ok for Linux and Windows for Java 7, 8, > 11, 12-ea, 13-ea. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MTOOLCHAINS-3) PlexusConfiguration behavior in ToolchainConverter
[ https://issues.apache.org/jira/browse/MTOOLCHAINS-3?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MTOOLCHAINS-3. Resolution: Fixed Assignee: Robert Scholte Seems to be fixed as part of MTOOLCHAINS-15 > PlexusConfiguration behavior in ToolchainConverter > -- > > Key: MTOOLCHAINS-3 > URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-3 > Project: Maven Toolchains Plugin > Issue Type: Bug >Affects Versions: 1.0 >Reporter: Tomas Radej >Assignee: Robert Scholte >Priority: Major > Fix For: 3.0.0 > > Attachments: plexus-to-sisu.patch > > > Hi, > when packaging the Toolchains plugin to Fedora, I saw that the > ToolchainConverter class of the Toolchains plugin depends on the old behavior > of the PlexusConfiguration class, i. e. the getValue() and getName() methods > throwing a PlexusConfigurationException. However, the new behavior of the > PlexusConfiguration class (as found in Sonatype's Sisu, whose goal is to > replace Plexus) does not throw this exception, which causes the Toolchain > plugin not to compile when using the new library. > The point of this bug is to consult with you moving from > plexus-container-default to sisu-inject-plexus, thus removing the try/catch > block in > src/main/java/org/apache/maven/plugin/toolchain/ToolchainConverter.java, line > 84. A patch to perform that action is attached. > Thank you, Tomas Radej -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (MPMD-289) check: unable to find pmd.xml
[
https://issues.apache.org/jira/browse/MPMD-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Dangel updated MPMD-289:
Description:
With format html, the pmd.xml seems not to be generated.
Consequently, check whether there are no failures fails.
This problem does not occur when format is pmd.
Below i showed my pom.
{code}
org.apache.maven.plugins
maven-pmd-plugin
${versionPmdMvnPlugin}
net.sourceforge.pmd
pmd-core
${versionPmd}
net.sourceforge.pmd
pmd-java
${versionPmd}
true
${project.build.sourceEncoding}
100
false
false
html
check
cpd-check
{code}
was:
With format html, the pmd.xml seems not to be generated.
Consequently, check whether there are no failures fails.
This problem does not occur when format is pmd.
Below i showed my pom.
org.apache.maven.plugins
maven-pmd-plugin
${versionPmdMvnPlugin}
net.sourceforge.pmd
pmd-core
${versionPmd}
net.sourceforge.pmd
pmd-java
${versionPmd}
true
${project.build.sourceEncoding}
100
false
false
html
check
cpd-check
> check: unable to find pmd.xml
> -
>
> Key: MPMD-289
> URL: https://issues.apache.org/jira/browse/MPMD-289
> Project: Maven PMD Plugin
> Issue Type: Bug
>Affects Versions: 3.12.0
>Reporter: Ernst Reissner
>Priority: Major
>
> With format html, the pmd.xml seems not to be generated.
> Consequently, check whether there are no failures fails.
> This problem does not occur when format is pmd.
> Below i showed my pom.
>
>
>
> {code}
>
> org.apache.maven.plugins
> maven-pmd-plugin
> ${versionPmdMvnPlugin}
>
>
> net.sourceforge.pmd
> pmd-core
> ${versionPmd}
>
>
> net.sourceforge.pmd
> pmd-java
> ${versionPmd}
>
>
>
> true
> ${project.build.sourceEncoding}
> 100
>
> false
> false
> html
>
>
>
>
>
> check
> cpd-check
>
>
>
>
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MTOOLCHAINS-3) PlexusConfiguration behavior in ToolchainConverter
[
https://issues.apache.org/jira/browse/MTOOLCHAINS-3?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16854003#comment-16854003
]
James Gough commented on MTOOLCHAINS-3:
---
I've investigated this JIRA and the proposed patch. It looks to me like this
patch has actually been applied previously during refactoring. See:
{code:bash}
git diff 3913aef~ 3913aef
{code}
I also noticed that the configuration for sisu-inject-plexus is derived from
maven-plugin-api, which I don't think we want to override. The version that is
pulled in 1.4.2 no longer has the exceptions mentioned above.
{code:bash}
+- org.apache.maven:maven-plugin-api:jar:3.0:compile
| +- org.apache.maven:maven-model:jar:3.0:compile
| +- org.apache.maven:maven-artifact:jar:3.0:compile
| \- org.sonatype.sisu:sisu-inject-plexus:jar:1.4.2:compile
{code}
> PlexusConfiguration behavior in ToolchainConverter
> --
>
> Key: MTOOLCHAINS-3
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-3
> Project: Maven Toolchains Plugin
> Issue Type: Bug
>Affects Versions: 1.0
>Reporter: Tomas Radej
>Priority: Major
> Fix For: 3.0.0
>
> Attachments: plexus-to-sisu.patch
>
>
> Hi,
> when packaging the Toolchains plugin to Fedora, I saw that the
> ToolchainConverter class of the Toolchains plugin depends on the old behavior
> of the PlexusConfiguration class, i. e. the getValue() and getName() methods
> throwing a PlexusConfigurationException. However, the new behavior of the
> PlexusConfiguration class (as found in Sonatype's Sisu, whose goal is to
> replace Plexus) does not throw this exception, which causes the Toolchain
> plugin not to compile when using the new library.
> The point of this bug is to consult with you moving from
> plexus-container-default to sisu-inject-plexus, thus removing the try/catch
> block in
> src/main/java/org/apache/maven/plugin/toolchain/ToolchainConverter.java, line
> 84. A patch to perform that action is attached.
> Thank you, Tomas Radej
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MTOOLCHAINS-19) Use of toolchains plugin mangles compiler error output
[
https://issues.apache.org/jira/browse/MTOOLCHAINS-19?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16851976#comment-16851976
]
James Gough edited comment on MTOOLCHAINS-19 at 6/2/19 3:28 PM:
I have opened a [PR|https://github.com/codehaus-plexus/plexus-compiler/pull/63]
in the plexus-compiler project which should resolve this issue.
was (Author: jim__gough):
I have opened a [PR|https://github.com/codehaus-plexus/plexus-compiler/pull/62]
in the plexus-compiler project which should resolve this issue.
> Use of toolchains plugin mangles compiler error output
> --
>
> Key: MTOOLCHAINS-19
> URL: https://issues.apache.org/jira/browse/MTOOLCHAINS-19
> Project: Maven Toolchains Plugin
> Issue Type: Bug
>Affects Versions: 1.1, 3.0.0
> Environment: Ubuntu 16.04, Maven 3.2.3
>Reporter: Wolf Geldmacher
>Priority: Major
> Attachments: p.zip
>
>
> The attached project results in different (and wrong!) error messages when
> compiled without or with toolchains support.
> If compiled without toolchains support (mvn clean compile) the error message
> is:
> {noformat}
>[ERROR] .../src/main/java/ch/pecunifex/x/Cls1.java:[12,5] cannot access
> ch.pecunifex.x.Cls2
> bad source file: .../src/main/java/ch/pecunifex/x/Cls2.java
>file does not contain class ch.pecunifex.x.Cls2
>Please remove or make sure it appears in the correct subdirectory of
> the sourcepath.
> {noformat}
> wĥich is correct.
> If compiled with toolchains support (mvn -Ptoolchains clean compile) the
> error is:
> {noformat}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-compiler-plugin:3.6.1:compile
> (default-compile) on project p1: Compilation failure
> [ERROR] .../src/main/java/ch/pecunifex/x/Cls1.java:[3,15] FontDesignMetrics
> is internal proprietary API and may be removed in a future release
> {noformat}
> which is (at least) misleading. The true error is not visible anymore.
> (( The attached zip file has a {{toolchains.xml}} file that needs to be
> adapted to your setup (jdk location) and either must be put in {{~/.m2}} or
> its location specified on the command line. ))
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-archetype] eolivelli commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)
eolivelli commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-498038064 @Tibor17 thank you for the heads up. I will continue as soon as possible thank you @tony-- I will be back with news. Your part of the work is okay. Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-archetype] Tibor17 commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)
Tibor17 commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-498037939 @eolivelli Jenkins will be switched off, see the page. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-archetype] eolivelli commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)
eolivelli commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-498037456 I have added debug as suggested by @Tibor17 but the is no much to need, at least in the scope of this issue I am seeing that even master is flaky https://builds.apache.org/job/maven-box/job/maven-archetype/job/master/ I will kick CI until I get a blue build and then commit this path This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console
Tibor17 commented on a change in pull request #112: Adding support for
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r289644721
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/testset/DirectoryScannerParameters.java
##
@@ -110,8 +111,15 @@ public boolean isFailIfNoTests()
return failIfNoTests;
}
-public RunOrder[] getRunOrder()
+public RunOrders getRunOrders()
+{
+return runOrders;
+}
+
+private static RunOrders readRunOrders( String runOrder )
Review comment:
This method is never called. Pls remove it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console
Tibor17 commented on a change in pull request #112: Adding support for
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r289644674
##
File path:
surefire-api/src/main/java/org/apache/maven/surefire/util/RunOrders.java
##
@@ -0,0 +1,103 @@
+package org.apache.maven.surefire.util;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.annotation.ParametersAreNonnullByDefault;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+
+/**
+ * Represents a complete set of run orders with arguments
+ *
+ * @author mailto:krzysztof.suszyn...@wavesoftware.pl;>Krzysztof
Suszynski
+ */
+@ParametersAreNonnullByDefault
+public final class RunOrders
+{
+private final List withArguments;
+
+public RunOrders( RunOrder... runOrders )
Review comment:
@cardil
Why this class exists? Always the is only one runOrder in this array.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Closed] (MANT-66) Ambiguous date in generated header comment
[ https://issues.apache.org/jira/browse/MANT-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MANT-66. -- Resolution: Auto Closed Assignee: Robert Scholte Plugin is now retired, the issue won't be fixed. > Ambiguous date in generated header comment > -- > > Key: MANT-66 > URL: https://issues.apache.org/jira/browse/MANT-66 > Project: Maven Ant Plugin > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Sebb >Assignee: Robert Scholte >Priority: Trivial > > The date in the header comment is ambigious. For example: > > Is that Oct 4th or April 10th 2011? > Or even April 11th, 2010? > Dates should always use the format /mm/dd (or -mm-dd etc.). > It might be worth updating the comment to include the plugin version number > as well. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MANT-64) generate build file fails to define includeantruntime
[ https://issues.apache.org/jira/browse/MANT-64?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MANT-64. -- Resolution: Auto Closed Assignee: Robert Scholte Plugin is now retired, the issue won't be fixed. > generate build file fails to define includeantruntime > - > > Key: MANT-64 > URL: https://issues.apache.org/jira/browse/MANT-64 > Project: Maven Ant Plugin > Issue Type: Bug >Affects Versions: 2.3 >Reporter: Sebb >Assignee: Robert Scholte >Priority: Major > > The generated build file fails to include a definition for includeantruntime, > resulting in warnings such as: > maven-build.xml:74: warning: 'includeantruntime' was not set, defaulting to > build.sysclasspath=last; set to false for repeatable builds > For compatibility with Maven classpath, surely the generated build file > should include "includeantruntime=false" ? -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MANT-87) Getting Forked Java VM exited abnormally
[ https://issues.apache.org/jira/browse/MANT-87?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MANT-87. -- Resolution: Auto Closed Assignee: Robert Scholte Plugin is now retired, the issue won't be fixed. > Getting Forked Java VM exited abnormally > > > Key: MANT-87 > URL: https://issues.apache.org/jira/browse/MANT-87 > Project: Maven Ant Plugin > Issue Type: Bug > Environment: Java 1.7 + Jenkins + Ant 1.7 + JUnit >Reporter: Shantanu Inamdar >Assignee: Robert Scholte >Priority: Critical > Labels: ant, java1.7, jenkins, junit > > Hello, > Recently I have migrated from Java 6 to Java 7, was getting verifyError, but > after changing fork settings that error has gone away and now I am getting > this error "AssertionFailedError: Forked Java VM exited abnormally". > I tried many options with combinations of fork settings. tried increasing the > heap size, clonevm etc. Have been facing this issue since few days not able > to find any solution. > Please help resolving this issue. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (MANT-73) Wrong repositories in generated get-deps task and speed improvement
[
https://issues.apache.org/jira/browse/MANT-73?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MANT-73.
--
Resolution: Auto Closed
Assignee: Robert Scholte
Plugin is now retired, the issue won't be fixed.
> Wrong repositories in generated get-deps task and speed improvement
> ---
>
> Key: MANT-73
> URL: https://issues.apache.org/jira/browse/MANT-73
> Project: Maven Ant Plugin
> Issue Type: Bug
>Affects Versions: 2.3
> Environment: linux, jDK 1.6, maven 3.0.4
>Reporter: Jorge Gomez
>Assignee: Robert Scholte
>Priority: Blocker
> Attachments: avoidsnapshots_and_skipexisting.diff
>
>
> When one artifact existed in more than one repository, the first was selected
> by default. This lead to undesirable behaviors when developing for sonatype
> repository. In this case, I observed snapshots version were automatically
> selected, but they did not exist. For instance, the following was generated
> for Junit 4.8.1.
> src="https://oss.sonatype.org/content/repositories/snapshots/junit/junit/4.8.1/junit-4.8.1.jar;
> dest="${maven.repo.local}/junit/junit/4.8.1/junit-4.8.1.jar"
> usetimestamp="false"
> ignoreerrors="true"/>
> https://oss.sonatype.org/content/repositories/snapshots/junit/junit/4.8.1/junit-4.8.1.jar
> does not exist, by the way. This lead to important delays in compilation and
> any other target depending on get-deps.
> Making the AntBuildWriter select those repositories which are not snapshots,
> solves the issues. With the attched patch, the previous task becomes into:
> src="https://oss.sonatype.org/content/repositories/snapshots/junit/junit/4.8.1/junit-4.8.1.jar;
> dest="${maven.repo.local}/junit/junit/4.8.1/junit-4.8.1.jar"
> usetimestamp="false"
> ignoreerrors="true"/>
> Nevertheless, this still makes the get-deps slow. By increasing the minimum
> ant version to 1.8.0, it is possible to use "skipexisting" attribute for ant
> task. This, combined with "usetimestamp=true" makes compilation lightning
> fast once everything is downloaded. Now the task looks like:
> src="http://repo.maven.apache.org/maven2/junit/junit/4.8.1/junit-4.8.1.jar;
> dest="${maven.repo.local}/junit/junit/4.8.1/junit-4.8.1.jar"
> usetimestamp="true"
> ignoreerrors="true"
> skipexisting="true"/>
> The attached patch was created against the 2.3 tag version of the repository,
> though it is present as well in the head of the trunk. The pom.xml file was
> modified only to include the 1.8.0 version of ant instead of the old 1.7.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Closed] (MANT-63) get phase uses snapshot repo for non-snapshot dependencies
[
https://issues.apache.org/jira/browse/MANT-63?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Scholte closed MANT-63.
--
Resolution: Auto Closed
Assignee: Robert Scholte
Plugin is now retired, the issue won't be fixed.
> get phase uses snapshot repo for non-snapshot dependencies
> --
>
> Key: MANT-63
> URL: https://issues.apache.org/jira/browse/MANT-63
> Project: Maven Ant Plugin
> Issue Type: Bug
>Affects Versions: 2.3
>Reporter: Sebb
>Assignee: Robert Scholte
>Priority: Major
>
> Create dummy Maven project using mvn archetype:generate
> mvn ant:ant
> Generated script contains the following, which is correct:
> {code}
> http://repo1.maven.org/maven2/junit/junit/3.8.1/junit-3.8.1.jar;
> dest="${maven.repo.local}/junit/junit/3.8.1/junit-3.8.1.jar"
> usetimestamp="false"
> ignoreerrors="true"/>
> {code}
> Now add the following to the POM:
> {code}
>
> org.apache
> apache
> 9
>
> {code}
> mvn ant:ant
> now generates:
> {code}
> src="http://repository.apache.org/snapshots/junit/junit/3.8.1/junit-3.8.1.jar;
>
> dest="${maven.repo.local}/junit/junit/3.8.1/junit-3.8.1.jar"
> usetimestamp="false"
> ignoreerrors="true"/>
> src="http://repo1.maven.org/maven2/junit/junit/3.8.1/junit-3.8.1.jar;
> dest="${maven.repo.local}/junit/junit/3.8.1/junit-3.8.1.jar"
> usetimestamp="false"
> ignoreerrors="true"/>
> {code}
> which means that the script will generate an error for the download.
> The generated script should only generate one download, based on whether the
> version is a SNAPSHOT or not.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MANT-86) Retire the plugin
[ https://issues.apache.org/jira/browse/MANT-86?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte reassigned MANT-86: -- Assignee: Robert Scholte > Retire the plugin > - > > Key: MANT-86 > URL: https://issues.apache.org/jira/browse/MANT-86 > Project: Maven Ant Plugin > Issue Type: Wish >Affects Versions: 3.0 >Reporter: Karl Heinz Marbaise >Assignee: Robert Scholte >Priority: Major > Fix For: 3.0 > > > We should start a VOTE > http://maven.apache.org/developers/retirement-plan-plugins.html at the > 2015/02/01 to ultimately retire this plugin... -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven] MartinKanters commented on a change in pull request #251: [MNG-6665] toolchain.xml file should support environment variables
MartinKanters commented on a change in pull request #251: [MNG-6665]
toolchain.xml file should support environment variables
URL: https://github.com/apache/maven/pull/251#discussion_r289643063
##
File path:
maven-core/src/main/java/org/apache/maven/toolchain/building/DefaultToolchainsBuilder.java
##
@@ -66,16 +75,86 @@ public ToolchainsBuildingResult build(
ToolchainsBuildingRequest request )
toolchainsMerger.merge( userToolchains, globalToolchains,
TrackableBase.GLOBAL_LEVEL );
problems.setSource( "" );
-
+
+userToolchains = interpolate( userToolchains, problems );
+
if ( hasErrors( problems.getProblems() ) )
{
throw new ToolchainsBuildingException( problems.getProblems() );
}
-
-
+
+
return new DefaultToolchainsBuildingResult( userToolchains,
problems.getProblems() );
}
+private PersistedToolchains interpolate( PersistedToolchains toolchains,
ProblemCollector problems )
+{
+
+StringWriter stringWriter = new StringWriter( 1024 * 4 );
+try
+{
+toolchainsWriter.write( stringWriter, null, toolchains );
+}
+catch ( IOException e )
+{
+throw new IllegalStateException( "Failed to serialize toolchains
to memory", e );
+}
+
+String serializedToolchains = stringWriter.toString();
+
+RegexBasedInterpolator interpolator = new RegexBasedInterpolator();
+
+try
+{
+interpolator.addValueSource( new EnvarBasedValueSource() );
+}
+catch ( IOException e )
+{
+problems.add( Problem.Severity.WARNING, "Failed to use environment
variables for interpolation: "
++ e.getMessage(), -1, -1, e );
+}
+
+interpolator.addPostProcessor( new InterpolationPostProcessor()
+{
+@Override
+public Object execute( String expression, Object value )
+{
+if ( value != null )
+{
+// we're going to parse this back in as XML so we need to
escape XML markup
+value = value.toString().replace( "&", "" ).replace(
"<", "" ).replace( ">", "" );
Review comment:
This logic is taken from the DefaultSettingsBuilder, if it already exists in
one of the libraries I can change both places.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-archetype] Tibor17 commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)
Tibor17 commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-498030811 @eolivelli Easier thing would be to enable the output logs: https://maven.apache.org/plugins/maven-invoker-plugin/run-mojo.html#showErrors https://maven.apache.org/plugins/maven-invoker-plugin/run-mojo.html#streamLogs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (SUREFIRE-1670) wrong "Filtering by Test Class Names" in failsafe "Using JUnit 5 Platform" page
Masahiko Sakamoto created SUREFIRE-1670: --- Summary: wrong "Filtering by Test Class Names" in failsafe "Using JUnit 5 Platform" page Key: SUREFIRE-1670 URL: https://issues.apache.org/jira/browse/SUREFIRE-1670 Project: Maven Surefire Issue Type: Bug Components: documentation, Maven Failsafe Plugin Reporter: Masahiko Sakamoto In http://maven.apache.org/surefire/maven-failsafe-plugin/examples/junit-platform.html , "Filtering by Test Class Names" section says " ... Test.java". But these are wrong because these class name patterns is for surefire-plugin. That url is for failsafe-plugin, so that section should be "...IT.java" . (e.g. http://maven.apache.org/surefire/maven-failsafe-plugin/integration-test-mojo.html#includes ) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-archetype] Tibor17 commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)
Tibor17 commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-498029797 @eolivelli Try to use the script we have in surefire and you will see the zip. Adapt the script for this project (dir names) and then update the official scrpt but do not update it multiple times; otherwise all 100 maven projects and branches are run and the Jenkins is overloaded then. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Commented] (MNG-4979) Cannot override configuration parameter from command line
[
https://issues.apache.org/jira/browse/MNG-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16853944#comment-16853944
]
Robert Scholte commented on MNG-4979:
-
By giving the configuration a final version, you'll turn it into a constant,
replacing the expression to a specific value that cannot be overridden via
commandline. That's a feature.
The proper way to solve this is by changing its value via properties:
{code:xml}
false
{code}
Now you can override it via commandline.
> Cannot override configuration parameter from command line
> -
>
> Key: MNG-4979
> URL: https://issues.apache.org/jira/browse/MNG-4979
> Project: Maven
> Issue Type: Bug
> Components: Plugins and Lifecycle
>Affects Versions: 2.2.1
>Reporter: Stefan Birkner
>Priority: Major
>
> See the attachements for a sample project of the surefire integration tests.
> Its pom sets the skipTests option of the surefire-plugin to false.
>
> ...
>
> false
>
>
> This configuration is not overriden by the appropriate command line parameter:
> mvn -DskipTests=true test
> Executing this line will set the skipTests parameter of the Surefire plugin
> to false and the tests will not be skipped.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [maven-archetype] Tibor17 commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)
Tibor17 commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-498016483 @eolivelli No, maybe because they are supposed to be Maven artifacts. Deploying snapshots to ASF Sonatype repo would make more sense. There is not `archive` nor `zip` function called in the script https://gitbox.apache.org/repos/asf?p=maven-jenkins-lib.git;a=blob_plain;f=vars/asfMavenTlpPlgnBuild.groovy;hb=HEAD This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-archetype] eolivelli commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)
eolivelli commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-498014132 @Tibor17 is there any way to get build files? In surefire we are creating a zip with all of the logs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-archetype] eolivelli commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8)
eolivelli commented on issue #28: ARCHETYPE-567: switch to dom4j 2.1.1 (and Java 8) URL: https://github.com/apache/maven-archetype/pull/28#issuecomment-498014094 I have reverted last commit. I don't think that it was the cause. I am digging into logs. Apparently there is no failure This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] cardil edited a comment on issue #112: Adding support for externally passed random seed and printing used seed on console
cardil edited a comment on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-498011714 > I have a question to the new constant RANDOM_SEED in BooterConstants. Was is necessary. Could it be transfered in the value of randomOrder? This property is used to pass a computed random seed to forked process with Booter Serializer/Deserializer. Passing just run order is insufficient. When user do not pass a seed, I generate one and use it to order tests and print it on console. I can modify runOrder value, bu i feel like that's code smell. Better to leave it in original value and add additional parameter as exact seed - genereted or given. Example: User gives `-Dsurefire.runOrder=random`. I generate seed, say: `128312` and pass `runOrder => random, seed => 128312` to forked process. When user gives `-Dsurefire.runOrder=random:128312`, I reuse seed given and pass `runOrder => random:128312, seed => 128312` to forked process. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console
Tibor17 commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-498013493 @cardil Regarding the comment https://github.com/apache/maven-surefire/pull/112#issuecomment-498011714 I perfectly understand the code smell. I was thinking about extension abilities by user's SPI. So, if we transfer the string from plugin JVM to the forked JVM means that the use can attach SPI class to the forked JVM and use his own mechanism to 1. parse this string and 2. implement RunOrder. WDYT? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console
cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-498012985 Ok. I've rebased the code. I will now work on site documentation and on code coverage as @Tibor17 suggested. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console
cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-498012857 > @cardil I'd like to appreciate this plugin extension. I've used it for my project to find some test orders that may lead to failures, it's very convenient that I can reproduce exact order on any machine whatever JVM it has. Awesome. I've been using that pattern for years in different languages. It's really helpful. But to use it to full extend we should think of a way of passing this seed to JUnit, TestNG to let those frameworks consume the external seed to order their execution in random, but deterministic way. That would be awesome! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] cardil commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console
cardil commented on a change in pull request #112: Adding support for
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r289633174
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java
##
@@ -181,6 +183,30 @@ public void runStarting()
log( "---" );
log( " T E S T S" );
log( "---" );
+displayRandomization();
+}
+}
+
+private boolean isRandomized()
+{
+return reportConfiguration.getRunOrderParameters() != null
+&& reportConfiguration.getRunOrderParameters().isRandomized();
+}
+
+private void displayRandomization()
+{
+if ( isRandomized() )
+{
+final Randomizer randomizer =
reportConfiguration.getRunOrderParameters().getRandomizer();
+final String pluginName = reportConfiguration.getPluginName();
+
+log( "" );
+log( String.format(
Review comment:
This is crucial place. Without showing the seed to user, by default, this PR
have no sense. It must be presented to user be able to reproduce the same exact
run.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] cardil commented on a change in pull request #112: Adding support for externally passed random seed and printing used seed on console
cardil commented on a change in pull request #112: Adding support for
externally passed random seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#discussion_r289633130
##
File path:
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/DefaultReporterFactory.java
##
@@ -181,6 +183,30 @@ public void runStarting()
log( "---" );
log( " T E S T S" );
log( "---" );
+displayRandomization();
+}
+}
+
+private boolean isRandomized()
+{
+return reportConfiguration.getRunOrderParameters() != null
+&& reportConfiguration.getRunOrderParameters().isRandomized();
+}
+
+private void displayRandomization()
+{
+if ( isRandomized() )
+{
+final Randomizer randomizer =
reportConfiguration.getRunOrderParameters().getRandomizer();
+final String pluginName = reportConfiguration.getPluginName();
+
+log( "" );
+log( String.format(
+"Tests are randomly ordered. Re-run the same execution
order"
++ " with -D%s.runOrder=random:%d",
+pluginName, randomizer.getSeed()
+) );
+log( "" );
Review comment:
This is "\n", just like the code in `runCompleted()` (just beneath) that
existed before.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[jira] [Reopened] (MNG-4979) Cannot override configuration parameter from command line
[ https://issues.apache.org/jira/browse/MNG-4979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tibor Digana reopened MNG-4979: --- User setting should take precedens of POM setting. We have seen this as serious problem for users. > Cannot override configuration parameter from command line > - > > Key: MNG-4979 > URL: https://issues.apache.org/jira/browse/MNG-4979 > Project: Maven > Issue Type: Bug > Components: Plugins and Lifecycle >Affects Versions: 2.2.1 >Reporter: Stefan Birkner >Priority: Major > > See the attachements for a sample project of the surefire integration tests. > Its pom sets the skipTests option of the surefire-plugin to false. > > ... > > false > > > This configuration is not overriden by the appropriate command line parameter: > mvn -DskipTests=true test > Executing this line will set the skipTests parameter of the Surefire plugin > to false and the tests will not be skipped. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [maven-surefire] cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console
cardil commented on issue #112: Adding support for externally passed random
seed and printing used seed on console
URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-498012070
> Can you remove this text from JavaDoc from both MOJO classes?
> MNG-4979 should be reopened and fixes but it is secondary problem of Maven
itself.
>
> ```
> * Note that due to bug https://issues.apache.org/jira/browse/MNG-4979;>MNG-4979 it's
> * better to configure {@code runOrder} in {@code pom.xml} file using
Maven {@code properties},
> * if you feel that you will need to change this parameter from the
command line in the future.
> *
> *
> ```
Ok, I will remove it. Can you reopen that task? Or create other? I't lng
lasting problem.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [maven-surefire] cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console
cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-498011781 > Is there related issue in ASF Jira for this PR? I think not. I've just created this PR 3 years ago. I didn't created an issue. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-surefire] cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console
cardil commented on issue #112: Adding support for externally passed random seed and printing used seed on console URL: https://github.com/apache/maven-surefire/pull/112#issuecomment-498011714 > @cardil I'd like to appreciate this plugin extension. I've used it for my project to find some test orders that may lead to failures, it's very convenient that I can reproduce exact order on any machine whatever JVM it has. > BooterConstants This property is used to pass a computed random seed to forked process with Booter Serializer/Deserializer. Passing just run order is insufficient. When user do not pass a seed, I generate one and use it to order tests and print it on console. I can modify runOrder value, bu i feel like that's code smell. Better to leave it in original value and add additional parameter as exact seed - genereted or given. Example: User gives `-Dsurefire.runOrder=random`. I generate seed, say: `128312` and pass `runOrder => random, seed => 128312` to forked process. When user gives `-Dsurefire.runOrder=random:128312`, I reuse seed given and pass `runOrder => random:128312, seed => 128312` to forked process. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
