[jira] [Commented] (MSHARED-681) Maven-Shared: Java7Support silently fails overwriting symlinks
[ https://issues.apache.org/jira/browse/MSHARED-681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116341#comment-17116341 ] Hudson commented on MSHARED-681: Build succeeded in Jenkins: Maven TLP » maven-shared-utils » master #61 See https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/master/61/ > Maven-Shared: Java7Support silently fails overwriting symlinks > -- > > Key: MSHARED-681 > URL: https://issues.apache.org/jira/browse/MSHARED-681 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-utils >Reporter: Markus Karg >Assignee: Olivier Lamy >Priority: Critical > > When A is an existing symlink to B, then createSymbolicLink(A,C) does > neither overwrite A->B by A->C (as expected in analogy to the behavior > of copy(A,C)) nor does it throw an exception nor does it return A->B to > indicate the failure, but it actually "silently fails", i. e. it returns > A->C! > This certainly is heavily problematic, unsymmetric to what > copy(File,File) and Files.createSymbolicLink(Path,Path) do, and > certainly unwanted and buggy behavior. > The solution is to delete any existing target before creating the > symlic, hence copying the behavior of copy(File,File). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MSHARED-681) Maven-Shared: Java7Support silently fails overwriting symlinks
[ https://issues.apache.org/jira/browse/MSHARED-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy closed MSHARED-681. Resolution: Fixed > Maven-Shared: Java7Support silently fails overwriting symlinks > -- > > Key: MSHARED-681 > URL: https://issues.apache.org/jira/browse/MSHARED-681 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-utils >Reporter: Markus Karg >Assignee: Olivier Lamy >Priority: Critical > Fix For: maven-shared-utils-3.3.0 > > > When A is an existing symlink to B, then createSymbolicLink(A,C) does > neither overwrite A->B by A->C (as expected in analogy to the behavior > of copy(A,C)) nor does it throw an exception nor does it return A->B to > indicate the failure, but it actually "silently fails", i. e. it returns > A->C! > This certainly is heavily problematic, unsymmetric to what > copy(File,File) and Files.createSymbolicLink(Path,Path) do, and > certainly unwanted and buggy behavior. > The solution is to delete any existing target before creating the > symlic, hence copying the behavior of copy(File,File). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSHARED-681) Maven-Shared: Java7Support silently fails overwriting symlinks
[ https://issues.apache.org/jira/browse/MSHARED-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy updated MSHARED-681: - Fix Version/s: maven-shared-utils-3.3.0 > Maven-Shared: Java7Support silently fails overwriting symlinks > -- > > Key: MSHARED-681 > URL: https://issues.apache.org/jira/browse/MSHARED-681 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-utils >Reporter: Markus Karg >Assignee: Olivier Lamy >Priority: Critical > Fix For: maven-shared-utils-3.3.0 > > > When A is an existing symlink to B, then createSymbolicLink(A,C) does > neither overwrite A->B by A->C (as expected in analogy to the behavior > of copy(A,C)) nor does it throw an exception nor does it return A->B to > indicate the failure, but it actually "silently fails", i. e. it returns > A->C! > This certainly is heavily problematic, unsymmetric to what > copy(File,File) and Files.createSymbolicLink(Path,Path) do, and > certainly unwanted and buggy behavior. > The solution is to delete any existing target before creating the > symlic, hence copying the behavior of copy(File,File). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MSHARED-681) Maven-Shared: Java7Support silently fails overwriting symlinks
[ https://issues.apache.org/jira/browse/MSHARED-681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Olivier Lamy reassigned MSHARED-681: Assignee: Olivier Lamy > Maven-Shared: Java7Support silently fails overwriting symlinks > -- > > Key: MSHARED-681 > URL: https://issues.apache.org/jira/browse/MSHARED-681 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-utils >Reporter: Markus Karg >Assignee: Olivier Lamy >Priority: Critical > > When A is an existing symlink to B, then createSymbolicLink(A,C) does > neither overwrite A->B by A->C (as expected in analogy to the behavior > of copy(A,C)) nor does it throw an exception nor does it return A->B to > indicate the failure, but it actually "silently fails", i. e. it returns > A->C! > This certainly is heavily problematic, unsymmetric to what > copy(File,File) and Files.createSymbolicLink(Path,Path) do, and > certainly unwanted and buggy behavior. > The solution is to delete any existing target before creating the > symlic, hence copying the behavior of copy(File,File). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSITE-845) Drop Maven 2 support
[ https://issues.apache.org/jira/browse/MSITE-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116273#comment-17116273 ] Hudson commented on MSITE-845: -- Build succeeded in Jenkins: Maven TLP » maven-site-plugin » plex #5 See https://builds.apache.org/job/maven-box/job/maven-site-plugin/job/plex/5/ > Drop Maven 2 support > > > Key: MSITE-845 > URL: https://issues.apache.org/jira/browse/MSITE-845 > Project: Maven Site Plugin > Issue Type: Improvement >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.9.1 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (JXR-154) xref-test package summary lists also classes from main source directories
[
https://issues.apache.org/jira/browse/JXR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116239#comment-17116239
]
Robert Scholte commented on JXR-154:
I don't recall introducing it, but I did refactor it a lot. IIRC it acts like a
classloader, so source files can refer to each other, that's why it is a
singleton.
> xref-test package summary lists also classes from main source directories
> -
>
> Key: JXR-154
> URL: https://issues.apache.org/jira/browse/JXR-154
> Project: Maven JXR
> Issue Type: Bug
> Components: maven2 jxr plugin
>Affects Versions: 3.1.0
> Environment: Apache Maven 3.6.3
> (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /opt/apache-maven
> Java version: 1.8.0_201, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_CA, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-101-generic", arch: "amd64", family: "unix
>Reporter: Andreas Sewe
>Priority: Major
> Labels: regression
> Fix For: next-release
>
> Attachments: it.patch
>
>
> This is a regression from 3.0.0:
> The {{xref-test}} report lists not only classes from the test source
> directories, but also from the main source directories in its
> {{package-summary.html}}. This is not only unexpected, but the respective
> links to the actual sources are also dead.
> Using {{git bisect}}, I was able to narrow this bug (introduced between
> jxr-3.0.0 and 82193ede1e036a0e66e1591295f2311982a17c73) down to the following
> commit:
> {noformat}
> b4117e7ef0795eed02e2ace3c9c4c310f5391aac is the first bad commit
> commit b4117e7ef0795eed02e2ace3c9c4c310f5391aac
> Author: rfscholte
> Date: Fri Jul 5 00:11:29 2019 +0200[JXR-142] Switch to JSR330
> Dependency Injection,
> [JXR-144] Require Maven 3.1.0:04 04
> 9bd9a415b2e3d94406911ca475603de67b504be9
> dc78032a3f63c806041f360da96e9468c955f421 M maven-jxr-plugin
> :04 04 a9bbe183fcbc2b22afae203be4483fd9c1dd2a1b
> c15f3e82de0050ffa3834c0ff076fa8a6b57c31a Mmaven-jxr
> :100644 100644 e61a9f56ba6ea12165b72967873f72ed7611f894
> be2f7ecc125a573c7316c048dc521c40c60aa5f1 Mpom.xml
> bisect run success {noformat}
> using the attached patch [^it.patch] to the most basic integration test,
> {{simple-project}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MSITE-845) Drop Maven 2 support
[ https://issues.apache.org/jira/browse/MSITE-845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116233#comment-17116233 ] Hudson commented on MSITE-845: -- Build succeeded in Jenkins: Maven TLP » maven-site-plugin » master #95 See https://builds.apache.org/job/maven-box/job/maven-site-plugin/job/master/95/ > Drop Maven 2 support > > > Key: MSITE-845 > URL: https://issues.apache.org/jira/browse/MSITE-845 > Project: Maven Site Plugin > Issue Type: Improvement >Reporter: Tibor Digana >Assignee: Tibor Digana >Priority: Major > Fix For: 3.9.1 > > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JXR-146) upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts
[ https://issues.apache.org/jira/browse/JXR-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated JXR-146: -- Fix Version/s: next-release > upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts > --- > > Key: JXR-146 > URL: https://issues.apache.org/jira/browse/JXR-146 > Project: Maven JXR > Issue Type: Dependency upgrade >Affects Versions: 3.0.0 >Reporter: Herve Boutemy >Priority: Major > Labels: up-for-grabs > Fix For: next-release > > > to benefit from dependencies removal in DOXIASITETOOLS-215 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (JXR-154) xref-test package summary lists also classes from main source directories
[
https://issues.apache.org/jira/browse/JXR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated JXR-154:
--
Fix Version/s: next-release
> xref-test package summary lists also classes from main source directories
> -
>
> Key: JXR-154
> URL: https://issues.apache.org/jira/browse/JXR-154
> Project: Maven JXR
> Issue Type: Bug
> Components: maven2 jxr plugin
>Affects Versions: 3.1.0
> Environment: Apache Maven 3.6.3
> (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /opt/apache-maven
> Java version: 1.8.0_201, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_CA, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-101-generic", arch: "amd64", family: "unix
>Reporter: Andreas Sewe
>Priority: Major
> Labels: regression
> Fix For: next-release
>
> Attachments: it.patch
>
>
> This is a regression from 3.0.0:
> The {{xref-test}} report lists not only classes from the test source
> directories, but also from the main source directories in its
> {{package-summary.html}}. This is not only unexpected, but the respective
> links to the actual sources are also dead.
> Using {{git bisect}}, I was able to narrow this bug (introduced between
> jxr-3.0.0 and 82193ede1e036a0e66e1591295f2311982a17c73) down to the following
> commit:
> {noformat}
> b4117e7ef0795eed02e2ace3c9c4c310f5391aac is the first bad commit
> commit b4117e7ef0795eed02e2ace3c9c4c310f5391aac
> Author: rfscholte
> Date: Fri Jul 5 00:11:29 2019 +0200[JXR-142] Switch to JSR330
> Dependency Injection,
> [JXR-144] Require Maven 3.1.0:04 04
> 9bd9a415b2e3d94406911ca475603de67b504be9
> dc78032a3f63c806041f360da96e9468c955f421 M maven-jxr-plugin
> :04 04 a9bbe183fcbc2b22afae203be4483fd9c1dd2a1b
> c15f3e82de0050ffa3834c0ff076fa8a6b57c31a Mmaven-jxr
> :100644 100644 e61a9f56ba6ea12165b72967873f72ed7611f894
> be2f7ecc125a573c7316c048dc521c40c60aa5f1 Mpom.xml
> bisect run success {noformat}
> using the attached patch [^it.patch] to the most basic integration test,
> {{simple-project}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6919) maven-wrapper on windows
[ https://issues.apache.org/jira/browse/MNG-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116195#comment-17116195 ] Robert Scholte commented on MNG-6919: - After adding a space to a folder, I only see failures with the source type. The javac and java commands are missing proper quotes, so I'll fix that. Can you share a failing build with the current scripts? > maven-wrapper on windows > > > Key: MNG-6919 > URL: https://issues.apache.org/jira/browse/MNG-6919 > Project: Maven > Issue Type: Bug > Components: Bootstrap Build >Affects Versions: 3.7.0-candidate >Reporter: James Z.M. Gao >Priority: Minor > > new maven-wrapper inherit 2 bugs for windows batch scripts: > # cannot read the config ".mvn\wrapper\maven-wrapper.properties" correctly > when the full path has space. > # -eof style of cmd scripts are not CRLF- (This is fixed by assembly-plugin > `lineEnding` settings) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MNG-6920) in maven-wrapper, maven user home is not consistent with maven core
[ https://issues.apache.org/jira/browse/MNG-6920?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MNG-6920. --- Fix Version/s: 3.7.0 Resolution: Fixed Fixed in [f8b556c2e88f32c618405ed76ec1917a12682bed|https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=f8b556c2e88f32c618405ed76ec1917a12682bed] Thanks for the PR! > in maven-wrapper, maven user home is not consistent with maven core > --- > > Key: MNG-6920 > URL: https://issues.apache.org/jira/browse/MNG-6920 > Project: Maven > Issue Type: Improvement > Components: Bootstrap Build >Affects Versions: 3.7.0-candidate >Reporter: James Z.M. Gao >Assignee: Robert Scholte >Priority: Minor > Fix For: 3.7.0 > > > New maven wrapper guesses the maven user home location via system props, > system envs > and at last the default location (~/.m2). This guessing order is the > convention of the gradle wrapper. > For maven, user home has a fixed location, i.e. ~/.m2, described > [here|https://maven.apache.org/settings.html#Settings_Details] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (JXR-154) xref-test package summary lists also classes from main source directories
[
https://issues.apache.org/jira/browse/JXR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116183#comment-17116183
]
Andreas Sewe commented on JXR-154:
--
{quote}
Will prepare a pull request that fixes this.
{quote}
Easier said than done. At the moment,
https://github.com/sewe/maven-jxr/tree/JXR-154 fails the {{JXR141Test}}.
Why? There is a lot of shared state/caching and _sometimes_ this seems to be
relied on, e.g., when {{JavaCodeTransform}} relies on its {{FileManager}} being
the same {{FileManager}} that was "filled" by using a {{PackageManager}}
earlier in {{JXR.xref}}. But even if desired, the way {{FileManager}} and
{{PackageManager}} are shared (or not, as there are also {{new FileManager()}}
calls) seems very brittle and error-prone and I wouldn't be surprised if other
bugs besides JXR-154 are hidden therein.
Maybe this is something [~rfscholte] could have a look at, as he introduced the
shared components initially.
> xref-test package summary lists also classes from main source directories
> -
>
> Key: JXR-154
> URL: https://issues.apache.org/jira/browse/JXR-154
> Project: Maven JXR
> Issue Type: Bug
> Components: maven2 jxr plugin
>Affects Versions: 3.1.0
> Environment: Apache Maven 3.6.3
> (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /opt/apache-maven
> Java version: 1.8.0_201, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_CA, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-101-generic", arch: "amd64", family: "unix
>Reporter: Andreas Sewe
>Priority: Major
> Labels: regression
> Attachments: it.patch
>
>
> This is a regression from 3.0.0:
> The {{xref-test}} report lists not only classes from the test source
> directories, but also from the main source directories in its
> {{package-summary.html}}. This is not only unexpected, but the respective
> links to the actual sources are also dead.
> Using {{git bisect}}, I was able to narrow this bug (introduced between
> jxr-3.0.0 and 82193ede1e036a0e66e1591295f2311982a17c73) down to the following
> commit:
> {noformat}
> b4117e7ef0795eed02e2ace3c9c4c310f5391aac is the first bad commit
> commit b4117e7ef0795eed02e2ace3c9c4c310f5391aac
> Author: rfscholte
> Date: Fri Jul 5 00:11:29 2019 +0200[JXR-142] Switch to JSR330
> Dependency Injection,
> [JXR-144] Require Maven 3.1.0:04 04
> 9bd9a415b2e3d94406911ca475603de67b504be9
> dc78032a3f63c806041f360da96e9468c955f421 M maven-jxr-plugin
> :04 04 a9bbe183fcbc2b22afae203be4483fd9c1dd2a1b
> c15f3e82de0050ffa3834c0ff076fa8a6b57c31a Mmaven-jxr
> :100644 100644 e61a9f56ba6ea12165b72967873f72ed7611f894
> be2f7ecc125a573c7316c048dc521c40c60aa5f1 Mpom.xml
> bisect run success {noformat}
> using the attached patch [^it.patch] to the most basic integration test,
> {{simple-project}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JXR-154) xref-test package summary lists also classes from main source directories
[
https://issues.apache.org/jira/browse/JXR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116171#comment-17116171
]
Andreas Sewe commented on JXR-154:
--
OK, I figured out the root cause: The "Switch to JSR330 Dependency Injection"
made the {{PackageManager}}, which keeps tracks of the packages and their
classes seen so far, a {{@Singleton}}. And this causes the same
{{PackageManager}} instance to be used in the invocation of the {{jxr}} and
{{test-jxr}} goals.
Will prepare a pull request that fixes this.
> xref-test package summary lists also classes from main source directories
> -
>
> Key: JXR-154
> URL: https://issues.apache.org/jira/browse/JXR-154
> Project: Maven JXR
> Issue Type: Bug
> Components: maven2 jxr plugin
>Affects Versions: 3.1.0
> Environment: Apache Maven 3.6.3
> (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /opt/apache-maven
> Java version: 1.8.0_201, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_CA, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-101-generic", arch: "amd64", family: "unix
>Reporter: Andreas Sewe
>Priority: Major
> Labels: regression
> Attachments: it.patch
>
>
> This is a regression from 3.0.0:
> The {{xref-test}} report lists not only classes from the test source
> directories, but also from the main source directories in its
> {{package-summary.html}}. This is not only unexpected, but the respective
> links to the actual sources are also dead.
> Using {{git bisect}}, I was able to narrow this bug (introduced between
> jxr-3.0.0 and 82193ede1e036a0e66e1591295f2311982a17c73) down to the following
> commit:
> {noformat}
> b4117e7ef0795eed02e2ace3c9c4c310f5391aac is the first bad commit
> commit b4117e7ef0795eed02e2ace3c9c4c310f5391aac
> Author: rfscholte
> Date: Fri Jul 5 00:11:29 2019 +0200[JXR-142] Switch to JSR330
> Dependency Injection,
> [JXR-144] Require Maven 3.1.0:04 04
> 9bd9a415b2e3d94406911ca475603de67b504be9
> dc78032a3f63c806041f360da96e9468c955f421 M maven-jxr-plugin
> :04 04 a9bbe183fcbc2b22afae203be4483fd9c1dd2a1b
> c15f3e82de0050ffa3834c0ff076fa8a6b57c31a Mmaven-jxr
> :100644 100644 e61a9f56ba6ea12165b72967873f72ed7611f894
> be2f7ecc125a573c7316c048dc521c40c60aa5f1 Mpom.xml
> bisect run success {noformat}
> using the attached patch [^it.patch] to the most basic integration test,
> {{simple-project}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (JXR-154) xref-test package summary lists also classes from main source directories
[
https://issues.apache.org/jira/browse/JXR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116149#comment-17116149
]
Andreas Sewe commented on JXR-154:
--
For the record, the full {{git bisect}} history:
{noformat}
git bisect start
# good: [224c62f3d0098042fb0a9d228434082e249c4c5b] [maven-release-plugin]
prepare release jxr-3.0.0
git bisect good 224c62f3d0098042fb0a9d228434082e249c4c5b
# bad: [82193ede1e036a0e66e1591295f2311982a17c73] remove unused imports (#24)
git bisect bad 82193ede1e036a0e66e1591295f2311982a17c73
# bad: [ab343d1704760cf448031802979915f2d7f7e044] README improvement
git bisect bad ab343d1704760cf448031802979915f2d7f7e044
# bad: [85fb8b1b444d76a86e0cd1b19039b2637da6fd19] [JXR-147] make build
Reproducible
git bisect bad 85fb8b1b444d76a86e0cd1b19039b2637da6fd19
# good: [910158efbc691cc8ebbd7120ba97d62abc78b056] added a link to plugin
documentation
git bisect good 910158efbc691cc8ebbd7120ba97d62abc78b056
# bad: [b4117e7ef0795eed02e2ace3c9c4c310f5391aac] [JXR-142] Switch to JSR330
Dependency Injection, [JXR-144] Require Maven 3.1.0
git bisect bad b4117e7ef0795eed02e2ace3c9c4c310f5391aac
# good: [6f50a1c74d0d3aabe1f0223c5b3791f713ab7276] Add non-forking jxr/test-jxr
goals
git bisect good 6f50a1c74d0d3aabe1f0223c5b3791f713ab7276
# first bad commit: [b4117e7ef0795eed02e2ace3c9c4c310f5391aac] [JXR-142] Switch
to JSR330 Dependency Injection, [JXR-144] Require Maven 3.1.0 {noformat}
> xref-test package summary lists also classes from main source directories
> -
>
> Key: JXR-154
> URL: https://issues.apache.org/jira/browse/JXR-154
> Project: Maven JXR
> Issue Type: Bug
> Components: maven2 jxr plugin
>Affects Versions: 3.1.0
> Environment: Apache Maven 3.6.3
> (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /opt/apache-maven
> Java version: 1.8.0_201, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_CA, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-101-generic", arch: "amd64", family: "unix
>Reporter: Andreas Sewe
>Priority: Major
> Labels: regression
> Attachments: it.patch
>
>
> This is a regression from 3.0.0:
> The {{xref-test}} report lists not only classes from the test source
> directories, but also from the main source directories in its
> {{package-summary.html}}. This is not only unexpected, but the respective
> links to the actual sources are also dead.
> Using {{git bisect}}, I was able to narrow this bug (introduced between
> jxr-3.0.0 and 82193ede1e036a0e66e1591295f2311982a17c73) down to the following
> commit:
> {noformat}
> b4117e7ef0795eed02e2ace3c9c4c310f5391aac is the first bad commit
> commit b4117e7ef0795eed02e2ace3c9c4c310f5391aac
> Author: rfscholte
> Date: Fri Jul 5 00:11:29 2019 +0200[JXR-142] Switch to JSR330
> Dependency Injection,
> [JXR-144] Require Maven 3.1.0:04 04
> 9bd9a415b2e3d94406911ca475603de67b504be9
> dc78032a3f63c806041f360da96e9468c955f421 M maven-jxr-plugin
> :04 04 a9bbe183fcbc2b22afae203be4483fd9c1dd2a1b
> c15f3e82de0050ffa3834c0ff076fa8a6b57c31a Mmaven-jxr
> :100644 100644 e61a9f56ba6ea12165b72967873f72ed7611f894
> be2f7ecc125a573c7316c048dc521c40c60aa5f1 Mpom.xml
> bisect run success {noformat}
> using the attached patch [^it.patch] to the most basic integration test,
> {{simple-project}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (JXR-154) xref-test package summary lists also classes from main source directories
[
https://issues.apache.org/jira/browse/JXR-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andreas Sewe updated JXR-154:
-
Attachment: it.patch
Description:
This is a regression from 3.0.0:
The {{xref-test}} report lists not only classes from the test source
directories, but also from the main source directories in its
{{package-summary.html}}. This is not only unexpected, but the respective links
to the actual sources are also dead.
Using {{git bisect}}, I was able to narrow this bug (introduced between
jxr-3.0.0 and 82193ede1e036a0e66e1591295f2311982a17c73) down to the following
commit:
{noformat}
b4117e7ef0795eed02e2ace3c9c4c310f5391aac is the first bad commit
commit b4117e7ef0795eed02e2ace3c9c4c310f5391aac
Author: rfscholte
Date: Fri Jul 5 00:11:29 2019 +0200[JXR-142] Switch to JSR330 Dependency
Injection,
[JXR-144] Require Maven 3.1.0:04 04
9bd9a415b2e3d94406911ca475603de67b504be9
dc78032a3f63c806041f360da96e9468c955f421 M maven-jxr-plugin
:04 04 a9bbe183fcbc2b22afae203be4483fd9c1dd2a1b
c15f3e82de0050ffa3834c0ff076fa8a6b57c31a M maven-jxr
:100644 100644 e61a9f56ba6ea12165b72967873f72ed7611f894
be2f7ecc125a573c7316c048dc521c40c60aa5f1 M pom.xml
bisect run success {noformat}
using the attached patch [^it.patch] to the most basic integration test,
{{simple-project}}.
was:
This is a regression from 3.0.0:
The {{xref-test}} report lists not only classes from the test source
directories, but also from the main source directories in its
\{{package-summary.html}}. This is not only unexpected, but the respective
links to the actual sources are also dead.
Using {{git bisect}}, I was able to narrow this bug (introduced between
jxr-3.0.0 and 82193ede1e036a0e66e1591295f2311982a17c73) down to the following
commit:
{noformat}
b4117e7ef0795eed02e2ace3c9c4c310f5391aac is the first bad commit
commit b4117e7ef0795eed02e2ace3c9c4c310f5391aac
Author: rfscholte
Date: Fri Jul 5 00:11:29 2019 +0200[JXR-142] Switch to JSR330 Dependency
Injection,
[JXR-144] Require Maven 3.1.0:04 04
9bd9a415b2e3d94406911ca475603de67b504be9
dc78032a3f63c806041f360da96e9468c955f421 M maven-jxr-plugin
:04 04 a9bbe183fcbc2b22afae203be4483fd9c1dd2a1b
c15f3e82de0050ffa3834c0ff076fa8a6b57c31a M maven-jxr
:100644 100644 e61a9f56ba6ea12165b72967873f72ed7611f894
be2f7ecc125a573c7316c048dc521c40c60aa5f1 M pom.xml
bisect run success {noformat}
using the attached patch to the most basic integration test, {{simple-project}}.
Environment:
Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f)
Maven home: /opt/apache-maven
Java version: 1.8.0_201, vendor: Oracle Corporation, runtime:
/usr/lib/jvm/java-8-oracle/jre
Default locale: en_CA, platform encoding: UTF-8
OS name: "linux", version: "4.15.0-101-generic", arch: "amd64", family: "unix
> xref-test package summary lists also classes from main source directories
> -
>
> Key: JXR-154
> URL: https://issues.apache.org/jira/browse/JXR-154
> Project: Maven JXR
> Issue Type: Bug
> Components: maven2 jxr plugin
>Affects Versions: 3.1.0
> Environment: Apache Maven 3.6.3
> (cecedd343002696d0abb50b32b541b8a6ba2883f)
> Maven home: /opt/apache-maven
> Java version: 1.8.0_201, vendor: Oracle Corporation, runtime:
> /usr/lib/jvm/java-8-oracle/jre
> Default locale: en_CA, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-101-generic", arch: "amd64", family: "unix
>Reporter: Andreas Sewe
>Priority: Major
> Labels: regression
> Attachments: it.patch
>
>
> This is a regression from 3.0.0:
> The {{xref-test}} report lists not only classes from the test source
> directories, but also from the main source directories in its
> {{package-summary.html}}. This is not only unexpected, but the respective
> links to the actual sources are also dead.
> Using {{git bisect}}, I was able to narrow this bug (introduced between
> jxr-3.0.0 and 82193ede1e036a0e66e1591295f2311982a17c73) down to the following
> commit:
> {noformat}
> b4117e7ef0795eed02e2ace3c9c4c310f5391aac is the first bad commit
> commit b4117e7ef0795eed02e2ace3c9c4c310f5391aac
> Author: rfscholte
> Date: Fri Jul 5 00:11:29 2019 +0200[JXR-142] Switch to JSR330
> Dependency Injection,
> [JXR-144] Require Maven 3.1.0:04 04
> 9bd9a415b2e3d94406911ca475603de67b504be9
> dc78032a3f63c806041f360da96e9468c955f421 M maven-jxr-plugin
> :04 04 a9bbe183fcbc2b22afae203be4483fd9c1dd2a1b
> c15f3e82de0050ffa3834c0ff076fa8a6b57c31a Mmaven-jxr
> :100644 100644 e61a9f56ba6ea12165b72967873f72ed7611f894
> be2f7ecc125a573c7316c048dc521c40c60aa5f1 Mpom.xml
> bisect run success {noformat}
> using the attached patch [^it.patch] to the most basic integration
[jira] [Created] (JXR-154) xref-test package summary lists also classes from main source directories
Andreas Sewe created JXR-154:
Summary: xref-test package summary lists also classes from main
source directories
Key: JXR-154
URL: https://issues.apache.org/jira/browse/JXR-154
Project: Maven JXR
Issue Type: Bug
Components: maven2 jxr plugin
Affects Versions: 3.1.0
Reporter: Andreas Sewe
This is a regression from 3.0.0:
The {{xref-test}} report lists not only classes from the test source
directories, but also from the main source directories in its
\{{package-summary.html}}. This is not only unexpected, but the respective
links to the actual sources are also dead.
Using {{git bisect}}, I was able to narrow this bug (introduced between
jxr-3.0.0 and 82193ede1e036a0e66e1591295f2311982a17c73) down to the following
commit:
{noformat}
b4117e7ef0795eed02e2ace3c9c4c310f5391aac is the first bad commit
commit b4117e7ef0795eed02e2ace3c9c4c310f5391aac
Author: rfscholte
Date: Fri Jul 5 00:11:29 2019 +0200[JXR-142] Switch to JSR330 Dependency
Injection,
[JXR-144] Require Maven 3.1.0:04 04
9bd9a415b2e3d94406911ca475603de67b504be9
dc78032a3f63c806041f360da96e9468c955f421 M maven-jxr-plugin
:04 04 a9bbe183fcbc2b22afae203be4483fd9c1dd2a1b
c15f3e82de0050ffa3834c0ff076fa8a6b57c31a M maven-jxr
:100644 100644 e61a9f56ba6ea12165b72967873f72ed7611f894
be2f7ecc125a573c7316c048dc521c40c60aa5f1 M pom.xml
bisect run success {noformat}
using the attached patch to the most basic integration test, {{simple-project}}.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (MNG-6916) A hyphen sign in name of local repository causes build failure
[ https://issues.apache.org/jira/browse/MNG-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6916. --- Fix Version/s: (was: wontfix-candidate) Resolution: Invalid Thanks, closing this as invalid. > A hyphen sign in name of local repository causes build failure > -- > > Key: MNG-6916 > URL: https://issues.apache.org/jira/browse/MNG-6916 > Project: Maven > Issue Type: Bug > Components: Bootstrap Build >Affects Versions: 3.6.3 > Environment: Windows 10 Professional Build 1909 > Oracle JDK 11.0.7 > IntelliJ IDEA 2020.1 (Ultimate Edition) > Build #IU-201.6668.121, built on April 8, 2020 > Maven 3.6.3 >Reporter: axin >Priority: Trivial > Labels: build, test > > I created a maven project in IntelliJ idea. And there is only one dependency: > JUnit 4.13. I found that if the name of the local maven repository contains a > hyphen sign, the build will fail. > local maven repository name example: E:\Dev\maven-repository > The error is: package org.junit does not exist > > Update: This issue is caused by IntelliJ IDEA 2020.1.1 and 2020.1.2 > Maven works fine from the command line. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6916) A hyphen sign in name of local repository causes build failure
[ https://issues.apache.org/jira/browse/MNG-6916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116088#comment-17116088 ] axin commented on MNG-6916: --- [~michael-o] JetBrains says they have received similar bug reports. It is caused by a Kotlin plugin. They will fix this bug in the next stable release【IntelliJ IEDA 2020.1.3】. > A hyphen sign in name of local repository causes build failure > -- > > Key: MNG-6916 > URL: https://issues.apache.org/jira/browse/MNG-6916 > Project: Maven > Issue Type: Bug > Components: Bootstrap Build >Affects Versions: 3.6.3 > Environment: Windows 10 Professional Build 1909 > Oracle JDK 11.0.7 > IntelliJ IDEA 2020.1 (Ultimate Edition) > Build #IU-201.6668.121, built on April 8, 2020 > Maven 3.6.3 >Reporter: axin >Priority: Trivial > Labels: build, test > Fix For: wontfix-candidate > > > I created a maven project in IntelliJ idea. And there is only one dependency: > JUnit 4.13. I found that if the name of the local maven repository contains a > hyphen sign, the build will fail. > local maven repository name example: E:\Dev\maven-repository > The error is: package org.junit does not exist > > Update: This issue is caused by IntelliJ IDEA 2020.1.1 and 2020.1.2 > Maven works fine from the command line. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEP-644) Reintroduce the verbose option for dependency:tree
[ https://issues.apache.org/jira/browse/MDEP-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116084#comment-17116084 ] Ian Lavallee commented on MDEP-644: --- [~Olof Larsson] I'm working on it. It's my first significant ticket so it may take me a while but hopefully I can get it done. > Reintroduce the verbose option for dependency:tree > -- > > Key: MDEP-644 > URL: https://issues.apache.org/jira/browse/MDEP-644 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: John Lin >Priority: Major > Labels: intern > > The verbose option for dependency:tree is removed in maven-dependency-plugin > 3.0. This issue is to reintroduce the option. > In verbose mode the dependency tree shows dependencies that were omitted for: > being a duplicate of another; conflicting with another's version and/or > scope; and introducing a cycle into the dependency tree. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (JXR-152) Support search box
[ https://issues.apache.org/jira/browse/JXR-152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116077#comment-17116077 ] Jesper Udby commented on JXR-152: - [~rfscholte] I did look into it a few months ago and I do believe I came to the conclusion that is was not entirely trivial. I do not at the moment have the capacity to look into it. > Support search box > -- > > Key: JXR-152 > URL: https://issues.apache.org/jira/browse/JXR-152 > Project: Maven JXR > Issue Type: New Feature >Reporter: Robert Scholte >Priority: Major > > Since Java 13 frames have been removed > (https://bugs.openjdk.java.net/browse/JDK-8215599) in favor of the search > box (https://openjdk.java.net/jeps/225) > JXR should be able to do the same. Assuming relative paths are used and that > JXR generates the same pages, it should be possible to copy and reuse these > files and Javadoc is generated. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven] mthmulders commented on a change in pull request #342: [MNG-5760] Add --resume / -r switch
mthmulders commented on a change in pull request #342:
URL: https://github.com/apache/maven/pull/342#discussion_r429940070
##
File path: maven-core/src/main/java/org/apache/maven/DefaultMaven.java
##
@@ -366,20 +366,21 @@ private void afterSessionEnd( Collection
projects, MavenSession se
private void saveResumptionDataWhenApplicable( MavenExecutionResult
result, MavenSession session )
{
-List lifecycleExecutionExceptions =
result.getExceptions().stream()
+long lifecycleExecutionExceptionCount = result.getExceptions().stream()
.filter( LifecycleExecutionException.class::isInstance )
-.map( LifecycleExecutionException.class::cast )
-.collect( Collectors.toList() );
+.count();
Review comment:
Ah yes, of course, that makes perfect sense!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MCOMPILER-416) make build faster: when "Nothing to compile" then skip the follow-up plugin
[
https://issues.apache.org/jira/browse/MCOMPILER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17116016#comment-17116016
]
qxo commented on MCOMPILER-416:
---
Yes, just change "post action" goal from process-classes to compile phase
will fix the issue:
when nothing to compile , then no more these "post action":)
> make build faster: when "Nothing to compile" then skip the follow-up plugin
> ---
>
> Key: MCOMPILER-416
> URL: https://issues.apache.org/jira/browse/MCOMPILER-416
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Reporter: qxo
>Assignee: Robert Scholte
>Priority: Minor
>
> PR: [https://github.com/apache/maven-compiler-plugin/pull/33]
> make the build faster
> ie:
> {code:xml}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
>
> default-compile
> compile
>
> compile
>
>
> nothingToCompileOn
>
>
>
>
>
> org.apache.maven.plugins
> maven-antrun-plugin
> 3.0.0
>
>
> test1
> process-classes
>
>
>
>
>
>
> ${nothingToCompileOn}
>
>
> run
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution
Tibor17 edited a comment on pull request #293:
URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-633546412
@rfscholte
In my local test the JUnit4 is on modulepath. JUnit 4.13 is an automatic
module.
I've observed `java.lang.NoClassDefFoundError:
org/junit/runner/notification/RunNotifier` without `ALL-MODULE-PATH`. Another
options `--add-opens junit/org.junit=ALL-UNNAMED --add-opens
junit/org.junit.runner.notification=ALL-UNNAMED` did not help.
This is my descriptor in `src/main/java`:
```
module main
{
exports main;
}
```
and this is the test descriptor:
```
open module test
{
requires main;
requires junit;
exports test to junit;
}
```
This means we are missing the direction where classpath (surefire-api) is
calling the module `junit`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution
Tibor17 edited a comment on pull request #293:
URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-633546412
@rfscholte
In my local test the JUnit4 is on modulepath. JUnit 4.13 is an automatic
module.
I've observed `java.lang.NoClassDefFoundError:
org/junit/runner/notification/RunNotifier` without `ALL-MODULE-PATH`. Another
options `--add-opens junit/org.junit=ALL-UNNAMED --add-opens
junit/org.junit.runner.notification=ALL-UNNAMED` did not help.
This is my descriptor in `src/main/java`:
```
module main
{
exports main;
}
```
and this is the test descriptor:
```
open module test
{
requires main;
requires junit;
exports test to junit;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution
Tibor17 commented on pull request #293:
URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-633546412
@rfscholte
In my local test the JUnit4 is on modulepath. JUnit 4.13 is an automatic
module.
I've observed `java.lang.NoClassDefFoundError:
org/junit/runner/notification/RunNotifier` without `ALL-MODULE-PATH`. Another
options `--add-opens junit/org.junit=ALL-UNNAMED --add-opens
junit/org.junit.runner.notification=ALL-UNNAMED` did not help.
This is my descriptor in `src\main\java`:
```
module main
{
exports main;
}
```
and this is the test descriptor:
```
open module test
{
requires main;
requires junit;
exports test to junit;
}
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-enforcer] famod commented on a change in pull request #57: [MENFORCER-346] - RequireSnapshotVersion: Fix parent with CI Friendly Version
famod commented on a change in pull request #57: URL: https://github.com/apache/maven-enforcer/pull/57#discussion_r429904157 ## File path: maven-enforcer-plugin/src/it/projects/require-snapshot-version_failure_parent-ci-friendly/pom.xml ## @@ -0,0 +1,63 @@ + + + + + Review comment: Not sure I'm following: This is the root element so there should be no indentation here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo commented on a change in pull request #57: [MENFORCER-346] - RequireSnapshotVersion: Fix parent with CI Friendly Version
elharo commented on a change in pull request #57: URL: https://github.com/apache/maven-enforcer/pull/57#discussion_r429905368 ## File path: maven-enforcer-plugin/src/it/projects/require-snapshot-version_failure_parent-ci-friendly/pom.xml ## @@ -0,0 +1,63 @@ + + + + + Review comment: I must have been confused. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNGSITE-393) Remove references to Maven 2.x
[ https://issues.apache.org/jira/browse/MNGSITE-393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115979#comment-17115979 ] Hudson commented on MNGSITE-393: Build succeeded in Jenkins: Maven TLP » maven-site » elharo-patch-6 #5 See https://builds.apache.org/job/maven-box/job/maven-site/job/elharo-patch-6/5/ > Remove references to Maven 2.x > -- > > Key: MNGSITE-393 > URL: https://issues.apache.org/jira/browse/MNGSITE-393 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Major > Time Spent: 4h > Remaining Estimate: 0h > > Maven 3.x is over a decade old now and we're talking about Maven 4. It's time > to clean out all the random discussion here and there about how Maven 2.x did > things, differences between Maven 2 and 3, what works in Maven 3 but not 2, > etc. > Assume Maven 3.0 as the minimum, probably Maven 3.1. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-enforcer] famod commented on a change in pull request #57: [MENFORCER-346] - RequireSnapshotVersion: Fix parent with CI Friendly Version
famod commented on a change in pull request #57: URL: https://github.com/apache/maven-enforcer/pull/57#discussion_r429904157 ## File path: maven-enforcer-plugin/src/it/projects/require-snapshot-version_failure_parent-ci-friendly/pom.xml ## @@ -0,0 +1,63 @@ + + + + + Review comment: Not sure I'm following: This is the root element so there should be not indentation here? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] famod commented on pull request #57: [MENFORCER-346] - RequireSnapshotVersion: Fix parent with CI Friendly Version
famod commented on pull request #57: URL: https://github.com/apache/maven-enforcer/pull/57#issuecomment-633542683 > Thanks. This looks significant enough to require an ICLA. I've just submitted it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo closed pull request #67: ignore .checkstyle
elharo closed pull request #67: URL: https://github.com/apache/maven-enforcer/pull/67 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo opened a new pull request #67: ignore .checkstyle
elharo opened a new pull request #67: URL: https://github.com/apache/maven-enforcer/pull/67 @michael-o This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1570) Maven-fail-safe doesn't put testing JPMS module on module path
[
https://issues.apache.org/jira/browse/SUREFIRE-1570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115976#comment-17115976
]
Tibor Digana commented on SUREFIRE-1570:
I was an issue with JDK 11 on our Jenkins.
It's gone now.
> Maven-fail-safe doesn't put testing JPMS module on module path
> --
>
> Key: SUREFIRE-1570
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1570
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Failsafe Plugin
>Affects Versions: 2.22.0
>Reporter: Pavel_K
>Assignee: Tibor Digana
>Priority: Major
> Fix For: 3.0.0-M5
>
> Attachments: mavenproject20.zip
>
>
> I uploaded project - mavenproject20. Run `mvn verify`. You will see the
> following:
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO]
>
> [INFO] Building mavenproject20 0.1.0-SNAPSHOT
> [INFO]
>
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:resources (default-resources) @
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] Copying 0 resource
> [INFO]
> [INFO] --- maven-compiler-plugin:3.8.0:compile (default-compile) @
> mavenproject20 ---
> [WARNING]
>
> [WARNING] * Required filename-based automodules detected. Please don't
> publish this project to a public artifact repository! *
> [WARNING]
>
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 3 source files to
> /home/Jim/NetBeansProjects/mavenproject20/target/classes
> [WARNING]
> /home/Jim/NetBeansProjects/mavenproject20/src/main/java/module-info.java:[1,8]
> module name component Mavenproject20 should avoid terminal digits
> [INFO]
> [INFO] --- maven-resources-plugin:2.6:testResources (default-testResources) @
> mavenproject20 ---
> [INFO] Using 'UTF-8' encoding to copy filtered resources.
> [INFO] skip non existing resourceDirectory
> /home/Jim/NetBeansProjects/mavenproject20/src/test/resources
> [INFO]
> [INFO] --- maven-compiler-plugin:3.8.0:testCompile (default-testCompile) @
> mavenproject20 ---
> [INFO] Changes detected - recompiling the module!
> [INFO] Compiling 1 source file to
> /home/Jim/NetBeansProjects/mavenproject20/target/test-classes
> [INFO]
> [INFO] --- maven-surefire-plugin:2.12.4:test (default-test) @ mavenproject20
> ---
> [INFO]
> [INFO] --- maven-jar-plugin:2.4:jar (default-jar) @ mavenproject20 ---
> [INFO] Building jar:
> /home/Jim/NetBeansProjects/mavenproject20/target/mavenproject20-0.1.0-SNAPSHOT.jar
> [INFO]
> [INFO] --- maven-failsafe-plugin:2.22.0:integration-test (integration-tests)
> @ mavenproject20 ---
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> [INFO] Running me.pavel.mavenproject20.ServiceIT
> JDKModulePath:null
> ModuleName:null
> module jdk.unsupported
> module jdk.sctp
> module java.naming
> module java.jnlp
> module jdk.httpserver
> module java.xml
> module javafx.controls
> module java.datatransfer
> module jdk.javadoc
> module jdk.jconsole
> module java.instrument
> module jdk.packager
> module jdk.deploy
> module jdk.jfr
> module jdk.management
> module jdk.charsets
> module oracle.net
> module jdk.jdeps
> module java.sql.rowset
> module jdk.net
> module jdk.accessibility
> module jdk.attach
> module jdk.internal.le
> module jdk.snmp
> module java.base
> module jdk.plugin
> module jdk.dynalink
> module jdk.naming.rmi
> module jdk.internal.opt
> module java.management.rmi
> module jdk.management.jfr
> module javafx.swing
> module jdk.editpad
> module jdk.crypto.ec
> module jdk.javaws
> module jdk.jstatd
> module jdk.management.agent
> module javafx.graphics
> module javafx.media
> module java.rmi
> module java.prefs
> module jdk.security.jgss
> module javafx.fxml
> module java.smartcardio
> module jdk.xml.dom
> module java.xml.crypto
> module jdk.jsobject
> module jdk.jdi
> module jdk.compiler
> module java.management
> module jdk.management.cmm
> module jdk.packager.services
> module jdk.jartool
> module jdk.scripting.nashorn
> module java.security.jgss
> module jdk.localedata
> module java.desktop
> module jdk.zipfs
> module jdk.jshell
> module oracle.desktop
> module jdk.internal.ed
> module java.security.sasl
> module jdk.jdwp.agent
> module java.compiler
> module jdk.plugin.dom
> module
[GitHub] [maven-enforcer] elharo commented on pull request #32: [MENFORCER-298] Ensure bannedDependencies does not corrupt the classpath when using timestamped snapshots
elharo commented on pull request #32: URL: https://github.com/apache/maven-enforcer/pull/32#issuecomment-633539453 Since this is several years old, I'm going to close it. Feel free to open a new PR that resolves the merge conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo closed pull request #32: [MENFORCER-298] Ensure bannedDependencies does not corrupt the classpath when using timestamped snapshots
elharo closed pull request #32: URL: https://github.com/apache/maven-enforcer/pull/32 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo commented on pull request #26: Add Unit tests for RequireUpperBoundDeps
elharo commented on pull request #26: URL: https://github.com/apache/maven-enforcer/pull/26#issuecomment-633539263 Since this is several years old, I'm going to close it. Feel free to open a new PR that resolves the merge conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo closed pull request #26: Add Unit tests for RequireUpperBoundDeps
elharo closed pull request #26: URL: https://github.com/apache/maven-enforcer/pull/26 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo closed pull request #25: MENFORCER-276 - Support ignoring dependency scopes in RequireUpperBoundDeps
elharo closed pull request #25: URL: https://github.com/apache/maven-enforcer/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo commented on pull request #25: MENFORCER-276 - Support ignoring dependency scopes in RequireUpperBoundDeps
elharo commented on pull request #25: URL: https://github.com/apache/maven-enforcer/pull/25#issuecomment-633539099 Since this is several years old, I'm going to close it. Feel free to open a new PR that resolves the merge conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-tree] elharo closed pull request #2: [MSHARED-816] Add support for pre-managed metadata to Maven31Dependen…
elharo closed pull request #2: URL: https://github.com/apache/maven-dependency-tree/pull/2 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-tree] elharo commented on pull request #2: [MSHARED-816] Add support for pre-managed metadata to Maven31Dependen…
elharo commented on pull request #2: URL: https://github.com/apache/maven-dependency-tree/pull/2#issuecomment-633537981 Since this is over a year old, I'm going to close it. Feel free to open a new PR that resolved the merge conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo closed pull request #53: [MENFORCER-332] Dependency graph performance fix
elharo closed pull request #53: URL: https://github.com/apache/maven-enforcer/pull/53 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo commented on pull request #53: [MENFORCER-332] Dependency graph performance fix
elharo commented on pull request #53: URL: https://github.com/apache/maven-enforcer/pull/53#issuecomment-633538028 Since this is over a year old, I'm going to close it. Feel free to open a new PR that resolved the merge conflicts. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo commented on a change in pull request #57: [MENFORCER-346] - RequireSnapshotVersion: Fix parent with CI Friendly Version
elharo commented on a change in pull request #57: URL: https://github.com/apache/maven-enforcer/pull/57#discussion_r429895968 ## File path: maven-enforcer-plugin/src/it/projects/require-snapshot-version_failure_parent-ci-friendly/pom.xml ## @@ -0,0 +1,63 @@ + + + + + Review comment: two space indents for XML files per project style This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo closed pull request #51: MENFORCER . Updated "Extra Enforcer Rules" dependency
elharo closed pull request #51: URL: https://github.com/apache/maven-enforcer/pull/51 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo closed pull request #62: [SECURITY] Use HTTPS to resolve dependencies in Maven Build
elharo closed pull request #62: URL: https://github.com/apache/maven-enforcer/pull/62 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo commented on a change in pull request #49: MENFORCER-245 Improve documentation about writing own Enforcer Rule
elharo commented on a change in pull request #49:
URL: https://github.com/apache/maven-enforcer/pull/49#discussion_r429891969
##
File path: enforcer-api/src/site/apt/writing-a-custom-rule.apt.vm
##
@@ -33,71 +33,50 @@ Writing a custom rule
[[1]] First make a new jar project starting with the sample pom below:
+---+
-
-http://maven.apache.org/POM/4.0.0;
- xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
- xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
- 4.0.0
-
- custom-rule
- custom-rule-sample
- jar
- 1.0
-
- My Custom Rule
- This is my custom rule.
-
-
-${project.version}
-2.0.9
-
-
-
-
- org.apache.maven.enforcer
- enforcer-api
- ${api.version}
-
-
- org.apache.maven
- maven-project
- ${maven.version}
-
-
- org.apache.maven
- maven-core
- ${maven.version}
-
-
- org.apache.maven
- maven-artifact
- ${maven.version}
-
-
- org.apache.maven
- maven-plugin-api
- ${maven.version}
-
-
- org.codehaus.plexus
- plexus-container-default
- 1.0-alpha-9
-
-
- junit
- junit
- 3.8.2
- test
-
-
-
-
-
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
+custom-rule
+custom-rule-sample
+jar
+1.0
+My Custom Rule
+This is my custom rule.
+
+${project.version}
+3.0
+
+
+
+org.apache.maven.enforcer
+enforcer-api
+${api.version}
+
+
+org.apache.maven
+maven-core
+${maven.version}
+
+
+org.apache.maven
+maven-plugin-api
+${maven.version}
+
+
+junit
+junit
+3.8.1
+test
+
+
+
+
+---+
[[2]] Create your rule class. The rule must implement the
{{{./apidocs/index.html}EnforcerRule}} interface.
The rule can get access to components and the log via the
{{{./apidocs/index.html}EnforcerRuleHelper}} interface.
+ In addition, the rule must provide a setter method for each parameter
allowed to be configured in the pom.xml file (like the shown in point 5).
Review comment:
the shown?
##
File path: enforcer-api/src/custom-rule-sample/pom.xml
##
@@ -1,73 +1,58 @@
-
-
-http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
- 4.0.0
- custom-rule
- custom-rule-sample
- jar
- 1.0
- My Custom Rule
- This is my custom rule.
-
- 1.0-beta-1
- 2.0.9
-
-
-
-
-
- org.apache.maven.enforcer
- enforcer-api
- ${api.version}
-
-
- org.apache.maven
- maven-project
- ${maven.version}
-
-
- org.apache.maven
- maven-core
- ${maven.version}
-
-
- org.apache.maven
- maven-artifact
- ${maven.version}
-
-
- org.apache.maven
- maven-plugin-api
- ${maven.version}
-
-
- org.codehaus.plexus
- plexus-container-default
- 1.0-alpha-9
-
-
- junit
- junit
- 3.8.1
- test
-
-
-
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+4.0.0
Review comment:
convention for XML files in Maven is two space indents
##
File path:
enforcer-api/src/custom-rule-sample/src/main/java/org/apache/maven/enforcer/rule/MyCustomRule.java
##
@@ -1,120 +1,131 @@
-package org.apache.maven.enforcer.rule;
-
-/*
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except
[GitHub] [maven-enforcer] elharo closed pull request #52: [MENFORCER-331] - Maven-enforcer-rules to use maven-resolver-util.
elharo closed pull request #52: URL: https://github.com/apache/maven-enforcer/pull/52 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] elharo merged pull request #63: Corrects the recommended plugin version in the README (update from 3.0.0-M2 to 3.0.0-M3)
elharo merged pull request #63: URL: https://github.com/apache/maven-enforcer/pull/63 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] rfscholte commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution
rfscholte commented on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-633517786 I am the one responsible for adding of 'ALL-MODULE-PATH' to the JPMS specs, but discovered I don't need it anymore. It is a simple but brute way to everything see everything. maven-compiler-plugin nor maven-javadoc-plugin is using it anymore, all is handled via building up the right request for LocationManager in Plexus Java This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #293: [SUREFIRE-1733] Surefire and Failsafe JPMS additions for JUnit 5.x execution
Tibor17 commented on pull request #293: URL: https://github.com/apache/maven-surefire/pull/293#issuecomment-633510292 @cowwoc I wrote the JPMS test with JUnit4 as well. The only I had to add was `--add-modules ALL-MODULE-PATH`. I will add those ITs, no problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MRELEASE-1047) Creating a release version already released corrupts the source pom files if the tag name is already in SCM.
Peter Grape created MRELEASE-1047: - Summary: Creating a release version already released corrupts the source pom files if the tag name is already in SCM. Key: MRELEASE-1047 URL: https://issues.apache.org/jira/browse/MRELEASE-1047 Project: Maven Release Plugin Issue Type: Bug Components: perform Affects Versions: 3.0.0-M1, 2.5.3 Reporter: Peter Grape *Problem:* If you create a release with the same version that has already been released, causes the release process to be halted due to a SCM Tag name conflict in Git and most likely other SCMs as well and the POM files will enter a invalid state since the released versions are checked in. *Suggested solution:* A verification step needs to be added to make sure the generated tag name is not already set. and stop the process there. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-wagon] michael-o commented on pull request #67: Feature/MNG-5583 per endpoint support for PKI authentication
michael-o commented on pull request #67: URL: https://github.com/apache/maven-wagon/pull/67#issuecomment-633482529 Since this is a massive change, I have to complete the current Wagon release first and then will pick this up in June. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MCOMPILER-416) make build faster: when "Nothing to compile" then skip the follow-up plugin
[
https://issues.apache.org/jira/browse/MCOMPILER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115872#comment-17115872
]
Robert Scholte commented on MCOMPILER-416:
--
which plugins are bound to the {{process-classes}} phase?
> make build faster: when "Nothing to compile" then skip the follow-up plugin
> ---
>
> Key: MCOMPILER-416
> URL: https://issues.apache.org/jira/browse/MCOMPILER-416
> Project: Maven Compiler Plugin
> Issue Type: Improvement
>Reporter: qxo
>Assignee: Robert Scholte
>Priority: Minor
>
> PR: [https://github.com/apache/maven-compiler-plugin/pull/33]
> make the build faster
> ie:
> {code:xml}
>
> org.apache.maven.plugins
> maven-compiler-plugin
>
>
> default-compile
> compile
>
> compile
>
>
> nothingToCompileOn
>
>
>
>
>
> org.apache.maven.plugins
> maven-antrun-plugin
> 3.0.0
>
>
> test1
> process-classes
>
>
>
>
>
>
> ${nothingToCompileOn}
>
>
> run
>
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-6921) Maven compile with properties ${artifactId} and ${project.build.finalName} occurs java.lang.NullPointerException
[
https://issues.apache.org/jira/browse/MNG-6921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
anruence updated MNG-6921:
--
Summary: Maven compile with properties ${artifactId} and
${project.build.finalName} occurs java.lang.NullPointerException (was: Maven
compile with ${artifactId} and ${project.build.finalName} occurs
java.lang.NullPointerException)
> Maven compile with properties ${artifactId} and ${project.build.finalName}
> occurs java.lang.NullPointerException
>
>
> Key: MNG-6921
> URL: https://issues.apache.org/jira/browse/MNG-6921
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 3.6.2, 3.6.3
> Environment: MacOS 10.15.2
>Reporter: anruence
>Priority: Major
> Labels: NPE
> Attachments: maven-demo.zip
>
>
> with maven 3.3.9，this project with command "mvn compile" can process
> normally，but NPE when change to 3.6.3
> after debug :
> ${artifactId} and ${project.build.finalName} define at same time will cause
> InterpolationCycleException
> PS: ${project.build.finalName} will be parse to
> ${project.artifactId}-${project.version} with default config.
> this problem can replay with attach project
> {code:java}
> Caused by: java.lang.NullPointerException
> at java.util.concurrent.ConcurrentHashMap$MapEntry.setValue
> (ConcurrentHashMap.java:3539)
> at
> org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit
> (StringVisitorModelInterpolator.java:1429)
> at
> org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit
> (StringVisitorModelInterpolator.java:1027)
> at
> org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit
> (StringVisitorModelInterpolator.java:170)
> at
> org.apache.maven.model.interpolation.StringVisitorModelInterpolator.interpolateModel
> (StringVisitorModelInterpolator.java:107)
> at org.apache.maven.model.building.DefaultModelBuilder.interpolateModel
> (DefaultModelBuilder.java:789)
> at org.apache.maven.model.building.DefaultModelBuilder.build
> (DefaultModelBuilder.java:393)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:448)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:414)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:558)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:414)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:377)
> at org.apache.maven.graph.DefaultGraphBuilder.collectProjects
> (DefaultGraphBuilder.java:414)
> at org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor
> (DefaultGraphBuilder.java:405)
> at org.apache.maven.graph.DefaultGraphBuilder.build
> (DefaultGraphBuilder.java:82)
> at org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:507)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:219)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:567)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347){code}
>
> pom.xml
> {code:java}
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
>
> com.example
> maven-demo
> 0.0.1-SNAPSHOT
>
> 0.0.1-SNAPSHOT
> maven-demo-api
> Demo project for Maven
> jar
>
> com.example
> maven-demo-api
> maven-demo-api
> ${project.build.finalName}
>
> ${artifactId}
>
>
>
>
[jira] [Updated] (MNG-6921) Maven compile with ${artifactId} and ${project.build.finalName} occurs java.lang.NullPointerException
[
https://issues.apache.org/jira/browse/MNG-6921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
anruence updated MNG-6921:
--
Summary: Maven compile with ${artifactId} and ${project.build.finalName}
occurs java.lang.NullPointerException (was: Maven compile with properties
occurs java.lang.NullPointerException)
> Maven compile with ${artifactId} and ${project.build.finalName} occurs
> java.lang.NullPointerException
> -
>
> Key: MNG-6921
> URL: https://issues.apache.org/jira/browse/MNG-6921
> Project: Maven
> Issue Type: Bug
> Components: Command Line
>Affects Versions: 3.6.2, 3.6.3
> Environment: MacOS 10.15.2
>Reporter: anruence
>Priority: Major
> Labels: NPE
> Attachments: maven-demo.zip
>
>
> with maven 3.3.9，this project with command "mvn compile" can process
> normally，but NPE when change to 3.6.3
> after debug :
> ${artifactId} and ${project.build.finalName} define at same time will cause
> InterpolationCycleException
> PS: ${project.build.finalName} will be parse to
> ${project.artifactId}-${project.version} with default config.
> this problem can replay with attach project
> {code:java}
> Caused by: java.lang.NullPointerException
> at java.util.concurrent.ConcurrentHashMap$MapEntry.setValue
> (ConcurrentHashMap.java:3539)
> at
> org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit
> (StringVisitorModelInterpolator.java:1429)
> at
> org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit
> (StringVisitorModelInterpolator.java:1027)
> at
> org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit
> (StringVisitorModelInterpolator.java:170)
> at
> org.apache.maven.model.interpolation.StringVisitorModelInterpolator.interpolateModel
> (StringVisitorModelInterpolator.java:107)
> at org.apache.maven.model.building.DefaultModelBuilder.interpolateModel
> (DefaultModelBuilder.java:789)
> at org.apache.maven.model.building.DefaultModelBuilder.build
> (DefaultModelBuilder.java:393)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:448)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:414)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:558)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:414)
> at org.apache.maven.project.DefaultProjectBuilder.build
> (DefaultProjectBuilder.java:377)
> at org.apache.maven.graph.DefaultGraphBuilder.collectProjects
> (DefaultGraphBuilder.java:414)
> at org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor
> (DefaultGraphBuilder.java:405)
> at org.apache.maven.graph.DefaultGraphBuilder.build
> (DefaultGraphBuilder.java:82)
> at org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:507)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:219)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:567)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347){code}
>
> pom.xml
> {code:java}
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> https://maven.apache.org/xsd/maven-4.0.0.xsd;>
> 4.0.0
>
> com.example
> maven-demo
> 0.0.1-SNAPSHOT
>
> 0.0.1-SNAPSHOT
> maven-demo-api
> Demo project for Maven
> jar
>
> com.example
> maven-demo-api
> maven-demo-api
> ${project.build.finalName}
>
> ${artifactId}
>
>
>
> org.springframework.boot
>
[jira] [Updated] (MNG-6921) Maven compile with properties occurs java.lang.NullPointerException
[
https://issues.apache.org/jira/browse/MNG-6921?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
anruence updated MNG-6921:
--
Description:
with maven 3.3.9，this project with command "mvn compile" can process
normally，but NPE when change to 3.6.3
after debug :
${artifactId} and ${project.build.finalName} define at same time will cause
InterpolationCycleException
PS: ${project.build.finalName} will be parse to
${project.artifactId}-${project.version} with default config.
this problem can replay with attach project
{code:java}
Caused by: java.lang.NullPointerException
at java.util.concurrent.ConcurrentHashMap$MapEntry.setValue
(ConcurrentHashMap.java:3539)
at
org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit
(StringVisitorModelInterpolator.java:1429)
at
org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit
(StringVisitorModelInterpolator.java:1027)
at
org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit
(StringVisitorModelInterpolator.java:170)
at
org.apache.maven.model.interpolation.StringVisitorModelInterpolator.interpolateModel
(StringVisitorModelInterpolator.java:107)
at org.apache.maven.model.building.DefaultModelBuilder.interpolateModel
(DefaultModelBuilder.java:789)
at org.apache.maven.model.building.DefaultModelBuilder.build
(DefaultModelBuilder.java:393)
at org.apache.maven.project.DefaultProjectBuilder.build
(DefaultProjectBuilder.java:448)
at org.apache.maven.project.DefaultProjectBuilder.build
(DefaultProjectBuilder.java:414)
at org.apache.maven.project.DefaultProjectBuilder.build
(DefaultProjectBuilder.java:558)
at org.apache.maven.project.DefaultProjectBuilder.build
(DefaultProjectBuilder.java:414)
at org.apache.maven.project.DefaultProjectBuilder.build
(DefaultProjectBuilder.java:377)
at org.apache.maven.graph.DefaultGraphBuilder.collectProjects
(DefaultGraphBuilder.java:414)
at org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor
(DefaultGraphBuilder.java:405)
at org.apache.maven.graph.DefaultGraphBuilder.build
(DefaultGraphBuilder.java:82)
at org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:507)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:219)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:567)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:347){code}
pom.xml
{code:java}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
com.example
maven-demo
0.0.1-SNAPSHOT
0.0.1-SNAPSHOT
maven-demo-api
Demo project for Maven
jar
com.example
maven-demo-api
maven-demo-api
${project.build.finalName}
${artifactId}
org.springframework.boot
spring-boot-maven-plugin
org.apache.maven.plugins
maven-jar-plugin
2.3.2
${finalName}
{code}
org.apache.maven.model.interpolation.StringVisitorModelInterpolator#visit
{code:java}
private void visit( Properties properties )
{
if ( properties != null )
{
for ( Map.Entry entry : properties.entrySet() )
{
Object v = entry.getValue();
if ( v instanceof String )
{
String value = (String) v;
String inter = interpolate( value ); // inter can be return null
if ( value != inter )
{
entry.setValue( inter );
}
}
}
}
}
{code}
was:
with maven 3.3.9，this project with command "mvn compile" can process
normally，but NPE when change to 3.6.3
[GitHub] [maven] rfscholte commented on a change in pull request #342: [MNG-5760] Add --resume / -r switch
rfscholte commented on a change in pull request #342:
URL: https://github.com/apache/maven/pull/342#discussion_r429806085
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionManager.java
##
@@ -0,0 +1,308 @@
+package org.apache.maven.execution;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import com.google.common.annotations.VisibleForTesting;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.lifecycle.LifecycleExecutionException;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.project.MavenProject;
+import org.codehaus.plexus.logging.Logger;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.IOException;
+import java.io.Reader;
+import java.io.Writer;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import static java.util.Comparator.comparing;
+
+/**
+ * This implementation of {@link BuildResumptionManager} persists information
in a properties file. The file is stored
+ * in the build output directory under the Maven execution root.
+ */
+@Named
+@Singleton
+public class DefaultBuildResumptionManager implements BuildResumptionManager
+{
+private static final String RESUME_PROPERTIES_FILENAME =
"resume.properties";
+private static final String RESUME_FROM_PROPERTY = "resumeFrom";
+private static final String EXCLUDED_PROJECTS_PROPERTY =
"excludedProjects";
+private static final String PROPERTY_DELIMITER = ", ";
+
+@Inject
+private Logger logger;
+
+@Override
+public boolean persistResumptionData( MavenExecutionResult result,
MavenProject rootProject )
+{
+Properties properties = determineResumptionProperties( result );
+
+if ( properties.isEmpty() )
+{
+logger.debug( "Will not create " + RESUME_PROPERTIES_FILENAME + "
file: nothing to resume from" );
+return false;
+}
+
+return writeResumptionFile( rootProject, properties );
+}
+
+@Override
+public void applyResumptionData( MavenExecutionRequest request,
MavenProject rootProject )
+{
+Properties properties = loadResumptionFile(
rootProject.getBuild().getDirectory() );
+applyResumptionProperties( request, properties );
+}
+
+@Override
+public void removeResumptionData( MavenProject rootProject )
+{
+Path resumeProperties = Paths.get(
rootProject.getBuild().getDirectory(), RESUME_PROPERTIES_FILENAME );
+try
+{
+Files.deleteIfExists( resumeProperties );
+}
+catch ( IOException e )
+{
+logger.warn( "Could not delete " + RESUME_PROPERTIES_FILENAME + "
file. ", e );
+}
+}
+
+@Override
+public String getResumeFromSelector( List mavenProjects,
MavenProject failedProject )
+{
+boolean hasOverlappingArtifactId = mavenProjects.stream()
+.filter( project -> failedProject.getArtifactId().equals(
project.getArtifactId() ) )
+.count() > 1;
+
+if ( hasOverlappingArtifactId )
+{
+return failedProject.getGroupId() + ":" +
failedProject.getArtifactId();
+}
+
+return ":" + failedProject.getArtifactId();
+}
+
+@VisibleForTesting
+Properties determineResumptionProperties( MavenExecutionResult result )
+{
+Properties properties = new Properties();
+
+List failedProjects = getFailedProjectsInOrder( result );
+if ( !failedProjects.isEmpty() )
+{
+MavenProject resumeFromProject = failedProjects.get( 0 );
+Optional resumeFrom = getResumeFrom( result,
resumeFromProject );
+Optional projectsToSkip = determineProjectsToSkip( result,
failedProjects, resumeFromProject );
+
+resumeFrom.ifPresent( value -> properties.setProperty(
RESUME_FROM_PROPERTY, value ) );
+projectsToSkip.ifPresent( value ->
[GitHub] [maven] rfscholte commented on a change in pull request #342: [MNG-5760] Add --resume / -r switch
rfscholte commented on a change in pull request #342:
URL: https://github.com/apache/maven/pull/342#discussion_r429804991
##
File path: maven-core/src/main/java/org/apache/maven/DefaultMaven.java
##
@@ -366,20 +366,21 @@ private void afterSessionEnd( Collection
projects, MavenSession se
private void saveResumptionDataWhenApplicable( MavenExecutionResult
result, MavenSession session )
{
-List lifecycleExecutionExceptions =
result.getExceptions().stream()
+long lifecycleExecutionExceptionCount = result.getExceptions().stream()
.filter( LifecycleExecutionException.class::isInstance )
-.map( LifecycleExecutionException.class::cast )
-.collect( Collectors.toList() );
+.count();
Review comment:
The next codeblock needs to know if there were
lifecycleExecutionException. That said, the amount doesn't matter, a simple
`boolean` would be sufficient. A count needs to loop over all exceptions,
whereas replacing `filter` with `anyMatch` would be the optimized
implementation.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MNG-6921) Maven compile with properties occurs java.lang.NullPointerException
anruence created MNG-6921:
-
Summary: Maven compile with properties occurs
java.lang.NullPointerException
Key: MNG-6921
URL: https://issues.apache.org/jira/browse/MNG-6921
Project: Maven
Issue Type: Bug
Components: Command Line
Affects Versions: 3.6.3, 3.6.2
Environment: MacOS 10.15.2
Reporter: anruence
Attachments: maven-demo.zip
with maven 3.3.9，this project with command "mvn compile" can process
normally，but NPE when change to 3.6.3
this problem can replay with attach project
{code:java}
Caused by: java.lang.NullPointerException
at java.util.concurrent.ConcurrentHashMap$MapEntry.setValue
(ConcurrentHashMap.java:3539)
at
org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit
(StringVisitorModelInterpolator.java:1429)
at
org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit
(StringVisitorModelInterpolator.java:1027)
at
org.apache.maven.model.interpolation.StringVisitorModelInterpolator$ModelVisitor.visit
(StringVisitorModelInterpolator.java:170)
at
org.apache.maven.model.interpolation.StringVisitorModelInterpolator.interpolateModel
(StringVisitorModelInterpolator.java:107)
at org.apache.maven.model.building.DefaultModelBuilder.interpolateModel
(DefaultModelBuilder.java:789)
at org.apache.maven.model.building.DefaultModelBuilder.build
(DefaultModelBuilder.java:393)
at org.apache.maven.project.DefaultProjectBuilder.build
(DefaultProjectBuilder.java:448)
at org.apache.maven.project.DefaultProjectBuilder.build
(DefaultProjectBuilder.java:414)
at org.apache.maven.project.DefaultProjectBuilder.build
(DefaultProjectBuilder.java:558)
at org.apache.maven.project.DefaultProjectBuilder.build
(DefaultProjectBuilder.java:414)
at org.apache.maven.project.DefaultProjectBuilder.build
(DefaultProjectBuilder.java:377)
at org.apache.maven.graph.DefaultGraphBuilder.collectProjects
(DefaultGraphBuilder.java:414)
at org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor
(DefaultGraphBuilder.java:405)
at org.apache.maven.graph.DefaultGraphBuilder.build
(DefaultGraphBuilder.java:82)
at org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:507)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:219)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:957)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:289)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:193)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:62)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:567)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:282)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:225)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:406)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:347){code}
pom.xml
{code:java}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
https://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
com.example
maven-demo
0.0.1-SNAPSHOT
0.0.1-SNAPSHOT
maven-demo-api
Demo project for Maven
jar
com.example
maven-demo-api
maven-demo-api
${project.build.finalName}
${artifactId}
org.springframework.boot
spring-boot-maven-plugin
org.apache.maven.plugins
maven-jar-plugin
2.3.2
${finalName}
{code}
org.apache.maven.model.interpolation.StringVisitorModelInterpolator#visit
{code:java}
private void visit( Properties properties )
{
if ( properties != null )
{
for ( Map.Entry entry : properties.entrySet() )
{
Object v = entry.getValue();
if ( v instanceof String )
{
String value = (String) v;
String inter = interpolate( value ); // inter can be return null
if ( value != inter )
{
entry.setValue( inter );
}
}
}
}
}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MNG-6919) maven-wrapper on windows
[ https://issues.apache.org/jira/browse/MNG-6919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17115756#comment-17115756 ] Robert Scholte commented on MNG-6919: - Let me see if I can run the ITs on a path containing spaces first > maven-wrapper on windows > > > Key: MNG-6919 > URL: https://issues.apache.org/jira/browse/MNG-6919 > Project: Maven > Issue Type: Bug > Components: Bootstrap Build >Affects Versions: 3.7.0-candidate >Reporter: James Z.M. Gao >Priority: Minor > > new maven-wrapper inherit 2 bugs for windows batch scripts: > # cannot read the config ".mvn\wrapper\maven-wrapper.properties" correctly > when the full path has space. > # -eof style of cmd scripts are not CRLF- (This is fixed by assembly-plugin > `lineEnding` settings) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-wagon] mthmulders commented on a change in pull request #67: Feature/MNG-5583 per endpoint support for PKI authentication
mthmulders commented on a change in pull request #67: URL: https://github.com/apache/maven-wagon/pull/67#discussion_r429754973 ## File path: wagon-tcks/wagon-tck-http/src/main/java/org/apache/maven/wagon/tck/http/GetWagonTests.java ## @@ -545,4 +549,9 @@ protected void testErrorHandling( final int code ) // expected } } + +protected AuthenticationInfo getAuthIfNeeded( AuthenticationInfo info ) throws Exception Review comment: What is the purpose of this method? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] mthmulders commented on a change in pull request #67: Feature/MNG-5583 per endpoint support for PKI authentication
mthmulders commented on a change in pull request #67: URL: https://github.com/apache/maven-wagon/pull/67#discussion_r429754252 ## File path: wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/JSSEKeyManager.java ## @@ -0,0 +1,139 @@ +package org.apache.maven.wagon.shared.http; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +import java.net.Socket; +import java.security.Principal; +import java.security.PrivateKey; +import java.security.cert.X509Certificate; + +import javax.net.ssl.SSLEngine; +import javax.net.ssl.X509ExtendedKeyManager; +import javax.net.ssl.X509KeyManager; + +/** + * This was borrowed from Apache Tomcat Review comment: Does Tomcat also have a unit test for this class? If so, I think we might want to borrow that as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] mthmulders commented on a change in pull request #67: Feature/MNG-5583 per endpoint support for PKI authentication
mthmulders commented on a change in pull request #67: URL: https://github.com/apache/maven-wagon/pull/67#discussion_r429754516 ## File path: wagon-providers/wagon-http-lightweight/src/test/java/org/apache/maven/wagon/providers/http/TckTest.java ## @@ -20,6 +20,7 @@ */ import org.apache.maven.wagon.tck.http.GetWagonTests; +import org.apache.maven.wagon.tck.http.HttpsClientCertGetWagonTests; Review comment: I don't see why this is necessary. Could you please explain? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters edited a comment on pull request #342: [MNG-5760] Add --resume / -r switch
MartinKanters edited a comment on pull request #342: URL: https://github.com/apache/maven/pull/342#issuecomment-633401173 > how about a simple `canResume()` (who knows if there will be other requirements to resume)? Sounds good, Robert. We will change this name, indeed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on pull request #342: [MNG-5760] Add --resume / -r switch
MartinKanters commented on pull request #342: URL: https://github.com/apache/maven/pull/342#issuecomment-633401173 > how about a simple `canResume()` (who knows if there will be other requirements to resume)? Sounds good, Robert. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on a change in pull request #342: [MNG-5760] Add --resume / -r switch
MartinKanters commented on a change in pull request #342:
URL: https://github.com/apache/maven/pull/342#discussion_r429751573
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionManager.java
##
@@ -0,0 +1,308 @@
+package org.apache.maven.execution;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import com.google.common.annotations.VisibleForTesting;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.lifecycle.LifecycleExecutionException;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.project.MavenProject;
+import org.codehaus.plexus.logging.Logger;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.IOException;
+import java.io.Reader;
+import java.io.Writer;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import static java.util.Comparator.comparing;
+
+/**
+ * This implementation of {@link BuildResumptionManager} persists information
in a properties file. The file is stored
+ * in the build output directory under the Maven execution root.
+ */
+@Named
+@Singleton
+public class DefaultBuildResumptionManager implements BuildResumptionManager
+{
+private static final String RESUME_PROPERTIES_FILENAME =
"resume.properties";
+private static final String RESUME_FROM_PROPERTY = "resumeFrom";
+private static final String EXCLUDED_PROJECTS_PROPERTY =
"excludedProjects";
+private static final String PROPERTY_DELIMITER = ", ";
+
+@Inject
+private Logger logger;
+
+@Override
+public boolean persistResumptionData( MavenExecutionResult result,
MavenProject rootProject )
+{
+Properties properties = determineResumptionProperties( result );
+
+if ( properties.isEmpty() )
+{
+logger.debug( "Will not create " + RESUME_PROPERTIES_FILENAME + "
file: nothing to resume from" );
+return false;
+}
+
+return writeResumptionFile( rootProject, properties );
+}
+
+@Override
+public void applyResumptionData( MavenExecutionRequest request,
MavenProject rootProject )
+{
+Properties properties = loadResumptionFile(
rootProject.getBuild().getDirectory() );
+applyResumptionProperties( request, properties );
+}
+
+@Override
+public void removeResumptionData( MavenProject rootProject )
+{
+Path resumeProperties = Paths.get(
rootProject.getBuild().getDirectory(), RESUME_PROPERTIES_FILENAME );
+try
+{
+Files.deleteIfExists( resumeProperties );
+}
+catch ( IOException e )
+{
+logger.warn( "Could not delete " + RESUME_PROPERTIES_FILENAME + "
file. ", e );
+}
+}
+
+@Override
+public String getResumeFromSelector( List mavenProjects,
MavenProject failedProject )
+{
+boolean hasOverlappingArtifactId = mavenProjects.stream()
+.filter( project -> failedProject.getArtifactId().equals(
project.getArtifactId() ) )
+.count() > 1;
+
+if ( hasOverlappingArtifactId )
+{
+return failedProject.getGroupId() + ":" +
failedProject.getArtifactId();
+}
+
+return ":" + failedProject.getArtifactId();
+}
+
+@VisibleForTesting
+Properties determineResumptionProperties( MavenExecutionResult result )
+{
+Properties properties = new Properties();
+
+List failedProjects = getFailedProjectsInOrder( result );
+if ( !failedProjects.isEmpty() )
+{
+MavenProject resumeFromProject = failedProjects.get( 0 );
+Optional resumeFrom = getResumeFrom( result,
resumeFromProject );
+Optional projectsToSkip = determineProjectsToSkip( result,
failedProjects, resumeFromProject );
+
+resumeFrom.ifPresent( value -> properties.setProperty(
RESUME_FROM_PROPERTY, value ) );
+projectsToSkip.ifPresent( value ->
[GitHub] [maven] MartinKanters commented on a change in pull request #342: [MNG-5760] Add --resume / -r switch
MartinKanters commented on a change in pull request #342:
URL: https://github.com/apache/maven/pull/342#discussion_r429751000
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionManager.java
##
@@ -0,0 +1,308 @@
+package org.apache.maven.execution;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import com.google.common.annotations.VisibleForTesting;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.lifecycle.LifecycleExecutionException;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.project.MavenProject;
+import org.codehaus.plexus.logging.Logger;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.IOException;
+import java.io.Reader;
+import java.io.Writer;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import static java.util.Comparator.comparing;
+
+/**
+ * This implementation of {@link BuildResumptionManager} persists information
in a properties file. The file is stored
+ * in the build output directory under the Maven execution root.
+ */
+@Named
+@Singleton
+public class DefaultBuildResumptionManager implements BuildResumptionManager
+{
+private static final String RESUME_PROPERTIES_FILENAME =
"resume.properties";
+private static final String RESUME_FROM_PROPERTY = "resumeFrom";
+private static final String EXCLUDED_PROJECTS_PROPERTY =
"excludedProjects";
+private static final String PROPERTY_DELIMITER = ", ";
+
+@Inject
+private Logger logger;
+
+@Override
+public boolean persistResumptionData( MavenExecutionResult result,
MavenProject rootProject )
+{
+Properties properties = determineResumptionProperties( result );
+
+if ( properties.isEmpty() )
+{
+logger.debug( "Will not create " + RESUME_PROPERTIES_FILENAME + "
file: nothing to resume from" );
+return false;
+}
+
+return writeResumptionFile( rootProject, properties );
+}
+
+@Override
+public void applyResumptionData( MavenExecutionRequest request,
MavenProject rootProject )
+{
+Properties properties = loadResumptionFile(
rootProject.getBuild().getDirectory() );
+applyResumptionProperties( request, properties );
+}
+
+@Override
+public void removeResumptionData( MavenProject rootProject )
+{
+Path resumeProperties = Paths.get(
rootProject.getBuild().getDirectory(), RESUME_PROPERTIES_FILENAME );
+try
+{
+Files.deleteIfExists( resumeProperties );
+}
+catch ( IOException e )
+{
+logger.warn( "Could not delete " + RESUME_PROPERTIES_FILENAME + "
file. ", e );
+}
+}
+
+@Override
+public String getResumeFromSelector( List mavenProjects,
MavenProject failedProject )
+{
+boolean hasOverlappingArtifactId = mavenProjects.stream()
+.filter( project -> failedProject.getArtifactId().equals(
project.getArtifactId() ) )
+.count() > 1;
+
+if ( hasOverlappingArtifactId )
+{
+return failedProject.getGroupId() + ":" +
failedProject.getArtifactId();
+}
+
+return ":" + failedProject.getArtifactId();
+}
+
+@VisibleForTesting
+Properties determineResumptionProperties( MavenExecutionResult result )
+{
+Properties properties = new Properties();
+
+List failedProjects = getFailedProjectsInOrder( result );
+if ( !failedProjects.isEmpty() )
+{
+MavenProject resumeFromProject = failedProjects.get( 0 );
+Optional resumeFrom = getResumeFrom( result,
resumeFromProject );
+Optional projectsToSkip = determineProjectsToSkip( result,
failedProjects, resumeFromProject );
+
+resumeFrom.ifPresent( value -> properties.setProperty(
RESUME_FROM_PROPERTY, value ) );
+projectsToSkip.ifPresent( value ->
[GitHub] [maven] MartinKanters commented on a change in pull request #342: [MNG-5760] Add --resume / -r switch
MartinKanters commented on a change in pull request #342:
URL: https://github.com/apache/maven/pull/342#discussion_r429750167
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionManager.java
##
@@ -0,0 +1,308 @@
+package org.apache.maven.execution;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import com.google.common.annotations.VisibleForTesting;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.lifecycle.LifecycleExecutionException;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.project.MavenProject;
+import org.codehaus.plexus.logging.Logger;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.IOException;
+import java.io.Reader;
+import java.io.Writer;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import static java.util.Comparator.comparing;
+
+/**
+ * This implementation of {@link BuildResumptionManager} persists information
in a properties file. The file is stored
+ * in the build output directory under the Maven execution root.
+ */
+@Named
+@Singleton
+public class DefaultBuildResumptionManager implements BuildResumptionManager
+{
+private static final String RESUME_PROPERTIES_FILENAME =
"resume.properties";
+private static final String RESUME_FROM_PROPERTY = "resumeFrom";
+private static final String EXCLUDED_PROJECTS_PROPERTY =
"excludedProjects";
+private static final String PROPERTY_DELIMITER = ", ";
+
+@Inject
+private Logger logger;
+
+@Override
+public boolean persistResumptionData( MavenExecutionResult result,
MavenProject rootProject )
+{
+Properties properties = determineResumptionProperties( result );
+
+if ( properties.isEmpty() )
+{
+logger.debug( "Will not create " + RESUME_PROPERTIES_FILENAME + "
file: nothing to resume from" );
+return false;
+}
+
+return writeResumptionFile( rootProject, properties );
+}
+
+@Override
+public void applyResumptionData( MavenExecutionRequest request,
MavenProject rootProject )
+{
+Properties properties = loadResumptionFile(
rootProject.getBuild().getDirectory() );
+applyResumptionProperties( request, properties );
+}
+
+@Override
+public void removeResumptionData( MavenProject rootProject )
+{
+Path resumeProperties = Paths.get(
rootProject.getBuild().getDirectory(), RESUME_PROPERTIES_FILENAME );
+try
+{
+Files.deleteIfExists( resumeProperties );
+}
+catch ( IOException e )
+{
+logger.warn( "Could not delete " + RESUME_PROPERTIES_FILENAME + "
file. ", e );
+}
+}
+
+@Override
+public String getResumeFromSelector( List mavenProjects,
MavenProject failedProject )
+{
+boolean hasOverlappingArtifactId = mavenProjects.stream()
+.filter( project -> failedProject.getArtifactId().equals(
project.getArtifactId() ) )
+.count() > 1;
+
+if ( hasOverlappingArtifactId )
+{
+return failedProject.getGroupId() + ":" +
failedProject.getArtifactId();
+}
+
+return ":" + failedProject.getArtifactId();
+}
+
+@VisibleForTesting
+Properties determineResumptionProperties( MavenExecutionResult result )
+{
+Properties properties = new Properties();
+
+List failedProjects = getFailedProjectsInOrder( result );
+if ( !failedProjects.isEmpty() )
+{
+MavenProject resumeFromProject = failedProjects.get( 0 );
+Optional resumeFrom = getResumeFrom( result,
resumeFromProject );
+Optional projectsToSkip = determineProjectsToSkip( result,
failedProjects, resumeFromProject );
+
+resumeFrom.ifPresent( value -> properties.setProperty(
RESUME_FROM_PROPERTY, value ) );
+projectsToSkip.ifPresent( value ->
[GitHub] [maven] MartinKanters commented on a change in pull request #342: [MNG-5760] Add --resume / -r switch
MartinKanters commented on a change in pull request #342:
URL: https://github.com/apache/maven/pull/342#discussion_r429748977
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionManager.java
##
@@ -0,0 +1,308 @@
+package org.apache.maven.execution;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import com.google.common.annotations.VisibleForTesting;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.lifecycle.LifecycleExecutionException;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.project.MavenProject;
+import org.codehaus.plexus.logging.Logger;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.IOException;
+import java.io.Reader;
+import java.io.Writer;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import static java.util.Comparator.comparing;
+
+/**
+ * This implementation of {@link BuildResumptionManager} persists information
in a properties file. The file is stored
+ * in the build output directory under the Maven execution root.
+ */
+@Named
+@Singleton
+public class DefaultBuildResumptionManager implements BuildResumptionManager
+{
+private static final String RESUME_PROPERTIES_FILENAME =
"resume.properties";
+private static final String RESUME_FROM_PROPERTY = "resumeFrom";
+private static final String EXCLUDED_PROJECTS_PROPERTY =
"excludedProjects";
+private static final String PROPERTY_DELIMITER = ", ";
+
+@Inject
+private Logger logger;
Review comment:
Sounds like a good refactor indeed!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on a change in pull request #342: [MNG-5760] Add --resume / -r switch
MartinKanters commented on a change in pull request #342:
URL: https://github.com/apache/maven/pull/342#discussion_r429748772
##
File path: maven-core/src/main/java/org/apache/maven/DefaultMaven.java
##
@@ -366,20 +366,21 @@ private void afterSessionEnd( Collection
projects, MavenSession se
private void saveResumptionDataWhenApplicable( MavenExecutionResult
result, MavenSession session )
{
-List lifecycleExecutionExceptions =
result.getExceptions().stream()
+long lifecycleExecutionExceptionCount = result.getExceptions().stream()
.filter( LifecycleExecutionException.class::isInstance )
-.map( LifecycleExecutionException.class::cast )
-.collect( Collectors.toList() );
+.count();
Review comment:
We think this is the most readable way of counting those specific
exceptions. Rewriting it in a for-loop could potentially save some resources
(if javac does not already optimize the stream for us). We usually go for
easy-to-read code first, and optimize when needed.
That said, I am not sure if the Maven codebase has a different strategy?
Maybe @rfscholte or someone else can chip in?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] mthmulders commented on a change in pull request #342: [MNG-5760] Add --resume / -r switch
mthmulders commented on a change in pull request #342:
URL: https://github.com/apache/maven/pull/342#discussion_r429747671
##
File path:
maven-core/src/main/java/org/apache/maven/execution/DefaultBuildResumptionManager.java
##
@@ -0,0 +1,308 @@
+package org.apache.maven.execution;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import com.google.common.annotations.VisibleForTesting;
+import org.apache.commons.lang3.StringUtils;
+import org.apache.maven.lifecycle.LifecycleExecutionException;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.project.MavenProject;
+import org.codehaus.plexus.logging.Logger;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+import javax.inject.Singleton;
+import java.io.IOException;
+import java.io.Reader;
+import java.io.Writer;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Arrays;
+import java.util.List;
+import java.util.Objects;
+import java.util.Optional;
+import java.util.Properties;
+import java.util.stream.Collectors;
+
+import static java.util.Comparator.comparing;
+
+/**
+ * This implementation of {@link BuildResumptionManager} persists information
in a properties file. The file is stored
+ * in the build output directory under the Maven execution root.
+ */
+@Named
+@Singleton
+public class DefaultBuildResumptionManager implements BuildResumptionManager
+{
+private static final String RESUME_PROPERTIES_FILENAME =
"resume.properties";
+private static final String RESUME_FROM_PROPERTY = "resumeFrom";
+private static final String EXCLUDED_PROJECTS_PROPERTY =
"excludedProjects";
+private static final String PROPERTY_DELIMITER = ", ";
+
+@Inject
+private Logger logger;
Review comment:
I think we use String concat a few times for building a log message. We
should also use SLF4J's parameter feature (`"{} happened"`)
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
