[GitHub] [maven] PoojaChandak opened a new pull request #369: Document update

[GitBox]

PoojaChandak opened a new pull request #369:
URL: https://github.com/apache/maven/pull/369


   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [ ] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MNG) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line 
and body.
- [ ] Format the pull request title like `[MNG-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MNG-XXX` with the appropriate JIRA issue. Best 
practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [ ] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   [core-its]: https://maven.apache.org/core-its/core-it-suite/
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MDEP-708) dependency:analyze should recommend narrower scope where possible

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172735#comment-17172735
 ] 

Hudson commented on MDEP-708:
-

Build succeeded in Jenkins: Maven TLP » maven-dependency-plugin » MDEP-644 #2

See 
https://builds.apache.org/job/maven-box/job/maven-dependency-plugin/job/MDEP-644/2/

> dependency:analyze should recommend narrower scope where possible
> -
>
> Key: MDEP-708
> URL: https://issues.apache.org/jira/browse/MDEP-708
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
>  Labels: intern
> Fix For: 3.1.3
>
>
> E.g. if a dependency is indeed used but has compile scope and is only needed 
> in tests, mvn dependency:analyze should suggest reducing its scope.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MDEP-645) List classes in a given artifact

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172734#comment-17172734
 ] 

Hudson commented on MDEP-645:
-

Build succeeded in Jenkins: Maven TLP » maven-dependency-plugin » MDEP-644 #2

See 
https://builds.apache.org/job/maven-box/job/maven-dependency-plugin/job/MDEP-644/2/

> List classes in a given artifact
> 
>
> Key: MDEP-645
> URL: https://issues.apache.org/jira/browse/MDEP-645
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>Affects Versions: 3.1.3
>Reporter: John Lin
>Assignee: Elliotte Rusty Harold
>Priority: Minor
>  Labels: intern
> Fix For: 3.1.3
>
>
> When I want to list all the classes in a given artifact, I have to use 
> {{jar}} command to show files in the corresponding .jar file.
> For example, I want to list all the classes in the artifact
> {code}
> org.apache.commons:commons-lang3:3.6
> {code}
> I have to run
> {code}
> jar tf 
> ~/.m2/repository/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.jar
> {code}
> This method has some disadvantages:
> # The jar file may not be downloaded, so it may not be in 
> {{~/.m2/repository}}.
> # It's kind of tedious to type such a long filename.
> # The output is shown in raw filenames, e.g., 
> {{org/apache/commons/lang3/SystemUtils.class}}, but I generally want a 
> package + class name {{org.apache.commons.lang3.SystemUtils}}.
> So I would expect a goal called {{show}} with an argument {{artifact}}, so I 
> can type
> {code}
> mvn dependency:show -Dartifact=org.apache.commons:commons-lang3:3.6
> {code}
> to show
> {code}
> org.apache.commons.lang3.CharUtils
> org.apache.commons.lang3.RandomStringUtils
> ...
> {code}
> What do you guys think? Thanks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MRESOLVER-129) Exclusion has no setters

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172730#comment-17172730
 ] 

Hudson commented on MRESOLVER-129:
--

Build succeeded in Jenkins: Maven TLP » maven-resolver » master #100

See https://builds.apache.org/job/maven-box/job/maven-resolver/job/master/100/

> Exclusion has no setters
> 
>
> Key: MRESOLVER-129
> URL: https://issues.apache.org/jira/browse/MRESOLVER-129
> Project: Maven Resolver
>  Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 1.5.1
>
>
> delete "Note: Instances of this class are immutable and the exposed mutators 
> return new objects rather than changing the current instance." since there 
> are no mutators on Exclusion



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-dependency-plugin] elharo commented on a change in pull request #92: [MDEP-644] Reintroduce the verbose option for dependency:tree

[GitBox]

elharo commented on a change in pull request #92:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/92#discussion_r466705394



##
File path: 
src/main/java/org/apache/maven/plugins/dependency/tree/verbose/RepositoryUtility.java
##
@@ -0,0 +1,207 @@
+package org.apache.maven.plugins.dependency.tree.verbose;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.repository.internal.MavenRepositorySystemUtils;
+import org.eclipse.aether.DefaultRepositorySystemSession;
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.artifact.DefaultArtifact;
+import org.eclipse.aether.collection.DependencySelector;
+import org.eclipse.aether.repository.LocalRepository;
+import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.resolution.VersionRangeRequest;
+import org.eclipse.aether.resolution.VersionRangeResolutionException;
+import org.eclipse.aether.resolution.VersionRangeResult;
+import org.eclipse.aether.util.graph.selector.AndDependencySelector;
+import org.eclipse.aether.util.graph.selector.ExclusionDependencySelector;
+import org.eclipse.aether.util.graph.selector.ScopeDependencySelector;
+import 
org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer;
+import org.eclipse.aether.util.graph.transformer.JavaDependencyContextRefiner;
+import org.eclipse.aether.version.Version;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Arrays;
+
+/**
+ * Aether initialization. This uses Maven Resolver 1.4.2 or later. There are 
many other versions of Aether

Review comment:
   This comment seems no longer correct. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-dependency-plugin] ian-lavallee commented on a change in pull request #92: [MDEP-644] Reintroduce the verbose option for dependency:tree

[GitBox]

ian-lavallee commented on a change in pull request #92:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/92#discussion_r466696381



##
File path: 
src/main/java/org/apache/maven/plugins/dependency/tree/verbose/RepositoryUtility.java
##
@@ -0,0 +1,216 @@
+package org.apache.maven.plugins.dependency.tree.verbose;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+
+import org.apache.maven.repository.internal.MavenRepositorySystemUtils;
+import org.eclipse.aether.DefaultRepositorySystemSession;
+import org.eclipse.aether.RepositorySystem;
+import org.eclipse.aether.RepositorySystemSession;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.artifact.DefaultArtifact;
+import org.eclipse.aether.collection.DependencySelector;
+import org.eclipse.aether.repository.LocalRepository;
+import org.eclipse.aether.repository.RemoteRepository;
+import org.eclipse.aether.resolution.VersionRangeRequest;
+import org.eclipse.aether.resolution.VersionRangeResolutionException;
+import org.eclipse.aether.resolution.VersionRangeResult;
+import org.eclipse.aether.util.graph.selector.AndDependencySelector;
+import org.eclipse.aether.util.graph.selector.ExclusionDependencySelector;
+import org.eclipse.aether.util.graph.selector.ScopeDependencySelector;
+import 
org.eclipse.aether.util.graph.transformer.ChainedDependencyGraphTransformer;
+import org.eclipse.aether.util.graph.transformer.JavaDependencyContextRefiner;
+import org.eclipse.aether.version.Version;
+
+import java.io.File;
+import java.io.IOException;
+import java.net.URI;
+import java.net.URISyntaxException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.Set;
+
+
+/**
+ * Aether initialization. This uses Maven Resolver 1.4.2 or later. There are 
many other versions of Aether
+ * from Sonatype and the Eclipse Project, but this is the current one.
+ */
+public final class RepositoryUtility
+{
+
+public static final RemoteRepository CENTRAL = new 
RemoteRepository.Builder( "central", "default",

Review comment:
   I agree with this. I spent some time using the injected session and 
repositorySystemSession but couldn't get the output to be correct. I think we 
can merge this in still because it will still work for most users and I will 
work on this issue and the other missing features.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-dependency-plugin] ian-lavallee commented on a change in pull request #92: [MDEP-644] Reintroduce the verbose option for dependency:tree

[GitBox]

ian-lavallee commented on a change in pull request #92:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/92#discussion_r466690592



##
File path: 
src/main/java/org/apache/maven/plugins/dependency/tree/verbose/OsProperties.java
##
@@ -0,0 +1,91 @@
+package org.apache.maven.plugins.dependency.tree.verbose;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+
+
+import java.util.HashMap;
+import java.util.Locale;
+import java.util.Map;
+
+/**
+ * Platform-dependent project properties normalized from ${os.name} and 
${os.arch}. Netty uses these to select
+ * system-specific dependencies through the
+ * os-maven-plugin.
+ */
+public class OsProperties

Review comment:
   Yeah it's used in a static initialization block in 
VerboseDependencyGraphBuilder, I'll change it to package-private





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] michael-o commented on pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

michael-o commented on pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#issuecomment-670169900


   @chrisbeckey What is your stance on my previous comment?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-resolver] michael-o commented on pull request #22: Introduce caching for tracking files.

[GitBox]

michael-o commented on pull request #22:
URL: https://github.com/apache/maven-resolver/pull/22#issuecomment-670163738


   Please read: 
https://issues.apache.org/jira/browse/MRESOLVER-68?focusedCommentId=17172644=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17172644



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Comment Edited] (MRESOLVER-68) Add caching around File.getCanonicalPath

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172644#comment-17172644
 ] 

Michael Osipov edited comment on MRESOLVER-68 at 8/6/20, 8:00 PM:
--

I think that this ticket is not required not is the canonicalization necessary. 
The {{TrackingFileManager}} is package private, thus never used externally. It 
used the interned string reperesentation of the canonical path and file 
locking. We all know that file locking in a single JVM are pointless, it will 
lead to race conditions. This is why the locking is multistage. Single JVM and 
file locks for multi JVM. The interesting part is that if you look up the call 
stack of  {{TrackingFileManager#read(File)}} and 
{{TrackingFileManager#update(File, Map)}} you'll see that all 
of them are wrapped in a {{SyncContext}} which already add locks for them. I 
don't understand why this is done here. If outer look works, I see no need to 
lock again somewhere deeper. I am also keen to say that this kind of 
synchronization can be completely removed if you have a decent 
{{SyncContextFactory}} implementation.
 I am inclined to override the {{TrackingFileManager}} with MRESOLVER-130 for 
obvious reasons.
[~elharo], please add your thoughts on my analysis.


was (Author: michael-o):
I think that this ticket is not required not is the canonicalization necessary. 
The {{TrackingFileManager}} is package private, thus never used externally. It 
used the interned string reperesentation of the canonical path and file 
locking. We all know that file locking in a single JVM are pointless, it will 
lead to race conditions. This is why the locking is multistage. Single JVM and 
file locks for multi JVM. The interesting part is that if you look up the call 
stack of  {{TrackingFileManager#read(File)}} and 
{{}}{{TrackingFileManager#u}}{{pdate(File, Map)}} you'll see 
that all of them are wrapped in a {{SyncContext}} which already add locks for 
them. I don't understand why this is done here. If outer look works, I see no 
need to lock again somewhere deeper. I am also keen to say that this kind of 
synchronization can be completely removed if you have a decent 
{{SyncContextFactory}} implementation.
 

[~elharo], please add your thoughts on my analysis.

> Add caching around File.getCanonicalPath
> 
>
> Key: MRESOLVER-68
> URL: https://issues.apache.org/jira/browse/MRESOLVER-68
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Reporter: Richard Atkins
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Maven Resolver spends a lot of time calculating the canonical path for a 
> File, and subsequently interning the result, in order to generate an in 
> memory lock object for the File. This can add up to 50% or more of the time 
> in a build, especially when using maven-enforcer-plugin with the 
> bannedDependencies rule with searchTransitive true.
> Caching these lookups will reduce build times, even for well behaved plugins.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MRESOLVER-68) Add caching around File.getCanonicalPath

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-68?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172644#comment-17172644
 ] 

Michael Osipov commented on MRESOLVER-68:
-

I think that this ticket is not required not is the canonicalization necessary. 
The {{TrackingFileManager}} is package private, thus never used externally. It 
used the interned string reperesentation of the canonical path and file 
locking. We all know that file locking in a single JVM are pointless, it will 
lead to race conditions. This is why the locking is multistage. Single JVM and 
file locks for multi JVM. The interesting part is that if you look up the call 
stack of  {{TrackingFileManager#read(File)}} and 
{{}}{{TrackingFileManager#u}}{{pdate(File, Map)}} you'll see 
that all of them are wrapped in a {{SyncContext}} which already add locks for 
them. I don't understand why this is done here. If outer look works, I see no 
need to lock again somewhere deeper. I am also keen to say that this kind of 
synchronization can be completely removed if you have a decent 
{{SyncContextFactory}} implementation.
 

[~elharo], please add your thoughts on my analysis.

> Add caching around File.getCanonicalPath
> 
>
> Key: MRESOLVER-68
> URL: https://issues.apache.org/jira/browse/MRESOLVER-68
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Reporter: Richard Atkins
>Priority: Major
>  Time Spent: 10m
>  Remaining Estimate: 0h
>
> Maven Resolver spends a lot of time calculating the canonical path for a 
> File, and subsequently interning the result, in order to generate an in 
> memory lock object for the File. This can add up to 50% or more of the time 
> in a build, especially when using maven-enforcer-plugin with the 
> bannedDependencies rule with searchTransitive true.
> Caching these lookups will reduce build times, even for well behaved plugins.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (MRESOLVER-128) Support smart checksums for Wagon Transporter

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRESOLVER-128.

Resolution: Won't Fix

Closing as described.

> Support smart checksums for Wagon Transporter
> -
>
> Key: MRESOLVER-128
> URL: https://issues.apache.org/jira/browse/MRESOLVER-128
> Project: Maven Resolver
>  Issue Type: Improvement
>  Components: resolver
>Reporter: Konrad Windszus
>Priority: Major
>
> The HTTP transporter can use checksum implicitly transferred via the {{ETag}} 
> response header: 
> https://github.com/apache/maven-resolver/blob/47edcfe69c4e52ced4cb93d65b7348b5645cdd68/maven-resolver-transport-http/src/main/java/org/eclipse/aether/transport/http/HttpTransporter.java#L526.
>  This feature is called smart checksums.
> The same functionality should also be supported in Wagon.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Closed] (MRESOLVER-129) Exclusion has no setters

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MRESOLVER-129.

Resolution: Fixed

Fixed with 
[bceb43a2880efe3fd9b59e78ad0fc8ca1ba68e80|https://gitbox.apache.org/repos/asf?p=maven-resolver.git;a=commit;h=bceb43a2880efe3fd9b59e78ad0fc8ca1ba68e80].

> Exclusion has no setters
> 
>
> Key: MRESOLVER-129
> URL: https://issues.apache.org/jira/browse/MRESOLVER-129
> Project: Maven Resolver
>  Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 1.5.1
>
>
> delete "Note: Instances of this class are immutable and the exposed mutators 
> return new objects rather than changing the current instance." since there 
> are no mutators on Exclusion



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (MRESOLVER-129) Exclusion has no setters

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MRESOLVER-129:


Assignee: Michael Osipov

> Exclusion has no setters
> 
>
> Key: MRESOLVER-129
> URL: https://issues.apache.org/jira/browse/MRESOLVER-129
> Project: Maven Resolver
>  Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Trivial
>
> delete "Note: Instances of this class are immutable and the exposed mutators 
> return new objects rather than changing the current instance." since there 
> are no mutators on Exclusion



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (MRESOLVER-129) Exclusion has no setters

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MRESOLVER-129:
-
Fix Version/s: 1.5.1

> Exclusion has no setters
> 
>
> Key: MRESOLVER-129
> URL: https://issues.apache.org/jira/browse/MRESOLVER-129
> Project: Maven Resolver
>  Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 1.5.1
>
>
> delete "Note: Instances of this class are immutable and the exposed mutators 
> return new objects rather than changing the current instance." since there 
> are no mutators on Exclusion



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MRESOLVER-130) Move GlobalSyncContextFactory to a separate module

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOLVER-130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172629#comment-17172629
 ] 

Michael Osipov commented on MRESOLVER-130:
--

[~rreich], I have moved the new impl to a separate module for obvious reasons. 
Please compile again and put this module in the ext classpath. Tried here with 
MRESOLVER-25, works for me.

> Move GlobalSyncContextFactory to a separate module
> --
>
> Key: MRESOLVER-130
> URL: https://issues.apache.org/jira/browse/MRESOLVER-130
> Project: Maven Resolver
>  Issue Type: Task
>  Components: resolver
>Affects Versions: 1.5.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.5.1
>
>
> In order to retain maximum performance for the sake of instability, the 
> synchronized context factory shall be moved to 
> {{maven-resolver-synccontext-global}} and has to be dropped to 
> \{{${maven.home}/lib/ext}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6975) Wagon-HTTP, set content-type when determinable from file extension

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172615#comment-17172615
 ] 

Michael Osipov commented on MNG-6975:
-

Do you think you can write also a test case which depicts your new feature?

> Wagon-HTTP, set content-type when determinable from file extension
> --
>
> Key: MNG-6975
> URL: https://issues.apache.org/jira/browse/MNG-6975
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.6.3
>Reporter: Christopher Beckey
>Assignee: Michael Osipov
>Priority: Minor
>  Labels: pull-request-available
>
> Add determination of content type from file extension when sending from File, 
> using javax.activation.MimetypesFileTypeMap.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (MNG-6975) Wagon-HTTP, set content-type when determinable from file extension

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MNG-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MNG-6975:
---

Assignee: Michael Osipov

> Wagon-HTTP, set content-type when determinable from file extension
> --
>
> Key: MNG-6975
> URL: https://issues.apache.org/jira/browse/MNG-6975
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.6.3
>Reporter: Christopher Beckey
>Assignee: Michael Osipov
>Priority: Minor
>  Labels: pull-request-available
>
> Add determination of content type from file extension when sending from File, 
> using javax.activation.MimetypesFileTypeMap.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (MRESOLVER-130) Move GlobalSyncContextFactory to a separate module

[Michael Osipov (Jira)]

 [ 
https://issues.apache.org/jira/browse/MRESOLVER-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MRESOLVER-130:
-
Summary: Move GlobalSyncContextFactory to a separate module  (was: Move 
GlobalSyncContext to a separate module)

> Move GlobalSyncContextFactory to a separate module
> --
>
> Key: MRESOLVER-130
> URL: https://issues.apache.org/jira/browse/MRESOLVER-130
> Project: Maven Resolver
>  Issue Type: Task
>  Components: resolver
>Affects Versions: 1.5.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 1.5.1
>
>
> In order to retain maximum performance for the sake of instability, the 
> synchronized context factory shall be moved to 
> {{maven-resolver-synccontext-global}} and has to be dropped to 
> \{{${maven.home}/lib/ext}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (MRESOLVER-130) Move GlobalSyncContext to a separate module

[Michael Osipov (Jira)]

Michael Osipov created MRESOLVER-130:


 Summary: Move GlobalSyncContext to a separate module
 Key: MRESOLVER-130
 URL: https://issues.apache.org/jira/browse/MRESOLVER-130
 Project: Maven Resolver
  Issue Type: Task
  Components: resolver
Affects Versions: 1.5.0
Reporter: Michael Osipov
Assignee: Michael Osipov
 Fix For: 1.5.1


In order to retain maximum performance for the sake of instability, the 
synchronized context factory shall be moved to 
{{maven-resolver-synccontext-global}} and has to be dropped to 
\{{${maven.home}/lib/ext}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-wagon] chrisbeckey commented on a change in pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

chrisbeckey commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466592978



##
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##
@@ -279,6 +332,20 @@ public boolean isStreaming()
 private static final boolean SSL_ALLOW_ALL =
 Boolean.valueOf( System.getProperty( "maven.wagon.http.ssl.allowall", 
"false" ) );
 
+/**
+ * If enabled, then the content-type HTTP header will be set using the 
file extension
+ * or the stream header to determine the type, disabled by default
+ */
+private static final boolean AUTOSET_CONTENT_TYPE =
+Boolean.valueOf( System.getProperty( 
"maven.wagon.http.autocontenttype", "true" ) );

Review comment:
   I've noticed that in OSS contributions, at least others I've made, 
consistency is valued highly. No other reason and, FWIW and IMHO, 
unboxing/autoboxing should be banished from decent society.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] chrisbeckey commented on a change in pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

chrisbeckey commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466590246



##
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##
@@ -279,6 +332,20 @@ public boolean isStreaming()
 private static final boolean SSL_ALLOW_ALL =
 Boolean.valueOf( System.getProperty( "maven.wagon.http.ssl.allowall", 
"false" ) );
 
+/**
+ * If enabled, then the content-type HTTP header will be set using the 
file extension
+ * or the stream header to determine the type, disabled by default

Review comment:
   Nice catch, fixed the comment. property is TRUE by default (i.e. 
content-type will be determined and set)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] pzygielo commented on a change in pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

pzygielo commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466589590



##
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##
@@ -279,6 +332,20 @@ public boolean isStreaming()
 private static final boolean SSL_ALLOW_ALL =
 Boolean.valueOf( System.getProperty( "maven.wagon.http.ssl.allowall", 
"false" ) );
 
+/**
+ * If enabled, then the content-type HTTP header will be set using the 
file extension
+ * or the stream header to determine the type, disabled by default
+ */
+private static final boolean AUTOSET_CONTENT_TYPE =
+Boolean.valueOf( System.getProperty( 
"maven.wagon.http.autocontenttype", "true" ) );

Review comment:
   I understand it's pattern copied from existing code - but why in new 
code not use `parseBoolean` instead of `valueOf` and skip unboxing?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] pzygielo commented on a change in pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

pzygielo commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466588481



##
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##
@@ -279,6 +332,20 @@ public boolean isStreaming()
 private static final boolean SSL_ALLOW_ALL =
 Boolean.valueOf( System.getProperty( "maven.wagon.http.ssl.allowall", 
"false" ) );
 
+/**
+ * If enabled, then the content-type HTTP header will be set using the 
file extension
+ * or the stream header to determine the type, disabled by default

Review comment:
   I'm not sure - is it disabled when property is set to `true` (which is 
set as default for `getProperty` call)?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] michael-o commented on pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

michael-o commented on pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#issuecomment-670071258


   The stream guessing is almost pointless, look at its code: 
https://github.com/battleblow/openjdk-jdk8u/blob/bsd-port/jdk/src/share/classes/java/net/URLConnection.java
   
   Path based approach looks better:
   ```
   #sun.net.www MIME content-types table
   #
   # Property fields:
   #
   #::= 'description' '=' 
   # ::= 'file_extensions' '=' 
   #  ::= 'icon' '=' 
   # ::= 'browser' | 'application' | 'save' | 'unknown'
   #::= 'application' '=' 
   #
   
   #
   # The "we don't know anything about this data" type(s).
   # Used internally to mark unrecognized types.
   #
   content/unknown: description=Unknown Content
   unknown/unknown: description=Unknown Data Type
   
   #
   # The template we should use for temporary files when launching an 
application
   # to view a document of given type.
   #
   temp.file.template: c:\\temp\\%s
   
   #
   # The "real" types.
   #
   application/octet-stream: \
description=Generic Binary Stream;\
file_extensions=.saveme,.dump,.hqx,.arc,.obj,.lib,.bin,.exe,.zip,.gz
   
   application/oda: \
description=ODA Document;\
file_extensions=.oda
   
   application/pdf: \
description=Adobe PDF Format;\
file_extensions=.pdf
   
   application/postscript: \
description=Postscript File;\
file_extensions=.eps,.ai,.ps;\
icon=ps
   
   application/rtf: \
description=Wordpad Document;\
file_extensions=.rtf;\
action=application;\
application=wordpad.exe %s
   
   application/x-dvi: \
description=TeX DVI File;\
file_extensions=.dvi
   
   application/x-hdf: \
description=Hierarchical Data Format;\
file_extensions=.hdf;\
action=save
   
   application/x-latex: \
description=LaTeX Source;\
file_extensions=.latex
   
   application/x-netcdf: \
description=Unidata netCDF Data Format;\
file_extensions=.nc,.cdf;\
action=save
   
   application/x-tex: \
description=TeX Source;\
file_extensions=.tex
   
   application/x-texinfo: \
description=Gnu Texinfo;\
file_extensions=.texinfo,.texi
   
   application/x-troff: \
description=Troff Source;\
file_extensions=.t,.tr,.roff
   
   application/x-troff-man: \
description=Troff Manpage Source;\
file_extensions=.man
   
   application/x-troff-me: \
description=Troff ME Macros;\
file_extensions=.me
   
   application/x-troff-ms: \
description=Troff MS Macros;\
file_extensions=.ms
   
   application/x-wais-source: \
description=Wais Source;\
file_extensions=.src,.wsrc
   
   application/zip: \
description=Zip File;\
file_extensions=.zip;\
icon=zip;\
action=save
   
   application/x-bcpio: \
description=Old Binary CPIO Archive;\
file_extensions=.bcpio;\
action=save
   
   application/x-cpio: \
description=Unix CPIO Archive;\
file_extensions=.cpio;\
action=save
   
   application/x-gtar: \
description=Gnu Tar Archive;\
file_extensions=.gtar;\
icon=tar;\
action=save
   
   application/x-shar: \
description=Shell Archive;\
file_extensions=.sh,.shar;\
action=save
   
   application/x-sv4cpio: \
description=SVR4 CPIO Archive;\
file_extensions=.sv4cpio;\
action=save
   
   application/x-sv4crc: \
description=SVR4 CPIO with CRC;\
file_extensions=.sv4crc;\
action=save
   
   application/x-tar: \
description=Tar Archive;\
file_extensions=.tar;\
icon=tar;\
action=save
   
   application/x-ustar: \
description=US Tar Archive;\
file_extensions=.ustar;\
action=save
   
   audio/basic: \
description=Basic Audio;\
file_extensions=.snd,.au;\
icon=audio
   
   audio/x-aiff: \
description=Audio Interchange Format File;\
file_extensions=.aifc,.aif,.aiff;\
icon=aiff
   
   audio/x-wav: \
description=Wav Audio;\
file_extensions=.wav;\
icon=wav;\
action=application;\
application=mplayer.exe %s
   
   image/gif: \
description=GIF Image;\
file_extensions=.gif;\
icon=gif;\
action=browser
   
   image/ief: \
description=Image Exchange Format;\
file_extensions=.ief
   
   image/jpeg: \
description=JPEG Image;\
file_extensions=.jfif,.jfif-tbnl,.jpe,.jpg,.jpeg;\
icon=jpeg;\
action=browser
   
   image/tiff: \
description=TIFF Image;\
file_extensions=.tif,.tiff;\
icon=tiff
   
   image/vnd.fpx: \
description=FlashPix Image;\
file_extensions=.fpx,.fpix
   
   image/x-cmu-rast: \
description=CMU 

[GitHub] [maven-wagon] michael-o commented on a change in pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

michael-o commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466568033



##
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##
@@ -169,6 +154,44 @@ private WagonHttpEntity( final InputStream stream, final 
Resource resource, fina
 
 this.wagon = wagon;
 
+// if the autoset content flag is SET and the content type is blank
+// then try to determine what the content type is and set it
+if ( AUTOSET_CONTENT_TYPE && getContentType() == null )
+{
+try
+{
+autosetContentType();
+}
+catch ( IOException ioX )
+{
+if ( AUTOSET_CONTENT_TYPE_FATAL )
+{
+throw new TransferFailedException(
+"Failed to determine content type, "
++ " unset 
'maven.wagon.http.autocontenttype.fatal' to allow continued processing",
+ioX );
+}
+}
+}
+}
+
+private void autosetContentType() throws IOException
+{
+// if the content-type has not been set then
+// if the option flag is TRUE and the content type is determinable 
from the file extension
+// then set it from the file extension
+final String mimeType = AUTOSET_CONTENT_TYPE
+? this.source != null
+? URLConnection.guessContentTypeFromName( 
source.getName() )
+: this.stream != null
+? URLConnection.guessContentTypeFromStream( 
this.stream )

Review comment:
   Javadoc does not even mentioned that. Please add a comment above.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-dependency-plugin] ian-lavallee commented on pull request #94: [MDEP-644] add resolver dependency

[GitBox]

ian-lavallee commented on pull request #94:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/94#issuecomment-670059431


   I can't push to this branch because I don't have permissions but if you 
declare maven-resolver-transport-file, transport-http, api, util jetty-server 
and maven-compat it fixes the failing tests.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] chrisbeckey commented on a change in pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

chrisbeckey commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466558697



##
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##
@@ -169,6 +154,44 @@ private WagonHttpEntity( final InputStream stream, final 
Resource resource, fina
 
 this.wagon = wagon;
 
+// if the autoset content flag is SET and the content type is blank
+// then try to determine what the content type is and set it
+if ( AUTOSET_CONTENT_TYPE && getContentType() == null )
+{
+try
+{
+autosetContentType();
+}
+catch ( IOException ioX )
+{
+if ( AUTOSET_CONTENT_TYPE_FATAL )
+{
+throw new TransferFailedException(
+"Failed to determine content type, "
++ " unset 
'maven.wagon.http.autocontenttype.fatal' to allow continued processing",
+ioX );
+}
+}
+}
+}
+
+private void autosetContentType() throws IOException
+{
+// if the content-type has not been set then
+// if the option flag is TRUE and the content type is determinable 
from the file extension
+// then set it from the file extension
+final String mimeType = AUTOSET_CONTENT_TYPE
+? this.source != null
+? URLConnection.guessContentTypeFromName( 
source.getName() )
+: this.stream != null
+? URLConnection.guessContentTypeFromStream( 
this.stream )

Review comment:
   If the stream does not support mark then guessContentTypeFromStream will 
return null. Here is the code:
   static public String guessContentTypeFromStream(InputStream is)
   throws IOException {
   // If we can't read ahead safely, just give up on guessing
   if (!is.markSupported())
   return null;
   ...
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] michael-o commented on a change in pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

michael-o commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466554768



##
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##
@@ -169,6 +154,44 @@ private WagonHttpEntity( final InputStream stream, final 
Resource resource, fina
 
 this.wagon = wagon;
 
+// if the autoset content flag is SET and the content type is blank
+// then try to determine what the content type is and set it
+if ( AUTOSET_CONTENT_TYPE && getContentType() == null )
+{
+try
+{
+autosetContentType();
+}
+catch ( IOException ioX )
+{
+if ( AUTOSET_CONTENT_TYPE_FATAL )
+{
+throw new TransferFailedException(
+"Failed to determine content type, "
++ " unset 
'maven.wagon.http.autocontenttype.fatal' to allow continued processing",
+ioX );
+}
+}
+}
+}
+
+private void autosetContentType() throws IOException
+{
+// if the content-type has not been set then
+// if the option flag is TRUE and the content type is determinable 
from the file extension
+// then set it from the file extension
+final String mimeType = AUTOSET_CONTENT_TYPE
+? this.source != null
+? URLConnection.guessContentTypeFromName( 
source.getName() )
+: this.stream != null
+? URLConnection.guessContentTypeFromStream( 
this.stream )

Review comment:
   You cannot do this. This will consume a few magic bytes from the stream 
making it useless. You can utilize this only with a pushback stream.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] michael-o commented on a change in pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

michael-o commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466554768



##
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##
@@ -169,6 +154,44 @@ private WagonHttpEntity( final InputStream stream, final 
Resource resource, fina
 
 this.wagon = wagon;
 
+// if the autoset content flag is SET and the content type is blank
+// then try to determine what the content type is and set it
+if ( AUTOSET_CONTENT_TYPE && getContentType() == null )
+{
+try
+{
+autosetContentType();
+}
+catch ( IOException ioX )
+{
+if ( AUTOSET_CONTENT_TYPE_FATAL )
+{
+throw new TransferFailedException(
+"Failed to determine content type, "
++ " unset 
'maven.wagon.http.autocontenttype.fatal' to allow continued processing",
+ioX );
+}
+}
+}
+}
+
+private void autosetContentType() throws IOException
+{
+// if the content-type has not been set then
+// if the option flag is TRUE and the content type is determinable 
from the file extension
+// then set it from the file extension
+final String mimeType = AUTOSET_CONTENT_TYPE
+? this.source != null
+? URLConnection.guessContentTypeFromName( 
source.getName() )
+: this.stream != null
+? URLConnection.guessContentTypeFromStream( 
this.stream )

Review comment:
   You cannot do this. This will confuse a few magic bytes from the stream 
making it useless. You can utilize this only with a pushback stream.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] chrisbeckey commented on a change in pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

chrisbeckey commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466547343



##
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##
@@ -82,6 +82,7 @@
 import org.apache.maven.wagon.resource.Resource;
 import org.codehaus.plexus.util.StringUtils;
 
+import javax.activation.MimetypesFileTypeMap;

Review comment:
   fixed in latest push





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] chrisbeckey commented on pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

chrisbeckey commented on pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#issuecomment-670046025


   Updated to use URLConnection.guess***, which also allows this to work with 
streaming. Added a second property to control behavior when an error in content 
identification occurs. Default to creating content-type and not failing if 
determining content-type fails. Thanks to @elharo for the suggestion, this is 
better than before.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] chrisbeckey commented on pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

chrisbeckey commented on pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#issuecomment-670041840


   Regarding the version 1.11 vs 11: in following up on the suggestion by 
@elharo to use URLConnection.guess... the need for javax.activation has been 
negated. Update to the PR is coming soon.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] pzygielo commented on pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

pzygielo commented on pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#issuecomment-670029018


   @chrisbeckey 
   > Just to be sure I tested it with "1.11" and with "11" and they both worked.
   
   Yeah, but why it did?
   
   I think that 1.11 works only because when 
   ```
   [DEBUG] Detected Java String: '11.0.8'
   [DEBUG] Normalized Java String: '11.0.8'
   ```
   normalized string is tested against range `[1.11,)` - it is accepted due to 
11 (of `11.0.8`) being greater than 1 of (`1.11`).
   
   I am pretty sure it shall be `[11,)`, as you see, with `[1.11,)` for example 
JDK 10 is also accepted (as `10 > 1`).



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-dependency-plugin] michael-o commented on pull request #94: [MDEP-644] add resolver dependency

[GitBox]

michael-o commented on pull request #94:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/94#issuecomment-670018605


   Why does a test require outbound access?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-dependency-plugin] elharo commented on pull request #94: [MDEP-644] add resolver dependency

[GitBox]

elharo commented on pull request #94:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/94#issuecomment-670015800


   [INFO] Running org.apache.maven.plugins.dependency.TestListClassesMojo
   org.eclipse.aether.transfer.NoRepositoryConnectorException: No connector 
available to access repository central (https://repo.maven.apache.org/maven2) 
of type default using the available factories 
at 
org.eclipse.aether.internal.impl.DefaultRepositoryConnectorProvider.newRepositoryConnector(DefaultRepositoryConnectorProvider.java:193)
at 
org.eclipse.aether.internal.impl.DefaultArtifactResolver.performDownloads(DefaultArtifactResolver.java:531)
at 
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolve(DefaultArtifactResolver.java:436)
at 
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifacts(DefaultArtifactResolver.java:262)
at 
org.eclipse.aether.internal.impl.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:239)
at 
org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.loadPom(DefaultArtifactDescriptorReader.java:320)
at 
org.apache.maven.repository.internal.DefaultArtifactDescriptorReader.readArtifactDescriptor(DefaultArtifactDescriptorReader.java:217)
at 
org.eclipse.aether.internal.impl.DefaultRepositorySystem.readArtifactDescriptor(DefaultRepositorySystem.java:288)
at 
org.apache.maven.shared.transfer.artifact.resolve.internal.Maven31ArtifactResolver.resolveArtifact(Maven31ArtifactResolver.java:104)
at 
org.apache.maven.shared.transfer.artifact.resolve.internal.Maven31ArtifactResolver.resolveArtifact(Maven31ArtifactResolver.java:80)
at 
org.apache.maven.shared.transfer.artifact.resolve.internal.DefaultArtifactResolver.resolveArtifact(DefaultArtifactResolver.java:75)
at 
org.apache.maven.plugins.dependency.ListClassesMojo.execute(ListClassesMojo.java:175)
at 
org.apache.maven.plugins.dependency.TestListClassesMojo.testListClassesNotTransitive(TestListClassesMojo.java:74)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] elharo commented on a change in pull request #72: [MNG-6975] Wagon-HTTP, set content-type when determinable from file extension

[GitBox]

elharo commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466503929



##
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##
@@ -82,6 +82,7 @@
 import org.apache.maven.wagon.resource.Resource;
 import org.codehaus.plexus.util.StringUtils;
 
+import javax.activation.MimetypesFileTypeMap;

Review comment:
   This class is not significant enough to pull in the javax.activation 
package. I'm sure there's an alternative somewhere. Or just use 
`URLConnection.guessContentTypeFromName`





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] elharo merged pull request #71: docs: remove Maven 1 link

[GitBox]

elharo merged pull request #71:
URL: https://github.com/apache/maven-wagon/pull/71


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-dependency-plugin] elharo commented on pull request #94: [MDEP-644] add resolver dependency

[GitBox]

elharo commented on pull request #94:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/94#issuecomment-669998545


   The org.eclipse.aether.spi.connector.Transfer class does not have the 
setState method the wagon aether connector invokes.
   
   Next step is to see if we can replace aether-connector-wagon with something 
more up to date.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] chrisbeckey commented on pull request #72: Wagon-HTTP, set content-type when determinable from file extension (MNG-6975)

[GitBox]

chrisbeckey commented on pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#issuecomment-669998232


   regarding: "Is it really 1.11? If yes, then this is a bug in Maven."
   Just to be sure I tested it with "1.11" and with "11" and they both worked.
   I then tried with "12" (I'm running JDK 11) and it failed with the expected
   missing package. I think it works either way.
   
   regarding: "per-server config rather than global."
   I agree, is there an example you can point me to that I can start from?
   
   On Thu, Aug 6, 2020 at 11:17 AM Michael Osipov 
   wrote:
   
   >
   > *This email was sent from an external source so please treat with caution.*
   > --
   > *@michael-o* commented on this pull request.
   >
   > --
   >
   > In wagon-providers/pom.xml
   > 
   > :
   >
   > > @@ -78,4 +78,20 @@ under the License.
   >test
   >  
   >
   > +
   > +  
   > +
   > +  jdk11
   > +  
   > +[1.11,)
   >
   > Is it really 1.11? If yes, then this is a bug in Maven.
   > --
   >
   > In
   > 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
   > 
   > :
   >
   > > @@ -279,6 +296,13 @@ public boolean isStreaming()
   >  private static final boolean SSL_ALLOW_ALL =
   >  Boolean.valueOf( System.getProperty( 
"maven.wagon.http.ssl.allowall", "false" ) );
   >
   > +/**
   > + * If enabled, then the content-type HTTP header will be set using 
the file extension to determine the type,
   > + * disabled by default
   > + * This flag is only effective when uploading from a File, not 
directly from a Stream.
   > + */
   > +private static final boolean SET_CONTENT_TYPE_FROM_FILE_EXTENSION =
   >
   > I wonder whether this should be a per-server config rather than global. In
   > general, sys props are either globally or for a technical reason. WDYT?
   >
   > —
   > You are receiving this because you authored the thread.
   > Reply to this email directly, view it on GitHub
   > 
,
   > or unsubscribe
   > 

   > .
   >
   
   About Ascential plc: Ascential (LSE:ASCL.L) is a specialist information, 
data and analytics company that helps the world’s most ambitious businesses win 
in the digital economy. Our information, insights, connections, data and 
digital tools solve customer problems in three disciplines: 
   Product Design via global trend forecasting service WGSN;
   Marketing via global benchmark for creative excellence and effectiveness 
Cannes Lions and WARC and strategic advisory firm MediaLink; and 
   Sales via ecommerce-driven data, insights and advisory service Edge by 
Ascential, leading managed services provider for Amazon Flywheel Digital, the 
world's premier payments and Fin Tech congress Money20/20, global retail 
industry summit World Retail Congress and retail news outlet Retail Week.
   Ascential also powers political, construction and environmental intelligence 
brands DeHavilland, Glenigan and Groundsure.
   The information in or attached to this email is confidential and may be 
legally privileged. If you are not the intended recipient of this message, any 
use, disclosure, copying, distribution or any action taken in reliance on it is 
prohibited and may be unlawful. 
   If you have received this message in error, please notify the sender 
immediately by return email and delete this message and any copies from your 
computer and network. Ascential does not warrant that this email and any 
attachments are free from viruses and accepts no liability for any loss 
resulting from infected email transmissions.
   Ascential reserves the right to monitor all email through its networks. Any 
view expressed may be those of the originator and not necessarily of Ascential 
plc. 
   Please be advised all phone calls may be recorded for training and quality 
purposes and by accepting and/or making calls to us you acknowledge and agree 
to calls being recorded. 
   Ascential plc, number 9934451 (England and Wales). Registered Office: The 
Prow, 1 Wilder Walk, London W1B 5AP.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-dependency-plugin] ian-lavallee commented on pull request #94: [MDEP-644] add resolver dependency

[GitBox]

ian-lavallee commented on pull request #94:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/94#issuecomment-669997202


   @elharo CI still failing with the exclusion. I'll try excluding from the 
resolver next and then shading and ping you when I need a CI kicked off



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-6975) Wagon-HTTP, set content-type when determinable from file extension

[Christopher Beckey (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172460#comment-17172460
 ] 

Christopher Beckey commented on MNG-6975:
-

This is the plugin element from the project which is deploying its site:
{quote}{{ }}
{{ org.apache.maven.plugins}}
{{ maven-site-plugin}}
{{ 3.9.1}}
{{ }}
{{}}
{{ org.apache.maven.wagon}}
{{ wagon-webdav-jackrabbit}}
{{}}
{{ 3.4.1}}
{{ }}
{{ }}
{{ }}
{{ com.sun.activation}}
{{ javax.activation}}
{{ 1.2.0}}
{{ }}
{{ }}
{{ }}
{quote}

> Wagon-HTTP, set content-type when determinable from file extension
> --
>
> Key: MNG-6975
> URL: https://issues.apache.org/jira/browse/MNG-6975
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.6.3
>Reporter: Christopher Beckey
>Priority: Minor
>  Labels: pull-request-available
>
> Add determination of content type from file extension when sending from File, 
> using javax.activation.MimetypesFileTypeMap.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-wagon] michael-o commented on a change in pull request #72: Wagon-HTTP, set content-type when determinable from file extension (MNG-6975)

[GitBox]

michael-o commented on a change in pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72#discussion_r466472750



##
File path: wagon-providers/pom.xml
##
@@ -78,4 +78,20 @@ under the License.
   test
 
   
+
+  
+
+  jdk11
+  
+[1.11,)

Review comment:
   Is it really 1.11? If yes, then this is a bug in Maven.

##
File path: 
wagon-providers/wagon-http-shared/src/main/java/org/apache/maven/wagon/shared/http/AbstractHttpClientWagon.java
##
@@ -279,6 +296,13 @@ public boolean isStreaming()
 private static final boolean SSL_ALLOW_ALL =
 Boolean.valueOf( System.getProperty( "maven.wagon.http.ssl.allowall", 
"false" ) );
 
+/**
+ * If enabled, then the content-type HTTP header will be set using the 
file extension to determine the type,
+ * disabled by default
+ * This flag is only effective when uploading from a File, not directly 
from a Stream.
+ */
+private static final boolean SET_CONTENT_TYPE_FROM_FILE_EXTENSION =

Review comment:
   I wonder whether this should be a per-server config rather than global. 
In general, sys props are either globally or for a technical reason. WDYT? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-dependency-plugin] elharo commented on pull request #94: [MDEP-644] add resolver dependency

[GitBox]

elharo commented on pull request #94:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/94#issuecomment-669987887


   org.elipse.aether.spi is in the resolver and in the aether dependency
   
   [INFO] Running org.apache.maven.plugins.dependency.TestListClassesMojo
   Exception in thread "pool-409-thread-1" java.lang.NoSuchMethodError: 
org.eclipse.aether.spi.connector.Transfer.setState(Lorg/eclipse/aether/spi/connector/Transfer$State;)Lorg/eclipse/aether/spi/connector/Transfer;
at 
org.eclipse.aether.connector.wagon.WagonRepositoryConnector$GetTask.run(WagonRepositoryConnector.java:608)
at 
org.eclipse.aether.util.concurrency.RunnableErrorForwarder$1.run(RunnableErrorForwarder.java:67)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-dependency-plugin] elharo edited a comment on pull request #94: [MDEP-644] add resolver dependency

[GitBox]

elharo edited a comment on pull request #94:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/94#issuecomment-669987887


   org.eclipse.aether.spi is in the resolver and in the aether dependency
   
   [INFO] Running org.apache.maven.plugins.dependency.TestListClassesMojo
   Exception in thread "pool-409-thread-1" java.lang.NoSuchMethodError: 
org.eclipse.aether.spi.connector.Transfer.setState(Lorg/eclipse/aether/spi/connector/Transfer$State;)Lorg/eclipse/aether/spi/connector/Transfer;
at 
org.eclipse.aether.connector.wagon.WagonRepositoryConnector$GetTask.run(WagonRepositoryConnector.java:608)
at 
org.eclipse.aether.util.concurrency.RunnableErrorForwarder$1.run(RunnableErrorForwarder.java:67)
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-6975) Wagon-HTTP, set content-type when determinable from file extension

[Christopher Beckey (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172440#comment-17172440
 ] 

Christopher Beckey commented on MNG-6975:
-

[https://github.com/apache/maven-wagon/pull/72]

> Wagon-HTTP, set content-type when determinable from file extension
> --
>
> Key: MNG-6975
> URL: https://issues.apache.org/jira/browse/MNG-6975
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.6.3
>Reporter: Christopher Beckey
>Priority: Minor
>  Labels: pull-request-available
>
> Add determination of content type from file extension when sending from File, 
> using javax.activation.MimetypesFileTypeMap.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-wagon] chrisbeckey opened a new pull request #72: Wagon-HTTP, set content-type when determinable from file extension (MNG-6975)

[GitBox]

chrisbeckey opened a new pull request #72:
URL: https://github.com/apache/maven-wagon/pull/72


   Set the HTTP content-type header, using the file extension to determine 
value, when uploading a file.
   Note that this requires JDK version below 11, else the javax.activation 
package is not available. To compile with JDK 11 or after requires the addition 
of:


com.sun.activation

javax.activation
1.2.0

   This dependency has been added in a JDK11 specific profile in 
maven-wagon.wagon-providers.pom.xml
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-wagon] elharo opened a new pull request #71: docs: rmeove Maven 1 link

[GitBox]

elharo opened a new pull request #71:
URL: https://github.com/apache/maven-wagon/pull/71


   what else would it mean?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-6975) Wagon-HTTP, set content-type when determinable from file extension

[Christopher Beckey (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172432#comment-17172432
 ] 

Christopher Beckey commented on MNG-6975:
-

Specifically this came from needing AWS to retain the correct content-type when 
deploying the project site. We have our project site in S3, behind a CloudFront 
Distribution (to provide security). If the content-type is not specified when 
deploying the site then CloudFront defaults it to application.octet-stream, the 
result is that every file on the site is downloaded rather than displayed when 
accessed in a browser.

I have the code just about complete, a PR will be available in a few minutes. 
The PR includes conditionals such that:
 # the content-type is not overridden if it has been set
 # the content-type is written only when a system property 
(maven.wagon.http.file.autocontenttype) is set, the default behavior is 
consistent with current behavior
 # the content-type is only written if it was determinable (not null or empty) 
from the javax.activation.MimetypesFileTypeMap instance

> Wagon-HTTP, set content-type when determinable from file extension
> --
>
> Key: MNG-6975
> URL: https://issues.apache.org/jira/browse/MNG-6975
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.6.3
>Reporter: Christopher Beckey
>Priority: Minor
>  Labels: pull-request-available
>
> Add determination of content type from file extension when sending from File, 
> using javax.activation.MimetypesFileTypeMap.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6975) Wagon-HTTP, set content-type when determinable from file extension

[Michael Osipov (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6975?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172413#comment-17172413
 ] 

Michael Osipov commented on MNG-6975:
-

Can you describe your usecase?

> Wagon-HTTP, set content-type when determinable from file extension
> --
>
> Key: MNG-6975
> URL: https://issues.apache.org/jira/browse/MNG-6975
> Project: Maven
>  Issue Type: Improvement
>  Components: Plugins and Lifecycle
>Affects Versions: 3.6.3
>Reporter: Christopher Beckey
>Priority: Minor
>  Labels: pull-request-available
>
> Add determination of content type from file extension when sending from File, 
> using javax.activation.MimetypesFileTypeMap.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (ARCHETYPE-606) There is no way to include .gitignore files for the jar goal

[Dennis Lundberg (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Lundberg updated ARCHETYPE-606:
--
Summary: There is no way to include .gitignore files for the jar goal  
(was: Parameter addDefaultExcludes with false does not copy .gitignore)

> There is no way to include .gitignore files for the jar goal
> 
>
> Key: ARCHETYPE-606
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-606
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 3.2.0
> Environment: CentOS 7 64bits, OpenJDK 11.0.7, Maven 3.6.3, Maven 
> Archetype Plugin 3.2.0
>Reporter: Joël Royer
>Priority: Major
>
> In a Maven archetype, I'm using the resource plugin to copy some files like a 
> .gitignore template. But this file is not copied when I generate a project 
> from this artefact.
> Here is my config for the resource plugin in my artefact:
> {code:java}
> 
>  org.apache.maven.plugins
>  maven-resources-plugin
>  3.1.0
>  
>   
>   
>   false
>  
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Moved] (ARCHETYPE-606) Parameter addDefaultExcludes with false does not copy .gitignore

[Dennis Lundberg (Jira)]

 [ 
https://issues.apache.org/jira/browse/ARCHETYPE-606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dennis Lundberg moved MRESOURCES-264 to ARCHETYPE-606:
--

  Component/s: (was: copy)
   Plugin
  Key: ARCHETYPE-606  (was: MRESOURCES-264)
Affects Version/s: (was: 3.1.0)
   3.2.0
  Project: Maven Archetype  (was: Maven Resources Plugin)

> Parameter addDefaultExcludes with false does not copy .gitignore
> 
>
> Key: ARCHETYPE-606
> URL: https://issues.apache.org/jira/browse/ARCHETYPE-606
> Project: Maven Archetype
>  Issue Type: Bug
>  Components: Plugin
>Affects Versions: 3.2.0
> Environment: CentOS 7 64bits, OpenJDK 11.0.7, Maven 3.6.3, Maven 
> Archetype Plugin 3.2.0
>Reporter: Joël Royer
>Priority: Major
>
> In a Maven archetype, I'm using the resource plugin to copy some files like a 
> .gitignore template. But this file is not copied when I generate a project 
> from this artefact.
> Here is my config for the resource plugin in my artefact:
> {code:java}
> 
>  org.apache.maven.plugins
>  maven-resources-plugin
>  3.1.0
>  
>   
>   
>   false
>  
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MRESOURCES-264) Parameter addDefaultExcludes with false does not copy .gitignore

[Dennis Lundberg (Jira)]

[ 
https://issues.apache.org/jira/browse/MRESOURCES-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172389#comment-17172389
 ] 

Dennis Lundberg commented on MRESOURCES-264:


Thank you for the example project [~joelroyer].

I have tried it and can verify that maven-resources-plugin in fact does copy 
the .gitignore file to target/classes/archetype-resources. So 
maven-resources-plugin does what you have told it to do.

After that maven-archetype-plugin takes over and packages your archetype with 
the jar goal, using your supplied archetype-metadata.xml file. That plugin 
however does NOT include the .gitignore file. I haven't looked at the code, but 
I assume that the copying of a fileSet also has some kind of default ignores.

What you need is a way to tell maven-archetype-plugin to not exclude such 
files. I'm going to move this issue over to the JIRA project for 
maven-archetype.

> Parameter addDefaultExcludes with false does not copy .gitignore
> 
>
> Key: MRESOURCES-264
> URL: https://issues.apache.org/jira/browse/MRESOURCES-264
> Project: Maven Resources Plugin
>  Issue Type: Bug
>  Components: copy
>Affects Versions: 3.1.0
> Environment: CentOS 7 64bits, OpenJDK 11.0.7, Maven 3.6.3, Maven 
> Archetype Plugin 3.2.0
>Reporter: Joël Royer
>Priority: Major
>
> In a Maven archetype, I'm using the resource plugin to copy some files like a 
> .gitignore template. But this file is not copied when I generate a project 
> from this artefact.
> Here is my config for the resource plugin in my artefact:
> {code:java}
> 
>  org.apache.maven.plugins
>  maven-resources-plugin
>  3.1.0
>  
>   
>   
>   false
>  
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (MNG-6975) Wagon-HTTP, set content-type when determinable from file extension

[Christopher Beckey (Jira)]

Christopher Beckey created MNG-6975:
---

 Summary: Wagon-HTTP, set content-type when determinable from file 
extension
 Key: MNG-6975
 URL: https://issues.apache.org/jira/browse/MNG-6975
 Project: Maven
  Issue Type: Improvement
  Components: Plugins and Lifecycle
Affects Versions: 3.6.3
Reporter: Christopher Beckey


Add determination of content type from file extension when sending from File, 
using javax.activation.MimetypesFileTypeMap.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (MASFRES-38) Issue while running maven command for ui plugins-Could not determine SWT implementation fragment bundle for environment

[Jasmeet (Jira)]

Jasmeet created MASFRES-38:
--

 Summary: Issue while running maven command for ui plugins-Could 
not determine SWT implementation fragment bundle for environment
 Key: MASFRES-38
 URL: https://issues.apache.org/jira/browse/MASFRES-38
 Project: Apache Maven Resource Bundles
  Issue Type: Bug
  Components: apache-incubator-disclaimer-resource-bundle
 Environment: win32win32  win32  
x86
Reporter: Jasmeet


While running mvn clean command for plugins having required 
bundles-Require-Bundle: org.eclipse.ui,
 org.eclipse.core.runtime,
 org.eclipse.core.expressions;bundle-version="3.4.400",

Below error comes-

Internal error: java.lang.RuntimeException: Could not determine SWT 
implementation fragment bundle for environment \{osgi.os=win32, osgi.ws=win32, 
org.eclipse.update.install.features=true, osgi.arch=x86_64} -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: 
java.lang.RuntimeException: Could not determine SWT implementation fragment 
bundle for environment \{osgi.os=win32, osgi.ws=win32, 
org.eclipse.update.install.features=true, osgi.arch=x86_64}
 at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:120)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MDEP-708) dependency:analyze should recommend narrower scope where possible

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MDEP-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172364#comment-17172364
 ] 

Hudson commented on MDEP-708:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-dependency-plugin » 
master #13

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-dependency-plugin/job/master/13/

> dependency:analyze should recommend narrower scope where possible
> -
>
> Key: MDEP-708
> URL: https://issues.apache.org/jira/browse/MDEP-708
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Major
>  Labels: intern
> Fix For: 3.1.3
>
>
> E.g. if a dependency is indeed used but has compile scope and is only needed 
> in tests, mvn dependency:analyze should suggest reducing its scope.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-dependency-plugin] pzygielo commented on a change in pull request #92: [MDEP-644] Reintroduce the verbose option for dependency:tree

[GitBox]

pzygielo commented on a change in pull request #92:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/92#discussion_r466403074



##
File path: 
src/test/java/org/apache/maven/plugins/dependency/TestListClassesMojo.java
##
@@ -58,6 +59,11 @@ protected void setUp()
 setVariableValueToObject( mojo, "session", legacySupport.getSession() 
);
 }
 
+public void test()

Review comment:
   :eyes: :confused: 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-dependency-plugin] elharo commented on a change in pull request #92: [MDEP-644] Reintroduce the verbose option for dependency:tree

[GitBox]

elharo commented on a change in pull request #92:
URL: 
https://github.com/apache/maven-dependency-plugin/pull/92#discussion_r466396456



##
File path: 
src/main/java/org/apache/maven/plugins/dependency/tree/verbose/OsProperties.java
##
@@ -0,0 +1,91 @@
+package org.apache.maven.plugins.dependency.tree.verbose;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+
+
+import java.util.HashMap;
+import java.util.Locale;
+import java.util.Map;
+
+/**
+ * Platform-dependent project properties normalized from ${os.name} and 
${os.arch}. Netty uses these to select
+ * system-specific dependencies through the
+ * os-maven-plugin.
+ */
+public class OsProperties

Review comment:
   does this need to be public? For that matter, is it used at all? I don't 
see where it's referenced. 

##
File path: 
src/main/java/org/apache/maven/plugins/dependency/tree/verbose/OsProperties.java
##
@@ -0,0 +1,91 @@
+package org.apache.maven.plugins.dependency.tree.verbose;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *  http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+

Review comment:
   remove extra blank lines





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172333#comment-17172333
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6965 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6965/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172331#comment-17172331
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6965 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6965/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172325#comment-17172325
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6952 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6952/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172323#comment-17172323
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6952 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6952/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (MRESOURCES-264) Parameter addDefaultExcludes with false does not copy .gitignore

[Jira]

[ 
https://issues.apache.org/jira/browse/MRESOURCES-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172308#comment-17172308
 ] 

Joël Royer edited comment on MRESOURCES-264 at 8/6/20, 12:38 PM:
-

I'm using maven-resource-plugin in a maven artefact, and I have a .gitignore in 
src/main/resources/archetypes-resources folder.

Here is my pom.xml:
{code:xml}

http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
 4.0.0

 com.foo.archetypes
 my-archetype
 1.0.0-SNAPSHOT
 maven-archetype

 
  UTF-8
  3.2.0
  3.1.0
 

 
  
   
org.apache.maven.archetype
archetype-packaging
${maven-archetype.version}
   
  

  
   

 org.apache.maven.plugins
 maven-resources-plugin
 ${maven-resources-plugin.version}
 
  false
 

   
  
 
{code}
Here is the fileset in archetype-metadata.xml:
{code:xml}

 
 
  .gitignore
  README.md
 
{code}
README.md file is well copied but not .gitignore.


was (Author: joelroyer):
I'm using maven-resource-plugin in a maven artefact, and I have a .gitignore in 
src/main/resources/archetypes-resources folder.

Here is my pom.xml:
{code:xml}

http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
 4.0.0

 com.foo.archetypes
 my-archetype
 1.0.0-SNAPSHOT
 maven-archetype

 
  UTF-8
  3.2.0
  3.1.0
 

 
  
   
org.apache.maven.archetype
archetype-packaging
${maven-archetype.version}
   
  

  
   

 org.apache.maven.plugins
 maven-resources-plugin
 ${maven-resources-plugin.version}
 
  false
 

   
  
 
{code}
Here is the fileset in archetype-metadata.xml:
{code:xml}

 
 
  .gitignore
  README.md
 
{code}
README file is well copied but not .gitignore.

> Parameter addDefaultExcludes with false does not copy .gitignore
> 
>
> Key: MRESOURCES-264
> URL: https://issues.apache.org/jira/browse/MRESOURCES-264
> Project: Maven Resources Plugin
>  Issue Type: Bug
>  Components: copy
>Affects Versions: 3.1.0
> Environment: CentOS 7 64bits, OpenJDK 11.0.7, Maven 3.6.3, Maven 
> Archetype Plugin 3.2.0
>Reporter: Joël Royer
>Priority: Major
>
> In a Maven archetype, I'm using the resource plugin to copy some files like a 
> .gitignore template. But this file is not copied when I generate a project 
> from this artefact.
> Here is my config for the resource plugin in my artefact:
> {code:java}
> 
>  org.apache.maven.plugins
>  maven-resources-plugin
>  3.1.0
>  
>   
>   
>   false
>  
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (MRESOURCES-264) Parameter addDefaultExcludes with false does not copy .gitignore

[Jira]

[ 
https://issues.apache.org/jira/browse/MRESOURCES-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172308#comment-17172308
 ] 

Joël Royer edited comment on MRESOURCES-264 at 8/6/20, 12:38 PM:
-

I'm using maven-resource-plugin in a maven artefact, and I have a .gitignore in 
src/main/resources/archetypes-resources folder.

Here is my pom.xml:
{code:xml}

http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
 4.0.0

 com.foo.archetypes
 my-archetype
 1.0.0-SNAPSHOT
 maven-archetype

 
  UTF-8
  3.2.0
  3.1.0
 

 
  
   
org.apache.maven.archetype
archetype-packaging
${maven-archetype.version}
   
  

  
   

 org.apache.maven.plugins
 maven-resources-plugin
 ${maven-resources-plugin.version}
 
  false
 

   
  
 
{code}
Here is the fileset in archetype-metadata.xml:
{code:xml}

 
 
  .gitignore
  README.md
 
{code}
README file is well copied but not .gitignore.


was (Author: joelroyer):
I'm using maven-resource-plugin in a maven artefact, and I have a .gitignore in 
src/main/resources/archetypes-resources folder.

Here is my pom.xml:
{code:xml}

http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
 4.0.0

 com.foo.archetypes
 my-archetype
 1.0.0-SNAPSHOT
 maven-archetype

 
  UTF-8
  3.2.0
  3.1.0
 

 
  
   
org.apache.maven.archetype
archetype-packaging
${maven-archetype.version}
   
  

  
   

 org.apache.maven.plugins
 maven-archetype-plugin
 ${maven-archetype.version}
 
  true
 



 org.apache.maven.plugins
 maven-resources-plugin
 ${maven-resources-plugin.version}
 
  false
 

   
  
 
{code}
Here is the fileset in archetype-metadata.xml:
{code:xml}

 
 
  .gitignore
  README.md
 
{code}
README file is well copied but not .gitignore.

> Parameter addDefaultExcludes with false does not copy .gitignore
> 
>
> Key: MRESOURCES-264
> URL: https://issues.apache.org/jira/browse/MRESOURCES-264
> Project: Maven Resources Plugin
>  Issue Type: Bug
>  Components: copy
>Affects Versions: 3.1.0
> Environment: CentOS 7 64bits, OpenJDK 11.0.7, Maven 3.6.3, Maven 
> Archetype Plugin 3.2.0
>Reporter: Joël Royer
>Priority: Major
>
> In a Maven archetype, I'm using the resource plugin to copy some files like a 
> .gitignore template. But this file is not copied when I generate a project 
> from this artefact.
> Here is my config for the resource plugin in my artefact:
> {code:java}
> 
>  org.apache.maven.plugins
>  maven-resources-plugin
>  3.1.0
>  
>   
>   
>   false
>  
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (MRESOURCES-264) Parameter addDefaultExcludes with false does not copy .gitignore

[Jira]

[ 
https://issues.apache.org/jira/browse/MRESOURCES-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172308#comment-17172308
 ] 

Joël Royer edited comment on MRESOURCES-264 at 8/6/20, 12:23 PM:
-

I'm using maven-resource-plugin in a maven artefact, and I have a .gitignore in 
src/main/resources/archetypes-resources folder.

Here is my pom.xml:
{code:xml}

http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
 4.0.0

 com.foo.archetypes
 my-archetype
 1.0.0-SNAPSHOT
 maven-archetype

 
  UTF-8
  3.2.0
  3.1.0
 

 
  
   
org.apache.maven.archetype
archetype-packaging
${maven-archetype.version}
   
  

  
   

 org.apache.maven.plugins
 maven-archetype-plugin
 ${maven-archetype.version}
 
  true
 



 org.apache.maven.plugins
 maven-resources-plugin
 ${maven-resources-plugin.version}
 
  false
 

   
  
 
{code}
Here is the fileset in archetype-metadata.xml:
{code:xml}

 
 
  .gitignore
  README.md
 
{code}
README file is well copied but not .gitignore.


was (Author: joelroyer):
I'm using maven-resource-plugin in a maven artefact, and I have a .gitignore in 
src/main/resources/archetypes-resources folder.

Here is my pom.xml:
{code:xml}

http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
 4.0.0

 com.foo.archetypes
 my-archetype
 1.0.0-SNAPSHOT
 maven-archetype

 
  UTF-8
  3.2.0
  3.1.0
 

 
  
   
org.apache.maven.archetype
archetype-packaging
${maven-archetype.version}
   
  

  
   

 org.apache.maven.plugins
 maven-archetype-plugin
 ${maven-archetype.version}
 
  true
 



 org.apache.maven.plugins
 maven-resources-plugin
 ${maven-resources-plugin.version}
 
  false
 

   
  
 
{code}
Here is the fileset in archetype-metadata.xml:
{code:xml}

 /
 
  .gitignore
  README.md
 
{code}
README file is well copied but not .gitignore.

> Parameter addDefaultExcludes with false does not copy .gitignore
> 
>
> Key: MRESOURCES-264
> URL: https://issues.apache.org/jira/browse/MRESOURCES-264
> Project: Maven Resources Plugin
>  Issue Type: Bug
>  Components: copy
>Affects Versions: 3.1.0
> Environment: CentOS 7 64bits, OpenJDK 11.0.7, Maven 3.6.3, Maven 
> Archetype Plugin 3.2.0
>Reporter: Joël Royer
>Priority: Major
>
> In a Maven archetype, I'm using the resource plugin to copy some files like a 
> .gitignore template. But this file is not copied when I generate a project 
> from this artefact.
> Here is my config for the resource plugin in my artefact:
> {code:java}
> 
>  org.apache.maven.plugins
>  maven-resources-plugin
>  3.1.0
>  
>   
>   
>   false
>  
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172314#comment-17172314
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6556 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6556/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172316#comment-17172316
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6556 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6556/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[GitHub] [maven-release] bguerin commented on pull request #56: [MRELEASE-1042] releaseProfiles get overriden by activeProfiles

[GitBox]

bguerin commented on pull request #56:
URL: https://github.com/apache/maven-release/pull/56#issuecomment-669893662


   This PR is a fix of a previous one : 
https://github.com/apache/maven-release/pull/50, where a new test was added :
   
https://github.com/apache/maven-release/pull/50/files#diff-1579aec6b35365b482da7a7e6b257f30R710
   
   Here, in this PR, I am also fixing the previously added test



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[jira] [Comment Edited] (MRESOURCES-264) Parameter addDefaultExcludes with false does not copy .gitignore

[Jira]

[ 
https://issues.apache.org/jira/browse/MRESOURCES-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172308#comment-17172308
 ] 

Joël Royer edited comment on MRESOURCES-264 at 8/6/20, 12:12 PM:
-

I'm using maven-resource-plugin in a maven artefact, and I have a .gitignore in 
src/main/resources/archetypes-resources folder.

Here is my pom.xml:
{code:xml}

http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
 4.0.0

 com.foo.archetypes
 my-archetype
 1.0.0-SNAPSHOT
 maven-archetype

 
  UTF-8
  3.2.0
  3.1.0
 

 
  
   
org.apache.maven.archetype
archetype-packaging
${maven-archetype.version}
   
  

  
   

 org.apache.maven.plugins
 maven-archetype-plugin
 ${maven-archetype.version}
 
  true
 



 org.apache.maven.plugins
 maven-resources-plugin
 ${maven-resources-plugin.version}
 
  false
 

   
  
 
{code}
Here is the fileset in archetype-metadata.xml:
{code:xml}

 /
 
  .gitignore
  README.md
 
{code}
README file is well copied but not .gitignore.


was (Author: joelroyer):
I'm using maven-resource-plugin in a maven artefact, and I have a .gitignore in 
src/main/resources/archetypes-resources folder.

Here is my pom.xml:
{code:xml}

http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
 4.0.0

 com.foo.archetypes
 my-archetype
 1.0.0-SNAPSHOT
 maven-archetype

 
  UTF-8
  3.2.0
  3.1.0
 

 
  
   
org.apache.maven.archetype
archetype-packaging
${maven-archetype.version}
   
  

  
   

 org.apache.maven.plugins
 maven-archetype-plugin
 ${maven-archetype.version}
 
  true
 



 org.apache.maven.plugins
 maven-resources-plugin
 ${maven-resources-plugin.version}
 
  false
 

   
  
 
{code}
Here is the fileset in archetype-metadata.xml:
{code:xml}

 /
 
  .gitignore
  README.md
 

{code}

> Parameter addDefaultExcludes with false does not copy .gitignore
> 
>
> Key: MRESOURCES-264
> URL: https://issues.apache.org/jira/browse/MRESOURCES-264
> Project: Maven Resources Plugin
>  Issue Type: Bug
>  Components: copy
>Affects Versions: 3.1.0
> Environment: CentOS 7 64bits, OpenJDK 11.0.7, Maven 3.6.3, Maven 
> Archetype Plugin 3.2.0
>Reporter: Joël Royer
>Priority: Major
>
> In a Maven archetype, I'm using the resource plugin to copy some files like a 
> .gitignore template. But this file is not copied when I generate a project 
> from this artefact.
> Here is my config for the resource plugin in my artefact:
> {code:java}
> 
>  org.apache.maven.plugins
>  maven-resources-plugin
>  3.1.0
>  
>   
>   
>   false
>  
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172311#comment-17172311
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MODELTESTS_IMPROVEMENT #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MODELTESTS_IMPROVEMENT/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MRESOURCES-264) Parameter addDefaultExcludes with false does not copy .gitignore

[Jira]

[ 
https://issues.apache.org/jira/browse/MRESOURCES-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172308#comment-17172308
 ] 

Joël Royer commented on MRESOURCES-264:
---

I'm using maven-resource-plugin in a maven artefact, and I have a .gitignore in 
src/main/resources/archetypes-resources folder. This

Here is my pom.xml:
{code:xml}

http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
 4.0.0

 com.foo.archetypes
 my-archetype
 1.0.0-SNAPSHOT
 maven-archetype

 
  UTF-8
  3.2.0
  3.1.0
 

 
  
   
org.apache.maven.archetype
archetype-packaging
${maven-archetype.version}
   
  

  
   

 org.apache.maven.plugins
 maven-archetype-plugin
 ${maven-archetype.version}
 
  true
 



 org.apache.maven.plugins
 maven-resources-plugin
 ${maven-resources-plugin.version}
 
  false
 

   
  
 
{code}
Here is the fileset in archetype-metadata.xml:
{code:xml}

 /
 
  .gitignore
  README.md
 

{code}

> Parameter addDefaultExcludes with false does not copy .gitignore
> 
>
> Key: MRESOURCES-264
> URL: https://issues.apache.org/jira/browse/MRESOURCES-264
> Project: Maven Resources Plugin
>  Issue Type: Bug
>  Components: copy
>Affects Versions: 3.1.0
> Environment: CentOS 7 64bits, OpenJDK 11.0.7, Maven 3.6.3, Maven 
> Archetype Plugin 3.2.0
>Reporter: Joël Royer
>Priority: Major
>
> In a Maven archetype, I'm using the resource plugin to copy some files like a 
> .gitignore template. But this file is not copied when I generate a project 
> from this artefact.
> Here is my config for the resource plugin in my artefact:
> {code:java}
> 
>  org.apache.maven.plugins
>  maven-resources-plugin
>  3.1.0
>  
>   
>   
>   false
>  
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Comment Edited] (MRESOURCES-264) Parameter addDefaultExcludes with false does not copy .gitignore

[Jira]

[ 
https://issues.apache.org/jira/browse/MRESOURCES-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172308#comment-17172308
 ] 

Joël Royer edited comment on MRESOURCES-264 at 8/6/20, 12:11 PM:
-

I'm using maven-resource-plugin in a maven artefact, and I have a .gitignore in 
src/main/resources/archetypes-resources folder.

Here is my pom.xml:
{code:xml}

http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
 4.0.0

 com.foo.archetypes
 my-archetype
 1.0.0-SNAPSHOT
 maven-archetype

 
  UTF-8
  3.2.0
  3.1.0
 

 
  
   
org.apache.maven.archetype
archetype-packaging
${maven-archetype.version}
   
  

  
   

 org.apache.maven.plugins
 maven-archetype-plugin
 ${maven-archetype.version}
 
  true
 



 org.apache.maven.plugins
 maven-resources-plugin
 ${maven-resources-plugin.version}
 
  false
 

   
  
 
{code}
Here is the fileset in archetype-metadata.xml:
{code:xml}

 /
 
  .gitignore
  README.md
 

{code}


was (Author: joelroyer):
I'm using maven-resource-plugin in a maven artefact, and I have a .gitignore in 
src/main/resources/archetypes-resources folder. This

Here is my pom.xml:
{code:xml}

http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; 
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
 4.0.0

 com.foo.archetypes
 my-archetype
 1.0.0-SNAPSHOT
 maven-archetype

 
  UTF-8
  3.2.0
  3.1.0
 

 
  
   
org.apache.maven.archetype
archetype-packaging
${maven-archetype.version}
   
  

  
   

 org.apache.maven.plugins
 maven-archetype-plugin
 ${maven-archetype.version}
 
  true
 



 org.apache.maven.plugins
 maven-resources-plugin
 ${maven-resources-plugin.version}
 
  false
 

   
  
 
{code}
Here is the fileset in archetype-metadata.xml:
{code:xml}

 /
 
  .gitignore
  README.md
 

{code}

> Parameter addDefaultExcludes with false does not copy .gitignore
> 
>
> Key: MRESOURCES-264
> URL: https://issues.apache.org/jira/browse/MRESOURCES-264
> Project: Maven Resources Plugin
>  Issue Type: Bug
>  Components: copy
>Affects Versions: 3.1.0
> Environment: CentOS 7 64bits, OpenJDK 11.0.7, Maven 3.6.3, Maven 
> Archetype Plugin 3.2.0
>Reporter: Joël Royer
>Priority: Major
>
> In a Maven archetype, I'm using the resource plugin to copy some files like a 
> .gitignore template. But this file is not copied when I generate a project 
> from this artefact.
> Here is my config for the resource plugin in my artefact:
> {code:java}
> 
>  org.apache.maven.plugins
>  maven-resources-plugin
>  3.1.0
>  
>   
>   
>   false
>  
> 
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172309#comment-17172309
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MODELTESTS_IMPROVEMENT #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MODELTESTS_IMPROVEMENT/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172292#comment-17172292
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6909 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6909/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172290#comment-17172290
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6909 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6909/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172288#comment-17172288
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6512-build-11 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6512-build-11/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172286#comment-17172286
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6512-build-11 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6512-build-11/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172282#comment-17172282
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MRESOLVER-94 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MRESOLVER-94/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172284#comment-17172284
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MRESOLVER-94 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MRESOLVER-94/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172271#comment-17172271
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6553 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6553/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172269#comment-17172269
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6553 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6553/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172260#comment-17172260
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6552 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6552/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172262#comment-17172262
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6552 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6552/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172254#comment-17172254
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6551 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6551/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172252#comment-17172252
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6551 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6551/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172247#comment-17172247
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6555 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6555/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172245#comment-17172245
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6555 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6555/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172234#comment-17172234
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6554 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6554/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172232#comment-17172232
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6554 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6554/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172220#comment-17172220
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6550 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6550/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1717#comment-1717
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6169/MNG-6550 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6169%252FMNG-6550/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172211#comment-17172211
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6889 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6889/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172209#comment-17172209
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6889 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6889/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172202#comment-17172202
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6548 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6548/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172200#comment-17172200
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6548 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6548/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172183#comment-17172183
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6888 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6888/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172181#comment-17172181
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6888 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6888/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6972) Allow access to org.apache.maven.graph

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172176#comment-17172176
 ] 

Hudson commented on MNG-6972:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-5567 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-5567/5/

> Allow access to org.apache.maven.graph
> --
>
> Key: MNG-6972
> URL: https://issues.apache.org/jira/browse/MNG-6972
> Project: Maven
>  Issue Type: Improvement
>  Components: Class Loading, Plugin API
>Affects Versions: 3.6.3
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: easyfix, pull-request-available
> Fix For: 3.7.0
>
>
> Hi
> maven doesn't export org.apache.maven.graph package in 
> maven-core/src/main/resources/META-INF/maven/extension.xml so the 
> GraphBuilder is not usable in extensions.
> {code:java}
> // leads to java.lang.NoClassDefFoundError: 
> Lorg/apache/maven/graph/GraphBuilder;
> @Requirement( hint = GraphBuilder.HINT )
> private GraphBuilder graphBuilder;
> {code}
> Background: if one build extension adds dependencies and another build 
> extension uses {{session.getProjectDependencyGraph()}}, then the dependency 
> graph is out of date. This is because the graph is only rebuilt after 
> executing _all_ extensions. One solution to this would be to update the 
> {{MavenSession}} and setting the new dependency graph in the first extension, 
> but for this we need access to the {{GraphBuilder}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172174#comment-17172174
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-5567 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-5567/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MNG-6974) IT for MNG-5175 (Wagon HTTP) fails with JDK 14

[Hudson (Jira)]

[ 
https://issues.apache.org/jira/browse/MNG-6974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17172163#comment-17172163
 ] 

Hudson commented on MNG-6974:
-

Build unstable in Jenkins: Maven » Maven TLP » maven » MNG-6829 #5

See 
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-6829/5/

> IT for MNG-5175 (Wagon HTTP) fails with JDK 14
> --
>
> Key: MNG-6974
> URL: https://issues.apache.org/jira/browse/MNG-6974
> Project: Maven
>  Issue Type: Bug
>  Components: Integration Tests
>Reporter: Michael Kroll
>Assignee: Michael Osipov
>Priority: Major
>  Labels: pull-request-available, test
>
> [ERROR] Tests run: 846, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 
> 210.078 s <<< FAILURE! - in org.apache.maven.it.IntegrationTestSuite
> [ERROR] 
> testmng5175_ReadTimeOutFromSettings(org.apache.maven.it.MavenITmng5175WagonHttpTest)
>   Time elapsed: 0.166 s  <<< ERROR!
> org.apache.maven.it.VerificationException: Text not found in log: Could not 
> transfer artifact 
> org.apache.maven.its.mng5175:fake-dependency:pom:1.0-SNAPSHOT
>   at 
> org.apache.maven.it.MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings(MavenITmng5175WagonHttpTest.java:128)
> https://github.com/apache/maven/pull/368/checks?check_run_id=941247515



--
This message was sent by Atlassian Jira
(v8.3.4#803005)