[jira] [Commented] (SUREFIRE-1854) Support include/exclude junit test engine
[ https://issues.apache.org/jira/browse/SUREFIRE-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217333#comment-17217333 ] Adam commented on SUREFIRE-1854: [~tibordigana] , this what you sent is inclusion and exclusion of tests, not test engines :) JUnit options: -e, --include-engine=ID Provide the ID of an engine to be included in the test run. This option can be repeated. -E, --exclude-engine=ID Provide the ID of an engine to be excluded from the test run. This option can be repeated. > Support include/exclude junit test engine > - > > Key: SUREFIRE-1854 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1854 > Project: Maven Surefire > Issue Type: New Feature > Components: JUnit 5.x support, Maven Surefire Plugin >Affects Versions: 2.22.2 >Reporter: Adam >Priority: Major > > It could be very important for my project to support include/exclude junit > test engine by Maven Surefire Plugin. > Junit Console Launcher have existing support for this: > [https://junit.org/junit5/docs/current/user-guide/#running-tests-console-launcher-options] > Similar solution exists for Gradle: > https://junit.org/junit5/docs/current/user-guide/#running-tests-build-gradle -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (SUREFIRE-1854) Support include/exclude junit test engine
[ https://issues.apache.org/jira/browse/SUREFIRE-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217157#comment-17217157 ] Tibor Digana commented on SUREFIRE-1854: Can you write a test for this and show me what's going on? Here is the tutorial https://maven.apache.org/surefire/maven-surefire-plugin/examples/inclusion-exclusion.html > Support include/exclude junit test engine > - > > Key: SUREFIRE-1854 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1854 > Project: Maven Surefire > Issue Type: New Feature > Components: JUnit 5.x support, Maven Surefire Plugin >Affects Versions: 2.22.2 >Reporter: Adam >Priority: Major > > It could be very important for my project to support include/exclude junit > test engine by Maven Surefire Plugin. > Junit Console Launcher have existing support for this: > [https://junit.org/junit5/docs/current/user-guide/#running-tests-console-launcher-options] > Similar solution exists for Gradle: > https://junit.org/junit5/docs/current/user-guide/#running-tests-build-gradle -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-doxia-converter] asfgit closed pull request #6: update JUnit dependency
asfgit closed pull request #6: URL: https://github.com/apache/maven-doxia-converter/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-converter] asfgit closed pull request #4: Bump jacoco-maven-plugin from 0.8.5 to 0.8.6
asfgit closed pull request #4: URL: https://github.com/apache/maven-doxia-converter/pull/4 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-converter] dependabot[bot] commented on pull request #5: Bump junit from 4.13 to 4.13.1
dependabot[bot] commented on pull request #5: URL: https://github.com/apache/maven-doxia-converter/pull/5#issuecomment-712400448 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-converter] asfgit closed pull request #5: Bump junit from 4.13 to 4.13.1
asfgit closed pull request #5: URL: https://github.com/apache/maven-doxia-converter/pull/5 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-converter] dependabot[bot] commented on pull request #4: Bump jacoco-maven-plugin from 0.8.5 to 0.8.6
dependabot[bot] commented on pull request #4: URL: https://github.com/apache/maven-doxia-converter/pull/4#issuecomment-712400375 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia-converter] georgiosmakrhs opened a new pull request #6: update JUnit dependency
georgiosmakrhs opened a new pull request #6: URL: https://github.com/apache/maven-doxia-converter/pull/6 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7002) Extend DefaultGraphBuilder unit tests to cover that child projects get included with the --pl switch
Martin Kanters created MNG-7002: --- Summary: Extend DefaultGraphBuilder unit tests to cover that child projects get included with the --pl switch Key: MNG-7002 URL: https://issues.apache.org/jira/browse/MNG-7002 Project: Maven Issue Type: Improvement Components: Reactor and workspace Reporter: Martin Kanters MNG-6981 was recently merged in master and is only covered in integration tests. Since [DefaultGraphBuilderTest|https://github.com/apache/maven/blob/master/maven-core/src/test/java/org/apache/maven/graph/DefaultGraphBuilderTest.java] now contains a multi module structure this flow can be tested in unit tests, offering developers quicker feedback during development. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6981) Add --recursive option
[
https://issues.apache.org/jira/browse/MNG-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17217009#comment-17217009
]
Martin Kanters commented on MNG-6981:
-
Merged in master with
[42af8ba5a21dc085d065cfa0b4c5557fb40ad7ac|https://github.com/apache/maven/commit/42af8ba5a21dc085d065cfa0b4c5557fb40ad7ac]
> Add --recursive option
> --
>
> Key: MNG-6981
> URL: https://issues.apache.org/jira/browse/MNG-6981
> Project: Maven
> Issue Type: New Feature
> Components: Command Line
>Affects Versions: 3.6.3
>Reporter: Knut Wannheden
>Assignee: Martin Kanters
>Priority: Minor
> Fix For: 3.7.0
>
>
> Since there is already a {{\--non-recursive}} option a new {{\--recursive}}
> option might be confusing, but let me explain my use case. I often use the
> {{-pl}} option and in a multi-module Maven project with more than just two
> "levels", I would like to be able to build a project (or set of projects)
> including all child-modules. This is, AFAIK, currently not possible and what
> I would like to use the new {{\--recursive}} (or similar) option for.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (MNG-6981) Add --recursive option
[
https://issues.apache.org/jira/browse/MNG-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters resolved MNG-6981.
-
Resolution: Implemented
> Add --recursive option
> --
>
> Key: MNG-6981
> URL: https://issues.apache.org/jira/browse/MNG-6981
> Project: Maven
> Issue Type: New Feature
> Components: Command Line
>Affects Versions: 3.6.3
>Reporter: Knut Wannheden
>Assignee: Martin Kanters
>Priority: Minor
> Fix For: 3.7.0
>
>
> Since there is already a {{\--non-recursive}} option a new {{\--recursive}}
> option might be confusing, but let me explain my use case. I often use the
> {{-pl}} option and in a multi-module Maven project with more than just two
> "levels", I would like to be able to build a project (or set of projects)
> including all child-modules. This is, AFAIK, currently not possible and what
> I would like to use the new {{\--recursive}} (or similar) option for.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-6981) Add --recursive option
[
https://issues.apache.org/jira/browse/MNG-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters updated MNG-6981:
Priority: Minor (was: Major)
> Add --recursive option
> --
>
> Key: MNG-6981
> URL: https://issues.apache.org/jira/browse/MNG-6981
> Project: Maven
> Issue Type: New Feature
> Components: Command Line
>Affects Versions: 3.6.3
>Reporter: Knut Wannheden
>Assignee: Martin Kanters
>Priority: Minor
>
> Since there is already a {{\--non-recursive}} option a new {{\--recursive}}
> option might be confusing, but let me explain my use case. I often use the
> {{-pl}} option and in a multi-module Maven project with more than just two
> "levels", I would like to be able to build a project (or set of projects)
> including all child-modules. This is, AFAIK, currently not possible and what
> I would like to use the new {{\--recursive}} (or similar) option for.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (MNG-6981) Add --recursive option
[
https://issues.apache.org/jira/browse/MNG-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters reassigned MNG-6981:
---
Assignee: Martin Kanters
> Add --recursive option
> --
>
> Key: MNG-6981
> URL: https://issues.apache.org/jira/browse/MNG-6981
> Project: Maven
> Issue Type: New Feature
> Components: Command Line
>Affects Versions: 3.6.3
>Reporter: Knut Wannheden
>Assignee: Martin Kanters
>Priority: Major
>
> Since there is already a {{\--non-recursive}} option a new {{\--recursive}}
> option might be confusing, but let me explain my use case. I often use the
> {{-pl}} option and in a multi-module Maven project with more than just two
> "levels", I would like to be able to build a project (or set of projects)
> including all child-modules. This is, AFAIK, currently not possible and what
> I would like to use the new {{\--recursive}} (or similar) option for.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-6981) Add --recursive option
[
https://issues.apache.org/jira/browse/MNG-6981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters updated MNG-6981:
Fix Version/s: 3.7.0
> Add --recursive option
> --
>
> Key: MNG-6981
> URL: https://issues.apache.org/jira/browse/MNG-6981
> Project: Maven
> Issue Type: New Feature
> Components: Command Line
>Affects Versions: 3.6.3
>Reporter: Knut Wannheden
>Assignee: Martin Kanters
>Priority: Minor
> Fix For: 3.7.0
>
>
> Since there is already a {{\--non-recursive}} option a new {{\--recursive}}
> option might be confusing, but let me explain my use case. I often use the
> {{-pl}} option and in a multi-module Maven project with more than just two
> "levels", I would like to be able to build a project (or set of projects)
> including all child-modules. This is, AFAIK, currently not possible and what
> I would like to use the new {{\--recursive}} (or similar) option for.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[GitHub] [maven] MartinKanters closed pull request #374: [MNG-6981] Include child projects of projects selected with --pl
MartinKanters closed pull request #374: URL: https://github.com/apache/maven/pull/374 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] MartinKanters closed pull request #71: [MNG-6981] Include child projects of projects selected with --pl
MartinKanters closed pull request #71: URL: https://github.com/apache/maven-integration-testing/pull/71 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MNG-6118) Add option to execute goals on a specific module while building a multimodule project
[
https://issues.apache.org/jira/browse/MNG-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters resolved MNG-6118.
-
Resolution: Implemented
> Add option to execute goals on a specific module while building a multimodule
> project
> -
>
> Key: MNG-6118
> URL: https://issues.apache.org/jira/browse/MNG-6118
> Project: Maven
> Issue Type: Improvement
> Components: Command Line, Plugins and Lifecycle
>Reporter: Robert Scholte
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 3.7.0
>
>
> Suppose we have a multimodule which results in a war. In the end we want to
> run this war in a container like jetty. Up until now the {{jetty:run}} is
> executed on every module, which doesn't make sense for the other modules.
> This is just one of several examples where you want to control on which
> module to execute a specific goal. In case of wars, the plugin could check
> for the packaging type, but in case of jars this won't work.
> There should be a generic solution to mark goals for a specific module.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MNG-6118) Add option to execute goals on a specific module while building a multimodule project
[
https://issues.apache.org/jira/browse/MNG-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters updated MNG-6118:
Fix Version/s: 3.7.0
> Add option to execute goals on a specific module while building a multimodule
> project
> -
>
> Key: MNG-6118
> URL: https://issues.apache.org/jira/browse/MNG-6118
> Project: Maven
> Issue Type: Improvement
> Components: Command Line, Plugins and Lifecycle
>Reporter: Robert Scholte
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 3.7.0
>
>
> Suppose we have a multimodule which results in a war. In the end we want to
> run this war in a container like jetty. Up until now the {{jetty:run}} is
> executed on every module, which doesn't make sense for the other modules.
> This is just one of several examples where you want to control on which
> module to execute a specific goal. In case of wars, the plugin could check
> for the packaging type, but in case of jars this won't work.
> There should be a generic solution to mark goals for a specific module.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (MNG-6118) Add option to execute goals on a specific module while building a multimodule project
[
https://issues.apache.org/jira/browse/MNG-6118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Martin Kanters reassigned MNG-6118:
---
Assignee: Martin Kanters
> Add option to execute goals on a specific module while building a multimodule
> project
> -
>
> Key: MNG-6118
> URL: https://issues.apache.org/jira/browse/MNG-6118
> Project: Maven
> Issue Type: Improvement
> Components: Command Line, Plugins and Lifecycle
>Reporter: Robert Scholte
>Assignee: Martin Kanters
>Priority: Major
>
> Suppose we have a multimodule which results in a war. In the end we want to
> run this war in a container like jetty. Up until now the {{jetty:run}} is
> executed on every module, which doesn't make sense for the other modules.
> This is just one of several examples where you want to control on which
> module to execute a specific goal. In case of wars, the plugin could check
> for the packaging type, but in case of jars this won't work.
> There should be a generic solution to mark goals for a specific module.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (DOXIASITETOOLS-226) Use latest JUnit version 4.13.1
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned DOXIASITETOOLS-226: --- Assignee: Sylwester Lachiewicz > Use latest JUnit version 4.13.1 > --- > > Key: DOXIASITETOOLS-226 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-226 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Affects Versions: 1.9.3 >Reporter: Georgios Makris >Assignee: Sylwester Lachiewicz >Priority: Trivial > > Update JUnit dependency to current latest version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (DOXIASITETOOLS-226) Use latest JUnit version 4.13.1
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated DOXIASITETOOLS-226: Fix Version/s: 1.9.3 > Use latest JUnit version 4.13.1 > --- > > Key: DOXIASITETOOLS-226 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-226 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Affects Versions: 1.9.3 >Reporter: Georgios Makris >Assignee: Sylwester Lachiewicz >Priority: Trivial > Fix For: 1.9.3 > > > Update JUnit dependency to current latest version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (DOXIASITETOOLS-226) Use latest JUnit version 4.13.1
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz closed DOXIASITETOOLS-226.
---
Resolution: Fixed
> Use latest JUnit version 4.13.1
> ---
>
> Key: DOXIASITETOOLS-226
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-226
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Affects Versions: 1.9.3
>Reporter: Georgios Makris
>Assignee: Sylwester Lachiewicz
>Priority: Trivial
> Fix For: 1.9.3
>
>
> Update JUnit dependency to current latest version.
>
> h3. Security fix: {{TemporaryFolder}} now limits access to temporary folders
> on Java 1.7 or later
> A local information disclosure vulnerability in {{TemporaryFolder}} has been
> fixed. See the published [security
> advisory|https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp]
> for details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (DOXIASITETOOLS-226) Use latest JUnit version 4.13.1
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated DOXIASITETOOLS-226:
Description:
Update JUnit dependency to current latest version.
h3. Security fix: {{TemporaryFolder}} now limits access to temporary folders on
Java 1.7 or later
A local information disclosure vulnerability in {{TemporaryFolder}} has been
fixed. See the published [security
advisory|https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp]
for details.
was:Update JUnit dependency to current latest version.
> Use latest JUnit version 4.13.1
> ---
>
> Key: DOXIASITETOOLS-226
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-226
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Affects Versions: 1.9.3
>Reporter: Georgios Makris
>Assignee: Sylwester Lachiewicz
>Priority: Trivial
> Fix For: 1.9.3
>
>
> Update JUnit dependency to current latest version.
>
> h3. Security fix: {{TemporaryFolder}} now limits access to temporary folders
> on Java 1.7 or later
> A local information disclosure vulnerability in {{TemporaryFolder}} has been
> fixed. See the published [security
> advisory|https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp]
> for details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (WAGON-601) Use latest JUnit version 4.13.1
[
https://issues.apache.org/jira/browse/WAGON-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated WAGON-601:
---
Fix Version/s: 3.4.2
> Use latest JUnit version 4.13.1
> ---
>
> Key: WAGON-601
> URL: https://issues.apache.org/jira/browse/WAGON-601
> Project: Maven Wagon
> Issue Type: Dependency upgrade
>Reporter: Georgios Makris
>Assignee: Sylwester Lachiewicz
>Priority: Trivial
> Fix For: 3.4.2
>
>
> Update JUnit dependency to current latest version.
>
> h3. Security fix: {{TemporaryFolder}} now limits access to temporary folders
> on Java 1.7 or later
> A local information disclosure vulnerability in {{TemporaryFolder}} has been
> fixed. See the published [security
> advisory|https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp]
> for details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (WAGON-601) Use latest JUnit version 4.13.1
[
https://issues.apache.org/jira/browse/WAGON-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated WAGON-601:
---
Description:
Update JUnit dependency to current latest version.
h3. Security fix: {{TemporaryFolder}} now limits access to temporary folders on
Java 1.7 or later
A local information disclosure vulnerability in {{TemporaryFolder}} has been
fixed. See the published [security
advisory|https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp]
for details.
was:Update JUnit dependency to current latest version.
> Use latest JUnit version 4.13.1
> ---
>
> Key: WAGON-601
> URL: https://issues.apache.org/jira/browse/WAGON-601
> Project: Maven Wagon
> Issue Type: Dependency upgrade
>Reporter: Georgios Makris
>Assignee: Sylwester Lachiewicz
>Priority: Trivial
>
> Update JUnit dependency to current latest version.
>
> h3. Security fix: {{TemporaryFolder}} now limits access to temporary folders
> on Java 1.7 or later
> A local information disclosure vulnerability in {{TemporaryFolder}} has been
> fixed. See the published [security
> advisory|https://github.com/junit-team/junit4/security/advisories/GHSA-269g-pwp5-87pp]
> for details.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (WAGON-601) Use latest JUnit version 4.13.1
[ https://issues.apache.org/jira/browse/WAGON-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned WAGON-601: -- Assignee: Sylwester Lachiewicz > Use latest JUnit version 4.13.1 > --- > > Key: WAGON-601 > URL: https://issues.apache.org/jira/browse/WAGON-601 > Project: Maven Wagon > Issue Type: Dependency upgrade >Reporter: Georgios Makris >Assignee: Sylwester Lachiewicz >Priority: Trivial > > Update JUnit dependency to current latest version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHADE-148) Shade Plugin gets stuck in infinite loop building dependency reduced POM
[ https://issues.apache.org/jira/browse/MSHADE-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216828#comment-17216828 ] maobaolong commented on MSHADE-148: --- I think this issue is not fixed before merge the https://github.com/apache/maven-shade-plugin/pull/16 , is there anyone want to discuss with this PR? its look good to me. > Shade Plugin gets stuck in infinite loop building dependency reduced POM > > > Key: MSHADE-148 > URL: https://issues.apache.org/jira/browse/MSHADE-148 > Project: Maven Shade Plugin > Issue Type: Bug >Affects Versions: 2.1 > Environment: OS X 10.7.5 >Reporter: Rob Vesse >Assignee: Karl Heinz Marbaise >Priority: Major > Fix For: 2.4.1 > > Attachments: MSHADE-148.patch, dependency-reduced-pom.xml, > mshade-148-reproduction-pom.xml, pom.xml, shade-bug.txt > > Time Spent: 10m > Remaining Estimate: 0h > > I have encountered a bug whereby the shade plugin gets stuck in an infinite > loop in the step of creating a dependency reduced POM. > I have attached a minimal POM that reproduces the issue and done some > debugging on this. The problem seems to be caused by using both the jar and > test-jar version of a dependency (jena-fuseki in my example) while also > including a jar dependency that is a transitive dependency of the other > dependencies (jena-arq in my example). Removing either the jar/test-jar > resolves the problem and so does removing the other jar dependency. > The problem appears to be that the plugin is getting stuck endlessly trying > to produce the dependency-reduced-pom.xml > If I watch the file over time it is repeatedly deleted and rewritten, each > time it is written it gets larger. When I manage to kill the process at a > point where the file is non-empty I can see that the plugin is endlessly > adding the same set of to one of the jena-fuseki dependencies. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on a change in pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507838067
##
File path: src/site/apt/examples/skinny-modules.apt.vm
##
@@ -0,0 +1,191 @@
+ --
+ Creating Skinny Modules
+ --
+ Marat Abrarov
+ --
+ 2020-10-18
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/doxia/references/apt-format.html
+
+Creating Skinny Modules
+
+ This is a bit like {{{./skinny-wars.html}skinny WARs}}, but taken to the
+ next level and applied to EAR modules of type:
+
+ * {{{../modules.html#webModule}WAR}}
+
+ * {{{../modules.html#rarModule}RAR}}
+
+ * {{{../modules.html#wsrModule}WSR}}
+
+ * {{{../modules.html#sarModule}SAR}}
+
+ * {{{../modules.html#harModule}HAR}}
+
+ Starting with version 3.1.1 Maven EAR Plugin supports referencing
+ external JARs packaged within the EAR via the <<>> setting
+ in EAR module <<>>.
+
+ We need to change the EAR project's <<>> to package those JARs
+ in the EAR and to use the
+ {{{../ear-mojo.html#skinnyModules}skinnyModules}} parameter.
+
+ <> In this example we package all JARs into a <<>> directory
+ within the EAR. This is just to distinguish between Java EE modules
+ (which will be packaged in the root of the EAR) and Java libraries
+ (which are packaged in <<>>). Also, we use non standard
+ <<>> just to shorten names of files packaged
Review comment:
Addressed in 83a46e0
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on a change in pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507837865
##
File path: src/site/apt/examples/skinny-modules.apt.vm
##
@@ -0,0 +1,191 @@
+ --
+ Creating Skinny Modules
+ --
+ Marat Abrarov
+ --
+ 2020-10-18
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/doxia/references/apt-format.html
+
+Creating Skinny Modules
+
+ This is a bit like {{{./skinny-wars.html}skinny WARs}}, but taken to the
+ next level and applied to EAR modules of type:
+
+ * {{{../modules.html#webModule}WAR}}
+
+ * {{{../modules.html#rarModule}RAR}}
+
+ * {{{../modules.html#wsrModule}WSR}}
+
+ * {{{../modules.html#sarModule}SAR}}
+
+ * {{{../modules.html#harModule}HAR}}
+
+ Starting with version 3.1.1 Maven EAR Plugin supports referencing
Review comment:
Addressed in 83a46e0
##
File path: src/site/apt/examples/skinny-modules.apt.vm
##
@@ -0,0 +1,191 @@
+ --
+ Creating Skinny Modules
+ --
+ Marat Abrarov
+ --
+ 2020-10-18
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/doxia/references/apt-format.html
+
+Creating Skinny Modules
+
+ This is a bit like {{{./skinny-wars.html}skinny WARs}}, but taken to the
+ next level and applied to EAR modules of type:
+
+ * {{{../modules.html#webModule}WAR}}
+
+ * {{{../modules.html#rarModule}RAR}}
+
+ * {{{../modules.html#wsrModule}WSR}}
+
+ * {{{../modules.html#sarModule}SAR}}
+
+ * {{{../modules.html#harModule}HAR}}
+
+ Starting with version 3.1.1 Maven EAR Plugin supports referencing
Review comment:
Addressed in 83a46e0
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on a change in pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507837640
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -739,6 +751,11 @@ public boolean isNonFilteredExtension( String fileName )
private void changeManifestClasspath( EarModule module, File original,
JavaEEVersion javaEEVersion )
throws MojoFailureException
{
+final String moduleLibDir = module.getLibDir();
+if ( !( moduleLibDir == null || skinnyModules || skinnyWars && module
instanceof WebModule ) )
Review comment:
Addressed in 83a46e0
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -799,16 +816,16 @@ private void changeManifestClasspath( EarModule module,
File original, JavaEEVer
classPath = new Attribute( "Class-Path", "" );
}
-// Remove JAR modules
-for ( JarModule jm : getAllJarModules() )
+if ( moduleLibDir != null && ( skinnyModules || skinnyWars &&
module instanceof WebModule ) )
Review comment:
Addressed in 83a46e0
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-6995) Support core extensions in modules of aggregator projects
[ https://issues.apache.org/jira/browse/MNG-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216783#comment-17216783 ] Igor Fedorenko commented on MNG-6995: - Maven would need to read the aggregator pom in order to find all modules being aggregated and their respective configured Core Extensions. This alone would require non-trivial changes to how Maven Core, Core Extensions and aggregator pom interact. "Mutually exclusive" extensions are very likely to result in subtle build inconsistencies, e.g., stale build output files are not regenerated in _some_ cases, or build failures that happen depending on build order and timing. I don't see this as an acceptable failure mode for generally available Maven feature. > Support core extensions in modules of aggregator projects > - > > Key: MNG-6995 > URL: https://issues.apache.org/jira/browse/MNG-6995 > Project: Maven > Issue Type: New Feature > Components: Class Loading >Affects Versions: 3.6.3 >Reporter: mike duigou >Priority: Major > > If you have defined core extensions using the MNG-5771 .mvn/extensions.xml > mechanism and then include the module in an aggregator pom the extensions > will currently be ignored. Only extensions defined in same directory as the > aggregator pom will be used and those extensions will not be invoked for the > modules, only for the aggregator itself. > Ideally modules should build with whatever core extensions they have defined. > Building a module as part of an aggregator should behave not differently than > building the module standalone. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MNG-6995) Support core extensions in modules of aggregator projects
[ https://issues.apache.org/jira/browse/MNG-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216768#comment-17216768 ] Matthieu Brouillard edited comment on MNG-6995 at 10/19/20, 2:29 PM: - > but also means Core Extensions resolution and instantiation cannot rely on > anything in pom.xml nothing related to this ticket requires anything in a pom file > Core Extensions are global to the build that's the point with this ticket and the aggregator pom. > aggregator project can conceivably include modules with mutually exclusive > extensions But here we are not talking about "mutually exclusive" extensions, this could be left to the end user to use extensions that are not colliding to each others. We are "just" asking if core-extensions could be activated while loading/resolving the POM for the reactor. was (Author: mcfoggy): > but also means Core Extensions resolution and instantiation cannot rely on > anything in pom.xml nothing related to this ticket requires anything in a pom file > Core Extensions are global to the build that's the point with this ticket and the aggregator pom. > aggregator project can conceivably include modules with mutually exclusive > extensions You probably meant `cannot`. But here we are not talking about "mutually exclusive" extensions, this could be left to the end user to use extensions that are not colliding to each others. We are "just" asking if core-extensions could be activated while loading/resolving the POM for the reactor. > Support core extensions in modules of aggregator projects > - > > Key: MNG-6995 > URL: https://issues.apache.org/jira/browse/MNG-6995 > Project: Maven > Issue Type: New Feature > Components: Class Loading >Affects Versions: 3.6.3 >Reporter: mike duigou >Priority: Major > > If you have defined core extensions using the MNG-5771 .mvn/extensions.xml > mechanism and then include the module in an aggregator pom the extensions > will currently be ignored. Only extensions defined in same directory as the > aggregator pom will be used and those extensions will not be invoked for the > modules, only for the aggregator itself. > Ideally modules should build with whatever core extensions they have defined. > Building a module as part of an aggregator should behave not differently than > building the module standalone. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MNG-6995) Support core extensions in modules of aggregator projects
[ https://issues.apache.org/jira/browse/MNG-6995?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216768#comment-17216768 ] Matthieu Brouillard commented on MNG-6995: -- > but also means Core Extensions resolution and instantiation cannot rely on > anything in pom.xml nothing related to this ticket requires anything in a pom file > Core Extensions are global to the build that's the point with this ticket and the aggregator pom. > aggregator project can conceivably include modules with mutually exclusive > extensions You probably meant `cannot`. But here we are not talking about "mutually exclusive" extensions, this could be left to the end user to use extensions that are not colliding to each others. We are "just" asking if core-extensions could be activated while loading/resolving the POM for the reactor. > Support core extensions in modules of aggregator projects > - > > Key: MNG-6995 > URL: https://issues.apache.org/jira/browse/MNG-6995 > Project: Maven > Issue Type: New Feature > Components: Class Loading >Affects Versions: 3.6.3 >Reporter: mike duigou >Priority: Major > > If you have defined core extensions using the MNG-5771 .mvn/extensions.xml > mechanism and then include the module in an aggregator pom the extensions > will currently be ignored. Only extensions defined in same directory as the > aggregator pom will be used and those extensions will not be invoked for the > modules, only for the aggregator itself. > Ideally modules should build with whatever core extensions they have defined. > Building a module as part of an aggregator should behave not differently than > building the module standalone. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on a change in pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507723769
##
File path: src/main/java/org/apache/maven/plugins/ear/EarModule.java
##
@@ -114,7 +114,8 @@ void resolveArtifact( Set artifacts )
boolean changeManifestClasspath();
/**
- * @return The libDir.
+ * @return The directory of module which contains JAR libraries packaged
within module. Can be {@code null},
Review comment:
Addressed in 83a46e0
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on a change in pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507723916 ## File path: src/main/java/org/apache/maven/plugins/ear/AbstractEarModule.java ## @@ -360,34 +374,34 @@ public String toString() } /** - * Cleans the bundle directory so that it might be used properly. + * Cleans the path pointing to resource inside archive so that it might be used properly. Review comment: Addressed in 83a46e0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on a change in pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507724100
##
File path: src/main/java/org/apache/maven/plugins/ear/AbstractEarModule.java
##
@@ -91,6 +91,14 @@
private String moduleId;
+/**
+ * Directory of module which contains libraries packaged into module.
{@code null} value means that module
+ * doesn't contain any library. Each module type can provide default value
for this directory and this option
+ * can be used to override that default value. If module libraries are
located at the root of module then use
+ * single slash (/) to configure that in POM, i.e. single slash is treated
as empty string.
Review comment:
Addressed in 83a46e0
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on a change in pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507723262
##
File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java
##
@@ -211,6 +211,18 @@
@Parameter( defaultValue = "false" )
private boolean skinnyWars;
+/**
+ * Whether to create skinny EAR modules or not. A skinny EAR module is a
WAR, SAR, HAR, RAR or WSR module that
+ * does not have all of its dependencies in it. Instead those dependencies
are shared between the WARs, SARs, HARs,
+ * RARs and WSRs through the EAR. This option takes precedence over {@link
#skinnyWars} option, i.e. if
Review comment:
Addressed in 83a46e0
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on a change in pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507723416 ## File path: src/main/java/org/apache/maven/plugins/ear/EarMojo.java ## @@ -211,6 +211,18 @@ @Parameter( defaultValue = "false" ) private boolean skinnyWars; +/** + * Whether to create skinny EAR modules or not. A skinny EAR module is a WAR, SAR, HAR, RAR or WSR module that + * does not have all of its dependencies in it. Instead those dependencies are shared between the WARs, SARs, HARs, Review comment: Addressed in 83a46e0 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on a change in pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507722777
##
File path: src/site/apt/examples/skinny-modules.apt.vm
##
@@ -0,0 +1,191 @@
+ --
+ Creating Skinny Modules
+ --
+ Marat Abrarov
+ --
+ 2020-10-18
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/doxia/references/apt-format.html
+
+Creating Skinny Modules
+
+ This is a bit like {{{./skinny-wars.html}skinny WARs}}, but taken to the
+ next level and applied to EAR modules of type:
+
+ * {{{../modules.html#webModule}WAR}}
+
+ * {{{../modules.html#rarModule}RAR}}
+
+ * {{{../modules.html#wsrModule}WSR}}
+
+ * {{{../modules.html#sarModule}SAR}}
+
+ * {{{../modules.html#harModule}HAR}}
+
+ Starting with version 3.1.1 Maven EAR Plugin supports referencing
+ external JARs packaged within the EAR via the <<>> setting
+ in EAR module <<>>.
+
+ We need to change the EAR project's <<>> to package those JARs
+ in the EAR and to use the
+ {{{../ear-mojo.html#skinnyModules}skinnyModules}} parameter.
+
+ <> In this example we package all JARs into a <<>> directory
+ within the EAR. This is just to distinguish between Java EE modules
+ (which will be packaged in the root of the EAR) and Java libraries
+ (which are packaged in <<>>). Also, we use non standard
+ <<>> just to shorten names of files packaged
+ in EAR and to keep them close to the names used in local repository
+ for a better readability.
+
++-+
+
+ ...
+
+
+
+ com.acme
+ shared-jar
+ 1.0.0
+
+
+ com.acme
+ war
+ 1.0.0
+ war
+
+
+ com.acme
+ rar
+ 1.0.0
+ rar
+
+
+ com.acme
+ sar
+ 1.0.0
+ sar
+
+
+ ...
+
+
+
+org.apache.maven.plugins
+maven-ear-plugin
+${project.version}
+
+
@{artifactId}@-@{version}@@{dashClassifier?}@.@{extension}@
+ libs/
+ true
+
+
+
+
+ ...
+
++-+
+
+ Your EAR will contain something like this:
+
++-+
+ .
+ |-- META-INF
+ | `-- application.xml
+ |-- libs
+ | `-- shared-jar-1.0.0.jar
+ |-- war-1.0.0.war
+ |-- sar-1.0.0.sar
+ `-- rar-1.0.0.rar
++-+
+
+ If you look inside the copies of <<>>, <<>>
+ and <<>>, that are packaged within the EAR, you will see that
+ they no longer contain <<>>,
+ <<>> and <<>> files
respectively.
+
+ Also, if you inspect the <<>> of WAR, SAR and HAR modules of EAR
+ you will notice that the <<>> entry has been modified or added,
+ if it was missing, and now has a reference to <<>>.
+
+ If archive representing EAR module has non standard location of libraries then
+ this location can be configured using <<>> property.
+
+ Here is example for SAR which contains libraries at the root of archive
Review comment:
Addressed in 83a46e0
##
File path: src/site/apt/examples/skinny-modules.apt.vm
##
@@ -0,0 +1,191 @@
+ --
+ Creating Skinny Modules
+ --
+ Marat Abrarov
+ --
+ 2020-10-18
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/doxia/references/apt-format.html
+
+Creating Skinny Modules
+
+ This is a bit like {{{./skinny-wars.html}skinny WARs}}, but t
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on a change in pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507722576
##
File path: src/site/apt/examples/skinny-modules.apt.vm
##
@@ -0,0 +1,191 @@
+ --
+ Creating Skinny Modules
+ --
+ Marat Abrarov
+ --
+ 2020-10-18
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/doxia/references/apt-format.html
+
+Creating Skinny Modules
+
+ This is a bit like {{{./skinny-wars.html}skinny WARs}}, but taken to the
+ next level and applied to EAR modules of type:
+
+ * {{{../modules.html#webModule}WAR}}
+
+ * {{{../modules.html#rarModule}RAR}}
+
+ * {{{../modules.html#wsrModule}WSR}}
+
+ * {{{../modules.html#sarModule}SAR}}
+
+ * {{{../modules.html#harModule}HAR}}
+
+ Starting with version 3.1.1 Maven EAR Plugin supports referencing
+ external JARs packaged within the EAR via the <<>> setting
+ in EAR module <<>>.
+
+ We need to change the EAR project's <<>> to package those JARs
+ in the EAR and to use the
+ {{{../ear-mojo.html#skinnyModules}skinnyModules}} parameter.
+
+ <> In this example we package all JARs into a <<>> directory
+ within the EAR. This is just to distinguish between Java EE modules
+ (which will be packaged in the root of the EAR) and Java libraries
+ (which are packaged in <<>>). Also, we use non standard
+ <<>> just to shorten names of files packaged
+ in EAR and to keep them close to the names used in local repository
+ for a better readability.
+
++-+
+
+ ...
+
+
+
+ com.acme
+ shared-jar
+ 1.0.0
+
+
+ com.acme
+ war
+ 1.0.0
+ war
+
+
+ com.acme
+ rar
+ 1.0.0
+ rar
+
+
+ com.acme
+ sar
+ 1.0.0
+ sar
+
+
+ ...
+
+
+
+org.apache.maven.plugins
+maven-ear-plugin
+${project.version}
+
+
@{artifactId}@-@{version}@@{dashClassifier?}@.@{extension}@
+ libs/
+ true
+
+
+
+
+ ...
+
++-+
+
+ Your EAR will contain something like this:
+
++-+
+ .
+ |-- META-INF
+ | `-- application.xml
+ |-- libs
+ | `-- shared-jar-1.0.0.jar
+ |-- war-1.0.0.war
+ |-- sar-1.0.0.sar
+ `-- rar-1.0.0.rar
++-+
+
+ If you look inside the copies of <<>>, <<>>
+ and <<>>, that are packaged within the EAR, you will see that
+ they no longer contain <<>>,
+ <<>> and <<>> files
respectively.
+
+ Also, if you inspect the <<>> of WAR, SAR and HAR modules of EAR
+ you will notice that the <<>> entry has been modified or added,
+ if it was missing, and now has a reference to <<>>.
+
+ If archive representing EAR module has non standard location of libraries then
Review comment:
Addressed in 83a46e0
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on a change in pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507722346
##
File path: src/site/apt/examples/skinny-modules.apt.vm
##
@@ -0,0 +1,191 @@
+ --
+ Creating Skinny Modules
+ --
+ Marat Abrarov
+ --
+ 2020-10-18
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/doxia/references/apt-format.html
+
+Creating Skinny Modules
+
+ This is a bit like {{{./skinny-wars.html}skinny WARs}}, but taken to the
+ next level and applied to EAR modules of type:
+
+ * {{{../modules.html#webModule}WAR}}
+
+ * {{{../modules.html#rarModule}RAR}}
+
+ * {{{../modules.html#wsrModule}WSR}}
+
+ * {{{../modules.html#sarModule}SAR}}
+
+ * {{{../modules.html#harModule}HAR}}
+
+ Starting with version 3.1.1 Maven EAR Plugin supports referencing
+ external JARs packaged within the EAR via the <<>> setting
+ in EAR module <<>>.
+
+ We need to change the EAR project's <<>> to package those JARs
+ in the EAR and to use the
+ {{{../ear-mojo.html#skinnyModules}skinnyModules}} parameter.
+
+ <> In this example we package all JARs into a <<>> directory
+ within the EAR. This is just to distinguish between Java EE modules
+ (which will be packaged in the root of the EAR) and Java libraries
+ (which are packaged in <<>>). Also, we use non standard
+ <<>> just to shorten names of files packaged
+ in EAR and to keep them close to the names used in local repository
+ for a better readability.
+
++-+
+
+ ...
+
+
+
+ com.acme
+ shared-jar
+ 1.0.0
+
+
+ com.acme
+ war
+ 1.0.0
+ war
+
+
+ com.acme
+ rar
+ 1.0.0
+ rar
+
+
+ com.acme
+ sar
+ 1.0.0
+ sar
+
+
+ ...
+
+
+
+org.apache.maven.plugins
+maven-ear-plugin
+${project.version}
+
+
@{artifactId}@-@{version}@@{dashClassifier?}@.@{extension}@
+ libs/
+ true
+
+
+
+
+ ...
+
++-+
+
+ Your EAR will contain something like this:
+
++-+
+ .
+ |-- META-INF
+ | `-- application.xml
+ |-- libs
+ | `-- shared-jar-1.0.0.jar
+ |-- war-1.0.0.war
+ |-- sar-1.0.0.sar
+ `-- rar-1.0.0.rar
++-+
+
+ If you look inside the copies of <<>>, <<>>
+ and <<>>, that are packaged within the EAR, you will see that
+ they no longer contain <<>>,
+ <<>> and <<>> files
respectively.
+
+ Also, if you inspect the <<>> of WAR, SAR and HAR modules of EAR
+ you will notice that the <<>> entry has been modified or added,
+ if it was missing, and now has a reference to <<>>.
+
+ If archive representing EAR module has non standard location of libraries then
+ this location can be configured using <<>> property.
Review comment:
Addressed in 83a46e0
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on a change in pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on a change in pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507721671
##
File path: src/site/apt/index.apt.vm
##
@@ -63,13 +63,18 @@ ${project.name}
For more information about the Java EE technology, please visit
{{http://www.oracle.com/us/technologies/java/enterprise-edition/overview/index.html}}.
+* Version 3.1.1
+
+ Starting with version 3.1.1 {{{./ear-mojo.html#skinnyModules}skinnyModules}}
parameter
Review comment:
Addressed in 83a46e0
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-ear-plugin] mabrarov commented on pull request #24: [MEAR-153] skinnyModules option
mabrarov commented on pull request #24: URL: https://github.com/apache/maven-ear-plugin/pull/24#issuecomment-712134089 > https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-ear-plugin/job/mear-153/ It looks like smth wrong with Jenkins - build looks hanged on checkout phase:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-wagon] michael-o commented on pull request #73: WAGON-601 update JUnit version
michael-o commented on pull request #73: URL: https://github.com/apache/maven-wagon/pull/73#issuecomment-712095663 @slachiewicz Please handle the ticket also! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-ear-plugin] elharo commented on a change in pull request #24: [MEAR-153] skinnyModules option
elharo commented on a change in pull request #24:
URL: https://github.com/apache/maven-ear-plugin/pull/24#discussion_r507647064
##
File path: src/main/java/org/apache/maven/plugins/ear/AbstractEarModule.java
##
@@ -360,34 +374,34 @@ public String toString()
}
/**
- * Cleans the bundle directory so that it might be used properly.
+ * Cleans the path pointing to resource inside archive so that it might be
used properly.
Review comment:
the resource inside the archive
##
File path: src/main/java/org/apache/maven/plugins/ear/AbstractEarModule.java
##
@@ -91,6 +91,14 @@
private String moduleId;
+/**
+ * Directory of module which contains libraries packaged into module.
{@code null} value means that module
+ * doesn't contain any library. Each module type can provide default value
for this directory and this option
+ * can be used to override that default value. If module libraries are
located at the root of module then use
+ * single slash (/) to configure that in POM, i.e. single slash is treated
as empty string.
Review comment:
single slash (/) to configure that in POM. That is, a single slash is
treated as an empty string.
##
File path: src/main/java/org/apache/maven/plugins/ear/EarModule.java
##
@@ -114,7 +114,8 @@ void resolveArtifact( Set artifacts )
boolean changeManifestClasspath();
/**
- * @return The libDir.
+ * @return The directory of module which contains JAR libraries packaged
within module. Can be {@code null},
Review comment:
the directory of the module which contains the JAR files packages within
the module
##
File path: src/site/apt/examples/skinny-modules.apt.vm
##
@@ -0,0 +1,191 @@
+ --
+ Creating Skinny Modules
+ --
+ Marat Abrarov
+ --
+ 2020-10-18
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/doxia/references/apt-format.html
+
+Creating Skinny Modules
+
+ This is a bit like {{{./skinny-wars.html}skinny WARs}}, but taken to the
+ next level and applied to EAR modules of type:
+
+ * {{{../modules.html#webModule}WAR}}
+
+ * {{{../modules.html#rarModule}RAR}}
+
+ * {{{../modules.html#wsrModule}WSR}}
+
+ * {{{../modules.html#sarModule}SAR}}
+
+ * {{{../modules.html#harModule}HAR}}
+
+ Starting with version 3.1.1 Maven EAR Plugin supports referencing
Review comment:
3.1.1., the
##
File path: src/site/apt/examples/skinny-modules.apt.vm
##
@@ -0,0 +1,191 @@
+ --
+ Creating Skinny Modules
+ --
+ Marat Abrarov
+ --
+ 2020-10-18
+ --
+
+~~ Licensed to the Apache Software Foundation (ASF) under one
+~~ or more contributor license agreements. See the NOTICE file
+~~ distributed with this work for additional information
+~~ regarding copyright ownership. The ASF licenses this file
+~~ to you under the Apache License, Version 2.0 (the
+~~ "License"); you may not use this file except in compliance
+~~ with the License. You may obtain a copy of the License at
+~~
+~~ http://www.apache.org/licenses/LICENSE-2.0
+~~
+~~ Unless required by applicable law or agreed to in writing,
+~~ software distributed under the License is distributed on an
+~~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+~~ KIND, either express or implied. See the License for the
+~~ specific language governing permissions and limitations
+~~ under the License.
+
+~~ NOTE: For help with the syntax of this file, see:
+~~ http://maven.apache.org/doxia/references/apt-format.html
+
+Creating Skinny Modules
+
+ This is a bit like {{{./skinny-wars.html}skinny WARs}}, but taken to the
+ next level and applied to EAR modules of type:
+
+ * {{{../modules.html#webModule}WAR}}
+
+ * {{{../modules.html#rarModule}RAR}}
+
+ * {{{../modules.html#wsrModule}WSR}}
+
+ * {{{../modules.html#sarModule}SAR}}
+
+ * {{{../modules.html#harModule}HAR}}
+
+ Starting with version 3.1.1 Maven EAR Plugin supports referencing
Review comment:
the Maven EAR
##
File path: src/site/apt/examples/skinny-modules.apt.vm
##
@@ -0,0 +1,191 @@
+ --
+ Cre
[jira] [Commented] (SUREFIRE-1854) Support include/exclude junit test engine
[ https://issues.apache.org/jira/browse/SUREFIRE-1854?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17216594#comment-17216594 ] Adam commented on SUREFIRE-1854: I check whole documentation etc. but did not found anything... [~tibordigana], can you provide me where I can find information how to include/exclude engine by surefire plugin? > Support include/exclude junit test engine > - > > Key: SUREFIRE-1854 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1854 > Project: Maven Surefire > Issue Type: New Feature > Components: JUnit 5.x support, Maven Surefire Plugin >Affects Versions: 2.22.2 >Reporter: Adam >Priority: Major > > It could be very important for my project to support include/exclude junit > test engine by Maven Surefire Plugin. > Junit Console Launcher have existing support for this: > [https://junit.org/junit5/docs/current/user-guide/#running-tests-console-launcher-options] > Similar solution exists for Gradle: > https://junit.org/junit5/docs/current/user-guide/#running-tests-build-gradle -- This message was sent by Atlassian Jira (v8.3.4#803005)
