[GitHub] [maven-dependency-plugin] lars-sh commented on pull request #123: [MDEP-714] - Add analyze parameter "ignoreUnusedRuntime"
lars-sh commented on pull request #123: URL: https://github.com/apache/maven-dependency-plugin/pull/123#issuecomment-817224443 Sure, just added one. Please tell me, if I should do more. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dist-tool] pcavezzan commented on pull request #2: Added a menu to point to maven test bench project that run a daily check of memory allocation
pcavezzan commented on pull request #2: URL: https://github.com/apache/maven-dist-tool/pull/2#issuecomment-817210854 Thank you @slachiewicz for your feedback Would you prefer to have the tests running alongside with maven-dist-tool ? Like @jeanbisutti said, from what we understood, `maven-dist-tool` was just about reporting and nothing else. That's why we were thinking about with @jeanbisutti and @hboutemy to go step by step with this report about daily memory check of maven build: 1. add a simple badge to indicate if check passes or fails (this PR) 2. working on having something more useful for maven development like having a trend chart about the last x daily check. What do you think about that ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MCOMPILER-460) Compiler doesn't show detailed information with the Maven Toolchains
Johan Janssen created MCOMPILER-460: --- Summary: Compiler doesn't show detailed information with the Maven Toolchains Key: MCOMPILER-460 URL: https://issues.apache.org/jira/browse/MCOMPILER-460 Project: Maven Compiler Plugin Issue Type: Bug Affects Versions: 3.8.1 Environment: Windows Java 16 Reporter: Johan Janssen I've created an example to showcase the issue: https://github.com/johanjanssen/mavenexample When running without the Toolchains on Java 16 {{}} {code:java} mvn compile or docker build -t mavenexample -f DockerfileJava16 . {code} Gives {{}} {code:java} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project broken: Fatal error compiling: java.lang.IllegalAccessError: class lombok.javac.apt.LombokProcessor (in unnamed module @0x21bd20ee) cannot access class com.sun.tools.javac.processing.JavacProcessingEnvironment (in module jdk.compiler) because module jdk.compiler does not export com.sun.tools.javac.processing to unnamed module @0x21bd20ee -> [Help 1]{code} {{}} When running with the Toolchains on Java 16 {{}} {code:java} mvn compile -Ptoolchain or docker build -t mavenexample -f DockerfileJava16Toolchain . {code} Gives {{}} {code:java} [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile) on project broken: Compilation failure -> [Help 1]{code} {{}} So the Toolchain setup lacks quite some information about the compilation failure. Is it possible to get the same error information when using the toolchain? My usecase is having a quick way to build the same code with 2 different versions of Java. To show one version works and the other fails. It's also possible with Docker or setting the JAVA_HOME variable. But I was curious to see if it would work with toolchains as well. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-dist-tool] jeanbisutti commented on pull request #2: Added a menu to point to maven test bench project that run a daily check of memory allocation
jeanbisutti commented on pull request #2: URL: https://github.com/apache/maven-dist-tool/pull/2#issuecomment-817180254 @slachiewicz `We asked here quick-perf/maven-test-bench#18 to maybe add code to our tool to do perf tests and have our reports also - would it be possible to implement?` quick-perf/maven-test-bench#18 proposes to "ingest daily Maven memory check to daily Maven dist-tool report", I don't see the mention of performance tests addition. From what I understand from maven-dist-tool Readme and code, it aims at producing a report. The performance information is _automatically_ generated _each day_ in the following way: * The Maven head is checkouted and a Maven distribution is built from it * A specific version of Apache Camel is checkouted, a massive multi module project * `mvn validate` is applied on this project, and the heap allocation is checked Control and reduce heap allocation seem an important matter for Maven project. Indeed, a part of the heap allocation will be garbage collected and the garbage collection activity is succeptible to slow down the build. Also, less heap allocation means that we may execute Maven with a smaller heap size. Having a daily check on Maven heap allocation may help the Maven development because: * It would be possible to be comfortable that each new code modification does not lead to a significant increase of heap allocation, so it would not be needed to manually launch a heap bench of a new Maven distribution (for example with Maven 3.8.1 and 4.0 snasphot) * Having a regular check would ease the identification of the code causing a significant increase of heap allocation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] kriegaex commented on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout
kriegaex commented on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-817140702 Sorry for maybe asking a stupid question, but the last thing I was testing and giving feedback to was @Tibor17's [branch `dry-pipes-tcp-guarantees`](https://github.com/apache/maven-surefire/tree/dry-pipes-tcp-guarantees), not this one. But now someone has approved the changes in this branch. I am a little confused. I did not think that this one was the one to be merged into master, rather the one I tested successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1837) NullPointerException at AbstractSurefireMojo$ClasspathCache.setCachedClasspath
[ https://issues.apache.org/jira/browse/SUREFIRE-1837?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318494#comment-17318494 ] Ruslan Sibgatullin commented on SUREFIRE-1837: -- [~tibordigana] thanks for the reply. I'd say we will first try to run our CI on just recently released Maven version 3.8.1 But if the behavior is the same can I just create a similar ticket here in Jira but for the different project (say, _Maven (MNG)_) ? Also, I don't have an account in your internal Apache Slack. > NullPointerException at AbstractSurefireMojo$ClasspathCache.setCachedClasspath > -- > > Key: SUREFIRE-1837 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1837 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 3.0.0-M5 > Environment: mvn --version > Apache Maven 3.6.3 (cecedd343002696d0abb50b32b541b8a6ba2883f) > Maven home: /opt/apache-maven-3.6.3 > Java version: 11.0.8, vendor: Amazon.com Inc., runtime: > /usr/lib/jvm/java-11-amazon-corretto > Jenkins ver. 2.204.6 on Ubuntu 18 >Reporter: Ruslan Sibgatullin >Priority: Major > > While migrating a rather old and big project from Java 8 to Java 11 the > following exception happens occasionally (once in 3-4 builds): > {code:java} > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test (default-test) > on project my_project: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test failed.: > NullPointerException -> [Help 1] > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute > goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test > (default-test) on project cachereloader-validation: Execution default-test of > goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test failed. > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:215) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at > org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call > (MultiThreadedBuilder.java:190) > at > org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call > (MultiThreadedBuilder.java:186) > at java.util.concurrent.FutureTask.run (FutureTask.java:264) > at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515) > at java.util.concurrent.FutureTask.run (FutureTask.java:264) > at java.util.concurrent.ThreadPoolExecutor.runWorker > (ThreadPoolExecutor.java:1128) > at java.util.concurrent.ThreadPoolExecutor$Worker.run > (ThreadPoolExecutor.java:628) > at java.lang.Thread.run (Thread.java:834) > Caused by: org.apache.maven.plugin.PluginExecutionException: Execution > default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M5:test failed. > at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo > (DefaultBuildPluginManager.java:148) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:210) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:156) > at org.apache.maven.lifecycle.internal.MojoExecutor.execute > (MojoExecutor.java:148) > at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject > (LifecycleModuleBuilder.java:117) > at > org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call > (MultiThreadedBuilder.java:190) > at > org.apache.maven.lifecycle.internal.builder.multithreaded.MultiThreadedBuilder$1.call > (MultiThreadedBuilder.java:186) > at java.util.concurrent.FutureTask.run (FutureTask.java:264) > at java.util.concurrent.Executors$RunnableAdapter.call (Executors.java:515) > at java.util.concurrent.FutureTask.run (FutureTask.java:264) > at java.util.concurrent.ThreadPoolExecutor.runWorker > (ThreadPoolExecutor.java:1128) > at java.util.concurrent.ThreadPoolExecutor$Worker.run > (ThreadPoolExecutor.java:628) > at java.lang.Thread.run (Thread.java:834) > Caused by: java.lang.NullPointerException > at > org.apache.maven.plugin.surefire.AbstractSurefireMojo$ClasspathCache.setCachedClasspath > (AbstractSurefireMojo.java:4121) > at > org.apache.maven.plugin.surefire.AbstractSurefireMojo$ClasspathCache.access$200 > (AbstractSurefireMojo.java:4102) > at > org.apache.maven.plugin.surefire.AbstractSurefireMojo.newStartupConfigWithClasspath > (AbstractSurefireMojo.java:1913) > at >
[GitHub] [maven-dist-tool] slachiewicz commented on pull request #2: Added a menu to point to maven test bench project that run a daily check of memory allocation
slachiewicz commented on pull request #2: URL: https://github.com/apache/maven-dist-tool/pull/2#issuecomment-817115402 Thx for the effort, but adding a link to the static site will not help here. We asked here https://github.com/quick-perf/maven-test-bench/issues/18 to maybe add code to our tool to do perf tests and have our reports also - would it be possible to implement? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-1907) maven run test when surefire skipTest enabled by default
[ https://issues.apache.org/jira/browse/SUREFIRE-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahdi updated SUREFIRE-1907: Attachment: (was: example_project.tar.gz) > maven run test when surefire skipTest enabled by default > > > Key: SUREFIRE-1907 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1907 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 3.0.0-M5 >Reporter: Mahdi >Priority: Critical > > according to your documents : > https://maven.apache.org/surefire/maven-surefire-plugin/examples/skipping-tests.html > I try to disable tests by default and run this tests on cli with this command > : > {quote}mvn clean compile test -DskipTests=false > {quote} > but still tests skipped in this case . > I also ask this question on StackOverflow with more explanation : > https://stackoverflow.com/questions/67032138/maven-run-test-when-surefire-skiptest-enabled-by-default/67032191?noredirect=1#comment118486523_67032191 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MSHARED-930) SimpleResourceInclusionScanner.getIncludedSources() returns wrong generic type
[ https://issues.apache.org/jira/browse/MSHARED-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MSHARED-930. Resolution: Fixed > SimpleResourceInclusionScanner.getIncludedSources() returns wrong generic type > -- > > Key: MSHARED-930 > URL: https://issues.apache.org/jira/browse/MSHARED-930 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-io >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: maven-shared-io-3.0.1 > > > ResourceInclusionScanner.getInlcudedSources (the supertype) is declared to > return Set. However SimpleResourceInclusionScanner.getIncludedSources() > is declared to return a Set and actually returns Set. > In fact, returns: Collections.emptySet() or > Collections,singleton(String[]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Moved] (MNGSITE-447) The option -Dproject.scm.developerConnection as specified in the guide does not work
[ https://issues.apache.org/jira/browse/MNGSITE-447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte moved MRELEASE-1017 to MNGSITE-447: -- Component/s: (was: prepare) Key: MNGSITE-447 (was: MRELEASE-1017) Affects Version/s: (was: 2.5.3) Project: Maven Project Web Site (was: Maven Release Plugin) > The option -Dproject.scm.developerConnection as specified in the guide does > not work > > > Key: MNGSITE-447 > URL: https://issues.apache.org/jira/browse/MNGSITE-447 > Project: Maven Project Web Site > Issue Type: Bug >Reporter: George Belden >Priority: Major > > What I'm reporting is basically the same as the following which looks to > never have been resolved. > https://issues.apache.org/jira/browse/MRELEASE-707 > > The option -Dproject.scm.developerConnection as specified on the following > guide does not work. > [https://maven.apache.org/guides/mini/guide-releasing.html] > > It would be nice if the documentation could be updated so as not to be > misleading. However it would be even nicer to have that functionality, as it > is a critical configuration in order to be able to use this plugin in modern > CI/CD pipelines. > Is such a configuration planned for any future release? I have already > bolted this functionality onto the 2.5.3 source so that I can at least use > this on my projects. Otherwise this plugin is not usable for my team, hence > why I am marking this as major. But I do not understand the procedure for > sharing this feature, or if it's already being added to a future release then > it's a moot point. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Moved] (MNGSITE-446) Documentation incorrectly states that release.properties is retained
[ https://issues.apache.org/jira/browse/MNGSITE-446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte moved MRELEASE-1059 to MNGSITE-446: -- Component/s: (was: documentation) Key: MNGSITE-446 (was: MRELEASE-1059) Project: Maven Project Web Site (was: Maven Release Plugin) > Documentation incorrectly states that release.properties is retained > > > Key: MNGSITE-446 > URL: https://issues.apache.org/jira/browse/MNGSITE-446 > Project: Maven Project Web Site > Issue Type: Improvement >Reporter: Shannon Carey >Priority: Minor > > [https://maven.apache.org/guides/mini/guide-releasing.html] says: > {quote}The _release.properties_ file is created while preparing the release. > After performing the release the file remains within the project root > directory until the maven user deletes it. > {quote} > However, that is not true. The _release.properties_ file is deleted by the > "perform" step. > Unfortunately, that makes it difficult to determine what version was just > released. But, this Jira is merely requesting for the documentation to be > corrected. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MRELEASE-935) Support for expression in 'version' tag
[ https://issues.apache.org/jira/browse/MRELEASE-935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17010910#comment-17010910 ] Robert Scholte edited comment on MRELEASE-935 at 4/10/21, 10:04 AM: Issues with CI friendly versions will be solved in Maven 4 with MNG-6656 was (Author: rfscholte): Issues with CI friendly versions will be solved in Maven 3.7.0 with MNG-6656 > Support for expression in 'version' tag > --- > > Key: MRELEASE-935 > URL: https://issues.apache.org/jira/browse/MRELEASE-935 > Project: Maven Release Plugin > Issue Type: New Feature >Affects Versions: 2.5.3 >Reporter: Andrea Scarpino >Priority: Minor > Attachments: support_for_revision_in_version.patch > > > The release plugin doesn't support a version value that points to a property > which define the version. > Everytime I use the plugin, the version in the current POM loose the > expression. Maybe it could work using the property to which it points? > {noformat} > $ grep '' pom.xml > ${parent.project.version} > $ grep '' pom.xml > 0.0.1-SNAPSHOT > {noformat} > Could you please implement this or point me to the files that handle this? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSHARED-944) Set minimum Maven version to 3.1.1
[ https://issues.apache.org/jira/browse/MSHARED-944?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-944: - Fix Version/s: maven-shared-io-3.0.1 > Set minimum Maven version to 3.1.1 > -- > > Key: MSHARED-944 > URL: https://issues.apache.org/jira/browse/MSHARED-944 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: file-management, maven-shared-io, maven-shared-jar >Reporter: Elliotte Rusty Harold >Priority: Major > Fix For: maven-shared-io-3.0.1, maven-archiver-3.5.1, > file-management-3.0.1 > > > > > Note: We have a conflict with asm:asm:3.3.1 in Maven 3.1.0, see MNG-5499 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MRELEASE-581) Git relative pathing broken with release plugin
[ https://issues.apache.org/jira/browse/MRELEASE-581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MRELEASE-581. --- Assignee: Robert Scholte Resolution: Auto Closed Assuming this has already been fixed, as Git is already widely used. > Git relative pathing broken with release plugin > --- > > Key: MRELEASE-581 > URL: https://issues.apache.org/jira/browse/MRELEASE-581 > Project: Maven Release Plugin > Issue Type: Bug > Components: Git, prepare >Affects Versions: 2.0 > Environment: windows xp, service pack 2 >Reporter: Matthew Sandoz >Assignee: Robert Scholte >Priority: Minor > Fix For: Backlog > > Attachments: MRELEASE-581.patch, gitexe.zip > > > i have a multimodule project, and when i try to do a release, i get > everything working fine until the end. It seems to think for some reason that > I am at the root of my scm tree. The repo i have to work in has several > projects, and mine is in a subdirectory - domains/redemption. the plugin > appears to try to check in my submodules at my current location instead of my > scm root. > COMMAND: > {{mvn release:prepare -DpreparationGoals="clean install" -DskipTests > -DautoVersionSubmodules=true}} > {noformat} > END OF OUTPUT: > [INFO] [INFO] Reactor Summary: > [INFO] [INFO] > > [INFO] [INFO] Redemption Parent POM . SUCCESS > [2.595s] > [INFO] [INFO] Redemption Runtime Confguration ... SUCCESS > [3.531s] > [INFO] [INFO] Redemption Service Metadata ... SUCCESS > [18.816s] > [INFO] [INFO] Redemption Model .. SUCCESS > [35.693s] > [INFO] [INFO] Redemption DAO SUCCESS > [41.770s] > [INFO] [INFO] Redemption Service Implementation . SUCCESS > [17.517s] > [INFO] [INFO] crm :: guest :: redemption :: ESB :: Parent POM ... SUCCESS > [0.016s] > [INFO] [INFO] crm :: guest :: redemption :: ESB :: XSLT . SUCCESS > [5.469s] > [INFO] [INFO] crm :: guest :: redemption :: ESB :: EIP .. SUCCESS > [0.343s] > [INFO] [INFO] crm :: guest :: redemption :: ESB :: Version Router ... SUCCESS > [3.157s] > [INFO] [INFO] crm :: guest :: redemption :: ESB :: Binding Component :: > Service Unit SUCCESS [3.656s] > [INFO] [INFO] crm :: guest :: redemption :: ESB :: Service Assembly . SUCCESS > [3.516s] > [INFO] [INFO] > > [INFO] [INFO] > > [INFO] [INFO] BUILD SUCCESSFUL > [INFO] [INFO] > > [INFO] [INFO] Total time: 2 minutes 26 seconds > [INFO] [INFO] Finished at: Tue Jul 27 17:18:02 EDT 2010 > [INFO] [INFO] Final Memory: 116M/254M > [INFO] [INFO] > > [INFO] Checking in modified POMs... > [INFO] Executing: cmd.exe /X /C "git add pom.xml redemption-conf\pom.xml > redemption-metadata\pom.xml redemption-model\pom.xml rede > mption-dao\pom.xml redemption-impl\pom.xml redemption-esb\pom.xml > redemption-esb\redemption-xslt\pom.xml redemption-esb\redemption > -eip\pom.xml redemption-esb\redemption-router\pom.xml > redemption-esb\redemption-bc-su\pom.xml redemption-esb\redemption-sa\pom.xml > " > [INFO] Working directory: D:\workspaces\crm-dev\domains\redemption > [INFO] Executing: cmd.exe /X /C "git status" > [INFO] Working directory: D:\workspaces\crm-dev\domains\redemption > [INFO] Executing: cmd.exe /X /C "git commit --verbose -F > D:\DOCUME~1\sandozm\LOCALS~1\Temp\maven-scm-1862033505.commit pom.xml red > emption-conf\pom.xml redemption-metadata\pom.xml redemption-model\pom.xml > redemption-dao\pom.xml redemption-impl\pom.xml redemptio > n-esb\pom.xml redemption-esb\redemption-xslt\pom.xml > redemption-esb\redemption-eip\pom.xml redemption-esb\redemption-router\pom.xm > l redemption-esb\redemption-bc-su\pom.xml > redemption-esb\redemption-sa\pom.xml" > [INFO] Working directory: D:\workspaces\crm-dev\domains\redemption > [INFO] > > [ERROR] BUILD FAILURE > [INFO] > > [INFO] Unable to commit files > Provider message: > The git-commit command failed. > Command output: > error: pathspec 'redemption-conf\pom.xml' did not match any file(s) known to > git. > error: pathspec 'redemption-metadata\pom.xml' did not match any file(s) known > to git. > error: pathspec 'redemption-model\pom.xml' did not match any
[jira] [Commented] (MSHARED-930) SimpleResourceInclusionScanner.getIncludedSources() returns wrong generic type
[ https://issues.apache.org/jira/browse/MSHARED-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318454#comment-17318454 ] Hudson commented on MSHARED-930: Build succeeded in Jenkins: Maven » Maven TLP » maven-shared-io » master #25 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-shared-io/job/master/25/ > SimpleResourceInclusionScanner.getIncludedSources() returns wrong generic type > -- > > Key: MSHARED-930 > URL: https://issues.apache.org/jira/browse/MSHARED-930 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-io >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: maven-shared-io-3.0.1 > > > ResourceInclusionScanner.getInlcudedSources (the supertype) is declared to > return Set. However SimpleResourceInclusionScanner.getIncludedSources() > is declared to return a Set and actually returns Set. > In fact, returns: Collections.emptySet() or > Collections,singleton(String[]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-shared-io] slachiewicz commented on pull request #10: [MSHARED-930] Fix SimpleResourceInclusionScanner.getIncludedSources() returns wrong…
slachiewicz commented on pull request #10: URL: https://github.com/apache/maven-shared-io/pull/10#issuecomment-817109331 merged, Found one more case `Collections.empty` was returning `Set`. Thx you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-io] asfgit closed pull request #10: [MSHARED-930] Fix SimpleResourceInclusionScanner.getIncludedSources() returns wrong…
asfgit closed pull request #10: URL: https://github.com/apache/maven-shared-io/pull/10 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MRELEASE-959) release:branch does not consider release versions
[ https://issues.apache.org/jira/browse/MRELEASE-959?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MRELEASE-959. --- Assignee: Robert Scholte Resolution: Not A Problem The idea behind the plugin is that you always work with SNAPSHOTs. Only during release:prepare the version is renamed to a non-SNAPSHOT version, tagged, and make it again a SNAPSHOT version. Branches are intended to continue your development work, they should not be compared with tags. With that in mind, the release:branch works as expected. > release:branch does not consider release versions > - > > Key: MRELEASE-959 > URL: https://issues.apache.org/jira/browse/MRELEASE-959 > Project: Maven Release Plugin > Issue Type: Bug > Components: branch >Affects Versions: 2.5.3 >Reporter: Ramona Koch >Assignee: Robert Scholte >Priority: Minor > Labels: patch > Attachments: release-branch-considers-releaseVersion.patch > > > What I try to achieve, is to create a release branch from my development > branch. The development branch has a snapshot version (e.g. 1.0.0-SNAPSHOT). > As a result of the command I expect, to get a new branch containing version > 1.0.0 and a changed development branch with version 1.0.1-SNAPSHOT. My > project is a multi-module project. > Related to the specification I assume, that this is the command I need to use: > {code} > mvn release:branch -DupdateBranchVersions=true -DupdateWorkCopyVersions=true > -DupdateVersionsToSnapshot=false -DreleaseVersion=1.0.0 > -DdevelopmentVersion=1.0.1-SNAPSHOT -DbranchName=release-1.0.0 > -DautoVersionSubmodules=true > {code} > But this will result in asking me for a branch version, which only accepts > snapshot versions. If I use {{batch-mode}} it will just use 1.0.1-SNAPSHOT. > I also tried to give the versions per module by using {{-Dproject.dev...}} > and {{-Dproject.rel...}}. It results in the same behaviour. > At the end I had a look into the code and it seems, that it simply ignores > the updateVersionsToSnapshot, which defines whether to update versions to > SNAPSHOT in the branch or not. Since the default is true, it will always put > a snapshot version in the branch. > I will attach a patch file containing my proposed fix (including tests). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (SUREFIRE-1907) maven run test when surefire skipTest enabled by default
[ https://issues.apache.org/jira/browse/SUREFIRE-1907?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mahdi updated SUREFIRE-1907: Attachment: example_project.tar.gz > maven run test when surefire skipTest enabled by default > > > Key: SUREFIRE-1907 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1907 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 3.0.0-M5 >Reporter: Mahdi >Priority: Critical > Attachments: example_project.tar.gz > > > according to your documents : > https://maven.apache.org/surefire/maven-surefire-plugin/examples/skipping-tests.html > I try to disable tests by default and run this tests on cli with this command > : > {quote}mvn clean compile test -DskipTests=false > {quote} > but still tests skipped in this case . > I also ask this question on StackOverflow with more explanation : > https://stackoverflow.com/questions/67032138/maven-run-test-when-surefire-skiptest-enabled-by-default/67032191?noredirect=1#comment118486523_67032191 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (SUREFIRE-1907) maven run test when surefire skipTest enabled by default
Mahdi created SUREFIRE-1907: --- Summary: maven run test when surefire skipTest enabled by default Key: SUREFIRE-1907 URL: https://issues.apache.org/jira/browse/SUREFIRE-1907 Project: Maven Surefire Issue Type: Bug Components: Maven Surefire Plugin Affects Versions: 3.0.0-M5 Reporter: Mahdi according to your documents : https://maven.apache.org/surefire/maven-surefire-plugin/examples/skipping-tests.html I try to disable tests by default and run this tests on cli with this command : {quote}mvn clean compile test -DskipTests=false {quote} but still tests skipped in this case . I also ask this question on StackOverflow with more explanation : https://stackoverflow.com/questions/67032138/maven-run-test-when-surefire-skiptest-enabled-by-default/67032191?noredirect=1#comment118486523_67032191 -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MSHARED-930) SimpleResourceInclusionScanner.getIncludedSources() returns wrong generic type
[ https://issues.apache.org/jira/browse/MSHARED-930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17318451#comment-17318451 ] Hudson commented on MSHARED-930: Build succeeded in Jenkins: Maven » Maven TLP » maven-shared-io » MSHARED-930 #2 See https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-shared-io/job/MSHARED-930/2/ > SimpleResourceInclusionScanner.getIncludedSources() returns wrong generic type > -- > > Key: MSHARED-930 > URL: https://issues.apache.org/jira/browse/MSHARED-930 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-io >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: maven-shared-io-3.0.1 > > > ResourceInclusionScanner.getInlcudedSources (the supertype) is declared to > return Set. However SimpleResourceInclusionScanner.getIncludedSources() > is declared to return a Set and actually returns Set. > In fact, returns: Collections.emptySet() or > Collections,singleton(String[]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (MRELEASE-983) Documentation for release plugin has still not been corrected.
[ https://issues.apache.org/jira/browse/MRELEASE-983?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Scholte closed MRELEASE-983. --- Assignee: Robert Scholte Resolution: Invalid If you take a closer look at the scm goals, you're see: {noformat} Default value is: ${project.scm.connection}. User property is: connectionUrl. {noformat} project.scm.connection is not the name of the parameter you can use via the commandline, that is connectionUrl. In this case you can change the value by either -DconnectionUrl=myNewConnectionUrl or by overriding the value in the properties of the pom.xml: {code:xml} myNewConnectionUrl {code} The ${project.scm.connection} is a read-only field and represents the path in the pom.xml, so it uses the connection value of the scm-section in > Documentation for release plugin has still not been corrected. > -- > > Key: MRELEASE-983 > URL: https://issues.apache.org/jira/browse/MRELEASE-983 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare >Affects Versions: 2.5.3 >Reporter: Justin Grant >Assignee: Robert Scholte >Priority: Minor > > Per MRELEASE-707, the documentation at > http://maven.apache.org/maven-release/maven-release-plugin/usage.html has > still not been corrected, even though the issue was marked as "closed". It > is not an unreasonable expectation as this is supported by the SCM plugin: > http://maven.apache.org/components/scm/maven-scm-plugin/status-mojo.html and > the other Maven Lifecycle plugins: > https://maven.apache.org/scm/maven-scm-plugin/validate-mojo.html > I'm still a little unclear as to why this is so ridiculous that you would > take this information as a parameters (for example, cases of releasing to a > different repository than is in your pom), but the documentation should be > corrected either way. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSHARED-930) SimpleResourceInclusionScanner.getIncludedSources() returns wrong generic type
[ https://issues.apache.org/jira/browse/MSHARED-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-930: - Description: ResourceInclusionScanner.getInlcudedSources (the supertype) is declared to return Set. However SimpleResourceInclusionScanner.getIncludedSources() is declared to return a Set and actually returns Set. In fact, returns: Collections.emptySet() or Collections,singleton(String[]) was:ResourceInclusionScanner.getInlcudedSources (the supertype) is declared to return Set. However SimpleResourceInclusionScanner.getIncludedSources() is declared to return a Set and actually returns Set. > SimpleResourceInclusionScanner.getIncludedSources() returns wrong generic type > -- > > Key: MSHARED-930 > URL: https://issues.apache.org/jira/browse/MSHARED-930 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-io >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: maven-shared-io-3.0.1 > > > ResourceInclusionScanner.getInlcudedSources (the supertype) is declared to > return Set. However SimpleResourceInclusionScanner.getIncludedSources() > is declared to return a Set and actually returns Set. > In fact, returns: Collections.emptySet() or > Collections,singleton(String[]) -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (MSHARED-930) SimpleResourceInclusionScanner.getIncludedSources() returns wrong generic type
[ https://issues.apache.org/jira/browse/MSHARED-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MSHARED-930: - Fix Version/s: maven-shared-io-3.0.1 > SimpleResourceInclusionScanner.getIncludedSources() returns wrong generic type > -- > > Key: MSHARED-930 > URL: https://issues.apache.org/jira/browse/MSHARED-930 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-io >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: maven-shared-io-3.0.1 > > > ResourceInclusionScanner.getInlcudedSources (the supertype) is declared to > return Set. However SimpleResourceInclusionScanner.getIncludedSources() > is declared to return a Set and actually returns Set. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (MSHARED-930) SimpleResourceInclusionScanner.getIncludedSources() returns wrong generic type
[ https://issues.apache.org/jira/browse/MSHARED-930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MSHARED-930: Assignee: Sylwester Lachiewicz > SimpleResourceInclusionScanner.getIncludedSources() returns wrong generic type > -- > > Key: MSHARED-930 > URL: https://issues.apache.org/jira/browse/MSHARED-930 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-shared-io >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Major > > ResourceInclusionScanner.getInlcudedSources (the supertype) is declared to > return Set. However SimpleResourceInclusionScanner.getIncludedSources() > is declared to return a Set and actually returns Set. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [maven-dist-tool] jeanbisutti commented on pull request #2: Added a menu to point to maven test bench project that run a daily check of memory allocation
jeanbisutti commented on pull request #2: URL: https://github.com/apache/maven-dist-tool/pull/2#issuecomment-817102643 @slachiewicz This work from @pcavezzan allows having a daily non-regression check on Maven head heap allocation. We did not execute the latest [benchmarks](https://github.com/quick-perf/maven-test-bench/blob/master/maven-perf/measures/mvn-validate-on-camel.png) for Maven 3.8.1 and 4.0 snapshot. It is possible to run them with the instructions given [here](https://github.com/quick-perf/maven-test-bench#benchmark-heap-allocation-of-several-maven-releases). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] reinhapa commented on pull request #343: SUREFIRE-1881 Adds additional debug log and fork connection timeout
reinhapa commented on pull request #343: URL: https://github.com/apache/maven-surefire/pull/343#issuecomment-817094502 Hi @Tibor17, I can confirm that it works with and without the `org.apache.maven.plugin.surefire.extensions.SurefireForkNodeFactory` setting! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org