[GitHub] [maven-release] dependabot[bot] opened a new pull request, #108: Bump maven-invoker from 2.2 to 3.2.0

2022-04-19 Thread GitBox


dependabot[bot] opened a new pull request, #108:
URL: https://github.com/apache/maven-release/pull/108

   Bumps [maven-invoker](https://github.com/apache/maven-invoker) from 2.2 to 
3.2.0.
   
   Release notes
   Sourced from https://github.com/apache/maven-invoker/releases;>maven-invoker's 
releases.
   
   3.2.0
   
    New features and improvements
   
   https://issues.apache.org/jira/browse/MSHARED-1040;>[MSHARED-1040] - 
Require Java 8 (https://github-redirect.dependabot.com/apache/maven-invoker/issues/45;>#45)
 https://github.com/slawekjaranowski;>@​slawekjaranowski
   https://issues.apache.org/jira/browse/MSHARED-1019;>[MSHARED-1019] - 
Allow pass raw cli option to Maven process (https://github-redirect.dependabot.com/apache/maven-invoker/issues/43;>#43)
 https://github.com/slawekjaranowski;>@​slawekjaranowski
   https://issues.apache.org/jira/browse/MSHARED-1018;>[MSHARED-1018] - 
Allow for using the -ntp ,--no-transfer-progress flag in Maven invocations (https://github-redirect.dependabot.com/apache/maven-invoker/issues/42;>#42)
 https://github.com/slawekjaranowski;>@​slawekjaranowski
   https://issues.apache.org/jira/browse/MSHARED-1009;>[MSHARED-1009] - 
Allow providing Maven executable from workspace (https://github-redirect.dependabot.com/apache/maven-invoker/issues/38;>#38)
 https://github.com/slawekjaranowski;>@​slawekjaranowski
   https://issues.apache.org/jira/browse/MSHARED-649;>[MSHARED-649] - 
Allow Pom file outside base directory (https://github-redirect.dependabot.com/apache/maven-invoker/issues/37;>#37)
 https://github.com/slawekjaranowski;>@​slawekjaranowski
   https://issues.apache.org/jira/browse/MSHARED-1007;>[MSHARED-1007] - 
Add MavenHome and MavenExecutable options to InvocationRequest (https://github-redirect.dependabot.com/apache/maven-invoker/issues/34;>#34)
 https://github.com/slawekjaranowski;>@​slawekjaranowski
   https://issues.apache.org/jira/browse/MINVOKER-233;>[MINVOKER-233] - 
Improve DefaultInvoker with a timeout.  (https://github-redirect.dependabot.com/apache/maven-invoker/issues/1;>#1)
 https://github.com/surli;>@​surli
   
    Bug Fixes
   
   https://issues.apache.org/jira/browse/MSHARED-1008;>[MSHARED-1008] - 
Set builder id in proper way (https://github-redirect.dependabot.com/apache/maven-invoker/issues/33;>#33)
 https://github.com/slawekjaranowski;>@​slawekjaranowski
   
    Dependency updates
   
   https://issues.apache.org/jira/browse/MSHARED-1042;>[MSHARED-1042] - 
Upgrade Parent to 35 (https://github-redirect.dependabot.com/apache/maven-invoker/issues/47;>#47)
 https://github.com/slawekjaranowski;>@​slawekjaranowski
   Bump maven-site-plugin from 3.9.1 to 3.10.0 (https://github-redirect.dependabot.com/apache/maven-invoker/issues/36;>#36)
 https://github.com/dependabot;>@​dependabot
   Bump extra-enforcer-rules from 1.4 to 1.5.1 (https://github-redirect.dependabot.com/apache/maven-invoker/issues/31;>#31)
 https://github.com/dependabot;>@​dependabot
   Bump maven-project-info-reports-plugin from 3.1.1 to 3.1.2 (https://github-redirect.dependabot.com/apache/maven-invoker/issues/11;>#11)
 https://github.com/dependabot;>@​dependabot
   Update build and deps (https://github-redirect.dependabot.com/apache/maven-invoker/issues/25;>#25)
 https://github.com/cstamas;>@​cstamas
   Bump actions/setup-java from 2.3.0 to 2.3.1 (https://github-redirect.dependabot.com/apache/maven-invoker/issues/23;>#23)
 https://github.com/dependabot;>@​dependabot
   Bump maven-javadoc-plugin from 3.2.0 to 3.3.1 (https://github-redirect.dependabot.com/apache/maven-invoker/issues/21;>#21)
 https://github.com/dependabot;>@​dependabot
   Bump actions/setup-java from 2.2.0 to 2.3.0 (https://github-redirect.dependabot.com/apache/maven-invoker/issues/20;>#20)
 https://github.com/dependabot;>@​dependabot
   Bump actions/cache from 2.1.5 to 2.1.6 (https://github-redirect.dependabot.com/apache/maven-invoker/issues/17;>#17)
 https://github.com/dependabot;>@​dependabot
   Bump actions/checkout from 2 to 2.3.4 (https://github-redirect.dependabot.com/apache/maven-invoker/issues/14;>#14)
 https://github.com/dependabot;>@​dependabot
   Bump actions/cache from v2.1.4 to v2.1.5 (https://github-redirect.dependabot.com/apache/maven-invoker/issues/10;>#10)
 https://github.com/dependabot;>@​dependabot
   Bump junit from 4.13.1 to 4.13.2 (https://github-redirect.dependabot.com/apache/maven-invoker/issues/8;>#8)
 https://github.com/dependabot;>@​dependabot
   
    Maintenance
   
   https://issues.apache.org/jira/browse/MSHARED-577;>[MSHARED-577] - 
Remove usage of M2_HOME environment variable (https://github-redirect.dependabot.com/apache/maven-invoker/issues/35;>#35)
 https://github.com/slawekjaranowski;>@​slawekjaranowski
   https://issues.apache.org/jira/browse/MSHARED-1006;>[MSHARED-1006] - 
Deprecate not thread safe methods on Invoker (https://github-redirect.dependabot.com/apache/maven-invoker/issues/32;>#32)
 https://github.com/slawekjaranowski;>@​slawekjaranowski
   Unit test 

[GitHub] [maven-release] dependabot[bot] opened a new pull request, #107: Bump plexus-interpolation from 1.17 to 1.26

2022-04-19 Thread GitBox


dependabot[bot] opened a new pull request, #107:
URL: https://github.com/apache/maven-release/pull/107

   Bumps 
[plexus-interpolation](https://github.com/codehaus-plexus/plexus-interpolation) 
from 1.17 to 1.26.
   
   Commits
   
   See full diff in https://github.com/codehaus-plexus/plexus-interpolation/commits/plexus-interpolation-1.26;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.plexus:plexus-interpolation=maven=1.17=1.26)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MINVOKER-261) Confusing error message

2022-04-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-261.

Resolution: Fixed

> Confusing error message
> ---
>
> Key: MINVOKER-261
> URL: https://issues.apache.org/jira/browse/MINVOKER-261
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Reporter: Elliotte Rusty Harold
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.3.0
>
>
> It took me a while to figure this one out:
> java.lang.IllegalStateException: ${maven.home} is not specified as a 
> directory: '/Cellar/maven/3.6.0/bin'.
>   
> Better message:
> ${maven.home} is set to '/Cellar/maven/3.6.0/bin' which does not exist
> or perhaps
> ${maven.home} is set to '/Cellar/maven/3.6.0/bin' which is not a directory



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-invoker-plugin] dependabot[bot] opened a new pull request, #113: Bump mockito-core from 4.3.1 to 4.5.0

2022-04-19 Thread GitBox


dependabot[bot] opened a new pull request, #113:
URL: https://github.com/apache/maven-invoker-plugin/pull/113

   Bumps [mockito-core](https://github.com/mockito/mockito) from 4.3.1 to 4.5.0.
   
   Release notes
   Sourced from https://github.com/mockito/mockito/releases;>mockito-core's 
releases.
   
   v4.5.0
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   4.5.0
   
   2022-04-19 - https://github.com/mockito/mockito/compare/v4.4.0...v4.5.0;>15 
commit(s) by Andrei Silviu Dragnea, Rafael Winterhalter, Rick Ossendrijver, 
dependabot[bot]
   Bump versions.errorprone from 2.13.0 to 2.13.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2621;>#2621)](https://github-redirect.dependabot.com/mockito/mockito/pull/2621;>mockito/mockito#2621)
   Bump versions.errorprone from 2.12.1 to 2.13.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2619;>#2619)](https://github-redirect.dependabot.com/mockito/mockito/pull/2619;>mockito/mockito#2619)
   Groovy inline [(https://github-redirect.dependabot.com/mockito/mockito/issues/2618;>#2618)](https://github-redirect.dependabot.com/mockito/mockito/pull/2618;>mockito/mockito#2618)
   Bump actions/setup-java from 2 to 3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2615;>#2615)](https://github-redirect.dependabot.com/mockito/mockito/pull/2615;>mockito/mockito#2615)
   Bump versions.bytebuddy from 1.12.8 to 1.12.9 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2614;>#2614)](https://github-redirect.dependabot.com/mockito/mockito/pull/2614;>mockito/mockito#2614)
   Support subclass mocks on Graal VM. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2613;>#2613)](https://github-redirect.dependabot.com/mockito/mockito/pull/2613;>mockito/mockito#2613)
   Bump com.diffplug.spotless from 6.4.1 to 6.4.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2611;>#2611)](https://github-redirect.dependabot.com/mockito/mockito/pull/2611;>mockito/mockito#2611)
   Bump kotlinx-coroutines-core from 1.6.0-native-mt to 1.6.1-native-mt 
[(https://github-redirect.dependabot.com/mockito/mockito/issues/2609;>#2609)](https://github-redirect.dependabot.com/mockito/mockito/pull/2609;>mockito/mockito#2609)
   Bump versions.errorprone from 2.10.0 to 2.12.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2608;>#2608)](https://github-redirect.dependabot.com/mockito/mockito/pull/2608;>mockito/mockito#2608)
   Bump kotlinVersion from 1.6.10 to 1.6.20 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2607;>#2607)](https://github-redirect.dependabot.com/mockito/mockito/pull/2607;>mockito/mockito#2607)
   Bump com.diffplug.spotless from 6.4.0 to 6.4.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2606;>#2606)](https://github-redirect.dependabot.com/mockito/mockito/pull/2606;>mockito/mockito#2606)
   Bump com.diffplug.spotless from 6.3.0 to 6.4.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2605;>#2605)](https://github-redirect.dependabot.com/mockito/mockito/pull/2605;>mockito/mockito#2605)
   Bump org.eclipse.osgi from 3.17.100 to 3.17.200 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2597;>#2597)](https://github-redirect.dependabot.com/mockito/mockito/pull/2597;>mockito/mockito#2597)
   Deprecate ListUtil and Fields classes [(https://github-redirect.dependabot.com/mockito/mockito/issues/2593;>#2593)](https://github-redirect.dependabot.com/mockito/mockito/pull/2593;>mockito/mockito#2593)
   mockito-errorprone seems not compatible with ErrorProne 2.11.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2554;>#2554)](https://github-redirect.dependabot.com/mockito/mockito/issues/2554;>mockito/mockito#2554)
   NullPointerException from Groovy metaclass methods when using 
mockito-inline (but not mockito-core) [(https://github-redirect.dependabot.com/mockito/mockito/issues/2522;>#2522)](https://github-redirect.dependabot.com/mockito/mockito/issues/2522;>mockito/mockito#2522)
   
   v4.4.0
   Changelog generated 
by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog 
Gradle Plugin
   4.4.0
   
   2022-03-08 - https://github.com/mockito/mockito/compare/v4.3.1...v4.4.0;>16 
commit(s) by Andrew Kozel, Brice Dutheil, Jean-Baptiste Mille, Mirko 
Alicastro, dependabot[bot]
   Bump groovy from 3.0.9 to 3.0.10 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2586;>#2586)](https://github-redirect.dependabot.com/mockito/mockito/pull/2586;>mockito/mockito#2586)
   Bump google-java-format from 1.14.0 to 1.15.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2585;>#2585)](https://github-redirect.dependabot.com/mockito/mockito/pull/2585;>mockito/mockito#2585)
   Bump actions/checkout from 2.4.0 to 3 

[GitHub] [maven-invoker-plugin] dependabot[bot] commented on pull request #109: Bump mockito-core from 4.3.1 to 4.4.0

2022-04-19 Thread GitBox


dependabot[bot] commented on PR #109:
URL: 
https://github.com/apache/maven-invoker-plugin/pull/109#issuecomment-1103452356

   Superseded by #113.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-invoker-plugin] dependabot[bot] closed pull request #109: Bump mockito-core from 4.3.1 to 4.4.0

2022-04-19 Thread GitBox


dependabot[bot] closed pull request #109: Bump mockito-core from 4.3.1 to 4.4.0
URL: https://github.com/apache/maven-invoker-plugin/pull/109


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-surefire] dsubelman commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

2022-04-19 Thread GitBox


dsubelman commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1103436778

   If the test fails with escaping characters ``, you can try using 
`String.replaceAll(String, String)` with regex.
   
   Instead of:
   
   return argLine
   .replace( "\n", " " )
   .replace( "\r", " " )
   .replace( "\t", " " );
   
   You can do:
   
   return argLine.replaceAll("\\s+", " ");
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MSKINS-177) Support native matomo (i.e Apache Analytics) as macro

2022-04-19 Thread Olivier Lamy (Jira)


 [ 
https://issues.apache.org/jira/browse/MSKINS-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy updated MSKINS-177:

Summary: Support native matomo (i.e Apache Analytics) as macro  (was: 
Support native apacheAnalyticsSiteId as macro)

> Support native matomo (i.e Apache Analytics) as macro
> -
>
> Key: MSKINS-177
> URL: https://issues.apache.org/jira/browse/MSKINS-177
> Project: Maven Skins
>  Issue Type: Improvement
>  Components: Fluido Skin
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: fluido-1.12.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[jira] [Closed] (DOXIASITETOOLS-252) Add Apache Analytics attributes in DecorationModel

2022-04-19 Thread Olivier Lamy (Jira)


 [ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy closed DOXIASITETOOLS-252.
---
Fix Version/s: (was: 1.11.2)
   Resolution: Won't Fix

> Add Apache Analytics attributes in DecorationModel
> --
>
> Key: DOXIASITETOOLS-252
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-252
> Project: Maven Doxia Sitetools
>  Issue Type: Improvement
>  Components: Decoration model
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-surefire] Tibor17 commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

2022-04-19 Thread GitBox


Tibor17 commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1103181744

   @mthmulders 
   I have one more question.
   The developers would not be able to see the TAB because it is a new space.
   If the new guy would refactor it again, then this IT would not cover the 
purpose that it has now.
   I know it is a question how the xml parser in Maven interprets the escaping 
characters, but I would like to ask you for testing the escaping characters  
`` on Maven 3.2.x and 3.8.x.
   WDYT?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Closed] (MINVOKER-300) Upgrade maven-invoker from 3.1.0 to 3.2.0

2022-04-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-300.

  Assignee: Slawomir Jaranowski
Resolution: Fixed

> Upgrade maven-invoker from 3.1.0 to 3.2.0
> -
>
> Key: MINVOKER-300
> URL: https://issues.apache.org/jira/browse/MINVOKER-300
> Project: Maven Invoker Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.3.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-invoker-plugin] slawekjaranowski merged pull request #112: Bump maven-invoker from 3.1.0 to 3.2.0

2022-04-19 Thread GitBox


slawekjaranowski merged PR #112:
URL: https://github.com/apache/maven-invoker-plugin/pull/112


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

2022-04-19 Thread GitBox


Tibor17 commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1103177674

   @mthmulders What was the reason that the only Java `1.8` was working in the 
old IT? I am just interested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MINVOKER-300) Upgrade maven-invoker from 3.1.0 to 3.2.0

2022-04-19 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINVOKER-300:


 Summary: Upgrade maven-invoker from 3.1.0 to 3.2.0
 Key: MINVOKER-300
 URL: https://issues.apache.org/jira/browse/MINVOKER-300
 Project: Maven Invoker Plugin
  Issue Type: Dependency upgrade
Reporter: Slawomir Jaranowski
 Fix For: 3.3.0






--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-fluido-skin] olamy commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

2022-04-19 Thread GitBox


olamy commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r853468880


##
pom.xml:
##
@@ -38,8 +38,8 @@ under the License.
   2011
 
   
-
scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git
-
scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git
+
scm:git:https://github.com/apache/maven-fluido-skin.git
+
scm:git:https://github.com/apache/maven-fluido-skin.git

Review Comment:
   not sure what is canonical when using git 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-fluido-skin] olamy commented on pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

2022-04-19 Thread GitBox


olamy commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1103131600

   makes sense using something generic such `custom/matomo/..` I will change 
that


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-doxia-sitetools] olamy commented on pull request #32: [DOXIASITETOOLS-252] Add Apache Analytics attributes in DecorationModel

2022-04-19 Thread GitBox


olamy commented on PR #32:
URL: 
https://github.com/apache/maven-doxia-sitetools/pull/32#issuecomment-1103129202

   makes sense


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-doxia-sitetools] olamy closed pull request #32: [DOXIASITETOOLS-252] Add Apache Analytics attributes in DecorationModel

2022-04-19 Thread GitBox


olamy closed pull request #32: [DOXIASITETOOLS-252] Add Apache Analytics 
attributes in DecorationModel
URL: https://github.com/apache/maven-doxia-sitetools/pull/32


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MASSEMBLY-940) moduleSet - incorrect binary dependencies added to assembly

2022-04-19 Thread Scott Shealy (Jira)


[ 
https://issues.apache.org/jira/browse/MASSEMBLY-940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524578#comment-17524578
 ] 

Scott Shealy commented on MASSEMBLY-940:


Can confirm I am hitting this bug. Does anyone have a workaround for this?

> moduleSet - incorrect binary dependencies added to assembly 
> 
>
> Key: MASSEMBLY-940
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-940
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Nigel Jones
>Priority: Major
>
> In moduleSet, dependencies are not based on specific modules included:
> I have a large multimodule project (https://github.com/odpi/egeria) which has 
> over 300 modules, mostly java (->jar).
> One of our submodules is responsible for creating the composite assembly. 
> Previously we were doing it 'the wrong way' (IMO) with lots of relative paths 
> (../../.. etc) and I've recently been trying to switch to using moduleSets, 
> and follow best practices for assembly. We were also previously doing lots of 
> building 'jar with dependencies' but this doesn't scale as every possibly 
> useful for ends up far too big...
> I have hit a problem with dependencies and moduleSets
> We have a series of 'client' artifacts. These have some dependencies (for 
> example we use restclient from spring, jackson etc). One section of my 
> assembly attempts to package the clients into a folder, and include any 
> dependencies they may need:
> 
>  
>  true
>  
>  org.odpi.egeria:asset-catalog-client:*
>  org.odpi.egeria:asset-consumer-client:*
>  org.odpi.egeria:asset-owner-client:*
>  org.odpi.egeria:community-profile-client:*
>  org.odpi.egeria:data-engine-client:*
>  org.odpi.egeria:it-infrastructure-client:*
>  org.odpi.egeria:it-infrastructure-client:*
>  org.odpi.egeria:data-manager-client:*
>  org.odpi.egeria:data-privacy-client:*
>  org.odpi.egeria:data-science-client:*
>  org.odpi.egeria:dev-ops-client:*
>  org.odpi.egeria:digital-architecture-client:*
>  org.odpi.egeria:discovery-engine-client:*
>  org.odpi.egeria:governance-engine-client:*
>  org.odpi.egeria:governance-program-client:*
>  org.odpi.egeria:information-view-client:*
>  org.odpi.egeria:project-management-client:*
>  org.odpi.egeria:security-officer-client:*
>  org.odpi.egeria:software-developer-client:*
>  org.odpi.egeria:stewardship-action-client:*
>  org.odpi.egeria:subject-area-client:*
>  org.odpi.egeria:admin-services-client:*
>  org.odpi.egeria:project-management-client:*
>  
>  
>  ./clients
>  false
>  true
>  
> We have a similar pattern for utilities, samples, connectors etc.
> I had thought 'includeDependencies' would JUST pull in dependencies for the 
> modules listed in the included. However I seem to get every dependency for 
> the entire project (reactor)
> I then tried:
> false
>  
>  
> instead, with the same result.
> Then switched to this -- since the pom for the module doing the assembly DOES 
> have a lot of dependencies (in fact it needs to be everything the assembly 
> refers to as a module, so that we ensure those modules are built first - and 
> exist) - so thinking (but unsure) if useProjectArtifact was relevant:
> false
>  
>  true
>  false
>  false
>  
> but yet again this still pulls in all dependencies.
> The results are inconsistent with 'mvn dependency:tree' - and in fact 
> whatever is built I just always seem to get the same. It's not transitively 
> based off every module in the reactor, but seems to be based of the pom of 
> the project containing the assembly.
> Shouldn't I just be pulling in dependencies of the binaries I specify in the 
> moduleSet?
> I've read the definitive maven book chapter, and the docs, but I can't quite 
> figure out what I'm missing here.
> To clarify as well, here's another example
> 
>  
>  true
>  
>  org.odpi.egeria:open-metadata-conformance-suite-client:*
>  
>  
>  ./conformance-suite
>  false
>  false
>  
>  
>  true
>  false
>  false
>  
>  
>  
>  
> Again, I get the same dependencies - this time into ./conformance-suite yet 
> that is just a single module I am putting into that dir - and I can simply 
> show
> [INFO] --- maven-dependency-plugin:3.1.2:tree (default-cli) @ 
> open-metadata-conformance-suite-client ---
> [INFO] org.odpi.egeria:open-metadata-conformance-suite-client:jar:2.1-SNAPSHOT
> [INFO] +- 
> org.odpi.egeria:open-metadata-conformance-suite-api:jar:2.1-SNAPSHOT:compile
> [INFO] | +- org.slf4j:slf4j-api:jar:1.7.30:compile
> [INFO] | \- com.fasterxml.jackson.core:jackson-annotations:jar:2.11.1:compile
> [INFO] +- org.odpi.egeria:rest-client-connectors-api:jar:2.1-SNAPSHOT:compile
> [INFO] | \- org.odpi.egeria:open-connector-framework:jar:2.1-SNAPSHOT:compile
> [INFO] | \- org.odpi.egeria:audit-log-framework:jar:2.1-SNAPSHOT:compile
> [INFO] +- 

[jira] [Updated] (SUREFIRE-2063) Adding argLine with tab characters fails

2022-04-19 Thread Maarten Mulders (Jira)


 [ 
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Maarten Mulders updated SUREFIRE-2063:
--
Summary: Adding argLine with tab characters fails  (was: Adding 
configuration using  with --add-opens or --add-exports fails)

> Adding argLine with tab characters fails
> 
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Priority: Blocker
>
> Since v3.3.0-M6 fails when using  to export or open a package. The 
> failure is produced when using --add-opens or --add-exports in .
> The execution doesn't fail with v3.3.0-M5 or earlier.
> As an example, it fails when using the following :
> {code:java}
> 
> --add-opens 
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens 
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
> 
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
> [INFO] Using auto detected provider 
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO] 
> [INFO] Results:
> [INFO] 
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO] 
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (dev) on project 
> testing: 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-surefire] mthmulders commented on pull request #523: [SUREFIRE-2063] Remove tabs in forked JVM arguments

2022-04-19 Thread GitBox


mthmulders commented on PR #523:
URL: https://github.com/apache/maven-surefire/pull/523#issuecomment-1103074651

   > Did you use JDK1.8 on your PC when you tested the IT?
   > Look at the GH CI results. All JDKs fail except 1.8.
   > Is this the reason?
   
   I'll soon push an update to an existing test, dropping the need for the 
extra test case. Also, that test runs on all versions of Java, rather than 
using module flags.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails

2022-04-19 Thread Maarten Mulders (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524568#comment-17524568
 ] 

Maarten Mulders commented on SUREFIRE-2063:
---

After digging into the integration test, it seems like the real problem is the 
use of *tabs* rather than spaces. It consistently fails with anything inside 
{{argLine}}, even when it's a simple {{-Dkey=value}} and not {{--add-opens}} or 
{{--add-exports}}.

I'll update the issue title accordingly.

> Adding configuration using  with --add-opens or --add-exports fails
> 
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Priority: Blocker
>
> Since v3.3.0-M6 fails when using  to export or open a package. The 
> failure is produced when using --add-opens or --add-exports in .
> The execution doesn't fail with v3.3.0-M5 or earlier.
> As an example, it fails when using the following :
> {code:java}
> 
> --add-opens 
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens 
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
> 
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
> [INFO] Using auto detected provider 
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO] 
> [INFO] Results:
> [INFO] 
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO] 
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (dev) on project 
> testing: 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-script-interpreter] dependabot[bot] commented on pull request #64: Bump maven-shared-components from 34 to 35

2022-04-19 Thread GitBox


dependabot[bot] commented on PR #64:
URL: 
https://github.com/apache/maven-script-interpreter/pull/64#issuecomment-1103069449

   OK, I won't notify you again about this release, but will get in touch when 
a new version is available. If you'd rather skip all updates until the next 
major or minor version, let me know by commenting `@dependabot ignore this 
major version` or `@dependabot ignore this minor version`. You can also ignore 
all major, minor, or patch releases for a dependency by adding an [`ignore` 
condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore)
 with the desired `update_types` to your config file.
   
   If you change your mind, just re-open this PR and I'll resolve any conflicts 
on it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-script-interpreter] slawekjaranowski closed pull request #64: Bump maven-shared-components from 34 to 35

2022-04-19 Thread GitBox


slawekjaranowski closed pull request #64: Bump maven-shared-components from 34 
to 35
URL: https://github.com/apache/maven-script-interpreter/pull/64


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (SUREFIRE-2063) Adding configuration using with --add-opens or --add-exports fails

2022-04-19 Thread Daniel Subelman (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524565#comment-17524565
 ] 

Daniel Subelman commented on SUREFIRE-2063:
---

[~tibordigana], even though I cannot see the backlog, I understand the 
complexity of maintaining an open-source Maven plugin. 

Let me know if I can help in any way.

> Adding configuration using  with --add-opens or --add-exports fails
> 
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
>  Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Priority: Blocker
>
> Since v3.3.0-M6 fails when using  to export or open a package. The 
> failure is produced when using --add-opens or --add-exports in .
> The execution doesn't fail with v3.3.0-M5 or earlier.
> As an example, it fails when using the following :
> {code:java}
> 
> --add-opens 
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens 
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
> 
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
> [INFO] Using auto detected provider 
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO] 
> [INFO] ---
> [INFO]  T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO] 
> [INFO] Results:
> [INFO] 
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO] 
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (dev) on project 
> testing: 
> {code}



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-scripting-plugin] bmarwell commented on a diff in pull request #5: [MSCRIPTING-9] - basic java scripting support

2022-04-19 Thread GitBox


bmarwell commented on code in PR #5:
URL: 
https://github.com/apache/maven-scripting-plugin/pull/5#discussion_r853402558


##
README.md:
##
@@ -65,7 +65,7 @@ There are some guidelines which will make applying PRs easier 
for us:
  Optional supplemental description.
 ```
 + Make sure you have added the necessary tests (JUnit/IT) for your changes.
-+ Run all the tests with `mvn -Prun-its verify` to assure nothing else was 
accidentally broken.
++ Run all the tests with `mvn -Prun-its verify` to assure nothing else was 
accidentally broken (you may need to run `mvn install` beforehand).

Review Comment:
   Review hint: This was not introduced by @rmannibucau’s change, mrm+invoker 
was already broken before.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-scripting-plugin] rmannibucau commented on pull request #5: [MSCRIPTING-9] - basic java scripting support

2022-04-19 Thread GitBox


rmannibucau commented on PR #5:
URL: 
https://github.com/apache/maven-scripting-plugin/pull/5#issuecomment-1102980200

   Fixed all review comments (cc @bmarwell )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-scripting-plugin] rmannibucau commented on a diff in pull request #5: [MSCRIPTING-9] - basic java scripting support

2022-04-19 Thread GitBox


rmannibucau commented on code in PR #5:
URL: 
https://github.com/apache/maven-scripting-plugin/pull/5#discussion_r853390470


##
README.md:
##
@@ -65,7 +65,7 @@ There are some guidelines which will make applying PRs easier 
for us:
  Optional supplemental description.
 ```
 + Make sure you have added the necessary tests (JUnit/IT) for your changes.
-+ Run all the tests with `mvn -Prun-its verify` to assure nothing else was 
accidentally broken.
++ Run all the tests with `mvn -Prun-its verify` to assure nothing else was 
accidentally broken (you can need to `mvn install` before).

Review Comment:
   @bmarwell well I will not enter into the debate but this is not my change 
but the way the project was setup, invoker+mrm config does not seem to work 
reliably without an install so added the comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-scripting-plugin] rmannibucau commented on a diff in pull request #5: [MSCRIPTING-9] - basic java scripting support

2022-04-19 Thread GitBox


rmannibucau commented on code in PR #5:
URL: 
https://github.com/apache/maven-scripting-plugin/pull/5#discussion_r853389952


##
src/main/java/org/apache/maven/plugins/scripting/engine/JavaEngine.java:
##
@@ -0,0 +1,327 @@
+package org.apache.maven.plugins.scripting.engine;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.script.AbstractScriptEngine;
+import javax.script.Bindings;
+import javax.script.Compilable;
+import javax.script.CompiledScript;
+import javax.script.ScriptContext;
+import javax.script.ScriptEngine;
+import javax.script.ScriptEngineFactory;
+import javax.script.ScriptException;
+import javax.script.SimpleBindings;
+import javax.tools.JavaCompiler;
+import javax.tools.ToolProvider;
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.io.StringReader;
+import java.io.Writer;
+import java.net.URL;
+import java.net.URLClassLoader;
+import java.nio.file.FileVisitResult;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.SimpleFileVisitor;
+import java.nio.file.attribute.BasicFileAttributes;
+import java.util.stream.Stream;
+
+import static java.util.Objects.requireNonNull;
+import static java.util.stream.Collectors.joining;
+
+/**
+ * The java engine implementation.
+ */
+public class JavaEngine extends AbstractScriptEngine implements Compilable
+{
+private final ScriptEngineFactory factory;
+
+public JavaEngine( ScriptEngineFactory factory )
+{
+this.factory = factory;
+}
+
+@Override
+public CompiledScript compile( String script ) throws ScriptException
+{
+// plexus compiler is great but overkill there so don't bring it just 
for that
+final JavaCompiler compiler = requireNonNull(
+ToolProvider.getSystemJavaCompiler(),
+"you must run on a JDK to have a compiler" );
+Path tmpDir = null;
+try
+{
+tmpDir = Files.createTempDirectory( getClass().getSimpleName() );
+
+final String packageName = getClass().getPackage().getName() + 
".generated";
+final String className = "JavaCompiledScript_" + Math.abs( 
script.hashCode() );
+final String source = toSource( packageName, className, script );
+final Path src = tmpDir.resolve( "sources" );
+final Path bin = tmpDir.resolve( "bin" );
+final Path srcDir = src.resolve( packageName.replace( '.', '/' ) );
+Files.createDirectories( srcDir );
+Files.createDirectories( bin );
+final Path java = srcDir.resolve( className + ".java" );
+try ( Writer writer = Files.newBufferedWriter( java ) )
+{
+writer.write( source );
+}
+
+// todo: enable to control it from the project but requires a bit 
too much config effort for this iteration
+final String classpath = mavenClasspathPrefix() + 
System.getProperty( getClass().getName() + ".classpath",
+System.getProperty( "java.class.path", System.getProperty( 
"surefire.real.class.path" ) ) );
+
+// todo: use log, not very important for now so using std streams
+final int run = compiler.run( null, System.out, System.err, 
Stream.of(
+"-classpath", classpath,
+"-sourcepath", src.toAbsolutePath().toString(),
+"-d", bin.toAbsolutePath().toString(),
+java.toAbsolutePath().toString() )
+.toArray( String[]::new ) );
+if ( run != 0 )
+{
+throw new IllegalArgumentException(
+"Can't compile the incoming script, here is the 
generated code: >\n" + source + "\n<\n" );
+}
+final URLClassLoader loader = new URLClassLoader(
+new URL[]{ bin.toUri().toURL() },
+Thread.currentThread().getContextClassLoader() );
+final Class loadClass =
+loader.loadClass( packageName + '.' + className 

[GitHub] [maven-scripting-plugin] rmannibucau commented on a diff in pull request #5: [MSCRIPTING-9] - basic java scripting support

2022-04-19 Thread GitBox


rmannibucau commented on code in PR #5:
URL: 
https://github.com/apache/maven-scripting-plugin/pull/5#discussion_r853389337


##
src/main/java/org/apache/maven/plugins/scripting/engine/JavaEngine.java:
##
@@ -0,0 +1,327 @@
+package org.apache.maven.plugins.scripting.engine;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.script.AbstractScriptEngine;
+import javax.script.Bindings;
+import javax.script.Compilable;
+import javax.script.CompiledScript;
+import javax.script.ScriptContext;
+import javax.script.ScriptEngine;
+import javax.script.ScriptEngineFactory;
+import javax.script.ScriptException;
+import javax.script.SimpleBindings;
+import javax.tools.JavaCompiler;
+import javax.tools.ToolProvider;
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.io.StringReader;
+import java.io.Writer;
+import java.net.URL;
+import java.net.URLClassLoader;
+import java.nio.file.FileVisitResult;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.SimpleFileVisitor;
+import java.nio.file.attribute.BasicFileAttributes;
+import java.util.stream.Stream;
+
+import static java.util.Objects.requireNonNull;
+import static java.util.stream.Collectors.joining;
+
+/**
+ * The java engine implementation.
+ */
+public class JavaEngine extends AbstractScriptEngine implements Compilable
+{
+private final ScriptEngineFactory factory;
+
+public JavaEngine( ScriptEngineFactory factory )
+{
+this.factory = factory;
+}
+
+@Override
+public CompiledScript compile( String script ) throws ScriptException
+{
+// plexus compiler is great but overkill there so don't bring it just 
for that
+final JavaCompiler compiler = requireNonNull(
+ToolProvider.getSystemJavaCompiler(),
+"you must run on a JDK to have a compiler" );
+Path tmpDir = null;
+try
+{
+tmpDir = Files.createTempDirectory( getClass().getSimpleName() );
+
+final String packageName = getClass().getPackage().getName() + 
".generated";
+final String className = "JavaCompiledScript_" + Math.abs( 
script.hashCode() );
+final String source = toSource( packageName, className, script );
+final Path src = tmpDir.resolve( "sources" );
+final Path bin = tmpDir.resolve( "bin" );
+final Path srcDir = src.resolve( packageName.replace( '.', '/' ) );
+Files.createDirectories( srcDir );
+Files.createDirectories( bin );
+final Path java = srcDir.resolve( className + ".java" );
+try ( Writer writer = Files.newBufferedWriter( java ) )
+{
+writer.write( source );
+}
+
+// todo: enable to control it from the project but requires a bit 
too much config effort for this iteration
+final String classpath = mavenClasspathPrefix() + 
System.getProperty( getClass().getName() + ".classpath",
+System.getProperty( "java.class.path", System.getProperty( 
"surefire.real.class.path" ) ) );
+
+// todo: use log, not very important for now so using std streams
+final int run = compiler.run( null, System.out, System.err, 
Stream.of(
+"-classpath", classpath,
+"-sourcepath", src.toAbsolutePath().toString(),
+"-d", bin.toAbsolutePath().toString(),
+java.toAbsolutePath().toString() )
+.toArray( String[]::new ) );
+if ( run != 0 )
+{
+throw new IllegalArgumentException(
+"Can't compile the incoming script, here is the 
generated code: >\n" + source + "\n<\n" );
+}
+final URLClassLoader loader = new URLClassLoader(
+new URL[]{ bin.toUri().toURL() },
+Thread.currentThread().getContextClassLoader() );
+final Class loadClass =
+loader.loadClass( packageName + '.' + className 

[GitHub] [maven-scripting-plugin] bmarwell commented on a diff in pull request #5: [MSCRIPTING-9] - basic java scripting support

2022-04-19 Thread GitBox


bmarwell commented on code in PR #5:
URL: 
https://github.com/apache/maven-scripting-plugin/pull/5#discussion_r853357835


##
README.md:
##
@@ -65,7 +65,7 @@ There are some guidelines which will make applying PRs easier 
for us:
  Optional supplemental description.
 ```
 + Make sure you have added the necessary tests (JUnit/IT) for your changes.
-+ Run all the tests with `mvn -Prun-its verify` to assure nothing else was 
accidentally broken.
++ Run all the tests with `mvn -Prun-its verify` to assure nothing else was 
accidentally broken (you can need to `mvn install` before).

Review Comment:
   ```suggestion
   + Run all the tests with `mvn -Prun-its verify` to assure nothing else was 
accidentally broken (you may need to run `mvn install` beforehand).
   ```



##
src/main/java/org/apache/maven/plugins/scripting/engine/JavaEngine.java:
##
@@ -0,0 +1,327 @@
+package org.apache.maven.plugins.scripting.engine;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.script.AbstractScriptEngine;
+import javax.script.Bindings;
+import javax.script.Compilable;
+import javax.script.CompiledScript;
+import javax.script.ScriptContext;
+import javax.script.ScriptEngine;
+import javax.script.ScriptEngineFactory;
+import javax.script.ScriptException;
+import javax.script.SimpleBindings;
+import javax.tools.JavaCompiler;
+import javax.tools.ToolProvider;
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.IOException;
+import java.io.Reader;
+import java.io.StringReader;
+import java.io.Writer;
+import java.net.URL;
+import java.net.URLClassLoader;
+import java.nio.file.FileVisitResult;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.nio.file.Paths;
+import java.nio.file.SimpleFileVisitor;
+import java.nio.file.attribute.BasicFileAttributes;
+import java.util.stream.Stream;
+
+import static java.util.Objects.requireNonNull;
+import static java.util.stream.Collectors.joining;
+
+/**
+ * The java engine implementation.
+ */
+public class JavaEngine extends AbstractScriptEngine implements Compilable
+{
+private final ScriptEngineFactory factory;
+
+public JavaEngine( ScriptEngineFactory factory )
+{
+this.factory = factory;
+}
+
+@Override
+public CompiledScript compile( String script ) throws ScriptException
+{
+// plexus compiler is great but overkill there so don't bring it just 
for that
+final JavaCompiler compiler = requireNonNull(
+ToolProvider.getSystemJavaCompiler(),
+"you must run on a JDK to have a compiler" );
+Path tmpDir = null;
+try
+{
+tmpDir = Files.createTempDirectory( getClass().getSimpleName() );
+
+final String packageName = getClass().getPackage().getName() + 
".generated";
+final String className = "JavaCompiledScript_" + Math.abs( 
script.hashCode() );
+final String source = toSource( packageName, className, script );
+final Path src = tmpDir.resolve( "sources" );
+final Path bin = tmpDir.resolve( "bin" );
+final Path srcDir = src.resolve( packageName.replace( '.', '/' ) );
+Files.createDirectories( srcDir );
+Files.createDirectories( bin );
+final Path java = srcDir.resolve( className + ".java" );
+try ( Writer writer = Files.newBufferedWriter( java ) )
+{
+writer.write( source );
+}
+
+// todo: enable to control it from the project but requires a bit 
too much config effort for this iteration
+final String classpath = mavenClasspathPrefix() + 
System.getProperty( getClass().getName() + ".classpath",
+System.getProperty( "java.class.path", System.getProperty( 
"surefire.real.class.path" ) ) );
+
+// todo: use log, not very important for now so using std streams

Review Comment:
   ```suggestion
   // TODO: use a Logger in subsequent releases. Not very important 
as of now, so using std streams
   ```



##
src/main/java/org/apache/maven/plugins/scripting/engine/JavaEngine.java:
##
@@ -0,0 

[jira] [Updated] (MSCRIPTING-9) Support java scripting

2022-04-19 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/MSCRIPTING-9?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated MSCRIPTING-9:

Labels: pull-request-available  (was: )

> Support java scripting
> --
>
> Key: MSCRIPTING-9
> URL: https://issues.apache.org/jira/browse/MSCRIPTING-9
> Project: Maven Scripting
>  Issue Type: Task
>Reporter: Romain Manni-Bucau
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-scripting-plugin] rmannibucau opened a new pull request, #5: [MSCRIPTING-9] - basic java scripting support

2022-04-19 Thread GitBox


rmannibucau opened a new pull request, #5:
URL: https://github.com/apache/maven-scripting-plugin/pull/5

   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [X] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MSCRIPTING) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line 
and body.
- [X] Format the pull request title like `[MSCRIPTING-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MSCRIPTING-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [X] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify` to make sure basic checks pass. A more 
thorough check will 
  be performed on your pull request automatically.
- [X] You have run the integration tests successfully (`mvn -Prun-its clean 
verify`).
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [ ] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [ ] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   description: the goal is to be able to script - as with any jsr223 impl - in 
plain java
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MSCRIPTING-9) Support java scripting

2022-04-19 Thread Romain Manni-Bucau (Jira)
Romain Manni-Bucau created MSCRIPTING-9:
---

 Summary: Support java scripting
 Key: MSCRIPTING-9
 URL: https://issues.apache.org/jira/browse/MSCRIPTING-9
 Project: Maven Scripting
  Issue Type: Task
Reporter: Romain Manni-Bucau






--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-war-plugin] michael-o commented on a diff in pull request #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…

2022-04-19 Thread GitBox


michael-o commented on code in PR #22:
URL: https://github.com/apache/maven-war-plugin/pull/22#discussion_r853251454


##
pom.xml:
##
@@ -118,7 +118,7 @@
 
   org.apache.maven.shared
   maven-shared-utils
-  3.2.1
+  3.3.3

Review Comment:
   3.3.4



##
src/it/MWAR-450/pom.xml:
##
@@ -0,0 +1,55 @@
+
+
+
+
+
+  4.0.0
+
+  org.apache.maven.its.war
+  mwar450
+  1.0-SNAPSHOT
+  war
+
+  
+UTF-8
+  
+
+  
+mwar450
+
+  
+org.apache.maven.plugins
+maven-war-plugin
+@project.version@
+
+  
+  ISO-8859-1
+  
+
+  WEB-INF/classes
+  true
+  src/main/webapp/WEB-INF/classes

Review Comment:
   Aren't they in `src/main/resources`?



##
src/it/MWAR-450/verify.bsh:
##
@@ -0,0 +1,94 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+
+import org.codehaus.plexus.util.*;
+
+boolean result = true;
+
+try
+{
+File target = new File( basedir, "target/mwar450/WEB-INF/classes" );
+if ( !target.exists() || !target.isDirectory() )
+{
+System.err.println( "target/mwar450/WEB-INF/classes is missing or is 
not a directory." );
+return false;
+}
+
+// Load and check log4j.xml
+File log4jxml = new File( target, "log4j.xml" );
+if ( !log4jxml.exists() || log4jxml.isDirectory() )
+{
+System.err.println( "log4j.xml is missing or is a directory." );
+return false;
+}
+FileInputStream fis = new FileInputStream ( log4jxml );
+String paramContent = IOUtil.toString ( fis, "UTF-8" );
+System.out.println( "content='" + paramContent + "'" );

Review Comment:
   This output will be mangled if run on non-UTF-8. 



##
src/it/MWAR-450/verify.bsh:
##
@@ -0,0 +1,94 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+
+import org.codehaus.plexus.util.*;
+
+boolean result = true;
+
+try
+{
+File target = new File( basedir, "target/mwar450/WEB-INF/classes" );
+if ( !target.exists() || !target.isDirectory() )
+{
+System.err.println( "target/mwar450/WEB-INF/classes is missing or is 
not a directory." );
+return false;
+}
+
+// Load and check log4j.xml
+File log4jxml = new File( target, "log4j.xml" );
+if ( !log4jxml.exists() || log4jxml.isDirectory() )
+{
+System.err.println( "log4j.xml is missing or is a directory." );
+return false;
+}
+FileInputStream fis = new FileInputStream ( log4jxml );
+String paramContent = IOUtil.toString ( fis, "UTF-8" );
+System.out.println( "content='" + paramContent + "'" );
+int indexOf = paramContent.indexOf( "This file is encoded in UTF-8 and 
should remain so after filtering - åäö" );
+if ( indexOf < 0 )
+{
+  System.err.println( "Non-ascii characters changed encoding during 
filtering" );
+  return false;
+}
+
+// Load and check my.properties
+File myProperties = new File( target, "my.properties" );
+if ( !myProperties.exists() || myProperties.isDirectory() )
+{
+System.err.println( "my.properties is missing or is a directory." );
+return false;
+}
+Properties properties = new Properties();
+FileInputStream fis = new FileInputStream( myProperties );
+properties.load( fis );
+fis.close();
+String property = 

[jira] [Commented] (DOXIASITETOOLS-252) Add Apache Analytics attributes in DecorationModel

2022-04-19 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524411#comment-17524411
 ] 

Michael Osipov commented on DOXIASITETOOLS-252:
---

https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1102767815
https://github.com/apache/maven-doxia-sitetools/pull/32#issuecomment-1102570844

> Add Apache Analytics attributes in DecorationModel
> --
>
> Key: DOXIASITETOOLS-252
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-252
> Project: Maven Doxia Sitetools
>  Issue Type: Improvement
>  Components: Decoration model
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 1.11.2
>
>




--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-fluido-skin] michael-o commented on pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

2022-04-19 Thread GitBox


michael-o commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1102773768

   > This should only be Matomo-specific, not ASF specific. Just make the full 
host a mandatory config option (next to site id) to make this feature usable 
outside ASF projects.
   
   I like that. It could be in `custom/matomo/...`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-fluido-skin] kwin commented on pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

2022-04-19 Thread GitBox


kwin commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1102767815

   This should only be Matomo-specific, not ASF specific. Just make the full 
host a mandatory config option (next to site id) to make this feature usable 
outside ASF projects.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] pzygielo commented on pull request #127: [MJAVADOC-710] Break the build if replaced or removed property is used

2022-04-19 Thread GitBox


pzygielo commented on PR #127:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/127#issuecomment-1102746581

   May I ask for review, please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-war-plugin] dennisl commented on pull request #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…

2022-04-19 Thread GitBox


dennisl commented on PR #22:
URL: https://github.com/apache/maven-war-plugin/pull/22#issuecomment-1102738911

   Thanks for the review Michael! I have made changes based on your suggestions.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (SUREFIRE-2072) Surefire retains too much heap in some case, leading to OutOfMemory

2022-04-19 Thread Tibor Digana (Jira)


[ 
https://issues.apache.org/jira/browse/SUREFIRE-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524325#comment-17524325
 ] 

Tibor Digana commented on SUREFIRE-2072:


[~mickael.istria]
Regarding our code, TestSetRunListener appears in maven-surefire-common, and it 
dependent on Maven API which means that it must be part of the forked JVM, 
otherwise it breaks some project strengths.
Haing it in the forked JVM may lead to these issues because the instance of 
TestSetRunListener would be one, I guess as in Eclipse Tycho, and the objects 
would be reclaimed after the method testSetCompleted() is finished.

> Surefire retains too much heap in some case, leading to OutOfMemory
> ---
>
> Key: SUREFIRE-2072
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2072
> Project: Maven Surefire
>  Issue Type: Bug
>Reporter: Mickael Istria
>Priority: Major
>
> Most likely since SuREFIRE-1845, every test execution can retain 64kB of RAM 
> (as cache). Which caching is welcome, this cannot scale with some big test 
> suites of several thousands of tests and cause OutOfMemoryError.
> This is the case when running Eclipse JDT dom test suite, since 
> tycho-surefire-plugin started to adopt surefire 3.0.0.M6, as described in 
> https://github.com/eclipse/tycho/issues/879#issuecomment-1096454637



--
This message was sent by Atlassian Jira
(v8.20.7#820007)


[GitHub] [maven-fluido-skin] michael-o commented on a diff in pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

2022-04-19 Thread GitBox


michael-o commented on code in PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#discussion_r852988270


##
pom.xml:
##
@@ -38,8 +38,8 @@ under the License.
   2011
 
   
-
scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git
-
scm:git:https://gitbox.apache.org/repos/asf/maven-fluido-skin.git
+
scm:git:https://github.com/apache/maven-fluido-skin.git
+
scm:git:https://github.com/apache/maven-fluido-skin.git

Review Comment:
   Please drop these, the canonical repos ar at ASF, not GH



##
src/it/mskins-177-apache-analytics/pom.xml:
##
@@ -0,0 +1,69 @@
+
+
+http://maven.apache.org/POM/4.0.0; 
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
+  xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
+  4.0.0
+  
+org.apache.maven.skins
+maven-skins
+@project.parent.version@
+  
+
+  org.apache.maven.skins.its
+  mskins-177_apache_analytics
+  1.0-SNAPSHOT
+
+  
+@project.name@
+@project.description@
+@project.groupId@
+@project.artifactId@
+@project.version@
+  
+
+  
+
+  
+org.apache.maven.plugins
+maven-site-plugin
+@sitePluginVersion@
+
+  
+org.apache.maven.doxia
+doxia-decoration-model
+@doxiaSitetoolsVersion@
+  
+
+  
+
+  
+
+  
+
+  
+org.apache.maven.plugins
+maven-project-info-reports-plugin
+3.0.0

Review Comment:
   Use 3.2.2



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-antrun-plugin] dependabot[bot] opened a new pull request, #51: Bump checkstyle from 9.3 to 10.1

2022-04-19 Thread GitBox


dependabot[bot] opened a new pull request, #51:
URL: https://github.com/apache/maven-antrun-plugin/pull/51

   Bumps [checkstyle](https://github.com/checkstyle/checkstyle) from 9.3 to 
10.1.
   
   Release notes
   Sourced from https://github.com/checkstyle/checkstyle/releases;>checkstyle's 
releases.
   
   checkstyle-10.1
   https://checkstyle.org/releasenotes.html#Release_10.1;>https://checkstyle.org/releasenotes.html#Release_10.1
   checkstyle-10.0
   https://checkstyle.org/releasenotes.html#Release_10.0;>https://checkstyle.org/releasenotes.html#Release_10.0
   
   
   
   Commits
   
   https://github.com/checkstyle/checkstyle/commit/7fa1eb2060fed4a91d874a695b1d8a53890204f4;>7fa1eb2
 [maven-release-plugin] prepare release checkstyle-10.1
   https://github.com/checkstyle/checkstyle/commit/3be1cc02d7c0a532639dddcefe30c79ba8864209;>3be1cc0
 doc: release notes for 10.1
   https://github.com/checkstyle/checkstyle/commit/3b3fc46c2b3b24a88c48efe6b2f8133de94b89df;>3b3fc46
 minor: remove suppression for spotbugs-maven-plugin version check
   https://github.com/checkstyle/checkstyle/commit/a8cc4dd8e8571ecd96544192bdf5bafbcf433950;>a8cc4dd
 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/6207;>#6207:
 Add Xpath Regression Test for MethodName
   https://github.com/checkstyle/checkstyle/commit/21125a7d176a92291c8d624ab6fa6f459d30e049;>21125a7
 dependency: bump forbiddenapis from 3.2 to 3.3
   https://github.com/checkstyle/checkstyle/commit/b8628532f12f46ab18e61372a997a4ca73e33d2a;>b862853
 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/10924;>#10924:
 Update SeparatorWrapCheck to use code points
   https://github.com/checkstyle/checkstyle/commit/693ed38d02a2c3a29da1135180111e85a123c1d8;>693ed38
 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11446;>#11446:
 Update ImportOrderCheckTest to use verifyWithInlineConfigParser
   https://github.com/checkstyle/checkstyle/commit/23b1b29b6a0a865a68f2f29305ddc9709ece2e97;>23b1b29
 dependency: bump spotbugs-maven-plugin from 4.5.3.0 to 4.6.0.0
   https://github.com/checkstyle/checkstyle/commit/56a87add6ee7eeab833e9203c3694c9769a40e34;>56a87ad
 Issue https://github-redirect.dependabot.com/checkstyle/checkstyle/issues/11439;>#11439:
 Converted test for SuppressionXpathSingleFilterTest to use inli...
   https://github.com/checkstyle/checkstyle/commit/51c04122c24a41a7e890dda24227d1a3c7e24531;>51c0412
 minor: change java version for modernizer plugin
   Additional commits viewable in https://github.com/checkstyle/checkstyle/compare/checkstyle-9.3...checkstyle-10.1;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.puppycrawl.tools:checkstyle=maven=9.3=10.1)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-antrun-plugin] dependabot[bot] opened a new pull request, #50: Bump maven-plugins from 34 to 35

2022-04-19 Thread GitBox


dependabot[bot] opened a new pull request, #50:
URL: https://github.com/apache/maven-antrun-plugin/pull/50

   Bumps [maven-plugins](https://github.com/apache/maven-parent) from 34 to 35.
   
   Commits
   
   See full diff in https://github.com/apache/maven-parent/commits;>compare view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.plugins:maven-plugins=maven=34=35)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-surefire] Tibor17 commented on pull request #499: Remove TestListResolver#optionallyWildcardFilter

2022-04-19 Thread GitBox


Tibor17 commented on PR #499:
URL: https://github.com/apache/maven-surefire/pull/499#issuecomment-1102655438

   Hi @slawekjaranowski ,
   
   I will have time today late evening.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-antrun-plugin] dependabot[bot] opened a new pull request, #49: Bump maven-site-plugin from 3.10.0 to 3.11.0

2022-04-19 Thread GitBox


dependabot[bot] opened a new pull request, #49:
URL: https://github.com/apache/maven-antrun-plugin/pull/49

   Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 
3.10.0 to 3.11.0.
   
   Release notes
   Sourced from https://github.com/apache/maven-site-plugin/releases;>maven-site-plugin's 
releases.
   
   3.11.0
   What's Changed
   
   [MSITE-812] Missing '/' in log when deploying documentation by 
site:stage by https://github.com/aajisaka;>@​aajisaka 
in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/1;>apache/maven-site-plugin#1
   [MSITE-828] Upgrade jetty to recent version. Update to java 1.8 
(required for jetty) by https://github.com/oflebbe;>@​oflebbe in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/3;>apache/maven-site-plugin#3
   MSITE-848 Update sitedescriptor.apt by https://github.com/ctubbsii;>@​ctubbsii in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/13;>apache/maven-site-plugin#13
   MSITE-847: Corrected link to prerequisite maven version. by https://github.com/KathrynN;>@​KathrynN in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/14;>apache/maven-site-plugin#14
   remove info about old version by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/19;>apache/maven-site-plugin#19
   update test dependencies by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/17;>apache/maven-site-plugin#17
   Only reference current version: created on website by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/18;>apache/maven-site-plugin#18
   [MNGSITE-393] assume Maven 3 as default by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/20;>apache/maven-site-plugin#20
   add .checkstyle to .gitignore by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/22;>apache/maven-site-plugin#22
   remove unused code by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/23;>apache/maven-site-plugin#23
   [MSITE-859] update apache commons lang and IO by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/25;>apache/maven-site-plugin#25
   [MSITE-757] remove Maven 2 support by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/24;>apache/maven-site-plugin#24
   [MSITE-757] drop Maven 2 mention by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/26;>apache/maven-site-plugin#26
   docs: use https by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/28;>apache/maven-site-plugin#28
   [MSITE-861] remove obsolete dependency by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/29;>apache/maven-site-plugin#29
   [MNGSITE-393] remove Maven 1 and 2 info by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/30;>apache/maven-site-plugin#30
   Fix script injection example in docs by https://github.com/strkkk;>@​strkkk in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/35;>apache/maven-site-plugin#35
   trivial change by https://github.com/elharo;>@​elharo in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/38;>apache/maven-site-plugin#38
   [MSITE-871] Upgrade Maven Javadoc Plugin in integration tests by https://github.com/mthmulders;>@​mthmulders in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/39;>apache/maven-site-plugin#39
   Bump plexus-archiver from 4.2.4 to 4.2.5 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/47;>apache/maven-site-plugin#47
   Bump maven-shared-utils from 3.3.3 to 3.3.4 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/50;>apache/maven-site-plugin#50
   Bump slf4jVersion from 1.7.29 to 1.7.31 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/54;>apache/maven-site-plugin#54
   Bump slf4jVersion from 1.7.31 to 1.7.32 by https://github.com/dependabot;>@​dependabot in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/58;>apache/maven-site-plugin#58
   Add PR template by https://github.com/slawekjaranowski;>@​slawekjaranowski 
in https://github-redirect.dependabot.com/apache/maven-site-plugin/pull/63;>apache/maven-site-plugin#63
   [MSITE-877] Shared GitHub Actions by https://github.com/slawekjaranowski;>@​slawekjaranowski 
in 

[GitHub] [maven-antrun-plugin] dependabot[bot] opened a new pull request, #48: Bump modello-maven-plugin from 1.11 to 2.0.0

2022-04-19 Thread GitBox


dependabot[bot] opened a new pull request, #48:
URL: https://github.com/apache/maven-antrun-plugin/pull/48

   Bumps [modello-maven-plugin](https://github.com/codehaus-plexus/modello) 
from 1.11 to 2.0.0.
   
   Release notes
   Sourced from https://github.com/codehaus-plexus/modello/releases;>modello-maven-plugin's
 releases.
   
   Modello 2.0.0
   this releases requires Java 8 (previous releases required Java 7)
   
    New features and improvements
   
   Add Modello 2.0.0 model XSD (c909e6c054a4b4ca7e9f1f9efb3b4db7853c9ad5) 
https://github.com/hboutemy;>@​hboutemy
   Manage xdoc anchor name conflicts (2 classes with same anchor)  
(2590c0fa9c069e7d243a6dff0c323f21816f23b4) https://github.com/hboutemy;>@​hboutemy
   Drop unnecessary check for identical branches (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/171;>#171)
 https://github.com/pzygielo;>@​pzygielo
   Require Maven 3.1.1 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/124;>#124)
 https://github.com/slachiewicz;>@​slachiewicz
   Use a caching writer to avoid overwriting identical files (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/116;>#116)
 https://github.com/gnodet;>@​gnodet
   Migrate from codehaus:wstx to com.fasterxml.woodstox:woodstox-core 6.2.4 
(https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/101;>#101)
 https://github.com/slachiewicz;>@​slachiewicz
   Make location handling more memory efficient (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/31;>#31)
 https://github.com/oehme;>@​oehme
   Xpp3 extended writer (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/30;>#30)
 https://github.com/hboutemy;>@​hboutemy
   Refactor some old java APIs usage (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/26;>#26)
 https://github.com/rfscholte;>@​rfscholte
   Add a new field fileComment (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/3;>#3)
 https://github.com/ptahchiev;>@​ptahchiev
   
    Bug Fixes
   
   Fix javaSource default value (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/117;>#117)
 https://github.com/gnodet;>@​gnodet
   Fix modello-plugin-snakeyaml (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/56;>#56)
 https://github.com/pzygielo;>@​pzygielo
   
    Dependency updates
   
   Bump maven-javadoc-plugin from 3.3.1 to 3.3.2 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/184;>#184)
 https://github.com/dependabot;>@​dependabot
   Bump release-drafter/release-drafter from 5.17.6 to 5.18.0 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/179;>#179)
 https://github.com/dependabot;>@​dependabot
   Bump taglist-maven-plugin from 2.4 to 3.0.0 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/177;>#177)
 https://github.com/dependabot;>@​dependabot
   Bump checkstyle from 9.2.1 to 9.3 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/178;>#178)
 https://github.com/dependabot;>@​dependabot
   Bump xmlunit-core from 2.8.4 to 2.9.0 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/172;>#172)
 https://github.com/dependabot;>@​dependabot
   Bump junit from 4.12 to 4.13.1 in 
/modello-maven-plugin/src/it/maven-model (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/176;>#176)
 https://github.com/dependabot;>@​dependabot
   Bump xercesImpl from 2.12.1 to 2.12.2 in 
/modello-plugins/modello-plugin-xsd (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/175;>#175)
 https://github.com/dependabot;>@​dependabot
   Bump xercesImpl from 2.12.1 to 2.12.2 in 
/modello-plugins/modello-plugin-jsonschema (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/174;>#174)
 https://github.com/dependabot;>@​dependabot
   Bump mavenPluginTools from 3.6.2 to 3.6.4 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/169;>#169)
 https://github.com/dependabot;>@​dependabot
   Bump maven-compiler-plugin from 3.8.1 to 3.9.0 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/166;>#166)
 https://github.com/dependabot;>@​dependabot
   Bump maven-jar-plugin from 3.2.0 to 3.2.2 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/164;>#164)
 https://github.com/dependabot;>@​dependabot
   Bump release-drafter/release-drafter from 5.15.0 to 5.17.6 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/170;>#170)
 https://github.com/dependabot;>@​dependabot
   Bump woodstox-core from 6.2.7 to 6.2.8 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/167;>#167)
 https://github.com/dependabot;>@​dependabot
   Bump maven-release-plugin from 3.0.0-M4 to 3.0.0-M5 (https://github-redirect.dependabot.com/codehaus-plexus/modello/issues/161;>#161)
 https://github.com/dependabot;>@​dependabot
   Bump checkstyle 

[GitHub] [maven-ear-plugin] cstamas commented on pull request #46: [MEAR-304] Update plugin dependencies

2022-04-19 Thread GitBox


cstamas commented on PR #46:
URL: https://github.com/apache/maven-ear-plugin/pull/46#issuecomment-1102622025

   Updated to Maven 3.2.5 and ITs are passing OK


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-ear-plugin] cstamas commented on pull request #46: [MEAR-304] Update plugin dependencies

2022-04-19 Thread GitBox


cstamas commented on PR #46:
URL: https://github.com/apache/maven-ear-plugin/pull/46#issuecomment-1102593142

   Would be nice to have here m-rar-p release, as latest is 2.x and is used in 
tests...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-doxia-sitetools] michael-o commented on pull request #32: [DOXIASITETOOLS-252] Add Apache Analytics attributes in DecorationModel

2022-04-19 Thread GitBox


michael-o commented on PR #32:
URL: 
https://github.com/apache/maven-doxia-sitetools/pull/32#issuecomment-1102570844

   True, and I consider this as a mistake. The custom element provides all you 
need. Have you evaluated it at all? The problem by putting this into Doxia 
Sitetools is you will ned to update the *entire* stack for this. Keeping it in 
`custom` only requires a skin change.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (DOXIASITETOOLS-252) Add Apache Analytics attributes in DecorationModel

2022-04-19 Thread Olivier Lamy (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524269#comment-17524269
 ] 

Olivier Lamy commented on DOXIASITETOOLS-252:
-

We already have google here so what’s wrong added Apache related stuff to an 
Apache project?

> Add Apache Analytics attributes in DecorationModel
> --
>
> Key: DOXIASITETOOLS-252
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-252
> Project: Maven Doxia Sitetools
>  Issue Type: Improvement
>  Components: Decoration model
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 1.11.2
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [maven-doxia-sitetools] olamy commented on pull request #32: [DOXIASITETOOLS-252] Add Apache Analytics attributes in DecorationModel

2022-04-19 Thread GitBox


olamy commented on PR #32:
URL: 
https://github.com/apache/maven-doxia-sitetools/pull/32#issuecomment-1102537092

   We already have google so we could at least have Apache related stuff here...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (DOXIASITETOOLS-252) Add Apache Analytics attributes in DecorationModel

2022-04-19 Thread Michael Osipov (Jira)


[ 
https://issues.apache.org/jira/browse/DOXIASITETOOLS-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524265#comment-17524265
 ] 

Michael Osipov commented on DOXIASITETOOLS-252:
---

I consider this to be wrong here. This should be part of {{}} 
element. This isn't really of general interest.

> Add Apache Analytics attributes in DecorationModel
> --
>
> Key: DOXIASITETOOLS-252
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-252
> Project: Maven Doxia Sitetools
>  Issue Type: Improvement
>  Components: Decoration model
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 1.11.2
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [maven-fluido-skin] olamy commented on pull request #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

2022-04-19 Thread GitBox


olamy commented on PR #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22#issuecomment-1102523686

   depends on https://github.com/apache/maven-doxia-sitetools/pull/32


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-fluido-skin] olamy opened a new pull request, #22: [MSKINS-177] Support native apacheAnalyticsSiteId as macro

2022-04-19 Thread GitBox


olamy opened a new pull request, #22:
URL: https://github.com/apache/maven-fluido-skin/pull/22

   Signed-off-by: Olivier Lamy 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MSKINS-177) Support native apacheAnalyticsSiteId as macro

2022-04-19 Thread Olivier Lamy (Jira)


 [ 
https://issues.apache.org/jira/browse/MSKINS-177?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Olivier Lamy updated MSKINS-177:

Fix Version/s: fluido-1.12.0
   (was: fluido-1.11.0)

> Support native apacheAnalyticsSiteId as macro
> -
>
> Key: MSKINS-177
> URL: https://issues.apache.org/jira/browse/MSKINS-177
> Project: Maven Skins
>  Issue Type: Improvement
>  Components: Fluido Skin
>Reporter: Olivier Lamy
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: fluido-1.12.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [maven-doxia-sitetools] olamy opened a new pull request, #32: [DOXIASITETOOLS-252] Add Apache Analytics attributes in DecorationModel

2022-04-19 Thread GitBox


olamy opened a new pull request, #32:
URL: https://github.com/apache/maven-doxia-sitetools/pull/32

   Signed-off-by: Olivier Lamy 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (DOXIASITETOOLS-252) Add Apache Analytics attributes in DecorationModel

2022-04-19 Thread Olivier Lamy (Jira)
Olivier Lamy created DOXIASITETOOLS-252:
---

 Summary: Add Apache Analytics attributes in DecorationModel
 Key: DOXIASITETOOLS-252
 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-252
 Project: Maven Doxia Sitetools
  Issue Type: Improvement
  Components: Decoration model
Reporter: Olivier Lamy
Assignee: Olivier Lamy
 Fix For: 1.11.2






--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Commented] (MPIR-399) Upgrade to Maven 3.2.5

2022-04-19 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MPIR-399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524155#comment-17524155
 ] 

Hudson commented on MPIR-399:
-

Build failed in Jenkins: Maven » Maven TLP » maven-project-info-reports-plugin 
» master #11

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-project-info-reports-plugin/job/master/11/

> Upgrade to Maven 3.2.5
> --
>
> Key: MPIR-399
> URL: https://issues.apache.org/jira/browse/MPIR-399
> Project: Maven Project Info Reports Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.3.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (MPIR-399) Upgrade to Maven 3.2.5

2022-04-19 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPIR-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MPIR-399.
---
Resolution: Fixed

Fixed with 
[f784eef507716c789c2e05a93750c508ce8b9947|https://gitbox.apache.org/repos/asf?p=maven-project-info-reports-plugin.git;a=commit;h=f784eef507716c789c2e05a93750c508ce8b9947].

> Upgrade to Maven 3.2.5
> --
>
> Key: MPIR-399
> URL: https://issues.apache.org/jira/browse/MPIR-399
> Project: Maven Project Info Reports Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.3.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[GitHub] [maven-project-info-reports-plugin] dependabot[bot] opened a new pull request, #34: Bump jackson-datatype-jsr310 from 2.6.4 to 2.9.8 in /src/it/dependencies-java-1.7-and-1.8

2022-04-19 Thread GitBox


dependabot[bot] opened a new pull request, #34:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/34

   Bumps jackson-datatype-jsr310 from 2.6.4 to 2.9.8.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.fasterxml.jackson.datatype:jackson-datatype-jsr310=maven=2.6.4=2.9.8)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   - `@dependabot use these labels` will set the current labels as the default 
for future PRs for this repo and language
   - `@dependabot use these reviewers` will set the current reviewers as the 
default for future PRs for this repo and language
   - `@dependabot use these assignees` will set the current assignees as the 
default for future PRs for this repo and language
   - `@dependabot use this milestone` will set the current milestone as the 
default for future PRs for this repo and language
   
   You can disable automated security fix PRs for this repo from the [Security 
Alerts 
page](https://github.com/apache/maven-project-info-reports-plugin/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-project-info-reports-plugin] asfgit merged pull request #33: Move to maven 3.2.5

2022-04-19 Thread GitBox


asfgit merged PR #33:
URL: https://github.com/apache/maven-project-info-reports-plugin/pull/33


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPIR-415) Wrong old goal name in "Incompatibility Notice" table in website

2022-04-19 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MPIR-415?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17524131#comment-17524131
 ] 

Hudson commented on MPIR-415:
-

Build succeeded in Jenkins: Maven » Maven TLP » 
maven-project-info-reports-plugin » master #10

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-project-info-reports-plugin/job/master/10/

> Wrong old goal name in "Incompatibility Notice" table in website
> 
>
> Key: MPIR-415
> URL: https://issues.apache.org/jira/browse/MPIR-415
> Project: Maven Project Info Reports Plugin
>  Issue Type: Bug
>Reporter: Tilman Hausherr
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.3.0
>
>
> https://maven.apache.org/plugins/maven-project-info-reports-plugin/
> The "Incompatibility Notice" table has "issue-management" twice. I suspect 
> the left one should have been "issue-tracking".



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (MPIR-415) Wrong old goal name in "Incompatibility Notice" table in website

2022-04-19 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPIR-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MPIR-415.
---
Resolution: Fixed

Fixed with 
[62f490b101f01215e39a86f2810679a77249e024|https://gitbox.apache.org/repos/asf?p=maven-project-info-reports-plugin.git;a=commit;h=62f490b101f01215e39a86f2810679a77249e024].

> Wrong old goal name in "Incompatibility Notice" table in website
> 
>
> Key: MPIR-415
> URL: https://issues.apache.org/jira/browse/MPIR-415
> Project: Maven Project Info Reports Plugin
>  Issue Type: Bug
>Reporter: Tilman Hausherr
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.3.0
>
>
> https://maven.apache.org/plugins/maven-project-info-reports-plugin/
> The "Incompatibility Notice" table has "issue-management" twice. I suspect 
> the left one should have been "issue-tracking".



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Assigned] (MPIR-399) Upgrade to Maven 3.2.5

2022-04-19 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPIR-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MPIR-399:
---

Assignee: Tamás Cservenák  (was: Michael Osipov)

> Upgrade to Maven 3.2.5
> --
>
> Key: MPIR-399
> URL: https://issues.apache.org/jira/browse/MPIR-399
> Project: Maven Project Info Reports Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Assignee: Tamás Cservenák
>Priority: Major
> Fix For: 3.3.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Assigned] (MPIR-399) Upgrade to Maven 3.2.5

2022-04-19 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPIR-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MPIR-399:
---

Assignee: Michael Osipov

> Upgrade to Maven 3.2.5
> --
>
> Key: MPIR-399
> URL: https://issues.apache.org/jira/browse/MPIR-399
> Project: Maven Project Info Reports Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (MPIR-399) Upgrade to Maven 3.2.5

2022-04-19 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPIR-399?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MPIR-399:

Fix Version/s: 3.3.0

> Upgrade to Maven 3.2.5
> --
>
> Key: MPIR-399
> URL: https://issues.apache.org/jira/browse/MPIR-399
> Project: Maven Project Info Reports Plugin
>  Issue Type: Dependency upgrade
>Reporter: Elliotte Rusty Harold
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.3.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Updated] (MPIR-415) Wrong old goal name in "Incompatibility Notice" table in website

2022-04-19 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPIR-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MPIR-415:

Fix Version/s: 3.3.0

> Wrong old goal name in "Incompatibility Notice" table in website
> 
>
> Key: MPIR-415
> URL: https://issues.apache.org/jira/browse/MPIR-415
> Project: Maven Project Info Reports Plugin
>  Issue Type: Bug
>Reporter: Tilman Hausherr
>Priority: Trivial
> Fix For: 3.3.0
>
>
> https://maven.apache.org/plugins/maven-project-info-reports-plugin/
> The "Incompatibility Notice" table has "issue-management" twice. I suspect 
> the left one should have been "issue-tracking".



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Assigned] (MPIR-415) Wrong old goal name in "Incompatibility Notice" table in website

2022-04-19 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPIR-415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov reassigned MPIR-415:
---

Assignee: Michael Osipov

> Wrong old goal name in "Incompatibility Notice" table in website
> 
>
> Key: MPIR-415
> URL: https://issues.apache.org/jira/browse/MPIR-415
> Project: Maven Project Info Reports Plugin
>  Issue Type: Bug
>Reporter: Tilman Hausherr
>Assignee: Michael Osipov
>Priority: Trivial
> Fix For: 3.3.0
>
>
> https://maven.apache.org/plugins/maven-project-info-reports-plugin/
> The "Incompatibility Notice" table has "issue-management" twice. I suspect 
> the left one should have been "issue-tracking".



--
This message was sent by Atlassian Jira
(v8.20.1#820001)


[jira] [Closed] (MPIR-400) mvn -pl . clean site site:stage fails when extensions are part of pom.xml

2022-04-19 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPIR-400?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MPIR-400.
---
Fix Version/s: (was: waiting-for-feedback)
   (was: wontfix-candidate)
   Resolution: Incomplete

Information provided, no reaction for almost a year.

> mvn -pl . clean site site:stage fails when extensions are part of pom.xml
> -
>
> Key: MPIR-400
> URL: https://issues.apache.org/jira/browse/MPIR-400
> Project: Maven Project Info Reports Plugin
>  Issue Type: Bug
>  Components: index, modules
>Affects Versions: 3.0.0, 3.1.0, 3.1.1
> Environment: Apache Maven Version: 3.6.3
> Java version: 1.8.0_251, vendor: Oracle Corporation, runtime: C:\Program 
> Files\Java\jdk1.8.0_251\jre
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
>Reporter: Marwa Khabbaz
>Priority: Major
> Attachments: error_log.txt, example.zip, pom_aggregator.xml, 
> pom_sub-module.xml
>
>
> I have a project consisting of an aggregator and a submodule, which inherits 
> directly from the aggregator. I have the following scenarios:
>  * When I execute {{mvn clean site site:stage}} (without {{-pl .}}), the 
> build is successful.
>  * When I leave out the extensions out of the {{pom.xml}}-file of my 
> aggregator and execute the {{mvn -pl . clean site site:stage}}, the build is 
> successful.
>  * When I put in extensions to the {{pom.xml}}-file of my aggregator but 
> leave out the reports for {{index}} and {{modules}} (the only sites that 
> refer to my submodule) by explicitly defining the report set in the 
> {{pom.xml}}-file of the aggregator, the build is successful.
>  * As soon as I put extensions into the {{pom.xml}}-file of my aggregator and 
> leave in the reports for {{index}} and {{modules}}, then execute the build 
> {{mvn -pl . clean site site:stage}} for the aggregator, the build fails with 
> a {{NullPointerException}}.
> I attached the error log of the last scenario and the {{pom.xml}} of the 
> aggregator and its submodule to this ticket. This has never been a problem 
> until the release of {{maven-project-info-reports-plugin 3.0.0}}.
> Hopefully I managed to understandably describe my issue.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)