[GitHub] [maven-release] dependabot[bot] closed pull request #109: Bump maven-parent from 34 to 35
dependabot[bot] closed pull request #109: Bump maven-parent from 34 to 35 URL: https://github.com/apache/maven-release/pull/109 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] dependabot[bot] commented on pull request #109: Bump maven-parent from 34 to 35
dependabot[bot] commented on PR #109: URL: https://github.com/apache/maven-release/pull/109#issuecomment-1109318722 Superseded by #115. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] dependabot[bot] opened a new pull request, #115: Bump maven-parent from 34 to 36
dependabot[bot] opened a new pull request, #115: URL: https://github.com/apache/maven-release/pull/115 Bumps [maven-parent](https://github.com/apache/maven-parent) from 34 to 36. Release notes Sourced from https://github.com/apache/maven-parent/releases;>maven-parent's releases. 36 What's Changed [MPOM-300] switch from GA to ASF Matomo. by https://github.com/bmarwell;>@bmarwell in https://github-redirect.dependabot.com/apache/maven-parent/pull/58;>apache/maven-parent#58 [MPOM-308] Upgrade Maven PMD Plugin from 3.15.0 to 3.16.0 by https://github.com/slawekjaranowski;>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-parent/pull/59;>apache/maven-parent#59 Bump taglist-maven-plugin from 2.4 to 3.0.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/45;>apache/maven-parent#45 Bump maven-jxr-plugin from 3.1.1 to 3.2.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/60;>apache/maven-parent#60 [MPOM-313] execute checkstyle in early phase of the build by https://github.com/olamy;>@olamy in https://github-redirect.dependabot.com/apache/maven-parent/pull/55;>apache/maven-parent#55 [MPOM-314] Upgrade modello-maven-plugin from 1.11 to 2.0.0 by https://github.com/slawekjaranowski;>@slawekjaranowski in https://github-redirect.dependabot.com/apache/maven-parent/pull/61;>apache/maven-parent#61 Bump apache from 25 to 26 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/62;>apache/maven-parent#62 New Contributors https://github.com/bmarwell;>@bmarwell made their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/58;>apache/maven-parent#58 https://github.com/olamy;>@olamy made their first contribution in https://github-redirect.dependabot.com/apache/maven-parent/pull/55;>apache/maven-parent#55 Full Changelog: https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36;>https://github.com/apache/maven-parent/compare/maven-parent-35...maven-parent-36 35 What's Changed docs: remove out of date comment by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-parent/pull/8;>apache/maven-parent#8 [MPOM-252] remove broken mail list archives by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-parent/pull/18;>apache/maven-parent#18 Bump plexus-utils from 3.1.0 to 3.3.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/13;>apache/maven-parent#13 Bump maven-toolchains-plugin from 1.1 to 3.0.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/10;>apache/maven-parent#10 Bump plexus-container-default from 1.0-alpha-30 to 2.1.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/11;>apache/maven-parent#11 Bump plexus-component-annotations from 2.0.0 to 2.1.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/15;>apache/maven-parent#15 Bump mavenPluginToolsVersion from 3.5.2 to 3.6.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/16;>apache/maven-parent#16 Bump modello-maven-plugin from 1.9.1 to 1.11 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/12;>apache/maven-parent#12 Bump maven-jxr-plugin from 2.5 to 3.0.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/9;>apache/maven-parent#9 Bump maven-pmd-plugin from 3.8 to 3.13.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/17;>apache/maven-parent#17 Bump maven-pmd-plugin from 3.14.0 to 3.15.0 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/28;>apache/maven-parent#28 [MPOM-268] - Removed unused property by https://github.com/khmarbaise;>@khmarbaise in https://github-redirect.dependabot.com/apache/maven-parent/pull/29;>apache/maven-parent#29 Bump mavenPluginToolsVersion from 3.6.0 to 3.6.1 by https://github.com/dependabot;>@dependabot in https://github-redirect.dependabot.com/apache/maven-parent/pull/25;>apache/maven-parent#25 [MPOM-270] Fix enforcer plugin by https://github.com/cstamas;>@cstamas in https://github-redirect.dependabot.com/apache/maven-parent/pull/32;>apache/maven-parent#32 [MPOM-271] Add drop legacy dependencies profile by https://github.com/cstamas;>@cstamas in
[GitHub] [maven-release] dependabot[bot] opened a new pull request, #114: Bump plexus-sec-dispatcher from 1.3 to 1.4
dependabot[bot] opened a new pull request, #114: URL: https://github.com/apache/maven-release/pull/114 Bumps plexus-sec-dispatcher from 1.3 to 1.4. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-release] dependabot[bot] opened a new pull request, #113: Bump mockito-core from 2.28.2 to 4.5.1
dependabot[bot] opened a new pull request, #113: URL: https://github.com/apache/maven-release/pull/113 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 4.5.1. Release notes Sourced from https://github.com/mockito/mockito/releases;>mockito-core's releases. v4.5.1 Changelog generated by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog Gradle Plugin 4.5.1 2022-04-21 - https://github.com/mockito/mockito/compare/v4.5.0...v4.5.1;>2 commit(s) by Jeremy Landis, dependabot[bot] Fixes https://github-redirect.dependabot.com/mockito/mockito/issues/2623;>#2623: Use zulu distribution and java 11 for release GHA job [(https://github-redirect.dependabot.com/mockito/mockito/issues/2624;>#2624)](https://github-redirect.dependabot.com/mockito/mockito/pull/2624;>mockito/mockito#2624) Missing errorprone module for 4.5.0 in central as release was done with jdk 8 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2623;>#2623)](https://github-redirect.dependabot.com/mockito/mockito/issues/2623;>mockito/mockito#2623) Bump kotlinVersion from 1.6.20 to 1.6.21 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2622;>#2622)](https://github-redirect.dependabot.com/mockito/mockito/pull/2622;>mockito/mockito#2622) Missing net.bytebuddy.utility.GraalImageCode exception If you encounter any issues with missing ByteBuddy classes, make sure you are using ByteBuddy 1.12 or higher. v4.5.0 Changelog generated by https://github.com/shipkit/shipkit-changelog;>Shipkit Changelog Gradle Plugin 4.5.0 2022-04-19 - https://github.com/mockito/mockito/compare/v4.4.0...v4.5.0;>15 commit(s) by Andrei Silviu Dragnea, Rafael Winterhalter, Rick Ossendrijver, dependabot[bot] Bump versions.errorprone from 2.13.0 to 2.13.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2621;>#2621)](https://github-redirect.dependabot.com/mockito/mockito/pull/2621;>mockito/mockito#2621) Bump versions.errorprone from 2.12.1 to 2.13.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2619;>#2619)](https://github-redirect.dependabot.com/mockito/mockito/pull/2619;>mockito/mockito#2619) Groovy inline [(https://github-redirect.dependabot.com/mockito/mockito/issues/2618;>#2618)](https://github-redirect.dependabot.com/mockito/mockito/pull/2618;>mockito/mockito#2618) Bump actions/setup-java from 2 to 3 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2615;>#2615)](https://github-redirect.dependabot.com/mockito/mockito/pull/2615;>mockito/mockito#2615) Bump versions.bytebuddy from 1.12.8 to 1.12.9 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2614;>#2614)](https://github-redirect.dependabot.com/mockito/mockito/pull/2614;>mockito/mockito#2614) Support subclass mocks on Graal VM. [(https://github-redirect.dependabot.com/mockito/mockito/issues/2613;>#2613)](https://github-redirect.dependabot.com/mockito/mockito/pull/2613;>mockito/mockito#2613) Bump com.diffplug.spotless from 6.4.1 to 6.4.2 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2611;>#2611)](https://github-redirect.dependabot.com/mockito/mockito/pull/2611;>mockito/mockito#2611) Bump kotlinx-coroutines-core from 1.6.0-native-mt to 1.6.1-native-mt [(https://github-redirect.dependabot.com/mockito/mockito/issues/2609;>#2609)](https://github-redirect.dependabot.com/mockito/mockito/pull/2609;>mockito/mockito#2609) Bump versions.errorprone from 2.10.0 to 2.12.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2608;>#2608)](https://github-redirect.dependabot.com/mockito/mockito/pull/2608;>mockito/mockito#2608) Bump kotlinVersion from 1.6.10 to 1.6.20 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2607;>#2607)](https://github-redirect.dependabot.com/mockito/mockito/pull/2607;>mockito/mockito#2607) Bump com.diffplug.spotless from 6.4.0 to 6.4.1 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2606;>#2606)](https://github-redirect.dependabot.com/mockito/mockito/pull/2606;>mockito/mockito#2606) Bump com.diffplug.spotless from 6.3.0 to 6.4.0 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2605;>#2605)](https://github-redirect.dependabot.com/mockito/mockito/pull/2605;>mockito/mockito#2605) Bump org.eclipse.osgi from 3.17.100 to 3.17.200 [(https://github-redirect.dependabot.com/mockito/mockito/issues/2597;>#2597)](https://github-redirect.dependabot.com/mockito/mockito/pull/2597;>mockito/mockito#2597) Deprecate ListUtil and Fields classes [(https://github-redirect.dependabot.com/mockito/mockito/issues/2593;>#2593)](https://github-redirect.dependabot.com/mockito/mockito/pull/2593;>mockito/mockito#2593) mockito-errorprone seems not compatible with ErrorProne 2.11.0
[jira] [Closed] (MRELEASE-1022) release:prepare does not honor project.dev version predefined in release.properties
[
https://issues.apache.org/jira/browse/MRELEASE-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy closed MRELEASE-1022.
--
Resolution: Fixed
> release:prepare does not honor project.dev version predefined in
> release.properties
> ---
>
> Key: MRELEASE-1022
> URL: https://issues.apache.org/jira/browse/MRELEASE-1022
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 2.5.3
> Environment:
> C:\Users\fandre\Documents\MXW\RD\RD>C:\ASF\apache-maven-3.6.1\bin\mvn
> --version
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T21:00:29+02:00)
> Maven home: C:\ASF\apache-maven-3.6.1\bin\..
> Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_181\jre
> Default locale: fr_FR, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: zosrothko
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.0.0-M6
>
> Attachments: mvn.log, pom.xml, pom.xml, pom.xml, release.properties,
> release.properties.dryRun
>
>
> Hi
> Using the release.properties defined as below
> {code:java}
> scm.tag=rd-2019.3
> project.rel.com.scort\:rd=2019.3
> project.dev.com.scort\:rd=2019.4-SNAPSHOT
> project.rel.com.scort.merge\:mergejar=1.2.0
> project.dev.com.scort.merge\:mergejar=1.2.0
> project.rel.com.scort.plugins\:mergejar=1.2.0
> project.dev.com.scort.plugins\:mergejar=1.2.0
> {code}
> with the command
> {code:java}
> mvn -B release:prepare -DdryRun=true
> {code}
> the maven-release-plugin does not use the specified 'project.dev' version to
> update the pom in the second phase. Here the log
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] RD
> [pom]
> [INFO] Jar Merger
> [jar]
> [INFO] MAVEN plugin to merge jar
> [maven-plugin]
> [INFO]
> [INFO] < com.scort:rd
> >
> [INFO] Building RD 2019.3-SNAPSHOT
> [1/3]
> [INFO] [ pom
> ]-
> [INFO]
> [INFO] --- maven-release-plugin:2.5.3:prepare (default-cli) @ rd ---
> [INFO] Verifying that there are no local modifications...
> [INFO] ignoring changes on: **\pom.xml.next, **\release.properties,
> **\pom.xml.branch, **\pom.xml.tag, **\pom.xml.backup, **\pom.xml.releaseBackup
> [INFO] Executing: cmd.exe /X /C "git rev-parse --show-toplevel"
> [INFO] Working directory: C:\Users\fandre\Documents\MXW\RD\RD
> [INFO] Executing: cmd.exe /X /C "git status --porcelain ."
> [INFO] Working directory: C:\Users\fandre\Documents\MXW\RD\RD
> [WARNING] Ignoring unrecognized line: ?? RD/release.properties.copy
> [INFO] Checking dependencies and plugins for snapshots ...
> [INFO] Transforming 'RD'...
> [INFO] Updating ${antmergejar} to 1.2.0
> [INFO] Updating ${mavenmergejar} to 1.2.0
> [INFO] Transforming 'Jar Merger'...
> [INFO] Transforming 'MAVEN plugin to merge jar'...
> [INFO] Not generating release POMs
> [INFO] Executing preparation goals - since this is simulation mode it is
> running against the original project, not the rewritten ones
> [INFO] Executing goals 'clean verify'...
> [INFO] [INFO] Scanning for projects...
> [INFO] [INFO]
>
> [INFO] [INFO] Reactor Build Order:
> [INFO] [INFO]
> [INFO] [INFO] RD
> [pom]
> [INFO] [INFO] Jar Merger
> [jar]
> [INFO] [INFO] MAVEN plugin to merge jar
> [maven-plugin]
> [INFO] [INFO]
> [INFO] [INFO] < com.scort:rd
> >
> [INFO] [INFO] Building RD 2019.3-SNAPSHOT
> [1/3]
> [INFO] [INFO] [ pom
> ]-
> [INFO] [INFO]
> [INFO] [INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @ rd ---
> [INFO] [INFO]
> [INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ rd ---
> [INFO] [INFO]
> [INFO] [INFO] --< com.scort.merge:mergejar
> >--
> [INFO] [INFO] Building Jar Merger 1.2.0
> [2/3]
> [INFO] [INFO] [ jar
> ]-
> [INFO] [INFO]
[jira] [Commented] (MRELEASE-1022) release:prepare does not honor project.dev version predefined in release.properties
[
https://issues.apache.org/jira/browse/MRELEASE-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527833#comment-17527833
]
Olivier Lamy commented on MRELEASE-1022:
PR merged thanks!
> release:prepare does not honor project.dev version predefined in
> release.properties
> ---
>
> Key: MRELEASE-1022
> URL: https://issues.apache.org/jira/browse/MRELEASE-1022
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 2.5.3
> Environment:
> C:\Users\fandre\Documents\MXW\RD\RD>C:\ASF\apache-maven-3.6.1\bin\mvn
> --version
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T21:00:29+02:00)
> Maven home: C:\ASF\apache-maven-3.6.1\bin\..
> Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_181\jre
> Default locale: fr_FR, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: zosrothko
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.0.0-M6
>
> Attachments: mvn.log, pom.xml, pom.xml, pom.xml, release.properties,
> release.properties.dryRun
>
>
> Hi
> Using the release.properties defined as below
> {code:java}
> scm.tag=rd-2019.3
> project.rel.com.scort\:rd=2019.3
> project.dev.com.scort\:rd=2019.4-SNAPSHOT
> project.rel.com.scort.merge\:mergejar=1.2.0
> project.dev.com.scort.merge\:mergejar=1.2.0
> project.rel.com.scort.plugins\:mergejar=1.2.0
> project.dev.com.scort.plugins\:mergejar=1.2.0
> {code}
> with the command
> {code:java}
> mvn -B release:prepare -DdryRun=true
> {code}
> the maven-release-plugin does not use the specified 'project.dev' version to
> update the pom in the second phase. Here the log
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] RD
> [pom]
> [INFO] Jar Merger
> [jar]
> [INFO] MAVEN plugin to merge jar
> [maven-plugin]
> [INFO]
> [INFO] < com.scort:rd
> >
> [INFO] Building RD 2019.3-SNAPSHOT
> [1/3]
> [INFO] [ pom
> ]-
> [INFO]
> [INFO] --- maven-release-plugin:2.5.3:prepare (default-cli) @ rd ---
> [INFO] Verifying that there are no local modifications...
> [INFO] ignoring changes on: **\pom.xml.next, **\release.properties,
> **\pom.xml.branch, **\pom.xml.tag, **\pom.xml.backup, **\pom.xml.releaseBackup
> [INFO] Executing: cmd.exe /X /C "git rev-parse --show-toplevel"
> [INFO] Working directory: C:\Users\fandre\Documents\MXW\RD\RD
> [INFO] Executing: cmd.exe /X /C "git status --porcelain ."
> [INFO] Working directory: C:\Users\fandre\Documents\MXW\RD\RD
> [WARNING] Ignoring unrecognized line: ?? RD/release.properties.copy
> [INFO] Checking dependencies and plugins for snapshots ...
> [INFO] Transforming 'RD'...
> [INFO] Updating ${antmergejar} to 1.2.0
> [INFO] Updating ${mavenmergejar} to 1.2.0
> [INFO] Transforming 'Jar Merger'...
> [INFO] Transforming 'MAVEN plugin to merge jar'...
> [INFO] Not generating release POMs
> [INFO] Executing preparation goals - since this is simulation mode it is
> running against the original project, not the rewritten ones
> [INFO] Executing goals 'clean verify'...
> [INFO] [INFO] Scanning for projects...
> [INFO] [INFO]
>
> [INFO] [INFO] Reactor Build Order:
> [INFO] [INFO]
> [INFO] [INFO] RD
> [pom]
> [INFO] [INFO] Jar Merger
> [jar]
> [INFO] [INFO] MAVEN plugin to merge jar
> [maven-plugin]
> [INFO] [INFO]
> [INFO] [INFO] < com.scort:rd
> >
> [INFO] [INFO] Building RD 2019.3-SNAPSHOT
> [1/3]
> [INFO] [INFO] [ pom
> ]-
> [INFO] [INFO]
> [INFO] [INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @ rd ---
> [INFO] [INFO]
> [INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ rd ---
> [INFO] [INFO]
> [INFO] [INFO] --< com.scort.merge:mergejar
> >--
> [INFO] [INFO] Building Jar Merger 1.2.0
> [2/3]
> [INFO] [INFO] [ jar
>
[jira] [Assigned] (MRELEASE-1022) release:prepare does not honor project.dev version predefined in release.properties
[
https://issues.apache.org/jira/browse/MRELEASE-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Olivier Lamy reassigned MRELEASE-1022:
--
Assignee: Olivier Lamy
> release:prepare does not honor project.dev version predefined in
> release.properties
> ---
>
> Key: MRELEASE-1022
> URL: https://issues.apache.org/jira/browse/MRELEASE-1022
> Project: Maven Release Plugin
> Issue Type: Bug
> Components: prepare
>Affects Versions: 2.5.3
> Environment:
> C:\Users\fandre\Documents\MXW\RD\RD>C:\ASF\apache-maven-3.6.1\bin\mvn
> --version
> Apache Maven 3.6.1 (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555;
> 2019-04-04T21:00:29+02:00)
> Maven home: C:\ASF\apache-maven-3.6.1\bin\..
> Java version: 1.8.0_181, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_181\jre
> Default locale: fr_FR, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: zosrothko
>Assignee: Olivier Lamy
>Priority: Major
> Fix For: 3.0.0-M6
>
> Attachments: mvn.log, pom.xml, pom.xml, pom.xml, release.properties,
> release.properties.dryRun
>
>
> Hi
> Using the release.properties defined as below
> {code:java}
> scm.tag=rd-2019.3
> project.rel.com.scort\:rd=2019.3
> project.dev.com.scort\:rd=2019.4-SNAPSHOT
> project.rel.com.scort.merge\:mergejar=1.2.0
> project.dev.com.scort.merge\:mergejar=1.2.0
> project.rel.com.scort.plugins\:mergejar=1.2.0
> project.dev.com.scort.plugins\:mergejar=1.2.0
> {code}
> with the command
> {code:java}
> mvn -B release:prepare -DdryRun=true
> {code}
> the maven-release-plugin does not use the specified 'project.dev' version to
> update the pom in the second phase. Here the log
> {code:java}
> [INFO] Scanning for projects...
> [INFO]
>
> [INFO] Reactor Build Order:
> [INFO]
> [INFO] RD
> [pom]
> [INFO] Jar Merger
> [jar]
> [INFO] MAVEN plugin to merge jar
> [maven-plugin]
> [INFO]
> [INFO] < com.scort:rd
> >
> [INFO] Building RD 2019.3-SNAPSHOT
> [1/3]
> [INFO] [ pom
> ]-
> [INFO]
> [INFO] --- maven-release-plugin:2.5.3:prepare (default-cli) @ rd ---
> [INFO] Verifying that there are no local modifications...
> [INFO] ignoring changes on: **\pom.xml.next, **\release.properties,
> **\pom.xml.branch, **\pom.xml.tag, **\pom.xml.backup, **\pom.xml.releaseBackup
> [INFO] Executing: cmd.exe /X /C "git rev-parse --show-toplevel"
> [INFO] Working directory: C:\Users\fandre\Documents\MXW\RD\RD
> [INFO] Executing: cmd.exe /X /C "git status --porcelain ."
> [INFO] Working directory: C:\Users\fandre\Documents\MXW\RD\RD
> [WARNING] Ignoring unrecognized line: ?? RD/release.properties.copy
> [INFO] Checking dependencies and plugins for snapshots ...
> [INFO] Transforming 'RD'...
> [INFO] Updating ${antmergejar} to 1.2.0
> [INFO] Updating ${mavenmergejar} to 1.2.0
> [INFO] Transforming 'Jar Merger'...
> [INFO] Transforming 'MAVEN plugin to merge jar'...
> [INFO] Not generating release POMs
> [INFO] Executing preparation goals - since this is simulation mode it is
> running against the original project, not the rewritten ones
> [INFO] Executing goals 'clean verify'...
> [INFO] [INFO] Scanning for projects...
> [INFO] [INFO]
>
> [INFO] [INFO] Reactor Build Order:
> [INFO] [INFO]
> [INFO] [INFO] RD
> [pom]
> [INFO] [INFO] Jar Merger
> [jar]
> [INFO] [INFO] MAVEN plugin to merge jar
> [maven-plugin]
> [INFO] [INFO]
> [INFO] [INFO] < com.scort:rd
> >
> [INFO] [INFO] Building RD 2019.3-SNAPSHOT
> [1/3]
> [INFO] [INFO] [ pom
> ]-
> [INFO] [INFO]
> [INFO] [INFO] --- maven-clean-plugin:2.6.1:clean (default-clean) @ rd ---
> [INFO] [INFO]
> [INFO] [INFO] --- maven-enforcer-plugin:1.4.1:enforce (enforce-maven) @ rd ---
> [INFO] [INFO]
> [INFO] [INFO] --< com.scort.merge:mergejar
> >--
> [INFO] [INFO] Building Jar Merger 1.2.0
> [2/3]
> [INFO] [INFO] [ jar
> ]-
>
[GitHub] [maven-release] olamy merged pull request #111: [MRELEASE-1022] Use versions defined in `release.properties` when doing `release:prepare`
olamy merged PR #111: URL: https://github.com/apache/maven-release/pull/111 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #529: [SUREFIRE-2076] BufferOverflowException when encoding message with null runMode
Tibor17 commented on PR #529: URL: https://github.com/apache/maven-surefire/pull/529#issuecomment-1109147928 After the #518 is merged, you have to rebase this PR. Then we will run the CI again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #518: [SUREFIRE-2058] Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging
Tibor17 commented on PR #518: URL: https://github.com/apache/maven-surefire/pull/518#issuecomment-1109146740 Let's run the CI build... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-filtering] ImadBL opened a new pull request, #31: Support JSON format for parameter filter files #MRESOURCES-284
ImadBL opened a new pull request, #31: URL: https://github.com/apache/maven-filtering/pull/31 Hi, This concerns the **maven-resources-plugin** (3.2.1-SNAPSHOT) and **maven-filtering** (3.3.0-SNAPSHOT) plugins. with this evolution it is now possible to add configuration files with json format. the second part of this evolution is to have to use a one configuration json file for all environments (dev, preprod, prod...etc ) for more example check: MRESOURCES-284 please note that you must accept the PR first for **maven-filtering** (3.3.0-SNAPSHOT) because **maven-resources-plugin** (3.2.1-SNAPSHOT) need **maven-filtering** (3.3.0-SNAPSHOT) if you have any questions do not hesitate, hoping that I have detailed well Best regards Imad BELMOUJAHID @ImadBL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resources-plugin] ImadBL opened a new pull request, #20: Support JSON format for parameter filter files #MRESOURCES-284
ImadBL opened a new pull request, #20: URL: https://github.com/apache/maven-resources-plugin/pull/20 Hi, This concerns the **maven-resources-plugin** (3.2.1-SNAPSHOT) and **maven-filtering** (3.3.0-SNAPSHOT) plugins. with this evolution it is now possible to add configuration files with json format. the second part of this evolution is to have to use a one configuration json file for all environments (dev, preprod, prod...etc ) for more example check: MRESOURCES-284 please note that you must accept the PR first for **maven-filtering** (3.3.0-SNAPSHOT) because **maven-resources-plugin** (3.2.1-SNAPSHOT) need **maven-filtering** (3.3.0-SNAPSHOT) if you have any questions do not hesitate, hoping that I have detailed well Best regards Imad BELMOUJAHID @ImadBL -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MRESOURCES-284) Support JSON format for parameter filter files
[
https://issues.apache.org/jira/browse/MRESOURCES-284?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Imad BELMOUJAHID updated MRESOURCES-284:
Description:
I wanted to trace a new evolution that I added recently. This concerns the
maven-resources-plugin (3.2.1-SNAPSHOT) and maven-filtering (3.3.0-SNAPSHOT)
plugins.
with this evolution it is now possible to add configuration files with json
format. the second part of the evolution is to have to use a single
configuration json file for all environments (dev, preprod, prod)
Example of use:
{code:java}
org.apache.maven.plugins
maven-resources-plugin
${maven-resources-plugin.version}
compile
resources
dev
@_*_@
${project.basedir}/src/main/properties/test.json
src/main/resources
true
{code}
dev : four determine the environment if the json file
contains multiple environments. if you want to use multiple files json (one for
each environment), you can remove this parameter and add the full path from the
root node in the ressource file (application.yml).
Example test.json:
{code:java}
{
"dev" : {
"type" : "toto",
"key2" : "value2",
"key3" : {
"key4" : "value4"
}
},
"qualif" : {
"type2" : "toto1",
"key5" : "value7",
"key7" : {
"key8" : "value7"
}
}
} {code}
Example ressource file: application.yml
{code:java}
spring:
profiles: @_key3.key4_@
toto: @_type_@
tata: @_key2_@ {code}
Example result:
{code:java}
spring:
profiles: value4
toto: toto
tata: value2 {code}
I will send the PR
thanks
was:
I wanted to trace a new evolution that I added recently. This concerns the
maven-resources-plugin (3.2.1-SNAPSHOT) and maven-filtering (3.3.0-SNAPSHOT)
plugins.
with this evolution it is now possible to add configuration files with json
format. the second part of the evolution is to have to use a single
configuration json file for all environments (dev, preprod, prod)
Example of use:
{code:java}
org.apache.maven.plugins
maven-resources-plugin
${maven-resources-plugin.version}
compile
resources
dev
@_*_@
${project.basedir}/src/main/properties/test.json
src/main/resources
true
{code}
dev : four determine the environment if the json file
contains multiple environments. if you want to use multiple files jdon (one for
each environment), you can remove this parameter and add the full path from the
root node in the ressource file (application.yml).
Example test.json:
{code:java}
{
"dev" : {
"type" : "toto",
"key2" : "value2",
"key3" : {
"key4" : "value4"
}
},
"qualif" : {
"type2" : "toto1",
"key5" : "value7",
"key7" : {
"key8" : "value7"
}
}
} {code}
Example ressource file: application.yml
{code:java}
spring:
profiles: @_key3.key4_@
toto: @_type_@
tata: @_key2_@ {code}
Example result:
{code:java}
spring:
profiles: value4
toto: toto
tata: value2 {code}
I will send the PR
thanks
> Support JSON format for parameter filter files
> --
>
> Key: MRESOURCES-284
> URL: https://issues.apache.org/jira/browse/MRESOURCES-284
> Project: Maven Resources Plugin
> Issue Type: New Feature
> Components: filtering
>Affects Versions: 3.2.0
>Reporter: Imad BELMOUJAHID
>Priority: Major
> Labels: features
> Original Estimate: 96h
> Remaining Estimate: 96h
>
> I wanted to trace a new evolution that I added recently. This concerns the
> maven-resources-plugin (3.2.1-SNAPSHOT) and maven-filtering (3.3.0-SNAPSHOT)
> plugins.
> with this evolution it is now possible to add configuration files with json
> format. the second part of the evolution is to have to use a single
> configuration json file for all environments (dev, preprod, prod)
> Example of use:
>
> {code:java}
>
>
> org.apache.maven.plugins
> maven-resources-plugin
> ${maven-resources-plugin.version}
>
[jira] [Created] (MRESOURCES-284) Support JSON format for parameter filter files
Imad BELMOUJAHID created MRESOURCES-284:
---
Summary: Support JSON format for parameter filter files
Key: MRESOURCES-284
URL: https://issues.apache.org/jira/browse/MRESOURCES-284
Project: Maven Resources Plugin
Issue Type: New Feature
Components: filtering
Affects Versions: 3.2.0
Reporter: Imad BELMOUJAHID
I wanted to trace a new evolution that I added recently. This concerns the
maven-resources-plugin (3.2.1-SNAPSHOT) and maven-filtering (3.3.0-SNAPSHOT)
plugins.
with this evolution it is now possible to add configuration files with json
format. the second part of the evolution is to have to use a single
configuration json file for all environments (dev, preprod, prod)
Example of use:
{code:java}
org.apache.maven.plugins
maven-resources-plugin
${maven-resources-plugin.version}
compile
resources
dev
@_*_@
${project.basedir}/src/main/properties/test.json
src/main/resources
true
{code}
dev : four determine the environment if the json file
contains multiple environments. if you want to use multiple files jdon (one for
each environment), you can remove this parameter and add the full path from the
root node in the ressource file (application.yml).
Example test.json:
{code:java}
{
"dev" : {
"type" : "toto",
"key2" : "value2",
"key3" : {
"key4" : "value4"
}
},
"qualif" : {
"type2" : "toto1",
"key5" : "value7",
"key7" : {
"key8" : "value7"
}
}
} {code}
Example ressource file: application.yml
{code:java}
spring:
profiles: @_key3.key4_@
toto: @_type_@
tata: @_key2_@ {code}
Example result:
{code:java}
spring:
profiles: value4
toto: toto
tata: value2 {code}
I will send the PR
thanks
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-dependency-tree] slachiewicz merged pull request #14: Bump maven-project-info-reports-plugin from 3.1.2 to 3.2.2
slachiewicz merged PR #14: URL: https://github.com/apache/maven-dependency-tree/pull/14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-tree] dependabot[bot] commented on pull request #12: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2
dependabot[bot] commented on PR #12: URL: https://github.com/apache/maven-dependency-tree/pull/12#issuecomment-1109103003 Superseded by #18. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-tree] dependabot[bot] opened a new pull request, #18: Bump maven-javadoc-plugin from 3.3.1 to 3.4.0
dependabot[bot] opened a new pull request, #18: URL: https://github.com/apache/maven-dependency-tree/pull/18 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.3.1 to 3.4.0. Release notes Sourced from https://github.com/apache/maven-javadoc-plugin/releases;>maven-javadoc-plugin's releases. 3.3.2 What's Changed [MJAVADOC-530] - Clean up additionalparam documentation by https://github.com/marschall;>@marschall in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/6;>apache/maven-javadoc-plugin#6 [MJAVADOC-538] Filter out 'Picked up' by https://github.com/risdenk;>@risdenk in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/11;>apache/maven-javadoc-plugin#11 [MJAVADOC-546] Allow to generate report in Spanish locale by https://github.com/belingueres;>@belingueres in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/12;>apache/maven-javadoc-plugin#12 [MJAVADOC-537] Explicitly the batchMode to true by https://github.com/joshiste;>@joshiste in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/7;>apache/maven-javadoc-plugin#7 fix mailing list url in README by https://github.com/rgdoliveira;>@rgdoliveira in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/13;>apache/maven-javadoc-plugin#13 [MJAVADOC-544] - Changed behaviour of Javadoc for temporary files encoding (options, argfile, ...) by https://github.com/michael-st;>@michael-st in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/10;>apache/maven-javadoc-plugin#10 [MJAVADOC-444] add aggregate-no-fork and aggregate-test-no-fork for non-forking versions of aggregate goals. by https://github.com/busbey;>@busbey in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/2;>apache/maven-javadoc-plugin#2 Avoid converting separator characters into newline. by https://github.com/cowwoc;>@cowwoc in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/19;>apache/maven-javadoc-plugin#19 [MJAVADOC-577] Fixed typos in User Guide. by https://github.com/glqdlt;>@glqdlt in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/20;>apache/maven-javadoc-plugin#20 Fix typo in additionalDependencies documentation by https://github.com/britter;>@britter in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/23;>apache/maven-javadoc-plugin#23 Add missing @since tags to sourceFile[Includes|Excludes] by https://github.com/britter;>@britter in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/24;>apache/maven-javadoc-plugin#24 Added example of --add-modules to aggregate FAQ. by https://github.com/cowwoc;>@cowwoc in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/18;>apache/maven-javadoc-plugin#18 Remove space typo in markdown by https://github.com/nrbw;>@nrbw in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/29;>apache/maven-javadoc-plugin#29 [MJAVADOC-620] Do not ignore JARs w/o module info when building classpath by https://github.com/fwienber;>@fwienber in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/35;>apache/maven-javadoc-plugin#35 [MJAVADOC-626] Add a stale javadoc detection mechanism by https://github.com/gnodet;>@gnodet in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/33;>apache/maven-javadoc-plugin#33 [MJAVADOC-613] exclude skipped modules from javadoc aggregate by https://github.com/olamy;>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/36;>apache/maven-javadoc-plugin#36 [MJAVADOC-636] exclude some modules from aggregated javadoc by https://github.com/olamy;>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/37;>apache/maven-javadoc-plugin#37 [MJAVADOC-639] include requires static from external dependencies for all modules by https://github.com/olamy;>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/38;>apache/maven-javadoc-plugin#38 [MJAVADOC-638] upgrade Doxia Sitetools to 1.9.2 to remove dependency on Struts by https://github.com/olamy;>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/39;>apache/maven-javadoc-plugin#39 MJAVADOC-610 by https://github.com/olamy;>@olamy in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/40;>apache/maven-javadoc-plugin#40 [MJAVADOC-644] Properly close DirectoryStream by https://github.com/britter;>@britter in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/41;>apache/maven-javadoc-plugin#41 update qdox by https://github.com/elharo;>@elharo in https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/pull/42;>apache/maven-javadoc-plugin#42 update doxia by
[GitHub] [maven-dependency-tree] dependabot[bot] closed pull request #12: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2
dependabot[bot] closed pull request #12: Bump maven-javadoc-plugin from 3.3.1 to 3.3.2 URL: https://github.com/apache/maven-dependency-tree/pull/12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1016) Transitive provided dependencies are not removed from collected dependency graph
[ https://issues.apache.org/jira/browse/MSHARED-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527769#comment-17527769 ] Daniel Norberg commented on MSHARED-1016: - [~rfscholte] would you be able to take a look at this? > Transitive provided dependencies are not removed from collected dependency > graph > > > Key: MSHARED-1016 > URL: https://issues.apache.org/jira/browse/MSHARED-1016 > Project: Maven Shared Components > Issue Type: Bug > Components: maven-dependency-tree >Affects Versions: maven-dependency-tree-3.1.0 >Reporter: Daniel Norberg >Priority: Major > > DependencyCollectorBuilder#collectDependencyGraph returns a dependency graph > containing transitive provided scope dependencies. This is inconsistent with > Maven behavior, which removes transitive provided scope dependencies from the > dependency graph: > [https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java#L80|https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java#L80.] > This might be the root cause of > https://issues.apache.org/jira/browse/MENFORCER-402 and > https://issues.apache.org/jira/browse/MENFORCER-394 > Note that transitive test scope dependencies are correctly filtered out using > a dependency selector. > It seems to me that we can add another dependency selector to also filter out > transitive provided scope dependencies: > [https://github.com/apache/maven-dependency-tree/blob/7a1a12533ac6898fcb3dacbcf2466ef71d11c43a/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven31DependencyCollectorBuilder.java#L108|https://github.com/apache/maven-dependency-tree/blob/master/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven31DependencyCollectorBuilder.java#L108] > [https://github.com/apache/maven-dependency-tree/blob/7a1a12533ac6898fcb3dacbcf2466ef71d11c43a/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven3DependencyCollectorBuilder.java#L108] > I have submitted a PR to do this: > [https://github.com/apache/maven-dependency-tree/pull/9] > > > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-surefire] Tibor17 commented on pull request #527: [SUREFIRE-2077] Allow consecutive spaces in argLine
Tibor17 commented on PR #527: URL: https://github.com/apache/maven-surefire/pull/527#issuecomment-1109032624 The initial problem was with tabs in CLI. This was fixed in [SUREFIRE-2063](https://issues.apache.org/jira/browse/SUREFIRE-2063) but it was not a real fix because it was not a real bug. It was not a real bug, it was just an improvement because the CLI and the platform can see the tab as collision, in JPMS to be concrete, and hard to understand for most of the common users. Even Maarten did not understand the issue immediately and he found the cause finally. So we make these treatments in order to come over the user troubles. We can argue in a loop and everybody may have a different opinion about these details, how to espace white characters, and what characters should be considered, etc. I believe that having \t and maybe new line characters is the issue which origins in the POM itself and not in this code. So, if it is this place of the root cause then it should be fixed there as well. Maybe some warning would be helpful, and maybe enough, just my thoughts. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] aalmiray commented on pull request #620: Reapply Refactor build and release workflows apache#574
aalmiray commented on PR #620: URL: https://github.com/apache/maven-mvnd/pull/620#issuecomment-1108956668 It depends. How are those binaries normally published? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] sbabcoc commented on pull request #528: SUREFIRE-2075: Only set thread count if specified in configuration
sbabcoc commented on PR #528: URL: https://github.com/apache/maven-surefire/pull/528#issuecomment-1108912592 @Tibor17 Also, I was under the impression that the reason for rejecting this change previously was that it was out of scope for resolution of SUREFIRE-2064, not that the rationale for this change was being questioned. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] mthmulders commented on pull request #527: [SUREFIRE-2077] Allow consecutive spaces in argLine
mthmulders commented on PR #527: URL: https://github.com/apache/maven-surefire/pull/527#issuecomment-1108908741 Let's have the conversation in JIRA, and when we have a decision, see if this implementation (still) makes sense. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2063) Adding argLine with tab characters fails
[
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527707#comment-17527707
]
Maarten Mulders commented on SUREFIRE-2063:
---
Moved to SUREFIRE-2077 - please share your thoughts, [~tibordigana] and
[~marcphilipp].
> Adding argLine with tab characters fails
>
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Assignee: Maarten Mulders
>Priority: Blocker
> Fix For: 3.0.0-M7
>
>
> Since v3.3.0-M6 fails when using to export or open a package. The
> failure is produced when using --add-opens or --add-exports in .
> The execution doesn't fail with v3.3.0-M5 or earlier.
> As an example, it fails when using the following :
> {code:java}
>
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
>
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (dev) on project
> testing:
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (SUREFIRE-2077) argLine with two spaces doesn't work
Maarten Mulders created SUREFIRE-2077:
-
Summary: argLine with two spaces doesn't work
Key: SUREFIRE-2077
URL: https://issues.apache.org/jira/browse/SUREFIRE-2077
Project: Maven Surefire
Issue Type: Bug
Components: process forking
Reporter: Maarten Mulders
Reported by [~marcphilipp]:
The fix for SUREFIRE-2063 breaks valid but questionable use cases such as
{code:xml}
"-DpropertyKey=value with 2 spaces"{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-surefire] sbabcoc commented on pull request #528: SUREFIRE-2075: Only set thread count if specified in configuration
sbabcoc commented on PR #528: URL: https://github.com/apache/maven-surefire/pull/528#issuecomment-1108905304 @Tibor17 The [threadCount] value is ignored if not running in parallel mode; from [org.testng.TestRunner] : `int threadCount = parallel ? xmlTest.getThreadCount() : 1;` I'm not clear why a default thread count of 5 doesn't make sense. Setting the default value to 1 is what doesn't make sense to me, because this will produce sequential execution behavior in configurations that specify parallel execution without explicitly specifying a thread count value. As it's currently implemented, the Surefire TestNG configurator override the default thread count value established by the TestNG framework, altering the default parallel execution behavior. This also contradicts the Surefire documentation. With my revisions in place, the documented default thread count is used, and all of the unit tests and integration tests run successfully. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWAR-454) Upgrade Parent to 36
[ https://issues.apache.org/jira/browse/MWAR-454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527702#comment-17527702 ] Hudson commented on MWAR-454: - Build succeeded in Jenkins: Maven » Maven TLP » maven-war-plugin » master #8 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-war-plugin/job/master/8/ > Upgrade Parent to 36 > > > Key: MWAR-454 > URL: https://issues.apache.org/jira/browse/MWAR-454 > Project: Maven WAR Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-mvnd] gnodet commented on pull request #620: Reapply Refactor build and release workflows apache#574
gnodet commented on PR #620: URL: https://github.com/apache/maven-mvnd/pull/620#issuecomment-1108891813 [aalmiray](https://github.com/aalmiray) is there a way to publish snapshots to the official apache snapshot repository or do I have to file a request to ASF infra to allow the usage of the GitHub token ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MWAR-454) Upgrade Parent to 36
[ https://issues.apache.org/jira/browse/MWAR-454?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MWAR-454. Resolution: Fixed > Upgrade Parent to 36 > > > Key: MWAR-454 > URL: https://issues.apache.org/jira/browse/MWAR-454 > Project: Maven WAR Plugin > Issue Type: Dependency upgrade >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.4.0 > > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-war-plugin] slawekjaranowski merged pull request #25: [MWAR-454] Upgrade Parent to 36
slawekjaranowski merged PR #25: URL: https://github.com/apache/maven-war-plugin/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-indexer] slachiewicz commented on pull request #200: Update to Lucene 9.1.0
slachiewicz commented on PR #200: URL: https://github.com/apache/maven-indexer/pull/200#issuecomment-1108872421 Always this can be first, independent subproject migrated to newer java :-) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2068) System.out.println() causes BufferOverflow
[
https://issues.apache.org/jira/browse/SUREFIRE-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527674#comment-17527674
]
Zoltan Meze commented on SUREFIRE-2068:
---
Test execution on [^surefire-buffer-overflow.zip] is passing on latest master
([2657a3233|https://github.com/apache/maven-surefire/commit/2657a32332551393beedc8a87d13a124238e8481]).
Failure was most likely caused by SUREFIRE-2056 (null testId causing
BufferOverflowException):
!screenshot-1.png!
> System.out.println() causes BufferOverflow
> --
>
> Key: SUREFIRE-2068
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2068
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, JUnit 5.x support
>Affects Versions: 3.0.0-M6
>Reporter: Steven Pearce
>Priority: Minor
> Attachments: screenshot-1.png, surefire-buffer-overflow.zip
>
>
> Using the SUREFIRE-1614 minimal project as a starting point I've added the
> line
> {noformat}
> System.out.println();
> {noformat}
> at line 16 of CustomRunner.class
> I've also updated the dependancies, but it mostly remains the same.
> I've attached the reproducible example
> Executing with `./mvnw -Pjunit5 test` or `./mvnw -Pjunit4 test` both produce
> the same output.
> Downgrading to 3.0.0-M5 no longer causes the issue.
> This will now trigger the exception
> {noformat}
> java.nio.BufferOverflowException
> at java.base/java.nio.Buffer.nextPutIndex(Buffer.java:722)
> at java.base/java.nio.HeapByteBuffer.put(HeapByteBuffer.java:209)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeString(AbstractStreamEncoder.java:127)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeStringData(AbstractStreamEncoder.java:171)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encode(AbstractStreamEncoder.java:157)
> at
> org.apache.maven.surefire.booter.spi.EventChannelEncoder.encodeMessage(EventChannelEncoder.java:398)
> at
> org.apache.maven.surefire.booter.spi.EventChannelEncoder.setOutErr(EventChannelEncoder.java:188)
> at
> org.apache.maven.surefire.booter.spi.EventChannelEncoder.testOutput(EventChannelEncoder.java:183)
> at
> org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:113)
> at
> org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:44)
> at
> org.apache.maven.surefire.junitplatform.RunListenerAdapter.writeTestOutput(RunListenerAdapter.java:379)
> at
> org.apache.maven.surefire.api.report.ConsoleOutputCapture$ForwardingPrintStream.println(ConsoleOutputCapture.java:144)
> at com.example.demo.CustomRunner.createTestClass(CustomRunner.java:16)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (SUREFIRE-2068) System.out.println() causes BufferOverflow
[
https://issues.apache.org/jira/browse/SUREFIRE-2068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoltan Meze updated SUREFIRE-2068:
--
Attachment: screenshot-1.png
> System.out.println() causes BufferOverflow
> --
>
> Key: SUREFIRE-2068
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2068
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.x support, JUnit 5.x support
>Affects Versions: 3.0.0-M6
>Reporter: Steven Pearce
>Priority: Minor
> Attachments: screenshot-1.png, surefire-buffer-overflow.zip
>
>
> Using the SUREFIRE-1614 minimal project as a starting point I've added the
> line
> {noformat}
> System.out.println();
> {noformat}
> at line 16 of CustomRunner.class
> I've also updated the dependancies, but it mostly remains the same.
> I've attached the reproducible example
> Executing with `./mvnw -Pjunit5 test` or `./mvnw -Pjunit4 test` both produce
> the same output.
> Downgrading to 3.0.0-M5 no longer causes the issue.
> This will now trigger the exception
> {noformat}
> java.nio.BufferOverflowException
> at java.base/java.nio.Buffer.nextPutIndex(Buffer.java:722)
> at java.base/java.nio.HeapByteBuffer.put(HeapByteBuffer.java:209)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeString(AbstractStreamEncoder.java:127)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeStringData(AbstractStreamEncoder.java:171)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encode(AbstractStreamEncoder.java:157)
> at
> org.apache.maven.surefire.booter.spi.EventChannelEncoder.encodeMessage(EventChannelEncoder.java:398)
> at
> org.apache.maven.surefire.booter.spi.EventChannelEncoder.setOutErr(EventChannelEncoder.java:188)
> at
> org.apache.maven.surefire.booter.spi.EventChannelEncoder.testOutput(EventChannelEncoder.java:183)
> at
> org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:113)
> at
> org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:44)
> at
> org.apache.maven.surefire.junitplatform.RunListenerAdapter.writeTestOutput(RunListenerAdapter.java:379)
> at
> org.apache.maven.surefire.api.report.ConsoleOutputCapture$ForwardingPrintStream.println(ConsoleOutputCapture.java:144)
> at com.example.demo.CustomRunner.createTestClass(CustomRunner.java:16)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Created] (MPLUGINTESTING-72) release 3.4.0
Samael Bate created MPLUGINTESTING-72: - Summary: release 3.4.0 Key: MPLUGINTESTING-72 URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-72 Project: Maven Plugin Testing Issue Type: Wish Reporter: Samael Bate the master branch is passing all builds. There hasn't been a release since 2014. What's the reasoning for not publishing a new release? There are numerous dependency updates as well as documentation fixes. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MRESOLVER-178) Introduce a simple inter-process SyncContext
[ https://issues.apache.org/jira/browse/MRESOLVER-178?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527673#comment-17527673 ] Michael Osipov commented on MRESOLVER-178: -- [~gnodet], ping! > Introduce a simple inter-process SyncContext > - > > Key: MRESOLVER-178 > URL: https://issues.apache.org/jira/browse/MRESOLVER-178 > Project: Maven Resolver > Issue Type: New Feature >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MPLUGINTESTING-71) Require Java 8
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-71?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527651#comment-17527651 ] Samael Bate commented on MPLUGINTESTING-71: --- Updating codebase to support more recent Java will likely require updates to min Maven version and Plexus. See related PR for MPLUGINTESTING-62 that was done in 2019. > Require Java 8 > -- > > Key: MPLUGINTESTING-71 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-71 > Project: Maven Plugin Testing > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-war-plugin] slawekjaranowski opened a new pull request, #26: [MWAR-452] One page about Skinny WARs
slawekjaranowski opened a new pull request, #26: URL: https://github.com/apache/maven-war-plugin/pull/26 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWAR) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MWAR-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MWAR-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGINTESTING-62) use maven API 3.6.0 and Plexus 2.0.0
[ https://issues.apache.org/jira/browse/MPLUGINTESTING-62?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527641#comment-17527641 ] Samael Bate commented on MPLUGINTESTING-62: --- When I raised the [PR for this|https://github.com/apache/maven-plugin-testing/pull/8] back in 2019, there was push back because people did not want to break compatibility with old Java/Maven versions. Now that a few years have passed is this still the case? Is there any appetite for these changes? I'd like to be able to use plugin testing > use maven API 3.6.0 and Plexus 2.0.0 > > > Key: MPLUGINTESTING-62 > URL: https://issues.apache.org/jira/browse/MPLUGINTESTING-62 > Project: Maven Plugin Testing > Issue Type: Dependency upgrade >Reporter: Samael Bate >Priority: Major > Labels: close-pending > > Along with updating to use Java 7 (MPLUGINTESTING-61) the plugin should use a > recent maven API. > As there is no 3.6.0 for maven-aether-provider it will need be set to 3.3.9 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-war-plugin] slawekjaranowski opened a new pull request, #25: [MWAR-454] Upgrade Parent to 36
slawekjaranowski opened a new pull request, #25: URL: https://github.com/apache/maven-war-plugin/pull/25 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MWAR) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MWAR-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MWAR-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] zoltanmeze commented on pull request #518: [SUREFIRE-2058] Corrupted STDOUT by directly writing to native stream in forked JVM 1 with UTF-8 console logging
zoltanmeze commented on PR #518: URL: https://github.com/apache/maven-surefire/pull/518#issuecomment-1108794842 @Tibor17 Done, created a separate jira ticket and PR for BufferOverflowException on null runMode, see https://github.com/apache/maven-surefire/pull/529 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] Tibor17 commented on pull request #527: [SUREFIRE-2063] Allow consecutive spaces in argLine
Tibor17 commented on PR #527: URL: https://github.com/apache/maven-surefire/pull/527#issuecomment-1108789885 @mthmulders @pzygielo Pls see the Jira https://issues.apache.org/jira/browse/SUREFIRE-2063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] zoltanmeze opened a new pull request, #529: [SUREFIRE-2076] BufferOverflowException when encoding message with null runMode
zoltanmeze opened a new pull request, #529: URL: https://github.com/apache/maven-surefire/pull/529 Per @Tibor17's comment https://github.com/apache/maven-surefire/pull/518#issuecomment-1099706229 and https://github.com/apache/maven-surefire/pull/518#issuecomment-1108371215 and after some dicsussion (see comment after https://github.com/apache/maven-surefire/pull/518#issuecomment-1099706229) pulled this into a separate issue. Jira ticket: https://issues.apache.org/jira/browse/SUREFIRE-2076 [AbstractStreamEncoder#encodeHeader](https://github.com/apache/maven-surefire/blob/959c1e9cabb8d06c72f5ebd7eb6e56e9987eccf8/surefire-api/src/main/java/org/apache/maven/surefire/api/stream/AbstractStreamEncoder.java#L86) stores runMode part in at least 3 bytes: - 1 byte for length - 1 byte delimiter - runMode content in length-bytes - 1 byte delimiter In case of null runMode the encoded part becomes `0::` (exactly 3 bytes length) The issue is that [AbstractStreamEncoder#estimateBufferLength](https://github.com/apache/maven-surefire/blob/959c1e9cabb8d06c72f5ebd7eb6e56e9987eccf8/surefire-api/src/main/java/org/apache/maven/surefire/api/stream/AbstractStreamEncoder.java#L184) is not expecting/couting any bytes for runMode part in case of null runMode. This results in in BufferOverflowException becase the byte size of the entire message is underestimated. Exception thrown: ``` java.nio.BufferOverflowException at java.nio.Buffer.nextPutIndex(Buffer.java:547) at java.nio.HeapByteBuffer.put(HeapByteBuffer.java:172) at org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeString(AbstractStreamEncoder.java:127) at org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeStringData(AbstractStreamEncoder.java:171) at org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encode(AbstractStreamEncoder.java:157) at org.apache.maven.surefire.booter.spi.EventChannelEncoder.encodeMessage(EventChannelEncoder.java:398) at org.apache.maven.surefire.booter.spi.EventChannelEncoder.setOutErr(EventChannelEncoder.java:188) at org.apache.maven.surefire.booter.spi.EventChannelEncoder.testOutput(EventChannelEncoder.java:183) at org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:113) at org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:44) at org.apache.maven.surefire.common.junit4.JUnit4RunListener.writeTestOutput(JUnit4RunListener.java:235) at org.apache.maven.surefire.api.report.ConsoleOutputCapture$ForwardingPrintStream.println(ConsoleOutputCapture.java:144) ``` Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service,
[jira] [Commented] (SUREFIRE-2063) Adding argLine with tab characters fails
[
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527609#comment-17527609
]
Tibor Digana commented on SUREFIRE-2063:
[~mthmulders]
The problem I see here is teh fact that we have already pushed this fix to
master and we closed this issue. We should not push more and more commits
within one Jira issue. So we should rephrase our needs, describe it why we need
it and do it properly in Jira and the code but I hope it would be the last one
regarding similar issue.
> Adding argLine with tab characters fails
>
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Assignee: Maarten Mulders
>Priority: Blocker
> Fix For: 3.0.0-M7
>
>
> Since v3.3.0-M6 fails when using to export or open a package. The
> failure is produced when using --add-opens or --add-exports in .
> The execution doesn't fail with v3.3.0-M5 or earlier.
> As an example, it fails when using the following :
> {code:java}
>
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
>
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (dev) on project
> testing:
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (SUREFIRE-2076) BufferOverflowException when encoding message with null runMode
[
https://issues.apache.org/jira/browse/SUREFIRE-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoltan Meze updated SUREFIRE-2076:
--
Description:
Per
[#issuecomment-1099231382|https://github.com/apache/maven-surefire/pull/518#issuecomment-1099231382],
[#issuecomment-1099706229|https://github.com/apache/maven-surefire/pull/518#issuecomment-1099706229],
[#pullrequestreview-951134938|https://github.com/apache/maven-surefire/pull/518#pullrequestreview-951134938]
and
[#issuecomment-1108371215|https://github.com/apache/maven-surefire/pull/518#issuecomment-1108371215]
RunMode can be null causing BufferOverflowException when encoding message.
Related to similar issue with null testIds:
[SUREFIRE-2056|https://issues.apache.org/jira/browse/SUREFIRE-2056]
[*AbstractStreamEncoder#encodeHeader*|https://github.com/apache/maven-surefire/blob/959c1e9cabb8d06c72f5ebd7eb6e56e9987eccf8/surefire-api/src/main/java/org/apache/maven/surefire/api/stream/AbstractStreamEncoder.java#L86]
stores runMode in at least 3 bytes:
* 1-byte length
* 1-byte delimiter
* length-bytes runMode
* 1-byte delimiter
In case of null runMode the encoded part becomes *0::* (exactly 3 bytes length)
The issue is that
[*AbstractStreamEncoder#estimateBufferLength*|https://github.com/apache/maven-surefire/blob/959c1e9cabb8d06c72f5ebd7eb6e56e9987eccf8/surefire-api/src/main/java/org/apache/maven/surefire/api/stream/AbstractStreamEncoder.java#L184]
is not expecting/couting any bytes for runMode part in case of null runMode.
This results in in BufferOverflowException becase the byte size of the message
is underestimated.
Exception thrown:
{code:java}
java.nio.BufferOverflowException
at java.nio.Buffer.nextPutIndex(Buffer.java:547)
at java.nio.HeapByteBuffer.put(HeapByteBuffer.java:172)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeString(AbstractStreamEncoder.java:127)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeStringData(AbstractStreamEncoder.java:171)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encode(AbstractStreamEncoder.java:157)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.encodeMessage(EventChannelEncoder.java:398)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.setOutErr(EventChannelEncoder.java:188)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.testOutput(EventChannelEncoder.java:183)
at
org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:113)
at
org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:44)
at
org.apache.maven.surefire.common.junit4.JUnit4RunListener.writeTestOutput(JUnit4RunListener.java:235)
at
org.apache.maven.surefire.api.report.ConsoleOutputCapture$ForwardingPrintStream.println(ConsoleOutputCapture.java:144)
{code}
was:
Per
[#issuecomment-1099231382|https://github.com/apache/maven-surefire/pull/518#issuecomment-1099231382],
[#issuecomment-1099706229|https://github.com/apache/maven-surefire/pull/518#issuecomment-1099706229],
[#pullrequestreview-951134938|https://github.com/apache/maven-surefire/pull/518#pullrequestreview-951134938]
and
[#issuecomment-1108371215|https://github.com/apache/maven-surefire/pull/518#issuecomment-1108371215]
RunMode can be null causing BufferOverflowException when encoding message.
Related to similar issue with null testIds:
[SUREFIRE-2056|https://issues.apache.org/jira/browse/SUREFIRE-2056]
*AbstractStreamEncoder#encodeHeader* stores runMode in at least 3 bytes:
* 1-byte length
* 1-byte delimiter
* length-bytes runMode
* 1-byte delimiter
In case of null runMode the encoded part becomes *0::* (exactly 3 bytes length)
The issue is that *AbstractStreamEncoder#estimateBufferLength* is not couting
any bytes in casae of null runMode.
This results in in BufferOverflowException becase the byte size of the message
is underestimated.
Exception thrown:
{code:java}
java.nio.BufferOverflowException
at java.nio.Buffer.nextPutIndex(Buffer.java:547)
at java.nio.HeapByteBuffer.put(HeapByteBuffer.java:172)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeString(AbstractStreamEncoder.java:127)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeStringData(AbstractStreamEncoder.java:171)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encode(AbstractStreamEncoder.java:157)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.encodeMessage(EventChannelEncoder.java:398)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.setOutErr(EventChannelEncoder.java:188)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.testOutput(EventChannelEncoder.java:183)
at
[jira] [Commented] (SUREFIRE-2063) Adding argLine with tab characters fails
[
https://issues.apache.org/jira/browse/SUREFIRE-2063?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527608#comment-17527608
]
Tibor Digana commented on SUREFIRE-2063:
[~mthmulders]
Basically, I don't mind due to I am not having this problem. I would prefer
some kind of backwards compatibility unless there is a strong reason to change
it.
> Adding argLine with tab characters fails
>
>
> Key: SUREFIRE-2063
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2063
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.0.0-M6
>Reporter: Daniel Subelman
>Assignee: Maarten Mulders
>Priority: Blocker
> Fix For: 3.0.0-M7
>
>
> Since v3.3.0-M6 fails when using to export or open a package. The
> failure is produced when using --add-opens or --add-exports in .
> The execution doesn't fail with v3.3.0-M5 or earlier.
> As an example, it fails when using the following :
> {code:java}
>
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.util=ALL-UNNAMED
> --add-opens
> org.junit.platform.commons/org.junit.platform.commons.logging=ALL-UNNAMED
>
> {code}
> The failure log:
> {code:java}
> [INFO] --- maven-surefire-plugin:3.0.0-M6:test (dev) @ testing ---
> [INFO] Using auto detected provider
> org.apache.maven.surefire.junitplatform.JUnitPlatformProvider
> [INFO]
> [INFO] ---
> [INFO] T E S T S
> [INFO] ---
> WARNING: Unknown module: org.junit.platform.commons specified to --add-opens
> Error: Could not find or load main class --add-opens
> Caused by: java.lang.ClassNotFoundException: --add-opens
> [INFO]
> [INFO] Results:
> [INFO]
> [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0
> [INFO]
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 9.157 s
> [INFO] Finished at: 2022-04-06T16:28:23-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M6:test (dev) on project
> testing:
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Updated] (SUREFIRE-2076) BufferOverflowException when encoding message with null runMode
[
https://issues.apache.org/jira/browse/SUREFIRE-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Zoltan Meze updated SUREFIRE-2076:
--
Description:
Per
[#issuecomment-1099231382|https://github.com/apache/maven-surefire/pull/518#issuecomment-1099231382],
[#issuecomment-1099706229|https://github.com/apache/maven-surefire/pull/518#issuecomment-1099706229],
[#pullrequestreview-951134938|https://github.com/apache/maven-surefire/pull/518#pullrequestreview-951134938]
and
[#issuecomment-1108371215|https://github.com/apache/maven-surefire/pull/518#issuecomment-1108371215]
RunMode can be null causing BufferOverflowException when encoding message.
Related to similar issue with null testIds:
[SUREFIRE-2056|https://issues.apache.org/jira/browse/SUREFIRE-2056]
*AbstractStreamEncoder#encodeHeader* stores runMode in at least 3 bytes:
* 1-byte length
* 1-byte delimiter
* length-bytes runMode
* 1-byte delimiter
In case of null runMode the encoded part becomes *0::* (exactly 3 bytes length)
The issue is that *AbstractStreamEncoder#estimateBufferLength* is not couting
any bytes in casae of null runMode.
This results in in BufferOverflowException becase the byte size of the message
is underestimated.
Exception thrown:
{code:java}
java.nio.BufferOverflowException
at java.nio.Buffer.nextPutIndex(Buffer.java:547)
at java.nio.HeapByteBuffer.put(HeapByteBuffer.java:172)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeString(AbstractStreamEncoder.java:127)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeStringData(AbstractStreamEncoder.java:171)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encode(AbstractStreamEncoder.java:157)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.encodeMessage(EventChannelEncoder.java:398)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.setOutErr(EventChannelEncoder.java:188)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.testOutput(EventChannelEncoder.java:183)
at
org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:113)
at
org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:44)
at
org.apache.maven.surefire.common.junit4.JUnit4RunListener.writeTestOutput(JUnit4RunListener.java:235)
at
org.apache.maven.surefire.api.report.ConsoleOutputCapture$ForwardingPrintStream.println(ConsoleOutputCapture.java:144)
{code}
was:
Per
[#issuecomment-1099231382|https://github.com/apache/maven-surefire/pull/518#issuecomment-1099231382],
[#issuecomment-1099706229|https://github.com/apache/maven-surefire/pull/518#issuecomment-1099706229],
[#pullrequestreview-951134938|https://github.com/apache/maven-surefire/pull/518#pullrequestreview-951134938]
and
[#issuecomment-1108371215|https://github.com/apache/maven-surefire/pull/518#issuecomment-1108371215]
RunMode can be null causing BufferOverflowException when encoding message.
Related to similar issue with null testIds:
[SUREFIRE-2056|https://issues.apache.org/jira/browse/SUREFIRE-2056]
Exception thrown:
{code:java}
java.nio.BufferOverflowException
at java.nio.Buffer.nextPutIndex(Buffer.java:547)
at java.nio.HeapByteBuffer.put(HeapByteBuffer.java:172)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeString(AbstractStreamEncoder.java:127)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeStringData(AbstractStreamEncoder.java:171)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encode(AbstractStreamEncoder.java:157)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.encodeMessage(EventChannelEncoder.java:398)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.setOutErr(EventChannelEncoder.java:188)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.testOutput(EventChannelEncoder.java:183)
at
org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:113)
at
org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:44)
at
org.apache.maven.surefire.common.junit4.JUnit4RunListener.writeTestOutput(JUnit4RunListener.java:235)
at
org.apache.maven.surefire.api.report.ConsoleOutputCapture$ForwardingPrintStream.println(ConsoleOutputCapture.java:144)
{code}
> BufferOverflowException when encoding message with null runMode
> ---
>
> Key: SUREFIRE-2076
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2076
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>
[GitHub] [maven-surefire] Tibor17 commented on pull request #528: SUREFIRE-2075: Only set thread count if specified in configuration
Tibor17 commented on PR #528: URL: https://github.com/apache/maven-surefire/pull/528#issuecomment-1108774464 @sbabcoc As I told you before, we will not accept this change. We spoke about it. The documentation in ASF says that 5 is used in TestNG and the developer originally said that this annoying value in TestNG can be changed because default value 5 does not make sense. I asked you to examine 0 and 1 because sequential order is default in all providers. 5 cannot be default value, this is nonsense. TestNG has this crazy value hardcoded. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MJAVADOC-708) How to get javadoc "locale" configuration from a Taglet in jdk9
[ https://issues.apache.org/jira/browse/MJAVADOC-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527599#comment-17527599 ] Michael Osipov commented on MJAVADOC-708: - Integrated into 17, no? > How to get javadoc "locale" configuration from a Taglet in jdk9 > --- > > Key: MJAVADOC-708 > URL: https://issues.apache.org/jira/browse/MJAVADOC-708 > Project: Maven Javadoc Plugin > Issue Type: Wish > Components: javadoc >Affects Versions: 3.3.2 >Reporter: David Hsing >Priority: Trivial > Labels: locale > > I'm writting a target class which extends from jdk.javadoc.doclet.Taglet, > this taglet needs to display multilingual “” in javadoc. > Is there any way to detect the "locale" configuration of > maven-javadoc-plugin,? > Thanks very much! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MINDEXER-147) Move rootGroups and allGroups fields out of index
[ https://issues.apache.org/jira/browse/MINDEXER-147?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527586#comment-17527586 ] Hudson commented on MINDEXER-147: - Build succeeded in Jenkins: Maven » Maven TLP » maven-indexer » master #28 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-indexer/job/master/28/ > Move rootGroups and allGroups fields out of index > - > > Key: MINDEXER-147 > URL: https://issues.apache.org/jira/browse/MINDEXER-147 > Project: Maven Indexer > Issue Type: Task >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 6.2.0 > > > These two were (mis) using index and were stored just to provide users like > IDEs the information that was anyway rebuilt on every update. > Make these two in memory, but keep it in written format to keep backward > compatibility. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MRESOLVER-253) Dynamic prefixes for LRM
[ https://issues.apache.org/jira/browse/MRESOLVER-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527583#comment-17527583 ] Tamás Cservenák commented on MRESOLVER-253: --- These pages are more "technical" documentation of Maven Resolver as a library. I'd agree, some more "user friendlier" documentation will be needed for Maven 3.9.x and 4.x for maven site... But any idea/change is welcome here as well. > Dynamic prefixes for LRM > > > Key: MRESOLVER-253 > URL: https://issues.apache.org/jira/browse/MRESOLVER-253 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > Enhances existing "enhanced" LRM (local repository manager) with "prefix" > from from path prefix composer. Default behavior is not changed (will not use > prefix, local repository will work as before). > The point in change is that it introduce a "composer", that is composing LRM > path prefixes, and is able to apply different strategies, and split local > repository into "installed" (locally built and installed) and "cached" > (downloaded from remote), etc. > There are several composer options out of the box: > * split between "cached" and locally "installed" artifacts > * split "cached" artifacts based on their origin (remote repository) > * split between "release" and "snapshot" versioned artifacts > These properties can all be configured via resolver "configuration", > essentially via session configuration. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (SUREFIRE-2076) BufferOverflowException when encoding message with null runMode
[
https://issues.apache.org/jira/browse/SUREFIRE-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527581#comment-17527581
]
Zoltan Meze commented on SUREFIRE-2076:
---
Probably related to this or SUREFIRE-2056, will confirm which one:
https://issues.apache.org/jira/browse/SUREFIRE-2068
> BufferOverflowException when encoding message with null runMode
> ---
>
> Key: SUREFIRE-2076
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2076
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M6
>Reporter: Zoltan Meze
>Priority: Major
>
> Per
> [#issuecomment-1099231382|https://github.com/apache/maven-surefire/pull/518#issuecomment-1099231382],
>
> [#issuecomment-1099706229|https://github.com/apache/maven-surefire/pull/518#issuecomment-1099706229],
>
> [#pullrequestreview-951134938|https://github.com/apache/maven-surefire/pull/518#pullrequestreview-951134938]
> and
> [#issuecomment-1108371215|https://github.com/apache/maven-surefire/pull/518#issuecomment-1108371215]
> RunMode can be null causing BufferOverflowException when encoding message.
> Related to similar issue with null testIds:
> [SUREFIRE-2056|https://issues.apache.org/jira/browse/SUREFIRE-2056]
> Exception thrown:
> {code:java}
> java.nio.BufferOverflowException
> at java.nio.Buffer.nextPutIndex(Buffer.java:547)
> at java.nio.HeapByteBuffer.put(HeapByteBuffer.java:172)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeString(AbstractStreamEncoder.java:127)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeStringData(AbstractStreamEncoder.java:171)
> at
> org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encode(AbstractStreamEncoder.java:157)
> at
> org.apache.maven.surefire.booter.spi.EventChannelEncoder.encodeMessage(EventChannelEncoder.java:398)
> at
> org.apache.maven.surefire.booter.spi.EventChannelEncoder.setOutErr(EventChannelEncoder.java:188)
> at
> org.apache.maven.surefire.booter.spi.EventChannelEncoder.testOutput(EventChannelEncoder.java:183)
> at
> org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:113)
> at
> org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:44)
> at
> org.apache.maven.surefire.common.junit4.JUnit4RunListener.writeTestOutput(JUnit4RunListener.java:235)
> at
> org.apache.maven.surefire.api.report.ConsoleOutputCapture$ForwardingPrintStream.println(ConsoleOutputCapture.java:144)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (MINDEXER-147) Move rootGroups and allGroups fields out of index
[ https://issues.apache.org/jira/browse/MINDEXER-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák resolved MINDEXER-147. -- Resolution: Fixed > Move rootGroups and allGroups fields out of index > - > > Key: MINDEXER-147 > URL: https://issues.apache.org/jira/browse/MINDEXER-147 > Project: Maven Indexer > Issue Type: Task >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 6.2.0 > > > These two were (mis) using index and were stored just to provide users like > IDEs the information that was anyway rebuilt on every update. > Make these two in memory, but keep it in written format to keep backward > compatibility. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MINDEXER-147) Move rootGroups and allGroups fields out of index
[ https://issues.apache.org/jira/browse/MINDEXER-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák closed MINDEXER-147. > Move rootGroups and allGroups fields out of index > - > > Key: MINDEXER-147 > URL: https://issues.apache.org/jira/browse/MINDEXER-147 > Project: Maven Indexer > Issue Type: Task >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 6.2.0 > > > These two were (mis) using index and were stored just to provide users like > IDEs the information that was anyway rebuilt on every update. > Make these two in memory, but keep it in written format to keep backward > compatibility. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-indexer] cstamas merged pull request #202: [MINDEXER-147] Move allGroups/rootGroups to in memory only
cstamas merged PR #202: URL: https://github.com/apache/maven-indexer/pull/202 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MINDEXER-147) Move rootGroups and allGroups fields out of index
[ https://issues.apache.org/jira/browse/MINDEXER-147?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák reassigned MINDEXER-147: Assignee: Tamás Cservenák > Move rootGroups and allGroups fields out of index > - > > Key: MINDEXER-147 > URL: https://issues.apache.org/jira/browse/MINDEXER-147 > Project: Maven Indexer > Issue Type: Task >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 6.2.0 > > > These two were (mis) using index and were stored just to provide users like > IDEs the information that was anyway rebuilt on every update. > Make these two in memory, but keep it in written format to keep backward > compatibility. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MRESOLVER-253) Dynamic prefixes for LRM
[ https://issues.apache.org/jira/browse/MRESOLVER-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527568#comment-17527568 ] Jesse Glick commented on MRESOLVER-253: --- This sounds promising. Is https://github.com/apache/maven-resolver/blob/master/src/site/markdown/local-repository.md + https://github.com/apache/maven-resolver/blob/master/src/site/markdown/configuration.md intended to be user documentation, or is something higher-level planned for the main Maven site? > Dynamic prefixes for LRM > > > Key: MRESOLVER-253 > URL: https://issues.apache.org/jira/browse/MRESOLVER-253 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > Enhances existing "enhanced" LRM (local repository manager) with "prefix" > from from path prefix composer. Default behavior is not changed (will not use > prefix, local repository will work as before). > The point in change is that it introduce a "composer", that is composing LRM > path prefixes, and is able to apply different strategies, and split local > repository into "installed" (locally built and installed) and "cached" > (downloaded from remote), etc. > There are several composer options out of the box: > * split between "cached" and locally "installed" artifacts > * split "cached" artifacts based on their origin (remote repository) > * split between "release" and "snapshot" versioned artifacts > These properties can all be configured via resolver "configuration", > essentially via session configuration. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-indexer] cstamas opened a new pull request, #202: [MINDEXER-147] Move allGroups/rootGroups to in memory only
cstamas opened a new pull request, #202: URL: https://github.com/apache/maven-indexer/pull/202 Do not (mis)use Lucene index to store potentially huge dataset, while this field is really not even searched, it just contains aggregated artifact groups that are present on index. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MINDEXER-147) Move rootGroups and allGroups fields out of index
Tamás Cservenák created MINDEXER-147: Summary: Move rootGroups and allGroups fields out of index Key: MINDEXER-147 URL: https://issues.apache.org/jira/browse/MINDEXER-147 Project: Maven Indexer Issue Type: Task Reporter: Tamás Cservenák Fix For: 6.2.0 These two were (mis) using index and were stored just to provide users like IDEs the information that was anyway rebuilt on every update. Make these two in memory, but keep it in written format to keep backward compatibility. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (MJAVADOC-708) How to get javadoc "locale" configuration from a Taglet in jdk9
[ https://issues.apache.org/jira/browse/MJAVADOC-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527562#comment-17527562 ] David Hsing edited comment on MJAVADOC-708 at 4/25/22 3:11 PM: --- Unfortunately, it doesn't look very feasible :( [https://mail.openjdk.java.net/pipermail/javadoc-dev/2021-June/002977.html|https://mail.openjdk.java.net/pipermail/javadoc-dev/2021-June/002977.html] was (Author: JIRAUSER287004): Unfortunately, it doesn't look very feasible :( [https://mail.openjdk.java.net/pipermail/javadoc-dev/2021-June/002977.html|http://example.com] > How to get javadoc "locale" configuration from a Taglet in jdk9 > --- > > Key: MJAVADOC-708 > URL: https://issues.apache.org/jira/browse/MJAVADOC-708 > Project: Maven Javadoc Plugin > Issue Type: Wish > Components: javadoc >Affects Versions: 3.3.2 >Reporter: David Hsing >Priority: Trivial > Labels: locale > > I'm writting a target class which extends from jdk.javadoc.doclet.Taglet, > this taglet needs to display multilingual “” in javadoc. > Is there any way to detect the "locale" configuration of > maven-javadoc-plugin,? > Thanks very much! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (MJAVADOC-708) How to get javadoc "locale" configuration from a Taglet in jdk9
[ https://issues.apache.org/jira/browse/MJAVADOC-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527562#comment-17527562 ] David Hsing edited comment on MJAVADOC-708 at 4/25/22 3:10 PM: --- Unfortunately, it doesn't look very feasible :( [https://mail.openjdk.java.net/pipermail/javadoc-dev/2021-June/002977.html|http://example.com] was (Author: JIRAUSER287004): Unfortunately, it doesn't look very feasible. > How to get javadoc "locale" configuration from a Taglet in jdk9 > --- > > Key: MJAVADOC-708 > URL: https://issues.apache.org/jira/browse/MJAVADOC-708 > Project: Maven Javadoc Plugin > Issue Type: Wish > Components: javadoc >Affects Versions: 3.3.2 >Reporter: David Hsing >Priority: Trivial > Labels: locale > > I'm writting a target class which extends from jdk.javadoc.doclet.Taglet, > this taglet needs to display multilingual “” in javadoc. > Is there any way to detect the "locale" configuration of > maven-javadoc-plugin,? > Thanks very much! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (MJAVADOC-708) How to get javadoc "locale" configuration from a Taglet in jdk9
[ https://issues.apache.org/jira/browse/MJAVADOC-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527562#comment-17527562 ] David Hsing edited comment on MJAVADOC-708 at 4/25/22 3:09 PM: --- Unfortunately, it doesn't look very feasible. was (Author: JIRAUSER287004): Unfortunately, it doesn't look very feasible. > How to get javadoc "locale" configuration from a Taglet in jdk9 > --- > > Key: MJAVADOC-708 > URL: https://issues.apache.org/jira/browse/MJAVADOC-708 > Project: Maven Javadoc Plugin > Issue Type: Wish > Components: javadoc >Affects Versions: 3.3.2 >Reporter: David Hsing >Priority: Trivial > Labels: locale > > I'm writting a target class which extends from jdk.javadoc.doclet.Taglet, > this taglet needs to display multilingual “” in javadoc. > Is there any way to detect the "locale" configuration of > maven-javadoc-plugin,? > Thanks very much! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MJAVADOC-708) How to get javadoc "locale" configuration from a Taglet in jdk9
[ https://issues.apache.org/jira/browse/MJAVADOC-708?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527562#comment-17527562 ] David Hsing commented on MJAVADOC-708: -- Unfortunately, it doesn't look very feasible. > How to get javadoc "locale" configuration from a Taglet in jdk9 > --- > > Key: MJAVADOC-708 > URL: https://issues.apache.org/jira/browse/MJAVADOC-708 > Project: Maven Javadoc Plugin > Issue Type: Wish > Components: javadoc >Affects Versions: 3.3.2 >Reporter: David Hsing >Priority: Trivial > Labels: locale > > I'm writting a target class which extends from jdk.javadoc.doclet.Taglet, > this taglet needs to display multilingual “” in javadoc. > Is there any way to detect the "locale" configuration of > maven-javadoc-plugin,? > Thanks very much! -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MDEP-802) analyze-only fails to recognize `aws-java-sdk-core` as a compile-time dependency
[
https://issues.apache.org/jira/browse/MDEP-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527545#comment-17527545
]
Slawomir Jaranowski commented on MDEP-802:
--
[~findinpath] please ask question in MDEP-791 this issue is more complicated
depends on MNG-6058
> analyze-only fails to recognize `aws-java-sdk-core` as a compile-time
> dependency
>
>
> Key: MDEP-802
> URL: https://issues.apache.org/jira/browse/MDEP-802
> Project: Maven Dependency Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Marius Grama
>Priority: Major
>
> The maven-dependency-plugin fails to recognize `aws-java-sdk-core` as a
> compile-time dependency, because we only explicitly use a class from
> `aws-java-sdk-glue`, which in turn extends from a class from
> `aws-java-sdk-core`.
>
> In order to cope with this problem, we set `aws-java-sdk-core` as an ignored
> dependency:
>
> {code}
> maven-dependency-plugin
>
>
>
>
> com.amazonaws:aws-java-sdk-core
>
>
>
> {code}
>
> Here is the commit showcasing the issue:
>
> [https://github.com/trinodb/trino/pull/11550/commits/22f227bb5721b1ea4783c6a58111ef5007f75316]
>
> Ideally we'd like not having to deal with this false positive problem.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-compiler-plugin] dependabot[bot] opened a new pull request, #118: Bump maven-javadoc-plugin from 3.3.2 to 3.4.0
dependabot[bot] opened a new pull request, #118: URL: https://github.com/apache/maven-compiler-plugin/pull/118 Bumps [maven-javadoc-plugin](https://github.com/apache/maven-javadoc-plugin) from 3.3.2 to 3.4.0. Commits https://github.com/apache/maven-javadoc-plugin/commit/40cc602f84dbb0689020b55b24970cdd7147722c;>40cc602 [maven-release-plugin] prepare release maven-javadoc-plugin-3.4.0 https://github.com/apache/maven-javadoc-plugin/commit/0c6b32fb5ec9c31b4e38d9f32616ff51102623da;>0c6b32f [MJAVADOC-714] Upgrade to Maven 3.2.5 https://github.com/apache/maven-javadoc-plugin/commit/506cb74e6abc4b108121b0c586a15b75dd5ccc39;>506cb74 [MJAVADOC-696] Invalid anchors in Javadoc and plugin mojo https://github.com/apache/maven-javadoc-plugin/commit/47d03d3a08cc58a93fa384f4661d79c350842b82;>47d03d3 [MJAVADOC-712] Remove remains of org.codehaus.doxia.sink.Sink https://github.com/apache/maven-javadoc-plugin/commit/5fae3b656e131fa233982eebf0944b5253fc845e;>5fae3b6 [MJAVADOC-711] Upgrade plugins in ITs https://github.com/apache/maven-javadoc-plugin/commit/03ca84372ab689c91dd0d5b63cc2ee12ee3c466b;>03ca843 Bump maven-archiver from 3.5.1 to 3.5.2 https://github.com/apache/maven-javadoc-plugin/commit/5dcfa6e70795d0b5cf5414a848e7e0aeb5541413;>5dcfa6e Bump plexus-archiver from 4.2.6 to 4.2.7 https://github.com/apache/maven-javadoc-plugin/commit/ca00601609903a0e88a067b2aa3d49e88191937a;>ca00601 Bump junit in /src/it/projects/MJAVADOC-498_modulepath https://github.com/apache/maven-javadoc-plugin/commit/2583554135dc04db58a435ebcbd2cd19f0d2563a;>2583554 Bump commons-io from 2.2 to 2.7 in /src/it/projects/MJAVADOC-437/module2 https://github.com/apache/maven-javadoc-plugin/commit/9dd7bddb3db6d0d230092d7fbbd4188a98a3a75e;>9dd7bdd use shared gh action/release-drafter (https://github-redirect.dependabot.com/apache/maven-javadoc-plugin/issues/128;>#128) Additional commits viewable in https://github.com/apache/maven-javadoc-plugin/compare/maven-javadoc-plugin-3.3.2...maven-javadoc-plugin-3.4.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] gnodet commented on pull request #150: Optimize build
gnodet commented on PR #150: URL: https://github.com/apache/maven-resolver/pull/150#issuecomment-1108631175 > > This redefines bnd plugin, latest updates was to 6.2.0 but you added 6.1.0? > > The upgrade to 6.2.0 was done 2 days ago, while my upgrade to 6.1.0 was 2 months ago. Anyway, I have some pending changes for this PR, but this will depend on [apache/maven-plugin-tools#67](https://github.com/apache/maven-plugin-tools/pull/67) and [codehaus-plexus/plexus-utils#184](https://github.com/codehaus-plexus/plexus-utils/pull/184). I'll have another look at this last PR to investigate the failing test. So @cstamas feel free to review https://github.com/codehaus-plexus/plexus-utils/pull/184 which I've just fixed ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-war-plugin] dennisl commented on pull request #23: [MWAR-453] Require Java 8
dennisl commented on PR #23: URL: https://github.com/apache/maven-war-plugin/pull/23#issuecomment-1108630093 @slachiewicz Would you mind rebasing your branch to master, now that MWAR-444 and MWAR-450 has been merged. I don't trust myself to do that right now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-2076) BufferOverflowException when encoding message with null runMode
Zoltan Meze created SUREFIRE-2076:
-
Summary: BufferOverflowException when encoding message with null
runMode
Key: SUREFIRE-2076
URL: https://issues.apache.org/jira/browse/SUREFIRE-2076
Project: Maven Surefire
Issue Type: Bug
Components: Maven Surefire Plugin
Affects Versions: 3.0.0-M6
Reporter: Zoltan Meze
Per
[#issuecomment-1099231382|https://github.com/apache/maven-surefire/pull/518#issuecomment-1099231382],
[#issuecomment-1099706229|https://github.com/apache/maven-surefire/pull/518#issuecomment-1099706229],
[#pullrequestreview-951134938|https://github.com/apache/maven-surefire/pull/518#pullrequestreview-951134938]
and
[#issuecomment-1108371215|https://github.com/apache/maven-surefire/pull/518#issuecomment-1108371215]
RunMode can be null causing BufferOverflowException when encoding message.
Related to similar issue with null testIds:
[SUREFIRE-2056|https://issues.apache.org/jira/browse/SUREFIRE-2056]
Exception thrown:
{code:java}
java.nio.BufferOverflowException
at java.nio.Buffer.nextPutIndex(Buffer.java:547)
at java.nio.HeapByteBuffer.put(HeapByteBuffer.java:172)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeString(AbstractStreamEncoder.java:127)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encodeStringData(AbstractStreamEncoder.java:171)
at
org.apache.maven.surefire.api.stream.AbstractStreamEncoder.encode(AbstractStreamEncoder.java:157)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.encodeMessage(EventChannelEncoder.java:398)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.setOutErr(EventChannelEncoder.java:188)
at
org.apache.maven.surefire.booter.spi.EventChannelEncoder.testOutput(EventChannelEncoder.java:183)
at
org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:113)
at
org.apache.maven.surefire.api.booter.ForkingRunListener.writeTestOutput(ForkingRunListener.java:44)
at
org.apache.maven.surefire.common.junit4.JUnit4RunListener.writeTestOutput(JUnit4RunListener.java:235)
at
org.apache.maven.surefire.api.report.ConsoleOutputCapture$ForwardingPrintStream.println(ConsoleOutputCapture.java:144)
{code}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-war-plugin] dennisl commented on pull request #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…
dennisl commented on PR #22: URL: https://github.com/apache/maven-war-plugin/pull/22#issuecomment-1108618869 Sorry, I messed up. I wanted to apply the pull requests in order, but there was a conflict between the PR for MWAR-444 and MWAR-450 that I was unable to resolve at github. Also I wanted to make sure that the failed checks for MWAR-444 had been resolved in master, so I decided to merge the PR for MWAR-444 into our fork. That was apparently one too many remote references for me to handle. I really hate those merge commits... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MWAR-454) Upgrade Parent to 36
Slawomir Jaranowski created MWAR-454: Summary: Upgrade Parent to 36 Key: MWAR-454 URL: https://issues.apache.org/jira/browse/MWAR-454 Project: Maven WAR Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: 3.4.0 -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MWAR-452) One page about Skinny WARs
[
https://issues.apache.org/jira/browse/MWAR-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MWAR-452:
-
Fix Version/s: 3.4.0
(was: next-release)
> One page about Skinny WARs
> --
>
> Key: MWAR-452
> URL: https://issues.apache.org/jira/browse/MWAR-452
> Project: Maven WAR Plugin
> Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.4.0
>
>
> We have:
> - https://maven.apache.org/plugins/maven-war-plugin/examples/skinny-wars.html
> - https://maven.apache.org/plugins/maven-ear-plugin/examples/skinny-wars.html
> Both site contains the same information and very similar (almost identical)
> content.
> {{Skinny WARs}} is feature of {{m-ear-p}} so page should be maintained in one
> place in {{m-ear-p}} project.
> In {{m-war-p}} we can link to site in {{m-ear-p}} project.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (MWAR-450) ISO8859-1 properties files get changed into UTF-8 when filtered
[
https://issues.apache.org/jira/browse/MWAR-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg resolved MWAR-450.
--
Assignee: Dennis Lundberg
Resolution: Fixed
> ISO8859-1 properties files get changed into UTF-8 when filtered
> ---
>
> Key: MWAR-450
> URL: https://issues.apache.org/jira/browse/MWAR-450
> Project: Maven WAR Plugin
> Issue Type: Improvement
> Components: filtering
>Affects Versions: 3.3.2
>Reporter: Dennis Lundberg
>Assignee: Dennis Lundberg
>Priority: Major
> Fix For: 3.4.0
>
>
> This issue is similar to
> https://issues.apache.org/jira/browse/MRESOURCES-171, but for filtering web
> resources in maven-war-plugin.
> We add properties files that have ISO-8859-1 encoding, as per the Java 8
> requirements, as web resources in a war project. When these resources are
> filtered they get converted to the encoding specified by the
> project.build.sourceEncoding. There is a parameter resourceEncoding that can
> be used to change the encoding for web reources, but it applies to all web
> resource files which is not always what you want.
> Here is the configuration used:
> {code:xml}
>
>
>
> org.apache.maven.plugins
> maven-war-plugin
> 3.3.2
>
>
>
> WEB-INF/classes
> true
> src/main/webapp/WEB-INF/classes
>
>
>
>
>
>
> {code}
> We propose to add a new parameter propertiesEncoding to the AbstractWarMojo.
> If the value of this parameter is set and filtering is enabled and a web
> resource file is a properties file, then the value of the parameter is used
> as encoding when filtering the file.
> If the parameter is not specified it defaults to
> project.build.sourceEncoding, thus keeping the current behavior of the plugin
> unchanged.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Resolved] (MWAR-444) Update plugin (requires Maven 3.2.5+)
[ https://issues.apache.org/jira/browse/MWAR-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dennis Lundberg resolved MWAR-444. -- Resolution: Fixed > Update plugin (requires Maven 3.2.5+) > - > > Key: MWAR-444 > URL: https://issues.apache.org/jira/browse/MWAR-444 > Project: Maven WAR Plugin > Issue Type: Task >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 3.4.0 > > > Update plugin > * require Maven 3.2.5+ > * set maven bits to provided scope > * get rid of old baggage, update dependencies -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-war-plugin] michael-o commented on pull request #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…
michael-o commented on PR #22: URL: https://github.com/apache/maven-war-plugin/pull/22#issuecomment-1108594277 Oh c'mon, really why didn't you rebase first? Now we have those useless merge commits on master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MWAR-450) ISO8859-1 properties files get changed into UTF-8 when filtered
[
https://issues.apache.org/jira/browse/MWAR-450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527502#comment-17527502
]
Hudson commented on MWAR-450:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-war-plugin » master #7
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-war-plugin/job/master/7/
> ISO8859-1 properties files get changed into UTF-8 when filtered
> ---
>
> Key: MWAR-450
> URL: https://issues.apache.org/jira/browse/MWAR-450
> Project: Maven WAR Plugin
> Issue Type: Improvement
> Components: filtering
>Affects Versions: 3.3.2
>Reporter: Dennis Lundberg
>Priority: Major
> Fix For: 3.4.0
>
>
> This issue is similar to
> https://issues.apache.org/jira/browse/MRESOURCES-171, but for filtering web
> resources in maven-war-plugin.
> We add properties files that have ISO-8859-1 encoding, as per the Java 8
> requirements, as web resources in a war project. When these resources are
> filtered they get converted to the encoding specified by the
> project.build.sourceEncoding. There is a parameter resourceEncoding that can
> be used to change the encoding for web reources, but it applies to all web
> resource files which is not always what you want.
> Here is the configuration used:
> {code:xml}
>
>
>
> org.apache.maven.plugins
> maven-war-plugin
> 3.3.2
>
>
>
> WEB-INF/classes
> true
> src/main/webapp/WEB-INF/classes
>
>
>
>
>
>
> {code}
> We propose to add a new parameter propertiesEncoding to the AbstractWarMojo.
> If the value of this parameter is set and filtering is enabled and a web
> resource file is a properties file, then the value of the parameter is used
> as encoding when filtering the file.
> If the parameter is not specified it defaults to
> project.build.sourceEncoding, thus keeping the current behavior of the plugin
> unchanged.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-war-plugin] dennisl merged pull request #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…
dennisl merged PR #22: URL: https://github.com/apache/maven-war-plugin/pull/22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-war-plugin] dependabot[bot] opened a new pull request, #24: Bump commons-io from 2.6 to 2.7
dependabot[bot] opened a new pull request, #24: URL: https://github.com/apache/maven-war-plugin/pull/24 Bumps commons-io from 2.6 to 2.7. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-war-plugin/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MWAR-448) packaging dependencies fails with "mvn install" but not "mvn package"
[ https://issues.apache.org/jira/browse/MWAR-448?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17525438#comment-17525438 ] Dennis Lundberg edited comment on MWAR-448 at 4/25/22 1:14 PM: --- In my opinion what you have described above is working as intended. If you add a dependency on some-parent and don't specify the type, Maven and its plugins will assume that some-parent produces a jar artifact. If some-parent does not produce a jar artifact (as is the case) then some plugins will fail if they cannot find that jar artifact. So for things to work properly you must specify type=pom in some-parent, as well as any other place that uses some-parent as a dependency. was (Author: dennisl): In my opinion what you have described above is working as intended. If you add a dependency on some-parent and don't specify the type, Maven and its plugins will assume that some-parent produces a jar artifact. If some-parent does not produce a jar artifact (as is the case) then som plugins will fail if they cannot find that jar artifact. So for things to work properly you must specify type=pom in some-parent, as well as any other place that uses some-parent as a dependency. > packaging dependencies fails with "mvn install" but not "mvn package" > - > > Key: MWAR-448 > URL: https://issues.apache.org/jira/browse/MWAR-448 > Project: Maven WAR Plugin > Issue Type: Bug >Affects Versions: 3.3.2 > Environment: maven 3.6.3 ( later versions have bugs which we can't > take in) >Reporter: Kari J. Niemi >Priority: Minor > Fix For: waiting-for-feedback > > > I think we discovered a minor odd difference with war-packaging between "mvn > package" or "mvn install". We would expect that only difference between the > two is that the latter also installs the produced stuff in the local maven > repository. > > We are packaging a few jars to a war. We have a parent pom with some modules, > and that is defined as a dependency in the pom.xml that produces a > war-package. Like this: > my-war-thingie:pom.xml (packaging:war) > * dependency: some-parent > some-parent:pom.xml (packaging:pom) > * module1 (packaging:jar) > * module2 (packaging:jar) > Earlier we had a different structure and everything was just fine: we did not > the have the child-modules but the parent-pom produced the jar. When we > changed the structure to the one described above: our CI was still OK, some > developers building OK as well -but some developers had failing maven builds > because of missing "some-parent.jar". > > It was bit of devastating hunt, but finally we discovered that "mvn package" > was building OK, but "mvn install" looks for "some-parent.jar". > We don't actually mind if the above scenario would fail in both cases, or if > it was successful - we would just expect that it works the same way for both. > If this is intended behaviour, it would be nice to have it documented. > FWIW: in our case, we anyway wanted to define direct dependencies from the > war-packaging to the child-modules. So actually, we are OK wih our builds > already. But the difference caused so may doubts about our builds > reproducibility - and also, it seems like a bug - so I wanted to be good > citizen and report the problem. > Edit: further note from our troubleshooting sessions: we don't have the > "type" for the dependency at all in my-war-thingie:pom.xml. Yesterday, we did > experiment setting the type as "pom" -and as a consequence, both "mvn > package" and "mvn install" were successful. The default as we know, > should/would be "jar". Maybe the missing dependency type is for some odd > reason resolved differently for "maven package" and "maven install"? -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Updated] (MWAR-450) ISO8859-1 properties files get changed into UTF-8 when filtered
[
https://issues.apache.org/jira/browse/MWAR-450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dennis Lundberg updated MWAR-450:
-
Fix Version/s: 3.4.0
> ISO8859-1 properties files get changed into UTF-8 when filtered
> ---
>
> Key: MWAR-450
> URL: https://issues.apache.org/jira/browse/MWAR-450
> Project: Maven WAR Plugin
> Issue Type: Improvement
> Components: filtering
>Affects Versions: 3.3.2
>Reporter: Dennis Lundberg
>Priority: Major
> Fix For: 3.4.0
>
>
> This issue is similar to
> https://issues.apache.org/jira/browse/MRESOURCES-171, but for filtering web
> resources in maven-war-plugin.
> We add properties files that have ISO-8859-1 encoding, as per the Java 8
> requirements, as web resources in a war project. When these resources are
> filtered they get converted to the encoding specified by the
> project.build.sourceEncoding. There is a parameter resourceEncoding that can
> be used to change the encoding for web reources, but it applies to all web
> resource files which is not always what you want.
> Here is the configuration used:
> {code:xml}
>
>
>
> org.apache.maven.plugins
> maven-war-plugin
> 3.3.2
>
>
>
> WEB-INF/classes
> true
> src/main/webapp/WEB-INF/classes
>
>
>
>
>
>
> {code}
> We propose to add a new parameter propertiesEncoding to the AbstractWarMojo.
> If the value of this parameter is set and filtering is enabled and a web
> resource file is a properties file, then the value of the parameter is used
> as encoding when filtering the file.
> If the parameter is not specified it defaults to
> project.build.sourceEncoding, thus keeping the current behavior of the plugin
> unchanged.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[GitHub] [maven-war-plugin] dennisl merged pull request #20: [MWAR-444] Update plugin (requires Maven 3.2.5+)
dennisl merged PR #20: URL: https://github.com/apache/maven-war-plugin/pull/20 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-war-plugin] dennisl commented on a diff in pull request #22: [MWAR-450] ISO-8859-1 properties files get changed into UTF-8 when fi…
dennisl commented on code in PR #22:
URL: https://github.com/apache/maven-war-plugin/pull/22#discussion_r857600052
##
src/it/MWAR-450/verify.bsh:
##
@@ -0,0 +1,94 @@
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.*;
+
+import org.codehaus.plexus.util.*;
+
+boolean result = true;
+
+try
+{
+File target = new File( basedir, "target/mwar450/WEB-INF/classes" );
+if ( !target.exists() || !target.isDirectory() )
+{
+System.err.println( "target/mwar450/WEB-INF/classes is missing or is
not a directory." );
+return false;
+}
+
+// Load and check log4j.xml
+File log4jxml = new File( target, "log4j.xml" );
+if ( !log4jxml.exists() || log4jxml.isDirectory() )
+{
+System.err.println( "log4j.xml is missing or is a directory." );
+return false;
+}
+FileInputStream fis = new FileInputStream ( log4jxml );
+String paramContent = IOUtil.toString ( fis, "UTF-8" );
+System.out.println( "content='" + paramContent + "'" );
+int indexOf = paramContent.indexOf( "This file is encoded in UTF-8 and
should remain so after filtering - åäö" );
+if ( indexOf < 0 )
+{
+ System.err.println( "Non-ascii characters changed encoding during
filtering" );
+ return false;
+}
+
+// Load and check my.properties
+File myProperties = new File( target, "my.properties" );
+if ( !myProperties.exists() || myProperties.isDirectory() )
+{
+System.err.println( "my.properties is missing or is a directory." );
+return false;
+}
+Properties properties = new Properties();
Review Comment:
It is true that changes were made in Java 9. From what I understand the
changes were made with regards to internationalization in
PropertyResourceBundle, but not to regular Properties.
https://docs.oracle.com/javase/9/docs/api/java/util/Properties.html
The assertions that are in place should work fine regardless of Java version
since we specify the encoding to use when reading the files, in the plugin's
code. The only exception som that rule is when reading the properties file in
the verify.bsh file in the integration test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MINDEXER-146) Fix issues reported by Lucene 9
[ https://issues.apache.org/jira/browse/MINDEXER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527471#comment-17527471 ] Hudson commented on MINDEXER-146: - Build succeeded in Jenkins: Maven » Maven TLP » maven-indexer » master #27 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-indexer/job/master/27/ > Fix issues reported by Lucene 9 > --- > > Key: MINDEXER-146 > URL: https://issues.apache.org/jira/browse/MINDEXER-146 > Project: Maven Indexer > Issue Type: Bug >Affects Versions: 6.1.1 >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 6.2.0 > > > When attempted Lucene 9.1.0 upgrade, there were several issues that failed > tests: > * uses of deprecated RAMDirectory > * omitNorms and indexOptions flops happening for same fields > Apply all the fixes so upgrade to Lucene 9.1.0 becomes no brainer, but it > will not happen now, as it requires Java11 level. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Comment Edited] (MDEP-802) analyze-only fails to recognize `aws-java-sdk-core` as a compile-time dependency
[
https://issues.apache.org/jira/browse/MDEP-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527469#comment-17527469
]
Marius Grama edited comment on MDEP-802 at 4/25/22 12:47 PM:
-
[~sjaranowski] it seems indeed pretty much similar to MDEP-791
I see that the issue has been reopened. Is there a plan to fix this problem or
is
https://issues.apache.org/jira/browse/MDEP-791?focusedCommentId=17519104=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17519104
the way to go for now?
was (Author: JIRAUSER288566):
[~sjaranowski] it seems indeed pretty much similar to MDEP-791
I see that the issue has been reopened. Is there a plan to fix this problem or
is the workaround the way to go for now?
> analyze-only fails to recognize `aws-java-sdk-core` as a compile-time
> dependency
>
>
> Key: MDEP-802
> URL: https://issues.apache.org/jira/browse/MDEP-802
> Project: Maven Dependency Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Marius Grama
>Priority: Major
>
> The maven-dependency-plugin fails to recognize `aws-java-sdk-core` as a
> compile-time dependency, because we only explicitly use a class from
> `aws-java-sdk-glue`, which in turn extends from a class from
> `aws-java-sdk-core`.
>
> In order to cope with this problem, we set `aws-java-sdk-core` as an ignored
> dependency:
>
> {code}
> maven-dependency-plugin
>
>
>
>
> com.amazonaws:aws-java-sdk-core
>
>
>
> {code}
>
> Here is the commit showcasing the issue:
>
> [https://github.com/trinodb/trino/pull/11550/commits/22f227bb5721b1ea4783c6a58111ef5007f75316]
>
> Ideally we'd like not having to deal with this false positive problem.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Commented] (MRESOLVER-252) Make LRM path composition reusable
[ https://issues.apache.org/jira/browse/MRESOLVER-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527467#comment-17527467 ] Hudson commented on MRESOLVER-252: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-resolver » master #26 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-resolver/job/master/26/ > Make LRM path composition reusable > -- > > Key: MRESOLVER-252 > URL: https://issues.apache.org/jira/browse/MRESOLVER-252 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > LocalRepositoryManager path composition was enclosed > into SimpleLocalRepositoryManager in not-quite reusable > manner. Make it reusable, by making it into a component. > Currently FileProvidedChecksumsSource was reusing local > paths, is adjusted now. > Also, make LRM implementations more encapsulated and > clear up many ctors leaving only one for simplicity. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MRESOLVER-253) Dynamic prefixes for LRM
[ https://issues.apache.org/jira/browse/MRESOLVER-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527468#comment-17527468 ] Hudson commented on MRESOLVER-253: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-resolver » master #26 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-resolver/job/master/26/ > Dynamic prefixes for LRM > > > Key: MRESOLVER-253 > URL: https://issues.apache.org/jira/browse/MRESOLVER-253 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > Enhances existing "enhanced" LRM (local repository manager) with "prefix" > from from path prefix composer. Default behavior is not changed (will not use > prefix, local repository will work as before). > The point in change is that it introduce a "composer", that is composing LRM > path prefixes, and is able to apply different strategies, and split local > repository into "installed" (locally built and installed) and "cached" > (downloaded from remote), etc. > There are several composer options out of the box: > * split between "cached" and locally "installed" artifacts > * split "cached" artifacts based on their origin (remote repository) > * split between "release" and "snapshot" versioned artifacts > These properties can all be configured via resolver "configuration", > essentially via session configuration. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Commented] (MDEP-802) analyze-only fails to recognize `aws-java-sdk-core` as a compile-time dependency
[
https://issues.apache.org/jira/browse/MDEP-802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17527469#comment-17527469
]
Marius Grama commented on MDEP-802:
---
[~sjaranowski] it seems indeed pretty much similar to MDEP-791
I see that the issue has been reopened. Is there a plan to fix this problem or
is the workaround the way to go for now?
> analyze-only fails to recognize `aws-java-sdk-core` as a compile-time
> dependency
>
>
> Key: MDEP-802
> URL: https://issues.apache.org/jira/browse/MDEP-802
> Project: Maven Dependency Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Marius Grama
>Priority: Major
>
> The maven-dependency-plugin fails to recognize `aws-java-sdk-core` as a
> compile-time dependency, because we only explicitly use a class from
> `aws-java-sdk-glue`, which in turn extends from a class from
> `aws-java-sdk-core`.
>
> In order to cope with this problem, we set `aws-java-sdk-core` as an ignored
> dependency:
>
> {code}
> maven-dependency-plugin
>
>
>
>
> com.amazonaws:aws-java-sdk-core
>
>
>
> {code}
>
> Here is the commit showcasing the issue:
>
> [https://github.com/trinodb/trino/pull/11550/commits/22f227bb5721b1ea4783c6a58111ef5007f75316]
>
> Ideally we'd like not having to deal with this false positive problem.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
[jira] [Closed] (MRESOLVER-252) Make LRM path composition reusable
[ https://issues.apache.org/jira/browse/MRESOLVER-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák closed MRESOLVER-252. - > Make LRM path composition reusable > -- > > Key: MRESOLVER-252 > URL: https://issues.apache.org/jira/browse/MRESOLVER-252 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > LocalRepositoryManager path composition was enclosed > into SimpleLocalRepositoryManager in not-quite reusable > manner. Make it reusable, by making it into a component. > Currently FileProvidedChecksumsSource was reusing local > paths, is adjusted now. > Also, make LRM implementations more encapsulated and > clear up many ctors leaving only one for simplicity. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (MRESOLVER-253) Dynamic prefixes for LRM
[ https://issues.apache.org/jira/browse/MRESOLVER-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák resolved MRESOLVER-253. --- Resolution: Fixed Fixed in b1aa64fbe6d1460d1b98d57039ec4a00de3d1a91 > Dynamic prefixes for LRM > > > Key: MRESOLVER-253 > URL: https://issues.apache.org/jira/browse/MRESOLVER-253 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > Enhances existing "enhanced" LRM (local repository manager) with "prefix" > from from path prefix composer. Default behavior is not changed (will not use > prefix, local repository will work as before). > The point in change is that it introduce a "composer", that is composing LRM > path prefixes, and is able to apply different strategies, and split local > repository into "installed" (locally built and installed) and "cached" > (downloaded from remote), etc. > There are several composer options out of the box: > * split between "cached" and locally "installed" artifacts > * split "cached" artifacts based on their origin (remote repository) > * split between "release" and "snapshot" versioned artifacts > These properties can all be configured via resolver "configuration", > essentially via session configuration. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Resolved] (MRESOLVER-252) Make LRM path composition reusable
[ https://issues.apache.org/jira/browse/MRESOLVER-252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák resolved MRESOLVER-252. --- Resolution: Fixed Fixed in b1aa64fbe6d1460d1b98d57039ec4a00de3d1a91 > Make LRM path composition reusable > -- > > Key: MRESOLVER-252 > URL: https://issues.apache.org/jira/browse/MRESOLVER-252 > Project: Maven Resolver > Issue Type: Task > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > LocalRepositoryManager path composition was enclosed > into SimpleLocalRepositoryManager in not-quite reusable > manner. Make it reusable, by making it into a component. > Currently FileProvidedChecksumsSource was reusing local > paths, is adjusted now. > Also, make LRM implementations more encapsulated and > clear up many ctors leaving only one for simplicity. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[jira] [Closed] (MRESOLVER-253) Dynamic prefixes for LRM
[ https://issues.apache.org/jira/browse/MRESOLVER-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák closed MRESOLVER-253. - > Dynamic prefixes for LRM > > > Key: MRESOLVER-253 > URL: https://issues.apache.org/jira/browse/MRESOLVER-253 > Project: Maven Resolver > Issue Type: New Feature > Components: Resolver >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 1.8.1 > > > Enhances existing "enhanced" LRM (local repository manager) with "prefix" > from from path prefix composer. Default behavior is not changed (will not use > prefix, local repository will work as before). > The point in change is that it introduce a "composer", that is composing LRM > path prefixes, and is able to apply different strategies, and split local > repository into "installed" (locally built and installed) and "cached" > (downloaded from remote), etc. > There are several composer options out of the box: > * split between "cached" and locally "installed" artifacts > * split "cached" artifacts based on their origin (remote repository) > * split between "release" and "snapshot" versioned artifacts > These properties can all be configured via resolver "configuration", > essentially via session configuration. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-resolver] cstamas merged pull request #167: [MRESOLVER-252] Make LRM path composition reusable
cstamas merged PR #167: URL: https://github.com/apache/maven-resolver/pull/167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MINDEXER-146) Fix issues reported by Lucene 9
[ https://issues.apache.org/jira/browse/MINDEXER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák resolved MINDEXER-146. -- Resolution: Fixed > Fix issues reported by Lucene 9 > --- > > Key: MINDEXER-146 > URL: https://issues.apache.org/jira/browse/MINDEXER-146 > Project: Maven Indexer > Issue Type: Bug >Affects Versions: 6.1.1 >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 6.2.0 > > > When attempted Lucene 9.1.0 upgrade, there were several issues that failed > tests: > * uses of deprecated RAMDirectory > * omitNorms and indexOptions flops happening for same fields > Apply all the fixes so upgrade to Lucene 9.1.0 becomes no brainer, but it > will not happen now, as it requires Java11 level. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-resolver] cstamas merged pull request #168: [MRESOLVER-253] Split LRM
cstamas merged PR #168: URL: https://github.com/apache/maven-resolver/pull/168 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MINDEXER-146) Fix issues reported by Lucene 9
[ https://issues.apache.org/jira/browse/MINDEXER-146?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamás Cservenák closed MINDEXER-146. > Fix issues reported by Lucene 9 > --- > > Key: MINDEXER-146 > URL: https://issues.apache.org/jira/browse/MINDEXER-146 > Project: Maven Indexer > Issue Type: Bug >Affects Versions: 6.1.1 >Reporter: Tamás Cservenák >Assignee: Tamás Cservenák >Priority: Major > Fix For: 6.2.0 > > > When attempted Lucene 9.1.0 upgrade, there were several issues that failed > tests: > * uses of deprecated RAMDirectory > * omitNorms and indexOptions flops happening for same fields > Apply all the fixes so upgrade to Lucene 9.1.0 becomes no brainer, but it > will not happen now, as it requires Java11 level. -- This message was sent by Atlassian Jira (v8.20.7#820007)
[GitHub] [maven-indexer] cstamas merged pull request #201: [MINDEXER-146] Fix issues reported by Lucene 9
cstamas merged PR #201: URL: https://github.com/apache/maven-indexer/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] gnodet commented on pull request #150: Optimize build
gnodet commented on PR #150: URL: https://github.com/apache/maven-resolver/pull/150#issuecomment-1108507005 > This redefines bnd plugin, latest updates was to 6.2.0 but you added 6.1.0? The upgrade to 6.2.0 was done 2 days ago, while my upgrade to 6.1.0 was 2 months ago. Anyway, I have some pending changes for this PR, but this will depend on https://github.com/apache/maven-plugin-tools/pull/67 and https://github.com/codehaus-plexus/plexus-utils/pull/184. I'll have another look at this last PR to investigate the failing test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #150: Optimize build
cstamas commented on PR #150: URL: https://github.com/apache/maven-resolver/pull/150#issuecomment-1108499291 This redefines bnd plugin, latest updates was to 6.2.0 but you added 6.1.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on pull request #150: Optimize build
cstamas commented on PR #150: URL: https://github.com/apache/maven-resolver/pull/150#issuecomment-1108499292 This redefines bnd plugin, latest updates was to 6.2.0 but you added 6.1.0? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-resolver] cstamas commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
cstamas commented on code in PR #168:
URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857560270
##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultLocalPathPrefixComposerFactory.java:
##
@@ -0,0 +1,61 @@
+package org.eclipse.aether.internal.impl;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.eclipse.aether.RepositorySystemSession;
+
+/**
+ * Default local path prefix composer factory: it fully reuses {@link
LocalPathPrefixComposerFactorySupport} class
+ * without changing anything from it.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named
+public final class DefaultLocalPathPrefixComposerFactory extends
LocalPathPrefixComposerFactorySupport
+{
+@Override
+public LocalPathPrefixComposer createComposer( RepositorySystemSession
session )
+{
+return new DefaultLocalPathPrefixComposer( isSplit( session ),
getLocalPrefix( session ),
+isSplitLocal( session ), getRemotePrefix( session ),
isSplitRemote( session ),
+isSplitRemoteRepository( session ),
isSplitRemoteRepositoryLast( session ),
+getReleasesPrefix( session ), getSnapshotsPrefix( session ) );
+}
+
+/**
+ * {@link LocalPathPrefixComposer} implementation that fully reuses {@link
LocalPathPrefixComposerSupport} class.
+ */
+private static class DefaultLocalPathPrefixComposer extends
LocalPathPrefixComposerSupport
+{
+@SuppressWarnings( "checkstyle:parameternumber" )
+private DefaultLocalPathPrefixComposer( boolean split, String
localPrefix, boolean splitLocal,
+ String remotePrefix, boolean
splitRemote, boolean splitRemoteRepository,
+ boolean
splitRemoteRepositoryLast,
+ String releasePrefix, String
snapshotPrefix )
Review Comment:
Fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-resolver] michael-o commented on a diff in pull request #168: [MRESOLVER-253] Split LRM
michael-o commented on code in PR #168:
URL: https://github.com/apache/maven-resolver/pull/168#discussion_r857541162
##
maven-resolver-impl/src/main/java/org/eclipse/aether/internal/impl/DefaultLocalPathPrefixComposerFactory.java:
##
@@ -0,0 +1,61 @@
+package org.eclipse.aether.internal.impl;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import javax.inject.Named;
+import javax.inject.Singleton;
+
+import org.eclipse.aether.RepositorySystemSession;
+
+/**
+ * Default local path prefix composer factory: it fully reuses {@link
LocalPathPrefixComposerFactorySupport} class
+ * without changing anything from it.
+ *
+ * @since TBD
+ */
+@Singleton
+@Named
+public final class DefaultLocalPathPrefixComposerFactory extends
LocalPathPrefixComposerFactorySupport
+{
+@Override
+public LocalPathPrefixComposer createComposer( RepositorySystemSession
session )
+{
+return new DefaultLocalPathPrefixComposer( isSplit( session ),
getLocalPrefix( session ),
+isSplitLocal( session ), getRemotePrefix( session ),
isSplitRemote( session ),
+isSplitRemoteRepository( session ),
isSplitRemoteRepositoryLast( session ),
+getReleasesPrefix( session ), getSnapshotsPrefix( session ) );
+}
+
+/**
+ * {@link LocalPathPrefixComposer} implementation that fully reuses {@link
LocalPathPrefixComposerSupport} class.
+ */
+private static class DefaultLocalPathPrefixComposer extends
LocalPathPrefixComposerSupport
+{
+@SuppressWarnings( "checkstyle:parameternumber" )
+private DefaultLocalPathPrefixComposer( boolean split, String
localPrefix, boolean splitLocal,
+ String remotePrefix, boolean
splitRemote, boolean splitRemoteRepository,
+ boolean
splitRemoteRepositoryLast,
+ String releasePrefix, String
snapshotPrefix )
Review Comment:
`releasesPrefix`, `snapshotsPrefix`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
