[GitHub] [maven-site-plugin] dependabot[bot] opened a new pull request, #95: Bump maven-reporting-api from 4.0.0-M1 to 4.0.0-M2

2022-07-04 Thread GitBox


dependabot[bot] opened a new pull request, #95:
URL: https://github.com/apache/maven-site-plugin/pull/95

   Bumps [maven-reporting-api](https://github.com/apache/maven-reporting-api) 
from 4.0.0-M1 to 4.0.0-M2.
   
   Commits
   
   https://github.com/apache/maven-reporting-api/commit/666d5cbde77cae1063786d793107caeef34c520f;>666d5cb
 [maven-release-plugin] prepare release maven-reporting-api-4.0.0-M2
   https://github.com/apache/maven-reporting-api/commit/2c44e1914ffaaf5fa072d1d6f716ef095a301d71;>2c44e19
 [MSHARED-1092] Upgrade to Doxia 2.0.0-M3
   https://github.com/apache/maven-reporting-api/commit/2d7a70e9ce5e2aae5d2a27664735bb7d4ce35535;>2d7a70e
 [MSHARED-1091] Upgrade Maven Parent to 36 and Maven to 3.2.5
   https://github.com/apache/maven-reporting-api/commit/fcc45aacaf0fce013f2c6ac1b79ce8e13afc941d;>fcc45aa
 [maven-release-plugin] prepare for next development iteration
   See full diff in https://github.com/apache/maven-reporting-api/compare/maven-reporting-api-4.0.0-M1...maven-reporting-api-4.0.0-M2;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.maven.reporting:maven-reporting-api=maven=4.0.0-M1=4.0.0-M2)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MASSEMBLY-907) Dependencies are not included when run with mvn install

2022-07-04 Thread Jira


[ 
https://issues.apache.org/jira/browse/MASSEMBLY-907?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562298#comment-17562298
 ] 

Daniel Fernández commented on MASSEMBLY-907:


I can confirm as of version 3.4.0 of the plugin this not only happens when 
doing "{{mvn install}}" but also with "{{mvn deploy}}", which heavily affects 
my build process. I don't have the involved _failing_ modules included as 
dependencies in the {{pom.xml}} of the assembly module.

I would disagree that having to add all involved first level modules to the 
{{pom.xml}} of the assembly project as explained in the first comment in this 
ticket makes sense, for four reasons IMHO:

*First*, because in my case I'm using a {{}} with 
{{true}}, so I should expect all 
reactor modules to be processed with their dependencies without needing to add 
all my large number of reactor modules one by one to the {{pom.xml}}. That 
would turn assembly maintenance really complex (we are talking dozens of 
modules at several levels).

*Second*, because all the modules are actually being processed, *but not their 
dependencies*, which is IMHO unexpected anywhere in Maven unless specifically 
configured to do otherwise. If the issue was with dependencies not being added 
to the {{pom.xml}}, it would be more coherent not process these dependencies 
(reactor modules) at all, instead of processing them, but not their 
dependencies.

*Third*, because the fact that this works as expected (by me) when doing "{{mvn 
package}}" but not "{{mvn deploy}}" is not a coherent behaviour.

*Fourth*, because processing of modules in the reactor *and* their transitive 
dependencies worked as expected (by me) until 3.1.1, when behaviour changed. So 
this broke many builds.

This is what my {{}} looks like:

{code:xml}
  


  true
  
org.thymeleaf:*
  
  
/dist
false

  
/lib
runtime

  org.thymeleaf:*

  

  


...

  
{code}

> Dependencies are not included when run with mvn install
> ---
>
> Key: MASSEMBLY-907
> URL: https://issues.apache.org/jira/browse/MASSEMBLY-907
> Project: Maven Assembly Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.1
>Reporter: Lau Bakman
>Priority: Major
> Attachments: 310_install.log, 310_install_verbose.log, 
> 311_install.log, 311_install_verbose.log, 311_package_verbose.log, 
> assembly_deps.zip
>
>
> We have just updated to version 3.1.1 due to MASSEMBLY-873 and have stumbled 
> upon a problem.
> Our project is structured similar to the attached project. When we build our 
> project using "mvn clean package" the project is assembled correctly 
> including dependencies. If we on the other hand build our project using "mvn 
> clean install", only the top level jar files are assembled and all 
> dependencies are missing.
> This worked in version 3.1.0.
> Is this by design? And if it is, is there a way to revert to the old behavior?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MWRAPPER-33) Use java 8 in maven-wrapper

2022-07-04 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MWRAPPER-33?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562289#comment-17562289
 ] 

Slawomir Jaranowski commented on MWRAPPER-33:
-

Next blocking update by java 7 [https://github.com/apache/maven-wrapper/pull/53]

 

> Use java 8 in maven-wrapper
> ---
>
> Key: MWRAPPER-33
> URL: https://issues.apache.org/jira/browse/MWRAPPER-33
> Project: Maven Wrapper
>  Issue Type: Improvement
>  Components: Maven Wrapper Jar
>Affects Versions: 3.1.0
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Currently {{maven-wrapper}} use java {*}5{*}.
> It blocks build project on java > 8.
> {{maven-wrapper-plugin}} require java 8, so we can use {{maven-wrapper}} with 
> java 5 but we can't install it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MWRAPPER-67) mvnw script does not download jar if used in git bash in windows

2022-07-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MWRAPPER-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562288#comment-17562288
 ] 

ASF GitHub Bot commented on MWRAPPER-67:


hazendaz commented on code in PR #44:
URL: https://github.com/apache/maven-wrapper/pull/44#discussion_r913267565


##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -192,7 +192,8 @@ else
   
wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar;
 fi
 while IFS="=" read key value; do
-  case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
+  # Remove invalid line endings from value
+  case "$key" in (wrapperUrl) wrapperUrl="${value%$'\r'}"; break ;;

Review Comment:
   @michael-o When you get a chance, can you check in on this again?  Thanks.





> mvnw script does not download jar if used in git bash in windows
> 
>
> Key: MWRAPPER-67
> URL: https://issues.apache.org/jira/browse/MWRAPPER-67
> Project: Maven Wrapper
>  Issue Type: Bug
>  Components: Maven Wrapper Scripts
>Affects Versions: 3.1.1
>Reporter: Jeremy Landis
>Priority: Minor
>
> Usage of git bash will not download the maven wrapper jar along with curl 
> (probably others) due to having windows line endings in the URL (trailing).  
> To ensure that is not the case, make sure to strip invalid line endings out 
> before usage.
> Use case, ./mvnw in powershell will use mvnw.cmd and has no issues 
> downloading.  If user does same in git bash, it will fail with invalid URL 
> error with curl.  Using ./mvnw.cmd there will work but not natural usage.  To 
> ensure this simply just works for full support, trim out invalid line feeds.
> note: This only affected the download.  It worked otherwise.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-wrapper] hazendaz commented on a diff in pull request #44: [MWRAPPER-67] Remove invalid line endings from wrapperUrl when used with git bash with mvnw script

2022-07-04 Thread GitBox


hazendaz commented on code in PR #44:
URL: https://github.com/apache/maven-wrapper/pull/44#discussion_r913267565


##
maven-wrapper-distribution/src/resources/mvnw:
##
@@ -192,7 +192,8 @@ else
   
wrapperUrl="https://repo.maven.apache.org/maven2/org/apache/maven/wrapper/maven-wrapper/@@project.version@@/maven-wrapper-@@project.version@@.jar;
 fi
 while IFS="=" read key value; do
-  case "$key" in (wrapperUrl) wrapperUrl="$value"; break ;;
+  # Remove invalid line endings from value
+  case "$key" in (wrapperUrl) wrapperUrl="${value%$'\r'}"; break ;;

Review Comment:
   @michael-o When you get a chance, can you check in on this again?  Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-wrapper] slawekjaranowski merged pull request #54: Bump mrm-maven-plugin from 1.4.0 to 1.4.1

2022-07-04 Thread GitBox


slawekjaranowski merged PR #54:
URL: https://github.com/apache/maven-wrapper/pull/54


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-404) JDK Requirements in plugin-info.html: Consider property "maven.compiler.release"

2022-07-04 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562282#comment-17562282
 ] 

Hudson commented on MPLUGIN-404:


Build failed in Jenkins: Maven » Maven TLP » maven-plugin-tools » master #22

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/22/

> JDK Requirements in plugin-info.html: Consider property 
> "maven.compiler.release"
> 
>
> Key: MPLUGIN-404
> URL: https://issues.apache.org/jira/browse/MPLUGIN-404
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.7.0
>
>
> Currently only the property {{maven.compiler.target}} is evaluated in 
> https://github.com/apache/maven-plugin-tools/blob/c6b1542b59fdde28b080cc42a82392eb059706b6/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java#L739
>  but not {{maven.compiler.release}} 
> (https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html).
> In general the {{release}} setting should take precedence over any {{target}} 
> setting.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MPLUGIN-404) JDK Requirements in plugin-info.html: Consider property "maven.compiler.release"

2022-07-04 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPLUGIN-404?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MPLUGIN-404.
---
Fix Version/s: 3.7.0
 Assignee: Slawomir Jaranowski
   Resolution: Fixed

> JDK Requirements in plugin-info.html: Consider property 
> "maven.compiler.release"
> 
>
> Key: MPLUGIN-404
> URL: https://issues.apache.org/jira/browse/MPLUGIN-404
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: 3.7.0
>
>
> Currently only the property {{maven.compiler.target}} is evaluated in 
> https://github.com/apache/maven-plugin-tools/blob/c6b1542b59fdde28b080cc42a82392eb059706b6/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java#L739
>  but not {{maven.compiler.release}} 
> (https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html).
> In general the {{release}} setting should take precedence over any {{target}} 
> setting.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] dependabot[bot] opened a new pull request, #116: Bump plexus-utils from 3.0.1 to 3.0.16 in /maven-plugin-plugin/src/it/mplugin-363_help-reproducible

2022-07-04 Thread GitBox


dependabot[bot] opened a new pull request, #116:
URL: https://github.com/apache/maven-plugin-tools/pull/116

   Bumps [plexus-utils](https://github.com/sonatype/plexus-utils) from 3.0.1 to 
3.0.16.
   
   Commits
   
   https://github.com/sonatype/plexus-utils/commit/cf317f9b4070c3c619e9ee75a3e38bea3ff621c1;>cf317f9
 [maven-release-plugin] prepare release plexus-utils-3.0.16
   https://github.com/sonatype/plexus-utils/commit/26e3ae87b56a7f389f1a1ce1fa563686b924256a;>26e3ae8
 Remove incorrect tag element
   https://github.com/sonatype/plexus-utils/commit/99639d6558620da489b7c6d1b0c88491cde75884;>99639d6
 Little test to mimic ${project.artifactMap(g:a:c)} usage
   https://github.com/sonatype/plexus-utils/commit/5d4697966d4c6161fc4bde1fd3fa27be6440eec0;>5d46979
 Needs to build with 1.7 because of some Java7 utils, but source/target needs 
...
   https://github.com/sonatype/plexus-utils/commit/18bd77d716ff73a707e09af7efc4d5ef5658ac35;>18bd77d
 We can't switch to Java7 yet while Maven still needs to run on Java6
   https://github.com/sonatype/plexus-utils/commit/3cf855c6403061ae216b0f805debbfda09be9245;>3cf855c
 Remove release cruft
   https://github.com/sonatype/plexus-utils/commit/3196d4c3c1fa42d11cfeb4e39c418c2f75c5a138;>3196d4c
 ignore .java-version
   https://github.com/sonatype/plexus-utils/commit/57b636d2c57f3c023a95be3fcb8270fb6ff6780c;>57b636d
 changed XmlUtilTest to create test output directory
   https://github.com/sonatype/plexus-utils/commit/33091f9b1e5a9abc0927bc51a1670d9d5ba85a1c;>33091f9
 Use the same method for finding the basedir as our other code.
   https://github.com/sonatype/plexus-utils/commit/a153249c24c32d3ab81850aaf7a263a78ca23f99;>a153249
 MNG-5553 reworked dotted expressions interpreter
   Additional commits viewable in https://github.com/sonatype/plexus-utils/compare/plexus-utils-3.0.1...plexus-utils-3.0.16;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.plexus:plexus-utils=maven=3.0.1=3.0.16)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/maven-plugin-tools/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-plugin-tools] dependabot[bot] opened a new pull request, #115: Bump plexus-utils from 3.0.1 to 3.0.16 in /maven-plugin-plugin/src/it/java-basic-annotations-jdkcurrent

2022-07-04 Thread GitBox


dependabot[bot] opened a new pull request, #115:
URL: https://github.com/apache/maven-plugin-tools/pull/115

   Bumps [plexus-utils](https://github.com/sonatype/plexus-utils) from 3.0.1 to 
3.0.16.
   
   Commits
   
   https://github.com/sonatype/plexus-utils/commit/cf317f9b4070c3c619e9ee75a3e38bea3ff621c1;>cf317f9
 [maven-release-plugin] prepare release plexus-utils-3.0.16
   https://github.com/sonatype/plexus-utils/commit/26e3ae87b56a7f389f1a1ce1fa563686b924256a;>26e3ae8
 Remove incorrect tag element
   https://github.com/sonatype/plexus-utils/commit/99639d6558620da489b7c6d1b0c88491cde75884;>99639d6
 Little test to mimic ${project.artifactMap(g:a:c)} usage
   https://github.com/sonatype/plexus-utils/commit/5d4697966d4c6161fc4bde1fd3fa27be6440eec0;>5d46979
 Needs to build with 1.7 because of some Java7 utils, but source/target needs 
...
   https://github.com/sonatype/plexus-utils/commit/18bd77d716ff73a707e09af7efc4d5ef5658ac35;>18bd77d
 We can't switch to Java7 yet while Maven still needs to run on Java6
   https://github.com/sonatype/plexus-utils/commit/3cf855c6403061ae216b0f805debbfda09be9245;>3cf855c
 Remove release cruft
   https://github.com/sonatype/plexus-utils/commit/3196d4c3c1fa42d11cfeb4e39c418c2f75c5a138;>3196d4c
 ignore .java-version
   https://github.com/sonatype/plexus-utils/commit/57b636d2c57f3c023a95be3fcb8270fb6ff6780c;>57b636d
 changed XmlUtilTest to create test output directory
   https://github.com/sonatype/plexus-utils/commit/33091f9b1e5a9abc0927bc51a1670d9d5ba85a1c;>33091f9
 Use the same method for finding the basedir as our other code.
   https://github.com/sonatype/plexus-utils/commit/a153249c24c32d3ab81850aaf7a263a78ca23f99;>a153249
 MNG-5553 reworked dotted expressions interpreter
   Additional commits viewable in https://github.com/sonatype/plexus-utils/compare/plexus-utils-3.0.1...plexus-utils-3.0.16;>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.codehaus.plexus:plexus-utils=maven=3.0.1=3.0.16)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   You can disable automated security fix PRs for this repo from the [Security 
Alerts page](https://github.com/apache/maven-plugin-tools/network/alerts).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-404) JDK Requirements in plugin-info.html: Consider property "maven.compiler.release"

2022-07-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562280#comment-17562280
 ] 

ASF GitHub Bot commented on MPLUGIN-404:


slawekjaranowski merged PR #114:
URL: https://github.com/apache/maven-plugin-tools/pull/114




> JDK Requirements in plugin-info.html: Consider property 
> "maven.compiler.release"
> 
>
> Key: MPLUGIN-404
> URL: https://issues.apache.org/jira/browse/MPLUGIN-404
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Konrad Windszus
>Priority: Minor
>
> Currently only the property {{maven.compiler.target}} is evaluated in 
> https://github.com/apache/maven-plugin-tools/blob/c6b1542b59fdde28b080cc42a82392eb059706b6/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java#L739
>  but not {{maven.compiler.release}} 
> (https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html).
> In general the {{release}} setting should take precedence over any {{target}} 
> setting.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] slawekjaranowski merged pull request #114: [MPLUGIN-404] Set JDK prerequisite preferably from release parameter or

2022-07-04 Thread GitBox


slawekjaranowski merged PR #114:
URL: https://github.com/apache/maven-plugin-tools/pull/114


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-402) report: allow to generate usage section in plugin-info.html with true

2022-07-04 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562278#comment-17562278
 ] 

Hudson commented on MPLUGIN-402:


Build failed in Jenkins: Maven » Maven TLP » maven-plugin-tools » master #20

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/20/

> report: allow to generate usage section in plugin-info.html with 
> true
> --
>
> Key: MPLUGIN-402
> URL: https://issues.apache.org/jira/browse/MPLUGIN-402
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>  Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Maven plugins overriding the default lifecycle mapping for a certain type 
> require to be configured with {{true}} 
> (https://maven.apache.org/pom.html#Plugins). The report goal though will 
> always generate a usage section for {{plugin-info.html}} without setting this 
> flag. 
> It should be configurable as optional goal parameter of 
> https://maven.apache.org/plugin-tools/maven-plugin-plugin/report-mojo.html 
> whether the plugin should be loaded with extensions or not.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MPLUGIN-402) report: allow to generate usage section in plugin-info.html with true

2022-07-04 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MPLUGIN-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MPLUGIN-402.
---
Fix Version/s: 3.7.0
 Assignee: Slawomir Jaranowski
   Resolution: Fixed

> report: allow to generate usage section in plugin-info.html with 
> true
> --
>
> Key: MPLUGIN-402
> URL: https://issues.apache.org/jira/browse/MPLUGIN-402
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>  Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Konrad Windszus
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Maven plugins overriding the default lifecycle mapping for a certain type 
> require to be configured with {{true}} 
> (https://maven.apache.org/pom.html#Plugins). The report goal though will 
> always generate a usage section for {{plugin-info.html}} without setting this 
> flag. 
> It should be configurable as optional goal parameter of 
> https://maven.apache.org/plugin-tools/maven-plugin-plugin/report-mojo.html 
> whether the plugin should be loaded with extensions or not.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPLUGIN-402) report: allow to generate usage section in plugin-info.html with true

2022-07-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562277#comment-17562277
 ] 

ASF GitHub Bot commented on MPLUGIN-402:


slawekjaranowski merged PR #99:
URL: https://github.com/apache/maven-plugin-tools/pull/99




> report: allow to generate usage section in plugin-info.html with 
> true
> --
>
> Key: MPLUGIN-402
> URL: https://issues.apache.org/jira/browse/MPLUGIN-402
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>  Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Maven plugins overriding the default lifecycle mapping for a certain type 
> require to be configured with {{true}} 
> (https://maven.apache.org/pom.html#Plugins). The report goal though will 
> always generate a usage section for {{plugin-info.html}} without setting this 
> flag. 
> It should be configurable as optional goal parameter of 
> https://maven.apache.org/plugin-tools/maven-plugin-plugin/report-mojo.html 
> whether the plugin should be loaded with extensions or not.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] slawekjaranowski merged pull request #99: [MPLUGIN-402] optionally render true in usage

2022-07-04 Thread GitBox


slawekjaranowski merged PR #99:
URL: https://github.com/apache/maven-plugin-tools/pull/99


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-gh-actions-shared] slawekjaranowski opened a new pull request, #49: Matrix build with many Maven versions

2022-07-04 Thread GitBox


slawekjaranowski opened a new pull request, #49:
URL: https://github.com/apache/maven-gh-actions-shared/pull/49

   additionally
- remove not used verify-site-goal
- rename maven_args to maven-args


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] michael-o commented on a diff in pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-04 Thread GitBox


michael-o commented on code in PR #308:
URL: https://github.com/apache/maven-site/pull/308#discussion_r913205677


##
content/markdown/configure.md:
##
@@ -65,26 +130,35 @@ From now on this can be done much more simpler and in a 
more Maven like way. So
 
 ```
 
-Now you can simply use an extension by defining the usual maven coordinates 
groupId, artifactId, version as any other artifact. Furthermore all transitive 
dependencies of those extensions will automatically being downloaded from your 
repository. So no need to create a shaded artifact anymore.
+### `/usr/local/etc/mavenrc` + `/etc/mavenrc` + `$HOME/.mavenrc`
 
-### `.mvn/maven.config` file:
+Unix-like systems only: 
+Configuration files executed by the Unix launcher scripts first thing, unless
+if the environment variable `$MAVEN_SKIP_RC` is set.
 
-It’s really hard to define a general set of options for calling the maven 
command line. Starting with Maven 3.3.1+, this can be solved by 
-putting this 
-options to a script but this can now simple being done by defining 
`${maven.projectBasedir}/.mvn/maven.config` file which contains the 
-configuration options for the `mvn` command line. 
+Typically environment variables - including `$PATH` - are set here.
 
-For example things like `-T3 -U --fail-at-end`. So you only have to call Maven 
just by using `mvn 
-clean package` instead of `mvn -T3 -U --fail-at-end clean package` and not to 
miss the `-T3 -U --fail-at-end` options on every call. The 
-`${maven.projectBasedir}/.mvn/maven.config` is located in the 
`${maven.projectBasedir}/.mvn/` directory; also works if in the root of a multi 
module build.
+### `%USERPROFILE%\mavenrc_pre.bat` + `%USERPROFILE%\mavenrc_pre.cmd`
 
-### `.mvn/jvm.config` file:
+Windows systems only:
+Configuration files executed by the Windows launcher scripts first thing 
_before_ launching the Maven JVM, 
+unless if the environment variable `%MAVEN_SKIP_RC%` is set.
 
-Starting with Maven 3.3.1+ you can define JVM configuration via 
`${maven.projectBasedir}/.mvn/jvm.config` file which means you can define the 
options for your build on a per project base. This file will become part of 
your project and will be checked in along with your project. So no need anymore 
for `MAVEN_OPTS`, `.mavenrc` files. So for example if you put the following JVM 
options into the `${maven.projectBasedir}/.mvn/jvm.config` file
+This can be used to provide secrets, like the password for a keystore:

Review Comment:
   Yeah, I know that issue, but the example is just bad. I.e., we shouldn't 
encourage people to expose secrets like this if it isn't necessary.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] michael-o commented on a diff in pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-04 Thread GitBox


michael-o commented on code in PR #308:
URL: https://github.com/apache/maven-site/pull/308#discussion_r913197502


##
content/markdown/configure.md:
##
@@ -65,26 +130,35 @@ From now on this can be done much more simpler and in a 
more Maven like way. So
 
 ```
 
-Now you can simply use an extension by defining the usual maven coordinates 
groupId, artifactId, version as any other artifact. Furthermore all transitive 
dependencies of those extensions will automatically being downloaded from your 
repository. So no need to create a shaded artifact anymore.
+### `/usr/local/etc/mavenrc` + `/etc/mavenrc` + `$HOME/.mavenrc`
 
-### `.mvn/maven.config` file:
+Unix-like systems only: 
+Configuration files executed by the Unix launcher scripts first thing, unless
+if the environment variable `$MAVEN_SKIP_RC` is set.
 
-It’s really hard to define a general set of options for calling the maven 
command line. Starting with Maven 3.3.1+, this can be solved by 
-putting this 
-options to a script but this can now simple being done by defining 
`${maven.projectBasedir}/.mvn/maven.config` file which contains the 
-configuration options for the `mvn` command line. 
+Typically environment variables - including `$PATH` - are set here.
 
-For example things like `-T3 -U --fail-at-end`. So you only have to call Maven 
just by using `mvn 
-clean package` instead of `mvn -T3 -U --fail-at-end clean package` and not to 
miss the `-T3 -U --fail-at-end` options on every call. The 
-`${maven.projectBasedir}/.mvn/maven.config` is located in the 
`${maven.projectBasedir}/.mvn/` directory; also works if in the root of a multi 
module build.
+### `%USERPROFILE%\mavenrc_pre.bat` + `%USERPROFILE%\mavenrc_pre.cmd`

Review Comment:
   See other comments.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] michael-o commented on a diff in pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-04 Thread GitBox


michael-o commented on code in PR #308:
URL: https://github.com/apache/maven-site/pull/308#discussion_r913197026


##
content/markdown/configure.md:
##
@@ -17,42 +17,107 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->
-The configuration for Apache Maven usage itself and projects built with 
resides 
-in a number of places: 
 
-## `MAVEN_OPTS` environment variable:
+Apache Maven ships with two launcher commands in the `${MAVEN_HOME}/bin` 
folder,
+which - based on several environment variables, project files and system files 
as described below
+- constructs and runs the appropriate `java ...` command line which then 
invokes the Java Virtual Machine (JVM) 
+that actually runs Maven.
 
-This variable contains parameters used to start up the JVM running Maven and
-can be used to supply additional options to it. E.g. JVM memory
-settings could be defined with the value `-Xms256m -Xmx512m`.
+* `mvn` - normal way to run from the command line.
+* `mvnDebug` - launches `mvn` in debug mode, waiting for a Java debugger to 
attach to port `$MAVEN_DEBUG_ADDRESS` (default 8000).
 
-## `MAVEN_ARGS` environment variable:
+
+## Environment variables
+
+In the following the Unix syntax for environment variables is used in the text.
+
+For Windows the syntax is slightly different, for `$A` use `%A%`.
+
+### `$MAVEN_OPTS` - `%MAVEN_OPTS%`
+
+The contents of this variable is placed in the `java` command _before_ the 
class name, and 
+can therefore be used to provide additional arguments to the Java Virtual 
Machine (JVM) without
+having to specify them on the command line every time.
+
+Examples include garbage collector and memory configuration, but _not_ options 
to Maven itself
+
+Use `java --help` and `java -X` to see what is possible in this particular JVM.
+
+
+
+### `$MAVEN_BASEDIR` - `%MAVEN_BASEDIR%`

Review Comment:
   Consider current wrapper scripts as defunct since they are forks of old 
Maven scripts which are have been reworked for 4. I have completely reduced the 
start script in 4. Don't use them as a canonical source.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-surefire] naveensrinivasan closed pull request #533: chore: Set permissions for GitHub actions

2022-07-04 Thread GitBox


naveensrinivasan closed pull request #533: chore: Set permissions for GitHub 
actions
URL: https://github.com/apache/maven-surefire/pull/533


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-surefire] naveensrinivasan commented on pull request #533: chore: Set permissions for GitHub actions

2022-07-04 Thread GitBox


naveensrinivasan commented on PR #533:
URL: https://github.com/apache/maven-surefire/pull/533#issuecomment-1174051312

   > So first we should check if it possible to change in base / shared action. 
Please do some of spike for it.
   > 
   > I will not start upgrading all our repos ... without having conviction 
that it is really need.
   
   I understand. I will close this for now. Thanks 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] michael-o commented on a diff in pull request #308: Mngsite 414 clean up https /maven.apache.org/configure.html

2022-07-04 Thread GitBox


michael-o commented on code in PR #308:
URL: https://github.com/apache/maven-site/pull/308#discussion_r913194400


##
content/markdown/configure.md:
##
@@ -17,42 +17,107 @@ KIND, either express or implied.  See the License for the
 specific language governing permissions and limitations
 under the License.
 -->
-The configuration for Apache Maven usage itself and projects built with 
resides 
-in a number of places: 
 
-## `MAVEN_OPTS` environment variable:
+Apache Maven ships with two launcher commands in the `${MAVEN_HOME}/bin` 
folder,

Review Comment:
   Steve Jobs has spoiled you'!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-site] michael-o commented on pull request #309: Delete index.apt

2022-07-04 Thread GitBox


michael-o commented on PR #309:
URL: https://github.com/apache/maven-site/pull/309#issuecomment-1174050608

   Not used anywhere?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1016) Transitive provided dependencies are not removed from collected dependency graph

2022-07-04 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562246#comment-17562246
 ] 

Hudson commented on MSHARED-1016:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-dependency-tree » master 
#17

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dependency-tree/job/master/17/

> Transitive provided dependencies are not removed from collected dependency 
> graph
> 
>
> Key: MSHARED-1016
> URL: https://issues.apache.org/jira/browse/MSHARED-1016
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-tree
>Affects Versions: maven-dependency-tree-3.1.0
>Reporter: Daniel Norberg
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-tree-next-release
>
>
> DependencyCollectorBuilder#collectDependencyGraph returns a dependency graph 
> containing transitive provided scope dependencies. This is inconsistent with 
> Maven behavior, which removes transitive provided scope dependencies from the 
> dependency graph:
> [https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java#L80|https://github.com/apache/maven/blob/706d9319f14b507f3c3deeba4eeda1a51a531c9b/maven-resolver-provider/src/main/java/org/apache/maven/repository/internal/MavenRepositorySystemUtils.java#L80.]
> This might be the root cause of 
> https://issues.apache.org/jira/browse/MENFORCER-402 and 
> https://issues.apache.org/jira/browse/MENFORCER-394
> Note that transitive test scope dependencies are correctly filtered out using 
> a dependency selector.
> It seems to me that we can add another dependency selector to also filter out 
> transitive provided scope dependencies:
> [https://github.com/apache/maven-dependency-tree/blob/7a1a12533ac6898fcb3dacbcf2466ef71d11c43a/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven31DependencyCollectorBuilder.java#L108|https://github.com/apache/maven-dependency-tree/blob/master/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven31DependencyCollectorBuilder.java#L108]
> [https://github.com/apache/maven-dependency-tree/blob/7a1a12533ac6898fcb3dacbcf2466ef71d11c43a/src/main/java/org/apache/maven/shared/dependency/graph/internal/Maven3DependencyCollectorBuilder.java#L108]
> I have submitted a PR to do this: 
> [https://github.com/apache/maven-dependency-tree/pull/9]
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-dependency-tree] slawekjaranowski merged pull request #21: [MSHARED-1016] IT tests for transitive provided scope dependencies

2022-07-04 Thread GitBox


slawekjaranowski merged PR #21:
URL: https://github.com/apache/maven-dependency-tree/pull/21


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MCOMPILER-497) Java 9 automodules and failOnWarning set to true

2022-07-04 Thread Florian Wiesner (Jira)
Florian Wiesner created MCOMPILER-497:
-

 Summary: Java 9 automodules and failOnWarning set to true
 Key: MCOMPILER-497
 URL: https://issues.apache.org/jira/browse/MCOMPILER-497
 Project: Maven Compiler Plugin
  Issue Type: Improvement
Affects Versions: 3.10.1
Reporter: Florian Wiesner


when setting {{true}} the automodule dependency 
log "Required filename-based automodules detected" will fail the build. As this 
is something you normally cannot fix as you have to augment external libraries, 
the only option is to turn the fail off, rending all other warnings useless.

Please introduce a configuration option to log "Required filename-based 
automodules detected" on info or to ignore with 
{{true}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #31: [MSHARED-1089] Upgrade maven-verifier to JDK 8 / Junit 5

2022-07-04 Thread GitBox


slawekjaranowski commented on code in PR #31:
URL: https://github.com/apache/maven-verifier/pull/31#discussion_r913142913


##
pom.xml:
##
@@ -73,9 +73,9 @@
 
 
 
-  junit
-  junit
-  4.13.2
+  org.junit.jupiter
+  junit-jupiter
+  5.8.0

Review Comment:
   https://issues.apache.org/jira/browse/MSHARED-1043



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #31: [MSHARED-1089] Upgrade maven-verifier to JDK 8 / Junit 5

2022-07-04 Thread GitBox


slawekjaranowski commented on code in PR #31:
URL: https://github.com/apache/maven-verifier/pull/31#discussion_r913141944


##
pom.xml:
##
@@ -73,9 +73,9 @@
 
 
 
-  junit
-  junit
-  4.13.2
+  org.junit.jupiter
+  junit-jupiter
+  5.8.0

Review Comment:
   Ok, now it will be next major version.
   
   so we can put junit in test scope.
   
   and remove all deprecated method from production code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-integration-testing] gnodet commented on a diff in pull request #176: Move ITs to JDK 8 / JUnit 5

2022-07-04 Thread GitBox


gnodet commented on code in PR #176:
URL: 
https://github.com/apache/maven-integration-testing/pull/176#discussion_r913138176


##
core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/pom.xml:
##
@@ -46,9 +46,9 @@ under the License.
   2.0
 
 
-  junit
-  junit
-  3.8.2
+  org.junit.jupiter
+  junit-jupiter
+  5.8.0

Review Comment:
   Moved it to the parent dependency management section.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-dependency-tree] danielnorberg commented on pull request #9: [MSHARED-1016] - exclude transitive provided scope dependencies

2022-07-04 Thread GitBox


danielnorberg commented on PR #9:
URL: 
https://github.com/apache/maven-dependency-tree/pull/9#issuecomment-1173794416

   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MPLUGIN-404) JDK Requirements in plugin-info.html: Consider property "maven.compiler.release"

2022-07-04 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-404?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562169#comment-17562169
 ] 

ASF GitHub Bot commented on MPLUGIN-404:


kwin opened a new pull request, #114:
URL: https://github.com/apache/maven-plugin-tools/pull/114

   maven.compiler.release property




> JDK Requirements in plugin-info.html: Consider property 
> "maven.compiler.release"
> 
>
> Key: MPLUGIN-404
> URL: https://issues.apache.org/jira/browse/MPLUGIN-404
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Konrad Windszus
>Priority: Minor
>
> Currently only the property {{maven.compiler.target}} is evaluated in 
> https://github.com/apache/maven-plugin-tools/blob/c6b1542b59fdde28b080cc42a82392eb059706b6/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java#L739
>  but not {{maven.compiler.release}} 
> (https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html).
> In general the {{release}} setting should take precedence over any {{target}} 
> setting.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-plugin-tools] kwin opened a new pull request, #114: [MPLUGIN-404] Set JDK prerequisite preferably from release parameter or

2022-07-04 Thread GitBox


kwin opened a new pull request, #114:
URL: https://github.com/apache/maven-plugin-tools/pull/114

   maven.compiler.release property


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPLUGIN-404) JDK Requirements in plugin-info.html: Consider property "maven.compiler.release"

2022-07-04 Thread Konrad Windszus (Jira)
Konrad Windszus created MPLUGIN-404:
---

 Summary: JDK Requirements in plugin-info.html: Consider property 
"maven.compiler.release"
 Key: MPLUGIN-404
 URL: https://issues.apache.org/jira/browse/MPLUGIN-404
 Project: Maven Plugin Tools
  Issue Type: Bug
  Components: Plugin Plugin
Affects Versions: 3.6.4
Reporter: Konrad Windszus


Currently only the property {{maven.compiler.target}} is evaluated in 
https://github.com/apache/maven-plugin-tools/blob/c6b1542b59fdde28b080cc42a82392eb059706b6/maven-plugin-plugin/src/main/java/org/apache/maven/plugin/plugin/PluginReport.java#L739
 but not {{maven.compiler.release}} 
(https://maven.apache.org/plugins/maven-compiler-plugin/examples/set-compiler-release.html).

In general the {{release}} setting should take precedence over any {{target}} 
setting.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven] gnodet commented on pull request #703: New API with immutable model

2022-07-04 Thread GitBox


gnodet commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1173690384

   > What about 
https://github.com/apache/maven/blob/2926f033cb934e7bcef51362639663bc2a39cf9a/maven-core/src/main/java/org/apache/maven/artifact/handler/DefaultArtifactHandler.java
 and 
https://github.com/apache/maven/blob/896c707d324330d7d4ad92674187923945efcda9/maven-core/src/main/java/org/apache/maven/lifecycle/mapping/DefaultLifecycleMapping.java
 and/or 
https://github.com/apache/maven/blob/master/maven-core/src/main/java/org/apache/maven/lifecycle/providers/packaging/AbstractLifecycleMappingProvider.java.
 IMHO those are the recommended (and only?) way to override the default 
lifecycles for certain types 
(https://books.sonatype.com/mvnref-book/reference/writing-plugins-sect-plugins-lifecycle.html).
 Are those supposed to be implementation details or should those be moved to 
API as well (compare with https://issues.apache.org/jira/browse/MNG-5697).
   
   The extensibility part has not been really well defined yet.  I think the 
idea is to be really opened including whatever changes are needed for some 
time, but the reason I'd like to merge this PR is to be able to actually get 
started on other PRs, because as long as the API is not available, we can't 
create any PR on other projects to leverage it.
   
   On the `ArtifactHandler` part,   I don't think the `ArtifactHandler` should 
be visible in the API.  It has to be part of the SPI which is not really 
defined yet.
   
   On a related note, I think we should think whether it would make sense to 
split the `Artifact` interface into `Coordinates`, `AttachedArtifact` and 
`ResolvedArtifact` or whatever makes sense, because the `Artifact` interface 
conveys different semantics depending where it is used.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-install-plugin] olamy commented on pull request #31: [MINSTALL-175] Drop MAT

2022-07-04 Thread GitBox


olamy commented on PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1173680721

   > > I do not see really FUD and I'm prefectly aware of this acceptation of 
this **temporary** package naming. My point has nothing to do with the history 
on accepting some code. Please do not make confusion with my concern.
   > 
   > Am glad you finally woke up after 7 years, but this is still wrong: please 
point me at any email from Eclipse Foundation where they state we got 
**temporary [org.eclipse.aether] package namespace grant** only.
   > 
   
   not sure why you are mentioning this but this is not my point about a 
permanent or temporary grant.
   I'm just mentioning the fact I find obvious a project hosted at Apache use 
the corresponding package.
   if it takes time to change it fair enough we are all volunteers with 
different bandwidth to work on this.
   But my point is just related to hiding this as this has already changed and 
will change again.
   
   > We need to get rid of old, over-engineered, over-abstracted, half-assed 
and semi finished projects, to be able to move forward. They are all just 
burden, many of them are not touched for 10ish years, many are still maven2 
stuff (!) and are totally neglected. I'd be really grateful if you'd lend a 
hand on this "spring cleaning" work instead.
   
   I'm happy to get rid of this once we have finalised the package change or 
the maven 4.x api. 
   
   
   
   
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-install-plugin] cstamas commented on pull request #31: [MINSTALL-175] Drop MAT

2022-07-04 Thread GitBox


cstamas commented on PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1173654692

   > I do not see really FUD and I'm prefectly aware of this acceptation of 
this **temporary** package naming. My point has nothing to do with the history 
on accepting some code. Please do not make confusion with my concern.
   
   Am glad you finally woke up after 7 years, but this is still wrong: please 
point me at any email from Eclipse Foundation where they state we got 
**temporary [org.eclipse.aether] package namespace grant** only.
   
   ---
   
   We need to get rid of old, over-engineered, over-abstracted, half-assed and 
semi finished projects, to be able to move forward. They are all just burden, 
many of them are not touched for 10ish years, many are still maven2 stuff (!) 
and are totally neglected. I'd be really grateful if you'd  lend a hand on this 
"spring cleaning" work instead.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] jorsol opened a new pull request, #152: Add Integration Test for reproducible builds

2022-07-04 Thread GitBox


jorsol opened a new pull request, #152:
URL: https://github.com/apache/maven-javadoc-plugin/pull/152

   Signed-off-by: Jorge Solórzano 
   
   Following this checklist to help us incorporate your 
   contribution quickly and easily:
   
- [X] Make sure there is a [JIRA 
issue](https://issues.apache.org/jira/browse/MJAVADOC) filed 
  for the change (usually before you start working on it).  Trivial 
changes like typos do not 
  require a JIRA issue.  Your pull request should address just this 
issue, without 
  pulling in other changes.
- [X] Each commit in the pull request should have a meaningful subject line 
and body.
- [X] Format the pull request title like `[MJAVADOC-XXX] - Fixes bug in 
ApproximateQuantiles`,
  where you replace `MJAVADOC-XXX` with the appropriate JIRA issue. 
Best practice
  is to use the JIRA issue title in the pull request title and in the 
first line of the 
  commit message.
- [X] Write a pull request description that is detailed enough to 
understand what the pull request does, how, and why.
- [X] Run `mvn clean verify -Prun-its` to make sure basic checks pass. A 
more thorough check will 
  be performed on your pull request automatically.
   
   If your pull request is about ~20 lines of code you don't need to sign an
   [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
   please ask on the developers list.
   
   To make clear that you license your contribution under 
   the [Apache License Version 2.0, January 
2004](http://www.apache.org/licenses/LICENSE-2.0)
   you have to acknowledge this by using the following check-box.
   
- [X] I hereby declare this contribution to be licenced under the [Apache 
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
   
- [X] In any other case, please file an [Apache Individual Contributor 
License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-install-plugin] olamy commented on pull request #31: [MINSTALL-175] Drop MAT

2022-07-04 Thread GitBox


olamy commented on PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1173601559

   > > As an Apache project we do not own the package `org.eclipse.aether` so 
we cannot promote the use of such package distributed in a `org.apache.maven 
groupId`. This was supposed to be a temporary transitional phase. It's now 
almost 7 years the project has been moved here. So as a transition phase we had 
enough time to change this aberration from our source code. This usage should 
be dead already after so many years. It looks to moving backward with such 
change.. if the goal is remove some old dependencies we don't like (e.g the 
dependencies pulled by m-a-t) we can certainly exclude:
   > > ```
   > > maven-artifact-transfer-maven-3.0.x
   > > ```
   > > 
   > > 
   > > 
   > >   
   > > 
   > > 
   > >   
   > > 
   > > 
   > > 
   > >   
   > > And even drop this module from our source code if we don't want to keep 
supporting it. But the history of the source here at Apache is remove the usage 
of org.eclipse as a package we distribute which again is totally wrong and we 
cannot keep promoting.
   > 
   > Stop spreading FUD man, you personally voted +1 on threads "[VOTE] Accept 
the Aether code into the Maven project" and also on "[IP CLEARANCE] Aether, 
renamed to Maven Artifact Resolver" on private ML (unsure could I link these as 
archives for private ML are not public). Hence, due those two before, I bet you 
got mails from thread "Trademark requests from Apache Maven regarding Aether" 
as well, also on private ML (same ML as those two before). In short, 
"distributing org.eclipse.aether" packages IS NOT WRONG, The Eclipse Foundation 
granted us usage of that namespace.
   
   I do not see really FUD and I'm prefectly aware of this acceptation of this 
**temporary** package naming. My point has nothing to do with the history on 
accepting some code. Please do not make confusion with my concern.
   
   We created and agreed on m-artifact-transfer to hide all the previous 
package changes and the future changes.
   I just see the package `org.eclipse.aether` as deprecated already even 
before m-artifact-transfer was created.
   Again the current/previous package implementation is **temporary** and we 
will change it by a renaming from org.eclipse.aether to org.apache.maven. and 
we will provide a new API as well with 4.x
   So plugins maintainers do not have to worry about the real internal and 
obviously m-artifact-transfer will be de-facto deprecated when we will have 
maven 4.x api and/or resolver package renaming.
   If your concern is the possible m-artifact-transfer. Frankly since this has 
been created there were not many really 
   And we can definitely mark it as deprecated.. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-install-plugin] gnodet commented on pull request #31: [MINSTALL-175] Drop MAT

2022-07-04 Thread GitBox


gnodet commented on PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1173598780

   > > another aspect I'd like to make explicit: where is MAT used beyond 
m-install/deploy-p?
   > 
   > `m-invoker-p` for `install` goal
   
   Here's the full list or projects using MAT:
- maven-archetype-plugin
- archetype-common
- maven-assembly-plugin
- maven-changes-plugin
- maven-dependency-plugin
- maven-gpg-plugin
- maven-invoker-plugin
- maven-javadoc-plugin
- maven-pmd-plugin
- maven-project-info-reports-plugin
- maven-remote-resources-plugin
- maven-shade-plugin


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-install-plugin] slawekjaranowski commented on pull request #31: [MINSTALL-175] Drop MAT

2022-07-04 Thread GitBox


slawekjaranowski commented on PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1173528631

   > another aspect I'd like to make explicit: where is MAT used beyond 
m-install/deploy-p? 
   
   `m-invoker-p` for `install` goal  
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] gnodet commented on pull request #703: New API with immutable model

2022-07-04 Thread GitBox


gnodet commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1173518358

   > @gnodet Is there already a branch for any of the core plugins, to see if 
this API is complete? (i.e. allows to drop all other Maven dependencies)? Which 
plugin would be a good candidate for it?
   
   Yes, I created a `mvn4` branch for each maven project, but not everything 
has been migrated yet.
 https://github.com/apache/maven-plugin-tools/commits/mvn4
 https://github.com/apache/maven-install-plugin/commits/mvn4
 https://github.com/apache/maven-deploy-plugin/commits/mvn4
 ...
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #176: Move ITs to JDK 8 / JUnit 5

2022-07-04 Thread GitBox


michael-o commented on code in PR #176:
URL: 
https://github.com/apache/maven-integration-testing/pull/176#discussion_r912731459


##
core-it-suite/pom.xml:
##
@@ -166,9 +162,10 @@ under the License.
 maven-surefire-plugin
 
   
-**/IntegrationTestSuite.java
+**/MavenIT*.java
   
-  never
+  1
+  true

Review Comment:
   Question: We have two profiles: `embedded` and none. Does this change the 
behavior? Since non-embedded requires much more time.



##
core-it-support/core-it-plugins/maven-it-plugin-class-loader/maven-it-plugin-class-loader/pom.xml:
##
@@ -46,9 +46,9 @@ under the License.
   2.0
 
 
-  junit
-  junit
-  3.8.2
+  org.junit.jupiter
+  junit-jupiter
+  5.8.0

Review Comment:
   Obviously this should be property, no?



##
core-it-support/core-it-plugins/pom.xml:
##
@@ -121,7 +121,7 @@ under the License.
   
 org.apache.maven.plugins
 maven-plugin-plugin
-3.3
+3.6.0

Review Comment:
   Why two different version and not a single property?



##
core-it-support/maven-it-plugin-bootstrap/pom.xml:
##
@@ -57,6 +57,11 @@ under the License.
   maven-resolver-impl
   ${mavenResolverVersion}
 
+
+  org.apache.maven.plugin-tools
+  maven-plugin-annotations
+  3.3

Review Comment:
   3.6.4?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-install-plugin] cstamas commented on pull request #31: [MINSTALL-175] Drop MAT

2022-07-04 Thread GitBox


cstamas commented on PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1173486848

   My problem with MAT and reason why I want to get rid of it ASAP is that it's 
unfinished (as @gnodet says "does a bit more than install.deploy"). But is 
unfinished. I just want to cut it in root before it becomes "competing" with 
new API in a way, that someone start submitting PRs to "improve" or "finish" 
MAT, I just want to prevent resource waste (human resource) by spending any 
amount on MAT, and focus on new Maven API.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MJAVADOC-719) Update Maven Archiver to 3.6.0

2022-07-04 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562055#comment-17562055
 ] 

Hudson commented on MJAVADOC-719:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-javadoc-plugin » master 
#25

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-javadoc-plugin/job/master/25/

> Update Maven Archiver to 3.6.0
> --
>
> Key: MJAVADOC-719
> URL: https://issues.apache.org/jira/browse/MJAVADOC-719
> Project: Maven Javadoc Plugin
>  Issue Type: Dependency upgrade
>  Components: javadoc
>Affects Versions: 3.4.0
>Reporter: Jorge Solórzano
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.4.1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-install-plugin] gnodet commented on pull request #31: [MINSTALL-175] Drop MAT

2022-07-04 Thread GitBox


gnodet commented on PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1173464962

   > another aspect I'd like to make explicit: where is MAT used beyond 
m-install/deploy-p?
   > which leads to a corollary: why do some plugins require to do this job 
themselves instead of letting m-install/deploy-p?
   
   I think MAT would be de-facto deprecated whenever the new API is integrated.
   MAT does a bit more than install / deploy, I think the main usage for MAT is 
the dependency collection / resolution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] kwin commented on pull request #703: New API with immutable model

2022-07-04 Thread GitBox


kwin commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1173462028

   @gnodet Is there already a branch for any of the core plugins, to see if 
this API is complete? (i.e. allows to drop all other Maven dependencies)? Which 
plugin would be a good candidate for it?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] gnodet commented on pull request #703: New API with immutable model

2022-07-04 Thread GitBox


gnodet commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1173459869

   > Is this change planned for Maven 4 only or will be also soon backported to 
3.9 line?
   
   No, that's definitely a longer term goal, so maven 4 only.
   It would still be experimental for a couple of months / releases, the time 
to make sure the API is complete and stable.  A transition would also be needed 
to switch maven-core internal to this API and reverse the current code, i.e. 
have the old api implemented on top of the new one, so that we can drop it 
completely after a period.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-install-plugin] hboutemy commented on pull request #31: [MINSTALL-175] Drop MAT

2022-07-04 Thread GitBox


hboutemy commented on PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1173457140

   another aspect I'd like to make explicit: where is MAT used beyond 
m-install/deploy-p?
   which leads to a corollary: why do some plugins require to do this job 
themselves instead of letting m-install/deploy-p?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-install-plugin] hboutemy commented on pull request #31: [MINSTALL-175] Drop MAT

2022-07-04 Thread GitBox


hboutemy commented on PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1173452027

   what I see is that we should enhance MAT index page 
https://maven.apache.org/shared/maven-artifact-transfer/ to explain the other 
objective = have a single API mapped over different implementations varying 
from Maven version to Maven version


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] slachiewicz commented on pull request #703: New API with immutable model

2022-07-04 Thread GitBox


slachiewicz commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1173444782

   Is this change planned for Maven 4 only or will be also soon backported to 
3.9 line?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Created] (MPOM-337) Load plugins containing lifecycle mapping/artifact handler with true

2022-07-04 Thread Konrad Windszus (Jira)
Konrad Windszus created MPOM-337:


 Summary: Load plugins containing lifecycle mapping/artifact 
handler with true
 Key: MPOM-337
 URL: https://issues.apache.org/jira/browse/MPOM-337
 Project: Maven POMs
  Issue Type: Improvement
  Components: asf
Reporter: Konrad Windszus


As preparation of https://issues.apache.org/jira/browse/MNG-5697 all plugins 
containing a custom default lifecycle mapping and/or artifact handler should be 
loaded with {{true}}.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MJAVADOC-719) Update Maven Archiver to 3.6.0

2022-07-04 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MJAVADOC-719.

Fix Version/s: 3.4.1
 Assignee: Slawomir Jaranowski
   Resolution: Fixed

> Update Maven Archiver to 3.6.0
> --
>
> Key: MJAVADOC-719
> URL: https://issues.apache.org/jira/browse/MJAVADOC-719
> Project: Maven Javadoc Plugin
>  Issue Type: Dependency upgrade
>  Components: javadoc
>Affects Versions: 3.4.0
>Reporter: Jorge Solórzano
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.4.1
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-javadoc-plugin] dependabot[bot] opened a new pull request, #151: Bump mavenVersion from 3.2.5 to 3.8.6

2022-07-04 Thread GitBox


dependabot[bot] opened a new pull request, #151:
URL: https://github.com/apache/maven-javadoc-plugin/pull/151

   Bumps `mavenVersion` from 3.2.5 to 3.8.6.
   Updates `maven-compat` from 3.2.5 to 3.8.6
   
   Release notes
   Sourced from https://github.com/apache/maven/releases;>maven-compat's 
releases.
   
   3.8.6
   What's Changed
   
   [MNG-7441] 3.8.x Update version of logback by https://github.com/cstamas;>@​cstamas in https://github-redirect.dependabot.com/apache/maven/pull/708;>apache/maven#708
   [MNG-7432] Resolver session contains non-MavenWorkspaceReader by https://github.com/laeubi;>@​laeubi in https://github-redirect.dependabot.com/apache/maven/pull/695;>apache/maven#695
   [MNG-7459] Revert [3.8.x][MNG-7347] SessionScoped beans should be 
singletons for a given session by https://github.com/gnodet;>@​gnodet in https://github-redirect.dependabot.com/apache/maven/pull/715;>apache/maven#715
   [3.8.x] [MNG-7476] Display a warning when an aggregator mojo locks other 
mojos executions by https://github.com/gnodet;>@​gnodet in https://github-redirect.dependabot.com/apache/maven/pull/736;>apache/maven#736
   
   Full Changelog: https://github.com/apache/maven/compare/maven-3.8.5...maven-3.8.6;>https://github.com/apache/maven/compare/maven-3.8.5...maven-3.8.6
   3.8.5
   What's Changed
   
   [3.8.x][MNG-7156][MNG-7285] Add locking in MojoExecutor by https://github.com/gnodet;>@​gnodet in https://github-redirect.dependabot.com/apache/maven/pull/628;>apache/maven#628
   [MNG-6326] Make the build fail if core extensions can not be loaded by 
https://github.com/gnodet;>@​gnodet in https://github-redirect.dependabot.com/apache/maven/pull/648;>apache/maven#648
   [3.8.x][MNG-7347] SessionScoped beans should be singletons for a given 
session by https://github.com/gnodet;>@​gnodet in https://github-redirect.dependabot.com/apache/maven/pull/653;>apache/maven#653
   [3.8.x][MNG-7386] Make sure the ModelMerger$MergingList can be 
serialized by https://github.com/gnodet;>@​gnodet in 
https://github-redirect.dependabot.com/apache/maven/pull/656;>apache/maven#656
   [3.8.x][MNG-7349] Limit relocation warning message to direct 
dependencies only by https://github.com/gnodet;>@​gnodet in https://github-redirect.dependabot.com/apache/maven/pull/657;>apache/maven#657
   [3.8.x][MNG-6727] Changed expression check to project.version and 
project.parent.version by https://github.com/gnodet;>@​gnodet in https://github-redirect.dependabot.com/apache/maven/pull/670;>apache/maven#670
   [3.8.x][MNG-7395] - Support system-properties in extension.xml by https://github.com/laeubi;>@​laeubi in https://github-redirect.dependabot.com/apache/maven/pull/673;>apache/maven#673
   
   New Contributors
   
   https://github.com/laeubi;>@​laeubi made their 
first contribution in https://github-redirect.dependabot.com/apache/maven/pull/673;>apache/maven#673
   
   Full Changelog: https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5;>https://github.com/apache/maven/compare/maven-3.8.4...maven-3.8.5
   3.8.4
   What's Changed
   
   [MNG-6302] logging the module count by https://github.com/rmannibucau;>@​rmannibucau in https://github-redirect.dependabot.com/apache/maven/pull/136;>apache/maven#136
   [MNG-6424] - Upgrade plexus-interpolation to 1.25 by https://github.com/shemic87;>@​shemic87 in https://github-redirect.dependabot.com/apache/maven/pull/172;>apache/maven#172
   Update Jenkins build to use Maven 3.5.4 by https://github.com/slachiewicz;>@​slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/179;>apache/maven#179
   [MNG-6473] Update Mockito to 2.21.0 by https://github.com/slachiewicz;>@​slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/181;>apache/maven#181
   MNG-6414 Add more Apache license headers to skip downloading license … 
by https://github.com/slachiewicz;>@​slachiewicz in 
https://github-redirect.dependabot.com/apache/maven/pull/167;>apache/maven#167
   [MNG-6479] Upgrade XMLUnit to 2.2.1 by https://github.com/slachiewicz;>@​slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/183;>apache/maven#183
   Fixed typo in exception logging by https://github.com/slachiewicz;>@​slachiewicz in https://github-redirect.dependabot.com/apache/maven/pull/170;>apache/maven#170
   [MNG-6490] Maven fails reporting circular dependency when the depende… 
by https://github.com/slachiewicz;>@​slachiewicz in 
https://github-redirect.dependabot.com/apache/maven/pull/188;>apache/maven#188
   [MNG-6261] - using java File api to compare by https://github.com/fabcipriano;>@​fabcipriano in https://github-redirect.dependabot.com/apache/maven/pull/192;>apache/maven#192
   MNG-6529 - ProjectBuild.build(projectsList, ...) ignores 
request.isResolveDependencies() by https://github.com/mickaelistria;>@​mickaelistria in https://github-redirect.dependabot.com/apache/maven/pull/193;>apache/maven#193
   [MNG-6559] Fix mailing list URL by https://github.com/johnlinp;>@​johnlinp 

[GitHub] [maven-javadoc-plugin] dependabot[bot] closed pull request #147: Bump plexus-io from 3.2.0 to 3.4.0

2022-07-04 Thread GitBox


dependabot[bot] closed pull request #147: Bump plexus-io from 3.2.0 to 3.4.0
URL: https://github.com/apache/maven-javadoc-plugin/pull/147


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] dependabot[bot] commented on pull request #147: Bump plexus-io from 3.2.0 to 3.4.0

2022-07-04 Thread GitBox


dependabot[bot] commented on PR #147:
URL: 
https://github.com/apache/maven-javadoc-plugin/pull/147#issuecomment-1173436468

   Looks like org.codehaus.plexus:plexus-io is no longer a dependency, so this 
is no longer needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven-javadoc-plugin] slawekjaranowski merged pull request #150: [MJAVADOC-719] - Update Maven Archiver to 3.6.0

2022-07-04 Thread GitBox


slawekjaranowski merged PR #150:
URL: https://github.com/apache/maven-javadoc-plugin/pull/150


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Updated] (MPLUGIN-402) report: allow to generate usage section in plugin-info.html with true

2022-07-04 Thread Konrad Windszus (Jira)


 [ 
https://issues.apache.org/jira/browse/MPLUGIN-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Konrad Windszus updated MPLUGIN-402:

Description: 
Maven plugins overriding the default lifecycle mapping for a certain type 
require to be configured with {{true}} 
(https://maven.apache.org/pom.html#Plugins). The report goal though will always 
generate a usage section for {{plugin-info.html}} without setting this flag. 

It should be configurable as optional goal parameter of 
https://maven.apache.org/plugin-tools/maven-plugin-plugin/report-mojo.html 
whether the plugin should be loaded with extensions or not.

  was:
Maven plugins containing custom lifecycle mapping require to be configured with 
{{true}} (https://maven.apache.org/pom.html#Plugins). 
The report goal though will always generate a usage section for 
{{plugin-info.html}} without setting this flag. 

It should be configurable as optional goal parameter of 
https://maven.apache.org/plugin-tools/maven-plugin-plugin/report-mojo.html 
whether the plugin should be loaded with extensions or not.


> report: allow to generate usage section in plugin-info.html with 
> true
> --
>
> Key: MPLUGIN-402
> URL: https://issues.apache.org/jira/browse/MPLUGIN-402
> Project: Maven Plugin Tools
>  Issue Type: Improvement
>  Components: Plugin Plugin
>Affects Versions: 3.6.4
>Reporter: Konrad Windszus
>Priority: Major
>
> Maven plugins overriding the default lifecycle mapping for a certain type 
> require to be configured with {{true}} 
> (https://maven.apache.org/pom.html#Plugins). The report goal though will 
> always generate a usage section for {{plugin-info.html}} without setting this 
> flag. 
> It should be configurable as optional goal parameter of 
> https://maven.apache.org/plugin-tools/maven-plugin-plugin/report-mojo.html 
> whether the plugin should be loaded with extensions or not.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[GitHub] [maven-install-plugin] gnodet commented on pull request #31: [MINSTALL-175] Drop MAT

2022-07-04 Thread GitBox


gnodet commented on PR #31:
URL: 
https://github.com/apache/maven-install-plugin/pull/31#issuecomment-1173426700

   -0 I'm quite hesitant on that one.  I don't really see the benefit of 
dropping MAT now if the goal is to switch to the new API provided by 
https://github.com/apache/maven/pull/703.  If we keep this goal, I don't really 
see the point of switching to a get rid of MAT to switch to something else in a 
couple of weeks/months.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [maven] kwin commented on pull request #703: New API with immutable model

2022-07-04 Thread GitBox


kwin commented on PR #703:
URL: https://github.com/apache/maven/pull/703#issuecomment-1173423189

   What about 
https://github.com/apache/maven/blob/2926f033cb934e7bcef51362639663bc2a39cf9a/maven-core/src/main/java/org/apache/maven/artifact/handler/DefaultArtifactHandler.java
 and 
https://github.com/apache/maven/blob/896c707d324330d7d4ad92674187923945efcda9/maven-core/src/main/java/org/apache/maven/lifecycle/mapping/DefaultLifecycleMapping.java?
 IMHO those are the recommend way to override the default lifecycles for 
certain types 
(https://books.sonatype.com/mvnref-book/reference/writing-plugins-sect-plugins-lifecycle.html).
 Are those supposed to be implementation details or should those be moved to 
API as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[jira] [Commented] (MSHARED-1096) Upgrade Maven Reporting API to 4.0.0-M2

2022-07-04 Thread Hudson (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17562027#comment-17562027
 ] 

Hudson commented on MSHARED-1096:
-

Build succeeded in Jenkins: Maven » Maven TLP » maven-reporting-impl » master 
#18

See 
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-reporting-impl/job/master/18/

> Upgrade Maven Reporting API to 4.0.0-M2
> ---
>
> Key: MSHARED-1096
> URL: https://issues.apache.org/jira/browse/MSHARED-1096
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1096) Upgrade Maven Reporting API to 4.0.0-M2

2022-07-04 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1096?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov closed MSHARED-1096.
---
Resolution: Fixed

Fixed with  
[258769f26f354b2bbb9bf82483fa182a89a12cf0|https://gitbox.apache.org/repos/asf?p=maven-reporting-impl.git;a=commit;h=258769f26f354b2bbb9bf82483fa182a89a12cf0].

> Upgrade Maven Reporting API to 4.0.0-M2
> ---
>
> Key: MSHARED-1096
> URL: https://issues.apache.org/jira/browse/MSHARED-1096
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0-M2
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MPOM-335) Bump maven-assembly-plugin from 3.3.0 to 3.4.1

2022-07-04 Thread Michael Osipov (Jira)


 [ 
https://issues.apache.org/jira/browse/MPOM-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Michael Osipov updated MPOM-335:

Summary: Bump maven-assembly-plugin from 3.3.0 to 3.4.1  (was: Bump 
maven-assembly-plugin from 3.3.0 to 3.4.0)

> Bump maven-assembly-plugin from 3.3.0 to 3.4.1
> --
>
> Key: MPOM-335
> URL: https://issues.apache.org/jira/browse/MPOM-335
> Project: Maven POMs
>  Issue Type: Dependency upgrade
>  Components: asf
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: ASF-27
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)