[jira] [Commented] (MNG-7316) MavenProject.getAttachedArtifacts() regression with 3.8.1
[
https://issues.apache.org/jira/browse/MNG-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640428#comment-17640428
]
Christoph Läubrich commented on MNG-7316:
-
As said earlier I don't think a revert (and release just for this) is not good
for anything. Given that this "bug" is out in the wild for a long time most (if
not all) plugins requiring such a feature will have workarounds in place and
most likely not remove it anyways.
The more interesting part would be how to "move forward" and have an official
API to remove an artifact e.g. in *AttachedArtifactHelper* e.g. in 3.9.x so
people can finally "fix" their code when upgrading to 3.9.x line.
> MavenProject.getAttachedArtifacts() regression with 3.8.1
> -
>
> Key: MNG-7316
> URL: https://issues.apache.org/jira/browse/MNG-7316
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.2, 3.8.3
>Reporter: Gary D. Gregory
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> The method {{MavenProject.getAttachedArtifacts()}} as of 3.8.2 breaks
> releasing components for us at Apache Commons using our Maven Release plugin
> because the list returned is now immutable, we now get an exception when
> calling {{remove()}} on the collection returned by the API; see
> [https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java#L137]
> This worked fine in 3.8.1, may you please change it back for 3.8.4?
> We cannot use Maven 3.8.2 and 3.8.3 to release our components.
> ([~michael-o]: Ironically, I discovered this trying to create a release
> candidate for Apache Commons CLI.)
> The exception in 3.8.3:
> {quote}Caused by: java.lang.UnsupportedOperationException
> at java.util.Collections$UnmodifiableCollection.remove
> (Collections.java:1060)
> at
> org.apache.commons.release.plugin.mojos.CommonsDistributionDetachmentMojo.execute
> (CommonsDistributionDetachmentMojo.java:136)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7316) MavenProject.getAttachedArtifacts() regression with 3.8.1
[
https://issues.apache.org/jira/browse/MNG-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640307#comment-17640307
]
Olivier Lamy commented on MNG-7316:
---
frankly looking at the commons plugin code, it looks they should fix their
code (or at least make it more simple)
feel free to revert as it looks too complicated for some people to simplify or
change their code...
But it will be possible again to add exact same artifact to this list and
deploy it multiple times which cause issue when it's a release.
> MavenProject.getAttachedArtifacts() regression with 3.8.1
> -
>
> Key: MNG-7316
> URL: https://issues.apache.org/jira/browse/MNG-7316
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.2, 3.8.3
>Reporter: Gary D. Gregory
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> The method {{MavenProject.getAttachedArtifacts()}} as of 3.8.2 breaks
> releasing components for us at Apache Commons using our Maven Release plugin
> because the list returned is now immutable, we now get an exception when
> calling {{remove()}} on the collection returned by the API; see
> [https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java#L137]
> This worked fine in 3.8.1, may you please change it back for 3.8.4?
> We cannot use Maven 3.8.2 and 3.8.3 to release our components.
> ([~michael-o]: Ironically, I discovered this trying to create a release
> candidate for Apache Commons CLI.)
> The exception in 3.8.3:
> {quote}Caused by: java.lang.UnsupportedOperationException
> at java.util.Collections$UnmodifiableCollection.remove
> (Collections.java:1060)
> at
> org.apache.commons.release.plugin.mojos.CommonsDistributionDetachmentMojo.execute
> (CommonsDistributionDetachmentMojo.java:136)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-doxia] dependabot[bot] commented on pull request #121: Bump slf4jVersion from 1.7.36 to 2.0.3
dependabot[bot] commented on PR #121: URL: https://github.com/apache/maven-doxia/pull/121#issuecomment-1329889461 OK, I won't notify you about version 2.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia] dependabot[bot] closed pull request #121: Bump slf4jVersion from 1.7.36 to 2.0.3
dependabot[bot] closed pull request #121: Bump slf4jVersion from 1.7.36 to 2.0.3 URL: https://github.com/apache/maven-doxia/pull/121 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-doxia] slachiewicz commented on pull request #121: Bump slf4jVersion from 1.7.36 to 2.0.3
slachiewicz commented on PR #121: URL: https://github.com/apache/maven-doxia/pull/121#issuecomment-1329889444 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-parent] slachiewicz commented on pull request #81: [MPOM-348] Drop configuration for not used Maven Changes Plugin
slachiewicz commented on PR #81: URL: https://github.com/apache/maven-parent/pull/81#issuecomment-1329880647 done https://github.com/apache/maven-site/commit/9bb731504e71eac15ead884fbe0a265930317ac8 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-deploy-plugin] elharo merged pull request #29: Assume at least Maven 3
elharo merged PR #29: URL: https://github.com/apache/maven-deploy-plugin/pull/29 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7316) MavenProject.getAttachedArtifacts() regression with 3.8.1
[
https://issues.apache.org/jira/browse/MNG-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640257#comment-17640257
]
Michael Osipov commented on MNG-7316:
-
Good question. At most this one I guess:
https://github.com/apache/maven/commit/66a43813770cd7dee9eb1ed0372e3f784ba0c541#diff-ea86e9c1e8def45475c1f03fc335686165184ec2ab190054f5c8b7b77c4414f4R954
> MavenProject.getAttachedArtifacts() regression with 3.8.1
> -
>
> Key: MNG-7316
> URL: https://issues.apache.org/jira/browse/MNG-7316
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.2, 3.8.3
>Reporter: Gary D. Gregory
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> The method {{MavenProject.getAttachedArtifacts()}} as of 3.8.2 breaks
> releasing components for us at Apache Commons using our Maven Release plugin
> because the list returned is now immutable, we now get an exception when
> calling {{remove()}} on the collection returned by the API; see
> [https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java#L137]
> This worked fine in 3.8.1, may you please change it back for 3.8.4?
> We cannot use Maven 3.8.2 and 3.8.3 to release our components.
> ([~michael-o]: Ironically, I discovered this trying to create a release
> candidate for Apache Commons CLI.)
> The exception in 3.8.3:
> {quote}Caused by: java.lang.UnsupportedOperationException
> at java.util.Collections$UnmodifiableCollection.remove
> (Collections.java:1060)
> at
> org.apache.commons.release.plugin.mojos.CommonsDistributionDetachmentMojo.execute
> (CommonsDistributionDetachmentMojo.java:136)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7316) MavenProject.getAttachedArtifacts() regression with 3.8.1
[
https://issues.apache.org/jira/browse/MNG-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640245#comment-17640245
]
Sylwester Lachiewicz commented on MNG-7316:
---
You mean revert full commit or only one line thats returns immutable collection?
> MavenProject.getAttachedArtifacts() regression with 3.8.1
> -
>
> Key: MNG-7316
> URL: https://issues.apache.org/jira/browse/MNG-7316
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.2, 3.8.3
>Reporter: Gary D. Gregory
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> The method {{MavenProject.getAttachedArtifacts()}} as of 3.8.2 breaks
> releasing components for us at Apache Commons using our Maven Release plugin
> because the list returned is now immutable, we now get an exception when
> calling {{remove()}} on the collection returned by the API; see
> [https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java#L137]
> This worked fine in 3.8.1, may you please change it back for 3.8.4?
> We cannot use Maven 3.8.2 and 3.8.3 to release our components.
> ([~michael-o]: Ironically, I discovered this trying to create a release
> candidate for Apache Commons CLI.)
> The exception in 3.8.3:
> {quote}Caused by: java.lang.UnsupportedOperationException
> at java.util.Collections$UnmodifiableCollection.remove
> (Collections.java:1060)
> at
> org.apache.commons.release.plugin.mojos.CommonsDistributionDetachmentMojo.execute
> (CommonsDistributionDetachmentMojo.java:136)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-integration-testing] cstamas opened a new pull request, #215: [MNG-7608] Make ITs aware of transport change
cstamas opened a new pull request, #215: URL: https://github.com/apache/maven-integration-testing/pull/215 As Maven4 default transport changes, some ITs needs adjustment. --- https://issues.apache.org/jira/browse/MNG-7608 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-7316) MavenProject.getAttachedArtifacts() regression with 3.8.1
[
https://issues.apache.org/jira/browse/MNG-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned MNG-7316:
---
Assignee: Michael Osipov
> MavenProject.getAttachedArtifacts() regression with 3.8.1
> -
>
> Key: MNG-7316
> URL: https://issues.apache.org/jira/browse/MNG-7316
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.2, 3.8.3
>Reporter: Gary D. Gregory
>Assignee: Michael Osipov
>Priority: Critical
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> The method {{MavenProject.getAttachedArtifacts()}} as of 3.8.2 breaks
> releasing components for us at Apache Commons using our Maven Release plugin
> because the list returned is now immutable, we now get an exception when
> calling {{remove()}} on the collection returned by the API; see
> [https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java#L137]
> This worked fine in 3.8.1, may you please change it back for 3.8.4?
> We cannot use Maven 3.8.2 and 3.8.3 to release our components.
> ([~michael-o]: Ironically, I discovered this trying to create a release
> candidate for Apache Commons CLI.)
> The exception in 3.8.3:
> {quote}Caused by: java.lang.UnsupportedOperationException
> at java.util.Collections$UnmodifiableCollection.remove
> (Collections.java:1060)
> at
> org.apache.commons.release.plugin.mojos.CommonsDistributionDetachmentMojo.execute
> (CommonsDistributionDetachmentMojo.java:136)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7316) MavenProject.getAttachedArtifacts() regression with 3.8.1
[
https://issues.apache.org/jira/browse/MNG-7316?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640234#comment-17640234
]
Michael Osipov commented on MNG-7316:
-
[~gnodet], [~olamy], I want to roll back this change for 3.8.7 since the did
not properly define the behavior. My proposal is to add documentation for 3.9.0
that this list is immutable and in 3.8.7 no doc change, but revert. Then we can
think about how to make this better in the future.
> MavenProject.getAttachedArtifacts() regression with 3.8.1
> -
>
> Key: MNG-7316
> URL: https://issues.apache.org/jira/browse/MNG-7316
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.2, 3.8.3
>Reporter: Gary D. Gregory
>Priority: Critical
> Fix For: waiting-for-feedback, wontfix-candidate
>
>
> The method {{MavenProject.getAttachedArtifacts()}} as of 3.8.2 breaks
> releasing components for us at Apache Commons using our Maven Release plugin
> because the list returned is now immutable, we now get an exception when
> calling {{remove()}} on the collection returned by the API; see
> [https://github.com/apache/commons-release-plugin/blob/master/src/main/java/org/apache/commons/release/plugin/mojos/CommonsDistributionDetachmentMojo.java#L137]
> This worked fine in 3.8.1, may you please change it back for 3.8.4?
> We cannot use Maven 3.8.2 and 3.8.3 to release our components.
> ([~michael-o]: Ironically, I discovered this trying to create a release
> candidate for Apache Commons CLI.)
> The exception in 3.8.3:
> {quote}Caused by: java.lang.UnsupportedOperationException
> at java.util.Collections$UnmodifiableCollection.remove
> (Collections.java:1060)
> at
> org.apache.commons.release.plugin.mojos.CommonsDistributionDetachmentMojo.execute
> (CommonsDistributionDetachmentMojo.java:136)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:137)
> {quote}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-reporting-impl] michael-o commented on a diff in pull request #13: [MSHARED-1168] support markup output
michael-o commented on code in PR #13:
URL:
https://github.com/apache/maven-reporting-impl/pull/13#discussion_r1033951738
##
pom.xml:
##
@@ -131,6 +132,17 @@
doxia-site-renderer
${doxiaSitetoolsVersion}
+
+
+ org.apache.maven.doxia
+ doxia-module-apt
+ ${doxiaVersion}
+
+
+ org.apache.maven.doxia
+ doxia-module-xdoc
+ ${doxiaVersion}
+
Review Comment:
Aren't these sufficient at runtime?
##
src/main/java/org/apache/maven/reporting/AbstractMavenReport.java:
##
@@ -163,6 +177,61 @@ public void execute()
return;
}
+if ( outputFormat != null )
+{
+reportToMarkup();
+}
+else
+{
+reportToSite();
+}
+}
+
+private void reportToMarkup()
+throws MojoExecutionException
+{
+getLog().info( "rendering to " + outputFormat + " markup" );
Review Comment:
Rendering...
##
src/main/java/org/apache/maven/reporting/AbstractMavenReport.java:
##
@@ -163,6 +177,61 @@ public void execute()
return;
}
+if ( outputFormat != null )
+{
+reportToMarkup();
+}
+else
+{
+reportToSite();
+}
+}
+
+private void reportToMarkup()
+throws MojoExecutionException
+{
+getLog().info( "rendering to " + outputFormat + " markup" );
+
+if ( !isExternalReport() )
+{
+try
+{
+sinkFactory = container.lookup( SinkFactory.class,
outputFormat );
+sink = sinkFactory.createSink( outputDirectory,
getOutputName() + '.' + outputFormat );
+}
+catch ( ComponentLookupException cle )
+{
+throw new MojoExecutionException(
+"Cannot find SinkFactory for Doxia output format: " +
outputFormat, cle );
+}
+catch ( IOException ioe )
+{
+throw new MojoExecutionException( "Cannot create sink to " +
outputDirectory, ioe );
Review Comment:
sink for
##
src/main/java/org/apache/maven/reporting/AbstractMavenReport.java:
##
@@ -383,7 +452,10 @@ protected Skin getSkin()
*/
protected void closeReport()
{
-getSink().close();
+if ( getSink() != null )
Review Comment:
When can the sink be `null`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7608) Make Resolver native transport the default in Maven4
[ https://issues.apache.org/jira/browse/MNG-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640192#comment-17640192 ] Tamas Cservenak commented on MNG-7608: -- This requires IT changes: * MavenITmng3652UserAgentHeaderTest.testmng3652_AdditionnalHttpHeaderConfiguredInSettings * MavenITmng3652UserAgentHeaderTest.testmng3652_UserAgentConfiguredInSettings * MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings * MavenITmng7470ResolverTransportTest.testResolverTransportDefault (trivial, "default" is not anymore Wagon) Out of others for sure some use archaic (Maven2) way of plexus configuration to set headers and/or timeout settings (instead of common resolver configuration as explained [https://maven.apache.org/resolver/configuration.html] ) > Make Resolver native transport the default in Maven4 > > > Key: MNG-7608 > URL: https://issues.apache.org/jira/browse/MNG-7608 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate, 4.0.0 > > > The ancient Wagon should be phased out, and "native" resolver transport > should be the default in Maven4. This in start halves the HTTP request count > toward Maven Central and any major MRM. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MNG-7608) Make Resolver native transport the default in Maven4
[ https://issues.apache.org/jira/browse/MNG-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640192#comment-17640192 ] Tamas Cservenak edited comment on MNG-7608 at 11/28/22 6:46 PM: These requires IT changes: * MavenITmng3652UserAgentHeaderTest.testmng3652_AdditionnalHttpHeaderConfiguredInSettings * MavenITmng3652UserAgentHeaderTest.testmng3652_UserAgentConfiguredInSettings * MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings * MavenITmng7470ResolverTransportTest.testResolverTransportDefault (trivial, "default" is not anymore Wagon) Out of others for sure some use archaic (Maven2) way of plexus configuration to set headers and/or timeout settings (instead of common resolver configuration as explained [https://maven.apache.org/resolver/configuration.html] ) was (Author: cstamas): This requires IT changes: * MavenITmng3652UserAgentHeaderTest.testmng3652_AdditionnalHttpHeaderConfiguredInSettings * MavenITmng3652UserAgentHeaderTest.testmng3652_UserAgentConfiguredInSettings * MavenITmng5175WagonHttpTest.testmng5175_ReadTimeOutFromSettings * MavenITmng7470ResolverTransportTest.testResolverTransportDefault (trivial, "default" is not anymore Wagon) Out of others for sure some use archaic (Maven2) way of plexus configuration to set headers and/or timeout settings (instead of common resolver configuration as explained [https://maven.apache.org/resolver/configuration.html] ) > Make Resolver native transport the default in Maven4 > > > Key: MNG-7608 > URL: https://issues.apache.org/jira/browse/MNG-7608 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate, 4.0.0 > > > The ancient Wagon should be phased out, and "native" resolver transport > should be the default in Maven4. This in start halves the HTTP request count > toward Maven Central and any major MRM. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7608) Make Resolver native transport the default in Maven4
Tamas Cservenak created MNG-7608: Summary: Make Resolver native transport the default in Maven4 Key: MNG-7608 URL: https://issues.apache.org/jira/browse/MNG-7608 Project: Maven Issue Type: Improvement Reporter: Tamas Cservenak Fix For: 4.0.x-candidate, 4.0.0 The ancient Wagon should be phased out, and "native" resolver transport should be the default in Maven4. This in start halves the HTTP request count toward Maven Central and any major MRM. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MNG-7607) Add Transport to new Immutable API
Tamas Cservenak created MNG-7607: Summary: Add Transport to new Immutable API Key: MNG-7607 URL: https://issues.apache.org/jira/browse/MNG-7607 Project: Maven Issue Type: New Feature Reporter: Tamas Cservenak Fix For: 4.0.x-candidate, 4.0.0 Introduce simple API to GET/PUT resources. Keep it intentionally simple, that still covers quite broad range of use cases. If plugin/extension needs a bit advanced features (like conditional GETs or whatnot), they should roll their own. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #885: Make native resolver transport the m4 default.
cstamas commented on PR #885: URL: https://github.com/apache/maven/pull/885#issuecomment-1329567454 Default changed (MavenITmng7470ResolverTransportTest.testResolverTransportDefault), and other 3 ITs expect Wagon to be used without overriding default, out of which 2 uses ancient way of setting UA header (using plexus configuration) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640186#comment-17640186 ] ASF GitHub Bot commented on MNG-6609: - cstamas commented on PR #883: URL: https://github.com/apache/maven/pull/883#issuecomment-1329563048 Jut wanted to quickly "publish" my findings about the cause, but around same time moved to something else :smile: feel free to reuse (no need to keep my user ID, after all this is your change set with my one line removal). Or, I can pick it up later. > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #883: [MNG-6609] Profile activation based on packaging
cstamas commented on PR #883: URL: https://github.com/apache/maven/pull/883#issuecomment-1329563048 Jut wanted to quickly "publish" my findings about the cause, but around same time moved to something else :smile: feel free to reuse (no need to keep my user ID, after all this is your change set with my one line removal). Or, I can pick it up later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-2128) Need Help in Implementing patching of Surefire JUnit Parallel Execution Parameters
Kamalpreet created SUREFIRE-2128:
Summary: Need Help in Implementing patching of Surefire JUnit
Parallel Execution Parameters
Key: SUREFIRE-2128
URL: https://issues.apache.org/jira/browse/SUREFIRE-2128
Project: Maven Surefire
Issue Type: Wish
Components: Maven Failsafe Plugin, Maven Surefire Plugin
Reporter: Kamalpreet
Hi Team,
Not sure if this is the correct platform to reach out for help regarding
Surefire/Failsafe plugin.
I'm currently creating a package from where I would want to set JUnit parallel
execution parameters like below :
{code:java}
classesAndMethods
1
1
false{code}
I'm planning to use Instrumentation API to inject these parameters. I tried to
find the correct place where I can do so, but failed to find one.
Please point me to a class from where these value are being honoured So that I
could inject these parameters there. You could also suggest me a way to set
these values apart from adding them to ** element.
Thanks.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #884: Add M4 Transport API
cstamas commented on PR #884: URL: https://github.com/apache/maven/pull/884#issuecomment-1329316827 One big remark I just noticed: m4 API uses Optional quite extensively, while I went with my own preference. Better to not mix things, and rework this with Optional? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas opened a new pull request, #885: Make native resolver transport the m4 default.
cstamas opened a new pull request, #885: URL: https://github.com/apache/maven/pull/885 This immediately cuts in "half" the count of HTTP requests against Maven Central or any major MRM. Altering the meaning of "default": is now same as NATIVE, still leaving it in place for future, as "default" at some point may again become something different than "native". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] slawekjaranowski closed pull request #87: Bump slf4j-simple from 1.7.36 to 2.0.5
slawekjaranowski closed pull request #87: Bump slf4j-simple from 1.7.36 to 2.0.5 URL: https://github.com/apache/maven-jxr/pull/87 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] commented on pull request #87: Bump slf4j-simple from 1.7.36 to 2.0.5
dependabot[bot] commented on PR #87: URL: https://github.com/apache/maven-jxr/pull/87#issuecomment-1329299177 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] commented on pull request #88: Bump slf4j-api from 1.7.36 to 2.0.5
dependabot[bot] commented on PR #88: URL: https://github.com/apache/maven-jxr/pull/88#issuecomment-1329298807 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] slawekjaranowski closed pull request #88: Bump slf4j-api from 1.7.36 to 2.0.5
slawekjaranowski closed pull request #88: Bump slf4j-api from 1.7.36 to 2.0.5 URL: https://github.com/apache/maven-jxr/pull/88 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on pull request #884: Add M4 Transport API
slawekjaranowski commented on PR #884: URL: https://github.com/apache/maven/pull/884#issuecomment-1329296262 Great idea, I see that we can cover one case when user want to download a custom resource from remote repository. We also have another case when user want to download a custom resource from any remote url. And also want to use authorization configuration from settings/servers and preserve settings/proxy for connections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSHARED-1169) Deprecate join methods now available in Java 8 String class
Elliotte Rusty Harold created MSHARED-1169: -- Summary: Deprecate join methods now available in Java 8 String class Key: MSHARED-1169 URL: https://issues.apache.org/jira/browse/MSHARED-1169 Project: Maven Shared Components Issue Type: Improvement Components: maven-shared-utils Reporter: Elliotte Rusty Harold Assignee: Elliotte Rusty Harold -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #884: Add M4 Transport API
gnodet commented on code in PR #884:
URL: https://github.com/apache/maven/pull/884#discussion_r1033666376
##
api/maven-api-core/src/main/java/org/apache/maven/api/services/Transport.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.services;
+
+import java.io.Closeable;
+import java.net.URI;
+import java.nio.charset.Charset;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Path;
+import org.apache.maven.api.RemoteRepository;
+import org.apache.maven.api.annotations.Consumer;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nonnull;
+import org.apache.maven.api.annotations.Nullable;
+
+/**
+ * Transport for specified remote repository (using provided remote repository
base URI as root). Must be treated as a
+ * resource, best in try-with-resource block.
+ *
+ * @since 4.0
+ */
+@Experimental
+@Consumer
+public interface Transport extends Closeable {
+/**
+ * GETs the source URI content into target (does not have to exist, or
will be overwritten if exist). The
+ * source MUST BE relative from the {@link RemoteRepository#getUrl()} root.
+ *
+ * @return {@code true} if operation succeeded, {@code false} if source
does not exist.
+ * @throws RuntimeException If failed (and not due source not exists).
+ */
+boolean get(@Nonnull URI relativeSource, @Nonnull Path target);
+
+/**
+ * GETs the source URI content as byte array. The source MUST BE relative
from the {@link RemoteRepository#getUrl()}
+ * root.
+ *
+ * @return the byte array if operation succeeded, {@code null} if source
does not exist.
+ * @throws RuntimeException If failed (and not due source not exists).
+ */
+@Nullable
+byte[] getBytes(@Nonnull URI relativeSource);
+
+/**
+ * GETs the source URI content as string. The source MUST BE relative from
the {@link RemoteRepository#getUrl()}
+ * root.
+ *
+ * @return the string if operation succeeded, {@code null} if source does
not exist.
+ * @throws RuntimeException If failed (and not due source not exists).
+ */
+@Nullable
+String getString(@Nonnull URI relativeSource, @Nonnull Charset charset);
+
+/**
+ * GETs the source URI content as string using UTF8 charset. The source
MUST BE relative from the
+ * {@link RemoteRepository#getUrl()} root.
+ *
+ * @return the string if operation succeeded, {@code null} if source does
not exist.
+ * @throws RuntimeException If failed (and not due source not exists).
+ */
+default String getString(@Nonnull URI relativeSource) {
Review Comment:
`@Nullable` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #884: Add M4 Transport API
gnodet commented on code in PR #884:
URL: https://github.com/apache/maven/pull/884#discussion_r1033659141
##
api/maven-api-core/src/main/java/org/apache/maven/api/services/Transport.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.services;
+
+import java.io.Closeable;
+import java.net.URI;
+import java.nio.charset.Charset;
+import java.nio.file.Path;
+import org.apache.maven.api.RemoteRepository;
+import org.apache.maven.api.annotations.Consumer;
+import org.apache.maven.api.annotations.Experimental;
+import org.apache.maven.api.annotations.Nullable;
+
+/**
+ * Transport for specified remote repository (using provided remote repository
base URI as root). Must be treated as a
+ * resource, best in try-with-resource block.
+ *
+ * @since 4.0
+ */
+@Experimental
+@Consumer
+public interface Transport extends Closeable {
+/**
+ * GETs the source URI content into target (does not have to exist, or
will be overwritten if exist). The
+ * source MUST BE relative from the {@link RemoteRepository#getUrl()} root.
+ *
+ * @return {@code true} if operation succeeded, {@code false} if source
does not exist.
+ * @throws RuntimeException If failed (and not due source not exists).
+ */
+boolean get(URI relativeSource, Path target);
+
+/**
+ * GETs the source URI content into target consumer. The
+ * source MUST BE relative from the {@link RemoteRepository#getUrl()} root.
+ *
+ * @return the byte array if operation succeeded, {@code null} if source
does not exist.
+ * @throws RuntimeException If failed (and not due source not exists).
+ */
+@Nullable
+byte[] getBytes(URI relativeSource);
+
+/**
+ * GETs the source URI content as string. The
+ * source MUST BE relative from the {@link RemoteRepository#getUrl()} root.
+ *
+ * @return the string if operation succeeded, {@code null} if source does
not exist.
+ * @throws RuntimeException If failed (and not due source not exists).
+ */
+@Nullable
+String getString(URI relativeSource, Charset charset);
+
+/**
+ * PUTs the source file (must exist as file) to target URI. The target
MUST BE relative from the
+ * {@link RemoteRepository#getUrl()} root.
+ *
+ * @throws RuntimeException If PUT fails for any reason.
+ */
+void put(Path source, URI relativeTarget);
+
+/**
+ * PUTs the source byte array to target URI. The target MUST BE relative
from the
+ * {@link RemoteRepository#getUrl()} root.
+ *
+ * @throws RuntimeException If PUT fails for any reason.
+ */
+void putBytes(byte[] source, URI relativeTarget);
+
+/**
+ * PUTs the source string to target URI. The target MUST BE relative from
the
+ * {@link RemoteRepository#getUrl()} root.
+ *
+ * @throws RuntimeException If PUT fails for any reason.
+ */
+void putString(String source, Charset charset, URI relativeTarget);
Review Comment:
May I ask for a default:
```
default void putString(String source, URI relativeTarget) {
putString(source, StandardCharsets.UTF_8, relativeTarget);
}
```
##
api/maven-api-core/src/main/java/org/apache/maven/api/services/Transport.java:
##
@@ -0,0 +1,91 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.services;
+
+import java.io.Closeable;
[GitHub] [maven-integration-testing] kwin commented on a diff in pull request #214: [MNG-7606] add IT
kwin commented on code in PR #214:
URL:
https://github.com/apache/maven-integration-testing/pull/214#discussion_r1033574801
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7606DependencyImportScopeTest.java:
##
@@ -0,0 +1,46 @@
+package org.apache.maven.it;
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7606;>MNG-7606.
+ * It checks that "import" scope for dependencies work
+ *
+ */
+class MavenITmng7606DependencyImportScopeTest
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7606DependencyImportScopeTest()
+{
+super( "[3.9.0,)" );
Review Comment:
Agreed, adjusted accordingly in
https://github.com/apache/maven-integration-testing/pull/214/commits/e192fd6384aaeb266ce14b2a95a24947887dd3d9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] gnodet commented on a diff in pull request #884: Add M4 Transport API
gnodet commented on code in PR #884:
URL: https://github.com/apache/maven/pull/884#discussion_r1033568463
##
api/maven-api-core/src/main/java/org/apache/maven/api/services/Transport.java:
##
@@ -0,0 +1,50 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.services;
+
+import java.net.URI;
+import java.nio.file.Path;
+
+import org.apache.maven.api.RemoteRepository;
+import org.apache.maven.api.annotations.Consumer;
+import org.apache.maven.api.annotations.Experimental;
+
+/**
+ * @since 4.0
+ */
+@Experimental
+@Consumer
+public interface Transport
+{
Review Comment:
I would still add helpers for transferring the data as `byte[]` and
`String`. Even the `java.nio.Files` api now as those !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven] cstamas opened a new pull request, #884: Add M4 Transport API
cstamas opened a new pull request, #884: URL: https://github.com/apache/maven/pull/884 Something simple to use and would reuse all the auth/proxy etc data from Maven. Intentionally super-trivial API. If something more "serious" needed, plugin should probably roll it's own solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINDEXER-181) IndexDataReader should use Sets instead of ConcurrentHashMaps w/ fixed values
[
https://issues.apache.org/jira/browse/MINDEXER-181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640013#comment-17640013
]
Hudson commented on MINDEXER-181:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-indexer » master #86
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-indexer/job/master/86/
> IndexDataReader should use Sets instead of ConcurrentHashMaps w/ fixed values
> -
>
> Key: MINDEXER-181
> URL: https://issues.apache.org/jira/browse/MINDEXER-181
> Project: Maven Indexer
> Issue Type: Improvement
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 7.0.1
>
>
> Noticed that both, the single threaded and the multi threaded impl used CHMs.
> Instead of only changing {{readIndexST}} to plain {{{}Map{}}}s, I switched
> everything to {{{}Set{}}}s.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MINDEXER-181) IndexDataReader should use Sets instead of ConcurrentHashMaps w/ fixed values
[
https://issues.apache.org/jira/browse/MINDEXER-181?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MINDEXER-181.
Resolution: Fixed
> IndexDataReader should use Sets instead of ConcurrentHashMaps w/ fixed values
> -
>
> Key: MINDEXER-181
> URL: https://issues.apache.org/jira/browse/MINDEXER-181
> Project: Maven Indexer
> Issue Type: Improvement
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 7.0.1
>
>
> Noticed that both, the single threaded and the multi threaded impl used CHMs.
> Instead of only changing {{readIndexST}} to plain {{{}Map{}}}s, I switched
> everything to {{{}Set{}}}s.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-indexer] cstamas merged pull request #277: [MINDEXER-181] IndexDataReader should use Sets
cstamas merged PR #277: URL: https://github.com/apache/maven-indexer/pull/277 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHADE-434) Strange side-effect on rat-plugin
[
https://issues.apache.org/jira/browse/MSHADE-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17640002#comment-17640002
]
Chesnay Schepler commented on MSHADE-434:
-
After changing the rat-plugin to run in the {{validate}} phase our
checkstyle-plugin is now complaining in submodules that it can't find the
suppression file in the root directory anymore :/
> Strange side-effect on rat-plugin
> -
>
> Key: MSHADE-434
> URL: https://issues.apache.org/jira/browse/MSHADE-434
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Chesnay Schepler
>Priority: Major
>
> When upgrading the shade-plugin from 3.2.4 to 3.3.0, without changing
> anything else, the Apache Flink builds are getting failed by the rat-plugin,
> complaining about a number of files in the root target/ directory.
> These files do exist, but are usually excluded by the plugin.
> For some reason upgrading the shade-plugin is changing this behavior.
> {code:java}
> [WARNING] Files with unapproved licenses:
> /home/chesnay/dev/repos/flink/flink/target/rat.txt
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-result.xml
> /home/chesnay/dev/repos/flink/flink/target/checkstyle-cachefile
> {code}
> This is rally strange, and were wondering if you guys have any ideas for
> what could going on here.
> Interestingly enough explicitly listing these files (e.g., {{**/rat.txt}})
> results in them being excluded again.
> This happened with Java 8 + Maven 3.2.5 and Java 11 + Maven 3.8.6 and is 100%
> reproducible.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=1764#comment-1764 ] ASF GitHub Bot commented on MNG-6609: - cstamas opened a new pull request, #883: URL: https://github.com/apache/maven/pull/883 In short: do NOT set request.setRawModel as NOTHING sets it. The Maven4 vs Maven3 is different, in Maven 3 NOTHING calls request.setRawModel --- https://issues.apache.org/jira/browse/MNG-6609 > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas opened a new pull request, #883: [MNG-6609] Profile activation based on packaging
cstamas opened a new pull request, #883: URL: https://github.com/apache/maven/pull/883 In short: do NOT set request.setRawModel as NOTHING sets it. The Maven4 vs Maven3 is different, in Maven 3 NOTHING calls request.setRawModel --- https://issues.apache.org/jira/browse/MNG-6609 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo commented on pull request #270: [MDEP-831] Remove dependency on commons-lang3
elharo commented on PR #270: URL: https://github.com/apache/maven-dependency-plugin/pull/270#issuecomment-1328973547 [ERROR] - [ERROR] [INFO] - [INFO] Build Summary: [INFO] Passed: 75, Failed: 1, Errors: 0, Skipped: 0 [INFO] - [ERROR] The following builds failed: [ERROR] * mdep-450-project-with-ancestor/pom.xml [INFO] --- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] closed pull request #84: Bump slf4j-api from 1.7.36 to 2.0.4
dependabot[bot] closed pull request #84: Bump slf4j-api from 1.7.36 to 2.0.4 URL: https://github.com/apache/maven-jxr/pull/84 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] commented on pull request #84: Bump slf4j-api from 1.7.36 to 2.0.4
dependabot[bot] commented on PR #84: URL: https://github.com/apache/maven-jxr/pull/84#issuecomment-1328970009 Superseded by #88. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] commented on pull request #85: Bump slf4j-simple from 1.7.36 to 2.0.4
dependabot[bot] commented on PR #85: URL: https://github.com/apache/maven-jxr/pull/85#issuecomment-1328969624 Superseded by #87. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] opened a new pull request, #88: Bump slf4j-api from 1.7.36 to 2.0.5
dependabot[bot] opened a new pull request, #88: URL: https://github.com/apache/maven-jxr/pull/88 Bumps [slf4j-api](https://github.com/qos-ch/slf4j) from 1.7.36 to 2.0.5. Commits https://github.com/qos-ch/slf4j/commit/7e62e1e6917e19e6eeb8faf97daa9e2469bc946d;>7e62e1e prepare release 2.0.5 https://github.com/qos-ch/slf4j/commit/d250ad79ebbd46f098b07c0868d1cbc8c09c8d6c;>d250ad7 in jcl-over-slf4j rename LICENSE.TXT as LICENSE, add LICENSE file to log4j-ov... https://github.com/qos-ch/slf4j/commit/3bc58f3e81cfbe5ef9011c5124c0bd13dceee3a9;>3bc58f3 add SecurityManager support https://github.com/qos-ch/slf4j/commit/207bb299c319886aededb999269c1555abb9deae;>207bb29 start work on 2.0.5-SNAPSHOT https://github.com/qos-ch/slf4j/commit/35dd7ff1e75cf83ffb6784a9537ff92c865e78b2;>35dd7ff removed unused META-INF/services entry https://github.com/qos-ch/slf4j/commit/440c2f3000fc0e2d7646f0b3d6e36e8bc2ef2485;>440c2f3 prepare release 2.0.4 https://github.com/qos-ch/slf4j/commit/43a36303e5a2338c22ec9aad5b01a401034eb553;>43a3630 use the class loader that loaded LoggerFactory (instead of the threadContextC... https://github.com/qos-ch/slf4j/commit/557bf7c0bd4e2c2cd85ef389729107461938dd15;>557bf7c [SLF4J-548] Fix ServiceLoader usage in servlet environment https://github.com/qos-ch/slf4j/commit/632410565b26e4d67fc7ef2ce4c212380b4e59d1;>6324105 enhance manifest with capabilities https://github.com/qos-ch/slf4j/commit/e540299d58bc5f53cab3236cc1b2f29281982074;>e540299 edit blurb on release championing Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.5;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] closed pull request #85: Bump slf4j-simple from 1.7.36 to 2.0.4
dependabot[bot] closed pull request #85: Bump slf4j-simple from 1.7.36 to 2.0.4 URL: https://github.com/apache/maven-jxr/pull/85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-jxr] dependabot[bot] opened a new pull request, #87: Bump slf4j-simple from 1.7.36 to 2.0.5
dependabot[bot] opened a new pull request, #87: URL: https://github.com/apache/maven-jxr/pull/87 Bumps [slf4j-simple](https://github.com/qos-ch/slf4j) from 1.7.36 to 2.0.5. Commits https://github.com/qos-ch/slf4j/commit/7e62e1e6917e19e6eeb8faf97daa9e2469bc946d;>7e62e1e prepare release 2.0.5 https://github.com/qos-ch/slf4j/commit/d250ad79ebbd46f098b07c0868d1cbc8c09c8d6c;>d250ad7 in jcl-over-slf4j rename LICENSE.TXT as LICENSE, add LICENSE file to log4j-ov... https://github.com/qos-ch/slf4j/commit/3bc58f3e81cfbe5ef9011c5124c0bd13dceee3a9;>3bc58f3 add SecurityManager support https://github.com/qos-ch/slf4j/commit/207bb299c319886aededb999269c1555abb9deae;>207bb29 start work on 2.0.5-SNAPSHOT https://github.com/qos-ch/slf4j/commit/35dd7ff1e75cf83ffb6784a9537ff92c865e78b2;>35dd7ff removed unused META-INF/services entry https://github.com/qos-ch/slf4j/commit/440c2f3000fc0e2d7646f0b3d6e36e8bc2ef2485;>440c2f3 prepare release 2.0.4 https://github.com/qos-ch/slf4j/commit/43a36303e5a2338c22ec9aad5b01a401034eb553;>43a3630 use the class loader that loaded LoggerFactory (instead of the threadContextC... https://github.com/qos-ch/slf4j/commit/557bf7c0bd4e2c2cd85ef389729107461938dd15;>557bf7c [SLF4J-548] Fix ServiceLoader usage in servlet environment https://github.com/qos-ch/slf4j/commit/632410565b26e4d67fc7ef2ce4c212380b4e59d1;>6324105 enhance manifest with capabilities https://github.com/qos-ch/slf4j/commit/e540299d58bc5f53cab3236cc1b2f29281982074;>e540299 edit blurb on release championing Additional commits viewable in https://github.com/qos-ch/slf4j/compare/v_1.7.36...v_2.0.5;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-2127) Resource temporarily unavailable when running tests that invoke Node using Surefire 3
Artur created SUREFIRE-2127:
---
Summary: Resource temporarily unavailable when running tests that
invoke Node using Surefire 3
Key: SUREFIRE-2127
URL: https://issues.apache.org/jira/browse/SUREFIRE-2127
Project: Maven Surefire
Issue Type: Bug
Components: Maven Surefire Plugin
Affects Versions: 3.0.0-M7
Reporter: Artur
When running the Vaadin Flow test set using surefire 3.0.0-M7 we always end up
with
{code:java}
[SUREFIRE] std/in stream corrupted
java.io.IOException: Resource temporarily unavailable
at java.base/java.io.FileInputStream.readBytes(Native Method)
at java.base/java.io.FileInputStream.read(FileInputStream.java:276)
at
java.base/java.io.BufferedInputStream.read1(BufferedInputStream.java:282)
at
java.base/java.io.BufferedInputStream.read(BufferedInputStream.java:343)
at
java.base/java.io.BufferedInputStream.fill(BufferedInputStream.java:244)
at
java.base/java.io.BufferedInputStream.read1(BufferedInputStream.java:284)
at
java.base/java.io.BufferedInputStream.read(BufferedInputStream.java:343)
at
org.apache.maven.surefire.api.util.internal.Channels$3.readImpl(Channels.java:217)
at
org.apache.maven.surefire.api.util.internal.AbstractNoninterruptibleReadableChannel.read(AbstractNoninterruptibleReadableChannel.java:54)
at
org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:484)
at
org.apache.maven.surefire.api.stream.AbstractStreamDecoder.read(AbstractStreamDecoder.java:470)
at
org.apache.maven.surefire.api.stream.AbstractStreamDecoder.readMessageType(AbstractStreamDecoder.java:118)
at
org.apache.maven.surefire.booter.stream.CommandDecoder.decode(CommandDecoder.java:87)
at
org.apache.maven.surefire.booter.spi.CommandChannelDecoder.decode(CommandChannelDecoder.java:67)
at
org.apache.maven.surefire.booter.CommandReader$CommandRunnable.run(CommandReader.java:345)
at java.base/java.lang.Thread.run(Thread.java:833)
{code}
This problem is introduced in
[SUREFIRE-1658|https://issues.apache.org/jira/projects/SUREFIRE/issues/SUREFIRE-1658],
verified using git bisect
It seems to occur in tests that invoke `pnpm` through `node` so potentially
this is related to [https://github.com/nodejs/node/issues/42826] as the error
message "Resource temporarily unavailable" seems to refer to EAGAIN
[https://stackoverflow.com/a/4058377/3336733] or in other words that the file
descriptor is in non-blocking mode and there is no data available to read.
The Vaadin Flow PR where this has been tested is
[https://github.com/vaadin/flow/pull/15102]
Can be reproduced by checking out that branch (`upgrade-test-runners`) and
running `mvn test`. It will fail on the `flow-server` module from where all
tests except one have been removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-indexer] mbien commented on pull request #277: [MINDEXER-181] IndexDataReader should use Sets
mbien commented on PR #277: URL: https://github.com/apache/maven-indexer/pull/277#issuecomment-1328883441 > @mbien anything more you want to add or this PR is good to go? would be all for this PR. Wanted to investigate if it would be possible to do a shallow extraction (comparable to git clone --depth) based on artifact age or number of versions since it might be interesting for IDE use. As a test i tried to run with `indexUpdateRequest.setDocumentFilter((doc) -> false);` but this did produce an index with identical size even though the filter method was called. But first I probably try to take a look what is taking up all the space in the first place - maybe there are other ways to reduce footprint. But that would be all for later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] cstamas commented on a diff in pull request #214: [MNG-7606] add IT
cstamas commented on code in PR #214:
URL:
https://github.com/apache/maven-integration-testing/pull/214#discussion_r1033325772
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7606DependencyImportScopeTest.java:
##
@@ -0,0 +1,46 @@
+package org.apache.maven.it;
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7606;>MNG-7606.
+ * It checks that "import" scope for dependencies work
+ *
+ */
+class MavenITmng7606DependencyImportScopeTest
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7606DependencyImportScopeTest()
+{
+super( "[3.9.0,)" );
Review Comment:
This should work with all Mavens, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639915#comment-17639915 ] Hudson commented on MNG-6609: - Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #90 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/90/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-integration-testing] kwin commented on a diff in pull request #214: [MNG-7606] add IT
kwin commented on code in PR #214:
URL:
https://github.com/apache/maven-integration-testing/pull/214#discussion_r1033321507
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7606DependencyImportScopeTest.java:
##
@@ -0,0 +1,46 @@
+package org.apache.maven.it;
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7606;>MNG-7606.
+ * It checks that "import" scope for dependencies work
+ *
+ */
+class MavenITmng7606DependencyImportScopeTest
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7606DependencyImportScopeTest()
+{
+super( "[3.9.0,)" );
Review Comment:
What would be an appropriate lower bound here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] kwin commented on a diff in pull request #214: [MNG-7606] add IT
kwin commented on code in PR #214:
URL:
https://github.com/apache/maven-integration-testing/pull/214#discussion_r1033321094
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7606DependencyImportScopeTest.java:
##
@@ -0,0 +1,51 @@
+package org.apache.maven.it;
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7606;>MNG-7606.
+ * It checks that "import" scope for dependencies work
+ *
+ */
+class MavenITmng7606DependencyImportScopeTest
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7606DependencyImportScopeTest()
+{
+super( "[3.9.0,)" );
+}
+
+/**
+ * Verify that dependencies which are managed through imported dependency
management work
+ *
+ * @throws Exception in case of failure
+ */
+@Test
+void testDependencyResolution()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(),
"/mng-7606" );
+
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+verifier.setAutoclean( false );
+//verifier.setDebugJvm( true );
+//verifier.setForkJvm( true );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( "org.apache.maven.its.mng7606" );
+try
+{
+verifier.executeGoal( "validate" );
+verifier.verifyErrorFreeLog();
+}
+finally
+{
+verifier.resetStreams();
Review Comment:
Fixed in
https://github.com/apache/maven-integration-testing/commit/37a5d646c879f8b46d47c98966041aa3e85ae8bc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-integration-testing] kwin commented on pull request #214: [MNG-7607] add IT
kwin commented on PR #214: URL: https://github.com/apache/maven-integration-testing/pull/214#issuecomment-1328792727 > Hm, and issue is wrong: https://issues.apache.org/jira/browse/MNG-7606 Fixed commit message in https://github.com/apache/maven-integration-testing/commit/37a5d646c879f8b46d47c98966041aa3e85ae8bc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] cstamas commented on pull request #214: [MNG-7607] add IT
cstamas commented on PR #214: URL: https://github.com/apache/maven-integration-testing/pull/214#issuecomment-1328789558 Hm, and issue is wrong: https://issues.apache.org/jira/browse/MNG-7606 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #214: [MNG-7607] add IT
slawekjaranowski commented on code in PR #214:
URL:
https://github.com/apache/maven-integration-testing/pull/214#discussion_r1033310531
##
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng7606DependencyImportScopeTest.java:
##
@@ -0,0 +1,51 @@
+package org.apache.maven.it;
+
+import java.io.File;
+
+import org.apache.maven.shared.verifier.Verifier;
+import org.apache.maven.shared.verifier.util.ResourceExtractor;
+import org.junit.jupiter.api.Test;
+
+/**
+ * This is a test set for https://issues.apache.org/jira/browse/MNG-7606;>MNG-7606.
+ * It checks that "import" scope for dependencies work
+ *
+ */
+class MavenITmng7606DependencyImportScopeTest
+extends AbstractMavenIntegrationTestCase
+{
+
+public MavenITmng7606DependencyImportScopeTest()
+{
+super( "[3.9.0,)" );
+}
+
+/**
+ * Verify that dependencies which are managed through imported dependency
management work
+ *
+ * @throws Exception in case of failure
+ */
+@Test
+void testDependencyResolution()
+throws Exception
+{
+File testDir = ResourceExtractor.simpleExtractResources( getClass(),
"/mng-7606" );
+
+Verifier verifier = newVerifier( testDir.getAbsolutePath() );
+verifier.setAutoclean( false );
+//verifier.setDebugJvm( true );
+//verifier.setForkJvm( true );
+verifier.deleteDirectory( "target" );
+verifier.deleteArtifacts( "org.apache.maven.its.mng7606" );
+try
+{
+verifier.executeGoal( "validate" );
+verifier.verifyErrorFreeLog();
+}
+finally
+{
+verifier.resetStreams();
Review Comment:
Deprecated - not needed - please also look for other deprecated methods of
Verifier.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639872#comment-17639872 ] Hudson commented on MNG-6609: - Build unstable in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #89 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/89/ > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-mvnd] ohavlicek opened a new issue, #746: NullPointerException while running
ohavlicek opened a new issue, #746: URL: https://github.com/apache/maven-mvnd/issues/746 Hi, I wanted to give this a try, but I'm getting a NPE. ``` [ERROR] NullPointerException java.lang.NullPointerException: null at org.mvndaemon.mvnd.builder.ProjectComparator.create0(ProjectComparator.java:66) at org.mvndaemon.mvnd.builder.ProjectComparator.create(ProjectComparator.java:55) at org.mvndaemon.mvnd.builder.SmartBuilderImpl.(SmartBuilderImpl.java:74) at org.mvndaemon.mvnd.builder.SmartBuilder.build(SmartBuilder.java:111) at org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:294) at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:192) at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:105) at org.apache.maven.cli.DaemonMavenCli.execute(DaemonMavenCli.java:687) at org.apache.maven.cli.DaemonMavenCli.doMain(DaemonMavenCli.java:239) at org.apache.maven.cli.DaemonMavenCli.main(DaemonMavenCli.java:215) at org.mvndaemon.mvnd.daemon.Server.handle(Server.java:572) at org.mvndaemon.mvnd.daemon.Server.client(Server.java:256) at org.mvndaemon.mvnd.daemon.Server.accept(Server.java:224) at java.base/java.lang.Thread.run(Thread.java:834) [ERROR] ``` Is there something I can do? ``` mvnd --version mvnd 0.8.2 windows-amd64 native client (2bba2d6a4d3a5012ddf9f1f42a22784cad4011e3) Terminal: org.jline.terminal.impl.jansi.win.JansiWinSysTerminal Apache Maven 3.8.6 (84538c9988a25aec085021c365c560670ad80f63) Maven home: C:\DiskD\DEV_HOME\TOOLS\maven-mvnd-0.8.2\mvn Java version: 11.0.6, vendor: Oracle Corporation, runtime: D:\DEV_HOME\TOOLS\java\1.11.0_6 Default locale: en_US, platform encoding: Cp1252 OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-7606) Maven 3.9.0-SNAPSHOT cannot build Maven 4.0.0-SNAPSHOT
[
https://issues.apache.org/jira/browse/MNG-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned MNG-7606:
Assignee: Konrad Windszus
> Maven 3.9.0-SNAPSHOT cannot build Maven 4.0.0-SNAPSHOT
> --
>
> Key: MNG-7606
> URL: https://issues.apache.org/jira/browse/MNG-7606
> Project: Maven
> Issue Type: Bug
>Reporter: Tamas Cservenak
>Assignee: Konrad Windszus
>Priority: Blocker
> Fix For: 3.9.0
>
>
> How to reproduce: build maven-3.9.x branch
> (e921f1564ef9460ca58745eb52e3967dbbd0b9e7) then checkout master branch
> (c6ecff9923088d854d4621e17d602f1c70dda806) and try to build it with built
> 3.9.0-SNAPSHOT: it fails.
> Error is:
> {noformat}
> [cstamas@blondie maven (master)]$ mvn -V clean install
> Apache Maven 3.9.0-SNAPSHOT (e921f1564ef9460ca58745eb52e3967dbbd0b9e7)
> Maven home: /home/cstamas/.sdkman/candidates/maven/3.9.0-SNAPSHOT
> Java version: 17.0.5, vendor: Eclipse Adoptium, runtime:
> /home/cstamas/.sdkman/candidates/java/17.0.5-tem
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "6.0.9-300.fc37.x86_64", arch: "amd64", family:
> "unix"
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [ERROR] 'dependencies.dependency.version' for
> org.junit.jupiter:junit-jupiter-engine:jar is missing. @ line 485, column 17
> @
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project org.apache.maven:maven:4.0.0-alpha-3-SNAPSHOT
> (/home/cstamas/Worx/apache-maven/maven/pom.xml) has 1 error
> [ERROR] 'dependencies.dependency.version' for
> org.junit.jupiter:junit-jupiter-engine:jar is missing. @ line 485, column 17
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
> [cstamas@blondie maven (master)]$ {noformat}
> Maven 3.8.6 and 4.0.0-alpha-3-SNAPSHOT builds master just fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-indexer] cstamas commented on pull request #277: [MINDEXER-181] IndexDataReader should use Sets
cstamas commented on PR #277: URL: https://github.com/apache/maven-indexer/pull/277#issuecomment-1328696142 @mbien anything more you want to add or this PR is good to go? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7606) Maven 3.9.0-SNAPSHOT cannot build Maven 4.0.0-SNAPSHOT
[
https://issues.apache.org/jira/browse/MNG-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-7606:
-
Fix Version/s: 3.9.0
> Maven 3.9.0-SNAPSHOT cannot build Maven 4.0.0-SNAPSHOT
> --
>
> Key: MNG-7606
> URL: https://issues.apache.org/jira/browse/MNG-7606
> Project: Maven
> Issue Type: Bug
>Reporter: Tamas Cservenak
>Priority: Blocker
> Fix For: 3.9.0
>
>
> How to reproduce: build maven-3.9.x branch
> (e921f1564ef9460ca58745eb52e3967dbbd0b9e7) then checkout master branch
> (c6ecff9923088d854d4621e17d602f1c70dda806) and try to build it with built
> 3.9.0-SNAPSHOT: it fails.
> Error is:
> {noformat}
> [cstamas@blondie maven (master)]$ mvn -V clean install
> Apache Maven 3.9.0-SNAPSHOT (e921f1564ef9460ca58745eb52e3967dbbd0b9e7)
> Maven home: /home/cstamas/.sdkman/candidates/maven/3.9.0-SNAPSHOT
> Java version: 17.0.5, vendor: Eclipse Adoptium, runtime:
> /home/cstamas/.sdkman/candidates/java/17.0.5-tem
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "6.0.9-300.fc37.x86_64", arch: "amd64", family:
> "unix"
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [ERROR] 'dependencies.dependency.version' for
> org.junit.jupiter:junit-jupiter-engine:jar is missing. @ line 485, column 17
> @
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project org.apache.maven:maven:4.0.0-alpha-3-SNAPSHOT
> (/home/cstamas/Worx/apache-maven/maven/pom.xml) has 1 error
> [ERROR] 'dependencies.dependency.version' for
> org.junit.jupiter:junit-jupiter-engine:jar is missing. @ line 485, column 17
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
> [cstamas@blondie maven (master)]$ {noformat}
> Maven 3.8.6 and 4.0.0-alpha-3-SNAPSHOT builds master just fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Reopened] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reopened MNG-6609: -- Reverted breaking change on maven-3.9.x [https://github.com/apache/maven/commit/36ff9a65e637cc9054c0ed04814305a0493b701b] IT should be added: https://github.com/apache/maven/pull/849#issuecomment-1328673965 > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639855#comment-17639855 ] ASF GitHub Bot commented on MNG-6609: - cstamas commented on PR #849: URL: https://github.com/apache/maven/pull/849#issuecomment-1328688104 Reverted https://github.com/apache/maven/commit/36ff9a65e637cc9054c0ed04814305a0493b701b > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7606) Maven 3.9.0-SNAPSHOT cannot build Maven 4.0.0-SNAPSHOT
[
https://issues.apache.org/jira/browse/MNG-7606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639853#comment-17639853
]
Tamas Cservenak commented on MNG-7606:
--
Reverted maven-3.9.x change for now in
https://github.com/apache/maven/commit/36ff9a65e637cc9054c0ed04814305a0493b701b
> Maven 3.9.0-SNAPSHOT cannot build Maven 4.0.0-SNAPSHOT
> --
>
> Key: MNG-7606
> URL: https://issues.apache.org/jira/browse/MNG-7606
> Project: Maven
> Issue Type: Bug
>Reporter: Tamas Cservenak
>Priority: Blocker
>
> How to reproduce: build maven-3.9.x branch
> (e921f1564ef9460ca58745eb52e3967dbbd0b9e7) then checkout master branch
> (c6ecff9923088d854d4621e17d602f1c70dda806) and try to build it with built
> 3.9.0-SNAPSHOT: it fails.
> Error is:
> {noformat}
> [cstamas@blondie maven (master)]$ mvn -V clean install
> Apache Maven 3.9.0-SNAPSHOT (e921f1564ef9460ca58745eb52e3967dbbd0b9e7)
> Maven home: /home/cstamas/.sdkman/candidates/maven/3.9.0-SNAPSHOT
> Java version: 17.0.5, vendor: Eclipse Adoptium, runtime:
> /home/cstamas/.sdkman/candidates/java/17.0.5-tem
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "6.0.9-300.fc37.x86_64", arch: "amd64", family:
> "unix"
> [INFO] Scanning for projects...
> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> [ERROR] 'dependencies.dependency.version' for
> org.junit.jupiter:junit-jupiter-engine:jar is missing. @ line 485, column 17
> @
> [ERROR] The build could not read 1 project -> [Help 1]
> [ERROR]
> [ERROR] The project org.apache.maven:maven:4.0.0-alpha-3-SNAPSHOT
> (/home/cstamas/Worx/apache-maven/maven/pom.xml) has 1 error
> [ERROR] 'dependencies.dependency.version' for
> org.junit.jupiter:junit-jupiter-engine:jar is missing. @ line 485, column 17
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingException
> [cstamas@blondie maven (master)]$ {noformat}
> Maven 3.8.6 and 4.0.0-alpha-3-SNAPSHOT builds master just fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639856#comment-17639856 ] ASF GitHub Bot commented on MNG-6609: - marcphilipp commented on PR #849: URL: https://github.com/apache/maven/pull/849#issuecomment-1328688509 Thank you! > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] marcphilipp commented on pull request #849: [MNG-6609] Maven 3.9: profile activation by packaging
marcphilipp commented on PR #849: URL: https://github.com/apache/maven/pull/849#issuecomment-1328688509 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas commented on pull request #849: [MNG-6609] Maven 3.9: profile activation by packaging
cstamas commented on PR #849: URL: https://github.com/apache/maven/pull/849#issuecomment-1328688104 Reverted https://github.com/apache/maven/commit/36ff9a65e637cc9054c0ed04814305a0493b701b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17639852#comment-17639852 ] ASF GitHub Bot commented on MNG-6609: - marcphilipp commented on PR #849: URL: https://github.com/apache/maven/pull/849#issuecomment-1328681091 Sounds like a good idea! Would it be possible to revert the merge and reopen the original Jira issue? > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] marcphilipp commented on pull request #849: [MNG-6609] Maven 3.9: profile activation by packaging
marcphilipp commented on PR #849: URL: https://github.com/apache/maven/pull/849#issuecomment-1328681091 Sounds like a good idea! Would it be possible to revert the merge and reopen the original Jira issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
