[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642946#comment-17642946
]
ASF GitHub Bot commented on MNG-7619:
-
laeubi commented on PR #900:
URL: https://github.com/apache/maven/pull/900#issuecomment-1336328111
Not sure if this was already mentioned, but instead of "bake this in" would
it not be better to have a way for (core-)plugins to hook in a
`RepositoryListener` or even on the project level as we already to for
`AbstractMavenLifeCycleListeners` / `WorkspaceReaders`? The this can become
part of m-dependency-p for example.
I also wonder if it is even required to record the data at all, should it
not be sufficient to first load the pom(s), then generate a list of used
plugins and then resolve their dependencies and then do something similar to
`dependency:tree` (maybe plugin-dependency-tree)? To make it more convenient
then one might pass a `-DdependencyReverse=` to have a reverse output
rooted at the given GAV when build finished.
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] laeubi commented on pull request #900: [MNG-7619] Reverse Dependency Tree
laeubi commented on PR #900: URL: https://github.com/apache/maven/pull/900#issuecomment-1336328111 Not sure if this was already mentioned, but instead of "bake this in" would it not be better to have a way for (core-)plugins to hook in a `RepositoryListener` or even on the project level as we already to for `AbstractMavenLifeCycleListeners` / `WorkspaceReaders`? The this can become part of m-dependency-p for example. I also wonder if it is even required to record the data at all, should it not be sufficient to first load the pom(s), then generate a list of used plugins and then resolve their dependencies and then do something similar to `dependency:tree` (maybe plugin-dependency-tree)? To make it more convenient then one might pass a `-DdependencyReverse=` to have a reverse output rooted at the given GAV when build finished. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MSHADE-124) Need better plan for getting dependency-reduced-pom.xml out of basedir
[
https://issues.apache.org/jira/browse/MSHADE-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642859#comment-17642859
]
James Z.M. Gao edited comment on MSHADE-124 at 12/4/22 2:04 AM:
[~kriegaex] Here is a single pom test case, the change of the basedir fails the
assembly plugin.
{code:java}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
g
a
0
UTF-8
true
true
javax.inject
javax.inject
1
maven-jar-plugin
3.3.0
maven-shade-plugin
3.4.1
${project.build.directory}/dependency-reduced-pom.xml
${createDependencyReducedPom}
shade
package
maven-assembly-plugin
3.4.2
src
assembly
single
package
{code}
Place it in an empty folder, then the command `mvn package` should successfully
create target/a-0-src.tar.gz file containing this pom.xml. But the latest
version (3.4.1) of maven-shade-plugin fails the command with error:
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-assembly-plugin:3.4.2:single (assembly) on
project a: Failed to create assembly: Error creating assembly archive src:
archive cannot be empty -> [Help 1]
{noformat}
To work around, `mvn package -DcreateDependencyReducedPom=false` will generate
the expected archive file. In addition, the patch at
[https://github.com/apache/maven-shade-plugin/pull/128] can also pass this test.
was (Author: gzm55):
[~kriegaex] Here is a single pom test case, the change of the basedir fails the
assembly plugin.
{code:java}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
g
a
0
UTF-8
true
true
javax.inject
javax.inject
1
maven-jar-plugin
3.3.0
maven-shade-plugin
3.4.1
${project.build.directory}/dependency-reduced-pom.xml
${createDependencyReducedPom}
shade
package
maven-assembly-plugin
3.4.2
src
assembly
single
package
{code}
Run `mvn package` should successfully create target/a-0-src.tar.gz file
containing this pom.xml. But the latest version (3.4.1) of maven-shade-plugin
fails the command with error:
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-assembly-plugin:3.4.2:single (assembly) on
project a: Failed to create assembly: Error creating assembly archive src:
archive cannot be empty -> [Help 1]
{noformat}
To work around, `mvn package -DcreateDependencyReducedPom=false` will generate
the expected archive file. In addition,
[https://github.com/apache/maven-shade-plugin/pull/128] can also pass this test.
> Need better plan for getting dependency-reduced-pom.xml out of basedir
> --
>
> Key: MSHADE-124
> URL: https://issues.apache.org/jira/browse/MSHADE-124
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 1.7.1
>Reporter: Benson Margulies
>Priority: Major
>
> MSHADE-123 reported that putting the d-r-p into some location other
> than 'basedir' causes 'basedir' to follow it around, which can break builds.
> This is hard to fix, given the core maven definition of basedir as 'the dir
> containing the pom' with no option to change it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-84) Update documentation about shells
[
https://issues.apache.org/jira/browse/MWRAPPER-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642932#comment-17642932
]
Hudson commented on MWRAPPER-84:
Build unstable in Jenkins: Maven » Maven TLP » maven-wrapper » master #54
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-wrapper/job/master/54/
> Update documentation about shells
> -
>
> Key: MWRAPPER-84
> URL: https://issues.apache.org/jira/browse/MWRAPPER-84
> Project: Maven Wrapper
> Issue Type: Task
>Affects Versions: 3.1.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.0
>
>
> https://maven.apache.org/wrapper/ says:
> {noformat}
> For all those *nix operating systems, various shells should work including
> sh
> bash
> dash
> zsh
> {noformat}
> This section must be removed an replaced that the wrapper script required a
> POSIX-compatible Bourne shell.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MWRAPPER-84) Update documentation about shells
[
https://issues.apache.org/jira/browse/MWRAPPER-84?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed MWRAPPER-84.
--
Resolution: Fixed
Fixed with
[aaa1de7f2e4f233261de92923a1c0e1ae322a02b|https://gitbox.apache.org/repos/asf?p=maven-wrapper.git;a=commit;h=aaa1de7f2e4f233261de92923a1c0e1ae322a02b].
> Update documentation about shells
> -
>
> Key: MWRAPPER-84
> URL: https://issues.apache.org/jira/browse/MWRAPPER-84
> Project: Maven Wrapper
> Issue Type: Task
>Affects Versions: 3.1.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.0
>
>
> https://maven.apache.org/wrapper/ says:
> {noformat}
> For all those *nix operating systems, various shells should work including
> sh
> bash
> dash
> zsh
> {noformat}
> This section must be removed an replaced that the wrapper script required a
> POSIX-compatible Bourne shell.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MWRAPPER-84) Update documentation about shells
[
https://issues.apache.org/jira/browse/MWRAPPER-84?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642930#comment-17642930
]
ASF GitHub Bot commented on MWRAPPER-84:
asfgit closed pull request #70: [MWRAPPER-84] Update documentation about shells
URL: https://github.com/apache/maven-wrapper/pull/70
> Update documentation about shells
> -
>
> Key: MWRAPPER-84
> URL: https://issues.apache.org/jira/browse/MWRAPPER-84
> Project: Maven Wrapper
> Issue Type: Task
>Affects Versions: 3.1.1
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.0
>
>
> https://maven.apache.org/wrapper/ says:
> {noformat}
> For all those *nix operating systems, various shells should work including
> sh
> bash
> dash
> zsh
> {noformat}
> This section must be removed an replaced that the wrapper script required a
> POSIX-compatible Bourne shell.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-wrapper] asfgit closed pull request #70: [MWRAPPER-84] Update documentation about shells
asfgit closed pull request #70: [MWRAPPER-84] Update documentation about shells URL: https://github.com/apache/maven-wrapper/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-679) Introduce Sink#tableRows(void) method
[
https://issues.apache.org/jira/browse/DOXIA-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642927#comment-17642927
]
ASF GitHub Bot commented on DOXIA-679:
--
michael-o opened a new pull request, #127:
URL: https://github.com/apache/maven-doxia/pull/127
This closes #127
> Introduce Sink#tableRows(void) method
> -
>
> Key: DOXIA-679
> URL: https://issues.apache.org/jira/browse/DOXIA-679
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Sink API
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M5
>
>
> For the sake of convenience it is often sufficient to short cut
> {{sink.tableRows(null, false)}} to just {{sink.tableRows()}}. A a new
> interface method and have sink implementations handle it accordingly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-doxia] michael-o opened a new pull request, #127: [DOXIA-679] Introduce Sink#tableRows(void) method
michael-o opened a new pull request, #127: URL: https://github.com/apache/maven-doxia/pull/127 This closes #127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DOXIA-679) Introduce Sink#tableRows(void) method
Michael Osipov created DOXIA-679:
Summary: Introduce Sink#tableRows(void) method
Key: DOXIA-679
URL: https://issues.apache.org/jira/browse/DOXIA-679
Project: Maven Doxia
Issue Type: Improvement
Components: Sink API
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: 2.0.0-M5
For the sake of convenience it is often sufficient to short cut
{{sink.tableRows(null, false)}} to just {{sink.tableRows()}}. A a new interface
method and have sink implementations handle it accordingly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MDEP-840) Unused declared dependencies found but dependency is used?
[
https://issues.apache.org/jira/browse/MDEP-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642925#comment-17642925
]
Joe Barnett edited comment on MDEP-840 at 12/3/22 10:33 PM:
yes it also happens with the {{analyze}} goal.
was (Author: jbarnett):
yes it also happens with the {{analyze}} goal. will try to create a minimal
reproducer this coming week.
> Unused declared dependencies found but dependency is used?
> ---
>
> Key: MDEP-840
> URL: https://issues.apache.org/jira/browse/MDEP-840
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: analyze-only
>Affects Versions: 3.4.0
>Reporter: Joe Barnett
>Priority: Major
>
> We have a class here:
> [https://github.com/trib3/leakycauldron/blob/main/testing/src/main/kotlin/com/trib3/testing/server/ResourceTestBase.kt]
>
> that imports io.dropwizard.auth.AuthValueFactoryProvider from
> io.dropwizard:dropwizard-auth, and the pom declares that dependency directly.
>
> Starting with maven-dependency-plugin 3.4.0, we now get this error when
> running the analyze-only goal:
> {code:java}
> [ERROR] Unused declared dependencies found:
> [ERROR] io.dropwizard:dropwizard-auth:jar:2.1.4:compile{code}
>
> removing the declared dependency results in the code failing to compile since
> dropwizard-auth is no longer on the classpath. This worked in 3.3.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-840) Unused declared dependencies found but dependency is used?
[
https://issues.apache.org/jira/browse/MDEP-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642926#comment-17642926
]
Joe Barnett commented on MDEP-840:
--
minimal kotlin example here: https://github.com/josephlbarnett/mdep840
> Unused declared dependencies found but dependency is used?
> ---
>
> Key: MDEP-840
> URL: https://issues.apache.org/jira/browse/MDEP-840
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: analyze-only
>Affects Versions: 3.4.0
>Reporter: Joe Barnett
>Priority: Major
>
> We have a class here:
> [https://github.com/trib3/leakycauldron/blob/main/testing/src/main/kotlin/com/trib3/testing/server/ResourceTestBase.kt]
>
> that imports io.dropwizard.auth.AuthValueFactoryProvider from
> io.dropwizard:dropwizard-auth, and the pom declares that dependency directly.
>
> Starting with maven-dependency-plugin 3.4.0, we now get this error when
> running the analyze-only goal:
> {code:java}
> [ERROR] Unused declared dependencies found:
> [ERROR] io.dropwizard:dropwizard-auth:jar:2.1.4:compile{code}
>
> removing the declared dependency results in the code failing to compile since
> dropwizard-auth is no longer on the classpath. This worked in 3.3.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-840) Unused declared dependencies found but dependency is used?
[
https://issues.apache.org/jira/browse/MDEP-840?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642925#comment-17642925
]
Joe Barnett commented on MDEP-840:
--
yes it also happens with the {{analyze}} goal. will try to create a minimal
reproducer this coming week.
> Unused declared dependencies found but dependency is used?
> ---
>
> Key: MDEP-840
> URL: https://issues.apache.org/jira/browse/MDEP-840
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: analyze-only
>Affects Versions: 3.4.0
>Reporter: Joe Barnett
>Priority: Major
>
> We have a class here:
> [https://github.com/trib3/leakycauldron/blob/main/testing/src/main/kotlin/com/trib3/testing/server/ResourceTestBase.kt]
>
> that imports io.dropwizard.auth.AuthValueFactoryProvider from
> io.dropwizard:dropwizard-auth, and the pom declares that dependency directly.
>
> Starting with maven-dependency-plugin 3.4.0, we now get this error when
> running the analyze-only goal:
> {code:java}
> [ERROR] Unused declared dependencies found:
> [ERROR] io.dropwizard:dropwizard-auth:jar:2.1.4:compile{code}
>
> removing the declared dependency results in the code failing to compile since
> dropwizard-auth is no longer on the classpath. This worked in 3.3.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642924#comment-17642924
]
ASF GitHub Bot commented on MNG-7619:
-
michael-o commented on PR #900:
URL: https://github.com/apache/maven/pull/900#issuecomment-1336266571
> Thats org.eclipse.aether.graph.Dependency#toString, we could fix it, but
given this is "advanced" feature, I don't think is something would block this?
Agree, we need to spin off the issue there. Here, no change is required.
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #900: [MNG-7619] Reverse Dependency Tree
michael-o commented on PR #900: URL: https://github.com/apache/maven/pull/900#issuecomment-1336266571 > Thats org.eclipse.aether.graph.Dependency#toString, we could fix it, but given this is "advanced" feature, I don't think is something would block this? Agree, we need to spin off the issue there. Here, no change is required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642923#comment-17642923
]
ASF GitHub Bot commented on MNG-7619:
-
cstamas commented on PR #900:
URL: https://github.com/apache/maven/pull/900#issuecomment-1336266075
Thats org.eclipse.aether.graph.Dependency#toString, we could fix it, but
given this is "advanced" feature, I don't think is something would block this?
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #900: [MNG-7619] Reverse Dependency Tree
cstamas commented on PR #900: URL: https://github.com/apache/maven/pull/900#issuecomment-1336266075 Thats org.eclipse.aether.graph.Dependency#toString, we could fix it, but given this is "advanced" feature, I don't think is something would block this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642922#comment-17642922
]
ASF GitHub Bot commented on MNG-7619:
-
michael-o commented on PR #900:
URL: https://github.com/apache/maven/pull/900#issuecomment-1336265250
Can we leave out these empty parens:
`org.apache.maven.plugins:maven-dependency-plugin:jar:3.3.0 () (plugin)`? From
a user PoV it looks like a bug.
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] michael-o commented on pull request #900: [MNG-7619] Reverse Dependency Tree
michael-o commented on PR #900: URL: https://github.com/apache/maven/pull/900#issuecomment-1336265250 Can we leave out these empty parens: `org.apache.maven.plugins:maven-dependency-plugin:jar:3.3.0 () (plugin)`? From a user PoV it looks like a bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642919#comment-17642919
]
ASF GitHub Bot commented on MNG-7619:
-
cstamas commented on PR #900:
URL: https://github.com/apache/maven/pull/900#issuecomment-133626
Note: this is based on by @grgrzybek proposal and reuses some code he
provided. See https://github.com/apache/maven-resolver/pull/182
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #900: [MNG-7619] Reverse Dependency Tree
cstamas commented on PR #900: URL: https://github.com/apache/maven/pull/900#issuecomment-133626 Note: this is based on by @grgrzybek proposal and reuses some code he provided. See https://github.com/apache/maven-resolver/pull/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642917#comment-17642917
]
ASF GitHub Bot commented on MNG-7619:
-
michael-o commented on code in PR #900:
URL: https://github.com/apache/maven/pull/900#discussion_r1038874052
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.aether;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ListIterator;
+import java.util.Objects;
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+/**
+ * A class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ *
+ * @since 3.9.0
+ */
+class ReverseTreeRepositoryListener extends AbstractRepositoryListener {
+private static final String EOL = System.lineSeparator();
Review Comment:
LS, not EOL
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.aether;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ListIterator;
+import java.util.Objects;
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+/**
+ * A class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ *
+ * @since 3.9.0
+ */
+class ReverseTreeRepositoryListener extends AbstractRepositoryListener {
+private static final String EOL = System.lineSeparator();
+
+@Override
+public void artifactResolved(RepositoryEvent event) {
+requireNonNull(event, "event cannot be null");
+
+if (!event.getArtifact()
+.getFile()
+.getPath()
+
.startsWith(event.getSession().getLocalRepository().getBasedir().getPath())) {
+return; // reactor artifact
+}
+RequestTrace trace = event.getTrace();
+CollectStepData collectStepTrace = null;
+while (trace != null) {
+if (trace.getData() instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) trace.getData();
+break;
+}
+trace = trace.getParent();
+}
+
+if
[GitHub] [maven] michael-o commented on a diff in pull request #900: [MNG-7619] Reverse Dependency Tree
michael-o commented on code in PR #900:
URL: https://github.com/apache/maven/pull/900#discussion_r1038874052
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.aether;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ListIterator;
+import java.util.Objects;
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+/**
+ * A class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ *
+ * @since 3.9.0
+ */
+class ReverseTreeRepositoryListener extends AbstractRepositoryListener {
+private static final String EOL = System.lineSeparator();
Review Comment:
LS, not EOL
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.aether;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ListIterator;
+import java.util.Objects;
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+/**
+ * A class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ *
+ * @since 3.9.0
+ */
+class ReverseTreeRepositoryListener extends AbstractRepositoryListener {
+private static final String EOL = System.lineSeparator();
+
+@Override
+public void artifactResolved(RepositoryEvent event) {
+requireNonNull(event, "event cannot be null");
+
+if (!event.getArtifact()
+.getFile()
+.getPath()
+
.startsWith(event.getSession().getLocalRepository().getBasedir().getPath())) {
+return; // reactor artifact
+}
+RequestTrace trace = event.getTrace();
+CollectStepData collectStepTrace = null;
+while (trace != null) {
+if (trace.getData() instanceof CollectStepData) {
+collectStepTrace = (CollectStepData) trace.getData();
+break;
+}
+trace = trace.getParent();
+}
+
+if (collectStepTrace == null) {
+return;
+}
+
+Artifact resolvedArtifact = event.getArtifact();
+Artifact nodeArtifact = collectStepTrace.getNode().getArtifact();
+
+if (isInScope(resolvedArtifact,
[jira] [Updated] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak updated MNG-7619:
-
Description:
Ability to make Maven record:
* why given artifact is present in local repository
* record reverse dep tree how this artifact got resolved
This is mostly for detecting dependency resolution anomalies, ideally best
combined with {{-Dmaven.repo.local}} when you use new/empty local repo to build
a project. After the build, you will end up with reverse dep trees in
{{.tracking}} directories for each artifact.
To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[ https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642914#comment-17642914 ] ASF GitHub Bot commented on MNG-7619: - cstamas commented on PR #900: URL: https://github.com/apache/maven/pull/900#issuecomment-1336258963 Excercise: build this PR (will produce Maven 3.9.0-SNAPSHOT distro), then use same distro to build itself (or just maven.3.9.x, does not matter) using these: ``` mvn clean install -Dmaven.repo.local=local -Dmaven.repo.local.recordReverseTree -Drat.skip ``` (rat is dumb to inspect "local" where local repository is and fail, so we skip it). Q1: why is maven-core 2.2.1 in local repo? ``` [cstamas@infinity maven (maven-3.9.x +%)]$ tree -L 1 local/org/apache/maven/maven-core/2.2.1/.tracking/ local/org/apache/maven/maven-core/2.2.1/.tracking/ ├── org.apache.maven.plugins_maven-remote-resources-plugin_jar_1.7.0 ├── org.codehaus.mojo_build-helper-maven-plugin_jar_1.12 └── org.codehaus.mojo_buildnumber-maven-plugin_jar_1.4 0 directories, 3 files [cstamas@infinity maven (maven-3.9.x +%)]$ cat local/org/apache/maven/maven-core/2.2.1/.tracking/org.codehaus.mojo_build-helper-maven-plugin_jar_1.12 org.apache.maven:maven-core:jar:2.2.1 (compile) (plugin) org.codehaus.mojo:build-helper-maven-plugin:jar:1.12 () (plugin) [cstamas@infinity maven (maven-3.9.x +%)]$ ``` > Maven should explain why an artifact is present in local repository > --- > > Key: MNG-7619 > URL: https://issues.apache.org/jira/browse/MNG-7619 > Project: Maven > Issue Type: Improvement > Components: Dependencies >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #900: [MNG-7619] Reverse Dependency Tree
cstamas commented on PR #900: URL: https://github.com/apache/maven/pull/900#issuecomment-1336258963 Excercise: build this PR (will produce Maven 3.9.0-SNAPSHOT distro), then use same distro to build itself (or just maven.3.9.x, does not matter) using these: ``` mvn clean install -Dmaven.repo.local=local -Dmaven.repo.local.recordReverseTree -Drat.skip ``` (rat is dumb to inspect "local" where local repository is and fail, so we skip it). Q1: why is maven-core 2.2.1 in local repo? ``` [cstamas@infinity maven (maven-3.9.x +%)]$ tree -L 1 local/org/apache/maven/maven-core/2.2.1/.tracking/ local/org/apache/maven/maven-core/2.2.1/.tracking/ ├── org.apache.maven.plugins_maven-remote-resources-plugin_jar_1.7.0 ├── org.codehaus.mojo_build-helper-maven-plugin_jar_1.12 └── org.codehaus.mojo_buildnumber-maven-plugin_jar_1.4 0 directories, 3 files [cstamas@infinity maven (maven-3.9.x +%)]$ cat local/org/apache/maven/maven-core/2.2.1/.tracking/org.codehaus.mojo_build-helper-maven-plugin_jar_1.12 org.apache.maven:maven-core:jar:2.2.1 (compile) (plugin) org.codehaus.mojo:build-helper-maven-plugin:jar:1.12 () (plugin) [cstamas@infinity maven (maven-3.9.x +%)]$ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[ https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642913#comment-17642913 ] ASF GitHub Bot commented on MNG-7619: - cstamas opened a new pull request, #900: URL: https://github.com/apache/maven/pull/900 Adds Maven feature that is able to explain why an artifact is present in local repository. Usable for diagnosing resolution issues. --- https://issues.apache.org/jira/browse/MNG-7619 > Maven should explain why an artifact is present in local repository > --- > > Key: MNG-7619 > URL: https://issues.apache.org/jira/browse/MNG-7619 > Project: Maven > Issue Type: Improvement > Components: Dependencies >Reporter: Tamas Cservenak >Priority: Major > Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas opened a new pull request, #900: [MNG-7619] Reverse Dependency Tree
cstamas opened a new pull request, #900: URL: https://github.com/apache/maven/pull/900 Adds Maven feature that is able to explain why an artifact is present in local repository. Usable for diagnosing resolution issues. --- https://issues.apache.org/jira/browse/MNG-7619 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7619) Maven should explain why an artifact is present in local repository
Tamas Cservenak created MNG-7619: Summary: Maven should explain why an artifact is present in local repository Key: MNG-7619 URL: https://issues.apache.org/jira/browse/MNG-7619 Project: Maven Issue Type: Improvement Components: Dependencies Reporter: Tamas Cservenak Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-shared-utils] michael-o commented on a diff in pull request #123: [MSHARED-1172] Deprecate redundant isEmptyString method
michael-o commented on code in PR #123: URL: https://github.com/apache/maven-shared-utils/pull/123#discussion_r1038865260 ## src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomUtils.java: ## @@ -148,15 +148,15 @@ private static boolean isMergeChildren( Xpp3Dom dominant ) } /** - * @param str The string to be checked. - * @return true in case string is empty false otherwise. + * @deprecated use String.isBlank() (Java 11+) Review Comment: `String#isBlank()` is *not* a replacement because it will cause a NPE if null. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSHARED-1172) Deprecate Xpp3DomUtils.isEmptyString
Elliotte Rusty Harold created MSHARED-1172: -- Summary: Deprecate Xpp3DomUtils.isEmptyString Key: MSHARED-1172 URL: https://issues.apache.org/jira/browse/MSHARED-1172 Project: Maven Shared Components Issue Type: Improvement Reporter: Elliotte Rusty Harold This isn't a DOM utility. It's a string utility and it's already available in 18 other utility libraries including the JDK. Probably not even used and was just public by default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MSHARED-1172) Deprecate Xpp3DomUtils.isEmptyString
[ https://issues.apache.org/jira/browse/MSHARED-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MSHARED-1172: -- Assignee: Elliotte Rusty Harold > Deprecate Xpp3DomUtils.isEmptyString > > > Key: MSHARED-1172 > URL: https://issues.apache.org/jira/browse/MSHARED-1172 > Project: Maven Shared Components > Issue Type: Improvement >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > > This isn't a DOM utility. It's a string utility and it's already available in > 18 other utility libraries including the JDK. Probably not even used and was > just public by default. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPIR-425) License from text resource should be included as plain text
[ https://issues.apache.org/jira/browse/MPIR-425?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642909#comment-17642909 ] Michael Osipov commented on MPIR-425: - Man, you have to love https://github.com/busyloop/lolcat. > License from text resource should be included as plain text > --- > > Key: MPIR-425 > URL: https://issues.apache.org/jira/browse/MPIR-425 > Project: Maven Project Info Reports Plugin > Issue Type: Improvement > Components: licenses >Reporter: Slawomir Jaranowski >Priority: Major > Attachments: Screenshot 2022-12-03 at 10.24.48.png, Screenshot > 2022-12-03 at 10.25.17.png > > > When license is imported from text files additional parsing is not needed. > Now we have a colorized some of items. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (MSHARED-1169) Deprecate join methods now available in Java 8 String class
[ https://issues.apache.org/jira/browse/MSHARED-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MSHARED-1169. Resolution: Fixed > Deprecate join methods now available in Java 8 String class > --- > > Key: MSHARED-1169 > URL: https://issues.apache.org/jira/browse/MSHARED-1169 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHARED-1169) Deprecate join methods now available in Java 8 String class
[ https://issues.apache.org/jira/browse/MSHARED-1169?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MSHARED-1169. -- > Deprecate join methods now available in Java 8 String class > --- > > Key: MSHARED-1169 > URL: https://issues.apache.org/jira/browse/MSHARED-1169 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-shared-utils >Reporter: Elliotte Rusty Harold >Assignee: Elliotte Rusty Harold >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-shared-utils] elharo merged pull request #120: Bump plexus-utils from 3.4.2 to 3.5.0
elharo merged PR #120: URL: https://github.com/apache/maven-shared-utils/pull/120 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] elharo merged pull request #119: Bump commons-text from 1.3 to 1.10.0
elharo merged PR #119: URL: https://github.com/apache/maven-shared-utils/pull/119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] elharo merged pull request #127: [MSHARED-1169] deprecate join methods now available in Java 8 String class
elharo merged PR #127: URL: https://github.com/apache/maven-shared-utils/pull/127 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-831) Remove not used dependencies / Replace parts
[
https://issues.apache.org/jira/browse/MDEP-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642908#comment-17642908
]
Hudson commented on MDEP-831:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-dependency-plugin »
master #71
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-dependency-plugin/job/master/71/
> Remove not used dependencies / Replace parts
>
>
> Key: MDEP-831
> URL: https://issues.apache.org/jira/browse/MDEP-831
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Karl Heinz Marbaise
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Fix For: version-next
>
>
> Currently the dependency is not used at all:
> {code:xml}
>
> commons-beanutils
> commons-beanutils
> 1.9.4
>
> {code}
> The dependency is only used for a single method:
> {code:xml}
>
> org.apache.commons
> commons-collections4
> 4.2
>
> {code}
> The dependency is only used for two methods of StringUtils.
> {code:xml}
>
> org.apache.commons
> commons-lang3
> 3.12.0
>
> {code}
> The dependency is only used in tests for deleting a directory.
> {code:xml}
>
> commons-io
> commons-io
> 2.11.0
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SUREFIRE-2130) Rewrite several test classes in report plugin for upcoming Doxia 2.0.0 stack
Michael Osipov created SUREFIRE-2130:
Summary: Rewrite several test classes in report plugin for
upcoming Doxia 2.0.0 stack
Key: SUREFIRE-2130
URL: https://issues.apache.org/jira/browse/SUREFIRE-2130
Project: Maven Surefire
Issue Type: Task
Components: Maven Surefire Report Plugin
Affects Versions: 3.0.0-M7
Reporter: Michael Osipov
{{Surefire1183Test}}, {{Surefire597Test}}, {{SurefireReportMojoTest}} use too
much low level classes like concrete sinks, {{DecorationModel}},
{{SiteRenderingContext}}. Some of these will change or be removed in Doxia
2.0.0. Approaches like in MPIR, with a plugin specific abstract test class is
required to do all the hefty, and high level lifting without using Doxia
innards. If this isn't done already with Doxia 1.x these tests will not even
compile with Doxia 2.0.0 and need to be commented out/removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MDEP-831) Remove not used dependencies / Replace parts
[
https://issues.apache.org/jira/browse/MDEP-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold closed MDEP-831.
--
> Remove not used dependencies / Replace parts
>
>
> Key: MDEP-831
> URL: https://issues.apache.org/jira/browse/MDEP-831
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Karl Heinz Marbaise
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Fix For: version-next
>
>
> Currently the dependency is not used at all:
> {code:xml}
>
> commons-beanutils
> commons-beanutils
> 1.9.4
>
> {code}
> The dependency is only used for a single method:
> {code:xml}
>
> org.apache.commons
> commons-collections4
> 4.2
>
> {code}
> The dependency is only used for two methods of StringUtils.
> {code:xml}
>
> org.apache.commons
> commons-lang3
> 3.12.0
>
> {code}
> The dependency is only used in tests for deleting a directory.
> {code:xml}
>
> commons-io
> commons-io
> 2.11.0
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MDEP-831) Remove not used dependencies / Replace parts
[
https://issues.apache.org/jira/browse/MDEP-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold resolved MDEP-831.
Resolution: Fixed
> Remove not used dependencies / Replace parts
>
>
> Key: MDEP-831
> URL: https://issues.apache.org/jira/browse/MDEP-831
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Karl Heinz Marbaise
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Fix For: version-next
>
>
> Currently the dependency is not used at all:
> {code:xml}
>
> commons-beanutils
> commons-beanutils
> 1.9.4
>
> {code}
> The dependency is only used for a single method:
> {code:xml}
>
> org.apache.commons
> commons-collections4
> 4.2
>
> {code}
> The dependency is only used for two methods of StringUtils.
> {code:xml}
>
> org.apache.commons
> commons-lang3
> 3.12.0
>
> {code}
> The dependency is only used in tests for deleting a directory.
> {code:xml}
>
> commons-io
> commons-io
> 2.11.0
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MDEP-831) Remove not used dependencies / Replace parts
[
https://issues.apache.org/jira/browse/MDEP-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642907#comment-17642907
]
Elliotte Rusty Harold commented on MDEP-831:
commons-lang3 is now removed, as is beanutils so I'm going to close this.
commons-collections still needs to go but there's a separate bug for that.
> Remove not used dependencies / Replace parts
>
>
> Key: MDEP-831
> URL: https://issues.apache.org/jira/browse/MDEP-831
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Karl Heinz Marbaise
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Fix For: version-next
>
>
> Currently the dependency is not used at all:
> {code:xml}
>
> commons-beanutils
> commons-beanutils
> 1.9.4
>
> {code}
> The dependency is only used for a single method:
> {code:xml}
>
> org.apache.commons
> commons-collections4
> 4.2
>
> {code}
> The dependency is only used for two methods of StringUtils.
> {code:xml}
>
> org.apache.commons
> commons-lang3
> 3.12.0
>
> {code}
> The dependency is only used in tests for deleting a directory.
> {code:xml}
>
> commons-io
> commons-io
> 2.11.0
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MDEP-831) Remove not used dependencies / Replace parts
[
https://issues.apache.org/jira/browse/MDEP-831?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated MDEP-831:
---
Priority: Minor (was: Major)
> Remove not used dependencies / Replace parts
>
>
> Key: MDEP-831
> URL: https://issues.apache.org/jira/browse/MDEP-831
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Karl Heinz Marbaise
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Fix For: version-next
>
>
> Currently the dependency is not used at all:
> {code:xml}
>
> commons-beanutils
> commons-beanutils
> 1.9.4
>
> {code}
> The dependency is only used for a single method:
> {code:xml}
>
> org.apache.commons
> commons-collections4
> 4.2
>
> {code}
> The dependency is only used for two methods of StringUtils.
> {code:xml}
>
> org.apache.commons
> commons-lang3
> 3.12.0
>
> {code}
> The dependency is only used in tests for deleting a directory.
> {code:xml}
>
> commons-io
> commons-io
> 2.11.0
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MNG-7559) ComparableVersion vs versions with custom qualifiers
[
https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold resolved MNG-7559.
Fix Version/s: 3.9.0
Resolution: Fixed
> ComparableVersion vs versions with custom qualifiers
>
>
> Key: MNG-7559
> URL: https://issues.apache.org/jira/browse/MNG-7559
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.8.3
>Reporter: Andrzej Jarmoniuk
>Priority: Major
> Fix For: 3.9.0
>
> Attachments: image-2022-10-22-18-22-11-591.png
>
>
> Since I know that ComparableVersion was brought to Maven from
> versions-maven-plugin, it turns out the bug described here:
> https://github.com/mojohaus/versions-maven-plugin/issues/744
> also exists in maven, at least in 3.8.3.
> According to the maven version spec, versions containing a qualifier should
> be treated as less major than the same versions without the qualifier.
> Currently it's only the case for a few "standard" qualifiers, e.g. "-rc*",
> "-alpha", etc.
> However, it looks like "2.3-pfd" is deemed less major than "2.3".
> {code:java}
> @Test
> public void testComparableVersionWithCustomQualifier()
> {
> assertThat( new ComparableVersion( "2.3" ).compareTo( new
> ComparableVersion( "2.3-pfd" ) ),
> greaterThan( 0 ) );
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7559) ComparableVersion vs versions with custom qualifiers
[
https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold closed MNG-7559.
--
> ComparableVersion vs versions with custom qualifiers
>
>
> Key: MNG-7559
> URL: https://issues.apache.org/jira/browse/MNG-7559
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.8.3
>Reporter: Andrzej Jarmoniuk
>Priority: Major
> Fix For: 3.9.0
>
> Attachments: image-2022-10-22-18-22-11-591.png
>
>
> Since I know that ComparableVersion was brought to Maven from
> versions-maven-plugin, it turns out the bug described here:
> https://github.com/mojohaus/versions-maven-plugin/issues/744
> also exists in maven, at least in 3.8.3.
> According to the maven version spec, versions containing a qualifier should
> be treated as less major than the same versions without the qualifier.
> Currently it's only the case for a few "standard" qualifiers, e.g. "-rc*",
> "-alpha", etc.
> However, it looks like "2.3-pfd" is deemed less major than "2.3".
> {code:java}
> @Test
> public void testComparableVersionWithCustomQualifier()
> {
> assertThat( new ComparableVersion( "2.3" ).compareTo( new
> ComparableVersion( "2.3-pfd" ) ),
> greaterThan( 0 ) );
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7559) ComparableVersion vs versions with custom qualifiers
[
https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642905#comment-17642905
]
ASF GitHub Bot commented on MNG-7559:
-
elharo commented on PR #845:
URL: https://github.com/apache/maven/pull/845#issuecomment-1336244089
Jenkins passed my fork of this so I'm going to merge.
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7559/
> ComparableVersion vs versions with custom qualifiers
>
>
> Key: MNG-7559
> URL: https://issues.apache.org/jira/browse/MNG-7559
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.8.3
>Reporter: Andrzej Jarmoniuk
>Priority: Major
> Attachments: image-2022-10-22-18-22-11-591.png
>
>
> Since I know that ComparableVersion was brought to Maven from
> versions-maven-plugin, it turns out the bug described here:
> https://github.com/mojohaus/versions-maven-plugin/issues/744
> also exists in maven, at least in 3.8.3.
> According to the maven version spec, versions containing a qualifier should
> be treated as less major than the same versions without the qualifier.
> Currently it's only the case for a few "standard" qualifiers, e.g. "-rc*",
> "-alpha", etc.
> However, it looks like "2.3-pfd" is deemed less major than "2.3".
> {code:java}
> @Test
> public void testComparableVersionWithCustomQualifier()
> {
> assertThat( new ComparableVersion( "2.3" ).compareTo( new
> ComparableVersion( "2.3-pfd" ) ),
> greaterThan( 0 ) );
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7559) ComparableVersion vs versions with custom qualifiers
[
https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642906#comment-17642906
]
ASF GitHub Bot commented on MNG-7559:
-
elharo merged PR #845:
URL: https://github.com/apache/maven/pull/845
> ComparableVersion vs versions with custom qualifiers
>
>
> Key: MNG-7559
> URL: https://issues.apache.org/jira/browse/MNG-7559
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.8.3
>Reporter: Andrzej Jarmoniuk
>Priority: Major
> Attachments: image-2022-10-22-18-22-11-591.png
>
>
> Since I know that ComparableVersion was brought to Maven from
> versions-maven-plugin, it turns out the bug described here:
> https://github.com/mojohaus/versions-maven-plugin/issues/744
> also exists in maven, at least in 3.8.3.
> According to the maven version spec, versions containing a qualifier should
> be treated as less major than the same versions without the qualifier.
> Currently it's only the case for a few "standard" qualifiers, e.g. "-rc*",
> "-alpha", etc.
> However, it looks like "2.3-pfd" is deemed less major than "2.3".
> {code:java}
> @Test
> public void testComparableVersionWithCustomQualifier()
> {
> assertThat( new ComparableVersion( "2.3" ).compareTo( new
> ComparableVersion( "2.3-pfd" ) ),
> greaterThan( 0 ) );
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] elharo closed pull request #899: fix version comparison
elharo closed pull request #899: fix version comparison URL: https://github.com/apache/maven/pull/899 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] elharo merged pull request #845: [MNG-7559] Fix versions comparison
elharo merged PR #845: URL: https://github.com/apache/maven/pull/845 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] elharo commented on pull request #845: [MNG-7559] Fix versions comparison
elharo commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1336244089 Jenkins passed my fork of this so I'm going to merge. https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7559/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-447) Update to Maven Parent POM 38
[ https://issues.apache.org/jira/browse/MPLUGIN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642904#comment-17642904 ] ASF GitHub Bot commented on MPLUGIN-447: kwin commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336243709 > @kwin look for duplicate License headers > > can help: > > ``` > git grep -c "Licensed to the Apache Software Foundation" | grep -v ":1" > ``` Thanks for the hint. Is there a configuration in spotless to remove those duplicates or do you have a script for that available as well? Seems that almost all files have duplicate license headers after the automated formatting… > Update to Maven Parent POM 38 > - > > Key: MPLUGIN-447 > URL: https://issues.apache.org/jira/browse/MPLUGIN-447 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.8.0 > > > This also reformats source code, for details see MPOM-349 and > https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-dependency-plugin] elharo merged pull request #270: [MDEP-831] Remove dependency on commons-lang3
elharo merged PR #270: URL: https://github.com/apache/maven-dependency-plugin/pull/270 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] kwin commented on pull request #181: [MPLUGIN-447] Update to Maven Parent POM 38
kwin commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336243709 > @kwin look for duplicate License headers > > can help: > > ``` > git grep -c "Licensed to the Apache Software Foundation" | grep -v ":1" > ``` Thanks for the hint. Is there a configuration in spotless to remove those duplicates or do you have a script for that available as well? Seems that almost all files have duplicate license headers after the automated formatting… -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-447) Update to Maven Parent POM 38
[ https://issues.apache.org/jira/browse/MPLUGIN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642903#comment-17642903 ] ASF GitHub Bot commented on MPLUGIN-447: slawekjaranowski commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336224816 @kwin look for duplicate License headers can help: ``` git grep -c "Licensed to the Apache Software Foundation" | grep -v ":1" ``` > Update to Maven Parent POM 38 > - > > Key: MPLUGIN-447 > URL: https://issues.apache.org/jira/browse/MPLUGIN-447 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.8.0 > > > This also reformats source code, for details see MPOM-349 and > https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #181: [MPLUGIN-447] Update to Maven Parent POM 38
slawekjaranowski commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336224816 @kwin look for duplicate License headers can help: ``` git grep -c "Licensed to the Apache Software Foundation" | grep -v ":1" ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-447) Update to Maven Parent POM 38
[ https://issues.apache.org/jira/browse/MPLUGIN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642900#comment-17642900 ] ASF GitHub Bot commented on MPLUGIN-447: kwin commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336222545 > Why does upgrading the parent POM reformat pretty much every file? That seems like a very different thing. That is because the code format conventions have changed. There was a mailing list discussion around that. > Update to Maven Parent POM 38 > - > > Key: MPLUGIN-447 > URL: https://issues.apache.org/jira/browse/MPLUGIN-447 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.8.0 > > > This also reformats source code, for details see MPOM-349 and > https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-plugin-tools] kwin commented on pull request #181: [MPLUGIN-447] Update to Maven Parent POM 38
kwin commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336222545 > Why does upgrading the parent POM reformat pretty much every file? That seems like a very different thing. That is because the code format conventions have changed. There was a mailing list discussion around that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #194: [MENFORCER-438] Upgrade maven-plugin parent to 38 - cleanup
slawekjaranowski opened a new pull request, #194: URL: https://github.com/apache/maven-enforcer/pull/194 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MENFORCER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [x] Format the pull request title like `[MENFORCER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MENFORCER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [x] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] elharo opened a new pull request, #899: fix version comparison
elharo opened a new pull request, #899: URL: https://github.com/apache/maven/pull/899 Forking https://github.com/apache/maven/pull/845 so Jenkins will pick it up -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7559) ComparableVersion vs versions with custom qualifiers
[
https://issues.apache.org/jira/browse/MNG-7559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642885#comment-17642885
]
ASF GitHub Bot commented on MNG-7559:
-
elharo commented on PR #845:
URL: https://github.com/apache/maven/pull/845#issuecomment-1336213615
All looks good. I need to copy the PR into my account to run it through
Jenkins
> ComparableVersion vs versions with custom qualifiers
>
>
> Key: MNG-7559
> URL: https://issues.apache.org/jira/browse/MNG-7559
> Project: Maven
> Issue Type: Bug
>Affects Versions: 3.8.3
>Reporter: Andrzej Jarmoniuk
>Priority: Major
> Attachments: image-2022-10-22-18-22-11-591.png
>
>
> Since I know that ComparableVersion was brought to Maven from
> versions-maven-plugin, it turns out the bug described here:
> https://github.com/mojohaus/versions-maven-plugin/issues/744
> also exists in maven, at least in 3.8.3.
> According to the maven version spec, versions containing a qualifier should
> be treated as less major than the same versions without the qualifier.
> Currently it's only the case for a few "standard" qualifiers, e.g. "-rc*",
> "-alpha", etc.
> However, it looks like "2.3-pfd" is deemed less major than "2.3".
> {code:java}
> @Test
> public void testComparableVersionWithCustomQualifier()
> {
> assertThat( new ComparableVersion( "2.3" ).compareTo( new
> ComparableVersion( "2.3-pfd" ) ),
> greaterThan( 0 ) );
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] elharo commented on pull request #845: [MNG-7559] Fix versions comparison
elharo commented on PR #845: URL: https://github.com/apache/maven/pull/845#issuecomment-1336213615 All looks good. I need to copy the PR into my account to run it through Jenkins -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo commented on pull request #270: [MDEP-831] Remove dependency on commons-lang3
elharo commented on PR #270: URL: https://github.com/apache/maven-dependency-plugin/pull/270#issuecomment-1336211518 Tests passing, ready for review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7615) Multithreaded model builder
[ https://issues.apache.org/jira/browse/MNG-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642871#comment-17642871 ] ASF GitHub Bot commented on MNG-7615: - cstamas commented on PR #893: URL: https://github.com/apache/maven/pull/893#issuecomment-1336197409 Those two runs above were Java 11. Switched to Java 17, first run was OK, but then it deadlocked again: https://gist.github.com/cstamas/c44475bc3231363bc159d1a1d52f27c0 > Multithreaded model builder > --- > > Key: MNG-7615 > URL: https://issues.apache.org/jira/browse/MNG-7615 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > > Parsing all reactor models can be very lengthy, so use a map/reduce algorithm > to make the computation in parallel. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #893: [MNG-7615] Multithreaded model builder
cstamas commented on PR #893: URL: https://github.com/apache/maven/pull/893#issuecomment-1336197409 Those two runs above were Java 11. Switched to Java 17, first run was OK, but then it deadlocked again: https://gist.github.com/cstamas/c44475bc3231363bc159d1a1d52f27c0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7615) Multithreaded model builder
[ https://issues.apache.org/jira/browse/MNG-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642869#comment-17642869 ] ASF GitHub Bot commented on MNG-7615: - cstamas commented on PR #893: URL: https://github.com/apache/maven/pull/893#issuecomment-1336196855 Deadlock seems consistent, Ctrl-C after 6 minutes previous build, re-run and again: https://gist.github.com/cstamas/62818af78abb293088cbb9383a278285 > Multithreaded model builder > --- > > Key: MNG-7615 > URL: https://issues.apache.org/jira/browse/MNG-7615 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > > Parsing all reactor models can be very lengthy, so use a map/reduce algorithm > to make the computation in parallel. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #893: [MNG-7615] Multithreaded model builder
cstamas commented on PR #893: URL: https://github.com/apache/maven/pull/893#issuecomment-1336196855 Deadlock seems consistent, Ctrl-C after 6 minutes previous build, re-run and again: https://gist.github.com/cstamas/62818af78abb293088cbb9383a278285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7615) Multithreaded model builder
[
https://issues.apache.org/jira/browse/MNG-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642868#comment-17642868
]
ASF GitHub Bot commented on MNG-7615:
-
gnodet commented on code in PR #893:
URL: https://github.com/apache/maven/pull/893#discussion_r1038806942
##
maven-model-builder/src/main/java/org/apache/maven/model/superpom/DefaultSuperPomProvider.java:
##
@@ -52,8 +53,8 @@ public DefaultSuperPomProvider(ModelProcessor modelProcessor)
{
@Override
public Model getSuperModel(String version) {
-if (superModel == null) {
-String resource = "/org/apache/maven/model/pom-" + version +
".xml";
+return SUPER_MODELS.computeIfAbsent(version, v -> {
Review Comment:
It could, though the only place it's called is with `4.0.0` afaik, and
that's since ages. I found the code does not reflect the javadoc and that the
`version` parameter is not used, so I fixed it.
If that's not intended, then we should remove the parameter completely.
The version was originally hardcoded, see
https://github.com/apache/maven/commit/dd635ca490bae271442d7b69eafdf595a627cafd
The commit added a version parameter, but it's only used the first time and
subsequent calls return the cached version.
As for having multiple superpoms, I think the problem is that the version
has never been updated when the pom changed. So not sure what the future will
be for the supermom...
> Multithreaded model builder
> ---
>
> Key: MNG-7615
> URL: https://issues.apache.org/jira/browse/MNG-7615
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
>
> Parsing all reactor models can be very lengthy, so use a map/reduce algorithm
> to make the computation in parallel.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet commented on a diff in pull request #893: [MNG-7615] Multithreaded model builder
gnodet commented on code in PR #893:
URL: https://github.com/apache/maven/pull/893#discussion_r1038806942
##
maven-model-builder/src/main/java/org/apache/maven/model/superpom/DefaultSuperPomProvider.java:
##
@@ -52,8 +53,8 @@ public DefaultSuperPomProvider(ModelProcessor modelProcessor)
{
@Override
public Model getSuperModel(String version) {
-if (superModel == null) {
-String resource = "/org/apache/maven/model/pom-" + version +
".xml";
+return SUPER_MODELS.computeIfAbsent(version, v -> {
Review Comment:
It could, though the only place it's called is with `4.0.0` afaik, and
that's since ages. I found the code does not reflect the javadoc and that the
`version` parameter is not used, so I fixed it.
If that's not intended, then we should remove the parameter completely.
The version was originally hardcoded, see
https://github.com/apache/maven/commit/dd635ca490bae271442d7b69eafdf595a627cafd
The commit added a version parameter, but it's only used the first time and
subsequent calls return the cached version.
As for having multiple superpoms, I think the problem is that the version
has never been updated when the pom changed. So not sure what the future will
be for the supermom...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7615) Multithreaded model builder
[ https://issues.apache.org/jira/browse/MNG-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642867#comment-17642867 ] ASF GitHub Bot commented on MNG-7615: - cstamas commented on PR #893: URL: https://github.com/apache/maven/pull/893#issuecomment-1336195768 Tried to test drive it, seems it deadlocked (console stopped at line 12): https://gist.github.com/cstamas/d54715ffc24d7513e735353d17d8f78b > Multithreaded model builder > --- > > Key: MNG-7615 > URL: https://issues.apache.org/jira/browse/MNG-7615 > Project: Maven > Issue Type: Task >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > > Parsing all reactor models can be very lengthy, so use a map/reduce algorithm > to make the computation in parallel. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #893: [MNG-7615] Multithreaded model builder
cstamas commented on PR #893: URL: https://github.com/apache/maven/pull/893#issuecomment-1336195768 Tried to test drive it, seems it deadlocked (console stopped at line 12): https://gist.github.com/cstamas/d54715ffc24d7513e735353d17d8f78b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7612) Chained Local Repository
[ https://issues.apache.org/jira/browse/MNG-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642866#comment-17642866 ] Hudson commented on MNG-7612: - Build succeeded in Jenkins: Maven » Maven TLP » maven » master #145 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/145/ > Chained Local Repository > - > > Key: MNG-7612 > URL: https://issues.apache.org/jira/browse/MNG-7612 > Project: Maven > Issue Type: New Feature > Components: Artifacts and Repositories >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > New feature: Chained Local Repository Manager (CLRM). > This new feature is not something one would use in production, is more > targeted to Integration Test isolation. > User story: ITs usually are run as part of Maven build – lets call it "outer > build" – that may build among other things, plugins and some artifacts needed > for the ITs. The ITs itself – let's call them "inner build" – should run in > isolated environment. > Problem: the "outer build" is usually affected by user environment > (settings.xml, use of MRM, and may use user own local repository unless > alternate specified) but also we do not want user MRM to be altered by IT > runs. The "inner build" on the other hand, may fail if use same LRM as "outer > build", as they are isolated, so they do not use settings.xml from the outer > build, may not use MRM and same remote repository IDs, and all these may lead > to mysterious "artifact not found" problems. Typically, outer build may use > MRM that defines mirrorOf with ID "my-mrm", while inner would use defaults, > where only remote repository is "central": this leads that user LRM gets > populated with artifacts available from "my-mrm" remote repository, while > inner build would know only about "central" remote repository. Enhanced LRM > (default since Maven 3.0) would refuse to serve up these artifacts. > Solution is CLRM: with CLRM user is able to specify isolated LRM for ITs, > while still making artifacts from outer LRM "visible" (discoverable) for the > IT build. Inner build uses isolated LRM solely, but for resolution purposes > still is able to resolve from outer LRM, where outer build might deployed > artifacts, plugins used by IT inner build. > Technical remark: CLRM defines "head" LRM, and list of LRM as "tail". Almost > all methods are delegated toward "head", except for find methods (metadata > and artifact), exposing tail LRM contents for artifact resolution. Also, CLRM > is *able* to enforce artifact availability (as explained above), but in most > cases (at least in IT user story), one would want to inhibit this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHADE-124) Need better plan for getting dependency-reduced-pom.xml out of basedir
[
https://issues.apache.org/jira/browse/MSHADE-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642859#comment-17642859
]
James Z.M. Gao commented on MSHADE-124:
---
[~kriegaex] Here is a single pom test case, the change of the basedir fails the
assembly plugin.
{code:java}
http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
http://maven.apache.org/xsd/maven-4.0.0.xsd;>
4.0.0
g
a
0
UTF-8
true
true
javax.inject
javax.inject
1
maven-jar-plugin
3.3.0
maven-shade-plugin
3.4.1
${project.build.directory}/dependency-reduced-pom.xml
${createDependencyReducedPom}
shade
package
maven-assembly-plugin
3.4.2
src
assembly
single
package
{code}
Run `mvn package` should successfully create target/a-0-src.tar.gz file
containing this pom.xml. But the latest version (3.4.1) of maven-shade-plugin
fails the command with error:
{noformat}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-assembly-plugin:3.4.2:single (assembly) on
project a: Failed to create assembly: Error creating assembly archive src:
archive cannot be empty -> [Help 1]
{noformat}
To work around, `mvn package -DcreateDependencyReducedPom=false` will generate
the expected archive file. In addition,
[https://github.com/apache/maven-shade-plugin/pull/128] can also pass this test.
> Need better plan for getting dependency-reduced-pom.xml out of basedir
> --
>
> Key: MSHADE-124
> URL: https://issues.apache.org/jira/browse/MSHADE-124
> Project: Maven Shade Plugin
> Issue Type: Bug
>Affects Versions: 1.7.1
>Reporter: Benson Margulies
>Priority: Major
>
> MSHADE-123 reported that putting the d-r-p into some location other
> than 'basedir' causes 'basedir' to follow it around, which can break builds.
> This is hard to fix, given the core maven definition of basedir as 'the dir
> containing the pom' with no option to change it.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7612) Chained Local Repository
[ https://issues.apache.org/jira/browse/MNG-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MNG-7612. Resolution: Fixed > Chained Local Repository > - > > Key: MNG-7612 > URL: https://issues.apache.org/jira/browse/MNG-7612 > Project: Maven > Issue Type: New Feature > Components: Artifacts and Repositories >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > New feature: Chained Local Repository Manager (CLRM). > This new feature is not something one would use in production, is more > targeted to Integration Test isolation. > User story: ITs usually are run as part of Maven build – lets call it "outer > build" – that may build among other things, plugins and some artifacts needed > for the ITs. The ITs itself – let's call them "inner build" – should run in > isolated environment. > Problem: the "outer build" is usually affected by user environment > (settings.xml, use of MRM, and may use user own local repository unless > alternate specified) but also we do not want user MRM to be altered by IT > runs. The "inner build" on the other hand, may fail if use same LRM as "outer > build", as they are isolated, so they do not use settings.xml from the outer > build, may not use MRM and same remote repository IDs, and all these may lead > to mysterious "artifact not found" problems. Typically, outer build may use > MRM that defines mirrorOf with ID "my-mrm", while inner would use defaults, > where only remote repository is "central": this leads that user LRM gets > populated with artifacts available from "my-mrm" remote repository, while > inner build would know only about "central" remote repository. Enhanced LRM > (default since Maven 3.0) would refuse to serve up these artifacts. > Solution is CLRM: with CLRM user is able to specify isolated LRM for ITs, > while still making artifacts from outer LRM "visible" (discoverable) for the > IT build. Inner build uses isolated LRM solely, but for resolution purposes > still is able to resolve from outer LRM, where outer build might deployed > artifacts, plugins used by IT inner build. > Technical remark: CLRM defines "head" LRM, and list of LRM as "tail". Almost > all methods are delegated toward "head", except for find methods (metadata > and artifact), exposing tail LRM contents for artifact resolution. Also, CLRM > is *able* to enforce artifact availability (as explained above), but in most > cases (at least in IT user story), one would want to inhibit this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7612) Chained Local Repository
[ https://issues.apache.org/jira/browse/MNG-7612?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642858#comment-17642858 ] ASF GitHub Bot commented on MNG-7612: - slawekjaranowski merged PR #897: URL: https://github.com/apache/maven/pull/897 > Chained Local Repository > - > > Key: MNG-7612 > URL: https://issues.apache.org/jira/browse/MNG-7612 > Project: Maven > Issue Type: New Feature > Components: Artifacts and Repositories >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > New feature: Chained Local Repository Manager (CLRM). > This new feature is not something one would use in production, is more > targeted to Integration Test isolation. > User story: ITs usually are run as part of Maven build – lets call it "outer > build" – that may build among other things, plugins and some artifacts needed > for the ITs. The ITs itself – let's call them "inner build" – should run in > isolated environment. > Problem: the "outer build" is usually affected by user environment > (settings.xml, use of MRM, and may use user own local repository unless > alternate specified) but also we do not want user MRM to be altered by IT > runs. The "inner build" on the other hand, may fail if use same LRM as "outer > build", as they are isolated, so they do not use settings.xml from the outer > build, may not use MRM and same remote repository IDs, and all these may lead > to mysterious "artifact not found" problems. Typically, outer build may use > MRM that defines mirrorOf with ID "my-mrm", while inner would use defaults, > where only remote repository is "central": this leads that user LRM gets > populated with artifacts available from "my-mrm" remote repository, while > inner build would know only about "central" remote repository. Enhanced LRM > (default since Maven 3.0) would refuse to serve up these artifacts. > Solution is CLRM: with CLRM user is able to specify isolated LRM for ITs, > while still making artifacts from outer LRM "visible" (discoverable) for the > IT build. Inner build uses isolated LRM solely, but for resolution purposes > still is able to resolve from outer LRM, where outer build might deployed > artifacts, plugins used by IT inner build. > Technical remark: CLRM defines "head" LRM, and list of LRM as "tail". Almost > all methods are delegated toward "head", except for find methods (metadata > and artifact), exposing tail LRM contents for artifact resolution. Also, CLRM > is *able* to enforce artifact availability (as explained above), but in most > cases (at least in IT user story), one would want to inhibit this. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] slawekjaranowski merged pull request #897: [MNG-7612] Chained LRM
slawekjaranowski merged PR #897: URL: https://github.com/apache/maven/pull/897 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-447) Update to Maven Parent POM 38
[ https://issues.apache.org/jira/browse/MPLUGIN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642855#comment-17642855 ] ASF GitHub Bot commented on MPLUGIN-447: elharo commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336186154 Why does upgrading the parent POM reformat pretty much every file? That seems like a very different thing. > Update to Maven Parent POM 38 > - > > Key: MPLUGIN-447 > URL: https://issues.apache.org/jira/browse/MPLUGIN-447 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.8.0 > > > This also reformats source code, for details see MPOM-349 and > https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7615) Multithreaded model builder
[
https://issues.apache.org/jira/browse/MNG-7615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642854#comment-17642854
]
ASF GitHub Bot commented on MNG-7615:
-
cstamas commented on code in PR #893:
URL: https://github.com/apache/maven/pull/893#discussion_r1038801109
##
maven-model-builder/src/main/java/org/apache/maven/model/superpom/DefaultSuperPomProvider.java:
##
@@ -52,8 +53,8 @@ public DefaultSuperPomProvider(ModelProcessor modelProcessor)
{
@Override
public Model getSuperModel(String version) {
-if (superModel == null) {
-String resource = "/org/apache/maven/model/pom-" + version +
".xml";
+return SUPER_MODELS.computeIfAbsent(version, v -> {
Review Comment:
Does this mean that for example maven 4.0.1 could return super POM of Maven
3.8.6 (ie. newer could have all super POMs of older Mavens?)
> Multithreaded model builder
> ---
>
> Key: MNG-7615
> URL: https://issues.apache.org/jira/browse/MNG-7615
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
>
> Parsing all reactor models can be very lengthy, so use a map/reduce algorithm
> to make the computation in parallel.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-plugin-tools] elharo commented on pull request #181: [MPLUGIN-447] Update to Maven Parent POM 38
elharo commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336186154 Why does upgrading the parent POM reformat pretty much every file? That seems like a very different thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #893: [MNG-7615] Multithreaded model builder
cstamas commented on code in PR #893:
URL: https://github.com/apache/maven/pull/893#discussion_r1038801109
##
maven-model-builder/src/main/java/org/apache/maven/model/superpom/DefaultSuperPomProvider.java:
##
@@ -52,8 +53,8 @@ public DefaultSuperPomProvider(ModelProcessor modelProcessor)
{
@Override
public Model getSuperModel(String version) {
-if (superModel == null) {
-String resource = "/org/apache/maven/model/pom-" + version +
".xml";
+return SUPER_MODELS.computeIfAbsent(version, v -> {
Review Comment:
Does this mean that for example maven 4.0.1 could return super POM of Maven
3.8.6 (ie. newer could have all super POMs of older Mavens?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MNG-7618) Use goalPrefix instead of artifactId to display mojos being executed
[
https://issues.apache.org/jira/browse/MNG-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-7618:
-
Summary: Use goalPrefix instead of artifactId to display mojos being
executed (was: Use goalPrefix instead of artifactId 4to display mojos being
executed )
> Use goalPrefix instead of artifactId to display mojos being executed
> -
>
> Key: MNG-7618
> URL: https://issues.apache.org/jira/browse/MNG-7618
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> The main problem is that the information displayed when starting a mojo looks
> like:
> {code:java}
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-maven-version) @
> camel ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-java-version) @ camel
> ---
> [INFO]
> {code}
> However, if you try to execute {{{}maven-enforcer-plugin:3.0.0:enforce{}}},
> you end up with the following:
> {code:java}
> [INFO] BuildTimeEventSpy is registered.
> [INFO] Scanning for projects...
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/maven-enforcer-plugin/3.0.0/maven-metadata.xml
> Downloading from central:
> https://repo.maven.apache.org/maven2/maven-enforcer-plugin/3.0.0/maven-metadata.xml
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.879 s
> [INFO] Finished at: 2022-12-03T12:12:40+01:00
> [INFO]
>
> [ERROR] Error resolving version for plugin 'maven-enforcer-plugin:3.0.0' from
> the repositories [local (/Users/gnodet/.m2/repository), apache.snapshots
> (https://repository.apache.org/snapshots/), central
> (https://repo.maven.apache.org/maven2)]: Plugin not found in any plugin
> repository -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginVersionResolutionException
> {code}
>
> I suggest to change the display to the {{pluginPrefix}} which gives
> {code}
> [INFO] ---< org.apache.camel:camel
> >---
> [INFO] Building Camel 4.0.0-SNAPSHOT
> [INFO] from pom.xml
> [INFO] [ pom
> ]-
> [WARN] Parameter 'reportPlugins' is unknown for plugin
> 'maven-site-plugin:3.11.0:attach-descriptor (attach-descriptor)'
> [INFO]
> [INFO] --- enforcer:3.0.0:enforce (enforce-maven-version) @ camel ---
> [INFO]
> [INFO] --- enforcer:3.0.0:enforce (enforce-java-version) @ camel ---
> [INFO]
> [INFO] --- enforcer:3.0.0:enforce (enforce-maven) @ camel ---
> [INFO]
> {code}
> which can then be easily executed:
> {code}
> ➜ maven git:(build-improvements) ✗ mvn -N -f ../camel flatten:1.2.5:flatten
> [INFO] BuildTimeEventSpy is registered.
> [INFO] Processing build on daemon 56c20cb8
> [INFO] Scanning for projects...
> [INFO] BuildTimeEventSpy is registered.
> [INFO]
> [INFO] Using the SmartBuilder implementation with a thread count of 9
> [INFO] Task segments : [flatten:1.2.5:flatten]
> [INFO] Build maximum degree of concurrency is 9
> [INFO] Total number of projects is 1
> [INFO]
> [INFO] ---< org.apache.camel:camel
> >---
> [INFO] Building Camel 4.0.0-SNAPSHOT
> [INFO] from pom.xml
> [INFO] [ pom
> ]-
> [INFO]
> [INFO] --- flatten:1.2.5:flatten (default-cli) @ camel ---
> [INFO] Generating flattened POM of project
> org.apache.camel:camel:pom:4.0.0-SNAPSHOT...
> [INFO] Segment walltime 0 s, segment projects service time 0 s,
> effective/maximum degree of concurrency 0.97/9
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 0.025 s (Wall Clock)
> [INFO] Finished at: 2022-12-03T12:14:29+01:00
> [INFO]
>
> ➜ maven git:(build-improvements) ✗
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MDEP-838) " Artifact has not been packaged yet" Errro message is not very helpful.
[ https://issues.apache.org/jira/browse/MDEP-838?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MDEP-838: --- Issue Type: Bug (was: Improvement) > " Artifact has not been packaged yet" Errro message is not very helpful. > > > Key: MDEP-838 > URL: https://issues.apache.org/jira/browse/MDEP-838 > Project: Maven Dependency Plugin > Issue Type: Bug >Reporter: Christoph Läubrich >Priority: Major > > Today in a build i get the error > > Artifact has not been packaged yet. When used on reactor artifact, copy > > should be executed after packaging: see MDEP-187 > So I know something is wrong but ... > The error message should at best include > # The "not packed artifact" > # The possible location / reactor project > # Probably *why* it is not considered as packed (e.g does it has no artifact > file? Is it a directory? Something else?) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-838) " Artifact has not been packaged yet" Errro message is not very helpful.
[ https://issues.apache.org/jira/browse/MDEP-838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642843#comment-17642843 ] Elliotte Rusty Harold commented on MDEP-838: We need more details. What command did you run? Do you have a simple project that can reproduce this? > " Artifact has not been packaged yet" Errro message is not very helpful. > > > Key: MDEP-838 > URL: https://issues.apache.org/jira/browse/MDEP-838 > Project: Maven Dependency Plugin > Issue Type: Improvement >Reporter: Christoph Läubrich >Priority: Major > > Today in a build i get the error > > Artifact has not been packaged yet. When used on reactor artifact, copy > > should be executed after packaging: see MDEP-187 > So I know something is wrong but ... > The error message should at best include > # The "not packed artifact" > # The possible location / reactor project > # Probably *why* it is not considered as packed (e.g does it has no artifact > file? Is it a directory? Something else?) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MDEP-839) dependency:list should output a plain list whe used with a file
[ https://issues.apache.org/jira/browse/MDEP-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MDEP-839: --- Issue Type: Bug (was: Improvement) > dependency:list should output a plain list whe used with a file > --- > > Key: MDEP-839 > URL: https://issues.apache.org/jira/browse/MDEP-839 > Project: Maven Dependency Plugin > Issue Type: Bug >Reporter: Christoph Läubrich >Priority: Major > > There is a parameter to redirect the output to a file: > https://maven.apache.org/plugins/maven-dependency-plugin/list-mojo.html#outputFile > This currently has some issues I would not expect when redirecting such > content to a file: > # First line in the file is empty > # Second line says 'The following files have been resolved:' > # next lines are indented > # ANSI Escape Characters are emmited e.g. [36m -- module maven.core[0;1;33m > (auto)[m > What I would expect: > Each line just contains the raw resolved dependency e.g. > "org.apache.maven:maven-core:jar:3.8.6:provided" and no more content is > printed out, especially no ANSI Escapes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MDEP-839) dependency:list should output a plain list whe used with a file
[ https://issues.apache.org/jira/browse/MDEP-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MDEP-839: --- Priority: Minor (was: Major) > dependency:list should output a plain list whe used with a file > --- > > Key: MDEP-839 > URL: https://issues.apache.org/jira/browse/MDEP-839 > Project: Maven Dependency Plugin > Issue Type: Bug >Reporter: Christoph Läubrich >Priority: Minor > > There is a parameter to redirect the output to a file: > https://maven.apache.org/plugins/maven-dependency-plugin/list-mojo.html#outputFile > This currently has some issues I would not expect when redirecting such > content to a file: > # First line in the file is empty > # Second line says 'The following files have been resolved:' > # next lines are indented > # ANSI Escape Characters are emmited e.g. [36m -- module maven.core[0;1;33m > (auto)[m > What I would expect: > Each line just contains the raw resolved dependency e.g. > "org.apache.maven:maven-core:jar:3.8.6:provided" and no more content is > printed out, especially no ANSI Escapes -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MDEP-831) Remove not used dependencies / Replace parts
[
https://issues.apache.org/jira/browse/MDEP-831?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642841#comment-17642841
]
Elliotte Rusty Harold commented on MDEP-831:
commons-collections4 covered in MDEP-832
> Remove not used dependencies / Replace parts
>
>
> Key: MDEP-831
> URL: https://issues.apache.org/jira/browse/MDEP-831
> Project: Maven Dependency Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Karl Heinz Marbaise
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: version-next
>
>
> Currently the dependency is not used at all:
> {code:xml}
>
> commons-beanutils
> commons-beanutils
> 1.9.4
>
> {code}
> The dependency is only used for a single method:
> {code:xml}
>
> org.apache.commons
> commons-collections4
> 4.2
>
> {code}
> The dependency is only used for two methods of StringUtils.
> {code:xml}
>
> org.apache.commons
> commons-lang3
> 3.12.0
>
> {code}
> The dependency is only used in tests for deleting a directory.
> {code:xml}
>
> commons-io
> commons-io
> 2.11.0
>
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] slawekjaranowski opened a new pull request, #348: Clean workspace before build
slawekjaranowski opened a new pull request, #348: URL: https://github.com/apache/maven-site/pull/348 Old workspace can contain corrupted git data or contain data created by another git version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-mvnd] gnodet commented on issue #745: Is it possible to print the version of the plugin
gnodet commented on issue #745: URL: https://github.com/apache/maven-mvnd/issues/745#issuecomment-1336161265 https://user-images.githubusercontent.com/84022/205443254-727df289-e26b-4ffb-9662-d75b83bd8755.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] dependabot[bot] commented on pull request #559: Bump maven-reporting-api from 3.1.0 to 3.1.1
dependabot[bot] commented on PR #559: URL: https://github.com/apache/maven-surefire/pull/559#issuecomment-1336148866 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] michael-o closed pull request #559: Bump maven-reporting-api from 3.1.0 to 3.1.1
michael-o closed pull request #559: Bump maven-reporting-api from 3.1.0 to 3.1.1 URL: https://github.com/apache/maven-surefire/pull/559 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] michael-o commented on pull request #559: Bump maven-reporting-api from 3.1.0 to 3.1.1
michael-o commented on PR #559: URL: https://github.com/apache/maven-surefire/pull/559#issuecomment-1336148855 Superseded with #579. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-surefire] michael-o opened a new pull request, #579: [SUREFIRE-2129] Upgrade Maven Reporting API to 3.1.1/Maven Reporting …
michael-o opened a new pull request, #579: URL: https://github.com/apache/maven-surefire/pull/579 …Impl to 3.2.0 This closes #579 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-2129) Upgrade Maven Reporting API to 3.1.1/Maven Reporting Impl to 3.2.0
Michael Osipov created SUREFIRE-2129: Summary: Upgrade Maven Reporting API to 3.1.1/Maven Reporting Impl to 3.2.0 Key: SUREFIRE-2129 URL: https://issues.apache.org/jira/browse/SUREFIRE-2129 Project: Maven Surefire Issue Type: Dependency upgrade Components: Maven Surefire Report Plugin Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 3.0.0-M8 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MENFORCER-440) Allow 8 as JDK version for requireJavaVersion
Slawomir Jaranowski created MENFORCER-440:
-
Summary: Allow 8 as JDK version for requireJavaVersion
Key: MENFORCER-440
URL: https://issues.apache.org/jira/browse/MENFORCER-440
Project: Maven Enforcer Plugin
Issue Type: Improvement
Components: Standard Rules
Reporter: Slawomir Jaranowski
We can use java version as {{8}} for target maven-compiler-plugin.
In order to have simplify configuration requireJavaVersion should also
recognize {{8}} as {{1.8}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-mvnd] gnodet commented on issue #745: Is it possible to print the version of the plugin
gnodet commented on issue #745: URL: https://github.com/apache/maven-mvnd/issues/745#issuecomment-1336137863 In relation to [MNG-7618](https://issues.apache.org/jira/browse/MNG-7618), I think it could be a good enhancement to switch the display to `pluginPrefix:version:goal` so that we end up with the same display as `maven-4.0.0-alpha-3`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7618) Use goalPrefix instead of artifactId 4to display mojos being executed
[
https://issues.apache.org/jira/browse/MNG-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642811#comment-17642811
]
ASF GitHub Bot commented on MNG-7618:
-
gnodet opened a new pull request, #898:
URL: https://github.com/apache/maven/pull/898
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you
replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to
use the JIRA issue
title in the pull request title and in the first line of the commit
message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Use goalPrefix instead of artifactId 4to display mojos being executed
> --
>
> Key: MNG-7618
> URL: https://issues.apache.org/jira/browse/MNG-7618
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> The main problem is that the information displayed when starting a mojo looks
> like:
> {code:java}
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-maven-version) @
> camel ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-java-version) @ camel
> ---
> [INFO]
> {code}
> However, if you try to execute {{{}maven-enforcer-plugin:3.0.0:enforce{}}},
> you end up with the following:
> {code:java}
> [INFO] BuildTimeEventSpy is registered.
> [INFO] Scanning for projects...
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/maven-enforcer-plugin/3.0.0/maven-metadata.xml
> Downloading from central:
> https://repo.maven.apache.org/maven2/maven-enforcer-plugin/3.0.0/maven-metadata.xml
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.879 s
> [INFO] Finished at: 2022-12-03T12:12:40+01:00
> [INFO]
>
> [ERROR] Error resolving version for plugin 'maven-enforcer-plugin:3.0.0' from
> the repositories [local (/Users/gnodet/.m2/repository), apache.snapshots
> (https://repository.apache.org/snapshots/), central
> (https://repo.maven.apache.org/maven2)]: Plugin not found in any plugin
> repository -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginVersionResolutionException
> {code}
>
> I suggest to change the display to the {{pluginPrefix}} which gives
> {code}
> [INFO] ---< org.apache.camel:camel
> >---
> [INFO] Building Camel 4.0.0-SNAPSHOT
> [INFO] from pom.xml
> [INFO] [ pom
> ]-
> [WARN] Parameter 'reportPlugins' is unknown for plugin
> 'maven-site-plugin:3.11.0:attach-descriptor
[GitHub] [maven] gnodet opened a new pull request, #898: [MNG-7618] Use goalPrefix instead of artifactId 4to display mojos being executed
gnodet opened a new pull request, #898: URL: https://github.com/apache/maven/pull/898 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7618) Use goalPrefix instead of artifactId 4to display mojos being executed
Guillaume Nodet created MNG-7618:
Summary: Use goalPrefix instead of artifactId 4to display mojos
being executed
Key: MNG-7618
URL: https://issues.apache.org/jira/browse/MNG-7618
Project: Maven
Issue Type: Task
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
Fix For: 4.0.0-alpha-3
The main problem is that the information displayed when starting a mojo looks
like:
{code:java}
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-maven-version) @ camel
---
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-java-version) @ camel
---
[INFO]
{code}
However, if you try to execute {{{}maven-enforcer-plugin:3.0.0:enforce{}}}, you
end up with the following:
{code:java}
[INFO] BuildTimeEventSpy is registered.
[INFO] Scanning for projects...
Downloading from apache.snapshots:
https://repository.apache.org/snapshots/maven-enforcer-plugin/3.0.0/maven-metadata.xml
Downloading from central:
https://repo.maven.apache.org/maven2/maven-enforcer-plugin/3.0.0/maven-metadata.xml
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 0.879 s
[INFO] Finished at: 2022-12-03T12:12:40+01:00
[INFO]
[ERROR] Error resolving version for plugin 'maven-enforcer-plugin:3.0.0' from
the repositories [local (/Users/gnodet/.m2/repository), apache.snapshots
(https://repository.apache.org/snapshots/), central
(https://repo.maven.apache.org/maven2)]: Plugin not found in any plugin
repository -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e
switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please
read the following articles:
[ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/PluginVersionResolutionException
{code}
I suggest to change the display to the {{pluginPrefix}} which gives
{code}
[INFO] ---< org.apache.camel:camel >---
[INFO] Building Camel 4.0.0-SNAPSHOT
[INFO] from pom.xml
[INFO] [ pom ]-
[WARN] Parameter 'reportPlugins' is unknown for plugin
'maven-site-plugin:3.11.0:attach-descriptor (attach-descriptor)'
[INFO]
[INFO] --- enforcer:3.0.0:enforce (enforce-maven-version) @ camel ---
[INFO]
[INFO] --- enforcer:3.0.0:enforce (enforce-java-version) @ camel ---
[INFO]
[INFO] --- enforcer:3.0.0:enforce (enforce-maven) @ camel ---
[INFO]
{code}
which can then be easily executed:
{code}
➜ maven git:(build-improvements) ✗ mvn -N -f ../camel flatten:1.2.5:flatten
[INFO] BuildTimeEventSpy is registered.
[INFO] Processing build on daemon 56c20cb8
[INFO] Scanning for projects...
[INFO] BuildTimeEventSpy is registered.
[INFO]
[INFO] Using the SmartBuilder implementation with a thread count of 9
[INFO] Task segments : [flatten:1.2.5:flatten]
[INFO] Build maximum degree of concurrency is 9
[INFO] Total number of projects is 1
[INFO]
[INFO] ---< org.apache.camel:camel >---
[INFO] Building Camel 4.0.0-SNAPSHOT
[INFO] from pom.xml
[INFO] [ pom ]-
[INFO]
[INFO] --- flatten:1.2.5:flatten (default-cli) @ camel ---
[INFO] Generating flattened POM of project
org.apache.camel:camel:pom:4.0.0-SNAPSHOT...
[INFO] Segment walltime 0 s, segment projects service time 0 s,
effective/maximum degree of concurrency 0.97/9
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 0.025 s (Wall Clock)
[INFO] Finished at: 2022-12-03T12:14:29+01:00
[INFO]
➜ maven git:(build-improvements) ✗
{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7608) Make Resolver native transport the default in Maven4
[ https://issues.apache.org/jira/browse/MNG-7608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17642808#comment-17642808 ] ASF GitHub Bot commented on MNG-7608: - cstamas commented on PR #892: URL: https://github.com/apache/maven/pull/892#issuecomment-1336130709 Nothing of legacy is lost, resolver transport (since 3.0) was always like this: ``` maven +-> transport-wagon +-> wagon-http | +-> wagon-foo | +-> ... +-> transport-http +-> transport-jetty (or whatever) ``` All what happened here is the "transport-wagon" got it's original priority for resolver applied (is demoted). Hence, to use custom wagon, all you need is to set transport-wagon, and from there, everything is "as before". This change merely exposed (and reordered) the first level of "transort-*" nodes... > Make Resolver native transport the default in Maven4 > > > Key: MNG-7608 > URL: https://issues.apache.org/jira/browse/MNG-7608 > Project: Maven > Issue Type: Improvement >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate, 4.0.0 > > > The ancient Wagon should be phased out, and "native" resolver transport > should be the default in Maven4. This in start halves the HTTP request count > toward Maven Central and any major MRM. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #892: [MNG-7608] Make native transport the default
cstamas commented on PR #892: URL: https://github.com/apache/maven/pull/892#issuecomment-1336130709 Nothing of legacy is lost, resolver transport (since 3.0) was always like this: ``` maven +-> transport-wagon +-> wagon-http | +-> wagon-foo | +-> ... +-> transport-http +-> transport-jetty (or whatever) ``` All what happened here is the "transport-wagon" got it's original priority for resolver applied (is demoted). Hence, to use custom wagon, all you need is to set transport-wagon, and from there, everything is "as before". This change merely exposed (and reordered) the first level of "transort-*" nodes... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
