[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #268: [MDEP-831] remove unused beanutils dependency
slawekjaranowski commented on PR #268: URL: https://github.com/apache/maven-dependency-plugin/pull/268#issuecomment-1336863176 You right fixing such issue at source is the best way, but until it happens we should have some workaround. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo commented on pull request #268: [MDEP-831] remove unused beanutils dependency
elharo commented on PR #268: URL: https://github.com/apache/maven-dependency-plugin/pull/268#issuecomment-1336566149 Seems like the correct way to handle this is by releasing org.apache.maven.doxia:doxia-site-renderer:2.0.0 and then upgrading the dependency plugin to that version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] elharo commented on pull request #268: [MDEP-831] remove unused beanutils dependency
elharo commented on PR #268: URL: https://github.com/apache/maven-dependency-plugin/pull/268#issuecomment-1336562239 Adding an extra dependency is not the right way to handle this. DependencyManagement might be better but is not really right for this case either. This needs to be fixed in whatever dependency is pulling in the old version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-plugin] slawekjaranowski commented on pull request #268: [MDEP-831] remove unused beanutils dependency
slawekjaranowski commented on PR #268: URL: https://github.com/apache/maven-dependency-plugin/pull/268#issuecomment-1336558063 @elharo , @slachiewicz It was added in order to override transitive version, now we have version 1.7.0 - please examine dependency tree Why we need newer version ... because of CVE ... Probably better place will be dependencyManagement for such case. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-shared-utils] elharo commented on a diff in pull request #123: [MSHARED-1172] Deprecate redundant isEmptyString method
elharo commented on code in PR #123: URL: https://github.com/apache/maven-shared-utils/pull/123#discussion_r1039017348 ## src/main/java/org/apache/maven/shared/utils/xml/Xpp3DomUtils.java: ## @@ -148,15 +148,15 @@ private static boolean isMergeChildren( Xpp3Dom dominant ) } /** - * @param str The string to be checked. - * @return true in case string is empty false otherwise. + * @deprecated use String.isBlank() (Java 11+) Review Comment: fixed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHARED-1151) Upgrade Parent to 38
[ https://issues.apache.org/jira/browse/MSHARED-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MSHARED-1151: --- Summary: Upgrade Parent to 38 (was: Upgrade Parent to 37) > Upgrade Parent to 38 > > > Key: MSHARED-1151 > URL: https://issues.apache.org/jira/browse/MSHARED-1151 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-invoker >Reporter: Slawomir Jaranowski >Priority: Major > Labels: up-for-grabs > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-848) Code Improvement in ReaderFactory to get rid of commons-io dependency
[
https://issues.apache.org/jira/browse/MSHARED-848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643064#comment-17643064
]
Elliotte Rusty Harold commented on MSHARED-848:
---
commons-io has been upgraded to 2.11 so the CVE is no longer an issue. The
underlying issue remains.
> Code Improvement in ReaderFactory to get rid of commons-io dependency
> -
>
> Key: MSHARED-848
> URL: https://issues.apache.org/jira/browse/MSHARED-848
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-shared-utils
>Affects Versions: maven-shared-utils-3.3.3
>Reporter: Karl Heinz Marbaise
>Priority: Minor
>
> Currently the dependency to:
> {code:xml}
>
> commons-io
> commons-io
> 2.6
>
> {code}
> is only needed within the class {{ReaderFactory}} which imports
> {{org.apache.commons.io.input.XmlStreamReader}}.
> The question: Can that be replaced with something different? In consequence
> we could get rid of the dependency on {{commons-io}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-677) Macro for printing project properties
[
https://issues.apache.org/jira/browse/DOXIA-677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated DOXIA-677:
--
Fix Version/s: wontfix-candidate
> Macro for printing project properties
> -
>
> Key: DOXIA-677
> URL: https://issues.apache.org/jira/browse/DOXIA-677
> Project: Maven Doxia
> Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Priority: Major
> Fix For: wontfix-candidate
>
>
> Many time we use Velocity only for resolving project properties like:
> {code}
> ${project.version}
> {code}
> Another case is that for Markdown we have conflicts
> Velocity uses # as a prefix for macros and ## as a prefix for comments
> but in Markdown those are used for headers
> So Doxia macro will be useful is such cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-677) Macro for printing project properties
[
https://issues.apache.org/jira/browse/DOXIA-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643053#comment-17643053
]
Slawomir Jaranowski commented on DOXIA-677:
---
For simple project properties usage filtering by resources plugin looks the
best way for me.
> Macro for printing project properties
> -
>
> Key: DOXIA-677
> URL: https://issues.apache.org/jira/browse/DOXIA-677
> Project: Maven Doxia
> Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Many time we use Velocity only for resolving project properties like:
> {code}
> ${project.version}
> {code}
> Another case is that for Markdown we have conflicts
> Velocity uses # as a prefix for macros and ## as a prefix for comments
> but in Markdown those are used for headers
> So Doxia macro will be useful is such cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643049#comment-17643049
]
ASF GitHub Bot commented on MNG-7619:
-
cstamas opened a new pull request, #902:
URL: https://github.com/apache/maven/pull/902
Adds Maven feature that is able to explain why an artifact is present in
local repository.
Usable for diagnosing resolution issues.
In local repository, for each artifact it records `.tracking` folder,
containing farthest artifact that got to this artifact, and the list of graph
nodes that lead to it.
Note: this is based on by @grgrzybek proposal and reuses some code he
provided. See https://github.com/apache/maven-resolver/pull/182
Forward-port of: https://github.com/apache/maven/pull/900
---
https://issues.apache.org/jira/browse/MNG-7619
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you
replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to
use the JIRA issue
title in the pull request title and in the first line of the commit
message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas opened a new pull request, #902: [MNG-7619] Reverse Dependency Tree
cstamas opened a new pull request, #902: URL: https://github.com/apache/maven/pull/902 Adds Maven feature that is able to explain why an artifact is present in local repository. Usable for diagnosing resolution issues. In local repository, for each artifact it records `.tracking` folder, containing farthest artifact that got to this artifact, and the list of graph nodes that lead to it. Note: this is based on by @grgrzybek proposal and reuses some code he provided. See https://github.com/apache/maven-resolver/pull/182 Forward-port of: https://github.com/apache/maven/pull/900 --- https://issues.apache.org/jira/browse/MNG-7619 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-569) Add Markdown Sink to be able to convert anything to Markdown
[ https://issues.apache.org/jira/browse/DOXIA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643046#comment-17643046 ] ASF GitHub Bot commented on DOXIA-569: -- hboutemy opened a new pull request, #128: URL: https://github.com/apache/maven-doxia/pull/128 https://issues.apache.org/jira/browse/DOXIA-569 > Add Markdown Sink to be able to convert anything to Markdown > > > Key: DOXIA-569 > URL: https://issues.apache.org/jira/browse/DOXIA-569 > Project: Maven Doxia > Issue Type: New Feature > Components: Module - Markdown >Affects Versions: 1.8 >Reporter: Herve Boutemy >Priority: Major > Labels: intern > > Markdown is well known: having Markdown Sink would help people transform > existing content to Markdown -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-doxia] hboutemy opened a new pull request, #128: DOXIA-569 add Markdown output (sink)
hboutemy opened a new pull request, #128: URL: https://github.com/apache/maven-doxia/pull/128 https://issues.apache.org/jira/browse/DOXIA-569 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MENFORCER-438) Upgrade maven-plugin parent to 38
[ https://issues.apache.org/jira/browse/MENFORCER-438?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643013#comment-17643013 ] Hudson commented on MENFORCER-438: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-enforcer » master #82 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-enforcer/job/master/82/ > Upgrade maven-plugin parent to 38 > - > > Key: MENFORCER-438 > URL: https://issues.apache.org/jira/browse/MENFORCER-438 > Project: Maven Enforcer Plugin > Issue Type: Dependency upgrade >Affects Versions: 3.1.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: next-release > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-site] slawekjaranowski merged pull request #348: Clean workspace before build
slawekjaranowski merged PR #348: URL: https://github.com/apache/maven-site/pull/348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #185: Bump maven-common-artifact-filters from 3.2.0 to 3.3.2
slawekjaranowski commented on PR #185: URL: https://github.com/apache/maven-enforcer/pull/185#issuecomment-1336420553 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #194: [MENFORCER-438] Upgrade maven-plugin parent to 38 - cleanup
slawekjaranowski merged PR #194: URL: https://github.com/apache/maven-enforcer/pull/194 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MENFORCER-411) DependencyConvergence should support including/excluding certain dependencies
[ https://issues.apache.org/jira/browse/MENFORCER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17643009#comment-17643009 ] Hudson commented on MENFORCER-411: -- Build succeeded in Jenkins: Maven » Maven TLP » maven-enforcer » master #81 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-enforcer/job/master/81/ > DependencyConvergence should support including/excluding certain dependencies > - > > Key: MENFORCER-411 > URL: https://issues.apache.org/jira/browse/MENFORCER-411 > Project: Maven Enforcer Plugin > Issue Type: New Feature > Components: Standard Rules >Affects Versions: 3.1.0 >Reporter: Forrest Feaser >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > Original Estimate: 4h > Remaining Estimate: 4h > > It would be nice if the DependencyConvergence rule could specify certain > dependencies that should/should not fail the build. This might be useful if > your project has a lot of dependency conflicts, but you know there are just a > few troublesome ones that cause issues, and you don't want to resolve the > conflicts for your entire project. > Here is my PR: https://github.com/apache/maven-enforcer/pull/136 > Do I need to sign the Contributor License Agreement for this? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MENFORCER-411) DependencyConvergence should support including/excluding certain dependencies
[ https://issues.apache.org/jira/browse/MENFORCER-411?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MENFORCER-411. - Fix Version/s: next-release Assignee: Slawomir Jaranowski Resolution: Fixed > DependencyConvergence should support including/excluding certain dependencies > - > > Key: MENFORCER-411 > URL: https://issues.apache.org/jira/browse/MENFORCER-411 > Project: Maven Enforcer Plugin > Issue Type: New Feature > Components: Standard Rules >Affects Versions: 3.1.0 >Reporter: Forrest Feaser >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > Original Estimate: 4h > Remaining Estimate: 4h > > It would be nice if the DependencyConvergence rule could specify certain > dependencies that should/should not fail the build. This might be useful if > your project has a lot of dependency conflicts, but you know there are just a > few troublesome ones that cause issues, and you don't want to resolve the > conflicts for your entire project. > Here is my PR: https://github.com/apache/maven-enforcer/pull/136 > Do I need to sign the Contributor License Agreement for this? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-enforcer] slawekjaranowski merged pull request #136: [MENFORCER-411] DependencyConvergence takes include/exclude parameters to filter errors
slawekjaranowski merged PR #136: URL: https://github.com/apache/maven-enforcer/pull/136 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642995#comment-17642995
]
ASF GitHub Bot commented on MNG-7619:
-
pzygielo commented on code in PR #900:
URL: https://github.com/apache/maven/pull/900#discussion_r1038965386
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.aether;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.ListIterator;
+import java.util.Objects;
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+/**
+ * A class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ *
+ * @since 3.9.0
+ */
+class ReverseTreeRepositoryListener extends AbstractRepositoryListener {
+@Override
+public void artifactResolved(RepositoryEvent event) {
+requireNonNull(event, "event cannot be null");
+
+if (!event.getArtifact()
+.getFile()
+.getPath()
+
.startsWith(event.getSession().getLocalRepository().getBasedir().getPath())) {
+return; // reactor artifact
+}
+RequestTrace trace = event.getTrace();
+CollectStepData collectStepTrace = null;
Review Comment:
Class method (static) would need no instance for test. Like it doesn't to do
its job.
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] pzygielo commented on a diff in pull request #900: [MNG-7619] Reverse Dependency Tree
pzygielo commented on code in PR #900:
URL: https://github.com/apache/maven/pull/900#discussion_r1038965386
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.aether;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.ListIterator;
+import java.util.Objects;
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+/**
+ * A class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ *
+ * @since 3.9.0
+ */
+class ReverseTreeRepositoryListener extends AbstractRepositoryListener {
+@Override
+public void artifactResolved(RepositoryEvent event) {
+requireNonNull(event, "event cannot be null");
+
+if (!event.getArtifact()
+.getFile()
+.getPath()
+
.startsWith(event.getSession().getLocalRepository().getBasedir().getPath())) {
+return; // reactor artifact
+}
+RequestTrace trace = event.getTrace();
+CollectStepData collectStepTrace = null;
Review Comment:
Class method (static) would need no instance for test. Like it doesn't to do
its job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642993#comment-17642993
]
ASF GitHub Bot commented on MNG-7619:
-
cstamas commented on PR #900:
URL: https://github.com/apache/maven/pull/900#issuecomment-1336402839
Um, unsure why GH says "removed request" from @pzygielo , I actually asked
both @michael-o and @pzygielo for repeated review...
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-677) Macro for printing project properties
[
https://issues.apache.org/jira/browse/DOXIA-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642985#comment-17642985
]
Michael Osipov commented on DOXIA-677:
--
[~hboutemy], I think your approach needs to be added to the Site Plugin as well
to have a lightweight alternative when you don't need all Velocity features. I
think this request is obsolete.
> Macro for printing project properties
> -
>
> Key: DOXIA-677
> URL: https://issues.apache.org/jira/browse/DOXIA-677
> Project: Maven Doxia
> Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Many time we use Velocity only for resolving project properties like:
> {code}
> ${project.version}
> {code}
> Another case is that for Markdown we have conflicts
> Velocity uses # as a prefix for macros and ## as a prefix for comments
> but in Markdown those are used for headers
> So Doxia macro will be useful is such cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (DOXIA-677) Macro for printing project properties
[
https://issues.apache.org/jira/browse/DOXIA-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642971#comment-17642971
]
Michael Osipov edited comment on DOXIA-677 at 12/4/22 11:20 AM:
I don't really get what macro you want to introduce, that will do what
but FYI, I lately had a discussion with Mybatis Spring project who wanted
exactly that: easy {{${project.version}}} replacement in their site that is
written in Markdown
I proposed an approach based on Velocity (= "replace {{##}} with {{#[[##]]#}},
{{###}} with {{#[[###]]#}}, ..." ) that they did not like, giving a very good
reason = "I prefer to use .md file instead of .vm file cannot render on GitHub
UI." (see https://github.com/mybatis/spring/pull/759 for full discussion)
then I proposed an approach using maven-resources-plugin to do the filtering:
https://github.com/mybatis/spring/pull/763
notice that the Velocity approach is already documented, even if (as usual)
it's not easy to find:
https://maven.apache.org/plugins/maven-site-plugin/examples/creating-content.html#common-issues-and-workarounds
was (Author: hboutemy):
I don't really get what macro you want to introduce, that will do what
but FYI, I lately had a discussion with Mybatis Spring project who wanted
exactly that: easy {{${project.version}}} replacement in their site taht is
written in Markdown
I proposed an approach based on Velocity (= "replace {{##}} with {{#[[##]]#}},
{{###}} with {{#[[###]]#}}, ..." ) that they did not like, giving a very good
reason = "I prefer to use .md file instead of .vm file cannot render on GitHub
UI." (see https://github.com/mybatis/spring/pull/759 for full discussion)
then I proposed an approach using maven-resources-plugin to do the filtering:
https://github.com/mybatis/spring/pull/763
notice that the Velocity approach is already documented, even if (as usual)
it's not easy to find:
https://maven.apache.org/plugins/maven-site-plugin/examples/creating-content.html#common-issues-and-workarounds
> Macro for printing project properties
> -
>
> Key: DOXIA-677
> URL: https://issues.apache.org/jira/browse/DOXIA-677
> Project: Maven Doxia
> Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Many time we use Velocity only for resolving project properties like:
> {code}
> ${project.version}
> {code}
> Another case is that for Markdown we have conflicts
> Velocity uses # as a prefix for macros and ## as a prefix for comments
> but in Markdown those are used for headers
> So Doxia macro will be useful is such cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642977#comment-17642977
]
ASF GitHub Bot commented on MNG-7619:
-
pzygielo commented on code in PR #900:
URL: https://github.com/apache/maven/pull/900#discussion_r1038946944
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.aether;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.ListIterator;
+import java.util.Objects;
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+/**
+ * A class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ *
+ * @since 3.9.0
+ */
+class ReverseTreeRepositoryListener extends AbstractRepositoryListener {
+@Override
+public void artifactResolved(RepositoryEvent event) {
+requireNonNull(event, "event cannot be null");
+
+if (!event.getArtifact()
+.getFile()
+.getPath()
+
.startsWith(event.getSession().getLocalRepository().getBasedir().getPath())) {
+return; // reactor artifact
+}
+RequestTrace trace = event.getTrace();
+CollectStepData collectStepTrace = null;
Review Comment:
Could this variable be moved one line up, and the loop then extracted to
(tested) class method?
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] pzygielo commented on a diff in pull request #900: [MNG-7619] Reverse Dependency Tree
pzygielo commented on code in PR #900:
URL: https://github.com/apache/maven/pull/900#discussion_r1038946944
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.aether;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.ListIterator;
+import java.util.Objects;
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+/**
+ * A class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ *
+ * @since 3.9.0
+ */
+class ReverseTreeRepositoryListener extends AbstractRepositoryListener {
+@Override
+public void artifactResolved(RepositoryEvent event) {
+requireNonNull(event, "event cannot be null");
+
+if (!event.getArtifact()
+.getFile()
+.getPath()
+
.startsWith(event.getSession().getLocalRepository().getBasedir().getPath())) {
+return; // reactor artifact
+}
+RequestTrace trace = event.getTrace();
+CollectStepData collectStepTrace = null;
Review Comment:
Could this variable be moved one line up, and the loop then extracted to
(tested) class method?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-plugin-tools] dependabot[bot] commented on pull request #180: Bump slf4jVersion from 1.7.5 to 2.0.5
dependabot[bot] commented on PR #180: URL: https://github.com/apache/maven-plugin-tools/pull/180#issuecomment-1336373966 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] slawekjaranowski closed pull request #180: Bump slf4jVersion from 1.7.5 to 2.0.5
slawekjaranowski closed pull request #180: Bump slf4jVersion from 1.7.5 to 2.0.5 URL: https://github.com/apache/maven-plugin-tools/pull/180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642975#comment-17642975
]
ASF GitHub Bot commented on MNG-7619:
-
pzygielo commented on code in PR #900:
URL: https://github.com/apache/maven/pull/900#discussion_r1038946491
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.aether;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.ListIterator;
+import java.util.Objects;
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+/**
+ * A class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ *
+ * @since 3.9.0
+ */
+class ReverseTreeRepositoryListener extends AbstractRepositoryListener {
+@Override
+public void artifactResolved(RepositoryEvent event) {
+requireNonNull(event, "event cannot be null");
+
+if (!event.getArtifact()
+.getFile()
+.getPath()
+
.startsWith(event.getSession().getLocalRepository().getBasedir().getPath())) {
+return; // reactor artifact
Review Comment:
Could this condition be extracted to method IDK, `isReactorArtifact(event)`?
The comment then removed?
The method tested?
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] pzygielo commented on a diff in pull request #900: [MNG-7619] Reverse Dependency Tree
pzygielo commented on code in PR #900:
URL: https://github.com/apache/maven/pull/900#discussion_r1038946491
##
maven-core/src/main/java/org/apache/maven/internal/aether/ReverseTreeRepositoryListener.java:
##
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.internal.aether;
+
+import static java.util.Objects.requireNonNull;
+
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.nio.charset.StandardCharsets;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.ArrayList;
+import java.util.ListIterator;
+import java.util.Objects;
+import org.eclipse.aether.AbstractRepositoryListener;
+import org.eclipse.aether.RepositoryEvent;
+import org.eclipse.aether.RequestTrace;
+import org.eclipse.aether.artifact.Artifact;
+import org.eclipse.aether.collection.CollectStepData;
+import org.eclipse.aether.graph.Dependency;
+import org.eclipse.aether.graph.DependencyNode;
+
+/**
+ * A class building reverse tree using {@link CollectStepData} trace data
provided in {@link RepositoryEvent}
+ * events fired during collection.
+ *
+ * @since 3.9.0
+ */
+class ReverseTreeRepositoryListener extends AbstractRepositoryListener {
+@Override
+public void artifactResolved(RepositoryEvent event) {
+requireNonNull(event, "event cannot be null");
+
+if (!event.getArtifact()
+.getFile()
+.getPath()
+
.startsWith(event.getSession().getLocalRepository().getBasedir().getPath())) {
+return; // reactor artifact
Review Comment:
Could this condition be extracted to method IDK, `isReactorArtifact(event)`?
The comment then removed?
The method tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (DOXIA-569) Add Markdown Sink to be able to convert anything to Markdown
[ https://issues.apache.org/jira/browse/DOXIA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Herve Boutemy updated DOXIA-569: Fix Version/s: (was: wontfix-candidate) > Add Markdown Sink to be able to convert anything to Markdown > > > Key: DOXIA-569 > URL: https://issues.apache.org/jira/browse/DOXIA-569 > Project: Maven Doxia > Issue Type: New Feature > Components: Module - Markdown >Affects Versions: 1.8 >Reporter: Herve Boutemy >Priority: Major > Labels: intern > > Markdown is well known: having Markdown Sink would help people transform > existing content to Markdown -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (DOXIA-677) Macro for printing project properties
[
https://issues.apache.org/jira/browse/DOXIA-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642971#comment-17642971
]
Herve Boutemy edited comment on DOXIA-677 at 12/4/22 10:32 AM:
---
I don't really get what macro you want to introduce, that will do what
but FYI, I lately had a discussion with Mybatis Spring project who wanted
exactly that: easy {{${project.version}}} replacement in their site taht is
written in Markdown
I proposed an approach based on Velocity (= "replace {{##}} with {{#[[##]]#}},
{{###}} with {{#[[###]]#}}, ..." ) that they did not like, giving a very good
reason = "I prefer to use .md file instead of .vm file cannot render on GitHub
UI." (see https://github.com/mybatis/spring/pull/759 for full discussion)
then I proposed an approach using maven-resources-plugin to do the filtering:
https://github.com/mybatis/spring/pull/763
notice that the Velocity approach is already documented, even if (as usual)
it's not easy to find:
https://maven.apache.org/plugins/maven-site-plugin/examples/creating-content.html#common-issues-and-workarounds
was (Author: hboutemy):
I don't really get what macro you want to introduce, that will do what
but FYI, I lately had a discussion with Mybatis Spring project who wanted
exactly that: easy {{${project.version}}} replacement in their site
I proposed an approach based on Velocity (= "replace {{##}} with {{#[[##]]#}},
{{###}} with {{#[[###]]#}}, ..." ) that they did not like, giving a very good
reason = "I prefer to use .md file instead of .vm file cannot render on GitHub
UI." (see https://github.com/mybatis/spring/pull/759 for full discussion)
then I proposed an approach using maven-resources-plugin to do the filtering:
https://github.com/mybatis/spring/pull/763
notice that the Velocity approach is already documented, even if (as usual)
it's not easy to find:
https://maven.apache.org/plugins/maven-site-plugin/examples/creating-content.html#common-issues-and-workarounds
> Macro for printing project properties
> -
>
> Key: DOXIA-677
> URL: https://issues.apache.org/jira/browse/DOXIA-677
> Project: Maven Doxia
> Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Many time we use Velocity only for resolving project properties like:
> {code}
> ${project.version}
> {code}
> Another case is that for Markdown we have conflicts
> Velocity uses # as a prefix for macros and ## as a prefix for comments
> but in Markdown those are used for headers
> So Doxia macro will be useful is such cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (DOXIA-677) Macro for printing project properties
[
https://issues.apache.org/jira/browse/DOXIA-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642971#comment-17642971
]
Herve Boutemy edited comment on DOXIA-677 at 12/4/22 10:28 AM:
---
I don't really get what macro you want to introduce, that will do what
but FYI, I lately had a discussion with Mybatis Spring project who wanted
exactly that: easy {{${project.version}}} replacement in their site
I proposed an approach based on Velocity (= "replace {{##}} with {{#[[##]]#}},
{{###}} with {{#[[###]]#}}, ..." ) that they did not like, giving a very good
reason = "I prefer to use .md file instead of .vm file cannot render on GitHub
UI." (see https://github.com/mybatis/spring/pull/759 for full discussion)
then I proposed an approach using maven-resources-plugin to do the filtering:
https://github.com/mybatis/spring/pull/763
notice that the Velocity approach is already documented, even if (as usual)
it's not easy to find:
https://maven.apache.org/plugins/maven-site-plugin/examples/creating-content.html#common-issues-and-workarounds
was (Author: hboutemy):
I don't really get what macro you want to introduce, that will do what
but FYI, I lately had a discussion with Mybatis Spring project who wanted
exactly that: easy ${project.version} replacement in their site
I proposed an approach based on Velocity (= "replace ## with #[[##]]#, ### with
#[[###]]#, ..." ) that they did not like, giving a very good reason = "I prefer
to use .md file instead of .vm file cannot render on GitHub UI." (see
https://github.com/mybatis/spring/pull/759 for full discussion)
then I proposed an approach using maven-resources-plugin to do the filtering:
https://github.com/mybatis/spring/pull/763
notice that the Velocity approach is already documented, even if (as usual)
it's not easy to find:
https://maven.apache.org/plugins/maven-site-plugin/examples/creating-content.html#common-issues-and-workarounds
> Macro for printing project properties
> -
>
> Key: DOXIA-677
> URL: https://issues.apache.org/jira/browse/DOXIA-677
> Project: Maven Doxia
> Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Many time we use Velocity only for resolving project properties like:
> {code}
> ${project.version}
> {code}
> Another case is that for Markdown we have conflicts
> Velocity uses # as a prefix for macros and ## as a prefix for comments
> but in Markdown those are used for headers
> So Doxia macro will be useful is such cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-677) Macro for printing project properties
[
https://issues.apache.org/jira/browse/DOXIA-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642971#comment-17642971
]
Herve Boutemy commented on DOXIA-677:
-
I don't really get what macro you want to introduce, that will do what
but FYI, I lately had a discussion with Mybatis Spring project who wanted
exactly that: easy ${project.version} replacement in their site
I proposed an approach based on Velocity (= "replace ## with #[[##]]#, ### with
#[[###]]#, ..." ) that they did not like, giving a very good reason = "I prefer
to use .md file instead of .vm file cannot render on GitHub UI." (see
https://github.com/mybatis/spring/pull/759 for full discussion)
then I proposed an approach using maven-resources-plugin to do the filtering:
https://github.com/mybatis/spring/pull/763
notice that the Velocity approach is already documented, even if (as usual)
it's not easy to find:
https://maven.apache.org/plugins/maven-site-plugin/examples/creating-content.html#common-issues-and-workarounds
> Macro for printing project properties
> -
>
> Key: DOXIA-677
> URL: https://issues.apache.org/jira/browse/DOXIA-677
> Project: Maven Doxia
> Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Many time we use Velocity only for resolving project properties like:
> {code}
> ${project.version}
> {code}
> Another case is that for Markdown we have conflicts
> Velocity uses # as a prefix for macros and ## as a prefix for comments
> but in Markdown those are used for headers
> So Doxia macro will be useful is such cases.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642964#comment-17642964
]
ASF GitHub Bot commented on MNG-7619:
-
cstamas commented on PR #900:
URL: https://github.com/apache/maven/pull/900#issuecomment-1336366201
@laeubi while I agree with ideas you wrote, I am still for this PR to go in,
here is why:
This PR is (nearly) trivial, but gives you powerful tool (for investigation,
answering several questions), is registered early (earliest possible), and does
not prevent anything of those you wrote (a plugin). Moreover, by being earliest
present, and present during whole session of a real build, it covers
_everything_ (even some plugin that may dynamically resolve). Not easily done
with something like build extension or even plugin (they are all too late to
cover everything).
Also, none of these prevents anything of those things you wrote, this is
totally orthogonal. I personally see this like `-X`, a handy switch seldom used
by users, but when one needs it, is very very handy.
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas commented on pull request #900: [MNG-7619] Reverse Dependency Tree
cstamas commented on PR #900: URL: https://github.com/apache/maven/pull/900#issuecomment-1336366201 @laeubi while I agree with ideas you wrote, I am still for this PR to go in, here is why: This PR is (nearly) trivial, but gives you powerful tool (for investigation, answering several questions), is registered early (earliest possible), and does not prevent anything of those you wrote (a plugin). Moreover, by being earliest present, and present during whole session of a real build, it covers _everything_ (even some plugin that may dynamically resolve). Not easily done with something like build extension or even plugin (they are all too late to cover everything). Also, none of these prevents anything of those things you wrote, this is totally orthogonal. I personally see this like `-X`, a handy switch seldom used by users, but when one needs it, is very very handy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] sultan opened a new pull request, #901: fix version comparison
sultan opened a new pull request, #901: URL: https://github.com/apache/maven/pull/901 Following MNG-7559 Treat equally * 6.1m5 * 6.1m.5 * 6.1m-5 Display parameters as parsed by Maven (in canonical form and as a list of tokens) and comparison result: 1. 6.1m5 -> 6.1-milestone-5; tokens: [6, 1, [milestone, [5]]] 6.1m5 > 6.1m.5 2. 6.1m.5 -> 6.1-m.5; tokens: [6, 1, [m, 5]] 6.1m.5 > 6.1m-5 3. 6.1m-5 -> 6.1-m-5; tokens: [6, 1, [m, [5]]] --- Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPLUGIN-447) Update to Maven Parent POM 38
[ https://issues.apache.org/jira/browse/MPLUGIN-447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642963#comment-17642963 ] ASF GitHub Bot commented on MPLUGIN-447: slawekjaranowski commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336365886 > > @kwin look for duplicate License headers > > can help: > > ``` > > git grep -c "Licensed to the Apache Software Foundation" | grep -v ":1" > > ``` > > Thanks for the hint. Is there a configuration in spotless to remove those duplicates or do you have a script for that available as well? Seems that almost all files have duplicate license headers after the automated formatting… In IDE I copy old header and use options replace all. > Update to Maven Parent POM 38 > - > > Key: MPLUGIN-447 > URL: https://issues.apache.org/jira/browse/MPLUGIN-447 > Project: Maven Plugin Tools > Issue Type: Dependency upgrade >Reporter: Konrad Windszus >Priority: Major > Fix For: 3.8.0 > > > This also reformats source code, for details see MPOM-349 and > https://lists.apache.org/thread/14n13z4sh3twy5qgp5f487f1z0s5pc4s. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #181: [MPLUGIN-447] Update to Maven Parent POM 38
slawekjaranowski commented on PR #181: URL: https://github.com/apache/maven-plugin-tools/pull/181#issuecomment-1336365886 > > @kwin look for duplicate License headers > > can help: > > ``` > > git grep -c "Licensed to the Apache Software Foundation" | grep -v ":1" > > ``` > > Thanks for the hint. Is there a configuration in spotless to remove those duplicates or do you have a script for that available as well? Seems that almost all files have duplicate license headers after the automated formatting… In IDE I copy old header and use options replace all. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-2130) Rewrite several test classes in report plugin for upcoming Doxia 2.0.0 stack
[
https://issues.apache.org/jira/browse/SUREFIRE-2130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated SUREFIRE-2130:
Description:
https://github.com/apache/maven-surefire/tree/master/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report:
{{Surefire1183Test}}, {{Surefire597Test}}, {{SurefireReportMojoTest}} use too
much low level classes like concrete sinks, {{DecorationModel}},
{{SiteRenderingContext}}.
Some of these will change or be removed in Doxia 2.0.0. Approaches like in
MPIR, with a plugin specific abstract test class is required to do all the
hefty, and high level lifting without using Doxia innards. If this isn't done
already with Doxia 1.x these tests will not even compile with Doxia 2.0.0 and
need to be commented out/removed.
was:{{Surefire1183Test}}, {{Surefire597Test}}, {{SurefireReportMojoTest}} use
too much low level classes like concrete sinks, {{DecorationModel}},
{{SiteRenderingContext}}. Some of these will change or be removed in Doxia
2.0.0. Approaches like in MPIR, with a plugin specific abstract test class is
required to do all the hefty, and high level lifting without using Doxia
innards. If this isn't done already with Doxia 1.x these tests will not even
compile with Doxia 2.0.0 and need to be commented out/removed.
> Rewrite several test classes in report plugin for upcoming Doxia 2.0.0 stack
>
>
> Key: SUREFIRE-2130
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2130
> Project: Maven Surefire
> Issue Type: Task
> Components: Maven Surefire Report Plugin
>Affects Versions: 3.0.0-M7
>Reporter: Michael Osipov
>Priority: Blocker
>
> https://github.com/apache/maven-surefire/tree/master/maven-surefire-report-plugin/src/test/java/org/apache/maven/plugins/surefire/report:
> {{Surefire1183Test}}, {{Surefire597Test}}, {{SurefireReportMojoTest}} use
> too much low level classes like concrete sinks, {{DecorationModel}},
> {{SiteRenderingContext}}.
> Some of these will change or be removed in Doxia 2.0.0. Approaches like in
> MPIR, with a plugin specific abstract test class is required to do all the
> hefty, and high level lifting without using Doxia innards. If this isn't done
> already with Doxia 1.x these tests will not even compile with Doxia 2.0.0 and
> need to be commented out/removed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MSHADE-124) Need better plan for getting dependency-reduced-pom.xml out of basedir
[ https://issues.apache.org/jira/browse/MSHADE-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642951#comment-17642951 ] Alexander Kriegisch edited comment on MSHADE-124 at 12/4/22 8:05 AM: - [~gzm55], I am sorry if I am asking a naive question, but why would anyone use Shade and Assembly in the same module? In all situations I ever encountered, I would use either A or B, but not both. Is there an actual use case? Having said that, of course it is still great that you created a patch which covers even this corner case. 🙂 was (Author: kriegaex): [~gzm55], I am sorry if I am asking a naive question, but why would anyone use Shade and Assembly in the same module? In all situations I ever encountered, I would use either A or B, but not both. Is there an actual use case? > Need better plan for getting dependency-reduced-pom.xml out of basedir > -- > > Key: MSHADE-124 > URL: https://issues.apache.org/jira/browse/MSHADE-124 > Project: Maven Shade Plugin > Issue Type: Bug >Affects Versions: 1.7.1 >Reporter: Benson Margulies >Priority: Major > > MSHADE-123 reported that putting the d-r-p into some location other > than 'basedir' causes 'basedir' to follow it around, which can break builds. > This is hard to fix, given the core maven definition of basedir as 'the dir > containing the pom' with no option to change it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (MSHADE-124) Need better plan for getting dependency-reduced-pom.xml out of basedir
[ https://issues.apache.org/jira/browse/MSHADE-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642951#comment-17642951 ] Alexander Kriegisch edited comment on MSHADE-124 at 12/4/22 8:01 AM: - [~gzm55], I am sorry if I am asking a naive question, but why would anyone use Shade and Assembly in the same module? In all situations I ever encountered, I would use either A or B, but not both. Is there an actual use case? was (Author: kriegaex): I am sorry if I am asking a naive questions, but why would anyone use Shade and Assembly in the same module? In all situations I ever encountered, I would use either A or B, but not both. Is there an actual use case? > Need better plan for getting dependency-reduced-pom.xml out of basedir > -- > > Key: MSHADE-124 > URL: https://issues.apache.org/jira/browse/MSHADE-124 > Project: Maven Shade Plugin > Issue Type: Bug >Affects Versions: 1.7.1 >Reporter: Benson Margulies >Priority: Major > > MSHADE-123 reported that putting the d-r-p into some location other > than 'basedir' causes 'basedir' to follow it around, which can break builds. > This is hard to fix, given the core maven definition of basedir as 'the dir > containing the pom' with no option to change it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHADE-124) Need better plan for getting dependency-reduced-pom.xml out of basedir
[ https://issues.apache.org/jira/browse/MSHADE-124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17642951#comment-17642951 ] Alexander Kriegisch commented on MSHADE-124: I am sorry if I am asking a naive questions, but why would anyone use Shade and Assembly in the same module? In all situations I ever encountered, I would use either A or B, but not both. Is there an actual use case? > Need better plan for getting dependency-reduced-pom.xml out of basedir > -- > > Key: MSHADE-124 > URL: https://issues.apache.org/jira/browse/MSHADE-124 > Project: Maven Shade Plugin > Issue Type: Bug >Affects Versions: 1.7.1 >Reporter: Benson Margulies >Priority: Major > > MSHADE-123 reported that putting the d-r-p into some location other > than 'basedir' causes 'basedir' to follow it around, which can break builds. > This is hard to fix, given the core maven definition of basedir as 'the dir > containing the pom' with no option to change it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
