[GitHub] [maven-doxia] kwin commented on a diff in pull request #128: DOXIA-569 add Markdown output (sink)
kwin commented on code in PR #128:
URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1040615055
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownSink.java:
##
@@ -0,0 +1,1180 @@
+package org.apache.maven.doxia.module.markdown;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.io.PrintWriter;
+import java.io.Writer;
+import java.util.ArrayList;
+import java.util.List;
+import java.util.Stack;
+
+import org.apache.maven.doxia.sink.SinkEventAttributes;
+import org.apache.maven.doxia.sink.impl.AbstractTextSink;
+import org.apache.maven.doxia.sink.impl.SinkEventAttributeSet;
+import org.codehaus.plexus.util.StringUtils;
+
+/**
+ * Markdown generator implementation.
+ *
+ * Note: The encoding used is UTF-8.
+ */
+public class MarkdownSink
+extends AbstractTextSink
+implements MarkdownMarkup
+{
+// --
+// Instance fields
+// --
+
+/** A buffer that holds the current text when headerFlag or bufferFlag
set to true. */
+private StringBuffer buffer;
+
+/** A buffer that holds the table caption. */
+private StringBuilder tableCaptionBuffer;
+
+/** author. */
+private String author;
+
+/** title. */
+private String title;
+
+/** date. */
+private String date;
+
+/** startFlag. */
+private boolean startFlag;
+
+/** tableCaptionFlag. */
+private boolean tableCaptionFlag;
+
+/** tableCellFlag. */
+private boolean tableCellFlag;
+
+/** headerFlag. */
+private boolean headerFlag;
+
+/** bufferFlag. */
+private boolean bufferFlag;
+
+/** itemFlag. */
+private boolean itemFlag;
+
+/** verbatimFlag. */
+private boolean verbatimFlag;
+
+/** gridFlag for tables. */
+private boolean gridFlag;
+
+/** number of cells in a table. */
+private int cellCount;
+
+/** The writer to use. */
+private final PrintWriter writer;
+
+/** justification of table cells. */
+private int[] cellJustif;
+
+/** a line of a row in a table. */
+private String rowLine;
+
+/** listNestingIndent. */
+private String listNestingIndent;
+
+/** listStyles. */
+private final Stack listStyles;
+
+/** Keep track of the closing tags for inline events. */
+protected Stack> inlineStack = new Stack<>();
+
+// --
+// Public protected methods
+// --
+
+/**
+ * Constructor, initialize the Writer and the variables.
+ *
+ * @param writer not null writer to write the result. Should be an
UTF-8 Writer.
+ */
+protected MarkdownSink( Writer writer )
+{
+this.writer = new PrintWriter( writer );
+this.listStyles = new Stack<>();
+
+init();
+}
+
+/**
+ * Returns the buffer that holds the current text.
+ *
+ * @return A StringBuffer.
+ */
+protected StringBuffer getBuffer()
+{
+return buffer;
+}
+
+/**
+ * Used to determine whether we are in head mode.
+ *
+ * @param headFlag True for head mode.
+ */
+protected void setHeadFlag( boolean headFlag )
+{
+this.headerFlag = headFlag;
+}
+
+/**
+ * {@inheritDoc}
+ */
+protected void init()
+{
+super.init();
+
+resetBuffer();
+
+this.tableCaptionBuffer = new StringBuilder();
+this.listNestingIndent = "";
+
+this.author = null;
+this.title = null;
+this.date = null;
+this.startFlag = true;
+this.tableCaptionFlag = false;
+this.tableCellFlag = false;
+this.headerFlag = false;
+this.bufferFlag = false;
+this.itemFlag = false;
+this.verbatimFlag = false;
+this.gridFlag = false;
+this.cellCount = 0;
+this.cellJustif = null;
+this.rowLine = null;
+this.listStyles.clear();
+
[jira] [Commented] (DOXIA-569) Add Markdown Sink to be able to convert anything to Markdown
[
https://issues.apache.org/jira/browse/DOXIA-569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643705#comment-17643705
]
ASF GitHub Bot commented on DOXIA-569:
--
kwin commented on code in PR #128:
URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1040611824
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownMarkup.java:
##
@@ -0,0 +1,147 @@
+package org.apache.maven.doxia.module.markdown;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.doxia.markup.TextMarkup;
+import org.codehaus.plexus.util.StringUtils;
+
+/**
+ * This interface defines all markups and syntaxes used by the Markdown
format.
+ */
+@SuppressWarnings( "checkstyle:interfaceistype" )
+public interface MarkdownMarkup
+extends TextMarkup
+{
+// --
+// Markup separators
+// --
+
+/** APT backslash markup char: '\\' */
Review Comment:
why do we need APT constants in this class?
> Add Markdown Sink to be able to convert anything to Markdown
>
>
> Key: DOXIA-569
> URL: https://issues.apache.org/jira/browse/DOXIA-569
> Project: Maven Doxia
> Issue Type: New Feature
> Components: Module - Markdown
>Affects Versions: 1.8
>Reporter: Herve Boutemy
>Priority: Major
> Labels: intern
>
> Markdown is well known: having Markdown Sink would help people transform
> existing content to Markdown
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-doxia] kwin commented on a diff in pull request #128: DOXIA-569 add Markdown output (sink)
kwin commented on code in PR #128:
URL: https://github.com/apache/maven-doxia/pull/128#discussion_r1040611824
##
doxia-modules/doxia-module-markdown/src/main/java/org/apache/maven/doxia/module/markdown/MarkdownMarkup.java:
##
@@ -0,0 +1,147 @@
+package org.apache.maven.doxia.module.markdown;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import org.apache.maven.doxia.markup.TextMarkup;
+import org.codehaus.plexus.util.StringUtils;
+
+/**
+ * This interface defines all markups and syntaxes used by the Markdown
format.
+ */
+@SuppressWarnings( "checkstyle:interfaceistype" )
+public interface MarkdownMarkup
+extends TextMarkup
+{
+// --
+// Markup separators
+// --
+
+/** APT backslash markup char: '\\' */
Review Comment:
why do we need APT constants in this class?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [maven-wagon] dependabot[bot] opened a new pull request, #87: Bump commons-net from 3.6 to 3.9.0 in /wagon-providers/wagon-ftp
dependabot[bot] opened a new pull request, #87: URL: https://github.com/apache/maven-wagon/pull/87 Bumps commons-net from 3.6 to 3.9.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-wagon/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dependency-tree] dependabot[bot] opened a new pull request, #32: Bump commons-net from 3.2 to 3.9.0 in /src/it/reactor/module-y-deps-x
dependabot[bot] opened a new pull request, #32: URL: https://github.com/apache/maven-dependency-tree/pull/32 Bumps commons-net from 3.2 to 3.9.0. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/maven-dependency-tree/network/alerts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-site] dependabot[bot] opened a new pull request, #349: Bump maven-site-plugin from 4.0.0-M3 to 4.0.0-M4
dependabot[bot] opened a new pull request, #349: URL: https://github.com/apache/maven-site/pull/349 Bumps [maven-site-plugin](https://github.com/apache/maven-site-plugin) from 4.0.0-M3 to 4.0.0-M4. Commits https://github.com/apache/maven-site-plugin/commit/4d8ff445df743ad6e79f10ed2896803fc8537b9d;>4d8ff44 [maven-release-plugin] prepare release maven-site-plugin-4.0.0-M4 https://github.com/apache/maven-site-plugin/commit/eea479f137c841684c0fd594f5dd4022e2586f89;>eea479f [MSITE-917] Upgrade components and plugin in ITs https://github.com/apache/maven-site-plugin/commit/107785fd681f3f112cfe11fbaf817345eb183163;>107785f [MSITE-919] Upgrade Maven Reporting Exec to 2.0.0-M3 https://github.com/apache/maven-site-plugin/commit/94b8b161da3ca7a0bcf4617d6dd54d26b2d84027;>94b8b16 [MSITE-918] Upgrade Maven Reporting API to 4.0.0-M3 https://github.com/apache/maven-site-plugin/commit/c9b984bbd27c85a4f011f01b30ff7541ad6ca927;>c9b984b [MSITE-915] Upgrade Plexus Utils to 3.5.0 https://github.com/apache/maven-site-plugin/commit/32a7d0877e6ed0e4aae21a0a317529cf3cc4e860;>32a7d08 [MSITE-916] Upgrade Plexus Archiver to 4.6.0 https://github.com/apache/maven-site-plugin/commit/692ef875339dab92661c0c19bcb0703d33cf1892;>692ef87 [MSITE-913] Upgrade to Doxia/Doxia Sitetools to 2.0.0-M4 https://github.com/apache/maven-site-plugin/commit/867f8ebd884cf2c2463c1bf1eb906ac7a3aab2f6;>867f8eb [MSITE-914] SiteMojo never populates Doxia Sitetools Site Renderer supportedL... https://github.com/apache/maven-site-plugin/commit/0e1362fd6ac2f746f57914c37ab8e86b934e6412;>0e1362f [MSITE-912] Reporting plugins never executed if more than one locale is confi... https://github.com/apache/maven-site-plugin/commit/6d62d1dda7ad9d9c35f77dff8f8463e18839fcdc;>6d62d1d add Reproducible Builds badge Additional commits viewable in https://github.com/apache/maven-site-plugin/compare/maven-site-plugin-4.0.0-M3...maven-site-plugin-4.0.0-M4;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSHARED-480) Use maven-site-plugin's site.xml to use site's skin instead of default when run as mojo
[
https://issues.apache.org/jira/browse/MSHARED-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSHARED-480:
---
Summary: Use maven-site-plugin's site.xml to use site's skin instead of
default when run as mojo (was: use maven-site-plugin's site.xml to use site's
skin instead of default when run as mojo)
> Use maven-site-plugin's site.xml to use site's skin instead of default when
> run as mojo
> ---
>
> Key: MSHARED-480
> URL: https://issues.apache.org/jira/browse/MSHARED-480
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-impl
>Affects Versions: maven-reporting-impl 2.4
>Reporter: Herve Boutemy
>Assignee: Michael Osipov
>Priority: Minor
>
> currently, when a reporting mojo is not used as maven-site-plugin's report
> but as direct mojo invocation, maven-site-renderer default skin is always
> used: would be more consistent if using site decoration consistently with
> maven-site-plugin
> Or more precisely, I didn't currently find any reporting plugin that did the
> effort to mimic maven-site-plugin's decoration model/skin: every reporting
> plugin I know of uses features of {{maven-reporting-impl}} for site rendring
> (with this known limitation)
> implementing the feature in {{maven-reporting-impl}} will make it accessible
> to any reporting plugin once it upgrades it dependency version
> once done, we can activate skin resources copy, that was commented while
> working on MSHARED-120 (and would not give expected result if skin used is
> not consistent)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MSHARED-480) use maven-site-plugin's site.xml to use site's skin instead of default when run as mojo
[
https://issues.apache.org/jira/browse/MSHARED-480?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSHARED-480:
---
Issue Type: Improvement (was: Bug)
> use maven-site-plugin's site.xml to use site's skin instead of default when
> run as mojo
> ---
>
> Key: MSHARED-480
> URL: https://issues.apache.org/jira/browse/MSHARED-480
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-reporting-impl
>Affects Versions: maven-reporting-impl 2.4
>Reporter: Herve Boutemy
>Assignee: Michael Osipov
>Priority: Minor
>
> currently, when a reporting mojo is not used as maven-site-plugin's report
> but as direct mojo invocation, maven-site-renderer default skin is always
> used: would be more consistent if using site decoration consistently with
> maven-site-plugin
> Or more precisely, I didn't currently find any reporting plugin that did the
> effort to mimic maven-site-plugin's decoration model/skin: every reporting
> plugin I know of uses features of {{maven-reporting-impl}} for site rendring
> (with this known limitation)
> implementing the feature in {{maven-reporting-impl}} will make it accessible
> to any reporting plugin once it upgrades it dependency version
> once done, we can activate skin resources copy, that was commented while
> working on MSHARED-120 (and would not give expected result if skin used is
> not consistent)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-resolver] cstamas opened a new pull request, #226: Alternate transform API
cstamas opened a new pull request, #226: URL: https://github.com/apache/maven-resolver/pull/226 Is WIP, just some ideas... Alternate transformation API, that is: - logically simpler, as it ALWAYS get applied (unlike branching like FileTransformer) - by default just uses "identity" transformation - can inhibit (prevent), replace, or even "decorate" (add more) artifacts for single transformation - caller is completely oblivious about what is happening - distinguishes install and deploy ops Heretic thought: - one of the FIRST thought for artifact transformation (aside of consumer POM transformation) is SIGNING :) as resolver could symetrically support signing (with pluggable signers) just like it supports checksumming -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPOM-376) Spotless importOrder should be taken into consideration
[ https://issues.apache.org/jira/browse/MPOM-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MPOM-376. Resolution: Fixed > Spotless importOrder should be taken into consideration > --- > > Key: MPOM-376 > URL: https://issues.apache.org/jira/browse/MPOM-376 > Project: Maven POMs > Issue Type: Bug > Components: maven >Affects Versions: MAVEN-38 >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: MAVEN-39 > > > Configuration items in spotless should be in correct order. > Currently importOrder is not taken into consideration > So imports are sorted in wrong way, not corresponding to configuration. > https://github.com/diffplug/spotless/issues/1417 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPOM-376) Spotless importOrder should be taken into consideration
[ https://issues.apache.org/jira/browse/MPOM-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643556#comment-17643556 ] Hudson commented on MPOM-376: - Build succeeded in Jenkins: Maven » Maven TLP » maven-parent » master #71 See https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/71/ > Spotless importOrder should be taken into consideration > --- > > Key: MPOM-376 > URL: https://issues.apache.org/jira/browse/MPOM-376 > Project: Maven POMs > Issue Type: Bug > Components: maven >Affects Versions: MAVEN-38 >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: MAVEN-39 > > > Configuration items in spotless should be in correct order. > Currently importOrder is not taken into consideration > So imports are sorted in wrong way, not corresponding to configuration. > https://github.com/diffplug/spotless/issues/1417 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-parent] slawekjaranowski merged pull request #97: [MPOM-376] Spotless importOrder should be taken into consideration
slawekjaranowski merged PR #97: URL: https://github.com/apache/maven-parent/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSHADE-435) Add parameter to ignore project artifact for excludes filtering
Marcono1234 created MSHADE-435:
--
Summary: Add parameter to ignore project artifact for excludes
filtering
Key: MSHADE-435
URL: https://issues.apache.org/jira/browse/MSHADE-435
Project: Maven Shade Plugin
Issue Type: New Feature
Affects Versions: 3.4.1
Reporter: Marcono1234
h3. The problem
When specifying wildcard {{exclude}} filters with {{*:*}}
it is often desired to only remove the classes and resources from dependencies,
but not from the artifact of the project which is currently built.
Examples for this are {{module-info.class}} files (see MSHADE-300), and more
recently due to MSHADE-306 all kind of common resource files, e.g.
{{META-INF/MANIFEST.MF}} (for non OSGi projects), {{META-INF/NOTICE}}, ...
See also [this recent Stack Overflow
question|https://stackoverflow.com/q/64110058].
Unfortunately it is not easily possible at the moment to remove the files from
dependencies only, but to keep the project resources (without a warning from
the shade plugin) because filters always apply to the project artifact too, so
you would end up excluding for example your own {{MANIFEST.MF}} file as well.
According to the
[documentation|https://maven.apache.org/plugins/maven-shade-plugin/shade-mojo.html#filters]
it is also not possible to specify some kind of "keep" filter which
counteracts the wildcard exclude filter because inclusions are always evaluated
before exclusions.
h3. Possible solution
One possible solution would be to add a new {{considerProjectArtifact}}
parameter or similar with default value {{true}} for {{filter}} elements. When
set to {{false}} the files from the project artifact are not considered.
This is mainly from the perspective of exclusions, not sure how
{{considerProjectArtifact}} should behave for inclusions.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-surefire] dependabot[bot] opened a new pull request, #580: Bump javassist from 3.29.0-GA to 3.29.2-GA
dependabot[bot] opened a new pull request, #580: URL: https://github.com/apache/maven-surefire/pull/580 Bumps [javassist](https://github.com/jboss-javassist/javassist) from 3.29.0-GA to 3.29.2-GA. Release notes Sourced from https://github.com/jboss-javassist/javassist/releases;>javassist's releases. Javassist 3.29.2-GA This release is a maintenance update. It includes a fix for GitHub Issue https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/427;>jboss-javassist/javassist#427. Javassist 3.29.1-GA This release is a maintenance update. It includes a fix for GitHub Issue https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/423;>#423. Changelog Sourced from https://github.com/jboss-javassist/javassist/blob/master/Changes.md;>javassist's changelog. Changes version 3.29.2 on September 14, 2022 GitHub Issue https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/427;>#427. version 3.29.1 on August 11, 2022 GitHub Issue https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/423;>#423. Readme.html was deleted (GitHub Issue https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/414;>#414). version 3.29 on May 13, 2022 GitHub Issue https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/378;>#378, PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/278;>#278, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/299;>#299, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/382;>#382, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/383;>#383, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/390;>#390, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/391;>#391, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/395;>#395, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/399;>#399, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/409;>#409. version 3.28 on May 8, 2021 GitHub Issue https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/305;>#305, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/328;>#328, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/339;>#339, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/350;>#350, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/357;>#357, and PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/363;>#363. version 3.27 on March 19, 2020 GitHub Issue https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/271;>#271 (PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/279;>#279), https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/280;>#280 (PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/281;>#281), https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/282;>#282, and PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/294;>#294. version 3.26 on October 3, 2019 GitHub Issue https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/270;>#270 (PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/272;>#272), https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/265;>#265 (PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/267;>#267), https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/271;>#271, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/222;>#222, and https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/275;>#275. version 3.25 on April 16, 2019 GitHub Issue https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/72;>#72 (PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/231;>#231), https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/241;>#241, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/242;>#242 (PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/243;>#243), PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/244;>#244, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/246;>#246 (PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/247;>#247), PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/250;>#250, https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/252;>#252 (PR https://github-redirect.dependabot.com/jboss-javassist/javassist/issues/253;>#253), PR
[GitHub] [maven-parent] kwin commented on a diff in pull request #97: [MPOM-376] Spotless importOrder should be taken into consideration
kwin commented on code in PR #97: URL: https://github.com/apache/maven-parent/pull/97#discussion_r1039945219 ## pom.xml: ## @@ -1166,11 +1166,11 @@ under the License. 2.27.1 + Review Comment: A comment why the order is important and a reference to the ticket would be useful here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MPOM-376) Spotless importOrder should be taken into consideration
[ https://issues.apache.org/jira/browse/MPOM-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MPOM-376: Assignee: Slawomir Jaranowski > Spotless importOrder should be taken into consideration > --- > > Key: MPOM-376 > URL: https://issues.apache.org/jira/browse/MPOM-376 > Project: Maven POMs > Issue Type: Bug > Components: maven >Affects Versions: MAVEN-38 >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > > Configuration items in spotless should be in correct order. > Currently importOrder is not taken into consideration > So imports are sorted in wrong way, not corresponding to configuration. > https://github.com/diffplug/spotless/issues/1417 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPOM-376) Spotless importOrder should be taken into consideration
[ https://issues.apache.org/jira/browse/MPOM-376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MPOM-376: - Fix Version/s: MAVEN-39 > Spotless importOrder should be taken into consideration > --- > > Key: MPOM-376 > URL: https://issues.apache.org/jira/browse/MPOM-376 > Project: Maven POMs > Issue Type: Bug > Components: maven >Affects Versions: MAVEN-38 >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: MAVEN-39 > > > Configuration items in spotless should be in correct order. > Currently importOrder is not taken into consideration > So imports are sorted in wrong way, not corresponding to configuration. > https://github.com/diffplug/spotless/issues/1417 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-parent] slawekjaranowski opened a new pull request, #97: [MPOM-376] Spotless importOrder should be taken into consideration
slawekjaranowski opened a new pull request, #97: URL: https://github.com/apache/maven-parent/pull/97 Spotless formatters must be placed in correct order in configuration -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-7568) [WARNING] The requested profile "ABCDEF" could not be activated because it does not exist.
[
https://issues.apache.org/jira/browse/MNG-7568?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MNG-7568.
> [WARNING] The requested profile "ABCDEF" could not be activated because it
> does not exist.
> --
>
> Key: MNG-7568
> URL: https://issues.apache.org/jira/browse/MNG-7568
> Project: Maven
> Issue Type: Bug
> Components: Core, Profiles
>Affects Versions: 3.8.1, 3.8.6
>Reporter: Piotr Zygielo
>Assignee: Martin Kanters
>Priority: Major
> Fix For: 3.8.x-candidate, 3.9.0
>
>
> WARNING comes at end of build log if profile is defined in settings.xml (it
> definitely does exist) and even more, I am deactivating it, not activating...
> {code:bash}
> mvn -P!ABCDEF clean test
> {code}
> in fact, profile is deactivated during build so everything goes as expected,
> except misleading message
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7576) Restore compatibility with maven 3
[
https://issues.apache.org/jira/browse/MNG-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643458#comment-17643458
]
Hudson commented on MNG-7576:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #150
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/150/
> Restore compatibility with maven 3
> --
>
> Key: MNG-7576
> URL: https://issues.apache.org/jira/browse/MNG-7576
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {{MavenBuildTimestamp}}
> https://github.com/apache/maven/commit/18eff3baeb899ddd27b34635c8f0d7e47f5c027b
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7618) Use goalPrefix instead of artifactId to display mojos being executed
[
https://issues.apache.org/jira/browse/MNG-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643444#comment-17643444
]
Hudson commented on MNG-7618:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #149
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/149/
> Use goalPrefix instead of artifactId to display mojos being executed
> -
>
> Key: MNG-7618
> URL: https://issues.apache.org/jira/browse/MNG-7618
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> The main problem is that the information displayed when starting a mojo looks
> like:
> {code:java}
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-maven-version) @
> camel ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-java-version) @ camel
> ---
> [INFO]
> {code}
> However, if you try to execute {{{}maven-enforcer-plugin:3.0.0:enforce{}}},
> you end up with the following:
> {code:java}
> [INFO] BuildTimeEventSpy is registered.
> [INFO] Scanning for projects...
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/maven-enforcer-plugin/3.0.0/maven-metadata.xml
> Downloading from central:
> https://repo.maven.apache.org/maven2/maven-enforcer-plugin/3.0.0/maven-metadata.xml
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.879 s
> [INFO] Finished at: 2022-12-03T12:12:40+01:00
> [INFO]
>
> [ERROR] Error resolving version for plugin 'maven-enforcer-plugin:3.0.0' from
> the repositories [local (/Users/gnodet/.m2/repository), apache.snapshots
> (https://repository.apache.org/snapshots/), central
> (https://repo.maven.apache.org/maven2)]: Plugin not found in any plugin
> repository -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginVersionResolutionException
> {code}
>
> I suggest to change the display to the {{pluginPrefix}} which gives
> {code}
> [INFO] ---< org.apache.camel:camel
> >---
> [INFO] Building Camel 4.0.0-SNAPSHOT
> [INFO] from pom.xml
> [INFO] [ pom
> ]-
> [WARN] Parameter 'reportPlugins' is unknown for plugin
> 'maven-site-plugin:3.11.0:attach-descriptor (attach-descriptor)'
> [INFO]
> [INFO] --- enforcer:3.0.0:enforce (enforce-maven-version) @ camel ---
> [INFO]
> [INFO] --- enforcer:3.0.0:enforce (enforce-java-version) @ camel ---
> [INFO]
> [INFO] --- enforcer:3.0.0:enforce (enforce-maven) @ camel ---
> [INFO]
> {code}
> which can then be easily executed:
> {code}
> ➜ maven git:(build-improvements) ✗ mvn -N -f ../camel flatten:1.2.5:flatten
> [INFO] BuildTimeEventSpy is registered.
> [INFO] Processing build on daemon 56c20cb8
> [INFO] Scanning for projects...
> [INFO] BuildTimeEventSpy is registered.
> [INFO]
> [INFO] Using the SmartBuilder implementation with a thread count of 9
> [INFO] Task segments : [flatten:1.2.5:flatten]
> [INFO] Build maximum degree of concurrency is 9
> [INFO] Total number of projects is 1
> [INFO]
> [INFO] ---< org.apache.camel:camel
> >---
> [INFO] Building Camel 4.0.0-SNAPSHOT
> [INFO] from pom.xml
> [INFO] [ pom
> ]-
> [INFO]
> [INFO] --- flatten:1.2.5:flatten (default-cli) @ camel ---
> [INFO] Generating flattened POM of project
> org.apache.camel:camel:pom:4.0.0-SNAPSHOT...
> [INFO] Segment walltime 0 s, segment projects service time 0 s,
> effective/maximum degree of concurrency 0.97/9
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 0.025 s (Wall Clock)
> [INFO] Finished at: 2022-12-03T12:14:29+01:00
> [INFO]
>
> ➜ maven git:(build-improvements) ✗
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7576) Restore compatibility with maven 3
[
https://issues.apache.org/jira/browse/MNG-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643442#comment-17643442
]
ASF GitHub Bot commented on MNG-7576:
-
gnodet merged PR #903:
URL: https://github.com/apache/maven/pull/903
> Restore compatibility with maven 3
> --
>
> Key: MNG-7576
> URL: https://issues.apache.org/jira/browse/MNG-7576
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {{MavenBuildTimestamp}}
> https://github.com/apache/maven/commit/18eff3baeb899ddd27b34635c8f0d7e47f5c027b
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet merged pull request #903: [MNG-7576] Restore compatibility for flatten-maven-plugin
gnodet merged PR #903: URL: https://github.com/apache/maven/pull/903 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7576) Restore compatibility with maven 3
[
https://issues.apache.org/jira/browse/MNG-7576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643428#comment-17643428
]
ASF GitHub Bot commented on MNG-7576:
-
gnodet opened a new pull request, #903:
URL: https://github.com/apache/maven/pull/903
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MNG) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you
replace `MNG-XXX`
and `SUMMARY` with the appropriate JIRA issue. Best practice is to
use the JIRA issue
title in the pull request title and in the first line of the commit
message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the [Core IT][core-its] successfully.
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
[core-its]: https://maven.apache.org/core-its/core-it-suite/
> Restore compatibility with maven 3
> --
>
> Key: MNG-7576
> URL: https://issues.apache.org/jira/browse/MNG-7576
> Project: Maven
> Issue Type: Task
>Affects Versions: 4.0.0-alpha-2
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> {{MavenBuildTimestamp}}
> https://github.com/apache/maven/commit/18eff3baeb899ddd27b34635c8f0d7e47f5c027b
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet opened a new pull request, #903: [MNG-7576] Restore compatibility for flatten-maven-plugin
gnodet opened a new pull request, #903: URL: https://github.com/apache/maven/pull/903 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643427#comment-17643427
]
Hudson commented on MNG-7619:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #148
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/148/
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643423#comment-17643423
]
Hudson commented on MNG-7619:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » maven-3.9.x #96
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/maven-3.9.x/96/
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-6609) Profile activation by packaging
[ https://issues.apache.org/jira/browse/MNG-6609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed MNG-6609. --- > Profile activation by packaging > > > Key: MNG-6609 > URL: https://issues.apache.org/jira/browse/MNG-6609 > Project: Maven > Issue Type: Improvement > Components: Profiles >Affects Versions: 3.6.0 >Reporter: Konrad Windszus >Assignee: Konrad Windszus >Priority: Major > Fix For: 3.9.0, 4.0.0, 4.0.0-alpha-3 > > > Due to the lack of mixins, it is common that modules which use different > packagings share the same parent pom. As those often use different > dependencies/plugins, it would be nice to have profiles which are activated > based on the packaging of a module. That is currently not possible. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven-integration-testing] gnodet merged pull request #217: [MNG-7618] Fix display for plugins
gnodet merged PR #217: URL: https://github.com/apache/maven-integration-testing/pull/217 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-7618) Use goalPrefix instead of artifactId to display mojos being executed
[
https://issues.apache.org/jira/browse/MNG-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-7618.
Resolution: Fixed
> Use goalPrefix instead of artifactId to display mojos being executed
> -
>
> Key: MNG-7618
> URL: https://issues.apache.org/jira/browse/MNG-7618
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> The main problem is that the information displayed when starting a mojo looks
> like:
> {code:java}
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-maven-version) @
> camel ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-java-version) @ camel
> ---
> [INFO]
> {code}
> However, if you try to execute {{{}maven-enforcer-plugin:3.0.0:enforce{}}},
> you end up with the following:
> {code:java}
> [INFO] BuildTimeEventSpy is registered.
> [INFO] Scanning for projects...
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/maven-enforcer-plugin/3.0.0/maven-metadata.xml
> Downloading from central:
> https://repo.maven.apache.org/maven2/maven-enforcer-plugin/3.0.0/maven-metadata.xml
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.879 s
> [INFO] Finished at: 2022-12-03T12:12:40+01:00
> [INFO]
>
> [ERROR] Error resolving version for plugin 'maven-enforcer-plugin:3.0.0' from
> the repositories [local (/Users/gnodet/.m2/repository), apache.snapshots
> (https://repository.apache.org/snapshots/), central
> (https://repo.maven.apache.org/maven2)]: Plugin not found in any plugin
> repository -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginVersionResolutionException
> {code}
>
> I suggest to change the display to the {{pluginPrefix}} which gives
> {code}
> [INFO] ---< org.apache.camel:camel
> >---
> [INFO] Building Camel 4.0.0-SNAPSHOT
> [INFO] from pom.xml
> [INFO] [ pom
> ]-
> [WARN] Parameter 'reportPlugins' is unknown for plugin
> 'maven-site-plugin:3.11.0:attach-descriptor (attach-descriptor)'
> [INFO]
> [INFO] --- enforcer:3.0.0:enforce (enforce-maven-version) @ camel ---
> [INFO]
> [INFO] --- enforcer:3.0.0:enforce (enforce-java-version) @ camel ---
> [INFO]
> [INFO] --- enforcer:3.0.0:enforce (enforce-maven) @ camel ---
> [INFO]
> {code}
> which can then be easily executed:
> {code}
> ➜ maven git:(build-improvements) ✗ mvn -N -f ../camel flatten:1.2.5:flatten
> [INFO] BuildTimeEventSpy is registered.
> [INFO] Processing build on daemon 56c20cb8
> [INFO] Scanning for projects...
> [INFO] BuildTimeEventSpy is registered.
> [INFO]
> [INFO] Using the SmartBuilder implementation with a thread count of 9
> [INFO] Task segments : [flatten:1.2.5:flatten]
> [INFO] Build maximum degree of concurrency is 9
> [INFO] Total number of projects is 1
> [INFO]
> [INFO] ---< org.apache.camel:camel
> >---
> [INFO] Building Camel 4.0.0-SNAPSHOT
> [INFO] from pom.xml
> [INFO] [ pom
> ]-
> [INFO]
> [INFO] --- flatten:1.2.5:flatten (default-cli) @ camel ---
> [INFO] Generating flattened POM of project
> org.apache.camel:camel:pom:4.0.0-SNAPSHOT...
> [INFO] Segment walltime 0 s, segment projects service time 0 s,
> effective/maximum degree of concurrency 0.97/9
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 0.025 s (Wall Clock)
> [INFO] Finished at: 2022-12-03T12:14:29+01:00
> [INFO]
>
> ➜ maven git:(build-improvements) ✗
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7618) Use goalPrefix instead of artifactId to display mojos being executed
[
https://issues.apache.org/jira/browse/MNG-7618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643421#comment-17643421
]
ASF GitHub Bot commented on MNG-7618:
-
gnodet merged PR #898:
URL: https://github.com/apache/maven/pull/898
> Use goalPrefix instead of artifactId to display mojos being executed
> -
>
> Key: MNG-7618
> URL: https://issues.apache.org/jira/browse/MNG-7618
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0-alpha-3
>
>
> The main problem is that the information displayed when starting a mojo looks
> like:
> {code:java}
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-maven-version) @
> camel ---
> [INFO]
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (enforce-java-version) @ camel
> ---
> [INFO]
> {code}
> However, if you try to execute {{{}maven-enforcer-plugin:3.0.0:enforce{}}},
> you end up with the following:
> {code:java}
> [INFO] BuildTimeEventSpy is registered.
> [INFO] Scanning for projects...
> Downloading from apache.snapshots:
> https://repository.apache.org/snapshots/maven-enforcer-plugin/3.0.0/maven-metadata.xml
> Downloading from central:
> https://repo.maven.apache.org/maven2/maven-enforcer-plugin/3.0.0/maven-metadata.xml
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.879 s
> [INFO] Finished at: 2022-12-03T12:12:40+01:00
> [INFO]
>
> [ERROR] Error resolving version for plugin 'maven-enforcer-plugin:3.0.0' from
> the repositories [local (/Users/gnodet/.m2/repository), apache.snapshots
> (https://repository.apache.org/snapshots/), central
> (https://repo.maven.apache.org/maven2)]: Plugin not found in any plugin
> repository -> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/PluginVersionResolutionException
> {code}
>
> I suggest to change the display to the {{pluginPrefix}} which gives
> {code}
> [INFO] ---< org.apache.camel:camel
> >---
> [INFO] Building Camel 4.0.0-SNAPSHOT
> [INFO] from pom.xml
> [INFO] [ pom
> ]-
> [WARN] Parameter 'reportPlugins' is unknown for plugin
> 'maven-site-plugin:3.11.0:attach-descriptor (attach-descriptor)'
> [INFO]
> [INFO] --- enforcer:3.0.0:enforce (enforce-maven-version) @ camel ---
> [INFO]
> [INFO] --- enforcer:3.0.0:enforce (enforce-java-version) @ camel ---
> [INFO]
> [INFO] --- enforcer:3.0.0:enforce (enforce-maven) @ camel ---
> [INFO]
> {code}
> which can then be easily executed:
> {code}
> ➜ maven git:(build-improvements) ✗ mvn -N -f ../camel flatten:1.2.5:flatten
> [INFO] BuildTimeEventSpy is registered.
> [INFO] Processing build on daemon 56c20cb8
> [INFO] Scanning for projects...
> [INFO] BuildTimeEventSpy is registered.
> [INFO]
> [INFO] Using the SmartBuilder implementation with a thread count of 9
> [INFO] Task segments : [flatten:1.2.5:flatten]
> [INFO] Build maximum degree of concurrency is 9
> [INFO] Total number of projects is 1
> [INFO]
> [INFO] ---< org.apache.camel:camel
> >---
> [INFO] Building Camel 4.0.0-SNAPSHOT
> [INFO] from pom.xml
> [INFO] [ pom
> ]-
> [INFO]
> [INFO] --- flatten:1.2.5:flatten (default-cli) @ camel ---
> [INFO] Generating flattened POM of project
> org.apache.camel:camel:pom:4.0.0-SNAPSHOT...
> [INFO] Segment walltime 0 s, segment projects service time 0 s,
> effective/maximum degree of concurrency 0.97/9
> [INFO]
>
> [INFO] BUILD SUCCESS
> [INFO]
>
> [INFO] Total time: 0.025 s (Wall Clock)
> [INFO] Finished at: 2022-12-03T12:14:29+01:00
> [INFO]
>
> ➜ maven git:(build-improvements) ✗
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] gnodet merged pull request #898: [MNG-7618] Use goalPrefix instead of artifactId to display mojos being executed
gnodet merged PR #898: URL: https://github.com/apache/maven/pull/898 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak reassigned MNG-7619:
Assignee: Tamas Cservenak
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Assignee: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tamas Cservenak closed MNG-7619.
Resolution: Fixed
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643402#comment-17643402
]
ASF GitHub Bot commented on MNG-7619:
-
cstamas merged PR #900:
URL: https://github.com/apache/maven/pull/900
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7619) Maven should explain why an artifact is present in local repository
[
https://issues.apache.org/jira/browse/MNG-7619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643403#comment-17643403
]
ASF GitHub Bot commented on MNG-7619:
-
cstamas merged PR #902:
URL: https://github.com/apache/maven/pull/902
> Maven should explain why an artifact is present in local repository
> ---
>
> Key: MNG-7619
> URL: https://issues.apache.org/jira/browse/MNG-7619
> Project: Maven
> Issue Type: Improvement
> Components: Dependencies
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 3.9.0, 4.0.x-candidate, 4.0.0-alpha-3
>
>
> Ability to make Maven record:
> * why given artifact is present in local repository
> * record reverse dep tree how this artifact got resolved
> This is mostly for detecting dependency resolution anomalies, ideally best
> combined with {{-Dmaven.repo.local}} when you use new/empty local repo to
> build a project. After the build, you will end up with reverse dep trees in
> {{.tracking}} directories for each artifact.
> To enable, pass {{-Dmaven.repo.local.recordReverseTree}} on CLI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] cstamas merged pull request #902: [MNG-7619] Reverse Dependency Tree
cstamas merged PR #902: URL: https://github.com/apache/maven/pull/902 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] cstamas merged pull request #900: [MNG-7619] Reverse Dependency Tree
cstamas merged PR #900: URL: https://github.com/apache/maven/pull/900 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNGSITE-501) Clarify JDK activation element
[
https://issues.apache.org/jira/browse/MNGSITE-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus closed MNGSITE-501.
---
> Clarify JDK activation element
> --
>
> Key: MNGSITE-501
> URL: https://issues.apache.org/jira/browse/MNGSITE-501
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Both in [https://maven.apache.org/pom.html#Activation] and
> [https://maven.apache.org/guides/introduction/introduction-to-profiles.html#details-on-profile-activation]
> the {{jdk}} element needs clarification that not all values are interpreted
> as ranges (in contrast to what the referenced version range specification
> from enforcer maven plugin in
> [https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html] says).
> Actually there are three different kind of values supported:
> # Version ranges (if the value starts with either "[" or "(")
> # A negated prefix (if the value starts with "!")
> # A (non-negated) prefix for all other cases
> This can be seen in
> [https://github.com/apache/maven/blob/001eef8452b38110a2557446aa81b8fb1ff35f92/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivator.java#L69]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MNGSITE-501) Clarify JDK activation element
[
https://issues.apache.org/jira/browse/MNGSITE-501?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved MNGSITE-501.
-
Resolution: Fixed
> Clarify JDK activation element
> --
>
> Key: MNGSITE-501
> URL: https://issues.apache.org/jira/browse/MNGSITE-501
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Both in [https://maven.apache.org/pom.html#Activation] and
> [https://maven.apache.org/guides/introduction/introduction-to-profiles.html#details-on-profile-activation]
> the {{jdk}} element needs clarification that not all values are interpreted
> as ranges (in contrast to what the referenced version range specification
> from enforcer maven plugin in
> [https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html] says).
> Actually there are three different kind of values supported:
> # Version ranges (if the value starts with either "[" or "(")
> # A negated prefix (if the value starts with "!")
> # A (non-negated) prefix for all other cases
> This can be seen in
> [https://github.com/apache/maven/blob/001eef8452b38110a2557446aa81b8fb1ff35f92/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivator.java#L69]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPOM-375) Add license header automatically to all files
[
https://issues.apache.org/jira/browse/MPOM-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MPOM-375:
-
Description:
Currently license headers are only added to some java files. One should
leverage option
https://github.com/diffplug/spotless/tree/main/plugin-maven#license-header to
add/modify it in all files (also to always properly reflect the year of the
last modification).
Also e.g. Java files within {{src/test/resources}} are currently not considered
with regards to license file.
This is currently blocked though by
https://github.com/diffplug/spotless/issues/1418.
was:
Currently license headers are only added to java files. One should leverage
option
https://github.com/diffplug/spotless/tree/main/plugin-maven#license-header to
add/modify it in all files (also to always properly reflect the year of the
last modification).
Also e.g. Java files within {{src/test/resources}} are currently not considered
with regards to license file.
This is currently blocked though by
https://github.com/diffplug/spotless/issues/1418.
> Add license header automatically to all files
> -
>
> Key: MPOM-375
> URL: https://issues.apache.org/jira/browse/MPOM-375
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Affects Versions: MAVEN-38
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently license headers are only added to some java files. One should
> leverage option
> https://github.com/diffplug/spotless/tree/main/plugin-maven#license-header to
> add/modify it in all files (also to always properly reflect the year of the
> last modification).
> Also e.g. Java files within {{src/test/resources}} are currently not
> considered with regards to license file.
> This is currently blocked though by
> https://github.com/diffplug/spotless/issues/1418.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPOM-375) Add license header automatically to all files
[
https://issues.apache.org/jira/browse/MPOM-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MPOM-375:
-
Description:
Currently license headers are only added to java files. One should leverage
option
https://github.com/diffplug/spotless/tree/main/plugin-maven#license-header to
add/modify it in all files (also to always properly reflect the year of the
last modification).
Also e.g. Java files within {{src/test/resources}} are currently not considered
with regards to license file.
This is currently blocked though by
https://github.com/diffplug/spotless/issues/1418.
was:
Currently license headers are only added to java files. One should leverage
option
https://github.com/diffplug/spotless/tree/main/plugin-maven#license-header to
add/modify it in all files (also to always properly reflect the year of the
last modification).
Also e.g. Java files within {{src/test/resources}} are currently not considered
with regards to license file.
> Add license header automatically to all files
> -
>
> Key: MPOM-375
> URL: https://issues.apache.org/jira/browse/MPOM-375
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Affects Versions: MAVEN-38
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently license headers are only added to java files. One should leverage
> option
> https://github.com/diffplug/spotless/tree/main/plugin-maven#license-header to
> add/modify it in all files (also to always properly reflect the year of the
> last modification).
> Also e.g. Java files within {{src/test/resources}} are currently not
> considered with regards to license file.
> This is currently blocked though by
> https://github.com/diffplug/spotless/issues/1418.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPOM-376) Spotless importOrder should be taken into consideration
[
https://issues.apache.org/jira/browse/MPOM-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643346#comment-17643346
]
Konrad Windszus commented on MPOM-376:
--
This is because palantir also defines an import order
(https://google.github.io/styleguide/javaguide.html#s3.3.3-import-ordering-and-spacing)
and as it is applied afterwards overwrites the one established by
{{importOrder}}.
> Spotless importOrder should be taken into consideration
> ---
>
> Key: MPOM-376
> URL: https://issues.apache.org/jira/browse/MPOM-376
> Project: Maven POMs
> Issue Type: Bug
> Components: maven
>Affects Versions: MAVEN-38
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> Configuration items in spotless should be in correct order.
> Currently importOrder is not taken into consideration
> So imports are sorted in wrong way, not corresponding to configuration.
> https://github.com/diffplug/spotless/issues/1417
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MPOM-373) Execute spotless before rat
[
https://issues.apache.org/jira/browse/MPOM-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus closed MPOM-373.
> Execute spotless before rat
> ---
>
> Key: MPOM-373
> URL: https://issues.apache.org/jira/browse/MPOM-373
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Affects Versions: MAVEN-38
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: MAVEN-39
>
>
> {{apache-rat-plugin:check}} should be executed after a reformatting with
> {{spotless-maven-plugin:apply}}. Currently the latter is executed in phase
> {{process-sourcess}} while the former is executed in {{validate}}
> (https://github.com/apache/creadur-rat/blob/acc6141d3bfbea4c1811604fa5668b1572e85898/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java#L48).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MPOM-373) Execute spotless before rat
[
https://issues.apache.org/jira/browse/MPOM-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned MPOM-373:
Assignee: Konrad Windszus
> Execute spotless before rat
> ---
>
> Key: MPOM-373
> URL: https://issues.apache.org/jira/browse/MPOM-373
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Affects Versions: MAVEN-38
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: MAVEN-39
>
>
> {{apache-rat-plugin:check}} should be executed after a reformatting with
> {{spotless-maven-plugin:apply}}. Currently the latter is executed in phase
> {{process-sourcess}} while the former is executed in {{validate}}
> (https://github.com/apache/creadur-rat/blob/acc6141d3bfbea4c1811604fa5668b1572e85898/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java#L48).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPOM-373) Execute spotless before rat
[
https://issues.apache.org/jira/browse/MPOM-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643316#comment-17643316
]
Hudson commented on MPOM-373:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-parent » master #69
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-parent/job/master/69/
> Execute spotless before rat
> ---
>
> Key: MPOM-373
> URL: https://issues.apache.org/jira/browse/MPOM-373
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Affects Versions: MAVEN-38
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: MAVEN-39
>
>
> {{apache-rat-plugin:check}} should be executed after a reformatting with
> {{spotless-maven-plugin:apply}}. Currently the latter is executed in phase
> {{process-sourcess}} while the former is executed in {{validate}}
> (https://github.com/apache/creadur-rat/blob/acc6141d3bfbea4c1811604fa5668b1572e85898/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java#L48).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MPOM-373) Execute spotless before rat
[
https://issues.apache.org/jira/browse/MPOM-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved MPOM-373.
--
Resolution: Fixed
> Execute spotless before rat
> ---
>
> Key: MPOM-373
> URL: https://issues.apache.org/jira/browse/MPOM-373
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Affects Versions: MAVEN-38
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: MAVEN-39
>
>
> {{apache-rat-plugin:check}} should be executed after a reformatting with
> {{spotless-maven-plugin:apply}}. Currently the latter is executed in phase
> {{process-sourcess}} while the former is executed in {{validate}}
> (https://github.com/apache/creadur-rat/blob/acc6141d3bfbea4c1811604fa5668b1572e85898/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java#L48).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-parent] kwin merged pull request #96: [MPOM-373] Execute spotless-m-p before apache-rat-plugin
kwin merged PR #96: URL: https://github.com/apache/maven-parent/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dist-tool] dependabot[bot] closed pull request #21: Bump maven-reporting-exec from 2.0.0-M1 to 2.0.0-M2
dependabot[bot] closed pull request #21: Bump maven-reporting-exec from 2.0.0-M1 to 2.0.0-M2 URL: https://github.com/apache/maven-dist-tool/pull/21 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-dist-tool] dependabot[bot] opened a new pull request, #24: Bump maven-reporting-exec from 2.0.0-M1 to 2.0.0-M3
dependabot[bot] opened a new pull request, #24: URL: https://github.com/apache/maven-dist-tool/pull/24 Bumps [maven-reporting-exec](https://github.com/apache/maven-reporting-exec) from 2.0.0-M1 to 2.0.0-M3. Commits https://github.com/apache/maven-reporting-exec/commit/003c5372ee1e1fa2e5cc4d2bb815f005595a2266;>003c537 [maven-release-plugin] prepare release maven-reporting-exec-2.0.0-M3 https://github.com/apache/maven-reporting-exec/commit/5e3abc48753a01230ab2750f20ccd3bf4f0a25f9;>5e3abc4 [MSHARED-1164] Upgrade to Doxia/Doxia Sitetools to 2.0.0-M4 https://github.com/apache/maven-reporting-exec/commit/ee34d2762c6c793fb52132621150bcef02dc90bd;>ee34d27 [MSHARED-1167] Upgrade plugins in ITs https://github.com/apache/maven-reporting-exec/commit/d9599003a6e4058fbc0cf0848bb0e3569b52affc;>d959900 [MSHARED-1163] Upgrade Maven Reporting API to 4.0.0-M3 https://github.com/apache/maven-reporting-exec/commit/a153cb1e1f801f12b34bf83f127b0a83ae863306;>a153cb1 [MSHARED-1166] Upgrade Plexus Utils to 3.5.0 https://github.com/apache/maven-reporting-exec/commit/47a7c4df2c10c458ba4965c09ef16037c2144d51;>47a7c4d update Reproducible Builds badge link https://github.com/apache/maven-reporting-exec/commit/5a22bdfe496503d0d3a7ce23be6b7be94a495ba7;>5a22bdf Improve TODOs https://github.com/apache/maven-reporting-exec/commit/26646518ffc9e9ead8c150385c112f69dd60ccb9;>2664651 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-reporting-exec/commit/d9582052eb344b7d98ead8c463f3a88c4b363442;>d958205 [maven-release-plugin] prepare release maven-reporting-exec-2.0.0-M2 https://github.com/apache/maven-reporting-exec/commit/91dfb34ed92737b0101cf4668331130325e63a94;>91dfb34 [MSHARED-1105] Replace Plexus Annotations with JSR 330 and upgrade relevant d... Additional commits viewable in https://github.com/apache/maven-reporting-exec/compare/maven-reporting-exec-2.0.0-M1...maven-reporting-exec-2.0.0-M3;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Comment Edited] (MPOM-374) Autoformat *.groovy files
[
https://issues.apache.org/jira/browse/MPOM-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643293#comment-17643293
]
Konrad Windszus edited comment on MPOM-374 at 12/5/22 11:56 AM:
At least adding the license header does not work for groovy scripts (as used by
maven-invoker-plugin). The spotless-maven-plugin then fails with
{code}
[ERROR] Step 'com.diffplug.spotless.generic.LicenseHeaderStep' found problem in
'src/it/packaging-jar/verify.groovy':
Unable to find delimiter regex ^package
java.lang.IllegalArgumentException: Unable to find delimiter regex ^package
{code}
I raised https://github.com/diffplug/spotless/issues/1418 to track that.
was (Author: kwin):
At least adding the license header does not work for groovy scripts (as used by
maven-invoker-plugin). The spotless-maven-plugin then fails with
{code}
[ERROR] Step 'com.diffplug.spotless.generic.LicenseHeaderStep' found problem in
'src/it/packaging-jar/verify.groovy':
Unable to find delimiter regex ^package
java.lang.IllegalArgumentException: Unable to find delimiter regex ^package
{code}
> Autoformat *.groovy files
> -
>
> Key: MPOM-374
> URL: https://issues.apache.org/jira/browse/MPOM-374
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Affects Versions: MAVEN-38
>Reporter: Konrad Windszus
>Priority: Major
>
> As groovy is pretty common for integration tests we should autoformat those
> as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPOM-374) Autoformat *.groovy files
[
https://issues.apache.org/jira/browse/MPOM-374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643293#comment-17643293
]
Konrad Windszus commented on MPOM-374:
--
At least adding the license header does not work for groovy scripts (as used by
maven-invoker-plugin). The spotless-maven-plugin then fails with
{code}
[ERROR] Step 'com.diffplug.spotless.generic.LicenseHeaderStep' found problem in
'src/it/packaging-jar/verify.groovy':
Unable to find delimiter regex ^package
java.lang.IllegalArgumentException: Unable to find delimiter regex ^package
{code}
> Autoformat *.groovy files
> -
>
> Key: MPOM-374
> URL: https://issues.apache.org/jira/browse/MPOM-374
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Affects Versions: MAVEN-38
>Reporter: Konrad Windszus
>Priority: Major
>
> As groovy is pretty common for integration tests we should autoformat those
> as well.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-jarsigner-plugin] danshome commented on pull request #2: Mark verify and sign Mojos thread safe
danshome commented on PR #2: URL: https://github.com/apache/maven-jarsigner-plugin/pull/2#issuecomment-1337189131 @slachiewicz When will this change be merged into the master? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MPOM-376) Spotless importOrder should be taken into consideration
Slawomir Jaranowski created MPOM-376: Summary: Spotless importOrder should be taken into consideration Key: MPOM-376 URL: https://issues.apache.org/jira/browse/MPOM-376 Project: Maven POMs Issue Type: Bug Components: maven Affects Versions: MAVEN-38 Reporter: Slawomir Jaranowski Configuration items in spotless should be in correct order. Currently importOrder is not taken into consideration So imports are sorted in wrong way, not corresponding to configuration. https://github.com/diffplug/spotless/issues/1417 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MPLUGIN-444) JavadocLinkGenerator.createLink: Support nested binary class names
[
https://issues.apache.org/jira/browse/MPLUGIN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643264#comment-17643264
]
Hudson commented on MPLUGIN-444:
Build succeeded in Jenkins: Maven » Maven TLP » maven-plugin-tools » master #93
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/93/
> JavadocLinkGenerator.createLink: Support nested binary class names
> --
>
> Key: MPLUGIN-444
> URL: https://issues.apache.org/jira/browse/MPLUGIN-444
> Project: Maven Plugin Tools
> Issue Type: Bug
>Affects Versions: 3.7.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: next-release
>
>
> Currently all binary names containing a dollar "$" throw an
> {{IllegalArgumentException}} when being invoked with
> {{JavadocLinkGenerator.createLink(...)}}. Actually member classes should be
> supported as links to their Javadoc can be reliably constructed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPOM-375) Add license header automatically to all files
[
https://issues.apache.org/jira/browse/MPOM-375?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MPOM-375:
-
Description:
Currently license headers are only added to java files. One should leverage
option
https://github.com/diffplug/spotless/tree/main/plugin-maven#license-header to
add/modify it in all files (also to always properly reflect the year of the
last modification).
Also e.g. Java files within {{src/test/resources}} are currently not considered
with regards to license file.
was:Currently license headers are only added to java files. One should
leverage option
https://github.com/diffplug/spotless/tree/main/plugin-maven#license-header to
add/modify it in all files (also to always properly reflect the year of the
last modification)
> Add license header automatically to all files
> -
>
> Key: MPOM-375
> URL: https://issues.apache.org/jira/browse/MPOM-375
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Affects Versions: MAVEN-38
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently license headers are only added to java files. One should leverage
> option
> https://github.com/diffplug/spotless/tree/main/plugin-maven#license-header to
> add/modify it in all files (also to always properly reflect the year of the
> last modification).
> Also e.g. Java files within {{src/test/resources}} are currently not
> considered with regards to license file.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MPOM-375) Add license header automatically to all files
Konrad Windszus created MPOM-375: Summary: Add license header automatically to all files Key: MPOM-375 URL: https://issues.apache.org/jira/browse/MPOM-375 Project: Maven POMs Issue Type: Improvement Components: maven Affects Versions: MAVEN-38 Reporter: Konrad Windszus Currently license headers are only added to java files. One should leverage option https://github.com/diffplug/spotless/tree/main/plugin-maven#license-header to add/modify it in all files (also to always properly reflect the year of the last modification) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MPOM-374) Autoformat *.groovy files
Konrad Windszus created MPOM-374: Summary: Autoformat *.groovy files Key: MPOM-374 URL: https://issues.apache.org/jira/browse/MPOM-374 Project: Maven POMs Issue Type: Improvement Components: maven Affects Versions: MAVEN-38 Reporter: Konrad Windszus As groovy is pretty common for integration tests we should autoformat those as well. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MPOM-373) Execute spotless before rat
[
https://issues.apache.org/jira/browse/MPOM-373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MPOM-373:
-
Description: {{apache-rat-plugin:check}} should be executed after a
reformatting with {{spotless-maven-plugin:apply}}. Currently the latter is
executed in phase {{process-sourcess}} while the former is executed in
{{validate}}
(https://github.com/apache/creadur-rat/blob/acc6141d3bfbea4c1811604fa5668b1572e85898/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java#L48).
(was: {{apache-rat-plugin:check}} should be executed after a reformatting
with {{spotless-maven-plugin:apply}}. Currently the later is executed in phase
{{process-sourcess}} while the former is executed in {{validate}}
(https://github.com/apache/creadur-rat/blob/acc6141d3bfbea4c1811604fa5668b1572e85898/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java#L48).)
> Execute spotless before rat
> ---
>
> Key: MPOM-373
> URL: https://issues.apache.org/jira/browse/MPOM-373
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Affects Versions: MAVEN-38
>Reporter: Konrad Windszus
>Priority: Major
> Fix For: MAVEN-39
>
>
> {{apache-rat-plugin:check}} should be executed after a reformatting with
> {{spotless-maven-plugin:apply}}. Currently the latter is executed in phase
> {{process-sourcess}} while the former is executed in {{validate}}
> (https://github.com/apache/creadur-rat/blob/acc6141d3bfbea4c1811604fa5668b1572e85898/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java#L48).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MPOM-373) Execute spotless before rat
Konrad Windszus created MPOM-373:
Summary: Execute spotless before rat
Key: MPOM-373
URL: https://issues.apache.org/jira/browse/MPOM-373
Project: Maven POMs
Issue Type: Improvement
Components: maven
Affects Versions: MAVEN-38
Reporter: Konrad Windszus
Fix For: MAVEN-39
{{apache-rat-plugin:check}} should be executed after a reformatting with
{{spotless-maven-plugin:apply}}. Currently the later is executed in phase
{{process-sourcess}} while the former is executed in {{validate}}
(https://github.com/apache/creadur-rat/blob/acc6141d3bfbea4c1811604fa5668b1572e85898/apache-rat-plugin/src/main/java/org/apache/rat/mp/RatCheckMojo.java#L48).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5
[
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643242#comment-17643242
]
Hudson commented on MNG-7611:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven-plugin-tools » master #91
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/91/
> java.lang.IllegalStateException: Required Java version 1.8 is not met by
> current version: 17.0.5
>
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not
> met by current version: 17.0.5
>at
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-443) Javadoc reference containing a link label with spaces are not detected
[
https://issues.apache.org/jira/browse/MPLUGIN-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643243#comment-17643243
]
Hudson commented on MPLUGIN-443:
Build succeeded in Jenkins: Maven » Maven TLP » maven-plugin-tools » master #91
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-plugin-tools/job/master/91/
> Javadoc reference containing a link label with spaces are not detected
> --
>
> Key: MPLUGIN-443
> URL: https://issues.apache.org/jira/browse/MPLUGIN-443
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: API
>Affects Versions: 3.7.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: next-release
>
>
> For example the following link tag is not properly parsed:
> {code}
> {@link #member label with spaces}
> {code}
> and leads to the following exception
> {code}
> java.lang.IllegalArgumentException: Invalid format of javadoc reference:
> #member label with spaces
> at
> org.apache.maven.tools.plugin.javadoc.JavadocReference.parse(JavadocReference.java:74)
> ...
> {code}
> According to
> https://docs.oracle.com/en/java/javase/17/docs/specs/javadoc/doc-comment-spec.html#link
> this should be valid though as the link tag ends only with the '}'
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MPLUGIN-444) JavadocLinkGenerator.createLink: Support nested binary class names
[
https://issues.apache.org/jira/browse/MPLUGIN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved MPLUGIN-444.
-
Resolution: Fixed
> JavadocLinkGenerator.createLink: Support nested binary class names
> --
>
> Key: MPLUGIN-444
> URL: https://issues.apache.org/jira/browse/MPLUGIN-444
> Project: Maven Plugin Tools
> Issue Type: Bug
>Affects Versions: 3.7.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: next-release
>
>
> Currently all binary names containing a dollar "$" throw an
> {{IllegalArgumentException}} when being invoked with
> {{JavadocLinkGenerator.createLink(...)}}. Actually member classes should be
> supported as links to their Javadoc can be reliably constructed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-444) JavadocLinkGenerator.createLink: Support nested binary class names
[
https://issues.apache.org/jira/browse/MPLUGIN-444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643219#comment-17643219
]
ASF GitHub Bot commented on MPLUGIN-444:
kwin merged PR #178:
URL: https://github.com/apache/maven-plugin-tools/pull/178
> JavadocLinkGenerator.createLink: Support nested binary class names
> --
>
> Key: MPLUGIN-444
> URL: https://issues.apache.org/jira/browse/MPLUGIN-444
> Project: Maven Plugin Tools
> Issue Type: Bug
>Affects Versions: 3.7.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: next-release
>
>
> Currently all binary names containing a dollar "$" throw an
> {{IllegalArgumentException}} when being invoked with
> {{JavadocLinkGenerator.createLink(...)}}. Actually member classes should be
> supported as links to their Javadoc can be reliably constructed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-plugin-tools] kwin merged pull request #178: [MPLUGIN-444] JavadocLinkGenerator.createLink: Support nested binary
kwin merged PR #178: URL: https://github.com/apache/maven-plugin-tools/pull/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MPLUGIN-443) Javadoc reference containing a link label with spaces are not detected
[
https://issues.apache.org/jira/browse/MPLUGIN-443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved MPLUGIN-443.
-
Resolution: Fixed
> Javadoc reference containing a link label with spaces are not detected
> --
>
> Key: MPLUGIN-443
> URL: https://issues.apache.org/jira/browse/MPLUGIN-443
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: API
>Affects Versions: 3.7.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: next-release
>
>
> For example the following link tag is not properly parsed:
> {code}
> {@link #member label with spaces}
> {code}
> and leads to the following exception
> {code}
> java.lang.IllegalArgumentException: Invalid format of javadoc reference:
> #member label with spaces
> at
> org.apache.maven.tools.plugin.javadoc.JavadocReference.parse(JavadocReference.java:74)
> ...
> {code}
> According to
> https://docs.oracle.com/en/java/javase/17/docs/specs/javadoc/doc-comment-spec.html#link
> this should be valid though as the link tag ends only with the '}'
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MPLUGIN-443) Javadoc reference containing a link label with spaces are not detected
[
https://issues.apache.org/jira/browse/MPLUGIN-443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643218#comment-17643218
]
ASF GitHub Bot commented on MPLUGIN-443:
kwin merged PR #177:
URL: https://github.com/apache/maven-plugin-tools/pull/177
> Javadoc reference containing a link label with spaces are not detected
> --
>
> Key: MPLUGIN-443
> URL: https://issues.apache.org/jira/browse/MPLUGIN-443
> Project: Maven Plugin Tools
> Issue Type: Bug
> Components: API
>Affects Versions: 3.7.0
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: next-release
>
>
> For example the following link tag is not properly parsed:
> {code}
> {@link #member label with spaces}
> {code}
> and leads to the following exception
> {code}
> java.lang.IllegalArgumentException: Invalid format of javadoc reference:
> #member label with spaces
> at
> org.apache.maven.tools.plugin.javadoc.JavadocReference.parse(JavadocReference.java:74)
> ...
> {code}
> According to
> https://docs.oracle.com/en/java/javase/17/docs/specs/javadoc/doc-comment-spec.html#link
> this should be valid though as the link tag ends only with the '}'
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7611) java.lang.IllegalStateException: Required Java version 1.8 is not met by current version: 17.0.5
[
https://issues.apache.org/jira/browse/MNG-7611?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643217#comment-17643217
]
ASF GitHub Bot commented on MNG-7611:
-
kwin merged PR #184:
URL: https://github.com/apache/maven-plugin-tools/pull/184
> java.lang.IllegalStateException: Required Java version 1.8 is not met by
> current version: 17.0.5
>
>
> Key: MNG-7611
> URL: https://issues.apache.org/jira/browse/MNG-7611
> Project: Maven
> Issue Type: Task
>Reporter: Guillaume Nodet
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-3
>
>
> {code:java}
> Caused by: java.lang.IllegalStateException: Required Java version 1.8 is not
> met by current version: 17.0.5
>at
> org.apache.maven.plugin.internal.MavenPluginJavaPrerequisiteChecker.accept(MavenPluginJavaPrerequisiteChecker.java:38)
>at
> org.apache.maven.plugin.internal.DefaultMavenPluginManager.lambda$checkPrerequisites$1(DefaultMavenPluginManager.java:289)
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-plugin-tools] kwin merged pull request #177: [MPLUGIN-443] Detect javadoc link labels with spaces
kwin merged PR #177: URL: https://github.com/apache/maven-plugin-tools/pull/177 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-plugin-tools] kwin merged pull request #184: [MNG-7611] Change semantics of plugin descriptor's "requiredJavaVersion"
kwin merged PR #184: URL: https://github.com/apache/maven-plugin-tools/pull/184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7598) Enforce binary backwards-compatibility with Maven 3 of all exported packages
[ https://issues.apache.org/jira/browse/MNG-7598?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643216#comment-17643216 ] ASF GitHub Bot commented on MNG-7598: - kwin commented on PR #874: URL: https://github.com/apache/maven/pull/874#issuecomment-1337080224 @gnodet Any objection to merge this (after fixing the conflicts)? > Enforce binary backwards-compatibility with Maven 3 of all exported packages > > > Key: MNG-7598 > URL: https://issues.apache.org/jira/browse/MNG-7598 > Project: Maven > Issue Type: Improvement >Reporter: Konrad Windszus >Priority: Major > Fix For: 4.0.0 > > > All packages exported through the API classloader (indicated in > https://github.com/apache/maven/blob/master/maven-core/src/main/resources/META-INF/maven/extension.xml) > should be binary backwards-compatible in Maven 4. > To enforce this the > [japicmp-maven-plugin|https://siom79.github.io/japicmp/MavenPlugin.html] > should be leveraged during the build. > Compare with the discussion at > https://lists.apache.org/thread/l8brfb69z2vclds1v91j7x98fp9ls7rj. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [maven] kwin commented on pull request #874: [MNG-7598] Enforce binary backwards-compatibility
kwin commented on PR #874: URL: https://github.com/apache/maven/pull/874#issuecomment-1337080224 @gnodet Any objection to merge this (after fixing the conflicts)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNGSITE-501) Clarify JDK activation element
[
https://issues.apache.org/jira/browse/MNGSITE-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643195#comment-17643195
]
Hudson commented on MNGSITE-501:
Build succeeded in Jenkins: Maven » Maven TLP » maven-site » master #186
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven-site/job/master/186/
> Clarify JDK activation element
> --
>
> Key: MNGSITE-501
> URL: https://issues.apache.org/jira/browse/MNGSITE-501
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Both in [https://maven.apache.org/pom.html#Activation] and
> [https://maven.apache.org/guides/introduction/introduction-to-profiles.html#details-on-profile-activation]
> the {{jdk}} element needs clarification that not all values are interpreted
> as ranges (in contrast to what the referenced version range specification
> from enforcer maven plugin in
> [https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html] says).
> Actually there are three different kind of values supported:
> # Version ranges (if the value starts with either "[" or "(")
> # A negated prefix (if the value starts with "!")
> # A (non-negated) prefix for all other cases
> This can be seen in
> [https://github.com/apache/maven/blob/001eef8452b38110a2557446aa81b8fb1ff35f92/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivator.java#L69]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNGSITE-501) Clarify JDK activation element
[
https://issues.apache.org/jira/browse/MNGSITE-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643193#comment-17643193
]
ASF GitHub Bot commented on MNGSITE-501:
kwin merged PR #346:
URL: https://github.com/apache/maven-site/pull/346
> Clarify JDK activation element
> --
>
> Key: MNGSITE-501
> URL: https://issues.apache.org/jira/browse/MNGSITE-501
> Project: Maven Project Web Site
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Both in [https://maven.apache.org/pom.html#Activation] and
> [https://maven.apache.org/guides/introduction/introduction-to-profiles.html#details-on-profile-activation]
> the {{jdk}} element needs clarification that not all values are interpreted
> as ranges (in contrast to what the referenced version range specification
> from enforcer maven plugin in
> [https://maven.apache.org/enforcer/enforcer-rules/versionRanges.html] says).
> Actually there are three different kind of values supported:
> # Version ranges (if the value starts with either "[" or "(")
> # A negated prefix (if the value starts with "!")
> # A (non-negated) prefix for all other cases
> This can be seen in
> [https://github.com/apache/maven/blob/001eef8452b38110a2557446aa81b8fb1ff35f92/maven-model-builder/src/main/java/org/apache/maven/model/profile/activation/JdkVersionProfileActivator.java#L69]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-site] kwin merged pull request #346: [MNGSITE-501] Clarify profile jdk activation
kwin merged PR #346: URL: https://github.com/apache/maven-site/pull/346 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7609) Clarify documentation of extension descriptor
[
https://issues.apache.org/jira/browse/MNG-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643187#comment-17643187
]
Hudson commented on MNG-7609:
-
Build succeeded in Jenkins: Maven » Maven TLP » maven » master #147
See
https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/147/
> Clarify documentation of extension descriptor
> -
>
> Key: MNG-7609
> URL: https://issues.apache.org/jira/browse/MNG-7609
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-3
>
>
> The extension descriptor is documented in
> https://maven.apache.org/ref/3-LATEST/maven-core/extension.html based on the
> MDO file at
> https://github.com/apache/maven/blob/master/maven-core/src/main/mdo/extension.mdo.
> It is lacking important information such as
> - how are subpackages and wildcards handled in {{exportedPackages}}?
> - how can one export individual classes via {{exportedPackages}} (compare
> with
> https://github.com/apache/maven/blob/c6ecff9923088d854d4621e17d602f1c70dda806/maven-core/src/main/mdo/extension.mdo#L50)
> - how are {{exportedPackages}} and {{exportedArtifacts}} related? Are they
> just merged or are they combined in some other way?
> The better extension descriptor documentation should finally be linked also
> from
> https://github.com/apache/maven/blob/master/maven-core/src/site/apt/core-extensions.apt.vm,
> as well as from
> https://maven.apache.org/guides/mini/guide-maven-classloading.html#API_Classloader
> and https://maven.apache.org/guides/mini/guide-using-extensions.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven-invoker-plugin] olamy commented on pull request #154: [MINVOKER-312] change to groovy groupId org.apache.groovy and bump version to 4.x support jdk19
olamy commented on PR #154: URL: https://github.com/apache/maven-invoker-plugin/pull/154#issuecomment-1337033917 > We need also update https://maven.apache.org/plugins/maven-invoker-plugin/groovy-version.html > > Info about import `groovy.xml..` packages can be useful good point! I will fix that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-invoker-plugin] slawekjaranowski commented on pull request #154: [MINVOKER-312] change to groovy groupId org.apache.groovy and bump version to 4.x support jdk19
slawekjaranowski commented on PR #154: URL: https://github.com/apache/maven-invoker-plugin/pull/154#issuecomment-1337012874 We need also update https://maven.apache.org/plugins/maven-invoker-plugin/groovy-version.html Info about import `groovy.xml..` packages can be useful -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (MNG-7609) Clarify documentation of extension descriptor
[
https://issues.apache.org/jira/browse/MNG-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved MNG-7609.
--
Fix Version/s: 4.0.0
4.0.0-alpha-3
Assignee: Konrad Windszus
Resolution: Fixed
> Clarify documentation of extension descriptor
> -
>
> Key: MNG-7609
> URL: https://issues.apache.org/jira/browse/MNG-7609
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-3
>
>
> The extension descriptor is documented in
> https://maven.apache.org/ref/3-LATEST/maven-core/extension.html based on the
> MDO file at
> https://github.com/apache/maven/blob/master/maven-core/src/main/mdo/extension.mdo.
> It is lacking important information such as
> - how are subpackages and wildcards handled in {{exportedPackages}}?
> - how can one export individual classes via {{exportedPackages}} (compare
> with
> https://github.com/apache/maven/blob/c6ecff9923088d854d4621e17d602f1c70dda806/maven-core/src/main/mdo/extension.mdo#L50)
> - how are {{exportedPackages}} and {{exportedArtifacts}} related? Are they
> just merged or are they combined in some other way?
> The better extension descriptor documentation should finally be linked also
> from
> https://github.com/apache/maven/blob/master/maven-core/src/site/apt/core-extensions.apt.vm,
> as well as from
> https://maven.apache.org/guides/mini/guide-maven-classloading.html#API_Classloader
> and https://maven.apache.org/guides/mini/guide-using-extensions.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7609) Clarify documentation of extension descriptor
[
https://issues.apache.org/jira/browse/MNG-7609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17643174#comment-17643174
]
ASF GitHub Bot commented on MNG-7609:
-
kwin merged PR #896:
URL: https://github.com/apache/maven/pull/896
> Clarify documentation of extension descriptor
> -
>
> Key: MNG-7609
> URL: https://issues.apache.org/jira/browse/MNG-7609
> Project: Maven
> Issue Type: Improvement
> Components: Core
>Reporter: Konrad Windszus
>Priority: Major
>
> The extension descriptor is documented in
> https://maven.apache.org/ref/3-LATEST/maven-core/extension.html based on the
> MDO file at
> https://github.com/apache/maven/blob/master/maven-core/src/main/mdo/extension.mdo.
> It is lacking important information such as
> - how are subpackages and wildcards handled in {{exportedPackages}}?
> - how can one export individual classes via {{exportedPackages}} (compare
> with
> https://github.com/apache/maven/blob/c6ecff9923088d854d4621e17d602f1c70dda806/maven-core/src/main/mdo/extension.mdo#L50)
> - how are {{exportedPackages}} and {{exportedArtifacts}} related? Are they
> just merged or are they combined in some other way?
> The better extension descriptor documentation should finally be linked also
> from
> https://github.com/apache/maven/blob/master/maven-core/src/site/apt/core-extensions.apt.vm,
> as well as from
> https://maven.apache.org/guides/mini/guide-maven-classloading.html#API_Classloader
> and https://maven.apache.org/guides/mini/guide-using-extensions.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[GitHub] [maven] kwin merged pull request #896: [MNG-7609] Clarify extension descriptor documentation
kwin merged PR #896: URL: https://github.com/apache/maven/pull/896 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven-install-plugin] slawekjaranowski commented on pull request #48: Bump maven-plugins from 37 to 38
slawekjaranowski commented on PR #48: URL: https://github.com/apache/maven-install-plugin/pull/48#issuecomment-1336971291 Please check checkstyle site report https://issues.apache.org/jira/browse/MPOM-371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
