[jira] [Updated] (SUREFIRE-2103) and causing Java heap space issue.
[ https://issues.apache.org/jira/browse/SUREFIRE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-2103: - Fix Version/s: (was: waiting-for-feedback) > and causing Java heap space issue. > - > > Key: SUREFIRE-2103 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2103 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin >Affects Versions: 3.0.0-M5, 3.0.0-M6 >Reporter: parita jivani >Priority: Critical > > We have Java test projects, which has different integration and UI tests. We > are upgrading failsafe and surefire version from 2.17 to 3.0.0-M5. After > upgrade few projects were failing with Java heap space. After analysing the > issue, we got to know that failsafe reports creation is causing the memory > issue. Failsafe plugin is writing and elements > with log details. In our case, build logs contains huge data of script > execution logs(around >= 1GB). While creating failsafe report, failsafe > plugin is writing entire logs to *.xml report and causing failure due to java > heap space. > > For issue resolution my suggestion is to get some configuration to > unable/disable option for tags would really help. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (SUREFIRE-2141) Surefire 3.0.0-M8 tests don't pass on Mac M1 (Surefire1295AttributeJvmCrashesToTestsIT)
[
https://issues.apache.org/jira/browse/SUREFIRE-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated SUREFIRE-2141:
Issue Type: Test (was: New Feature)
> Surefire 3.0.0-M8 tests don't pass on Mac M1
> (Surefire1295AttributeJvmCrashesToTestsIT)
> ---
>
> Key: SUREFIRE-2141
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2141
> Project: Maven Surefire
> Issue Type: Test
>Affects Versions: 3.0.0-M8
>Reporter: Enrico Olivelli
>Priority: Critical
>
>
> This test never passes on M1 Macs: Surefire1295AttributeJvmCrashesToTestsIT
> This is the error I can find in
> surefire-its/target/Surefire1295AttributeJvmCrashesToTestsIT_test_segfault_2/target/surefire-reports/junit44.environment.Test1CrashedTest.txt
> The problem is in the crashjvm library
> https://mvnrepository.com/artifact/uk.me.mjt/crashjvm/1.0
> The library seems dead
> {code:java}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.546 s <<<
> FAILURE! - in junit44.environment.Test1CrashedTest
> junit44.environment.Test1CrashedTest.testCrashJvm Time elapsed: 1.53 s <<<
> ERROR!
> java.lang.ExceptionInInitializerError
> at
> junit44.environment.Test1CrashedTest.testCrashJvm(Test1CrashedTest.java:34)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
> at
> org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
> at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
> at
> org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
> at
> org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
> at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
> at
> org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
> at
> org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
> at
> org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
> at
> org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
> at
> org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
> at
> org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:377)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:284)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:248)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:167)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:456)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)
> Caused by: java.lang.RuntimeException: Unrecognised arch, aarch64
> at uk.me.mjt.FindLibrary.getArch(FindLibrary.java:142)
> at
> uk.me.mjt.FindLibrary.extractNativeLibAsTempFile(FindLibrary.java:108)
> at uk.me.mjt.FindLibrary.loadLibraryFromJarFile(FindLibrary.java:44)
> at
> uk.me.mjt.FindLibrary.loadLibraryExtractingFromJarIfNeeded(FindLibrary.java:25)
> at uk.me.mjt.CrashJvm.(CrashJvm.java:5)
> ... 25 more
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SUREFIRE-2141) Surefire 3.0.0-M8 tests don't pass on Mac M1 (Surefire1295AttributeJvmCrashesToTestsIT)
[
https://issues.apache.org/jira/browse/SUREFIRE-2141?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated SUREFIRE-2141:
Priority: Minor (was: Critical)
> Surefire 3.0.0-M8 tests don't pass on Mac M1
> (Surefire1295AttributeJvmCrashesToTestsIT)
> ---
>
> Key: SUREFIRE-2141
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2141
> Project: Maven Surefire
> Issue Type: Test
>Affects Versions: 3.0.0-M8
>Reporter: Enrico Olivelli
>Priority: Minor
>
>
> This test never passes on M1 Macs: Surefire1295AttributeJvmCrashesToTestsIT
> This is the error I can find in
> surefire-its/target/Surefire1295AttributeJvmCrashesToTestsIT_test_segfault_2/target/surefire-reports/junit44.environment.Test1CrashedTest.txt
> The problem is in the crashjvm library
> https://mvnrepository.com/artifact/uk.me.mjt/crashjvm/1.0
> The library seems dead
> {code:java}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 1.546 s <<<
> FAILURE! - in junit44.environment.Test1CrashedTest
> junit44.environment.Test1CrashedTest.testCrashJvm Time elapsed: 1.53 s <<<
> ERROR!
> java.lang.ExceptionInInitializerError
> at
> junit44.environment.Test1CrashedTest.testCrashJvm(Test1CrashedTest.java:34)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at org.junit.internal.runners.TestMethod.invoke(TestMethod.java:59)
> at
> org.junit.internal.runners.MethodRoadie.runTestMethod(MethodRoadie.java:98)
> at org.junit.internal.runners.MethodRoadie$2.run(MethodRoadie.java:79)
> at
> org.junit.internal.runners.MethodRoadie.runBeforesThenTestThenAfters(MethodRoadie.java:87)
> at
> org.junit.internal.runners.MethodRoadie.runTest(MethodRoadie.java:77)
> at org.junit.internal.runners.MethodRoadie.run(MethodRoadie.java:42)
> at
> org.junit.internal.runners.JUnit4ClassRunner.invokeTestMethod(JUnit4ClassRunner.java:88)
> at
> org.junit.internal.runners.JUnit4ClassRunner.runMethods(JUnit4ClassRunner.java:51)
> at
> org.junit.internal.runners.JUnit4ClassRunner$1.run(JUnit4ClassRunner.java:44)
> at
> org.junit.internal.runners.ClassRoadie.runUnprotected(ClassRoadie.java:27)
> at
> org.junit.internal.runners.ClassRoadie.runProtected(ClassRoadie.java:37)
> at
> org.junit.internal.runners.JUnit4ClassRunner.run(JUnit4ClassRunner.java:42)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:377)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:284)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:248)
> at
> org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:167)
> at
> org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:456)
> at
> org.apache.maven.surefire.booter.ForkedBooter.execute(ForkedBooter.java:169)
> at
> org.apache.maven.surefire.booter.ForkedBooter.run(ForkedBooter.java:595)
> at
> org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:581)
> Caused by: java.lang.RuntimeException: Unrecognised arch, aarch64
> at uk.me.mjt.FindLibrary.getArch(FindLibrary.java:142)
> at
> uk.me.mjt.FindLibrary.extractNativeLibAsTempFile(FindLibrary.java:108)
> at uk.me.mjt.FindLibrary.loadLibraryFromJarFile(FindLibrary.java:44)
> at
> uk.me.mjt.FindLibrary.loadLibraryExtractingFromJarIfNeeded(FindLibrary.java:25)
> at uk.me.mjt.CrashJvm.(CrashJvm.java:5)
> ... 25 more
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SUREFIRE-2103) and causing Java heap space issue.
[ https://issues.apache.org/jira/browse/SUREFIRE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed SUREFIRE-2103. --- > and causing Java heap space issue. > - > > Key: SUREFIRE-2103 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2103 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin >Affects Versions: 3.0.0-M5, 3.0.0-M6 >Reporter: parita jivani >Priority: Critical > Fix For: waiting-for-feedback > > > We have Java test projects, which has different integration and UI tests. We > are upgrading failsafe and surefire version from 2.17 to 3.0.0-M5. After > upgrade few projects were failing with Java heap space. After analysing the > issue, we got to know that failsafe reports creation is causing the memory > issue. Failsafe plugin is writing and elements > with log details. In our case, build logs contains huge data of script > execution logs(around >= 1GB). While creating failsafe report, failsafe > plugin is writing entire logs to *.xml report and causing failure due to java > heap space. > > For issue resolution my suggestion is to get some configuration to > unable/disable option for tags would really help. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Resolved] (SUREFIRE-2103) and causing Java heap space issue.
[ https://issues.apache.org/jira/browse/SUREFIRE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved SUREFIRE-2103. - Resolution: Fixed sounds like it's fixed, comment and I'll reopen if it can still be reproduced > and causing Java heap space issue. > - > > Key: SUREFIRE-2103 > URL: https://issues.apache.org/jira/browse/SUREFIRE-2103 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Failsafe Plugin >Affects Versions: 3.0.0-M5, 3.0.0-M6 >Reporter: parita jivani >Priority: Critical > Fix For: waiting-for-feedback > > > We have Java test projects, which has different integration and UI tests. We > are upgrading failsafe and surefire version from 2.17 to 3.0.0-M5. After > upgrade few projects were failing with Java heap space. After analysing the > issue, we got to know that failsafe reports creation is causing the memory > issue. Failsafe plugin is writing and elements > with log details. In our case, build logs contains huge data of script > execution logs(around >= 1GB). While creating failsafe report, failsafe > plugin is writing entire logs to *.xml report and causing failure due to java > heap space. > > For issue resolution my suggestion is to get some configuration to > unable/disable option for tags would really help. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] subject verb agreement [maven-compiler-plugin]
elharo opened a new pull request, #221: URL: https://github.com/apache/maven-compiler-plugin/pull/221 minor grammar fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-1810) Surefire plugin SurefireBooterForkException if path has Spaces in the name
[ https://issues.apache.org/jira/browse/SUREFIRE-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-1810: - Fix Version/s: waiting-for-feedback > Surefire plugin SurefireBooterForkException if path has Spaces in the name > -- > > Key: SUREFIRE-1810 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1810 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 3.0.0-M4 > Environment: OS: Microsoft Windows 10 Pro 10.0.19041 Build 19041 > Maven: 3.6.3 > Java: "11.0.7" 2020-04-14 LTS | Java(TM) SE Runtime Environment 18.9 (build > 11.0.7+8-LTS) | Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.7+8-LTS, > mixed mode) >Reporter: Tiago Jorge Proença Gaspar Casinhas >Priority: Major > Labels: newbie > Fix For: waiting-for-feedback > > Attachments: 2020-06-26T09-50-50_242.dumpstream, dump2.txt > > > When I attempt to run tests using `mvn clean install` or similar commands > that run through the verify phase, I get a SurefireBooterForkException if the > path to my project contains any space. > Example: +C:\Users\tcasinhas\Documents\Git\My Project\mproj-subproj-cases+ > > If I remove the space, the build runs sucessfully. > Example: +C:\Users\tcasinhas\Documents\Git\My-Project\mproj-subproj-cases+ > Notes: > I ommited the company and project name, but left everything else in the dump > as is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Comment Edited] (SUREFIRE-1810) Surefire plugin SurefireBooterForkException if path has Spaces in the name
[
https://issues.apache.org/jira/browse/SUREFIRE-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801400#comment-17801400
]
Michael Osipov edited comment on SUREFIRE-1810 at 12/30/23 11:40 PM:
-
OK, the issue I have found isn't related to this one. You problem is selfmade:
{noformat}
${argLine} -Xms256m -Xmx2048m
-Djava.library.path=C:\Users\tcasinhas\Documents\Git\myProject
Project\sph-casetailor-casekyccddrev\context/src/main/resources
{noformat}
You have failed to quote {{java.library.path}}, this the space gives you
trouble.
[~sjaranowski], I hate {{argLine}} in every single plugin with a passion
because it just causes trouble.
I consider this one as invalid.
was (Author: michael-o):
OK, the issue I have found isn't related to this one. You problem is selfmade:
{noformat}
${argLine} -Xms256m -Xmx2048m
-Djava.library.path=C:\Users\tcasinhas\Documents\Git\myProject
Project\sph-casetailor-casekyccddrev\context/src/main/resources
{noformat}
You have failed to quote {{java.library.path}}, this the space gives you
trouble.
[~sjaranowski], I have {{argLine}} in every single plugin with a passion
because they just cause trouble.
I consider this one as invalid.
> Surefire plugin SurefireBooterForkException if path has Spaces in the name
> --
>
> Key: SUREFIRE-1810
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1810
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M4
> Environment: OS: Microsoft Windows 10 Pro 10.0.19041 Build 19041
> Maven: 3.6.3
> Java: "11.0.7" 2020-04-14 LTS | Java(TM) SE Runtime Environment 18.9 (build
> 11.0.7+8-LTS) | Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.7+8-LTS,
> mixed mode)
>Reporter: Tiago Jorge Proença Gaspar Casinhas
>Priority: Major
> Labels: newbie
> Attachments: 2020-06-26T09-50-50_242.dumpstream, dump2.txt
>
>
> When I attempt to run tests using `mvn clean install` or similar commands
> that run through the verify phase, I get a SurefireBooterForkException if the
> path to my project contains any space.
> Example: +C:\Users\tcasinhas\Documents\Git\My Project\mproj-subproj-cases+
>
> If I remove the space, the build runs sucessfully.
> Example: +C:\Users\tcasinhas\Documents\Git\My-Project\mproj-subproj-cases+
> Notes:
> I ommited the company and project name, but left everything else in the dump
> as is.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2225) Surefire ITs fail when project directory contains space
[
https://issues.apache.org/jira/browse/SUREFIRE-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801403#comment-17801403
]
ASF GitHub Bot commented on SUREFIRE-2225:
--
michael-o opened a new pull request, #705:
URL: https://github.com/apache/maven-surefire/pull/705
This closes #705
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Surefire ITs fail when project directory contains space
> ---
>
> Key: SUREFIRE-2225
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2225
> Project: Maven Surefire
> Issue Type: Bug
> Components: process forking
>Affects Versions: 3.2.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.4
>
>
> Perform the following, e.g. on Windows:
> {noformat}
> git clone maven-surefire.git "Maven Surefire"
> cd "Maven Surefire"
> mvn install
> mvn verify -Prun-its
> {noformat}
> It will fail:
> {noformat}
> [ERROR]
> org.apache.maven.surefire.its.jiras.Surefire772SpecifiedReportsIT.testSkippedFailsafeReportGeneration
> -- Time elapsed: 0.080 s <<< ERROR!
> org.apache.maven.surefire.its.fixture.SurefireVerifierException:
> Exit code was non-zero: 255; command line and log =
> D:\Entwicklung\Programme\apache-maven-3.8.8\bin\mvn -fn -e --batch-mode
> -Dmaven.repo.local=C:\Users\mosipov\.m2\repository
> org.apache.maven.plugins:maven-clean-plugin:clean
> -Dsurefire.version=3.2.4-SNAPSHOT
> -Djacoco.agent="-javaagent:C:\\Users\\mosipov\\.m2\\repository\\org\\jacoco\\org.jacoco.agent\\0.8.8\\org.jacoco.agent-0.8.8-runtime.jar=destfile=D:\\Entwicklung\\Projekte\\Maven
>
> Surefire\\surefire-its\\target\\jacoco.exec,includes=**/failsafe/*:**/failsafe/**/*:**/surefire/*:**/surefire/**/*,excludes=**/HelpMojo.class:**/shadefire/**/*:org/jacoco/**/*:com/vladium/emma/rt/*"
> -nsu -Dclean.skip=true -Dmaven.clean.skip=true -PskipFailsafe
> org.apache.maven.plugins:maven-surefire-report-plugin:3.2.4-SNAPSHOT::failsafe-report-only
>
> org.apache.maven.plugins:maven-surefire-report-plugin:3.2.4-SNAPSHOT:report-only
> Syntaxfehler.
> at
> org.apache.maven.surefire.its.fixture.MavenLauncher.executeCurrentGoals(MavenLauncher.java:274)
> at
> org.apache.maven.surefire.its.fixture.SurefireLauncher.executeCurrentGoals(SurefireLauncher.java:142)
> at
> org.apache.maven.surefire.its.jiras.Surefire772SpecifiedReportsIT.testSkippedFailsafeReportGeneration(Surefire772SpecifiedReportsIT.java:53)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
>
[PR] [SUREFIRE-2225] Surefire ITs fail when project directory contains space [maven-surefire]
michael-o opened a new pull request, #705: URL: https://github.com/apache/maven-surefire/pull/705 This closes #705 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-2225) Surefire ITs fail when project directory contains space
[
https://issues.apache.org/jira/browse/SUREFIRE-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2225:
-
Description:
Perform the following, e.g. on Windows:
{noformat}
git clone maven-surefire.git "Maven Surefire"
cd "Maven Surefire"
mvn install
mvn verify -Prun-its
{noformat}
It will fail:
{noformat}
[ERROR]
org.apache.maven.surefire.its.jiras.Surefire772SpecifiedReportsIT.testSkippedFailsafeReportGeneration
-- Time elapsed: 0.080 s <<< ERROR!
org.apache.maven.surefire.its.fixture.SurefireVerifierException:
Exit code was non-zero: 255; command line and log =
D:\Entwicklung\Programme\apache-maven-3.8.8\bin\mvn -fn -e --batch-mode
-Dmaven.repo.local=C:\Users\mosipov\.m2\repository
org.apache.maven.plugins:maven-clean-plugin:clean
-Dsurefire.version=3.2.4-SNAPSHOT
-Djacoco.agent="-javaagent:C:\\Users\\mosipov\\.m2\\repository\\org\\jacoco\\org.jacoco.agent\\0.8.8\\org.jacoco.agent-0.8.8-runtime.jar=destfile=D:\\Entwicklung\\Projekte\\Maven
Surefire\\surefire-its\\target\\jacoco.exec,includes=**/failsafe/*:**/failsafe/**/*:**/surefire/*:**/surefire/**/*,excludes=**/HelpMojo.class:**/shadefire/**/*:org/jacoco/**/*:com/vladium/emma/rt/*"
-nsu -Dclean.skip=true -Dmaven.clean.skip=true -PskipFailsafe
org.apache.maven.plugins:maven-surefire-report-plugin:3.2.4-SNAPSHOT::failsafe-report-only
org.apache.maven.plugins:maven-surefire-report-plugin:3.2.4-SNAPSHOT:report-only
Syntaxfehler.
at
org.apache.maven.surefire.its.fixture.MavenLauncher.executeCurrentGoals(MavenLauncher.java:274)
at
org.apache.maven.surefire.its.fixture.SurefireLauncher.executeCurrentGoals(SurefireLauncher.java:142)
at
org.apache.maven.surefire.its.jiras.Surefire772SpecifiedReportsIT.testSkippedFailsafeReportGeneration(Surefire772SpecifiedReportsIT.java:53)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:49)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:120)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:95)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:69)
at
org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:146)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
at
org.apache.maven.surefire.boote
[jira] [Assigned] (SUREFIRE-2225) Surefire ITs fail when project directory contains space
[
https://issues.apache.org/jira/browse/SUREFIRE-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov reassigned SUREFIRE-2225:
Assignee: Michael Osipov
> Surefire ITs fail when project directory contains space
> ---
>
> Key: SUREFIRE-2225
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2225
> Project: Maven Surefire
> Issue Type: Bug
> Components: process forking
>Affects Versions: 3.2.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.4
>
>
> Perform the following, e.g. on Windows:
> {noformat}
> git clone maven-surefire.git "Maven Surefire"
> cd "Maven Surefire"
> mvn install
> mvn verify -Prun-its
> {noformat}
> It will fail:
> {noformat}
> [ERROR]
> org.apache.maven.surefire.its.jiras.Surefire772SpecifiedReportsIT.testSkippedFailsafeReportGeneration
> -- Time elapsed: 0.080 s <<< ERROR!
> org.apache.maven.surefire.its.fixture.SurefireVerifierException:
> Exit code was non-zero: 255; command line and log =
> D:\Entwicklung\Programme\apache-maven-3.8.8\bin\mvn -fn -e --batch-mode
> -Dmaven.repo.local=C:\Users\mosipov\.m2\repository
> org.apache.maven.plugins:maven-clean-plugin:clean
> -Dsurefire.version=3.2.4-SNAPSHOT
> -Djacoco.agent="-javaagent:C:\\Users\\mosipov\\.m2\\repository\\org\\jacoco\\org.jacoco.agent\\0.8.8\\org.jacoco.agent-0.8.8-runtime.jar=destfile=D:\\Entwicklung\\Projekte\\Maven
>
> Surefire\\surefire-its\\target\\jacoco.exec,includes=**/failsafe/*:**/failsafe/**/*:**/surefire/*:**/surefire/**/*,excludes=**/HelpMojo.class:**/shadefire/**/*:org/jacoco/**/*:com/vladium/emma/rt/*"
> -nsu -Dclean.skip=true -Dmaven.clean.skip=true -PskipFailsafe
> org.apache.maven.plugins:maven-surefire-report-plugin:3.2.4-SNAPSHOT::failsafe-report-only
>
> org.apache.maven.plugins:maven-surefire-report-plugin:3.2.4-SNAPSHOT:report-only
> Syntaxfehler.
> at
> org.apache.maven.surefire.its.fixture.MavenLauncher.executeCurrentGoals(MavenLauncher.java:274)
> at
> org.apache.maven.surefire.its.fixture.SurefireLauncher.executeCurrentGoals(SurefireLauncher.java:142)
> at
> org.apache.maven.surefire.its.jiras.Surefire772SpecifiedReportsIT.testSkippedFailsafeReportGeneration(Surefire772SpecifiedReportsIT.java:53)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at org.junit.runners.Suite.runChild(Suite.java:128)
> at org.junit.runners.Suite.runChild(Suite.java:27)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.j
[jira] [Updated] (SUREFIRE-2225) Surefire ITs fail when project directory contains space
[
https://issues.apache.org/jira/browse/SUREFIRE-2225?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2225:
-
Description:
Perform the following, e.g. on Windows:
{noformat}
git clone maven-surefire.git "Maven Surefire"
cd "Maven Surefire"
mvn install
mvn verify -Prun-its
{noformat}
It will fail:
{noformat}
[ERROR]
org.apache.maven.surefire.its.jiras.Surefire772SpecifiedReportsIT.testSkippedFailsafeReportGeneration
-- Time elapsed: 0.080 s <<< ERROR!
org.apache.maven.surefire.its.fixture.SurefireVerifierException:
Exit code was non-zero: 255; command line and log =
D:\Entwicklung\Programme\apache-maven-3.8.8\bin\mvn -fn -e --batch-mode
-Dmaven.repo.local=C:\Users\mosipov\.m2\repository
org.apache.maven.plugins:maven-clean-plugin:clean
-Dsurefire.version=3.2.4-SNAPSHOT
-Djacoco.agent="-javaagent:C:\\Users\\mosipov\\.m2\\repository\\org\\jacoco\\org.jacoco.agent\\0.8.8\\org.jacoco.agent-0.8.8-runtime.jar=destfile=D:\\Entwicklung\\Projekte\\Maven
Surefire\\surefire-its\\target\\jacoco.exec,includes=**/failsafe/*:**/failsafe/**/*:**/surefire/*:**/surefire/**/*,excludes=**/HelpMojo.class:**/shadefire/**/*:org/jacoco/**/*:com/vladium/emma/rt/*"
-nsu -Dclean.skip=true -Dmaven.clean.skip=true -PskipFailsafe
org.apache.maven.plugins:maven-surefire-report-plugin:3.2.4-SNAPSHOT::failsafe-report-only
org.apache.maven.plugins:maven-surefire-report-plugin:3.2.4-SNAPSHOT:report-only
Syntaxfehler.
at
org.apache.maven.surefire.its.fixture.MavenLauncher.executeCurrentGoals(MavenLauncher.java:274)
at
org.apache.maven.surefire.its.fixture.SurefireLauncher.executeCurrentGoals(SurefireLauncher.java:142)
at
org.apache.maven.surefire.its.jiras.Surefire772SpecifiedReportsIT.testSkippedFailsafeReportGeneration(Surefire772SpecifiedReportsIT.java:53)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:49)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:120)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:95)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:69)
at
org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:146)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
at
org.apache.maven.surefire.boote
[jira] [Created] (SUREFIRE-2225) Surefire ITs fail when project directory contains space
Michael Osipov created SUREFIRE-2225:
Summary: Surefire ITs fail when project directory contains space
Key: SUREFIRE-2225
URL: https://issues.apache.org/jira/browse/SUREFIRE-2225
Project: Maven Surefire
Issue Type: Bug
Components: process forking
Affects Versions: 3.2.3
Reporter: Michael Osipov
Fix For: 3.2.4
Perform the following, e.g. on Windows:
{noformat}
git clone maven-surefire.git "Maven Surefire"
cd "Maven Surefire"
mvn install
mvn verify -Prun-its
{nofromat}
It will fail:
{noformat}
[ERROR]
org.apache.maven.surefire.its.jiras.Surefire772SpecifiedReportsIT.testSkippedFailsafeReportGeneration
-- Time elapsed: 0.080 s <<< ERROR!
org.apache.maven.surefire.its.fixture.SurefireVerifierException:
Exit code was non-zero: 255; command line and log =
D:\Entwicklung\Programme\apache-maven-3.8.8\bin\mvn -fn -e --batch-mode
-Dmaven.repo.local=C:\Users\mosipov\.m2\repository
org.apache.maven.plugins:maven-clean-plugin:clean
-Dsurefire.version=3.2.4-SNAPSHOT
-Djacoco.agent="-javaagent:C:\\Users\\mosipov\\.m2\\repository\\org\\jacoco\\org.jacoco.agent\\0.8.8\\org.jacoco.agent-0.8.8-runtime.jar=destfile=D:\\Entwicklung\\Projekte\\Maven
Surefire\\surefire-its\\target\\jacoco.exec,includes=**/failsafe/*:**/failsafe/**/*:**/surefire/*:**/surefire/**/*,excludes=**/HelpMojo.class:**/shadefire/**/*:org/jacoco/**/*:com/vladium/emma/rt/*"
-nsu -Dclean.skip=true -Dmaven.clean.skip=true -PskipFailsafe
org.apache.maven.plugins:maven-surefire-report-plugin:3.2.4-SNAPSHOT::failsafe-report-only
org.apache.maven.plugins:maven-surefire-report-plugin:3.2.4-SNAPSHOT:report-only
Syntaxfehler.
at
org.apache.maven.surefire.its.fixture.MavenLauncher.executeCurrentGoals(MavenLauncher.java:274)
at
org.apache.maven.surefire.its.fixture.SurefireLauncher.executeCurrentGoals(SurefireLauncher.java:142)
at
org.apache.maven.surefire.its.jiras.Surefire772SpecifiedReportsIT.testSkippedFailsafeReportGeneration(Surefire772SpecifiedReportsIT.java:53)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:49)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:120)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:95)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:69)
[jira] [Commented] (SUREFIRE-1810) Surefire plugin SurefireBooterForkException if path has Spaces in the name
[
https://issues.apache.org/jira/browse/SUREFIRE-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801400#comment-17801400
]
Michael Osipov commented on SUREFIRE-1810:
--
OK, the issue I have found isn't related to this one. You problem is selfmade:
{noformat}
${argLine} -Xms256m -Xmx2048m
-Djava.library.path=C:\Users\tcasinhas\Documents\Git\myProject
Project\sph-casetailor-casekyccddrev\context/src/main/resources
{noformat}
You have failed to quote {{java.library.path}}, this the space gives you
trouble.
[~sjaranowski], I have {{argLine}} in every single plugin with a passion
because they just cause trouble.
I consider this one as invalid.
> Surefire plugin SurefireBooterForkException if path has Spaces in the name
> --
>
> Key: SUREFIRE-1810
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1810
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M4
> Environment: OS: Microsoft Windows 10 Pro 10.0.19041 Build 19041
> Maven: 3.6.3
> Java: "11.0.7" 2020-04-14 LTS | Java(TM) SE Runtime Environment 18.9 (build
> 11.0.7+8-LTS) | Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.7+8-LTS,
> mixed mode)
>Reporter: Tiago Jorge Proença Gaspar Casinhas
>Priority: Major
> Labels: newbie
> Attachments: 2020-06-26T09-50-50_242.dumpstream, dump2.txt
>
>
> When I attempt to run tests using `mvn clean install` or similar commands
> that run through the verify phase, I get a SurefireBooterForkException if the
> path to my project contains any space.
> Example: +C:\Users\tcasinhas\Documents\Git\My Project\mproj-subproj-cases+
>
> If I remove the space, the build runs sucessfully.
> Example: +C:\Users\tcasinhas\Documents\Git\My-Project\mproj-subproj-cases+
> Notes:
> I ommited the company and project name, but left everything else in the dump
> as is.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-1810) Surefire plugin SurefireBooterForkException if path has Spaces in the name
[ https://issues.apache.org/jira/browse/SUREFIRE-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801398#comment-17801398 ] Michael Osipov commented on SUREFIRE-1810: -- I have found the cause. The Jacoco Maven Plugin is broken/fucked up/trying to be smart. > Surefire plugin SurefireBooterForkException if path has Spaces in the name > -- > > Key: SUREFIRE-1810 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1810 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 3.0.0-M4 > Environment: OS: Microsoft Windows 10 Pro 10.0.19041 Build 19041 > Maven: 3.6.3 > Java: "11.0.7" 2020-04-14 LTS | Java(TM) SE Runtime Environment 18.9 (build > 11.0.7+8-LTS) | Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.7+8-LTS, > mixed mode) >Reporter: Tiago Jorge Proença Gaspar Casinhas >Priority: Major > Labels: newbie > Attachments: 2020-06-26T09-50-50_242.dumpstream, dump2.txt > > > When I attempt to run tests using `mvn clean install` or similar commands > that run through the verify phase, I get a SurefireBooterForkException if the > path to my project contains any space. > Example: +C:\Users\tcasinhas\Documents\Git\My Project\mproj-subproj-cases+ > > If I remove the space, the build runs sucessfully. > Example: +C:\Users\tcasinhas\Documents\Git\My-Project\mproj-subproj-cases+ > Notes: > I ommited the company and project name, but left everything else in the dump > as is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.apache.maven.shared:maven-shared-utils from 3.4.1 to 3.4.2 [maven-invoker-plugin]
khmarbaise merged PR #201: URL: https://github.com/apache/maven-invoker-plugin/pull/201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump junitVersion from 5.10.0 to 5.10.1 [maven-doxia]
dependabot[bot] commented on PR #178: URL: https://github.com/apache/maven-doxia/pull/178#issuecomment-1872612323 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump junitVersion from 5.10.0 to 5.10.1 [maven-doxia]
asfgit closed pull request #178: Bump junitVersion from 5.10.0 to 5.10.1 URL: https://github.com/apache/maven-doxia/pull/178 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-721) Bump JUnit from 5.10.0 to 5.10.1
[ https://issues.apache.org/jira/browse/DOXIA-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801395#comment-17801395 ] ASF GitHub Bot commented on DOXIA-721: -- slachiewicz opened a new pull request, #191: URL: https://github.com/apache/maven-doxia/pull/191 (no comment) > Bump JUnit from 5.10.0 to 5.10.1 > > > Key: DOXIA-721 > URL: https://issues.apache.org/jira/browse/DOXIA-721 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 2.0.0, 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (DOXIA-721) Bump JUnit from 5.10.0 to 5.10.1
Sylwester Lachiewicz created DOXIA-721: -- Summary: Bump JUnit from 5.10.0 to 5.10.1 Key: DOXIA-721 URL: https://issues.apache.org/jira/browse/DOXIA-721 Project: Maven Doxia Issue Type: Dependency upgrade Reporter: Sylwester Lachiewicz Fix For: 2.0.0, 2.0.0-M9 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.apache.maven:maven-parent from 40 to 41 [maven-doxia]
dependabot[bot] commented on PR #188: URL: https://github.com/apache/maven-doxia/pull/188#issuecomment-1872604359 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven:maven-parent from 40 to 41 [maven-doxia]
asfgit closed pull request #188: Bump org.apache.maven:maven-parent from 40 to 41 URL: https://github.com/apache/maven-doxia/pull/188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DOXIATOOLS-81) Switch to Junit5
Sylwester Lachiewicz created DOXIATOOLS-81: -- Summary: Switch to Junit5 Key: DOXIATOOLS-81 URL: https://issues.apache.org/jira/browse/DOXIATOOLS-81 Project: Maven Doxia Tools Issue Type: Dependency upgrade Components: Doxia Converter Reporter: Sylwester Lachiewicz Fix For: doxia-converter-1.4 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-1507) maven-surefire-plugin version 2.20.1 giving NullPointerException
[
https://issues.apache.org/jira/browse/SUREFIRE-1507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801391#comment-17801391
]
Michael Osipov commented on SUREFIRE-1507:
--
Still waiting...
> maven-surefire-plugin version 2.20.1 giving NullPointerException
>
>
> Key: SUREFIRE-1507
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1507
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 2.20.1
>Reporter: Aleena Davy
>Priority: Minor
> Fix For: waiting-for-feedback
>
>
> My Appium-Java-Maven tests is giving the following error while running on
> Circle CI, runs fine locally
> {{[ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test (default-test) on
> project MumboiOSTests: Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:2.20.1:test failed.:
> NullPointerException}}
> versions used:
> maven: 3.5.3
> maven-surefire-plugin:2.20.1
> JUnit 4.11
> Please find the log below
> [https://gist.github.com/aleenadavy90/bdc06f953397cd5240bf41eee1dee212]
>
> Update:
> I switched the java version to 9 and everything works fine.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-1530) Surefire html report does not style correctly in chrome
[
https://issues.apache.org/jira/browse/SUREFIRE-1530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801390#comment-17801390
]
Michael Osipov commented on SUREFIRE-1530:
--
Still waiting for response...
> Surefire html report does not style correctly in chrome
> ---
>
> Key: SUREFIRE-1530
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1530
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Report Plugin
>Affects Versions: 2.21.0
>Reporter: Henning Vogt
>Priority: Minor
> Fix For: waiting-for-feedback
>
>
> Generating a surefire-report.html does not produce an html that can be
> displayed correctly with chrome. IE11 works, but e.g. chrome displays this
> errormessage:
> {code}Refused to apply inline style because it violates the following Content
> Security Policy directive: "style-src 'self'". Either the 'unsafe-inline'
> keyword, a hash ('sha256-kQThACQ+E3akfK9JEvBX7ueISL6ruT6sN9Ni6lZIRVM='), or a
> nonce ('nonce-...') is required to enable inline execution.
> surefire-report.html:1 Blocked script execution in
> 'http://mycompany.com:8081/jenkins/job/VR/job/vrservice/site/surefire-report.html'
> because the document's frame is sandboxed and the 'allow-scripts' permission
> is not set.
> Refused to apply inline style because it violates the following Content
> Security Policy directive: "style-src 'self'". Either the 'unsafe-inline'
> keyword, a hash ('sha256-a4tj1WXEmGqOxBANAF3uzawGDJwaj6X3GnmrjTUzhuc='), or a
> nonce ('nonce-...') is required to enable inline execution.
> Refused to apply inline style because it violates the following Content
> Security Policy directive: "style-src 'self'". Either the 'unsafe-inline'
> keyword, a hash ('sha256-qRVIxZQ0xPYjv3U7P4/5y8byVpOp48F0bdyO/vM0kyY='), or a
> nonce ('nonce-...') is required to enable inline execution.
> Refused to apply inline style because it violates the following Content
> Security Policy directive: "style-src 'self'". Either the 'unsafe-inline'
> keyword, a hash ('sha256-0EZqoz+oBhx7gF4nvY2bSqoGyy4zLjNF+SDQXGp/ZrY='), or a
> nonce ('nonce-...') is required to enable inline execution.
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (SUREFIRE-1732) ForkedProcessEvent class was missing while executing org.apache.maven.plugins:maven-surefire-plugin
[ https://issues.apache.org/jira/browse/SUREFIRE-1732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed SUREFIRE-1732. Fix Version/s: (was: waiting-for-feedback) Resolution: Not A Problem As far as I understand this is not an issue anymore... > ForkedProcessEvent class was missing while executing > org.apache.maven.plugins:maven-surefire-plugin > > > Key: SUREFIRE-1732 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1732 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 3.0.0-M4 >Reporter: Akanksha Jain >Priority: Major > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M4:test (default-test) > on project idgenerator: Execution default-test of goal > org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M4:test failed: A > required class was missing while executing > org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M4:test: > org/apache/maven/surefire/booter/ForkedProcessEvent [ERROR] > - [ERROR] realm = > plugin>org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M4 [ERROR] > strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy [ERROR] > urls[0] = > file:/var/lib/jenkins/.m2/repository/org/apache/maven/plugins/maven-surefire-plugin/3.0.0-M4/maven-surefire-plugin-3.0.0-M4.jar > [ERROR] urls[1] = > file:/var/lib/jenkins/.m2/repository/org/apache/maven/surefire/surefire-junit4/2.22.1/surefire-junit4-2.22.1.jar > [ERROR] urls[2] = > file:/var/lib/jenkins/.m2/repository/org/apache/maven/surefire/surefire-api/2.22.1/surefire-api-2.22.1.jar > [ERROR] urls[3] = > file:/var/lib/jenkins/.m2/repository/org/apache/maven/surefire/surefire-logger-api/2.22.1/surefire-logger-api-2.22.1.jar > [ERROR] urls[4] = > file:/var/lib/jenkins/.m2/repository/org/apache/maven/surefire/maven-surefire-common/3.0.0-M4/maven-surefire-common-3.0.0-M4.jar > [ERROR] urls[5] = > file:/var/lib/jenkins/.m2/repository/org/apache/maven/surefire/surefire-extensions-api/3.0.0-M4/surefire-extensions-api-3.0.0-M4.jar > [ERROR] urls[6] = > file:/var/lib/jenkins/.m2/repository/org/apache/maven/surefire/surefire-booter/3.0.0-M4/surefire-booter-3.0.0-M4.jar > [ERROR] urls[7] = > file:/var/lib/jenkins/.m2/repository/org/apache/maven/shared/maven-artifact-transfer/0.11.0/maven-artifact-transfer-0.11.0.jar > [ERROR] urls[8] = > file:/var/lib/jenkins/.m2/repository/org/apache/maven/shared/maven-common-artifact-filters/3.1.0/maven-common-artifact-filters-3.1.0.jar > [ERROR] urls[9] = > file:/var/lib/jenkins/.m2/repository/org/sonatype/sisu/sisu-inject-bean/1.4.2/sisu-inject-bean-1.4.2.jar > [ERROR] urls[10] = > file:/var/lib/jenkins/.m2/repository/org/sonatype/sisu/sisu-guice/2.1.7/sisu-guice-2.1.7-noaop.jar > [ERROR] urls[11] = > file:/var/lib/jenkins/.m2/repository/commons-codec/commons-codec/1.11/commons-codec-1.11.jar > [ERROR] urls[12] = > file:/var/lib/jenkins/.m2/repository/org/codehaus/plexus/plexus-java/1.0.3/plexus-java-1.0.3.jar > [ERROR] urls[13] = > file:/var/lib/jenkins/.m2/repository/org/ow2/asm/asm/7.0/asm-7.0.jar [ERROR] > urls[14] = > file:/var/lib/jenkins/.m2/repository/com/thoughtworks/qdox/qdox/2.0-M9/qdox-2.0-M9.jar > [ERROR] urls[15] = > file:/var/lib/jenkins/.m2/repository/org/codehaus/plexus/plexus-utils/1.1/plexus-utils-1.1.jar > [ERROR] Number of foreign imports: 1 [ERROR] import: Entry[import from realm > ClassRealm[maven.api, parent: null]] [ERROR] [ERROR] > -: > org.apache.maven.surefire.booter.ForkedProcessEvent -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SUREFIRE-1673) Surefire does not detect junit 5.5.0 tests when running a maven build
[ https://issues.apache.org/jira/browse/SUREFIRE-1673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed SUREFIRE-1673. Fix Version/s: (was: waiting-for-feedback) Resolution: Incomplete No response. > Surefire does not detect junit 5.5.0 tests when running a maven build > - > > Key: SUREFIRE-1673 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1673 > Project: Maven Surefire > Issue Type: Bug > Components: JUnit 5.x support >Affects Versions: 3.0.0-M1 > Environment: Java 8 maven 3.6.0 and maven 3.6.1 >Reporter: Ramon Yanez den Haan >Priority: Major > > I was using junit 5.4.2 which is correctly started by surefire 3.0.0-M1. > June 30 2019 junit 5.5.0 came out. And the only thing I did is to change the > junit version in the pom from 5.4.2 to 5.5.0 and then due to some change in > junit, surefire 3.0.0-M1 does not find any unit tests anymore: > > With junit 5.4.2: > > — maven-surefire-plugin:3.0.0-M1:test (default-test) @ > CodeQualityDataRetriever — > [INFO] > [INFO] --- > [INFO] T E S T S > [INFO] --- > * > ** > *** > Test output removed to keep the issue short > [INFO] Results: > [INFO] > [INFO] Tests run: 62, Failures: 0, Errors: 0, Skipped: 0 > > With junit 5.5.0 > — maven-surefire-plugin:3.0.0-M1:test (default-test) @ > CodeQualityDataRetriever — > [INFO] > [INFO] --- > [INFO] T E S T S > [INFO] --- > [INFO] > [INFO] Results: > [INFO] > [INFO] Tests run: 0, Failures: 0, Errors: 0, Skipped: 0 > > When I run the tests from Intellij (by clicking on it and choosing run) > intellij test runner is used which correctly runs all unit tests, with both > junit 5.4.2 or with 5.5.0 > But with the maven build with surefire it only works for junit 5.4.2 > > I see in the changelog of junit there are a lot of changes, could it be that > surefire needs to adapt the calling pattern so that it can also run junit > 5.5.0 tests? -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-1662) Invalid content of .surefire-XXXXXXXXX statistic file when parameters contain new line
[
https://issues.apache.org/jira/browse/SUREFIRE-1662?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801387#comment-17801387
]
Michael Osipov commented on SUREFIRE-1662:
--
Still waiting...
> Invalid content of .surefire-X statistic file when parameters contain
> new line
> --
>
> Key: SUREFIRE-1662
> URL: https://issues.apache.org/jira/browse/SUREFIRE-1662
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M3
>Reporter: Ondrej Lukas
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> In case when _@Parameters_ contains any new line ("_\n_") then created
> _.surefire-X_ statistic file is invalid because new line is not
> escaped in that file.
> It causes that tests can be run only once. Exception like this is thrown
> during second run:
> {code}
> Execution default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed:
> java.lang.NumberFormatException: For input string:
> "NewLine](com.example.SomeTest)"
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
> default-test of goal
> org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test failed:
> java.lang.NumberFormatException: For input string:
> "NewLine](com.example.SomeTest)"
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> (DefaultBuildPluginManager.java:148)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:148)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:117)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:81)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:956)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:288)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethod
[jira] [Updated] (SUREFIRE-1810) Surefire plugin SurefireBooterForkException if path has Spaces in the name
[ https://issues.apache.org/jira/browse/SUREFIRE-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated SUREFIRE-1810: - Fix Version/s: (was: waiting-for-feedback) > Surefire plugin SurefireBooterForkException if path has Spaces in the name > -- > > Key: SUREFIRE-1810 > URL: https://issues.apache.org/jira/browse/SUREFIRE-1810 > Project: Maven Surefire > Issue Type: Bug > Components: Maven Surefire Plugin >Affects Versions: 3.0.0-M4 > Environment: OS: Microsoft Windows 10 Pro 10.0.19041 Build 19041 > Maven: 3.6.3 > Java: "11.0.7" 2020-04-14 LTS | Java(TM) SE Runtime Environment 18.9 (build > 11.0.7+8-LTS) | Java HotSpot(TM) 64-Bit Server VM 18.9 (build 11.0.7+8-LTS, > mixed mode) >Reporter: Tiago Jorge Proença Gaspar Casinhas >Priority: Major > Labels: newbie > Attachments: 2020-06-26T09-50-50_242.dumpstream, dump2.txt > > > When I attempt to run tests using `mvn clean install` or similar commands > that run through the verify phase, I get a SurefireBooterForkException if the > path to my project contains any space. > Example: +C:\Users\tcasinhas\Documents\Git\My Project\mproj-subproj-cases+ > > If I remove the space, the build runs sucessfully. > Example: +C:\Users\tcasinhas\Documents\Git\My-Project\mproj-subproj-cases+ > Notes: > I ommited the company and project name, but left everything else in the dump > as is. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (DOXIA-720) Upgrade to Parent 41
[ https://issues.apache.org/jira/browse/DOXIA-720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIA-720. Resolution: Fixed Fixed with [cd6f0ce93f488a6504c975cef831e43777dfcd91|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=commit;h=cd6f0ce93f488a6504c975cef831e43777dfcd91]. > Upgrade to Parent 41 > > > Key: DOXIA-720 > URL: https://issues.apache.org/jira/browse/DOXIA-720 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-717) Upgrade to org.codehaus.plexus:plexus-testing 1.3.0
[ https://issues.apache.org/jira/browse/DOXIA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801383#comment-17801383 ] ASF GitHub Bot commented on DOXIA-717: -- asfgit merged PR #190: URL: https://github.com/apache/maven-doxia/pull/190 > Upgrade to org.codehaus.plexus:plexus-testing 1.3.0 > --- > > Key: DOXIA-717 > URL: https://issues.apache.org/jira/browse/DOXIA-717 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Minor > Fix For: 2.0.0, 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (DOXIA-717) Upgrade to org.codehaus.plexus:plexus-testing 1.3.0
[ https://issues.apache.org/jira/browse/DOXIA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIA-717. Resolution: Fixed Fixed with [6056509c937713463e7eaad8c4e23150376178aa|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=commit;h=6056509c937713463e7eaad8c4e23150376178aa]. > Upgrade to org.codehaus.plexus:plexus-testing 1.3.0 > --- > > Key: DOXIA-717 > URL: https://issues.apache.org/jira/browse/DOXIA-717 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Minor > Fix For: 2.0.0, 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIA-717] Update org.codehaus.plexus:plexus-testing to 1.3.0 [maven-doxia]
asfgit merged PR #190: URL: https://github.com/apache/maven-doxia/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-1810) Surefire plugin SurefireBooterForkException if path has Spaces in the name
[
https://issues.apache.org/jira/browse/SUREFIRE-1810?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801382#comment-17801382
]
Michael Osipov commented on SUREFIRE-1810:
--
I can, unfortunately confirm this with:
{noformat}
git clone https://gitbox.apache.org/repos/asf/maven-surefire.git "Maven
Surefire"
...
[ERROR]
org.apache.maven.surefire.its.jiras.Surefire772SpecifiedReportsIT.testSkippedFailsafeReportGeneration
-- Time elapsed: 0.080 s <<< ERROR!
org.apache.maven.surefire.its.fixture.SurefireVerifierException:
Exit code was non-zero: 255; command line and log =
D:\Entwicklung\Programme\apache-maven-3.8.8\bin\mvn -fn -e --batch-mode
-Dmaven.repo.local=C:\Users\mosipov\.m2\repository
org.apache.maven.plugins:maven-clean-plugin:clean
-Dsurefire.version=3.2.4-SNAPSHOT
-Djacoco.agent="-javaagent:C:\\Users\\mosipov\\.m2\\repository\\org\\jacoco\\org.jacoco.agent\\0.8.8\\org.jacoco.agent-0.8.8-runtime.jar=destfile=D:\\Entwicklung\\Projekte\\Maven
Surefire\\surefire-its\\target\\jacoco.exec,includes=**/failsafe/*:**/failsafe/**/*:**/surefire/*:**/surefire/**/*,excludes=**/HelpMojo.class:**/shadefire/**/*:org/jacoco/**/*:com/vladium/emma/rt/*"
-nsu -Dclean.skip=true -Dmaven.clean.skip=true -PskipFailsafe
org.apache.maven.plugins:maven-surefire-report-plugin:3.2.4-SNAPSHOT::failsafe-report-only
org.apache.maven.plugins:maven-surefire-report-plugin:3.2.4-SNAPSHOT:report-only
Syntaxfehler.
at
org.apache.maven.surefire.its.fixture.MavenLauncher.executeCurrentGoals(MavenLauncher.java:274)
at
org.apache.maven.surefire.its.fixture.SurefireLauncher.executeCurrentGoals(SurefireLauncher.java:142)
at
org.apache.maven.surefire.its.jiras.Surefire772SpecifiedReportsIT.testSkippedFailsafeReportGeneration(Surefire772SpecifiedReportsIT.java:53)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)
at
org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
at
org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
at
org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
at
org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at
org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
at
org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.junit.runners.Suite.runChild(Suite.java:128)
at org.junit.runners.Suite.runChild(Suite.java:27)
at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
at org.apache.maven.surefire.junitcore.JUnitCore.run(JUnitCore.java:49)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.createRequestAndRun(JUnitCoreWrapper.java:120)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.executeEager(JUnitCoreWrapper.java:95)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:75)
at
org.apache.maven.surefire.junitcore.JUnitCoreWrapper.execute(JUnitCoreWrapper.java:69)
at
org.apache.maven.surefire.junitcore.JUnitCoreProvider.invoke(JUnitCoreProvider.java:146)
at
org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:385)
at
org.apache.maven.surefire.booter.ForkedBoot
[jira] [Updated] (DOXIA-717) Upgrade to org.codehaus.plexus:plexus-testing 1.3.0
[ https://issues.apache.org/jira/browse/DOXIA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-717: - Summary: Upgrade to org.codehaus.plexus:plexus-testing 1.3.0 (was: Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0) > Upgrade to org.codehaus.plexus:plexus-testing 1.3.0 > --- > > Key: DOXIA-717 > URL: https://issues.apache.org/jira/browse/DOXIA-717 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Minor > Fix For: 2.0.0, 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (DOXIA-717) Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0
[ https://issues.apache.org/jira/browse/DOXIA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-717: - Fix Version/s: 2.0.0 > Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0 > - > > Key: DOXIA-717 > URL: https://issues.apache.org/jira/browse/DOXIA-717 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 2.0.0, 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (DOXIA-717) Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0
[ https://issues.apache.org/jira/browse/DOXIA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned DOXIA-717: Assignee: Michael Osipov > Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0 > - > > Key: DOXIA-717 > URL: https://issues.apache.org/jira/browse/DOXIA-717 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Minor > Fix For: 2.0.0, 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (DOXIA-720) Upgrade to Parent 41
Michael Osipov created DOXIA-720: Summary: Upgrade to Parent 41 Key: DOXIA-720 URL: https://issues.apache.org/jira/browse/DOXIA-720 Project: Maven Doxia Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 2.0.0, 2.0.0-M9 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump commons-io:commons-io from 2.11.0 to 2.15.1 [maven-doxia]
dependabot[bot] closed pull request #189: Bump commons-io:commons-io from 2.11.0 to 2.15.1 URL: https://github.com/apache/maven-doxia/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump commons-io:commons-io from 2.11.0 to 2.15.1 [maven-doxia]
dependabot[bot] commented on PR #189: URL: https://github.com/apache/maven-doxia/pull/189#issuecomment-1872585783 Looks like commons-io:commons-io is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DOXIA-719) Properly manage Commons IO/Lang 3
Michael Osipov created DOXIA-719: Summary: Properly manage Commons IO/Lang 3 Key: DOXIA-719 URL: https://issues.apache.org/jira/browse/DOXIA-719 Project: Maven Doxia Issue Type: Dependency upgrade Affects Versions: 2.0.0-M8 Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 2.0.0, 2.0.0-M9 They should be in the parent with Lang at 3.14.0 and IO at 2.15.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (DOXIA-719) Properly manage Commons IO/Lang 3
[ https://issues.apache.org/jira/browse/DOXIA-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIA-719. Resolution: Fixed Fixed with [87e8ba0e44fd5bea37edacbea62f6936c2274914|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=commit;h=87e8ba0e44fd5bea37edacbea62f6936c2274914]. > Properly manage Commons IO/Lang 3 > - > > Key: DOXIA-719 > URL: https://issues.apache.org/jira/browse/DOXIA-719 > Project: Maven Doxia > Issue Type: Dependency upgrade >Affects Versions: 2.0.0-M8 >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M9 > > > They should be in the parent with Lang at 3.14.0 and IO at 2.15.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (SUREFIRE-2118) surefire-report xml format not compliant with xsi for test failing in all of the re-runs
[
https://issues.apache.org/jira/browse/SUREFIRE-2118?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed SUREFIRE-2118.
Fix Version/s: (was: waiting-for-feedback)
Resolution: Incomplete
No sample project provided.
> surefire-report xml format not compliant with xsi for test failing in all of
> the re-runs
>
>
> Key: SUREFIRE-2118
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2118
> Project: Maven Surefire
> Issue Type: Bug
> Components: Junit 4.7+ (parallel) support, Maven Surefire Plugin,
> xml generation
>Affects Versions: 3.0.0-M7
>Reporter: Yamini
>Priority: Major
>
> We expect the format of surefire .xml report for test failing in all rerun to
> be as mentioned in
> [https://maven.apache.org/surefire/maven-surefire-plugin/examples/rerun-failing-tests.html#:~:text=2)-,The%20test%20fails%20in%20all%20of%20the%20re%2Druns%3A,-failure%20and%20error]
>
> But, I can see the following format for my run
> rerunFailingTestsCount = 2
> {code:java}
>
> first failure stack trace
>
> rerun failure stack trace
>
>
> rerun failure stack trace
> rerun failure
>
> {code}
> we have only one in last rerunFailure. is missing
> under and first
>
> surefire-plugin
> {code:java}
>
> org.apache.maven.plugins
> maven-surefire-plugin
> 3.0.0-M7
>
>
> org.apache.maven.surefire
> surefire-junit47
> 3.0.0-M7
>
>
>
>
>
> true
>
> all
> 4
> 1C
> ${tests.groups}
> 2
>
> {code}
>
> Why is it not compliant? Can the issue be fixed?
> Please let me know if you need any more information.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-716) Update and unify XMLReader creation and configuration
[
https://issues.apache.org/jira/browse/DOXIA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801377#comment-17801377
]
ASF GitHub Bot commented on DOXIA-716:
--
asfgit merged PR #187:
URL: https://github.com/apache/maven-doxia/pull/187
> Update and unify XMLReader creation and configuration
> -
>
> Key: DOXIA-716
> URL: https://issues.apache.org/jira/browse/DOXIA-716
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M9
>
>
> * {{XMLReaderFactory}} is deprecated from Java 9
> * Force XML Schema as main language if both DTD and XSD are provided
> * Force {{Locale#ROOT}} for portability
> * Remove old Xerces hack
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (DOXIA-716) Update and unify XMLReader creation and configuration
[
https://issues.apache.org/jira/browse/DOXIA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov closed DOXIA-716.
Resolution: Fixed
Fixed with
[e43b2001d52119a1f48815180effd2ce643809ae|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=commit;h=e43b2001d52119a1f48815180effd2ce643809ae].
> Update and unify XMLReader creation and configuration
> -
>
> Key: DOXIA-716
> URL: https://issues.apache.org/jira/browse/DOXIA-716
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M9
>
>
> * {{XMLReaderFactory}} is deprecated from Java 9
> * Force XML Schema as main language if both DTD and XSD are provided
> * Force {{Locale#ROOT}} for portability
> * Remove old Xerces hack
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (DOXIA-716) Update and unify XMLReader creation and configuration
[
https://issues.apache.org/jira/browse/DOXIA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated DOXIA-716:
-
Fix Version/s: 2.0.0
> Update and unify XMLReader creation and configuration
> -
>
> Key: DOXIA-716
> URL: https://issues.apache.org/jira/browse/DOXIA-716
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M9
>
>
> * {{XMLReaderFactory}} is deprecated from Java 9
> * Force XML Schema as main language if both DTD and XSD are provided
> * Force {{Locale#ROOT}} for portability
> * Remove old Xerces hack
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-716] Update and unify XMLReader creation and configuration [maven-doxia]
asfgit merged PR #187: URL: https://github.com/apache/maven-doxia/pull/187 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-716) Update and unify XMLReader creation and configuration
[
https://issues.apache.org/jira/browse/DOXIA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801373#comment-17801373
]
ASF GitHub Bot commented on DOXIA-716:
--
michael-o commented on code in PR #187:
URL: https://github.com/apache/maven-doxia/pull/187#discussion_r1438663904
##
doxia-core/src/main/java/org/apache/maven/doxia/util/XmlValidator.java:
##
@@ -65,57 +86,42 @@ public class XmlValidator {
*/
public void validate(String content) throws ParseException {
try {
-// 1 if there's a doctype
-boolean hasDoctype = false;
-Matcher matcher = PATTERN_DOCTYPE.matcher(content);
-if (matcher.find()) {
-hasDoctype = true;
-}
-
-// 2 check for an xmlns instance
-boolean hasXsd = false;
-matcher = PATTERN_TAG.matcher(content);
-if (matcher.find()) {
-String value = matcher.group(2);
-
-if
(value.contains(XMLConstants.W3C_XML_SCHEMA_INSTANCE_NS_URI)) {
-hasXsd = true;
-}
-}
-
-// 3 validate content
-getXmlReader(hasXsd && hasDoctype).parse(new InputSource(new
StringReader(content)));
-} catch (IOException | SAXException e) {
+getXmlReader().parse(new InputSource(new StringReader(content)));
+} catch (IOException | SAXException | ParserConfigurationException e) {
throw new ParseException("Error validating the model", e);
}
}
/**
- * @param hasDtdAndXsd to flag the ErrorHandler.
* @return an xmlReader instance.
* @throws SAXException if any
+ * @throws ParserConfigurationException
*/
-private XMLReader getXmlReader(boolean hasDtdAndXsd) throws SAXException {
+public XMLReader getXmlReader() throws SAXException,
ParserConfigurationException {
if (xmlReader == null) {
Review Comment:
No objections, but that would be a behavioral change and should be a
separate issue.
> Update and unify XMLReader creation and configuration
> -
>
> Key: DOXIA-716
> URL: https://issues.apache.org/jira/browse/DOXIA-716
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M9
>
>
> * {{XMLReaderFactory}} is deprecated from Java 9
> * Force XML Schema as main language if both DTD and XSD are provided
> * Force {{Locale#ROOT}} for portability
> * Remove old Xerces hack
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-716] Update and unify XMLReader creation and configuration [maven-doxia]
michael-o commented on code in PR #187:
URL: https://github.com/apache/maven-doxia/pull/187#discussion_r1438663904
##
doxia-core/src/main/java/org/apache/maven/doxia/util/XmlValidator.java:
##
@@ -65,57 +86,42 @@ public class XmlValidator {
*/
public void validate(String content) throws ParseException {
try {
-// 1 if there's a doctype
-boolean hasDoctype = false;
-Matcher matcher = PATTERN_DOCTYPE.matcher(content);
-if (matcher.find()) {
-hasDoctype = true;
-}
-
-// 2 check for an xmlns instance
-boolean hasXsd = false;
-matcher = PATTERN_TAG.matcher(content);
-if (matcher.find()) {
-String value = matcher.group(2);
-
-if
(value.contains(XMLConstants.W3C_XML_SCHEMA_INSTANCE_NS_URI)) {
-hasXsd = true;
-}
-}
-
-// 3 validate content
-getXmlReader(hasXsd && hasDoctype).parse(new InputSource(new
StringReader(content)));
-} catch (IOException | SAXException e) {
+getXmlReader().parse(new InputSource(new StringReader(content)));
+} catch (IOException | SAXException | ParserConfigurationException e) {
throw new ParseException("Error validating the model", e);
}
}
/**
- * @param hasDtdAndXsd to flag the ErrorHandler.
* @return an xmlReader instance.
* @throws SAXException if any
+ * @throws ParserConfigurationException
*/
-private XMLReader getXmlReader(boolean hasDtdAndXsd) throws SAXException {
+public XMLReader getXmlReader() throws SAXException,
ParserConfigurationException {
if (xmlReader == null) {
Review Comment:
No objections, but that would be a behavioral change and should be a
separate issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MNG-7986) Spurious JUnit 4.12 jar on boot classpath
[
https://issues.apache.org/jira/browse/MNG-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Karl Heinz Marbaise updated MNG-7986:
-
Fix Version/s: waiting-for-feedback
> Spurious JUnit 4.12 jar on boot classpath
> -
>
> Key: MNG-7986
> URL: https://issues.apache.org/jira/browse/MNG-7986
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-9
>Reporter: Jean Gauthier
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: output-maven-4.0.0-alpha8-surefire-2.22.2.txt,
> output-maven-4.0.0-alpha9-surefire-2.22.2.txt,
> output-maven-4.0.0-alpha9-surefire-3.0.0-M4.txt, reproducer.zip
>
>
> We noticed a regression in Maven 4.0.0-alpha9 for Surefire versions
> 2.21.0-3.0.0-M3: when specifying a dependency to JUnit 4.13, JUnit 4.12 gets
> added before it on the boot classpath.
> This causes issues e.g. when defining a custom JUnit 4 RunListener in a
> project: because JUnit 4.12 is listed first, the new {{testSuiteStarted}}
> callback that was added in 4.13 does not get invoked anymore.
> This can be reproduced by running {{./mvnw clean test
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugin.surefire.SurefirePlugin=debug}}
> on the attached project (and setting the Maven/Surefire versions
> accordingly).
> I have also added the output logs for the following version combinations as
> attachment to the ticket:
> * Maven 4.0.0-alpha8 + Surefire 2.22.2 => works correctly (contains
> {{RunListener - testSuiteStarted}})
> * Maven 4.0.0-alpha9 + Surefire 2.22.2 => broken (does not contain
> {{RunListener - testSuiteStarted}})
> * Maven 4.0.0-alpha9 + Surefire 3.0.0-M4 => works correctly (contains
> {{RunListener - testSuiteStarted}})
> Please let me know in case additional information is needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7986) Spurious JUnit 4.12 jar on boot classpath
[
https://issues.apache.org/jira/browse/MNG-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801370#comment-17801370
]
Karl Heinz Marbaise commented on MNG-7986:
--
That reproducer example contains a lot of far outdated plugins (apart from
usign Java 7 as target). I have updated all the plugins in the example in
relationship to https://maven.apache.org/plugins/ (most recent versions).
I tested with Maven 4.0.0-alpha-10, 3.9.6, 3.8.8, 3.6.3, 3.5.4, 3.3.9 and as
[~michael-o] suggest using Surefire 3.2.3 and it shows the expected output:
{code}
[INFO] --- maven-surefire-plugin:3.2.3:test (default-test) @ reproducer ---
[INFO] Using auto detected provider
org.apache.maven.surefire.junit4.JUnit4Provider
[INFO]
[INFO] ---
[INFO] T E S T S
[INFO] ---
Creation of Run Listener...
[INFO] Running org.example.SimpleTest
RunListener - testSuiteStarted
RunListener - testStarted
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.021 s
-- in org.example.SimpleTest
[INFO]
{code}
That means in consequence you should upgrade all the plugins you are using
including the Maven version... We have a new alpha-10 version of Maven 4
available... https://maven.apache.org/docs/history.html
it's great to see people are testing with the new Maven 4.0.0 alpha versions,
but I recommend to test with most recent version of the plugins. Also I
recommend to take into account that JUnit 4.X might be out-of-date as well and
should be replaced it with JUnit Jupiter (aka JUnit 5) https://junit.org/junit5/
> Spurious JUnit 4.12 jar on boot classpath
> -
>
> Key: MNG-7986
> URL: https://issues.apache.org/jira/browse/MNG-7986
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-9
>Reporter: Jean Gauthier
>Priority: Major
> Attachments: output-maven-4.0.0-alpha8-surefire-2.22.2.txt,
> output-maven-4.0.0-alpha9-surefire-2.22.2.txt,
> output-maven-4.0.0-alpha9-surefire-3.0.0-M4.txt, reproducer.zip
>
>
> We noticed a regression in Maven 4.0.0-alpha9 for Surefire versions
> 2.21.0-3.0.0-M3: when specifying a dependency to JUnit 4.13, JUnit 4.12 gets
> added before it on the boot classpath.
> This causes issues e.g. when defining a custom JUnit 4 RunListener in a
> project: because JUnit 4.12 is listed first, the new {{testSuiteStarted}}
> callback that was added in 4.13 does not get invoked anymore.
> This can be reproduced by running {{./mvnw clean test
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugin.surefire.SurefirePlugin=debug}}
> on the attached project (and setting the Maven/Surefire versions
> accordingly).
> I have also added the output logs for the following version combinations as
> attachment to the ticket:
> * Maven 4.0.0-alpha8 + Surefire 2.22.2 => works correctly (contains
> {{RunListener - testSuiteStarted}})
> * Maven 4.0.0-alpha9 + Surefire 2.22.2 => broken (does not contain
> {{RunListener - testSuiteStarted}})
> * Maven 4.0.0-alpha9 + Surefire 3.0.0-M4 => works correctly (contains
> {{RunListener - testSuiteStarted}})
> Please let me know in case additional information is needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-interpolation from 1.26 to 1.27 [maven-invoker-plugin]
khmarbaise merged PR #206: URL: https://github.com/apache/maven-invoker-plugin/pull/206 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-716) Update and unify XMLReader creation and configuration
[
https://issues.apache.org/jira/browse/DOXIA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801362#comment-17801362
]
ASF GitHub Bot commented on DOXIA-716:
--
kwin commented on code in PR #187:
URL: https://github.com/apache/maven-doxia/pull/187#discussion_r1438615161
##
doxia-core/src/main/java/org/apache/maven/doxia/util/XmlValidator.java:
##
@@ -65,57 +86,42 @@ public class XmlValidator {
*/
public void validate(String content) throws ParseException {
try {
-// 1 if there's a doctype
-boolean hasDoctype = false;
-Matcher matcher = PATTERN_DOCTYPE.matcher(content);
-if (matcher.find()) {
-hasDoctype = true;
-}
-
-// 2 check for an xmlns instance
-boolean hasXsd = false;
-matcher = PATTERN_TAG.matcher(content);
-if (matcher.find()) {
-String value = matcher.group(2);
-
-if
(value.contains(XMLConstants.W3C_XML_SCHEMA_INSTANCE_NS_URI)) {
-hasXsd = true;
-}
-}
-
-// 3 validate content
-getXmlReader(hasXsd && hasDoctype).parse(new InputSource(new
StringReader(content)));
-} catch (IOException | SAXException e) {
+getXmlReader().parse(new InputSource(new StringReader(content)));
+} catch (IOException | SAXException | ParserConfigurationException e) {
throw new ParseException("Error validating the model", e);
}
}
/**
- * @param hasDtdAndXsd to flag the ErrorHandler.
* @return an xmlReader instance.
* @throws SAXException if any
+ * @throws ParserConfigurationException
*/
-private XMLReader getXmlReader(boolean hasDtdAndXsd) throws SAXException {
+public XMLReader getXmlReader() throws SAXException,
ParserConfigurationException {
if (xmlReader == null) {
Review Comment:
I am not sure if caching is wise here, as SAXParser/SAXParserFactory is not
not thread-safe AFAIK
(https://docs.oracle.com/cd/E17802_01/webservices/webservices/docs/1.5/api/javax/xml/parsers/SAXParserFactory.html).
At least this should be documented in the javadoc that the returned XMLReader
needs to be synchronized somehow to be used among multiple threads.
> Update and unify XMLReader creation and configuration
> -
>
> Key: DOXIA-716
> URL: https://issues.apache.org/jira/browse/DOXIA-716
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M9
>
>
> * {{XMLReaderFactory}} is deprecated from Java 9
> * Force XML Schema as main language if both DTD and XSD are provided
> * Force {{Locale#ROOT}} for portability
> * Remove old Xerces hack
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-716] Update and unify XMLReader creation and configuration [maven-doxia]
kwin commented on code in PR #187:
URL: https://github.com/apache/maven-doxia/pull/187#discussion_r1438615161
##
doxia-core/src/main/java/org/apache/maven/doxia/util/XmlValidator.java:
##
@@ -65,57 +86,42 @@ public class XmlValidator {
*/
public void validate(String content) throws ParseException {
try {
-// 1 if there's a doctype
-boolean hasDoctype = false;
-Matcher matcher = PATTERN_DOCTYPE.matcher(content);
-if (matcher.find()) {
-hasDoctype = true;
-}
-
-// 2 check for an xmlns instance
-boolean hasXsd = false;
-matcher = PATTERN_TAG.matcher(content);
-if (matcher.find()) {
-String value = matcher.group(2);
-
-if
(value.contains(XMLConstants.W3C_XML_SCHEMA_INSTANCE_NS_URI)) {
-hasXsd = true;
-}
-}
-
-// 3 validate content
-getXmlReader(hasXsd && hasDoctype).parse(new InputSource(new
StringReader(content)));
-} catch (IOException | SAXException e) {
+getXmlReader().parse(new InputSource(new StringReader(content)));
+} catch (IOException | SAXException | ParserConfigurationException e) {
throw new ParseException("Error validating the model", e);
}
}
/**
- * @param hasDtdAndXsd to flag the ErrorHandler.
* @return an xmlReader instance.
* @throws SAXException if any
+ * @throws ParserConfigurationException
*/
-private XMLReader getXmlReader(boolean hasDtdAndXsd) throws SAXException {
+public XMLReader getXmlReader() throws SAXException,
ParserConfigurationException {
if (xmlReader == null) {
Review Comment:
I am not sure if caching is wise here, as SAXParser/SAXParserFactory is not
not thread-safe AFAIK
(https://docs.oracle.com/cd/E17802_01/webservices/webservices/docs/1.5/api/javax/xml/parsers/SAXParserFactory.html).
At least this should be documented in the javadoc that the returned XMLReader
needs to be synchronized somehow to be used among multiple threads.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIA-717) Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0
[ https://issues.apache.org/jira/browse/DOXIA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801360#comment-17801360 ] ASF GitHub Bot commented on DOXIA-717: -- michael-o commented on code in PR #190: URL: https://github.com/apache/maven-doxia/pull/190#discussion_r1438604080 ## pom.xml: ## @@ -188,8 +188,8 @@ under the License. com.google.inject guice -4.2.3 -no_aop +6.0.0 +test Review Comment: Alright, I see. Please leave a comment in the commit message so that this information does not get lost. > Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0 > - > > Key: DOXIA-717 > URL: https://issues.apache.org/jira/browse/DOXIA-717 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIA-717] Update org.codehaus.plexus:plexus-testing to 1.3.0 [maven-doxia]
michael-o commented on code in PR #190: URL: https://github.com/apache/maven-doxia/pull/190#discussion_r1438604080 ## pom.xml: ## @@ -188,8 +188,8 @@ under the License. com.google.inject guice -4.2.3 -no_aop +6.0.0 +test Review Comment: Alright, I see. Please leave a comment in the commit message so that this information does not get lost. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (DOXIASITETOOLS-322) Upgrade to Doxia 2.0.0-M9
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-322?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIASITETOOLS-322: -- Fix Version/s: 2.0.0-M17 2.0.0 (was: 2.0.0-M13) > Upgrade to Doxia 2.0.0-M9 > - > > Key: DOXIASITETOOLS-322 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-322 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M17 > > > This requires accommodations for DOXIA-709. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-717) Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0
[ https://issues.apache.org/jira/browse/DOXIA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801359#comment-17801359 ] ASF GitHub Bot commented on DOXIA-717: -- slachiewicz commented on code in PR #190: URL: https://github.com/apache/maven-doxia/pull/190#discussion_r1438603150 ## pom.xml: ## @@ -188,8 +188,8 @@ under the License. com.google.inject guice -4.2.3 -no_aop +6.0.0 +test Review Comment: Plexus testing uses it. With the old version - tests will fail > Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0 > - > > Key: DOXIA-717 > URL: https://issues.apache.org/jira/browse/DOXIA-717 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIA-717] Update org.codehaus.plexus:plexus-testing to 1.3.0 [maven-doxia]
slachiewicz commented on code in PR #190: URL: https://github.com/apache/maven-doxia/pull/190#discussion_r1438603150 ## pom.xml: ## @@ -188,8 +188,8 @@ under the License. com.google.inject guice -4.2.3 -no_aop +6.0.0 +test Review Comment: Plexus testing uses it. With the old version - tests will fail -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-717) Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0
[ https://issues.apache.org/jira/browse/DOXIA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801358#comment-17801358 ] ASF GitHub Bot commented on DOXIA-717: -- michael-o commented on code in PR #190: URL: https://github.com/apache/maven-doxia/pull/190#discussion_r1438602545 ## pom.xml: ## @@ -188,8 +188,8 @@ under the License. com.google.inject guice -4.2.3 -no_aop +6.0.0 +test Review Comment: How does this relate to Plexus Testing? > Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0 > - > > Key: DOXIA-717 > URL: https://issues.apache.org/jira/browse/DOXIA-717 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIA-717] Update org.codehaus.plexus:plexus-testing to 1.3.0 [maven-doxia]
michael-o commented on code in PR #190: URL: https://github.com/apache/maven-doxia/pull/190#discussion_r1438602545 ## pom.xml: ## @@ -188,8 +188,8 @@ under the License. com.google.inject guice -4.2.3 -no_aop +6.0.0 +test Review Comment: How does this relate to Plexus Testing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-718) Apply best security recommendations to xml parsing and validation
[
https://issues.apache.org/jira/browse/DOXIA-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801357#comment-17801357
]
Michael Osipov commented on DOXIA-718:
--
I have tried to modify the {{XmlValidator}} class and run Doxia Sitetools tests
with {{entitityTest.xml}}. All of the are still resolved. I consider this test
to fail so the config does not seem to be complete. Also disabling DTDs will
break valid use cases Xdoc and FML support...
> Apply best security recommendations to xml parsing and validation
> -
>
> Key: DOXIA-718
> URL: https://issues.apache.org/jira/browse/DOXIA-718
> Project: Maven Doxia
> Issue Type: Improvement
>Reporter: Sylwester Lachiewicz
>Priority: Minor
>
> Apply OWASP recommendation if needed
>
> [https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-540) Update/remove ancient information on Doxia site
[ https://issues.apache.org/jira/browse/DOXIA-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801355#comment-17801355 ] ASF GitHub Bot commented on DOXIA-540: -- elharo merged PR #32: URL: https://github.com/apache/maven-doxia-site/pull/32 > Update/remove ancient information on Doxia site > --- > > Key: DOXIA-540 > URL: https://issues.apache.org/jira/browse/DOXIA-540 > Project: Maven Doxia > Issue Type: Task > Components: Documentation >Reporter: Michael Osipov >Priority: Major > Labels: up-for-grabs > Time Spent: 10m > Remaining Estimate: 0h > > Tasks to perform: > * Remove [Developer Docs|http://maven.apache.org/doxia/] for ancient versions. > * Remove Doxia IDE intergration is there is none working > * Remove [Upgrading|http://maven.apache.org/doxia/upgrading.html], it is > overhauled. > * Check [FAQ|http://maven.apache.org/doxia/faq.html] for validity. > * Merge [Apt > Enhancements|http://maven.apache.org/doxia/references/doxia-apt.html] into > [main site|http://maven.apache.org/doxia/references/apt-format.html]. > * Check [Issues|http://maven.apache.org/doxia/issues/index.html] for > validity. > * Update [External Resources|http://maven.apache.org/doxia/resources.html]. > * Remove ancient information from [Sink > API|http://maven.apache.org/doxia/doxia/doxia-sink-api/index.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-540) Update/remove ancient information on Doxia site
[ https://issues.apache.org/jira/browse/DOXIA-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801354#comment-17801354 ] ASF GitHub Bot commented on DOXIA-540: -- elharo merged PR #33: URL: https://github.com/apache/maven-doxia-site/pull/33 > Update/remove ancient information on Doxia site > --- > > Key: DOXIA-540 > URL: https://issues.apache.org/jira/browse/DOXIA-540 > Project: Maven Doxia > Issue Type: Task > Components: Documentation >Reporter: Michael Osipov >Priority: Major > Labels: up-for-grabs > Time Spent: 10m > Remaining Estimate: 0h > > Tasks to perform: > * Remove [Developer Docs|http://maven.apache.org/doxia/] for ancient versions. > * Remove Doxia IDE intergration is there is none working > * Remove [Upgrading|http://maven.apache.org/doxia/upgrading.html], it is > overhauled. > * Check [FAQ|http://maven.apache.org/doxia/faq.html] for validity. > * Merge [Apt > Enhancements|http://maven.apache.org/doxia/references/doxia-apt.html] into > [main site|http://maven.apache.org/doxia/references/apt-format.html]. > * Check [Issues|http://maven.apache.org/doxia/issues/index.html] for > validity. > * Update [External Resources|http://maven.apache.org/doxia/resources.html]. > * Remove ancient information from [Sink > API|http://maven.apache.org/doxia/doxia/doxia-sink-api/index.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIA-540] remove markmail links [maven-doxia-site]
elharo merged PR #32: URL: https://github.com/apache/maven-doxia-site/pull/32 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DOXIA-540] Remove IDE integration [maven-doxia-site]
elharo merged PR #33: URL: https://github.com/apache/maven-doxia-site/pull/33 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-540) Update/remove ancient information on Doxia site
[ https://issues.apache.org/jira/browse/DOXIA-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801353#comment-17801353 ] Elliotte Rusty Harold commented on DOXIA-540: - Pending open PRs I think this is all done except possibly "Check Issues for validity" if anyone feels competent to judge that > Update/remove ancient information on Doxia site > --- > > Key: DOXIA-540 > URL: https://issues.apache.org/jira/browse/DOXIA-540 > Project: Maven Doxia > Issue Type: Task > Components: Documentation >Reporter: Michael Osipov >Priority: Major > Labels: up-for-grabs > Time Spent: 10m > Remaining Estimate: 0h > > Tasks to perform: > * Remove [Developer Docs|http://maven.apache.org/doxia/] for ancient versions. > * Remove Doxia IDE intergration is there is none working > * Remove [Upgrading|http://maven.apache.org/doxia/upgrading.html], it is > overhauled. > * Check [FAQ|http://maven.apache.org/doxia/faq.html] for validity. > * Merge [Apt > Enhancements|http://maven.apache.org/doxia/references/doxia-apt.html] into > [main site|http://maven.apache.org/doxia/references/apt-format.html]. > * Check [Issues|http://maven.apache.org/doxia/issues/index.html] for > validity. > * Update [External Resources|http://maven.apache.org/doxia/resources.html]. > * Remove ancient information from [Sink > API|http://maven.apache.org/doxia/doxia/doxia-sink-api/index.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-540) Update/remove ancient information on Doxia site
[ https://issues.apache.org/jira/browse/DOXIA-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801352#comment-17801352 ] ASF GitHub Bot commented on DOXIA-540: -- elharo opened a new pull request, #33: URL: https://github.com/apache/maven-doxia-site/pull/33 Per @mosipov none of this is working > Update/remove ancient information on Doxia site > --- > > Key: DOXIA-540 > URL: https://issues.apache.org/jira/browse/DOXIA-540 > Project: Maven Doxia > Issue Type: Task > Components: Documentation >Reporter: Michael Osipov >Priority: Major > Labels: up-for-grabs > Time Spent: 10m > Remaining Estimate: 0h > > Tasks to perform: > * Remove [Developer Docs|http://maven.apache.org/doxia/] for ancient versions. > * Remove Doxia IDE intergration is there is none working > * Remove [Upgrading|http://maven.apache.org/doxia/upgrading.html], it is > overhauled. > * Check [FAQ|http://maven.apache.org/doxia/faq.html] for validity. > * Merge [Apt > Enhancements|http://maven.apache.org/doxia/references/doxia-apt.html] into > [main site|http://maven.apache.org/doxia/references/apt-format.html]. > * Check [Issues|http://maven.apache.org/doxia/issues/index.html] for > validity. > * Update [External Resources|http://maven.apache.org/doxia/resources.html]. > * Remove ancient information from [Sink > API|http://maven.apache.org/doxia/doxia/doxia-sink-api/index.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [DOXIA-540] Remove IDE integration [maven-doxia-site]
elharo opened a new pull request, #33: URL: https://github.com/apache/maven-doxia-site/pull/33 Per @mosipov none of this is working -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-540) Update/remove ancient information on Doxia site
[ https://issues.apache.org/jira/browse/DOXIA-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801351#comment-17801351 ] ASF GitHub Bot commented on DOXIA-540: -- elharo opened a new pull request, #32: URL: https://github.com/apache/maven-doxia-site/pull/32 sadly defunct > Update/remove ancient information on Doxia site > --- > > Key: DOXIA-540 > URL: https://issues.apache.org/jira/browse/DOXIA-540 > Project: Maven Doxia > Issue Type: Task > Components: Documentation >Reporter: Michael Osipov >Priority: Major > Labels: up-for-grabs > Time Spent: 10m > Remaining Estimate: 0h > > Tasks to perform: > * Remove [Developer Docs|http://maven.apache.org/doxia/] for ancient versions. > * Remove Doxia IDE intergration is there is none working > * Remove [Upgrading|http://maven.apache.org/doxia/upgrading.html], it is > overhauled. > * Check [FAQ|http://maven.apache.org/doxia/faq.html] for validity. > * Merge [Apt > Enhancements|http://maven.apache.org/doxia/references/doxia-apt.html] into > [main site|http://maven.apache.org/doxia/references/apt-format.html]. > * Check [Issues|http://maven.apache.org/doxia/issues/index.html] for > validity. > * Update [External Resources|http://maven.apache.org/doxia/resources.html]. > * Remove ancient information from [Sink > API|http://maven.apache.org/doxia/doxia/doxia-sink-api/index.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [DOXIA-540] remove markmail links [maven-doxia-site]
elharo opened a new pull request, #32: URL: https://github.com/apache/maven-doxia-site/pull/32 sadly defunct -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-540) Update/remove ancient information on Doxia site
[ https://issues.apache.org/jira/browse/DOXIA-540?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801350#comment-17801350 ] Elliotte Rusty Harold commented on DOXIA-540: - and while we're at it, markmail is dead > Update/remove ancient information on Doxia site > --- > > Key: DOXIA-540 > URL: https://issues.apache.org/jira/browse/DOXIA-540 > Project: Maven Doxia > Issue Type: Task > Components: Documentation >Reporter: Michael Osipov >Priority: Major > Labels: up-for-grabs > Time Spent: 10m > Remaining Estimate: 0h > > Tasks to perform: > * Remove [Developer Docs|http://maven.apache.org/doxia/] for ancient versions. > * Remove Doxia IDE intergration is there is none working > * Remove [Upgrading|http://maven.apache.org/doxia/upgrading.html], it is > overhauled. > * Check [FAQ|http://maven.apache.org/doxia/faq.html] for validity. > * Merge [Apt > Enhancements|http://maven.apache.org/doxia/references/doxia-apt.html] into > [main site|http://maven.apache.org/doxia/references/apt-format.html]. > * Check [Issues|http://maven.apache.org/doxia/issues/index.html] for > validity. > * Update [External Resources|http://maven.apache.org/doxia/resources.html]. > * Remove ancient information from [Sink > API|http://maven.apache.org/doxia/doxia/doxia-sink-api/index.html]. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Try to unbreak CI [maven-doxia-site]
elharo merged PR #28: URL: https://github.com/apache/maven-doxia-site/pull/28 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIA-716) Update and unify XMLReader creation and configuration
[
https://issues.apache.org/jira/browse/DOXIA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801348#comment-17801348
]
ASF GitHub Bot commented on DOXIA-716:
--
michael-o commented on code in PR #187:
URL: https://github.com/apache/maven-doxia/pull/187#discussion_r1438593509
##
doxia-core/src/test/java/org/apache/maven/doxia/xsd/AbstractXmlValidator.java:
##
@@ -157,8 +161,17 @@ protected void setValidate(boolean validate) {
private XMLReader getXMLReader() {
if (xmlReader == null) {
try {
-xmlReader =
XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");
+SAXParserFactory parserFactory =
SAXParserFactory.newInstance();
Review Comment:
Done and ran through doxia-sitetools and m-site-p.
> Update and unify XMLReader creation and configuration
> -
>
> Key: DOXIA-716
> URL: https://issues.apache.org/jira/browse/DOXIA-716
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M9
>
>
> * {{XMLReaderFactory}} is deprecated from Java 9
> * Force XML Schema as main language if both DTD and XSD are provided
> * Force {{Locale#ROOT}} for portability
> * Remove old Xerces hack
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-716] Update and unify XMLReader creation and configuration [maven-doxia]
michael-o commented on code in PR #187:
URL: https://github.com/apache/maven-doxia/pull/187#discussion_r1438593509
##
doxia-core/src/test/java/org/apache/maven/doxia/xsd/AbstractXmlValidator.java:
##
@@ -157,8 +161,17 @@ protected void setValidate(boolean validate) {
private XMLReader getXMLReader() {
if (xmlReader == null) {
try {
-xmlReader =
XMLReaderFactory.createXMLReader("org.apache.xerces.parsers.SAXParser");
+SAXParserFactory parserFactory =
SAXParserFactory.newInstance();
Review Comment:
Done and ran through doxia-sitetools and m-site-p.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 39 to 41 [maven-invoker]
khmarbaise merged PR #70: URL: https://github.com/apache/maven-invoker/pull/70 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801345#comment-17801345
]
Michael Osipov commented on MSITE-1000:
---
Congrats for creation the thousandth issue!
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-710 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIA-710) Inconsistent anchors between toc macro and headers
[
https://issues.apache.org/jira/browse/DOXIA-710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801341#comment-17801341
]
ASF GitHub Bot commented on DOXIA-710:
--
kwin commented on PR #180:
URL: https://github.com/apache/maven-doxia/pull/180#issuecomment-1872519693
> can we somehow check it based on our maven-site and the doxia converter?
Doesn't affect Doxia Converter, for checking with m-site-p you need a patch
for m-site-p and m-doxia-sitetools (see some WIP PRs in
https://issues.apache.org/jira/browse/MSITE-1000 and
https://issues.apache.org/jira/browse/DOXIASITETOOLS-322).
> Inconsistent anchors between toc macro and headers
> --
>
> Key: DOXIA-710
> URL: https://issues.apache.org/jira/browse/DOXIA-710
> Project: Maven Doxia
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Konrad Windszus
>Priority: Critical
>
> In markdown document add:
> {code:java}
>
> {code}
> Then anchors generated by toc macro looks like: {{#Your_First_Mojo}}
> and anchors generated by skin looks like: {{#your-first-plugin}}
> - Doxia Site Renderer 2.0.0-M4
> - Fluido Skin 1.11.1
> Tested on Maven main site without more investigate.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-710] Auto-generate anchor for TOC entries [maven-doxia]
kwin commented on PR #180: URL: https://github.com/apache/maven-doxia/pull/180#issuecomment-1872519693 > can we somehow check it based on our maven-site and the doxia converter? Doesn't affect Doxia Converter, for checking with m-site-p you need a patch for m-site-p and m-doxia-sitetools (see some WIP PRs in https://issues.apache.org/jira/browse/MSITE-1000 and https://issues.apache.org/jira/browse/DOXIASITETOOLS-322). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 39 to 41 [maven-invoker]
khmarbaise commented on PR #70: URL: https://github.com/apache/maven-invoker/pull/70#issuecomment-1872518405 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MINVOKER-350) Upgrade maven-plugin parent to 41
[ https://issues.apache.org/jira/browse/MINVOKER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl Heinz Marbaise closed MINVOKER-350. Resolution: Done > Upgrade maven-plugin parent to 41 > - > > Key: MINVOKER-350 > URL: https://issues.apache.org/jira/browse/MINVOKER-350 > Project: Maven Invoker Plugin > Issue Type: Improvement >Affects Versions: 3.6.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.x > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-350) Upgrade maven-plugin parent to 41
[ https://issues.apache.org/jira/browse/MINVOKER-350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801338#comment-17801338 ] Karl Heinz Marbaise commented on MINVOKER-350: -- Done in [d3a7592143f48d260536b0d8acfa9f9d878c7d7c|https://gitbox.apache.org/repos/asf?p=maven-invoker-plugin.git;a=commitdiff;h=d3a7592143f48d260536b0d8acfa9f9d878c7d7c] > Upgrade maven-plugin parent to 41 > - > > Key: MINVOKER-350 > URL: https://issues.apache.org/jira/browse/MINVOKER-350 > Project: Maven Invoker Plugin > Issue Type: Improvement >Affects Versions: 3.6.0 >Reporter: Karl Heinz Marbaise >Assignee: Karl Heinz Marbaise >Priority: Minor > Fix For: 3.x > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-interpolation from 1.26 to 1.27 [maven-invoker-plugin]
khmarbaise commented on PR #206: URL: https://github.com/apache/maven-invoker-plugin/pull/206#issuecomment-1872517561 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-shared-utils from 3.4.1 to 3.4.2 [maven-help-plugin]
slachiewicz merged PR #102: URL: https://github.com/apache/maven-help-plugin/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (DOXIA-718) Apply best security recommendations to xml parsing and validation
Sylwester Lachiewicz created DOXIA-718: -- Summary: Apply best security recommendations to xml parsing and validation Key: DOXIA-718 URL: https://issues.apache.org/jira/browse/DOXIA-718 Project: Maven Doxia Issue Type: Improvement Reporter: Sylwester Lachiewicz Apply OWASP recommendation if needed [https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-717) Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0
[ https://issues.apache.org/jira/browse/DOXIA-717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801334#comment-17801334 ] ASF GitHub Bot commented on DOXIA-717: -- slachiewicz opened a new pull request, #190: URL: https://github.com/apache/maven-doxia/pull/190 (no comment) > Update org.codehaus.plexus:plexus-testing from 1.1.0 to 1.3.0 > - > > Key: DOXIA-717 > URL: https://issues.apache.org/jira/browse/DOXIA-717 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.apache.maven:maven-parent from 40 to 41 [maven-doxia]
slachiewicz commented on PR #188: URL: https://github.com/apache/maven-doxia/pull/188#issuecomment-1872516058 will be fixed by #190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [DOXIA-717] Update org.codehaus.plexus:plexus-testing to 1.3.0 [maven-doxia]
slachiewicz opened a new pull request, #190: URL: https://github.com/apache/maven-doxia/pull/190 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (DOXIA-703) doxia-site CI is broken
[ https://issues.apache.org/jira/browse/DOXIA-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed DOXIA-703. -- Resolution: Fixed now its green > doxia-site CI is broken > --- > > Key: DOXIA-703 > URL: https://issues.apache.org/jira/browse/DOXIA-703 > Project: Maven Doxia > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Blocker > > [INFO] Using this base directory for staging: > /home/runner/work/maven-doxia-site/maven-doxia-site/target/staging > [INFO] Pushing /home/runner/work/maven-doxia-site/maven-doxia-site/target/site > [INFO]>>> to > file:///home/runner/work/maven-doxia-site/maven-doxia-site/target/staging/../../../doxia/website/content > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 46.400 s > [INFO] Finished at: 2023-04-23T11:21:08Z > [INFO] > > Error: Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.12.1:stage (default-cli) on > project doxia-site: Error uploading site: Error copying directory structure: > Unknown file type: > /home/runner/work/maven-doxia-site/maven-doxia-site/target/site/doxia-ide -> > [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (DOXIA-703) doxia-site CI is broken
[ https://issues.apache.org/jira/browse/DOXIA-703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned DOXIA-703: -- Assignee: Sylwester Lachiewicz > doxia-site CI is broken > --- > > Key: DOXIA-703 > URL: https://issues.apache.org/jira/browse/DOXIA-703 > Project: Maven Doxia > Issue Type: Bug >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Blocker > > [INFO] Using this base directory for staging: > /home/runner/work/maven-doxia-site/maven-doxia-site/target/staging > [INFO] Pushing /home/runner/work/maven-doxia-site/maven-doxia-site/target/site > [INFO]>>> to > file:///home/runner/work/maven-doxia-site/maven-doxia-site/target/staging/../../../doxia/website/content > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 46.400 s > [INFO] Finished at: 2023-04-23T11:21:08Z > [INFO] > > Error: Failed to execute goal > org.apache.maven.plugins:maven-site-plugin:3.12.1:stage (default-cli) on > project doxia-site: Error uploading site: Error copying directory structure: > Unknown file type: > /home/runner/work/maven-doxia-site/maven-doxia-site/target/site/doxia-ide -> > [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-716) Update and unify XMLReader creation and configuration
[
https://issues.apache.org/jira/browse/DOXIA-716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801332#comment-17801332
]
ASF GitHub Bot commented on DOXIA-716:
--
michael-o commented on PR #187:
URL: https://github.com/apache/maven-doxia/pull/187#issuecomment-1872514850
> looks good to me. While we are here maybe something for parsing and later
for validation can be hardened:
https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html
This should be separate, please file a JIRA issue.
> Update and unify XMLReader creation and configuration
> -
>
> Key: DOXIA-716
> URL: https://issues.apache.org/jira/browse/DOXIA-716
> Project: Maven Doxia
> Issue Type: Improvement
> Components: Core
>Affects Versions: 2.0.0-M8
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0-M9
>
>
> * {{XMLReaderFactory}} is deprecated from Java 9
> * Force XML Schema as main language if both DTD and XSD are provided
> * Force {{Locale#ROOT}} for portability
> * Remove old Xerces hack
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIA-716] Update and unify XMLReader creation and configuration [maven-doxia]
michael-o commented on PR #187: URL: https://github.com/apache/maven-doxia/pull/187#issuecomment-1872514850 > looks good to me. While we are here maybe something for parsing and later for validation can be hardened: https://cheatsheetseries.owasp.org/cheatsheets/XML_External_Entity_Prevention_Cheat_Sheet.html This should be separate, please file a JIRA issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-322) Upgrade to Doxia 2.0.0-M9
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801331#comment-17801331 ] Michael Osipov commented on DOXIASITETOOLS-322: --- Some work has been done here: https://github.com/apache/maven-doxia-sitetools/pull/124 > Upgrade to Doxia 2.0.0-M9 > - > > Key: DOXIASITETOOLS-322 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-322 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0-M13 > > > This requires accommodations for DOXIA-709. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801330#comment-17801330
]
ASF GitHub Bot commented on MSITE-1000:
---
kwin commented on code in PR #171:
URL: https://github.com/apache/maven-site-plugin/pull/171#discussion_r1438573138
##
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguration.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site.render;
+
+import java.util.LinkedList;
+import java.util.List;
+
+import org.apache.maven.shared.utils.io.MatchPattern;
+import org.apache.maven.shared.utils.io.MatchPatterns;
+
+public class ParserConfiguration {
Review Comment:
This is supposed to be passed to
https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-710 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]
kwin commented on code in PR #171:
URL: https://github.com/apache/maven-site-plugin/pull/171#discussion_r1438573138
##
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguration.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site.render;
+
+import java.util.LinkedList;
+import java.util.List;
+
+import org.apache.maven.shared.utils.io.MatchPattern;
+import org.apache.maven.shared.utils.io.MatchPatterns;
+
+public class ParserConfiguration {
Review Comment:
This is supposed to be passed to
https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/SiteRenderingContext.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Adjust GHA setup to fix site builds [maven-doxia-site]
slachiewicz merged PR #31: URL: https://github.com/apache/maven-doxia-site/pull/31 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Adjust GHA setup to fix site builds [maven-doxia-site]
slachiewicz opened a new pull request, #31: URL: https://github.com/apache/maven-doxia-site/pull/31 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801329#comment-17801329
]
ASF GitHub Bot commented on MSITE-1000:
---
kwin opened a new pull request, #171:
URL: https://github.com/apache/maven-site-plugin/pull/171
This is WIP to gather early feedback
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-710 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[PR] Bump commons-io:commons-io from 2.11.0 to 2.15.1 [maven-doxia]
dependabot[bot] opened a new pull request, #189: URL: https://github.com/apache/maven-doxia/pull/189 Bumps commons-io:commons-io from 2.11.0 to 2.15.1. [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
