Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 [maven-build-cache-extension]
dependabot[bot] closed pull request #124: Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 URL: https://github.com/apache/maven-build-cache-extension/pull/124 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 [maven-build-cache-extension]
dependabot[bot] commented on PR #124: URL: https://github.com/apache/maven-build-cache-extension/pull/124#issuecomment-1874947408 Superseded by #125. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 [maven-build-cache-extension]
dependabot[bot] opened a new pull request, #125: URL: https://github.com/apache/maven-build-cache-extension/pull/125 Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.24.2 to 3.25.1. Release notes Sourced from https://github.com/assertj/assertj/releases";>org.assertj:assertj-core's releases. v3.25.1 :jigsaw: Binary Compatibility The release is: Binary compatible with the previous minor version. Binary incompatible with the previous patch version. :bug: Bug Fixes Core Revert "Provide value when assertThatThrownBy/thenThrownBy fail" https://redirect.github.com/assertj/assertj/issues/3318";>#3318 Revert "fix: containsExactly does not work properly with maps not using equals to compare keys" https://redirect.github.com/assertj/assertj/issues/3321";>#3321 v3.25.0 :jigsaw: Binary Compatibility The release is https://assertj.github.io/doc/#binary-compatibility";>binary compatible with the previous minor version. :no_entry_sign: Deprecated Core Deprecate the following date/time related assertions in favor of isCloseTo: isEqualToIgnoringHours isEqualToIgnoringMinutes isEqualToIgnoringSeconds isEqualToIgnoringMillis isEqualToIgnoringNanos isInSameHourAs isInSameMinuteAs isInSameSecondAs Deprecate asList in favor of asInstanceOf https://redirect.github.com/assertj/assertj/issues/3138";>#3138 :sparkles: New Features Core Add Descriptable#describedAs(Supplier) Add isInThePast and isInTheFuture to LocalDate assertions https://redirect.github.com/assertj/assertj/issues/2933";>#2933 Add isInThePast and isInTheFuture to the missing Java 8 date/time types https://redirect.github.com/assertj/assertj/issues/2947";>#2947 Add isRecord and isNotRecord to Class assertions https://redirect.github.com/assertj/assertj/issues/2968";>#2968 Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert https://redirect.github.com/assertj/assertj/issues/2969";>#2969 Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions https://redirect.github.com/assertj/assertj/issues/2580";>#2580 Add hasRecordComponents to Class assertions https://redirect.github.com/assertj/assertj/issues/2995";>#2995 Add getters for field path in ComparisonDifference https://redirect.github.com/assertj/assertj/issues/3007";>#3007 Allow to compare enum and string fields in the recursive comparison https://redirect.github.com/assertj/assertj/issues/2616";>#2616 Provide value when assertThatThrownBy / thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3043";>#3043 Add isSealed and isNotSealed to Class assertions https://redirect.github.com/assertj/assertj/issues/3080";>#3080 Add assertThatCharSequence to disambiguate Groovy's GString https://redirect.github.com/assertj/assertj/issues/3132";>#3132 ... (truncated) Commits https://github.com/assertj/assertj/commit/65f6433d26f74795434ac2ef2118cd5cec7c1be4";>65f6433 [maven-release-plugin] prepare release assertj-build-3.25.1 https://github.com/assertj/assertj/commit/4753165446ddec5e25250e52e6e5582093793262";>4753165 Revert "fix: containsExactly does not work properly with maps not using equal... https://github.com/assertj/assertj/commit/2a7c5a6e205e29d42e9886657987893cb03b6875";>2a7c5a6 Revert "Provide value when assertThatThrownBy/thenThrownBy fail" (https://redirect.github.com/assertj/assertj/issues/3318";>#3318) https://github.com/assertj/assertj/commit/887f97b65da068e03308a6373a0c8a76912377aa";>887f97b Update license headers https://github.com/assertj/assertj/commit/25347d57bb28295548ec6bd5b06e70b6d03496c9";>25347d5 [maven-release-plugin] prepare for next development iteration https://github.com/assertj/assertj/commit/2c1c0839af66989c2d30d5b556799ca75ef2c246";>2c1c083 [maven-release-plugin] prepare release assertj-build-3.25.0 https://github.com/assertj/assertj/commit/c44129de725f5a3ecbaba16dd7b9ec31fd9e293b";>c44129d Move flatten-maven-plugin version to separate property https://github.com/assertj/assertj/commit/31cefaf68c04e13c6703033151f776251782af85";>31cefaf Apply flatten-maven-plugin to assertj-core and assertj-guava (https://redirect.github.com/assertj/assertj/issues/3311";>#3311) https://github.com/assertj/assertj/commit/435d183f2ededb18246338fb780098fabfba700b";>435d183 chore(deps-dev): bump org.testng:testng from 7.8.0 to 7.9.0 (https://redirect.github.com/assertj/assertj/issues/3312";>#3312) https://github.com/assertj/assertj/commit/e044604d99cdb513177d467886d51c47e0163251";>e044604 chore(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.4 to 3 Additional commits viewable in https://github.com/assertj/assertj/compare/assertj-build-3.24.2...assertj-build-3.25.1";>compare view [ StatelessXmlReporter#getTestProblems() does not properly reflect report schema structure
[
https://issues.apache.org/jira/browse/SUREFIRE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17802035#comment-17802035
]
ASF GitHub Bot commented on SUREFIRE-2224:
--
marcphilipp commented on code in PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#discussion_r1440135518
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##
@@ -456,21 +456,13 @@ private static void getTestProblems(
}
}
-boolean hasNestedElements = createOutErrElementsInside & stackTrace !=
null;
-
-if (stackTrace != null) {
-if (hasNestedElements) {
-ppw.startElement("stackTrace");
+if (enableNestedOutErrElements) {
+ppw.startElement("stackTrace");
+if (stackTrace != null) {
+extraEscapeElementValue(stackTrace, outputStreamWriter, ppw,
fw);
}
+ppw.endElement();
-extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
Review Comment:
Yes, that's right.
## Before (with 3.2.3 and earlier)
```xml
```
## After this change
```xml
```
> StatelessXmlReporter#getTestProblems() does not properly reflect report
> schema structure
>
>
> Key: SUREFIRE-2224
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2224
> Project: Maven Surefire
> Issue Type: Bug
> Components: xml generation
>Affects Versions: 3.2.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.4
>
>
> According to
> https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
> and
> https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/failsafe-test-report.xsd
> not all nested elements contain {{stackTrace}}, {{system-out}} and
> {{system-err}} elements, but the code makes it conditional whether there is a
> stack trace or not. This does not comply with the schema definition. Either
> the nested element is simple content or complex. In the latter {{stackTrace}}
> is mandatory, even if there is no strack trace according to the schema. The
> system streams are optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SUREFIRE-2224] StatelessXmlReporter#getTestProblems() does not properly reflect report schema structure [maven-surefire]
marcphilipp commented on code in PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#discussion_r1440135518
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##
@@ -456,21 +456,13 @@ private static void getTestProblems(
}
}
-boolean hasNestedElements = createOutErrElementsInside & stackTrace !=
null;
-
-if (stackTrace != null) {
-if (hasNestedElements) {
-ppw.startElement("stackTrace");
+if (enableNestedOutErrElements) {
+ppw.startElement("stackTrace");
+if (stackTrace != null) {
+extraEscapeElementValue(stackTrace, outputStreamWriter, ppw,
fw);
}
+ppw.endElement();
-extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
Review Comment:
Yes, that's right.
## Before (with 3.2.3 and earlier)
```xml
```
## After this change
```xml
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump org.codehaus.plexus:plexus-component-annotations from 2.0.0 to 2.2.0 [maven-archetype]
dependabot[bot] opened a new pull request, #180: URL: https://github.com/apache/maven-archetype/pull/180 Bumps [org.codehaus.plexus:plexus-component-annotations](https://github.com/codehaus-plexus/plexus-containers) from 2.0.0 to 2.2.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-containers/releases";>org.codehaus.plexus:plexus-component-annotations's releases. 2.2.0 improve documentation to switch to Sisu (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/121";>#121) https://github.com/hboutemy";>@hboutemy pom clean after parent upgrade (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/120";>#120) https://github.com/hboutemy";>@hboutemy Improve plexus-component metadata - remove dependency to plexus-container-default (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/109";>#109) https://github.com/slachiewicz";>@slachiewicz Add deprecation information to Plexus components (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/108";>#108) https://github.com/slachiewicz";>@slachiewicz Require Java 8 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/107";>#107) https://github.com/slachiewicz";>@slachiewicz Drop plexus-container-default artefact (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/135";>#135) https://github.com/slachiewicz";>@slachiewicz Require Maven 3.6.3+ (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/133";>#133) https://github.com/slachiewicz";>@slachiewicz Switch to JUnit5 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/134";>#134) https://github.com/slachiewicz";>@slachiewicz Bump org.eclipse.sisu.plexus from 0.3.0.M1 to 0.9.0.M2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/113";>#113) https://github.com/dependabot";>@dependabot 📦 Dependency updates Bump org.codehaus.plexus:plexus-testing from 1.2.0 to 1.3.0 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/139";>#139) https://github.com/dependabot";>@dependabot Bump org.codehaus.plexus:plexus from 15 to 16 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/138";>#138) https://github.com/dependabot";>@dependabot Bump org.apache.xbean:xbean-reflect from 4.23 to 4.24 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/131";>#131) https://github.com/dependabot";>@dependabot Reorg dependencyManagement to subprojects. Prepare to drop plexus-container-default (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/132";>#132) https://github.com/slachiewicz";>@slachiewicz Bump org.ow2.asm:asm from 9.5 to 9.6 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/129";>#129) https://github.com/dependabot";>@dependabot Bump maven-invoker-plugin from 3.5.1 to 3.6.0 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/125";>#125) https://github.com/dependabot";>@dependabot Bump xbean-reflect from 4.22 to 4.23 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/116";>#116) https://github.com/dependabot";>@dependabot Bump maven-plugin-annotations from 3.8.1 to 3.8.2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/104";>#104) https://github.com/dependabot";>@dependabot Bump maven-plugin-plugin from 3.8.1 to 3.8.2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/105";>#105) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.4.2 to 3.4.3 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/102";>#102) https://github.com/dependabot";>@dependabot Bump asm from 9.4 to 9.5 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/99";>#99) https://github.com/dependabot";>@dependabot Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/97";>#97) https://github.com/dependabot";>@dependabot Bump checkstyle from 9.2 to 9.3 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/96";>#96) https://github.com/dependabot";>@dependabot Bump maven-plugin-plugin from 3.7.1 to 3.8.1 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/92";>#92) https://github.com/dependabot";>@dependabot Bump maven-plugin-annotations from 3.7.1 to 3.8.1 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/93";>#93) https://github.com/dependabot";>@dependabot Bump asm from 9.3 to 9.4 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/88";>#88) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.4.1 to 3.4.2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/85";>#85) https://github.com/dependabot";>@dependabot Bump maven-plugin-plugin from 3.7.0 to 3.7.1 (
[PR] Bump org.apache.maven.plugins:maven-docck-plugin from 1.1 to 1.2 [maven-archetype]
dependabot[bot] opened a new pull request, #181: URL: https://github.com/apache/maven-archetype/pull/181 Bumps [org.apache.maven.plugins:maven-docck-plugin](https://github.com/apache/maven-docck-plugin) from 1.1 to 1.2. Commits https://github.com/apache/maven-docck-plugin/commit/a47e98c1fcabbfe9422621c1a2d2abe56e43d1e1";>a47e98c [maven-release-plugin] prepare release maven-docck-plugin-1.2 https://github.com/apache/maven-docck-plugin/commit/00c05e46fad519c4b377e9041176dce69e44e04b";>00c05e4 [MDOCCK-39] Prepare documentation for retired https://github.com/apache/maven-docck-plugin/commit/4663f8de97ae72a6132b0ea03069c29260c46ffb";>4663f8d [MNG-6829] Replace StringUtils#isEmpty(String) & #isNotEmpty(String) (https://redirect.github.com/apache/maven-docck-plugin/issues/3";>#3) https://github.com/apache/maven-docck-plugin/commit/4f66af7c9f8cf65e127378094f458b24ef6e6097";>4f66af7 Auto-link MDOCCK Jira https://github.com/apache/maven-docck-plugin/commit/9a51d8217df4cc44a7535f82e723d70bb972da6b";>9a51d82 Use shared GitHub Actions https://github.com/apache/maven-docck-plugin/commit/3a0d4c7388ef8af9675b696c5e6efc3ac348e38b";>3a0d4c7 Fix project name in readme https://github.com/apache/maven-docck-plugin/commit/08fe1a8c8c4cfaafae6c6d51bc1109c570a59a78";>08fe1a8 Fix JavaDoc https://github.com/apache/maven-docck-plugin/commit/1e0896228aebefab6c2b4750e9cc8002e0dd8ed7";>1e08962 update CI url https://github.com/apache/maven-docck-plugin/commit/ab5588ce05b89d434980ff07c3e1bcd66468d967";>ab5588c Made use of Java 8 code for creating a singletonList https://github.com/apache/maven-docck-plugin/commit/27483cd1d58d5e2d82d14ad45460b1a109e4887c";>27483cd [MDOCCK-35] - Upgrade Http Client Additional commits viewable in https://github.com/apache/maven-docck-plugin/compare/maven-docck-plugin-1.1...maven-docck-plugin-1.2";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.codehaus.plexus:plexus-component-metadata from 2.0.0 to 2.2.0 [maven-archetype]
dependabot[bot] opened a new pull request, #179: URL: https://github.com/apache/maven-archetype/pull/179 Bumps [org.codehaus.plexus:plexus-component-metadata](https://github.com/codehaus-plexus/plexus-containers) from 2.0.0 to 2.2.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-containers/releases";>org.codehaus.plexus:plexus-component-metadata's releases. 2.2.0 improve documentation to switch to Sisu (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/121";>#121) https://github.com/hboutemy";>@hboutemy pom clean after parent upgrade (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/120";>#120) https://github.com/hboutemy";>@hboutemy Improve plexus-component metadata - remove dependency to plexus-container-default (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/109";>#109) https://github.com/slachiewicz";>@slachiewicz Add deprecation information to Plexus components (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/108";>#108) https://github.com/slachiewicz";>@slachiewicz Require Java 8 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/107";>#107) https://github.com/slachiewicz";>@slachiewicz Drop plexus-container-default artefact (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/135";>#135) https://github.com/slachiewicz";>@slachiewicz Require Maven 3.6.3+ (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/133";>#133) https://github.com/slachiewicz";>@slachiewicz Switch to JUnit5 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/134";>#134) https://github.com/slachiewicz";>@slachiewicz Bump org.eclipse.sisu.plexus from 0.3.0.M1 to 0.9.0.M2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/113";>#113) https://github.com/dependabot";>@dependabot 📦 Dependency updates Bump org.codehaus.plexus:plexus-testing from 1.2.0 to 1.3.0 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/139";>#139) https://github.com/dependabot";>@dependabot Bump org.codehaus.plexus:plexus from 15 to 16 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/138";>#138) https://github.com/dependabot";>@dependabot Bump org.apache.xbean:xbean-reflect from 4.23 to 4.24 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/131";>#131) https://github.com/dependabot";>@dependabot Reorg dependencyManagement to subprojects. Prepare to drop plexus-container-default (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/132";>#132) https://github.com/slachiewicz";>@slachiewicz Bump org.ow2.asm:asm from 9.5 to 9.6 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/129";>#129) https://github.com/dependabot";>@dependabot Bump maven-invoker-plugin from 3.5.1 to 3.6.0 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/125";>#125) https://github.com/dependabot";>@dependabot Bump xbean-reflect from 4.22 to 4.23 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/116";>#116) https://github.com/dependabot";>@dependabot Bump maven-plugin-annotations from 3.8.1 to 3.8.2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/104";>#104) https://github.com/dependabot";>@dependabot Bump maven-plugin-plugin from 3.8.1 to 3.8.2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/105";>#105) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.4.2 to 3.4.3 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/102";>#102) https://github.com/dependabot";>@dependabot Bump asm from 9.4 to 9.5 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/99";>#99) https://github.com/dependabot";>@dependabot Bump plexus-utils from 3.5.0 to 3.5.1 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/97";>#97) https://github.com/dependabot";>@dependabot Bump checkstyle from 9.2 to 9.3 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/96";>#96) https://github.com/dependabot";>@dependabot Bump maven-plugin-plugin from 3.7.1 to 3.8.1 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/92";>#92) https://github.com/dependabot";>@dependabot Bump maven-plugin-annotations from 3.7.1 to 3.8.1 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/93";>#93) https://github.com/dependabot";>@dependabot Bump asm from 9.3 to 9.4 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/88";>#88) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.4.1 to 3.4.2 (https://redirect.github.com/codehaus-plexus/plexus-containers/pull/85";>#85) https://github.com/dependabot";>@dependabot Bump maven-plugin-plugin from 3.7.0 to 3.7.1 (https:
[PR] Bump org.codehaus.modello:modello-maven-plugin from 2.1.0 to 2.1.2 [maven-archetype]
dependabot[bot] opened a new pull request, #178: URL: https://github.com/apache/maven-archetype/pull/178 Bumps [org.codehaus.modello:modello-maven-plugin](https://github.com/codehaus-plexus/modello) from 2.1.0 to 2.1.2. Release notes Sourced from https://github.com/codehaus-plexus/modello/releases";>org.codehaus.modello:modello-maven-plugin's releases. 2.1.2 Switch to codehaus plexus-build-api 1.2.0 (https://redirect.github.com/codehaus-plexus/modello/pull/345";>#345) https://github.com/gnodet";>@gnodet Add plexus 13 parent and reformat (https://redirect.github.com/codehaus-plexus/modello/pull/344";>#344) https://github.com/gnodet";>@gnodet Remove readonly flag from basedir: support .mdo from any location (https://redirect.github.com/codehaus-plexus/modello/pull/299";>#299) https://github.com/hboutemy";>@hboutemy Require Maven 3.5.4+ (https://redirect.github.com/codehaus-plexus/modello/pull/335";>#335) https://github.com/slachiewicz";>@slachiewicz Prepare to run with Java 19+ (https://redirect.github.com/codehaus-plexus/modello/pull/314";>#314) https://github.com/slachiewicz";>@slachiewicz 📦 Dependency updates Bump maven-release-plugin from 3.0.0 to 3.0.1 (https://redirect.github.com/codehaus-plexus/modello/pull/353";>#353) https://github.com/dependabot";>@dependabot Bump plexus-utils from 3.5.1 to 4.0.0 (https://redirect.github.com/codehaus-plexus/modello/pull/348";>#348) https://github.com/dependabot";>@dependabot Bump maven-checkstyle-plugin from 3.2.2 to 3.3.0 (https://redirect.github.com/codehaus-plexus/modello/pull/347";>#347) https://github.com/dependabot";>@dependabot Bump jackson-bom from 2.15.1 to 2.15.2 (https://redirect.github.com/codehaus-plexus/modello/pull/352";>#352) https://github.com/dependabot";>@dependabot Bump maven-source-plugin from 3.2.1 to 3.3.0 (https://redirect.github.com/codehaus-plexus/modello/pull/349";>#349) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.4.3 to 3.4.4 (https://redirect.github.com/codehaus-plexus/modello/pull/351";>#351) https://github.com/dependabot";>@dependabot Bump maven-dependency-plugin from 3.5.0 to 3.6.0 (https://redirect.github.com/codehaus-plexus/modello/pull/350";>#350) https://github.com/dependabot";>@dependabot Bump jackson-bom from 2.14.2 to 2.15.1 (https://redirect.github.com/codehaus-plexus/modello/pull/342";>#342) https://github.com/dependabot";>@dependabot Bump maven-pmd-plugin from 3.20.0 to 3.21.0 (https://redirect.github.com/codehaus-plexus/modello/pull/341";>#341) https://github.com/dependabot";>@dependabot Bump maven-assembly-plugin from 3.5.0 to 3.6.0 (https://redirect.github.com/codehaus-plexus/modello/pull/339";>#339) https://github.com/dependabot";>@dependabot Bump maven-gpg-plugin from 3.0.1 to 3.1.0 (https://redirect.github.com/codehaus-plexus/modello/pull/338";>#338) https://github.com/dependabot";>@dependabot Bump jsoup from 1.15.4 to 1.16.1 (https://redirect.github.com/codehaus-plexus/modello/pull/336";>#336) https://github.com/dependabot";>@dependabot Bump mavenPluginTools from 3.8.2 to 3.9.0 (https://redirect.github.com/codehaus-plexus/modello/pull/340";>#340) https://github.com/dependabot";>@dependabot Bump surefire.version from 3.0.0 to 3.1.0 (https://redirect.github.com/codehaus-plexus/modello/pull/337";>#337) https://github.com/dependabot";>@dependabot Bump mavenPluginTools from 3.8.1 to 3.8.2 (https://redirect.github.com/codehaus-plexus/modello/pull/333";>#333) https://github.com/dependabot";>@dependabot Bump maven-checkstyle-plugin from 3.2.1 to 3.2.2 (https://redirect.github.com/codehaus-plexus/modello/pull/332";>#332) https://github.com/dependabot";>@dependabot Bump woodstox-core from 6.5.0 to 6.5.1 (https://redirect.github.com/codehaus-plexus/modello/pull/331";>#331) https://github.com/dependabot";>@dependabot Bump maven-project-info-reports-plugin from 3.4.2 to 3.4.3 (https://redirect.github.com/codehaus-plexus/modello/pull/330";>#330) https://github.com/dependabot";>@dependabot Bump apache-source-release-assembly-descriptor from 1.0.6 to 1.5 (https://redirect.github.com/codehaus-plexus/modello/pull/329";>#329) https://github.com/dependabot";>@dependabot Bump maven-enforcer-plugin from 3.2.1 to 3.3.0 (https://redirect.github.com/codehaus-plexus/modello/pull/328";>#328) https://github.com/dependabot";>@dependabot Bump maven-invoker-plugin from 3.5.0 to 3.5.1 (https://redirect.github.com/codehaus-plexus/modello/pull/327";>#327) https://github.com/dependabot";>@dependabot Bump maven-scm-publish-plugin from 3.1.0 to 3.2.1 (https://redirect.github.com/codehaus-plexus/modello/pull/326";>#326) https://github.com/dependabot";>@dependabot Bump maven-deploy-plugin from 3.1.0 to 3.1.1 (https://redirect.github.com/codehaus-plexus/modello/pull/324";>#324) https://github.com/dependabot";>@dependabot Bump
[PR] Bump org.easymock:easymock from 3.6 to 5.2.0 [maven-archetype]
dependabot[bot] opened a new pull request, #177: URL: https://github.com/apache/maven-archetype/pull/177 Bumps [org.easymock:easymock](https://github.com/easymock/easymock) from 3.6 to 5.2.0. Release notes Sourced from https://github.com/easymock/easymock/releases";>org.easymock:easymock's releases. 5.2.0 Fixes problems with Java 17 for mocks in different modules. Also fixes the source jar that was empty. Change log EasyMock HEAD build fails on JDK21 (https://redirect.github.com/easymock/easymock/issues/442";>#442) Error running tests after Java upgrade to IBM Semeru jdk-17.0.6+10 (from jdk1.8.0_311.jdk) (https://redirect.github.com/easymock/easymock/issues/393";>#393) LinkageError when mocking certain classes (https://redirect.github.com/easymock/easymock/issues/373";>#373) pom file error: the source.jar is not deployed correctly to maven (https://redirect.github.com/easymock/easymock/issues/369";>#369) Can't mock methods called from the constructor of a partial mock (https://redirect.github.com/easymock/easymock/issues/358";>#358) Partial mocking Swing components in EasyMock 5.1.0 (https://redirect.github.com/easymock/easymock/issues/356";>#356) java.lang.NoSuchMethodException on mock(Timestamp.class) (https://redirect.github.com/easymock/easymock/issues/256";>#256) Bump com.puppycrawl.tools:checkstyle from 10.12.2 to 10.12.3 (https://redirect.github.com/easymock/easymock/pull/461";>#461) Bump net.bytebuddy:byte-buddy from 1.14.6 to 1.14.7 (https://redirect.github.com/easymock/easymock/pull/460";>#460) Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.3.0 to 3.4.0 (https://redirect.github.com/easymock/easymock/pull/458";>#458) Bump net.bytebuddy:byte-buddy from 1.14.5 to 1.14.6 (https://redirect.github.com/easymock/easymock/pull/457";>#457) Bump commonmarker from 0.23.9 to 0.23.10 in /website (https://redirect.github.com/easymock/easymock/pull/454";>#454) Bump jmh.version from 1.36 to 1.37 (https://redirect.github.com/easymock/easymock/pull/452";>#452) Bump com.puppycrawl.tools:checkstyle from 10.12.1 to 10.12.2 (https://redirect.github.com/easymock/easymock/pull/450";>#450) Bump junit.jupiter.version from 5.9.3 to 5.10.0 (https://redirect.github.com/easymock/easymock/pull/449";>#449) Bump depends-maven-plugin from 1.4.0 to 1.5.0 (https://redirect.github.com/easymock/easymock/pull/447";>#447) Bump checkstyle from 10.12.0 to 10.12.1 (https://redirect.github.com/easymock/easymock/pull/446";>#446) Bump maven-clean-plugin from 3.2.0 to 3.3.1 (https://redirect.github.com/easymock/easymock/pull/445";>#445) Bump spotbugs-maven-plugin from 4.7.3.4 to 4.7.3.5 (https://redirect.github.com/easymock/easymock/pull/444";>#444) Bump maven-shade-plugin from 3.4.1 to 3.5.0 (https://redirect.github.com/easymock/easymock/pull/443";>#443) Bump surefire-testng from 3.1.0 to 3.1.2 (https://redirect.github.com/easymock/easymock/pull/440";>#440) Bump versions-maven-plugin from 2.15.0 to 2.16.0 (https://redirect.github.com/easymock/easymock/pull/439";>#439) Bump maven-project-info-reports-plugin from 3.4.4 to 3.4.5 (https://redirect.github.com/easymock/easymock/pull/438";>#438) Bump maven-surefire-plugin from 3.1.0 to 3.1.2 (https://redirect.github.com/easymock/easymock/pull/437";>#437) Bump surefire-junit-platform from 3.1.0 to 3.1.2 (https://redirect.github.com/easymock/easymock/pull/436";>#436) Bump byte-buddy from 1.14.4 to 1.14.5 (https://redirect.github.com/easymock/easymock/pull/435";>#435) Bump maven-project-info-reports-plugin from 3.4.3 to 3.4.4 (https://redirect.github.com/easymock/easymock/pull/434";>#434) Bump checkstyle from 10.11.0 to 10.12.0 (https://redirect.github.com/easymock/easymock/pull/433";>#433) Bump maven-dependency-plugin from 3.5.0 to 3.6.0 (https://redirect.github.com/easymock/easymock/pull/432";>#432) Bump maven-checkstyle-plugin from 3.2.2 to 3.3.0 (https://redirect.github.com/easymock/easymock/pull/431";>#431) Bump maven-source-plugin from 3.2.1 to 3.3.0 (https://redirect.github.com/easymock/easymock/pull/429";>#429) Bump maven-bundle-plugin from 5.1.8 to 5.1.9 (https://redirect.github.com/easymock/easymock/pull/428";>#428) Bump maven-pmd-plugin from 3.20.0 to 3.21.0 (https://redirect.github.com/easymock/easymock/pull/427";>#427) Bump maven-assembly-plugin from 3.5.0 to 3.6.0 (https://redirect.github.com/easymock/easymock/pull/426";>#426) Bump maven-remote-resources-plugin from 3.0.0 to 3.1.0 (https://redirect.github.com/easymock/easymock/pull/425";>#425) Bump build-helper-maven-plugin from 3.3.0 to 3.4.0 (https://redirect.github.com/easymock/easymock/pull/424";>#424) Bump checkstyle from 10.10.0 to 10.11.0 (https://redirect.github.com/easymock/easymock/pull/423";>#423) Bump maven-surefire-plugin from 3.0.0 to 3.1.0 (https://redirect.github.com/easymock/easymock/pull/422";>#422) Bump maven-gpg-plugin from 3.0.1 to 3.1.0 (https://redi
[PR] Bump org.assertj:assertj-core from 3.25.0 to 3.25.1 [maven-invoker-plugin]
dependabot[bot] opened a new pull request, #211: URL: https://github.com/apache/maven-invoker-plugin/pull/211 Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.25.0 to 3.25.1. Release notes Sourced from https://github.com/assertj/assertj/releases";>org.assertj:assertj-core's releases. v3.25.1 :jigsaw: Binary Compatibility The release is: Binary compatible with the previous minor version. Binary incompatible with the previous patch version. :bug: Bug Fixes Core Revert "Provide value when assertThatThrownBy/thenThrownBy fail" https://redirect.github.com/assertj/assertj/issues/3318";>#3318 Revert "fix: containsExactly does not work properly with maps not using equals to compare keys" https://redirect.github.com/assertj/assertj/issues/3321";>#3321 Commits https://github.com/assertj/assertj/commit/65f6433d26f74795434ac2ef2118cd5cec7c1be4";>65f6433 [maven-release-plugin] prepare release assertj-build-3.25.1 https://github.com/assertj/assertj/commit/4753165446ddec5e25250e52e6e5582093793262";>4753165 Revert "fix: containsExactly does not work properly with maps not using equal... https://github.com/assertj/assertj/commit/2a7c5a6e205e29d42e9886657987893cb03b6875";>2a7c5a6 Revert "Provide value when assertThatThrownBy/thenThrownBy fail" (https://redirect.github.com/assertj/assertj/issues/3318";>#3318) https://github.com/assertj/assertj/commit/887f97b65da068e03308a6373a0c8a76912377aa";>887f97b Update license headers https://github.com/assertj/assertj/commit/25347d57bb28295548ec6bd5b06e70b6d03496c9";>25347d5 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/assertj/assertj/compare/assertj-build-3.25.0...assertj-build-3.25.1";>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.assertj:assertj-bom from 3.24.2 to 3.25.1 [maven-dependency-analyzer]
dependabot[bot] opened a new pull request, #104: URL: https://github.com/apache/maven-dependency-analyzer/pull/104 Bumps [org.assertj:assertj-bom](https://github.com/assertj/assertj) from 3.24.2 to 3.25.1. Release notes Sourced from https://github.com/assertj/assertj/releases";>org.assertj:assertj-bom's releases. v3.25.1 :jigsaw: Binary Compatibility The release is: Binary compatible with the previous minor version. Binary incompatible with the previous patch version. :bug: Bug Fixes Core Revert "Provide value when assertThatThrownBy/thenThrownBy fail" https://redirect.github.com/assertj/assertj/issues/3318";>#3318 Revert "fix: containsExactly does not work properly with maps not using equals to compare keys" https://redirect.github.com/assertj/assertj/issues/3321";>#3321 v3.25.0 :jigsaw: Binary Compatibility The release is https://assertj.github.io/doc/#binary-compatibility";>binary compatible with the previous minor version. :no_entry_sign: Deprecated Core Deprecate the following date/time related assertions in favor of isCloseTo: isEqualToIgnoringHours isEqualToIgnoringMinutes isEqualToIgnoringSeconds isEqualToIgnoringMillis isEqualToIgnoringNanos isInSameHourAs isInSameMinuteAs isInSameSecondAs Deprecate asList in favor of asInstanceOf https://redirect.github.com/assertj/assertj/issues/3138";>#3138 :sparkles: New Features Core Add Descriptable#describedAs(Supplier) Add isInThePast and isInTheFuture to LocalDate assertions https://redirect.github.com/assertj/assertj/issues/2933";>#2933 Add isInThePast and isInTheFuture to the missing Java 8 date/time types https://redirect.github.com/assertj/assertj/issues/2947";>#2947 Add isRecord and isNotRecord to Class assertions https://redirect.github.com/assertj/assertj/issues/2968";>#2968 Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert https://redirect.github.com/assertj/assertj/issues/2969";>#2969 Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions https://redirect.github.com/assertj/assertj/issues/2580";>#2580 Add hasRecordComponents to Class assertions https://redirect.github.com/assertj/assertj/issues/2995";>#2995 Add getters for field path in ComparisonDifference https://redirect.github.com/assertj/assertj/issues/3007";>#3007 Allow to compare enum and string fields in the recursive comparison https://redirect.github.com/assertj/assertj/issues/2616";>#2616 Provide value when assertThatThrownBy / thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3043";>#3043 Add isSealed and isNotSealed to Class assertions https://redirect.github.com/assertj/assertj/issues/3080";>#3080 Add assertThatCharSequence to disambiguate Groovy's GString https://redirect.github.com/assertj/assertj/issues/3132";>#3132 ... (truncated) Commits https://github.com/assertj/assertj/commit/65f6433d26f74795434ac2ef2118cd5cec7c1be4";>65f6433 [maven-release-plugin] prepare release assertj-build-3.25.1 https://github.com/assertj/assertj/commit/4753165446ddec5e25250e52e6e5582093793262";>4753165 Revert "fix: containsExactly does not work properly with maps not using equal... https://github.com/assertj/assertj/commit/2a7c5a6e205e29d42e9886657987893cb03b6875";>2a7c5a6 Revert "Provide value when assertThatThrownBy/thenThrownBy fail" (https://redirect.github.com/assertj/assertj/issues/3318";>#3318) https://github.com/assertj/assertj/commit/887f97b65da068e03308a6373a0c8a76912377aa";>887f97b Update license headers https://github.com/assertj/assertj/commit/25347d57bb28295548ec6bd5b06e70b6d03496c9";>25347d5 [maven-release-plugin] prepare for next development iteration https://github.com/assertj/assertj/commit/2c1c0839af66989c2d30d5b556799ca75ef2c246";>2c1c083 [maven-release-plugin] prepare release assertj-build-3.25.0 https://github.com/assertj/assertj/commit/c44129de725f5a3ecbaba16dd7b9ec31fd9e293b";>c44129d Move flatten-maven-plugin version to separate property https://github.com/assertj/assertj/commit/31cefaf68c04e13c6703033151f776251782af85";>31cefaf Apply flatten-maven-plugin to assertj-core and assertj-guava (https://redirect.github.com/assertj/assertj/issues/3311";>#3311) https://github.com/assertj/assertj/commit/435d183f2ededb18246338fb780098fabfba700b";>435d183 chore(deps-dev): bump org.testng:testng from 7.8.0 to 7.9.0 (https://redirect.github.com/assertj/assertj/issues/3312";>#3312) https://github.com/assertj/assertj/commit/e044604d99cdb513177d467886d51c47e0163251";>e044604 chore(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.4 to 3 Additional commits viewable in https://github.com/assertj/assertj/compare/assertj-build-3.24.2...assertj-build-3.25.1";>compare view [ from 3.24.2 to 3.25.1. Release notes Sourced from https://github.com/assertj/assertj/releases";>org.assertj:assertj-core's releases. v3.25.1 :jigsaw: Binary Compatibility The release is: Binary compatible with the previous minor version. Binary incompatible with the previous patch version. :bug: Bug Fixes Core Revert "Provide value when assertThatThrownBy/thenThrownBy fail" https://redirect.github.com/assertj/assertj/issues/3318";>#3318 Revert "fix: containsExactly does not work properly with maps not using equals to compare keys" https://redirect.github.com/assertj/assertj/issues/3321";>#3321 v3.25.0 :jigsaw: Binary Compatibility The release is https://assertj.github.io/doc/#binary-compatibility";>binary compatible with the previous minor version. :no_entry_sign: Deprecated Core Deprecate the following date/time related assertions in favor of isCloseTo: isEqualToIgnoringHours isEqualToIgnoringMinutes isEqualToIgnoringSeconds isEqualToIgnoringMillis isEqualToIgnoringNanos isInSameHourAs isInSameMinuteAs isInSameSecondAs Deprecate asList in favor of asInstanceOf https://redirect.github.com/assertj/assertj/issues/3138";>#3138 :sparkles: New Features Core Add Descriptable#describedAs(Supplier) Add isInThePast and isInTheFuture to LocalDate assertions https://redirect.github.com/assertj/assertj/issues/2933";>#2933 Add isInThePast and isInTheFuture to the missing Java 8 date/time types https://redirect.github.com/assertj/assertj/issues/2947";>#2947 Add isRecord and isNotRecord to Class assertions https://redirect.github.com/assertj/assertj/issues/2968";>#2968 Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert https://redirect.github.com/assertj/assertj/issues/2969";>#2969 Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions https://redirect.github.com/assertj/assertj/issues/2580";>#2580 Add hasRecordComponents to Class assertions https://redirect.github.com/assertj/assertj/issues/2995";>#2995 Add getters for field path in ComparisonDifference https://redirect.github.com/assertj/assertj/issues/3007";>#3007 Allow to compare enum and string fields in the recursive comparison https://redirect.github.com/assertj/assertj/issues/2616";>#2616 Provide value when assertThatThrownBy / thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3043";>#3043 Add isSealed and isNotSealed to Class assertions https://redirect.github.com/assertj/assertj/issues/3080";>#3080 Add assertThatCharSequence to disambiguate Groovy's GString https://redirect.github.com/assertj/assertj/issues/3132";>#3132 ... (truncated) Commits https://github.com/assertj/assertj/commit/65f6433d26f74795434ac2ef2118cd5cec7c1be4";>65f6433 [maven-release-plugin] prepare release assertj-build-3.25.1 https://github.com/assertj/assertj/commit/4753165446ddec5e25250e52e6e5582093793262";>4753165 Revert "fix: containsExactly does not work properly with maps not using equal... https://github.com/assertj/assertj/commit/2a7c5a6e205e29d42e9886657987893cb03b6875";>2a7c5a6 Revert "Provide value when assertThatThrownBy/thenThrownBy fail" (https://redirect.github.com/assertj/assertj/issues/3318";>#3318) https://github.com/assertj/assertj/commit/887f97b65da068e03308a6373a0c8a76912377aa";>887f97b Update license headers https://github.com/assertj/assertj/commit/25347d57bb28295548ec6bd5b06e70b6d03496c9";>25347d5 [maven-release-plugin] prepare for next development iteration https://github.com/assertj/assertj/commit/2c1c0839af66989c2d30d5b556799ca75ef2c246";>2c1c083 [maven-release-plugin] prepare release assertj-build-3.25.0 https://github.com/assertj/assertj/commit/c44129de725f5a3ecbaba16dd7b9ec31fd9e293b";>c44129d Move flatten-maven-plugin version to separate property https://github.com/assertj/assertj/commit/31cefaf68c04e13c6703033151f776251782af85";>31cefaf Apply flatten-maven-plugin to assertj-core and assertj-guava (https://redirect.github.com/assertj/assertj/issues/3311";>#3311) https://github.com/assertj/assertj/commit/435d183f2ededb18246338fb780098fabfba700b";>435d183 chore(deps-dev): bump org.testng:testng from 7.8.0 to 7.9.0 (https://redirect.github.com/assertj/assertj/issues/3312";>#3312) https://github.com/assertj/assertj/commit/e044604d99cdb513177d467886d51c47e0163251";>e044604 chore(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.4 to 3 Additional commits viewable in https://github.com/assertj/assertj/compare/assertj-build-3.24.2...assertj-build-3.25.1";>compare view [ from 3.24.2 to 3.25.1. Release notes Sourced from https://github.com/assertj/assertj/releases";>org.assertj:assertj-core's releases. v3.25.1 :jigsaw: Binary Compatibility The release is: Binary compatible with the previous minor version. Binary incompatible with the previous patch version. :bug: Bug Fixes Core Revert "Provide value when assertThatThrownBy/thenThrownBy fail" https://redirect.github.com/assertj/assertj/issues/3318";>#3318 Revert "fix: containsExactly does not work properly with maps not using equals to compare keys" https://redirect.github.com/assertj/assertj/issues/3321";>#3321 v3.25.0 :jigsaw: Binary Compatibility The release is https://assertj.github.io/doc/#binary-compatibility";>binary compatible with the previous minor version. :no_entry_sign: Deprecated Core Deprecate the following date/time related assertions in favor of isCloseTo: isEqualToIgnoringHours isEqualToIgnoringMinutes isEqualToIgnoringSeconds isEqualToIgnoringMillis isEqualToIgnoringNanos isInSameHourAs isInSameMinuteAs isInSameSecondAs Deprecate asList in favor of asInstanceOf https://redirect.github.com/assertj/assertj/issues/3138";>#3138 :sparkles: New Features Core Add Descriptable#describedAs(Supplier) Add isInThePast and isInTheFuture to LocalDate assertions https://redirect.github.com/assertj/assertj/issues/2933";>#2933 Add isInThePast and isInTheFuture to the missing Java 8 date/time types https://redirect.github.com/assertj/assertj/issues/2947";>#2947 Add isRecord and isNotRecord to Class assertions https://redirect.github.com/assertj/assertj/issues/2968";>#2968 Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert https://redirect.github.com/assertj/assertj/issues/2969";>#2969 Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions https://redirect.github.com/assertj/assertj/issues/2580";>#2580 Add hasRecordComponents to Class assertions https://redirect.github.com/assertj/assertj/issues/2995";>#2995 Add getters for field path in ComparisonDifference https://redirect.github.com/assertj/assertj/issues/3007";>#3007 Allow to compare enum and string fields in the recursive comparison https://redirect.github.com/assertj/assertj/issues/2616";>#2616 Provide value when assertThatThrownBy / thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3043";>#3043 Add isSealed and isNotSealed to Class assertions https://redirect.github.com/assertj/assertj/issues/3080";>#3080 Add assertThatCharSequence to disambiguate Groovy's GString https://redirect.github.com/assertj/assertj/issues/3132";>#3132 ... (truncated) Commits https://github.com/assertj/assertj/commit/65f6433d26f74795434ac2ef2118cd5cec7c1be4";>65f6433 [maven-release-plugin] prepare release assertj-build-3.25.1 https://github.com/assertj/assertj/commit/4753165446ddec5e25250e52e6e5582093793262";>4753165 Revert "fix: containsExactly does not work properly with maps not using equal... https://github.com/assertj/assertj/commit/2a7c5a6e205e29d42e9886657987893cb03b6875";>2a7c5a6 Revert "Provide value when assertThatThrownBy/thenThrownBy fail" (https://redirect.github.com/assertj/assertj/issues/3318";>#3318) https://github.com/assertj/assertj/commit/887f97b65da068e03308a6373a0c8a76912377aa";>887f97b Update license headers https://github.com/assertj/assertj/commit/25347d57bb28295548ec6bd5b06e70b6d03496c9";>25347d5 [maven-release-plugin] prepare for next development iteration https://github.com/assertj/assertj/commit/2c1c0839af66989c2d30d5b556799ca75ef2c246";>2c1c083 [maven-release-plugin] prepare release assertj-build-3.25.0 https://github.com/assertj/assertj/commit/c44129de725f5a3ecbaba16dd7b9ec31fd9e293b";>c44129d Move flatten-maven-plugin version to separate property https://github.com/assertj/assertj/commit/31cefaf68c04e13c6703033151f776251782af85";>31cefaf Apply flatten-maven-plugin to assertj-core and assertj-guava (https://redirect.github.com/assertj/assertj/issues/3311";>#3311) https://github.com/assertj/assertj/commit/435d183f2ededb18246338fb780098fabfba700b";>435d183 chore(deps-dev): bump org.testng:testng from 7.8.0 to 7.9.0 (https://redirect.github.com/assertj/assertj/issues/3312";>#3312) https://github.com/assertj/assertj/commit/e044604d99cdb513177d467886d51c47e0163251";>e044604 chore(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.4 to 3 Additional commits viewable in https://github.com/assertj/assertj/compare/assertj-build-3.24.2...assertj-build-3.25.1";>compare view [ from 3.24.2 to 3.25.1. Release notes Sourced from https://github.com/assertj/assertj/releases";>org.assertj:assertj-core's releases. v3.25.1 :jigsaw: Binary Compatibility The release is: Binary compatible with the previous minor version. Binary incompatible with the previous patch version. :bug: Bug Fixes Core Revert "Provide value when assertThatThrownBy/thenThrownBy fail" https://redirect.github.com/assertj/assertj/issues/3318";>#3318 Revert "fix: containsExactly does not work properly with maps not using equals to compare keys" https://redirect.github.com/assertj/assertj/issues/3321";>#3321 v3.25.0 :jigsaw: Binary Compatibility The release is https://assertj.github.io/doc/#binary-compatibility";>binary compatible with the previous minor version. :no_entry_sign: Deprecated Core Deprecate the following date/time related assertions in favor of isCloseTo: isEqualToIgnoringHours isEqualToIgnoringMinutes isEqualToIgnoringSeconds isEqualToIgnoringMillis isEqualToIgnoringNanos isInSameHourAs isInSameMinuteAs isInSameSecondAs Deprecate asList in favor of asInstanceOf https://redirect.github.com/assertj/assertj/issues/3138";>#3138 :sparkles: New Features Core Add Descriptable#describedAs(Supplier) Add isInThePast and isInTheFuture to LocalDate assertions https://redirect.github.com/assertj/assertj/issues/2933";>#2933 Add isInThePast and isInTheFuture to the missing Java 8 date/time types https://redirect.github.com/assertj/assertj/issues/2947";>#2947 Add isRecord and isNotRecord to Class assertions https://redirect.github.com/assertj/assertj/issues/2968";>#2968 Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert https://redirect.github.com/assertj/assertj/issues/2969";>#2969 Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions https://redirect.github.com/assertj/assertj/issues/2580";>#2580 Add hasRecordComponents to Class assertions https://redirect.github.com/assertj/assertj/issues/2995";>#2995 Add getters for field path in ComparisonDifference https://redirect.github.com/assertj/assertj/issues/3007";>#3007 Allow to compare enum and string fields in the recursive comparison https://redirect.github.com/assertj/assertj/issues/2616";>#2616 Provide value when assertThatThrownBy / thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3043";>#3043 Add isSealed and isNotSealed to Class assertions https://redirect.github.com/assertj/assertj/issues/3080";>#3080 Add assertThatCharSequence to disambiguate Groovy's GString https://redirect.github.com/assertj/assertj/issues/3132";>#3132 ... (truncated) Commits https://github.com/assertj/assertj/commit/65f6433d26f74795434ac2ef2118cd5cec7c1be4";>65f6433 [maven-release-plugin] prepare release assertj-build-3.25.1 https://github.com/assertj/assertj/commit/4753165446ddec5e25250e52e6e5582093793262";>4753165 Revert "fix: containsExactly does not work properly with maps not using equal... https://github.com/assertj/assertj/commit/2a7c5a6e205e29d42e9886657987893cb03b6875";>2a7c5a6 Revert "Provide value when assertThatThrownBy/thenThrownBy fail" (https://redirect.github.com/assertj/assertj/issues/3318";>#3318) https://github.com/assertj/assertj/commit/887f97b65da068e03308a6373a0c8a76912377aa";>887f97b Update license headers https://github.com/assertj/assertj/commit/25347d57bb28295548ec6bd5b06e70b6d03496c9";>25347d5 [maven-release-plugin] prepare for next development iteration https://github.com/assertj/assertj/commit/2c1c0839af66989c2d30d5b556799ca75ef2c246";>2c1c083 [maven-release-plugin] prepare release assertj-build-3.25.0 https://github.com/assertj/assertj/commit/c44129de725f5a3ecbaba16dd7b9ec31fd9e293b";>c44129d Move flatten-maven-plugin version to separate property https://github.com/assertj/assertj/commit/31cefaf68c04e13c6703033151f776251782af85";>31cefaf Apply flatten-maven-plugin to assertj-core and assertj-guava (https://redirect.github.com/assertj/assertj/issues/3311";>#3311) https://github.com/assertj/assertj/commit/435d183f2ededb18246338fb780098fabfba700b";>435d183 chore(deps-dev): bump org.testng:testng from 7.8.0 to 7.9.0 (https://redirect.github.com/assertj/assertj/issues/3312";>#3312) https://github.com/assertj/assertj/commit/e044604d99cdb513177d467886d51c47e0163251";>e044604 chore(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.4 to 3 Additional commits viewable in https://github.com/assertj/assertj/compare/assertj-build-3.24.2...assertj-build-3.25.1";>compare view [ with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump aether-spi from 1.7 to 1.13.1 [maven-archetype]
slachiewicz closed pull request #138: Bump aether-spi from 1.7 to 1.13.1 URL: https://github.com/apache/maven-archetype/pull/138 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (ARCHETYPE-653) Require Maven 3.2.5+
[ https://issues.apache.org/jira/browse/ARCHETYPE-653?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed ARCHETYPE-653. -- Resolution: Duplicate > Require Maven 3.2.5+ > > > Key: ARCHETYPE-653 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-653 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Priority: Minor > > [https://maven.apache.org/docs/history.html] > > "Maven before 3.6.3 has now reached its end of life. New plugin releases will > require Maven 3.2.5 or later. The following information is made available for > reference." -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump jdom2 from 2.0.6 to 2.0.6.1 [maven-archetype]
slachiewicz merged PR #140: URL: https://github.com/apache/maven-archetype/pull/140 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (ARCHETYPE-602) Set minimum enforced Maven version to 3.2.5
[ https://issues.apache.org/jira/browse/ARCHETYPE-602?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated ARCHETYPE-602: --- Summary: Set minimum enforced Maven version to 3.2.5 (was: Set minimum enforced Maven version to 3.1.0) > Set minimum enforced Maven version to 3.2.5 > --- > > Key: ARCHETYPE-602 > URL: https://issues.apache.org/jira/browse/ARCHETYPE-602 > Project: Maven Archetype > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Priority: Major > Fix For: 3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[ https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801933#comment-17801933 ] ASF GitHub Bot commented on MNG-6776: - michael-o commented on PR #1361: URL: https://github.com/apache/maven/pull/1361#issuecomment-1874589827 @slawekjaranowski This is a cherrypick from master. It does not change behavior. Unmodifiables should on main only and require a new issue. Note that this will need special handling in plugin tools otherwise it will fail. > Inconsistent list of parameters in MojoDescriptor > - > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.6.2 >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
michael-o commented on PR #1361: URL: https://github.com/apache/maven/pull/1361#issuecomment-1874589827 @slawekjaranowski This is a cherrypick from master. It does not change behavior. Unmodifiables should on main only and require a new issue. Note that this will need special handling in plugin tools otherwise it will fail. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801932#comment-17801932
]
ASF GitHub Bot commented on MSITE-1000:
---
kwin commented on code in PR #171:
URL: https://github.com/apache/maven-site-plugin/pull/171#discussion_r1439879467
##
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguration.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site.render;
+
+import java.util.LinkedList;
+import java.util.List;
+
+import org.apache.maven.shared.utils.io.MatchPattern;
+import org.apache.maven.shared.utils.io.MatchPatterns;
+
+public class ParserConfiguration {
+
+/**
+ * List of {@link MatchPattern} strings. If not set this configurations
applies to all documents.
+ */
+private final List patterns;
+/**
+ * @see {@link Parser#setEmitComments(boolean)}
+ */
+private boolean emitComments;
+/**
+ * @see {@link Parser#setEmitAnchorsForIndexableEntries(boolean)}
+ */
+private boolean emitAnchorsForIndexableEntries;
+
+public ParserConfiguration() {
+patterns = new LinkedList<>();
+}
+
+public boolean isEmitComments() {
+return emitComments;
+}
+
+public void setEmitComments(boolean emitComments) {
+this.emitComments = emitComments;
+}
+
+public boolean isEmitAnchorsForIndexableEntries() {
+return emitAnchorsForIndexableEntries;
+}
+
+public void setEmitAnchorsForIndexableEntries(boolean
emitAnchorsForIndexableEntries) {
+this.emitAnchorsForIndexableEntries = emitAnchorsForIndexableEntries;
+}
+
+public void addPattern(String pattern) {
+patterns.add(pattern);
+}
+
+public MatchPatterns getPatterns() {
Review Comment:
Returning a Predicate on the file name is probably better instead of
exposing the impl here.
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-710 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSITE-1000] Introduce parser configuration parameter [maven-site-plugin]
kwin commented on code in PR #171:
URL: https://github.com/apache/maven-site-plugin/pull/171#discussion_r1439879467
##
src/main/java/org/apache/maven/plugins/site/render/ParserConfiguration.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.site.render;
+
+import java.util.LinkedList;
+import java.util.List;
+
+import org.apache.maven.shared.utils.io.MatchPattern;
+import org.apache.maven.shared.utils.io.MatchPatterns;
+
+public class ParserConfiguration {
+
+/**
+ * List of {@link MatchPattern} strings. If not set this configurations
applies to all documents.
+ */
+private final List patterns;
+/**
+ * @see {@link Parser#setEmitComments(boolean)}
+ */
+private boolean emitComments;
+/**
+ * @see {@link Parser#setEmitAnchorsForIndexableEntries(boolean)}
+ */
+private boolean emitAnchorsForIndexableEntries;
+
+public ParserConfiguration() {
+patterns = new LinkedList<>();
+}
+
+public boolean isEmitComments() {
+return emitComments;
+}
+
+public void setEmitComments(boolean emitComments) {
+this.emitComments = emitComments;
+}
+
+public boolean isEmitAnchorsForIndexableEntries() {
+return emitAnchorsForIndexableEntries;
+}
+
+public void setEmitAnchorsForIndexableEntries(boolean
emitAnchorsForIndexableEntries) {
+this.emitAnchorsForIndexableEntries = emitAnchorsForIndexableEntries;
+}
+
+public void addPattern(String pattern) {
+patterns.add(pattern);
+}
+
+public MatchPatterns getPatterns() {
Review Comment:
Returning a Predicate on the file name is probably better instead of
exposing the impl here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MARCHETYPES-76) maven-archetype-quickstart generates EOLed maven.compiler setup
[ https://issues.apache.org/jira/browse/MARCHETYPES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801930#comment-17801930 ] ASF GitHub Bot commented on MARCHETYPES-76: --- elharo merged PR #25: URL: https://github.com/apache/maven-archetypes/pull/25 > maven-archetype-quickstart generates EOLed maven.compiler setup > > > Key: MARCHETYPES-76 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-76 > Project: Maven Archetype Bundles > Issue Type: Bug > Components: Maven Quickstart Archetype >Reporter: jiri vanek >Priority: Major > > The default imput to #compilerProperties is 1.7, which is making any > generated project to be not buildable with fresh jdk21. The default should > be1.8. Where jdk8 is still live and jdk21 is still comaptible with it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MARCHETYPES-76] maven-archetype-quickstart generates EOLed maven.compiler setup [maven-archetypes]
elharo merged PR #25: URL: https://github.com/apache/maven-archetypes/pull/25 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-velocity from 1.2 to 2.1.0 [maven-archetype]
elharo commented on PR #173: URL: https://github.com/apache/maven-archetype/pull/173#issuecomment-1874572483 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-invoker from 3.0.1 to 3.2.0 [maven-archetype]
elharo commented on PR #172: URL: https://github.com/apache/maven-archetype/pull/172#issuecomment-1874572265 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[
https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801907#comment-17801907
]
ASF GitHub Bot commented on MNG-6776:
-
slawekjaranowski commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1439751661
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -198,31 +200,25 @@ public void setParameters(List parameters)
throws DuplicateParameterE
* @throws DuplicateParameterException if any
*/
public void addParameter(Parameter parameter) throws
DuplicateParameterException {
-if (parameters != null && parameters.contains(parameter)) {
+if (parameters.contains(parameter)) {
throw new DuplicateParameterException(parameter.getName()
+ " has been declared multiple times in mojo with goal: "
+ getGoal() + " (implementation: "
+ getImplementation() + ")");
}
-if (parameters == null) {
-parameters = new LinkedList<>();
-}
-
parameters.add(parameter);
}
/**
- * @return the list parameters as a Map
+ * @return the list parameters as a Map (keyed by {@link
Parameter#getName()}) that is built from
+ * {@link #parameters} list on each call. In other words, the map returned
is built on fly and is a copy.
+ * Any change to this map is NOT reflected on list and other way around!
Review Comment:
unmodifiable?
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -163,31 +163,33 @@ public void setLanguage(String language) {
}
/**
- * @return Description with reason of a Mojo deprecation.
+ * @return true if the Mojo is deprecated, false
otherwise.
*/
public String getDeprecated() {
return deprecated;
}
/**
- * @param deprecated Description with reason of a Mojo deprecation.
+ * @param deprecated true to deprecate the Mojo,
false otherwise.
*/
public void setDeprecated(String deprecated) {
this.deprecated = deprecated;
}
/**
- * @return the list of parameters
+ * @return the list of parameters copy. Any change to returned list is NOT
reflected on this instance. To add
+ * parameters, use {@link #addParameter(Parameter)} method.
*/
public List getParameters() {
-return parameters;
+return new ArrayList<>(parameters);
Review Comment:
Maybe we should return unmodifiable collections, it will be difficult to
detect if someone try to change this.
> Inconsistent list of parameters in MojoDescriptor
> -
>
> Key: MNG-6776
> URL: https://issues.apache.org/jira/browse/MNG-6776
> Project: Maven
> Issue Type: Bug
> Components: Plugin API
>Affects Versions: 3.6.2
>Reporter: Sylwester Lachiewicz
>Assignee: Tamas Cservenak
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While working with maven-plugin-tools I discovered inconsistent results
> returned from MojoDescriptor getParameters() and getParametersMap().
> In
> [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101]
> If first I call MojoDescriptor.getParameterMap() and then later add parameter
> via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still
> return map with old (cached) list with parameters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
slawekjaranowski commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1439751661
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -198,31 +200,25 @@ public void setParameters(List parameters)
throws DuplicateParameterE
* @throws DuplicateParameterException if any
*/
public void addParameter(Parameter parameter) throws
DuplicateParameterException {
-if (parameters != null && parameters.contains(parameter)) {
+if (parameters.contains(parameter)) {
throw new DuplicateParameterException(parameter.getName()
+ " has been declared multiple times in mojo with goal: "
+ getGoal() + " (implementation: "
+ getImplementation() + ")");
}
-if (parameters == null) {
-parameters = new LinkedList<>();
-}
-
parameters.add(parameter);
}
/**
- * @return the list parameters as a Map
+ * @return the list parameters as a Map (keyed by {@link
Parameter#getName()}) that is built from
+ * {@link #parameters} list on each call. In other words, the map returned
is built on fly and is a copy.
+ * Any change to this map is NOT reflected on list and other way around!
Review Comment:
unmodifiable?
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -163,31 +163,33 @@ public void setLanguage(String language) {
}
/**
- * @return Description with reason of a Mojo deprecation.
+ * @return true if the Mojo is deprecated, false
otherwise.
*/
public String getDeprecated() {
return deprecated;
}
/**
- * @param deprecated Description with reason of a Mojo deprecation.
+ * @param deprecated true to deprecate the Mojo,
false otherwise.
*/
public void setDeprecated(String deprecated) {
this.deprecated = deprecated;
}
/**
- * @return the list of parameters
+ * @return the list of parameters copy. Any change to returned list is NOT
reflected on this instance. To add
+ * parameters, use {@link #addParameter(Parameter)} method.
*/
public List getParameters() {
-return parameters;
+return new ArrayList<>(parameters);
Review Comment:
Maybe we should return unmodifiable collections, it will be difficult to
detect if someone try to change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[ https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801892#comment-17801892 ] ASF GitHub Bot commented on MNG-6776: - michael-o opened a new pull request, #1361: URL: https://github.com/apache/maven/pull/1361 It may lead to confusion as parameters (list) and parametersMap (map) may "fall apart" easily. Also, parametersMap did not honor parameter ordering while parameters list makes it look that order is important. Simply, rebuild the map always and retain ordering as well. Added UT and also removed some cruft provided by java8. --- https://issues.apache.org/jira/browse/MNG-7309 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > Inconsistent list of parameters in MojoDescriptor > - > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.6.2 >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[ https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801893#comment-17801893 ] ASF GitHub Bot commented on MNG-6776: - michael-o commented on PR #1361: URL: https://github.com/apache/maven/pull/1361#issuecomment-1874393484 As a result of https://github.com/apache/maven-plugin-tools/pull/253 > Inconsistent list of parameters in MojoDescriptor > - > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.6.2 >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
michael-o commented on PR #1361: URL: https://github.com/apache/maven/pull/1361#issuecomment-1874393484 As a result of https://github.com/apache/maven-plugin-tools/pull/253 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
michael-o opened a new pull request, #1361: URL: https://github.com/apache/maven/pull/1361 It may lead to confusion as parameters (list) and parametersMap (map) may "fall apart" easily. Also, parametersMap did not honor parameter ordering while parameters list makes it look that order is important. Simply, rebuild the map always and retain ordering as well. Added UT and also removed some cruft provided by java8. --- https://issues.apache.org/jira/browse/MNG-7309 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Renamed local variable in maven archetype quickstart [maven-archetypes]
elharo commented on code in PR #26: URL: https://github.com/apache/maven-archetypes/pull/26#discussion_r1439707296 ## maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml: ## @@ -1,11 +1,11 @@ -#macro( compilerProperties $javaCompilerVersion ) +#macro( compilerProperties $javaCompilerVersionLocal ) Review Comment: Is this variable set by user code/properties somewhere that will need to update to the new name? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MARCHETYPES-78) Update default Java version in archetype projects to 1.8
[
https://issues.apache.org/jira/browse/MARCHETYPES-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated MARCHETYPES-78:
-
Description:
namely at least
maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml
maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml
maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml
maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml
maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml
maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml
maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml
still use 1.7 as default version.
I'm happy to fix them all (see
https://github.com/apache/maven-archetypes/pull/18 and
https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-76), but
first I need some ack from somebody with commit permissions to
MARCHETYPES/https://github.com/apache/maven-archetypes
{code:java}
grep -ir -e maven.compiler.source -e maven.compiler.target| grep -v test
maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
1.7
maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
1.7
maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
1.8
maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
1.8
maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
${jcv}
maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
${jcv}
{code}
with tests:
{code:java}
grep -ir -e maven.compiler.source -e maven.compiler.target
maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
1.7
maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
1.7
maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
1.8
maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
1.8
maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
1.7
maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
${jcv}
maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
${jcv}
maven-archetype-quickstart/src/test/resources/projects/it-java-7/reference/pom.xml:
1.7
maven-archetype-quickstart/src/test/resources/projects/it-java-7/reference/pom.xml:
1.7
maven-archetype-quickstart/src/test/resources/projects/it-java-7-junit-4.12/reference/pom.xml:
1.7
maven-archetype-quickstart/src/test/resources/projects/it-java-7-junit-4.12/reference/pom.xml:
1.7
{code}
was:
namely at least
maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml
maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resou
[jira] [Commented] (MARCHETYPES-78) Update default Java version in archetype projects to 1.8
[
https://issues.apache.org/jira/browse/MARCHETYPES-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801890#comment-17801890
]
ASF GitHub Bot commented on MARCHETYPES-78:
---
elharo merged PR #24:
URL: https://github.com/apache/maven-archetypes/pull/24
> Update default Java version in archetype projects to 1.8
>
>
> Key: MARCHETYPES-78
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-78
> Project: Maven Archetype Bundles
> Issue Type: Improvement
>Reporter: jiri vanek
>Priority: Major
>
> namely at least
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml
> still uses 1.7 as default version.
> I'm happy to fix them all (see
> https://github.com/apache/maven-archetypes/pull/18 and
> https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-76),
> but first I need some ack from somebody with commit permissions to
> MARCHETYPES/https://github.com/apache/maven-archetypes
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target| grep -v test
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> {code}
> with tests:
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> maven-archetype-quickstart/src/mai
Re: [PR] [MARCHETYPES-78] Update default Java version in archetype projects to 1.8 [maven-archetypes]
elharo merged PR #24: URL: https://github.com/apache/maven-archetypes/pull/24 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.0 to 4.9.1 [maven-archetype]
elharo merged PR #176: URL: https://github.com/apache/maven-archetype/pull/176 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump com.ibm.icu:icu4j from 70.1 to 74.2 [maven-archetype]
elharo merged PR #175: URL: https://github.com/apache/maven-archetype/pull/175 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-invoker-plugin from 3.5.1 to 3.6.0 [maven-archetype]
elharo merged PR #174: URL: https://github.com/apache/maven-archetype/pull/174 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2224) StatelessXmlReporter#getTestProblems() does not properly reflect report schema structure
[
https://issues.apache.org/jira/browse/SUREFIRE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801874#comment-17801874
]
ASF GitHub Bot commented on SUREFIRE-2224:
--
michael-o commented on code in PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#discussion_r1439670377
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##
@@ -456,21 +456,13 @@ private static void getTestProblems(
}
}
-boolean hasNestedElements = createOutErrElementsInside & stackTrace !=
null;
-
-if (stackTrace != null) {
-if (hasNestedElements) {
-ppw.startElement("stackTrace");
+if (enableNestedOutErrElements) {
+ppw.startElement("stackTrace");
+if (stackTrace != null) {
+extraEscapeElementValue(stackTrace, outputStreamWriter, ppw,
fw);
}
+ppw.endElement();
-extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
Review Comment:
I think I understand what you mean. Let me rephrase and I guess you are
right here, the schema is poorly designed. According to
https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
both `failure` and `error` aren't complex elements, thus do *not* contain
`stackTrace`. Their element body contains the strack trace? Is that the case,
if so I will cancel the vote and work on a fix and let you know.
> StatelessXmlReporter#getTestProblems() does not properly reflect report
> schema structure
>
>
> Key: SUREFIRE-2224
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2224
> Project: Maven Surefire
> Issue Type: Bug
> Components: xml generation
>Affects Versions: 3.2.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.4
>
>
> According to
> https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
> and
> https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/failsafe-test-report.xsd
> not all nested elements contain {{stackTrace}}, {{system-out}} and
> {{system-err}} elements, but the code makes it conditional whether there is a
> stack trace or not. This does not comply with the schema definition. Either
> the nested element is simple content or complex. In the latter {{stackTrace}}
> is mandatory, even if there is no strack trace according to the schema. The
> system streams are optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SUREFIRE-2224] StatelessXmlReporter#getTestProblems() does not properly reflect report schema structure [maven-surefire]
michael-o commented on code in PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#discussion_r1439670377
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##
@@ -456,21 +456,13 @@ private static void getTestProblems(
}
}
-boolean hasNestedElements = createOutErrElementsInside & stackTrace !=
null;
-
-if (stackTrace != null) {
-if (hasNestedElements) {
-ppw.startElement("stackTrace");
+if (enableNestedOutErrElements) {
+ppw.startElement("stackTrace");
+if (stackTrace != null) {
+extraEscapeElementValue(stackTrace, outputStreamWriter, ppw,
fw);
}
+ppw.endElement();
-extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
Review Comment:
I think I understand what you mean. Let me rephrase and I guess you are
right here, the schema is poorly designed. According to
https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
both `failure` and `error` aren't complex elements, thus do *not* contain
`stackTrace`. Their element body contains the strack trace? Is that the case,
if so I will cancel the vote and work on a fix and let you know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2224) StatelessXmlReporter#getTestProblems() does not properly reflect report schema structure
[
https://issues.apache.org/jira/browse/SUREFIRE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801873#comment-17801873
]
ASF GitHub Bot commented on SUREFIRE-2224:
--
michael-o commented on code in PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#discussion_r1439670377
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##
@@ -456,21 +456,13 @@ private static void getTestProblems(
}
}
-boolean hasNestedElements = createOutErrElementsInside & stackTrace !=
null;
-
-if (stackTrace != null) {
-if (hasNestedElements) {
-ppw.startElement("stackTrace");
+if (enableNestedOutErrElements) {
+ppw.startElement("stackTrace");
+if (stackTrace != null) {
+extraEscapeElementValue(stackTrace, outputStreamWriter, ppw,
fw);
}
+ppw.endElement();
-extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
Review Comment:
I think I understand what you mean. Let me rephrase and I guess you are
right here, the schema is poorly designed. According to
https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
both `failure` and `error` aren't complex elements, thus do *not* contain
`stackTrace`. Their element body contains the strack trace?
> StatelessXmlReporter#getTestProblems() does not properly reflect report
> schema structure
>
>
> Key: SUREFIRE-2224
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2224
> Project: Maven Surefire
> Issue Type: Bug
> Components: xml generation
>Affects Versions: 3.2.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.4
>
>
> According to
> https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
> and
> https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/failsafe-test-report.xsd
> not all nested elements contain {{stackTrace}}, {{system-out}} and
> {{system-err}} elements, but the code makes it conditional whether there is a
> stack trace or not. This does not comply with the schema definition. Either
> the nested element is simple content or complex. In the latter {{stackTrace}}
> is mandatory, even if there is no strack trace according to the schema. The
> system streams are optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SUREFIRE-2224] StatelessXmlReporter#getTestProblems() does not properly reflect report schema structure [maven-surefire]
michael-o commented on code in PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#discussion_r1439670377
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##
@@ -456,21 +456,13 @@ private static void getTestProblems(
}
}
-boolean hasNestedElements = createOutErrElementsInside & stackTrace !=
null;
-
-if (stackTrace != null) {
-if (hasNestedElements) {
-ppw.startElement("stackTrace");
+if (enableNestedOutErrElements) {
+ppw.startElement("stackTrace");
+if (stackTrace != null) {
+extraEscapeElementValue(stackTrace, outputStreamWriter, ppw,
fw);
}
+ppw.endElement();
-extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
Review Comment:
I think I understand what you mean. Let me rephrase and I guess you are
right here, the schema is poorly designed. According to
https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
both `failure` and `error` aren't complex elements, thus do *not* contain
`stackTrace`. Their element body contains the strack trace?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2224) StatelessXmlReporter#getTestProblems() does not properly reflect report schema structure
[
https://issues.apache.org/jira/browse/SUREFIRE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801871#comment-17801871
]
ASF GitHub Bot commented on SUREFIRE-2224:
--
marcphilipp commented on code in PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#discussion_r1439664959
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##
@@ -456,21 +456,13 @@ private static void getTestProblems(
}
}
-boolean hasNestedElements = createOutErrElementsInside & stackTrace !=
null;
-
-if (stackTrace != null) {
-if (hasNestedElements) {
-ppw.startElement("stackTrace");
+if (enableNestedOutErrElements) {
+ppw.startElement("stackTrace");
+if (stackTrace != null) {
+extraEscapeElementValue(stackTrace, outputStreamWriter, ppw,
fw);
}
+ppw.endElement();
-extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
Review Comment:
This still needs to be called if `stackTrace != null` and
`!enableNestedOutErrElements`. Otherwise, `error` and `failure` elements won't
contain the stack trace as their content.
> StatelessXmlReporter#getTestProblems() does not properly reflect report
> schema structure
>
>
> Key: SUREFIRE-2224
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2224
> Project: Maven Surefire
> Issue Type: Bug
> Components: xml generation
>Affects Versions: 3.2.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.4
>
>
> According to
> https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
> and
> https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/failsafe-test-report.xsd
> not all nested elements contain {{stackTrace}}, {{system-out}} and
> {{system-err}} elements, but the code makes it conditional whether there is a
> stack trace or not. This does not comply with the schema definition. Either
> the nested element is simple content or complex. In the latter {{stackTrace}}
> is mandatory, even if there is no strack trace according to the schema. The
> system streams are optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SUREFIRE-2224] StatelessXmlReporter#getTestProblems() does not properly reflect report schema structure [maven-surefire]
marcphilipp commented on code in PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#discussion_r1439664959
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##
@@ -456,21 +456,13 @@ private static void getTestProblems(
}
}
-boolean hasNestedElements = createOutErrElementsInside & stackTrace !=
null;
-
-if (stackTrace != null) {
-if (hasNestedElements) {
-ppw.startElement("stackTrace");
+if (enableNestedOutErrElements) {
+ppw.startElement("stackTrace");
+if (stackTrace != null) {
+extraEscapeElementValue(stackTrace, outputStreamWriter, ppw,
fw);
}
+ppw.endElement();
-extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
Review Comment:
This still needs to be called if `stackTrace != null` and
`!enableNestedOutErrElements`. Otherwise, `error` and `failure` elements won't
contain the stack trace as their content.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (SUREFIRE-2199) [WARNING] * org.apache.maven.plugins:maven-surefire-report-plugin:3.1.2
[
https://issues.apache.org/jira/browse/SUREFIRE-2199?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2199:
-
Fix Version/s: Backlog
> [WARNING] * org.apache.maven.plugins:maven-surefire-report-plugin:3.1.2
>
>
> Key: SUREFIRE-2199
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2199
> Project: Maven Surefire
> Issue Type: Wish
>Affects Versions: 3.1.2
>Reporter: Eric Kolotyluk
>Assignee: Michael Osipov
>Priority: Minor
> Fix For: Backlog
>
>
> When running {{mvn clean site -Dmaven.plugin.validation=VERBOSE}} I get
> {{[WARNING] * org.apache.maven.plugins:maven-surefire-report-plugin:3.1.2}}
> {{[WARNING] Declared at location(s):}}
> {{[WARNING] * unknown}}
> {{[WARNING] Mojo EXTERNAL issue(s):}}
> {{[WARNING] * Mojo surefire-report:failsafe-report-only
> (org.apache.maven.plugins.surefire.report.FailsafeReportMojo)}}
> {{[WARNING] - Parameter 'localRepository' uses deprecated parameter
> expression '${localRepository}': ArtifactRepository type is deprecated and
> its use in Mojos should be avoided.}}
> {{[WARNING] * Mojo surefire-report:report
> (org.apache.maven.plugins.surefire.report.SurefireReportMojo)}}
> {{[WARNING] - Parameter 'localRepository' uses deprecated parameter
> expression '${localRepository}': ArtifactRepository type is deprecated and
> its use in Mojos should be avoided.}}
> {{[WARNING] * Mojo surefire-report:report-only
> (org.apache.maven.plugins.surefire.report.SurefireReportOnlyMojo)}}
> {{[WARNING] - Parameter 'localRepository' uses deprecated parameter
> expression '${localRepository}': ArtifactRepository type is deprecated and
> its use in Mojos should be avoided.}}
> [WARNING]
> _*I wish I could eliminate all warnings in my projects, but it's not always
> easy or possible.*_ ;)
> My context is
> {{$ mvn -version}}
> {{Apache Maven 3.9.5 (57804ffe001d7215b5e7bcb531cf83df38f93546)}}
> {{Maven home: C:\Program Files (Open)\Apache\apache-maven-3.9.5}}
> {{Java version: 21, vendor: Oracle Corporation, runtime: C:\Program
> Files\java\jdk-21}}
> {{Default locale: en_CA, platform encoding: UTF-8}}
> {{OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"}}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MCHECKSTYLE-429) Deprecation warning
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-429?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MCHECKSTYLE-429:
---
Fix Version/s: 4.0.0-M1
> Deprecation warning
> ---
>
> Key: MCHECKSTYLE-429
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-429
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 3.2.1, 3.2.2
>Reporter: Lenny Primak
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 4.0.0-M1
>
>
> Every time checkstyle plugin is ran, the following warning occurs:
> {code:java}
> [INFO] --- checkstyle:3.2.1:checkstyle (default) @ shiro-cdi ---
> [WARNING] Parameter 'localRepository' is deprecated core expression; Avoid
> use of ArtifactRepository type. If you need access to local repository,
> switch to '${repositorySystemSession}' expression and get LRM from it instead.
> [INFO] Rendering content with
> org.apache.maven.skins:maven-default-skin:jar:1.3 skin.
> [INFO] Starting audit...
> Audit done.
> {code}
> Looks like maven 3.9.x deprecated `localRepository` variable and the plugin
> needs to be updated to reflect this
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1348) Upgrade plugins and components (in ITs)
[
https://issues.apache.org/jira/browse/MSHARED-1348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801857#comment-17801857
]
ASF GitHub Bot commented on MSHARED-1348:
-
michael-o opened a new pull request, #29:
URL: https://github.com/apache/maven-reporting-impl/pull/29
This closes #20
> Upgrade plugins and components (in ITs)
> ---
>
> Key: MSHARED-1348
> URL: https://issues.apache.org/jira/browse/MSHARED-1348
> Project: Maven Shared Components
> Issue Type: Dependency upgrade
> Components: maven-reporting-impl
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: maven-reporting-impl-4.0.0,
> maven-reporting-impl-4.0.0-M14
>
>
> * Upgrade to JUnit 5.10.1
> * Upgrade to Maven Site Plugin 4.0.0-M13
> * Also fixed issues reported by {{dependency:analyze}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MSHARED-1348) Upgrade plugins and components (in ITs)
Michael Osipov created MSHARED-1348:
---
Summary: Upgrade plugins and components (in ITs)
Key: MSHARED-1348
URL: https://issues.apache.org/jira/browse/MSHARED-1348
Project: Maven Shared Components
Issue Type: Dependency upgrade
Components: maven-reporting-impl
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: maven-reporting-impl-4.0.0-M14, maven-reporting-impl-4.0.0
* Upgrade to JUnit 5.10.1
* Upgrade to Maven Site Plugin 4.0.0-M13
* Also fixed issues reported by {{dependency:analyze}}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-76) maven-archetype-quickstart generates EOLed maven.compiler setup
[ https://issues.apache.org/jira/browse/MARCHETYPES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801849#comment-17801849 ] ASF GitHub Bot commented on MARCHETYPES-76: --- judovana commented on PR #25: URL: https://github.com/apache/maven-archetypes/pull/25#issuecomment-1874261752 I had rebased it so it is not based on https://github.com/apache/maven-archetypes/pull/23, as it do not need to be. I is still depending on https://github.com/apache/maven-archetypes/pull/24 anyway (aka have no reasoning without it) > maven-archetype-quickstart generates EOLed maven.compiler setup > > > Key: MARCHETYPES-76 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-76 > Project: Maven Archetype Bundles > Issue Type: Bug > Components: Maven Quickstart Archetype >Reporter: jiri vanek >Priority: Major > > The default imput to #compilerProperties is 1.7, which is making any > generated project to be not buildable with fresh jdk21. The default should > be1.8. Where jdk8 is still live and jdk21 is still comaptible with it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MARCHETYPES-76] maven-archetype-quickstart generates EOLed maven.compiler setup [maven-archetypes]
judovana commented on PR #25: URL: https://github.com/apache/maven-archetypes/pull/25#issuecomment-1874261752 I had rebased it so it is not based on https://github.com/apache/maven-archetypes/pull/23, as it do not need to be. I is still depending on https://github.com/apache/maven-archetypes/pull/24 anyway (aka have no reasoning without it) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add tests with Java 8 and 21 [maven-archetypes]
judovana commented on PR #23: URL: https://github.com/apache/maven-archetypes/pull/23#issuecomment-1874254805 The changes were split to several PRs on @ slachiewicz request -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MARCHETYPES-76) maven-archetype-quickstart generates EOLed maven.compiler setup
[ https://issues.apache.org/jira/browse/MARCHETYPES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801846#comment-17801846 ] ASF GitHub Bot commented on MARCHETYPES-76: --- judovana commented on PR #25: URL: https://github.com/apache/maven-archetypes/pull/25#issuecomment-1874253053 Note, that the CI on this is, and will be failing, untill https://github.com/apache/maven-archetypes/pull/24 is merged. I have no issues to add this into https://github.com/apache/maven-archetypes/pull/24 itself, but @slachiewicz required to have this test change in separate PR. Note, that without https://github.com/apache/maven-archetypes/pull/24 the change do not have any reasoning. > maven-archetype-quickstart generates EOLed maven.compiler setup > > > Key: MARCHETYPES-76 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-76 > Project: Maven Archetype Bundles > Issue Type: Bug > Components: Maven Quickstart Archetype >Reporter: jiri vanek >Priority: Major > > The default imput to #compilerProperties is 1.7, which is making any > generated project to be not buildable with fresh jdk21. The default should > be1.8. Where jdk8 is still live and jdk21 is still comaptible with it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MARCHETYPES-76] maven-archetype-quickstart generates EOLed maven.compiler setup [maven-archetypes]
judovana commented on PR #25: URL: https://github.com/apache/maven-archetypes/pull/25#issuecomment-1874253053 Note, that the CI on this is, and will be failing, untill https://github.com/apache/maven-archetypes/pull/24 is merged. I have no issues to add this into https://github.com/apache/maven-archetypes/pull/24 itself, but @slachiewicz required to have this test change in separate PR. Note, that without https://github.com/apache/maven-archetypes/pull/24 the change do not have any reasoning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add tests with Java 8 and 21 [maven-archetypes]
judovana commented on PR #23: URL: https://github.com/apache/maven-archetypes/pull/23#issuecomment-1874249710 hi! Sorry, I had to be explicit in initial comment - this is expected to fail, because jdk21 is not supported. If you look into https://github.com/apache/maven-archetypes/pull/24, which is adding jdk21 support, and which is based on this PR's commit, you will see the tests are passing -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801845#comment-17801845 ] ASF GitHub Bot commented on DOXIASITETOOLS-323: --- michael-o opened a new pull request, #125: URL: https://github.com/apache/maven-doxia-sitetools/pull/125 Co-authored-by: Sylwester Lachiewicz This closes #125 > Upgrade components > -- > > Key: DOXIASITETOOLS-323 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M17 > > > * Upgrade to Plexus Interpolation 1.27 > * Upgrade to Plexus Testing 1.3.0 > * Upgrade to Plexus Velocity 2.1.0 > * Upgrade to Commons Lang 3.14.0 > * Upgrade to Commons IO 2.15.1 > * Upgrade to JUnit 5.10.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (DOXIASITETOOLS-323) Upgrade components
Michael Osipov created DOXIASITETOOLS-323: - Summary: Upgrade components Key: DOXIASITETOOLS-323 URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323 Project: Maven Doxia Sitetools Issue Type: Dependency upgrade Reporter: Michael Osipov Fix For: 2.0.0, 2.0.0-M17 * Upgrade to Plexus Interpolation 1.27 * Upgrade to Plexus Testing 1.3.0 * Upgrade to Plexus Velocity 2.1.0 * Upgrade to Commons Lang 3.14.0 * Upgrade to Commons IO 2.15.1 * Upgrade to JUnit 5.10.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (DOXIASITETOOLS-323) Upgrade components
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned DOXIASITETOOLS-323: - Assignee: Michael Osipov > Upgrade components > -- > > Key: DOXIASITETOOLS-323 > URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323 > Project: Maven Doxia Sitetools > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M17 > > > * Upgrade to Plexus Interpolation 1.27 > * Upgrade to Plexus Testing 1.3.0 > * Upgrade to Plexus Velocity 2.1.0 > * Upgrade to Commons Lang 3.14.0 > * Upgrade to Commons IO 2.15.1 > * Upgrade to JUnit 5.10.1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump net.sourceforge.plantuml:plantuml from 1.2023.12 to 1.2023.13 [maven-site]
slawekjaranowski merged PR #476: URL: https://github.com/apache/maven-site/pull/476 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (DOXIA-721) Upgrade to JUnit 5.10.1
[ https://issues.apache.org/jira/browse/DOXIA-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIA-721. Resolution: Fixed Fixed with [7bf6861d31250f535e9ca79a4b9d443fcf4b1f7c|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=commit;h=7bf6861d31250f535e9ca79a4b9d443fcf4b1f7c]. > Upgrade to JUnit 5.10.1 > --- > > Key: DOXIA-721 > URL: https://issues.apache.org/jira/browse/DOXIA-721 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Minor > Fix For: 2.0.0, 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-721) Upgrade to JUnit 5.10.1
[ https://issues.apache.org/jira/browse/DOXIA-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801829#comment-17801829 ] ASF GitHub Bot commented on DOXIA-721: -- asfgit merged PR #191: URL: https://github.com/apache/maven-doxia/pull/191 > Upgrade to JUnit 5.10.1 > --- > > Key: DOXIA-721 > URL: https://issues.apache.org/jira/browse/DOXIA-721 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Minor > Fix For: 2.0.0, 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-721) Upgrade to JUnit 5.10.1
[ https://issues.apache.org/jira/browse/DOXIA-721?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801828#comment-17801828 ] ASF GitHub Bot commented on DOXIA-721: -- asfgit merged PR #191: URL: https://github.com/apache/maven-doxia/pull/191 > Upgrade to JUnit 5.10.1 > --- > > Key: DOXIA-721 > URL: https://issues.apache.org/jira/browse/DOXIA-721 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Minor > Fix For: 2.0.0, 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [DOXIA-721] Bump JUnit to 5.10.1 [maven-doxia]
asfgit merged PR #191: URL: https://github.com/apache/maven-doxia/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DOXIA-721] Bump JUnit to 5.10.1 [maven-doxia]
asfgit merged PR #191: URL: https://github.com/apache/maven-doxia/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Improve documentation about plugin-tools [maven-site]
slawekjaranowski merged PR #479: URL: https://github.com/apache/maven-site/pull/479 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (DOXIA-721) Upgrade to JUnit 5.10.1
[ https://issues.apache.org/jira/browse/DOXIA-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated DOXIA-721: - Summary: Upgrade to JUnit 5.10.1 (was: Bump JUnit from 5.10.0 to 5.10.1) > Upgrade to JUnit 5.10.1 > --- > > Key: DOXIA-721 > URL: https://issues.apache.org/jira/browse/DOXIA-721 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Minor > Fix For: 2.0.0, 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (DOXIA-721) Bump JUnit from 5.10.0 to 5.10.1
[ https://issues.apache.org/jira/browse/DOXIA-721?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned DOXIA-721: Assignee: Michael Osipov > Bump JUnit from 5.10.0 to 5.10.1 > > > Key: DOXIA-721 > URL: https://issues.apache.org/jira/browse/DOXIA-721 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Sylwester Lachiewicz >Assignee: Michael Osipov >Priority: Minor > Fix For: 2.0.0, 2.0.0-M9 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Extend info about cleanups after retirement [maven-site]
slawekjaranowski merged PR #481: URL: https://github.com/apache/maven-site/pull/481 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-2228) Upgrade to Doxia 2.0.0 Milestone Stack
Michael Osipov created SUREFIRE-2228: Summary: Upgrade to Doxia 2.0.0 Milestone Stack Key: SUREFIRE-2228 URL: https://issues.apache.org/jira/browse/SUREFIRE-2228 Project: Maven Surefire Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: Backlog * Ugprade to Doxia 2.0.0-M8 * Upgrade to Maven Reporting Impl 4.0.0-M13 * Upgrade to Maven Site Plugin 4.0.0-M13 * Upgrade to Maven Maven Project Info Reports Plugin 4.0.0-M1 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2161) Align Mojo class names and output names
[
https://issues.apache.org/jira/browse/SUREFIRE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801813#comment-17801813
]
ASF GitHub Bot commented on SUREFIRE-2161:
--
michael-o commented on PR #708:
URL: https://github.com/apache/maven-surefire/pull/708#issuecomment-1874130363
This is a prerequisite for Doxia 2.0.0.
> Align Mojo class names and output names
> ---
>
> Key: SUREFIRE-2161
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
> Project: Maven Surefire
> Issue Type: Task
> Components: Maven Surefire Report Plugin
>Affects Versions: 3.0.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: Backlog
>
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | -{{FailsafeReportMojo}}- \\ {{FailsafeOnlyReport}} || -{{failsafe-report}}-
> \\ {{failsafe}} |
> | -{{SurefireReportMojo}}- \\ {{SurefireReport}} || -{{surefire-report}}- \\
> {{surefire}} |
> | -{{SurefireReportOnlyMojo}}- \\ {{SurefireOnlyReport}} ||
> -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2161) Align Mojo class names and output names
[
https://issues.apache.org/jira/browse/SUREFIRE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801812#comment-17801812
]
ASF GitHub Bot commented on SUREFIRE-2161:
--
michael-o opened a new pull request, #708:
URL: https://github.com/apache/maven-surefire/pull/708
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> Align Mojo class names and output names
> ---
>
> Key: SUREFIRE-2161
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
> Project: Maven Surefire
> Issue Type: Task
> Components: Maven Surefire Report Plugin
>Affects Versions: 3.0.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: Backlog
>
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | -{{FailsafeReportMojo}}- \\ {{FailsafeOnlyReport}} || -{{failsafe-report}}-
> \\ {{failsafe}} |
> | -{{SurefireReportMojo}}- \\ {{SurefireReport}} || -{{surefire-report}}- \\
> {{surefire}} |
> | -{{SurefireReportOnlyMojo}}- \\ {{SurefireOnlyReport}} ||
> -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SUREFIRE-2161] Align Mojo class names and output names [maven-surefire]
michael-o commented on PR #708: URL: https://github.com/apache/maven-surefire/pull/708#issuecomment-1874130363 This is a prerequisite for Doxia 2.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SUREFIRE-2161] Align Mojo class names and output names [maven-surefire]
michael-o opened a new pull request, #708: URL: https://github.com/apache/maven-surefire/pull/708 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7986) Spurious JUnit 4.12 jar on boot classpath
[
https://issues.apache.org/jira/browse/MNG-7986?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801808#comment-17801808
]
Marc Philipp commented on MNG-7986:
---
Thanks for looking into this! Our intention for reporting this issue was to
make you aware that there apparently was some change that breaks existing
plugins. You're right to point out there are newer versions that work just fine
and anyone should update all plugins before migrating to Maven 4.x. To us it
looked like a change in plexus-java that affects dependency management and
might also have the potential to break other usages.
> Spurious JUnit 4.12 jar on boot classpath
> -
>
> Key: MNG-7986
> URL: https://issues.apache.org/jira/browse/MNG-7986
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 4.0.0-alpha-9
>Reporter: Jean Gauthier
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: output-maven-4.0.0-alpha8-surefire-2.22.2.txt,
> output-maven-4.0.0-alpha9-surefire-2.22.2.txt,
> output-maven-4.0.0-alpha9-surefire-3.0.0-M4.txt, reproducer.zip
>
>
> We noticed a regression in Maven 4.0.0-alpha9 for Surefire versions
> 2.21.0-3.0.0-M3: when specifying a dependency to JUnit 4.13, JUnit 4.12 gets
> added before it on the boot classpath.
> This causes issues e.g. when defining a custom JUnit 4 RunListener in a
> project: because JUnit 4.12 is listed first, the new {{testSuiteStarted}}
> callback that was added in 4.13 does not get invoked anymore.
> This can be reproduced by running {{./mvnw clean test
> -Dorg.slf4j.simpleLogger.log.org.apache.maven.plugin.surefire.SurefirePlugin=debug}}
> on the attached project (and setting the Maven/Surefire versions
> accordingly).
> I have also added the output logs for the following version combinations as
> attachment to the ticket:
> * Maven 4.0.0-alpha8 + Surefire 2.22.2 => works correctly (contains
> {{RunListener - testSuiteStarted}})
> * Maven 4.0.0-alpha9 + Surefire 2.22.2 => broken (does not contain
> {{RunListener - testSuiteStarted}})
> * Maven 4.0.0-alpha9 + Surefire 3.0.0-M4 => works correctly (contains
> {{RunListener - testSuiteStarted}})
> Please let me know in case additional information is needed.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SUREFIRE-2161) Align Mojo class names and output names
[
https://issues.apache.org/jira/browse/SUREFIRE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2161:
-
Description:
Currently, names in those mojos are inconsistent with the rest of our reports,
namely, the output name does not have an explicit {{-report}} suffix, the goal
name should match the class name. Other plugins have been aligned long time
ago, it is about time for this one:
|| Mojo class name || output name ||
| -{{FailsafeReportMojo}}- \\ {{FailsafeOnlyReport}} || -{{failsafe-report}}-
\\ {{failsafe}} |
| -{{SurefireReportMojo}}- \\ {{SurefireReport}} || -{{surefire-report}}- \\
{{surefire}} |
| -{{SurefireReportOnlyMojo}}- \\ {{SurefireOnlyReport}} ||
-{{surefire-report}}- \\ {{surefire}} |
was:
Currently, names in those mojos are inconsistent with the rest of our reports,
namely, the output name does not have an explicit {{-report}} suffix, the goal
name should match the class name. Other plugins have been aligned long time
ago, it is about time for this one:
|| Mojo class name || output name ||
| -{{FailsafeReport}}- \\ {{FailsafeOnlyReport}} || -{{failsafe-report}}- \\
{{failsafe}} |
| {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
| {{SurefireOnlyReport}} || -{{surefire-report}}- \\ {{surefire}} |
> Align Mojo class names and output names
> ---
>
> Key: SUREFIRE-2161
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
> Project: Maven Surefire
> Issue Type: Task
> Components: Maven Surefire Report Plugin
>Affects Versions: 3.0.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: Backlog
>
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | -{{FailsafeReportMojo}}- \\ {{FailsafeOnlyReport}} || -{{failsafe-report}}-
> \\ {{failsafe}} |
> | -{{SurefireReportMojo}}- \\ {{SurefireReport}} || -{{surefire-report}}- \\
> {{surefire}} |
> | -{{SurefireReportOnlyMojo}}- \\ {{SurefireOnlyReport}} ||
> -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (SUREFIRE-2161) Align Mojo class names and output names
[
https://issues.apache.org/jira/browse/SUREFIRE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2161:
-
Description:
Currently, names in those mojos are inconsistent with the rest of our reports,
namely, the output name does not have an explicit {{-report}} suffix, the goal
name should match the class name. Other plugins have been aligned long time
ago, it is about time for this one:
|| Mojo class name || output name ||
| -{{FailsafeReport}}- \\ {{FailsafeOnlyReport}} || -{{failsafe-report}}- \\
{{failsafe}} |
| {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
| {{SurefireOnlyReport}} || -{{surefire-report}}- \\ {{surefire}} |
was:
Currently, names in those mojos are inconsistent with the rest of our reports,
namely, the output name does not have an explicit {{-report}} suffix, the goal
name should match the class name. Other plugins have been aligned long time
ago, it is about time for this one:
|| Mojo class name || output name ||
| -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} || -{{failsafe-report}}- \\
{{failsafe}} |
| {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
| {{SurefireReportOnly}} || -{{surefire-report}}- \\ {{surefire}} |
> Align Mojo class names and output names
> ---
>
> Key: SUREFIRE-2161
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
> Project: Maven Surefire
> Issue Type: Task
> Components: Maven Surefire Report Plugin
>Affects Versions: 3.0.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: Backlog
>
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | -{{FailsafeReport}}- \\ {{FailsafeOnlyReport}} || -{{failsafe-report}}- \\
> {{failsafe}} |
> | {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
> | {{SurefireOnlyReport}} || -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2161) Align Mojo class names and output names
[
https://issues.apache.org/jira/browse/SUREFIRE-2161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17801795#comment-17801795
]
Michael Osipov commented on SUREFIRE-2161:
--
This will also include the renaming of
{{org.apache.maven.plugin.surefire.SurefirePlugin}} to
{{org.apache.maven.plugin.surefire.SurefireMojo}}.
> Align Mojo class names and output names
> ---
>
> Key: SUREFIRE-2161
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2161
> Project: Maven Surefire
> Issue Type: Task
> Components: Maven Surefire Report Plugin
>Affects Versions: 3.0.0
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: Backlog
>
>
> Currently, names in those mojos are inconsistent with the rest of our
> reports, namely, the output name does not have an explicit {{-report}}
> suffix, the goal name should match the class name. Other plugins have been
> aligned long time ago, it is about time for this one:
> || Mojo class name || output name ||
> | -{{FailsafeReport}}- \\ {{FailsafeReportOnly}} || -{{failsafe-report}}- \\
> {{failsafe}} |
> | {{SurefireReport}} || -{{surefire-report}}- \\ {{surefire}} |
> | {{SurefireReportOnly}} || -{{surefire-report}}- \\ {{surefire}} |
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SUREFIRE-2227) Dynamically calculate xrefTestLocation
Michael Osipov created SUREFIRE-2227:
Summary: Dynamically calculate xrefTestLocation
Key: SUREFIRE-2227
URL: https://issues.apache.org/jira/browse/SUREFIRE-2227
Project: Maven Surefire
Issue Type: Improvement
Components: Maven Surefire Report Plugin
Affects Versions: 3.2.3
Reporter: Michael Osipov
Assignee: Michael Osipov
Fix For: Backlog
After MSHARED-1327 we need to dynamically calculate where (Test) XRef report
resides. Unless an explicit value has been provided.
The calculation considers both standalone mode *and* site mode.
The parameter {{xrefLocation}} will be renamed to {{xrefTestLocation}} because
we only link to test source code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
