[jira] [Updated] (SUREFIRE-2232) StatelessXmlReporter fails to process failed result without a throwable
[
https://issues.apache.org/jira/browse/SUREFIRE-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2232:
-
Fix Version/s: waiting-for-feedback
(was: Backlog)
> StatelessXmlReporter fails to process failed result without a throwable
> ---
>
> Key: SUREFIRE-2232
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2232
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M6, 3.2.3
>Reporter: Artem Yak
>Priority: Minor
> Fix For: waiting-for-feedback
>
>
>
> A regression bug appeared in 3.0.0-M6:
> A testNG test class has a listener which updates results from SUCCESS to
> FAILURE:
>
> {noformat}
> @Override
> public void onTestSuccess(ITestResult result) {
> result.setStatus(ITestResult.FAILURE);
> result.getTestContext().getPassedTests().removeResult(result);
> result.getTestContext().getFailedTests().addResult(result);
> }{noformat}
>
> Surefire fails to process a failed test result without a throwable and
> reports 0 total tests.
> {code:java}
> ForkStarter IOException: java.util.NoSuchElementException.
> org.apache.maven.plugin.surefire.booterclient.output.MultipleFailureException:
> java.util.NoSuchElementException
> at
> org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.(ThreadedStreamConsumer.java:59)
> at
> org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer.(ThreadedStreamConsumer.java:107)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:546)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:285)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:250)
> {code}
>
> Reproducible unit test.
> {code:java}
> package org.apache.maven.plugin.surefire.report;
> import java.io.File;
> import java.util.HashMap;
> import java.util.concurrent.atomic.AtomicInteger;
> import junit.framework.TestCase;
> import
> org.apache.maven.plugin.surefire.booterclient.output.DeserializedStacktraceWriter;
> import org.apache.maven.surefire.api.report.SimpleReportEntry;
> import org.apache.maven.surefire.api.report.StackTraceWriter;
> import static org.apache.maven.plugin.surefire.report.ReportEntryType.ERROR;
> import static org.apache.maven.surefire.api.report.RunMode.NORMAL_RUN;
> @SuppressWarnings({"ResultOfMethodCallIgnored", "checkstyle:magicnumber"})
> public class StatelessXmlReporter2Test extends TestCase {
> private static final String XSD =
>
> "https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report-3.0.xsd;;
> private static final AtomicInteger FOLDER_POSTFIX = new AtomicInteger();
> private File reportDir;
> @Override
> protected void setUp() throws Exception {
> File basedir = new File(".");
> File target = new File(basedir.getCanonicalFile(), "target");
> target.mkdir();
> String reportRelDir = getClass().getSimpleName() + "-" +
> FOLDER_POSTFIX.incrementAndGet();
> reportDir = new File(target, reportRelDir);
> reportDir.mkdir();
> }
> @Override
> protected void tearDown() {
> }
> public void testOutputFailedTestWithoutThrowable() {
> StackTraceWriter stackTraceWriterOne = new
> DeserializedStacktraceWriter(null, null, "");
> WrappedReportEntry testReport = new WrappedReportEntry(
> new SimpleReportEntry(
> NORMAL_RUN, 1L, getClass().getName(), null, "a test name",
> null, stackTraceWriterOne, 5),
> ERROR,
> 5,
> null,
> null);
> TestSetStats testSetStats = new TestSetStats(false, false);
> testSetStats.testError(testReport);
> StatelessXmlReporter reporter = new StatelessXmlReporter(
> reportDir, null, false, 1, new HashMap<>(), XSD, "3.0", false,
> false, false, false);
> reporter.testSetCompleted(testReport, testSetStats);
> }
> } {code}
>
>
>
> {code:java}
> java.util.NoSuchElementException
> at java.base/java.util.StringTokenizer.nextToken(StringTokenizer.java:349)
> at
> org.apache.maven.plugin.surefire.report.StatelessXmlReporter.getTestProblems(StatelessXmlReporter.java:454)
> at
> org.apache.maven.plugin.surefire.report.StatelessXmlReporter.serializeTestClassWithRerun(StatelessXmlReporter.java:256)
> at
> org.apache.maven.plugin.surefire.report.StatelessXmlReporter.serializeTestClass(StatelessXmlReporter.java:207)
> at
> org.apache.maven.plugin.surefire.report.StatelessXmlReporter.testSetCompleted(StatelessXmlReporter.java:161)
> at
>
[jira] [Updated] (SUREFIRE-2232) StatelessXmlReporter fails to process failed result without a throwable
[
https://issues.apache.org/jira/browse/SUREFIRE-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2232:
-
Fix Version/s: Backlog
> StatelessXmlReporter fails to process failed result without a throwable
> ---
>
> Key: SUREFIRE-2232
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2232
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M6, 3.2.3
>Reporter: Artem Yak
>Priority: Minor
> Fix For: Backlog
>
>
>
> A regression bug appeared in 3.0.0-M6:
> A testNG test class has a listener which updates results from SUCCESS to
> FAILURE:
>
> {noformat}
> @Override
> public void onTestSuccess(ITestResult result) {
> result.setStatus(ITestResult.FAILURE);
> result.getTestContext().getPassedTests().removeResult(result);
> result.getTestContext().getFailedTests().addResult(result);
> }{noformat}
>
> Surefire fails to process a failed test result without a throwable and
> reports 0 total tests.
> {code:java}
> ForkStarter IOException: java.util.NoSuchElementException.
> org.apache.maven.plugin.surefire.booterclient.output.MultipleFailureException:
> java.util.NoSuchElementException
> at
> org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.(ThreadedStreamConsumer.java:59)
> at
> org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer.(ThreadedStreamConsumer.java:107)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:546)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:285)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:250)
> {code}
>
> Reproducible unit test.
> {code:java}
> package org.apache.maven.plugin.surefire.report;
> import java.io.File;
> import java.util.HashMap;
> import java.util.concurrent.atomic.AtomicInteger;
> import junit.framework.TestCase;
> import
> org.apache.maven.plugin.surefire.booterclient.output.DeserializedStacktraceWriter;
> import org.apache.maven.surefire.api.report.SimpleReportEntry;
> import org.apache.maven.surefire.api.report.StackTraceWriter;
> import static org.apache.maven.plugin.surefire.report.ReportEntryType.ERROR;
> import static org.apache.maven.surefire.api.report.RunMode.NORMAL_RUN;
> @SuppressWarnings({"ResultOfMethodCallIgnored", "checkstyle:magicnumber"})
> public class StatelessXmlReporter2Test extends TestCase {
> private static final String XSD =
>
> "https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report-3.0.xsd;;
> private static final AtomicInteger FOLDER_POSTFIX = new AtomicInteger();
> private File reportDir;
> @Override
> protected void setUp() throws Exception {
> File basedir = new File(".");
> File target = new File(basedir.getCanonicalFile(), "target");
> target.mkdir();
> String reportRelDir = getClass().getSimpleName() + "-" +
> FOLDER_POSTFIX.incrementAndGet();
> reportDir = new File(target, reportRelDir);
> reportDir.mkdir();
> }
> @Override
> protected void tearDown() {
> }
> public void testOutputFailedTestWithoutThrowable() {
> StackTraceWriter stackTraceWriterOne = new
> DeserializedStacktraceWriter(null, null, "");
> WrappedReportEntry testReport = new WrappedReportEntry(
> new SimpleReportEntry(
> NORMAL_RUN, 1L, getClass().getName(), null, "a test name",
> null, stackTraceWriterOne, 5),
> ERROR,
> 5,
> null,
> null);
> TestSetStats testSetStats = new TestSetStats(false, false);
> testSetStats.testError(testReport);
> StatelessXmlReporter reporter = new StatelessXmlReporter(
> reportDir, null, false, 1, new HashMap<>(), XSD, "3.0", false,
> false, false, false);
> reporter.testSetCompleted(testReport, testSetStats);
> }
> } {code}
>
>
>
> {code:java}
> java.util.NoSuchElementException
> at java.base/java.util.StringTokenizer.nextToken(StringTokenizer.java:349)
> at
> org.apache.maven.plugin.surefire.report.StatelessXmlReporter.getTestProblems(StatelessXmlReporter.java:454)
> at
> org.apache.maven.plugin.surefire.report.StatelessXmlReporter.serializeTestClassWithRerun(StatelessXmlReporter.java:256)
> at
> org.apache.maven.plugin.surefire.report.StatelessXmlReporter.serializeTestClass(StatelessXmlReporter.java:207)
> at
> org.apache.maven.plugin.surefire.report.StatelessXmlReporter.testSetCompleted(StatelessXmlReporter.java:161)
> at
>
[jira] [Commented] (SUREFIRE-2232) StatelessXmlReporter fails to process failed result without a throwable
[
https://issues.apache.org/jira/browse/SUREFIRE-2232?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804989#comment-17804989
]
Michael Osipov commented on SUREFIRE-2232:
--
Please try 3.2.5.
> StatelessXmlReporter fails to process failed result without a throwable
> ---
>
> Key: SUREFIRE-2232
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2232
> Project: Maven Surefire
> Issue Type: Bug
> Components: Maven Surefire Plugin
>Affects Versions: 3.0.0-M6, 3.2.3
>Reporter: Artem Yak
>Priority: Minor
>
>
> A regression bug appeared in 3.0.0-M6:
> A testNG test class has a listener which updates results from SUCCESS to
> FAILURE:
>
> {noformat}
> @Override
> public void onTestSuccess(ITestResult result) {
> result.setStatus(ITestResult.FAILURE);
> result.getTestContext().getPassedTests().removeResult(result);
> result.getTestContext().getFailedTests().addResult(result);
> }{noformat}
>
> Surefire fails to process a failed test result without a throwable and
> reports 0 total tests.
> {code:java}
> ForkStarter IOException: java.util.NoSuchElementException.
> org.apache.maven.plugin.surefire.booterclient.output.MultipleFailureException:
> java.util.NoSuchElementException
> at
> org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.(ThreadedStreamConsumer.java:59)
> at
> org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer.(ThreadedStreamConsumer.java:107)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:546)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:285)
> at
> org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:250)
> {code}
>
> Reproducible unit test.
> {code:java}
> package org.apache.maven.plugin.surefire.report;
> import java.io.File;
> import java.util.HashMap;
> import java.util.concurrent.atomic.AtomicInteger;
> import junit.framework.TestCase;
> import
> org.apache.maven.plugin.surefire.booterclient.output.DeserializedStacktraceWriter;
> import org.apache.maven.surefire.api.report.SimpleReportEntry;
> import org.apache.maven.surefire.api.report.StackTraceWriter;
> import static org.apache.maven.plugin.surefire.report.ReportEntryType.ERROR;
> import static org.apache.maven.surefire.api.report.RunMode.NORMAL_RUN;
> @SuppressWarnings({"ResultOfMethodCallIgnored", "checkstyle:magicnumber"})
> public class StatelessXmlReporter2Test extends TestCase {
> private static final String XSD =
>
> "https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report-3.0.xsd;;
> private static final AtomicInteger FOLDER_POSTFIX = new AtomicInteger();
> private File reportDir;
> @Override
> protected void setUp() throws Exception {
> File basedir = new File(".");
> File target = new File(basedir.getCanonicalFile(), "target");
> target.mkdir();
> String reportRelDir = getClass().getSimpleName() + "-" +
> FOLDER_POSTFIX.incrementAndGet();
> reportDir = new File(target, reportRelDir);
> reportDir.mkdir();
> }
> @Override
> protected void tearDown() {
> }
> public void testOutputFailedTestWithoutThrowable() {
> StackTraceWriter stackTraceWriterOne = new
> DeserializedStacktraceWriter(null, null, "");
> WrappedReportEntry testReport = new WrappedReportEntry(
> new SimpleReportEntry(
> NORMAL_RUN, 1L, getClass().getName(), null, "a test name",
> null, stackTraceWriterOne, 5),
> ERROR,
> 5,
> null,
> null);
> TestSetStats testSetStats = new TestSetStats(false, false);
> testSetStats.testError(testReport);
> StatelessXmlReporter reporter = new StatelessXmlReporter(
> reportDir, null, false, 1, new HashMap<>(), XSD, "3.0", false,
> false, false, false);
> reporter.testSetCompleted(testReport, testSetStats);
> }
> } {code}
>
>
>
> {code:java}
> java.util.NoSuchElementException
> at java.base/java.util.StringTokenizer.nextToken(StringTokenizer.java:349)
> at
> org.apache.maven.plugin.surefire.report.StatelessXmlReporter.getTestProblems(StatelessXmlReporter.java:454)
> at
> org.apache.maven.plugin.surefire.report.StatelessXmlReporter.serializeTestClassWithRerun(StatelessXmlReporter.java:256)
> at
> org.apache.maven.plugin.surefire.report.StatelessXmlReporter.serializeTestClass(StatelessXmlReporter.java:207)
> at
> org.apache.maven.plugin.surefire.report.StatelessXmlReporter.testSetCompleted(StatelessXmlReporter.java:161)
> at
>
[jira] [Commented] (MNG-8000) DefaultArtifact lacks constructors for version and optional
[ https://issues.apache.org/jira/browse/MNG-8000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804971#comment-17804971 ] ASF GitHub Bot commented on MNG-8000: - CrazyHZM opened a new pull request, #1368: URL: https://github.com/apache/maven/pull/1368 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ > DefaultArtifact lacks constructors for version and optional > --- > > Key: MNG-8000 > URL: https://issues.apache.org/jira/browse/MNG-8000 > Project: Maven > Issue Type: Task > Components: Core >Affects Versions: 4.0.0-alpha-10 >Reporter: Zhongming Hua >Priority: Minor > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MNG-8000] DefaultArtifact lacks constructors for version and optional [maven]
CrazyHZM opened a new pull request, #1368: URL: https://github.com/apache/maven/pull/1368 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-8000) DefaultArtifact lacks constructors for version and optional
Zhongming Hua created MNG-8000: -- Summary: DefaultArtifact lacks constructors for version and optional Key: MNG-8000 URL: https://issues.apache.org/jira/browse/MNG-8000 Project: Maven Issue Type: Task Components: Core Affects Versions: 4.0.0-alpha-10 Reporter: Zhongming Hua -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] Bump version.maven-surefire from 3.2.2 to 3.2.5 [maven-apache-parent]
dependabot[bot] opened a new pull request, #186: URL: https://github.com/apache/maven-apache-parent/pull/186 Bumps `version.maven-surefire` from 3.2.2 to 3.2.5. Updates `org.apache.maven.plugins:maven-failsafe-plugin` from 3.2.2 to 3.2.5 Commits https://github.com/apache/maven-surefire/commit/4b3a2719d80613f2ed304fc34144fed81c3043cd;>4b3a271 [maven-release-plugin] prepare release surefire-3.2.5 https://github.com/apache/maven-surefire/commit/eb3f1d946fbb9d1dbaba2fc7113f408f15a60f62;>eb3f1d9 Bump org.codehaus.plexus:plexus-component-metadata from 2.1.1 to 2.2.0 https://github.com/apache/maven-surefire/commit/430c406756df4e6bfad462426544d71a0d5e5867;>430c406 Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 https://github.com/apache/maven-surefire/commit/2d92f2d422f07e75c188312cd2371127508a8e10;>2d92f2d [SUREFIRE-2231] JaCoCo 0.8.11 fails with old TestNG releases on Java 17+ https://github.com/apache/maven-surefire/commit/3290740be8d81351331d5cd320e56346713ed2c2;>3290740 Bump org.apache.maven.plugins:maven-docck-plugin from 1.1 to 1.2 https://github.com/apache/maven-surefire/commit/25a9776c0e1d0c445a1ef5dbcb7ee27483bb029d;>25a9776 Bump net.java.dev.javacc:javacc from 7.0.12 to 7.0.13 https://github.com/apache/maven-surefire/commit/7752f7e62bf6710616e231c9a0cf6cd7e574416f;>7752f7e Bump commons-io:commons-io from 2.15.0 to 2.15.1 https://github.com/apache/maven-surefire/commit/8874add5bb1b32e65eb5022f02d7bb01add9a3a8;>8874add Revert Bump jacocoVersion from 0.8.8 to 0.8.11 https://github.com/apache/maven-surefire/commit/c0f775569b4ddd603a1c5c96e16abc78aa794173;>c0f7755 Fix formatting https://github.com/apache/maven-surefire/commit/e5f45452728fe78753e713b15ce4743634db01a2;>e5f4545 Bump jacocoVersion from 0.8.8 to 0.8.11 Additional commits viewable in https://github.com/apache/maven-surefire/compare/surefire-3.2.2...surefire-3.2.5;>compare view Updates `org.apache.maven.plugins:maven-surefire-plugin` from 3.2.2 to 3.2.5 Commits https://github.com/apache/maven-surefire/commit/4b3a2719d80613f2ed304fc34144fed81c3043cd;>4b3a271 [maven-release-plugin] prepare release surefire-3.2.5 https://github.com/apache/maven-surefire/commit/eb3f1d946fbb9d1dbaba2fc7113f408f15a60f62;>eb3f1d9 Bump org.codehaus.plexus:plexus-component-metadata from 2.1.1 to 2.2.0 https://github.com/apache/maven-surefire/commit/430c406756df4e6bfad462426544d71a0d5e5867;>430c406 Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 https://github.com/apache/maven-surefire/commit/2d92f2d422f07e75c188312cd2371127508a8e10;>2d92f2d [SUREFIRE-2231] JaCoCo 0.8.11 fails with old TestNG releases on Java 17+ https://github.com/apache/maven-surefire/commit/3290740be8d81351331d5cd320e56346713ed2c2;>3290740 Bump org.apache.maven.plugins:maven-docck-plugin from 1.1 to 1.2 https://github.com/apache/maven-surefire/commit/25a9776c0e1d0c445a1ef5dbcb7ee27483bb029d;>25a9776 Bump net.java.dev.javacc:javacc from 7.0.12 to 7.0.13 https://github.com/apache/maven-surefire/commit/7752f7e62bf6710616e231c9a0cf6cd7e574416f;>7752f7e Bump commons-io:commons-io from 2.15.0 to 2.15.1 https://github.com/apache/maven-surefire/commit/8874add5bb1b32e65eb5022f02d7bb01add9a3a8;>8874add Revert Bump jacocoVersion from 0.8.8 to 0.8.11 https://github.com/apache/maven-surefire/commit/c0f775569b4ddd603a1c5c96e16abc78aa794173;>c0f7755 Fix formatting https://github.com/apache/maven-surefire/commit/e5f45452728fe78753e713b15ce4743634db01a2;>e5f4545 Bump jacocoVersion from 0.8.8 to 0.8.11 Additional commits viewable in https://github.com/apache/maven-surefire/compare/surefire-3.2.2...surefire-3.2.5;>compare view Updates `org.apache.maven.plugins:maven-surefire-report-plugin` from 3.2.2 to 3.2.5 Commits https://github.com/apache/maven-surefire/commit/4b3a2719d80613f2ed304fc34144fed81c3043cd;>4b3a271 [maven-release-plugin] prepare release surefire-3.2.5 https://github.com/apache/maven-surefire/commit/eb3f1d946fbb9d1dbaba2fc7113f408f15a60f62;>eb3f1d9 Bump org.codehaus.plexus:plexus-component-metadata from 2.1.1 to 2.2.0 https://github.com/apache/maven-surefire/commit/430c406756df4e6bfad462426544d71a0d5e5867;>430c406 Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 https://github.com/apache/maven-surefire/commit/2d92f2d422f07e75c188312cd2371127508a8e10;>2d92f2d [SUREFIRE-2231] JaCoCo 0.8.11 fails with old TestNG releases on Java 17+ https://github.com/apache/maven-surefire/commit/3290740be8d81351331d5cd320e56346713ed2c2;>3290740 Bump org.apache.maven.plugins:maven-docck-plugin from 1.1 to 1.2 https://github.com/apache/maven-surefire/commit/25a9776c0e1d0c445a1ef5dbcb7ee27483bb029d;>25a9776 Bump net.java.dev.javacc:javacc from 7.0.12 to 7.0.13 https://github.com/apache/maven-surefire/commit/7752f7e62bf6710616e231c9a0cf6cd7e574416f;>7752f7e Bump commons-io:commons-io from 2.15.0 to 2.15.1
[PR] Bump doxiaVersion from 2.0.0-M8 to 2.0.0-M9 [maven-site-plugin]
dependabot[bot] opened a new pull request, #172: URL: https://github.com/apache/maven-site-plugin/pull/172 Bumps `doxiaVersion` from 2.0.0-M8 to 2.0.0-M9. Updates `org.apache.maven.doxia:doxia-sink-api` from 2.0.0-M8 to 2.0.0-M9 Commits https://github.com/apache/maven-doxia/commit/a145f7613da5e7f9721da125780255041c46de98;>a145f76 [maven-release-plugin] prepare release doxia-2.0.0-M9 https://github.com/apache/maven-doxia/commit/1b32ad456fdf6fa6342cb08dfeb4e35bed25c739;>1b32ad4 [DOXIA-695] Support heading level 6 (https://redirect.github.com/apache/maven-doxia/issues/193;>#193) https://github.com/apache/maven-doxia/commit/e8fac7f66a76379f05121df021fe0144a4300fac;>e8fac7f Bump org.jetbrains:annotations from 24.0.1 to 24.1.0 https://github.com/apache/maven-doxia/commit/7a04c033456511e1bd4870f03ba768d03158f368;>7a04c03 [DOXIA-722] Optionally create anchors for index entries (used in TOC (https://redirect.github.com/apache/maven-doxia/issues/180;>#180) https://github.com/apache/maven-doxia/commit/7bf6861d31250f535e9ca79a4b9d443fcf4b1f7c;>7bf6861 [DOXIA-721] Upgrade to JUnit 5.10.1 https://github.com/apache/maven-doxia/commit/ff8445fd25d64e18ca4913a523b6510984513607;>ff8445f Remove fault dep declaration https://github.com/apache/maven-doxia/commit/cd6f0ce93f488a6504c975cef831e43777dfcd91;>cd6f0ce [DOXIA-720] Upgrade to Parent 41 https://github.com/apache/maven-doxia/commit/6056509c937713463e7eaad8c4e23150376178aa;>6056509 [DOXIA-717] Upgrade to org.codehaus.plexus:plexus-testing 1.3.0 https://github.com/apache/maven-doxia/commit/87e8ba0e44fd5bea37edacbea62f6936c2274914;>87e8ba0 [DOXIA-719] Properly manage Commons IO/Lang 3 https://github.com/apache/maven-doxia/commit/e43b2001d52119a1f48815180effd2ce643809ae;>e43b200 [DOXIA-716] Update and unify XMLReader creation and configuration Additional commits viewable in https://github.com/apache/maven-doxia/compare/doxia-2.0.0-M8...doxia-2.0.0-M9;>compare view Updates `org.apache.maven.doxia:doxia-core` from 2.0.0-M8 to 2.0.0-M9 Commits https://github.com/apache/maven-doxia/commit/a145f7613da5e7f9721da125780255041c46de98;>a145f76 [maven-release-plugin] prepare release doxia-2.0.0-M9 https://github.com/apache/maven-doxia/commit/1b32ad456fdf6fa6342cb08dfeb4e35bed25c739;>1b32ad4 [DOXIA-695] Support heading level 6 (https://redirect.github.com/apache/maven-doxia/issues/193;>#193) https://github.com/apache/maven-doxia/commit/e8fac7f66a76379f05121df021fe0144a4300fac;>e8fac7f Bump org.jetbrains:annotations from 24.0.1 to 24.1.0 https://github.com/apache/maven-doxia/commit/7a04c033456511e1bd4870f03ba768d03158f368;>7a04c03 [DOXIA-722] Optionally create anchors for index entries (used in TOC (https://redirect.github.com/apache/maven-doxia/issues/180;>#180) https://github.com/apache/maven-doxia/commit/7bf6861d31250f535e9ca79a4b9d443fcf4b1f7c;>7bf6861 [DOXIA-721] Upgrade to JUnit 5.10.1 https://github.com/apache/maven-doxia/commit/ff8445fd25d64e18ca4913a523b6510984513607;>ff8445f Remove fault dep declaration https://github.com/apache/maven-doxia/commit/cd6f0ce93f488a6504c975cef831e43777dfcd91;>cd6f0ce [DOXIA-720] Upgrade to Parent 41 https://github.com/apache/maven-doxia/commit/6056509c937713463e7eaad8c4e23150376178aa;>6056509 [DOXIA-717] Upgrade to org.codehaus.plexus:plexus-testing 1.3.0 https://github.com/apache/maven-doxia/commit/87e8ba0e44fd5bea37edacbea62f6936c2274914;>87e8ba0 [DOXIA-719] Properly manage Commons IO/Lang 3 https://github.com/apache/maven-doxia/commit/e43b2001d52119a1f48815180effd2ce643809ae;>e43b200 [DOXIA-716] Update and unify XMLReader creation and configuration Additional commits viewable in https://github.com/apache/maven-doxia/compare/doxia-2.0.0-M8...doxia-2.0.0-M9;>compare view Updates `org.apache.maven.doxia:doxia-module-xhtml5` from 2.0.0-M8 to 2.0.0-M9 Updates `org.apache.maven.doxia:doxia-module-apt` from 2.0.0-M8 to 2.0.0-M9 Updates `org.apache.maven.doxia:doxia-module-xdoc` from 2.0.0-M8 to 2.0.0-M9 Updates `org.apache.maven.doxia:doxia-module-fml` from 2.0.0-M8 to 2.0.0-M9 Updates `org.apache.maven.doxia:doxia-module-markdown` from 2.0.0-M8 to 2.0.0-M9 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel
Re: [PR] Bump doxiaVersion from 2.0.0-M6 to 2.0.0-M8 [maven-doxia-converter]
dependabot[bot] commented on PR #54: URL: https://github.com/apache/maven-doxia-converter/pull/54#issuecomment-1884162463 Superseded by #61. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump doxiaVersion from 2.0.0-M6 to 2.0.0-M8 [maven-doxia-converter]
dependabot[bot] closed pull request #54: Bump doxiaVersion from 2.0.0-M6 to 2.0.0-M8 URL: https://github.com/apache/maven-doxia-converter/pull/54 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump doxiaVersion from 2.0.0-M6 to 2.0.0-M9 [maven-doxia-converter]
dependabot[bot] opened a new pull request, #61: URL: https://github.com/apache/maven-doxia-converter/pull/61 Bumps `doxiaVersion` from 2.0.0-M6 to 2.0.0-M9. Updates `org.apache.maven.doxia:doxia-core` from 2.0.0-M6 to 2.0.0-M9 Commits https://github.com/apache/maven-doxia/commit/a145f7613da5e7f9721da125780255041c46de98;>a145f76 [maven-release-plugin] prepare release doxia-2.0.0-M9 https://github.com/apache/maven-doxia/commit/1b32ad456fdf6fa6342cb08dfeb4e35bed25c739;>1b32ad4 [DOXIA-695] Support heading level 6 (https://redirect.github.com/apache/maven-doxia/issues/193;>#193) https://github.com/apache/maven-doxia/commit/e8fac7f66a76379f05121df021fe0144a4300fac;>e8fac7f Bump org.jetbrains:annotations from 24.0.1 to 24.1.0 https://github.com/apache/maven-doxia/commit/7a04c033456511e1bd4870f03ba768d03158f368;>7a04c03 [DOXIA-722] Optionally create anchors for index entries (used in TOC (https://redirect.github.com/apache/maven-doxia/issues/180;>#180) https://github.com/apache/maven-doxia/commit/7bf6861d31250f535e9ca79a4b9d443fcf4b1f7c;>7bf6861 [DOXIA-721] Upgrade to JUnit 5.10.1 https://github.com/apache/maven-doxia/commit/ff8445fd25d64e18ca4913a523b6510984513607;>ff8445f Remove fault dep declaration https://github.com/apache/maven-doxia/commit/cd6f0ce93f488a6504c975cef831e43777dfcd91;>cd6f0ce [DOXIA-720] Upgrade to Parent 41 https://github.com/apache/maven-doxia/commit/6056509c937713463e7eaad8c4e23150376178aa;>6056509 [DOXIA-717] Upgrade to org.codehaus.plexus:plexus-testing 1.3.0 https://github.com/apache/maven-doxia/commit/87e8ba0e44fd5bea37edacbea62f6936c2274914;>87e8ba0 [DOXIA-719] Properly manage Commons IO/Lang 3 https://github.com/apache/maven-doxia/commit/e43b2001d52119a1f48815180effd2ce643809ae;>e43b200 [DOXIA-716] Update and unify XMLReader creation and configuration Additional commits viewable in https://github.com/apache/maven-doxia/compare/doxia-2.0.0-M6...doxia-2.0.0-M9;>compare view Updates `org.apache.maven.doxia:doxia-sink-api` from 2.0.0-M6 to 2.0.0-M9 Commits https://github.com/apache/maven-doxia/commit/a145f7613da5e7f9721da125780255041c46de98;>a145f76 [maven-release-plugin] prepare release doxia-2.0.0-M9 https://github.com/apache/maven-doxia/commit/1b32ad456fdf6fa6342cb08dfeb4e35bed25c739;>1b32ad4 [DOXIA-695] Support heading level 6 (https://redirect.github.com/apache/maven-doxia/issues/193;>#193) https://github.com/apache/maven-doxia/commit/e8fac7f66a76379f05121df021fe0144a4300fac;>e8fac7f Bump org.jetbrains:annotations from 24.0.1 to 24.1.0 https://github.com/apache/maven-doxia/commit/7a04c033456511e1bd4870f03ba768d03158f368;>7a04c03 [DOXIA-722] Optionally create anchors for index entries (used in TOC (https://redirect.github.com/apache/maven-doxia/issues/180;>#180) https://github.com/apache/maven-doxia/commit/7bf6861d31250f535e9ca79a4b9d443fcf4b1f7c;>7bf6861 [DOXIA-721] Upgrade to JUnit 5.10.1 https://github.com/apache/maven-doxia/commit/ff8445fd25d64e18ca4913a523b6510984513607;>ff8445f Remove fault dep declaration https://github.com/apache/maven-doxia/commit/cd6f0ce93f488a6504c975cef831e43777dfcd91;>cd6f0ce [DOXIA-720] Upgrade to Parent 41 https://github.com/apache/maven-doxia/commit/6056509c937713463e7eaad8c4e23150376178aa;>6056509 [DOXIA-717] Upgrade to org.codehaus.plexus:plexus-testing 1.3.0 https://github.com/apache/maven-doxia/commit/87e8ba0e44fd5bea37edacbea62f6936c2274914;>87e8ba0 [DOXIA-719] Properly manage Commons IO/Lang 3 https://github.com/apache/maven-doxia/commit/e43b2001d52119a1f48815180effd2ce643809ae;>e43b200 [DOXIA-716] Update and unify XMLReader creation and configuration Additional commits viewable in https://github.com/apache/maven-doxia/compare/doxia-2.0.0-M6...doxia-2.0.0-M9;>compare view Updates `org.apache.maven.doxia:doxia-module-apt` from 2.0.0-M6 to 2.0.0-M9 Updates `org.apache.maven.doxia:doxia-module-fml` from 2.0.0-M6 to 2.0.0-M9 Updates `org.apache.maven.doxia:doxia-module-xdoc` from 2.0.0-M6 to 2.0.0-M9 Updates `org.apache.maven.doxia:doxia-module-xhtml5` from 2.0.0-M6 to 2.0.0-M9 Updates `org.apache.maven.doxia:doxia-module-markdown` from 2.0.0-M6 to 2.0.0-M9 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel
[jira] [Commented] (MNG-7976) Investigate MNG-6127 IT instability
[ https://issues.apache.org/jira/browse/MNG-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804962#comment-17804962 ] Zhongming Hua commented on MNG-7976: [~cstamas] I can find the log from [https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/master/509/artifact/core-it-suite-logs-linux-jdk11.zip]. Let‘s wait for it to reappear.:D > Investigate MNG-6127 IT instability > --- > > Key: MNG-7976 > URL: https://issues.apache.org/jira/browse/MNG-7976 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > > The MNG-6127 IT quite often fails, and passes when CI job rebuilt, seems > unstable. > Look into it why (lurking concurrency bug somewhere? or just the IT is > flakey?) and fix it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.0 to 4.9.1 [maven-javadoc-plugin]
elharo commented on PR #263: URL: https://github.com/apache/maven-javadoc-plugin/pull/263#issuecomment-1884123094 Error: Internal server error occurred while resolving "actions/checkout@v4". Internal server error occurred while resolving "actions/setup-java@v4". Internal server error occurred while resolving "actions/upload-artifact@v4" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-io from 3.4.1 to 3.4.2 [maven-javadoc-plugin]
elharo commented on PR #262: URL: https://github.com/apache/maven-javadoc-plugin/pull/262#issuecomment-1884121951 CI loks borked: Error: Could not find satisfied version for SemVer '21'. Available versions: 20.0.2+9, 20.0.1+9, 19.0.2+7, 18.0.2+9, 18.0.2+9, 18.0.1+102, 18.0.1+10, 17.0.9+9, 17.0.8+101, 17.0.8+7, 17.0.7+7, 17.0.6+10, 17.0.5+8, 17.0.4+101, 17.0.4+8, 17.0.3+7, 17.0.2+8, 17.0.1+12, 16.0.2+7, 16.0.1+9, 16.0.0+36, 15.0.2+7, 15.0.1+9, 15.0.0+36, 14.0.2+12, 14.0.1+7.1, 14.0.0+36.1, 14.0.0+36.1, 13.0.2+8.1, 13.0.1+9.1, 13.0.0+33.1, 12.0.2+10.1, 12.0.1+12, 12.0.0+33, 11.0.21+9, 11.0.20+101, 11.0.20+8, 11.0.19+7, 11.0.18+10, 11.0.17+8, 11.0.16+101, 11.0.16+8, 11.0.15+10, 11.0.14+101, 11.0.14+9, 11.0.13+8, 11.0.12+7, 11.0.11+9, 11.0.10+9, 11.0.9+11, 11.0.8+10, 11.0.7+10.1, 11.0.6+10.1, 11.0.6+10.1, 11.0.5+10.1, 11.0.4+11.1, 11.0.3+7, 11.0.3+7, 11.0.2+9, 11.0.2+9, 11.0.1+13, 11.0.0+28, 10.0.2+13, 9.0.4+12, 8.0.392+8, 8.0.382+5, 8.0.372+7, 8.0.362+9, 8.0.352+8, 8.0.345+1, 8.0.345+1, 8.0.345+1, 8.0.332+9, 8.0.322+6, 8.0.312+7, 8.0.302+8, 8.0.292+10, 8.0.282+8, 8.0.275+1, 8.0.272+10, 8.0.265+1, 8.0.262+10, 8.0.252+9.1, 8.0.242+8.1, 8.0.232+9.1, 8.0.222+10.1, 8.0. 212+4.openj9-0.14.2, 8.0.212+3.openj9-0.14.0, 8.0.202+8.openj9-0.12.1, 8.0.202+8, 8.0.192+12.openj9-0.11.0, 8.0.192+12, 8.0.181+13.openj9-0.9.0, 8.0.162+12.openj9-0.8.0 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (SUREFIRE-2232) StatelessXmlReporter fails to process failed result without a throwable
Artem Yak created SUREFIRE-2232:
---
Summary: StatelessXmlReporter fails to process failed result
without a throwable
Key: SUREFIRE-2232
URL: https://issues.apache.org/jira/browse/SUREFIRE-2232
Project: Maven Surefire
Issue Type: Bug
Components: Maven Surefire Plugin
Affects Versions: 3.2.3, 3.0.0-M6
Reporter: Artem Yak
A regression bug appeared in 3.0.0-M6:
A testNG test class has a listener which updates results from SUCCESS to
FAILURE:
{noformat}
@Override
public void onTestSuccess(ITestResult result) {
result.setStatus(ITestResult.FAILURE);
result.getTestContext().getPassedTests().removeResult(result);
result.getTestContext().getFailedTests().addResult(result);
}{noformat}
Surefire fails to process a failed test result without a throwable and reports
0 total tests.
{code:java}
ForkStarter IOException: java.util.NoSuchElementException.
org.apache.maven.plugin.surefire.booterclient.output.MultipleFailureException:
java.util.NoSuchElementException
at
org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.(ThreadedStreamConsumer.java:59)
at
org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer.(ThreadedStreamConsumer.java:107)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.fork(ForkStarter.java:546)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:285)
at
org.apache.maven.plugin.surefire.booterclient.ForkStarter.run(ForkStarter.java:250)
{code}
Reproducible unit test.
{code:java}
package org.apache.maven.plugin.surefire.report;
import java.io.File;
import java.util.HashMap;
import java.util.concurrent.atomic.AtomicInteger;
import junit.framework.TestCase;
import
org.apache.maven.plugin.surefire.booterclient.output.DeserializedStacktraceWriter;
import org.apache.maven.surefire.api.report.SimpleReportEntry;
import org.apache.maven.surefire.api.report.StackTraceWriter;
import static org.apache.maven.plugin.surefire.report.ReportEntryType.ERROR;
import static org.apache.maven.surefire.api.report.RunMode.NORMAL_RUN;
@SuppressWarnings({"ResultOfMethodCallIgnored", "checkstyle:magicnumber"})
public class StatelessXmlReporter2Test extends TestCase {
private static final String XSD =
"https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report-3.0.xsd;;
private static final AtomicInteger FOLDER_POSTFIX = new AtomicInteger();
private File reportDir;
@Override
protected void setUp() throws Exception {
File basedir = new File(".");
File target = new File(basedir.getCanonicalFile(), "target");
target.mkdir();
String reportRelDir = getClass().getSimpleName() + "-" +
FOLDER_POSTFIX.incrementAndGet();
reportDir = new File(target, reportRelDir);
reportDir.mkdir();
}
@Override
protected void tearDown() {
}
public void testOutputFailedTestWithoutThrowable() {
StackTraceWriter stackTraceWriterOne = new
DeserializedStacktraceWriter(null, null, "");
WrappedReportEntry testReport = new WrappedReportEntry(
new SimpleReportEntry(
NORMAL_RUN, 1L, getClass().getName(), null, "a test name",
null, stackTraceWriterOne, 5),
ERROR,
5,
null,
null);
TestSetStats testSetStats = new TestSetStats(false, false);
testSetStats.testError(testReport);
StatelessXmlReporter reporter = new StatelessXmlReporter(
reportDir, null, false, 1, new HashMap<>(), XSD, "3.0", false,
false, false, false);
reporter.testSetCompleted(testReport, testSetStats);
}
} {code}
{code:java}
java.util.NoSuchElementException
at java.base/java.util.StringTokenizer.nextToken(StringTokenizer.java:349)
at
org.apache.maven.plugin.surefire.report.StatelessXmlReporter.getTestProblems(StatelessXmlReporter.java:454)
at
org.apache.maven.plugin.surefire.report.StatelessXmlReporter.serializeTestClassWithRerun(StatelessXmlReporter.java:256)
at
org.apache.maven.plugin.surefire.report.StatelessXmlReporter.serializeTestClass(StatelessXmlReporter.java:207)
at
org.apache.maven.plugin.surefire.report.StatelessXmlReporter.testSetCompleted(StatelessXmlReporter.java:161)
at
org.apache.maven.plugin.surefire.report.StatelessXmlReporter2Test.testOutputFailedTestWithoutThrowable(StatelessXmlReporter2Test.java:72){code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1350) Upgrade parent POM to version 41
[ https://issues.apache.org/jira/browse/MSHARED-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804916#comment-17804916 ] ASF GitHub Bot commented on MSHARED-1350: - slachiewicz merged PR #103: URL: https://github.com/apache/maven-script-interpreter/pull/103 > Upgrade parent POM to version 41 > > > Key: MSHARED-1350 > URL: https://issues.apache.org/jira/browse/MSHARED-1350 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-script-interpreter >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: maven-script-interpreter-1.5 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MSHARED-1350) Upgrade parent POM to version 41
[ https://issues.apache.org/jira/browse/MSHARED-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MSHARED-1350: - Assignee: Sylwester Lachiewicz > Upgrade parent POM to version 41 > > > Key: MSHARED-1350 > URL: https://issues.apache.org/jira/browse/MSHARED-1350 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-script-interpreter >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: maven-script-interpreter-1.5 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MSHARED-1350) Upgrade parent POM to version 41
[ https://issues.apache.org/jira/browse/MSHARED-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MSHARED-1350. - Resolution: Fixed > Upgrade parent POM to version 41 > > > Key: MSHARED-1350 > URL: https://issues.apache.org/jira/browse/MSHARED-1350 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-script-interpreter >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: maven-script-interpreter-1.5 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSHARED-1350] Upgrade parent POM to version 41 [maven-script-interpreter]
slachiewicz merged PR #103: URL: https://github.com/apache/maven-script-interpreter/pull/103 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 39 to 41 [maven-script-interpreter]
dependabot[bot] commented on PR #101: URL: https://github.com/apache/maven-script-interpreter/pull/101#issuecomment-1883945371 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 39 to 41 [maven-script-interpreter]
slachiewicz closed pull request #101: Bump org.apache.maven.shared:maven-shared-components from 39 to 41 URL: https://github.com/apache/maven-script-interpreter/pull/101 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1350) Upgrade parent POM to version 41
[ https://issues.apache.org/jira/browse/MSHARED-1350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804913#comment-17804913 ] ASF GitHub Bot commented on MSHARED-1350: - slachiewicz opened a new pull request, #103: URL: https://github.com/apache/maven-script-interpreter/pull/103 (no comment) > Upgrade parent POM to version 41 > > > Key: MSHARED-1350 > URL: https://issues.apache.org/jira/browse/MSHARED-1350 > Project: Maven Shared Components > Issue Type: Dependency upgrade > Components: maven-script-interpreter >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: maven-script-interpreter-1.5 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.apache.maven.plugins:maven-site-plugin from 4.0.0-M8 to 4.0.0-M13 [maven-site]
dependabot[bot] commented on PR #477: URL: https://github.com/apache/maven-site/pull/477#issuecomment-1883938825 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-site-plugin from 4.0.0-M8 to 4.0.0-M13 [maven-site]
asfgit closed pull request #477: Bump org.apache.maven.plugins:maven-site-plugin from 4.0.0-M8 to 4.0.0-M13 URL: https://github.com/apache/maven-site/pull/477 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MPOM-375) Add license header automatically to all files
[
https://issues.apache.org/jira/browse/MPOM-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804905#comment-17804905
]
Sylwester Lachiewicz commented on MPOM-375:
---
{quote}Improvement published in {{plugin-maven 2.35.0}}
{quote}
> Add license header automatically to all files
> -
>
> Key: MPOM-375
> URL: https://issues.apache.org/jira/browse/MPOM-375
> Project: Maven POMs
> Issue Type: Improvement
> Components: maven
>Affects Versions: MAVEN-38
>Reporter: Konrad Windszus
>Priority: Major
>
> Currently license headers are only added to some java files. One should
> leverage option
> https://github.com/diffplug/spotless/tree/main/plugin-maven#license-header to
> add/modify it in all files (also to always properly reflect the year of the
> last modification).
> Also e.g. Java files within {{src/test/resources}} are currently not
> considered with regards to license file.
> This is currently blocked though by
> https://github.com/diffplug/spotless/issues/1418.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MPOM-452) Apache Parent POM - Use property for Apache Repository IDs
[ https://issues.apache.org/jira/browse/MPOM-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MPOM-452: -- Fix Version/s: ASF-32 > Apache Parent POM - Use property for Apache Repository IDs > -- > > Key: MPOM-452 > URL: https://issues.apache.org/jira/browse/MPOM-452 > Project: Maven POMs > Issue Type: Improvement >Affects Versions: ASF-31 >Reporter: Lenny Primak >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: ASF-32 > > > Add ability to override Apache Release and Snapshot repository IDs via > properties > Useful to deploy to different instances of repositories -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MPOM-452) Apache Parent POM - Use property for Apache Repository IDs
[ https://issues.apache.org/jira/browse/MPOM-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MPOM-452: - Assignee: Sylwester Lachiewicz > Apache Parent POM - Use property for Apache Repository IDs > -- > > Key: MPOM-452 > URL: https://issues.apache.org/jira/browse/MPOM-452 > Project: Maven POMs > Issue Type: Improvement >Affects Versions: ASF-31 >Reporter: Lenny Primak >Assignee: Sylwester Lachiewicz >Priority: Minor > > Add ability to override Apache Release and Snapshot repository IDs via > properties > Useful to deploy to different instances of repositories -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPOM-452) Apache Parent POM - Use property for Apache Repository IDs
[ https://issues.apache.org/jira/browse/MPOM-452?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MPOM-452. - Resolution: Fixed > Apache Parent POM - Use property for Apache Repository IDs > -- > > Key: MPOM-452 > URL: https://issues.apache.org/jira/browse/MPOM-452 > Project: Maven POMs > Issue Type: Improvement >Affects Versions: ASF-31 >Reporter: Lenny Primak >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: ASF-32 > > > Add ability to override Apache Release and Snapshot repository IDs via > properties > Useful to deploy to different instances of repositories -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPOM-452] Use properties for snapshot and release repository IDs as well [maven-apache-parent]
slachiewicz merged PR #184: URL: https://github.com/apache/maven-apache-parent/pull/184 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MPOM-449) Remove the leading "1." from source/target properties
[
https://issues.apache.org/jira/browse/MPOM-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz closed MPOM-449.
-
Resolution: Fixed
> Remove the leading "1." from source/target properties
> -
>
> Key: MPOM-449
> URL: https://issues.apache.org/jira/browse/MPOM-449
> Project: Maven POMs
> Issue Type: Bug
> Components: maven
>Affects Versions: MAVEN-41
>Reporter: Tamas Cservenak
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: MAVEN-42
>
>
> The parent 41 has these lines:
> {noformat}
> 1.${javaVersion}
> 1.${javaVersion} {noformat}
> This makes any Java above 9 defunct (and we do not go below 8, so it works
> for only two versions). If you try to use 11, 17 or oh my god 21, you end up
> with "1.11", "1.17" and "1.21" subsequently. While for javac this is not a
> biggie (it will ignore this if release set, and hopefully is), but
> reporting/site/whatever craps out badly on this.
> Remove the prefix "1.", and let those on 8 use 1.8 instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MPOM-449) Remove the leading "1." from source/target properties
[
https://issues.apache.org/jira/browse/MPOM-449?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz reassigned MPOM-449:
-
Assignee: Sylwester Lachiewicz
> Remove the leading "1." from source/target properties
> -
>
> Key: MPOM-449
> URL: https://issues.apache.org/jira/browse/MPOM-449
> Project: Maven POMs
> Issue Type: Bug
> Components: maven
>Affects Versions: MAVEN-41
>Reporter: Tamas Cservenak
>Assignee: Sylwester Lachiewicz
>Priority: Major
> Fix For: MAVEN-42
>
>
> The parent 41 has these lines:
> {noformat}
> 1.${javaVersion}
> 1.${javaVersion} {noformat}
> This makes any Java above 9 defunct (and we do not go below 8, so it works
> for only two versions). If you try to use 11, 17 or oh my god 21, you end up
> with "1.11", "1.17" and "1.21" subsequently. While for javac this is not a
> biggie (it will ignore this if release set, and hopefully is), but
> reporting/site/whatever craps out badly on this.
> Remove the prefix "1.", and let those on 8 use 1.8 instead.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MPOM-449] Remove the leading "1." from source/target properties [maven-parent]
slachiewicz merged PR #155: URL: https://github.com/apache/maven-parent/pull/155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] docck Maven Plugin was retired so remove reference from docs [maven-site]
slawekjaranowski merged PR #483: URL: https://github.com/apache/maven-site/pull/483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MPOM-455) Add dependencyManagement for JUnit 5
[ https://issues.apache.org/jira/browse/MPOM-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MPOM-455: -- Fix Version/s: MAVEN-42 > Add dependencyManagement for JUnit 5 > > > Key: MPOM-455 > URL: https://issues.apache.org/jira/browse/MPOM-455 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: maven >Reporter: Sylwester Lachiewicz >Priority: Minor > Fix For: MAVEN-42 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MPOM-455) Add dependencyManagement for JUnit 5
[ https://issues.apache.org/jira/browse/MPOM-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz reassigned MPOM-455: - Assignee: Sylwester Lachiewicz > Add dependencyManagement for JUnit 5 > > > Key: MPOM-455 > URL: https://issues.apache.org/jira/browse/MPOM-455 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: maven >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: MAVEN-42 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MPOM-455) Add dependencyManagement for JUnit 5
[ https://issues.apache.org/jira/browse/MPOM-455?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MPOM-455. - Resolution: Fixed > Add dependencyManagement for JUnit 5 > > > Key: MPOM-455 > URL: https://issues.apache.org/jira/browse/MPOM-455 > Project: Maven POMs > Issue Type: Dependency upgrade > Components: maven >Reporter: Sylwester Lachiewicz >Assignee: Sylwester Lachiewicz >Priority: Minor > Fix For: MAVEN-42 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MPOM-455] Add dependencyManagement for JUnit 5 [maven-parent]
slachiewicz merged PR #154: URL: https://github.com/apache/maven-parent/pull/154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MSHARED-1350) Upgrade parent POM to version 41
Sylwester Lachiewicz created MSHARED-1350: - Summary: Upgrade parent POM to version 41 Key: MSHARED-1350 URL: https://issues.apache.org/jira/browse/MSHARED-1350 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-script-interpreter Reporter: Sylwester Lachiewicz Fix For: maven-script-interpreter-1.5 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MASSEMBLY-1008) Assembly plugin handles scopes wrongly
[ https://issues.apache.org/jira/browse/MASSEMBLY-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804899#comment-17804899 ] ASF GitHub Bot commented on MASSEMBLY-1008: --- slawekjaranowski commented on code in PR #166: URL: https://github.com/apache/maven-assembly-plugin/pull/166#discussion_r1446680127 ## pom.xml: ## @@ -108,10 +108,9 @@ under the License. org.eclipse.aether - aether-api + aether-util Assembly plugin handles scopes wrongly > -- > > Key: MASSEMBLY-1008 > URL: https://issues.apache.org/jira/browse/MASSEMBLY-1008 > Project: Maven Assembly Plugin > Issue Type: Bug > Components: dependencySet >Reporter: Tamas Cservenak >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > > This affects all assembly releases. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MASSEMBLY-1008] Fix transitive dependencies resolving with required scope [maven-assembly-plugin]
slawekjaranowski commented on code in PR #166: URL: https://github.com/apache/maven-assembly-plugin/pull/166#discussion_r1446680127 ## pom.xml: ## @@ -108,10 +108,9 @@ under the License. org.eclipse.aether - aether-api + aether-util Review Comment: yes next PR with separate issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Add JDK 21 to standard builds, deploy by JDK 21 [maven-jenkins-lib]
slawekjaranowski commented on PR #10: URL: https://github.com/apache/maven-jenkins-lib/pull/10#issuecomment-1883882369 Similar as in GH Actions https://github.com/apache/maven-gh-actions-shared/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7999) Review components with unused members
[ https://issues.apache.org/jira/browse/MNG-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-7999: - Fix Version/s: 4.0.0 4.0.0-alpha-11 (was: 4.0.x-candidate) > Review components with unused members > - > > Key: MNG-7999 > URL: https://issues.apache.org/jira/browse/MNG-7999 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > > I found at least two components: > * org/apache/maven/lifecycle/DefaultLifecycleExecutor > * org/apache/maven/lifecycle/internal/LifecycleStarter > but I bet there are more... > Given clients should _inject_ and not manually instantiate components, ctor > changes should be hidden from them (managed by DI). Hence, changes like these > are "safe" as long as client code "plays by the rules". -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Use Maven 3.6.3, 3.9.6 in matrix build by default [maven-gh-actions-shared]
cstamas commented on code in PR #93: URL: https://github.com/apache/maven-gh-actions-shared/pull/93#discussion_r1446647366 ## .github/workflows/maven-verify-test.yml: ## @@ -35,4 +35,4 @@ jobs: ff-jdk: '21' verify-goal: clean install verify-fail-fast: false - maven-matrix: '[ "3.9.6", "3.2.5", "3.8.8" ]' + maven-matrix: '[ "3.9.6", "3.8.8", "3.6,3" ]' Review Comment: comma vs dot? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Use Maven 3.6.3, 3.9.6 in matrix build by default [maven-gh-actions-shared]
slawekjaranowski opened a new pull request, #93: URL: https://github.com/apache/maven-gh-actions-shared/pull/93 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.3 [maven-doxia-converter]
dependabot[bot] commented on PR #60: URL: https://github.com/apache/maven-doxia-converter/pull/60#issuecomment-1883837536 Looks like org.codehaus.plexus:plexus-xml is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.3 [maven-doxia-converter]
dependabot[bot] closed pull request #60: Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 4.0.3 URL: https://github.com/apache/maven-doxia-converter/pull/60 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] docck Maven Plugin was retired so remove reference from docs [maven-site]
slawekjaranowski commented on PR #483: URL: https://github.com/apache/maven-site/pull/483#issuecomment-1883834018 https://issues.apache.org/jira/browse/MDOCCK-39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Restrict permissions to GITHUB_TOKEN [maven-gh-actions-shared]
slawekjaranowski opened a new pull request, #92: URL: https://github.com/apache/maven-gh-actions-shared/pull/92 https://docs.github.com/en/actions/using-jobs/assigning-permissions-to-jobs https://github.com/release-drafter/release-drafter -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] docck Maven Plugin was retired so remove reference from docs [maven-site]
gnodet commented on PR #483: URL: https://github.com/apache/maven-site/pull/483#issuecomment-1883799098 It would be nice to indicate the reason why the plugin was retired. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNG-7998) Internal cleanup re Tasks (goal vs lifecycle)
[ https://issues.apache.org/jira/browse/MNG-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-7998. Resolution: Fixed > Internal cleanup re Tasks (goal vs lifecycle) > - > > Key: MNG-7998 > URL: https://issues.apache.org/jira/browse/MNG-7998 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > > Just a small cleanup regarding "tasks". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7998) Internal cleanup re Tasks (goal vs lifecycle)
[ https://issues.apache.org/jira/browse/MNG-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804882#comment-17804882 ] ASF GitHub Bot commented on MNG-7998: - cstamas merged PR #1366: URL: https://github.com/apache/maven/pull/1366 > Internal cleanup re Tasks (goal vs lifecycle) > - > > Key: MNG-7998 > URL: https://issues.apache.org/jira/browse/MNG-7998 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > > Just a small cleanup regarding "tasks". -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-7998] Minor cleanup regarding "tasks" [maven]
cstamas merged PR #1366: URL: https://github.com/apache/maven/pull/1366 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MNGSITE-530) Link to Maven 4.1.0 XSD is broken / shows "404 Page not found"
[
https://issues.apache.org/jira/browse/MNGSITE-530?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNGSITE-530.
---
Resolution: Fixed
> Link to Maven 4.1.0 XSD is broken / shows "404 Page not found"
> --
>
> Key: MNGSITE-530
> URL: https://issues.apache.org/jira/browse/MNGSITE-530
> Project: Maven Project Web Site
> Issue Type: Bug
> Environment: Chrome
>Reporter: Matthias Bünger
>Assignee: Guillaume Nodet
>Priority: Major
>
> The link on the maven-model page to the Maven 4.1.0-XSD is broken/dead.
> The [alpha-10 maven-model
> page|https://maven.apache.org/ref/4.0.0-alpha-10/maven-model/maven.html]
> lists links to all current XSD, including the one for the 4.1.0 version of
> Maven 4:
> But the linked file: {{https://maven.apache.org/xsd/maven-4.1.0.xsd}} is not
> existing and throws a "404 Page not found" (as of 2023-12-26), while all
> others are working.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Comment Edited] (MBUILDCACHE-73) Add project version as additional property for reconcilation
[
https://issues.apache.org/jira/browse/MBUILDCACHE-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804848#comment-17804848
]
Xaver edited comment on MBUILDCACHE-73 at 1/9/24 8:30 PM:
--
Hi there,
V1.0.1 works awesome (we use it in a large multi module project and reduced
computation costs of CI/CD by ~80%)! Thanks a lot for it.
I think that the merge of
[PR#117|https://github.com/apache/maven-build-cache-extension/pull/117] /
MBUILDCACHE-76 was a mistake.
Please look at the [description of the
extension|https://maven.apache.org/extensions/maven-build-cache-extension/]:
{panel:title=A combination of features achieves that:}
Version normalization supports project *version agnostic caches*
{panel}
Have a look at the code:
https://github.com/apache/maven-build-cache-extension/blob/maven-build-cache-extension-1.1.0/src/main/java/org/apache/maven/buildcache/DefaultNormalizedModelProvider.java#L81-L82
The version is explicitly removed to achieve the version agnostic cache
{code:java}
// does not make sense to add project version to calculate hash
resultModel.setVersion(NORMALIZED_VERSION);
{code}
Other modern build tools I know (e.g. gradle, nx.dev) use version agnostic
caches. I really missed this feature a lot.
Please don't close this issue. It's important for many use cases that the
version is optional for checksum calculation.
Thank you from a happy 1.0.1 user.
was (Author: JIRAUSER303756):
Hi there,
V1.0.1 works awesome (we use it in a large multi module project and reduced
computation costs of CI/CD by ~80%)! Thanks a lot for it.
I think that the merge of
[PR#117|https://github.com/apache/maven-build-cache-extension/pull/117] /
MBUILDCACHE-76 was a mistake.
Please look at the [description of the
extension|https://maven.apache.org/extensions/maven-build-cache-extension/]:
{panel:title=A combination of features achieves that:}
Version normalization supports project *version agnostic caches*
{panel}
Other modern build tools I know (e.g. gradle, nx.dev) use version agnostic
caches. I really missed this feature a lot.
Please don't close this issue. It's important for many use cases that the
version is optional for checksum calculation.
Thank you from a happy 1.0.1 user.
> Add project version as additional property for reconcilation
>
>
> Key: MBUILDCACHE-73
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-73
> Project: Maven Build Cache Extension
> Issue Type: New Feature
>Affects Versions: 1.0.1
>Reporter: Patrik Dudits
>Priority: Major
>
> Certain plugins or goals might require to run when project version changes
> regardless of other inputs. A typical example would be {{deploy:deploy}} or
> in my specific case {{docker:build}} - It is OK to reuse the build artifact,
> but if version changed, I do want to upload it.
> Currently only way to achieve that is to put the goal into {{runAlways}}
> section. But that results in needles snapshots to be deployed or docker
> images being built even if there's no relevant change.
> The reconcile section allows to specify properties for futher fine tuning the
> input. These are limited to goal parameters, and neither of my examples
> contain project version as a parameter, both use project model to fetch it.
> Proposal would be to extend tag {{reconcile}} either with:
> * special magic name {{project.version}} to include version tracking, so
> this could be achieved by {{}}
> * attribute {{{}expression{}}}, to achieve the result with {{ propertyName="version" expression="${project.version}"/>}}
> * interpolating {{defaultValue}} attribute
> The second form would be preferrable as it has much larger scale of
> application, I can imagine putting base docker image digests in environment
> variable to invalidate builds when base tag gets updated. It is also more
> discoverable than third option.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNGSITE-530) Link to Maven 4.1.0 XSD is broken / shows "404 Page not found"
[
https://issues.apache.org/jira/browse/MNGSITE-530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804874#comment-17804874
]
ASF GitHub Bot commented on MNGSITE-530:
gnodet merged PR #480:
URL: https://github.com/apache/maven-site/pull/480
> Link to Maven 4.1.0 XSD is broken / shows "404 Page not found"
> --
>
> Key: MNGSITE-530
> URL: https://issues.apache.org/jira/browse/MNGSITE-530
> Project: Maven Project Web Site
> Issue Type: Bug
> Environment: Chrome
>Reporter: Matthias Bünger
>Assignee: Guillaume Nodet
>Priority: Major
>
> The link on the maven-model page to the Maven 4.1.0-XSD is broken/dead.
> The [alpha-10 maven-model
> page|https://maven.apache.org/ref/4.0.0-alpha-10/maven-model/maven.html]
> lists links to all current XSD, including the one for the 4.1.0 version of
> Maven 4:
> But the linked file: {{https://maven.apache.org/xsd/maven-4.1.0.xsd}} is not
> existing and throws a "404 Page not found" (as of 2023-12-26), while all
> others are working.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNGSITE-530] Link to Maven 4.1.0 XSD is broken / shows "404 Page not found" [maven-site]
gnodet merged PR #480: URL: https://github.com/apache/maven-site/pull/480 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-5862) POM XML parser needs XInclude and/or XML Entity support
[
https://issues.apache.org/jira/browse/MNG-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804862#comment-17804862
]
ASF GitHub Bot commented on MNG-5862:
-
gnodet commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1446522303
##
maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java:
##
@@ -100,14 +104,39 @@ private Path getRootDirectory(Map options) {
return (Path) value;
}
+private boolean getXInclude(Map options) {
+Object value = (options != null) ? options.get(XINCLUDE) : null;
+return value instanceof Boolean && (Boolean) value;
+}
+
private Model read(InputStream input, Path pomFile, Map
options) throws IOException {
try {
-XMLInputFactory factory = new com.ctc.wstx.stax.WstxInputFactory();
-
factory.setProperty(XMLInputFactory.IS_REPLACING_ENTITY_REFERENCES, false);
-XMLStreamReader parser = factory.createXMLStreamReader(input);
-
InputSource source = getSource(options);
boolean strict = isStrict(options);
+Path rootDirectory = getRootDirectory(options);
+
+Source xmlSource;
+if (pomFile != null) {
+if (input != null) {
+xmlSource = new StaxPathInputSource(pomFile, input);
+} else {
+xmlSource = new Stax2FileSource(pomFile.toFile());
+}
+} else {
+xmlSource = new StreamSource(input);
+}
+
+XMLStreamReader parser;
+// We only support xml entities and xinclude when reading a file
in strict mode
+if (pomFile != null && strict && getXInclude(options)) {
+parser = XInclude.xinclude(xmlSource, new
LocalXmlResolver(rootDirectory));
+} else {
+XMLInputFactory factory = new
com.ctc.wstx.stax.WstxInputFactory();
+
factory.setProperty(XMLInputFactory.IS_REPLACING_ENTITY_REFERENCES, false);
+
factory.setProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, false);
Review Comment:
> Nothing you can do here, but this property should have been named
SUPPORTS_EXTERNAL_ENTITIES
Agreed
> POM XML parser needs XInclude and/or XML Entity support
> ---
>
> Key: MNG-5862
> URL: https://issues.apache.org/jira/browse/MNG-5862
> Project: Maven
> Issue Type: New Feature
> Components: POM
>Reporter: Jason Vas Dias
>Assignee: Guillaume Nodet
>Priority: Major
>
> POM XML files can get very large and repetitive , and not all modularizaton
> scenarios can be resolved by using a Super POM as described in MNG-1980 ,
> and would be easily resolved if only the POM parser supported XIncludes or
> XML Entities - neither are supported.
> Here is one such scenario:
> I have a large project that has several SureFire plugin based "Test Suites" -
> each test suite uses a "common-at-classes" module of common test classes,
> and is essentially identical except in its XML configuration "test resource"
> files
> - so the structure is like this :
> {quote}
> {noformat}
> Top Level project directory:
>./pom.xml
>./acceptance-tests/pom.xml
>./acceptance-tests/common-at-classes/pom.xml
>./acceptance-tests/test-suite_#1/pom.xml
>...
>./acceptance-tests/test-suite_#N/pom.xml
> {noformat}
> {quote}
> There are @ 10 ( being upgraded to @ 20) "test suites",
> which all do exactly the same thing, but with slightly
> different "test resource" configuration files,
> and depend on the 'acceptance-tests/common-at-classes" JAR .
> We can modularize all the test-suite dependencies OK in the single
> common-at-classes/pom.xml location .
> But their is no way to modularize the actual XML code that runs each
> test-suite with plugin executions - these plugin execution stanzas can
> currently ONLY
> be in each test-suite#N directory, even though they are identical.
> It would make no sense to have the "Super POM" : acceptance-tests/pom.xml
> contain the plugin executions to run any single test suite ; nor can the
> common-at-classes/pom.xml contain the plugin execution to run any
> test suite, since a test suite run depends on the customized test resource
> files that only exist in each "test_suite#N/" sub-project .
> So the only solution currently available with Maven is to copy the XML stanzas
> that configure and run the test suite ( about 400 lines of XML ) into each of
> the 10-20 test-suite/pom.xml files ; this is all because Maven does not
> support
> XML XInclude or XML Entities; if it did, we could put all this code into one
> XML
> file provided by the common-at-classes project, and include
Re: [PR] [MNG-5862] Support XML entities and XInclude [maven]
gnodet commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1446522303
##
maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java:
##
@@ -100,14 +104,39 @@ private Path getRootDirectory(Map options) {
return (Path) value;
}
+private boolean getXInclude(Map options) {
+Object value = (options != null) ? options.get(XINCLUDE) : null;
+return value instanceof Boolean && (Boolean) value;
+}
+
private Model read(InputStream input, Path pomFile, Map
options) throws IOException {
try {
-XMLInputFactory factory = new com.ctc.wstx.stax.WstxInputFactory();
-
factory.setProperty(XMLInputFactory.IS_REPLACING_ENTITY_REFERENCES, false);
-XMLStreamReader parser = factory.createXMLStreamReader(input);
-
InputSource source = getSource(options);
boolean strict = isStrict(options);
+Path rootDirectory = getRootDirectory(options);
+
+Source xmlSource;
+if (pomFile != null) {
+if (input != null) {
+xmlSource = new StaxPathInputSource(pomFile, input);
+} else {
+xmlSource = new Stax2FileSource(pomFile.toFile());
+}
+} else {
+xmlSource = new StreamSource(input);
+}
+
+XMLStreamReader parser;
+// We only support xml entities and xinclude when reading a file
in strict mode
+if (pomFile != null && strict && getXInclude(options)) {
+parser = XInclude.xinclude(xmlSource, new
LocalXmlResolver(rootDirectory));
+} else {
+XMLInputFactory factory = new
com.ctc.wstx.stax.WstxInputFactory();
+
factory.setProperty(XMLInputFactory.IS_REPLACING_ENTITY_REFERENCES, false);
+
factory.setProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, false);
Review Comment:
> Nothing you can do here, but this property should have been named
SUPPORTS_EXTERNAL_ENTITIES
Agreed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7999) Review components with unused members
[
https://issues.apache.org/jira/browse/MNG-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804860#comment-17804860
]
ASF GitHub Bot commented on MNG-7999:
-
cstamas commented on code in PR #1367:
URL: https://github.com/apache/maven/pull/1367#discussion_r1446520933
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DependencyContext.java:
##
@@ -48,7 +43,7 @@ public class DependencyContext {
private final Collection scopesToResolveForAggregatedProjects;
-private volatile Collection lastDependencyArtifacts = UNRESOLVED;
+private volatile Collection lastDependencyArtifacts = new ArrayList<>();
Review Comment:
fixed
> Review components with unused members
> -
>
> Key: MNG-7999
> URL: https://issues.apache.org/jira/browse/MNG-7999
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> I found at least two components:
> * org/apache/maven/lifecycle/DefaultLifecycleExecutor
> * org/apache/maven/lifecycle/internal/LifecycleStarter
> but I bet there are more...
> Given clients should _inject_ and not manually instantiate components, ctor
> changes should be hidden from them (managed by DI). Hence, changes like these
> are "safe" as long as client code "plays by the rules".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7999] Cleanup [maven]
cstamas commented on code in PR #1367:
URL: https://github.com/apache/maven/pull/1367#discussion_r1446520933
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DependencyContext.java:
##
@@ -48,7 +43,7 @@ public class DependencyContext {
private final Collection scopesToResolveForAggregatedProjects;
-private volatile Collection lastDependencyArtifacts = UNRESOLVED;
+private volatile Collection lastDependencyArtifacts = new ArrayList<>();
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-5862] Support XML entities and XInclude [maven]
gnodet commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1446520142
##
api/maven-api-core/src/main/java/org/apache/maven/api/feature/Features.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.feature;
+
+import java.util.Map;
+import java.util.Objects;
+import java.util.Properties;
+
+import org.apache.maven.api.Session;
+import org.apache.maven.api.annotations.Nonnull;
+
+/**
+ * Centralized class for feature information
+ *
+ * @since 4.0.0
+ */
+public final class Features {
+
+public static final String BUILDCONSUMER =
"maven.experimental.buildconsumer";
+
+public static final String XINCLUDE = "maven.experimental.xinclude";
+
+public static final String TRUE = "true";
+
+private Features() {}
+
+@Nonnull
+public static boolean buildConsumer(@Nonnull Properties userProperties) {
+return
TRUE.equals(Objects.requireNonNull(userProperties).getOrDefault(BUILDCONSUMER,
TRUE));
+}
+
+@Nonnull
+public static boolean buildConsumer(@Nonnull Map
userProperties) {
+return
TRUE.equals(Objects.requireNonNull(userProperties).getOrDefault(BUILDCONSUMER,
TRUE));
Review Comment:
`userProperties` is now `Nullable`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-5862) POM XML parser needs XInclude and/or XML Entity support
[
https://issues.apache.org/jira/browse/MNG-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804858#comment-17804858
]
ASF GitHub Bot commented on MNG-5862:
-
gnodet commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1446520142
##
api/maven-api-core/src/main/java/org/apache/maven/api/feature/Features.java:
##
@@ -0,0 +1,72 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.api.feature;
+
+import java.util.Map;
+import java.util.Objects;
+import java.util.Properties;
+
+import org.apache.maven.api.Session;
+import org.apache.maven.api.annotations.Nonnull;
+
+/**
+ * Centralized class for feature information
+ *
+ * @since 4.0.0
+ */
+public final class Features {
+
+public static final String BUILDCONSUMER =
"maven.experimental.buildconsumer";
+
+public static final String XINCLUDE = "maven.experimental.xinclude";
+
+public static final String TRUE = "true";
+
+private Features() {}
+
+@Nonnull
+public static boolean buildConsumer(@Nonnull Properties userProperties) {
+return
TRUE.equals(Objects.requireNonNull(userProperties).getOrDefault(BUILDCONSUMER,
TRUE));
+}
+
+@Nonnull
+public static boolean buildConsumer(@Nonnull Map
userProperties) {
+return
TRUE.equals(Objects.requireNonNull(userProperties).getOrDefault(BUILDCONSUMER,
TRUE));
Review Comment:
`userProperties` is now `Nullable`
> POM XML parser needs XInclude and/or XML Entity support
> ---
>
> Key: MNG-5862
> URL: https://issues.apache.org/jira/browse/MNG-5862
> Project: Maven
> Issue Type: New Feature
> Components: POM
>Reporter: Jason Vas Dias
>Assignee: Guillaume Nodet
>Priority: Major
>
> POM XML files can get very large and repetitive , and not all modularizaton
> scenarios can be resolved by using a Super POM as described in MNG-1980 ,
> and would be easily resolved if only the POM parser supported XIncludes or
> XML Entities - neither are supported.
> Here is one such scenario:
> I have a large project that has several SureFire plugin based "Test Suites" -
> each test suite uses a "common-at-classes" module of common test classes,
> and is essentially identical except in its XML configuration "test resource"
> files
> - so the structure is like this :
> {quote}
> {noformat}
> Top Level project directory:
>./pom.xml
>./acceptance-tests/pom.xml
>./acceptance-tests/common-at-classes/pom.xml
>./acceptance-tests/test-suite_#1/pom.xml
>...
>./acceptance-tests/test-suite_#N/pom.xml
> {noformat}
> {quote}
> There are @ 10 ( being upgraded to @ 20) "test suites",
> which all do exactly the same thing, but with slightly
> different "test resource" configuration files,
> and depend on the 'acceptance-tests/common-at-classes" JAR .
> We can modularize all the test-suite dependencies OK in the single
> common-at-classes/pom.xml location .
> But their is no way to modularize the actual XML code that runs each
> test-suite with plugin executions - these plugin execution stanzas can
> currently ONLY
> be in each test-suite#N directory, even though they are identical.
> It would make no sense to have the "Super POM" : acceptance-tests/pom.xml
> contain the plugin executions to run any single test suite ; nor can the
> common-at-classes/pom.xml contain the plugin execution to run any
> test suite, since a test suite run depends on the customized test resource
> files that only exist in each "test_suite#N/" sub-project .
> So the only solution currently available with Maven is to copy the XML stanzas
> that configure and run the test suite ( about 400 lines of XML ) into each of
> the 10-20 test-suite/pom.xml files ; this is all because Maven does not
> support
> XML XInclude or XML Entities; if it did, we could put all this code into one
> XML
> file provided by the common-at-classes project, and include it in each test
> suite .
> The test suite XML is then a nightmare to
Re: [PR] Remove experimental bit from buildconsumer [maven-integration-testing]
gnodet merged PR #331: URL: https://github.com/apache/maven-integration-testing/pull/331 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-7999) Review components with unused members
[
https://issues.apache.org/jira/browse/MNG-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804857#comment-17804857
]
ASF GitHub Bot commented on MNG-7999:
-
gnodet commented on code in PR #1367:
URL: https://github.com/apache/maven/pull/1367#discussion_r1446515465
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DependencyContext.java:
##
@@ -48,7 +43,7 @@ public class DependencyContext {
private final Collection scopesToResolveForAggregatedProjects;
-private volatile Collection lastDependencyArtifacts = UNRESOLVED;
+private volatile Collection lastDependencyArtifacts = new ArrayList<>();
Review Comment:
`Collections.emptyList()`, as this collection is never written to.
> Review components with unused members
> -
>
> Key: MNG-7999
> URL: https://issues.apache.org/jira/browse/MNG-7999
> Project: Maven
> Issue Type: Task
> Components: Core
>Reporter: Tamas Cservenak
>Priority: Major
> Fix For: 4.0.x-candidate
>
>
> I found at least two components:
> * org/apache/maven/lifecycle/DefaultLifecycleExecutor
> * org/apache/maven/lifecycle/internal/LifecycleStarter
> but I bet there are more...
> Given clients should _inject_ and not manually instantiate components, ctor
> changes should be hidden from them (managed by DI). Hence, changes like these
> are "safe" as long as client code "plays by the rules".
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7999] Cleanup [maven]
gnodet commented on code in PR #1367:
URL: https://github.com/apache/maven/pull/1367#discussion_r1446515465
##
maven-core/src/main/java/org/apache/maven/lifecycle/internal/DependencyContext.java:
##
@@ -48,7 +43,7 @@ public class DependencyContext {
private final Collection scopesToResolveForAggregatedProjects;
-private volatile Collection lastDependencyArtifacts = UNRESOLVED;
+private volatile Collection lastDependencyArtifacts = new ArrayList<>();
Review Comment:
`Collections.emptyList()`, as this collection is never written to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-7999) Review components with unused members
[ https://issues.apache.org/jira/browse/MNG-7999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804851#comment-17804851 ] ASF GitHub Bot commented on MNG-7999: - cstamas opened a new pull request, #1367: URL: https://github.com/apache/maven/pull/1367 This is an ongoing effort to perform a bit of cleanup in Maven Core and around. No logic changes, just removing unused members, redundant checks, etc. --- https://issues.apache.org/jira/browse/MNG-7999 > Review components with unused members > - > > Key: MNG-7999 > URL: https://issues.apache.org/jira/browse/MNG-7999 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.x-candidate > > > I found at least two components: > * org/apache/maven/lifecycle/DefaultLifecycleExecutor > * org/apache/maven/lifecycle/internal/LifecycleStarter > but I bet there are more... > Given clients should _inject_ and not manually instantiate components, ctor > changes should be hidden from them (managed by DI). Hence, changes like these > are "safe" as long as client code "plays by the rules". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MNG-7999] Cleanup [maven]
cstamas opened a new pull request, #1367: URL: https://github.com/apache/maven/pull/1367 This is an ongoing effort to perform a bit of cleanup in Maven Core and around. No logic changes, just removing unused members, redundant checks, etc. --- https://issues.apache.org/jira/browse/MNG-7999 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MBUILDCACHE-73) Add project version as additional property for reconcilation
[
https://issues.apache.org/jira/browse/MBUILDCACHE-73?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804848#comment-17804848
]
Xaver commented on MBUILDCACHE-73:
--
Hi there,
V1.0.1 works awesome (we use it in a large multi module project and reduced
computation costs of CI/CD by ~80%)! Thanks a lot for it.
I think that the merge of
[PR#117|https://github.com/apache/maven-build-cache-extension/pull/117] /
MBUILDCACHE-76 was a mistake.
Please look at the [description of the
extension|https://maven.apache.org/extensions/maven-build-cache-extension/]:
{panel:title=A combination of features achieves that:}
Version normalization supports project *version agnostic caches*
{panel}
Other modern build tools I know (e.g. gradle, nx.dev) use version agnostic
caches. I really missed this feature a lot.
Please don't close this issue. It's important for many use cases that the
version is optional for checksum calculation.
Thank you from a happy 1.0.1 user.
> Add project version as additional property for reconcilation
>
>
> Key: MBUILDCACHE-73
> URL: https://issues.apache.org/jira/browse/MBUILDCACHE-73
> Project: Maven Build Cache Extension
> Issue Type: New Feature
>Affects Versions: 1.0.1
>Reporter: Patrik Dudits
>Priority: Major
>
> Certain plugins or goals might require to run when project version changes
> regardless of other inputs. A typical example would be {{deploy:deploy}} or
> in my specific case {{docker:build}} - It is OK to reuse the build artifact,
> but if version changed, I do want to upload it.
> Currently only way to achieve that is to put the goal into {{runAlways}}
> section. But that results in needles snapshots to be deployed or docker
> images being built even if there's no relevant change.
> The reconcile section allows to specify properties for futher fine tuning the
> input. These are limited to goal parameters, and neither of my examples
> contain project version as a parameter, both use project model to fetch it.
> Proposal would be to extend tag {{reconcile}} either with:
> * special magic name {{project.version}} to include version tracking, so
> this could be achieved by {{}}
> * attribute {{{}expression{}}}, to achieve the result with {{ propertyName="version" expression="${project.version}"/>}}
> * interpolating {{defaultValue}} attribute
> The second form would be preferrable as it has much larger scale of
> application, I can imagine putting base docker image digests in environment
> variable to invalidate builds when base tag gets updated. It is also more
> discoverable than third option.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-7999) Review components with unused members
Tamas Cservenak created MNG-7999: Summary: Review components with unused members Key: MNG-7999 URL: https://issues.apache.org/jira/browse/MNG-7999 Project: Maven Issue Type: Task Components: Core Reporter: Tamas Cservenak Fix For: 4.0.x-candidate I found at least two components: * org/apache/maven/lifecycle/DefaultLifecycleExecutor * org/apache/maven/lifecycle/internal/LifecycleStarter but I bet there are more... Given clients should _inject_ and not manually instantiate components, ctor changes should be hidden from them (managed by DI). Hence, changes like these are "safe" as long as client code "plays by the rules". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Assigned] (MNG-7998) Internal cleanup re Tasks (goal vs lifecycle)
[ https://issues.apache.org/jira/browse/MNG-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-7998: Assignee: Tamas Cservenak > Internal cleanup re Tasks (goal vs lifecycle) > - > > Key: MNG-7998 > URL: https://issues.apache.org/jira/browse/MNG-7998 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > > Just a small cleanup regarding "tasks". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7976) Investigate MNG-6127 IT instability
[ https://issues.apache.org/jira/browse/MNG-7976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804831#comment-17804831 ] Tamas Cservenak commented on MNG-7976: -- Tried locally (on Linux and MacOS) to reproduce failure, to no avail. [~crazyhzm] thanks for debug logs! Still, the verbose logs helps only locally, as CI does not offer them for download, so even if it fails somewhere in future, we cannot get those... > Investigate MNG-6127 IT instability > --- > > Key: MNG-7976 > URL: https://issues.apache.org/jira/browse/MNG-7976 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > > The MNG-6127 IT quite often fails, and passes when CI job rebuilt, seems > unstable. > Look into it why (lurking concurrency bug somewhere? or just the IT is > flakey?) and fix it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-391) annotationProcessorPaths have to follow dependencyManagement rules
[ https://issues.apache.org/jira/browse/MCOMPILER-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804814#comment-17804814 ] Falko Modler commented on MCOMPILER-391: Heads-up: m2e in Eclipse IDE needs an adjustment to be able to cope with such annotationProcessorPaths without version: https://github.com/eclipse-m2e/m2e-core/issues/1644 > annotationProcessorPaths have to follow dependencyManagement rules > -- > > Key: MCOMPILER-391 > URL: https://issues.apache.org/jira/browse/MCOMPILER-391 > Project: Maven Compiler Plugin > Issue Type: Bug >Affects Versions: 3.8.0 >Reporter: Stanislav Spiridonov >Assignee: Slawomir Jaranowski >Priority: Blocker > Fix For: 3.12.0 > > Attachments: MCOMPILER-391.zip > > > # Use the version from dependency management > # Respect the exclude (blocker for me) -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-7998) Internal cleanup re Tasks (goal vs lifecycle)
[ https://issues.apache.org/jira/browse/MNG-7998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804803#comment-17804803 ] ASF GitHub Bot commented on MNG-7998: - cstamas opened a new pull request, #1366: URL: https://github.com/apache/maven/pull/1366 Just a minor cleanup regarding internals of "tasks". --- https://issues.apache.org/jira/browse/MNG-7998 > Internal cleanup re Tasks (goal vs lifecycle) > - > > Key: MNG-7998 > URL: https://issues.apache.org/jira/browse/MNG-7998 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-11 > > > Just a small cleanup regarding "tasks". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[PR] [MNG-7998] Minor cleanup regarding "tasks" [maven]
cstamas opened a new pull request, #1366: URL: https://github.com/apache/maven/pull/1366 Just a minor cleanup regarding internals of "tasks". --- https://issues.apache.org/jira/browse/MNG-7998 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7998) Internal cleanup re Tasks (goal vs lifecycle)
Tamas Cservenak created MNG-7998: Summary: Internal cleanup re Tasks (goal vs lifecycle) Key: MNG-7998 URL: https://issues.apache.org/jira/browse/MNG-7998 Project: Maven Issue Type: Task Components: Core Reporter: Tamas Cservenak Fix For: 4.0.0, 4.0.0-alpha-11 Just a small cleanup regarding "tasks". -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804795#comment-17804795 ] Romain Manni-Bucau commented on MSOURCES-143: - [~rvesse] yes, if you check the output you see that attach-sources is done twice, one being explicit in the project pom, dropping it solves it and still enable to complete the release "as expected". (side note: for the setup using a local repo is easier than your github where we don't have perms - for good - so switched to scm:git:file:///tmp/repo to test). I think it is cause of default binding of source plugin and you don't override it but append your execution. Agree a help mojo could simplify the visualisation of the flows/pipelines too. > Can't create a source and test jar in Commons using commons-parent > -- > > Key: MSOURCES-143 > URL: https://issues.apache.org/jira/browse/MSOURCES-143 > Project: Maven Source Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Gary D. Gregory >Priority: Major > > Steps to reproduce: > # git clone https://gitbox.apache.org/repos/asf/commons-parent.git > # cd commons-parent > # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473 > # mvn clean install > # cd .. > # git clone https://gitbox.apache.org/repos/asf/commons-cli.git > # cd commons-cli > # git checkout 08f8c5034a8492be6db65b2086341c292489ee53 > # mvn clean package > [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli --- > [ERROR] We have duplicated artifacts attached. > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 15.233 s > [INFO] Finished at: 2023-08-15T15:39:45-04:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork > (create-source-jar) on project commons-cli: Presumably you have configured > maven-source-plugn to execute twice times in your build. You have to > configure a classifier for at least on of them. -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[
https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804780#comment-17804780
]
Rob Vesse commented on MSOURCES-143:
[~romain.manni-bucau] From my further investigations I'm still unclear that it
is a problem in my project setup.
As far as I was aware I was using a perfectly straightforward configuration for
the {{maven-source-plugin}} that didn't include duplicate plugin invocations.
The bug was provoked by interaction with another plugin in specific
circumstances (activating the implicit release profile during a {{mvn
release:perform}}) that introduced a duplicate invocation unexpectedly.
It may be that I've done things in a non-ideal way, in which case the "fix" for
the issue is for the plugin developers to provide better documentation around
Best Practises for the plugin, document potential gotchas like the release
plugin interaction I've found today etc.
> Can't create a source and test jar in Commons using commons-parent
> --
>
> Key: MSOURCES-143
> URL: https://issues.apache.org/jira/browse/MSOURCES-143
> Project: Maven Source Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Gary D. Gregory
>Priority: Major
>
> Steps to reproduce:
> # git clone https://gitbox.apache.org/repos/asf/commons-parent.git
> # cd commons-parent
> # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473
> # mvn clean install
> # cd ..
> # git clone https://gitbox.apache.org/repos/asf/commons-cli.git
> # cd commons-cli
> # git checkout 08f8c5034a8492be6db65b2086341c292489ee53
> # mvn clean package
> [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli ---
> [ERROR] We have duplicated artifacts attached.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 15.233 s
> [INFO] Finished at: 2023-08-15T15:39:45-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork
> (create-source-jar) on project commons-cli: Presumably you have configured
> maven-source-plugn to execute twice times in your build. You have to
> configure a classifier for at least on of them. -> [Help 1]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[
https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804777#comment-17804777
]
Rob Vesse commented on MSOURCES-143:
Put together a minimal reproducer and did some analysis at
https://github.com/rvesse/source-plugin-breaks-releases
For my particular case it's the interaction between this new duplicate
invocation check and the implicit release profile that the
{{maven-release-plugin}} activates by default (at least for their 2.x
versions). You can get Maven to show you the pom with the excess invocation by
activating the implicit release profile via the {{performRelease}} property as
the release plugin does i.e. {{mvn help:effective-pom -DperformRelease=true}}
I was using the {{jar}} goal of the {{maven-source-plugin}} in my own
{{pom.xml}} and the implicit release profile adds an additional {{jar-no-fork}}
goal hence failing the duplicate invocation check.
One workaround I found was to disable usage of the implicit release profile,
this can most easily done by upgrading to a 3.x release of the
{{maven-release-plugin}} as they now disable usage of that by default. Or if
you need to continue using a 2.x version of the release plugin you can add
{{false}} to the plugin configuration.
> Can't create a source and test jar in Commons using commons-parent
> --
>
> Key: MSOURCES-143
> URL: https://issues.apache.org/jira/browse/MSOURCES-143
> Project: Maven Source Plugin
> Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Gary D. Gregory
>Priority: Major
>
> Steps to reproduce:
> # git clone https://gitbox.apache.org/repos/asf/commons-parent.git
> # cd commons-parent
> # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473
> # mvn clean install
> # cd ..
> # git clone https://gitbox.apache.org/repos/asf/commons-cli.git
> # cd commons-cli
> # git checkout 08f8c5034a8492be6db65b2086341c292489ee53
> # mvn clean package
> [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli ---
> [ERROR] We have duplicated artifacts attached.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 15.233 s
> [INFO] Finished at: 2023-08-15T15:39:45-04:00
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork
> (create-source-jar) on project commons-cli: Presumably you have configured
> maven-source-plugn to execute twice times in your build. You have to
> configure a classifier for at least on of them. -> [Help 1]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus updated MSITE-1000:
---
Component/s: doxia integration
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
> Components: doxia integration
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Assigned] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus reassigned MSITE-1000:
--
Assignee: Konrad Windszus
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (MNG-7997) Alias not working when invoking mojo directly
Christoph Läubrich created MNG-7997:
---
Summary: Alias not working when invoking mojo directly
Key: MNG-7997
URL: https://issues.apache.org/jira/browse/MNG-7997
Project: Maven
Issue Type: New Feature
Reporter: Christoph Läubrich
See the following mojo description:
https://tycho.eclipseprojects.io/doc/latest/tycho-versions-plugin/set-version-mojo.html
it says it has a required user property 'newVersion' with an alias of
'developmentVersion'
but running
mvn org.eclipse.tycho:tycho-versions-plugin:4.0.4:set-version
-DdevelopmentVersion=5.6.0-SNAPSHOT
gives
{code:java}
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.eclipse.tycho:tycho-versions-plugin:4.0.4:set-version (default-cli) on
project top: The parameters 'newVersion' for goal
org.eclipse.tycho:tycho-versions-plugin:4.0.4:set-version are missing or invalid
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:333)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:174)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
(MojoExecutor.java:75)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
(MojoExecutor.java:162)
at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
(DefaultMojosExecutionStrategy.java:39)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:159)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:105)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:73)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:53)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
(LifecycleStarter.java:118)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
(NativeMethodAccessorImpl.java:77)
at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke (Method.java:568)
at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
(Launcher.java:283)
at org.codehaus.plexus.classworlds.launcher.Launcher.launch
(Launcher.java:226)
at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
(Launcher.java:407)
at org.codehaus.plexus.classworlds.launcher.Launcher.main
(Launcher.java:348)
Caused by: org.apache.maven.plugin.PluginParameterException: The parameters
'newVersion' for goal org.eclipse.tycho:tycho-versions-plugin:4.0.4:set-version
are missing or invalid
at
org.apache.maven.plugin.internal.DefaultMavenPluginManager.populateMojoExecutionFields
(DefaultMavenPluginManager.java:624)
at
org.apache.maven.plugin.internal.DefaultMavenPluginManager.getConfiguredMojo
(DefaultMavenPluginManager.java:573)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:114)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2
(MojoExecutor.java:328)
at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
(MojoExecutor.java:316)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:212)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:174)
at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
(MojoExecutor.java:75)
at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
(MojoExecutor.java:162)
at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
(DefaultMojosExecutionStrategy.java:39)
at org.apache.maven.lifecycle.internal.MojoExecutor.execute
(MojoExecutor.java:159)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:105)
at org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
(LifecycleModuleBuilder.java:73)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
(SingleThreadedBuilder.java:53)
at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804739#comment-17804739 ] Gary D. Gregory commented on MSOURCES-143: -- Hi [~romain.manni-bucau] I gave up on debugging this (as noted above) and set the plug in version to 3.2.1. I suppose one day we'll be forced to upgrade or someone will figure it out. > Can't create a source and test jar in Commons using commons-parent > -- > > Key: MSOURCES-143 > URL: https://issues.apache.org/jira/browse/MSOURCES-143 > Project: Maven Source Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Gary D. Gregory >Priority: Major > > Steps to reproduce: > # git clone https://gitbox.apache.org/repos/asf/commons-parent.git > # cd commons-parent > # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473 > # mvn clean install > # cd .. > # git clone https://gitbox.apache.org/repos/asf/commons-cli.git > # cd commons-cli > # git checkout 08f8c5034a8492be6db65b2086341c292489ee53 > # mvn clean package > [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli --- > [ERROR] We have duplicated artifacts attached. > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 15.233 s > [INFO] Finished at: 2023-08-15T15:39:45-04:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork > (create-source-jar) on project commons-cli: Presumably you have configured > maven-source-plugn to execute twice times in your build. You have to > configure a classifier for at least on of them. -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Improve transfer listener speed [maven]
michael-o commented on code in PR #1302:
URL: https://github.com/apache/maven/pull/1302#discussion_r1446105119
##
maven-embedder/src/main/java/org/apache/maven/cli/transfer/ConsoleMavenTransferListener.java:
##
@@ -34,79 +36,159 @@
*/
public class ConsoleMavenTransferListener extends
AbstractMavenTransferListener {
-private Map transfers = new LinkedHashMap<>();
-private FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH); // use
in a synchronized fashion
-private StringBuilder buffer = new StringBuilder(128); // use in a
synchronized fashion
+public static final int MIN_DELAY_BETWEEN_UPDATES = 50;
+private final Map transfers =
+new
ConcurrentSkipListMap<>(Comparator.comparing(TransferResource::getResourceName));
+private final FileSizeFormat format = new FileSizeFormat(Locale.ENGLISH);
+private final ThreadLocal buffers =
ThreadLocal.withInitial(() -> new StringBuilder(128));
-private boolean printResourceNames;
+private final boolean printResourceNames;
private int lastLength;
+private final Object lock = new Object();
+private final Thread updater;
public ConsoleMavenTransferListener(PrintStream out, boolean
printResourceNames) {
super(out);
this.printResourceNames = printResourceNames;
+updater = new Thread(this::update);
+updater.setDaemon(true);
+updater.start();
}
@Override
-public synchronized void transferInitiated(TransferEvent event) {
-overridePreviousTransfer(event);
-
-super.transferInitiated(event);
+public void transferInitiated(TransferEvent event) {
+transfers.put(event.getResource(), event);
+synchronized (lock) {
+lock.notifyAll();
+}
}
@Override
-public synchronized void transferCorrupted(TransferEvent event) throws
TransferCancelledException {
-overridePreviousTransfer(event);
-
-super.transferCorrupted(event);
+public void transferCorrupted(TransferEvent event) throws
TransferCancelledException {
+transfers.put(event.getResource(), event);
+synchronized (lock) {
+lock.notifyAll();
+}
}
@Override
-public synchronized void transferProgressed(TransferEvent event) throws
TransferCancelledException {
-TransferResource resource = event.getResource();
-transfers.put(resource, event.getTransferredBytes());
-
-buffer.append("Progress (").append(transfers.size()).append("): ");
-
-Iterator> entries =
-transfers.entrySet().iterator();
-while (entries.hasNext()) {
-Map.Entry entry = entries.next();
-long total = entry.getKey().getContentLength();
-Long complete = entry.getValue();
+public void transferProgressed(TransferEvent event) throws
TransferCancelledException {
+transfers.put(event.getResource(), event);
+synchronized (lock) {
+lock.notifyAll();
+}
+}
-String resourceName = entry.getKey().getResourceName();
+@Override
+public void transferSucceeded(TransferEvent event) {
+transfers.put(event.getResource(), event);
+synchronized (lock) {
+if (transfers.size() == 1) {
+doUpdate();
+} else {
+lock.notifyAll();
+}
+}
+}
-if (printResourceNames) {
-int idx = resourceName.lastIndexOf('/');
+@Override
+public void transferFailed(TransferEvent event) {
+transfers.put(event.getResource(), event);
+synchronized (lock) {
+if (transfers.size() == 1) {
+doUpdate();
+} else {
+lock.notifyAll();
+}
+}
+}
-if (idx < 0) {
-buffer.append(resourceName);
-} else {
-buffer.append(resourceName, idx + 1,
resourceName.length());
+void update() {
+synchronized (lock) {
+try {
+long t0 = System.currentTimeMillis();
+while (true) {
+lock.wait(100);
+long t1 = System.currentTimeMillis();
+if (t1 - t0 > MIN_DELAY_BETWEEN_UPDATES) {
Review Comment:
Don't use ? `currentTimeMillis()` for elapsed time. Use `System#nanoTime()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804731#comment-17804731 ] Romain Manni-Bucau commented on MSOURCES-143: - [~ggregory] well the only thing which is sure is that one artifact (plugin/execution) is ran twice, then cause can be due to multiple factors, either you consider spdx is buggy or that commons-parent is wrong - no judgement from my side on which one is the most accurate. But conclusion is the project "pipeline" must be reworked to sanitize that. Normally debug logs should give enough info about that, if not then we would have to enhance the attachements debug logs. > Can't create a source and test jar in Commons using commons-parent > -- > > Key: MSOURCES-143 > URL: https://issues.apache.org/jira/browse/MSOURCES-143 > Project: Maven Source Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Gary D. Gregory >Priority: Major > > Steps to reproduce: > # git clone https://gitbox.apache.org/repos/asf/commons-parent.git > # cd commons-parent > # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473 > # mvn clean install > # cd .. > # git clone https://gitbox.apache.org/repos/asf/commons-cli.git > # cd commons-cli > # git checkout 08f8c5034a8492be6db65b2086341c292489ee53 > # mvn clean package > [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli --- > [ERROR] We have duplicated artifacts attached. > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 15.233 s > [INFO] Finished at: 2023-08-15T15:39:45-04:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork > (create-source-jar) on project commons-cli: Presumably you have configured > maven-source-plugn to execute twice times in your build. You have to > configure a classifier for at least on of them. -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MSHARED-995) Documents of patterns used for filtering
[
https://issues.apache.org/jira/browse/MSHARED-995?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold updated MSHARED-995:
--
Summary: Documents of patterns used for filtering (was: documentation)
> Documents of patterns used for filtering
>
>
> Key: MSHARED-995
> URL: https://issues.apache.org/jira/browse/MSHARED-995
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-filtering
>Reporter: Delany
>Priority: Major
>
> There's basically no documentation on the pattern matching used to filter
> resources. The filter component documentation reads like dev documentation,
> and I'm left to trail-and-error to figure it out. Adding to the confusion is
> that Maven plugins can implement their own pattern matching/strain of regex.
> I think the assembly plugin does its own thing. Its frustrating enough when
> regex doesn't match so can I at least be clear on the algorithm.
> For example, I want to set a more specific filter to copy resources. The
> filename may have anywhere between 1 and 5 characters followed by an
> extension.
> I tried five question marks, but that only matches 5 characters not 4.
>
> {code:java}
> ?.changelog
> {code}
> There's no support for something like
>
> {code:java}
> ?{1,5}.changelog
> {code}
>
> I see double asterisk in some patterns, suggesting globbing. Can this be
> stated? Perhaps at one point it was obvious - it may seem too simple to
> bother with. But the Internet is full of alternatives today and a simple
> write-up will save a lot of guess-work for newbies and those of us with bad
> memory.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MSHARED-1022) Documents of patterns used for filtering
[
https://issues.apache.org/jira/browse/MSHARED-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold closed MSHARED-1022.
--
> Documents of patterns used for filtering
>
>
> Key: MSHARED-1022
> URL: https://issues.apache.org/jira/browse/MSHARED-1022
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-common-artifact-filters
>Reporter: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
>
> For class:
> - {{org.apache.maven.shared.artifact.filter.PatternIncludesArtifactFilter}}
> - {{org.apache.maven.shared.artifact.filter.PatternExcludesArtifactFilter}}
>
> we can use patterns for filtering artifact, but pattern string is not
> documented.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Resolved] (MSHARED-1022) Documents of patterns used for filtering
[
https://issues.apache.org/jira/browse/MSHARED-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold resolved MSHARED-1022.
Resolution: Duplicate
valid issue that will be tracked in an earlier bug
> Documents of patterns used for filtering
>
>
> Key: MSHARED-1022
> URL: https://issues.apache.org/jira/browse/MSHARED-1022
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-common-artifact-filters
>Reporter: Slawomir Jaranowski
>Priority: Major
> Labels: up-for-grabs
>
> For class:
> - {{org.apache.maven.shared.artifact.filter.PatternIncludesArtifactFilter}}
> - {{org.apache.maven.shared.artifact.filter.PatternExcludesArtifactFilter}}
>
> we can use patterns for filtering artifact, but pattern string is not
> documented.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.0 to 4.9.1 [maven-javadoc-plugin]
elharo commented on PR #263: URL: https://github.com/apache/maven-javadoc-plugin/pull/263#issuecomment-1883042021 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-interactivity-api from 1.1 to 1.2 [maven-javadoc-plugin]
elharo commented on PR #258: URL: https://github.com/apache/maven-javadoc-plugin/pull/258#issuecomment-1883041585 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Clean mdo schemas [maven]
elharo commented on code in PR #1365:
URL: https://github.com/apache/maven/pull/1365#discussion_r1446077275
##
api/maven-api-plugin/src/main/mdo/lifecycle.mdo:
##
@@ -18,20 +18,20 @@ under the License.
-->
http://codehaus-plexus.github.io/MODELLO/2.0.0;
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
- xsi:schemaLocation="http://codehaus-plexus.github.io/MODELLO/2.0.0
http://codehaus-plexus.github.io/modello/xsd/modello-2.0.0.xsd;
+ xsi:schemaLocation="http://codehaus-plexus.github.io/MODELLO/2.0.0
https://codehaus-plexus.github.io/modello/xsd/modello-2.0.0.xsd;
xml.namespace="http://maven.apache.org/LIFECYCLE/${version};
xml.schemaLocation="http://maven.apache.org/xsd/lifecycle-${version}.xsd;>
lifecycle
Lifecycle
LifecycleConfiguration
1.0.0
-
+
Review Comment:
CDATA no longer needed here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-5862) POM XML parser needs XInclude and/or XML Entity support
[
https://issues.apache.org/jira/browse/MNG-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804719#comment-17804719
]
ASF GitHub Bot commented on MNG-5862:
-
elharo commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1446059983
##
maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java:
##
@@ -100,14 +104,39 @@ private Path getRootDirectory(Map options) {
return (Path) value;
}
+private boolean getXInclude(Map options) {
+Object value = (options != null) ? options.get(XINCLUDE) : null;
+return value instanceof Boolean && (Boolean) value;
+}
+
private Model read(InputStream input, Path pomFile, Map
options) throws IOException {
try {
-XMLInputFactory factory = new com.ctc.wstx.stax.WstxInputFactory();
-
factory.setProperty(XMLInputFactory.IS_REPLACING_ENTITY_REFERENCES, false);
-XMLStreamReader parser = factory.createXMLStreamReader(input);
-
InputSource source = getSource(options);
boolean strict = isStrict(options);
+Path rootDirectory = getRootDirectory(options);
+
+Source xmlSource;
+if (pomFile != null) {
+if (input != null) {
+xmlSource = new StaxPathInputSource(pomFile, input);
+} else {
+xmlSource = new Stax2FileSource(pomFile.toFile());
+}
+} else {
+xmlSource = new StreamSource(input);
+}
+
+XMLStreamReader parser;
+// We only support xml entities and xinclude when reading a file
in strict mode
+if (pomFile != null && strict && getXInclude(options)) {
+parser = XInclude.xinclude(xmlSource, new
LocalXmlResolver(rootDirectory));
+} else {
+XMLInputFactory factory = new
com.ctc.wstx.stax.WstxInputFactory();
+
factory.setProperty(XMLInputFactory.IS_REPLACING_ENTITY_REFERENCES, false);
+
factory.setProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, false);
Review Comment:
Nothing you can do here, but this property should have been named
SUPPORTS_EXTERNAL_ENTITIES
##
maven-stax-xinclude/src/main/java/org/apache/maven/stax/xinclude/DOMXMLElementEvaluator.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.stax.xinclude;
+
+import java.util.Map;
+import java.util.Objects;
+
+import com.ctc.wstx.dtd.DTDAttribute;
+import com.ctc.wstx.dtd.DTDElement;
+import com.ctc.wstx.dtd.DTDSubset;
+import com.ctc.wstx.util.PrefixedName;
+import org.w3c.dom.Element;
+
+/**
+ * This class extends the XMLElementEvaluator to support the DOM
implementation in XMLElement.
+ *
+ * This class is based upon a class of the same name in Apache Woden.
+ */
+class DOMXMLElementEvaluator extends XMLElementEvaluator {
+
+private DTDSubset dtd;
+
+/**
+ * Constructs a new DOMXMLElementEvaluator to evaluate a XPointer on a DOM
Element.
+ *
+ * @param xpointer an XPointer to evaluate
+ * @param element an DOM Element to be evaluated
+ */
+DOMXMLElementEvaluator(XPointer xpointer, Element element, DTDSubset dtd) {
+super(xpointer, createXMLElement(element));
+this.dtd = dtd;
+}
+
+/*
+ * (non-Javadoc)
+ * @see
org.apache.woden.internal.xpointer.XMLElementEvaluator#testElementShorthand(org.apache.woden.XMLElement,
java.lang.String)
+ */
+public boolean testElementShorthand(XMLElement element, String
shorthand) {
+// Simple http://www.w3.org/TR/xml-id/ support for now until we
support full scheme based ID's.
+Element domElement = element.getSource();
+String attr =
domElement.getAttributeNS("http://www.w3.org/XML/1998/namespace;, "id");
+if (Objects.equals(attr, shorthand)) {
+return true;
+}
+if (dtd != null) {
+Map map = dtd.getElementMap();
+if (map != null) {
+DTDElement
Re: [PR] [MNG-5862] Support XML entities and XInclude [maven]
elharo commented on code in PR #1205:
URL: https://github.com/apache/maven/pull/1205#discussion_r1446059983
##
maven-model-builder/src/main/java/org/apache/maven/model/io/DefaultModelReader.java:
##
@@ -100,14 +104,39 @@ private Path getRootDirectory(Map options) {
return (Path) value;
}
+private boolean getXInclude(Map options) {
+Object value = (options != null) ? options.get(XINCLUDE) : null;
+return value instanceof Boolean && (Boolean) value;
+}
+
private Model read(InputStream input, Path pomFile, Map
options) throws IOException {
try {
-XMLInputFactory factory = new com.ctc.wstx.stax.WstxInputFactory();
-
factory.setProperty(XMLInputFactory.IS_REPLACING_ENTITY_REFERENCES, false);
-XMLStreamReader parser = factory.createXMLStreamReader(input);
-
InputSource source = getSource(options);
boolean strict = isStrict(options);
+Path rootDirectory = getRootDirectory(options);
+
+Source xmlSource;
+if (pomFile != null) {
+if (input != null) {
+xmlSource = new StaxPathInputSource(pomFile, input);
+} else {
+xmlSource = new Stax2FileSource(pomFile.toFile());
+}
+} else {
+xmlSource = new StreamSource(input);
+}
+
+XMLStreamReader parser;
+// We only support xml entities and xinclude when reading a file
in strict mode
+if (pomFile != null && strict && getXInclude(options)) {
+parser = XInclude.xinclude(xmlSource, new
LocalXmlResolver(rootDirectory));
+} else {
+XMLInputFactory factory = new
com.ctc.wstx.stax.WstxInputFactory();
+
factory.setProperty(XMLInputFactory.IS_REPLACING_ENTITY_REFERENCES, false);
+
factory.setProperty(XMLInputFactory.IS_SUPPORTING_EXTERNAL_ENTITIES, false);
Review Comment:
Nothing you can do here, but this property should have been named
SUPPORTS_EXTERNAL_ENTITIES
##
maven-stax-xinclude/src/main/java/org/apache/maven/stax/xinclude/DOMXMLElementEvaluator.java:
##
@@ -0,0 +1,98 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.stax.xinclude;
+
+import java.util.Map;
+import java.util.Objects;
+
+import com.ctc.wstx.dtd.DTDAttribute;
+import com.ctc.wstx.dtd.DTDElement;
+import com.ctc.wstx.dtd.DTDSubset;
+import com.ctc.wstx.util.PrefixedName;
+import org.w3c.dom.Element;
+
+/**
+ * This class extends the XMLElementEvaluator to support the DOM
implementation in XMLElement.
+ *
+ * This class is based upon a class of the same name in Apache Woden.
+ */
+class DOMXMLElementEvaluator extends XMLElementEvaluator {
+
+private DTDSubset dtd;
+
+/**
+ * Constructs a new DOMXMLElementEvaluator to evaluate a XPointer on a DOM
Element.
+ *
+ * @param xpointer an XPointer to evaluate
+ * @param element an DOM Element to be evaluated
+ */
+DOMXMLElementEvaluator(XPointer xpointer, Element element, DTDSubset dtd) {
+super(xpointer, createXMLElement(element));
+this.dtd = dtd;
+}
+
+/*
+ * (non-Javadoc)
+ * @see
org.apache.woden.internal.xpointer.XMLElementEvaluator#testElementShorthand(org.apache.woden.XMLElement,
java.lang.String)
+ */
+public boolean testElementShorthand(XMLElement element, String
shorthand) {
+// Simple http://www.w3.org/TR/xml-id/ support for now until we
support full scheme based ID's.
+Element domElement = element.getSource();
+String attr =
domElement.getAttributeNS("http://www.w3.org/XML/1998/namespace;, "id");
+if (Objects.equals(attr, shorthand)) {
+return true;
+}
+if (dtd != null) {
+Map map = dtd.getElementMap();
+if (map != null) {
+DTDElement dtdElement = map.get(new
PrefixedName(domElement.getPrefix(), domElement.getLocalName()));
+if (dtdElement != null) {
+DTDAttribute dtdAttribute = dtdElement.getIdAttribute();
+
[jira] [Closed] (MNG-7996) Remove experimental flag from build-consumer feature
[
https://issues.apache.org/jira/browse/MNG-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-7996.
Resolution: Fixed
> Remove experimental flag from build-consumer feature
>
>
> Key: MNG-7996
> URL: https://issues.apache.org/jira/browse/MNG-7996
> Project: Maven
> Issue Type: New Feature
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-11
>
>
> The user property is renamed from {{maven.experimental.buildconsumer}} to
> {{{}maven.buildconsumer{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-7996) Remove experimental flag from build-consumer feature
[
https://issues.apache.org/jira/browse/MNG-7996?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804716#comment-17804716
]
ASF GitHub Bot commented on MNG-7996:
-
gnodet merged PR #1364:
URL: https://github.com/apache/maven/pull/1364
> Remove experimental flag from build-consumer feature
>
>
> Key: MNG-7996
> URL: https://issues.apache.org/jira/browse/MNG-7996
> Project: Maven
> Issue Type: New Feature
>Reporter: Guillaume Nodet
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 4.0.0, 4.0.0-alpha-11
>
>
> The user property is renamed from {{maven.experimental.buildconsumer}} to
> {{{}maven.buildconsumer{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-7996] Remove experimental flag from build-consumer feature [maven]
gnodet merged PR #1364: URL: https://github.com/apache/maven/pull/1364 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MNG-7996) Remove experimental flag from build-consumer feature
Guillaume Nodet created MNG-7996:
Summary: Remove experimental flag from build-consumer feature
Key: MNG-7996
URL: https://issues.apache.org/jira/browse/MNG-7996
Project: Maven
Issue Type: New Feature
Reporter: Guillaume Nodet
Assignee: Guillaume Nodet
Fix For: 4.0.0, 4.0.0-alpha-11
The user property is renamed from {{maven.experimental.buildconsumer}} to
{{{}maven.buildconsumer{}}}.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-5862) POM XML parser needs XInclude and/or XML Entity support
[
https://issues.apache.org/jira/browse/MNG-5862?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804715#comment-17804715
]
ASF GitHub Bot commented on MNG-5862:
-
gnodet commented on PR #1205:
URL: https://github.com/apache/maven/pull/1205#issuecomment-1883027717
One possibility would be to create an extension to support this feature.
This should be possible as the entities/xinclude are only processed at build
time and the consumer pom is flattened.
> POM XML parser needs XInclude and/or XML Entity support
> ---
>
> Key: MNG-5862
> URL: https://issues.apache.org/jira/browse/MNG-5862
> Project: Maven
> Issue Type: New Feature
> Components: POM
>Reporter: Jason Vas Dias
>Assignee: Guillaume Nodet
>Priority: Major
>
> POM XML files can get very large and repetitive , and not all modularizaton
> scenarios can be resolved by using a Super POM as described in MNG-1980 ,
> and would be easily resolved if only the POM parser supported XIncludes or
> XML Entities - neither are supported.
> Here is one such scenario:
> I have a large project that has several SureFire plugin based "Test Suites" -
> each test suite uses a "common-at-classes" module of common test classes,
> and is essentially identical except in its XML configuration "test resource"
> files
> - so the structure is like this :
> {quote}
> {noformat}
> Top Level project directory:
>./pom.xml
>./acceptance-tests/pom.xml
>./acceptance-tests/common-at-classes/pom.xml
>./acceptance-tests/test-suite_#1/pom.xml
>...
>./acceptance-tests/test-suite_#N/pom.xml
> {noformat}
> {quote}
> There are @ 10 ( being upgraded to @ 20) "test suites",
> which all do exactly the same thing, but with slightly
> different "test resource" configuration files,
> and depend on the 'acceptance-tests/common-at-classes" JAR .
> We can modularize all the test-suite dependencies OK in the single
> common-at-classes/pom.xml location .
> But their is no way to modularize the actual XML code that runs each
> test-suite with plugin executions - these plugin execution stanzas can
> currently ONLY
> be in each test-suite#N directory, even though they are identical.
> It would make no sense to have the "Super POM" : acceptance-tests/pom.xml
> contain the plugin executions to run any single test suite ; nor can the
> common-at-classes/pom.xml contain the plugin execution to run any
> test suite, since a test suite run depends on the customized test resource
> files that only exist in each "test_suite#N/" sub-project .
> So the only solution currently available with Maven is to copy the XML stanzas
> that configure and run the test suite ( about 400 lines of XML ) into each of
> the 10-20 test-suite/pom.xml files ; this is all because Maven does not
> support
> XML XInclude or XML Entities; if it did, we could put all this code into one
> XML
> file provided by the common-at-classes project, and include it in each test
> suite .
> The test suite XML is then a nightmare to maintain, consistently for all test
> suites.
> This is becoming such a problem that I am considering making the root project
> POM do nothing more than transform the test-suite poms with XML XInclude-s
> (using an external XML processor), creating a new copy of the whole project,
> and then run an exec plugin goal which runs maven with the transformed POMs.
> Please, please can we have some form of XInclude or XML Entity support , or
> support for an "" element, in the POM parser !
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-5862] Support XML entities and XInclude [maven]
gnodet commented on PR #1205: URL: https://github.com/apache/maven/pull/1205#issuecomment-1883027717 One possibility would be to create an extension to support this feature. This should be possible as the entities/xinclude are only processed at build time and the consumer pom is flattened. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804705#comment-17804705 ] Gary D. Gregory commented on MSOURCES-143: -- But my (poor) understanding of this in the commons-parent case is that this is NOT a bug in MY project, but a bug in the SPDX plug in? Or am I reading this wrong? The bottom line is that it's near impossible to figure out and much less clear to fix. > Can't create a source and test jar in Commons using commons-parent > -- > > Key: MSOURCES-143 > URL: https://issues.apache.org/jira/browse/MSOURCES-143 > Project: Maven Source Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Gary D. Gregory >Priority: Major > > Steps to reproduce: > # git clone https://gitbox.apache.org/repos/asf/commons-parent.git > # cd commons-parent > # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473 > # mvn clean install > # cd .. > # git clone https://gitbox.apache.org/repos/asf/commons-cli.git > # cd commons-cli > # git checkout 08f8c5034a8492be6db65b2086341c292489ee53 > # mvn clean package > [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli --- > [ERROR] We have duplicated artifacts attached. > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 15.233 s > [INFO] Finished at: 2023-08-15T15:39:45-04:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork > (create-source-jar) on project commons-cli: Presumably you have configured > maven-source-plugn to execute twice times in your build. You have to > configure a classifier for at least on of them. -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSOURCES-143) Can't create a source and test jar in Commons using commons-parent
[ https://issues.apache.org/jira/browse/MSOURCES-143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17804702#comment-17804702 ] Romain Manni-Bucau commented on MSOURCES-143: - [~rvesse] probably linked to the fact the bug is not on maven plugin side but the project setup, if you look your build output you will see multiple executions attaching the same binary for sources which was a bug in earlier versions, using it is no more supported (for goods) but can break builds which were abusing this bug. You can see it earlier binding source plugin to an earlier stage - this is mainly dependent your project setup. So while I understand it is bothering it also show you have a bug in your maven usage so it is good. Side note: you'll get the same kind of validation with maven 4 upgrade which will start to fail with missing enabled profiles instead of ignoring it and all that for a better usage and enforce the control of the build instead of faking build was fine when it was not. > Can't create a source and test jar in Commons using commons-parent > -- > > Key: MSOURCES-143 > URL: https://issues.apache.org/jira/browse/MSOURCES-143 > Project: Maven Source Plugin > Issue Type: Bug >Affects Versions: 3.3.0 >Reporter: Gary D. Gregory >Priority: Major > > Steps to reproduce: > # git clone https://gitbox.apache.org/repos/asf/commons-parent.git > # cd commons-parent > # git checkout 8d886ce8382f7a79f06d51a3afc386b8a37d0473 > # mvn clean install > # cd .. > # git clone https://gitbox.apache.org/repos/asf/commons-cli.git > # cd commons-cli > # git checkout 08f8c5034a8492be6db65b2086341c292489ee53 > # mvn clean package > [INFO] --- source:3.3.0:jar-no-fork (create-source-jar) @ commons-cli --- > [ERROR] We have duplicated artifacts attached. > [INFO] > > [INFO] BUILD FAILURE > [INFO] > > [INFO] Total time: 15.233 s > [INFO] Finished at: 2023-08-15T15:39:45-04:00 > [INFO] > > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-source-plugin:3.3.0:jar-no-fork > (create-source-jar) on project commons-cli: Presumably you have configured > maven-source-plugn to execute twice times in your build. You have to > configure a classifier for at least on of them. -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
