[PR] Bump com.github.luben:zstd-jni from 1.5.6-1 to 1.5.6-2 [maven-assembly-plugin]
dependabot[bot] opened a new pull request, #200: URL: https://github.com/apache/maven-assembly-plugin/pull/200 Bumps [com.github.luben:zstd-jni](https://github.com/luben/zstd-jni) from 1.5.6-1 to 1.5.6-2. Commits https://github.com/luben/zstd-jni/commit/1ff893399707523b04ccd373ff6c3e659ec8;>1ff8933 Use cross-compile for i386 https://github.com/luben/zstd-jni/commit/b833326e2a4845fbeec6ca6f58e00049e4ee9c16;>b833326 Adding a getByReferenceBuffer() method. https://github.com/luben/zstd-jni/commit/2a262bf94c818919a6348bd232b63a238c7461fd;>2a262bf Add new constructor to ZstdDictCompress and ZstdDictDecompress that https://github.com/luben/zstd-jni/commit/a516a43567454f10eed8fe3c69d13e6b95a37060;>a516a43 Add back some inspection on MacOS, bump version https://github.com/luben/zstd-jni/commit/2e00ab12f38a28d23cbb1749200fb42880f929af;>2e00ab1 Enable tests on M1 MacOS https://github.com/luben/zstd-jni/commit/c76455c47f48e20fe7fc6e815a1c31300a46d546;>c76455c Add debugging in MacOS CI https://github.com/luben/zstd-jni/commit/ec1ddeb069f59727ecfcbeeb34ca3e6d8a481d49;>ec1ddeb Use the M1 MacOS runner to compile the aarch64 binary https://github.com/luben/zstd-jni/commit/fb6a35d89939c615dde306a8cbfc0a4de1b0c3c9;>fb6a35d Update also checkout and setup-qemu actions https://github.com/luben/zstd-jni/commit/7525a53f8bd144eabde2769ce0e87193be67cd35;>7525a53 setup-java v4 See full diff in https://github.com/luben/zstd-jni/compare/v1.5.6-1...v1.5.6-2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.hazelcast:hazelcast from 5.3.6 to 5.3.7 [maven-resolver]
dependabot[bot] opened a new pull request, #458: URL: https://github.com/apache/maven-resolver/pull/458 Bumps [com.hazelcast:hazelcast](https://github.com/hazelcast/hazelcast) from 5.3.6 to 5.3.7. Release notes Sourced from https://github.com/hazelcast/hazelcast/releases;>com.hazelcast:hazelcast's releases. v5.3.7 This document lists the enhancements, fixed issues, and removed or deprecated features for Hazelcast Platform 5.3.7 release. The numbers in the square brackets refer to the issues and pull requests in Hazelcast's GitHub repository. Enhancements Improved the time spent on the first partition migration, in case a new member joins a cluster with high partition count. https://redirect.github.com/hazelcast/hazelcast/issues/1201;>#1201 Updated the versions of following dependencies: gRPC to 1.60.0 Jetty to 9.4.53.v20231009 AWS SDK to 1.12.688 https://redirect.github.com/hazelcast/hazelcast/issues/1207;>#1207, https://redirect.github.com/hazelcast/hazelcast/issues/1208;>#1208, https://redirect.github.com/hazelcast/hazelcast/issues/1209;>#1209 Commits https://github.com/hazelcast/hazelcast/commit/e2dadf56f301548b69a27d7b5feb9773560ac7c1;>e2dadf5 Upgrade version to 5.3.7 https://github.com/hazelcast/hazelcast/commit/3b01aeb85fac7ff22f48f937798eb5b5803cec7e;>3b01aeb Add RN for Platform OS 5.3.7 (https://redirect.github.com/hazelcast/hazelcast/issues/1236;>#1236) https://github.com/hazelcast/hazelcast/commit/e077a221ca63b846b7d8482fd9c5c9cf767d1f14;>e077a22 Fix Vulnerability in elasticsearch 7.17.13 CVE [HZ-4631] [5.3.7] (https://redirect.github.com/hazelcast/hazelcast/issues/1206;>#1206) https://github.com/hazelcast/hazelcast/commit/fdf59c32e27b15275b97a733cecb7028bb6f4212;>fdf59c3 Update aws-java-sdk-bundle version to 1.12.688 [HZ-4631] (https://redirect.github.com/hazelcast/hazelcast/issues/1209;>#1209) https://github.com/hazelcast/hazelcast/commit/e7f3c9bf25d283ccd66e9f01a20642c6ab26f52d;>e7f3c9b Fix Vulnerability in PostgreSQL driver for CVE-2024-1597 [HZ-4631] [5.3.7] (#... https://github.com/hazelcast/hazelcast/commit/07040bee04575e5f4f2b4a7875bd13339ea2adfb;>07040be Bump jetty to mitigate CVE-2023-44487 [5.3.7] (https://redirect.github.com/hazelcast/hazelcast/issues/1208;>#1208) https://github.com/hazelcast/hazelcast/commit/cf829e8545227110de1160b559942f511464;>cf8 Bump grpc to mitigate CVE-2023-44487 [5.3.7][HZ-4299] (https://redirect.github.com/hazelcast/hazelcast/issues/1207;>#1207) https://github.com/hazelcast/hazelcast/commit/fecc5232c884558afdadc6e13437678e32af1ecc;>fecc523 Batch partition replica updates [HZ-3652] [5.3.7] (https://redirect.github.com/hazelcast/hazelcast/issues/1201;>#1201) https://github.com/hazelcast/hazelcast/commit/39798a5e942e92d0ab0f7e4915da2b7ea07bccd6;>39798a5 Update POM version to 5.3.7-SNAPSHOT [HZ-4188][5.3.7] (https://redirect.github.com/hazelcast/hazelcast/issues/1197;>#1197) https://github.com/hazelcast/hazelcast/commit/0539187294aec0fd73f3dd27a2c5ed8b7fe07a76;>0539187 Disable dependabot in EE (https://redirect.github.com/hazelcast/hazelcast/issues/393;>#393) [5.3.7] Additional commits viewable in https://github.com/hazelcast/hazelcast/compare/v5.3.6...v5.3.7;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop
[PR] Bump org.apache.maven.plugins:maven-source-plugin from 3.3.0 to 3.3.1 [maven-apache-parent]
dependabot[bot] opened a new pull request, #205: URL: https://github.com/apache/maven-apache-parent/pull/205 Bumps [org.apache.maven.plugins:maven-source-plugin](https://github.com/apache/maven-source-plugin) from 3.3.0 to 3.3.1. Commits https://github.com/apache/maven-source-plugin/commit/f80596e4eb587cf99452b67b43ee9729fdadbf3a;>f80596e [maven-release-plugin] prepare release maven-source-plugin-3.3.1 https://github.com/apache/maven-source-plugin/commit/7626998d262931570c969abe3fc60cf911fd6820;>7626998 Bump apache/maven-gh-actions-shared from 3 to 4 https://github.com/apache/maven-source-plugin/commit/83c963c0fffadd3257e9a1ca9266cfac98c057c3;>83c963c Bump org.apache.maven.plugins:maven-plugins from 39 to 41 (https://redirect.github.com/apache/maven-source-plugin/issues/18;>#18) https://github.com/apache/maven-source-plugin/commit/40ae49538beebc793f16a91578629383de114edb;>40ae495 Bump org.codehaus.plexus:plexus-archiver from 4.8.0 to 4.9.1 (https://redirect.github.com/apache/maven-source-plugin/issues/20;>#20) https://github.com/apache/maven-source-plugin/commit/073462bf11ad9cf61cab6a2ed213bb8af5349f35;>073462b Bump org.apache.maven:maven-archiver from 3.6.0 to 3.6.1 (https://redirect.github.com/apache/maven-source-plugin/issues/21;>#21) https://github.com/apache/maven-source-plugin/commit/0b1c82366e306c9d138a3a83950326071c2fc7c6;>0b1c823 Fix typos in AbstractSourceJarMojo exception https://github.com/apache/maven-source-plugin/commit/099c65a64ac20e9f1133b41e2d1906944f6c13c3;>099c65a [MSOURCES-142] Bump org.codehaus.plexus:plexus-archiver from 4.7.1 to 4.8.0 (... https://github.com/apache/maven-source-plugin/commit/1edeea47f80bc5c5903e88c1adbff56501248a8b;>1edeea4 [MSOURCES-139] Fix typo in AbstractSourceJarMojo exception https://github.com/apache/maven-source-plugin/commit/436966ed7f93611d5faa6534478347b99c40f488;>436966e [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-source-plugin/compare/maven-source-plugin-3.3.0...maven-source-plugin-3.3.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove property keywords because of conflict in inline command configration parameters [maven-checkstyle-plugin]
talha-inozu commented on PR #132: URL: https://github.com/apache/maven-checkstyle-plugin/pull/132#issuecomment-2038384851 > > Example: In pom.xml ` my_checks.xml ` But at the code: `@Parameter(property = "checkstyle.config.location", defaultValue = DEFAULT_CONFIG_LOCATION) = protected String configLocation;` > > You can see that `configLocation` and `checkstyle.config.location` conflicts > > Because of checkstyle.config.location , `mvn checkstyle:check` command doesnt see the configureLocation. > > There is no conflicts simply properties is used to assign configuration values for not mentioned options If you have configuration in pom in static way - properties are not used any more ... Yes, I know, but even though I have defined it statically in the pom, when I run it from cmd as mvn checkstyle:check, it does not see the configLocation section in the pom. If I run it as an inline command and I define it as static in the pom, only those with the same property name can be used. I followed the steps I saw in the checklist and when I removed the properties, there was no error and as far as I can see, it was fixed. Can you check it again? When I run it inline and give statically configLocation in the pom, it cannot bind because the @Parameter porperty name is not the same with pom config name and than it uses the default value. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MDEP-317] - add mojo to analyze invalid exclusions [maven-dependency-plugin]
slawekjaranowski commented on code in PR #362:
URL:
https://github.com/apache/maven-dependency-plugin/pull/362#discussion_r1552504011
##
src/main/java/org/apache/maven/plugins/dependency/exclusion/AnalyzeExclusionsMojo.java:
##
@@ -0,0 +1,159 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.plugins.dependency.exclusion;
+
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.function.Consumer;
+
+import org.apache.maven.artifact.Artifact;
+import org.apache.maven.execution.MavenSession;
+import org.apache.maven.model.Dependency;
+import org.apache.maven.plugin.AbstractMojo;
+import org.apache.maven.plugin.MojoExecutionException;
+import org.apache.maven.plugin.MojoFailureException;
+import org.apache.maven.plugins.annotations.Component;
+import org.apache.maven.plugins.annotations.Mojo;
+import org.apache.maven.plugins.annotations.Parameter;
+import org.apache.maven.plugins.annotations.ResolutionScope;
+import org.apache.maven.project.DefaultProjectBuildingRequest;
+import org.apache.maven.project.MavenProject;
+import org.apache.maven.project.ProjectBuilder;
+import org.apache.maven.project.ProjectBuildingException;
+import org.apache.maven.project.ProjectBuildingRequest;
+import org.apache.maven.project.ProjectBuildingResult;
+
+import static java.lang.String.format;
+import static java.util.stream.Collectors.toList;
+import static java.util.stream.Collectors.toSet;
+import static org.apache.commons.lang3.StringUtils.stripToEmpty;
+import static
org.apache.maven.plugins.dependency.exclusion.Coordinates.coordinates;
+
+/**
+ * Analyzes the exclusions defined on dependencies in this project and reports
if any of them are invalid.
+ *
+ * Relevant use case is when an artifact in a later version has removed usage
of a dependency, making the exclusion no
+ * longer valid.
+ *
+ *
+ * @since 3.6.2
+ */
+@Mojo(name = "analyze-exclusions", requiresDependencyResolution =
ResolutionScope.TEST, threadSafe = true)
+public class AnalyzeExclusionsMojo extends AbstractMojo {
+
+@Component
+private MavenProject project;
+
+@Component
+private ProjectBuilder projectBuilder;
+
+@Component
+private MavenSession session;
+
+/**
+ * Whether to fail the build if invalid exclusions is found.
+ */
+@Parameter(property = "failOnWarning", defaultValue = "false")
+private boolean failOnWarning;
Review Comment:
Last comment - I would like to change name of this parameter to something
else.
The same is used in `analyze` gola, so I will can not define different
values for both
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Resolved] (MENFORCER-500) New rule: Maven coordinates must match pattern
[
https://issues.apache.org/jira/browse/MENFORCER-500?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Konrad Windszus resolved MENFORCER-500.
---
Fix Version/s: next-release
Resolution: Fixed
Fixed in
https://github.com/apache/maven-enforcer/commit/80ee78e5f7473dafc8ca8e68d8f2af7895290303.
> New rule: Maven coordinates must match pattern
> --
>
> Key: MENFORCER-500
> URL: https://issues.apache.org/jira/browse/MENFORCER-500
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
> Fix For: next-release
>
>
> Sometimes it is crucial that the {{groupId}} and/or the {{artifactId}} match
> a certain pattern (e.g. because it is reserved namespace prefix for deploying
> to Maven Central). It would be beneficial to enforce that with a standard
> rule.
> The pattern should be a configurable regex pattern (independently for
> {{artifactId}} and {{groupId}})
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MENFORCER-500) New rule: Maven coordinates must match pattern
[
https://issues.apache.org/jira/browse/MENFORCER-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834052#comment-17834052
]
ASF GitHub Bot commented on MENFORCER-500:
--
kwin merged PR #309:
URL: https://github.com/apache/maven-enforcer/pull/309
> New rule: Maven coordinates must match pattern
> --
>
> Key: MENFORCER-500
> URL: https://issues.apache.org/jira/browse/MENFORCER-500
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Sometimes it is crucial that the {{groupId}} and/or the {{artifactId}} match
> a certain pattern (e.g. because it is reserved namespace prefix for deploying
> to Maven Central). It would be beneficial to enforce that with a standard
> rule.
> The pattern should be a configurable regex pattern (independently for
> {{artifactId}} and {{groupId}})
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MENFORCER-500] New rule to enforce that Maven coordinates match given [maven-enforcer]
kwin merged PR #309: URL: https://github.com/apache/maven-enforcer/pull/309 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [I] if i use nixos system, how can i install [maven-mvnd]
nathansit commented on issue #928: URL: https://github.com/apache/maven-mvnd/issues/928#issuecomment-2037951009 See README and see if you have further questions? https://github.com/apache/maven-mvnd?tab=readme-ov-file#how-to-install-mvnd -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MCLEAN-116) Propagating a source exception in Cleaner class
[
https://issues.apache.org/jira/browse/MCLEAN-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski updated MCLEAN-116:
---
Summary: Propagating a source exception in Cleaner class (was: Create
interface method to catch exceptions)
> Propagating a source exception in Cleaner class
> ---
>
> Key: MCLEAN-116
> URL: https://issues.apache.org/jira/browse/MCLEAN-116
> Project: Maven Clean Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.2
>Reporter: Matthias Bünger
>Assignee: Slawomir Jaranowski
>Priority: Minor
>
> As stated multiple times in the {{Cleaner}} class, the {{Logger}} interface
> of this class does not provide a method to log exceptions and needs a
> refactoring
> {code:java}
> // ...
> if (logDebug != null) {
> // TODO: this Logger interface cannot log exceptions and
> needs refactoring
> logDebug.log("Unable to fast delete directory: " + e);
> }
> // ...
> private interface Logger {
> void log(CharSequence message);
> }
> {code}
> However: Many plugins, e.g. the javadoc-plugin or the pmg-plugin use the
> {{org.apache.maven.plugin.logging.Log}} interface. Therefor using this
> interface instead an own could be a better solution than adding a new method
> to the interface in the {{Cleaner}} class.
> _This ticket was created to have this task in the issue tracker_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MCLEAN-116) Propagating a source exception in Cleaner class
[
https://issues.apache.org/jira/browse/MCLEAN-116?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Slawomir Jaranowski closed MCLEAN-116.
--
Fix Version/s: next-release
Resolution: Fixed
> Propagating a source exception in Cleaner class
> ---
>
> Key: MCLEAN-116
> URL: https://issues.apache.org/jira/browse/MCLEAN-116
> Project: Maven Clean Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.2
>Reporter: Matthias Bünger
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: next-release
>
>
> As stated multiple times in the {{Cleaner}} class, the {{Logger}} interface
> of this class does not provide a method to log exceptions and needs a
> refactoring
> {code:java}
> // ...
> if (logDebug != null) {
> // TODO: this Logger interface cannot log exceptions and
> needs refactoring
> logDebug.log("Unable to fast delete directory: " + e);
> }
> // ...
> private interface Logger {
> void log(CharSequence message);
> }
> {code}
> However: Many plugins, e.g. the javadoc-plugin or the pmg-plugin use the
> {{org.apache.maven.plugin.logging.Log}} interface. Therefor using this
> interface instead an own could be a better solution than adding a new method
> to the interface in the {{Cleaner}} class.
> _This ticket was created to have this task in the issue tracker_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MCLEAN-116) Create interface method to catch exceptions
[
https://issues.apache.org/jira/browse/MCLEAN-116?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834049#comment-17834049
]
ASF GitHub Bot commented on MCLEAN-116:
---
slawekjaranowski merged PR #37:
URL: https://github.com/apache/maven-clean-plugin/pull/37
> Create interface method to catch exceptions
> ---
>
> Key: MCLEAN-116
> URL: https://issues.apache.org/jira/browse/MCLEAN-116
> Project: Maven Clean Plugin
> Issue Type: Improvement
>Affects Versions: 3.3.2
>Reporter: Matthias Bünger
>Assignee: Slawomir Jaranowski
>Priority: Minor
>
> As stated multiple times in the {{Cleaner}} class, the {{Logger}} interface
> of this class does not provide a method to log exceptions and needs a
> refactoring
> {code:java}
> // ...
> if (logDebug != null) {
> // TODO: this Logger interface cannot log exceptions and
> needs refactoring
> logDebug.log("Unable to fast delete directory: " + e);
> }
> // ...
> private interface Logger {
> void log(CharSequence message);
> }
> {code}
> However: Many plugins, e.g. the javadoc-plugin or the pmg-plugin use the
> {{org.apache.maven.plugin.logging.Log}} interface. Therefor using this
> interface instead an own could be a better solution than adding a new method
> to the interface in the {{Cleaner}} class.
> _This ticket was created to have this task in the issue tracker_
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MCLEAN-116] Use default Log interface [maven-clean-plugin]
slawekjaranowski merged PR #37: URL: https://github.com/apache/maven-clean-plugin/pull/37 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove property keywords because of conflict in inline command configration parameters [maven-checkstyle-plugin]
slawekjaranowski commented on PR #132: URL: https://github.com/apache/maven-checkstyle-plugin/pull/132#issuecomment-2037897766 > Example: In pom.xml ` my_checks.xml ` But at the code: `@Parameter(property = "checkstyle.config.location", defaultValue = DEFAULT_CONFIG_LOCATION) = protected String configLocation;` > > You can see that `configLocation` and `checkstyle.config.location` conflicts > > Because of checkstyle.config.location , `mvn checkstyle:check` command doesnt see the configureLocation. There is no conflicts simply properties is used to assign configuration values for not mentioned options If you have configuration in pom in static way - properties are not used any more ... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MENFORCER-500) New rule: Maven coordinates must match pattern
[
https://issues.apache.org/jira/browse/MENFORCER-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834044#comment-17834044
]
ASF GitHub Bot commented on MENFORCER-500:
--
kwin commented on code in PR #309:
URL: https://github.com/apache/maven-enforcer/pull/309#discussion_r1552208018
##
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireMatchingCoordinates.java:
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.enforcer.rules;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+
+import java.util.Objects;
+import java.util.regex.Pattern;
+
+import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
+import org.apache.maven.project.MavenProject;
+
+/**
+ * This rule checks that the Maven coordinates (i.e. the project's {@code
groupId} and {@code artifactId}) each match a given pattern.
+ * @since 3.5.0
+ */
+@Named("requireMatchingCoordinates")
+public final class RequireMatchingCoordinates extends
AbstractStandardEnforcerRule {
+
+private Pattern groupIdPattern;
+
+private Pattern artifactIdPattern;
+
+private boolean moduleNameMustMatchArtifactId;
+
+private final MavenProject project;
+
+@Inject
+public RequireMatchingCoordinates(MavenProject project) {
+this.project = Objects.requireNonNull(project);
+}
+
+@Override
+public void execute() throws EnforcerRuleException {
+StringBuilder msgBuilder = new StringBuilder();
+if (groupIdPattern != null
+&& !groupIdPattern.matcher(project.getGroupId()).matches()) {
+msgBuilder
+.append("Group ID must match pattern \"")
+.append(groupIdPattern)
+.append("\" but is \"")
+.append(project.getGroupId())
+.append("\"");
+}
+if (artifactIdPattern != null
+&&
!artifactIdPattern.matcher(project.getArtifactId()).matches()) {
+if (msgBuilder.length() > 0) {
+msgBuilder.append(System.lineSeparator());
+}
+msgBuilder
+.append("Artifact ID must match pattern \"")
+.append(artifactIdPattern)
+.append("\" but is \"")
+.append(project.getArtifactId())
+.append("\"");
+}
+if (moduleNameMustMatchArtifactId
+&& !project.isExecutionRoot()
+&&
!project.getBasedir().getName().equals(project.getArtifactId())) {
+if (msgBuilder.length() > 0) {
+msgBuilder.append(System.lineSeparator());
+}
+msgBuilder
+.append("Module directory name must be equal to its
artifact ID \"")
+.append(project.getArtifactId())
+.append("\" but is \"")
+.append(project.getBasedir().getName())
+.append("\"");
+}
+if (msgBuilder.length() > 0) {
+throw new EnforcerRuleException(msgBuilder.toString());
+}
+}
+
+public void setGroupIdPattern(String groupIdPattern) {
Review Comment:
slightly less reflection magic for setter injection:
https://github.com/eclipse/sisu.plexus/blob/5e8587eac8c4c079566dcd0ccb0d5dba40cb4169/org.eclipse.sisu.plexus/src/main/java/org/eclipse/sisu/plexus/CompositeBeanHelper.java#L143-L226
:-)
> New rule: Maven coordinates must match pattern
> --
>
> Key: MENFORCER-500
> URL: https://issues.apache.org/jira/browse/MENFORCER-500
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Sometimes it is crucial that the {{groupId}} and/or the {{artifactId}} match
> a certain pattern (e.g. because it is reserved namespace prefix for deploying
> to Maven Central). It would be beneficial to enforce that with a standard
> rule.
> The pattern
Re: [PR] [MENFORCER-500] New rule to enforce that Maven coordinates match given [maven-enforcer]
kwin commented on code in PR #309:
URL: https://github.com/apache/maven-enforcer/pull/309#discussion_r1552208018
##
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireMatchingCoordinates.java:
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.enforcer.rules;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+
+import java.util.Objects;
+import java.util.regex.Pattern;
+
+import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
+import org.apache.maven.project.MavenProject;
+
+/**
+ * This rule checks that the Maven coordinates (i.e. the project's {@code
groupId} and {@code artifactId}) each match a given pattern.
+ * @since 3.5.0
+ */
+@Named("requireMatchingCoordinates")
+public final class RequireMatchingCoordinates extends
AbstractStandardEnforcerRule {
+
+private Pattern groupIdPattern;
+
+private Pattern artifactIdPattern;
+
+private boolean moduleNameMustMatchArtifactId;
+
+private final MavenProject project;
+
+@Inject
+public RequireMatchingCoordinates(MavenProject project) {
+this.project = Objects.requireNonNull(project);
+}
+
+@Override
+public void execute() throws EnforcerRuleException {
+StringBuilder msgBuilder = new StringBuilder();
+if (groupIdPattern != null
+&& !groupIdPattern.matcher(project.getGroupId()).matches()) {
+msgBuilder
+.append("Group ID must match pattern \"")
+.append(groupIdPattern)
+.append("\" but is \"")
+.append(project.getGroupId())
+.append("\"");
+}
+if (artifactIdPattern != null
+&&
!artifactIdPattern.matcher(project.getArtifactId()).matches()) {
+if (msgBuilder.length() > 0) {
+msgBuilder.append(System.lineSeparator());
+}
+msgBuilder
+.append("Artifact ID must match pattern \"")
+.append(artifactIdPattern)
+.append("\" but is \"")
+.append(project.getArtifactId())
+.append("\"");
+}
+if (moduleNameMustMatchArtifactId
+&& !project.isExecutionRoot()
+&&
!project.getBasedir().getName().equals(project.getArtifactId())) {
+if (msgBuilder.length() > 0) {
+msgBuilder.append(System.lineSeparator());
+}
+msgBuilder
+.append("Module directory name must be equal to its
artifact ID \"")
+.append(project.getArtifactId())
+.append("\" but is \"")
+.append(project.getBasedir().getName())
+.append("\"");
+}
+if (msgBuilder.length() > 0) {
+throw new EnforcerRuleException(msgBuilder.toString());
+}
+}
+
+public void setGroupIdPattern(String groupIdPattern) {
Review Comment:
slightly less reflection magic for setter injection:
https://github.com/eclipse/sisu.plexus/blob/5e8587eac8c4c079566dcd0ccb0d5dba40cb4169/org.eclipse.sisu.plexus/src/main/java/org/eclipse/sisu/plexus/CompositeBeanHelper.java#L143-L226
:-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MENFORCER-500) New rule: Maven coordinates must match pattern
[
https://issues.apache.org/jira/browse/MENFORCER-500?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17834043#comment-17834043
]
ASF GitHub Bot commented on MENFORCER-500:
--
slawekjaranowski commented on code in PR #309:
URL: https://github.com/apache/maven-enforcer/pull/309#discussion_r1552202688
##
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireMatchingCoordinates.java:
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.enforcer.rules;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+
+import java.util.Objects;
+import java.util.regex.Pattern;
+
+import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
+import org.apache.maven.project.MavenProject;
+
+/**
+ * This rule checks that the Maven coordinates (i.e. the project's {@code
groupId} and {@code artifactId}) each match a given pattern.
+ * @since 3.5.0
+ */
+@Named("requireMatchingCoordinates")
+public final class RequireMatchingCoordinates extends
AbstractStandardEnforcerRule {
+
+private Pattern groupIdPattern;
+
+private Pattern artifactIdPattern;
+
+private boolean moduleNameMustMatchArtifactId;
+
+private final MavenProject project;
+
+@Inject
+public RequireMatchingCoordinates(MavenProject project) {
+this.project = Objects.requireNonNull(project);
+}
+
+@Override
+public void execute() throws EnforcerRuleException {
+StringBuilder msgBuilder = new StringBuilder();
+if (groupIdPattern != null
+&& !groupIdPattern.matcher(project.getGroupId()).matches()) {
+msgBuilder
+.append("Group ID must match pattern \"")
+.append(groupIdPattern)
+.append("\" but is \"")
+.append(project.getGroupId())
+.append("\"");
+}
+if (artifactIdPattern != null
+&&
!artifactIdPattern.matcher(project.getArtifactId()).matches()) {
+if (msgBuilder.length() > 0) {
+msgBuilder.append(System.lineSeparator());
+}
+msgBuilder
+.append("Artifact ID must match pattern \"")
+.append(artifactIdPattern)
+.append("\" but is \"")
+.append(project.getArtifactId())
+.append("\"");
+}
+if (moduleNameMustMatchArtifactId
+&& !project.isExecutionRoot()
+&&
!project.getBasedir().getName().equals(project.getArtifactId())) {
+if (msgBuilder.length() > 0) {
+msgBuilder.append(System.lineSeparator());
+}
+msgBuilder
+.append("Module directory name must be equal to its
artifact ID \"")
+.append(project.getArtifactId())
+.append("\" but is \"")
+.append(project.getBasedir().getName())
+.append("\"");
+}
+if (msgBuilder.length() > 0) {
+throw new EnforcerRuleException(msgBuilder.toString());
+}
+}
+
+public void setGroupIdPattern(String groupIdPattern) {
Review Comment:
setters methods are not required
> New rule: Maven coordinates must match pattern
> --
>
> Key: MENFORCER-500
> URL: https://issues.apache.org/jira/browse/MENFORCER-500
> Project: Maven Enforcer Plugin
> Issue Type: Improvement
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Sometimes it is crucial that the {{groupId}} and/or the {{artifactId}} match
> a certain pattern (e.g. because it is reserved namespace prefix for deploying
> to Maven Central). It would be beneficial to enforce that with a standard
> rule.
> The pattern should be a configurable regex pattern (independently for
> {{artifactId}} and {{groupId}})
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MENFORCER-500] New rule to enforce that Maven coordinates match given [maven-enforcer]
slawekjaranowski commented on code in PR #309:
URL: https://github.com/apache/maven-enforcer/pull/309#discussion_r1552202688
##
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/RequireMatchingCoordinates.java:
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.enforcer.rules;
+
+import javax.inject.Inject;
+import javax.inject.Named;
+
+import java.util.Objects;
+import java.util.regex.Pattern;
+
+import org.apache.maven.enforcer.rule.api.EnforcerRuleException;
+import org.apache.maven.project.MavenProject;
+
+/**
+ * This rule checks that the Maven coordinates (i.e. the project's {@code
groupId} and {@code artifactId}) each match a given pattern.
+ * @since 3.5.0
+ */
+@Named("requireMatchingCoordinates")
+public final class RequireMatchingCoordinates extends
AbstractStandardEnforcerRule {
+
+private Pattern groupIdPattern;
+
+private Pattern artifactIdPattern;
+
+private boolean moduleNameMustMatchArtifactId;
+
+private final MavenProject project;
+
+@Inject
+public RequireMatchingCoordinates(MavenProject project) {
+this.project = Objects.requireNonNull(project);
+}
+
+@Override
+public void execute() throws EnforcerRuleException {
+StringBuilder msgBuilder = new StringBuilder();
+if (groupIdPattern != null
+&& !groupIdPattern.matcher(project.getGroupId()).matches()) {
+msgBuilder
+.append("Group ID must match pattern \"")
+.append(groupIdPattern)
+.append("\" but is \"")
+.append(project.getGroupId())
+.append("\"");
+}
+if (artifactIdPattern != null
+&&
!artifactIdPattern.matcher(project.getArtifactId()).matches()) {
+if (msgBuilder.length() > 0) {
+msgBuilder.append(System.lineSeparator());
+}
+msgBuilder
+.append("Artifact ID must match pattern \"")
+.append(artifactIdPattern)
+.append("\" but is \"")
+.append(project.getArtifactId())
+.append("\"");
+}
+if (moduleNameMustMatchArtifactId
+&& !project.isExecutionRoot()
+&&
!project.getBasedir().getName().equals(project.getArtifactId())) {
+if (msgBuilder.length() > 0) {
+msgBuilder.append(System.lineSeparator());
+}
+msgBuilder
+.append("Module directory name must be equal to its
artifact ID \"")
+.append(project.getArtifactId())
+.append("\" but is \"")
+.append(project.getBasedir().getName())
+.append("\"");
+}
+if (msgBuilder.length() > 0) {
+throw new EnforcerRuleException(msgBuilder.toString());
+}
+}
+
+public void setGroupIdPattern(String groupIdPattern) {
Review Comment:
setters methods are not required
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-1022) jgit push failure is not failing the build
[
https://issues.apache.org/jira/browse/SCM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833968#comment-17833968
]
ASF GitHub Bot commented on SCM-1022:
-
attiand commented on code in PR #203:
URL: https://github.com/apache/maven-scm/pull/203#discussion_r1551846585
##
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckinCommandTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.scm.provider.git.jgit.command.checkin;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.scm.PlexusJUnit4TestSupport;
+import org.apache.maven.scm.ScmFileSet;
+import org.apache.maven.scm.ScmTestCase;
+import org.apache.maven.scm.command.checkin.CheckInScmResult;
+import org.apache.maven.scm.command.checkout.CheckOutScmResult;
+import org.apache.maven.scm.provider.git.GitScmTestUtils;
+import org.apache.maven.scm.repository.ScmRepository;
+import org.codehaus.plexus.util.FileUtils;
+import org.junit.Test;
+
+import static org.junit.Assert.assertFalse;
+
+public class JGitCheckinCommandTest extends ScmTestCase {
Review Comment:
Good point. It turns out that the `RemoteRefUpdate.Status#UP_TO_DATE`
equivalent for gitexe is considered ok as the `git push` command returns zero.
Which seems questionable for maven-release. Nothing would be changed in the
upstream.
Which is better: To have equal behavior for both implementations, or a
successful, possibly empty release?
> jgit push failure is not failing the build
> --
>
> Key: SCM-1022
> URL: https://issues.apache.org/jira/browse/SCM-1022
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 2.0.1
>Reporter: Mattias Andersson
>Priority: Major
>
> If the push command fails, the maven build does not fail. This means binaries
> are deployed, but the remote repo is not updated. The issue seems related to
> SCM-854.
> We use Gerrit and have the merge strategy set to "fast forward only". If
> someone pushes a commit during the release job, only an INFO message is
> logged, but the maven build is successful.
> The same use case with the maven-scm-provider-gitexe (the default) fails the
> build as expected (git push returns a non-zero exit code)
> {code:java}
> 10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
> 10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
> 10:28:03 [INFO] fetch url: ssh://xxx@xxx
> 10:28:03 [INFO] push url: ssh://xxx@xxx
> 10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
> net.i2p.crypto.eddsa.EdDSASecurityProvider
> 10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
> Nio2ServiceFactoryFactory
> 10:28:04 [INFO] REJECTED_NONFASTFORWARD -
> RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
> 1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
> srcRef=refs/heads/master, message=null]
> 10:28:04 [INFO] 12/17 prepare:scm-tag
> 10:28:04 [INFO] Tagging release with the label 2.15.0...
> 10:28:04 [INFO] push tag [2.15.0] to remote...
> 10:28:04 [INFO] fetch url: ssh://xxx@xxx
> 10:28:04 [INFO] push url: ssh://xxx@xxx
> 10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
> ...968d97de8331ce19d43c719e870890def5ee65d9,
> fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]
attiand commented on code in PR #203:
URL: https://github.com/apache/maven-scm/pull/203#discussion_r1551846585
##
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckinCommandTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.scm.provider.git.jgit.command.checkin;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.scm.PlexusJUnit4TestSupport;
+import org.apache.maven.scm.ScmFileSet;
+import org.apache.maven.scm.ScmTestCase;
+import org.apache.maven.scm.command.checkin.CheckInScmResult;
+import org.apache.maven.scm.command.checkout.CheckOutScmResult;
+import org.apache.maven.scm.provider.git.GitScmTestUtils;
+import org.apache.maven.scm.repository.ScmRepository;
+import org.codehaus.plexus.util.FileUtils;
+import org.junit.Test;
+
+import static org.junit.Assert.assertFalse;
+
+public class JGitCheckinCommandTest extends ScmTestCase {
Review Comment:
Good point. It turns out that the `RemoteRefUpdate.Status#UP_TO_DATE`
equivalent for gitexe is considered ok as the `git push` command returns zero.
Which seems questionable for maven-release. Nothing would be changed in the
upstream.
Which is better: To have equal behavior for both implementations, or a
successful, possibly empty release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-1022) jgit push failure is not failing the build
[
https://issues.apache.org/jira/browse/SCM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833932#comment-17833932
]
ASF GitHub Bot commented on SCM-1022:
-
michael-o commented on code in PR #203:
URL: https://github.com/apache/maven-scm/pull/203#discussion_r1551701670
##
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckinCommandTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.scm.provider.git.jgit.command.checkin;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.scm.PlexusJUnit4TestSupport;
+import org.apache.maven.scm.ScmFileSet;
+import org.apache.maven.scm.ScmTestCase;
+import org.apache.maven.scm.command.checkin.CheckInScmResult;
+import org.apache.maven.scm.command.checkout.CheckOutScmResult;
+import org.apache.maven.scm.provider.git.GitScmTestUtils;
+import org.apache.maven.scm.repository.ScmRepository;
+import org.codehaus.plexus.util.FileUtils;
+import org.junit.Test;
+
+import static org.junit.Assert.assertFalse;
+
+public class JGitCheckinCommandTest extends ScmTestCase {
Review Comment:
If this remains file name should be `JGitCheckInCommandTest`
> jgit push failure is not failing the build
> --
>
> Key: SCM-1022
> URL: https://issues.apache.org/jira/browse/SCM-1022
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 2.0.1
>Reporter: Mattias Andersson
>Priority: Major
>
> If the push command fails, the maven build does not fail. This means binaries
> are deployed, but the remote repo is not updated. The issue seems related to
> SCM-854.
> We use Gerrit and have the merge strategy set to "fast forward only". If
> someone pushes a commit during the release job, only an INFO message is
> logged, but the maven build is successful.
> The same use case with the maven-scm-provider-gitexe (the default) fails the
> build as expected (git push returns a non-zero exit code)
> {code:java}
> 10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
> 10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
> 10:28:03 [INFO] fetch url: ssh://xxx@xxx
> 10:28:03 [INFO] push url: ssh://xxx@xxx
> 10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
> net.i2p.crypto.eddsa.EdDSASecurityProvider
> 10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
> Nio2ServiceFactoryFactory
> 10:28:04 [INFO] REJECTED_NONFASTFORWARD -
> RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
> 1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
> srcRef=refs/heads/master, message=null]
> 10:28:04 [INFO] 12/17 prepare:scm-tag
> 10:28:04 [INFO] Tagging release with the label 2.15.0...
> 10:28:04 [INFO] push tag [2.15.0] to remote...
> 10:28:04 [INFO] fetch url: ssh://xxx@xxx
> 10:28:04 [INFO] push url: ssh://xxx@xxx
> 10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
> ...968d97de8331ce19d43c719e870890def5ee65d9,
> fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]
michael-o commented on code in PR #203:
URL: https://github.com/apache/maven-scm/pull/203#discussion_r1551701670
##
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckinCommandTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.scm.provider.git.jgit.command.checkin;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.scm.PlexusJUnit4TestSupport;
+import org.apache.maven.scm.ScmFileSet;
+import org.apache.maven.scm.ScmTestCase;
+import org.apache.maven.scm.command.checkin.CheckInScmResult;
+import org.apache.maven.scm.command.checkout.CheckOutScmResult;
+import org.apache.maven.scm.provider.git.GitScmTestUtils;
+import org.apache.maven.scm.repository.ScmRepository;
+import org.codehaus.plexus.util.FileUtils;
+import org.junit.Test;
+
+import static org.junit.Assert.assertFalse;
+
+public class JGitCheckinCommandTest extends ScmTestCase {
Review Comment:
If this remains file name should be `JGitCheckInCommandTest`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-1022) jgit push failure is not failing the build
[
https://issues.apache.org/jira/browse/SCM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833930#comment-17833930
]
ASF GitHub Bot commented on SCM-1022:
-
michael-o commented on code in PR #203:
URL: https://github.com/apache/maven-scm/pull/203#discussion_r1551698288
##
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommand.java:
##
@@ -139,7 +141,20 @@ protected CheckInScmResult executeCheckInCommand(
}
RefSpec refSpec = new RefSpec(Constants.R_HEADS + branch + ":"
+ Constants.R_HEADS + branch);
logger.info("push changes to remote... " + refSpec);
-JGitUtils.push(git, (GitScmProviderRepository) repo, refSpec);
+Iterable pushResultList = JGitUtils.push(git,
(GitScmProviderRepository) repo, refSpec);
+
+for (PushResult pushResult : pushResultList) {
+for (RemoteRefUpdate remoteRefUpdate :
pushResult.getRemoteUpdates()) {
+if (remoteRefUpdate.getStatus() !=
RemoteRefUpdate.Status.OK) {
+return new CheckInScmResult(
+"JGit checkin",
+"The git-push command failed, with status:
"
++
remoteRefUpdate.getStatus().name(),
Review Comment:
I think we can reduce to `getStatus()` and the implicit string conv will do
the magic for us.
> jgit push failure is not failing the build
> --
>
> Key: SCM-1022
> URL: https://issues.apache.org/jira/browse/SCM-1022
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 2.0.1
>Reporter: Mattias Andersson
>Priority: Major
>
> If the push command fails, the maven build does not fail. This means binaries
> are deployed, but the remote repo is not updated. The issue seems related to
> SCM-854.
> We use Gerrit and have the merge strategy set to "fast forward only". If
> someone pushes a commit during the release job, only an INFO message is
> logged, but the maven build is successful.
> The same use case with the maven-scm-provider-gitexe (the default) fails the
> build as expected (git push returns a non-zero exit code)
> {code:java}
> 10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
> 10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
> 10:28:03 [INFO] fetch url: ssh://xxx@xxx
> 10:28:03 [INFO] push url: ssh://xxx@xxx
> 10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
> net.i2p.crypto.eddsa.EdDSASecurityProvider
> 10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
> Nio2ServiceFactoryFactory
> 10:28:04 [INFO] REJECTED_NONFASTFORWARD -
> RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
> 1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
> srcRef=refs/heads/master, message=null]
> 10:28:04 [INFO] 12/17 prepare:scm-tag
> 10:28:04 [INFO] Tagging release with the label 2.15.0...
> 10:28:04 [INFO] push tag [2.15.0] to remote...
> 10:28:04 [INFO] fetch url: ssh://xxx@xxx
> 10:28:04 [INFO] push url: ssh://xxx@xxx
> 10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
> ...968d97de8331ce19d43c719e870890def5ee65d9,
> fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]
michael-o commented on code in PR #203:
URL: https://github.com/apache/maven-scm/pull/203#discussion_r1551698288
##
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/main/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckInCommand.java:
##
@@ -139,7 +141,20 @@ protected CheckInScmResult executeCheckInCommand(
}
RefSpec refSpec = new RefSpec(Constants.R_HEADS + branch + ":"
+ Constants.R_HEADS + branch);
logger.info("push changes to remote... " + refSpec);
-JGitUtils.push(git, (GitScmProviderRepository) repo, refSpec);
+Iterable pushResultList = JGitUtils.push(git,
(GitScmProviderRepository) repo, refSpec);
+
+for (PushResult pushResult : pushResultList) {
+for (RemoteRefUpdate remoteRefUpdate :
pushResult.getRemoteUpdates()) {
+if (remoteRefUpdate.getStatus() !=
RemoteRefUpdate.Status.OK) {
+return new CheckInScmResult(
+"JGit checkin",
+"The git-push command failed, with status:
"
++
remoteRefUpdate.getStatus().name(),
Review Comment:
I think we can reduce to `getStatus()` and the implicit string conv will do
the magic for us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump mavenVersion from 3.2.5 to 3.3.9 [maven-doap-plugin]
dependabot[bot] opened a new pull request, #24: URL: https://github.com/apache/maven-doap-plugin/pull/24 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-1022) jgit push failure is not failing the build
[
https://issues.apache.org/jira/browse/SCM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833917#comment-17833917
]
ASF GitHub Bot commented on SCM-1022:
-
kwin commented on code in PR #203:
URL: https://github.com/apache/maven-scm/pull/203#discussion_r1551603301
##
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckinCommandTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.scm.provider.git.jgit.command.checkin;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.scm.PlexusJUnit4TestSupport;
+import org.apache.maven.scm.ScmFileSet;
+import org.apache.maven.scm.ScmTestCase;
+import org.apache.maven.scm.command.checkin.CheckInScmResult;
+import org.apache.maven.scm.command.checkout.CheckOutScmResult;
+import org.apache.maven.scm.provider.git.GitScmTestUtils;
+import org.apache.maven.scm.repository.ScmRepository;
+import org.codehaus.plexus.util.FileUtils;
+import org.junit.Test;
+
+import static org.junit.Assert.assertFalse;
+
+public class JGitCheckinCommandTest extends ScmTestCase {
Review Comment:
I would prefer having this test as part of the Git TCK so that it is
executed against both Git CLI and JGit.
> jgit push failure is not failing the build
> --
>
> Key: SCM-1022
> URL: https://issues.apache.org/jira/browse/SCM-1022
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 2.0.1
>Reporter: Mattias Andersson
>Priority: Major
>
> If the push command fails, the maven build does not fail. This means binaries
> are deployed, but the remote repo is not updated. The issue seems related to
> SCM-854.
> We use Gerrit and have the merge strategy set to "fast forward only". If
> someone pushes a commit during the release job, only an INFO message is
> logged, but the maven build is successful.
> The same use case with the maven-scm-provider-gitexe (the default) fails the
> build as expected (git push returns a non-zero exit code)
> {code:java}
> 10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
> 10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
> 10:28:03 [INFO] fetch url: ssh://xxx@xxx
> 10:28:03 [INFO] push url: ssh://xxx@xxx
> 10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
> net.i2p.crypto.eddsa.EdDSASecurityProvider
> 10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
> Nio2ServiceFactoryFactory
> 10:28:04 [INFO] REJECTED_NONFASTFORWARD -
> RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
> 1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
> srcRef=refs/heads/master, message=null]
> 10:28:04 [INFO] 12/17 prepare:scm-tag
> 10:28:04 [INFO] Tagging release with the label 2.15.0...
> 10:28:04 [INFO] push tag [2.15.0] to remote...
> 10:28:04 [INFO] fetch url: ssh://xxx@xxx
> 10:28:04 [INFO] push url: ssh://xxx@xxx
> 10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
> ...968d97de8331ce19d43c719e870890def5ee65d9,
> fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]
kwin commented on code in PR #203:
URL: https://github.com/apache/maven-scm/pull/203#discussion_r1551603301
##
maven-scm-providers/maven-scm-providers-git/maven-scm-provider-jgit/src/test/java/org/apache/maven/scm/provider/git/jgit/command/checkin/JGitCheckinCommandTest.java:
##
@@ -0,0 +1,104 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.scm.provider.git.jgit.command.checkin;
+
+import java.io.File;
+import java.io.IOException;
+
+import org.apache.maven.scm.PlexusJUnit4TestSupport;
+import org.apache.maven.scm.ScmFileSet;
+import org.apache.maven.scm.ScmTestCase;
+import org.apache.maven.scm.command.checkin.CheckInScmResult;
+import org.apache.maven.scm.command.checkout.CheckOutScmResult;
+import org.apache.maven.scm.provider.git.GitScmTestUtils;
+import org.apache.maven.scm.repository.ScmRepository;
+import org.codehaus.plexus.util.FileUtils;
+import org.junit.Test;
+
+import static org.junit.Assert.assertFalse;
+
+public class JGitCheckinCommandTest extends ScmTestCase {
Review Comment:
I would prefer having this test as part of the Git TCK so that it is
executed against both Git CLI and JGit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SCM-1022) jgit push failure is not failing the build
[
https://issues.apache.org/jira/browse/SCM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833914#comment-17833914
]
ASF GitHub Bot commented on SCM-1022:
-
michael-o commented on PR #203:
URL: https://github.com/apache/maven-scm/pull/203#issuecomment-2037067814
Looking into...
> jgit push failure is not failing the build
> --
>
> Key: SCM-1022
> URL: https://issues.apache.org/jira/browse/SCM-1022
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 2.0.1
>Reporter: Mattias Andersson
>Priority: Major
>
> If the push command fails, the maven build does not fail. This means binaries
> are deployed, but the remote repo is not updated. The issue seems related to
> SCM-854.
> We use Gerrit and have the merge strategy set to "fast forward only". If
> someone pushes a commit during the release job, only an INFO message is
> logged, but the maven build is successful.
> The same use case with the maven-scm-provider-gitexe (the default) fails the
> build as expected (git push returns a non-zero exit code)
> {code:java}
> 10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
> 10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
> 10:28:03 [INFO] fetch url: ssh://xxx@xxx
> 10:28:03 [INFO] push url: ssh://xxx@xxx
> 10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
> net.i2p.crypto.eddsa.EdDSASecurityProvider
> 10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
> Nio2ServiceFactoryFactory
> 10:28:04 [INFO] REJECTED_NONFASTFORWARD -
> RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
> 1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
> srcRef=refs/heads/master, message=null]
> 10:28:04 [INFO] 12/17 prepare:scm-tag
> 10:28:04 [INFO] Tagging release with the label 2.15.0...
> 10:28:04 [INFO] push tag [2.15.0] to remote...
> 10:28:04 [INFO] fetch url: ssh://xxx@xxx
> 10:28:04 [INFO] push url: ssh://xxx@xxx
> 10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
> ...968d97de8331ce19d43c719e870890def5ee65d9,
> fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SCM-1022] - jgit push failure is not failing the build [maven-scm]
michael-o commented on PR #203: URL: https://github.com/apache/maven-scm/pull/203#issuecomment-2037067814 Looking into... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SCM-1022) jgit push failure is not failing the build
[
https://issues.apache.org/jira/browse/SCM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833892#comment-17833892
]
Mattias Andersson commented on SCM-1022:
[~michael-o] we created the PR above. Any feedback would be appreciated.
> jgit push failure is not failing the build
> --
>
> Key: SCM-1022
> URL: https://issues.apache.org/jira/browse/SCM-1022
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 2.0.1
>Reporter: Mattias Andersson
>Priority: Major
>
> If the push command fails, the maven build does not fail. This means binaries
> are deployed, but the remote repo is not updated. The issue seems related to
> SCM-854.
> We use Gerrit and have the merge strategy set to "fast forward only". If
> someone pushes a commit during the release job, only an INFO message is
> logged, but the maven build is successful.
> The same use case with the maven-scm-provider-gitexe (the default) fails the
> build as expected (git push returns a non-zero exit code)
> {code:java}
> 10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
> 10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
> 10:28:03 [INFO] fetch url: ssh://xxx@xxx
> 10:28:03 [INFO] push url: ssh://xxx@xxx
> 10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
> net.i2p.crypto.eddsa.EdDSASecurityProvider
> 10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
> Nio2ServiceFactoryFactory
> 10:28:04 [INFO] REJECTED_NONFASTFORWARD -
> RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
> 1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
> srcRef=refs/heads/master, message=null]
> 10:28:04 [INFO] 12/17 prepare:scm-tag
> 10:28:04 [INFO] Tagging release with the label 2.15.0...
> 10:28:04 [INFO] push tag [2.15.0] to remote...
> 10:28:04 [INFO] fetch url: ssh://xxx@xxx
> 10:28:04 [INFO] push url: ssh://xxx@xxx
> 10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
> ...968d97de8331ce19d43c719e870890def5ee65d9,
> fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SCM-1022) jgit push failure is not failing the build
[
https://issues.apache.org/jira/browse/SCM-1022?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833889#comment-17833889
]
ASF GitHub Bot commented on SCM-1022:
-
attiand opened a new pull request, #203:
URL: https://github.com/apache/maven-scm/pull/203
(no comment)
> jgit push failure is not failing the build
> --
>
> Key: SCM-1022
> URL: https://issues.apache.org/jira/browse/SCM-1022
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-jgit
>Affects Versions: 2.0.1
>Reporter: Mattias Andersson
>Priority: Major
>
> If the push command fails, the maven build does not fail. This means binaries
> are deployed, but the remote repo is not updated. The issue seems related to
> SCM-854.
> We use Gerrit and have the merge strategy set to "fast forward only". If
> someone pushes a commit during the release job, only an INFO message is
> logged, but the maven build is successful.
> The same use case with the maven-scm-provider-gitexe (the default) fails the
> build as expected (git push returns a non-zero exit code)
> {code:java}
> 10:28:03 [INFO] commit done: [maven-release-plugin] prepare release 2.15.0
> 10:28:03 [INFO] push changes to remote... refs/heads/master:refs/heads/master
> 10:28:03 [INFO] fetch url: ssh://xxx@xxx
> 10:28:03 [INFO] push url: ssh://xxx@xxx
> 10:28:03 [INFO] getOrCreateProvider(EdDSA) created instance of
> net.i2p.crypto.eddsa.EdDSASecurityProvider
> 10:28:03 [INFO] No detected/configured IoServiceFactoryFactory using
> Nio2ServiceFactoryFactory
> 10:28:04 [INFO] REJECTED_NONFASTFORWARD -
> RemoteRefUpdate[remoteName=refs/heads/master, REJECTED_NONFASTFORWARD,
> 1eee06203068576ddcaae4eefe0ea15a52fb49ba...3102c82c6b62d4e86c75194569c2574ac722b6dd,
> srcRef=refs/heads/master, message=null]
> 10:28:04 [INFO] 12/17 prepare:scm-tag
> 10:28:04 [INFO] Tagging release with the label 2.15.0...
> 10:28:04 [INFO] push tag [2.15.0] to remote...
> 10:28:04 [INFO] fetch url: ssh://xxx@xxx
> 10:28:04 [INFO] push url: ssh://xxx@xxx
> 10:28:05 [INFO] OK - RemoteRefUpdate[remoteName=refs/tags/2.15.0, OK,
> ...968d97de8331ce19d43c719e870890def5ee65d9,
> fastForward, srcRef=refs/tags/2.15.0, message=null]{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MNG-8084) Make the v4 api usable outside the Maven runtime
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833888#comment-17833888 ] ASF GitHub Bot commented on MNG-8084: - gnodet opened a new pull request, #1465: URL: https://github.com/apache/maven/pull/1465 (no comment) > Make the v4 api usable outside the Maven runtime > > > Key: MNG-8084 > URL: https://issues.apache.org/jira/browse/MNG-8084 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Priority: Major > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-8091) Update Resolver to 2.0.0-alpha-10
[ https://issues.apache.org/jira/browse/MNG-8091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833885#comment-17833885 ] ASF GitHub Bot commented on MNG-8091: - gnodet merged PR #1460: URL: https://github.com/apache/maven/pull/1460 > Update Resolver to 2.0.0-alpha-10 > - > > Key: MNG-8091 > URL: https://issues.apache.org/jira/browse/MNG-8091 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (MNG-8091) Update Resolver to 2.0.0-alpha-10
[ https://issues.apache.org/jira/browse/MNG-8091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8091. Resolution: Fixed > Update Resolver to 2.0.0-alpha-10 > - > > Key: MNG-8091 > URL: https://issues.apache.org/jira/browse/MNG-8091 > Project: Maven > Issue Type: Dependency upgrade >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 4.0.0, 4.0.0-alpha-14 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8091] Update Resolver to 2.0.0-alpha-10 [maven]
gnodet merged PR #1460: URL: https://github.com/apache/maven/pull/1460 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MARTIFACT-60) artifact:3.5.0:check-buildplan is too chatty by default
[
https://issues.apache.org/jira/browse/MARTIFACT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833881#comment-17833881
]
Gary D. Gregory commented on MARTIFACT-60:
--
For a bit of context, I think that once a project opens itself up to patches
and PRs from the world at large, a CI should check everything, especially when
it is inexpensive.
> artifact:3.5.0:check-buildplan is too chatty by default
> ---
>
> Key: MARTIFACT-60
> URL: https://issues.apache.org/jira/browse/MARTIFACT-60
> Project: Maven Artifact Plugin
> Issue Type: Improvement
> Components: artifact:check-buildplan
>Affects Versions: 3.5.0, 3.5.1
> Environment: Apache Maven 3.9.6
> (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: C:\java\apache-maven-3.9.6
> Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program
> Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Gary D. Gregory
>Priority: Major
>
> Running the plugin is too chatty by default, for example, I don't need
> everything that's NOT wrong. Just tell me what's wrong or nothing:
> {noformat}
> [INFO] — artifact:3.5.0:check-buildplan (check-buildplan) @ commons-io —
> [INFO] no known issue with
> org.apache.maven.plugins:maven-enforcer-plugin:3.4.1
> [INFO] no known issue with org.apache.rat:apache-rat-plugin:0.16.1
> [INFO] no known issue with
> org.apache.maven.plugins:maven-artifact-plugin:3.5.0
> [INFO] no known issue with org.codehaus.mojo:build-helper-maven-plugin:3.5.0
> [INFO] no known issue with org.apache.maven.plugins:maven-antrun-plugin:3.1.0
> [INFO] no known issue with
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0 (>= 1.7.0)
> [INFO] no known issue with org.codehaus.mojo:buildnumber-maven-plugin:3.2.0
> [INFO] no known issue with
> org.apache.maven.plugins:maven-resources-plugin:3.3.1
> [INFO] no known issue with
> org.apache.maven.plugins:maven-compiler-plugin:3.13.0
> [INFO] no known issue with org.apache.felix:maven-bundle-plugin:5.1.9 (>=
> 5.1.9)
> [INFO] no known issue with org.jacoco:jacoco-maven-plugin:0.8.11
> [INFO] no known issue with
> org.apache.maven.plugins:maven-surefire-plugin:3.2.5
> [INFO] no known issue with org.apache.maven.plugins:maven-jar-plugin:3.3.0
> (>= 3.2.0)
> [INFO] no known issue with org.apache.maven.plugins:maven-site-plugin:3.12.1
> [INFO] no known issue with org.apache.maven.plugins:maven-source-plugin:3.2.1
> (>= 3.2.1)
> [INFO] no known issue with org.cyclonedx:cyclonedx-maven-plugin:2.8.0
> [INFO] no known issue with org.spdx:spdx-maven-plugin:0.7.3
> [INFO] no known issue with org.moditect:moditect-maven-plugin:1.2.1.Final (>=
> 1.0.0.Final)
> [INFO] no known issue with org.apache.maven.plugins:maven-install-plugin:3.1.1
> [INFO] no known issue with org.apache.maven.plugins:maven-deploy-plugin:3.1.1
> {noformat}
> Either say nothing or, if you must, perhaps a single log event:
> "No issues found in 16 plugins." Note that sentences should start with a
> capital letter.
> The current info would be fine at the debug logging level IMO.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MARTIFACT-59) artifact plugin should tolerate injected project.build.outputTimestamp
[
https://issues.apache.org/jira/browse/MARTIFACT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833855#comment-17833855
]
ASF GitHub Bot commented on MARTIFACT-59:
-
rmannibucau commented on PR #30:
URL:
https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2036447015
@hboutemy ok, so 1.2.1 is using a hardcoded value - so out of scope of this
PR - and 1.3.0-SNAPSHOT does use a placeholder (this PR case).
> artifact plugin should tolerate injected project.build.outputTimestamp
> --
>
> Key: MARTIFACT-59
> URL: https://issues.apache.org/jira/browse/MARTIFACT-59
> Project: Maven Artifact Plugin
> Issue Type: Improvement
>Reporter: Romain Manni-Bucau
>Priority: Minor
> Labels: pull-request-available
>
> Goal is to not log
> {code:java}
> Reproducible Build not activated by project.build.outputTimestamp property:
> see https://maven.apache.org/guides/mini/guide-reproducible-builds.html {code}
> when the project is actually set but computed from another property and not
> fail (check mojo) when the setup is the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MARTIFACT-59] tolerate injected timestamp value [maven-artifact-plugin]
rmannibucau commented on PR #30: URL: https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2036447015 @hboutemy ok, so 1.2.1 is using a hardcoded value - so out of scope of this PR - and 1.3.0-SNAPSHOT does use a placeholder (this PR case). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump slf4jVersion from 1.7.36 to 2.0.12 [maven-build-cache-extension]
dependabot[bot] opened a new pull request, #141: URL: https://github.com/apache/maven-build-cache-extension/pull/141 Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MARTIFACT-59) artifact plugin should tolerate injected project.build.outputTimestamp
[
https://issues.apache.org/jira/browse/MARTIFACT-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833831#comment-17833831
]
ASF GitHub Bot commented on MARTIFACT-59:
-
hboutemy commented on PR #30:
URL:
https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2036280952
yours: `[INFO] Building ModiTect Parent 1.3.0-SNAPSHOT
[1/8]`
mine: `[INFO] Building ModiTect Parent 1.2.1.Final
[1/8]`
> artifact plugin should tolerate injected project.build.outputTimestamp
> --
>
> Key: MARTIFACT-59
> URL: https://issues.apache.org/jira/browse/MARTIFACT-59
> Project: Maven Artifact Plugin
> Issue Type: Improvement
>Reporter: Romain Manni-Bucau
>Priority: Minor
> Labels: pull-request-available
>
> Goal is to not log
> {code:java}
> Reproducible Build not activated by project.build.outputTimestamp property:
> see https://maven.apache.org/guides/mini/guide-reproducible-builds.html {code}
> when the project is actually set but computed from another property and not
> fail (check mojo) when the setup is the same.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MARTIFACT-59] tolerate injected timestamp value [maven-artifact-plugin]
hboutemy commented on PR #30: URL: https://github.com/apache/maven-artifact-plugin/pull/30#issuecomment-2036280952 yours: `[INFO] Building ModiTect Parent 1.3.0-SNAPSHOT [1/8]` mine: `[INFO] Building ModiTect Parent 1.2.1.Final [1/8]` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MARTIFACT-60) artifact:3.5.0:check-buildplan is too chatty by default
[
https://issues.apache.org/jira/browse/MARTIFACT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Herve Boutemy updated MARTIFACT-60:
---
Affects Version/s: 3.5.1
> artifact:3.5.0:check-buildplan is too chatty by default
> ---
>
> Key: MARTIFACT-60
> URL: https://issues.apache.org/jira/browse/MARTIFACT-60
> Project: Maven Artifact Plugin
> Issue Type: Improvement
> Components: artifact:check-buildplan
>Affects Versions: 3.5.0, 3.5.1
> Environment: Apache Maven 3.9.6
> (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: C:\java\apache-maven-3.9.6
> Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program
> Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Gary D. Gregory
>Priority: Major
>
> Running the plugin is too chatty by default, for example, I don't need
> everything that's NOT wrong. Just tell me what's wrong or nothing:
> {noformat}
> [INFO] — artifact:3.5.0:check-buildplan (check-buildplan) @ commons-io —
> [INFO] no known issue with
> org.apache.maven.plugins:maven-enforcer-plugin:3.4.1
> [INFO] no known issue with org.apache.rat:apache-rat-plugin:0.16.1
> [INFO] no known issue with
> org.apache.maven.plugins:maven-artifact-plugin:3.5.0
> [INFO] no known issue with org.codehaus.mojo:build-helper-maven-plugin:3.5.0
> [INFO] no known issue with org.apache.maven.plugins:maven-antrun-plugin:3.1.0
> [INFO] no known issue with
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0 (>= 1.7.0)
> [INFO] no known issue with org.codehaus.mojo:buildnumber-maven-plugin:3.2.0
> [INFO] no known issue with
> org.apache.maven.plugins:maven-resources-plugin:3.3.1
> [INFO] no known issue with
> org.apache.maven.plugins:maven-compiler-plugin:3.13.0
> [INFO] no known issue with org.apache.felix:maven-bundle-plugin:5.1.9 (>=
> 5.1.9)
> [INFO] no known issue with org.jacoco:jacoco-maven-plugin:0.8.11
> [INFO] no known issue with
> org.apache.maven.plugins:maven-surefire-plugin:3.2.5
> [INFO] no known issue with org.apache.maven.plugins:maven-jar-plugin:3.3.0
> (>= 3.2.0)
> [INFO] no known issue with org.apache.maven.plugins:maven-site-plugin:3.12.1
> [INFO] no known issue with org.apache.maven.plugins:maven-source-plugin:3.2.1
> (>= 3.2.1)
> [INFO] no known issue with org.cyclonedx:cyclonedx-maven-plugin:2.8.0
> [INFO] no known issue with org.spdx:spdx-maven-plugin:0.7.3
> [INFO] no known issue with org.moditect:moditect-maven-plugin:1.2.1.Final (>=
> 1.0.0.Final)
> [INFO] no known issue with org.apache.maven.plugins:maven-install-plugin:3.1.1
> [INFO] no known issue with org.apache.maven.plugins:maven-deploy-plugin:3.1.1
> {noformat}
> Either say nothing or, if you must, perhaps a single log event:
> "No issues found in 16 plugins." Note that sentences should start with a
> capital letter.
> The current info would be fine at the debug logging level IMO.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MARTIFACT-60) artifact:3.5.0:check-buildplan is too chatty by default
[
https://issues.apache.org/jira/browse/MARTIFACT-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17833829#comment-17833829
]
Herve Boutemy commented on MARTIFACT-60:
I feel people bind this goal in their normal build lifecycle, in which case I
understand it is found very chatty
when I wrote it, this goal has been intended for CLI use, as checking on every
build does not make much sense to me: this goal was written to do the first
Reproducible Builds activation easily with fast CLI feedback and fix
easy-fixable issues in pom.xml immediately. Once it's done, remaining issues
are much more precise than just a plugin version: this goal won't help much any
more, only comparison and human dive into "why is there a difference?", with a
human brain to track root cause.
I'm not clear if we should fight the lifecycle bound approach: what I've learn
over time is that fighting users is a lost game, users are too many, it's much
easier to adapt a little bit when it's not hard = this case.
perhaps this is a natural expectation from users: I must admit that even in my
expected CLI usage, seeing a wide list of non-problems makes it hard to dive.
Making by default a summary and eventually a verbose option makes sense
(in addition, when I wrote the goal, "mvn builplan:list" was not well known, I
needed to show even to myself that this goal was filtering on this list:
nowadays, this goal is well know to everybody, my intent is probably not valid
any more)
+1 to do that
> artifact:3.5.0:check-buildplan is too chatty by default
> ---
>
> Key: MARTIFACT-60
> URL: https://issues.apache.org/jira/browse/MARTIFACT-60
> Project: Maven Artifact Plugin
> Issue Type: Improvement
> Components: artifact:check-buildplan
>Affects Versions: 3.5.0
> Environment: Apache Maven 3.9.6
> (bc0240f3c744dd6b6ec2920b3cd08dcc295161ae)
> Maven home: C:\java\apache-maven-3.9.6
> Java version: 17.0.8, vendor: Eclipse Adoptium, runtime: C:\Program
> Files\Eclipse Adoptium\jdk-17.0.8.7-hotspot
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Gary D. Gregory
>Priority: Major
>
> Running the plugin is too chatty by default, for example, I don't need
> everything that's NOT wrong. Just tell me what's wrong or nothing:
> {noformat}
> [INFO] — artifact:3.5.0:check-buildplan (check-buildplan) @ commons-io —
> [INFO] no known issue with
> org.apache.maven.plugins:maven-enforcer-plugin:3.4.1
> [INFO] no known issue with org.apache.rat:apache-rat-plugin:0.16.1
> [INFO] no known issue with
> org.apache.maven.plugins:maven-artifact-plugin:3.5.0
> [INFO] no known issue with org.codehaus.mojo:build-helper-maven-plugin:3.5.0
> [INFO] no known issue with org.apache.maven.plugins:maven-antrun-plugin:3.1.0
> [INFO] no known issue with
> org.apache.maven.plugins:maven-remote-resources-plugin:3.1.0 (>= 1.7.0)
> [INFO] no known issue with org.codehaus.mojo:buildnumber-maven-plugin:3.2.0
> [INFO] no known issue with
> org.apache.maven.plugins:maven-resources-plugin:3.3.1
> [INFO] no known issue with
> org.apache.maven.plugins:maven-compiler-plugin:3.13.0
> [INFO] no known issue with org.apache.felix:maven-bundle-plugin:5.1.9 (>=
> 5.1.9)
> [INFO] no known issue with org.jacoco:jacoco-maven-plugin:0.8.11
> [INFO] no known issue with
> org.apache.maven.plugins:maven-surefire-plugin:3.2.5
> [INFO] no known issue with org.apache.maven.plugins:maven-jar-plugin:3.3.0
> (>= 3.2.0)
> [INFO] no known issue with org.apache.maven.plugins:maven-site-plugin:3.12.1
> [INFO] no known issue with org.apache.maven.plugins:maven-source-plugin:3.2.1
> (>= 3.2.1)
> [INFO] no known issue with org.cyclonedx:cyclonedx-maven-plugin:2.8.0
> [INFO] no known issue with org.spdx:spdx-maven-plugin:0.7.3
> [INFO] no known issue with org.moditect:moditect-maven-plugin:1.2.1.Final (>=
> 1.0.0.Final)
> [INFO] no known issue with org.apache.maven.plugins:maven-install-plugin:3.1.1
> [INFO] no known issue with org.apache.maven.plugins:maven-deploy-plugin:3.1.1
> {noformat}
> Either say nothing or, if you must, perhaps a single log event:
> "No issues found in 16 plugins." Note that sentences should start with a
> capital letter.
> The current info would be fine at the debug logging level IMO.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
