Re: [PR] Adjustments in new API related to PathType [maven]
gnodet commented on code in PR #1501:
URL: https://github.com/apache/maven/pull/1501#discussion_r1590556633
##
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##
@@ -81,6 +81,24 @@ public interface Type extends ExtensibleEnum {
*/
String MODULAR_JAR = "modular-jar";
+/**
+ * Artifact type name for a JAR file that can be placed either on the
annotation processor class-path
+ * or module-path. The path (classes or modules) is chosen by the plugin,
possibly using heuristic rules.
+ */
+String PROCESSOR = "proc";
+
+/**
+ * Artifact type name for a JAR file to unconditionally place on the
annotation processor class-path.
+ * If the JAR is modular, its module information are ignored.
+ */
+String CLASSPATH_PROCESSOR = "classpath-proc";
+
+/**
+ * Artifact type name for a JAR file to unconditionally place on the
annotation processor module-path.
+ * If the JAR is not modular, then it is loaded by Java as an unnamed
module.
+ */
+String MODULAR_PROCESSOR = "modular-proc";
Review Comment:
`"modular-processor"` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Adjustments in new API related to PathType [maven]
gnodet commented on code in PR #1501:
URL: https://github.com/apache/maven/pull/1501#discussion_r1590556560
##
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##
@@ -81,6 +81,24 @@ public interface Type extends ExtensibleEnum {
*/
String MODULAR_JAR = "modular-jar";
+/**
+ * Artifact type name for a JAR file that can be placed either on the
annotation processor class-path
+ * or module-path. The path (classes or modules) is chosen by the plugin,
possibly using heuristic rules.
+ */
+String PROCESSOR = "proc";
+
+/**
+ * Artifact type name for a JAR file to unconditionally place on the
annotation processor class-path.
+ * If the JAR is modular, its module information are ignored.
+ */
+String CLASSPATH_PROCESSOR = "classpath-proc";
Review Comment:
`"classpath-processor"` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Adjustments in new API related to PathType [maven]
gnodet commented on code in PR #1501:
URL: https://github.com/apache/maven/pull/1501#discussion_r1590556427
##
api/maven-api-core/src/main/java/org/apache/maven/api/Type.java:
##
@@ -81,6 +81,24 @@ public interface Type extends ExtensibleEnum {
*/
String MODULAR_JAR = "modular-jar";
+/**
+ * Artifact type name for a JAR file that can be placed either on the
annotation processor class-path
+ * or module-path. The path (classes or modules) is chosen by the plugin,
possibly using heuristic rules.
+ */
+String PROCESSOR = "proc";
Review Comment:
Why not `"processor"` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-8084) Make the v4 api usable outside the Maven runtime
[ https://issues.apache.org/jira/browse/MNG-8084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843632#comment-17843632 ] ASF GitHub Bot commented on MNG-8084: - gnodet merged PR #1500: URL: https://github.com/apache/maven/pull/1500 > Make the v4 api usable outside the Maven runtime > > > Key: MNG-8084 > URL: https://issues.apache.org/jira/browse/MNG-8084 > Project: Maven > Issue Type: New Feature >Reporter: Guillaume Nodet >Assignee: Guillaume Nodet >Priority: Major > Fix For: 4.0.0, 4.0.0-beta-1 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-8084] add system properties to test [maven]
gnodet merged PR #1500: URL: https://github.com/apache/maven/pull/1500 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results
[ https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843631#comment-17843631 ] ASF GitHub Bot commented on MDEP-799: - monperrus commented on PR #325: URL: https://github.com/apache/maven-dependency-plugin/pull/325#issuecomment-209537 @pombredanne @elharo if we are able to drive to merge, we can put more effort on this PR. > improve mvn dependency:tree - add optional JSON output of the results > - > > Key: MDEP-799 > URL: https://issues.apache.org/jira/browse/MDEP-799 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: Zhenxu Ke >Priority: Major > > I'd like to add an output type JSON, will open a pull request soon -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MDEP-799] tree: add optional output type json [maven-dependency-plugin]
monperrus commented on PR #325: URL: https://github.com/apache/maven-dependency-plugin/pull/325#issuecomment-209537 @pombredanne @elharo if we are able to drive to merge, we can put more effort on this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.github.siom79.japicmp:japicmp-maven-plugin from 0.21.1 to 0.21.2 [maven-resolver]
dependabot[bot] opened a new pull request, #490: URL: https://github.com/apache/maven-resolver/pull/490 Bumps [com.github.siom79.japicmp:japicmp-maven-plugin](https://github.com/siom79/japicmp) from 0.21.1 to 0.21.2. Commits https://github.com/siom79/japicmp/commit/1d75ed7bf40136c50d810a3c3675e6bb7ad8ed8f;>1d75ed7 [maven-release-plugin] prepare release japicmp-base-0.21.2 https://github.com/siom79/japicmp/commit/317f2638c93bf639471b79e74e27965d8a148c6e;>317f263 Merge pull request https://redirect.github.com/siom79/japicmp/issues/397;>#397 from Billlynch/master https://github.com/siom79/japicmp/commit/7a235952659cb82687456bf6be225b4a9a8fa80a;>7a23595 remove formatting noise https://github.com/siom79/japicmp/commit/ac02dc88cc18dbf328e0fb5d7422d543b90687e5;>ac02dc8 refactor https://github.com/siom79/japicmp/commit/8a10b717347c0c7a96d1b5eb5b55a222d648d899;>8a10b71 fix: check changes in return types https://github.com/siom79/japicmp/commit/68727ed928502f0062cab4177eea6efe21c2e697;>68727ed [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/siom79/japicmp/compare/japicmp-base-0.21.1...japicmp-base-0.21.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.codehaus.modello:modello-maven-plugin from 2.3.0 to 2.4.0 [maven-parent]
dependabot[bot] opened a new pull request, #179: URL: https://github.com/apache/maven-parent/pull/179 Bumps [org.codehaus.modello:modello-maven-plugin](https://github.com/codehaus-plexus/modello) from 2.3.0 to 2.4.0. Release notes Sourced from https://github.com/codehaus-plexus/modello/releases;>org.codehaus.modello:modello-maven-plugin's releases. 2.4.0 New features and improvements Keep license structure (https://redirect.github.com/codehaus-plexus/modello/pull/440;>#440) https://github.com/cstamas;>@cstamas Support addition of license header to generated files (https://redirect.github.com/codehaus-plexus/modello/pull/437;>#437) https://github.com/cstamas;>@cstamas Make generated code - Java 8 based by default (https://redirect.github.com/codehaus-plexus/modello/pull/425;>#425) https://github.com/slachiewicz;>@slachiewicz threadsafety (https://redirect.github.com/codehaus-plexus/modello/pull/423;>#423) https://github.com/gnodet;>@gnodet Bug Fixes Revert snakeyaml to 1.33 (as 2.x is not fully compatible with 1.x) (https://redirect.github.com/codehaus-plexus/modello/pull/422;>#422) https://github.com/slachiewicz;>@slachiewicz Dependency updates Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 (https://redirect.github.com/codehaus-plexus/modello/pull/438;>#438) https://github.com/dependabot;>@dependabot Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 (https://redirect.github.com/codehaus-plexus/modello/pull/436;>#436) https://github.com/dependabot;>@dependabot Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1 (https://redirect.github.com/codehaus-plexus/modello/pull/433;>#433) https://github.com/dependabot;>@dependabot Bump com.fasterxml.woodstox:woodstox-core from 6.6.1 to 6.6.2 (https://redirect.github.com/codehaus-plexus/modello/pull/432;>#432) https://github.com/dependabot;>@dependabot Bump com.fasterxml.jackson:jackson-bom from 2.16.1 to 2.17.0 (https://redirect.github.com/codehaus-plexus/modello/pull/431;>#431) https://github.com/dependabot;>@dependabot Bump plexus.compiler.version from 2.14.2 to 2.15.0 (https://redirect.github.com/codehaus-plexus/modello/pull/430;>#430) https://github.com/dependabot;>@dependabot Bump org.codehaus.plexus:plexus from 16 to 17 (https://redirect.github.com/codehaus-plexus/modello/pull/428;>#428) https://github.com/dependabot;>@dependabot Bump com.fasterxml.woodstox:woodstox-core from 6.6.0 to 6.6.1 (https://redirect.github.com/codehaus-plexus/modello/pull/427;>#427) https://github.com/dependabot;>@dependabot Revert snakeyaml to 1.33 (as 2.x is not fully compatible with 1.x) (https://redirect.github.com/codehaus-plexus/modello/pull/422;>#422) https://github.com/slachiewicz;>@slachiewicz Commits https://github.com/codehaus-plexus/modello/commit/321c16e24877fb105ef76c4e9b384d37b9472f97;>321c16e [maven-release-plugin] prepare release modello-2.4.0 https://github.com/codehaus-plexus/modello/commit/d96892444607f5f57e058b96a72da1d99d5cb5c9;>d968924 Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 (https://redirect.github.com/codehaus-plexus/modello/issues/438;>#438) https://github.com/codehaus-plexus/modello/commit/18d2f87e347ae8a06000cdfdff02cbb952a6b979;>18d2f87 Keep license structure (https://redirect.github.com/codehaus-plexus/modello/issues/440;>#440) https://github.com/codehaus-plexus/modello/commit/c90d219fd200b6f0a6161e721d83d85cd21d8dfb;>c90d219 Support addition of license header to generated files (https://redirect.github.com/codehaus-plexus/modello/issues/437;>#437) https://github.com/codehaus-plexus/modello/commit/676f1045959cb9ca8dbe63ce09d167044d5a87ce;>676f104 Bump org.codehaus.plexus:plexus-utils from 4.0.0 to 4.0.1 https://github.com/codehaus-plexus/modello/commit/ef562b0e627f934dfbbf952cb9a52afd8f7b6122;>ef562b0 Bump org.apache.maven.plugins:maven-invoker-plugin from 3.6.0 to 3.6.1 https://github.com/codehaus-plexus/modello/commit/05305839f0438ebb3a0582cd4368161630b71f7a;>0530583 Bump com.fasterxml.woodstox:woodstox-core from 6.6.1 to 6.6.2 https://github.com/codehaus-plexus/modello/commit/f18ce44395d7baa9e00d95cd0063b3f70b0a2735;>f18ce44 Bump com.fasterxml.jackson:jackson-bom from 2.16.1 to 2.17.0 https://github.com/codehaus-plexus/modello/commit/630866303675ed71779a71118710dd54ad31c684;>6308663 Bump plexus.compiler.version from 2.14.2 to 2.15.0 https://github.com/codehaus-plexus/modello/commit/3403b18462c1d1843d9118839c032a37547a82dc;>3403b18 Drop redundant profile for spotless plugin Additional commits viewable in https://github.com/codehaus-plexus/modello/compare/modello-2.3.0...modello-2.4.0;>compare view [![Dependabot compatibility
[PR] Bump maven.plugin-tools.version from 3.12.0 to 3.13.0 [maven-mvnd]
dependabot[bot] opened a new pull request, #987: URL: https://github.com/apache/maven-mvnd/pull/987 Bumps `maven.plugin-tools.version` from 3.12.0 to 3.13.0. Updates `org.apache.maven.plugin-tools:maven-plugin-annotations` from 3.12.0 to 3.13.0 Commits https://github.com/apache/maven-plugin-tools/commit/7a9ba2adccd253185ee35fe9db0a2462a26d860a;>7a9ba2a [maven-release-plugin] prepare release maven-plugin-tools-3.13.0 https://github.com/apache/maven-plugin-tools/commit/789315b6958250c0e2e9291bb407a25fdd5112e3;>789315b [MPLUGIN-521] Nested types not properly extracted cause exception while gener... https://github.com/apache/maven-plugin-tools/commit/1fa18050144db3cf767a5ba8f5f48dbb451d1aa6;>1fa1805 [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of m... https://github.com/apache/maven-plugin-tools/commit/e746d9cc35cb03c03c61101d2b11f8247e6dcc82;>e746d9c [MPLUGIN-517] GoalRenderer renderParameterDetails() renders in wrong order https://github.com/apache/maven-plugin-tools/commit/af234c66cc1282e5c86262a20ba1b80b1c38b25e;>af234c6 [MPLUGIN-516] Bump asmVersion from 9.6 to 9.7 https://github.com/apache/maven-plugin-tools/commit/9fc1aaaed7f36460b8706339a04656901b7babec;>9fc1aaa [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.12.0...maven-plugin-tools-3.13.0;>compare view Updates `org.apache.maven.plugins:maven-plugin-plugin` from 3.12.0 to 3.13.0 Commits https://github.com/apache/maven-plugin-tools/commit/7a9ba2adccd253185ee35fe9db0a2462a26d860a;>7a9ba2a [maven-release-plugin] prepare release maven-plugin-tools-3.13.0 https://github.com/apache/maven-plugin-tools/commit/789315b6958250c0e2e9291bb407a25fdd5112e3;>789315b [MPLUGIN-521] Nested types not properly extracted cause exception while gener... https://github.com/apache/maven-plugin-tools/commit/1fa18050144db3cf767a5ba8f5f48dbb451d1aa6;>1fa1805 [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of m... https://github.com/apache/maven-plugin-tools/commit/e746d9cc35cb03c03c61101d2b11f8247e6dcc82;>e746d9c [MPLUGIN-517] GoalRenderer renderParameterDetails() renders in wrong order https://github.com/apache/maven-plugin-tools/commit/af234c66cc1282e5c86262a20ba1b80b1c38b25e;>af234c6 [MPLUGIN-516] Bump asmVersion from 9.6 to 9.7 https://github.com/apache/maven-plugin-tools/commit/9fc1aaaed7f36460b8706339a04656901b7babec;>9fc1aaa [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.12.0...maven-plugin-tools-3.13.0;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump io.takari.maven:takari-smart-builder from 0.6.5 to 0.6.6 [maven-mvnd]
dependabot[bot] opened a new pull request, #986: URL: https://github.com/apache/maven-mvnd/pull/986 Bumps [io.takari.maven:takari-smart-builder](https://github.com/takari/takari-smart-builder) from 0.6.5 to 0.6.6. Release notes Sourced from https://github.com/takari/takari-smart-builder/releases;>io.takari.maven:takari-smart-builder's releases. 0.6.6 What's Changed Update parent and deps by https://github.com/cstamas;>@cstamas in https://redirect.github.com/takari/takari-smart-builder/pull/55;>takari/takari-smart-builder#55 Full Changelog: https://github.com/takari/takari-smart-builder/compare/takari-smart-builder-0.6.5...takari-smart-builder-0.6.6;>https://github.com/takari/takari-smart-builder/compare/takari-smart-builder-0.6.5...takari-smart-builder-0.6.6 Commits https://github.com/takari/takari-smart-builder/commit/f59805f9c92f9831c93bdd7a6d052f51e8cd7f4d;>f59805f [maven-release-plugin] prepare release takari-smart-builder-0.6.6 https://github.com/takari/takari-smart-builder/commit/47c1bd1436e4ce55a872aeac6e4832a78ddfd30c;>47c1bd1 Update parent and deps (https://redirect.github.com/takari/takari-smart-builder/issues/55;>#55) https://github.com/takari/takari-smart-builder/commit/e79504f6a041b9fe628417ca55a793439fe2abb1;>e79504f Add blame ignore https://github.com/takari/takari-smart-builder/commit/1003c0fb8e5031cbf53812a201af74ad9443e3d0;>1003c0f Update README.md https://github.com/takari/takari-smart-builder/commit/68ea350cc2561f8105b820458a51bd215eb187d1;>68ea350 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/takari/takari-smart-builder/compare/takari-smart-builder-0.6.5...takari-smart-builder-0.6.6;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump com.google.guava:guava from 32.1.3-jre to 33.2.0-jre [maven-mvnd]
dependabot[bot] opened a new pull request, #985: URL: https://github.com/apache/maven-mvnd/pull/985 Bumps [com.google.guava:guava](https://github.com/google/guava) from 32.1.3-jre to 33.2.0-jre. Release notes Sourced from https://github.com/google/guava/releases;>com.google.guava:guava's releases. 33.2.0 Android users: Please test recent Guava versions If you know of Guava Android users who have not yet upgraded to at least release https://github.com/google/guava/releases/tag/v33.0.0;>33.0.0, please encourage them to upgrade, preferably to today's release, 33.2.0. These releases have begun adding Java 8+ APIs to guava-android. While we don't anticipate problems, we do anticipate that any unexpected problems could force a disruptive rollback. To minimize any disruption, we'd like to catch any such problems early. Please https://github.com/google/guava/issues/new?assignees=labels=type%3Ddefectprojects=template=bug_report.yaml;>let us know of any problems you encounter. Maven dependency groupIdcom.google.guava/groupId artifactIdguava/artifactId version33.2.0-jre/version !-- or, for Android: -- version33.2.0-android/version /dependency Jar files https://repo1.maven.org/maven2/com/google/guava/guava/33.2.0-jre/guava-33.2.0-jre.jar;>33.2.0-jre.jar https://repo1.maven.org/maven2/com/google/guava/guava/33.2.0-android/guava-33.2.0-android.jar;>33.2.0-android.jar Guava requires https://github.com/google/guava/wiki/UseGuavaInYourBuild#what-about-guavas-own-dependencies;>one runtime dependency, which you can download here: https://repo1.maven.org/maven2/com/google/guava/failureaccess/1.0.1/failureaccess-1.0.1.jar;>failureaccess-1.0.1.jar Javadoc https://guava.dev/releases/33.2.0-jre/api/docs/;>33.2.0-jre https://guava.dev/releases/33.2.0-android/api/docs/;>33.2.0-android JDiff https://guava.dev/releases/33.2.0-jre/api/diffs/;>33.2.0-jre vs. 33.1.0-jre https://guava.dev/releases/33.2.0-android/api/diffs/;>33.2.0-android vs. 33.1.0-android https://guava.dev/releases/33.2.0-android/api/androiddiffs/;>33.2.0-android vs. 33.2.0-jre Changelog Dropped testing for Android versions before Lollipop (API Level 21). Guava may stop working under older versions in the future, or it may have done so already. Fixed https://redirect.github.com/google/guava/issues/7134;>a GWT compilation breakage under Gradle. (858caf425c) collect: Made our Collector APIs (e.g., ImmutableList.toImmutableList()) available in guava-android. More https://redirect.github.com/google/guava/issues/6567;>Java 8 APIs will follow in future releases. (96fca0b747) As always, streams are available to Android code only when that code https://developer.android.com/studio/write/java8-support#library-desugaring;>enables library desugaring or targets a new enough API Level (https://developer.android.com/reference/java/util/stream/Stream;>24 (Nougat) for many stream APIs). (But note that we test only with library desugaring, so we don't https://redirect.github.com/google/guava/issues/7197;>currently know if API Level 24 is high enough to use our Collector APIs unless you have also enabled library desugaring.) Guava users who avoid the Collector APIs do not need to meet this requirement. collect: Fixed a potential NullPointerException in ImmutableMap.Builder on a rare code path. (70a98115d8) net: Added HttpHeaders constants Ad-Auction-Allowed, Permissions-Policy-Report-Only, and Sec-GPC. (7dc01ed27b, 41d0d9a833, 38c8017bd44b7919b112f1c99f3d8ce4b058ae5d) 33.1.0 Request for Android users ... (truncated) Commits See full diff in https://github.com/google/guava/commits;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is
[PR] Bump version.maven-plugin-tools from 3.12.0 to 3.13.0 [maven-apache-parent]
dependabot[bot] opened a new pull request, #223: URL: https://github.com/apache/maven-apache-parent/pull/223 Bumps `version.maven-plugin-tools` from 3.12.0 to 3.13.0. Updates `org.apache.maven.plugin-tools:maven-plugin-annotations` from 3.12.0 to 3.13.0 Commits https://github.com/apache/maven-plugin-tools/commit/7a9ba2adccd253185ee35fe9db0a2462a26d860a;>7a9ba2a [maven-release-plugin] prepare release maven-plugin-tools-3.13.0 https://github.com/apache/maven-plugin-tools/commit/789315b6958250c0e2e9291bb407a25fdd5112e3;>789315b [MPLUGIN-521] Nested types not properly extracted cause exception while gener... https://github.com/apache/maven-plugin-tools/commit/1fa18050144db3cf767a5ba8f5f48dbb451d1aa6;>1fa1805 [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of m... https://github.com/apache/maven-plugin-tools/commit/e746d9cc35cb03c03c61101d2b11f8247e6dcc82;>e746d9c [MPLUGIN-517] GoalRenderer renderParameterDetails() renders in wrong order https://github.com/apache/maven-plugin-tools/commit/af234c66cc1282e5c86262a20ba1b80b1c38b25e;>af234c6 [MPLUGIN-516] Bump asmVersion from 9.6 to 9.7 https://github.com/apache/maven-plugin-tools/commit/9fc1aaaed7f36460b8706339a04656901b7babec;>9fc1aaa [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.12.0...maven-plugin-tools-3.13.0;>compare view Updates `org.apache.maven.plugins:maven-plugin-plugin` from 3.12.0 to 3.13.0 Commits https://github.com/apache/maven-plugin-tools/commit/7a9ba2adccd253185ee35fe9db0a2462a26d860a;>7a9ba2a [maven-release-plugin] prepare release maven-plugin-tools-3.13.0 https://github.com/apache/maven-plugin-tools/commit/789315b6958250c0e2e9291bb407a25fdd5112e3;>789315b [MPLUGIN-521] Nested types not properly extracted cause exception while gener... https://github.com/apache/maven-plugin-tools/commit/1fa18050144db3cf767a5ba8f5f48dbb451d1aa6;>1fa1805 [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of m... https://github.com/apache/maven-plugin-tools/commit/e746d9cc35cb03c03c61101d2b11f8247e6dcc82;>e746d9c [MPLUGIN-517] GoalRenderer renderParameterDetails() renders in wrong order https://github.com/apache/maven-plugin-tools/commit/af234c66cc1282e5c86262a20ba1b80b1c38b25e;>af234c6 [MPLUGIN-516] Bump asmVersion from 9.6 to 9.7 https://github.com/apache/maven-plugin-tools/commit/9fc1aaaed7f36460b8706339a04656901b7babec;>9fc1aaa [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.12.0...maven-plugin-tools-3.13.0;>compare view Updates `org.apache.maven.plugins:maven-plugin-report-plugin` from 3.12.0 to 3.13.0 Commits https://github.com/apache/maven-plugin-tools/commit/7a9ba2adccd253185ee35fe9db0a2462a26d860a;>7a9ba2a [maven-release-plugin] prepare release maven-plugin-tools-3.13.0 https://github.com/apache/maven-plugin-tools/commit/789315b6958250c0e2e9291bb407a25fdd5112e3;>789315b [MPLUGIN-521] Nested types not properly extracted cause exception while gener... https://github.com/apache/maven-plugin-tools/commit/1fa18050144db3cf767a5ba8f5f48dbb451d1aa6;>1fa1805 [MPLUGIN-519][MPLUGIN-520] Parent POM 42, prerequisite of 3.6.3, get rid of m... https://github.com/apache/maven-plugin-tools/commit/e746d9cc35cb03c03c61101d2b11f8247e6dcc82;>e746d9c [MPLUGIN-517] GoalRenderer renderParameterDetails() renders in wrong order https://github.com/apache/maven-plugin-tools/commit/af234c66cc1282e5c86262a20ba1b80b1c38b25e;>af234c6 [MPLUGIN-516] Bump asmVersion from 9.6 to 9.7 https://github.com/apache/maven-plugin-tools/commit/9fc1aaaed7f36460b8706339a04656901b7babec;>9fc1aaa [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-plugin-tools/compare/maven-plugin-tools-3.12.0...maven-plugin-tools-3.13.0;>compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close
[PR] Bump org.apache.maven.reporting:maven-reporting-impl from 3.1.0 to 3.2.0 [maven-changelog-plugin]
dependabot[bot] opened a new pull request, #19: URL: https://github.com/apache/maven-changelog-plugin/pull/19 Bumps [org.apache.maven.reporting:maven-reporting-impl](https://github.com/apache/maven-reporting-impl) from 3.1.0 to 3.2.0. Commits https://github.com/apache/maven-reporting-impl/commit/967e756d41c00c123c5c545676b5bffd35918970;>967e756 [maven-release-plugin] prepare release maven-reporting-impl-3.2.0 https://github.com/apache/maven-reporting-impl/commit/ecf1b039a76a1b6eeda5e79e0885599e9e573cc8;>ecf1b03 [MSHARED-1099] Render with a skin when report is run in standalone mode https://github.com/apache/maven-reporting-impl/commit/df5e068b2db2945d3c8906fbb2e5bd01864c0e50;>df5e068 [MSHARED-1121] Upgrade plugins and components in project and ITs https://github.com/apache/maven-reporting-impl/commit/ae6a6d127b1a405bfb571811c47b9e30eb2eb5ed;>ae6a6d1 [MSHARED-1120] Upgrade Maven Reporting API to 3.1.1 https://github.com/apache/maven-reporting-impl/commit/b3f28da88871f961f50fd3b274773bb94252736c;>b3f28da Update CI URL https://github.com/apache/maven-reporting-impl/commit/bbddd4d800ce605316add4220b91ad33e5ae7557;>bbddd4d [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-reporting-impl/compare/maven-reporting-impl-3.1.0...maven-reporting-impl-3.2.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.reporting:maven-reporting-api from 3.1.0 to 3.1.1 [maven-changelog-plugin]
dependabot[bot] opened a new pull request, #18: URL: https://github.com/apache/maven-changelog-plugin/pull/18 Bumps [org.apache.maven.reporting:maven-reporting-api](https://github.com/apache/maven-reporting-api) from 3.1.0 to 3.1.1. Commits https://github.com/apache/maven-reporting-api/commit/d61224e3318f825673deee76eddc13a8a20be426;>d61224e [maven-release-plugin] prepare release maven-reporting-api-3.1.1 https://github.com/apache/maven-reporting-api/commit/f9adb8d7e6a2f31d4057e01643f4a535547ee6cc;>f9adb8d [MSHARED-1118] Restore binary compat for MavenReport (partially revert MSHARE... https://github.com/apache/maven-reporting-api/commit/63194dc13b0c2fe47114aebf3c0bf2dd9f04eb02;>63194dc Update CI URL https://github.com/apache/maven-reporting-api/commit/b12d9d97cab4d7603563e00fcdee0bf62ed4680d;>b12d9d9 Remove superfluous page https://github.com/apache/maven-reporting-api/commit/b93edcd4a7c1df031fa37cc69192c2bb1a1f9fa4;>b93edcd Shared GitHub actions v2 https://github.com/apache/maven-reporting-api/commit/e21ec0e35ce23fcb36b78b39bc6ebac971ae05fa;>e21ec0e [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-reporting-api/compare/maven-reporting-api-3.1.0...maven-reporting-api-3.1.1;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.codehaus.plexus:plexus-utils from 3.3.1 to 4.0.1 [maven-changelog-plugin]
dependabot[bot] opened a new pull request, #17: URL: https://github.com/apache/maven-changelog-plugin/pull/17 Bumps [org.codehaus.plexus:plexus-utils](https://github.com/codehaus-plexus/plexus-utils) from 3.3.1 to 4.0.1. Release notes Sourced from https://github.com/codehaus-plexus/plexus-utils/releases;>org.codehaus.plexus:plexus-utils's releases. 4.0.1 New features and improvements Add .gitignore to default excludes (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/269;>#269) https://github.com/slawekjaranowski;>@slawekjaranowski downgrade plexus-xml from 4 to 3: keep Maven 3 compatibility (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/263;>#263) https://github.com/hboutemy;>@hboutemy Dependency updates downgrade plexus-xml from 4 to 3: keep Maven 3 compatibility (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/263;>#263) https://github.com/hboutemy;>@hboutemy Bump org.codehaus.plexus:plexus from 13 to 17 (https://redirect.github.com/codehaus-plexus/plexus-utils/issues/262;>#262 https://redirect.github.com/codehaus-plexus/plexus-utils/issues/265;>#265 https://redirect.github.com/codehaus-plexus/plexus-utils/issues/266;>#266 https://redirect.github.com/codehaus-plexus/plexus-utils/issues/268;>#268) https://github.com/dependabot;>@dependabot Bump plexus-xml from 4.0.0 to 4.0.2 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/259;>#259) https://github.com/dependabot;>@dependabot Bump org.junit.jupiter:junit-jupiter from 5.9.2 to 5.10.0 (https://redirect.github.com/codehaus-plexus/plexus-utils/issues/251;>#251 https://redirect.github.com/codehaus-plexus/plexus-utils/issues/261;>#261) https://github.com/dependabot;>@dependabot Maintenance pom.mxl and site.xml cleanup (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/257;>#257) https://github.com/hboutemy;>@hboutemy Bump release-drafter/release-drafter from 5 to 6 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/267;>#267) https://github.com/dependabot;>@dependabot 4.0.0 Starting with version 4, XML classes (in org.codehaus.plexus.util.xml and org.codehaus.plexus.util.xml.pull) have been extracted to a separate https://github.com/codehaus-plexus/plexus-xml/;>plexus-xml 4: if you need them, just use this new artifact as outlined in https://codehaus-plexus.github.io/plexus-xml/dependency-info.html;>https://codehaus-plexus.github.io/plexus-xml/dependency-info.html. Fix false difference detected with CachingOutputStream/CachingWriter when streams are flushed (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/252;>#252) https://github.com/gnodet;>@gnodet Dependency updates Switch to junit 5 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/245;>#245) https://github.com/gnodet;>@gnodet Maintenance Switch to junit 5 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/245;>#245) https://github.com/gnodet;>@gnodet Remove unused/unmaintained jira export (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/247;>#247) https://github.com/gnodet;>@gnodet Switch build ci workflow to master branch (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/250;>#250) https://github.com/slachiewicz;>@slachiewicz Bump maven-resources-plugin from 2.7 to 3.3.1 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/209;>#209) https://github.com/dependabot;>@dependabot Fix SCM information (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/254;>#254) https://github.com/gnodet;>@gnodet Fix non contiguous imports (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/255;>#255) https://github.com/gnodet;>@gnodet 3.5.1 New features and improvements Reading and writing files using Java NIO (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/232;>#232) https://github.com/mkarg;>@mkarg Bug Fixes Partial revert of Support combine.self='remove' to fix MNG-7709 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/241;>#241) https://github.com/gnodet;>@gnodet Fix reading comments with UTF chars (fixes https://redirect.github.com/codehaus-plexus/plexus-utils/issues/238;>#238) (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/240;>#240) https://github.com/gnodet;>@gnodet Dependency updates Bump codehaus-plexus/.github from 0.0.1 to 0.0.4 (https://redirect.github.com/codehaus-plexus/plexus-utils/pull/237;>#237) https://github.com/dependabot;>@dependabot ... (truncated) Commits https://github.com/codehaus-plexus/plexus-utils/commit/31ef81812095709ebbfa0e4b707e1c3ad00a51e5;>31ef818 [maven-release-plugin] prepare release plexus-utils-4.0.1
Re: [PR] Adjustments in new API related to PathType [maven]
desruisseaux commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590440306 ## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ## @@ -18,6 +18,10 @@ */ package org.apache.maven.api; +import javax.tools.DocumentationTool; Review Comment: "Java" here refers to standard Java as defined by Oracle (other entities must use other names, e.g. "Jakarta"). The use of standard `javax.tools` API should not block non-standard Java tools to be added to this `JavaPathType` enumeration if desired, because `Location` is an interface with 2 non-default methods easy to implement (`getName()` and `isOutputLocation()`), and the proposed `JavaPathType.location()` property is `Optional` anyway. The close connection to `javax.tools` API may actually be desirable because contrarily to other API, `javax.tools` is updated immediately when new Java features requires compiler changes. For example, `javax.tools` has been updated in Java 9 with the addition of new methods specific to modules management. By contrast, Maven and the Plexus compiler did not really reflected that evolution as far as I can see. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adjustments in new API related to PathType [maven]
desruisseaux commented on code in PR #1501:
URL: https://github.com/apache/maven/pull/1501#discussion_r1590433117
##
api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java:
##
@@ -63,16 +75,17 @@ public enum JavaPathType implements PathType {
* class-path.
*
*/
-CLASSES("--class-path"),
+CLASSES(StandardLocation.CLASS_PATH, "--class-path"),
Review Comment:
The presence or not of this string depends on the [comment
below](https://github.com/apache/maven/pull/1501#discussion_r1590432486).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Adjustments in new API related to PathType [maven]
desruisseaux commented on code in PR #1501:
URL: https://github.com/apache/maven/pull/1501#discussion_r1590432902
##
api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java:
##
@@ -187,31 +247,38 @@ public Optional option() {
*
* @param paths the path to format as a tool option
* @return the option associated to this path type followed by the given
path elements,
- * or an empty string if there is no path element
+ * or an empty array if there is no path element
* @throws IllegalStateException if no option is associated to this path
type
*/
@Nonnull
@Override
-public String option(Iterable paths) {
+public String[] option(Iterable paths) {
Review Comment:
The presence or not of this method depends on the [comment
below](https://github.com/apache/maven/pull/1501#discussion_r1590432486).
##
api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java:
##
@@ -187,31 +247,38 @@ public Optional option() {
*
* @param paths the path to format as a tool option
* @return the option associated to this path type followed by the given
path elements,
- * or an empty string if there is no path element
+ * or an empty array if there is no path element
* @throws IllegalStateException if no option is associated to this path
type
*/
@Nonnull
@Override
-public String option(Iterable paths) {
+public String[] option(Iterable paths) {
return format(null, paths);
}
/**
* Implementation shared with {@link Modular}.
*/
-String format(String moduleName, Iterable paths) {
+final String[] format(String moduleName, Iterable paths) {
Review Comment:
The presence or not of this method depends on the [comment
below](https://github.com/apache/maven/pull/1501#discussion_r1590432486).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Adjustments in new API related to PathType [maven]
desruisseaux commented on code in PR #1501:
URL: https://github.com/apache/maven/pull/1501#discussion_r1590432486
##
api/maven-api-core/src/main/java/org/apache/maven/api/PathType.java:
##
@@ -94,23 +94,24 @@ public String option(Iterable paths) {
* The path elements are separated by an option-specific or
platform-specific separator.
* If the given {@code paths} argument contains no element, then this
method returns an empty string.
*
- * Examples:
- * If {@code paths} is a list containing two elements, {@code path1} and
{@code path2}, then:
- *
+ * Examples
+ * If {@code paths} is a list containing two elements, {@code dir/path1}
and {@code dir/path2}, then:
+ *
*
* If this type is {@link JavaPathType#MODULES}, then this method
returns
- * {@code "--module-path path1:path2"} on Unix or {@code
"--module-path path1;path2"} on Windows.
+ * {@code {"--module-path", "dir/path1:dir/path2"}} on Unix or
+ * {@code {"--module-path", "dir\path1;dir\path2"}} on Windows.
* If this type was created by {@code
JavaPathType.patchModule("foo.bar")}, then the method returns
- * {@code "--patch-module foo.bar=path1:path2"} on Unix or {@code
"--patch-module foo.bar=path1;path2"}
- * on Windows.
+ * {@code {"--patch-module", "foo.bar=dir/path1:dir/path2"}} on Unix
or
+ * {@code {"--patch-module", "foo.bar=dir\path1;dir\path2"}} on
Windows.
*
*
* @param paths the path to format as a string
* @return the option associated to this path type followed by the given
path elements,
- * or an empty string if there is no path element.
+ * or an empty array if there is no path element.
*/
@Nonnull
-String option(Iterable paths);
+String[] option(Iterable paths);
Review Comment:
The method is proposed here for two reasons: code reuse, and because the
method behaviour depends on the option rather than the plugin using it.
### Code reuse
The use of this method would be shared by many plugins. For example, the
same `--class-path` option is used by `java`, `javac`, `javadoc`, `javap`,
`jdeprscan`, `jdeps`, `jmod` and `jshell`. In current Maven architecture, those
tools are handled by independent plugins. This method reduces the need to
repeat the same code in all plugins.
**Note:** this strategy relies on Oracle using consistently the same option
names for all tools. It seems to be the case for all tools except `serialver`,
provided that we use the modern form (e.g. `--class-path` instead of `-cp`).
### Who defines the behaviour
The behaviour of this method depends on the option rather than the plugin.
For example, `JavaPathType.CLASSES` formats the given list of files as
`--class-path `. But `JavaPathType.patchModule("org.my.module")`
formats the same list of files as `--patch-module org.my.module=`.
This rule is applied consistently in at least `java`, `javac` and `javadoc`. As
we can see, the actual work done by this method is determined by the option,
not by the plugin, which is why the method appears in `PathType`: for allowing
the implementation to be option-dependent.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Created] (MSHARED-1392) Upgrade to Parent 42
Michael Osipov created MSHARED-1392: --- Summary: Upgrade to Parent 42 Key: MSHARED-1392 URL: https://issues.apache.org/jira/browse/MSHARED-1392 Project: Maven Shared Components Issue Type: Dependency upgrade Components: maven-reporting-api, maven-reporting-exec, maven-reporting-impl Reporter: Michael Osipov Assignee: Michael Osipov Fix For: maven-reporting-impl-4.0.0-M15, maven-reporting-exec-2.0.0-M14, maven-reporting-api-4.0.0, maven-reporting-impl-4.0.0, maven-reporting-exec-2.0.0, maven-reporting-api-4.0.0-M12 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Closed] (DOXIA-736) Upgrade to Parent 42
[ https://issues.apache.org/jira/browse/DOXIA-736?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov closed DOXIA-736. Resolution: Fixed Fixed with [11c6a53f9308848813fa09ce4a7d111ce2e75ee0|https://gitbox.apache.org/repos/asf?p=maven-doxia.git;a=commit;h=11c6a53f9308848813fa09ce4a7d111ce2e75ee0]. > Upgrade to Parent 42 > > > Key: DOXIA-736 > URL: https://issues.apache.org/jira/browse/DOXIA-736 > Project: Maven Doxia > Issue Type: Dependency upgrade >Reporter: Michael Osipov >Assignee: Michael Osipov >Priority: Major > Fix For: 2.0.0, 2.0.0-M11 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (DOXIA-736) Upgrade to Parent 42
Michael Osipov created DOXIA-736: Summary: Upgrade to Parent 42 Key: DOXIA-736 URL: https://issues.apache.org/jira/browse/DOXIA-736 Project: Maven Doxia Issue Type: Dependency upgrade Reporter: Michael Osipov Assignee: Michael Osipov Fix For: 2.0.0, 2.0.0-M11 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.codehaus.plexus:plexus-cipher from 2.0 to 2.1.0 [maven-release]
dependabot[bot] commented on PR #199: URL: https://github.com/apache/maven-release/pull/199#issuecomment-2094921933 OK, I won't notify you about org.codehaus.plexus:plexus-cipher again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-cipher from 2.0 to 2.1.0 [maven-release]
dependabot[bot] closed pull request #199: Bump org.codehaus.plexus:plexus-cipher from 2.0 to 2.1.0 URL: https://github.com/apache/maven-release/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-cipher from 2.0 to 2.1.0 [maven-release]
slachiewicz commented on PR #199: URL: https://github.com/apache/maven-release/pull/199#issuecomment-2094921921 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MANTRUN-239) Update parent pom to 42
[ https://issues.apache.org/jira/browse/MANTRUN-239?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MANTRUN-239: - Summary: Update parent pom to 42 (was: Update parent pom to 41) > Update parent pom to 42 > --- > > Key: MANTRUN-239 > URL: https://issues.apache.org/jira/browse/MANTRUN-239 > Project: Maven Antrun Plugin > Issue Type: Dependency upgrade >Reporter: Elliotte Rusty Harold >Assignee: Sylwester Lachiewicz >Priority: Major > Fix For: 3.2.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.apache.maven.plugins:maven-plugins from 41 to 42 [maven-antrun-plugin]
slachiewicz merged PR #96: URL: https://github.com/apache/maven-antrun-plugin/pull/96 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSITE-1000:
--
Description:
Currently only the attributes used for rendering the site can be parameterized
in
https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
There is no possibility to configure the parser in
https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
per document.
This would be nice in the context of
https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
should be switched on/off for certain documents. Also generation of comments
may be desirable for certain documents.
I propose the following additional plugin goal parameter:
{code}
**/apt/**
false
true
{code}
where {{parserConfigurations}} is an array of a complex type with (include)
patterns on the source path (String array) and boolean methods for features.
This also required an upgrade to Maven Plugin Tools 3.13.0.
was:
Currently only the attributes used for rendering the site can be parameterized
in
https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
There is no possibility to configure the parser in
https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
per document.
This would be nice in the context of
https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
should be switched on/off for certain documents. Also generation of comments
may be desirable for certain documents.
I propose the following additional plugin goal parameter:
{code}
**/apt/**
false
true
{code}
where {{parserConfigurations}} is an array of a complex type with (include)
patterns on the source path (String array) and boolean methods for features.
This also required an upgrade to Maven Plugin Tools 3.13.0
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
> Components: doxia integration
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
> This also required an upgrade to Maven Plugin Tools 3.13.0.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Updated] (MSITE-1000) Allow parametrisation of Doxia parser per file
[
https://issues.apache.org/jira/browse/MSITE-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MSITE-1000:
--
Description:
Currently only the attributes used for rendering the site can be parameterized
in
https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
There is no possibility to configure the parser in
https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
per document.
This would be nice in the context of
https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
should be switched on/off for certain documents. Also generation of comments
may be desirable for certain documents.
I propose the following additional plugin goal parameter:
{code}
**/apt/**
false
true
{code}
where {{parserConfigurations}} is an array of a complex type with (include)
patterns on the source path (String array) and boolean methods for features.
This also required an upgrade to Maven Plugin Tools 3.13.0
was:
Currently only the attributes used for rendering the site can be parameterized
in
https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
There is no possibility to configure the parser in
https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
per document.
This would be nice in the context of
https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
should be switched on/off for certain documents. Also generation of comments
may be desirable for certain documents.
I propose the following additional plugin goal parameter:
{code}
**/apt/**
false
true
{code}
where {{parserConfigurations}} is an array of a complex type with (include)
patterns on the source path (String array) and boolean methods for features.
> Allow parametrisation of Doxia parser per file
> --
>
> Key: MSITE-1000
> URL: https://issues.apache.org/jira/browse/MSITE-1000
> Project: Maven Site Plugin
> Issue Type: New Feature
> Components: doxia integration
>Reporter: Konrad Windszus
>Assignee: Konrad Windszus
>Priority: Major
>
> Currently only the attributes used for rendering the site can be
> parameterized in
> https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#attributes.
> There is no possibility to configure the parser in
> https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-site-renderer/src/main/java/org/apache/maven/doxia/siterenderer/DefaultSiteRenderer.java#L322
> per document.
> This would be nice in the context of
> https://issues.apache.org/jira/browse/DOXIA-722 where generation of anchors
> should be switched on/off for certain documents. Also generation of comments
> may be desirable for certain documents.
> I propose the following additional plugin goal parameter:
> {code}
>
>
>
> **/apt/**
>
> false
> true
>
>
> {code}
> where {{parserConfigurations}} is an array of a complex type with (include)
> patterns on the source path (String array) and boolean methods for features.
>
> This also required an upgrade to Maven Plugin Tools 3.13.0
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Bump version.xmlunit from 2.9.1 to 2.10.0 [maven-antrun-plugin]
dependabot[bot] commented on PR #97: URL: https://github.com/apache/maven-antrun-plugin/pull/97#issuecomment-2094915357 OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump version.xmlunit from 2.9.1 to 2.10.0 [maven-antrun-plugin]
slachiewicz closed pull request #97: Bump version.xmlunit from 2.9.1 to 2.10.0 URL: https://github.com/apache/maven-antrun-plugin/pull/97 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.xmlunit:xmlunit-core from 2.9.1 to 2.10.0 [maven-antrun-plugin]
slachiewicz merged PR #98: URL: https://github.com/apache/maven-antrun-plugin/pull/98 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adjustments in new API related to PathType [maven]
gnodet commented on code in PR #1501:
URL: https://github.com/apache/maven/pull/1501#discussion_r1590366917
##
api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java:
##
@@ -63,16 +75,17 @@ public enum JavaPathType implements PathType {
* class-path.
*
*/
-CLASSES("--class-path"),
+CLASSES(StandardLocation.CLASS_PATH, "--class-path"),
Review Comment:
Is the `option` string still useful ? That looks really redundant and
specific to tool implementations. Can we only keep the `StandardLocation` ?
##
api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java:
##
@@ -40,6 +44,13 @@
* Path types are often exclusive. For example, a dependency should not be
both on the Java class-path
* and on the Java module-path.
*
+ * Relationship with Java compiler standard location
+ * This enumeration is closely related to the {@link JavaFileManager.Location}
enumerations.
+ * A difference is that the latter enumerate input and output files, while
{@code JavaPathType}
+ * enumerates only input dependencies. Another difference is that {@code
JavaPathType} contains
+ * some enumeration values used only at runtime and therefor not available in
{@code javax.tool},
Review Comment:
therefor -> therefore
##
api/maven-api-core/src/main/java/org/apache/maven/api/PathType.java:
##
@@ -94,23 +94,24 @@ public String option(Iterable paths) {
* The path elements are separated by an option-specific or
platform-specific separator.
* If the given {@code paths} argument contains no element, then this
method returns an empty string.
*
- * Examples:
- * If {@code paths} is a list containing two elements, {@code path1} and
{@code path2}, then:
- *
+ * Examples
+ * If {@code paths} is a list containing two elements, {@code dir/path1}
and {@code dir/path2}, then:
+ *
*
* If this type is {@link JavaPathType#MODULES}, then this method
returns
- * {@code "--module-path path1:path2"} on Unix or {@code
"--module-path path1;path2"} on Windows.
+ * {@code {"--module-path", "dir/path1:dir/path2"}} on Unix or
+ * {@code {"--module-path", "dir\path1;dir\path2"}} on Windows.
* If this type was created by {@code
JavaPathType.patchModule("foo.bar")}, then the method returns
- * {@code "--patch-module foo.bar=path1:path2"} on Unix or {@code
"--patch-module foo.bar=path1;path2"}
- * on Windows.
+ * {@code {"--patch-module", "foo.bar=dir/path1:dir/path2"}} on Unix
or
+ * {@code {"--patch-module", "foo.bar=dir\path1;dir\path2"}} on
Windows.
*
*
* @param paths the path to format as a string
* @return the option associated to this path type followed by the given
path elements,
- * or an empty string if there is no path element.
+ * or an empty array if there is no path element.
*/
@Nonnull
-String option(Iterable paths);
+String[] option(Iterable paths);
Review Comment:
I wonder if this method should be moved out of the API.
##
api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java:
##
@@ -187,31 +247,38 @@ public Optional option() {
*
* @param paths the path to format as a tool option
* @return the option associated to this path type followed by the given
path elements,
- * or an empty string if there is no path element
+ * or an empty array if there is no path element
* @throws IllegalStateException if no option is associated to this path
type
*/
@Nonnull
@Override
-public String option(Iterable paths) {
+public String[] option(Iterable paths) {
return format(null, paths);
}
/**
* Implementation shared with {@link Modular}.
*/
-String format(String moduleName, Iterable paths) {
+final String[] format(String moduleName, Iterable paths) {
Review Comment:
I wonder if this method should be moved out of the API.
##
api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java:
##
@@ -40,6 +44,13 @@
* Path types are often exclusive. For example, a dependency should not be
both on the Java class-path
* and on the Java module-path.
*
+ * Relationship with Java compiler standard location
+ * This enumeration is closely related to the {@link JavaFileManager.Location}
enumerations.
+ * A difference is that the latter enumerate input and output files, while
{@code JavaPathType}
Review Comment:
enumerate -> enumerates
##
api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java:
##
@@ -187,31 +247,38 @@ public Optional option() {
*
* @param paths the path to format as a tool option
* @return the option associated to this path type followed by the given
path elements,
-
[jira] [Created] (MCOMPILER-591) testCompile wrong detects target less that 1.9 if provided as 8
Slawomir Jaranowski created MCOMPILER-591:
-
Summary: testCompile wrong detects target less that 1.9 if
provided as 8
Key: MCOMPILER-591
URL: https://issues.apache.org/jira/browse/MCOMPILER-591
Project: Maven Compiler Plugin
Issue Type: Bug
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
Fix For: next-release
When we provide target as *8* testCompile wrong detect that is less than
{*}1.9/9{*}.
Method is used to detect if should use modulepath when module descriptor is
present in main code.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Closed] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration
[ https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MCOMPILER-588. - Fix Version/s: next-release Resolution: Fixed > JUnit4 test framework to JUnit5 migration > - > > Key: MCOMPILER-588 > URL: https://issues.apache.org/jira/browse/MCOMPILER-588 > Project: Maven Compiler Plugin > Issue Type: Improvement >Reporter: Mikhail Deviatov >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: next-release > > > We have JUnit5 test framework for a long time. > It have modular architecture, good support in IDE and quite fast. It would be > good to add support JUnit5 to the project. > The problem is that there are 2 library used for testing in project > *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both > don't have JUnit5 support. > I created a solution that overrides parts of code used derived and my own > implementation. > Please take a look at it > https://github.com/apache/maven-compiler-plugin/pull/233 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration
[ https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843577#comment-17843577 ] ASF GitHub Bot commented on MCOMPILER-588: -- slawekjaranowski merged PR #236: URL: https://github.com/apache/maven-compiler-plugin/pull/236 > JUnit4 test framework to JUnit5 migration > - > > Key: MCOMPILER-588 > URL: https://issues.apache.org/jira/browse/MCOMPILER-588 > Project: Maven Compiler Plugin > Issue Type: Improvement >Reporter: Mikhail Deviatov >Assignee: Slawomir Jaranowski >Priority: Major > > We have JUnit5 test framework for a long time. > It have modular architecture, good support in IDE and quite fast. It would be > good to add support JUnit5 to the project. > The problem is that there are 2 library used for testing in project > *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both > don't have JUnit5 support. > I created a solution that overrides parts of code used derived and my own > implementation. > Please take a look at it > https://github.com/apache/maven-compiler-plugin/pull/233 -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MCOMPILER-588] JUnit4 test framework to JUnit5 migration [maven-compiler-plugin]
slawekjaranowski merged PR #236: URL: https://github.com/apache/maven-compiler-plugin/pull/236 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Adjustments in new API related to PathType [maven]
rmannibucau commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590346155 ## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ## @@ -18,6 +18,10 @@ */ package org.apache.maven.api; +import javax.tools.DocumentationTool; Review Comment: Ok for me if the name reflects it so something like JavaxToolPathType - or whatever makes it explicit. JavaPathType is way more generic IMHO. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (MCOMPILER-590) Upgrade Parent to 42
Slawomir Jaranowski created MCOMPILER-590: - Summary: Upgrade Parent to 42 Key: MCOMPILER-590 URL: https://issues.apache.org/jira/browse/MCOMPILER-590 Project: Maven Compiler Plugin Issue Type: Dependency upgrade Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: next-release -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MINVOKER-366) Require Maven 3.6.3
[ https://issues.apache.org/jira/browse/MINVOKER-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843566#comment-17843566 ] ASF GitHub Bot commented on MINVOKER-366: - slawekjaranowski opened a new pull request, #238: URL: https://github.com/apache/maven-invoker-plugin/pull/238 https://issues.apache.org/jira/browse/MINVOKER-366 > Require Maven 3.6.3 > --- > > Key: MINVOKER-366 > URL: https://issues.apache.org/jira/browse/MINVOKER-366 > Project: Maven Invoker Plugin > Issue Type: Improvement >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: 3.7.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Adjustments in new API related to PathType [maven]
desruisseaux commented on code in PR #1501: URL: https://github.com/apache/maven/pull/1501#discussion_r1590282082 ## api/maven-api-core/src/main/java/org/apache/maven/api/JavaPathType.java: ## @@ -18,6 +18,10 @@ */ package org.apache.maven.api; +import javax.tools.DocumentationTool; Review Comment: The generic API is the `PathType` interface. This dependency appears in th `JavaPathType` enumeration, which is the specialization for the Java tools. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1390) Deprecate InvocationRequest#setGoals
[ https://issues.apache.org/jira/browse/MSHARED-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843558#comment-17843558 ] ASF GitHub Bot commented on MSHARED-1390: - slawekjaranowski merged PR #76: URL: https://github.com/apache/maven-invoker/pull/76 > Deprecate InvocationRequest#setGoals > > > Key: MSHARED-1390 > URL: https://issues.apache.org/jira/browse/MSHARED-1390 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-invoker >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-invoker-3.3.0 > > > We should avoid parsing command line arguments. > Raw arguments should be used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
slawekjaranowski merged PR #76: URL: https://github.com/apache/maven-invoker/pull/76 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-335) Symlinks from source project are copied as file
[
https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843557#comment-17843557
]
ASF GitHub Bot commented on MINVOKER-335:
-
slawekjaranowski merged PR #237:
URL: https://github.com/apache/maven-invoker-plugin/pull/237
> Symlinks from source project are copied as file
> ---
>
> Key: MINVOKER-335
> URL: https://issues.apache.org/jira/browse/MINVOKER-335
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Source project:
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:26 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:27 testDirLink -> testDir
> lrwxr-xr-x 1 xxx 8 May 1 19:29 testLink.txt -> test.txt
> {noformat}
> after copy in {{target/it/..}}
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:30 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:30 testDirLink -> testDir
> -rw-r--r-- 1 xxx 40 May 1 18:44 testLink.txt
> {noformat}
> symlinks for directory are preserved only symlinks for file are broken
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MINVOKER-335] Use selector script for preparing test with symlinks [maven-invoker-plugin]
slawekjaranowski merged PR #237: URL: https://github.com/apache/maven-invoker-plugin/pull/237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1391) Code cleanups
[ https://issues.apache.org/jira/browse/MSHARED-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843556#comment-17843556 ] ASF GitHub Bot commented on MSHARED-1391: - slawekjaranowski opened a new pull request, #78: URL: https://github.com/apache/maven-invoker/pull/78 (no comment) > Code cleanups > - > > Key: MSHARED-1391 > URL: https://issues.apache.org/jira/browse/MSHARED-1391 > Project: Maven Shared Components > Issue Type: Task > Components: maven-invoker >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-invoker-3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MSHARED-1391) Code cleanups
Slawomir Jaranowski created MSHARED-1391: Summary: Code cleanups Key: MSHARED-1391 URL: https://issues.apache.org/jira/browse/MSHARED-1391 Project: Maven Shared Components Issue Type: Task Components: maven-invoker Reporter: Slawomir Jaranowski Assignee: Slawomir Jaranowski Fix For: maven-invoker-3.3.0 -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1390) Deprecate InvocationRequest#setGoals
[
https://issues.apache.org/jira/browse/MSHARED-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843552#comment-17843552
]
ASF GitHub Bot commented on MSHARED-1390:
-
slawekjaranowski commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590274270
##
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+@Override
+public InvocationRequest addArgs(Collection args) {
+args.stream().filter(arg ->
!StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
ok, such those are new methods we can simplify it
> Deprecate InvocationRequest#setGoals
>
>
> Key: MSHARED-1390
> URL: https://issues.apache.org/jira/browse/MSHARED-1390
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-invoker-3.3.0
>
>
> We should avoid parsing command line arguments.
> Raw arguments should be used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
slawekjaranowski commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590274270
##
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+@Override
+public InvocationRequest addArgs(Collection args) {
+args.stream().filter(arg ->
!StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
ok, such those are new methods we can simplify it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MDEP-923) Code cleanups
[
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843550#comment-17843550
]
ASF GitHub Bot commented on MDEP-923:
-
slawekjaranowski opened a new pull request, #388:
URL: https://github.com/apache/maven-dependency-plugin/pull/388
(no comment)
> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
> Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
> * cleanup pom after update to 42
> * exclude transitive dependencies on org.apache.maven
> * add {{@project.version@}} in ITs
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MINVOKER-335) Symlinks from source project are copied as file
[
https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843549#comment-17843549
]
ASF GitHub Bot commented on MINVOKER-335:
-
slawekjaranowski commented on code in PR #237:
URL:
https://github.com/apache/maven-invoker-plugin/pull/237#discussion_r1590271101
##
src/it/MINVOKER-335-symlinks-in-source/selector.groovy:
##
@@ -28,7 +28,12 @@ def testFile = projectPath.resolve('test.txt')
Files.createDirectory(testDir)
Files.createFile(testFile)
-Files.createSymbolicLink(projectPath.resolve('testDirLink'),
Paths.get('testDir'))
-Files.createSymbolicLink(projectPath.resolve('testLink.txt'),
Paths.get('test.txt'))
+// if FS not supports symlinks - we should skip test
Review Comment:
done
> Symlinks from source project are copied as file
> ---
>
> Key: MINVOKER-335
> URL: https://issues.apache.org/jira/browse/MINVOKER-335
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Source project:
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:26 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:27 testDirLink -> testDir
> lrwxr-xr-x 1 xxx 8 May 1 19:29 testLink.txt -> test.txt
> {noformat}
> after copy in {{target/it/..}}
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:30 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:30 testDirLink -> testDir
> -rw-r--r-- 1 xxx 40 May 1 18:44 testLink.txt
> {noformat}
> symlinks for directory are preserved only symlinks for file are broken
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1152) Switch project unit tests to JUnit 5
[ https://issues.apache.org/jira/browse/MSHARED-1152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843548#comment-17843548 ] ASF GitHub Bot commented on MSHARED-1152: - slawekjaranowski opened a new pull request, #77: URL: https://github.com/apache/maven-invoker/pull/77 small cosmetics > Switch project unit tests to JUnit 5 > > > Key: MSHARED-1152 > URL: https://issues.apache.org/jira/browse/MSHARED-1152 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-invoker >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Labels: up-for-grabs > Fix For: maven-invoker-3.3.0 > > -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MSHARED-1390) Deprecate InvocationRequest#setGoals
[
https://issues.apache.org/jira/browse/MSHARED-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843547#comment-17843547
]
ASF GitHub Bot commented on MSHARED-1390:
-
slawekjaranowski commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590269182
##
src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java:
##
@@ -552,6 +553,16 @@ enum CheckSumPolicy {
*/
InvocationRequest addArg(String arg);
+/**
+ * Add a raw arguments list to Maven cli command at the end of other
arguments.
Review Comment:
done
> Deprecate InvocationRequest#setGoals
>
>
> Key: MSHARED-1390
> URL: https://issues.apache.org/jira/browse/MSHARED-1390
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-invoker-3.3.0
>
>
> We should avoid parsing command line arguments.
> Raw arguments should be used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
slawekjaranowski commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590269182
##
src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java:
##
@@ -552,6 +553,16 @@ enum CheckSumPolicy {
*/
InvocationRequest addArg(String arg);
+/**
+ * Add a raw arguments list to Maven cli command at the end of other
arguments.
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSHARED-1390) Deprecate InvocationRequest#setGoals
[
https://issues.apache.org/jira/browse/MSHARED-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843546#comment-17843546
]
ASF GitHub Bot commented on MSHARED-1390:
-
michael-o commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590268823
##
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+@Override
+public InvocationRequest addArgs(Collection args) {
+args.stream().filter(arg ->
!StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
I'd say, shit in, shit out, no?
> Deprecate InvocationRequest#setGoals
>
>
> Key: MSHARED-1390
> URL: https://issues.apache.org/jira/browse/MSHARED-1390
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-invoker-3.3.0
>
>
> We should avoid parsing command line arguments.
> Raw arguments should be used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
michael-o commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590268823
##
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+@Override
+public InvocationRequest addArgs(Collection args) {
+args.stream().filter(arg ->
!StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
I'd say, shit in, shit out, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MSHARED-1390) Deprecate InvocationRequest#setGoals
[
https://issues.apache.org/jira/browse/MSHARED-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843545#comment-17843545
]
ASF GitHub Bot commented on MSHARED-1390:
-
slawekjaranowski commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590268473
##
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+@Override
+public InvocationRequest addArgs(Collection args) {
+args.stream().filter(arg ->
!StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
in `addArg` we do the same ...
I'm not sure how it works with empty arg
> Deprecate InvocationRequest#setGoals
>
>
> Key: MSHARED-1390
> URL: https://issues.apache.org/jira/browse/MSHARED-1390
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-invoker-3.3.0
>
>
> We should avoid parsing command line arguments.
> Raw arguments should be used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MSHARED-1390) Deprecate InvocationRequest#setGoals
[
https://issues.apache.org/jira/browse/MSHARED-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843544#comment-17843544
]
ASF GitHub Bot commented on MSHARED-1390:
-
michael-o commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590267374
##
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+@Override
+public InvocationRequest addArgs(Collection args) {
+args.stream().filter(arg ->
!StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
Should we really check for empty arg lines?
```
```
??
I mean that is a deliberate input, no?
##
src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java:
##
@@ -552,6 +553,16 @@ enum CheckSumPolicy {
*/
InvocationRequest addArg(String arg);
+/**
+ * Add a raw arguments list to Maven cli command at the end of other
arguments.
Review Comment:
Between "raw" and "arguments" should be one space
> Deprecate InvocationRequest#setGoals
>
>
> Key: MSHARED-1390
> URL: https://issues.apache.org/jira/browse/MSHARED-1390
> Project: Maven Shared Components
> Issue Type: Improvement
> Components: maven-invoker
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-invoker-3.3.0
>
>
> We should avoid parsing command line arguments.
> Raw arguments should be used.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
michael-o commented on code in PR #76:
URL: https://github.com/apache/maven-invoker/pull/76#discussion_r1590267374
##
src/main/java/org/apache/maven/shared/invoker/DefaultInvocationRequest.java:
##
@@ -471,6 +472,12 @@ public InvocationRequest addArg(String arg) {
return this;
}
+@Override
+public InvocationRequest addArgs(Collection args) {
+args.stream().filter(arg ->
!StringUtils.isBlank(arg)).forEach(this.args::add);
Review Comment:
Should we really check for empty arg lines?
```
```
??
I mean that is a deliberate input, no?
##
src/main/java/org/apache/maven/shared/invoker/InvocationRequest.java:
##
@@ -552,6 +553,16 @@ enum CheckSumPolicy {
*/
InvocationRequest addArg(String arg);
+/**
+ * Add a raw arguments list to Maven cli command at the end of other
arguments.
Review Comment:
Between "raw" and "arguments" should be one space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MINVOKER-335) Symlinks from source project are copied as file
[
https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843543#comment-17843543
]
ASF GitHub Bot commented on MINVOKER-335:
-
michael-o commented on code in PR #237:
URL:
https://github.com/apache/maven-invoker-plugin/pull/237#discussion_r1590267152
##
src/it/MINVOKER-335-symlinks-in-source/selector.groovy:
##
@@ -28,7 +28,12 @@ def testFile = projectPath.resolve('test.txt')
Files.createDirectory(testDir)
Files.createFile(testFile)
-Files.createSymbolicLink(projectPath.resolve('testDirLink'),
Paths.get('testDir'))
-Files.createSymbolicLink(projectPath.resolve('testLink.txt'),
Paths.get('test.txt'))
+// if FS not supports symlinks - we should skip test
Review Comment:
If FS does not support symlinks we should skip test
> Symlinks from source project are copied as file
> ---
>
> Key: MINVOKER-335
> URL: https://issues.apache.org/jira/browse/MINVOKER-335
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Source project:
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:26 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:27 testDirLink -> testDir
> lrwxr-xr-x 1 xxx 8 May 1 19:29 testLink.txt -> test.txt
> {noformat}
> after copy in {{target/it/..}}
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:30 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:30 testDirLink -> testDir
> -rw-r--r-- 1 xxx 40 May 1 18:44 testLink.txt
> {noformat}
> symlinks for directory are preserved only symlinks for file are broken
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Exclude JDK 8 - temurin, adopt-openj9 on macos [maven-javadoc-plugin]
slawekjaranowski merged PR #279: URL: https://github.com/apache/maven-javadoc-plugin/pull/279 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-335) Symlinks from source project are copied as file
[
https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843536#comment-17843536
]
ASF GitHub Bot commented on MINVOKER-335:
-
slawekjaranowski commented on PR #231:
URL:
https://github.com/apache/maven-invoker-plugin/pull/231#issuecomment-2094693119
@michael-o - done in #237
> Symlinks from source project are copied as file
> ---
>
> Key: MINVOKER-335
> URL: https://issues.apache.org/jira/browse/MINVOKER-335
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Source project:
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:26 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:27 testDirLink -> testDir
> lrwxr-xr-x 1 xxx 8 May 1 19:29 testLink.txt -> test.txt
> {noformat}
> after copy in {{target/it/..}}
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:30 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:30 testDirLink -> testDir
> -rw-r--r-- 1 xxx 40 May 1 18:44 testLink.txt
> {noformat}
> symlinks for directory are preserved only symlinks for file are broken
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MINVOKER-335] Preserve symlinks for copied files [maven-invoker-plugin]
slawekjaranowski commented on PR #231: URL: https://github.com/apache/maven-invoker-plugin/pull/231#issuecomment-2094693119 @michael-o - done in #237 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MINVOKER-335) Symlinks from source project are copied as file
[
https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843535#comment-17843535
]
ASF GitHub Bot commented on MINVOKER-335:
-
slawekjaranowski opened a new pull request, #237:
URL: https://github.com/apache/maven-invoker-plugin/pull/237
(no comment)
> Symlinks from source project are copied as file
> ---
>
> Key: MINVOKER-335
> URL: https://issues.apache.org/jira/browse/MINVOKER-335
> Project: Maven Invoker Plugin
> Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Source project:
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:26 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:27 testDirLink -> testDir
> lrwxr-xr-x 1 xxx 8 May 1 19:29 testLink.txt -> test.txt
> {noformat}
> after copy in {{target/it/..}}
> {noformat}
> -rw-r--r-- 1 xxx 40 May 1 18:44 test.txt
> drwxr-xr-x 2 xxx 64 May 1 19:30 testDir
> lrwxr-xr-x 1 xxx 7 May 1 19:30 testDirLink -> testDir
> -rw-r--r-- 1 xxx 40 May 1 18:44 testLink.txt
> {noformat}
> symlinks for directory are preserved only symlinks for file are broken
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] Update artifact-handlers.apt [maven]
SDhkjdkbsv commented on PR #1466: URL: https://github.com/apache/maven/pull/1466#issuecomment-2094687415 You mix few things here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1390) Deprecate InvocationRequest#setGoals
[ https://issues.apache.org/jira/browse/MSHARED-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843534#comment-17843534 ] ASF GitHub Bot commented on MSHARED-1390: - slawekjaranowski commented on PR #76: URL: https://github.com/apache/maven-invoker/pull/76#issuecomment-2094686028 @michael-o - done - only minimal changes > Deprecate InvocationRequest#setGoals > > > Key: MSHARED-1390 > URL: https://issues.apache.org/jira/browse/MSHARED-1390 > Project: Maven Shared Components > Issue Type: Improvement > Components: maven-invoker >Reporter: Slawomir Jaranowski >Assignee: Slawomir Jaranowski >Priority: Major > Fix For: maven-invoker-3.3.0 > > > We should avoid parsing command line arguments. > Raw arguments should be used. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MSHARED-1390] Deprecate InvocationRequest#setGoals [maven-invoker]
slawekjaranowski commented on PR #76: URL: https://github.com/apache/maven-invoker/pull/76#issuecomment-2094686028 @michael-o - done - only minimal changes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
