[jira] (MRAR-30) Filtering of RA.xml
[
https://jira.codehaus.org/browse/MRAR-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=325182#comment-325182
]
Florian Fray commented on MRAR-30:
--
Just faced the same problem, so I'm using this configuration as workaround:
{noformat}
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-rar-plugin/artifactId
configuration
filterRarSourceDirectorytrue/filterRarSourceDirectory
raXmlFile${rarSourceDirectory}/META-INF/nonexistent-ra.xml/raXmlFile
warnOnMissingRaXmlfalse/warnOnMissingRaXml
/configuration
executions
execution
idrar/id
goals
goalrar/goal
/goals
/execution
/executions
/plugin
{noformat}
Filtering of RA.xml
---
Key: MRAR-30
URL: https://jira.codehaus.org/browse/MRAR-30
Project: Maven 2.x Rar Plugin
Issue Type: New Feature
Affects Versions: 2.2
Environment: Win7 64Bit JDK1.6.0_26
Reporter: Markus KARG
Priority: Minor
It would be great if one could specify filteringtrue/filtering in the
pom.xml to make the RAR plugin filter the custom RA.xml file provided in src.
Using this feature, one could put ${project.version} into the custom RA.xml's
resourceadapter-version/ section.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-164) Support for specifying which encoding to use when filtering resources
[
http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=269188#action_269188
]
Florian Fray commented on MWAR-164:
---
Could somebody please review the patch and respond to this issue?
Best regards,
Florian
Support for specifying which encoding to use when filtering resources
-
Key: MWAR-164
URL: http://jira.codehaus.org/browse/MWAR-164
Project: Maven 2.x WAR Plugin
Issue Type: Improvement
Affects Versions: 2.1-alpha-1
Reporter: kai lilleby
Fix For: 2.2
Attachments: MWAR-164-maven-war-plugin.patch
Quoting Hervé:
{quote}
Maven filtering provides an encoding parameter to set encoding used when
reading/writing files. But war plugin uses null value, which means platform
encoding... Sorry, encoding support won't be totally free ;)
I added TODOs in the code.
For web.xml and container config XML file, I set encoding to UTF-8, which is a
better default value than platform encoding.
For other filtered resources, you'll need to add an encoding attribute to
o.a.m.model.Resource class, to let the user define which encoding he wants to
use when filtering. Perhaps using project.build.sourceEncoding as a default
value is a good idea.
Seems like this is worth a Jira issue to track this new feature.
{quote}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MNG-5091) Add option to fail build if WARNING's appear in POM
[
http://jira.codehaus.org/browse/MNG-5091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florian Fray updated MNG-5091:
--
Attachment: MNG-5091-maven-embedder.patch
Indeed I'd like the fail-on-warning - behaviour better, as it does not point to
any specific Maven version,
but I've created a small patch adding the suggested {{--validation-level}}
switches.
Anyway I'd prefer to be able to toggle this behaviour via the POM or the
settings.
There are just minor changes to the proposed solution, as there are:
- option values are all lower-case and
- an additional {{strict}} argument-value supporting
{{ModelBuildingRequest.VALIDATION_LEVEL_STRICT}}.
I'd like to change printing the error-message right after the help, but I
didn't really know if that would be okay.
Hopefully I spotted the proper locations for adding this little enhancement, so
I'm looking forward for a review.
Best regards,
Florian
Add option to fail build if WARNING's appear in POM
---
Key: MNG-5091
URL: http://jira.codehaus.org/browse/MNG-5091
Project: Maven 2 3
Issue Type: Improvement
Components: Command Line, POM
Affects Versions: 3.0.3
Reporter: Karl Heinz Marbaise
Priority: Minor
Attachments: MNG-5091-maven-embedder.patch
It would be nice to have the option to let a build fail if something like
this will appear:
{code}
[INFO] Scanning for projects...
[WARNING]
[WARNING] Some problems were encountered while building the effective model
for com.soebes.training.module:050-project-without-warnings:jar:0.1.0-SNAPSHOT
[WARNING] 'dependencies.dependency.(groupId:artifactId:type:classifier)' must
be unique: org.slf4j:slf4j-api:jar - duplicate declaration of version 1.6.1
@ line 28, column 14
[WARNING]
[WARNING] It is highly recommended to fix these problems because they
threaten the stability of your build.
[WARNING]
[WARNING] For this reason, future Maven versions might no longer support
building such malformed projects.
[WARNING]
{code}
This shoud be done for WARNING's in case of missing versions for plugins etc.
Currently it is possible to set the Validation leven in Jenkins/Hudson
already but it is not possible on command line. So an option on command line
like:
{code}
mvn --fail-warning ...
{code}
would be great. Or may be a good supplemental option to set the validation
level like:
{code}
mvn --validation-level MINIMAL
mvn --validation-level MAVEN20
mvn --validation-level MAVEN30
mvn --validation-level MAVEN31
mvn --validation-level DEFAULT
{code}
or may be both. May this might be an enhancement for Maven 3.0.4 ?
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-164) Support for specifying which encoding to use when filtering resources
[
http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=254557#action_254557
]
Florian Fray commented on MWAR-164:
---
Hi!
Has somebody had the chance to review this patch ?
Best regards,
Florian
Support for specifying which encoding to use when filtering resources
-
Key: MWAR-164
URL: http://jira.codehaus.org/browse/MWAR-164
Project: Maven 2.x WAR Plugin
Issue Type: Improvement
Affects Versions: 2.1-alpha-1
Reporter: kai lilleby
Fix For: 2.2
Attachments: MWAR-164-maven-war-plugin.patch
Quoting Hervé:
{quote}
Maven filtering provides an encoding parameter to set encoding used when
reading/writing files. But war plugin uses null value, which means platform
encoding... Sorry, encoding support won't be totally free ;)
I added TODOs in the code.
For web.xml and container config XML file, I set encoding to UTF-8, which is a
better default value than platform encoding.
For other filtered resources, you'll need to add an encoding attribute to
o.a.m.model.Resource class, to let the user define which encoding he wants to
use when filtering. Perhaps using project.build.sourceEncoding as a default
value is a good idea.
Seems like this is worth a Jira issue to track this new feature.
{quote}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MWAR-164) Support for specifying which encoding to use when filtering resources
[
http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=247770#action_247770
]
Florian Fray commented on MWAR-164:
---
I was facing this problem in our builds as well, so I've worked around it by
setting the JVM ??file.encoding??-property.
It works for me, but not for my team, so I'd like to fix it permanently.
For now my preference is to keep the existing behaviour as default (which is
odd, but well known). In my patch I've added a property named
??resourceEncoding?? to the AbstractWarMojo.
I've added this to my parent-poms:
{code}
plugin
groupIdorg.apache.maven.plugins/groupId
artifactIdmaven-war-plugin/artifactId
version2.2-SNAPSHOT/version
configuration
resourceEncoding${project.build.sourceEncoding}/resourceEncoding
/configuration
/plugin
{code}
In order to test this I've modified the
??web-resources-filtering??-Integration-Test and hope this will pass the review
:-)
Please find my patch attached to this bug-report.
Best regards,
Florian
Support for specifying which encoding to use when filtering resources
-
Key: MWAR-164
URL: http://jira.codehaus.org/browse/MWAR-164
Project: Maven 2.x WAR Plugin
Issue Type: Improvement
Affects Versions: 2.1-alpha-1
Reporter: kai lilleby
Fix For: 2.2
Quoting Hervé:
{quote}
Maven filtering provides an encoding parameter to set encoding used when
reading/writing files. But war plugin uses null value, which means platform
encoding... Sorry, encoding support won't be totally free ;)
I added TODOs in the code.
For web.xml and container config XML file, I set encoding to UTF-8, which is a
better default value than platform encoding.
For other filtered resources, you'll need to add an encoding attribute to
o.a.m.model.Resource class, to let the user define which encoding he wants to
use when filtering. Perhaps using project.build.sourceEncoding as a default
value is a good idea.
Seems like this is worth a Jira issue to track this new feature.
{quote}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (MWAR-164) Support for specifying which encoding to use when filtering resources
[
http://jira.codehaus.org/browse/MWAR-164?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Florian Fray updated MWAR-164:
--
Attachment: MWAR-164-maven-war-plugin.patch
Patch-file for MWAR-164 adding a resourceEncoding-property to the
AbstractWarMojo.
Support for specifying which encoding to use when filtering resources
-
Key: MWAR-164
URL: http://jira.codehaus.org/browse/MWAR-164
Project: Maven 2.x WAR Plugin
Issue Type: Improvement
Affects Versions: 2.1-alpha-1
Reporter: kai lilleby
Fix For: 2.2
Attachments: MWAR-164-maven-war-plugin.patch
Quoting Hervé:
{quote}
Maven filtering provides an encoding parameter to set encoding used when
reading/writing files. But war plugin uses null value, which means platform
encoding... Sorry, encoding support won't be totally free ;)
I added TODOs in the code.
For web.xml and container config XML file, I set encoding to UTF-8, which is a
better default value than platform encoding.
For other filtered resources, you'll need to add an encoding attribute to
o.a.m.model.Resource class, to let the user define which encoding he wants to
use when filtering. Perhaps using project.build.sourceEncoding as a default
value is a good idea.
Seems like this is worth a Jira issue to track this new feature.
{quote}
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
