[jira] Created: (SCM-331) bug found in StarteamUpdateCommand when doing a delete-local when a (view)label is used

2007-07-26 Thread Jan Edelbroek (JIRA)
bug found in StarteamUpdateCommand when doing a delete-local when a (view)label 
is used
---

 Key: SCM-331
 URL: http://jira.codehaus.org/browse/SCM-331
 Project: Maven SCM
  Issue Type: Bug
  Components: maven-scm-provider-starteam
Affects Versions: 1.0-beta-3
Reporter: Jan Edelbroek


After a succesfull update the StarteamUpdateCommand fires a delete-local 
command.
The command string that is created for the stcmd is wrong when a (view)label is 
used.
stcmd delete-local -x -nologo -stop -p [EMAIL 
PROTECTED]:port/Project/View/path -fp path-to-working-directory -is -cfgl  
alpha-1-1 -filter N
As you can see, the -cfgl option is between quotes and there is also an 
additional space character.

The problem is in the StarteamUpdateCommand class file (also in the trunk 
version).
The following line in the createDeleteLocalCommand method
args.add( -cfgl  );
should be replaced with
args.add( -cfgl );
thus leaving out the additional space character.

I can provide a patch when necessary.
See also SCM-309 in which i indicate that i have a patch ready to be able to 
use promotion states instead of view labels


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Created: (SCM-309) Use existing tag to use starteam promotion states

2007-05-09 Thread Jan Edelbroek (JIRA)
Use existing tag to use starteam promotion states
-

 Key: SCM-309
 URL: http://jira.codehaus.org/browse/SCM-309
 Project: Maven SCM
  Issue Type: Improvement
  Components: maven-scm-provider-starteam
Affects Versions: 1.0-beta-4
Reporter: Jan Edelbroek


Starteam has the possibility to use promotion states. Now only view labels can 
be used by configuring the tag.
My proposal is to modify the handling of the tag slightly so that promotion 
states can also be used.
For example: when the tag is configured as -pbeta then the tag will not be 
handled as a view label, but as a promotion state. In this example the 
promotion state is beta. The promotion state is simply indicated by the -p 
prefix in the tag. Configuring continuum with this tag is also easy, no changes 
are needed for continuum.
The modification involves small changes in the StarteamUpdateCommand and 
StarteamCheckOutCommand. I can provide a patch when needed.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Updated: (CONTINUUM-1182) Pass configured scm username and password to execution of maven goals

2007-04-19 Thread Jan Edelbroek (JIRA)

 [ 
http://jira.codehaus.org/browse/CONTINUUM-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Edelbroek updated CONTINUUM-1182:
-

Attachment: continuum-diff.txt

In the previous comment, i included the patch in the comment, which i think was 
not a good idea, so i add the patch as file too.

 Pass configured scm username and password to execution of maven goals
 -

 Key: CONTINUUM-1182
 URL: http://jira.codehaus.org/browse/CONTINUUM-1182
 Project: Continuum
  Issue Type: Improvement
  Components: Core system
Reporter: Jan Edelbroek
 Attachments: continuum-diff.txt


 It's possible to configure a scm username and password. Continuum uses this 
 to update the sourcecode from the scm before the actual build takes place.
 Because of this feature, i don't have to configure this in my project pom for 
 maven2.
 It would be nice if i could use these username and password also for 
 executing maven goals.
 For example, if i use the scm:tag goal in my build definition, it would be 
 nice to have something like this in my maven2 build definition:
 clean install scm:tag -Dusername=${scm.username} -Dpassword=${scm.password}
 In this case, continuum should substitute the configured scm username and 
 password before executing the build.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Commented: (SCM-142) Starteam tree stale

2007-04-18 Thread Jan Edelbroek (JIRA)

[ 
http://jira.codehaus.org/browse/SCM-142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_93205
 ] 

Jan Edelbroek commented on SCM-142:
---

Does anybody have a solution yet for this problem?
I have the same problem too and it seems that starteam has sometimes troubles 
with updating the status of the files.
Maybe this can be solved by using the update-status command (stcmd 
update-status ...) first before doing the checkout from starteam. I think this 
will solve most of the problems.


 Starteam tree stale
 ---

 Key: SCM-142
 URL: http://jira.codehaus.org/browse/SCM-142
 Project: Maven SCM
  Issue Type: Bug
  Components: maven-scm-provider-starteam
 Environment: continuum-1.0.2
Reporter: Bob Herrmann
 Fix For: future


 It only takes a few changes to starteam for the checked out filesystem to 
 become hopelessly stale.  The only recovery option is to completely remove 
 all files and startover.  Either the code checking out is not handing the 
 timestamps correctly, or starteam command line has problems keeping a checked 
 out tree in sync (this more likely - as we also see this problem with AntHill 
 when using it's incremental builder.)   Possible fixes might be to detect 
 'unknown' status's and flush the checked out tree.  Or try using the 2005 bco 
 command instead of stcmd.  

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira




[jira] Reopened: (CONTINUUM-1182) Pass configured scm username and password to execution of maven goals

2007-04-05 Thread Jan Edelbroek (JIRA)

 [ 
http://jira.codehaus.org/browse/CONTINUUM-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jan Edelbroek reopened CONTINUUM-1182:
--


Its not good to configure the scm username and password in the settings.xml, 
because it then can be read by other users. For me and our organisation it is 
very important that the scm username and password cannot be read by other users 
because only our build manager has certain rights to our SCM (which is Starteam 
in our case). Also in our organisation, the build environment is shared among 
different users, so storing the password in the settings.xml is not an option.
Therefore i need i way to use the scm username and password from continuum so 
that they can be used by a maven plugin.

I made a small change to continuum-core to get this to work. The idea behind 
this change is that the scm username and password are stored as environment 
variables in the shell where maven is executed. A maven plugin can then use 
these environment variables to configure the scm username and password.

I hope that you adopt this change in the next release of continuum.

The diff file is shown below and made against the 1.1-SNAPSHOT version, date 
2007-04-05.

Index: 
H:/workspaces/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/utils/shell/ShellCommandHelper.java
===
--- 
H:/workspaces/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/utils/shell/ShellCommandHelper.java
   (revision 525924)
+++ 
H:/workspaces/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/utils/shell/ShellCommandHelper.java
   (working copy)
@@ -20,6 +20,7 @@
  */
 
 import java.io.File;
+import org.apache.maven.continuum.model.project.Project;
 
 /**
  * @author a href=mailto:[EMAIL PROTECTED]Trygve Laugstoslash;l/a
@@ -30,14 +31,14 @@
 String ROLE = ShellCommandHelper.class.getName();
 
 ExecutionResult executeShellCommand( File workingDirectory, String 
executable, String arguments, File output,
- long idCommand )
+ Project project )
 throws Exception;
 
 ExecutionResult executeShellCommand( File workingDirectory, String 
executable, String[] arguments, File output,
- long idCommand )
+ Project project )
 throws Exception;
 
-boolean isRunning( long idCommand );
+boolean isRunning( Project project );
 
-void killProcess( long idCommand );
+void killProcess( Project project );
 }
Index: 
H:/workspaces/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/utils/shell/DefaultShellCommandHelper.java
===
--- 
H:/workspaces/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/utils/shell/DefaultShellCommandHelper.java
(revision 525924)
+++ 
H:/workspaces/continuum/trunk/continuum-core/src/main/java/org/apache/maven/continuum/utils/shell/DefaultShellCommandHelper.java
(working copy)
@@ -24,6 +24,7 @@
 import org.codehaus.plexus.util.cli.Commandline;
 import org.codehaus.plexus.util.cli.StreamConsumer;
 import org.codehaus.plexus.util.cli.WriterStreamConsumer;
+import org.apache.maven.continuum.model.project.Project;
 
 import java.io.File;
 import java.io.FileWriter;
@@ -45,8 +46,12 @@
 // ShellCommandHelper Implementation
 // --
 
+public static final String SCM_USERNAME = CONTINUUM.PROJECT.SCM.USERNAME;
+public static final String SCM_PASSWORD = CONTINUUM.PROJECT.SCM.PASSWORD;
+
+
 public ExecutionResult executeShellCommand( File workingDirectory, String 
executable, String arguments, File output,
-long idCommand )
+Project project  )
 throws Exception
 {
 Commandline cl = new Commandline();
@@ -55,11 +60,11 @@
 
 argument.setLine( arguments );
 
-return executeShellCommand( workingDirectory, executable, 
argument.getParts(), output, idCommand );
+return executeShellCommand( workingDirectory, executable, 
argument.getParts(), output, project );
 }
 
 public ExecutionResult executeShellCommand( File workingDirectory, String 
executable, String[] arguments,
-File output, long idCommand )
+File output, Project project )
 throws Exception
 {
 // 
--
@@ -68,12 +73,17 @@
 
 Commandline cl = new Commandline();
 
-cl.setPid( idCommand );
+cl.setPid( project.getId() );
 
 

[jira] Created: (CONTINUUM-1182) Pass configured scm username and password to execution of maven goals

2007-02-23 Thread Jan Edelbroek (JIRA)
Pass configured scm username and password to execution of maven goals
-

 Key: CONTINUUM-1182
 URL: http://jira.codehaus.org/browse/CONTINUUM-1182
 Project: Continuum
  Issue Type: Improvement
  Components: Core system
Reporter: Jan Edelbroek


It's possible to configure a scm username and password. Continuum uses this to 
update the sourcecode from the scm before the actual build takes place.
Because of this feature, i don't have to configure this in my project pom for 
maven2.
It would be nice if i could use these username and password also for executing 
maven goals.

For example, if i use the scm:tag goal in my build definition, it would be nice 
to have something like this in my maven2 build definition:
clean install scm:tag -Dusername=${scm.username} -Dpassword=${scm.password}

In this case, continuum should substitute the configured scm username and 
password before executing the build.


-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: 
http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira