[jira] [Commented] (MSHADE-291) shadedPattern applied multiples times when relocating the contents of META-INF/services files

2020-03-03 Thread Jan Luehe (Jira) 


[ 
https://issues.apache.org/jira/browse/MSHADE-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17050645#comment-17050645
 ] 

Jan Luehe commented on MSHADE-291:
--

Confirmed the fix in the just-released 3.2.2. Thanks guys!

> shadedPattern applied multiples times when relocating the contents of 
> META-INF/services files
> -
>
> Key: MSHADE-291
> URL: https://issues.apache.org/jira/browse/MSHADE-291
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.1, 3.2.0, 3.2.1
>Reporter: Jan Luehe
>Assignee: Robert Scholte
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.2.2
>
>
> Steps to reproduce:
> 1. Modified the test case for 
> https://issues.apache.org/jira/browse/MSHADE-190, as follows:
> {code:java}
> diff --git a/pom.xml b/pom.xml
> index 746b700..aea9abb 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -68,12 +68,12 @@
>  
>  org.apache.maven.plugins
>  maven-shade-plugin
> -2.4
> +3.1.1
>  
>  
>  
> -org.eclipse.*
> -borg.eclipse.*
> +org.eclipse
> +org.eclipse1234
>  
>  
>  
> {code}
> 2. mvn package
> 3. jar -xvf target/shade-meta-tc-1.0-SNAPSHOT.jar META-INF/services
> 4. cat META-INF/services/org.osgi.framework.launch.FrameworkFactory
> The shaded service implementation class looks as follows: 
> {code:java}
> org.eclipse12341234.osgi.launch.EquinoxFactory
> {code}
> It appears that shadedPattern was applied twice.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MSHADE-291) shadedPattern applied multiples times when relocating the contents of META-INF/services files

2020-02-04 Thread Jan Luehe (Jira) 


[ 
https://issues.apache.org/jira/browse/MSHADE-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17030088#comment-17030088
 ] 

Jan Luehe commented on MSHADE-291:
--

Is there any update on the 3.2.2 release?

> shadedPattern applied multiples times when relocating the contents of 
> META-INF/services files
> -
>
> Key: MSHADE-291
> URL: https://issues.apache.org/jira/browse/MSHADE-291
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.1, 3.2.0, 3.2.1
>Reporter: Jan Luehe
>Assignee: Robert Scholte
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.2.2
>
>
> Steps to reproduce:
> 1. Modified the test case for 
> https://issues.apache.org/jira/browse/MSHADE-190, as follows:
> {code:java}
> diff --git a/pom.xml b/pom.xml
> index 746b700..aea9abb 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -68,12 +68,12 @@
>  
>  org.apache.maven.plugins
>  maven-shade-plugin
> -2.4
> +3.1.1
>  
>  
>  
> -org.eclipse.*
> -borg.eclipse.*
> +org.eclipse
> +org.eclipse1234
>  
>  
>  
> {code}
> 2. mvn package
> 3. jar -xvf target/shade-meta-tc-1.0-SNAPSHOT.jar META-INF/services
> 4. cat META-INF/services/org.osgi.framework.launch.FrameworkFactory
> The shaded service implementation class looks as follows: 
> {code:java}
> org.eclipse12341234.osgi.launch.EquinoxFactory
> {code}
> It appears that shadedPattern was applied twice.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (MSHADE-291) shadedPattern applied multiples times when relocating the contents of META-INF/services files

2018-11-20 Thread Jan Luehe (JIRA) 


[ 
https://issues.apache.org/jira/browse/MSHADE-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693781#comment-16693781
 ] 

Jan Luehe commented on MSHADE-291:
--

Got it! Thank you for the explanation, [~rfscholte]

> shadedPattern applied multiples times when relocating the contents of 
> META-INF/services files
> -
>
> Key: MSHADE-291
> URL: https://issues.apache.org/jira/browse/MSHADE-291
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.1, 3.2.0, 3.2.1
>Reporter: Jan Luehe
>Assignee: Robert Scholte
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.2.2
>
>
> Steps to reproduce:
> 1. Modified the test case for 
> https://issues.apache.org/jira/browse/MSHADE-190, as follows:
> {code:java}
> diff --git a/pom.xml b/pom.xml
> index 746b700..aea9abb 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -68,12 +68,12 @@
>  
>  org.apache.maven.plugins
>  maven-shade-plugin
> -2.4
> +3.1.1
>  
>  
>  
> -org.eclipse.*
> -borg.eclipse.*
> +org.eclipse
> +org.eclipse1234
>  
>  
>  
> {code}
> 2. mvn package
> 3. jar -xvf target/shade-meta-tc-1.0-SNAPSHOT.jar META-INF/services
> 4. cat META-INF/services/org.osgi.framework.launch.FrameworkFactory
> The shaded service implementation class looks as follows: 
> {code:java}
> org.eclipse12341234.osgi.launch.EquinoxFactory
> {code}
> It appears that shadedPattern was applied twice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (MSHADE-291) shadedPattern applied multiples times when relocating the contents of META-INF/services files

2018-11-20 Thread Jan Luehe (JIRA) 


[ 
https://issues.apache.org/jira/browse/MSHADE-291?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16693601#comment-16693601
 ] 

Jan Luehe commented on MSHADE-291:
--

[~fabcipriano] and [~rfscholte], thank you for the fix! Would it be possible to 
make version 3.2.2 available at 
https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-shade-plugin?

> shadedPattern applied multiples times when relocating the contents of 
> META-INF/services files
> -
>
> Key: MSHADE-291
> URL: https://issues.apache.org/jira/browse/MSHADE-291
> Project: Maven Shade Plugin
>  Issue Type: Bug
>Affects Versions: 3.1.1, 3.2.0, 3.2.1
>Reporter: Jan Luehe
>Assignee: Robert Scholte
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.2.2
>
>
> Steps to reproduce:
> 1. Modified the test case for 
> https://issues.apache.org/jira/browse/MSHADE-190, as follows:
> {code:java}
> diff --git a/pom.xml b/pom.xml
> index 746b700..aea9abb 100644
> --- a/pom.xml
> +++ b/pom.xml
> @@ -68,12 +68,12 @@
>  
>  org.apache.maven.plugins
>  maven-shade-plugin
> -2.4
> +3.1.1
>  
>  
>  
> -org.eclipse.*
> -borg.eclipse.*
> +org.eclipse
> +org.eclipse1234
>  
>  
>  
> {code}
> 2. mvn package
> 3. jar -xvf target/shade-meta-tc-1.0-SNAPSHOT.jar META-INF/services
> 4. cat META-INF/services/org.osgi.framework.launch.FrameworkFactory
> The shaded service implementation class looks as follows: 
> {code:java}
> org.eclipse12341234.osgi.launch.EquinoxFactory
> {code}
> It appears that shadedPattern was applied twice.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (MSHADE-291) shadedPattern applied multiples times when relocating the contents of META-INF/services files

2018-06-18 Thread Jan Luehe (JIRA) 
Jan Luehe created MSHADE-291:


 Summary: shadedPattern applied multiples times when relocating the 
contents of META-INF/services files
 Key: MSHADE-291
 URL: https://issues.apache.org/jira/browse/MSHADE-291
 Project: Maven Shade Plugin
  Issue Type: Bug
Affects Versions: 3.1.1
Reporter: Jan Luehe


Steps to reproduce:

1. Modified the test case for https://issues.apache.org/jira/browse/MSHADE-190, 
as follows:

{code:java}
diff --git a/pom.xml b/pom.xml
index 746b700..aea9abb 100644
--- a/pom.xml
+++ b/pom.xml
@@ -68,12 +68,12 @@
 
 org.apache.maven.plugins
 maven-shade-plugin
-2.4
+3.1.1
 
 
 
-org.eclipse.*
-borg.eclipse.*
+org.eclipse
+org.eclipse1234
 
 
 
{code}

2. mvn package
3. jar -xvf target/shade-meta-tc-1.0-SNAPSHOT.jar META-INF/services
4. cat META-INF/services/org.osgi.framework.launch.FrameworkFactory

The shaded service implementation class looks as follows: 
{code:java}
org.eclipse12341234.osgi.launch.EquinoxFactory
{code}

It appears that shadedPattern was applied twice.





--
This message was sent by Atlassian JIRA
(v7.6.3#76005)