[jira] [Commented] (MRELEASE-1008) Changed formatting of pom file for multiline attributes during version bump
[ https://issues.apache.org/jira/browse/MRELEASE-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17438874#comment-17438874 ] John Lin commented on MRELEASE-1008: [~juliojgd] it seems that you tagged the wrong person. It's [~elharo] that said it is a cosmetic bug. > Changed formatting of pom file for multiline attributes during version bump > --- > > Key: MRELEASE-1008 > URL: https://issues.apache.org/jira/browse/MRELEASE-1008 > Project: Maven Release Plugin > Issue Type: Bug >Reporter: Roman Ivanov >Priority: Major > > during release, plugin create commit for version bump. > BUT in addition to this it change formatting of some tags - > https://github.com/checkstyle/checkstyle/commit/29a635421d9292673bbaaf0c0693d2191dfb5f18 > Plugin changes multiline attributes formatting to single-line. > In Checkstyle project we control length of lines in files to ease code review > in web. This allow us to avoid vertical scrolls, .. . > Such unexpected change triggered build problem right after release and make > it impossible to keep user-defined formatting . > Also reported at: > https://stackoverflow.com/questions/49085502/maven-release-plugin-changes-pom-formatting -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEP-645) List classes in a given artifact
[
https://issues.apache.org/jira/browse/MDEP-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17148224#comment-17148224
]
John Lin commented on MDEP-645:
---
It looks very promising and satisfying. Thank you all for the effort!
> List classes in a given artifact
>
>
> Key: MDEP-645
> URL: https://issues.apache.org/jira/browse/MDEP-645
> Project: Maven Dependency Plugin
> Issue Type: New Feature
>Reporter: John Lin
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Labels: intern
>
> When I want to list all the classes in a given artifact, I have to use
> {{jar}} command to show files in the corresponding .jar file.
> For example, I want to list all the classes in the artifact
> {code}
> org.apache.commons:commons-lang3:3.6
> {code}
> I have to run
> {code}
> jar tf
> ~/.m2/repository/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.jar
> {code}
> This method has some disadvantages:
> # The jar file may not be downloaded, so it may not be in
> {{~/.m2/repository}}.
> # It's kind of tedious to type such a long filename.
> # The output is shown in raw filenames, e.g.,
> {{org/apache/commons/lang3/SystemUtils.class}}, but I generally want a
> package + class name {{org.apache.commons.lang3.SystemUtils}}.
> So I would expect a goal called {{show}} with an argument {{artifact}}, so I
> can type
> {code}
> mvn dependency:show -Dartifact=org.apache.commons:commons-lang3:3.6
> {code}
> to show
> {code}
> org.apache.commons.lang3.CharUtils
> org.apache.commons.lang3.RandomStringUtils
> ...
> {code}
> What do you guys think? Thanks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MDEP-645) List classes in a given artifact
[
https://issues.apache.org/jira/browse/MDEP-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17112763#comment-17112763
]
John Lin commented on MDEP-645:
---
It's any artifact the user specifies, and it doesn't have to be within the
current project.
> List classes in a given artifact
>
>
> Key: MDEP-645
> URL: https://issues.apache.org/jira/browse/MDEP-645
> Project: Maven Dependency Plugin
> Issue Type: New Feature
>Reporter: John Lin
>Priority: Minor
> Labels: intern
>
> When I want to list all the classes in a given artifact, I have to use
> {{jar}} command to show files in the corresponding .jar file.
> For example, I want to list all the classes in the artifact
> {code}
> org.apache.commons:commons-lang3:3.6
> {code}
> I have to run
> {code}
> jar tf
> ~/.m2/repository/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.jar
> {code}
> This method has some disadvantages:
> # The jar file may not be downloaded, so it may not be in
> {{~/.m2/repository}}.
> # It's kind of tedious to type such a long filename.
> # The output is shown in raw filenames, e.g.,
> {{org/apache/commons/lang3/SystemUtils.class}}, but I generally want a
> package + class name {{org.apache.commons.lang3.SystemUtils}}.
> So I would expect a goal called {{show}} with an argument {{artifact}}, so I
> can type
> {code}
> mvn dependency:show -Dartifact=org.apache.commons:commons-lang3:3.6
> {code}
> to show
> {code}
> org.apache.commons.lang3.CharUtils
> org.apache.commons.lang3.RandomStringUtils
> ...
> {code}
> What do you guys think? Thanks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MDEP-645) List classes in a given artifact
[
https://issues.apache.org/jira/browse/MDEP-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17107844#comment-17107844
]
John Lin commented on MDEP-645:
---
I think it would be better if it's a new mojo. The mojo :list doesn't look like
a proper place to achieve this.
> List classes in a given artifact
>
>
> Key: MDEP-645
> URL: https://issues.apache.org/jira/browse/MDEP-645
> Project: Maven Dependency Plugin
> Issue Type: New Feature
>Reporter: John Lin
>Priority: Minor
> Labels: intern
>
> When I want to list all the classes in a given artifact, I have to use
> {{jar}} command to show files in the corresponding .jar file.
> For example, I want to list all the classes in the artifact
> {code}
> org.apache.commons:commons-lang3:3.6
> {code}
> I have to run
> {code}
> jar tf
> ~/.m2/repository/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.jar
> {code}
> This method has some disadvantages:
> # The jar file may not be downloaded, so it may not be in
> {{~/.m2/repository}}.
> # It's kind of tedious to type such a long filename.
> # The output is shown in raw filenames, e.g.,
> {{org/apache/commons/lang3/SystemUtils.class}}, but I generally want a
> package + class name {{org.apache.commons.lang3.SystemUtils}}.
> So I would expect a goal called {{show}} with an argument {{artifact}}, so I
> can type
> {code}
> mvn dependency:show -Dartifact=org.apache.commons:commons-lang3:3.6
> {code}
> to show
> {code}
> org.apache.commons.lang3.CharUtils
> org.apache.commons.lang3.RandomStringUtils
> ...
> {code}
> What do you guys think? Thanks.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MDEP-687) includeScope=runtime for copy-dependencies does not include transitive compile-time dependencies
[
https://issues.apache.org/jira/browse/MDEP-687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17101019#comment-17101019
]
John Lin commented on MDEP-687:
---
I executed {{mvn dependency:tree}} against your example pom, and here is the
result:
{code}
$ mvn dependency:tree
[INFO] Scanning for projects...
[INFO]
[INFO] ---< test:pom-test >
[INFO] Building pom-test 0.1
[INFO] [ jar ]-
[INFO]
[INFO] --- maven-dependency-plugin:3.1.2:tree (default-cli) @ pom-test ---
[INFO] test:pom-test:jar:0.1
[INFO] +- ch.qos.logback:logback-access:jar:1.2.2:compile
[INFO] +- ch.qos.logback:logback-core:jar:1.2.2:test
[INFO] \- org.slf4j:slf4j-api:jar:1.7.25:test
[INFO]
[INFO] BUILD SUCCESS
[INFO]
[INFO] Total time: 0.930 s
[INFO] Finished at: 2020-05-07T01:08:24+08:00
[INFO]
{code}
It seems that {{logback-core}} is treated as {{test}} scope in the first place.
I think it's because of the dependency mediation. You can find more details at
https://maven.apache.org/guides/introduction/introduction-to-dependency-mechanism.html.
> includeScope=runtime for copy-dependencies does not include transitive
> compile-time dependencies
>
>
> Key: MDEP-687
> URL: https://issues.apache.org/jira/browse/MDEP-687
> Project: Maven Dependency Plugin
> Issue Type: Bug
>Reporter: Dmitry Andrianov
>Priority: Major
>
> We using {{copy-dependencies}} from dependency plugin to collect all the
> libraries needed by the application at runtime into a {{lib/}} directory. We
> obviously do not want to include any test dependencies so we are setting
> {code:xml}
> runtime{code}
> It normally works as expected except for one case. Imagine::
> {code:java}
> application
> |
> + libOne (test)
> |
> + libTwo (compile)
> |
> + libOne (compile)
> {code}
> With this layout our application only needs {{libOne}} during tests but at
> the same time we depend on {{libTwo}} which in turn depends on {{libOne}}. In
> the end {{libOne}} is required for the application to function. Unfortunately
> it gets excluded by {{copy-dependencies}} with {{scope=runtime}}. This is a
> nasty surprise given the documentation
> [https://maven.apache.org/plugins/maven-dependency-plugin/copy-dependencies-mojo.html#includeScope]
> says
> {quote}The scopes being interpreted are the scopes as Maven sees them, not as
> specified in the pom.
> {quote}
> Surely, Maven should see {{libOne}} as a runtime thing when resolving
> dependencies...
> Below is a full POM that reproduces the case (with arbitrary libraries
> though).
> We have {{logback-access}} as compile dependency and it should bring
> {{logback-core}} with it but because we also declare {{logback-core}} as a
> test dependency for the application - it gets demoted to test only and not
> included into {{lib/}} directory.
> {code:xml}
>
> http://maven.apache.org/POM/4.0.0;
> xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance;
> xsi:schemaLocation="http://maven.apache.org/POM/4.0.0
> http://maven.apache.org/maven-v4_0_0.xsd;>
> 4.0.0
> test
> pom-test
> 0.1
> jar
>
>
>
> org.apache.maven.plugins
> maven-compiler-plugin
> 3.1
>
>
> org.apache.maven.plugins
> maven-dependency-plugin
> 3.1.2
>
>
> copy-dependencies
> package
>
> copy-dependencies
>
>
>
> ${project.build.directory}/lib
>
> runtime
>
>
>
>
>
>
>
>
> ch.qos.logback
> logback-access
> 1.2.2
>
>
> ch.qos.logback
> logback-core
> 1.2.2
>
>
>
> test
>
>
> org.slf4j
> slf4j-api
> 1.7.25
>
> test
>
>
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MDEP-643) includeGroupIds ending with ".pom" lead to error
[ https://issues.apache.org/jira/browse/MDEP-643?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17100934#comment-17100934 ] John Lin commented on MDEP-643: --- Question: I didn't see the option "includeGroupIds" in the documentation https://maven.apache.org/plugins/maven-dependency-plugin/unpack-mojo.html. Did I miss something? > includeGroupIds ending with ".pom" lead to error > > > Key: MDEP-643 > URL: https://issues.apache.org/jira/browse/MDEP-643 > Project: Maven Dependency Plugin > Issue Type: Bug > Components: unpack-dependencies >Affects Versions: 3.1.1 > Environment: MacOS, Intelij Idea with built-in-terminal >Reporter: Arnd Horstmann >Priority: Major > > a set of dependencies to third-party-jars, which I have to unpack, ends with > ".pom" in groupId. > When I try to include this groupId with , I get this Error > with "mvn clean install": > No such archiver: 'pom'. > If I rename the groupId in my local .m2-repository (and the effected pom), > everything just works fine. > By the way: I didn't try ".pom." as a qualifier in the middle... -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MDEP-679) mvn dependency:analyze detected wrong transitive dependency
[
https://issues.apache.org/jira/browse/MDEP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17064132#comment-17064132
]
John Lin commented on MDEP-679:
---
bq. I was looking at another one today where a dependency was listed as
declared but not used. I took it out, and it immediately listed as used but not
declared. WTF?
Can you please state more details about how is this issue related to my issue?
> mvn dependency:analyze detected wrong transitive dependency
> ---
>
> Key: MDEP-679
> URL: https://issues.apache.org/jira/browse/MDEP-679
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: analyze
>Affects Versions: 3.1.1
>Reporter: John Lin
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> To illustrate this issue, I created a sample project here:
> [https://github.com/johnlinp/misc-demo/tree/master/maven-dependency-analyze-dnsjava]
> The dependency tree is like this:
> {code:java}
> My app ---> ApacheJMeter_http ---> dnsjava
> {code}
> I didn't use any code directly from the artifact {{dnsjava}} in my app. I
> only used {{ApacheJMeter_http}}. However, the command {{mvn
> dependency:analyze}} will report a used undeclared dependency: {{dnsjava}}.
> {code:java}
> [INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @
> maven-dependency-analyze-dnsjava ---
> [WARNING] Used undeclared dependencies found:
> [WARNING]dnsjava:dnsjava:jar:2.1.9:runtime {code}
> It seems that the problem came from the line:
> {code:java}
> map.put("update", null);
> {code}
> If I change it into {{map.put("create", null);}} or even {{map.put("UPDATE",
> null);}}, the problem will disappear. Therefore, I think there might be
> something to do with the string "update".
> Note that this issue is not reproducible in maven-dependency-plugin:2.8.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MDEP-679) mvn dependency:analyze detected wrong transitive dependency
[
https://issues.apache.org/jira/browse/MDEP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17061283#comment-17061283
]
John Lin commented on MDEP-679:
---
I've submitted a PR:
[https://github.com/apache/maven-dependency-analyzer/pull/7]
The root cause is that the component that parses references in classes treat
string literals as class/method names. It happens that there is a class called
"update.class" in dnsjava-2.1.9.jar, without any package prefix. Therefore,
maven-dependency-analyzer would think my app uses dnsjava as a direct
dependency.
My fix to this issue is to exclude string literals when parsing the references.
> mvn dependency:analyze detected wrong transitive dependency
> ---
>
> Key: MDEP-679
> URL: https://issues.apache.org/jira/browse/MDEP-679
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: analyze
>Affects Versions: 3.1.1
>Reporter: John Lin
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> To illustrate this issue, I created a sample project here:
> [https://github.com/johnlinp/misc-demo/tree/master/maven-dependency-analyze-dnsjava]
> The dependency tree is like this:
> {code:java}
> My app ---> ApacheJMeter_http ---> dnsjava
> {code}
> I didn't use any code directly from the artifact {{dnsjava}} in my app. I
> only used {{ApacheJMeter_http}}. However, the command {{mvn
> dependency:analyze}} will report a used undeclared dependency: {{dnsjava}}.
> {code:java}
> [INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @
> maven-dependency-analyze-dnsjava ---
> [WARNING] Used undeclared dependencies found:
> [WARNING]dnsjava:dnsjava:jar:2.1.9:runtime {code}
> It seems that the problem came from the line:
> {code:java}
> map.put("update", null);
> {code}
> If I change it into {{map.put("create", null);}} or even {{map.put("UPDATE",
> null);}}, the problem will disappear. Therefore, I think there might be
> something to do with the string "update".
> Note that this issue is not reproducible in maven-dependency-plugin:2.8.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (MDEP-679) mvn dependency:analyze detected wrong transitive dependency
[
https://issues.apache.org/jira/browse/MDEP-679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
John Lin updated MDEP-679:
--
Description:
To illustrate this issue, I created a sample project here:
[https://github.com/johnlinp/misc-demo/tree/master/maven-dependency-analyze-dnsjava]
The dependency tree is like this:
{code:java}
My app ---> ApacheJMeter_http ---> dnsjava
{code}
I didn't use any code directly from the artifact {{dnsjava}} in my app. I only
used {{ApacheJMeter_http}}. However, the command {{mvn dependency:analyze}}
will report a used undeclared dependency: {{dnsjava}}.
{code:java}
[INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @
maven-dependency-analyze-dnsjava ---
[WARNING] Used undeclared dependencies found:
[WARNING]dnsjava:dnsjava:jar:2.1.9:runtime {code}
It seems that the problem came from the line:
{code:java}
map.put("update", null);
{code}
If I change it into {{map.put("create", null);}} or even {{map.put("UPDATE",
null);}}, the problem will disappear. Therefore, I think there might be
something to do with the string "update".
Note that this issue is not reproducible in maven-dependency-plugin:2.8.
was:
To illustrate this issue, I created a sample project here:
https://github.com/johnlinp/misc-demo/tree/master/maven-dependency-analyze-dnsjava
The dependency tree is like this:
{code}
My app ---> ApacheJMeter_http ---> dnsjava
{code}
I didn't use any code directly from the artifact {{dnsjava}} in my app. I only
used {{ApacheJMeter_http}}. However, the command {{mvn dependency:analyze}}
will report a used undeclared dependency: {{dnsjava}}.
It seems that the problem came from the line:
{code}
map.put("update", null);
{code}
If I change it into {{map.put("create", null);}} or even {{map.put("UPDATE",
null);}}, the problem will disappear. Therefore, I think there might be
something to do with the string "update".
Note that this issue is not reproducible in maven-dependency-plugin:2.8.
> mvn dependency:analyze detected wrong transitive dependency
> ---
>
> Key: MDEP-679
> URL: https://issues.apache.org/jira/browse/MDEP-679
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: analyze
>Affects Versions: 3.1.1
>Reporter: John Lin
>Priority: Major
>
> To illustrate this issue, I created a sample project here:
> [https://github.com/johnlinp/misc-demo/tree/master/maven-dependency-analyze-dnsjava]
> The dependency tree is like this:
> {code:java}
> My app ---> ApacheJMeter_http ---> dnsjava
> {code}
> I didn't use any code directly from the artifact {{dnsjava}} in my app. I
> only used {{ApacheJMeter_http}}. However, the command {{mvn
> dependency:analyze}} will report a used undeclared dependency: {{dnsjava}}.
> {code:java}
> [INFO] --- maven-dependency-plugin:3.1.1:analyze (default-cli) @
> maven-dependency-analyze-dnsjava ---
> [WARNING] Used undeclared dependencies found:
> [WARNING]dnsjava:dnsjava:jar:2.1.9:runtime {code}
> It seems that the problem came from the line:
> {code:java}
> map.put("update", null);
> {code}
> If I change it into {{map.put("create", null);}} or even {{map.put("UPDATE",
> null);}}, the problem will disappear. Therefore, I think there might be
> something to do with the string "update".
> Note that this issue is not reproducible in maven-dependency-plugin:2.8.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (MDEP-679) mvn dependency:analyze detected wrong transitive dependency
John Lin created MDEP-679:
-
Summary: mvn dependency:analyze detected wrong transitive
dependency
Key: MDEP-679
URL: https://issues.apache.org/jira/browse/MDEP-679
Project: Maven Dependency Plugin
Issue Type: Bug
Components: analyze
Affects Versions: 3.1.1
Reporter: John Lin
To illustrate this issue, I created a sample project here:
https://github.com/johnlinp/misc-demo/tree/master/maven-dependency-analyze-dnsjava
The dependency tree is like this:
{code}
My app ---> ApacheJMeter_http ---> dnsjava
{code}
I didn't use any code directly from the artifact {{dnsjava}} in my app. I only
used {{ApacheJMeter_http}}. However, the command {{mvn dependency:analyze}}
will report a used undeclared dependency: {{dnsjava}}.
It seems that the problem came from the line:
{code}
map.put("update", null);
{code}
If I change it into {{map.put("create", null);}} or even {{map.put("UPDATE",
null);}}, the problem will disappear. Therefore, I think there might be
something to do with the string "update".
Note that this issue is not reproducible in maven-dependency-plugin:2.8.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MRELEASE-1008) Changed formatting of pom file for multiline attributes during version bump
[ https://issues.apache.org/jira/browse/MRELEASE-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953500#comment-16953500 ] John Lin edited comment on MRELEASE-1008 at 10/17/19 8:29 AM: -- Maven Release Plugin uses JDOM to write XML documents: [https://github.com/apache/maven-release/blob/master/maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom/JDomModelETL.java#L211-L231] Since JDOM doesn't support modifying the XML document without changing the original XML format, this issue seems to be unsolvable. There may be some other opensource projects mentioned [here|https://stackoverflow.com/questions/2499011/modify-xml-node-but-keep-the-xml-file-format-intact] to modify XML document while keeping the original XML format, but they all look like dead projects and are not being maintained. was (Author: johnlinp): Maven Release Plugin use JDOM to write XML documents: [https://github.com/apache/maven-release/blob/master/maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom/JDomModelETL.java#L211-L231] Since JDOM doesn't support modifying the XML document without changing the original XML format, this issue seems to be unsolvable. There may be some other opensource projects mentioned [here|https://stackoverflow.com/questions/2499011/modify-xml-node-but-keep-the-xml-file-format-intact] to modify XML document while keeping the original XML format, but they all look like dead projects and are not being maintained. > Changed formatting of pom file for multiline attributes during version bump > --- > > Key: MRELEASE-1008 > URL: https://issues.apache.org/jira/browse/MRELEASE-1008 > Project: Maven Release Plugin > Issue Type: Bug >Reporter: Roman Ivanov >Priority: Major > > during release, plugin create commit for version bump. > BUT in addition to this it change formatting of some tags - > https://github.com/checkstyle/checkstyle/commit/29a635421d9292673bbaaf0c0693d2191dfb5f18 > Plugin changes multiline attributes formatting to single-line. > In Checkstyle project we control length of lines in files to ease code review > in web. This allow us to avoid vertical scrolls, .. . > Such unexpected change triggered build problem right after release and make > it impossible to keep user-defined formatting . > Also reported at: > https://stackoverflow.com/questions/49085502/maven-release-plugin-changes-pom-formatting -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-1008) Changed formatting of pom file for multiline attributes during version bump
[ https://issues.apache.org/jira/browse/MRELEASE-1008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16953500#comment-16953500 ] John Lin commented on MRELEASE-1008: Maven Release Plugin use JDOM to write XML documents: [https://github.com/apache/maven-release/blob/master/maven-release-manager/src/main/java/org/apache/maven/shared/release/transform/jdom/JDomModelETL.java#L211-L231] Since JDOM doesn't support modifying the XML document without changing the original XML format, this issue seems to be unsolvable. There may be some other opensource projects mentioned [here|https://stackoverflow.com/questions/2499011/modify-xml-node-but-keep-the-xml-file-format-intact] to modify XML document while keeping the original XML format, but they all look like dead projects and are not being maintained. > Changed formatting of pom file for multiline attributes during version bump > --- > > Key: MRELEASE-1008 > URL: https://issues.apache.org/jira/browse/MRELEASE-1008 > Project: Maven Release Plugin > Issue Type: Bug >Reporter: Roman Ivanov >Priority: Major > > during release, plugin create commit for version bump. > BUT in addition to this it change formatting of some tags - > https://github.com/checkstyle/checkstyle/commit/29a635421d9292673bbaaf0c0693d2191dfb5f18 > Plugin changes multiline attributes formatting to single-line. > In Checkstyle project we control length of lines in files to ease code review > in web. This allow us to avoid vertical scrolls, .. . > Such unexpected change triggered build problem right after release and make > it impossible to keep user-defined formatting . > Also reported at: > https://stackoverflow.com/questions/49085502/maven-release-plugin-changes-pom-formatting -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (MDEP-646) mvn dependency:analyze mistakenly treat backward compatible classes as used undeclared
John Lin created MDEP-646:
-
Summary: mvn dependency:analyze mistakenly treat backward
compatible classes as used undeclared
Key: MDEP-646
URL: https://issues.apache.org/jira/browse/MDEP-646
Project: Maven Dependency Plugin
Issue Type: Bug
Components: analyze
Affects Versions: 3.1.1
Reporter: John Lin
I have the following dependency in my {{pom.xml}}:
{code}
org.apache.cassandra
cassandra-all
2.1.8
{code}
Then a piece of code in my app:
{code}
import java.util.concurrent.ConcurrentHashMap;
public class App {
public void foo () {
ConcurrentHashMap m = new ConcurrentHashMap<>();
...
}
}
{code}
Then {{mvn dependency:analyze}} will find a used undeclared dependency:
{code}
[WARNING] Used undeclared dependencies found:
[WARNING]com.boundary:high-scale-lib:jar:1.0.6:compile
{code}
It turns out that {{cassandra-all}} has a dependency on {{high-scale-lib}}, and
{{high-scale-lib}} implemented a {{java.util.concurrent.ConcurrentHashMap}} for
backward compatibility.
In fact, my app use the built-in {{ConcurrentHashMap}} in JDK, not the
{{ConcurrentHashMap}} from {{high-scale-lib}}. So I believe that it is
incorrect for the dependency analysis to report it as used.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MDEP-645) List classes in a given artifact
John Lin created MDEP-645:
-
Summary: List classes in a given artifact
Key: MDEP-645
URL: https://issues.apache.org/jira/browse/MDEP-645
Project: Maven Dependency Plugin
Issue Type: New Feature
Reporter: John Lin
When I want to list all the classes in a given artifact, I have to use {{jar}}
command to show files in the corresponding .jar file.
For example, I want to list all the classes in the artifact
{code}
org.apache.commons:commons-lang3:3.6
{code}
I have to run
{code}
jar tf
~/.m2/repository/org/apache/commons/commons-lang3/3.6/commons-lang3-3.6.jar
{code}
This method has some disadvantages:
# The jar file may not be downloaded, so it may not be in {{~/.m2/repository}}.
# It's kind of tedious to type such a long filename.
# The output is shown in raw filenames, e.g.,
{{org/apache/commons/lang3/SystemUtils.class}}, but I generally want a package
+ class name {{org.apache.commons.lang3.SystemUtils}}.
So I would expect a goal called {{show}} with an argument {{artifact}}, so I
can type
{code}
mvn dependency:show -Dartifact=org.apache.commons:commons-lang3:3.6
{code}
to show
{code}
org.apache.commons.lang3.CharUtils
org.apache.commons.lang3.RandomStringUtils
...
{code}
What do you guys think? Thanks.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MDEP-644) Reintroduce the verbose option for dependency:tree
[ https://issues.apache.org/jira/browse/MDEP-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16803496#comment-16803496 ] John Lin commented on MDEP-644: --- Hi Robert, Yes, I would like to implement it. Is there any relevant material you suggest to read? Thank you. > Reintroduce the verbose option for dependency:tree > -- > > Key: MDEP-644 > URL: https://issues.apache.org/jira/browse/MDEP-644 > Project: Maven Dependency Plugin > Issue Type: New Feature > Components: tree >Reporter: John Lin >Priority: Major > > The verbose option for dependency:tree is removed in maven-dependency-plugin > 3.0. This issue is to reintroduce the option. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MDEP-494) Remove/replace Maven2 specific code
[ https://issues.apache.org/jira/browse/MDEP-494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802468#comment-16802468 ] John Lin commented on MDEP-494: --- Hi, I created https://issues.apache.org/jira/browse/MDEP-644 to reintroduce the verbose option for dependency:tree. > Remove/replace Maven2 specific code > --- > > Key: MDEP-494 > URL: https://issues.apache.org/jira/browse/MDEP-494 > Project: Maven Dependency Plugin > Issue Type: Improvement >Reporter: Robert Scholte >Assignee: Robert Scholte >Priority: Major > Fix For: 3.0.0 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MDEP-644) Reintroduce the verbose option for dependency:tree
John Lin created MDEP-644: - Summary: Reintroduce the verbose option for dependency:tree Key: MDEP-644 URL: https://issues.apache.org/jira/browse/MDEP-644 Project: Maven Dependency Plugin Issue Type: New Feature Components: tree Reporter: John Lin The verbose option for dependency:tree is removed in maven-dependency-plugin 3.0. This issue is to reintroduce the option. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MDEP-639) Not showing omitted dependencies when running dependency:tree verbose
[
https://issues.apache.org/jira/browse/MDEP-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802464#comment-16802464
]
John Lin edited comment on MDEP-639 at 3/27/19 5:41 AM:
It seems that it is expected:
[https://github.com/apache/maven-dependency-plugin/pull/4/files|https://github.com/apache/maven-dependency-plugin/pull/4/files.].
They removed the verbose option since maven-dependency-plugin 3.0.
was (Author: johnlinp):
It seems that it is expected:
[https://github.com/apache/maven-dependency-plugin/pull/4/files|https://github.com/apache/maven-dependency-plugin/pull/4/files.].
They removed the verbose option in Maven 3.0.
> Not showing omitted dependencies when running dependency:tree verbose
> -
>
> Key: MDEP-639
> URL: https://issues.apache.org/jira/browse/MDEP-639
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: tree
>Affects Versions: 3.1.1
> Environment: Ubuntu 18.04.1 LTS (64-bit) Bionic Beaver Linux
> 4.15.0-44-generic x86_64
>Reporter: Grzegorz Solecki
>Priority: Major
>
> When you run:
> {code:sh}
> $ mvn dependency:tree -Dverbose
> {code}
> it does not show omitted dependencies.
> It happens for version 3+.
> When I change to 2.10 it is working flawlessly
> Environment details:
> {code:sh}
> $ mvn -version
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
> 2018-10-24T14:41:47-04:00)
> Maven home: /home/grzsol1/dev/tls/mvn/current
> Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
> /home/grzsol1/dev/jdk/jdk1.8.0_191/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-44-generic", arch: "amd64", family: "unix"
> Ubuntu 18.04.1 LTS (64-bit) Bionic Beaver Linux 4.15.0-44-generic x86_64
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MDEP-639) Not showing omitted dependencies when running dependency:tree verbose
[
https://issues.apache.org/jira/browse/MDEP-639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16802464#comment-16802464
]
John Lin commented on MDEP-639:
---
It seems that it is expected:
[https://github.com/apache/maven-dependency-plugin/pull/4/files|https://github.com/apache/maven-dependency-plugin/pull/4/files.].
They removed the verbose option in Maven 3.0.
> Not showing omitted dependencies when running dependency:tree verbose
> -
>
> Key: MDEP-639
> URL: https://issues.apache.org/jira/browse/MDEP-639
> Project: Maven Dependency Plugin
> Issue Type: Bug
> Components: tree
>Affects Versions: 3.1.1
> Environment: Ubuntu 18.04.1 LTS (64-bit) Bionic Beaver Linux
> 4.15.0-44-generic x86_64
>Reporter: Grzegorz Solecki
>Priority: Major
>
> When you run:
> {code:sh}
> $ mvn dependency:tree -Dverbose
> {code}
> it does not show omitted dependencies.
> It happens for version 3+.
> When I change to 2.10 it is working flawlessly
> Environment details:
> {code:sh}
> $ mvn -version
> Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3;
> 2018-10-24T14:41:47-04:00)
> Maven home: /home/grzsol1/dev/tls/mvn/current
> Java version: 1.8.0_191, vendor: Oracle Corporation, runtime:
> /home/grzsol1/dev/jdk/jdk1.8.0_191/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.15.0-44-generic", arch: "amd64", family: "unix"
> Ubuntu 18.04.1 LTS (64-bit) Bionic Beaver Linux 4.15.0-44-generic x86_64
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (MNG-6559) Mailing list URL is incorrect in CONTRIBUTING.md
[ https://issues.apache.org/jira/browse/MNG-6559?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Lin updated MNG-6559: -- Description: The mailing list URL in CONTRIBUTING.md is currently [https://maven.apache.org/mail-lists.html], but it should have been [https://maven.apache.org/mailing-lists.html]. Besides, I also found that problem in [https://github.com/apache/maven/tree/master/apache-maven|https://github.com/apache/maven/tree/master/apache-maven]. was:The mailing list URL in CONTRIBUTING.md is currently [https://maven.apache.org/mail-lists.html], but it should have been [https://maven.apache.org/mailing-lists.html]. > Mailing list URL is incorrect in CONTRIBUTING.md > > > Key: MNG-6559 > URL: https://issues.apache.org/jira/browse/MNG-6559 > Project: Maven > Issue Type: Bug > Components: Documentation: General >Reporter: John Lin >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > The mailing list URL in CONTRIBUTING.md is currently > [https://maven.apache.org/mail-lists.html], but it should have been > [https://maven.apache.org/mailing-lists.html]. > Besides, I also found that problem in > [https://github.com/apache/maven/tree/master/apache-maven|https://github.com/apache/maven/tree/master/apache-maven]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MNG-6559) Mailing list URL is incorrect in CONTRIBUTING.md
John Lin created MNG-6559: - Summary: Mailing list URL is incorrect in CONTRIBUTING.md Key: MNG-6559 URL: https://issues.apache.org/jira/browse/MNG-6559 Project: Maven Issue Type: Bug Components: Documentation: General Reporter: John Lin The mailing list URL in CONTRIBUTING.md is currently [https://maven.apache.org/mail-lists.html], but it should have been [https://maven.apache.org/mailing-lists.html]. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
