[jira] [Commented] (DOXIA-707) Ability to define lineneding for generated content
[
https://issues.apache.org/jira/browse/DOXIA-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17779329#comment-17779329
]
Roman Ivanov commented on DOXIA-707:
[~michael-o], do you think that implementation of PrintWriter
As is done at https://github.com/checkstyle/checkstyle/pull/13947 is good
approach?
It looks weird that method
public void write(String line, int offset, int length) {
needs to be override with replacement of what is done by some other content
generator.
Method exists to fix problems of other logic.
> Ability to define lineneding for generated content
> --
>
> Key: DOXIA-707
> URL: https://issues.apache.org/jira/browse/DOXIA-707
> Project: Maven Doxia
> Issue Type: Improvement
>Reporter: Roman Ivanov
>Priority: Major
>
> in Checkstyle project we use doxia classes to generate xml files in xdoc
> format
> https://github.com/checkstyle/checkstyle/issues/13770
> We have a rule that all files in our git repo are Linux line-ending.
> Lunux/unix users are ok, but windows users have inconvenience that after
> build execution xdoc files are marked as changes in git, due to change in
> lineending.
> Right now we do hack with override of some doxia classes to enforce
> lineending that we need.
> It would be awesome if we can defined lineending in some config or system
> variable or
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (DOXIA-707) Ability to define lineneding for generated content
Roman Ivanov created DOXIA-707: -- Summary: Ability to define lineneding for generated content Key: DOXIA-707 URL: https://issues.apache.org/jira/browse/DOXIA-707 Project: Maven Doxia Issue Type: Improvement Reporter: Roman Ivanov in Checkstyle project we use doxia classes to generate xml files in xdoc format https://github.com/checkstyle/checkstyle/issues/13770 We have a rule that all files in our git repo are Linux line-ending. Lunux/unix users are ok, but windows users have inconvenience that after build execution xdoc files are marked as changes in git, due to change in lineending. Right now we do hack with override of some doxia classes to enforce lineending that we need. It would be awesome if we can defined lineending in some config or system variable or -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCHECKSTYLE-342) Support XML 1.1
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17614490#comment-17614490 ] Roman Ivanov commented on MCHECKSTYLE-342: -- [~eolivelli], can you reopen issue ? > Support XML 1.1 > --- > > Key: MCHECKSTYLE-342 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-342 > Project: Maven Checkstyle Plugin > Issue Type: New Feature > Components: checkstyle:check >Affects Versions: 2.17 >Reporter: richard >Assignee: Enrico Olivelli >Priority: Minor > > Checkstyle wishes to upgrade our XML logger to print out XML 1.1 documents. > We need this functionality to support escaping non-printable characters as > XML 1.0 doesn't allow this and considers it an invalid document. > > Exception in thread "main" javax.xml.stream.XMLStreamException: ParseError > > at [row,col]:[45615,80] > > Message: An invalid XML character (Unicode: 0x2) was found in the value of > > attribute "message" and element is "error". > Checkstyle cannot upgrade until maven-checkstyle does as we use it in alot of > regression testing. If we try to give the plugin an XML 1.1 document, it > fails with the following error: > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) > > on project postgresql: Unable to read Checkstyle results xml: > > /pipeline/source/pgjdbc/pgjdbc/target/checkstyle-result.xml: only 1.0 is > > supported as > version="1.1"... @1:19) -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MLINKCHECK-28) javax.net.ssl.SSLHandshakeException : Received fatal alert: handshake_failure
[
https://issues.apache.org/jira/browse/MLINKCHECK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17084904#comment-17084904
]
Roman Ivanov commented on MLINKCHECK-28:
checkstyle project is on jdk8 from May 29, 2016 , so this issue was created
when we were on jdk8 (we still use jdk8).
You can reproduce issue by execution of ".ci/run-link-check-plugin.sh" in our
repo.
Here is logs of execution of this command -
https://app.codeship.com/projects/124310
> javax.net.ssl.SSLHandshakeException : Received fatal alert: handshake_failure
> -
>
> Key: MLINKCHECK-28
> URL: https://issues.apache.org/jira/browse/MLINKCHECK-28
> Project: Maven Linkcheck Plugin
> Issue Type: Bug
>Affects Versions: 1.2
> Environment: Linux pc 4.4.0-59-generic #80-Ubuntu x86_64
>Reporter: Roman Ivanov
>Priority: Major
>
> reproducible on CI and on ubuntu 16.04.
> Link to repo: https://github.com/checkstyle/checkstyle
> CI logs: https://codeship.com/projects/124310/builds/22118854
> config: https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L1151
> It worked fine at 14:55 2017-01-26 on this CI, and failed at 17:51
> 2017-01-26. No config changes on checkstyle side, probably smth is changed on
> sourceforge side.
> Command in CI:
> {code}
> uname -a && mvn --version && curl -I http://checkstyle.sourceforge.net/ &&
> mvn clean site -Dcheckstyle.ant.skip=true -DskipTests -DskipITs
> -Dpmd.skip=true -Dfindbugs.skip=true -Dcobertura.skip=true
> -Dcheckstyle.skip=true && echo " grep of linkcheck.html--BEGIN"
> && grep externalLink target/site/linkcheck.html | cat && echo "
> grep of linkcheck.html--END" && RESULT=$(grep externalLink
> target/site/linkcheck.html | grep -v 'Read timed out' | wc -l) && echo 'Exit
> code:'$RESULT && if [[ $RESULT != 0 ]]; then false; fi
> {code}
> Problems with following links:
> https://sourceforge.net/p/checkstyle/news/feed
> https://sourceforge.net/projects/checkstyle/
> https://sourceforge.net/projects/checkstyle/files/checkstyle/
> Curl output right after maven execution, the same in CI:
> {code}
> $ curl -I https://sourceforge.net/projects/checkstyle/
> HTTP/1.1 200 OK
> Server: nginx
> Date: Sat, 28 Jan 2017 14:05:47 GMT
> Content-Type: text/html; charset=utf-8
>
> {code}
> HTML Report chunk:
> {code}
> href="https://sourceforge.net/p/checkstyle/news/feed;>https://sourceforge.net/p/checkstyle/news/feed:
> javax.net.ssl.SSLHandshakeException : Received fatal alert:
> handshake_failure
> href="https://sourceforge.net/projects/checkstyle/;>https://sourceforge.net/projects/checkstyle/:
> javax.net.ssl.SSLHandshakeException : Received fatal alert:
> handshake_failure
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (MCHECKSTYLE-384) Incompatibility to Checkstyle version >= 8.24
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17005365#comment-17005365
]
Roman Ivanov commented on MCHECKSTYLE-384:
--
Sorry for causing problems during updates.
Reason of why checkstyle is not following semantic versioning:
https://checkstyle.org/#Development_Cycle
https://github.com/checkstyle/checkstyle/issues/3709
8.X versions is full of heavy damages for compatibility, that we postponed for
many years.
Plugin can do nothing with this change, user config changes are unavoidable.
This issue should be closed.
> That should have been checkstyle 9.x
unfortunately no, minor version (it is minor update from checkstyle
perspective, there are bunch of others updates happening that require config
update) in checkstyle mean some non-bugs features are introduces. Other
plugins(eclipse-cs , sonar) have to be updated even when new Check is
introduced.
We will bump to 9.x probably when we update minimal jdk version or something
really big.
> Incompatibility to Checkstyle version >= 8.24
> --
>
> Key: MCHECKSTYLE-384
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-384
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:check
>Affects Versions: 3.1.0
>Reporter: Martin
>Priority: Blocker
>
> The latest {{maven-checkstyle-plugin}} is incompatible to Checkstyle version
> 8.24 and newer. The check for "LineLength" was moved from "TreeWalker" to
> "Checker".
> For further details see "Breaking backward compatibility" under
> https://checkstyle.org/releasenotes.html#Release_8.24
>
> {code:none|title=Maven Console Output}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.0:check (validate) on
> project top-secrect: Failed during checkstyle configuration: LineLength is
> not allowed as a child in Checker -> [Help 1]
> [ERROR] ...
> {code}
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (MCHECKSTYLE-312) Custom Checks are not shown at Rules sections
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000266#comment-17000266 ] Roman Ivanov edited comment on MCHECKSTYLE-312 at 12/19/19 6:29 PM: it is maven checkstyle plugin issue. Checkstyle library team noticed such issue during development. was (Author: romani): it is checkstyle plugin issue. Checkstyle library team noticed such issue during development. > Custom Checks are not shown at Rules sections > - > > Key: MCHECKSTYLE-312 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-312 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.16 > Environment: linux >Reporter: Roman Ivanov >Priority: Major > Attachments: Screenshot-empty-Rules-for-custom-Checks.png > > > Report example - http://vladlis.github.io/reports/static_check/orekit_before/ > If link does not exists, see attached image. > Problem: Custom checks are not show in Rules section, that make it hard to > understand how Check was configured to report that amount of violations. > Expected: Rules section should contain all checks that are used in config and > there options(parameters). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MCHECKSTYLE-312) Custom Checks are not shown at Rules sections
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17000266#comment-17000266 ] Roman Ivanov commented on MCHECKSTYLE-312: -- it is checkstyle plugin issue. Checkstyle library team noticed such issue during development. > Custom Checks are not shown at Rules sections > - > > Key: MCHECKSTYLE-312 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-312 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.16 > Environment: linux >Reporter: Roman Ivanov >Priority: Major > Attachments: Screenshot-empty-Rules-for-custom-Checks.png > > > Report example - http://vladlis.github.io/reports/static_check/orekit_before/ > If link does not exists, see attached image. > Problem: Custom checks are not show in Rules section, that make it hard to > understand how Check was configured to report that amount of violations. > Expected: Rules section should contain all checks that are used in config and > there options(parameters). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (MRELEASE-799) update-versions fails when the project artifact is used with a version other than the current snapshot
[
https://issues.apache.org/jira/browse/MRELEASE-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16958869#comment-16958869
]
Roman Ivanov commented on MRELEASE-799:
---
issue is still reproducible. See details on attempt to bump version of plugin
in checkstyle project - https://github.com/checkstyle/checkstyle/pull/7217
Yes we use different version of ourself/itself in special plugin, but it is
valid usage.
To reproduce, bump maven-release-plugin version to 2.5.3
Command:
{code}
mvn -e release:prepare -DdryRun=true --batch-mode -Darguments='-DskipTests
-DskipITs \
-Djacoco.skip=true -Dpmd.skip=true -Dspotbugs.skip=true -Dxml.skip=true \
-Dcheckstyle.ant.skip=true -Dcheckstyle.skip=true -Dgpg.skip=true'
{code}
output:
{code}
[INFO]
[INFO] Building checkstyle 8.26-SNAPSHOT
[INFO]
[INFO]
[INFO] --- maven-release-plugin:2.5.3:prepare (default-cli) @ checkstyle ---
[INFO] Verifying that there are no local modifications...
[INFO] ignoring changes on: **/pom.xml.releaseBackup, **/pom.xml.next,
**/pom.xml.tag, **/pom.xml.branch, **/release.properties, **/pom.xml.backup
[INFO] Executing: /bin/sh -c cd /home/rivanov/java/github/romani/checkstyle &&
git rev-parse --show-toplevel
[INFO] Working directory: /home/rivanov/java/github/romani/checkstyle
[INFO] Executing: /bin/sh -c cd /home/rivanov/java/github/romani/checkstyle &&
git status --porcelain .
[INFO] Working directory: /home/rivanov/java/github/romani/checkstyle
[WARNING] Ignoring unrecognized line: ?? release.properties
[INFO] Checking dependencies and plugins for snapshots ...
[INFO] Transforming 'checkstyle'...
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 1.337 s
[INFO] Finished at: 2019-10-24T05:44:02-07:00
[INFO] Final Memory: 21M/384M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) on
project checkstyle: The artifact (com.puppycrawl.tools:checkstyle) requires a
different version (8.26) than what is found (8.18) for the expression
(maven.sevntu-checkstyle-check.checkstyle.version) in the project
(com.puppycrawl.tools:checkstyle). -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-release-plugin:2.5.3:prepare (default-cli) on
project checkstyle: The artifact (com.puppycrawl.tools:checkstyle) requires a
different version (8.26) than what is found (8.18) for the expression
(maven.sevntu-checkstyle-check.checkstyle.version) in the project
(com.puppycrawl.tools:checkstyle).
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:212)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:128)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:307)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:193)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:106)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:863)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:288)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:199)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoFailureException: The artifact
(com.puppycrawl.tools:checkstyle) requires a different version (8.26) than what
is found (8.18) for the
[jira] [Commented] (MCHECKSTYLE-377) Violations or exceptions when using "external" FQCNs in @throws after upgrade to 3.1.0
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16865191#comment-16865191
]
Roman Ivanov commented on MCHECKSTYLE-377:
--
it is limitation of Checkstyle -
https://checkstyle.org/writingchecks.html#Limitations
All classpath activities of Checkstyle are deprecated and will be removed in
future versions.
Thanks a lot for sharing a workaround.
I do believe that issue should be closed, as it is not a plugin problem, it is
problem of checkstyle project, to be exact problem of JavadocMethod module in
checkstyle.
Users can track https://github.com/checkstyle/checkstyle/issues/6802 for more
details.
> Violations or exceptions when using "external" FQCNs in @throws after upgrade
> to 3.1.0
> --
>
> Key: MCHECKSTYLE-377
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-377
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
>Affects Versions: 3.1.0
> Environment: Apache Maven 3.6.1
> (d66c9c0b3152b2e69ee9bac180bb8fcc8e6af555; 2019-04-04T21:00:29+02:00)
> Java version: 1.8.0_202, vendor: Oracle Corporation
> Default locale: de_DE, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
>Reporter: Falko Modler
>Priority: Major
>
> I started to see strange violations and even exceptions after upgrading
> checkstyle-plugin from 3.0.0 and 3.1.0. Please note that I pinned Checkstyle
> to 8.7, so the Checkstyle version itself did _not_ change in my setup.
> The problem boils down to Checkstyle not being able anymore to load classes
> that reside in dependencies (= not im the same project as the checked class)
> when using fully qualified class names in {{@throws}} tags, e.g.:
> {code:java}
> /**
> * Foo.
> * @throws some.other.project.SomeException some exception.
> */
> public void foo() throws SomeException {
> // ...
> }
> {code}
> Please note that the actual throws declaration does _not_ use the fully
> qualified class name.
> While this might be an inconsistent/non DRY approach, it is not forbidden by
> JavaDoc or the compiler.
> In one case (where the exception resides in an external dependency), this
> resulted in a violation:
> {noformat}
> JavadocMethod: Expected @throws tag for 'SomeException'.
> {noformat}
> In another case (where the exception resides in the same module but
> implements an interface that resides in another module of the project being
> built), this resulted in an exception:
> {noformat}
> [...]
> Caused by: java.lang.NoClassDefFoundError:
> some/project/othermodule/SomeInterface
> at java.lang.ClassLoader.defineClass1(Native Method)
> at java.lang.ClassLoader.defineClass(ClassLoader.java:763)
> at
> java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
> at java.net.URLClassLoader.defineClass(URLClassLoader.java:468)
> at java.net.URLClassLoader.access$100(URLClassLoader.java:74)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:369)
> at java.net.URLClassLoader$1.run(URLClassLoader.java:363)
> at java.security.AccessController.doPrivileged(Native Method)
> at java.net.URLClassLoader.findClass(URLClassLoader.java:362)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:424)
> at java.lang.ClassLoader.loadClass(ClassLoader.java:357)
> at java.lang.Class.forName0(Native Method)
> at java.lang.Class.forName(Class.java:348)
> at
> com.puppycrawl.tools.checkstyle.checks.javadoc.ClassResolver.safeLoad(ClassResolver.java:216)
> at
> com.puppycrawl.tools.checkstyle.checks.javadoc.ClassResolver.resolve(ClassResolver.java:95)
> at
> com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.resolveClass(AbstractTypeAwareCheck.java:241)
> at
> com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.tryLoadClass(AbstractTypeAwareCheck.java:258)
> at
> com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck$RegularClass.getClazz(AbstractTypeAwareCheck.java:467)
> at
> com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.checkThrowsTags(JavadocMethodCheck.java:909)
> at
> com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.checkComment(JavadocMethodCheck.java:503)
> at
> com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck.processAST(JavadocMethodCheck.java:357)
> at
> com.puppycrawl.tools.checkstyle.checks.javadoc.AbstractTypeAwareCheck.visitToken(AbstractTypeAwareCheck.java:157)
> at
> com.puppycrawl.tools.checkstyle.TreeWalker.notifyVisit(TreeWalker.java:423)
> at
>
[jira] [Comment Edited] (MCHECKSTYLE-376) The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849074#comment-16849074
]
Roman Ivanov edited comment on MCHECKSTYLE-376 at 5/27/19 4:41 PM:
---
I would recommend to release maven plugin on checkstyle 8.20.
when users start to upgrade to new plugin, they will have tons of new
violations in code (few years of tons of bugfixes in checkstyle) as most of
users use default version from plugin.
it is better to not bother them with extensions recompilations, a lot of
companies have their own Checks(extensions), so it is better to not bother them
with extra activity.
Please release plugin.
was (Author: romani):
I would recommend to release maven plugin on checkstyle 8.20.
when users start to upgrade, they will have tons of new violations in code (few
years of tons of bugfixes in checkstyle).
it is better to not bother them with extensions recompilations, a lot of
companies have their own Checks(extensions), so it is better to not bother them
with extra activity.
Please release plugin.
> The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule
> 'NewlineAtEndOfFile' on Windows.
> --
>
> Key: MCHECKSTYLE-376
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-376
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:check
>Reporter: Tibor Digana
>Assignee: Enrico Olivelli
>Priority: Major
> Attachments: linux.zip, windows.zip
>
>
> Afects version 3.1.0 during the release vote.
> It looks like the library expects system based EOL character.
> The checkstyle reports the issue in two files in
> https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
> I doubt it is a problem with these two files, nothing but the library itself.
> No idea why other ITs do not fail on Windows too.
> {noformat}
> mvn -nsu checkstyle:check
> [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @
> mcheckstyle-54 ---
> [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml
> ruleset.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.450 s
> [INFO] Finished at: 2019-05-13T23:42:55+02:00
> [INFO] Final Memory: 12M/193M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check
> (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-376) The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16849074#comment-16849074
]
Roman Ivanov commented on MCHECKSTYLE-376:
--
I would recommend to release maven plugin on checkstyle 8.20.
when users start to upgrade, they will have tons of new violations in code (few
years of tons of bugfixes in checkstyle).
it is better to not bother them with extensions recompilations, a lot of
companies have their own Checks(extensions), so it is better to not bother them
with extra activity.
Please release plugin.
> The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule
> 'NewlineAtEndOfFile' on Windows.
> --
>
> Key: MCHECKSTYLE-376
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-376
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:check
>Reporter: Tibor Digana
>Assignee: Enrico Olivelli
>Priority: Major
> Attachments: linux.zip, windows.zip
>
>
> Afects version 3.1.0 during the release vote.
> It looks like the library expects system based EOL character.
> The checkstyle reports the issue in two files in
> https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
> I doubt it is a problem with these two files, nothing but the library itself.
> No idea why other ITs do not fail on Windows too.
> {noformat}
> mvn -nsu checkstyle:check
> [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @
> mcheckstyle-54 ---
> [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml
> ruleset.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.450 s
> [INFO] Finished at: 2019-05-13T23:42:55+02:00
> [INFO] Final Memory: 12M/193M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check
> (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-376) The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848429#comment-16848429
]
Roman Ivanov commented on MCHECKSTYLE-376:
--
release 8.21 is ready - https://checkstyle.org/releasenotes.html#Release_8.21
BUT we introduced big breaking compatibility for extensions, details of how
execution fails if there was extensions for checkstyle with non-standard Checks
- https://github.com/checkstyle/checkstyle/issues/3417#issuecomment-495998320
it would be better to release maven plugin on 8.20 to let users enjoy long
awaited latest checkstyle withtout requirements to recompile extensions.
> The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule
> 'NewlineAtEndOfFile' on Windows.
> --
>
> Key: MCHECKSTYLE-376
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-376
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:check
>Reporter: Tibor Digana
>Assignee: Enrico Olivelli
>Priority: Major
> Attachments: linux.zip, windows.zip
>
>
> Afects version 3.1.0 during the release vote.
> It looks like the library expects system based EOL character.
> The checkstyle reports the issue in two files in
> https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
> I doubt it is a problem with these two files, nothing but the library itself.
> No idea why other ITs do not fail on Windows too.
> {noformat}
> mvn -nsu checkstyle:check
> [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @
> mcheckstyle-54 ---
> [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml
> ruleset.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.450 s
> [INFO] Finished at: 2019-05-13T23:42:55+02:00
> [INFO] Final Memory: 12M/193M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check
> (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-376) The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843264#comment-16843264
]
Roman Ivanov commented on MCHECKSTYLE-376:
--
So git need to be configured to do clone properly.
Good news, I just merged change
https://github.com/checkstyle/checkstyle/issues/4073 to allow any lineends
symbol by default. It will be released at end of month as 8.21, so if you do
not know how to configure Jenkins build, we probably can simply upgrade to 8.21
( release will be at last weekend of May)
> The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule
> 'NewlineAtEndOfFile' on Windows.
> --
>
> Key: MCHECKSTYLE-376
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-376
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:check
>Reporter: Tibor Digana
>Priority: Major
> Attachments: linux.zip, windows.zip
>
>
> Afects version 3.1.0 during the release vote.
> It looks like the library expects system based EOL character.
> The checkstyle reports the issue in two files in
> https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
> I doubt it is a problem with these two files, nothing but the library itself.
> No idea why other ITs do not fail on Windows too.
> {noformat}
> mvn -nsu checkstyle:check
> [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @
> mcheckstyle-54 ---
> [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml
> ruleset.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.450 s
> [INFO] Finished at: 2019-05-13T23:42:55+02:00
> [INFO] Final Memory: 12M/193M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check
> (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-376) The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843253#comment-16843253
]
Roman Ivanov commented on MCHECKSTYLE-376:
--
I am not sure how Jenkins works in such cases, but I sure it can be read from
logs of build. Can you share link to build or logs?
Users and CI should be accurate with lineends in projects where validation of
them is activated. If nobody care about them, it better to disable Check. Such
Check have option to allow any lineends.
> The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule
> 'NewlineAtEndOfFile' on Windows.
> --
>
> Key: MCHECKSTYLE-376
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-376
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:check
>Reporter: Tibor Digana
>Priority: Major
> Attachments: linux.zip, windows.zip
>
>
> Afects version 3.1.0 during the release vote.
> It looks like the library expects system based EOL character.
> The checkstyle reports the issue in two files in
> https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
> I doubt it is a problem with these two files, nothing but the library itself.
> No idea why other ITs do not fail on Windows too.
> {noformat}
> mvn -nsu checkstyle:check
> [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @
> mcheckstyle-54 ---
> [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml
> ruleset.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.450 s
> [INFO] Finished at: 2019-05-13T23:42:55+02:00
> [INFO] Final Memory: 12M/193M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check
> (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MCHECKSTYLE-376) The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843199#comment-16843199
]
Roman Ivanov edited comment on MCHECKSTYLE-376 at 5/18/19 4:59 PM:
---
8.19 version
Use default config of Check,
https://github.com/checkstyle/checkstyle/blob/checkstyle-8.19/src/main/resources/sun_checks.xml#L56
Documentation state
http://checkstyle.sourceforge.net/version/8.19/config_misc.html#NewlineAtEndOfFile
that default value of lineSeparator is system.
It was like this even in old version
http://checkstyle.sourceforge.net/version/6.18/config_misc.html#NewlineAtEndOfFile
I do not see any recent behavior changes in this Check -
https://github.com/checkstyle/checkstyle/commits/a73ff0890c27cbe8affc1a55f2710a231687bd85/src/main/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheck.java
file
https://github.com/apache/maven-checkstyle-plugin/blob/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54/Mcheckstyle54.java
is recent changes in plugin
Issue is definitely in the way sources are cloned, we had the same problem, and
created help page on how to configure git on windows before clone
https://checkstyle.org/beginning_development.html#Before_development
But checkstyle library can improve message to be exact on expected symbol
"NewlineAtEndOfFile: File does not end with a newline" to be
"NewlineAtEndOfFile: File does not end with a newline #0D0A# for example.
was (Author: romani):
8.19 version
Use default config of Check,
https://github.com/checkstyle/checkstyle/blob/checkstyle-8.19/src/main/resources/sun_checks.xml#L56
Documentation state
http://checkstyle.sourceforge.net/version/8.19/config_misc.html#NewlineAtEndOfFile
that default value of lineSeparator is system.
It was like this even in old version
http://checkstyle.sourceforge.net/version/6.18/config_misc.html#NewlineAtEndOfFile
I do not see any recent behavior changes in this Check -
https://github.com/checkstyle/checkstyle/commits/a73ff0890c27cbe8affc1a55f2710a231687bd85/src/main/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheck.java
file
https://github.com/apache/maven-checkstyle-plugin/blob/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54/Mcheckstyle54.java
is recent changes in plugin
> The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule
> 'NewlineAtEndOfFile' on Windows.
> --
>
> Key: MCHECKSTYLE-376
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-376
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:check
>Reporter: Tibor Digana
>Priority: Major
> Attachments: linux.zip, windows.zip
>
>
> Afects version 3.1.0 during the release vote.
> It looks like the library expects system based EOL character.
> The checkstyle reports the issue in two files in
> https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
> I doubt it is a problem with these two files, nothing but the library itself.
> No idea why other ITs do not fail on Windows too.
> {noformat}
> mvn -nsu checkstyle:check
> [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @
> mcheckstyle-54 ---
> [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml
> ruleset.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.450 s
> [INFO] Finished at: 2019-05-13T23:42:55+02:00
> [INFO] Final Memory: 12M/193M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check
> (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}
--
This
[jira] [Comment Edited] (MCHECKSTYLE-376) The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843199#comment-16843199
]
Roman Ivanov edited comment on MCHECKSTYLE-376 at 5/18/19 4:31 PM:
---
8.19 version
Use default config of Check,
https://github.com/checkstyle/checkstyle/blob/checkstyle-8.19/src/main/resources/sun_checks.xml#L56
Documentation state
http://checkstyle.sourceforge.net/version/8.19/config_misc.html#NewlineAtEndOfFile
that default value of lineSeparator is system.
It was like this even in old version
http://checkstyle.sourceforge.net/version/6.18/config_misc.html#NewlineAtEndOfFile
I do not see any recent behavior changes in this Check -
https://github.com/checkstyle/checkstyle/commits/a73ff0890c27cbe8affc1a55f2710a231687bd85/src/main/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheck.java
file
https://github.com/apache/maven-checkstyle-plugin/blob/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54/Mcheckstyle54.java
is recent changes in plugin
was (Author: romani):
8.19 version
Use default config of Check,
https://github.com/checkstyle/checkstyle/blob/checkstyle-8.19/src/main/resources/sun_checks.xml#L56
Documentation state
http://checkstyle.sourceforge.net/version/8.19/config_misc.html#NewlineAtEndOfFile
that default value of lineSeparator is system.
It was like this even in old version
http://checkstyle.sourceforge.net/version/6.18/config_misc.html#NewlineAtEndOfFile
I do not see any recent behavior changes in this Check -
https://github.com/checkstyle/checkstyle/commits/a73ff0890c27cbe8affc1a55f2710a231687bd85/src/main/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheck.java
...
> The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule
> 'NewlineAtEndOfFile' on Windows.
> --
>
> Key: MCHECKSTYLE-376
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-376
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:check
>Reporter: Tibor Digana
>Priority: Major
> Attachments: linux.zip, windows.zip
>
>
> Afects version 3.1.0 during the release vote.
> It looks like the library expects system based EOL character.
> The checkstyle reports the issue in two files in
> https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
> I doubt it is a problem with these two files, nothing but the library itself.
> No idea why other ITs do not fail on Windows too.
> {noformat}
> mvn -nsu checkstyle:check
> [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @
> mcheckstyle-54 ---
> [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml
> ruleset.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.450 s
> [INFO] Finished at: 2019-05-13T23:42:55+02:00
> [INFO] Final Memory: 12M/193M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check
> (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-376) The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16843199#comment-16843199
]
Roman Ivanov commented on MCHECKSTYLE-376:
--
8.19 version
Use default config of Check,
https://github.com/checkstyle/checkstyle/blob/checkstyle-8.19/src/main/resources/sun_checks.xml#L56
Documentation state
http://checkstyle.sourceforge.net/version/8.19/config_misc.html#NewlineAtEndOfFile
that default value of lineSeparator is system.
It was like this even in old version
http://checkstyle.sourceforge.net/version/6.18/config_misc.html#NewlineAtEndOfFile
I do not see any recent behavior changes in this Check -
https://github.com/checkstyle/checkstyle/commits/a73ff0890c27cbe8affc1a55f2710a231687bd85/src/main/java/com/puppycrawl/tools/checkstyle/checks/NewlineAtEndOfFileCheck.java
...
> The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule
> 'NewlineAtEndOfFile' on Windows.
> --
>
> Key: MCHECKSTYLE-376
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-376
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:check
>Reporter: Tibor Digana
>Priority: Major
> Attachments: linux.zip, windows.zip
>
>
> Afects version 3.1.0 during the release vote.
> It looks like the library expects system based EOL character.
> The checkstyle reports the issue in two files in
> https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
> I doubt it is a problem with these two files, nothing but the library itself.
> No idea why other ITs do not fail on Windows too.
> {noformat}
> mvn -nsu checkstyle:check
> [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @
> mcheckstyle-54 ---
> [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml
> ruleset.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.450 s
> [INFO] Finished at: 2019-05-13T23:42:55+02:00
> [INFO] Final Memory: 12M/193M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check
> (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-375) Upgrade all test XML doctypes
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827612#comment-16827612 ] Roman Ivanov commented on MCHECKSTYLE-375: -- plugin is using old/unsecure urls https://github.com/apache/maven-checkstyle-plugin/search?p=2=Puppy+Crawl_q=Puppy+Crawl so it is vulnerable. > Upgrade all test XML doctypes > - > > Key: MCHECKSTYLE-375 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-375 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:check, checkstyle:checkstyle >Affects Versions: 3.0.0 >Reporter: richard >Priority: Major > > The tests used to test maven-checkstyle are using old DTDs and unsecure > "http" locations. This is related to CVE-2019-9658. The security issue is in > the parser that is used to parse this file. It leaves any code that parses > this file vulnerable to XXE via a MITM. > > All doctypes used in maven-checkstyle repo (configurations, suppressions, > import controls, etc...) should be updated to use the latest URL and public > DOCTYPEs. > Example: > > "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" > "https://checkstyle.org/dtds/configuration_1_3.dtd;> > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MCHECKSTYLE-375) Upgrade all test XML doctypes
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16827612#comment-16827612 ] Roman Ivanov edited comment on MCHECKSTYLE-375 at 4/27/19 1:52 PM: --- plugin is using old/unsecure urls in main code https://github.com/apache/maven-checkstyle-plugin/search?p=2=Puppy+Crawl_q=Puppy+Crawl so it is vulnerable. was (Author: romani): plugin is using old/unsecure urls https://github.com/apache/maven-checkstyle-plugin/search?p=2=Puppy+Crawl_q=Puppy+Crawl so it is vulnerable. > Upgrade all test XML doctypes > - > > Key: MCHECKSTYLE-375 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-375 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:check, checkstyle:checkstyle >Affects Versions: 3.0.0 >Reporter: richard >Priority: Major > > The tests used to test maven-checkstyle are using old DTDs and unsecure > "http" locations. This is related to CVE-2019-9658. The security issue is in > the parser that is used to parse this file. It leaves any code that parses > this file vulnerable to XXE via a MITM. > > All doctypes used in maven-checkstyle repo (configurations, suppressions, > import controls, etc...) should be updated to use the latest URL and public > DOCTYPEs. > Example: > > "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" > "https://checkstyle.org/dtds/configuration_1_3.dtd;> > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MRELEASE-1008) Changed formatting of pom file for multiline attributes during version bump
Roman Ivanov created MRELEASE-1008: -- Summary: Changed formatting of pom file for multiline attributes during version bump Key: MRELEASE-1008 URL: https://issues.apache.org/jira/browse/MRELEASE-1008 Project: Maven Release Plugin Issue Type: Bug Reporter: Roman Ivanov during release, plugin create commit for version bump. BUT in addition to this it change formatting of some tags - https://github.com/checkstyle/checkstyle/commit/29a635421d9292673bbaaf0c0693d2191dfb5f18 Plugin changes multiline attributes formatting to single-line. In Checkstyle project we control length of lines in files to ease code review in web. This allow us to avoid vertical scrolls, .. . Such unexpected change triggered build problem right after release and make it impossible to keep user-defined formatting . Also reported at: https://stackoverflow.com/questions/49085502/maven-release-plugin-changes-pom-formatting -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MPMD-257) Allow skip WARNING 'This analysis could be faster ...' by analysisCache=false
Roman Ivanov created MPMD-257:
-
Summary: Allow skip WARNING 'This analysis could be faster ...' by
analysisCache=false
Key: MPMD-257
URL: https://issues.apache.org/jira/browse/MPMD-257
Project: Maven PMD Plugin
Issue Type: Bug
Reporter: Roman Ivanov
in plugn where is property
https://maven.apache.org/plugins/maven-pmd-plugin/pmd-mojo.html#analysisCache
that suppose to enable/disable cache
but it is used only to allow set for cache location:
https://github.com/apache/maven-pmd-plugin/blob/89687854bc1c965f26adbc78410f75e631f66088/src/main/java/org/apache/maven/plugins/pmd/PmdReport.java#L678
Pmd allow to skip warning is "-nocahe" is defined.
https://github.com/pmd/pmd/blob/451815bf0a790805a6a38c1c8bfe798f2a5f04bd/pmd-core/src/main/java/net/sourceforge/pmd/PMD.java#L300
Detected:
{code}
$ mvn pmd:pmd -Dpmd.analysisCache=false
...
[WARNING] This analysis could be faster, please consider using Incremental
Analysis:
https://pmd.github.io/pmd-6.1.0/pmd_userdocs_getting_started.html#incremental-analysis
..
{code}
Expected: no WARNING in output
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MPMD-254) An API incompatibility was encountered while executing org.apache.maven.plugins:maven-pmd-plugin:3.9.0:pmd
[
https://issues.apache.org/jira/browse/MPMD-254?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16379245#comment-16379245
]
Roman Ivanov commented on MPMD-254:
---
workaround works fine, with pmd 6.1.0 -
https://github.com/checkstyle/checkstyle/commit/cba0f56054b402311cba2b2acb1e26e0c1506b13
> An API incompatibility was encountered while executing
> org.apache.maven.plugins:maven-pmd-plugin:3.9.0:pmd
> --
>
> Key: MPMD-254
> URL: https://issues.apache.org/jira/browse/MPMD-254
> Project: Maven PMD Plugin
> Issue Type: Bug
>Affects Versions: 3.9.0
>Reporter: Roman Ivanov
>Priority: Major
>
> code base [https://github.com/checkstyle/checkstyle/]
> jsut did update from 3.8 to 3.9.0 at
> [https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L214]
> {code}
> $ mvn verify
>
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 02:40 min
> [INFO] Finished at: 2018-02-22T08:18:54-08:00
> [INFO] Final Memory: 63M/615M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-pmd-plugin:3.9.0:pmd (pmd) on project
> checkstyle: Execution pmd of goal
> org.apache.maven.plugins:maven-pmd-plugin:3.9.0:pmd failed: An API
> incompatibility was encountered while executing
> org.apache.maven.plugins:maven-pmd-plugin:3.9.0:pmd:
> java.lang.IllegalAccessError: tried to access method
> net.sourceforge.pmd.util.ResourceLoader.()V from class
> org.apache.maven.plugins.pmd.PmdReport
> [ERROR] -
> [ERROR] realm =plugin>org.apache.maven.plugins:maven-pmd-plugin:3.9.0
> [ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
> [ERROR] urls[0] =
> file:/home/user/.m2/repository/org/apache/maven/plugins/maven-pmd-plugin/3.9.0/maven-pmd-plugin-3.9.0.jar
> [ERROR] urls[1] =
> file:/home/user/.m2/repository/net/sourceforge/pmd/pmd-java/5.8.1/pmd-java-5.8.1.jar
> [ERROR] urls[2] =
> file:/home/user/.m2/repository/jaxen/jaxen/1.1.6/jaxen-1.1.6.jar
> [ERROR] urls[3] =
> file:/home/user/.m2/repository/net/java/dev/javacc/javacc/5.0/javacc-5.0.jar
> [ERROR] urls[4] =
> file:/home/user/.m2/repository/net/sourceforge/saxon/saxon/9.1.0.8/saxon-9.1.0.8.jar
> [ERROR] urls[5] =
> file:/home/user/.m2/repository/org/ow2/asm/asm/5.0.4/asm-5.0.4.jar
> [ERROR] urls[6] =
> file:/home/user/.m2/repository/net/sourceforge/saxon/saxon/9.1.0.8/saxon-9.1.0.8-dom.jar
> [ERROR] urls[7] =
> file:/home/user/.m2/repository/net/sourceforge/pmd/pmd-core/5.8.1/pmd-core-5.8.1.jar
> [ERROR] urls[8] =
> file:/home/user/.m2/repository/com/beust/jcommander/1.48/jcommander-1.48.jar
> [ERROR] urls[9] =
> file:/home/user/.m2/repository/org/apache/commons/commons-lang3/3.4/commons-lang3-3.4.jar
> [ERROR] urls[10] =
> file:/home/user/.m2/repository/com/google/code/gson/gson/2.5/gson-2.5.jar
> [ERROR] urls[11] =
> file:/home/user/.m2/repository/net/sourceforge/pmd/pmd-javascript/5.8.1/pmd-javascript-5.8.1.jar
> [ERROR] urls[12] =
> file:/home/user/.m2/repository/org/mozilla/rhino/1.7.7/rhino-1.7.7.jar
> [ERROR] urls[13] =
> file:/home/user/.m2/repository/net/sourceforge/pmd/pmd-jsp/5.8.1/pmd-jsp-5.8.1.jar
> [ERROR] urls[14] =
> file:/home/user/.m2/repository/org/sonatype/sisu/sisu-inject-bean/1.4.2/sisu-inject-bean-1.4.2.jar
> [ERROR] urls[15] =
> file:/home/user/.m2/repository/org/sonatype/sisu/sisu-guice/2.1.7/sisu-guice-2.1.7-noaop.jar
> [ERROR] urls[16] =
> file:/home/user/.m2/repository/org/slf4j/jul-to-slf4j/1.7.25/jul-to-slf4j-1.7.25.jar
> [ERROR] urls[17] =
> file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.7/doxia-sink-api-1.7.jar
> [ERROR] urls[18] =
> file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.7/doxia-logging-api-1.7.jar
> [ERROR] urls[19] =
> file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-decoration-model/1.7/doxia-decoration-model-1.7.jar
> [ERROR] urls[20] =
> file:/home/user/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.6/plexus-component-annotations-1.6.jar
> [ERROR] urls[21] =
> file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-site-renderer/1.7/doxia-site-renderer-1.7.jar
> [ERROR] urls[22] =
> file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-core/1.7/doxia-core-1.7.jar
> [ERROR] urls[23] =
> file:/home/user/.m2/repository/commons-lang/commons-lang/2.4/commons-lang-2.4.jar
> [ERROR] urls[24] =
> file:/home/user/.m2/repository/xmlunit/xmlunit/1.5/xmlunit-1.5.jar
> [ERROR] urls[25] =
>
[jira] [Created] (MPMD-254) An API incompatibility was encountered while executing org.apache.maven.plugins:maven-pmd-plugin:3.9.0:pmd
Roman Ivanov created MPMD-254:
-
Summary: An API incompatibility was encountered while executing
org.apache.maven.plugins:maven-pmd-plugin:3.9.0:pmd
Key: MPMD-254
URL: https://issues.apache.org/jira/browse/MPMD-254
Project: Maven PMD Plugin
Issue Type: Bug
Affects Versions: 3.9.0
Reporter: Roman Ivanov
code base [https://github.com/checkstyle/checkstyle/]
jsut did update from 3.8 to 3.9.0 at
[https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L214]
{code}
$ mvn verify
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 02:40 min
[INFO] Finished at: 2018-02-22T08:18:54-08:00
[INFO] Final Memory: 63M/615M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-pmd-plugin:3.9.0:pmd (pmd) on project
checkstyle: Execution pmd of goal
org.apache.maven.plugins:maven-pmd-plugin:3.9.0:pmd failed: An API
incompatibility was encountered while executing
org.apache.maven.plugins:maven-pmd-plugin:3.9.0:pmd:
java.lang.IllegalAccessError: tried to access method
net.sourceforge.pmd.util.ResourceLoader.()V from class
org.apache.maven.plugins.pmd.PmdReport
[ERROR] -
[ERROR] realm =plugin>org.apache.maven.plugins:maven-pmd-plugin:3.9.0
[ERROR] strategy = org.codehaus.plexus.classworlds.strategy.SelfFirstStrategy
[ERROR] urls[0] =
file:/home/user/.m2/repository/org/apache/maven/plugins/maven-pmd-plugin/3.9.0/maven-pmd-plugin-3.9.0.jar
[ERROR] urls[1] =
file:/home/user/.m2/repository/net/sourceforge/pmd/pmd-java/5.8.1/pmd-java-5.8.1.jar
[ERROR] urls[2] =
file:/home/user/.m2/repository/jaxen/jaxen/1.1.6/jaxen-1.1.6.jar
[ERROR] urls[3] =
file:/home/user/.m2/repository/net/java/dev/javacc/javacc/5.0/javacc-5.0.jar
[ERROR] urls[4] =
file:/home/user/.m2/repository/net/sourceforge/saxon/saxon/9.1.0.8/saxon-9.1.0.8.jar
[ERROR] urls[5] =
file:/home/user/.m2/repository/org/ow2/asm/asm/5.0.4/asm-5.0.4.jar
[ERROR] urls[6] =
file:/home/user/.m2/repository/net/sourceforge/saxon/saxon/9.1.0.8/saxon-9.1.0.8-dom.jar
[ERROR] urls[7] =
file:/home/user/.m2/repository/net/sourceforge/pmd/pmd-core/5.8.1/pmd-core-5.8.1.jar
[ERROR] urls[8] =
file:/home/user/.m2/repository/com/beust/jcommander/1.48/jcommander-1.48.jar
[ERROR] urls[9] =
file:/home/user/.m2/repository/org/apache/commons/commons-lang3/3.4/commons-lang3-3.4.jar
[ERROR] urls[10] =
file:/home/user/.m2/repository/com/google/code/gson/gson/2.5/gson-2.5.jar
[ERROR] urls[11] =
file:/home/user/.m2/repository/net/sourceforge/pmd/pmd-javascript/5.8.1/pmd-javascript-5.8.1.jar
[ERROR] urls[12] =
file:/home/user/.m2/repository/org/mozilla/rhino/1.7.7/rhino-1.7.7.jar
[ERROR] urls[13] =
file:/home/user/.m2/repository/net/sourceforge/pmd/pmd-jsp/5.8.1/pmd-jsp-5.8.1.jar
[ERROR] urls[14] =
file:/home/user/.m2/repository/org/sonatype/sisu/sisu-inject-bean/1.4.2/sisu-inject-bean-1.4.2.jar
[ERROR] urls[15] =
file:/home/user/.m2/repository/org/sonatype/sisu/sisu-guice/2.1.7/sisu-guice-2.1.7-noaop.jar
[ERROR] urls[16] =
file:/home/user/.m2/repository/org/slf4j/jul-to-slf4j/1.7.25/jul-to-slf4j-1.7.25.jar
[ERROR] urls[17] =
file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-sink-api/1.7/doxia-sink-api-1.7.jar
[ERROR] urls[18] =
file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-logging-api/1.7/doxia-logging-api-1.7.jar
[ERROR] urls[19] =
file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-decoration-model/1.7/doxia-decoration-model-1.7.jar
[ERROR] urls[20] =
file:/home/user/.m2/repository/org/codehaus/plexus/plexus-component-annotations/1.6/plexus-component-annotations-1.6.jar
[ERROR] urls[21] =
file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-site-renderer/1.7/doxia-site-renderer-1.7.jar
[ERROR] urls[22] =
file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-core/1.7/doxia-core-1.7.jar
[ERROR] urls[23] =
file:/home/user/.m2/repository/commons-lang/commons-lang/2.4/commons-lang-2.4.jar
[ERROR] urls[24] =
file:/home/user/.m2/repository/xmlunit/xmlunit/1.5/xmlunit-1.5.jar
[ERROR] urls[25] =
file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-skin-model/1.7/doxia-skin-model-1.7.jar
[ERROR] urls[26] =
file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-module-xhtml/1.7/doxia-module-xhtml-1.7.jar
[ERROR] urls[27] =
file:/home/user/.m2/repository/org/apache/maven/doxia/doxia-module-fml/1.7/doxia-module-fml-1.7.jar
[ERROR] urls[28] =
file:/home/user/.m2/repository/org/codehaus/plexus/plexus-i18n/1.0-beta-7/plexus-i18n-1.0-beta-7.jar
[ERROR] urls[29] =
file:/home/user/.m2/repository/junit/junit/3.8.1/junit-3.8.1.jar
[ERROR] urls[30] =
[jira] [Comment Edited] (MCHECKSTYLE-346) Release a new version
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304642#comment-16304642 ] Roman Ivanov edited comment on MCHECKSTYLE-346 at 12/27/17 4:42 PM: It might be off topic here, but it would be awesome to upgrade checkstyleVersion to 7.X release but this will require upgrade of plugin to jdk8 , as it was major update for Checkstyle http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0 . can you help us to upgrade to jdk8 parent poms and . , we will contribute all other checkstyle related update, I could create separate issue on this if you agree to help. I will be definitely for 2.19 release was (Author: romani): It might be off topic here, but it would be awesome to upgrade checkstyleVersion to 7.X release but this will require upgrade of plugin to jdk8 , as it was major update for Checkstyle http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0 . can you help us to upgrade to jdk8 parent poms and . , we will contribute all other checkstyle related update, I could create separate issue on this if you agree to help. > Release a new version > - > > Key: MCHECKSTYLE-346 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.17 > Environment: All >Reporter: richard >Priority: Blocker > > Hello, > Since my posts in another issue have gone unnoticed > (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this > one to bring it up front. > The main checkstyle community have been waiting years for a 2.18 release for > fixes and functionality needed. As it is now, we cannot remove old deprecated > code from our utility as the plugin relies on them too much and breaks if > they are removed which forces us to continue supporting them just for you. > See Issue: https://github.com/checkstyle/checkstyle/issues/2883 > The last release for maven checkstyle plugin was 2015, but you continue to > update the code base. Why is this? Is there something that prevents you from > creating a new release? Do you lack personnel of some kind? Is it possible to > give us a time table for a 2.18 release? > If things continue as they are now, we may begin looking into breaking > compatibility with the plugin in newer versions as this project seems to have > run stagnant and is lacking support. If compatibility is broken, the current > plugin released will then only work with old and outdated versions. I, and I > am sure the community, don't wish to see this happen but the checkstyle > utility needs to keep evolving and remove outdated code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (MCHECKSTYLE-346) Release a new version
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304641#comment-16304641
]
Roman Ivanov edited comment on MCHECKSTYLE-346 at 12/27/17 4:41 PM:
{quote} If there are other issues which should be part of this release, let me
know. {quote}
please update to 6.19 version of checkstyle
{code}
$ git diff
diff --git a/maven-checkstyle-plugin/pom.xml b/maven-checkstyle-plugin/pom.xml
index 9686ca6..0cab64e 100644
--- a/maven-checkstyle-plugin/pom.xml
+++ b/maven-checkstyle-plugin/pom.xml
@@ -63,7 +63,7 @@ under the License.
1.${javaVersion}
1.${javaVersion}
3.0
-6.18
+6.19
1.4
3.4
{code}
this is the last checkstyle release for jdk7.
it is good to do 2.18 plugin release in such state.
was (Author: romani):
{quote} If there are other issues which should be part of this release, let me
know. {quote}
please update to 6.19 version of checkstyle
{code}
$ git diff
diff --git a/maven-checkstyle-plugin/pom.xml b/maven-checkstyle-plugin/pom.xml
index 9686ca6..0cab64e 100644
--- a/maven-checkstyle-plugin/pom.xml
+++ b/maven-checkstyle-plugin/pom.xml
@@ -63,7 +63,7 @@ under the License.
1.${javaVersion}
1.${javaVersion}
3.0
-6.18
+6.19
1.4
3.4
{code}
this is the last checkstyle release for jdk7.
it is good to release plugin.
> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for
> fixes and functionality needed. As it is now, we cannot remove old deprecated
> code from our utility as the plugin relies on them too much and breaks if
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to
> update the code base. Why is this? Is there something that prevents you from
> creating a new release? Do you lack personnel of some kind? Is it possible to
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking
> compatibility with the plugin in newer versions as this project seems to have
> run stagnant and is lacking support. If compatibility is broken, the current
> plugin released will then only work with old and outdated versions. I, and I
> am sure the community, don't wish to see this happen but the checkstyle
> utility needs to keep evolving and remove outdated code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (MCHECKSTYLE-346) Release a new version
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304642#comment-16304642 ] Roman Ivanov edited comment on MCHECKSTYLE-346 at 12/27/17 4:39 PM: It might be off topic here, but it would be awesome to upgrade checkstyleVersion to 7.X release but this will require upgrade of plugin to jdk8 , as it was major update for Checkstyle http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0 . can you help us to upgrade to jdk8 parent poms and . , we will contribute all other checkstyle related update, I could create separate issue on this if you agree to help. was (Author: romani): It might be off topic here, but it would be awesome to upgrade checkstyleVersion to 7.X release but this will require upgrade of plugin to jdk8 , as it major update for Checkstyle http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0 . can you help us to upgrade to jdk8 parent poms and . , we will contribute all other checkstyle related update, I could create separate issue on this if you agree to help. > Release a new version > - > > Key: MCHECKSTYLE-346 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.17 > Environment: All >Reporter: richard >Priority: Blocker > > Hello, > Since my posts in another issue have gone unnoticed > (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this > one to bring it up front. > The main checkstyle community have been waiting years for a 2.18 release for > fixes and functionality needed. As it is now, we cannot remove old deprecated > code from our utility as the plugin relies on them too much and breaks if > they are removed which forces us to continue supporting them just for you. > See Issue: https://github.com/checkstyle/checkstyle/issues/2883 > The last release for maven checkstyle plugin was 2015, but you continue to > update the code base. Why is this? Is there something that prevents you from > creating a new release? Do you lack personnel of some kind? Is it possible to > give us a time table for a 2.18 release? > If things continue as they are now, we may begin looking into breaking > compatibility with the plugin in newer versions as this project seems to have > run stagnant and is lacking support. If compatibility is broken, the current > plugin released will then only work with old and outdated versions. I, and I > am sure the community, don't wish to see this happen but the checkstyle > utility needs to keep evolving and remove outdated code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Comment Edited] (MCHECKSTYLE-346) Release a new version
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304641#comment-16304641
]
Roman Ivanov edited comment on MCHECKSTYLE-346 at 12/27/17 4:37 PM:
{quote} If there are other issues which should be part of this release, let me
know. {quote}
please update to 6.19 version of checkstyle
{code}
$ git diff
diff --git a/maven-checkstyle-plugin/pom.xml b/maven-checkstyle-plugin/pom.xml
index 9686ca6..0cab64e 100644
--- a/maven-checkstyle-plugin/pom.xml
+++ b/maven-checkstyle-plugin/pom.xml
@@ -63,7 +63,7 @@ under the License.
1.${javaVersion}
1.${javaVersion}
3.0
-6.18
+6.19
1.4
3.4
{code}
this is the last checkstyle release for jdk7.
it is good to release plugin.
was (Author: romani):
{quote} If there are other issues which should be part of this release, let me
know. {quote}
please update to 6.19 version of checkstyle
{code}
$ git diff
diff --git a/maven-checkstyle-plugin/pom.xml b/maven-checkstyle-plugin/pom.xml
index 9686ca6..0cab64e 100644
--- a/maven-checkstyle-plugin/pom.xml
+++ b/maven-checkstyle-plugin/pom.xml
@@ -63,7 +63,7 @@ under the License.
1.${javaVersion}
1.${javaVersion}
3.0
-6.18
+6.19
1.4
3.4
{code}
this is the last checkstyle release for jdk7.
> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for
> fixes and functionality needed. As it is now, we cannot remove old deprecated
> code from our utility as the plugin relies on them too much and breaks if
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to
> update the code base. Why is this? Is there something that prevents you from
> creating a new release? Do you lack personnel of some kind? Is it possible to
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking
> compatibility with the plugin in newer versions as this project seems to have
> run stagnant and is lacking support. If compatibility is broken, the current
> plugin released will then only work with old and outdated versions. I, and I
> am sure the community, don't wish to see this happen but the checkstyle
> utility needs to keep evolving and remove outdated code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MCHECKSTYLE-346) Release a new version
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304642#comment-16304642 ] Roman Ivanov commented on MCHECKSTYLE-346: -- It might be off topic here, but it would be awesome to upgrade checkstyleVersion to 7.X release but this will require upgrade of plugin to jdk8 , as it major update for Checkstyle http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0 . can you help us to upgrade to jdk8 parent poms and . , we will contribute all other checkstyle related update, I could create separate issue on this if you agree to help. > Release a new version > - > > Key: MCHECKSTYLE-346 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.17 > Environment: All >Reporter: richard >Priority: Blocker > > Hello, > Since my posts in another issue have gone unnoticed > (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this > one to bring it up front. > The main checkstyle community have been waiting years for a 2.18 release for > fixes and functionality needed. As it is now, we cannot remove old deprecated > code from our utility as the plugin relies on them too much and breaks if > they are removed which forces us to continue supporting them just for you. > See Issue: https://github.com/checkstyle/checkstyle/issues/2883 > The last release for maven checkstyle plugin was 2015, but you continue to > update the code base. Why is this? Is there something that prevents you from > creating a new release? Do you lack personnel of some kind? Is it possible to > give us a time table for a 2.18 release? > If things continue as they are now, we may begin looking into breaking > compatibility with the plugin in newer versions as this project seems to have > run stagnant and is lacking support. If compatibility is broken, the current > plugin released will then only work with old and outdated versions. I, and I > am sure the community, don't wish to see this happen but the checkstyle > utility needs to keep evolving and remove outdated code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MCHECKSTYLE-346) Release a new version
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304641#comment-16304641
]
Roman Ivanov commented on MCHECKSTYLE-346:
--
{quote} If there are other issues which should be part of this release, let me
know. {quote}
please update to 6.19 version of checkstyle
{code}
$ git diff
diff --git a/maven-checkstyle-plugin/pom.xml b/maven-checkstyle-plugin/pom.xml
index 9686ca6..0cab64e 100644
--- a/maven-checkstyle-plugin/pom.xml
+++ b/maven-checkstyle-plugin/pom.xml
@@ -63,7 +63,7 @@ under the License.
1.${javaVersion}
1.${javaVersion}
3.0
-6.18
+6.19
1.4
3.4
{code}
this is the last checkstyle release for jdk7.
> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for
> fixes and functionality needed. As it is now, we cannot remove old deprecated
> code from our utility as the plugin relies on them too much and breaks if
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to
> update the code base. Why is this? Is there something that prevents you from
> creating a new release? Do you lack personnel of some kind? Is it possible to
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking
> compatibility with the plugin in newer versions as this project seems to have
> run stagnant and is lacking support. If compatibility is broken, the current
> plugin released will then only work with old and outdated versions. I, and I
> am sure the community, don't wish to see this happen but the checkstyle
> utility needs to keep evolving and remove outdated code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Comment Edited] (MCHECKSTYLE-346) Release a new version
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304625#comment-16304625
]
Roman Ivanov edited comment on MCHECKSTYLE-346 at 12/27/17 3:57 PM:
{quote} we're probably even in worse shape. {quote}
I do understand you. Just try to find compromise to avoid blocks.
{quote} I can think of several other solutions, but in the end it all depends
how much control you want over this plugin and if the current situation is
acceptable. {quote}
Please share your thoughts , we can provide fixes (migration for new
versions of checkstyle, as we are in full context of how to make it), but it
would be awesome for us to know when we can expect release of such fixes.
We are completely understand that release will not be immediate, but at least
ones in few month, or any other trigger. I know that release process is not big
fun for engineers, and is postponed as much as possible, and . But
contributors will unlikely send you code if they know that release will take a
while, so fork is better for them or do any other workaround.
Please share your thought and thanks lot for cooperation.
was (Author: romani):
> we're probably even in worse shape.
I do understand you. Just try to find compromise to avoid blocks.
> I can think of several other solutions, but in the end it all depends how
> much control you want over this plugin and if the current situation is
> acceptable.
Please share your thoughts , we can provide fixes (migration for new
versions of checkstyle, as we are in full context of how to make it), but it
would be awesome for us to know when we can expect release of such fixes.
We are completely understand that release will not be immediate, but at least
ones in few month, or any other trigger. I know that release process is not big
fun for engineers, and is postponed as much as possible, and . But
contributors will unlikely send you code if they know that release will take a
while, so fork is better for them or do any other workaround.
Please share your thought and thanks lot for cooperation.
> Release a new version
> -
>
> Key: MCHECKSTYLE-346
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
>Affects Versions: 2.17
> Environment: All
>Reporter: richard
>Priority: Blocker
>
> Hello,
> Since my posts in another issue have gone unnoticed
> (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this
> one to bring it up front.
> The main checkstyle community have been waiting years for a 2.18 release for
> fixes and functionality needed. As it is now, we cannot remove old deprecated
> code from our utility as the plugin relies on them too much and breaks if
> they are removed which forces us to continue supporting them just for you.
> See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> The last release for maven checkstyle plugin was 2015, but you continue to
> update the code base. Why is this? Is there something that prevents you from
> creating a new release? Do you lack personnel of some kind? Is it possible to
> give us a time table for a 2.18 release?
> If things continue as they are now, we may begin looking into breaking
> compatibility with the plugin in newer versions as this project seems to have
> run stagnant and is lacking support. If compatibility is broken, the current
> plugin released will then only work with old and outdated versions. I, and I
> am sure the community, don't wish to see this happen but the checkstyle
> utility needs to keep evolving and remove outdated code.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MCHECKSTYLE-346) Release a new version
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16304625#comment-16304625 ] Roman Ivanov commented on MCHECKSTYLE-346: -- > we're probably even in worse shape. I do understand you. Just try to find compromise to avoid blocks. > I can think of several other solutions, but in the end it all depends how > much control you want over this plugin and if the current situation is > acceptable. Please share your thoughts , we can provide fixes (migration for new versions of checkstyle, as we are in full context of how to make it), but it would be awesome for us to know when we can expect release of such fixes. We are completely understand that release will not be immediate, but at least ones in few month, or any other trigger. I know that release process is not big fun for engineers, and is postponed as much as possible, and . But contributors will unlikely send you code if they know that release will take a while, so fork is better for them or do any other workaround. Please share your thought and thanks lot for cooperation. > Release a new version > - > > Key: MCHECKSTYLE-346 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.17 > Environment: All >Reporter: richard >Priority: Blocker > > Hello, > Since my posts in another issue have gone unnoticed > (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this > one to bring it up front. > The main checkstyle community have been waiting years for a 2.18 release for > fixes and functionality needed. As it is now, we cannot remove old deprecated > code from our utility as the plugin relies on them too much and breaks if > they are removed which forces us to continue supporting them just for you. > See Issue: https://github.com/checkstyle/checkstyle/issues/2883 > The last release for maven checkstyle plugin was 2015, but you continue to > update the code base. Why is this? Is there something that prevents you from > creating a new release? Do you lack personnel of some kind? Is it possible to > give us a time table for a 2.18 release? > If things continue as they are now, we may begin looking into breaking > compatibility with the plugin in newer versions as this project seems to have > run stagnant and is lacking support. If compatibility is broken, the current > plugin released will then only work with old and outdated versions. I, and I > am sure the community, don't wish to see this happen but the checkstyle > utility needs to keep evolving and remove outdated code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MCHECKSTYLE-346) Release a new version
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303321#comment-16303321 ] Roman Ivanov commented on MCHECKSTYLE-346: -- Hi [~rfscholte], thanks a lot for reply. Checkstyle team is small, and not capable in sync all plugins of checkstyle, we already got ownership of Sonar plugin and have lack of time to keep it in sync too. There are number of issues what are related to checkstyle and bunch of issues related to system that runs plugins (Sonar, maven,). So it will be hard for one team to maintain the project alone. What if some members (me and/or Richard) of Checkstyle team join to maven checkstyle plugin with ability to commit to it and release it, in this case we could help to upgrade plugin in changes related to checkstyle and Apache team still could help this plugin to upgrade in maven related changes. > Release a new version > - > > Key: MCHECKSTYLE-346 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.17 > Environment: All >Reporter: richard >Priority: Blocker > > Hello, > Since my posts in another issue have gone unnoticed > (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this > one to bring it up front. > The main checkstyle community have been waiting years for a 2.18 release for > fixes and functionality needed. As it is now, we cannot remove old deprecated > code from our utility as the plugin relies on them too much and breaks if > they are removed which forces us to continue supporting them just for you. > See Issue: https://github.com/checkstyle/checkstyle/issues/2883 > The last release for maven checkstyle plugin was 2015, but you continue to > update the code base. Why is this? Is there something that prevents you from > creating a new release? Do you lack personnel of some kind? Is it possible to > give us a time table for a 2.18 release? > If things continue as they are now, we may begin looking into breaking > compatibility with the plugin in newer versions as this project seems to have > run stagnant and is lacking support. If compatibility is broken, the current > plugin released will then only work with old and outdated versions. I, and I > am sure the community, don't wish to see this happen but the checkstyle > utility needs to keep evolving and remove outdated code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MSITE-748) EmptyStackException on xdoc toc macro usage
[
https://issues.apache.org/jira/browse/MSITE-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15991044#comment-15991044
]
Roman Ivanov commented on MSITE-748:
sad, it is not a workaround for me
> EmptyStackException on xdoc toc macro usage
> ---
>
> Key: MSITE-748
> URL: https://issues.apache.org/jira/browse/MSITE-748
> Project: Maven Site Plugin
> Issue Type: Bug
>Affects Versions: 3.4
> Environment: Ubuntu 12.04 64bit
>Reporter: Roman Ivanov
>Priority: Minor
>
> repository https://github.com/checkstyle/checkstyle
> update src/xdocs/config.xml, to add Content section conrtaining toc macro
> like this:
> {code}
>
>
>
>
>
>
>
>
> {code}
> build a site by command:
> {code}
> mvn -X clean site -Dlinkcheck.skip=true -Dmaven.javadoc.skip=true -DskipTests
> -DskipITs -Dpmd.skip=true -Dfindbugs.skip=true -Dcobertura.skip=true
> -Dcheckstyle.ant.skip=true
> {code}
> Exception:
> {code}
> [DEBUG] Generating
> /home/rivanov/java/git-others/checkstyle/checkstyle/target/site/config.html
> [DEBUG] Validating:
> /home/rivanov/java/git-others/checkstyle/checkstyle/src/xdocs/config.xml
> [DEBUG] Validating the content...
> [WARNING] was already defined in , ignored in
> .
> [DEBUG] Unrecognized xdoc tag: at [17:70]
> [DEBUG] Unrecognized xdoc tag: at [18:76]
> [warn] was already defined in , ignored in .
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 27.049s
> [INFO] Finished at: Wed Jun 24 21:34:25 PDT 2015
> [INFO] Final Memory: 59M/472M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> checkstyle: Execution default-site of goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site failed.
> EmptyStackException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on
> project checkstyle: Execution default-site of goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site failed.
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:225)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
> default-site of goal org.apache.maven.plugins:maven-site-plugin:3.4:site
> failed.
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: java.util.EmptyStackException
> at java.util.Stack.peek(Stack.java:102)
> at org.apache.maven.doxia.index.IndexingSink.peek(IndexingSink.java:292)
> at org.apache.maven.doxia.index.IndexingSink.text(IndexingSink.java:239)
> at
>
[jira] [Commented] (MSITE-748) EmptyStackException on xdoc toc macro usage
[
https://issues.apache.org/jira/browse/MSITE-748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15990951#comment-15990951
]
Roman Ivanov commented on MSITE-748:
but how to force site plugin or doxia to generate different H tag for "section"
?
> EmptyStackException on xdoc toc macro usage
> ---
>
> Key: MSITE-748
> URL: https://issues.apache.org/jira/browse/MSITE-748
> Project: Maven Site Plugin
> Issue Type: Bug
>Affects Versions: 3.4
> Environment: Ubuntu 12.04 64bit
>Reporter: Roman Ivanov
>Priority: Minor
>
> repository https://github.com/checkstyle/checkstyle
> update src/xdocs/config.xml, to add Content section conrtaining toc macro
> like this:
> {code}
>
>
>
>
>
>
>
>
> {code}
> build a site by command:
> {code}
> mvn -X clean site -Dlinkcheck.skip=true -Dmaven.javadoc.skip=true -DskipTests
> -DskipITs -Dpmd.skip=true -Dfindbugs.skip=true -Dcobertura.skip=true
> -Dcheckstyle.ant.skip=true
> {code}
> Exception:
> {code}
> [DEBUG] Generating
> /home/rivanov/java/git-others/checkstyle/checkstyle/target/site/config.html
> [DEBUG] Validating:
> /home/rivanov/java/git-others/checkstyle/checkstyle/src/xdocs/config.xml
> [DEBUG] Validating the content...
> [WARNING] was already defined in , ignored in
> .
> [DEBUG] Unrecognized xdoc tag: at [17:70]
> [DEBUG] Unrecognized xdoc tag: at [18:76]
> [warn] was already defined in , ignored in .
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 27.049s
> [INFO] Finished at: Wed Jun 24 21:34:25 PDT 2015
> [INFO] Final Memory: 59M/472M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
> checkstyle: Execution default-site of goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site failed.
> EmptyStackException -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on
> project checkstyle: Execution default-site of goal
> org.apache.maven.plugins:maven-site-plugin:3.4:site failed.
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:225)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
> default-site of goal org.apache.maven.plugins:maven-site-plugin:3.4:site
> failed.
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
> ... 19 more
> Caused by: java.util.EmptyStackException
> at java.util.Stack.peek(Stack.java:102)
> at org.apache.maven.doxia.index.IndexingSink.peek(IndexingSink.java:292)
> at org.apache.maven.doxia.index.IndexingSink.text(IndexingSink.java:239)
> at
>
[jira] [Commented] (MLINKCHECK-30) https link does not exists and redirected by website to another url
[ https://issues.apache.org/jira/browse/MLINKCHECK-30?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15962433#comment-15962433 ] Roman Ivanov commented on MLINKCHECK-30: [~michael-o] , > Why do you actually publish files with Sourceforge at all? I have recently > stopped that for my projects because they all are on Maven Cenral anyway. yes, this is just historical, but there is a nuance ... we publish special checkstyle-7.6.1-all.jar (attention to "-all") that is composite of all our dependencies to that resource. As far as I know maven central does not allow hosting of non standard jars. Link to jar is not a only problem, we host whole website on sourceforge so there are a lot of other links that fail with handshake error. There is long discussion of SSL problems with link-check-plugin https://github.com/checkstyle/checkstyle/pull/4114 . > https link does not exists and redirected by website to another url > > > Key: MLINKCHECK-30 > URL: https://issues.apache.org/jira/browse/MLINKCHECK-30 > Project: Maven Linkcheck Plugin > Issue Type: Bug >Reporter: Roman Ivanov > > there is > during site creation of checkstyle project > (https://github.com/checkstyle/checkstyle) - "mvn site" > there is url - > http://downloads.sourceforge.net/project/checkstyle/checkstyle/7.7-SNAPSHOT/checkstyle-7.7-SNAPSHOT-all.jar > it does not exists on sourceforge, as we publish only released jars, > http://wheregoes.com/retracer.php for > "http://downloads.sourceforge.net/project/checkstyle/checkstyle/7.7-SNAPSHOT/checkstyle-7.7-SNAPSHOT-all.jar; > show a problem(404) but in browser this link is redirected to > https://sourceforge.net/projects/checkstyle/files/ > Redirections are not allowed in config. Previously validation worked fine so > that we have this link in excludes. Now it does not generate a error. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Created] (MLINKCHECK-30) https link does not exists and redirected by website to another url
Roman Ivanov created MLINKCHECK-30: -- Summary: https link does not exists and redirected by website to another url Key: MLINKCHECK-30 URL: https://issues.apache.org/jira/browse/MLINKCHECK-30 Project: Maven Linkcheck Plugin Issue Type: Bug Reporter: Roman Ivanov there is during site creation of checkstyle project (https://github.com/checkstyle/checkstyle) - "mvn site" there is url - http://downloads.sourceforge.net/project/checkstyle/checkstyle/7.7-SNAPSHOT/checkstyle-7.7-SNAPSHOT-all.jar it does not exists on sourceforge, as we publish only released jars, http://wheregoes.com/retracer.php for "http://downloads.sourceforge.net/project/checkstyle/checkstyle/7.7-SNAPSHOT/checkstyle-7.7-SNAPSHOT-all.jar; show a problem(404) but in browser this link is redirected to https://sourceforge.net/projects/checkstyle/files/ Redirections are not allowed in config. Previously validation worked fine so that we have this link in excludes. Now it does not generate a error. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MLINKCHECK-28) javax.net.ssl.SSLHandshakeException : Received fatal alert: handshake_failure
[
https://issues.apache.org/jira/browse/MLINKCHECK-28?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15844087#comment-15844087
]
Roman Ivanov commented on MLINKCHECK-28:
I did suppressions to let us continue -
https://github.com/checkstyle/checkstyle/commit/861612671a7ad56901334dce338ff4b427a39189
> javax.net.ssl.SSLHandshakeException : Received fatal alert: handshake_failure
> -
>
> Key: MLINKCHECK-28
> URL: https://issues.apache.org/jira/browse/MLINKCHECK-28
> Project: Maven Linkcheck Plugin
> Issue Type: Bug
>Affects Versions: 1.2
> Environment: Linux pc 4.4.0-59-generic #80-Ubuntu x86_64
>Reporter: Roman Ivanov
>
> reproducible on CI and on ubuntu 16.04.
> Link to repo: https://github.com/checkstyle/checkstyle
> CI logs: https://codeship.com/projects/124310/builds/22118854
> config: https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L1151
> It worked fine at 14:55 2017-01-26 on this CI, and failed at 17:51
> 2017-01-26. No config changes on checkstyle side, probably smth is changed on
> sourceforge side.
> Command in CI:
> {code}
> uname -a && mvn --version && curl -I http://checkstyle.sourceforge.net/ &&
> mvn clean site -Dcheckstyle.ant.skip=true -DskipTests -DskipITs
> -Dpmd.skip=true -Dfindbugs.skip=true -Dcobertura.skip=true
> -Dcheckstyle.skip=true && echo " grep of linkcheck.html--BEGIN"
> && grep externalLink target/site/linkcheck.html | cat && echo "
> grep of linkcheck.html--END" && RESULT=$(grep externalLink
> target/site/linkcheck.html | grep -v 'Read timed out' | wc -l) && echo 'Exit
> code:'$RESULT && if [[ $RESULT != 0 ]]; then false; fi
> {code}
> Problems with following links:
> https://sourceforge.net/p/checkstyle/news/feed
> https://sourceforge.net/projects/checkstyle/
> https://sourceforge.net/projects/checkstyle/files/checkstyle/
> Curl output right after maven execution, the same in CI:
> {code}
> $ curl -I https://sourceforge.net/projects/checkstyle/
> HTTP/1.1 200 OK
> Server: nginx
> Date: Sat, 28 Jan 2017 14:05:47 GMT
> Content-Type: text/html; charset=utf-8
>
> {code}
> HTML Report chunk:
> {code}
> href="https://sourceforge.net/p/checkstyle/news/feed;>https://sourceforge.net/p/checkstyle/news/feed:
> javax.net.ssl.SSLHandshakeException : Received fatal alert:
> handshake_failure
> href="https://sourceforge.net/projects/checkstyle/;>https://sourceforge.net/projects/checkstyle/:
> javax.net.ssl.SSLHandshakeException : Received fatal alert:
> handshake_failure
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MLINKCHECK-28) javax.net.ssl.SSLHandshakeException : Received fatal alert: handshake_failure
Roman Ivanov created MLINKCHECK-28:
--
Summary: javax.net.ssl.SSLHandshakeException : Received fatal
alert: handshake_failure
Key: MLINKCHECK-28
URL: https://issues.apache.org/jira/browse/MLINKCHECK-28
Project: Maven Linkcheck Plugin
Issue Type: Bug
Affects Versions: 1.2
Environment: Linux pc 4.4.0-59-generic #80-Ubuntu x86_64
Reporter: Roman Ivanov
reproducible on CI and on ubuntu 16.04.
Link to repo: https://github.com/checkstyle/checkstyle
CI logs: https://codeship.com/projects/124310/builds/22118854
config: https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L1151
It worked fine at 14:55 2017-01-26 on this CI, and failed at 17:51 2017-01-26.
No config changes on checkstyle side, probably smth is changed on sourceforge
side.
Command in CI:
{code}
uname -a && mvn --version && curl -I http://checkstyle.sourceforge.net/ && mvn
clean site -Dcheckstyle.ant.skip=true -DskipTests -DskipITs -Dpmd.skip=true
-Dfindbugs.skip=true -Dcobertura.skip=true -Dcheckstyle.skip=true && echo
" grep of linkcheck.html--BEGIN" && grep externalLink
target/site/linkcheck.html | cat && echo " grep of
linkcheck.html--END" && RESULT=$(grep externalLink target/site/linkcheck.html |
grep -v 'Read timed out' | wc -l) && echo 'Exit code:'$RESULT && if [[ $RESULT
!= 0 ]]; then false; fi
{code}
Problems with following links:
https://sourceforge.net/p/checkstyle/news/feed
https://sourceforge.net/projects/checkstyle/
https://sourceforge.net/projects/checkstyle/files/checkstyle/
Curl output right after maven execution, the same in CI:
{code}
$ curl -I https://sourceforge.net/projects/checkstyle/
HTTP/1.1 200 OK
Server: nginx
Date: Sat, 28 Jan 2017 14:05:47 GMT
Content-Type: text/html; charset=utf-8
{code}
HTML Report chunk:
{code}
https://sourceforge.net/p/checkstyle/news/feed;>https://sourceforge.net/p/checkstyle/news/feed:
javax.net.ssl.SSLHandshakeException : Received fatal alert:
handshake_failure
https://sourceforge.net/projects/checkstyle/;>https://sourceforge.net/projects/checkstyle/:
javax.net.ssl.SSLHandshakeException : Received fatal alert:
handshake_failure
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-323) usage of checkstyle 7.0 (jdk8 is required)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15830868#comment-15830868 ] Roman Ivanov commented on MCHECKSTYLE-323: -- One more point to make next version to be based on 7.0 : Checkstyle is used in many places: maven, IDEs, Sonar like application. Unfortunately user have to keep checkstyle version in the same version in all systems. So if you give user 7.0 by default, user can use any 7.X he wants or other systems demands. https://maven.apache.org/plugins/maven-checkstyle-plugin/history.html > usage of checkstyle 7.0 (jdk8 is required) > -- > > Key: MCHECKSTYLE-323 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-323 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Reporter: Roman Ivanov > > Checkstyle 7.0 requires jdk8 for runtime. > It will be good to have special version of maven plugin that is using it, as > good milestone. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-323) usage of checkstyle 7.0 (jdk8 is required)
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15810417#comment-15810417 ] Roman Ivanov commented on MCHECKSTYLE-323: -- I know this feature and heavily use it. By this issue I mean: as plugin switch to jdk8 as minimum jdk, it would be better to use checkstyle 7.0 as version by default. Checkstyle will soon switch to version 8.X there will be a lot of API changes, it will be another good milestone for plugin. > usage of checkstyle 7.0 (jdk8 is required) > -- > > Key: MCHECKSTYLE-323 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-323 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Reporter: Roman Ivanov > > Checkstyle 7.0 requires jdk8 for runtime. > It will be good to have special version of maven plugin that is using it, as > good milestone. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MLINKCHECK-27) new option to set a path to "site" that need to be validated
Roman Ivanov created MLINKCHECK-27: -- Summary: new option to set a path to "site" that need to be validated Key: MLINKCHECK-27 URL: https://issues.apache.org/jira/browse/MLINKCHECK-27 Project: Maven Linkcheck Plugin Issue Type: New Feature Reporter: Roman Ivanov base on https://github.com/checkstyle/sonar-checkstyle/issues/56 There is need to test HTML pages that are not part of site of the project but they they are embedded documentation, just another folder with html pages that need validation. Looks like there is no way to configure plugin to do this: http://maven.apache.org/components/plugins/maven-linkcheck-plugin/linkcheck-mojo.html It would be good to have new option to set a path to "site" that need to be validated. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MSITE-774) Usage of validate=true lead to "SAX2 driver class org.apache.xerces.parsers.SAXParser not found" exception
[
https://issues.apache.org/jira/browse/MSITE-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15704281#comment-15704281
]
Roman Ivanov commented on MSITE-774:
issue is resolved in xml-maven-plugin project, will be released in version
after 1.0.1 .
> Usage of validate=true lead to "SAX2 driver class
> org.apache.xerces.parsers.SAXParser not found" exception
> --
>
> Key: MSITE-774
> URL: https://issues.apache.org/jira/browse/MSITE-774
> Project: Maven Site Plugin
> Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Roman Ivanov
>Assignee: Hervé Boutemy
>
> project: https://github.com/checkstyle/checkstyle
> usage of validate=true:
> {code}
> ...
> org.apache.maven.plugins
> maven-site-plugin
> ${maven.site.plugin.version}
>
> ${basedir}/src/xdocs
> true
>
> ...
> {code}
> lead to
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.5.1:site (default-site) on
> project checkstyle: Error parsing
> '~/checkstyle/checkstyle/src/xdocs/anttask.xml.vm': line [-1] Error
> validating the model: SAX2 driver class org.apache.xerces.parsers.SAXParser
> not found -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.5.1:site (default-site) on
> project checkstyle: Error parsing
> '~/checkstyle/checkstyle/src/xdocs/anttask.xml.vm': line [-1] Error
> validating the model: SAX2 driver class org.apache.xerces.parsers.SAXParser
> not found
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:216)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:160)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error parsing
> '~/checkstyle/checkstyle/src/xdocs/anttask.xml.vm': line [-1] Error
> validating the model: SAX2 driver class org.apache.xerces.parsers.SAXParser
> not found
> at
> org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:140)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> ... 19 more
> Caused by: org.apache.maven.doxia.siterenderer.RendererException: Error
> parsing '~/checkstyle/checkstyle/src/xdocs/anttask.xml.vm': line [-1] Error
> validating the model: SAX2 driver class org.apache.xerces.parsers.SAXParser
> not found
> at
> org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderDocument(DefaultSiteRenderer.java:449)
> at
> org.apache.maven.doxia.siterenderer.DoxiaDocumentRenderer.renderDocument(DoxiaDocumentRenderer.java:53)
> at
> org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:329)
> at
> org.apache.maven.plugins.site.render.SiteMojo.renderDoxiaDocuments(SiteMojo.java:264)
> at
> org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:171)
> at
>
[jira] [Created] (MCHECKSTYLE-323) usage of checkstyle 7.0 (jdk8 is required)
Roman Ivanov created MCHECKSTYLE-323: Summary: usage of checkstyle 7.0 (jdk8 is required) Key: MCHECKSTYLE-323 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-323 Project: Maven Checkstyle Plugin Issue Type: Bug Reporter: Roman Ivanov Checkstyle 7.0 requires jdk8 for runtime. It will be good to have special version of maven plugin that is using it, as good milestone. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MCHECKSTYLE-322) Update plugin to use 6.19 checkstyle (last version that is based on jdk7)
Roman Ivanov created MCHECKSTYLE-322: Summary: Update plugin to use 6.19 checkstyle (last version that is based on jdk7) Key: MCHECKSTYLE-322 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-322 Project: Maven Checkstyle Plugin Issue Type: Bug Reporter: Roman Ivanov Update plugin to use 6.19 checkstyle (last version that is based on jdk7). http://checkstyle.sourceforge.net/releasenotes.html#Release_6.19 Java8 based version is 7.0: http://checkstyle.sourceforge.net/releasenotes.html#Release_7.0 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MPIR-348) usage of http protocol in web site for git-scm.com resources cause redirects to https
[ https://issues.apache.org/jira/browse/MPIR-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Ivanov updated MPIR-348: -- Description: maven-project-info-reports-plugin: http://git-scm.com is redirecting to https://git-scm.com now, maven-linkcheck-plugin report a problem during site generation Example of linkcjeck failure is at https://codeship.com/projects/124310/builds/13103197 fix: https://github.com/apache/maven-plugins/pull/81/commits/58cbfcba342fced3fea29a50f08b6bdbf739b4d1 was: maven-project-info-reports-plugin: http://git-scm.com is redirecting to https://git-scm.com now, maven-linkcheck-plugin report a problem during site generation Example of linkcjeck failure is at https://codeship.com/projects/124310/builds/13103197 fix: https://github.com/apache/maven-plugins/pull/81/commits /58cbfcba342fced3fea29a50f08b6bdbf739b4d1 > usage of http protocol in web site for git-scm.com resources cause redirects > to https > - > > Key: MPIR-348 > URL: https://issues.apache.org/jira/browse/MPIR-348 > Project: Maven Project Info Reports Plugin > Issue Type: Bug >Reporter: Roman Ivanov > > maven-project-info-reports-plugin: http://git-scm.com is redirecting to > https://git-scm.com now, maven-linkcheck-plugin report a problem during site > generation > Example of linkcjeck failure is at > https://codeship.com/projects/124310/builds/13103197 > fix: > https://github.com/apache/maven-plugins/pull/81/commits/58cbfcba342fced3fea29a50f08b6bdbf739b4d1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MPIR-348) usage of http protocol in web site for git-scm.com resources cause redirects to https
Roman Ivanov created MPIR-348: - Summary: usage of http protocol in web site for git-scm.com resources cause redirects to https Key: MPIR-348 URL: https://issues.apache.org/jira/browse/MPIR-348 Project: Maven Project Info Reports Plugin Issue Type: Bug Reporter: Roman Ivanov maven-project-info-reports-plugin: http://git-scm.com is redirecting to https://git-scm.com now, maven-linkcheck-plugin report a problem during site generation Example of linkcjeck failure is at https://codeship.com/projects/124310/builds/13103197 fix: https://github.com/apache/maven-plugins/pull/81/commits /58cbfcba342fced3fea29a50f08b6bdbf739b4d1 -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MJAVADOC-423) wrong link generation for org.xml.sax.helpers.DefaultHandler
[ https://issues.apache.org/jira/browse/MJAVADOC-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15272260#comment-15272260 ] Roman Ivanov commented on MJAVADOC-423: --- OpenJDK issue: https://bugs.openjdk.java.net/browse/JDK-8155805 > wrong link generation for org.xml.sax.helpers.DefaultHandler > > > Key: MJAVADOC-423 > URL: https://issues.apache.org/jira/browse/MJAVADOC-423 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.10.1 >Reporter: Roman Ivanov > Attachments: linkcheck.html > > > Review report: > http://checkstyle.sourceforge.net/linkcheck.html > javadoc plugin - > https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524 > here you can see number of broken links as: > "http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true: > 404 Not Found > " > problem is in "helpers.DefaultHandler.html" should be > "helpers/DefaultHandler.html" > I switched to java7 in latest code of checkstyle > (https://github.com/checkstyle/checkstyle) project , but problem is the same. > to reproduce problem please do : > git clone https://github.com/checkstyle/checkstyle > cd checkstyle > mvn -Pdistro clean package > after that review linkcheck maven report. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Reopened] (MJAVADOC-423) wrong link generation for org.xml.sax.helpers.DefaultHandler
[ https://issues.apache.org/jira/browse/MJAVADOC-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Ivanov reopened MJAVADOC-423: --- Let me reopen issue to not let it be forgotten to recheck. > wrong link generation for org.xml.sax.helpers.DefaultHandler > > > Key: MJAVADOC-423 > URL: https://issues.apache.org/jira/browse/MJAVADOC-423 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.10.1 >Reporter: Roman Ivanov > Attachments: linkcheck.html > > > Review report: > http://checkstyle.sourceforge.net/linkcheck.html > javadoc plugin - > https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524 > here you can see number of broken links as: > "http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true: > 404 Not Found > " > problem is in "helpers.DefaultHandler.html" should be > "helpers/DefaultHandler.html" > I switched to java7 in latest code of checkstyle > (https://github.com/checkstyle/checkstyle) project , but problem is the same. > to reproduce problem please do : > git clone https://github.com/checkstyle/checkstyle > cd checkstyle > mvn -Pdistro clean package > after that review linkcheck maven report. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MJAVADOC-423) wrong link generation for org.xml.sax.helpers.DefaultHandler
[
https://issues.apache.org/jira/browse/MJAVADOC-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15270578#comment-15270578
]
Roman Ivanov commented on MJAVADOC-423:
---
Yes I did a report, but Oracle still try to confirm it as a bug.
(Review ID: JI-9035943) - linkoffline option generate broken link as
"org/xml/sax/helpers.DefaultHandler.html"
Problem is in absence of newline symbol at
target/javadoc-bundle-options/package-list .
Here are steps to show problem and make a workaround
{code}
git clone https://github.com/checkstyle/checkstyle.git
cd checkstyle
mvn clean javadoc:javadoc -X
grep "helpers\.DefaultHandler\.html"
target/site/apidocs/com/puppycrawl/tools/checkstyle/api/AbstractLoader.html
<< BAD LINKS ARE SHOWN >>
cd target/site/apidocs/
./javadoc.sh
grep "helpers\.DefaultHandler\.html"
../../../target/site/apidocs/com/puppycrawl/tools/checkstyle/api/AbstractLoader.html
<< BAD LINKS ARE SHOWN >>
printf "\n" >> ../../../target/javadoc-bundle-options/package-list
./javadoc.sh
grep "helpers\.DefaultHandler\.html"
../../../target/site/apidocs/com/puppycrawl/tools/checkstyle/api/AbstractLoader.html
<< NO BAD LINKS >>
{code}
[~michael-o] , Does it make sense to do reopen this issue and just add newline
symbol to target/javadoc-bundle-options/package-list ?
fix from JDK could take a while, and bug is still not confirmed.
> wrong link generation for org.xml.sax.helpers.DefaultHandler
>
>
> Key: MJAVADOC-423
> URL: https://issues.apache.org/jira/browse/MJAVADOC-423
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 2.10.1
>Reporter: Roman Ivanov
> Attachments: linkcheck.html
>
>
> Review report:
> http://checkstyle.sourceforge.net/linkcheck.html
> javadoc plugin -
> https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524
> here you can see number of broken links as:
> "http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true:
> 404 Not Found
> "
> problem is in "helpers.DefaultHandler.html" should be
> "helpers/DefaultHandler.html"
> I switched to java7 in latest code of checkstyle
> (https://github.com/checkstyle/checkstyle) project , but problem is the same.
> to reproduce problem please do :
> git clone https://github.com/checkstyle/checkstyle
> cd checkstyle
> mvn -Pdistro clean package
> after that review linkcheck maven report.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MSITE-774) Usage of validate=true lead to "SAX2 driver class org.apache.xerces.parsers.SAXParser not found" exception
[
https://issues.apache.org/jira/browse/MSITE-774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15265811#comment-15265811
]
Roman Ivanov commented on MSITE-774:
thanks a lot, let me know if you need any details or testing in our project.
> Usage of validate=true lead to "SAX2 driver class
> org.apache.xerces.parsers.SAXParser not found" exception
> --
>
> Key: MSITE-774
> URL: https://issues.apache.org/jira/browse/MSITE-774
> Project: Maven Site Plugin
> Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Roman Ivanov
>
> project: https://github.com/checkstyle/checkstyle
> usage of validate=true:
> {code}
> ...
> org.apache.maven.plugins
> maven-site-plugin
> ${maven.site.plugin.version}
>
> ${basedir}/src/xdocs
> true
>
> ...
> {code}
> lead to
> {code}
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-site-plugin:3.5.1:site (default-site) on
> project checkstyle: Error parsing
> '~/checkstyle/checkstyle/src/xdocs/anttask.xml.vm': line [-1] Error
> validating the model: SAX2 driver class org.apache.xerces.parsers.SAXParser
> not found -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> goal org.apache.maven.plugins:maven-site-plugin:3.5.1:site (default-site) on
> project checkstyle: Error parsing
> '~/checkstyle/checkstyle/src/xdocs/anttask.xml.vm': line [-1] Error
> validating the model: SAX2 driver class org.apache.xerces.parsers.SAXParser
> not found
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
> at
> org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
> at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
> at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
> at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
> at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:216)
> at org.apache.maven.cli.MavenCli.main(MavenCli.java:160)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:497)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
> at
> org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Error parsing
> '~/checkstyle/checkstyle/src/xdocs/anttask.xml.vm': line [-1] Error
> validating the model: SAX2 driver class org.apache.xerces.parsers.SAXParser
> not found
> at
> org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:140)
> at
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
> ... 19 more
> Caused by: org.apache.maven.doxia.siterenderer.RendererException: Error
> parsing '~/checkstyle/checkstyle/src/xdocs/anttask.xml.vm': line [-1] Error
> validating the model: SAX2 driver class org.apache.xerces.parsers.SAXParser
> not found
> at
> org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderDocument(DefaultSiteRenderer.java:449)
> at
> org.apache.maven.doxia.siterenderer.DoxiaDocumentRenderer.renderDocument(DoxiaDocumentRenderer.java:53)
> at
> org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:329)
> at
> org.apache.maven.plugins.site.render.SiteMojo.renderDoxiaDocuments(SiteMojo.java:264)
> at
> org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:171)
> at
> org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:135)
> ... 21 more
> Caused by:
[jira] [Created] (MSITE-774) Usage of validate=true lead to "SAX2 driver class org.apache.xerces.parsers.SAXParser not found" exception
Roman Ivanov created MSITE-774:
--
Summary: Usage of validate=true lead to "SAX2 driver class
org.apache.xerces.parsers.SAXParser not found" exception
Key: MSITE-774
URL: https://issues.apache.org/jira/browse/MSITE-774
Project: Maven Site Plugin
Issue Type: Bug
Affects Versions: 3.5.1
Reporter: Roman Ivanov
project: https://github.com/checkstyle/checkstyle
usage of validate=true:
{code}
...
org.apache.maven.plugins
maven-site-plugin
${maven.site.plugin.version}
${basedir}/src/xdocs
true
...
{code}
lead to
{code}
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.5.1:site (default-site) on project
checkstyle: Error parsing '~/checkstyle/checkstyle/src/xdocs/anttask.xml.vm':
line [-1] Error validating the model: SAX2 driver class
org.apache.xerces.parsers.SAXParser not found -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.5.1:site (default-site) on project
checkstyle: Error parsing '~/checkstyle/checkstyle/src/xdocs/anttask.xml.vm':
line [-1] Error validating the model: SAX2 driver class
org.apache.xerces.parsers.SAXParser not found
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:216)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:116)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:80)
at
org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build(SingleThreadedBuilder.java:51)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:120)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:355)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:155)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:584)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:216)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:160)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:289)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:229)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:415)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:356)
Caused by: org.apache.maven.plugin.MojoExecutionException: Error parsing
'~/checkstyle/checkstyle/src/xdocs/anttask.xml.vm': line [-1] Error validating
the model: SAX2 driver class org.apache.xerces.parsers.SAXParser not found
at
org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:140)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:132)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:208)
... 19 more
Caused by: org.apache.maven.doxia.siterenderer.RendererException: Error parsing
'~/checkstyle/checkstyle/src/xdocs/anttask.xml.vm': line [-1] Error validating
the model: SAX2 driver class org.apache.xerces.parsers.SAXParser not found
at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderDocument(DefaultSiteRenderer.java:449)
at
org.apache.maven.doxia.siterenderer.DoxiaDocumentRenderer.renderDocument(DoxiaDocumentRenderer.java:53)
at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:329)
at
org.apache.maven.plugins.site.render.SiteMojo.renderDoxiaDocuments(SiteMojo.java:264)
at
org.apache.maven.plugins.site.render.SiteMojo.renderLocale(SiteMojo.java:171)
at
org.apache.maven.plugins.site.render.SiteMojo.execute(SiteMojo.java:135)
... 21 more
Caused by: org.apache.maven.doxia.parser.ParseException: Error validating the
model: SAX2 driver class org.apache.xerces.parsers.SAXParser not found
at
org.apache.maven.doxia.util.XmlValidator.validate(XmlValidator.java:116)
at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.validate(DefaultSiteRenderer.java:1084)
at
org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderDocument(DefaultSiteRenderer.java:414)
... 26
[jira] [Resolved] (MJAVADOC-428) problem with generation link to DefaultHandler
[
https://issues.apache.org/jira/browse/MJAVADOC-428?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roman Ivanov resolved MJAVADOC-428.
---
Resolution: Duplicate
duplicate of MJAVADOC-423
> problem with generation link to DefaultHandler
> --
>
> Key: MJAVADOC-428
> URL: https://issues.apache.org/jira/browse/MJAVADOC-428
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 2.10.3
>Reporter: Roman Ivanov
>
> problem is described at https://jira.codehaus.org/browse/MJAVADOC-425
> update for new doxia works well the only issue left is :
> {quote}
> One more case:
> http://docs.oracle.com/javase/7/docs/api/org/xml/sax
> /helpers.DefaultHandler.html?is-external=true: 404 Not Found
> This link is broken because DefaultHandler is preceded by dot instead of '/'.
> {quote}
> Looks like it is not related to doxia version problem, but still a problem.
> You can find that error there -
> http://checkstyle.sourceforge.net/linkcheck.html
> to reproduce that problem please comment out line
> https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L1100
> and run "mvn clean site"
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MJAVADOC-423) wrong link generation for org.xml.sax.helpers.DefaultHandler
[ https://issues.apache.org/jira/browse/MJAVADOC-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15250399#comment-15250399 ] Roman Ivanov commented on MJAVADOC-423: --- ok, thanks a lot for details. Please close the issue. I will put a link here to new issue(jdk problem) when I open ticket against JDK. > wrong link generation for org.xml.sax.helpers.DefaultHandler > > > Key: MJAVADOC-423 > URL: https://issues.apache.org/jira/browse/MJAVADOC-423 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.10.1 >Reporter: Roman Ivanov > Attachments: linkcheck.html > > > Review report: > http://checkstyle.sourceforge.net/linkcheck.html > javadoc plugin - > https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524 > here you can see number of broken links as: > "http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true: > 404 Not Found > " > problem is in "helpers.DefaultHandler.html" should be > "helpers/DefaultHandler.html" > I switched to java7 in latest code of checkstyle > (https://github.com/checkstyle/checkstyle) project , but problem is the same. > to reproduce problem please do : > git clone https://github.com/checkstyle/checkstyle > cd checkstyle > mvn -Pdistro clean package > after that review linkcheck maven report. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MJAVADOC-423) wrong link generation for org.xml.sax.helpers.DefaultHandler
[
https://issues.apache.org/jira/browse/MJAVADOC-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248809#comment-15248809
]
Roman Ivanov commented on MJAVADOC-423:
---
the same result of latest maven + java:
{code}
$ mvn --version
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T08:41:47-08:00)
Maven home: /opt/maven/default
Java version: 1.8.0_92, vendor: Oracle Corporation
Java home: /opt/jdk1.8.0_92/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.13.0-83-generic", arch: "amd64", family: "unix"
{code}
> wrong link generation for org.xml.sax.helpers.DefaultHandler
>
>
> Key: MJAVADOC-423
> URL: https://issues.apache.org/jira/browse/MJAVADOC-423
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 2.10.1
>Reporter: Roman Ivanov
> Attachments: linkcheck.html
>
>
> Review report:
> http://checkstyle.sourceforge.net/linkcheck.html
> javadoc plugin -
> https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524
> here you can see number of broken links as:
> "http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true:
> 404 Not Found
> "
> problem is in "helpers.DefaultHandler.html" should be
> "helpers/DefaultHandler.html"
> I switched to java7 in latest code of checkstyle
> (https://github.com/checkstyle/checkstyle) project , but problem is the same.
> to reproduce problem please do :
> git clone https://github.com/checkstyle/checkstyle
> cd checkstyle
> mvn -Pdistro clean package
> after that review linkcheck maven report.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MJAVADOC-423) wrong link generation for org.xml.sax.helpers.DefaultHandler
[
https://issues.apache.org/jira/browse/MJAVADOC-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248763#comment-15248763
]
Roman Ivanov commented on MJAVADOC-423:
---
https://codeship.com/projects/124310/builds/14003186
has:
{code}
Linux railsonfire_836f5010-e89a-0133-fade-065ce6cf3321_ddca25c900cf
3.13.0-58-generic #97-Ubuntu SMP Wed Jul 8 02:56:15 UTC 2015 x86_64 x86_64
x86_64 GNU/Linux
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
2014-12-14T17:29:23+00:00)
Maven home: /home/rof/.maven/maven
Java version: 1.8.0_77, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-oracle/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "3.13.0-58-generic", arch: "amd64", family: "unix"
{code}
I will try the latest maven, but problem looks like related to maven plugin,
and we use the most recent released version.
Linux vs Windows could be nuance.
> wrong link generation for org.xml.sax.helpers.DefaultHandler
>
>
> Key: MJAVADOC-423
> URL: https://issues.apache.org/jira/browse/MJAVADOC-423
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 2.10.1
>Reporter: Roman Ivanov
> Attachments: linkcheck.html
>
>
> Review report:
> http://checkstyle.sourceforge.net/linkcheck.html
> javadoc plugin -
> https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524
> here you can see number of broken links as:
> "http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true:
> 404 Not Found
> "
> problem is in "helpers.DefaultHandler.html" should be
> "helpers/DefaultHandler.html"
> I switched to java7 in latest code of checkstyle
> (https://github.com/checkstyle/checkstyle) project , but problem is the same.
> to reproduce problem please do :
> git clone https://github.com/checkstyle/checkstyle
> cd checkstyle
> mvn -Pdistro clean package
> after that review linkcheck maven report.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MJAVADOC-423) wrong link generation for org.xml.sax.helpers.DefaultHandler
[
https://issues.apache.org/jira/browse/MJAVADOC-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248553#comment-15248553
]
Roman Ivanov edited comment on MJAVADOC-423 at 4/19/16 8:37 PM:
hmm, interesting...
Independent linux environment:
https://github.com/checkstyle/checkstyle/pull/3120 , failure is shared at
https://codeship.com/projects/124310/builds/14003186
We do not have Windows build for this :( for now.
Command that is used in Codeship CI:
https://github.com/checkstyle/checkstyle/issues/2727#issuecomment-172616360
My local:
{code}
✔ ~/checkstyle/checkstyle [mjavadoc-423 L|✚ 1]
13:20 $ git diff
diff --git a/pom.xml b/pom.xml
index 02085b7..2cbbaae 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1165,7 +1165,7 @@
and http://jira.codehaus.org/browse/DOXIA-525 and
http://jira.codehaus.org/browse/MLINKCHECK-21 will be fixed -->
**/com/puppycrawl/**
**/com/puppycrawl/**
> Key: MJAVADOC-423
> URL: https://issues.apache.org/jira/browse/MJAVADOC-423
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 2.10.1
>Reporter: Roman Ivanov
> Attachments: linkcheck.html
>
>
> Review report:
> http://checkstyle.sourceforge.net/linkcheck.html
> javadoc plugin -
> https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524
> here you can see number of broken links as:
> "http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true:
> 404 Not Found
> "
> problem is in "helpers.DefaultHandler.html" should be
> "helpers/DefaultHandler.html"
> I switched to java7 in latest code of checkstyle
> (https://github.com/checkstyle/checkstyle) project , but problem is the same.
> to reproduce problem please do :
> git clone https://github.com/checkstyle/checkstyle
> cd checkstyle
> mvn -Pdistro clean package
> after that review linkcheck maven report.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MJAVADOC-423) wrong link generation for org.xml.sax.helpers.DefaultHandler
[
https://issues.apache.org/jira/browse/MJAVADOC-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248553#comment-15248553
]
Roman Ivanov edited comment on MJAVADOC-423 at 4/19/16 8:29 PM:
hmm, interesting...
Independent linux environment:
https://github.com/checkstyle/checkstyle/pull/3120 , failure will be
https://codeship.com/projects/124310/builds/14003186
We do not have Windows build for this :( for now.
Command that is used in Codeship CI:
https://github.com/checkstyle/checkstyle/issues/2727#issuecomment-172616360
My local:
{code}
✔ ~/checkstyle/checkstyle [mjavadoc-423 L|✚ 1]
13:20 $ git diff
diff --git a/pom.xml b/pom.xml
index 02085b7..2cbbaae 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1165,7 +1165,7 @@
and http://jira.codehaus.org/browse/DOXIA-525 and
http://jira.codehaus.org/browse/MLINKCHECK-21 will be fixed -->
**/com/puppycrawl/**
**/com/puppycrawl/**
> Key: MJAVADOC-423
> URL: https://issues.apache.org/jira/browse/MJAVADOC-423
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 2.10.1
>Reporter: Roman Ivanov
> Attachments: linkcheck.html
>
>
> Review report:
> http://checkstyle.sourceforge.net/linkcheck.html
> javadoc plugin -
> https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524
> here you can see number of broken links as:
> "http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true:
> 404 Not Found
> "
> problem is in "helpers.DefaultHandler.html" should be
> "helpers/DefaultHandler.html"
> I switched to java7 in latest code of checkstyle
> (https://github.com/checkstyle/checkstyle) project , but problem is the same.
> to reproduce problem please do :
> git clone https://github.com/checkstyle/checkstyle
> cd checkstyle
> mvn -Pdistro clean package
> after that review linkcheck maven report.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MJAVADOC-423) wrong link generation for org.xml.sax.helpers.DefaultHandler
[
https://issues.apache.org/jira/browse/MJAVADOC-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15248553#comment-15248553
]
Roman Ivanov commented on MJAVADOC-423:
---
hmm, interesting...
Independent linux environment:
https://github.com/checkstyle/checkstyle/pull/3120 , failure will be
https://codeship.com/projects/124310/builds/14003186
We do not have Windows build for this :( for now.
My local:
{code}
✔ ~/checkstyle/checkstyle [mjavadoc-423 L|✚ 1]
13:20 $ git diff
diff --git a/pom.xml b/pom.xml
index 02085b7..2cbbaae 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1165,7 +1165,7 @@
and http://jira.codehaus.org/browse/DOXIA-525 and
http://jira.codehaus.org/browse/MLINKCHECK-21 will be fixed -->
**/com/puppycrawl/**
> Key: MJAVADOC-423
> URL: https://issues.apache.org/jira/browse/MJAVADOC-423
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 2.10.1
>Reporter: Roman Ivanov
> Attachments: linkcheck.html
>
>
> Review report:
> http://checkstyle.sourceforge.net/linkcheck.html
> javadoc plugin -
> https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524
> here you can see number of broken links as:
> "http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true:
> 404 Not Found
> "
> problem is in "helpers.DefaultHandler.html" should be
> "helpers/DefaultHandler.html"
> I switched to java7 in latest code of checkstyle
> (https://github.com/checkstyle/checkstyle) project , but problem is the same.
> to reproduce problem please do :
> git clone https://github.com/checkstyle/checkstyle
> cd checkstyle
> mvn -Pdistro clean package
> after that review linkcheck maven report.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MJAVADOC-423) wrong link generation for org.xml.sax.helpers.DefaultHandler
[
https://issues.apache.org/jira/browse/MJAVADOC-423?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246059#comment-15246059
]
Roman Ivanov commented on MJAVADOC-423:
---
Problems still acute, I just made a suppression to let me fix and control all
other problems.
steps to reproduce:
1)
change pom.xml like:
{code}
checkstyle/checkstyle [master|✚ 1] $ git diff
diff --git a/pom.xml b/pom.xml
index 02085b7..dbf974d 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1165,7 +1165,7 @@
and http://jira.codehaus.org/browse/DOXIA-525 and
http://jira.codehaus.org/browse/MLINKCHECK-21 will be fix
**/com/puppycrawl/**
> Key: MJAVADOC-423
> URL: https://issues.apache.org/jira/browse/MJAVADOC-423
> Project: Maven Javadoc Plugin
> Issue Type: Bug
>Affects Versions: 2.10.1
>Reporter: Roman Ivanov
>
> Review report:
> http://checkstyle.sourceforge.net/linkcheck.html
> javadoc plugin -
> https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524
> here you can see number of broken links as:
> "http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true:
> 404 Not Found
> "
> problem is in "helpers.DefaultHandler.html" should be
> "helpers/DefaultHandler.html"
> I switched to java7 in latest code of checkstyle
> (https://github.com/checkstyle/checkstyle) project , but problem is the same.
> to reproduce problem please do :
> git clone https://github.com/checkstyle/checkstyle
> cd checkstyle
> mvn -Pdistro clean package
> after that review linkcheck maven report.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Reopened] (MJAVADOC-423) wrong link generation for org.xml.sax.helpers.DefaultHandler
[ https://issues.apache.org/jira/browse/MJAVADOC-423?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Ivanov reopened MJAVADOC-423: --- > wrong link generation for org.xml.sax.helpers.DefaultHandler > > > Key: MJAVADOC-423 > URL: https://issues.apache.org/jira/browse/MJAVADOC-423 > Project: Maven Javadoc Plugin > Issue Type: Bug >Affects Versions: 2.10.1 >Reporter: Roman Ivanov > > Review report: > http://checkstyle.sourceforge.net/linkcheck.html > javadoc plugin - > https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524 > here you can see number of broken links as: > "http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true: > 404 Not Found > " > problem is in "helpers.DefaultHandler.html" should be > "helpers/DefaultHandler.html" > I switched to java7 in latest code of checkstyle > (https://github.com/checkstyle/checkstyle) project , but problem is the same. > to reproduce problem please do : > git clone https://github.com/checkstyle/checkstyle > cd checkstyle > mvn -Pdistro clean package > after that review linkcheck maven report. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-314) checkstyle:check should invoke the execution of this plugin's goal "checkstyle" prior to executing itself
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-314?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15190244#comment-15190244 ] Roman Ivanov commented on MCHECKSTYLE-314: -- [~michael-o], is there a plan to release this issue (2.18 is release date is not defined) ? 3 month is passed from fix. > checkstyle:check should invoke the execution of this plugin's goal > "checkstyle" prior to executing itself > - > > Key: MCHECKSTYLE-314 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-314 > Project: Maven Checkstyle Plugin > Issue Type: Improvement >Affects Versions: 2.17 >Reporter: Roman Ivanov >Assignee: Michael Osipov > Fix For: 2.18 > > > I run into problem with using checkstyles goal "checkstyle:check" in > sevntu.checkstyle project > (https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/sevntu-checks/pom.xml#L75) > as it always use default Sun config when I run "checkstyle:check", It took > me a while to figure out why that does not work. > I had a habit and convenience to run in such a ways pmd and findbug, just > "mvn pmd:check", "mvn findbug:check" it is human friendly. > PMD and Findbugs plugins already do this: > http://gleclaire.github.io/findbugs-maven-plugin/check-mojo.html > https://maven.apache.org/plugins/maven-pmd-plugin/check-mojo.html > search for "Invokes the execution of this plugin's goal" > vs > http://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html > Problem was also raised at : > http://stackoverflow.com/questions/11106767/maven-checkstylecheck-not-working > Please add support of this, most users are not professionals in Maven. I use > Maven for many years and it took me too much time to find a reason why it > does not work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MCHECKSTYLE-314) checkstyle:check should invoke the execution of this plugin's goal "checkstyle" prior to executing itself
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-314?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Ivanov updated MCHECKSTYLE-314: - Description: I run into problem with using checkstyles goal "checkstyle:check" in sevntu.checkstyle project (https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/sevntu-checks/pom.xml#L75) as it always use default Sun config when I run "checkstyle:check", It took me a while to figure out why that does not work. I had a habit and convenience to run in such a ways pmd and findbug, just "mvn pmd:check", "mvn findbug:check" it is human friendly. PMD and Findbugs plugins already do this: http://gleclaire.github.io/findbugs-maven-plugin/check-mojo.html https://maven.apache.org/plugins/maven-pmd-plugin/check-mojo.html search for "Invokes the execution of this plugin's goal" vs http://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html Problem was also raised at : http://stackoverflow.com/questions/11106767/maven-checkstylecheck-not-working Please add support of this, most users are not professionals in Maven. I use Maven for many years and it took me too much time to find a reason why it does not work. was: I run into problem with using checkstyles goal "checkstyle:check" in sevntu.checkstyle project (https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/sevntu-checks/pom.xml#L75) as it always use default sun config when I run "checkstyle:check", It took me a while to figure out why that does not work. I had a habit and convenience to run in such a ways pmd and findbug, just "mvn pmd:check", "mvn findbug:check" it is human friendly. PMD and Findbugs plugins already do this: http://gleclaire.github.io/findbugs-maven-plugin/check-mojo.html https://maven.apache.org/plugins/maven-pmd-plugin/check-mojo.html search for "Invokes the execution of this plugin's goal" vs http://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html Problem was also raised at : http://stackoverflow.com/questions/11106767/maven-checkstylecheck-not-working Please add support of this, most users are not professionals in Maven. I use Maven for many years and it took me too much time to find a reason why it does not work. > checkstyle:check should invoke the execution of this plugin's goal > "checkstyle" prior to executing itself > - > > Key: MCHECKSTYLE-314 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-314 > Project: Maven Checkstyle Plugin > Issue Type: Improvement >Affects Versions: 2.17 >Reporter: Roman Ivanov > > I run into problem with using checkstyles goal "checkstyle:check" in > sevntu.checkstyle project > (https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/sevntu-checks/pom.xml#L75) > as it always use default Sun config when I run "checkstyle:check", It took > me a while to figure out why that does not work. > I had a habit and convenience to run in such a ways pmd and findbug, just > "mvn pmd:check", "mvn findbug:check" it is human friendly. > PMD and Findbugs plugins already do this: > http://gleclaire.github.io/findbugs-maven-plugin/check-mojo.html > https://maven.apache.org/plugins/maven-pmd-plugin/check-mojo.html > search for "Invokes the execution of this plugin's goal" > vs > http://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html > Problem was also raised at : > http://stackoverflow.com/questions/11106767/maven-checkstylecheck-not-working > Please add support of this, most users are not professionals in Maven. I use > Maven for many years and it took me too much time to find a reason why it > does not work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MCHECKSTYLE-314) checkstyle:check should invoke the execution of this plugin's goal "checkstyle" prior to executing itself
Roman Ivanov created MCHECKSTYLE-314: Summary: checkstyle:check should invoke the execution of this plugin's goal "checkstyle" prior to executing itself Key: MCHECKSTYLE-314 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-314 Project: Maven Checkstyle Plugin Issue Type: Improvement Affects Versions: 2.17 Reporter: Roman Ivanov I run into problem with using checkstyles goal "checkstyle:check" in sevntu.checkstyle project (https://github.com/sevntu-checkstyle/sevntu.checkstyle/blob/master/sevntu-checks/pom.xml#L75) as it always use default sun config when I run "checkstyle:check", It took me a while to figure out why that does not work. I had a habit and convenience to run in such a ways pmd and findbug, just "mvn pmd:check", "mvn findbug:check" it is human friendly. PMD and Findbugs plugins already do this: http://gleclaire.github.io/findbugs-maven-plugin/check-mojo.html https://maven.apache.org/plugins/maven-pmd-plugin/check-mojo.html search for "Invokes the execution of this plugin's goal" vs http://maven.apache.org/plugins/maven-checkstyle-plugin/check-mojo.html Problem was also raised at : http://stackoverflow.com/questions/11106767/maven-checkstylecheck-not-working Please add support of this, most users are not professionals in Maven. I use Maven for many years and it took me too much time to find a reason why it does not work. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-289) enableRulesSummary option does not show Rules with default configuration
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14954843#comment-14954843 ] Roman Ivanov commented on MCHECKSTYLE-289: -- Michael, still no plugin release, do you have problems with release ? > enableRulesSummary option does not show Rules with default configuration > > > Key: MCHECKSTYLE-289 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-289 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Reporter: Roman Ivanov > > In Checkstyle development we use maven plugin a lot. > Option: > http://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html#enableRulesSummary > that option is convenient to estimate on what Rule set it was generated. > But it does not show Rule if it configured by default. > It that is bug- please fix, if that done on good reason please provide > additional option. > Example: > http://checkstyle.sourceforge.net/reports/google-style/guava/ > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml#L37 > Example where it not clear on what config that report was generated: > http://damianszczepanik.github.io/sevntu.checkstyle/sevntu.checkstyle/pull/327/index.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Updated] (MCHECKSTYLE-312) Custom Checks are not shown at Rules sections
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roman Ivanov updated MCHECKSTYLE-312: - Attachment: Screenshot-empty-Rules-for-custom-Checks.png > Custom Checks are not shown at Rules sections > - > > Key: MCHECKSTYLE-312 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-312 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.16 > Environment: linux >Reporter: Roman Ivanov > Attachments: Screenshot-empty-Rules-for-custom-Checks.png > > > Report example - http://vladlis.github.io/reports/static_check/orekit_before/ > If link does not exists, see attached image. > Problem: Custom checks are not show in Rules section, that make it hard to > understand how Check was configured to report that amount of violations. > Expected: Rules section should contain all checks that are used in config and > there options(parameters). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MCHECKSTYLE-312) Custom Checks are not shown at Rules sections
Roman Ivanov created MCHECKSTYLE-312: Summary: Custom Checks are not shown at Rules sections Key: MCHECKSTYLE-312 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-312 Project: Maven Checkstyle Plugin Issue Type: Bug Affects Versions: 2.16 Environment: linux Reporter: Roman Ivanov Attachments: Screenshot-empty-Rules-for-custom-Checks.png Report example - http://vladlis.github.io/reports/static_check/orekit_before/ If link does not exists, see attached image. Problem: Custom checks are not show in Rules section, that make it hard to understand how Check was configured to report that amount of violations. Expected: Rules section should contain all checks that are used in config and there options(parameters). -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-289) enableRulesSummary option does not show Rules with default configuration
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14938776#comment-14938776 ] Roman Ivanov commented on MCHECKSTYLE-289: -- We already waiting for long time, we can postpone this issue to next release. > enableRulesSummary option does not show Rules with default configuration > > > Key: MCHECKSTYLE-289 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-289 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Reporter: Roman Ivanov > > In Checkstyle development we use maven plugin a lot. > Option: > http://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html#enableRulesSummary > that option is convenient to estimate on what Rule set it was generated. > But it does not show Rule if it configured by default. > It that is bug- please fix, if that done on good reason please provide > additional option. > Example: > http://checkstyle.sourceforge.net/reports/google-style/guava/ > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml#L37 > Example where it not clear on what config that report was generated: > http://damianszczepanik.github.io/sevntu.checkstyle/sevntu.checkstyle/pull/327/index.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-293) usage of Checker.setClassLoader method
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14938760#comment-14938760 ] Roman Ivanov commented on MCHECKSTYLE-293: -- You are still on svn, for PR, do you mean patch file ? Or I am missung simething. > usage of Checker.setClassLoader method > -- > > Key: MCHECKSTYLE-293 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-293 > Project: Maven Checkstyle Plugin > Issue Type: Improvement >Affects Versions: 2.15 >Reporter: Roman Ivanov > > Reason: https://github.com/checkstyle/checkstyle/issues/922 > Will be released at the end of May as 6.7 version. > As Checkstyle project use plugin for testing, we can not remove old method, > and keep deprecated method we also do not want to for long time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-293) usage of Checker.setClassLoader method
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939163#comment-14939163 ] Roman Ivanov commented on MCHECKSTYLE-293: -- It would attract more patches to your code if you put this info to project web site. After Checkstyle switched to github, I had several PRs per week from community, now checkstyle project have more then 10 per week. > usage of Checker.setClassLoader method > -- > > Key: MCHECKSTYLE-293 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-293 > Project: Maven Checkstyle Plugin > Issue Type: Improvement >Affects Versions: 2.15 >Reporter: Roman Ivanov > > Reason: https://github.com/checkstyle/checkstyle/issues/922 > Will be released at the end of May as 6.7 version. > As Checkstyle project use plugin for testing, we can not remove old method, > and keep deprecated method we also do not want to for long time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-293) usage of Checker.setClassLoader method
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939155#comment-14939155 ] Roman Ivanov commented on MCHECKSTYLE-293: -- PR - https://github.com/apache/maven-plugins/pull/63 > usage of Checker.setClassLoader method > -- > > Key: MCHECKSTYLE-293 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-293 > Project: Maven Checkstyle Plugin > Issue Type: Improvement >Affects Versions: 2.15 >Reporter: Roman Ivanov > > Reason: https://github.com/checkstyle/checkstyle/issues/922 > Will be released at the end of May as 6.7 version. > As Checkstyle project use plugin for testing, we can not remove old method, > and keep deprecated method we also do not want to for long time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-289) enableRulesSummary option does not show Rules with default configuration
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14939167#comment-14939167 ] Roman Ivanov commented on MCHECKSTYLE-289: -- As I described in above: please open https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml#L37 there is OuterTypeFilename Check configuration, now take a look at maven report http://checkstyle.sourceforge.net/reports/google-style/guava/ and try to search "OuterTypeFilename" on the page. There is no any appearance. It is possible that there is no such violations. But it is absent at "Rules" section ? Most likely due to the fact that its configuration is default or maybe due to 0 violations, but that will be very useful to see by report that such Check was recognised by plugin and have default configuration, and amount of violations is 0. > enableRulesSummary option does not show Rules with default configuration > > > Key: MCHECKSTYLE-289 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-289 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Reporter: Roman Ivanov > > In Checkstyle development we use maven plugin a lot. > Option: > http://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html#enableRulesSummary > that option is convenient to estimate on what Rule set it was generated. > But it does not show Rule if it configured by default. > It that is bug- please fix, if that done on good reason please provide > additional option. > Example: > http://checkstyle.sourceforge.net/reports/google-style/guava/ > https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml#L37 > Example where it not clear on what config that report was generated: > http://damianszczepanik.github.io/sevntu.checkstyle/sevntu.checkstyle/pull/327/index.html -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-307) Upgrade to Checkstyle 6.10.1+
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803086#comment-14803086
]
Roman Ivanov commented on MCHECKSTYLE-307:
--
> Roman Ivanov, can we make some progress here?
[~michael-o], pleased point me to exact issue in Checkstyle
> Upgrade to Checkstyle 6.10.1+
> -
>
> Key: MCHECKSTYLE-307
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-307
> Project: Maven Checkstyle Plugin
> Issue Type: Task
>Affects Versions: 2.16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>
> Hi folks,
> I have upraded Checkstyle locally and almost all ITs pass except for the
> issues [~denn...@apache.org] already has described:
> {quote}
> Changes in Checkstyle 6.3 that impact this plugin:
> * The IT MCHECKSTYLE-214-basedir-resource fails after upgrade to Checkstyle
> 6.3 with NPE - I have not found a solution for this yet
> Changes in Checkstyle 6.6 that impact this plugin:
> * DefaultLogger( OutputStream, boolean ) now throws
> UnsupportedEncodingException - this is easy to fix
> {quote}
> The first issue is caused because the default checkfiles apply to specific
> file extensions now, so IT for MCHECKSTYLE-214. [~rfscholte], what do you
> think about it. We can invert the test or add a custom {{sun_checks.xml}}.
> The second one can be fixed with the linked GH issue.
> I am willing to promote a release if I get some help to resolve the issues
> above.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-308) Include config in checkstyle site results
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803057#comment-14803057 ] Roman Ivanov commented on MCHECKSTYLE-308: -- > the only questionis: how do you expect to render that information? to make it simple as first step, just make Check name appear in configuration table where all other non-default-configured Checks are present. > the XML view will just be pure text with line numbers on the left side. that will be good too, but see my point above. > Include config in checkstyle site results > - > > Key: MCHECKSTYLE-308 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-308 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle >Affects Versions: 2.16 > Environment: Windows 7, Eclipse Kepler SR2 >Reporter: richard >Priority: Minor > > When running "mvn site" to create a checkstyle report of code, it includes > the file location of the configuration file it is running with, but it > doesn't include the physical configuration in the report. > Example: http://rnveach.github.io/checkstyle/checkstyle.html > "The following document contains the results of Checkstyle 6.11-SNAPSHOT with > D:\Rickys\Java\checkstyleWorkspaceEclipse\contribution\checkstyle-tester\my_check.xml > ruleset." > When showing this report to others as a proof of some fix, especially over > the internet, it would be worth it to include the configuration in the > reports to verify that they are using the correct checks and to be able to > reproduce any warning/errors they have with their code. > To the viewers of the report, a mis-configured configuration file can look > the same as a properly configured one with no errors/warnings. > It is also possible to use a local configuration on the hard drive, instead > of a global one, which will hide the settings of the configuration and not > provide a visualization of its contents at the time the report was run. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-307) Upgrade to Checkstyle 6.10.1+
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14803297#comment-14803297
]
Roman Ivanov commented on MCHECKSTYLE-307:
--
> I am waiting now for the GitHub issue to be resolved. Roman Ivanov, can we
> make some progress here?
Sorry I am might be blind, please point me to github issue that you wait to be
resolved.
> Upgrade to Checkstyle 6.10.1+
> -
>
> Key: MCHECKSTYLE-307
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-307
> Project: Maven Checkstyle Plugin
> Issue Type: Task
>Affects Versions: 2.16
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>
> Hi folks,
> I have upraded Checkstyle locally and almost all ITs pass except for the
> issues [~denn...@apache.org] already has described:
> {quote}
> Changes in Checkstyle 6.3 that impact this plugin:
> * The IT MCHECKSTYLE-214-basedir-resource fails after upgrade to Checkstyle
> 6.3 with NPE - I have not found a solution for this yet
> Changes in Checkstyle 6.6 that impact this plugin:
> * DefaultLogger( OutputStream, boolean ) now throws
> UnsupportedEncodingException - this is easy to fix
> {quote}
> The first issue is caused because the default checkfiles apply to specific
> file extensions now, so IT for MCHECKSTYLE-214. [~rfscholte], what do you
> think about it. We can invert the test or add a custom {{sun_checks.xml}}.
> The second one can be fixed with the linked GH issue.
> I am willing to promote a release if I get some help to resolve the issues
> above.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-308) Include config in checkstyle site results
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742068#comment-14742068 ] Roman Ivanov commented on MCHECKSTYLE-308: -- After using HTML plugin reports for few years to verify each violations in report, I confirm that such update will be very useful. It even make sense to raise priority as this feature will be used in checkstyle development process right after it be implemented. > Include config in checkstyle site results > - > > Key: MCHECKSTYLE-308 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-308 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:checkstyle >Affects Versions: 2.16 > Environment: Windows 7, Eclipse Kepler SR2 >Reporter: richard >Priority: Minor > > When running "mvn site" to create a checkstyle report of code, it includes > the file location of the configuration file it is running with, but it > doesn't include the physical configuration in the report. > Example: http://rnveach.github.io/checkstyle/checkstyle.html > "The following document contains the results of Checkstyle 6.11-SNAPSHOT with > D:\Rickys\Java\checkstyleWorkspaceEclipse\contribution\checkstyle-tester\my_check.xml > ruleset." > When showing this report to others as a proof of some fix, especially over > the internet, it would be worth it to include the configuration in the > reports to verify that they are using the correct checks and to be able to > reproduce any warning/errors they have with their code. > To the viewers of the report, a mis-configured configuration file can look > the same as a properly configured one with no errors/warnings. > It is also possible to use a local configuration on the hard drive, instead > of a global one, which will hide the settings of the configuration and not > provide a visualization of its contents at the time the report was run. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-290) add a history table to show which version of Chesktyle is used by default in which version of m-checkstyle-p
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14634311#comment-14634311 ] Roman Ivanov commented on MCHECKSTYLE-290: -- but I don't know how to track evolution in Chesktyle documentation new check is rare event for Checkstyle for now. Usually we extend Check with new options to let it be more customizable to user expectations. In release notes we try to split such updates to separate group to ease user detection of that. But it might be reasonable to keep track in what version Check is introduced and in what version option is introduced. We show only latest documentation , and plugin is always behind by version of used checkstyle. add a history table to show which version of Chesktyle is used by default in which version of m-checkstyle-p Key: MCHECKSTYLE-290 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-290 Project: Maven Checkstyle Plugin Issue Type: Improvement Affects Versions: 2.15 Reporter: Hervé Boutemy Assignee: Hervé Boutemy Fix For: 2.16 this will ease people having problems probably related to Checkstyle evolution, but which are hard to track at the moment see http://mail-archives.apache.org/mod_mbox/maven-users/201504.mbox/%3C0A05D02C-865F-452F-8EA3-CEE499010396%40talios.com%3E notice with that documentation, it will be easier to go from m-checkstyle-p version to Checkstyle version, but I don't know how to track evolution in Chesktyle documentation... -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-300) Upgrade to Checkstyle 6.8.x+
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14616099#comment-14616099
]
Roman Ivanov commented on MCHECKSTYLE-300:
--
Hi [~denn...@apache.org] ,
{quote}The version of Checkstyle used in the upcoming 2.16 version of the
plugin requires Java 7, which has meant a bunch of changes to the POM (this is
the first Maven plugin that will require Java 7){quote}
Sorry for causing a problem by that, it was my decision that helped me to
attract more contributors to the project, there is no fun to contribute by Java
that is outdated. Even java7 already got EOL , do you know plans for upgrade
of pom's to java8 ?
{quote} I wanted to use the latest version of Checkstyle for the release, but
got stuck when upgrading, see MCHECKSTYLE-292{quote}
can you point me exact problem with that upgrade, I see reference to closed
issue and reference to changes in c-tor signature that will result in
additional catch in plugin as maximum, am I miss smth ?
{quote} it would be great if you could have a look at MCHECKSTYLE-292 and help
us get past the problems described in there.{quote}
see my answer above , please do not hesitate to contact our team at mail-list
(https://groups.google.com/forum/#!forum/checkstyle-devel) for any help or
problem you run into.
{quote} I will try to push for a release of the plugin now, in its current
state. Then when we get MCHECKSTYLE-292 solved I can push for another
release.{quote}
please do 2.16 , and 292 we will resolve as next step.
It would be really nice for plugin to catch up to almost same rollout schedule
(introducing checkstyle version bump as a hotfix release 2.16.1, 2.16.2
,..) if not braking compatibility is introduced by library. Please let me
know if I help somehow.
Upgrade to Checkstyle 6.8.x+
Key: MCHECKSTYLE-300
URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-300
Project: Maven Checkstyle Plugin
Issue Type: Improvement
Reporter: Juan Martín Sotuyo Dodero
We should upgrade to the latest and greatest checkstyle version. Notice since
6.8 there was a big breaking change:
Rename CheckStyleTask to CheckstyleAntTask, Rename and move
checkstyletask.properties. Author: Michal Kordas
[#1108|https://github.com/checkstyle/checkstyle/issues/1108]
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MCHECKSTYLE-300) Upgrade to Checkstyle 6.8.x+
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14612221#comment-14612221 ] Roman Ivanov edited comment on MCHECKSTYLE-300 at 7/2/15 5:11 PM: -- [~simpligility] , what is schedule for plugin release ? is it only lack of patches stop you release new version of plugin ? Checkstyle team use maven plugin in testing a lot in internal test/development, we could occasionally provide patches for version upgrades and help with compatibility problems, but if there is no information when that change go to release - there is no incentive. was (Author: romani): [~simpligility] , what is schedule for plugin release ? is it only lack of patches stop you release new version of plugin ? Checkstyle use maven plugin in testing a lot, we could occasionally provide patches for version upgrades and help with compatibility problems, but if there is no information when that change go to release - there is no incentive. Upgrade to Checkstyle 6.8.x+ Key: MCHECKSTYLE-300 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-300 Project: Maven Checkstyle Plugin Issue Type: Improvement Reporter: Juan Martín Sotuyo Dodero We should upgrade to the latest and greatest checkstyle version. Notice since 6.8 there was a big breaking change: Rename CheckStyleTask to CheckstyleAntTask, Rename and move checkstyletask.properties. Author: Michal Kordas [#1108|https://github.com/checkstyle/checkstyle/issues/1108] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-300) Upgrade to Checkstyle 6.8.x+
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14612221#comment-14612221 ] Roman Ivanov commented on MCHECKSTYLE-300: -- [~simpligility] , what is schedule for plugin release ? is it only lack of patches stop you release new version of plugin ? Checkstyle use maven plugin in testing a lot, we could occasionally provide patches for version upgrades and help with compatibility problems, but if there is no information when that change go to release - there is no incentive. Upgrade to Checkstyle 6.8.x+ Key: MCHECKSTYLE-300 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-300 Project: Maven Checkstyle Plugin Issue Type: Improvement Reporter: Juan Martín Sotuyo Dodero We should upgrade to the latest and greatest checkstyle version. Notice since 6.8 there was a big breaking change: Rename CheckStyleTask to CheckstyleAntTask, Rename and move checkstyletask.properties. Author: Michal Kordas [#1108|https://github.com/checkstyle/checkstyle/issues/1108] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-300) Upgrade to Checkstyle 6.8.x+
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14610967#comment-14610967 ] Roman Ivanov commented on MCHECKSTYLE-300: -- I do not understand problem, should not be any problem to plugin, please extend description. I wish plugin would release in the same frequency as checkstyle do - ones a month. That would simplify our cooperation a lot. Checkstyle team have a lot of stuff to deprecate and remove from API, maven plugin is stopping us to to do that quickly. Upgrade to Checkstyle 6.8.x+ Key: MCHECKSTYLE-300 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-300 Project: Maven Checkstyle Plugin Issue Type: Improvement Reporter: Juan Martín Sotuyo Dodero We should upgrade to the latest and greatest checkstyle version. Notice since 6.8 there was a big breaking change: Rename CheckStyleTask to CheckstyleAntTask, Rename and move checkstyletask.properties. Author: Michal Kordas [#1108|https://github.com/checkstyle/checkstyle/issues/1108] -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Commented] (MECLIPSE-735) Ignore warnings for generated source directories
[
https://issues.apache.org/jira/browse/MECLIPSE-735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14602124#comment-14602124
]
Roman Ivanov commented on MECLIPSE-735:
---
one more request for necessity and could be used as test project:
https://github.com/checkstyle/checkstyle/pull/1219#issuecomment-115119836
Ignore warnings for generated source directories
Key: MECLIPSE-735
URL: https://issues.apache.org/jira/browse/MECLIPSE-735
Project: Maven Eclipse Plugin
Issue Type: New Feature
Components: Core : Dependencies resolution and build path
(.classpath)
Reporter: Jeremy Gustie
Eclipse has added the ability to ignore warnings for specific source
directories (see [Bug
220928|https://bugs.eclipse.org/bugs/show_bug.cgi?id=220928]), it would be
nice if source folders located under the build directory automatically got an
{{ignore_optional_problems}} attribute set to {{true}} so generated code does
not produce warnings:
{code}
classpathentry including=**/*.java kind=src
path=target/generated-sources
attributes
attribute name=ignore_optional_problems value=true/
/attributes
/classpathentry
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MSITE-748) EmptyStackException on Content segment usage
Roman Ivanov created MSITE-748:
--
Summary: EmptyStackException on Content segment usage
Key: MSITE-748
URL: https://issues.apache.org/jira/browse/MSITE-748
Project: Maven Site Plugin
Issue Type: Bug
Affects Versions: 3.4
Environment: Ubuntu 12.04 64bit
Reporter: Roman Ivanov
repository https://github.com/checkstyle/checkstyle
update, to add Content section like this:
{code}
body
section name=Content
macro name=toc
param name=fromDepth value=1/
param name=toDepth value=1/
/macro
/section
section name=Overview
{code}
build a site by command:
{code}
mvn -X clean site -Dlinkcheck.skip=true -Dmaven.javadoc.skip=true -DskipTests
-DskipITs -Dpmd.skip=true -Dfindbugs.skip=true -Dcobertura.skip=true
-Dcheckstyle.ant.skip=true
{code}
Exception:
{code}
[DEBUG] Generating
/home/rivanov/java/git-others/checkstyle/checkstyle/target/site/config.html
[DEBUG] Validating:
/home/rivanov/java/git-others/checkstyle/checkstyle/src/xdocs/config.xml
[DEBUG] Validating the content...
[WARNING] title was already defined in properties, ignored title in
head.
[DEBUG] Unrecognized xdoc tag: link at [17:70]
[DEBUG] Unrecognized xdoc tag: link at [18:76]
[warn] title was already defined in properties, ignored title in head.
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 27.049s
[INFO] Finished at: Wed Jun 24 21:34:25 PDT 2015
[INFO] Final Memory: 59M/472M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
checkstyle: Execution default-site of goal
org.apache.maven.plugins:maven-site-plugin:3.4:site failed. EmptyStackException
- [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
checkstyle: Execution default-site of goal
org.apache.maven.plugins:maven-site-plugin:3.4:site failed.
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:225)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
default-site of goal org.apache.maven.plugins:maven-site-plugin:3.4:site failed.
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 19 more
Caused by: java.util.EmptyStackException
at java.util.Stack.peek(Stack.java:102)
at org.apache.maven.doxia.index.IndexingSink.peek(IndexingSink.java:292)
at org.apache.maven.doxia.index.IndexingSink.text(IndexingSink.java:239)
at
org.apache.maven.doxia.module.xdoc.XdocParser.handleSectionStart(XdocParser.java:505)
at
org.apache.maven.doxia.module.xdoc.XdocParser.handleStartTag(XdocParser.java:199)
at
org.apache.maven.doxia.parser.AbstractXmlParser.parseXml(AbstractXmlParser.java:235)
at
[jira] [Updated] (MSITE-748) EmptyStackException on Content segment usage
[
https://issues.apache.org/jira/browse/MSITE-748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Roman Ivanov updated MSITE-748:
---
Description:
repository https://github.com/checkstyle/checkstyle
update src/xdocs/config.xml, to add Content section like this:
{code}
body
section name=Content
macro name=toc
param name=fromDepth value=1/
param name=toDepth value=1/
/macro
/section
section name=Overview
{code}
build a site by command:
{code}
mvn -X clean site -Dlinkcheck.skip=true -Dmaven.javadoc.skip=true -DskipTests
-DskipITs -Dpmd.skip=true -Dfindbugs.skip=true -Dcobertura.skip=true
-Dcheckstyle.ant.skip=true
{code}
Exception:
{code}
[DEBUG] Generating
/home/rivanov/java/git-others/checkstyle/checkstyle/target/site/config.html
[DEBUG] Validating:
/home/rivanov/java/git-others/checkstyle/checkstyle/src/xdocs/config.xml
[DEBUG] Validating the content...
[WARNING] title was already defined in properties, ignored title in
head.
[DEBUG] Unrecognized xdoc tag: link at [17:70]
[DEBUG] Unrecognized xdoc tag: link at [18:76]
[warn] title was already defined in properties, ignored title in head.
[INFO]
[INFO] BUILD FAILURE
[INFO]
[INFO] Total time: 27.049s
[INFO] Finished at: Wed Jun 24 21:34:25 PDT 2015
[INFO] Final Memory: 59M/472M
[INFO]
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
checkstyle: Execution default-site of goal
org.apache.maven.plugins:maven-site-plugin:3.4:site failed. EmptyStackException
- [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal
org.apache.maven.plugins:maven-site-plugin:3.4:site (default-site) on project
checkstyle: Execution default-site of goal
org.apache.maven.plugins:maven-site-plugin:3.4:site failed.
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:225)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: org.apache.maven.plugin.PluginExecutionException: Execution
default-site of goal org.apache.maven.plugins:maven-site-plugin:3.4:site failed.
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:110)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
... 19 more
Caused by: java.util.EmptyStackException
at java.util.Stack.peek(Stack.java:102)
at org.apache.maven.doxia.index.IndexingSink.peek(IndexingSink.java:292)
at org.apache.maven.doxia.index.IndexingSink.text(IndexingSink.java:239)
at
org.apache.maven.doxia.module.xdoc.XdocParser.handleSectionStart(XdocParser.java:505)
at
org.apache.maven.doxia.module.xdoc.XdocParser.handleStartTag(XdocParser.java:199)
at
org.apache.maven.doxia.parser.AbstractXmlParser.parseXml(AbstractXmlParser.java:235)
at
org.apache.maven.doxia.parser.AbstractXmlParser.parse(AbstractXmlParser.java:145)
at
org.apache.maven.doxia.parser.XhtmlBaseParser.parse(XhtmlBaseParser.java:96)
at
[jira] [Created] (MCHECKSTYLE-293) usage of Checker.setClassLoader method
Roman Ivanov created MCHECKSTYLE-293: Summary: usage of Checker.setClassLoader method Key: MCHECKSTYLE-293 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-293 Project: Maven Checkstyle Plugin Issue Type: Improvement Affects Versions: 2.15 Reporter: Roman Ivanov Reason: https://github.com/checkstyle/checkstyle/issues/922 Will be released at the end of May as 6.7 version. As Checkstyle project use plugin for testing, we can not remove old method, and keep deprecated method we also do not want to for long time. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] [Created] (MJAVADOC-428) problem with generation link to DefaultHandler
Roman Ivanov created MJAVADOC-428:
-
Summary: problem with generation link to DefaultHandler
Key: MJAVADOC-428
URL: https://issues.apache.org/jira/browse/MJAVADOC-428
Project: Maven Javadoc Plugin
Issue Type: Bug
Affects Versions: 2.10.3
Reporter: Roman Ivanov
problem is described at https://jira.codehaus.org/browse/MJAVADOC-425
update for new doxia works well the only issue left is :
{quote}
One more case:
http://docs.oracle.com/javase/7/docs/api/org/xml/sax
/helpers.DefaultHandler.html?is-external=true: 404 Not Found
This link is broken because DefaultHandler is preceded by dot instead of '/'.
{quote}
Looks like it is not related to doxia version problem, but still a problem.
You can find that error there - http://checkstyle.sourceforge.net/linkcheck.html
to reproduce that problem please comment out line
https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L1100
and run mvn clean site
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] (MCHECKSTYLE-289) enableRulesSummary option does not show Rules with default configuration
Roman Ivanov created MCHECKSTYLE-289: Summary: enableRulesSummary option does not show Rules with default configuration Key: MCHECKSTYLE-289 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-289 Project: Maven Checkstyle Plugin Issue Type: Bug Reporter: Roman Ivanov In Checkstyle development we use maven plugin a lot. Option: http://maven.apache.org/plugins/maven-checkstyle-plugin/checkstyle-mojo.html#enableRulesSummary that option is convenient to estimate on what Rule set it was generated. But it does not show Rule if it configured by default. It that is bug- please fix, if that done on good reason please provide additional option. Example: http://checkstyle.sourceforge.net/reports/google-style/guava/ https://github.com/checkstyle/checkstyle/blob/master/src/main/resources/google_checks.xml#L37 Example where it not clear on what config that report was generated: http://damianszczepanik.github.io/sevntu.checkstyle/sevntu.checkstyle/pull/327/index.html -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-261) Upgrade to Checkstyle 6.1.1
[ https://jira.codehaus.org/browse/MCHECKSTYLE-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=360444#comment-360444 ] Roman Ivanov commented on MCHECKSTYLE-261: -- please use 6.2 version as it fixes some problems with compatibility problem that we caused at 6.0 Upgrade to Checkstyle 6.1.1 --- Key: MCHECKSTYLE-261 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-261 Project: Maven Checkstyle Plugin Issue Type: Improvement Affects Versions: 2.14 Reporter: Dennis Lundberg Fix For: 2.15 Upgrade to the latest 6.x version of Checkstyle, which at the time of writing is 6.1. Note that this upgrade will make the Checkstyle plugin require Java 6, because Checkstyle requires Java 6 since version 6.0. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MSITE-736) checkstyle:checkstyle does not generate css folder
Roman Ivanov created MSITE-736: -- Summary: checkstyle:checkstyle does not generate css folder Key: MSITE-736 URL: https://jira.codehaus.org/browse/MSITE-736 Project: Maven Site Plugin Issue Type: Bug Reporter: Roman Ivanov We plan to seriously use chekstyle maven plugin to generate reports for ease acceptance of new functionality in Checkstyle. We plan to use it like: mvn jxr:jxr mvn checkstyle:checkstyle right now after such command we have html report generated but it is not pretty due to missed css folder. If that is not by design - please append that folder to generated site folder. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MSITE-736) checkstyle:checkstyle does not generate css folder
[ https://jira.codehaus.org/browse/MSITE-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=360446#comment-360446 ] Roman Ivanov commented on MSITE-736: please move that issue to maven checkstyle plugin project checkstyle:checkstyle does not generate css folder -- Key: MSITE-736 URL: https://jira.codehaus.org/browse/MSITE-736 Project: Maven Site Plugin Issue Type: Bug Reporter: Roman Ivanov We plan to seriously use chekstyle maven plugin to generate reports for ease acceptance of new functionality in Checkstyle. We plan to use it like: mvn jxr:jxr mvn checkstyle:checkstyle right now after such command we have html report generated but it is not pretty due to missed css folder. If that is not by design - please append that folder to generated site folder. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-261) Upgrade to Checkstyle 6.1
[ https://jira.codehaus.org/browse/MCHECKSTYLE-261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=358970#comment-358970 ] Roman Ivanov commented on MCHECKSTYLE-261: -- checkstyle 6.1.1 was released 2 weeks ago, please use 6.1.1 Upgrade to Checkstyle 6.1 - Key: MCHECKSTYLE-261 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-261 Project: Maven Checkstyle Plugin Issue Type: Improvement Affects Versions: 2.14 Reporter: Dennis Lundberg Fix For: 2.15 Upgrade to the latest 6.x version of Checkstyle, which at the time of writing is 6.1. Note that this upgrade will make the Checkstyle plugin require Java 6, because Checkstyle requires Java 6 since version 6.0. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MCHECKSTYLE-253) Upgrade to checkstyle 5.9 for Java 8 compatibility
[ https://jira.codehaus.org/browse/MCHECKSTYLE-253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=358969#comment-358969 ] Roman Ivanov commented on MCHECKSTYLE-253: -- attention: Checkstyle 6.2 will be compiled base on java7, so 6.1.1 is latest binaries based on java6. Upgrade to checkstyle 5.9 for Java 8 compatibility -- Key: MCHECKSTYLE-253 URL: https://jira.codehaus.org/browse/MCHECKSTYLE-253 Project: Maven Checkstyle Plugin Issue Type: New Feature Reporter: Zlika Assignee: Mirko Friedenhagen Fix For: 2.14 Checkstyle 5.9 has just been released and adds support for Java 8. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MJAVADOC-423) wrong link generation for org.xml.sax.helpers.DefaultHandler
Roman Ivanov created MJAVADOC-423: - Summary: wrong link generation for org.xml.sax.helpers.DefaultHandler Key: MJAVADOC-423 URL: https://jira.codehaus.org/browse/MJAVADOC-423 Project: Maven Javadoc Plugin Issue Type: Bug Affects Versions: 2.10.1 Reporter: Roman Ivanov Review report: http://checkstyle.sourceforge.net/linkcheck.html javadoc plugin - https://github.com/checkstyle/checkstyle/blob/master/pom.xml#L524 here you can see number of broken links as: http://docs.oracle.com/javase/6/docs/api/org/xml/sax/helpers.DefaultHandler.html?is-external=true: 404 Not Found problem is in helpers.DefaultHandler.html should be helpers/DefaultHandler.html I switched to java7 in latest code of checkstyle (https://github.com/checkstyle/checkstyle) project , but problem is the same. to reproduce problem please do : git clone https://github.com/checkstyle/checkstyle cd checkstyle mvn -Pdistro clean package after that review linkcheck maven report. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MJAR-139) New option to avoid empty jar creation
[ https://jira.codehaus.org/browse/MJAR-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=291849#comment-291849 ] Roman Ivanov commented on MJAR-139: --- works fine, thanks for patch config to use: plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-jar-plugin/artifactId version2.4/version configuration skipIfEmptytrue/skipIfEmpty /configuration executions execution goals goaltest-jar/goal /goals /execution /executions /plugin New option to avoid empty jar creation -- Key: MJAR-139 URL: https://jira.codehaus.org/browse/MJAR-139 Project: Maven 2.x JAR Plugin Issue Type: Improvement Affects Versions: 2.3.1 Reporter: Roman Ivanov Assignee: Kristian Rosenvold Fix For: 2.4 Attachments: MJAR-139.patch Usage of test-jar is beneficial for all project, as all of them have tests. plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-jar-plugin/artifactId version2.3.1/version executions execution goals goaltest-jar/goal /goals /execution /executions /plugin Pom artifacts and some jar artifacts does not have test and will never have them. In logs we have: [WARNING] JAR will be empty - no content was marked for inclusion! and empty and useless artifacts are created, deployed , ... It will be convenient to have an plugin option to define whether skip empty jar creation and warning or generate jar with warning in log. Does it make sense ? By default option will be FALSE, to comply with previous behavior. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MJAR-139) New option to avoid empty jar creation
[ http://jira.codehaus.org/browse/MJAR-139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=240647#action_240647 ] Roman Ivanov commented on MJAR-139: --- Please comment this idea, we would like to provide patch if you will accept and apply it. New option to avoid empty jar creation -- Key: MJAR-139 URL: http://jira.codehaus.org/browse/MJAR-139 Project: Maven 2.x Jar Plugin Issue Type: Improvement Affects Versions: 2.3.1 Reporter: Roman Ivanov Usage of test-jar is beneficial for all project, as all of them have tests. plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-jar-plugin/artifactId version2.3.1/version executions execution goals goaltest-jar/goal /goals /execution /executions /plugin Pom artifacts and some jar artifacts does not have test and will never have them. In logs we have: [WARNING] JAR will be empty - no content was marked for inclusion! and empty and useless artifacts are created, deployed , ... It will be convenient to have an plugin option to define whether skip empty jar creation and warning or generate jar with warning in log. Does it make sense ? By default option will be FALSE, to comply with previous behavior. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MJAR-139) New option to avoid empty jar creation
New option to avoid empty jar creation -- Key: MJAR-139 URL: http://jira.codehaus.org/browse/MJAR-139 Project: Maven 2.x Jar Plugin Issue Type: Improvement Affects Versions: 2.3.1 Reporter: Roman Ivanov Usage of test-jar is beneficial for all project, as all of them have tests. plugin groupIdorg.apache.maven.plugins/groupId artifactIdmaven-jar-plugin/artifactId version2.3.1/version executions execution goals goaltest-jar/goal /goals /execution /executions /plugin Pom artifacts and some jar artifacts does not have test and will never have them. In logs we have: [WARNING] JAR will be empty - no content was marked for inclusion! and empty and useless artifacts are created, deployed , ... It will be convenient to have an plugin option to define whether skip empty jar creation and warning or generate jar with warning in log. Does it make sense ? By default option will be FALSE, to comply with previous behavior. -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
