[jira] [Created] (MDEP-933) Documents new output format - JSON of dependency:tree

2024-05-23 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MDEP-933:


 Summary: Documents new output format - JSON of dependency:tree
 Key: MDEP-933
 URL: https://issues.apache.org/jira/browse/MDEP-933
 Project: Maven Dependency Plugin
  Issue Type: Improvement
  Components: tree
Reporter: Slawomir Jaranowski
 Fix For: 3.7.0


We add new output format for dependency:tree but we are lack of documentation

We should add to Mojo description:

[https://maven.apache.org/plugins/maven-dependency-plugin/tree-mojo.html]

and to parameter 
[https://maven.apache.org/plugins/maven-dependency-plugin/tree-mojo.html#outputType]

I would to see an example page with format description.

In other case it will be complicated to use new feature.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results

2024-05-23 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17849012#comment-17849012
 ] 

Slawomir Jaranowski commented on MDEP-799:
--

[~elharo]  - thanks for take care about it. 

I assign you to issue.

Thera are a two more PR with the same ... please comments and close those

> improve mvn dependency:tree - add optional JSON output of the results
> -
>
> Key: MDEP-799
> URL: https://issues.apache.org/jira/browse/MDEP-799
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: tree
>Reporter: Zhenxu Ke
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: 3.7.0
>
>
> I'd like to add an output type JSON, will open a pull request soon



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MDEP-799) improve mvn dependency:tree - add optional JSON output of the results

2024-05-23 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MDEP-799:


Assignee: Elliotte Rusty Harold

> improve mvn dependency:tree - add optional JSON output of the results
> -
>
> Key: MDEP-799
> URL: https://issues.apache.org/jira/browse/MDEP-799
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: tree
>Reporter: Zhenxu Ke
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: 3.7.0
>
>
> I'd like to add an output type JSON, will open a pull request soon



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Reopened] (MDEP-929) Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.1

2024-05-22 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reopened MDEP-929:
--

> Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.1
> 
>
> Key: MDEP-929
> URL: https://issues.apache.org/jira/browse/MDEP-929
> Project: Maven Dependency Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEP-929) Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.1

2024-05-22 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MDEP-929:
-
Summary: Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 
to 1.14.1  (was: Bump org.apache.maven.shared:maven-dependency-analyzer from 
1.13.2 to 1.14.0)

> Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.1
> 
>
> Key: MDEP-929
> URL: https://issues.apache.org/jira/browse/MDEP-929
> Project: Maven Dependency Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MINVOKER-348) Build job report is truncated

2024-05-22 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-348.

Resolution: Fixed

> Build job report is truncated
> -
>
> Key: MINVOKER-348
> URL: https://issues.apache.org/jira/browse/MINVOKER-348
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Alvaro Sanchez-Mariscal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: BUILD-test-resources.xml, build.log
>
>
> The build-job.xml generated for a project is truncated:
> {code:xml}
> 
>  result="failure-post-hook" time="42.662" 
> buildlog="/Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/target/it/test-resources/build.log">
>   Assertion failed: 
> assert log.text.contains("BUILD SUCCESS")
>|   ||
>|   |false
>|   '[INFO] Error stacktraces are turned on.\n[INFO] Scanning for 
> projects...\n[WARNING] This build will only read from the build cache, since 
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO] 
> -
> {code}
> Examining the build output, it gets truncated after a {{<}} appears, which is 
> replaced in the XML with {{}};, but then nothing else. Snippet following
> {noformat}
> [INFO] Error stacktraces are turned on.\n[INFO] Scanning for 
> projects...\n[WARNING] This build will only read from the build cache, since 
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO] 
> -< io.micronaut.build.examples:test-resources 
> >-\n[INFO]
> {noformat}
> Then, the verify mojo crashes when reading such file:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-invoker-plugin:3.5.1:verify (integration-test) 
> on project micronaut-maven-integration-tests: Failed to read report file: 
> /Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/micronaut-maven-integration-tests/target/invoker-reports/BUILD-test-resources.xml:
>  no more data available - expected end tags  to 
> close start tag  from line 3 and start tag  from 
> line 2, parser stopped on START_TAG seen ...t part of the build 
> invocation.\n[INFO] \n[INFO] -... @8:242 -> [Help 1]
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report

2024-05-22 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-351.

Resolution: Fixed

> Prevent XML-prohibited characters from entering JUnit report
> 
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}} 
> nor the underlying XML infrastructure directly protect against the presence 
> of character literals prohibited by the XML specification, meaning such 
> literals can appear in the JUnit report and render it unreadable. *I would 
> appreciate if the Maven Invoker plugin could learn to strip prohibited 
> literals to protect its users from creative plugins.* I argue that this is a 
> safe and expected transformation that is not materially lossy.
> 
> h2. Background
> MINVOKER-196 added the {{}} option [back in 
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
>  As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit 
> report remains effectively 
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example 
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven 
> Invoker populates with the raw build log contents. I've observed that this 
> value is XML-escaped, which I imagine is well understood in the 
> implementation, although I can't immediately find documentation to support 
> that.
> However, escaping notwithstanding, a number of character literals are 
> outright prohibited by the XML specifications. These literals cannot be 
> escaped, and their presence renders an XML document not well formed. The 
> exact set of prohibited characters varies by XML version; the report produced 
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin 
> reads in the build log it does not strip these character literals and neither 
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a 
> build log ends up including a prohibited character the resulting JUnit report 
> will not be well formed.
> The set of prohibited characters is the complement of [the XML 
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When 
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a 
> spinner to standard out, and the implementation uses backspace to render the 
> spinner in place. I have used the Maven Invoker plugin with 
> {{}} to verify a pitest configuration, whereby I discovered 
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and 
> even if pitest could be changed that offers no protection against any other 
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via 
> {{}}. This is technically fairly easy to do, and makes 
> the transformation very explicit, but it requires considerable local work to 
> address an issue many would find obscure and the transformation is 
> permanently lossy unless the user also backs up the raw log to another file 
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals 
> in-between reading the build log and writing to the {{}} value 
> then {{}} will Just Work™, which I assert is what a user 
> will typically expect. Although the {{}} value will no longer 
> exactly match the build log contents, this lossy translation is acceptable: 
> the prohibited characters are overwhelmingly unprintable to begin with and 
> therefore cannot be meaningfully rendered in a static context, and the raw 
> build log remains unchanged in the event that the user needs to investigate 
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that 
> would be affected by it would already have unparseable JUnit reports.
> * I _believe_ that Java's {{j.u.r.Pattern}} can trivially express the 
> complement of allowed characters but there may exist more efficient solutions.
> * Consider also applying this 

[jira] [Closed] (MDEP-928) Allow to exclude classes from dependency:analyze

2024-05-22 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MDEP-928.

Resolution: Fixed

> Allow to exclude classes from dependency:analyze
> 
>
> Key: MDEP-928
> URL: https://issues.apache.org/jira/browse/MDEP-928
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: analyze, analyze-only, analyze-report
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Some of classes can be broken - so possibility to exclude can be helpful.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1401) Refresh checkstyle rules

2024-05-22 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1401:


 Summary: Refresh checkstyle rules
 Key: MSHARED-1401
 URL: https://issues.apache.org/jira/browse/MSHARED-1401
 Project: Maven Shared Components
  Issue Type: Task
  Components: maven-shared-resources
Reporter: Slawomir Jaranowski


eg - we should add {{AvoidStarImport}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1170) Upgrade Parent to 42

2024-05-21 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1170.

  Assignee: Slawomir Jaranowski
Resolution: Fixed

> Upgrade Parent to 42
> 
>
> Key: MSHARED-1170
> URL: https://issues.apache.org/jira/browse/MSHARED-1170
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-shared-resources
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
>  Labels: up-for-grabs
> Fix For: maven-shared-resources-6
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1170) Upgrade Parent to 42

2024-05-21 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1170?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1170:
-
Summary: Upgrade Parent to 42  (was: Upgrade Parent to 41)

> Upgrade Parent to 42
> 
>
> Key: MSHARED-1170
> URL: https://issues.apache.org/jira/browse/MSHARED-1170
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-shared-resources
>Reporter: Slawomir Jaranowski
>Priority: Major
>  Labels: up-for-grabs
> Fix For: maven-shared-resources-6
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEP-898) Upgrade to JDK11+ build requirement

2024-05-21 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-898?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MDEP-898:
-
Fix Version/s: (was: 3.7.0)

> Upgrade to JDK11+ build requirement
> ---
>
> Key: MDEP-898
> URL: https://issues.apache.org/jira/browse/MDEP-898
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>Affects Versions: 3.6.1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
>
> * Upgrade build requirement to JDK11+ so we can use 
> {{8}} and get rid of 
> WARNINGs like {{Warning:  bootstrap class path not set in conjunction with 
> -source 8}}
> * The reason for the WARNING is that we don't correctly set the bootstrap 
> classpath which can be easily handled by using {{--release}} option by JDK9+ 
> and the real point is that we don't use animalsniffer anymore. That was our 
> safety net which is not there anymore. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MDEP-898) Upgrade to JDK11+ build requirement

2024-05-21 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848372#comment-17848372
 ] 

Slawomir Jaranowski commented on MDEP-898:
--

remove from next release

> Upgrade to JDK11+ build requirement
> ---
>
> Key: MDEP-898
> URL: https://issues.apache.org/jira/browse/MDEP-898
> Project: Maven Dependency Plugin
>  Issue Type: Improvement
>Affects Versions: 3.6.1
>Reporter: Karl Heinz Marbaise
>Assignee: Karl Heinz Marbaise
>Priority: Minor
> Fix For: 3.7.0
>
>
> * Upgrade build requirement to JDK11+ so we can use 
> {{8}} and get rid of 
> WARNINGs like {{Warning:  bootstrap class path not set in conjunction with 
> -source 8}}
> * The reason for the WARNING is that we don't correctly set the bootstrap 
> classpath which can be easily handled by using {{--release}} option by JDK9+ 
> and the real point is that we don't use animalsniffer anymore. That was our 
> safety net which is not there anymore. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MDEP-929) Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.0

2024-05-21 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-929?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MDEP-929.

Resolution: Fixed

> Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.0
> 
>
> Key: MDEP-929
> URL: https://issues.apache.org/jira/browse/MDEP-929
> Project: Maven Dependency Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MDEP-929) Bump org.apache.maven.shared:maven-dependency-analyzer from 1.13.2 to 1.14.0

2024-05-21 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MDEP-929:


 Summary: Bump org.apache.maven.shared:maven-dependency-analyzer 
from 1.13.2 to 1.14.0
 Key: MDEP-929
 URL: https://issues.apache.org/jira/browse/MDEP-929
 Project: Maven Dependency Plugin
  Issue Type: Dependency upgrade
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: 3.7.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEP-928) Allow to exclude classes from dependency:analyze

2024-05-21 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-928?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MDEP-928:
-
Component/s: analyze
 analyze-only
 analyze-report

> Allow to exclude classes from dependency:analyze
> 
>
> Key: MDEP-928
> URL: https://issues.apache.org/jira/browse/MDEP-928
> Project: Maven Dependency Plugin
>  Issue Type: New Feature
>  Components: analyze, analyze-only, analyze-report
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Some of classes can be broken - so possibility to exclude can be helpful.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MDEP-928) Allow to exclude classes from dependency:analyze

2024-05-21 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MDEP-928:


 Summary: Allow to exclude classes from dependency:analyze
 Key: MDEP-928
 URL: https://issues.apache.org/jira/browse/MDEP-928
 Project: Maven Dependency Plugin
  Issue Type: New Feature
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: 3.7.0


Some of classes can be broken - so possibility to exclude can be helpful.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MPLUGIN-524) "org.apache.maven.artifact.repository.metadata.Plugin.getPrefix() is null" with Nexus Staging plugin

2024-05-21 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17848100#comment-17848100
 ] 

Slawomir Jaranowski commented on MPLUGIN-524:
-

unfortunately it is still widely used
[https://github.com/search?q=nexus-staging-maven-plugin+language%3A%22Maven+POM%22=code=Maven+POM]

We should talk with Sonatype about it ... how we cen help to improve ...

Also Sonatype prepare next plugin for new Central portal
[https://central.sonatype.org/publish/publish-portal-maven/] 

I afraid it is similar to old one

https://lists.apache.org/thread/bf3762lvd8l64hwyny7rnp3m6r852b9h

> "org.apache.maven.artifact.repository.metadata.Plugin.getPrefix() is null" 
> with Nexus Staging plugin
> 
>
> Key: MPLUGIN-524
> URL: https://issues.apache.org/jira/browse/MPLUGIN-524
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: Metadata Model
>Affects Versions: 3.13.0
>Reporter: Tristan Tarrant
>Priority: Major
>
> While attempting to release a plugin with nexus-staging-maven-plugin, I get 
> the following exception:
> {noformat}
> [ERROR] Failed to execute goal 
> org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13:deploy 
> (injected-nexus-deploy) on project proto-schema-compatibility-maven-plugin: 
> Failed to update metadata org.infinispan.maven-plugins/maven-metadata.xml: 
> Cannot invoke "String.equals(Object)" because the return value of 
> "org.apache.maven.artifact.repository.metadata.Plugin.getPrefix()" is null -> 
> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13:deploy 
> (injected-nexus-deploy) on project proto-schema-compatibility-maven-plugin: 
> Failed to update metadata org.infinispan.maven-plugins/maven-metadata.xml: 
> Cannot invoke "String.equals(Object)" because the return value of 
> "org.apache.maven.artifact.repository.metadata.Plugin.getP refix()" is null
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run 
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute 
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:159)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:105)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.DirectMethodHandleAccessor.invoke 
> (DirectMethodHandleAccessor.java:103)
> at java.lang.reflect.Method.invoke (Method.java:580)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:348)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to update 
> metadata org.infinispan.maven-plugins/maven-metadata.xml: Cannot invoke 
> "String.equals(Object)" because the return value of 
> "org.apache.maven.artifact.repository.metadata.Plugin.getPrefix()" is null
> at org.sonatype.nexus.maven.staging.deploy.DeployMojo.execute 
> (DeployMojo.java:216)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:126)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 
> (MojoExecutor.java:328)
> at 

[jira] [Closed] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes

2024-05-19 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1398.

Resolution: Fixed

> StringIndexOutOfBoundsException processing record classes
> -
>
> Key: MSHARED-1398
> URL: https://issues.apache.org/jira/browse/MSHARED-1398
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.14.0
>Reporter: Jared Stehler
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-analyzer-next-release
>
>
> Processing classes with records results in an index out of bounds exception:
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds 
> for length 41
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302)
>   at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832)
>   at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46)
>   at java.base@21.0.3/java.lang.String.charAt(String.java:1555)
>   at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378)
>   at app//org.objectweb.asm.Type.getReturnType(Type.java:355)
>   at 
> app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112)
>  {code}
> I have a reproducible test case here: 
> https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MJAVADOC-793) java.lang.NullPointerException: Cannot invoke "String.length()" because "text" is null

2024-05-19 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MJAVADOC-793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847694#comment-17847694
 ] 

Slawomir Jaranowski commented on MJAVADOC-793:
--

[~ggregory] when we will have a fix I can release next version

> java.lang.NullPointerException: Cannot invoke "String.length()" because 
> "text" is null
> --
>
> Key: MJAVADOC-793
> URL: https://issues.apache.org/jira/browse/MJAVADOC-793
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Gary D. Gregory
>Priority: Blocker
> Fix For: 3.6.4
>
>
> Plugin throws {{NullPointerException}} when running {{{}javadoc:javadoc{}}}.
> See:
>  * Failing PR: https://github.com/apache/commons-compress/pull/528
>  * Build log: 
> [https://github.com/apache/commons-compress/actions/runs/9113449616/job/25054982405?pr=528]
> Or:
>  # git clone [https://gitbox.apache.org/repos/asf/commons-compress.git]
>  # git checkout 542cc5a602a9128932e3fb75503383e481141e7e
>  # Edit pom.xml and set the parent POM to version 70
>  # Run 'mvn javadoc:javadoc' causes:
> {noformat}
> [INFO] --- javadoc:3.6.3:javadoc (default-cli) @ commons-compress ---
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  8.434 s
> [INFO] Finished at: 2024-05-16T09:36:02-04:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc (default-cli) on 
> project commons-compress: Execution default-cli of goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot 
> invoke "String.length()" because "text" is null -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc 
> (default-cli) on project commons-compress: Execution default-cli of goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot 
> invoke "String.length()" because "text" is null
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run 
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute 
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:159)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:105)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:348)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-cli of goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot 
> invoke "String.length()" 

[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes

2024-05-18 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847506#comment-17847506
 ] 

Slawomir Jaranowski commented on MSHARED-1398:
--

[~jstehler] - fixed you can check my last commit to PR

> StringIndexOutOfBoundsException processing record classes
> -
>
> Key: MSHARED-1398
> URL: https://issues.apache.org/jira/browse/MSHARED-1398
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.14.0
>Reporter: Jared Stehler
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-analyzer-next-release
>
>
> Processing classes with records results in an index out of bounds exception:
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds 
> for length 41
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302)
>   at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832)
>   at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46)
>   at java.base@21.0.3/java.lang.String.charAt(String.java:1555)
>   at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378)
>   at app//org.objectweb.asm.Type.getReturnType(Type.java:355)
>   at 
> app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112)
>  {code}
> I have a reproducible test case here: 
> https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEP-576) maven-dependency-plugin ignores class of object passed as a parameter to method references

2024-05-18 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MDEP-576:
-
Fix Version/s: 3.7.0
   (was: waiting-for-feedback)

> maven-dependency-plugin ignores class of object passed as a parameter to 
> method references
> --
>
> Key: MDEP-576
> URL: https://issues.apache.org/jira/browse/MDEP-576
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>Affects Versions: 3.0.1
>Reporter: Vladimir Dergachev
>Priority: Minor
> Fix For: 3.7.0
>
>
> Hi there, i created a project on 
> [github|https://github.com/vdergachev/dependency-plugin-vs-java-lambda] that 
> can help you to reproduce the issue. Just clone it and make {code}mvn clean 
> install{code}
> In my case plugin ignored Server class from jetty-server.jar and a as result 
> i got message {code}Unused declared dependencies found{code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes

2024-05-18 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MSHARED-1398:


Assignee: Slawomir Jaranowski

> StringIndexOutOfBoundsException processing record classes
> -
>
> Key: MSHARED-1398
> URL: https://issues.apache.org/jira/browse/MSHARED-1398
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.14.0
>Reporter: Jared Stehler
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-analyzer-next-release
>
>
> Processing classes with records results in an index out of bounds exception:
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds 
> for length 41
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302)
>   at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832)
>   at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46)
>   at java.base@21.0.3/java.lang.String.charAt(String.java:1555)
>   at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378)
>   at app//org.objectweb.asm.Type.getReturnType(Type.java:355)
>   at 
> app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112)
>  {code}
> I have a reproducible test case here: 
> https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report

2024-05-17 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847409#comment-17847409
 ] 

Slawomir Jaranowski commented on MINVOKER-351:
--

Please look at test in my PR, I modified it a little then when was proposed in 
attachment.
 * remove JDK 11 reqirement
 * pin used plugin version site and surefire

> Prevent XML-prohibited characters from entering JUnit report
> 
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}} 
> nor the underlying XML infrastructure directly protect against the presence 
> of character literals prohibited by the XML specification, meaning such 
> literals can appear in the JUnit report and render it unreadable. *I would 
> appreciate if the Maven Invoker plugin could learn to strip prohibited 
> literals to protect its users from creative plugins.* I argue that this is a 
> safe and expected transformation that is not materially lossy.
> 
> h2. Background
> MINVOKER-196 added the {{}} option [back in 
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
>  As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit 
> report remains effectively 
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example 
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven 
> Invoker populates with the raw build log contents. I've observed that this 
> value is XML-escaped, which I imagine is well understood in the 
> implementation, although I can't immediately find documentation to support 
> that.
> However, escaping notwithstanding, a number of character literals are 
> outright prohibited by the XML specifications. These literals cannot be 
> escaped, and their presence renders an XML document not well formed. The 
> exact set of prohibited characters varies by XML version; the report produced 
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin 
> reads in the build log it does not strip these character literals and neither 
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a 
> build log ends up including a prohibited character the resulting JUnit report 
> will not be well formed.
> The set of prohibited characters is the complement of [the XML 
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When 
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a 
> spinner to standard out, and the implementation uses backspace to render the 
> spinner in place. I have used the Maven Invoker plugin with 
> {{}} to verify a pitest configuration, whereby I discovered 
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and 
> even if pitest could be changed that offers no protection against any other 
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via 
> {{}}. This is technically fairly easy to do, and makes 
> the transformation very explicit, but it requires considerable local work to 
> address an issue many would find obscure and the transformation is 
> permanently lossy unless the user also backs up the raw log to another file 
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals 
> in-between reading the build log and writing to the {{}} value 
> then {{}} will Just Work™, which I assert is what a user 
> will typically expect. Although the {{}} value will no longer 
> exactly match the build log contents, this lossy translation is acceptable: 
> the prohibited characters are overwhelmingly unprintable to begin with and 
> therefore cannot be meaningfully rendered in a static context, and the raw 
> build log remains unchanged in the event that the user needs to investigate 
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that 
> would be affected by it would already have unparseable JUnit reports.
> * I 

[jira] [Commented] (MPLUGIN-384) Nexus Staging Plugin - incompatibility

2024-05-17 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MPLUGIN-384?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847406#comment-17847406
 ] 

Slawomir Jaranowski commented on MPLUGIN-384:
-

[~tristan.tarr...@gmail.com] please open a new issue 

> Nexus Staging Plugin - incompatibility
> --
>
> Key: MPLUGIN-384
> URL: https://issues.apache.org/jira/browse/MPLUGIN-384
> Project: Maven Plugin Tools
>  Issue Type: Bug
>  Components: Plugin Plugin
>Affects Versions: 3.6.2
> Environment: Windows 10 64-bit, Java 8 and 17, maven 3.8.1
>Reporter: Bob Marinier
>Assignee: Herve Boutemy
>Priority: Major
> Fix For: 3.6.4
>
>
> Version 3.6.1 of maven-plugin-plugin worked fine, but since updating to 
> version 3.6.2, I get an NPE (tested with Java 8 and Java 17). I believe the 
> error in both Java 8 and Java 17 is the same, but Java 17 gives a better 
> message (see below).
> Even though it's the nexus-staging-maven-plugin that is complaining, the 
> message implies that the maven-plugin-plugin is somehow failing to extract 
> the prefix from the plugin. Going back to maven-plugin-plugin version 3.6.1 
> fixes the issue.
> {noformat}
> [ERROR] Failed to execute goal 
> org.sonatype.plugins:nexus-staging-maven-plugin:1.6.8:deploy 
> (injected-nexus-deploy) on project my-maven-plugin: Failed to update metadata 
> my.group.id/maven-metadata.xml: Cannot invoke "String.equals(Object)" because 
> the return value of 
> "org.apache.maven.artifact.repository.metadata.Plugin.getPrefix()" is null -> 
> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.sonatype.plugins:nexus-staging-maven-plugin:1.6.8:deploy 
> (injected-nexus-deploy) on project my-maven-plugin: Failed to update metadata 
> my.group.id/maven-metadata.xml: Cannot invoke "String.equals(Object)" because 
> the return value of 
> "org.apache.maven.artifact.repository.metadata.Plugin.getPrefix()" is null
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:215)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:81)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:56)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:128)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:305)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:192)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:105)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:972)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:293)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:196)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:347)
> Caused by: org.apache.maven.plugin.MojoExecutionException: Failed to update 
> metadata my.group.id/maven-metadata.xml: Cannot invoke 
> "String.equals(Object)" because the return value of 
> "org.apache.maven.artifact.repository.metadata.Plugin.getPrefix()" is null
> at org.sonatype.nexus.maven.staging.deploy.DeployMojo.execute 
> (DeployMojo.java:216)
> at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:137)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:210)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:156)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:148)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:117)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> 

[jira] [Updated] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes

2024-05-17 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1398:
-
Fix Version/s: maven-dependency-analyzer-next-release

> StringIndexOutOfBoundsException processing record classes
> -
>
> Key: MSHARED-1398
> URL: https://issues.apache.org/jira/browse/MSHARED-1398
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.14.0
>Reporter: Jared Stehler
>Priority: Major
> Fix For: maven-dependency-analyzer-next-release
>
>
> Processing classes with records results in an index out of bounds exception:
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds 
> for length 41
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302)
>   at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832)
>   at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46)
>   at java.base@21.0.3/java.lang.String.charAt(String.java:1555)
>   at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378)
>   at app//org.objectweb.asm.Type.getReturnType(Type.java:355)
>   at 
> app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112)
>  {code}
> I have a reproducible test case here: 
> https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes

2024-05-17 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847396#comment-17847396
 ] 

Slawomir Jaranowski commented on MSHARED-1398:
--

[~jstehler] please create a PR with your test

> StringIndexOutOfBoundsException processing record classes
> -
>
> Key: MSHARED-1398
> URL: https://issues.apache.org/jira/browse/MSHARED-1398
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.14.0
>Reporter: Jared Stehler
>Priority: Major
>
> Processing classes with records results in an index out of bounds exception:
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds 
> for length 41
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302)
>   at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832)
>   at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46)
>   at java.base@21.0.3/java.lang.String.charAt(String.java:1555)
>   at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378)
>   at app//org.objectweb.asm.Type.getReturnType(Type.java:355)
>   at 
> app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112)
>  {code}
> I have a reproducible test case here: 
> https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSHARED-1398) StringIndexOutOfBoundsException processing record classes

2024-05-17 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MSHARED-1398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847394#comment-17847394
 ] 

Slawomir Jaranowski commented on MSHARED-1398:
--

Thanks for reporting  I was dropped a simply catch such exception in 
[https://github.com/apache/maven-dependency-analyzer/pull/118]

But you can skip problematic classes from analizes

I will check where is the root of cause - maybe we should report in to ASM.

> StringIndexOutOfBoundsException processing record classes
> -
>
> Key: MSHARED-1398
> URL: https://issues.apache.org/jira/browse/MSHARED-1398
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.14.0
>Reporter: Jared Stehler
>Priority: Major
>
> Processing classes with records results in an index out of bounds exception:
> {code:java}
> Caused by: java.lang.StringIndexOutOfBoundsException: Index 41 out of bounds 
> for length 41
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:55)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$1.apply(Preconditions.java:52)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:213)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions$4.apply(Preconditions.java:210)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:98)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:106)
>   at 
> java.base@21.0.3/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:302)
>   at java.base@21.0.3/java.lang.String.checkIndex(String.java:4832)
>   at java.base@21.0.3/java.lang.StringLatin1.charAt(StringLatin1.java:46)
>   at java.base@21.0.3/java.lang.String.charAt(String.java:1555)
>   at app//org.objectweb.asm.Type.getReturnTypeOffset(Type.java:378)
>   at app//org.objectweb.asm.Type.getReturnType(Type.java:355)
>   at 
> app//org.apache.maven.shared.dependency.analyzer.asm.ResultCollector.addMethodDesc(ResultCollector.java:112)
>  {code}
> I have a reproducible test case here: 
> https://github.com/jaredstehler/maven-dependency-analyzer/tree/js-repro-record-error



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEP-919) Fix / investigate failed ITs with Maven4

2024-05-17 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MDEP-919:
-
Description: 
We still have failed:
{noformat}
[ERROR] The following builds failed:
[ERROR] *  list-repositories/pom.xml
{noformat}

  was:
We still have failed:
{noformat}
[ERROR] The following builds failed:
[ERROR] *  tree-multimodule/pom.xml
[ERROR] *  tree-verbose/pom.xml
[ERROR] *  list-repositories/pom.xml
[ERROR] *  tree-verbose-multimodule/pom.xml{noformat}


> Fix / investigate failed ITs with Maven4
> 
>
> Key: MDEP-919
> URL: https://issues.apache.org/jira/browse/MDEP-919
> Project: Maven Dependency Plugin
>  Issue Type: Task
>Reporter: Slawomir Jaranowski
>Priority: Major
>
> We still have failed:
> {noformat}
> [ERROR] The following builds failed:
> [ERROR] *  list-repositories/pom.xml
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MINVOKER-348) Build job report is truncated

2024-05-16 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MINVOKER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847090#comment-17847090
 ] 

Slawomir Jaranowski commented on MINVOKER-348:
--

In [https://github.com/apache/maven-invoker-plugin/pull/242]
I added {{{}StringEscapeUtils.escapeXml10{}}}:
{code:java}

buildJob.setFailureMessage(StringEscapeUtils.escapeXml10(e.getMessage()));
{code}
I hope this help

> Build job report is truncated
> -
>
> Key: MINVOKER-348
> URL: https://issues.apache.org/jira/browse/MINVOKER-348
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Alvaro Sanchez-Mariscal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: BUILD-test-resources.xml, build.log
>
>
> The build-job.xml generated for a project is truncated:
> {code:xml}
> 
>  result="failure-post-hook" time="42.662" 
> buildlog="/Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/target/it/test-resources/build.log">
>   Assertion failed: 
> assert log.text.contains("BUILD SUCCESS")
>|   ||
>|   |false
>|   '[INFO] Error stacktraces are turned on.\n[INFO] Scanning for 
> projects...\n[WARNING] This build will only read from the build cache, since 
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO] 
> -
> {code}
> Examining the build output, it gets truncated after a {{<}} appears, which is 
> replaced in the XML with {{}};, but then nothing else. Snippet following
> {noformat}
> [INFO] Error stacktraces are turned on.\n[INFO] Scanning for 
> projects...\n[WARNING] This build will only read from the build cache, since 
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO] 
> -< io.micronaut.build.examples:test-resources 
> >-\n[INFO]
> {noformat}
> Then, the verify mojo crashes when reading such file:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-invoker-plugin:3.5.1:verify (integration-test) 
> on project micronaut-maven-integration-tests: Failed to read report file: 
> /Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/micronaut-maven-integration-tests/target/invoker-reports/BUILD-test-resources.xml:
>  no more data available - expected end tags  to 
> close start tag  from line 3 and start tag  from 
> line 2, parser stopped on START_TAG seen ...t part of the build 
> invocation.\n[INFO] \n[INFO] -... @8:242 -> [Help 1]
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MINVOKER-348) Build job report is truncated

2024-05-16 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MINVOKER-348:


Assignee: Slawomir Jaranowski

> Build job report is truncated
> -
>
> Key: MINVOKER-348
> URL: https://issues.apache.org/jira/browse/MINVOKER-348
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Alvaro Sanchez-Mariscal
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: BUILD-test-resources.xml, build.log
>
>
> The build-job.xml generated for a project is truncated:
> {code:xml}
> 
>  result="failure-post-hook" time="42.662" 
> buildlog="/Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/target/it/test-resources/build.log">
>   Assertion failed: 
> assert log.text.contains("BUILD SUCCESS")
>|   ||
>|   |false
>|   '[INFO] Error stacktraces are turned on.\n[INFO] Scanning for 
> projects...\n[WARNING] This build will only read from the build cache, since 
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO] 
> -
> {code}
> Examining the build output, it gets truncated after a {{<}} appears, which is 
> replaced in the XML with {{}};, but then nothing else. Snippet following
> {noformat}
> [INFO] Error stacktraces are turned on.\n[INFO] Scanning for 
> projects...\n[WARNING] This build will only read from the build cache, since 
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO] 
> -< io.micronaut.build.examples:test-resources 
> >-\n[INFO]
> {noformat}
> Then, the verify mojo crashes when reading such file:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-invoker-plugin:3.5.1:verify (integration-test) 
> on project micronaut-maven-integration-tests: Failed to read report file: 
> /Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/micronaut-maven-integration-tests/target/invoker-reports/BUILD-test-resources.xml:
>  no more data available - expected end tags  to 
> close start tag  from line 3 and start tag  from 
> line 2, parser stopped on START_TAG seen ...t part of the build 
> invocation.\n[INFO] \n[INFO] -... @8:242 -> [Help 1]
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MINVOKER-348) Build job report is truncated

2024-05-16 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MINVOKER-348:
-
Fix Version/s: 3.7.0
   (was: waiting-for-feedback)

> Build job report is truncated
> -
>
> Key: MINVOKER-348
> URL: https://issues.apache.org/jira/browse/MINVOKER-348
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Alvaro Sanchez-Mariscal
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: BUILD-test-resources.xml, build.log
>
>
> The build-job.xml generated for a project is truncated:
> {code:xml}
> 
>  result="failure-post-hook" time="42.662" 
> buildlog="/Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/target/it/test-resources/build.log">
>   Assertion failed: 
> assert log.text.contains("BUILD SUCCESS")
>|   ||
>|   |false
>|   '[INFO] Error stacktraces are turned on.\n[INFO] Scanning for 
> projects...\n[WARNING] This build will only read from the build cache, since 
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO] 
> -
> {code}
> Examining the build output, it gets truncated after a {{<}} appears, which is 
> replaced in the XML with {{}};, but then nothing else. Snippet following
> {noformat}
> [INFO] Error stacktraces are turned on.\n[INFO] Scanning for 
> projects...\n[WARNING] This build will only read from the build cache, since 
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO] 
> -< io.micronaut.build.examples:test-resources 
> >-\n[INFO]
> {noformat}
> Then, the verify mojo crashes when reading such file:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-invoker-plugin:3.5.1:verify (integration-test) 
> on project micronaut-maven-integration-tests: Failed to read report file: 
> /Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/micronaut-maven-integration-tests/target/invoker-reports/BUILD-test-resources.xml:
>  no more data available - expected end tags  to 
> close start tag  from line 3 and start tag  from 
> line 2, parser stopped on START_TAG seen ...t part of the build 
> invocation.\n[INFO] \n[INFO] -... @8:242 -> [Help 1]
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MINVOKER-307) invoker should also support the @{ } syntax like the surefire plugin

2024-05-16 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-307.

Resolution: Fixed

> invoker should also support the @{ } syntax like the surefire plugin
> 
>
> Key: MINVOKER-307
> URL: https://issues.apache.org/jira/browse/MINVOKER-307
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Assignee: Slawomir Jaranowski
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.7.0
>
>
> The surefire plugin supports a special `@\{ ... }` syntax to do 'late' 
> resolution of maven properties (not at POM evaluation time but at plugin 
> execution time). See 
> [https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine]
>  for details.
>  
> It would be great if the invoker plugin would support the same syntax for the 
>  configuration setting.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report

2024-05-16 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MINVOKER-351:


Assignee: Slawomir Jaranowski

> Prevent XML-prohibited characters from entering JUnit report
> 
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}} 
> nor the underlying XML infrastructure directly protect against the presence 
> of character literals prohibited by the XML specification, meaning such 
> literals can appear in the JUnit report and render it unreadable. *I would 
> appreciate if the Maven Invoker plugin could learn to strip prohibited 
> literals to protect its users from creative plugins.* I argue that this is a 
> safe and expected transformation that is not materially lossy.
> 
> h2. Background
> MINVOKER-196 added the {{}} option [back in 
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
>  As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit 
> report remains effectively 
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example 
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven 
> Invoker populates with the raw build log contents. I've observed that this 
> value is XML-escaped, which I imagine is well understood in the 
> implementation, although I can't immediately find documentation to support 
> that.
> However, escaping notwithstanding, a number of character literals are 
> outright prohibited by the XML specifications. These literals cannot be 
> escaped, and their presence renders an XML document not well formed. The 
> exact set of prohibited characters varies by XML version; the report produced 
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin 
> reads in the build log it does not strip these character literals and neither 
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a 
> build log ends up including a prohibited character the resulting JUnit report 
> will not be well formed.
> The set of prohibited characters is the complement of [the XML 
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When 
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a 
> spinner to standard out, and the implementation uses backspace to render the 
> spinner in place. I have used the Maven Invoker plugin with 
> {{}} to verify a pitest configuration, whereby I discovered 
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and 
> even if pitest could be changed that offers no protection against any other 
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via 
> {{}}. This is technically fairly easy to do, and makes 
> the transformation very explicit, but it requires considerable local work to 
> address an issue many would find obscure and the transformation is 
> permanently lossy unless the user also backs up the raw log to another file 
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals 
> in-between reading the build log and writing to the {{}} value 
> then {{}} will Just Work™, which I assert is what a user 
> will typically expect. Although the {{}} value will no longer 
> exactly match the build log contents, this lossy translation is acceptable: 
> the prohibited characters are overwhelmingly unprintable to begin with and 
> therefore cannot be meaningfully rendered in a static context, and the raw 
> build log remains unchanged in the event that the user needs to investigate 
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that 
> would be affected by it would already have unparseable JUnit reports.
> * I _believe_ that Java's {{j.u.r.Pattern}} can trivially express the 
> complement of allowed characters but there may exist more efficient solutions.
> * Consider 

[jira] [Commented] (MNG-8122) `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output dependency trees from all projects

2024-05-16 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17847051#comment-17847051
 ] 

Slawomir Jaranowski commented on MNG-8122:
--

Can be caused by different in -pl options - 
https://maven.apache.org/guides/mini/guide-multiple-modules-4.html

> `versions:display-dependency-updates -pl .` on Maven 4 alpha-13 will output 
> dependency trees from all projects
> --
>
> Key: MNG-8122
> URL: https://issues.apache.org/jira/browse/MNG-8122
> Project: Maven
>  Issue Type: Bug
>  Components: Command Line, Core
>Affects Versions: 4.0.0-alpha-12, 4.0.0-alpha-13
>Reporter: Benjamin Marwell
>Priority: Major
>
> When running this command:
> {code:bash}
> ./mvnw versions:display-dependency-updates -ntp -Prun-its 
> -DallowMajorUpdates=true 
> -Dmaven.version.ignore='.*-SNAPSHOT,.*-M[0-9],.*[aA]lpha(-)?[0-9],.*-RC[0-9],.*beta(-)?[0-9]*'
>  -pl .
> ─╯
> {code}
> with Maven Wrapper and Maven 4.0.0-alpha-12, it will actually output the 
> dependency trees on all projects.
> When switching back to v3.9.6, this does not happen.
> h2. Expected outcome
> Only display updates from root project
> h2. Actual outcome
> ignores? parameter {{-pl .}}
> h2. Versions
> dependency-plugin v3.6.1



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MJAVADOC-793) java.lang.NullPointerException: Cannot invoke "String.length()" because "text" is null

2024-05-16 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAVADOC-793?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MJAVADOC-793:
-
Fix Version/s: 3.6.4

> java.lang.NullPointerException: Cannot invoke "String.length()" because 
> "text" is null
> --
>
> Key: MJAVADOC-793
> URL: https://issues.apache.org/jira/browse/MJAVADOC-793
> Project: Maven Javadoc Plugin
>  Issue Type: Bug
>Affects Versions: 3.6.3
>Reporter: Gary D. Gregory
>Priority: Blocker
> Fix For: 3.6.4
>
>
> Plugin throws {{NullPointerException}} when running {{{}javadoc:javadoc{}}}.
> See:
>  * Failing PR: https://github.com/apache/commons-compress/pull/528
>  * Build log: 
> [https://github.com/apache/commons-compress/actions/runs/9113449616/job/25054982405?pr=528]
> Or:
>  # git clone [https://gitbox.apache.org/repos/asf/commons-compress.git]
>  # git checkout 542cc5a602a9128932e3fb75503383e481141e7e
>  # Edit pom.xml and set the parent POM to version 70
>  # Run 'mvn javadoc:javadoc' causes:
> {noformat}
> [INFO] --- javadoc:3.6.3:javadoc (default-cli) @ commons-compress ---
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  8.434 s
> [INFO] Finished at: 2024-05-16T09:36:02-04:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc (default-cli) on 
> project commons-compress: Execution default-cli of goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot 
> invoke "String.length()" because "text" is null -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc 
> (default-cli) on project commons-compress: Execution default-cli of goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot 
> invoke "String.length()" because "text" is null
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 
> (MojoExecutor.java:333)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:316)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:212)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:174)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 
> (MojoExecutor.java:75)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run 
> (MojoExecutor.java:162)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute 
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:159)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:105)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:906)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:283)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:206)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:77)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:568)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced 
> (Launcher.java:283)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch 
> (Launcher.java:226)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode 
> (Launcher.java:407)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main 
> (Launcher.java:348)
> Caused by: org.apache.maven.plugin.PluginExecutionException: Execution 
> default-cli of goal 
> org.apache.maven.plugins:maven-javadoc-plugin:3.6.3:javadoc failed: Cannot 
> invoke "String.length()" because "text" is null
> at 

[jira] [Commented] (MNG-8121) NullPointerException at org.apache.maven.artifact.repository.metadata.Metadata.merge (Metadata.java:293)

2024-05-15 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MNG-8121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17846615#comment-17846615
 ] 

Slawomir Jaranowski commented on MNG-8121:
--

Maybe ... 
https://github.com/apache/maven-plugin-tools/pull/280#discussion_r1601571108

> NullPointerException at 
> org.apache.maven.artifact.repository.metadata.Metadata.merge 
> (Metadata.java:293)
> 
>
> Key: MNG-8121
> URL: https://issues.apache.org/jira/browse/MNG-8121
> Project: Maven
>  Issue Type: Bug
>  Components: Artifacts and Repositories
>Affects Versions: 3.9.6
> Environment: Maven 3.9.6
> maven-plugin-plugin 3.13.0
> org.sonatype.plugins:nexus-staging-maven-plugin:1.6.13
>Reporter: Gili
>Priority: Major
>
> TL;DR {{org.apache.maven.artifact.repository.metadata.Metadata.merge 
> (Metadata.java:293)}} throws {{NullPointerException}} if previous releases of 
> a plugin did not have a goalPrefix set.
>  
> At least, this is my interpretation of what is going on.
>  
> Background
> -
>  
> I have an open-source project at 
> [https://github.com/cmake-maven-project/cmake-maven-project/tree/v3.27.1-b1] 
> with the following coordinates:
>  
> com.googlecode.cmake-maven-project
> cmake
>  
> If I upgrade "maven-plugin-plugin" from version 3.10.1 to 3.13.0 I am forced 
> to set "" because of 
> https://issues.apache.org/jira/browse/MPLUGIN-450 and 
> [https://github.com/apache/maven-plugin-tools/commit/ed4774bcd8b8d2d1f7ff1196cf7644054cb3ae14#diff-624cbd32cd7fc0f3f9154fbec92b8a1aebb04614360b4a0b5fc28a407e99d743L96]
>  
> In my particular case, I set "cmake-binaries" inside 
> cmake-binaries-plugin/pom.xml.
> Now, when I try deploying a release to Maven Central I get the following 
> exception stack trace:
>  
>  
> {noformat}
> java.lang.NullPointerException
>     at org.apache.maven.artifact.repository.metadata.Metadata.merge 
> (Metadata.java:293)
>     at 
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.updateRepositoryMetadata
>  (AbstractRepositoryMetadata.java:99)
>     at 
> org.apache.maven.artifact.repository.metadata.AbstractRepositoryMetadata.storeInLocalRepository
>  (AbstractRepositoryMetadata.java:59)
>     at org.apache.maven.artifact.repository.metadata.MetadataBridge.merge 
> (MetadataBridge.java:56)
>     at org.eclipse.aether.internal.impl.DefaultDeployer.upload 
> (DefaultDeployer.java:399)
>     at org.eclipse.aether.internal.impl.DefaultDeployer.deploy 
> (DefaultDeployer.java:294)
>     at org.eclipse.aether.internal.impl.DefaultDeployer.deploy 
> (DefaultDeployer.java:202)
>     at org.eclipse.aether.internal.impl.DefaultRepositorySystem.deploy 
> (DefaultRepositorySystem.java:393)
>     at org.apache.maven.artifact.deployer.DefaultArtifactDeployer.deploy 
> (DefaultArtifactDeployer.java:131)
>     at 
> org.sonatype.nexus.maven.staging.deploy.strategy.AbstractDeployStrategy.deployUp
>  (AbstractDeployStrategy.java:213)
>     at 
> org.sonatype.nexus.maven.staging.deploy.strategy.StagingDeployStrategy.finalizeDeploy
>  (StagingDeployStrategy.java:125)
>     at org.sonatype.nexus.maven.staging.deploy.DeployMojo.execute 
> (DeployMojo.java:213)
>     at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo 
> (DefaultBuildPluginManager.java:126){noformat}
>  
> I assume that this is caused by {{preExisting.getPrefix()}} returning null, 
> but I have no idea why this is happening. Perhaps this is caused by previous 
> versions not have a goalPrefix set? Shouldn't the implementation handle this 
> possibility?



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MINVOKER-365) Allow to pre-build script to set user properties

2024-05-14 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-365?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-365.

Resolution: Fixed

> Allow to pre-build script to set user properties
> 
>
> Key: MINVOKER-365
> URL: https://issues.apache.org/jira/browse/MINVOKER-365
> Project: Maven Invoker Plugin
>  Issue Type: New Feature
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> We can have a scenario when in pre-build script we run a mock server, eg by 
> WireMock or simply by other tools. 
> In such situation we have a random a use random port for listening 
> connection, so we need pass it to Maven execution.
> Other simple scenario is when we create a temporary file with test data.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report

2024-05-14 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MINVOKER-351:
-
Issue Type: Bug  (was: Improvement)

> Prevent XML-prohibited characters from entering JUnit report
> 
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Reporter: Mikkel Kjeldsen
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}} 
> nor the underlying XML infrastructure directly protect against the presence 
> of character literals prohibited by the XML specification, meaning such 
> literals can appear in the JUnit report and render it unreadable. *I would 
> appreciate if the Maven Invoker plugin could learn to strip prohibited 
> literals to protect its users from creative plugins.* I argue that this is a 
> safe and expected transformation that is not materially lossy.
> 
> h2. Background
> MINVOKER-196 added the {{}} option [back in 
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
>  As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit 
> report remains effectively 
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example 
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven 
> Invoker populates with the raw build log contents. I've observed that this 
> value is XML-escaped, which I imagine is well understood in the 
> implementation, although I can't immediately find documentation to support 
> that.
> However, escaping notwithstanding, a number of character literals are 
> outright prohibited by the XML specifications. These literals cannot be 
> escaped, and their presence renders an XML document not well formed. The 
> exact set of prohibited characters varies by XML version; the report produced 
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin 
> reads in the build log it does not strip these character literals and neither 
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a 
> build log ends up including a prohibited character the resulting JUnit report 
> will not be well formed.
> The set of prohibited characters is the complement of [the XML 
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When 
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a 
> spinner to standard out, and the implementation uses backspace to render the 
> spinner in place. I have used the Maven Invoker plugin with 
> {{}} to verify a pitest configuration, whereby I discovered 
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and 
> even if pitest could be changed that offers no protection against any other 
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via 
> {{}}. This is technically fairly easy to do, and makes 
> the transformation very explicit, but it requires considerable local work to 
> address an issue many would find obscure and the transformation is 
> permanently lossy unless the user also backs up the raw log to another file 
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals 
> in-between reading the build log and writing to the {{}} value 
> then {{}} will Just Work™, which I assert is what a user 
> will typically expect. Although the {{}} value will no longer 
> exactly match the build log contents, this lossy translation is acceptable: 
> the prohibited characters are overwhelmingly unprintable to begin with and 
> therefore cannot be meaningfully rendered in a static context, and the raw 
> build log remains unchanged in the event that the user needs to investigate 
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that 
> would be affected by it would already have unparseable JUnit reports.
> * I _believe_ that Java's {{j.u.r.Pattern}} can trivially express the 
> complement of allowed characters but there may exist more efficient solutions.
> * Consider also applying this transformation to the 2 uses 

[jira] [Updated] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report

2024-05-14 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MINVOKER-351:
-
Fix Version/s: 3.7.0
   (was: waiting-for-feedback)

> Prevent XML-prohibited characters from entering JUnit report
> 
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Mikkel Kjeldsen
>Priority: Major
> Fix For: 3.7.0
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}} 
> nor the underlying XML infrastructure directly protect against the presence 
> of character literals prohibited by the XML specification, meaning such 
> literals can appear in the JUnit report and render it unreadable. *I would 
> appreciate if the Maven Invoker plugin could learn to strip prohibited 
> literals to protect its users from creative plugins.* I argue that this is a 
> safe and expected transformation that is not materially lossy.
> 
> h2. Background
> MINVOKER-196 added the {{}} option [back in 
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
>  As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit 
> report remains effectively 
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example 
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven 
> Invoker populates with the raw build log contents. I've observed that this 
> value is XML-escaped, which I imagine is well understood in the 
> implementation, although I can't immediately find documentation to support 
> that.
> However, escaping notwithstanding, a number of character literals are 
> outright prohibited by the XML specifications. These literals cannot be 
> escaped, and their presence renders an XML document not well formed. The 
> exact set of prohibited characters varies by XML version; the report produced 
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin 
> reads in the build log it does not strip these character literals and neither 
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a 
> build log ends up including a prohibited character the resulting JUnit report 
> will not be well formed.
> The set of prohibited characters is the complement of [the XML 
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When 
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a 
> spinner to standard out, and the implementation uses backspace to render the 
> spinner in place. I have used the Maven Invoker plugin with 
> {{}} to verify a pitest configuration, whereby I discovered 
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and 
> even if pitest could be changed that offers no protection against any other 
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via 
> {{}}. This is technically fairly easy to do, and makes 
> the transformation very explicit, but it requires considerable local work to 
> address an issue many would find obscure and the transformation is 
> permanently lossy unless the user also backs up the raw log to another file 
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals 
> in-between reading the build log and writing to the {{}} value 
> then {{}} will Just Work™, which I assert is what a user 
> will typically expect. Although the {{}} value will no longer 
> exactly match the build log contents, this lossy translation is acceptable: 
> the prohibited characters are overwhelmingly unprintable to begin with and 
> therefore cannot be meaningfully rendered in a static context, and the raw 
> build log remains unchanged in the event that the user needs to investigate 
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that 
> would be affected by it would already have unparseable JUnit reports.
> * I _believe_ that Java's {{j.u.r.Pattern}} can trivially express the 
> complement of allowed characters but there may exist more efficient solutions.
> * Consider 

[jira] [Updated] (MJAR-300) maven jar plugin does not interpret build outputTimestamp correctly

2024-05-13 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAR-300?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MJAR-300:
-
Fix Version/s: waiting-for-feedback

> maven jar plugin does not interpret build outputTimestamp correctly
> ---
>
> Key: MJAR-300
> URL: https://issues.apache.org/jira/browse/MJAR-300
> Project: Maven JAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> consider a minimal project that packages a jar:
> % DATE=$(date -Iseconds) ; echo $DATE ; mvn -q clean package ; jar tvf 
> target/jartest-0.1-SNAPSHOT.jar
> 2024-02-10T21:44:53-08:00
>      0 Sat Feb 10 21:44:54 PST 2024 META-INF/
>    568 Sat Feb 10 21:44:54 PST 2024 META-INF/MANIFEST.MF
>      0 Sat Feb 10 21:44:54 PST 2024 META-INF/maven/
>      0 Sat Feb 10 21:44:54 PST 2024 META-INF/maven/jartest/
>      0 Sat Feb 10 21:44:54 PST 2024 META-INF/maven/jartest/jartest/
>      5 Sat Feb 10 21:44:54 PST 2024 testfile.txt
>    575 Sat Feb 10 21:39:50 PST 2024 META-INF/maven/jartest/jartest/pom.xml
>     56 Sat Feb 10 21:44:54 PST 2024 
> META-INF/maven/jartest/jartest/pom.properties
> Note how the timestamp returned by the date command and the timestamps of the 
> entries in the jar are basically the same (around 21:44:53 - 21:44:54 on Feb 
> 10th, 2024)
> Now use that date as the project build timestamp:
> DATE=$(date -Iseconds) ; echo $DATE ; mvn -q 
> -Dproject.build.outputTimestamp=$DATE clean package ; jar tvf 
> target/jartest-0.1-SNAPSHOT.jar
> 2024-02-10T21:46:30-08:00
>      0 Sun Feb 11 05:46:30 PST 2024 META-INF/
>    568 Sun Feb 11 05:46:30 PST 2024 META-INF/MANIFEST.MF
>      0 Sun Feb 11 05:46:30 PST 2024 META-INF/maven/
>      0 Sun Feb 11 05:46:30 PST 2024 META-INF/maven/jartest/
>      0 Sun Feb 11 05:46:30 PST 2024 META-INF/maven/jartest/jartest/
>      5 Sun Feb 11 05:46:30 PST 2024 testfile.txt
>    575 Sun Feb 11 05:46:30 PST 2024 META-INF/maven/jartest/jartest/pom.xml
>     56 Sun Feb 11 05:46:30 PST 2024 
> META-INF/maven/jartest/jartest/pom.properties
>  
> The timestamp and the entries in the jar differ by eight hours (the offset of 
> my local timezone).
> When forcing UTC:
> DATE=$(TZ=UTC date -Iseconds) ; echo $DATE ; mvn -q 
> -Dproject.build.outputTimestamp=$DATE clean package ; jar tvf 
> target/jartest-0.1-SNAPSHOT.jar
> 2024-02-11T05:48:22+00:00
>      0 Sun Feb 11 05:48:22 PST 2024 META-INF/
>    568 Sun Feb 11 05:48:22 PST 2024 META-INF/MANIFEST.MF
>      0 Sun Feb 11 05:48:22 PST 2024 META-INF/maven/
>      0 Sun Feb 11 05:48:22 PST 2024 META-INF/maven/jartest/
>      0 Sun Feb 11 05:48:22 PST 2024 META-INF/maven/jartest/jartest/
>      5 Sun Feb 11 05:48:22 PST 2024 testfile.txt
>    575 Sun Feb 11 05:48:22 PST 2024 META-INF/maven/jartest/jartest/pom.xml
>     56 Sun Feb 11 05:48:22 PST 2024 
> META-INF/maven/jartest/jartest/pom.properties
> The timestamp is "correct" but I passed it in as UTC but the jar plugin 
> considers it "local time" and silently attaches PST as timezone. This is 
> where the eight hours discrepancy come from.
> This seems to be specific to the outputTimestamp parsing of the jar plugin. 
>  
>  
>  
>  
>  
>  
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MJAR-310) [REGRESSION] Plugin fails to handle toolchain paths that contain spaces

2024-05-13 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MJAR-310?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MJAR-310:
-
Fix Version/s: next-release

> [REGRESSION] Plugin fails to handle toolchain paths that contain spaces
> ---
>
> Key: MJAR-310
> URL: https://issues.apache.org/jira/browse/MJAR-310
> Project: Maven JAR Plugin
>  Issue Type: Bug
>Affects Versions: 3.4.0, 3.4.1
> Environment: Maven 3.9.6
> Windows 10
>Reporter: Gili
>Priority: Major
> Fix For: next-release
>
>
> When upgrading from version 3.3.0 to 3.4.0 I started getting the following 
> build-time warning:
>  
> {{[WARNING] Unrecognized output form C:\Program 
> Files\Java\zulu-8\bin\javac.exe -version - 'C:\Program' is not recognized as 
> an internal or external command,}}
> {{operable program or batch file.}}
>  
> The contents of toolchain.xml is:
>  
> {{}}
> {{}}
> {{    }}
> {{        jdk}}
> {{        }}
> {{            8}}
> {{            zulu}}
> {{        }}
> {{        }}
> {{            C:\Program Files\Java\zulu-8}}
> {{        }}
> {{    }}
> {{}}
>  
> I don't know if this warning breaks anything.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNGSITE-538) Drop generation of site JAR

2024-05-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MNGSITE-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845856#comment-17845856
 ] 

Slawomir Jaranowski commented on MNGSITE-538:
-

I don't believe that it is used ... we can drop it after search other 
references in pages

> Drop generation of site JAR
> ---
>
> Key: MNGSITE-538
> URL: https://issues.apache.org/jira/browse/MNGSITE-538
> Project: Maven Project Web Site
>  Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> Is is highly questionable that anyone needs this site JAR. It wastes cycles. 
> Let's drop it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MNGSITE-538) Drop generation of site JAR

2024-05-13 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MNGSITE-538?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845842#comment-17845842
 ] 

Slawomir Jaranowski commented on MNGSITE-538:
-

There is reference at download page:
{noformat}
        Apache Maven Website As 
Documentation Archive {noformat}

> Drop generation of site JAR
> ---
>
> Key: MNGSITE-538
> URL: https://issues.apache.org/jira/browse/MNGSITE-538
> Project: Maven Project Web Site
>  Issue Type: Task
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
>
> Is is highly questionable that anyone needs this site JAR. It wastes cycles. 
> Let's drop it.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1394) Upgrade Maven core dependencies to the latest and make as provided

2024-05-12 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1394?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1394.

Resolution: Fixed

> Upgrade Maven core dependencies to the latest and make as provided
> --
>
> Key: MSHARED-1394
> URL: https://issues.apache.org/jira/browse/MSHARED-1394
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-dependency-analyzer
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-analyzer-1.14.0
>
>
> We need not to have a Maven core dependencies in compile scope.
> When we use this artifact in another for analyze project all Maven 
> dependencies are in place also in provided scope.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report

2024-05-12 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845678#comment-17845678
 ] 

Slawomir Jaranowski commented on MINVOKER-351:
--

[~mkjeldsen] thank it looks like we can simple use your example a next IT

> Prevent XML-prohibited characters from entering JUnit report
> 
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Mikkel Kjeldsen
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: minvoker-351.tar.gz
>
>
> Neither the Maven Invoker plugin's implementation of {{}} 
> nor the underlying XML infrastructure directly protect against the presence 
> of character literals prohibited by the XML specification, meaning such 
> literals can appear in the JUnit report and render it unreadable. *I would 
> appreciate if the Maven Invoker plugin could learn to strip prohibited 
> literals to protect its users from creative plugins.* I argue that this is a 
> safe and expected transformation that is not materially lossy.
> 
> h2. Background
> MINVOKER-196 added the {{}} option [back in 
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
>  As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit 
> report remains effectively 
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example 
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven 
> Invoker populates with the raw build log contents. I've observed that this 
> value is XML-escaped, which I imagine is well understood in the 
> implementation, although I can't immediately find documentation to support 
> that.
> However, escaping notwithstanding, a number of character literals are 
> outright prohibited by the XML specifications. These literals cannot be 
> escaped, and their presence renders an XML document not well formed. The 
> exact set of prohibited characters varies by XML version; the report produced 
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin 
> reads in the build log it does not strip these character literals and neither 
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a 
> build log ends up including a prohibited character the resulting JUnit report 
> will not be well formed.
> The set of prohibited characters is the complement of [the XML 
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When 
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a 
> spinner to standard out, and the implementation uses backspace to render the 
> spinner in place. I have used the Maven Invoker plugin with 
> {{}} to verify a pitest configuration, whereby I discovered 
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and 
> even if pitest could be changed that offers no protection against any other 
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via 
> {{}}. This is technically fairly easy to do, and makes 
> the transformation very explicit, but it requires considerable local work to 
> address an issue many would find obscure and the transformation is 
> permanently lossy unless the user also backs up the raw log to another file 
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals 
> in-between reading the build log and writing to the {{}} value 
> then {{}} will Just Work™, which I assert is what a user 
> will typically expect. Although the {{}} value will no longer 
> exactly match the build log contents, this lossy translation is acceptable: 
> the prohibited characters are overwhelmingly unprintable to begin with and 
> therefore cannot be meaningfully rendered in a static context, and the raw 
> build log remains unchanged in the event that the user needs to investigate 
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that 
> would be affected by it would already have unparseable JUnit reports.
> * I _believe_ that Java's {{j.u.r.Pattern}} can trivially express the 
> complement of allowed characters but 

[jira] [Closed] (MINVOKER-367) Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0

2024-05-11 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-367?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-367.

Resolution: Fixed

> Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0
> --
>
> Key: MINVOKER-367
> URL: https://issues.apache.org/jira/browse/MINVOKER-367
> Project: Maven Invoker Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MINVOKER-367) Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 3.3.0

2024-05-11 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINVOKER-367:


 Summary: Bump org.apache.maven.shared:maven-invoker from 3.2.0 to 
3.3.0
 Key: MINVOKER-367
 URL: https://issues.apache.org/jira/browse/MINVOKER-367
 Project: Maven Invoker Plugin
  Issue Type: Dependency upgrade
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: 3.7.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MINVOKER-307) invoker should also support the @{ } syntax like the surefire plugin

2024-05-11 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MINVOKER-307:
-
Fix Version/s: 3.7.0

> invoker should also support the @{ } syntax like the surefire plugin
> 
>
> Key: MINVOKER-307
> URL: https://issues.apache.org/jira/browse/MINVOKER-307
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Assignee: Slawomir Jaranowski
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.7.0
>
>
> The surefire plugin supports a special `@\{ ... }` syntax to do 'late' 
> resolution of maven properties (not at POM evaluation time but at plugin 
> execution time). See 
> [https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine]
>  for details.
>  
> It would be great if the invoker plugin would support the same syntax for the 
>  configuration setting.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Assigned] (MINVOKER-307) invoker should also support the @{ } syntax like the surefire plugin

2024-05-11 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-307?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski reassigned MINVOKER-307:


Assignee: Slawomir Jaranowski

> invoker should also support the @{ } syntax like the surefire plugin
> 
>
> Key: MINVOKER-307
> URL: https://issues.apache.org/jira/browse/MINVOKER-307
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Affects Versions: 3.3.0
>Reporter: Henning Schmiedehausen
>Assignee: Slawomir Jaranowski
>Priority: Major
>  Labels: up-for-grabs
>
> The surefire plugin supports a special `@\{ ... }` syntax to do 'late' 
> resolution of maven properties (not at POM evaluation time but at plugin 
> execution time). See 
> [https://maven.apache.org/surefire/maven-surefire-plugin/test-mojo.html#argLine]
>  for details.
>  
> It would be great if the invoker plugin would support the same syntax for the 
>  configuration setting.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1393) Allow to exclude classes from verification - revert MSHARED-1248

2024-05-11 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1393?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1393.

Resolution: Fixed

> Allow to exclude classes from verification - revert MSHARED-1248
> 
>
> Key: MSHARED-1393
> URL: https://issues.apache.org/jira/browse/MSHARED-1393
> Project: Maven Shared Components
>  Issue Type: New Feature
>  Components: maven-dependency-analyzer
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-analyzer-1.14.0
>
>
> In some situation project can contains corrupted classes.
> Instead of skip it with only warning like in: MSHARED-1248 we should have 
> possibility to skip only known corrupted classes - not all.
> When we skip all - we can stop analyzing anything when asm does not support 
> next byte code version.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MSOURCES-148) The plugin should respect the --update-dependencies for final versions

2024-05-11 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MSOURCES-148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845552#comment-17845552
 ] 

Slawomir Jaranowski commented on MSOURCES-148:
--

[~bmuschko] Can you show an example project?

The Maven plugins does not support cli arguments ... it is recognized by Maven 
executing 

But I don't see an argument {{--update-dependencies}} for Maven ... where you 
use such argument?

> The plugin should respect the --update-dependencies for final versions
> --
>
> Key: MSOURCES-148
> URL: https://issues.apache.org/jira/browse/MSOURCES-148
> Project: Maven Source Plugin
>  Issue Type: New Feature
>Reporter: Benjamin Muschko
>Priority: Major
>
> Executing the build with the flag {{--update-dependencies}} should only 
> update SNAPSHOT dependencies. The plugin doesn't seem to evaluate this flag. 
> Running the build with the flag will update SNAPSHOT _and_ final dependencies 
> leading to a much longer build time.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report

2024-05-11 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MINVOKER-351:
-
Fix Version/s: waiting-for-feedback

> Prevent XML-prohibited characters from entering JUnit report
> 
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Mikkel Kjeldsen
>Priority: Major
> Fix For: waiting-for-feedback
>
>
> Neither the Maven Invoker plugin's implementation of {{}} 
> nor the underlying XML infrastructure directly protect against the presence 
> of character literals prohibited by the XML specification, meaning such 
> literals can appear in the JUnit report and render it unreadable. *I would 
> appreciate if the Maven Invoker plugin could learn to strip prohibited 
> literals to protect its users from creative plugins.* I argue that this is a 
> safe and expected transformation that is not materially lossy.
> 
> h2. Background
> MINVOKER-196 added the {{}} option [back in 
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
>  As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit 
> report remains effectively 
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example 
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven 
> Invoker populates with the raw build log contents. I've observed that this 
> value is XML-escaped, which I imagine is well understood in the 
> implementation, although I can't immediately find documentation to support 
> that.
> However, escaping notwithstanding, a number of character literals are 
> outright prohibited by the XML specifications. These literals cannot be 
> escaped, and their presence renders an XML document not well formed. The 
> exact set of prohibited characters varies by XML version; the report produced 
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin 
> reads in the build log it does not strip these character literals and neither 
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a 
> build log ends up including a prohibited character the resulting JUnit report 
> will not be well formed.
> The set of prohibited characters is the complement of [the XML 
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When 
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a 
> spinner to standard out, and the implementation uses backspace to render the 
> spinner in place. I have used the Maven Invoker plugin with 
> {{}} to verify a pitest configuration, whereby I discovered 
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and 
> even if pitest could be changed that offers no protection against any other 
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via 
> {{}}. This is technically fairly easy to do, and makes 
> the transformation very explicit, but it requires considerable local work to 
> address an issue many would find obscure and the transformation is 
> permanently lossy unless the user also backs up the raw log to another file 
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals 
> in-between reading the build log and writing to the {{}} value 
> then {{}} will Just Work™, which I assert is what a user 
> will typically expect. Although the {{}} value will no longer 
> exactly match the build log contents, this lossy translation is acceptable: 
> the prohibited characters are overwhelmingly unprintable to begin with and 
> therefore cannot be meaningfully rendered in a static context, and the raw 
> build log remains unchanged in the event that the user needs to investigate 
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that 
> would be affected by it would already have unparseable JUnit reports.
> * I _believe_ that Java's {{j.u.r.Pattern}} can trivially express the 
> complement of allowed characters but there may exist more efficient solutions.
> * Consider also applying this transformation to the 2 uses of 
> 

[jira] [Commented] (MINVOKER-351) Prevent XML-prohibited characters from entering JUnit report

2024-05-11 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MINVOKER-351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845549#comment-17845549
 ] 

Slawomir Jaranowski commented on MINVOKER-351:
--

[~mkjeldsen] please provide a simple project which can reproduce it

> Prevent XML-prohibited characters from entering JUnit report
> 
>
> Key: MINVOKER-351
> URL: https://issues.apache.org/jira/browse/MINVOKER-351
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Mikkel Kjeldsen
>Priority: Major
>
> Neither the Maven Invoker plugin's implementation of {{}} 
> nor the underlying XML infrastructure directly protect against the presence 
> of character literals prohibited by the XML specification, meaning such 
> literals can appear in the JUnit report and render it unreadable. *I would 
> appreciate if the Maven Invoker plugin could learn to strip prohibited 
> literals to protect its users from creative plugins.* I argue that this is a 
> safe and expected transformation that is not materially lossy.
> 
> h2. Background
> MINVOKER-196 added the {{}} option [back in 
> maven-invoker-plugin-3.2.1|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.2.1/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1878-L1946].
>  As of [maven-invoker-plugin-3.6.0 the effective implementation of the JUnit 
> report remains effectively 
> unchanged|https://github.com/apache/maven-invoker-plugin/blob/maven-invoker-plugin-3.6.0/src/main/java/org/apache/maven/plugins/invoker/AbstractInvokerMojo.java#L1695-L1754].
> The JUnit report includes a {{}} element ([example 
> documentation|https://github.com/testmoapp/junitxml]) whose value Maven 
> Invoker populates with the raw build log contents. I've observed that this 
> value is XML-escaped, which I imagine is well understood in the 
> implementation, although I can't immediately find documentation to support 
> that.
> However, escaping notwithstanding, a number of character literals are 
> outright prohibited by the XML specifications. These literals cannot be 
> escaped, and their presence renders an XML document not well formed. The 
> exact set of prohibited characters varies by XML version; the report produced 
> by the Maven Invoker plugin is XML version 1.0. When the Maven Invoker plugin 
> reads in the build log it does not strip these character literals and neither 
> does the XML writer the Maven Invoker plugin relies on. Consequently, if a 
> build log ends up including a prohibited character the resulting JUnit report 
> will not be well formed.
> The set of prohibited characters is the complement of [the XML 
> specification's definition of {{Char}}|https://www.w3.org/TR/xml/#NT-Char].
> h2. Example
> Among the literals prohibited by XML version 1.0 is {{^H}} (backspace). When 
> [pitest runs via Maven|https://pitest.org/quickstart/maven/] it prints a 
> spinner to standard out, and the implementation uses backspace to render the 
> spinner in place. I have used the Maven Invoker plugin with 
> {{}} to verify a pitest configuration, whereby I discovered 
> this limitation.
> h2. Remediation
> h3. Blame plugins
> Perhaps pitest should not behave this way but we can't change pitest, and 
> even if pitest could be changed that offers no protection against any other 
> plugin, so blaming plugins is an ineffective course of action.
> h3. Work-arounds
> The user can manually clean the build log in-place via 
> {{}}. This is technically fairly easy to do, and makes 
> the transformation very explicit, but it requires considerable local work to 
> address an issue many would find obscure and the transformation is 
> permanently lossy unless the user also backs up the raw log to another file 
> name.
> h3. Strip prohibited literals inside Maven Invoker plugin
> If the Maven Invoker plugin learns to strip offending character literals 
> in-between reading the build log and writing to the {{}} value 
> then {{}} will Just Work™, which I assert is what a user 
> will typically expect. Although the {{}} value will no longer 
> exactly match the build log contents, this lossy translation is acceptable: 
> the prohibited characters are overwhelmingly unprintable to begin with and 
> therefore cannot be meaningfully rendered in a static context, and the raw 
> build log remains unchanged in the event that the user needs to investigate 
> or assert against the raw output.
> This change would be backwards compatible, because any existing user that 
> would be affected by it would already have unparseable JUnit reports.
> * I _believe_ that Java's {{j.u.r.Pattern}} can trivially express the 
> complement of allowed characters but there may exist more efficient solutions.
> * Consider also applying this transformation to the 2 

[jira] [Updated] (MINVOKER-348) Build job report is truncated

2024-05-11 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MINVOKER-348:
-
Fix Version/s: waiting-for-feedback

> Build job report is truncated
> -
>
> Key: MINVOKER-348
> URL: https://issues.apache.org/jira/browse/MINVOKER-348
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Alvaro Sanchez-Mariscal
>Priority: Major
> Fix For: waiting-for-feedback
>
> Attachments: BUILD-test-resources.xml, build.log
>
>
> The build-job.xml generated for a project is truncated:
> {code:xml}
> 
>  result="failure-post-hook" time="42.662" 
> buildlog="/Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/target/it/test-resources/build.log">
>   Assertion failed: 
> assert log.text.contains("BUILD SUCCESS")
>|   ||
>|   |false
>|   '[INFO] Error stacktraces are turned on.\n[INFO] Scanning for 
> projects...\n[WARNING] This build will only read from the build cache, since 
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO] 
> -
> {code}
> Examining the build output, it gets truncated after a {{<}} appears, which is 
> replaced in the XML with {{}};, but then nothing else. Snippet following
> {noformat}
> [INFO] Error stacktraces are turned on.\n[INFO] Scanning for 
> projects...\n[WARNING] This build will only read from the build cache, since 
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO] 
> -< io.micronaut.build.examples:test-resources 
> >-\n[INFO]
> {noformat}
> Then, the verify mojo crashes when reading such file:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-invoker-plugin:3.5.1:verify (integration-test) 
> on project micronaut-maven-integration-tests: Failed to read report file: 
> /Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/micronaut-maven-integration-tests/target/invoker-reports/BUILD-test-resources.xml:
>  no more data available - expected end tags  to 
> close start tag  from line 3 and start tag  from 
> line 2, parser stopped on START_TAG seen ...t part of the build 
> invocation.\n[INFO] \n[INFO] -... @8:242 -> [Help 1]
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MINVOKER-348) Build job report is truncated

2024-05-11 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MINVOKER-348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17845547#comment-17845547
 ] 

Slawomir Jaranowski commented on MINVOKER-348:
--

[~alvaro.sanchez] can you provide a simple project which can reproduce it?

> Build job report is truncated
> -
>
> Key: MINVOKER-348
> URL: https://issues.apache.org/jira/browse/MINVOKER-348
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Alvaro Sanchez-Mariscal
>Priority: Major
> Attachments: BUILD-test-resources.xml, build.log
>
>
> The build-job.xml generated for a project is truncated:
> {code:xml}
> 
>  result="failure-post-hook" time="42.662" 
> buildlog="/Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/target/it/test-resources/build.log">
>   Assertion failed: 
> assert log.text.contains("BUILD SUCCESS")
>|   ||
>|   |false
>|   '[INFO] Error stacktraces are turned on.\n[INFO] Scanning for 
> projects...\n[WARNING] This build will only read from the build cache, since 
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO] 
> -
> {code}
> Examining the build output, it gets truncated after a {{<}} appears, which is 
> replaced in the XML with {{}};, but then nothing else. Snippet following
> {noformat}
> [INFO] Error stacktraces are turned on.\n[INFO] Scanning for 
> projects...\n[WARNING] This build will only read from the build cache, since 
> the clean lifecycle is not part of the build invocation.\n[INFO] \n[INFO] 
> -< io.micronaut.build.examples:test-resources 
> >-\n[INFO]
> {noformat}
> Then, the verify mojo crashes when reading such file:
> {noformat}
> [ERROR] Failed to execute goal 
> org.apache.maven.plugins:maven-invoker-plugin:3.5.1:verify (integration-test) 
> on project micronaut-maven-integration-tests: Failed to read report file: 
> /Users/alvaro/Dev/micronaut-projects/micronaut-maven-plugin/micronaut-maven-integration-tests/target/invoker-reports/BUILD-test-resources.xml:
>  no more data available - expected end tags  to 
> close start tag  from line 3 and start tag  from 
> line 2, parser stopped on START_TAG seen ...t part of the build 
> invocation.\n[INFO] \n[INFO] -... @8:242 -> [Help 1]
> {noformat}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MDEP-923) Code cleanups

2024-05-10 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MDEP-923?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MDEP-923:
-
Description: 
* remove usage of deprecated API where possible
 * cleanup pom after update to 42
 * exclude transitive dependencies on org.apache.maven
 * add {{@project.version@}} in ITs
 * Remove plexus logger from DependencySilentLog

 

  was:
 * remove usage of deprecated API where possible
 * cleanup pom after update to 42
 * exclude transitive dependencies on org.apache.maven
 * add {{@project.version@}} in ITs

 


> Code cleanups
> -
>
> Key: MDEP-923
> URL: https://issues.apache.org/jira/browse/MDEP-923
> Project: Maven Dependency Plugin
>  Issue Type: Task
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> * remove usage of deprecated API where possible
>  * cleanup pom after update to 42
>  * exclude transitive dependencies on org.apache.maven
>  * add {{@project.version@}} in ITs
>  * Remove plexus logger from DependencySilentLog
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1395) Remove dependency on commons-io

2024-05-10 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1395.

Resolution: Fixed

> Remove dependency on commons-io
> ---
>
> Key: MSHARED-1395
> URL: https://issues.apache.org/jira/browse/MSHARED-1395
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-dependency-analyzer
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-analyzer-1.14.0
>
>
> Only one simple method is used {{IOUtils#toByteArra}} ... we can do it in 
> project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1395) Remove dependency on commons-io

2024-05-10 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1395:


 Summary: Remove dependency on commons-io
 Key: MSHARED-1395
 URL: https://issues.apache.org/jira/browse/MSHARED-1395
 Project: Maven Shared Components
  Issue Type: Improvement
  Components: maven-dependency-analyzer
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: maven-dependency-analyzer-1.14.0


Only one simple method is used {{IOUtils#toByteArra}} ... we can do it in 
project.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1394) Upgrade Maven core dependencies to the latest and make as provided

2024-05-09 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1394:


 Summary: Upgrade Maven core dependencies to the latest and make as 
provided
 Key: MSHARED-1394
 URL: https://issues.apache.org/jira/browse/MSHARED-1394
 Project: Maven Shared Components
  Issue Type: Improvement
  Components: maven-dependency-analyzer
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: maven-dependency-analyzer-1.14.0


We need not to have a Maven core dependencies in compile scope.

When we use this artifact in another for analyze project all Maven dependencies 
are in place also in provided scope.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1393) Allow to exclude classes from verification - revert MSHARED-1248

2024-05-09 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1393:


 Summary: Allow to exclude classes from verification - revert 
MSHARED-1248
 Key: MSHARED-1393
 URL: https://issues.apache.org/jira/browse/MSHARED-1393
 Project: Maven Shared Components
  Issue Type: New Feature
  Components: maven-dependency-analyzer
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: maven-dependency-analyzer-1.14.0


In some situation project can contains corrupted classes.

Instead of skip it with only warning like in: MSHARED-1248 we should have 
possibility to skip only known corrupted classes - not all.

When we skip all - we can stop analyzing anything when asm does not support 
next byte code version.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1356) Upgrade Parent to 42

2024-05-08 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1356:
-
Summary: Upgrade Parent to 42  (was: Upgrade Parent to 41)

> Upgrade Parent to 42
> 
>
> Key: MSHARED-1356
> URL: https://issues.apache.org/jira/browse/MSHARED-1356
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-dependency-analyzer
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-analyzer-1.13.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1272) commons-io from 2.11.0 to 2.16.1

2024-05-08 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1272:
-
Summary: commons-io from 2.11.0 to 2.16.1  (was: commons-io from 2.11.0 to 
2.16.0)

> commons-io from 2.11.0 to 2.16.1
> 
>
> Key: MSHARED-1272
> URL: https://issues.apache.org/jira/browse/MSHARED-1272
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-dependency-analyzer
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Fix For: maven-dependency-analyzer-1.13.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1372) Upgrade ASM from 9.5 to 9.7 (Java 23)

2024-05-08 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1372?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1372:
-
Summary: Upgrade ASM from 9.5 to 9.7 (Java 23)  (was: Upgrade ASM to 9.7 
(Java 23))

> Upgrade ASM from 9.5 to 9.7 (Java 23)
> -
>
> Key: MSHARED-1372
> URL: https://issues.apache.org/jira/browse/MSHARED-1372
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>Reporter: Sylwester Lachiewicz
>Assignee: Sylwester Lachiewicz
>Priority: Minor
> Fix For: maven-dependency-analyzer-1.13.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1272) commons-io from 2.11.0 to 2.16.0

2024-05-08 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1272:
-
Summary: commons-io from 2.11.0 to 2.16.0  (was: commons-io to 2.13.0)

> commons-io from 2.11.0 to 2.16.0
> 
>
> Key: MSHARED-1272
> URL: https://issues.apache.org/jira/browse/MSHARED-1272
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-dependency-analyzer
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Fix For: maven-dependency-analyzer-1.13.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1347) maven-dependency-plugin ignores class of object passed as a parameter to method references

2024-05-08 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1347:
-
Fix Version/s: maven-dependency-analyzer-1.13.3
   (was: maven-dependency-analyzer-next-release)

> maven-dependency-plugin ignores class of object passed as a parameter to 
> method references
> --
>
> Key: MSHARED-1347
> URL: https://issues.apache.org/jira/browse/MSHARED-1347
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.13.2
>Reporter: Vidar Breivik
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Fix For: maven-dependency-analyzer-1.13.3
>
>
> Text copied from [MDEP-576|https://issues.apache.org/jira/browse/MDEP-576]
> Hi there, i created a project on 
> [github|https://github.com/vdergachev/dependency-plugin-vs-java-lambda] that 
> can help you to reproduce the issue. Just clone it and make
> {code:java}
> mvn clean install{code}
> In my case plugin ignored Server class from jetty-server.jar and a as result 
> i got message
> {code:java}
> Unused declared dependencies found{code}
>  
> h4.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1356) Upgrade Parent to 41

2024-05-08 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1356?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1356:
-
Fix Version/s: maven-dependency-analyzer-1.13.3
   (was: maven-dependency-analyzer-next-release)

> Upgrade Parent to 41
> 
>
> Key: MSHARED-1356
> URL: https://issues.apache.org/jira/browse/MSHARED-1356
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-dependency-analyzer
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-dependency-analyzer-1.13.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1272) commons-io to 2.13.0

2024-05-08 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1272?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1272:
-
Fix Version/s: maven-dependency-analyzer-1.13.3
   (was: maven-dependency-analyzer-next-release)

> commons-io to 2.13.0
> 
>
> Key: MSHARED-1272
> URL: https://issues.apache.org/jira/browse/MSHARED-1272
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-dependency-analyzer
>Reporter: Elliotte Rusty Harold
>Assignee: Elliotte Rusty Harold
>Priority: Minor
> Fix For: maven-dependency-analyzer-1.13.3
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1248) maven-dependency-analyzer should log instead of failing when analyzing a corrupted jar file

2024-05-08 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1248?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1248:
-
Fix Version/s: maven-dependency-analyzer-1.13.3
   (was: maven-dependency-analyzer-next-release)

> maven-dependency-analyzer should log instead of failing when analyzing a 
> corrupted jar file
> ---
>
> Key: MSHARED-1248
> URL: https://issues.apache.org/jira/browse/MSHARED-1248
> Project: Maven Shared Components
>  Issue Type: Bug
>  Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.13.1
> Environment: Apache Maven 3.9.1 
> (2e178502fcdbffc201671fb2537d0cb4b4cc58f8)
> Maven home: C:\java\apache-maven-3.9.1
> Java version: 1.8.0_362, vendor: Temurin, runtime: C:\Program Files\Eclipse 
> Adoptium\jdk-8.0.362.9-hotspot\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> Microsoft Windows [Version 10.0.19044.2728]
>Reporter: Gary D. Gregory
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: maven-dependency-analyzer-1.13.3
>
>
> In Apache Commons BCEL, we include corrupted jar files created by the 
> oss-fuzz project which causes the build to fail when the CycloneDX plugin 
> runs to create an SBOM.
> This issue happens only after getting past the issue fixed by MSHARED-1247
> {noformat}
> [DEBUG] CycloneDX: Calculating Hashes
> [INFO] 
> 
> [INFO] BUILD FAILURE
> [INFO] 
> 
> [INFO] Total time:  3.594 s
> [INFO] Finished at: 2023-04-29T15:23:05-04:00
> [INFO] 
> 
> [ERROR] Failed to execute goal 
> org.cyclonedx:cyclonedx-maven-plugin:2.7.7:makeAggregateBom (default-cli) on 
> project bcel: Execution default-cli of goal 
> org.cyclonedx:cyclonedx-maven-plugin:2.7.7:makeAggregateBom failed: 
> Unsupported class file major version 1025 from directory = 
> C:\Users\ggregory\git\a\commons-bcel\target\test-classes, path = 
> C:\Users\ggregory\git\a\commons-bcel\target\test-classes\ossfuzz\issue51980\Test.class
>  -> [Help 1]
> org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute 
> goal org.cyclonedx:cyclonedx-maven-plugin:2.7.7:makeAggregateBom 
> (default-cli) on project bcel: Execution default-cli of goal 
> org.cyclonedx:cyclonedx-maven-plugin:2.7.7:makeAggregateBom failed: 
> Unsupported class file major version 1025 from directory = 
> C:\Users\ggregory\git\a\commons-bcel\target\test-classes, path = 
> C:\Users\ggregory\git\a\commons-bcel\target\test-classes\ossfuzz\issue51980\Test.class
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute2 
> (MojoExecutor.java:347)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute 
> (MojoExecutor.java:330)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:175)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000 
> (MojoExecutor.java:76)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run 
> (MojoExecutor.java:163)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute 
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute 
> (MojoExecutor.java:160)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:105)
> at 
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject 
> (LifecycleModuleBuilder.java:73)
> at 
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
>  (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute 
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:261)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:173)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:101)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:827)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:272)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:195)
> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at sun.reflect.NativeMethodAccessorImpl.invoke 
> (NativeMethodAccessorImpl.java:62)
> at sun.reflect.DelegatingMethodAccessorImpl.invoke 
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke 

[jira] [Closed] (MSHARED-971) System environment variable are always added to maven-invoker

2024-05-07 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-971.
---
Resolution: Fixed

> System environment variable are always added to maven-invoker
> -
>
> Key: MSHARED-971
> URL: https://issues.apache.org/jira/browse/MSHARED-971
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-invoker, maven-shared-utils
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: maven-invoker-3.3.0
>
>
> In {{org.apache.maven.shared.invoker.MavenCommandLineBuilder}}
> [https://github.com/apache/maven-invoker/blob/d58703dd592ba0bc6f0a09928d0cce90e4002af9/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java#L197-L242]
> we have code:
> {code}
> if ( request.isShellEnvironmentInherited() )
> {
> cli.addSystemEnvironment();
>  }
> {code}
> but in {{org.apache.maven.shared.utils.cli.Commandline}} we have:
> {code}
>  public String[] getEnvironmentVariables()
> {
> addSystemEnvironment();
>...
>  }
> {code}
> System environment variable are always added - it is inconsistent 
> implementation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MINVOKER-366) Require Maven 3.6.3

2024-05-07 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-366.

Resolution: Fixed

> Require Maven 3.6.3
> ---
>
> Key: MINVOKER-366
> URL: https://issues.apache.org/jira/browse/MINVOKER-366
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-971) System environment variable are always added to maven-invoker

2024-05-07 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-971?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-971:

Fix Version/s: maven-invoker-3.3.0

> System environment variable are always added to maven-invoker
> -
>
> Key: MSHARED-971
> URL: https://issues.apache.org/jira/browse/MSHARED-971
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-invoker, maven-shared-utils
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Minor
> Fix For: maven-invoker-3.3.0
>
>
> In {{org.apache.maven.shared.invoker.MavenCommandLineBuilder}}
> [https://github.com/apache/maven-invoker/blob/d58703dd592ba0bc6f0a09928d0cce90e4002af9/src/main/java/org/apache/maven/shared/invoker/MavenCommandLineBuilder.java#L197-L242]
> we have code:
> {code}
> if ( request.isShellEnvironmentInherited() )
> {
> cli.addSystemEnvironment();
>  }
> {code}
> but in {{org.apache.maven.shared.utils.cli.Commandline}} we have:
> {code}
>  public String[] getEnvironmentVariables()
> {
> addSystemEnvironment();
>...
>  }
> {code}
> System environment variable are always added - it is inconsistent 
> implementation.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1390) Deprecate InvocationRequest#setGoals

2024-05-06 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1390.

Resolution: Fixed

> Deprecate InvocationRequest#setGoals
> 
>
> Key: MSHARED-1390
> URL: https://issues.apache.org/jira/browse/MSHARED-1390
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-invoker
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-invoker-3.3.0
>
>
> We should avoid parsing command line arguments.
> Raw arguments should be used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MCOMPILER-591) testCompile wrong detects target less than 1.9 if provided as 8

2024-05-06 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MCOMPILER-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MCOMPILER-591.
-
Resolution: Fixed

> testCompile wrong detects target less than 1.9 if provided as 8
> ---
>
> Key: MCOMPILER-591
> URL: https://issues.apache.org/jira/browse/MCOMPILER-591
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: next-release
>
>
> When we provide target as *8* testCompile wrong detect that is less than 
> {*}1.9/9{*}.
> Method is used to detect if should use modulepath when module descriptor is 
> present in main code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1391) Code cleanups

2024-05-06 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1391?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1391.

Resolution: Fixed

> Code cleanups
> -
>
> Key: MSHARED-1391
> URL: https://issues.apache.org/jira/browse/MSHARED-1391
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-invoker
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-invoker-3.3.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MCOMPILER-591) testCompile wrong detects target less than 1.9 if provided as 8

2024-05-06 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MCOMPILER-591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MCOMPILER-591:
--
Summary: testCompile wrong detects target less than 1.9 if provided as 8  
(was: testCompile wrong detects target less that 1.9 if provided as 8)

> testCompile wrong detects target less than 1.9 if provided as 8
> ---
>
> Key: MCOMPILER-591
> URL: https://issues.apache.org/jira/browse/MCOMPILER-591
> Project: Maven Compiler Plugin
>  Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: next-release
>
>
> When we provide target as *8* testCompile wrong detect that is less than 
> {*}1.9/9{*}.
> Method is used to detect if should use modulepath when module descriptor is 
> present in main code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MDEP-926) proxy settings ignored for dependencies

2024-05-06 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MDEP-926?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843849#comment-17843849
 ] 

Slawomir Jaranowski commented on MDEP-926:
--

Yes I do it step by step

> proxy settings ignored for dependencies
> ---
>
> Key: MDEP-926
> URL: https://issues.apache.org/jira/browse/MDEP-926
> Project: Maven Dependency Plugin
>  Issue Type: Bug
>Reporter: Patrick Mackinlay
>Priority: Major
> Attachments: image-2024-04-23-12-02-38-218.png, settings.xml
>
>
> The proxy settings are ignored for dependencies in maven 3.9.6 (working in 
> 3.9.2).
> On a machine with no direct internet access, if you clear your local 
> repository with a command like:
> rm -rf ~/.m2/repository/org/apache/maven/maven-core/2.2.1
> and then try and download the dependency:
> mvn dependency:get -DgroupId=org.apache.maven -DartifactId=maven-core 
> -Dversion=2.2.1
>  
> It will fail. The proxy settings are ignored. However, it should be noted 
> that for plugins they are used, its only for dependencies that they are 
> ignored.
> maven version 3.9.2 works, so looks like this was introduced in 3.9.3 
> probably when the dependency plugin version was upgraded.
>  
> I used a minimal settings.xml with just one proxy entry.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MCOMPILER-591) testCompile wrong detects target less that 1.9 if provided as 8

2024-05-05 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MCOMPILER-591:
-

 Summary: testCompile wrong detects target less that 1.9 if 
provided as 8
 Key: MCOMPILER-591
 URL: https://issues.apache.org/jira/browse/MCOMPILER-591
 Project: Maven Compiler Plugin
  Issue Type: Bug
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: next-release


When we provide target as *8* testCompile wrong detect that is less than 
{*}1.9/9{*}.

Method is used to detect if should use modulepath when module descriptor is 
present in main code.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MCOMPILER-588) JUnit4 test framework to JUnit5 migration

2024-05-05 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MCOMPILER-588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MCOMPILER-588.
-
Fix Version/s: next-release
   Resolution: Fixed

> JUnit4 test framework to JUnit5 migration
> -
>
> Key: MCOMPILER-588
> URL: https://issues.apache.org/jira/browse/MCOMPILER-588
> Project: Maven Compiler Plugin
>  Issue Type: Improvement
>Reporter: Mikhail Deviatov
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: next-release
>
>
> We have JUnit5 test framework for a long time. 
> It have modular architecture, good support in IDE and quite fast. It would be 
> good to add support JUnit5 to the project.
> The problem is that there are 2 library used for testing in project 
> *maven-plugin-testing-harness* and *org.eclipse.sisu.plexus* and they both 
> don't have JUnit5 support.
> I created a solution that overrides parts of code used derived and my own 
> implementation.
> Please take a look at it
> https://github.com/apache/maven-compiler-plugin/pull/233



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MCOMPILER-590) Upgrade Parent to 42

2024-05-05 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MCOMPILER-590:
-

 Summary: Upgrade Parent to 42
 Key: MCOMPILER-590
 URL: https://issues.apache.org/jira/browse/MCOMPILER-590
 Project: Maven Compiler Plugin
  Issue Type: Dependency upgrade
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: next-release






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1391) Code cleanups

2024-05-05 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1391:


 Summary: Code cleanups
 Key: MSHARED-1391
 URL: https://issues.apache.org/jira/browse/MSHARED-1391
 Project: Maven Shared Components
  Issue Type: Task
  Components: maven-invoker
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: maven-invoker-3.3.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MINVOKER-366) Require Maven 3.6.3

2024-05-04 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINVOKER-366:


 Summary: Require Maven 3.6.3
 Key: MINVOKER-366
 URL: https://issues.apache.org/jira/browse/MINVOKER-366
 Project: Maven Invoker Plugin
  Issue Type: Improvement
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: 3.7.0






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1390) Deprecate InvocationRequest#setGoals

2024-05-04 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1390:


 Summary: Deprecate InvocationRequest#setGoals
 Key: MSHARED-1390
 URL: https://issues.apache.org/jira/browse/MSHARED-1390
 Project: Maven Shared Components
  Issue Type: Improvement
  Components: maven-invoker
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: maven-invoker-3.3.0


We should avoid parsing command line arguments.

Raw arguments should be used.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1389) Refresh download page

2024-05-04 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1389.

Resolution: Fixed

> Refresh download page
> -
>
> Key: MSHARED-1389
> URL: https://issues.apache.org/jira/browse/MSHARED-1389
> Project: Maven Shared Components
>  Issue Type: Task
>  Components: maven-invoker
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-invoker-next-release
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1382) Maven-invoker: support '--no-snapshot-updates'

2024-05-04 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1382.

Fix Version/s: maven-invoker-next-release
 Assignee: Slawomir Jaranowski
   Resolution: Fixed

> Maven-invoker: support '--no-snapshot-updates'
> --
>
> Key: MSHARED-1382
> URL: https://issues.apache.org/jira/browse/MSHARED-1382
> Project: Maven Shared Components
>  Issue Type: Improvement
>  Components: maven-invoker
>Affects Versions: maven-invoker-3.2.0
>Reporter: Leonid Rozenblyum
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: maven-invoker-next-release
>
>
> Let's add support for *{{--no-snapshot-updates}}* in 
> *{{org.apache.maven.shared.invoker.InvocationRequest}}*
>  
> Currently *{{InvocationRequest}}* supports just the *{{-U}}* *mvn* option 
> which is not enough: it's possible to force the snapshots update or keep 
> default maven policy on this.
>  
> But it's not possible to prevent snapshots updates which is highly desired 
> under some circumstances (e.g. for CI reproducibility).
>  
> NOTE: I may contribute a PR.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile

2024-05-04 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-364.

Resolution: Fixed

> Rename invoker.systemPropertiesFile to invoker.userPropertiesFile
> -
>
> Key: MINVOKER-364
> URL: https://issues.apache.org/jira/browse/MINVOKER-364
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>
> Old property will be deprecated
> It are user properties added to cli - not a system properties



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1389) Refresh download page

2024-05-03 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1389:


 Summary: Refresh download page
 Key: MSHARED-1389
 URL: https://issues.apache.org/jira/browse/MSHARED-1389
 Project: Maven Shared Components
  Issue Type: Task
  Components: maven-invoker
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: maven-invoker-next-release






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MSHARED-1338) Update groovy to 4.0.16

2024-05-03 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MSHARED-1338.

Fix Version/s: (was: waiting-for-feedback)
   Resolution: Invalid

> Update groovy to 4.0.16
> ---
>
> Key: MSHARED-1338
> URL: https://issues.apache.org/jira/browse/MSHARED-1338
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-invoker
>Reporter: Jorge Solórzano
>Priority: Major
>  Labels: up-for-grabs
>
> Update Groovy 4.0.16 to support running on JDK 22.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MSHARED-1388) Upgrade Parent to 42

2024-05-03 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MSHARED-1388:


 Summary: Upgrade Parent to 42
 Key: MSHARED-1388
 URL: https://issues.apache.org/jira/browse/MSHARED-1388
 Project: Maven Shared Components
  Issue Type: Dependency upgrade
  Components: maven-invoker
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: maven-invoker-next-release






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MSHARED-1338) Update groovy to 4.0.16

2024-05-03 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MSHARED-1338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MSHARED-1338:
-
Fix Version/s: waiting-for-feedback

> Update groovy to 4.0.16
> ---
>
> Key: MSHARED-1338
> URL: https://issues.apache.org/jira/browse/MSHARED-1338
> Project: Maven Shared Components
>  Issue Type: Dependency upgrade
>  Components: maven-invoker
>Reporter: Jorge Solórzano
>Priority: Major
>  Labels: up-for-grabs
> Fix For: waiting-for-feedback
>
>
> Update Groovy 4.0.16 to support running on JDK 22.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MINVOKER-365) Allow to pre-build script to set user properties

2024-05-03 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINVOKER-365:


 Summary: Allow to pre-build script to set user properties
 Key: MINVOKER-365
 URL: https://issues.apache.org/jira/browse/MINVOKER-365
 Project: Maven Invoker Plugin
  Issue Type: New Feature
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: 3.7.0


We can have a scenario when in pre-build script we run a mock server, eg by 
WireMock or simply by other tools. 

In such situation we have a random a use random port for listening connection, 
so we need pass it to Maven execution.

Other simple scenario is when we create a temporary file with test data.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MINVOKER-317) invoker:install installs different sets of dependencies, depending on the reactor build

2024-05-03 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-317?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-317.

Fix Version/s: (was: waiting-for-feedback)
   Resolution: Won't Fix

It is the same behavior as is in other Maven build ... dependencies in project 
can depends on current reactor

> invoker:install installs different sets of dependencies, depending on the 
> reactor build
> ---
>
> Key: MINVOKER-317
> URL: https://issues.apache.org/jira/browse/MINVOKER-317
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Affects Versions: 3.3.0, 3.4.0
>Reporter: Henning Schmiedehausen
>Priority: Major
>
> - Clone this repository: [https://github.com/hgschmie/invoker-bug]
> - Run "mvn clean install"
> The repository builds, runs all integration tests and installs dependencies 
> successfully.
> - Now run "mvn -pl :test clean install"
> One of the integration tests fails. The error message in 
> test/target/it/test-it-fails/build.log is
> [ERROR] Failed to execute goal on project test-it-ok: Could not resolve 
> dependencies for project invoker-bug:test-it-ok:jar:0.1-SNAPSHOT: Could not 
> find artifact invoker-bug:dep:jar:tests:0.1-SNAPSHOT -> [Help 1] 
> - Now run "mvn -am -pl :test clean install"
> the integration tests succeed
>  
> The main difference is:
> For the failing build, invoker:install reports
>  
> {quote}[INFO] --- maven-invoker-plugin:3.4.0:install 
> (basepom.invoker-integration-testing.default) @ test ---
> [WARNING] skip dependencyProject null for 
> projectId=invoker-bug:dep:0.1-SNAPSHOT
> [INFO] Installing /Users/henning/scratch/invoker-bug/pom.xml to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/parent/0.1-SNAPSHOT/parent-0.1-SNAPSHOT.pom
> [INFO] Installing /Users/henning/scratch/invoker-bug/test/pom.xml to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/test/0.1-SNAPSHOT/test-0.1-SNAPSHOT.pom
> [INFO] Installing 
> /Users/henning/scratch/invoker-bug/test/target/test-0.1-SNAPSHOT.jar to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/test/0.1-SNAPSHOT/test-0.1-SNAPSHOT.jar
> [INFO] Installing 
> /Users/henning/scratch/invoker-bug/test/target/test-0.1-SNAPSHOT-tests.jar to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/test/0.1-SNAPSHOT/test-0.1-SNAPSHOT-tests.jar
> [INFO] Installing 
> /Users/henning/scratch/invoker-bug/test/target/test-0.1-SNAPSHOT-sources.jar 
> to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/test/0.1-SNAPSHOT/test-0.1-SNAPSHOT-sources.jar
> [INFO] Installing 
> /Users/henning/scratch/invoker-bug/test/target/test-0.1-SNAPSHOT-test-sources.jar
>  to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/test/0.1-SNAPSHOT/test-0.1-SNAPSHOT-test-sources.jar
> {quote}
> For the successful build, it reports
> {quote}[INFO] --- maven-invoker-plugin:3.4.0:install 
> (basepom.invoker-integration-testing.default) @ test ---
> [INFO] Installing /Users/henning/scratch/invoker-bug/dep/pom.xml to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/dep/0.1-SNAPSHOT/dep-0.1-SNAPSHOT.pom
> [INFO] Installing 
> /Users/henning/scratch/invoker-bug/dep/target/dep-0.1-SNAPSHOT.jar to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/dep/0.1-SNAPSHOT/dep-0.1-SNAPSHOT.jar
> [INFO] Installing 
> /Users/henning/scratch/invoker-bug/dep/target/dep-0.1-SNAPSHOT-tests.jar to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/dep/0.1-SNAPSHOT/dep-0.1-SNAPSHOT-tests.jar
> [INFO] Installing 
> /Users/henning/scratch/invoker-bug/dep/target/dep-0.1-SNAPSHOT-sources.jar to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/dep/0.1-SNAPSHOT/dep-0.1-SNAPSHOT-sources.jar
> [INFO] Installing 
> /Users/henning/scratch/invoker-bug/dep/target/dep-0.1-SNAPSHOT-test-sources.jar
>  to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/dep/0.1-SNAPSHOT/dep-0.1-SNAPSHOT-test-sources.jar
> [INFO] Installing /Users/henning/scratch/invoker-bug/pom.xml to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/parent/0.1-SNAPSHOT/parent-0.1-SNAPSHOT.pom
> [INFO] Installing /Users/henning/scratch/invoker-bug/test/pom.xml to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/test/0.1-SNAPSHOT/test-0.1-SNAPSHOT.pom
> [INFO] Installing 
> /Users/henning/scratch/invoker-bug/test/target/test-0.1-SNAPSHOT.jar to 
> /Users/henning/scratch/invoker-bug/test/target/local-repo/invoker-bug/test/0.1-SNAPSHOT/test-0.1-SNAPSHOT.jar
> [INFO] Installing 
> /Users/henning/scratch/invoker-bug/test/target/test-0.1-SNAPSHOT-tests.jar to 
> 

[jira] [Closed] (MINVOKER-363) Bump org.apache.maven.shared:maven-script-interpreter from 1.4 to 1.6

2024-05-03 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-363.

Resolution: Fixed

> Bump org.apache.maven.shared:maven-script-interpreter from 1.4 to 1.6
> -
>
> Key: MINVOKER-363
> URL: https://issues.apache.org/jira/browse/MINVOKER-363
> Project: Maven Invoker Plugin
>  Issue Type: Dependency upgrade
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.7.0
>
>




--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Commented] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile

2024-05-03 Thread Slawomir Jaranowski (Jira)


[ 
https://issues.apache.org/jira/browse/MINVOKER-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17843187#comment-17843187
 ] 

Slawomir Jaranowski commented on MINVOKER-364:
--

{quote}
System properties are/will be handled separately?
{quote}

We have MAVEN_OPTS 

> Rename invoker.systemPropertiesFile to invoker.userPropertiesFile
> -
>
> Key: MINVOKER-364
> URL: https://issues.apache.org/jira/browse/MINVOKER-364
> Project: Maven Invoker Plugin
>  Issue Type: Improvement
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.6.2
>
>
> Old property will be deprecated
> It are user properties added to cli - not a system properties



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MINVOKER-335) Symlinks from source project are copied as file

2024-05-03 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-335?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MINVOKER-335:
-
Labels:   (was: up-for-grabs)

> Symlinks from source project are copied as file
> ---
>
> Key: MINVOKER-335
> URL: https://issues.apache.org/jira/browse/MINVOKER-335
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Reporter: Slawomir Jaranowski
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.6.2
>
>
> Source project:
> {noformat}
> -rw-r--r--  1 xxx  40 May  1 18:44 test.txt
> drwxr-xr-x  2 xxx  64 May  1 19:26 testDir
> lrwxr-xr-x  1 xxx   7 May  1 19:27 testDirLink -> testDir
> lrwxr-xr-x  1 xxx   8 May  1 19:29 testLink.txt -> test.txt
> {noformat}
> after copy in {{target/it/..}}
> {noformat}
> -rw-r--r--  1 xxx  40 May  1 18:44 test.txt
> drwxr-xr-x  2 xxx  64 May  1 19:30 testDir
> lrwxr-xr-x  1 xxx   7 May  1 19:30 testDirLink -> testDir
> -rw-r--r--  1 xxx  40 May  1 18:44 testLink.txt
> {noformat}
> symlinks for directory are preserved only symlinks for file are broken



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Updated] (MINVOKER-336) .mvn/extensions.xml from main project is used in it projects run

2024-05-03 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski updated MINVOKER-336:
-
Labels:   (was: up-for-grabs)

> .mvn/extensions.xml from main project is used in it projects run
> 
>
> Key: MINVOKER-336
> URL: https://issues.apache.org/jira/browse/MINVOKER-336
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Olivier Lamy
>Assignee: Slawomir Jaranowski
>Priority: Major
> Fix For: 3.6.2
>
>
> if the main project contains some extensions in the top directory 
> .mvn/extensions.xml this directory will be used in IT projects run.
> sounds more a issue with core (e.g MNG) due to the script mvn/mvn.bat 
> algorithm to find .mvn directory



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MINVOKER-364) Rename invoker.systemPropertiesFile to invoker.userPropertiesFile

2024-05-03 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINVOKER-364:


 Summary: Rename invoker.systemPropertiesFile to 
invoker.userPropertiesFile
 Key: MINVOKER-364
 URL: https://issues.apache.org/jira/browse/MINVOKER-364
 Project: Maven Invoker Plugin
  Issue Type: Improvement
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: 3.6.2


Old property will be deprecated

It are user properties added to cli - not a system properties



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MINVOKER-336) .mvn/extensions.xml from main project is used in it projects run

2024-05-03 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-336?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-336.

Resolution: Fixed

> .mvn/extensions.xml from main project is used in it projects run
> 
>
> Key: MINVOKER-336
> URL: https://issues.apache.org/jira/browse/MINVOKER-336
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Affects Versions: 3.5.1
>Reporter: Olivier Lamy
>Assignee: Slawomir Jaranowski
>Priority: Major
>  Labels: up-for-grabs
> Fix For: 3.6.2
>
>
> if the main project contains some extensions in the top directory 
> .mvn/extensions.xml this directory will be used in IT projects run.
> sounds more a issue with core (e.g MNG) due to the script mvn/mvn.bat 
> algorithm to find .mvn directory



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Created] (MINVOKER-363) Bump org.apache.maven.shared:maven-script-interpreter from 1.4 to 1.6

2024-05-03 Thread Slawomir Jaranowski (Jira)
Slawomir Jaranowski created MINVOKER-363:


 Summary: Bump org.apache.maven.shared:maven-script-interpreter 
from 1.4 to 1.6
 Key: MINVOKER-363
 URL: https://issues.apache.org/jira/browse/MINVOKER-363
 Project: Maven Invoker Plugin
  Issue Type: Dependency upgrade
Reporter: Slawomir Jaranowski
Assignee: Slawomir Jaranowski
 Fix For: 3.6.2






--
This message was sent by Atlassian Jira
(v8.20.10#820010)


[jira] [Closed] (MINVOKER-253) Sub Modules do not respect localRepositoryPath

2024-05-02 Thread Slawomir Jaranowski (Jira)


 [ 
https://issues.apache.org/jira/browse/MINVOKER-253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Slawomir Jaranowski closed MINVOKER-253.

Fix Version/s: (was: waiting-for-feedback)
   Resolution: Cannot Reproduce

Now I close it ... when we have a reproduce instruction we can reopen

> Sub Modules do not respect localRepositoryPath
> --
>
> Key: MINVOKER-253
> URL: https://issues.apache.org/jira/browse/MINVOKER-253
> Project: Maven Invoker Plugin
>  Issue Type: Bug
>Affects Versions: 3.2.1
> Environment: Maven 3.6.3, Java 1.8, Mac OSX 10.14.6
>Reporter: Andreas Schaefer
>Priority: Major
>
> I use the invoker to run IT tests of our maven plugin and in these tests I 
> use sub modules like core and ui.apps. When settings localRepositoryPath to 
> avoid adding IT tests artifacts to my local Maven repo the pom/artifact of 
> pom called by the invoker will not be installed but the sub modules still are.
> An example can be found at 
> [https://github.com/apache/sling-feature-converter-maven-plugin] .



--
This message was sent by Atlassian Jira
(v8.20.10#820010)


  1   2   3   4   5   6   7   8   9   10   >