[jira] [Comment Edited] (DOXIA-707) Ability to define lineneding for generated content
[ https://issues.apache.org/jira/browse/DOXIA-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773043#comment-17773043 ] richard edited comment on DOXIA-707 at 10/8/23 7:52 PM: How do we provide a writer to your plugin if we remove our custom doxia classes and only use maven site to build doxia pages? Our current, custom doxia code was suppose to be temporary and eventually removed. It was more of a hack to preview changes as we switch to using macros. was (Author: rveach): How do we provide a writer to your plugin if we remove our custom doxia classes and only use maven site to build doxia pages? Our current, custom doxia code was suppose to be temporary and eventually removed. > Ability to define lineneding for generated content > -- > > Key: DOXIA-707 > URL: https://issues.apache.org/jira/browse/DOXIA-707 > Project: Maven Doxia > Issue Type: Improvement >Reporter: Roman Ivanov >Priority: Major > > in Checkstyle project we use doxia classes to generate xml files in xdoc > format > https://github.com/checkstyle/checkstyle/issues/13770 > We have a rule that all files in our git repo are Linux line-ending. > Lunux/unix users are ok, but windows users have inconvenience that after > build execution xdoc files are marked as changes in git, due to change in > lineending. > Right now we do hack with override of some doxia classes to enforce > lineending that we need. > It would be awesome if we can defined lineending in some config or system > variable or -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (DOXIA-707) Ability to define lineneding for generated content
[ https://issues.apache.org/jira/browse/DOXIA-707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17773043#comment-17773043 ] richard commented on DOXIA-707: --- How do we provide a writer to your plugin if we remove our custom doxia classes and only use maven site to build doxia pages? Our current, custom doxia code was suppose to be temporary and eventually removed. > Ability to define lineneding for generated content > -- > > Key: DOXIA-707 > URL: https://issues.apache.org/jira/browse/DOXIA-707 > Project: Maven Doxia > Issue Type: Improvement >Reporter: Roman Ivanov >Priority: Major > > in Checkstyle project we use doxia classes to generate xml files in xdoc > format > https://github.com/checkstyle/checkstyle/issues/13770 > We have a rule that all files in our git repo are Linux line-ending. > Lunux/unix users are ok, but windows users have inconvenience that after > build execution xdoc files are marked as changes in git, due to change in > lineending. > Right now we do hack with override of some doxia classes to enforce > lineending that we need. > It would be awesome if we can defined lineending in some config or system > variable or -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MCHECKSTYLE-342) Support XML 1.1
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17612127#comment-17612127 ] richard commented on MCHECKSTYLE-342: - I wish this to be re-opened as it is not fixed from our latest CI run and is still a blocker. [https://github.com/checkstyle/checkstyle/pull/12247] Caused by: org.codehaus.plexus.util.xml.pull.XmlPullParserException: only 1.0 is supported as Support XML 1.1 > --- > > Key: MCHECKSTYLE-342 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-342 > Project: Maven Checkstyle Plugin > Issue Type: New Feature > Components: checkstyle:check >Affects Versions: 2.17 >Reporter: richard >Assignee: Enrico Olivelli >Priority: Minor > > Checkstyle wishes to upgrade our XML logger to print out XML 1.1 documents. > We need this functionality to support escaping non-printable characters as > XML 1.0 doesn't allow this and considers it an invalid document. > > Exception in thread "main" javax.xml.stream.XMLStreamException: ParseError > > at [row,col]:[45615,80] > > Message: An invalid XML character (Unicode: 0x2) was found in the value of > > attribute "message" and element is "error". > Checkstyle cannot upgrade until maven-checkstyle does as we use it in alot of > regression testing. If we try to give the plugin an XML 1.1 document, it > fails with the following error: > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) > > on project postgresql: Unable to read Checkstyle results xml: > > /pipeline/source/pgjdbc/pgjdbc/target/checkstyle-result.xml: only 1.0 is > > supported as > version="1.1"... @1:19) -> [Help 1] -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Created] (MCHECKSTYLE-381) Remove usage of deprecated class loading functionality from checkstyle
richard created MCHECKSTYLE-381: --- Summary: Remove usage of deprecated class loading functionality from checkstyle Key: MCHECKSTYLE-381 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-381 Project: Maven Checkstyle Plugin Issue Type: Improvement Reporter: richard Checkstyle Issue: [https://github.com/checkstyle/checkstyle/issues/7190] Checkstyle would like to remove all usage of class loading as it is a deprecated functionality and has since been made broken since recent changes. The methods were only left to keep compatibility with maven-checkstyle-plugin but they don't do anything anymore. Checkstyle is a static analysis tool. Class loading always had issues and this is why it was deprecated. We are now in the process of removing it completely. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (MCHECKSTYLE-376) The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848165#comment-16848165
]
richard edited comment on MCHECKSTYLE-376 at 5/25/19 12:09 PM:
---
As romani suggested the failure is because of the clone and the check. I looked
at the raw files and I saw nothing, so I believe the issue to be how it is
cloned. If the machine is windows, the clone method needs `core.autocrlf`
turned on as the check before 8.21 requires the system's line endings. Windows
is `\r\n` and unix is `\n`. If you don't fix the cloning, you'll have to
manually modify the files instead.
was (Author: rveach):
I had my own problems with line endings in maven-checkstyle-plugin when
presenting fixes. If a repo is suppose to be unix line endings as I assume this
repo should be, then windows users should enable `core.autocrlf` in git but
even with this enabled I got unexpected differences when making a commit. It
took a few tries before I could make a commit. I haven't looked further into
the issue yet.
As romani suggested the failure is because of the clone and the check. Since it
is only 2 files I would look at their line endings. The new changes to the
check with 8.21 will most likely fix the build but it will just hide the
problem with line feeds in your repo. It accepts any line feed and doesn't
matter if it is unix or windows allowing users to mix them up. I recommend
adding more checks to control line feeds in your repo. You can also set up an
appveyor CI and have it run your repo on windows to try and find any windows
related issues sooner.
[https://github.com/checkstyle/checkstyle/blob/master/appveyor.yml#L51]
[~romani] take note of this for
[https://github.com/checkstyle/checkstyle/issues/6558]
> The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule
> 'NewlineAtEndOfFile' on Windows.
> --
>
> Key: MCHECKSTYLE-376
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-376
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:check
>Reporter: Tibor Digana
>Assignee: Enrico Olivelli
>Priority: Major
> Attachments: linux.zip, windows.zip
>
>
> Afects version 3.1.0 during the release vote.
> It looks like the library expects system based EOL character.
> The checkstyle reports the issue in two files in
> https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
> I doubt it is a problem with these two files, nothing but the library itself.
> No idea why other ITs do not fail on Windows too.
> {noformat}
> mvn -nsu checkstyle:check
> [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @
> mcheckstyle-54 ---
> [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml
> ruleset.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.450 s
> [INFO] Finished at: 2019-05-13T23:42:55+02:00
> [INFO] Final Memory: 12M/193M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check
> (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-376) The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule 'NewlineAtEndOfFile' on Windows.
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16848165#comment-16848165
]
richard commented on MCHECKSTYLE-376:
-
I had my own problems with line endings in maven-checkstyle-plugin when
presenting fixes. If a repo is suppose to be unix line endings as I assume this
repo should be, then windows users should enable `core.autocrlf` in git but
even with this enabled I got unexpected differences when making a commit. It
took a few tries before I could make a commit. I haven't looked further into
the issue yet.
As romani suggested the failure is because of the clone and the check. Since it
is only 2 files I would look at their line endings. The new changes to the
check with 8.21 will most likely fix the build but it will just hide the
problem with line feeds in your repo. It accepts any line feed and doesn't
matter if it is unix or windows allowing users to mix them up. I recommend
adding more checks to control line feeds in your repo. You can also set up an
appveyor CI and have it run your repo on windows to try and find any windows
related issues sooner.
[https://github.com/checkstyle/checkstyle/blob/master/appveyor.yml#L51]
[~romani] take note of this for
[https://github.com/checkstyle/checkstyle/issues/6558]
> The IT fails MCHECKSTYLE-54 (Unix EOL files). Broken rule
> 'NewlineAtEndOfFile' on Windows.
> --
>
> Key: MCHECKSTYLE-376
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-376
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:check
>Reporter: Tibor Digana
>Assignee: Enrico Olivelli
>Priority: Major
> Attachments: linux.zip, windows.zip
>
>
> Afects version 3.1.0 during the release vote.
> It looks like the library expects system based EOL character.
> The checkstyle reports the issue in two files in
> https://github.com/apache/maven-checkstyle-plugin/tree/master/src/it/MCHECKSTYLE-54/src/main/java/org/apache/maven/plugins/checkstyle/mcheckstyle54
> I doubt it is a problem with these two files, nothing but the library itself.
> No idea why other ITs do not fail on Windows too.
> {noformat}
> mvn -nsu checkstyle:check
> [INFO] --- maven-checkstyle-plugin:3.1.1-SNAPSHOT:check (default-cli) @
> mcheckstyle-54 ---
> [INFO] There are 2 errors reported by Checkstyle 8.19 with sun_checks.xml
> ruleset.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\Mcheckstyle54.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [ERROR]
> src\main\java\org\apache\maven\plugins\checkstyle\mcheckstyle54\package-info.java:[1]
> (misc) NewlineAtEndOfFile: File does not end with a newline.
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 3.450 s
> [INFO] Finished at: 2019-05-13T23:42:55+02:00
> [INFO] Final Memory: 12M/193M
> [INFO]
>
> [ERROR] Failed to execute goal
> org.apache.maven.plugins:maven-checkstyle-plugin:3.1.1-SNAPSHOT:check
> (default-cli) on project mcheckstyle-54: You have 2 Checkstyle violations. ->
> [Help 1]
> [ERROR]
> [ERROR] To see the full stack trace of the errors, re-run Maven with the -e
> switch.
> [ERROR] Re-run Maven using the -X switch to enable full debug logging.
> [ERROR]
> [ERROR] For more information about the errors and possible solutions, please
> read the following articles:
> [ERROR] [Help 1]
> http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
> {noformat}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-342) Support XML 1.1
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16837638#comment-16837638 ] richard commented on MCHECKSTYLE-342: - [~eolivelli] this is not just a simple patch. The XML parser is another library and what I linked to was their master and was last updated in 2014, so there is no upgrade to go to and get around this. This seems like it requires a new XML parser and new code to connect the 2 together. If you had another parser in mind I could look into it. > Support XML 1.1 > --- > > Key: MCHECKSTYLE-342 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-342 > Project: Maven Checkstyle Plugin > Issue Type: New Feature > Components: checkstyle:check >Affects Versions: 2.17 >Reporter: richard >Assignee: Enrico Olivelli >Priority: Major > > Checkstyle wishes to upgrade our XML logger to print out XML 1.1 documents. > We need this functionality to support escaping non-printable characters as > XML 1.0 doesn't allow this and considers it an invalid document. > > Exception in thread "main" javax.xml.stream.XMLStreamException: ParseError > > at [row,col]:[45615,80] > > Message: An invalid XML character (Unicode: 0x2) was found in the value of > > attribute "message" and element is "error". > Checkstyle cannot upgrade until maven-checkstyle does as we use it in alot of > regression testing. If we try to give the plugin an XML 1.1 document, it > fails with the following error: > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) > > on project postgresql: Unable to read Checkstyle results xml: > > /pipeline/source/pgjdbc/pgjdbc/target/checkstyle-result.xml: only 1.0 is > > supported as > version="1.1"... @1:19) -> [Help 1] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-375) Upgrade all test XML doctypes
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-375?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835982#comment-16835982 ] richard commented on MCHECKSTYLE-375: - [~eolivelli] I started a PR. > Upgrade all test XML doctypes > - > > Key: MCHECKSTYLE-375 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-375 > Project: Maven Checkstyle Plugin > Issue Type: Improvement > Components: checkstyle:check, checkstyle:checkstyle >Affects Versions: 3.0.0 >Reporter: richard >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > The tests used to test maven-checkstyle are using old DTDs and unsecure > "http" locations. This is related to CVE-2019-9658. The security issue is in > the parser that is used to parse this file. It leaves any code that parses > this file vulnerable to XXE via a MITM. > > All doctypes used in maven-checkstyle repo (configurations, suppressions, > import controls, etc...) should be updated to use the latest URL and public > DOCTYPEs. > Example: > > "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN" > "https://checkstyle.org/dtds/configuration_1_3.dtd;> > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-342) Support XML 1.1
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16835958#comment-16835958 ] richard commented on MCHECKSTYLE-342: - [~eolivelli] it is still valid as far as I can tell. checkstyle cannot upgraded XML version because of this. See [https://github.com/sonatype/plexus-utils/blob/5ba6cfcca911200b5b9d2b313bb939e6d7cbbac6/src/main/java/org/codehaus/plexus/util/xml/pull/MXParser.java#L2662] which you are using to parse the XML at [https://github.com/apache/maven-checkstyle-plugin/blob/6abad1cb750244899c6e3b45a7a8bb49fba954db/src/main/java/org/apache/maven/plugins/checkstyle/CheckstyleViolationCheckMojo.java#L592] . > Support XML 1.1 > --- > > Key: MCHECKSTYLE-342 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-342 > Project: Maven Checkstyle Plugin > Issue Type: New Feature > Components: checkstyle:check >Affects Versions: 2.17 >Reporter: richard >Priority: Major > > Checkstyle wishes to upgrade our XML logger to print out XML 1.1 documents. > We need this functionality to support escaping non-printable characters as > XML 1.0 doesn't allow this and considers it an invalid document. > > Exception in thread "main" javax.xml.stream.XMLStreamException: ParseError > > at [row,col]:[45615,80] > > Message: An invalid XML character (Unicode: 0x2) was found in the value of > > attribute "message" and element is "error". > Checkstyle cannot upgrade until maven-checkstyle does as we use it in alot of > regression testing. If we try to give the plugin an XML 1.1 document, it > fails with the following error: > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) > > on project postgresql: Unable to read Checkstyle results xml: > > /pipeline/source/pgjdbc/pgjdbc/target/checkstyle-result.xml: only 1.0 is > > supported as > version="1.1"... @1:19) -> [Help 1] -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MCHECKSTYLE-375) Upgrade all test XML doctypes
richard created MCHECKSTYLE-375: --- Summary: Upgrade all test XML doctypes Key: MCHECKSTYLE-375 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-375 Project: Maven Checkstyle Plugin Issue Type: Improvement Components: checkstyle:check, checkstyle:checkstyle Affects Versions: 3.0.0 Reporter: richard The tests used to test maven-checkstyle are using old DTDs and unsecure "http" locations. This is related to CVE-2019-9658. The security issue is in the parser that is used to parse this file. It leaves any code that parses this file vulnerable to XXE via a MITM. All doctypes used in maven-checkstyle repo (configurations, suppressions, import controls, etc...) should be updated to use the latest URL and public DOCTYPEs. Example: https://checkstyle.org/dtds/configuration_1_3.dtd;> -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (MCHECKSTYLE-374) Replace deprecated methods in Checkstyle
richard created MCHECKSTYLE-374: --- Summary: Replace deprecated methods in Checkstyle Key: MCHECKSTYLE-374 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-374 Project: Maven Checkstyle Plugin Issue Type: Improvement Components: checkstyle:check, checkstyle:checkstyle Affects Versions: 3.0.0 Reporter: richard Since maven-checkstyle upgrade it's default version of checkstyle, the Checkstyle team is hoping that we can replace the use of deprecated methods. This replaces deprecated methods with their newer replacements. These methods have been deprecated since probably 8.2 but can't be removed from main repo because the plugin still uses them and this would break Checkstyle team's own CI which relies on the plugin. This change would break backward compatibility in the plugin as these methods only came around at 8.2. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-344) StringIndexOutOfBoundsException in RuleUtil
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16771087#comment-16771087
]
richard commented on MCHECKSTYLE-344:
-
Eolivelli responded in github PR and discussed doing a release sometime. They
are working on merging some other PRs.
https://github.com/apache/maven-checkstyle-plugin/pull/1#issuecomment-464564860
> StringIndexOutOfBoundsException in RuleUtil
> ---
>
> Key: MCHECKSTYLE-344
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-344
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:check
>Affects Versions: 2.17
>Reporter: fdvxxii
>Assignee: Guillaume Boué
>Priority: Major
> Fix For: 3.0.1
>
>
> {{RuleUtil}} has a bug at line 95:
> {code}
> final int end = eventSrcName.lastIndexOf('.');
> eventSrcName = eventSrcName.substring(0, end);
> {code}
> This code leads to a StringIndexOutOfBoundsException if the variable does not
> contain a period. I don't know if its a convention to have a period in that
> string, but either way the error message should me more expressive.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MCHECKSTYLE-344) StringIndexOutOfBoundsException in RuleUtil
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309744#comment-16309744
]
richard commented on MCHECKSTYLE-344:
-
We hit this as well in sevntu at
https://travis-ci.org/sevntu-checkstyle/sevntu.checkstyle/jobs/324422086 .
{noformat}
Caused by: java.lang.StringIndexOutOfBoundsException: String index out of
range: -1
at java.lang.String.substring (String.java:1967)
at org.apache.maven.plugin.checkstyle.RuleUtil.getCategory
(RuleUtil.java:95)
at
org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.countViolations
(CheckstyleViolationCheckMojo.java:651)
at org.apache.maven.plugin.checkstyle.CheckstyleViolationCheckMojo.execute
(CheckstyleViolationCheckMojo.java:576)
at org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
(DefaultBuildPluginManager.java:134)
{noformat}
This is the result of a change in the XML file in Checkstyle starting with
version 8.2 at https://github.com/checkstyle/checkstyle/issues/4607 .
By giving a module a unique id, we changed the XML file to print the id as the
source instead of the full class name. This is why maven plugin is expecting a
period in the source.
> StringIndexOutOfBoundsException in RuleUtil
> ---
>
> Key: MCHECKSTYLE-344
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-344
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:check
>Affects Versions: 2.17
>Reporter: fdvxxii
>
> {{RuleUtil}} has a bug at line 95:
> {code}
> final int end = eventSrcName.lastIndexOf('.');
> eventSrcName = eventSrcName.substring(0, end);
> {code}
> This code leads to a StringIndexOutOfBoundsException if the variable does not
> contain a period. I don't know if its a convention to have a period in that
> string, but either way the error message should me more expressive.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MCHECKSTYLE-346) Release a new version
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16309731#comment-16309731 ] richard commented on MCHECKSTYLE-346: - Robert Scholte Please release the plugin as it is now and let's close this issue. We will go from there by either opening new issues or pinging you on existing ones. Since we are new to the project, there will probably be questions we will be asking as we to try to help out. Thanks. > Release a new version > - > > Key: MCHECKSTYLE-346 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.17 > Environment: All >Reporter: richard >Priority: Blocker > > Hello, > Since my posts in another issue have gone unnoticed > (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this > one to bring it up front. > The main checkstyle community have been waiting years for a 2.18 release for > fixes and functionality needed. As it is now, we cannot remove old deprecated > code from our utility as the plugin relies on them too much and breaks if > they are removed which forces us to continue supporting them just for you. > See Issue: https://github.com/checkstyle/checkstyle/issues/2883 > The last release for maven checkstyle plugin was 2015, but you continue to > update the code base. Why is this? Is there something that prevents you from > creating a new release? Do you lack personnel of some kind? Is it possible to > give us a time table for a 2.18 release? > If things continue as they are now, we may begin looking into breaking > compatibility with the plugin in newer versions as this project seems to have > run stagnant and is lacking support. If compatibility is broken, the current > plugin released will then only work with old and outdated versions. I, and I > am sure the community, don't wish to see this happen but the checkstyle > utility needs to keep evolving and remove outdated code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MCHECKSTYLE-346) Release a new version
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16303058#comment-16303058 ] richard commented on MCHECKSTYLE-346: - As we have still not heard anything, we have started the process to break away from using maven-checkstyle-plugin in Checkstyle. Since it is the holiday season, we will wait until January before getting started. I suspect it may take us a month or so before we start incorporating serious backward breaking changes that will cause the plugin not to function with future versions of Checkstyle unless a new version of the maven plugin is released. Here are some of the referenced issues: https://github.com/checkstyle/contribution/issues/273 https://github.com/checkstyle/checkstyle/issues/5385 https://github.com/checkstyle/checkstyle/issues/5386 https://github.com/checkstyle/checkstyle/issues/2883 > Release a new version > - > > Key: MCHECKSTYLE-346 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346 > Project: Maven Checkstyle Plugin > Issue Type: Bug >Affects Versions: 2.17 > Environment: All >Reporter: richard >Priority: Blocker > > Hello, > Since my posts in another issue have gone unnoticed > (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this > one to bring it up front. > The main checkstyle community have been waiting years for a 2.18 release for > fixes and functionality needed. As it is now, we cannot remove old deprecated > code from our utility as the plugin relies on them too much and breaks if > they are removed which forces us to continue supporting them just for you. > See Issue: https://github.com/checkstyle/checkstyle/issues/2883 > The last release for maven checkstyle plugin was 2015, but you continue to > update the code base. Why is this? Is there something that prevents you from > creating a new release? Do you lack personnel of some kind? Is it possible to > give us a time table for a 2.18 release? > If things continue as they are now, we may begin looking into breaking > compatibility with the plugin in newer versions as this project seems to have > run stagnant and is lacking support. If compatibility is broken, the current > plugin released will then only work with old and outdated versions. I, and I > am sure the community, don't wish to see this happen but the checkstyle > utility needs to keep evolving and remove outdated code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (MCHECKSTYLE-346) Release a new version
richard created MCHECKSTYLE-346: --- Summary: Release a new version Key: MCHECKSTYLE-346 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-346 Project: Maven Checkstyle Plugin Issue Type: Bug Affects Versions: 2.17 Environment: All Reporter: richard Priority: Blocker Hello, Since my posts in another issue have gone unnoticed (https://issues.apache.org/jira/browse/MCHECKSTYLE-332), I am creating this one to bring it up front. The main checkstyle community have been waiting years for a 2.18 release for fixes and functionality needed. As it is now, we cannot remove old deprecated code from our utility as the plugin relies on them too much and breaks if they are removed which forces us to continue supporting them just for you. See Issue: https://github.com/checkstyle/checkstyle/issues/2883 The last release for maven checkstyle plugin was 2015, but you continue to update the code base. Why is this? Is there something that prevents you from creating a new release? Do you lack personnel of some kind? Is it possible to give us a time table for a 2.18 release? If things continue as they are now, we may begin looking into breaking compatibility with the plugin in newer versions as this project seems to have run stagnant and is lacking support. If compatibility is broken, the current plugin released will then only work with old and outdated versions. I, and I am sure the community, don't wish to see this happen but the checkstyle utility needs to keep evolving and remove outdated code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (MCHECKSTYLE-332) maven plugin not using cache property
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16278846#comment-16278846
]
richard commented on MCHECKSTYLE-332:
-
Is there a timetable when 2.18 will come out or are releases now abandoned for
this project? We have been waiting a year for this change.
Checkstyle cannot make backward breaking changes until the new version is
released. The old version will abend with the method in TreeWalker is removed
so we cannot remove it until the new version comes out.
See Issue: https://github.com/checkstyle/checkstyle/issues/2883
> maven plugin not using cache property
> -
>
> Key: MCHECKSTYLE-332
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-332
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 2.17
> Environment: Windows 7, 64 bit, JDK 8
>Reporter: richard
>Assignee: Guillaume Boué
> Fix For: 3.0.0
>
>
> When enabling cache in the pom for checkstyle via `cacheFile`, no cache file
> is ever created after the run and multiple runs are not using any cache as
> there is no speed up.
> POM:
> https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
> I am specifying the cache after line 472 with the following:
> bq. ${project.build.directory}/cachefile-sevntu
> When I specify the cache directly into the configuration file, the cache file
> is created, so this looks like an issue directly related to the maven plugin.
> I shouldn't need to specify it into the configuration since a property is
> available in the POM.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Updated] (MCHECKSTYLE-342) Support XML 1.1
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] richard updated MCHECKSTYLE-342: Description: Checkstyle wishes to upgrade our XML logger to print out XML 1.1 documents. We need this functionality to support escaping non-printable characters as XML 1.0 doesn't allow this and considers it an invalid document. > Exception in thread "main" javax.xml.stream.XMLStreamException: ParseError at > [row,col]:[45615,80] > Message: An invalid XML character (Unicode: 0x2) was found in the value of > attribute "message" and element is "error". Checkstyle cannot upgrade until maven-checkstyle does as we use it in alot of regression testing. If we try to give the plugin an XML 1.1 document, it fails with the following error: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) on > project postgresql: Unable to read Checkstyle results xml: > /pipeline/source/pgjdbc/pgjdbc/target/checkstyle-result.xml: only 1.0 is > supported as version="1.1"... @1:19) -> [Help 1] was: Checkstyle wishes to upgrade our XML logger to print out XML 1.1 documents. We need this functionality to support escaping non-printable characters as XML 1.0 doesn't allow this and considers it an invalid document. Exception in thread "main" javax.xml.stream.XMLStreamException: ParseError at [row,col]:[45615,80] Message: An invalid XML character (Unicode: 0x2) was found in the value of attribute "message" and element is "error". Checkstyle cannot upgrade until maven-checkstyle does as we use it in alot of regression testing. If we try to give the plugin an XML 1.1 document, it fails with the following error: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) on > project postgresql: Unable to read Checkstyle results xml: > /pipeline/source/pgjdbc/pgjdbc/target/checkstyle-result.xml: only 1.0 is > supported as version="1.1"... @1:19) -> [Help 1] > Support XML 1.1 > --- > > Key: MCHECKSTYLE-342 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-342 > Project: Maven Checkstyle Plugin > Issue Type: New Feature > Components: checkstyle:check >Affects Versions: 2.17 >Reporter: richard > > Checkstyle wishes to upgrade our XML logger to print out XML 1.1 documents. > We need this functionality to support escaping non-printable characters as > XML 1.0 doesn't allow this and considers it an invalid document. > > Exception in thread "main" javax.xml.stream.XMLStreamException: ParseError > > at [row,col]:[45615,80] > > Message: An invalid XML character (Unicode: 0x2) was found in the value of > > attribute "message" and element is "error". > Checkstyle cannot upgrade until maven-checkstyle does as we use it in alot of > regression testing. If we try to give the plugin an XML 1.1 document, it > fails with the following error: > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) > > on project postgresql: Unable to read Checkstyle results xml: > > /pipeline/source/pgjdbc/pgjdbc/target/checkstyle-result.xml: only 1.0 is > > supported as > version="1.1"... @1:19) -> [Help 1] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (MCHECKSTYLE-342) Support XML 1.1
richard created MCHECKSTYLE-342: --- Summary: Support XML 1.1 Key: MCHECKSTYLE-342 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-342 Project: Maven Checkstyle Plugin Issue Type: New Feature Components: checkstyle:check Affects Versions: 2.17 Reporter: richard Checkstyle wishes to upgrade our XML logger to print out XML 1.1 documents. We need this functionality to support escaping non-printable characters as XML 1.0 doesn't allow this and considers it an invalid document. > Exception in thread "main" javax.xml.stream.XMLStreamException: ParseError at > [row,col]:[45615,80] > Message: An invalid XML character (Unicode: 0x2) was found in the value of > attribute "message" and element is "error". Checkstyle cannot upgrade until maven-checkstyle does as we use it in alot of regression testing. If we try to give the plugin an XML 1.1 document, it fails with the following error: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) on > project postgresql: Unable to read Checkstyle results xml: > /pipeline/source/pgjdbc/pgjdbc/target/checkstyle-result.xml: only 1.0 is > supported as version="1.1"... @1:19) -> [Help 1] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Updated] (MCHECKSTYLE-342) Support XML 1.1
[ https://issues.apache.org/jira/browse/MCHECKSTYLE-342?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] richard updated MCHECKSTYLE-342: Description: Checkstyle wishes to upgrade our XML logger to print out XML 1.1 documents. We need this functionality to support escaping non-printable characters as XML 1.0 doesn't allow this and considers it an invalid document. Exception in thread "main" javax.xml.stream.XMLStreamException: ParseError at [row,col]:[45615,80] Message: An invalid XML character (Unicode: 0x2) was found in the value of attribute "message" and element is "error". Checkstyle cannot upgrade until maven-checkstyle does as we use it in alot of regression testing. If we try to give the plugin an XML 1.1 document, it fails with the following error: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) on > project postgresql: Unable to read Checkstyle results xml: > /pipeline/source/pgjdbc/pgjdbc/target/checkstyle-result.xml: only 1.0 is > supported as version="1.1"... @1:19) -> [Help 1] was: Checkstyle wishes to upgrade our XML logger to print out XML 1.1 documents. We need this functionality to support escaping non-printable characters as XML 1.0 doesn't allow this and considers it an invalid document. > Exception in thread "main" javax.xml.stream.XMLStreamException: ParseError at > [row,col]:[45615,80] > Message: An invalid XML character (Unicode: 0x2) was found in the value of > attribute "message" and element is "error". Checkstyle cannot upgrade until maven-checkstyle does as we use it in alot of regression testing. If we try to give the plugin an XML 1.1 document, it fails with the following error: > [ERROR] Failed to execute goal > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) on > project postgresql: Unable to read Checkstyle results xml: > /pipeline/source/pgjdbc/pgjdbc/target/checkstyle-result.xml: only 1.0 is > supported as version="1.1"... @1:19) -> [Help 1] > Support XML 1.1 > --- > > Key: MCHECKSTYLE-342 > URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-342 > Project: Maven Checkstyle Plugin > Issue Type: New Feature > Components: checkstyle:check >Affects Versions: 2.17 >Reporter: richard > > Checkstyle wishes to upgrade our XML logger to print out XML 1.1 documents. > We need this functionality to support escaping non-printable characters as > XML 1.0 doesn't allow this and considers it an invalid document. > Exception in thread "main" javax.xml.stream.XMLStreamException: ParseError at > [row,col]:[45615,80] > Message: An invalid XML character (Unicode: 0x2) was found in the value of > attribute "message" and element is "error". > Checkstyle cannot upgrade until maven-checkstyle does as we use it in alot of > regression testing. If we try to give the plugin an XML 1.1 document, it > fails with the following error: > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-checkstyle-plugin:2.17:check (default-cli) > > on project postgresql: Unable to read Checkstyle results xml: > > /pipeline/source/pgjdbc/pgjdbc/target/checkstyle-result.xml: only 1.0 is > > supported as > version="1.1"... @1:19) -> [Help 1] -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Created] (MCHECKSTYLE-338) Add support for 'omitIgnoredModules'
richard created MCHECKSTYLE-338: --- Summary: Add support for 'omitIgnoredModules' Key: MCHECKSTYLE-338 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-338 Project: Maven Checkstyle Plugin Issue Type: Improvement Components: checkstyle:check Affects Versions: 2.17 Environment: Windows 7, 64 bit Reporter: richard Checkstyle has an option in it's ant process that allows users to avoid executing modules that have a severity set to ignore. It is called `omitIgnoredModules`. It has been in checkstyle already for atleast 2 years. See: https://github.com/checkstyle/checkstyle/blob/2f3f4b76f04f0b5071abcaed54648a49a0db3160/src/main/java/com/puppycrawl/tools/checkstyle/ant/CheckstyleAntTask.java#L118 https://github.com/checkstyle/checkstyle/blob/2f3f4b76f04f0b5071abcaed54648a49a0db3160/src/main/java/com/puppycrawl/tools/checkstyle/ant/CheckstyleAntTask.java#L424-L428 We are in the process of adding this option to our CLI (https://github.com/checkstyle/checkstyle/issues/3566) and would like to see maven-checkstyle-plugin support this feature so users can customize it. A simple tag for this option like: `false` would be enough. Thanks. -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (MCHECKSTYLE-332) maven plugin not using cache property
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681518#comment-15681518
]
richard commented on MCHECKSTYLE-332:
-
When is 2.18 due out? It looks like 2.17 was back in 2015-10-15.
> maven plugin not using cache property
> -
>
> Key: MCHECKSTYLE-332
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-332
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 2.17
> Environment: Windows 7, 64 bit, JDK 8
>Reporter: richard
>Assignee: Guillaume Boué
> Fix For: 2.18
>
>
> When enabling cache in the pom for checkstyle via `cacheFile`, no cache file
> is ever created after the run and multiple runs are not using any cache as
> there is no speed up.
> POM:
> https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
> I am specifying the cache after line 472 with the following:
> bq. ${project.build.directory}/cachefile-sevntu
> When I specify the cache directly into the configuration file, the cache file
> is created, so this looks like an issue directly related to the maven plugin.
> I shouldn't need to specify it into the configuration since a property is
> available in the POM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-332) maven plugin not using cache property
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15681250#comment-15681250
]
richard commented on MCHECKSTYLE-332:
-
It should be noted that in Checkstyle 8, we will be completely removing that
property in TreeWalker.
https://github.com/checkstyle/checkstyle/issues/2883
> maven plugin not using cache property
> -
>
> Key: MCHECKSTYLE-332
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-332
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 2.17
> Environment: Windows 7, 64 bit, JDK 8
>Reporter: richard
>
> When enabling cache in the pom for checkstyle via `cacheFile`, no cache file
> is ever created after the run and multiple runs are not using any cache as
> there is no speed up.
> POM:
> https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
> I am specifying the cache after line 472 with the following:
> bq. ${project.build.directory}/cachefile-sevntu
> When I specify the cache directly into the configuration file, the cache file
> is created, so this looks like an issue directly related to the maven plugin.
> I shouldn't need to specify it into the configuration since a property is
> available in the POM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Comment Edited] (MCHECKSTYLE-332) maven plugin not using cache property
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15680404#comment-15680404
]
richard edited comment on MCHECKSTYLE-332 at 11/20/16 4:27 AM:
---
Here is a working example:
https://github.com/rnveach/checkstyle/blob/MCHECKSTYLE-332/pom.xml#L473
After running 'mvn checkstyle:checkstyle' or even 'mvn verify', I am expecting
to see the cache file 'cachefile-sevntu' directly inside 'target'.
It doesn't appear after maven completes successfully.
was (Author: rveach):
Here is a working example:
https://github.com/rnveach/checkstyle/blob/MCHECKSTYLE-332/pom.xml#L473
After running 'mvn checkstyle:checkstyle', I am expecting to see the cache file
'cachefile-sevntu' directly inside 'target'.
It doesn't appear after maven completes successfully.
> maven plugin not using cache property
> -
>
> Key: MCHECKSTYLE-332
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-332
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 2.17
> Environment: Windows 7, 64 bit, JDK 8
>Reporter: richard
>
> When enabling cache in the pom for checkstyle via `cacheFile`, no cache file
> is ever created after the run and multiple runs are not using any cache as
> there is no speed up.
> POM:
> https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
> I am specifying the cache after line 472 with the following:
> bq. ${project.build.directory}/cachefile-sevntu
> When I specify the cache directly into the configuration file, the cache file
> is created, so this looks like an issue directly related to the maven plugin.
> I shouldn't need to specify it into the configuration since a property is
> available in the POM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-332) maven plugin not using cache property
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15680404#comment-15680404
]
richard commented on MCHECKSTYLE-332:
-
Here is a working example:
https://github.com/rnveach/checkstyle/blob/MCHECKSTYLE-332/pom.xml#L473
After running 'mvn checkstyle:checkstyle', I am expecting to see the cache file
'cachefile-sevntu' directly inside 'target'.
It doesn't appear after maven completes successfully.
> maven plugin not using cache property
> -
>
> Key: MCHECKSTYLE-332
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-332
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 2.17
> Environment: Windows 7, 64 bit, JDK 8
>Reporter: richard
>
> When enabling cache in the pom for checkstyle via `cacheFile`, no cache file
> is ever created after the run and multiple runs are not using any cache as
> there is no speed up.
> POM:
> https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
> I am specifying the cache after line 472 with the following:
> bq. ${project.build.directory}/cachefile-sevntu
> When I specify the cache directly into the configuration file, the cache file
> is created, so this looks like an issue directly related to the maven plugin.
> I shouldn't need to specify it into the configuration since a property is
> available in the POM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MCHECKSTYLE-332) maven plugin not using cache property
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
richard updated MCHECKSTYLE-332:
Description:
When enabling cache in the pom for checkstyle via `cacheFile`, no cache file is
ever created after the run and multiple runs are not using any cache as there
is no speed up.
POM:
https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
I am specifying the cache after line 472 with the following:
bq. ${project.build.directory}/cachefile-sevntu
When I specify the cache directly into the configuration file, the cache file
is created, so this looks like an issue directly related to the maven plugin.
I shouldn't need to specify it into the configuration since a property is
available in the POM.
was:
When enabling cache in the pom for checkstyle via `cacheFile`, no cache file is
ever created after the run and multiple runs are not using any cache as there
is no speed up.
POM:
https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
I am specifying the cache after line 472 with the following:
bq. ${project.build.directory}/cachefile-sevntu
When I specify the cache directly into the configuration file, the file is
created, so this looks like an issue directly related to the maven plugin.
I shouldn't need to specify it into the configuration since a property is
available in the POM.
> maven plugin not using cache property
> -
>
> Key: MCHECKSTYLE-332
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-332
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 2.17
> Environment: Windows 7, 64 bit, JDK 8
>Reporter: richard
>
> When enabling cache in the pom for checkstyle via `cacheFile`, no cache file
> is ever created after the run and multiple runs are not using any cache as
> there is no speed up.
> POM:
> https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
> I am specifying the cache after line 472 with the following:
> bq. ${project.build.directory}/cachefile-sevntu
> When I specify the cache directly into the configuration file, the cache file
> is created, so this looks like an issue directly related to the maven plugin.
> I shouldn't need to specify it into the configuration since a property is
> available in the POM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MCHECKSTYLE-332) maven plugin not using cache property
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-332?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
richard updated MCHECKSTYLE-332:
Description:
When enabling cache in the pom for checkstyle via `cacheFile`, no cache file is
ever created after the run and multiple runs are not using any cache as there
is no speed up.
POM:
https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
I am specifying the cache after line 472 with the following:
bq. ${project.build.directory}/cachefile-sevntu
When I specify the cache directly into the configuration file, the file is
created, so this looks like an issue directly related to the maven plugin.
I shouldn't need to specify it into the configuration since a property is
available in the POM.
was:
When enabling cache in the pom for checkstyle via `cacheFile`, no cache file is
ever created after the run and multiple runs are not using any cache as there
is no speed up.
POM:
https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
I am specifying the cache after line 472 with the following:
`${project.build.directory}/cachefile-sevntu`
When I specify the cache directly into the configuration file, the file is
created, so this looks like an issue directly related to the maven plugin.
I shouldn't need to specify it into the configuration since a property is
available in the POM.
> maven plugin not using cache property
> -
>
> Key: MCHECKSTYLE-332
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-332
> Project: Maven Checkstyle Plugin
> Issue Type: Bug
> Components: checkstyle:checkstyle
>Affects Versions: 2.17
> Environment: Windows 7, 64 bit, JDK 8
>Reporter: richard
>
> When enabling cache in the pom for checkstyle via `cacheFile`, no cache file
> is ever created after the run and multiple runs are not using any cache as
> there is no speed up.
> POM:
> https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
> I am specifying the cache after line 472 with the following:
> bq. ${project.build.directory}/cachefile-sevntu
> When I specify the cache directly into the configuration file, the file is
> created, so this looks like an issue directly related to the maven plugin.
> I shouldn't need to specify it into the configuration since a property is
> available in the POM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MCHECKSTYLE-332) maven plugin not using cache property
richard created MCHECKSTYLE-332:
---
Summary: maven plugin not using cache property
Key: MCHECKSTYLE-332
URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-332
Project: Maven Checkstyle Plugin
Issue Type: Bug
Components: checkstyle:checkstyle
Affects Versions: 2.17
Environment: Windows 7, 64 bit, JDK 8
Reporter: richard
When enabling cache in the pom for checkstyle via `cacheFile`, no cache file is
ever created after the run and multiple runs are not using any cache as there
is no speed up.
POM:
https://github.com/checkstyle/checkstyle/blob/481406f2d5c07b8766757eb45bcc15fd1fa51bed/pom.xml#L453-L492
I am specifying the cache after line 472 with the following:
`${project.build.directory}/cachefile-sevntu`
When I specify the cache directly into the configuration file, the file is
created, so this looks like an issue directly related to the maven plugin.
I shouldn't need to specify it into the configuration since a property is
available in the POM.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MCHECKSTYLE-308) Include config in checkstyle site results
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14742207#comment-14742207
]
richard commented on MCHECKSTYLE-308:
-
{quote}how do you expect to render that information?{quote}
My opinion would be to have the ruleset path on the top of "checkstyle.html" be
a link to the XML document. Just like it does for the java code in the xref
directory, the XML view will just be pure text with line numbers on the left
side.
The XML view could be fancier, like the "Rules" section on "checkstyle.html",
but I still think a raw view needs to be available, but again thats just me.
> Include config in checkstyle site results
> -
>
> Key: MCHECKSTYLE-308
> URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-308
> Project: Maven Checkstyle Plugin
> Issue Type: Improvement
> Components: checkstyle:checkstyle
>Affects Versions: 2.16
> Environment: Windows 7, Eclipse Kepler SR2
>Reporter: richard
>Priority: Minor
>
> When running "mvn site" to create a checkstyle report of code, it includes
> the file location of the configuration file it is running with, but it
> doesn't include the physical configuration in the report.
> Example: http://rnveach.github.io/checkstyle/checkstyle.html
> "The following document contains the results of Checkstyle 6.11-SNAPSHOT with
> D:\Rickys\Java\checkstyleWorkspaceEclipse\contribution\checkstyle-tester\my_check.xml
> ruleset."
> When showing this report to others as a proof of some fix, especially over
> the internet, it would be worth it to include the configuration in the
> reports to verify that they are using the correct checks and to be able to
> reproduce any warning/errors they have with their code.
> To the viewers of the report, a mis-configured configuration file can look
> the same as a properly configured one with no errors/warnings.
> It is also possible to use a local configuration on the hard drive, instead
> of a global one, which will hide the settings of the configuration and not
> provide a visualization of its contents at the time the report was run.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MCHECKSTYLE-308) Include config in checkstyle site results
richard created MCHECKSTYLE-308: --- Summary: Include config in checkstyle site results Key: MCHECKSTYLE-308 URL: https://issues.apache.org/jira/browse/MCHECKSTYLE-308 Project: Maven Checkstyle Plugin Issue Type: Improvement Components: checkstyle:checkstyle Affects Versions: 2.16 Environment: Windows 7, Eclipse Kepler SR2 Reporter: richard Priority: Minor When running "mvn site" to create a checkstyle report of code, it includes the file location of the configuration file it is running with, but it doesn't include the physical configuration in the report. Example: http://rnveach.github.io/checkstyle/checkstyle.html "The following document contains the results of Checkstyle 6.11-SNAPSHOT with D:\Rickys\Java\checkstyleWorkspaceEclipse\contribution\checkstyle-tester\my_check.xml ruleset." When showing this report to others as a proof of some fix, especially over the internet, it would be worth it to include the configuration in the reports to verify that they are using the correct checks and to be able to reproduce any warning/errors they have with their code. To the viewers of the report, a mis-configured configuration file can look the same as a properly configured one with no errors/warnings. It is also possible to use a local configuration on the hard drive, instead of a global one, which will hide the settings of the configuration and not provide a visualization of its contents at the time the report was run. -- This message was sent by Atlassian JIRA (v6.3.4#6332)
[jira] Closed: (MAVEN-1788) maven war reports unsatisfied dependency with some jars even though those jars are in the local repository.
[ http://jira.codehaus.org/browse/MAVEN-1788?page=all ] Charles Richard closed MAVEN-1788. -- Resolution: Fixed Found the issue. Didn't realize the repository would be created at $HOME/.maven and the dependencies were missing at this path. Sorry. maven war reports unsatisfied dependency with some jars even though those jars are in the local repository. --- Key: MAVEN-1788 URL: http://jira.codehaus.org/browse/MAVEN-1788 Project: Maven Issue Type: Bug Components: core Affects Versions: 1.0.2 Environment: Solaris 10 Reporter: Charles Richard I was trying to get scarab to build and it's probably something i did but there was like 7 jar files that were given in a list of unsatisfied dependencies when i ran maven war -Dmaven.test.skip. I copied those jar files in the local repository and i'm still getting the same error. I get a download error with mode=online because those jars don't exist in ibiblio and i get the same error with mode.online=false which truely baffles me and leaves me wanting to bang my head on something :) My understanding is that Maven should be checking the local repository first to see if those jars are there, isn't this correct? The kicker is it doesn't seem to complain about other jars in the project.xml file. Thanks, Charles -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (MAVEN-1788) maven war reports unsatisfied dependency with some jars even though those jars are in the local repository.
maven war reports unsatisfied dependency with some jars even though those jars are in the local repository. --- Key: MAVEN-1788 URL: http://jira.codehaus.org/browse/MAVEN-1788 Project: Maven Issue Type: Bug Components: core Affects Versions: 1.0.2 Environment: Solaris 10 Reporter: Charles Richard I was trying to get scarab to build and it's probably something i did but there was like 7 jar files that were given in a list of unsatisfied dependencies when i ran maven war -Dmaven.test.skip. I copied those jar files in the local repository and i'm still getting the same error. I get a download error with mode=online because those jars don't exist in ibiblio and i get the same error with mode.online=false which truely baffles me and leaves me wanting to bang my head on something :) My understanding is that Maven should be checking the local repository first to see if those jars are there, isn't this correct? The kicker is it doesn't seem to complain about other jars in the project.xml file. Thanks, Charles -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Created: (SCM-222) Exception while executing CMS command while anonymous
Exception while executing CMS command while anonymous - Key: SCM-222 URL: http://jira.codehaus.org/browse/SCM-222 Project: Maven SCM Issue Type: Bug Components: maven-scm-provider-svn Affects Versions: 1.0-beta-2 Environment: Solaris 10, SunFire V100 Reporter: Charles Richard Priority: Minor I'm new to the following technologies so i imagine this is more of a user problem (ie me) but i can't seem to get around it: I've got Maven 1.0.2 and got the maven-scm-plugin version 1.6. When i execute the following command line to checkout a project as anonymous: maven scm:checkout -Dmaven.scm.url=scm:svn:http://my_ip/svn/portal_name/trunk I get an error Exception while executing SCM command. I noticed under CVS that somebody said that the path to CVS should be set but i'd like to think that having the scm plugin under Maven would be enough and that Subversion (SVN) would not need to be installed. Charles -- This message is automatically generated by JIRA. - If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa - For more information on JIRA, see: http://www.atlassian.com/software/jira
