Re: [PR] [MDEP-799] Add simple info json format for tree and cleanups [maven-dependency-plugin]
slawekjaranowski commented on code in PR #398:
URL:
https://github.com/apache/maven-dependency-plugin/pull/398#discussion_r1620690851
##
src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java:
##
@@ -86,30 +84,6 @@ public class TreeMojo extends AbstractMojo {
@Parameter(property = "outputEncoding", defaultValue =
"${project.reporting.outputEncoding}")
private String outputEncoding;
-/**
- * Contains the full list of projects in the reactor.
- */
-@Parameter(defaultValue = "${reactorProjects}", readonly = true, required
= true)
Review Comment:
no problem ... like unused variables are
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Publish maven 4.0.0-beta-3 schemas [maven-site]
gnodet opened a new pull request, #535: URL: https://github.com/apache/maven-site/pull/535 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.plugins:maven-enforcer-plugin from 3.4.1 to 3.5.0 [maven-pdf-plugin]
dependabot[bot] opened a new pull request, #54: URL: https://github.com/apache/maven-pdf-plugin/pull/54 Bumps [org.apache.maven.plugins:maven-enforcer-plugin](https://github.com/apache/maven-enforcer) from 3.4.1 to 3.5.0. Release notes Sourced from https://github.com/apache/maven-enforcer/releases;>org.apache.maven.plugins:maven-enforcer-plugin's releases. 3.5.0 New features and improvements https://issues.apache.org/jira/browse/MENFORCER-497;>[MENFORCER-497] - Require Maven 3.6.3+ (https://redirect.github.com/apache/maven-enforcer/pull/317;>#317) https://github.com/slawekjaranowski;>@slawekjaranowski https://issues.apache.org/jira/browse/MENFORCER-494;>[MENFORCER-494] - Allow banning dynamic versions in whole tree (https://redirect.github.com/apache/maven-enforcer/pull/294;>#294) https://github.com/JimmyAx;>@JimmyAx https://issues.apache.org/jira/browse/MENFORCER-500;>[MENFORCER-500] - New rule to enforce that Maven coordinates match given (https://redirect.github.com/apache/maven-enforcer/pull/309;>#309) https://github.com/kwin;>@kwin Bug Fixes https://issues.apache.org/jira/browse/MENFORCER-503;>[MENFORCER-503] - Pass context to ProfileActivator - fix NPE in Maven 3.9.7 (https://redirect.github.com/apache/maven-enforcer/pull/315;>#315) https://github.com/slawekjaranowski;>@slawekjaranowski Dependency updates https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-io:commons-io from 2.16.0 to 2.16.1 (https://redirect.github.com/apache/maven-enforcer/pull/311;>#311) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-codec:commons-codec from 1.16.1 to 1.17.0 (https://redirect.github.com/apache/maven-enforcer/pull/312;>#312) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-504;>[MENFORCER-504] - Bump org.apache.maven:maven-parent from 41 to 42 (https://redirect.github.com/apache/maven-enforcer/pull/314;>#314) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump org.apache.commons:commons-lang3 from 3.13.0 to 3.14.0 (https://redirect.github.com/apache/maven-enforcer/pull/298;>#298) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-codec:commons-codec from 1.16.0 to 1.16.1 (https://redirect.github.com/apache/maven-enforcer/pull/305;>#305) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-501;>[MENFORCER-501] - Bump commons-io:commons-io from 2.13.0 to 2.16.0 (https://redirect.github.com/apache/maven-enforcer/pull/310;>#310) https://github.com/dependabot;>@dependabot Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 in /maven-enforcer-plugin/src/it/projects/dependency-convergence_transitive_provided/module1 (https://redirect.github.com/apache/maven-enforcer/pull/307;>#307) https://github.com/dependabot;>@dependabot Bump apache/maven-gh-actions-shared from 3 to 4 (https://redirect.github.com/apache/maven-enforcer/pull/308;>#308) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-498;>[MENFORCER-498] - Update parent pom to 41 (https://redirect.github.com/apache/maven-enforcer/pull/306;>#306) https://github.com/slachiewicz;>@slachiewicz Bump org.junit:junit-bom from 5.10.1 to 5.10.2 (https://redirect.github.com/apache/maven-enforcer/pull/303;>#303) https://github.com/dependabot;>@dependabot Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 (https://redirect.github.com/apache/maven-enforcer/pull/301;>#301) https://github.com/dependabot;>@dependabot Bump org.codehaus.mojo:mrm-maven-plugin from 1.5.0 to 1.6.0 (https://redirect.github.com/apache/maven-enforcer/pull/295;>#295) https://github.com/dependabot;>@dependabot Bump org.junit:junit-bom from 5.10.0 to 5.10.1 (https://redirect.github.com/apache/maven-enforcer/pull/296;>#296) https://github.com/dependabot;>@dependabot https://issues.apache.org/jira/browse/MENFORCER-492;>[MENFORCER-492] - Bump plexus-utils from 3.5.1 to 4.0.0 and plexus-xml 3.0.0 (https://redirect.github.com/apache/maven-enforcer/pull/291;>#291) https://github.com/slawekjaranowski;>@slawekjaranowski Bump org.xerial.snappy:snappy-java from 1.1.10.1 to 1.1.10.4 in /maven-enforcer-plugin/src/it/projects/dependency-convergence_transitive_provided/module1 (https://redirect.github.com/apache/maven-enforcer/pull/292;>#292) https://github.com/dependabot;>@dependabot Maintenance https://issues.apache.org/jira/browse/MENFORCER-490;>[MENFORCER-490] - Remove unused dependency (https://redirect.github.com/apache/maven-enforcer/pull/316;>#316) https://github.com/elharo;>@elharo Bump org.apache.commons:commons-compress from 1.21 to 1.26.0 in
Re: [PR] [MDEP-799] Add simple info json format for tree and cleanups [maven-dependency-plugin]
elharo commented on code in PR #398:
URL:
https://github.com/apache/maven-dependency-plugin/pull/398#discussion_r1620629551
##
src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java:
##
@@ -86,30 +84,6 @@ public class TreeMojo extends AbstractMojo {
@Parameter(property = "outputEncoding", defaultValue =
"${project.reporting.outputEncoding}")
private String outputEncoding;
-/**
- * Contains the full list of projects in the reactor.
- */
-@Parameter(defaultValue = "${reactorProjects}", readonly = true, required
= true)
Review Comment:
does this cause problems for existing projects that set these?
##
src/main/java/org/apache/maven/plugins/dependency/tree/TreeMojo.java:
##
@@ -133,7 +107,8 @@ public class TreeMojo extends AbstractMojo {
/**
* If specified, this parameter will cause the dependency tree to be
written using the specified format. Currently
- * supported format are: text (default), dot,
graphml and tgf.
+ * supported format are: text (default), dot,
graphml, tgf
Review Comment:
format --> formats
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] [MDEP-799] Add simple info json format for tree and cleanups [maven-dependency-plugin]
slawekjaranowski opened a new pull request, #398: URL: https://github.com/apache/maven-dependency-plugin/pull/398 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-dependency-tree]
dependabot[bot] commented on PR #46: URL: https://github.com/apache/maven-dependency-tree/pull/46#issuecomment-2139052011 OK, I won't notify you about any of these dependencies again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump mavenVersion from 3.6.3 to 3.9.7 [maven-dependency-tree]
dependabot[bot] commented on PR #47: URL: https://github.com/apache/maven-dependency-tree/pull/47#issuecomment-2139053029 OK, I won't notify you about any of these dependencies again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump mavenVersion from 3.6.3 to 3.9.7 [maven-dependency-tree]
dependabot[bot] closed pull request #47: Bump mavenVersion from 3.6.3 to 3.9.7 URL: https://github.com/apache/maven-dependency-tree/pull/47 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump mavenVersion from 3.6.3 to 3.9.7 [maven-dependency-tree]
slawekjaranowski commented on PR #47: URL: https://github.com/apache/maven-dependency-tree/pull/47#issuecomment-2139052874 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-dependency-tree]
dependabot[bot] closed pull request #46: Bump resolverVersion from 1.4.1 to 1.9.20 URL: https://github.com/apache/maven-dependency-tree/pull/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-dependency-tree]
slawekjaranowski commented on PR #46: URL: https://github.com/apache/maven-dependency-tree/pull/46#issuecomment-2139051837 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MDEP-920] Bump org.assertj:assertj-core from 3.25.3 to 3.26.0 [maven-dependency-plugin]
slawekjaranowski merged PR #395: URL: https://github.com/apache/maven-dependency-plugin/pull/395 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Use Maven 3.9.7, m-wrapper-p 3.3.2 for build [maven-gh-actions-shared]
slawekjaranowski merged PR #102: URL: https://github.com/apache/maven-gh-actions-shared/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1406] Upgrade to Parent 42 and Maven 3.6.3 [maven-shared-jar]
slawekjaranowski commented on code in PR #39: URL: https://github.com/apache/maven-shared-jar/pull/39#discussion_r1619461788 ## pom.xml: ## @@ -56,7 +56,7 @@ 8 -3.2.5 +3.6.3 1.7.36 2023-04-15T15:52:39Z 5.10.2 Review Comment: We can drop `junitVersion` - we have dependencyManagement in parent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPIR-457] Upgrade to Parent 42 and Maven 3.6.3 [maven-project-info-reports-plugin]
michael-o commented on code in PR #66: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/66#discussion_r1620152407 ## pom.xml: ## @@ -184,7 +177,7 @@ under the License. org.apache.maven.shared maven-dependency-tree - 3.2.1 + 3.3.0 Review Comment: Yes, i know, but that is a separate issue and I have no clue how to do that. I'd appreciate a PR for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] typo: "add a the" becomes "add the" [maven]
triceo opened a new pull request, #1543: URL: https://github.com/apache/maven/pull/1543 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MNG-XXX] SUMMARY`, where you replace `MNG-XXX` and `SUMMARY` with the appropriate JIRA issue. - [ ] Also format the first line of the commit message like `[MNG-XXX] SUMMARY`. Best practice is to use the JIRA issue title in both the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the [Core IT][core-its] successfully. If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). [core-its]: https://maven.apache.org/core-its/core-it-suite/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPIR-457] Upgrade to Parent 42 and Maven 3.6.3 [maven-project-info-reports-plugin]
slawekjaranowski commented on code in PR #66: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/66#discussion_r1620118429 ## pom.xml: ## @@ -184,7 +177,7 @@ under the License. org.apache.maven.shared maven-dependency-tree - 3.2.1 + 3.3.0 Review Comment: We should drop it and use Resolver ... but can be done as separate issue -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MDEP-710] re-enable test in TestTreeMojo [maven-dependency-plugin]
slawekjaranowski merged PR #396: URL: https://github.com/apache/maven-dependency-plugin/pull/396 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Directory, not folder [maven-surefire]
michael-o merged PR #740: URL: https://github.com/apache/maven-surefire/pull/740 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2244] Make IT for SUREFIRE-1295 reliable [maven-surefire]
michael-o merged PR #741: URL: https://github.com/apache/maven-surefire/pull/741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [SUREFIRE-2244] Make IT for SUREFIRE-1295 reliable [maven-surefire]
michael-o merged PR #741: URL: https://github.com/apache/maven-surefire/pull/741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.shared:maven-dependency-tree from 3.2.1 to 3.3.0 [maven-dependency-plugin]
dependabot[bot] opened a new pull request, #397: URL: https://github.com/apache/maven-dependency-plugin/pull/397 Bumps [org.apache.maven.shared:maven-dependency-tree](https://github.com/apache/maven-dependency-tree) from 3.2.1 to 3.3.0. Commits https://github.com/apache/maven-dependency-tree/commit/7ea746c6336ec25d0335d86f14a4090747e26016;>7ea746c [maven-release-plugin] prepare release maven-dependency-tree-3.3.0 https://github.com/apache/maven-dependency-tree/commit/5bfb93c8f4b407e7c77137a41f7314d4dcfaee43;>5bfb93c [MSHARED-1405] Upgrade to Maven 3.6.3 https://github.com/apache/maven-dependency-tree/commit/fdde8ff86d4932788798da0e53555bdeb975d69c;>fdde8ff [MSHARED-1400] Bump org.apache.maven.shared:maven-shared-components from 41 t... https://github.com/apache/maven-dependency-tree/commit/3b78a1d722ef5c20af1b766399e75cc8311733b0;>3b78a1d Bump apache/maven-gh-actions-shared from 3 to 4 https://github.com/apache/maven-dependency-tree/commit/f1298657768f605d50df663bcac990e9d05b5670;>f129865 Bump org.junit.jupiter:junit-jupiter-api from 5.10.1 to 5.10.2 https://github.com/apache/maven-dependency-tree/commit/415ede6a9545c7ba2983a39d4ec85e1603aa11bf;>415ede6 Bump org.apache.maven.shared:maven-shared-components from 40 to 41 (https://redirect.github.com/apache/maven-dependency-tree/issues/42;>#42) https://github.com/apache/maven-dependency-tree/commit/f41424dae6cb1321191d8fd502cf2c454d1497c9;>f41424d Bump org.junit.jupiter:junit-jupiter-api from 5.10.0 to 5.10.1 https://github.com/apache/maven-dependency-tree/commit/b2923d2f0dd6241ceae7244086c4d5e4df7ed326;>b2923d2 [MSHARED-1333] - Upgrade maven-shared-components to version 40 https://github.com/apache/maven-dependency-tree/commit/1a6b6f12d8d1909354382304d4771216b67bc7f1;>1a6b6f1 Bump org.junit.jupiter:junit-jupiter-api from 5.9.3 to 5.10.0 https://github.com/apache/maven-dependency-tree/commit/6c1bff3247891dcd64ec4daf3b33dcbb9159ef0d;>6c1bff3 [MSHARED-1286]: Display if dependency is optional in tree Additional commits viewable in https://github.com/apache/maven-dependency-tree/compare/maven-dependency-tree-3.2.1...maven-dependency-tree-3.3.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MDEP-710] re-enable test in TestTreeMojo [maven-dependency-plugin]
slawekjaranowski opened a new pull request, #396: URL: https://github.com/apache/maven-dependency-plugin/pull/396 https://issues.apache.org/jira/browse/MDEP-710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1406] Upgrade to Parent 42 and Maven 3.6.3 [maven-shared-jar]
michael-o commented on code in PR #39: URL: https://github.com/apache/maven-shared-jar/pull/39#discussion_r1619462787 ## pom.xml: ## @@ -56,7 +56,7 @@ 8 -3.2.5 +3.6.3 1.7.36 2023-04-15T15:52:39Z 5.10.2 Review Comment: Will do -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1406] Upgrade to Parent 42 and Maven 3.6.3 [maven-shared-jar]
slawekjaranowski commented on code in PR #39: URL: https://github.com/apache/maven-shared-jar/pull/39#discussion_r1619461788 ## pom.xml: ## @@ -56,7 +56,7 @@ 8 -3.2.5 +3.6.3 1.7.36 2023-04-15T15:52:39Z 5.10.2 Review Comment: We cen drop `junitVersion` - we have dependencyManagement in parent -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [MSHARED-1406] Upgrade to Parent 42 and Maven 3.6.3 [maven-shared-jar]
michael-o opened a new pull request, #39: URL: https://github.com/apache/maven-shared-jar/pull/39 This closes #39 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix concurrent exception in BCEL [maven-shared-jar]
michael-o commented on PR #34: URL: https://github.com/apache/maven-shared-jar/pull/34#issuecomment-2138215634 Superseded by #39. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix concurrent exception in BCEL [maven-shared-jar]
michael-o closed pull request #34: Fix concurrent exception in BCEL URL: https://github.com/apache/maven-shared-jar/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHARED-1256] - Add support for Multi-Release jars [maven-shared-jar]
michael-o commented on code in PR #21:
URL: https://github.com/apache/maven-shared-jar/pull/21#discussion_r1619425244
##
src/main/java/org/apache/maven/shared/jar/JarData.java:
##
@@ -87,13 +98,19 @@ public JarData(File file, Manifest manifest, List
entries) {
this.entries = Collections.unmodifiableList(entries);
boolean aSealed = false;
+boolean multiRelease = false;
if (this.manifest != null) {
String sval =
this.manifest.getMainAttributes().getValue(Attributes.Name.SEALED);
if (sval != null && !sval.isEmpty()) {
aSealed = "true".equalsIgnoreCase(sval.trim());
}
+String sMultiRelease =
this.manifest.getMainAttributes().getValue(new
Attributes.Name("Multi-Release"));
Review Comment:
I'd reuse `sval` here
##
src/main/java/org/apache/maven/shared/jar/classes/JarClassesAnalysis.java:
##
@@ -51,8 +57,17 @@
@Named
@SuppressWarnings("checkstyle:MagicNumber")
public class JarClassesAnalysis {
+
private final Logger logger = LoggerFactory.getLogger(getClass());
+/**
+ * Constant representing the classes in the root of a Multi-Release JAR
file.
+ * Meaning outside of any given META-INF/versions/NN/... entry.
+ */
+private static final Integer ROOT = 0;
+
+private static final Pattern ENTRY_FILTER_MULTI_RELEASE =
Pattern.compile("^META-INF/versions/(\\d{1,2})/.*$");
Review Comment:
Rather `.+`? Empty entry is pointless no? Or should it also apply to the dir
entry?
##
src/main/java/org/apache/maven/shared/jar/classes/JarRuntimeVersions.java:
##
@@ -0,0 +1,107 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.maven.shared.jar.classes;
+
+import java.util.Map.Entry;
+import java.util.NavigableMap;
+import java.util.Objects;
+import java.util.Set;
+
+/**
+ * Gathered facts about the runtimeVersionMap contained within a Multi-Release
JAR file.
+ *
+ * @see
org.apache.maven.shared.jar.classes.JarClassesAnalysis#analyze(org.apache.maven.shared.jar.JarAnalyzer)
+ */
+public class JarRuntimeVersions {
Review Comment:
Same here..
##
src/main/java/org/apache/maven/shared/jar/classes/JarClassesAnalysis.java:
##
@@ -90,33 +105,105 @@ public class JarClassesAnalysis {
* @return the details of the classes found
*/
public JarClasses analyze(JarAnalyzer jarAnalyzer) {
-JarClasses classes = jarAnalyzer.getJarData().getJarClasses();
+JarData jarData = jarAnalyzer.getJarData();
+JarClasses classes = jarData.getJarClasses();
if (classes == null) {
-String jarfilename = jarAnalyzer.getFile().getAbsolutePath();
-classes = new JarClasses();
+if (jarData.isMultiRelease()) {
+classes = analyzeMultiRelease(jarAnalyzer);
+} else {
+classes = analyzeRoot(jarAnalyzer);
+}
+}
+return classes;
+}
-List classList = jarAnalyzer.getClassEntries();
+private Integer jarEntryVersion(JarEntry entry) {
+Matcher matcher = ENTRY_FILTER_MULTI_RELEASE.matcher(entry.getName());
+if (matcher.matches()) {
+return Integer.valueOf(matcher.group(1));
+}
+return ROOT;
+}
-classes.setDebugPresent(false);
+private JarClasses analyzeMultiRelease(JarAnalyzer jarAnalyzer) {
+String jarfilename = jarAnalyzer.getFile().getAbsolutePath();
Review Comment:
`jarFilename`
##
src/main/java/org/apache/maven/shared/jar/classes/JarRuntimeVersion.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or
[PR] [MPIR-457] Upgrade to Parent 42 and Maven 3.6.3 [maven-project-info-reports-plugin]
michael-o opened a new pull request, #66: URL: https://github.com/apache/maven-project-info-reports-plugin/pull/66 This closes #66 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPIR) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MPIR-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MPIR-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SUREFIRE-2244] Make IT for SUREFIRE-1295 reliable [maven-surefire]
michael-o opened a new pull request, #741: URL: https://github.com/apache/maven-surefire/pull/741 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Directory, not folder [maven-surefire]
michael-o opened a new pull request, #740: URL: https://github.com/apache/maven-surefire/pull/740 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] (doc) Address `CompilerMojo#getSourceInclusionScanner(String)` illogical `addAll` [maven-compiler-plugin]
JackPGreen opened a new pull request, #243: URL: https://github.com/apache/maven-compiler-plugin/pull/243 Sonar identified that usage of `addAll` in `CompilerMojo#getSourceInclusionScanner(String)` was [illogical](https://rules.sonarsource.com/java/RSPEC-2114/): https://github.com/apache/maven-compiler-plugin/blob/d79caa02f7b4b7efca14d178a1cc115ebf50e724/src/main/java/org/apache/maven/plugin/compiler/CompilerMojo.java#L394-L395 This was introduced in https://github.com/apache/maven-compiler-plugin/pull/141, and the same snippet is used in multiple places - only one has this defect, which I suspect is a copy-paste error. Changes: - updated to be consistent with the other examples - removed the `this.` qualifier, as the existing `incrementalExcludes` access in the same method doesn't use it to be consistent. I am not aware of any defect arising from this issue. --- Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCOMPILER) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MCOMPILER-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCOMPILER-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. --- To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MBUILDCACHE-87] - Checksum should consider plugin dependencies [maven-build-cache-extension]
reda-alaoui commented on PR #146: URL: https://github.com/apache/maven-build-cache-extension/pull/146#issuecomment-2137792088 @AlexanderAshitkin can you take a look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-api from 4.0.0-M11 to 4.0.0-M12 [maven-site-plugin]
dependabot[bot] commented on PR #190: URL: https://github.com/apache/maven-site-plugin/pull/190#issuecomment-2137656309 Looks like org.apache.maven.reporting:maven-reporting-api is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-exec from 2.0.0-M13 to 2.0.0-M14 [maven-site-plugin]
dependabot[bot] commented on PR #192: URL: https://github.com/apache/maven-site-plugin/pull/192#issuecomment-2137656156 Looks like org.apache.maven.reporting:maven-reporting-exec is up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-exec from 2.0.0-M13 to 2.0.0-M14 [maven-site-plugin]
michael-o commented on PR #192: URL: https://github.com/apache/maven-site-plugin/pull/192#issuecomment-2137655330 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-api from 4.0.0-M11 to 4.0.0-M12 [maven-site-plugin]
dependabot[bot] closed pull request #190: Bump org.apache.maven.reporting:maven-reporting-api from 4.0.0-M11 to 4.0.0-M12 URL: https://github.com/apache/maven-site-plugin/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-exec from 2.0.0-M13 to 2.0.0-M14 [maven-site-plugin]
dependabot[bot] closed pull request #192: Bump org.apache.maven.reporting:maven-reporting-exec from 2.0.0-M13 to 2.0.0-M14 URL: https://github.com/apache/maven-site-plugin/pull/192 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-api from 4.0.0-M11 to 4.0.0-M12 [maven-site-plugin]
michael-o commented on PR #190: URL: https://github.com/apache/maven-site-plugin/pull/190#issuecomment-2137655543 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump doxiaSitetoolsVersion from 2.0.0-M18 to 2.0.0-M19 [maven-site-plugin]
dependabot[bot] commented on PR #191: URL: https://github.com/apache/maven-site-plugin/pull/191#issuecomment-2137654847 Looks like these dependencies are up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump doxiaSitetoolsVersion from 2.0.0-M18 to 2.0.0-M19 [maven-site-plugin]
dependabot[bot] closed pull request #191: Bump doxiaSitetoolsVersion from 2.0.0-M18 to 2.0.0-M19 URL: https://github.com/apache/maven-site-plugin/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump doxiaVersion from 2.0.0-M10 to 2.0.0-M12 [maven-site-plugin]
dependabot[bot] closed pull request #189: Bump doxiaVersion from 2.0.0-M10 to 2.0.0-M12 URL: https://github.com/apache/maven-site-plugin/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump doxiaVersion from 2.0.0-M10 to 2.0.0-M12 [maven-site-plugin]
dependabot[bot] commented on PR #189: URL: https://github.com/apache/maven-site-plugin/pull/189#issuecomment-2137654749 Looks like these dependencies are up-to-date now, so this is no longer needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNGSITE-393] Assume 3.0 or later [maven-site]
elharo merged PR #533: URL: https://github.com/apache/maven-site/pull/533 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNGSITE-393] Assume 3.0 or later [maven-site]
elharo merged PR #534: URL: https://github.com/apache/maven-site/pull/534 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Fix multiline comment syntax [maven-site]
elharo merged PR #506: URL: https://github.com/apache/maven-site/pull/506 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Update guide-using-toolchains.apt [maven-site]
elharo merged PR #517: URL: https://github.com/apache/maven-site/pull/517 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Always link to the latest released super pom [maven-site]
elharo merged PR #519: URL: https://github.com/apache/maven-site/pull/519 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump net.sourceforge.plantuml:plantuml from 1.2024.4 to 1.2024.5 [maven-site]
elharo merged PR #532: URL: https://github.com/apache/maven-site/pull/532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Support sarif type [maven-checkstyle-plugin]
exiahuang commented on PR #136: URL: https://github.com/apache/maven-checkstyle-plugin/pull/136#issuecomment-2137251229 Add `outputFileFormat` support `sarif`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Support sarif type [maven-checkstyle-plugin]
exiahuang opened a new pull request, #136: URL: https://github.com/apache/maven-checkstyle-plugin/pull/136 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MCHECKSTYLE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [x] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[MCHECKSTYLE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `MCHECKSTYLE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Remove references to very old versions [maven-surefire]
michael-o merged PR #734: URL: https://github.com/apache/maven-surefire/pull/734 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Revert "Bump jacocoVersion from 0.8.11 to 0.8.12" [maven-surefire]
michael-o closed pull request #739: Revert "Bump jacocoVersion from 0.8.11 to 0.8.12" URL: https://github.com/apache/maven-surefire/pull/739 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Maven 3.9.x should use Maven 3.1 validation in strict mode [maven]
cstamas commented on PR #1542: URL: https://github.com/apache/maven/pull/1542#issuecomment-2136794853 Let's see CI, as it may have some quirks... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Maven 3.9.x should use Maven 3.1 validation in strict mode [maven]
gnodet opened a new pull request, #1542: URL: https://github.com/apache/maven/pull/1542 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Maven 3.9.x should use Maven 3.1 validation in strict mode [maven]
gnodet closed pull request #1541: Maven 3.9.x should use Maven 3.1 validation in strict mode URL: https://github.com/apache/maven/pull/1541 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] fix validation level [maven]
gnodet opened a new pull request, #1541:
URL: https://github.com/apache/maven/pull/1541
- **Bump version to 3.8.0-SNAPSHOT**
- **Add versionlessMavenDist profile**
- **[MNG-3220] fix doc: dependencyManagement import require scope import**
- **[MNG-7119] Upgrade Maven Wagon to 3.4.3**
- **use Maven Resolver 1.6.2**
- **[MNG-7116] add support for mirrorOf external:http:***
- **[MNG-7117] add support for blocked mirror**
- **[MNG-7118] block HTTP repositories by default**
- **[maven-release-plugin] prepare release maven-3.8.0**
- **[maven-release-plugin] prepare for next development iteration**
- **next version in branch 3.8.x is 3.8.1-SNAPSHOT**
- **[MNG-7128] keep blocked attribute from mirrors in artifact repositories**
- **[maven-release-plugin] prepare release maven-3.8.1**
- **[maven-release-plugin] prepare for next development iteration**
- **[MNG-7152] Upgrade Maven Resolver to 1.6.3**
- **[MNG-7155] upgrade maven-source-plugin from 3.2.0 to 3.2.1**
- **[MNG-7117] update link to settings xsd for version 1.2.0**
- **[MNG-5868] No duplicate artifacts in attached artifacts if attached
artifacts already contains the artifact remove it and add the new one**
- **[MNG-6071] Normalize relative paths for working directory**
- **[MNG-6983] Plugin key can get out of sync with artifactId and groupId**
- **[MNG-6819] Fix NullPointerException in StringVisitorModelInterpolator**
- **[MNG-6828] DependencyResolutionException breaks serialization**
- **[MNG-6842] ProjectBuilderTest uses Guava, but Guava is not defined in
dependencies**
- **[MNG-6850] Prevent printing the EXEC_DIR when it's just a disk letter**
- **[MNG-6843] Parallel build fails due to missing JAR artifacts in
compilePath**
- **[MNG-6937] StringSearchModelInterpolatorTest fails on symlinked paths**
- **[MNG-6964] Maven version sorting is internally inconsistent.**
- **[MNG-7000] metadata.mdo contains invalid link to schema**
- **[MNG-6816] Prefer System.lineSeparator() over system properties**
- **[MNG-6837] Simplify detection of the MAVEN_HOME and make it fully
qualified on Windows**
- **[MNG-7170] Allow to associate pomFile/${basedir} with
DefaultProjectBuilder.build(ModelSource, ...)**
- **[MNG-7179] Upgrade Jansi to 2.3.3**
- **[MNG-7177] Upgrade Maven Shared Utils to 3.3.4**
- **[MNG-7172] Remove expansion of Jansi native libraries**
- **[MNG-7032] Evaluate --help and --version after configuring the
logging/color**
- **[MNG-7080] Add a --color option to simplify color support**
- **[MNG-7127] fix MavenCliTest.testStyleColors test in JDK 16**
- **[MNG-6993] Upgrade SLF4J to 1.7.30**
- **[MNG-6886] upgrade plexus-cipher to 1.8 and update changed groupId
(#335)**
- **[MNG-6872] - Found CVEs in your dependencies - plexus-utils (tests)**
- **[MNG-6853] - Don't box primitives where it's not needed**
- **[MNG-6827] Replace deprecated StringUtils#defaultString() from Plexus
Utils**
- **[MNG-7149] Introduce MAVEN_DEBUG_ADDRESS in mvnDebug scripts**
- **[MNG-6859] Build not reproducible when built from source release**
- **[MNG-7064] Use HTTPS for schema location in global settings.xml**
- **[MNG-6967] Improve the command line output from maven-artifact.**
- **[MNG-6874] - Upgrade Maven Parent to 34**
- **[MNG-6884] - Cleanup POM File after version upgrade**
- **[MNG-6873] Align JUnit version to 4.13**
- **[MNG-6844] Use StandardCharsets and remove outdated @SuppressWarnings**
- **Document hacks as such**
- **Add new ignores**
- **[MNG-7180] Make --color option behave more like BSD/GNU grep's --color
option**
- **[MNG-7181] Make --version support -q**
- **[MNG-7184] document .mavenrc/mavenrc_pre.bat|cmd and MAVEN_SKIP_RC**
- **[MNG-7186] Upgrade Guice to 4.2.2**
- **[MNG-6987] Reorder groupId before artifactId when writing an exclusion
using maven-model**
- **[MNG-6810] - Remove profiles in maven-model**
- **[MNG-6811] - Remove unnecessary filtering configuration**
- **[MNG-6471] Parallel builder should use the module name as thread name**
- **[MNG-6754] Set the same timestamp in multi module builds**
- **[MNG-7185] Describe explicit and recommended version for
VersionRange.createFromVersionSpec()**
- **Use proper term: directory**
- **[MNG-7190] Load mavenrc from /usr/local/etc also in Bourne shell script**
- **[MNG-7190] add /usr/local/etc/mavenrc to reference documentation**
- **[MNG-7034] StackOverflowError thrown if a cycle exists in BOM imports**
- **[MNG-6648] 'mavenrc_pre' script does not receive arguments like mavenrc
in Bourne shell does**
- **[MNG-7010] Omit "NB: JAVA_HOME should point to a JDK not a JRE"**
- **[MNG-7196] Upgrade Jansi to 2.3.4**
- **[MNG-7198] Upgrade SLF4J to 1.7.32**
- **[maven-release-plugin] prepare release maven-3.8.2**
- **[maven-release-plugin] prepare for next development iteration**
-
[PR] Revert "Bump jacocoVersion from 0.8.11 to 0.8.12" [maven-surefire]
michael-o opened a new pull request, #739: URL: https://github.com/apache/maven-surefire/pull/739 This reverts commit 790e332790b1d601cb58e566c29eef3e47353f7d. Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.reporting:maven-reporting-exec from 2.0.0-M13 to 2.0.0-M14 [maven-site-plugin]
dependabot[bot] opened a new pull request, #192: URL: https://github.com/apache/maven-site-plugin/pull/192 Bumps [org.apache.maven.reporting:maven-reporting-exec](https://github.com/apache/maven-reporting-exec) from 2.0.0-M13 to 2.0.0-M14. Commits https://github.com/apache/maven-reporting-exec/commit/9bf76454ec2eb6ef5eacb542294cc8f6fe08fed6;>9bf7645 [maven-release-plugin] prepare release maven-reporting-exec-2.0.0-M14 https://github.com/apache/maven-reporting-exec/commit/be97a272f3d605658df797fa59776f802c1ca527;>be97a27 [MSHARED-1404] Upgrade plugins and components (in ITs) https://github.com/apache/maven-reporting-exec/commit/001346913d167074a0c5b899129104cb744f244d;>0013469 [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 (2) https://github.com/apache/maven-reporting-exec/commit/1e5bc1bbf3b8a4fc45d2ad61dd9eedcd251390e5;>1e5bc1b Bump maven-gh-actions-shared to v4 https://github.com/apache/maven-reporting-exec/commit/2cd21f6537e066c70f9d002e972a6312cfb5ad25;>2cd21f6 [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 https://github.com/apache/maven-reporting-exec/commit/c5ea890fa8e6d548c3856e072b7df7ccb4cc65e4;>c5ea890 [maven-release-plugin] prepare for next development iteration See full diff in https://github.com/apache/maven-reporting-exec/compare/maven-reporting-exec-2.0.0-M13...maven-reporting-exec-2.0.0-M14;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Dependency analyze cleanup [maven-surefire]
michael-o opened a new pull request, #738: URL: https://github.com/apache/maven-surefire/pull/738 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 [maven-shade-plugin]
dependabot[bot] commented on PR #227: URL: https://github.com/apache/maven-shade-plugin/pull/227#issuecomment-2135904832 OK, I won't notify you about version 4.x.x again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 [maven-shade-plugin]
dependabot[bot] closed pull request #227: Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 URL: https://github.com/apache/maven-shade-plugin/pull/227 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 3.5.1 to 4.0.1 [maven-shade-plugin]
slachiewicz commented on PR #227: URL: https://github.com/apache/maven-shade-plugin/pull/227#issuecomment-2135904756 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MNG-8097] Outline the two different ways to reference a dependency [maven-site]
kwin commented on code in PR #529:
URL: https://github.com/apache/maven-site/pull/529#discussion_r1617266482
##
content/apt/pom.apt.vm:
##
@@ -271,13 +271,20 @@ mvn install:install-file -Dfile=non-maven-proj.jar
-DgroupId=some.group -Dartifa
you browse the Maven central repository, you will notice that the
classifiers <<>> and <<>> are used
to deploy the project source code and API docs along with the packaged class
files.
+ The classifier may also be derived from the <> in case the related
{{{/ref/current/maven-core/artifact-handlers.html} artifact handler}} defines
one.
+
* <>:\
Corresponds to the chosen dependency type. This defaults to <<>>. While
it usually represents
- the extension on the filename of the dependency, that is not always the
case: a type can be mapped to a
+ the extension of the referenced artifact, that is not always the case: a
type can be mapped to a
different extension and a classifier. The type often corresponds to the
packaging used, though this is
also not always the case. Some examples are <<>>, <<>> and
<<>>:
see {{{/ref/current/maven-core/artifact-handlers.html}default artifact
handlers}} for a list. New types can be
defined by plugins that set <<>> to true, so this is not a
complete list.
+
+ In case there is an artifact handler defined there are different ways
of referencing the same dependency:
Review Comment:
> by removal of "filename", the term "extension" is suddenly changing it's
meaning (maven extension? this was my first thought while trying to comprehend
the message)
you kind of said the opposite in
https://github.com/apache/maven/pull/1466#issuecomment-2054144734. This is the
extension of the artifact which is not necessarily the extension of the
filename!
>> The depensency extension is told by type. Deoendency is never "anywhere
on disk", it may come from repo only.
or in https://github.com/apache/maven/pull/1466#issuecomment-2054145589
>> It is artifact that you need to inspect, not the backing file.
yes, good catch will fix.
> I find this very confusing all in all. Type is type, why do you want to
mixin here file extension
First of all, there was a mention of file extension before this PR, with
this PR I only refer to artifact extension (do you find this part
confusing???). This PR rather clarifies that there may be two ways to reference
the same artifact, examples:
1. ```
org.project
reusable-test-support
1.0
tests
```
vs.
```
org.project
reusable-test-support
1.0
test-jar
2. ```
org.project
my-osgi-bundle
1.0
```
vs.
```
org.project
my-osgi-bundle
1.0
bundle
3. ```
org.project
my-content-package
1.0
zip
```
vs.
```
org.project
my-content-package
1.0
content-package
Please be more concise with your criticism so that I am able to address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MNG-8097] Outline the two different ways to reference a dependency [maven-site]
kwin commented on code in PR #529:
URL: https://github.com/apache/maven-site/pull/529#discussion_r1617266482
##
content/apt/pom.apt.vm:
##
@@ -271,13 +271,20 @@ mvn install:install-file -Dfile=non-maven-proj.jar
-DgroupId=some.group -Dartifa
you browse the Maven central repository, you will notice that the
classifiers <<>> and <<>> are used
to deploy the project source code and API docs along with the packaged class
files.
+ The classifier may also be derived from the <> in case the related
{{{/ref/current/maven-core/artifact-handlers.html} artifact handler}} defines
one.
+
* <>:\
Corresponds to the chosen dependency type. This defaults to <<>>. While
it usually represents
- the extension on the filename of the dependency, that is not always the
case: a type can be mapped to a
+ the extension of the referenced artifact, that is not always the case: a
type can be mapped to a
different extension and a classifier. The type often corresponds to the
packaging used, though this is
also not always the case. Some examples are <<>>, <<>> and
<<>>:
see {{{/ref/current/maven-core/artifact-handlers.html}default artifact
handlers}} for a list. New types can be
defined by plugins that set <<>> to true, so this is not a
complete list.
+
+ In case there is an artifact handler defined there are different ways
of referencing the same dependency:
Review Comment:
> by removal of "filename", the term "extension" is suddenly changing it's
meaning (maven extension? this was my first thought while trying to comprehend
the message)
you kind of said the opposite in
https://github.com/apache/maven/pull/1466#issuecomment-2054144734. This is the
extension of the artifact which is not necessarily the extension of the
filename!
>> The depensency extension is told by type. Deoendency is never "anywhere
on disk", it may come from repo only.
> did you maybe mix up the "former and latter"?
yes, good catch will fix.
> I find this very confusing all in all. Type is type, why do you want to
mixin here file extension
First of all, there was a mention of file extension before this PR, with
this PR I only refer to artifact extension (do you find this part
confusing???). This PR rather clarifies that there may be two ways to reference
the same artifact, examples:
1. ```
org.project
reusable-test-support
1.0
tests
```
vs.
```
org.project
reusable-test-support
1.0
test-jar
2. ```
org.project
my-osgi-bundle
1.0
```
vs.
```
org.project
my-osgi-bundle
1.0
bundle
3. ```
org.project
my-content-package
1.0
zip
```
vs.
```
org.project
my-content-package
1.0
content-package
Please be more concise with your criticism so that I am able to address it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Bump net.bytebuddy:byte-buddy from 1.11.13 to 1.14.16 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #293: URL: https://github.com/apache/maven-plugin-tools/pull/293 Bumps [net.bytebuddy:byte-buddy](https://github.com/raphw/byte-buddy) from 1.11.13 to 1.14.16. Release notes Sourced from https://github.com/raphw/byte-buddy/releases;>net.bytebuddy:byte-buddy's releases. Byte Buddy 1.14.16 Update ASM and introduce support for Java 23. Byte Buddy 1.14.15 Allow attaching from root on J9. Byte Buddy 1.14.14 Adjust type validation to accept additional names that are legal in the class file format. Fix dynamic attach on Windows when a service user is active. Avoid failure when using Android's strict mode. Byte Buddy 1.14.13 Avoid resolving type variables when generic type processing is disabled. Improve error message for Byte Buddy agent external attach. Fix build for modular jars when using later version than Java 8. Byte Buddy 1.14.12 Pin proxy class file version to avoid implicit changes when using Graal native image. Add support for Java 23. Add missing @MaybeNull annotation. Byte Buddy 1.14.11 Adjusts Gradle plugin to support Gradle 8.4 without warnings. Avoid blurry exception on build plugin for fail fast. byte-buddy-1.14.10 Add lazy facade to default TypePool in AgentBuilder to avoid parsing of types ignored by name. Avoid module info classes in Android plugin. Byte Buddy 1.14.9 Update ASM to version 9.6 Support Android plugin to support APG version 7.4 Byte Buddy 1.14.8 Correctly read versions from class file that would use both bytes. Fix Byte Buddy Gradle plugin for Gradle 8.3+. Correct field and static method access on subtypes in MemberSubstitution. Support APK 7.4+ versions in Byte Buddy Gradle for Android plugin. Byte Buddy 1.14.7 Correctly read minor version from class file. Catch type resolution errors when applying Plugin.Engine. Byte Buddy 1.14.6 Add PatchMode.SUBSTITUTE and ResettableClassFileTransformer.Substitutable for in-order patching. Allow for explicit specification og differential matcher when patching an AgentBuilder. Add platform loader to locator for build plugins. Correctly resolve accessors for fields with capitalized first letter. Make jars for Android read-only as newer versions require it. ... (truncated) Changelog Sourced from https://github.com/raphw/byte-buddy/blob/master/release-notes.md;>net.bytebuddy:byte-buddy's changelog. 22. May 2024: version 1.14.16 Update ASM and introduce support for Java 23. 8. May 2024: version 1.14.15 Allow attaching from root on J9. 23. April 2024: version 1.14.14 Adjust type validation to accept additional names that are legal in the class file format. Fix dynamic attach on Windows when a service user is active. Avoid failure when using Android's strict mode. 28. March 2024: version 1.14.13 Avoid resolving type variables when generic type processing is disabled. Improve error message for Byte Buddy agent external attach. Fix build for modular jars when using later version than Java 8. 16. February 2024: version 1.14.12 Pin proxy class file version to avoid implicit changes when using Graal native image. Add support for Java 23. Add missing @MaybeNull annotation. 21. December 2023: version 1.14.11 Adjusts Gradle plugin to support Gradle 8.4 without warnings. Avoid blurry exception on build plugin for fail fast. 16. October 2023: version 1.14.10 Add lazy facade to default TypePool in AgentBuilder to avoid parsing of types ignored by name. Avoid module info classes in Android plugin. 9. October 2023: version 1.14.9 Update ASM to version 9.6 Support Android plugin to support APG version 7.4 15. September 2023: version 1.14.8 Correctly read versions from class file that would use both bytes. Fix Byte Buddy Gradle plugin for Gradle 8.3+. Correct field and static method access on subtypes in MemberSubstitution. Support APK 7.4+ versions in Byte Buddy Gradle for Android plugin. 28. August 2023: version 1.14.7 ... (truncated) Commits https://github.com/raphw/byte-buddy/commit/8f37644d35fdb1478d0982995f9cee9f7e2a91ff;>8f37644 [maven-release-plugin] prepare release byte-buddy-1.14.16 https://github.com/raphw/byte-buddy/commit/9e62bad5a1535a7ab16275652eac81ee5597833f;>9e62bad [release] Release new version https://github.com/raphw/byte-buddy/commit/6dc6b2ee59071ea88dbf9c3bbe4bf7df7aa95a69;>6dc6b2e Add checksums and fix build configuration. https://github.com/raphw/byte-buddy/commit/840bab42306b5d074a9265511480d2388cec1d84;>840bab4 Add missing checksums
[PR] Bump org.codehaus.plexus:plexus-classworlds from 2.7.0 to 2.8.0 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #292: URL: https://github.com/apache/maven-plugin-tools/pull/292 Bumps [org.codehaus.plexus:plexus-classworlds](https://github.com/codehaus-plexus/plexus-classworlds) from 2.7.0 to 2.8.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-classworlds/releases;>org.codehaus.plexus:plexus-classworlds's releases. 2.8.0 pom.mxl and site.xml cleanup (https://redirect.github.com/codehaus-plexus/plexus-classworlds/pull/95;>#95) https://github.com/hboutemy;>@hboutemy Dependency updates Migrate to JUnit 5 (https://redirect.github.com/codehaus-plexus/plexus-classworlds/pull/86;>#86) https://github.com/slachiewicz;>@slachiewicz Update dependencies used in test to more recent ones with less CVE (https://redirect.github.com/codehaus-plexus/plexus-classworlds/pull/88;>#88) https://github.com/slachiewicz;>@slachiewicz Maintenance Reuse plexus-pom action for CI (https://redirect.github.com/codehaus-plexus/plexus-classworlds/pull/101;>#101) https://github.com/slachiewicz;>@slachiewicz Cleanup gha - use same defaults from template (https://redirect.github.com/codehaus-plexus/plexus-classworlds/pull/87;>#87) https://github.com/slachiewicz;>@slachiewicz Commits https://github.com/codehaus-plexus/plexus-classworlds/commit/fc454e40c98c7122338a35733d8d00eee4e0eefb;>fc454e4 [maven-release-plugin] prepare release plexus-classworlds-2.8.0 https://github.com/codehaus-plexus/plexus-classworlds/commit/30cc871a4217ed0db11648c89649c62badf1d8a9;>30cc871 Bump org.codehaus.plexus:plexus from 15 to 16 https://github.com/codehaus-plexus/plexus-classworlds/commit/fe02226a5a32c5bdefbd887c1d1c52b38d2e0547;>fe02226 Reuse plexus-pom action for CI https://github.com/codehaus-plexus/plexus-classworlds/commit/07d2c10437f5c9826c0f4325eb7d3ccf5345ac2b;>07d2c10 Bump org.apache.maven.plugins:maven-dependency-plugin https://github.com/codehaus-plexus/plexus-classworlds/commit/d1bdf7c93cb215816e6eca5f84aadc39c30cf32e;>d1bdf7c fix surefire plugin config - forkMode none - forkCount 1 https://github.com/codehaus-plexus/plexus-classworlds/commit/32fac00c453d59ea2017533b55efaea7000c68f3;>32fac00 Bump org.codehaus.plexus:plexus from 14 to 15 https://github.com/codehaus-plexus/plexus-classworlds/commit/f70ed4a8fa1e8c265e7632c98eebec1584fe323a;>f70ed4a Bump org.codehaus.plexus:plexus from 13 to 14 https://github.com/codehaus-plexus/plexus-classworlds/commit/5f778ff6378aad5669365a1fb58f83fdb21c9caa;>5f778ff pom.mxl and site.xml cleanup https://github.com/codehaus-plexus/plexus-classworlds/commit/61101ebf31b3b41cabb82e70b1b97e107554d194;>61101eb Bump maven-bundle-plugin from 5.1.8 to 5.1.9 https://github.com/codehaus-plexus/plexus-classworlds/commit/78884e4d468ef8613ca0d29e5e815549af23e551;>78884e4 Bump maven-dependency-plugin from 3.5.0 to 3.6.0 Additional commits viewable in https://github.com/codehaus-plexus/plexus-classworlds/compare/plexus-classworlds-2.7.0...plexus-classworlds-2.8.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more
[PR] Bump maven3Version from 3.9.6 to 3.9.7 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #291: URL: https://github.com/apache/maven-plugin-tools/pull/291 Bumps `maven3Version` from 3.9.6 to 3.9.7. Updates `org.apache.maven:maven-model-builder` from 3.9.6 to 3.9.7 Release notes Sourced from https://github.com/apache/maven/releases;>org.apache.maven:maven-model-builder's releases. 3.9.7 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922version=12353964;>Release Notes - Maven - Version 3.9.7 ... (truncated) Commits https://github.com/apache/maven/commit/8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0;>8b094c9 [maven-release-plugin] prepare release maven-3.9.7 https://github.com/apache/maven/commit/6ff3a821e73ad5fa3fa30e40c51b161139573c15;>6ff3a82 [MNG-8125][MNG-8126][MNG-8127] Mild updates (https://redirect.github.com/apache/maven/issues/1533;>#1533) https://github.com/apache/maven/commit/73bc6caec7fb46d20aeefb29bc6bd00d39fb007e;>73bc6ca [MNG-8121] Fix NPE in metadata merge (https://redirect.github.com/apache/maven/issues/1508;>#1508) https://github.com/apache/maven/commit/558ae8a924440c57d7033ce039246d9b176d572b;>558ae8a [MNG-8115] Upgrade minimal set of dependencies (https://redirect.github.com/apache/maven/issues/1496;>#1496) https://github.com/apache/maven/commit/c44304fe33e091be2a4b6a5d65f06ba777a692a0;>c44304f [MNG-8118] Backport to Maven 3.9.x (https://redirect.github.com/apache/maven/issues/1505;>#1505) https://github.com/apache/maven/commit/c1c114dbf98f77eefacb5aa6887645e4de9f069c;>c1c114d [MNG-8081] Interpolate available properties during default profile selection ... https://github.com/apache/maven/commit/b4cbda8cb98ed1e72119d41095b9831ebd0fba86;>b4cbda8 [3.9.x][MNG-8109] Resolver 1.9.20 (https://redirect.github.com/apache/maven/issues/1490;>#1490) https://github.com/apache/maven/commit/bc52363d402f14043e2e4efed40799044cdf531b;>bc52363 [3.9.x][MNG-8106] Fix metadata merge (https://redirect.github.com/apache/maven/issues/1480;>#1480) https://github.com/apache/maven/commit/587e99bc70132f71d69305bcb7217ec5e151c25e;>587e99b [MNG-8094] Resolver 1.9.19 (https://redirect.github.com/apache/maven/issues/1468;>#1468) https://github.com/apache/maven/commit/548459b1a96b79d5e5917af17a0248954deaaa3f;>548459b [MNG-8011] Neuter the README (https://redirect.github.com/apache/maven/issues/1470;>#1470) Additional commits viewable in https://github.com/apache/maven/compare/maven-3.9.6...maven-3.9.7;>compare view Updates `org.apache.maven:maven-model` from 3.9.6 to 3.9.7 Release notes Sourced from https://github.com/apache/maven/releases;>org.apache.maven:maven-model's releases. 3.9.7 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316922version=12353964;>Release Notes - Maven - Version 3.9.7 ... (truncated) Commits https://github.com/apache/maven/commit/8b094c9513efc1b9ce2d952b3b9c8eaedaf8cbf0;>8b094c9 [maven-release-plugin] prepare release maven-3.9.7 https://github.com/apache/maven/commit/6ff3a821e73ad5fa3fa30e40c51b161139573c15;>6ff3a82 [MNG-8125][MNG-8126][MNG-8127] Mild updates (https://redirect.github.com/apache/maven/issues/1533;>#1533) https://github.com/apache/maven/commit/73bc6caec7fb46d20aeefb29bc6bd00d39fb007e;>73bc6ca [MNG-8121] Fix NPE in metadata merge (https://redirect.github.com/apache/maven/issues/1508;>#1508) https://github.com/apache/maven/commit/558ae8a924440c57d7033ce039246d9b176d572b;>558ae8a [MNG-8115] Upgrade minimal set of dependencies (https://redirect.github.com/apache/maven/issues/1496;>#1496) https://github.com/apache/maven/commit/c44304fe33e091be2a4b6a5d65f06ba777a692a0;>c44304f [MNG-8118] Backport to Maven 3.9.x (https://redirect.github.com/apache/maven/issues/1505;>#1505) https://github.com/apache/maven/commit/c1c114dbf98f77eefacb5aa6887645e4de9f069c;>c1c114d [MNG-8081] Interpolate available properties during default profile selection ... https://github.com/apache/maven/commit/b4cbda8cb98ed1e72119d41095b9831ebd0fba86;>b4cbda8 [3.9.x][MNG-8109] Resolver 1.9.20 (https://redirect.github.com/apache/maven/issues/1490;>#1490) https://github.com/apache/maven/commit/bc52363d402f14043e2e4efed40799044cdf531b;>bc52363 [3.9.x][MNG-8106] Fix metadata merge (https://redirect.github.com/apache/maven/issues/1480;>#1480) https://github.com/apache/maven/commit/587e99bc70132f71d69305bcb7217ec5e151c25e;>587e99b [MNG-8094] Resolver 1.9.19 (https://redirect.github.com/apache/maven/issues/1468;>#1468) https://github.com/apache/maven/commit/548459b1a96b79d5e5917af17a0248954deaaa3f;>548459b [MNG-8011] Neuter the README (https://redirect.github.com/apache/maven/issues/1470;>#1470) Additional commits viewable in https://github.com/apache/maven/compare/maven-3.9.6...maven-3.9.7;>compare view Updates `org.apache.maven:maven-plugin-api` from 3.9.6 to 3.9.7
[PR] Bump resolverVersion from 1.9.18 to 1.9.20 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #290: URL: https://github.com/apache/maven-plugin-tools/pull/290 Bumps `resolverVersion` from 1.9.18 to 1.9.20. Updates `org.apache.maven.resolver:maven-resolver-api` from 1.9.18 to 1.9.20 Release notes Sourced from https://github.com/apache/maven-resolver/releases;>org.apache.maven.resolver:maven-resolver-api's releases. 1.9.20 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628version=12354578;>Release Notes - Maven Resolver - Version 1.9.20 What's Changed [MRESOLVER-547] Just use setVersion by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/483;>apache/maven-resolver#483 [MRESOLVER-549] Parent POM 42 by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/484;>apache/maven-resolver#484 Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20;>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628version=12353946;>Release Notes - Maven Resolver - Version 1.9.19 ... (truncated) Commits https://github.com/apache/maven-resolver/commit/f5fbc245e64091a41ba0926a6958b98bf0b29eb3;>f5fbc24 [maven-release-plugin] prepare release maven-resolver-1.9.20 https://github.com/apache/maven-resolver/commit/446009d7073014a7d418a4b9637664a2f6d05c82;>446009d [MRESOLVER-549][MRESOLVER-550][MRESOLVER-551] Parent POM 42 (https://redirect.github.com/apache/maven-resolver/issues/484;>#484) https://github.com/apache/maven-resolver/commit/4f16d5ecd94f85e6e7d793e6b6b82f20c9afbf56;>4f16d5e [MRESOLVER-547] Just use setVersion (https://redirect.github.com/apache/maven-resolver/issues/483;>#483) https://github.com/apache/maven-resolver/commit/c1b24c699621930f4eb77721400f2f6c46930626;>c1b24c6 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-resolver/commit/c1b03574961fd2daa7a678bb3fbf9f0779afee56;>c1b0357 [maven-release-plugin] prepare release maven-resolver-1.9.19 https://github.com/apache/maven-resolver/commit/adadd42d1642f39bafedb2ddd619b044fecb12b0;>adadd42 [MRESOLVER-536] Do not belly up if FS does not support setting mtime (https://redirect.github.com/apache/maven-resolver/issues/469;>#469) https://github.com/apache/maven-resolver/commit/31df8a3dc503895172d277de56b1c4a53da0a27c;>31df8a3 [1.9.x] Update dependencies (https://redirect.github.com/apache/maven-resolver/issues/462;>#462) https://github.com/apache/maven-resolver/commit/b225076e5d5b2fe3f166a4018802ac94b7cc94f7;>b225076 [MRESOLVER-522] Improve congested file locks behaviour (https://redirect.github.com/apache/maven-resolver/issues/455;>#455) (https://redirect.github.com/apache/maven-resolver/issues/461;>#461) https://github.com/apache/maven-resolver/commit/fc969c2570041bb72c3f0141ff4957e8754f365c;>fc969c2 [1.9.x][MRESOLVER-483] Fix path concatenation logic (https://redirect.github.com/apache/maven-resolver/issues/420;>#420) https://github.com/apache/maven-resolver/commit/a3e620d6d2ab6ca58d42d264347341b31da00dde;>a3e620d Use one Maven in CI Additional commits viewable in https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.18...maven-resolver-1.9.20;>compare view Updates `org.apache.maven.resolver:maven-resolver-util` from 1.9.18 to 1.9.20 Release notes Sourced from https://github.com/apache/maven-resolver/releases;>org.apache.maven.resolver:maven-resolver-util's releases. 1.9.20 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628version=12354578;>Release Notes - Maven Resolver - Version 1.9.20 What's Changed [MRESOLVER-547] Just use setVersion by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/483;>apache/maven-resolver#483 [MRESOLVER-549] Parent POM 42 by https://github.com/cstamas;>@cstamas in https://redirect.github.com/apache/maven-resolver/pull/484;>apache/maven-resolver#484 Full Changelog: https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20;>https://github.com/apache/maven-resolver/compare/maven-resolver-1.9.19...maven-resolver-1.9.20 1.9.19 https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628version=12353946;>Release Notes - Maven Resolver - Version 1.9.19 ... (truncated) Commits https://github.com/apache/maven-resolver/commit/f5fbc245e64091a41ba0926a6958b98bf0b29eb3;>f5fbc24 [maven-release-plugin] prepare release maven-resolver-1.9.20 https://github.com/apache/maven-resolver/commit/446009d7073014a7d418a4b9637664a2f6d05c82;>446009d [MRESOLVER-549][MRESOLVER-550][MRESOLVER-551] Parent
Re: [PR] [MSHADE-428] Prevent null value in array of transformers [maven-shade-plugin]
cstamas merged PR #229: URL: https://github.com/apache/maven-shade-plugin/pull/229 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-impl from 4.0.0-M2 to 4.0.0-M14 [maven-dist-tool]
dependabot[bot] closed pull request #55: Bump org.apache.maven.reporting:maven-reporting-impl from 4.0.0-M2 to 4.0.0-M14 URL: https://github.com/apache/maven-dist-tool/pull/55 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.reporting:maven-reporting-impl from 4.0.0-M2 to 4.0.0-M14 [maven-dist-tool]
dependabot[bot] commented on PR #55: URL: https://github.com/apache/maven-dist-tool/pull/55#issuecomment-2135078243 Superseded by #58. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.apache.maven.reporting:maven-reporting-impl from 4.0.0-M2 to 4.0.0-M15 [maven-dist-tool]
dependabot[bot] opened a new pull request, #58: URL: https://github.com/apache/maven-dist-tool/pull/58 Bumps [org.apache.maven.reporting:maven-reporting-impl](https://github.com/apache/maven-reporting-impl) from 4.0.0-M2 to 4.0.0-M15. Commits https://github.com/apache/maven-reporting-impl/commit/a5ac7d7c600a9bcb4d2fea6d32d75f03f2a8555d;>a5ac7d7 [maven-release-plugin] prepare release maven-reporting-impl-4.0.0-M15 https://github.com/apache/maven-reporting-impl/commit/610c5230c447102f9899a7ae35d30541c3b1df6c;>610c523 [MSHARED-1402] Upgrade plugins and components (in ITs) https://github.com/apache/maven-reporting-impl/commit/99d69ef381eec1db8bbdedfe4d51ef1699ce391f;>99d69ef [MSHARED-1397] Bump org.apache.maven:maven-archiver from 3.6.1 to 3.6.2 (https://redirect.github.com/apache/maven-reporting-impl/issues/34;>#34) https://github.com/apache/maven-reporting-impl/commit/7bff1c2ddbe6d196ab71ad196a0367235a694332;>7bff1c2 [MSHARED-1392] Upgrade to Parent 42 and Maven 3.6.3 https://github.com/apache/maven-reporting-impl/commit/4dae8a736ba7c32fed3dac76ecf547edb922d492;>4dae8a7 [maven-release-plugin] prepare for next development iteration https://github.com/apache/maven-reporting-impl/commit/cefa8b026db16dab156d39cad7096a183046c467;>cefa8b0 [maven-release-plugin] prepare release maven-reporting-impl-4.0.0-M14 https://github.com/apache/maven-reporting-impl/commit/34de83672db5f01a3023d951db3366466d827f12;>34de836 [MSHARED-1361] Upgrade plugins and components (in ITs) (2) https://github.com/apache/maven-reporting-impl/commit/8464ab92499b37677eadf60ef4661bd9c847b0ac;>8464ab9 Bump org.junit:junit-bom from 5.10.1 to 5.10.2 https://github.com/apache/maven-reporting-impl/commit/e6db48408db861e3209748fe5ec10abd7dd25bfa;>e6db484 Add Dependabot config https://github.com/apache/maven-reporting-impl/commit/72181306bb0e12eed50c4ba4aec98dd76499df39;>7218130 [MSHARED-1348] Upgrade plugins and components (in ITs) Additional commits viewable in https://github.com/apache/maven-reporting-impl/compare/maven-reporting-impl-4.0.0-M2...maven-reporting-impl-4.0.0-M15;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-526] Clean up dependencies reported by dependencies:analyze [maven-plugin-tools]
michael-o commented on PR #287: URL: https://github.com/apache/maven-plugin-tools/pull/287#issuecomment-2135059349 > > > @michael-o @gnodet should we cherry-pick to 3.x branch? > > > > > > If the 3.x branch is active, we should, but I should that @gnodet would reset 3.x as as soon as he will bump master to 4.0.0. > > I've reset the 3.x branch to the current master (just after the release). Perfect, thanks. Let's wait until the vote has passed and then we can continue with your open PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-526] Clean up dependencies reported by dependencies:analyze [maven-plugin-tools]
gnodet commented on PR #287: URL: https://github.com/apache/maven-plugin-tools/pull/287#issuecomment-2135049608 > > @michael-o @gnodet should we cherry-pick to 3.x branch? > > If the 3.x branch is active, we should, but I should that @gnodet would reset 3.x as as soon as he will bump master to 4.0.0. I've reset the 3.x branch to the current master (just after the release). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
cstamas merged PR #228: URL: https://github.com/apache/maven-shade-plugin/pull/228 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-526] Clean up dependencies reported by dependencies:analyze [maven-plugin-tools]
michael-o commented on PR #287: URL: https://github.com/apache/maven-plugin-tools/pull/287#issuecomment-2134922184 > @michael-o @gnodet should we cherry-pick to 3.x branch? If the 3.x branch is active, we should, but I should that @gnodet would reset 3.x as as soon as he will bump master to 4.0.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] First try [maven-surefire]
michael-o opened a new pull request, #737: URL: https://github.com/apache/maven-surefire/pull/737 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616976316
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -444,6 +474,17 @@ public void execute() throws MojoExecutionException {
artifacts.add(project.getArtifact().getFile());
+if (extraJars != null && !extraJars.isEmpty()) {
+for (File extraJar : extraJars) {
+if (!Files.isRegularFile(extraJar.toPath())) {
+createErrorOutput();
Review Comment:
```java
private void createErrorOutput() {
getLog().error("The project main artifact does not exist. This could
have the following");
getLog().error("reasons:");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616973202
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -444,6 +474,17 @@ public void execute() throws MojoExecutionException {
artifacts.add(project.getArtifact().getFile());
+if (extraJars != null && !extraJars.isEmpty()) {
+for (File extraJar : extraJars) {
+if (!Files.isRegularFile(extraJar.toPath())) {
+createErrorOutput();
Review Comment:
Please check if this error message are correct here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
cstamas commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616945401
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
Review Comment:
pushed update
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
+
+/**
+ * Extra Artifacts to infuse into shaded result.
+ *
+ * One can add here "extra Artifacts" to be worked into the resulting
shaded JAR. The artifacts will be resolved
+ * (not transitively), and will be processed in same way as dependency
JARs (if any): regarding relocation,
+ * resource transformers and filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraArtifacts;
Review Comment:
pushed update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
cstamas commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616940993
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
+
+/**
+ * Extra Artifacts to infuse into shaded result.
+ *
+ * One can add here "extra Artifacts" to be worked into the resulting
shaded JAR. The artifacts will be resolved
+ * (not transitively), and will be processed in same way as dependency
JARs (if any): regarding relocation,
+ * resource transformers and filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraArtifacts;
Review Comment:
The ["standard"
format](https://github.com/apache/maven-resolver/blob/master/maven-resolver-api/src/main/java/org/eclipse/aether/artifact/DefaultArtifact.java#L51-L63),
will add to comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
cstamas commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616939947
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
Review Comment:
Yes, these are files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616934940
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
+
+/**
+ * Extra Artifacts to infuse into shaded result.
+ *
+ * One can add here "extra Artifacts" to be worked into the resulting
shaded JAR. The artifacts will be resolved
+ * (not transitively), and will be processed in same way as dependency
JARs (if any): regarding relocation,
+ * resource transformers and filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraArtifacts;
Review Comment:
We should describe format of item ... `groupId:artifactId:...`
which items are required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MSHADE-478] Extra JARs feature [maven-shade-plugin]
slawekjaranowski commented on code in PR #228:
URL:
https://github.com/apache/maven-shade-plugin/pull/228#discussion_r1616933185
##
src/main/java/org/apache/maven/plugins/shade/mojo/ShadeMojo.java:
##
@@ -393,6 +392,36 @@ public class ShadeMojo extends AbstractMojo {
@Parameter(defaultValue = "false")
private boolean skip;
+/**
+ * Extra JAR files to infuse into shaded result.
+ *
+ * One can add here "extra JARs", to be worked into the resulting shaded
JAR. The listed JAR files must exist.
+ * Extra JARs will be processed in same way as main JAR (if any): applied
relocation, resource transformers
+ * but not filtering.
+ *
+ * Note: this feature should be used lightly, is not meant as ability to
replace dependency hull! It is more
+ * just a feature to be able to slightly "differentiate" shaded JAR from
main only.
+ *
+ * @since 3.6.0
+ */
+@Parameter
+private List extraJars;
Review Comment:
we should add what is the item ... I guess that is a path to jar file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPLUGIN-526] Clean up dependencies reported by dependencies:analyze [maven-plugin-tools]
slawekjaranowski commented on PR #287: URL: https://github.com/apache/maven-plugin-tools/pull/287#issuecomment-2134786032 @michael-o @gnodet should we cherry-pick to 3.x branch? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.25.3 to 3.26.0 [maven-mvnd]
gnodet merged PR #1003: URL: https://github.com/apache/maven-mvnd/pull/1003 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.plugins:maven-wrapper-plugin from 3.3.1 to 3.3.2 [maven-mvnd]
gnodet merged PR #1004: URL: https://github.com/apache/maven-mvnd/pull/1004 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 3.0.1 [maven-plugin-tools]
asfgit merged PR #283: URL: https://github.com/apache/maven-plugin-tools/pull/283 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.25.3 to 3.26.0 [maven-plugin-tools]
asfgit merged PR #289: URL: https://github.com/apache/maven-plugin-tools/pull/289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-xml from 3.0.0 to 3.0.1 [maven-plugin-tools]
michael-o commented on PR #283: URL: https://github.com/apache/maven-plugin-tools/pull/283#issuecomment-2134602135 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.25.3 to 3.26.0 [maven-plugin-tools]
michael-o commented on PR #289: URL: https://github.com/apache/maven-plugin-tools/pull/289#issuecomment-2134599150 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [MPLUGIN-526] Clean up dependencies reported by dependencies:analyze [maven-plugin-tools]
asfgit closed pull request #287: [MPLUGIN-526] Clean up dependencies reported by dependencies:analyze URL: https://github.com/apache/maven-plugin-tools/pull/287 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 [maven-javadoc-plugin]
dependabot[bot] closed pull request #285: Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 URL: https://github.com/apache/maven-javadoc-plugin/pull/285 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 [maven-javadoc-plugin]
michael-o commented on PR #285: URL: https://github.com/apache/maven-javadoc-plugin/pull/285#issuecomment-2134562214 @dependabot ignore this dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 [maven-javadoc-plugin]
dependabot[bot] commented on PR #285: URL: https://github.com/apache/maven-javadoc-plugin/pull/285#issuecomment-2134562300 OK, I won't notify you about org.codehaus.plexus:plexus-archiver again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 [maven-javadoc-plugin]
dependabot[bot] commented on PR #285: URL: https://github.com/apache/maven-javadoc-plugin/pull/285#issuecomment-2134561635 Sorry, the command you entered is not valid for this pull request. Please check the syntax and try again. Valid commands: For single dependency PRs, use commands like: `@dependabot ignore this major version` `@dependabot ignore this minor version` `@dependabot ignore this dependency` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.1 to 4.9.2 [maven-javadoc-plugin]
michael-o commented on PR #285: URL: https://github.com/apache/maven-javadoc-plugin/pull/285#issuecomment-2134561590 @dependabot ignore dependency -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump resolverVersion from 1.4.1 to 1.9.20 [maven-javadoc-plugin]
dependabot[bot] commented on PR #284: URL: https://github.com/apache/maven-javadoc-plugin/pull/284#issuecomment-2134560977 OK, I won't notify you about any of these dependencies again, unless you re-open this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
