[GitHub] [maven] MartinKanters commented on pull request #639: [MNG-7310] Using the plexusContainer to prevent loading lifecycles from defined by extensions from other submodules.
MartinKanters commented on pull request #639: URL: https://github.com/apache/maven/pull/639#issuecomment-1036336300 > Ah, then it is indeed best to lookup the map once and store it in an member variable. Good suggestion! Just realized you meant exactly the opposite. Anyway, changed it accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on pull request #639: [MNG-7310] Using the plexusContainer to prevent loading lifecycles from defined by extensions from other submodules.
MartinKanters commented on pull request #639: URL: https://github.com/apache/maven/pull/639#issuecomment-1008035176 > RU sure you don't need to perform lookup on each call (instead to keep the map in final member?) This is a singleton, so the map you lookup in constructor, once inited, would not change Ah, then it is indeed best to lookup the map once and store it in an member variable. Good suggestion! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
