[GitHub] [maven] MartinKanters commented on pull request #659: [MNG-7390] Allow selecting modules outside the cwd into the reactor using --projects.
MartinKanters commented on pull request #659: URL: https://github.com/apache/maven/pull/659#issuecomment-1039465240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on pull request #659: [MNG-7390] Allow selecting modules outside the cwd into the reactor using --projects.
MartinKanters commented on pull request #659: URL: https://github.com/apache/maven/pull/659#issuecomment-1039473629 > Dank U Bitte schön. --- Here's the simplified PR, currently running against the ITs: https://github.com/apache/maven/pull/677 Related PR for maven-integration-tests (branch has been renamed to match this PR's branch): https://github.com/apache/maven-integration-testing/pull/138 Will now close this PR and later create a new one just for the refactorings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on pull request #659: [MNG-7390] Allow selecting modules outside the cwd into the reactor using --projects.
MartinKanters commented on pull request #659: URL: https://github.com/apache/maven/pull/659#issuecomment-1039465240 > > The change in essence is very simple. > > This is about it: [master...MartinKanters:MNG-7390-select-module-outside-pwd-simplified](https://github.com/apache/maven/compare/master...MartinKanters:MNG-7390-select-module-outside-pwd-simplified) > > Thanks, that is very helpful! The essence of the change is indeed pretty simple and I can make sense out of that. > > > [...] since we have covered it with a lot of unit tests and integration tests I had confidence that I could make the refactor > > That's what we have those tests for :-) > > I'm OK with the changes in the "simplified" version. Given that the tests all pass, I'm fine with merging the changes. > > Just a thought: would it be feasible to merge the simplified changes, and then have the refactoring as a separate PR, just to make it easier for everybody to follow along and review? I'd prefer to keep everyone involved as this is a piece of the code which is pretty hard to understand in itself... Sure, that's fine, I can do that. I'll try to split the changes into separate commits for review sake. It will take some time, though, I don't have that much time nowadays.. :) For now I'll create a separate PR for the simplified version (and ensure that the IT branch is renamed to the simplified branch name as well. Then I'll close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on pull request #659: [MNG-7390] Allow selecting modules outside the cwd into the reactor using --projects.
MartinKanters commented on pull request #659: URL: https://github.com/apache/maven/pull/659#issuecomment-1037399766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on pull request #659: [MNG-7390] Allow selecting modules outside the cwd into the reactor using --projects.
MartinKanters commented on pull request #659: URL: https://github.com/apache/maven/pull/659#issuecomment-1038134079 > I see a lot of code has changed due to a conversion from `List` to `Set` (which I think is fine, but I'm not 100% sure) and sometimes a variable rename. Unfortunately, it's all one big commit, which makes it hard for me to focus on the essentials of the change. I understand, it became quite terrible to review, sorry for that. The change in essence is very simple. This is about it: https://github.com/apache/maven/compare/master...MartinKanters:MNG-7390-select-module-outside-pwd-simplified > Is the `List` to `Set` conversion _necessary_ for this feature to work? For the variable rename, I can answer the question myself... ;-) I took the opportunity to refactor the whole class, as I never really liked the coding style much. It's hard to grasp the full business logic and since we have covered it with a lot of unit tests and integration tests I had confidence that I could make the refactor. I've put a list of main things changed in the PR description. If you want, we can have a meeting to go over the points together, let me know. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on pull request #659: [MNG-7390] Allow selecting modules outside the cwd into the reactor using --projects.
MartinKanters commented on pull request #659: URL: https://github.com/apache/maven/pull/659#issuecomment-1037432343 > under every condition or does it strictly require a `.mvn/` to be present? (Unfortunately) it strictly requires the .mvn directory in root, just like for MNG-6118. I've just created a testcase for that in the IT PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on pull request #659: [MNG-7390] Allow selecting modules outside the cwd into the reactor using --projects.
MartinKanters commented on pull request #659: URL: https://github.com/apache/maven/pull/659#issuecomment-1037425488 > The question is: Did you fix a cwd traversal or are you able to discover the root reactor although you are in a module? The latter, it discovers the reactor as if you were running it from the root, that's why you can select modules from different directories inside the same project. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] MartinKanters commented on pull request #659: [MNG-7390] Allow selecting modules outside the cwd into the reactor using --projects.
MartinKanters commented on pull request #659: URL: https://github.com/apache/maven/pull/659#issuecomment-1037399766 > Please select a proper commit title because it is now disjoint with the JIRA summary. Which one is better from your PoV? Good point! After some iterations this is what I came up with. The previous one contained something like "usual reactor", which is super vague. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
