[GitHub] [maven] michael-o commented on a change in pull request #436: [MNG-7080] Add a --color option to simplify color support
michael-o commented on a change in pull request #436: URL: https://github.com/apache/maven/pull/436#discussion_r626532470 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java ## @@ -149,6 +151,7 @@ public CLIManager() options.addOption( Option.builder( LEGACY_LOCAL_REPOSITORY ).longOpt( "legacy-local-repository" ).desc( "Use Maven 2 Legacy Local Repository behaviour, ie no use of _remote.repositories. Can also be activated by using -Dmaven.legacyLocalRepo=true" ).build() ); options.addOption( Option.builder( BUILDER ).longOpt( "builder" ).hasArg().desc( "The id of the build strategy to use" ).build() ); options.addOption( Option.builder( NO_TRANSFER_PROGRESS ).longOpt( "no-transfer-progress" ).desc( "Do not display transfer progress when downloading or uploading" ).build() ); +options.addOption( Option.builder().longOpt( COLOR ).hasArg().desc( "Color support mode (auto/always/never)" ).build() ); Review comment: Exactly, when I reviewed the PR for `-Dstyle.color` I requested to apply the `grep` logic to no to invent new terms. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #436: [MNG-7080] Add a --color option to simplify color support
michael-o commented on a change in pull request #436: URL: https://github.com/apache/maven/pull/436#discussion_r626340345 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java ## @@ -149,6 +151,7 @@ public CLIManager() options.addOption( Option.builder( LEGACY_LOCAL_REPOSITORY ).longOpt( "legacy-local-repository" ).desc( "Use Maven 2 Legacy Local Repository behaviour, ie no use of _remote.repositories. Can also be activated by using -Dmaven.legacyLocalRepo=true" ).build() ); options.addOption( Option.builder( BUILDER ).longOpt( "builder" ).hasArg().desc( "The id of the build strategy to use" ).build() ); options.addOption( Option.builder( NO_TRANSFER_PROGRESS ).longOpt( "no-transfer-progress" ).desc( "Do not display transfer progress when downloading or uploading" ).build() ); +options.addOption( Option.builder().longOpt( COLOR ).hasArg().desc( "Color support mode (auto/always/never)" ).build() ); Review comment: @MartinKanters This is a manifestation of the sytem property. No logical changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #436: [MNG-7080] Add a --color option to simplify color support
michael-o commented on a change in pull request #436: URL: https://github.com/apache/maven/pull/436#discussion_r626339823 ## File path: maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java ## @@ -149,6 +151,7 @@ public CLIManager() options.addOption( Option.builder( LEGACY_LOCAL_REPOSITORY ).longOpt( "legacy-local-repository" ).desc( "Use Maven 2 Legacy Local Repository behaviour, ie no use of _remote.repositories. Can also be activated by using -Dmaven.legacyLocalRepo=true" ).build() ); options.addOption( Option.builder( BUILDER ).longOpt( "builder" ).hasArg().desc( "The id of the build strategy to use" ).build() ); options.addOption( Option.builder( NO_TRANSFER_PROGRESS ).longOpt( "no-transfer-progress" ).desc( "Do not display transfer progress when downloading or uploading" ).build() ); +options.addOption( Option.builder().longOpt( COLOR ).hasArg().desc( "Color support mode (auto/always/never)" ).build() ); Review comment: I urge to retain `--color` because many many other tools use the same option. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #436: [MNG-7080] Add a --color option to simplify color support
michael-o commented on a change in pull request #436: URL: https://github.com/apache/maven/pull/436#discussion_r563901162 ## File path: pom.xml ## @@ -319,12 +319,12 @@ under the License. org.apache.maven.shared maven-shared-utils -3.2.1 +3.3.4-SNAPSHOT Review comment: We can't do this. When bisecting down to this commit it will be virtually impossible to reproduce. I went through with Maven Artifact Transfer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [maven] michael-o commented on a change in pull request #436: [MNG-7080] Add a --color option to simplify color support
michael-o commented on a change in pull request #436: URL: https://github.com/apache/maven/pull/436#discussion_r563901162 ## File path: pom.xml ## @@ -319,12 +319,12 @@ under the License. org.apache.maven.shared maven-shared-utils -3.2.1 +3.3.4-SNAPSHOT Review comment: We can't do this. When bisecting down to this commit it will be virtually impossible to reproduce. I went through with Maven Artifact Transfer. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
