[GitHub] [maven] rfscholte commented on issue #287: [MNG-6065] - Log fail-level option.
rfscholte commented on issue #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#issuecomment-562656230 -fae,--fail-at-end Only fail the build afterwards; allow all non-impacted builds to continue -ff,--fail-fastStop at first failure in reactorized builds -fn,--fail-never NEVER fail the build, regardless of project result These are the current fail-options. So it should start with `fail`, and short. e.g `--fail-on-severity ` / `-fos ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] rfscholte commented on issue #287: [MNG-6065] - Log fail-level option.
rfscholte commented on issue #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#issuecomment-562259775 Talking about `Level` within the context of logging is clear, but we're talking about the context of Maven. Suppose we would talk about `Level 42`, beside the band, what could it mean? 42 directories deep? Advanced user (depending on max level)? Hence I don't think `level` is enough, most likely `severity` or `loglevel` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] rfscholte commented on issue #287: [MNG-6065] - Log fail-level option.
rfscholte commented on issue #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#issuecomment-560542188 just thought of something else: is `level` the correct term, or should it be `severity`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven] rfscholte commented on issue #287: [MNG-6065] - Log fail-level option.
rfscholte commented on issue #287: [MNG-6065] - Log fail-level option. URL: https://github.com/apache/maven/pull/287#issuecomment-559255764 We probably need 2 loggers, as `MavenFailLevelLogger` comes with some overhead and logging is quite expensive, it should be as fast as possible. Also keep in mind that we now require Java8, so we could optimize the code with that syntax and APIs. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
