[GitHub] [maven-enforcer] svenlange commented on a change in pull request #35: [MENFORCER-304] - Improve dependency resolving in multiple modules project

2020-05-15 Thread GitBox 


svenlange commented on a change in pull request #35:
URL: https://github.com/apache/maven-enforcer/pull/35#discussion_r425633146



##
File path: 
enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java
##
@@ -191,4 +207,19 @@ public void setSearchTransitive( boolean 
theSearchTransitive )
 this.searchTransitive = theSearchTransitive;
 }
 
+/**
+ * @return the reactorProjects
+ */
+public List getReactorProjects()
+{
+return reactorProjects;
+}
+
+/**
+ * @param reactorProjects the reactorProjects to set
+ */
+public void setReactorProjects( List reactorProjects )
+{
+this.reactorProjects = reactorProjects;

Review comment:
   But this PR is still stuck cause @khmarbaise is not responding. Can 
anyone else review and decide, @elharo ?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-enforcer] svenlange commented on a change in pull request #35: [MENFORCER-304] - Improve dependency resolving in multiple modules project

2020-05-15 Thread GitBox 


svenlange commented on a change in pull request #35:
URL: https://github.com/apache/maven-enforcer/pull/35#discussion_r425632521



##
File path: 
enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java
##
@@ -191,4 +207,19 @@ public void setSearchTransitive( boolean 
theSearchTransitive )
 this.searchTransitive = theSearchTransitive;
 }
 
+/**
+ * @return the reactorProjects
+ */
+public List getReactorProjects()
+{
+return reactorProjects;
+}
+
+/**
+ * @param reactorProjects the reactorProjects to set
+ */
+public void setReactorProjects( List reactorProjects )
+{
+this.reactorProjects = reactorProjects;

Review comment:
   Great thanks!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [maven-enforcer] svenlange commented on a change in pull request #35: [MENFORCER-304] Improve dependency resolving in multiple modules project

2020-05-11 Thread GitBox 


svenlange commented on a change in pull request #35:
URL: https://github.com/apache/maven-enforcer/pull/35#discussion_r422942540



##
File path: 
enforcer-rules/src/main/java/org/apache/maven/plugins/enforcer/AbstractBanDependencies.java
##
@@ -191,4 +207,19 @@ public void setSearchTransitive( boolean 
theSearchTransitive )
 this.searchTransitive = theSearchTransitive;
 }
 
+/**
+ * @return the reactorProjects
+ */
+public List getReactorProjects()
+{
+return reactorProjects;
+}
+
+/**
+ * @param reactorProjects the reactorProjects to set
+ */
+public void setReactorProjects( List reactorProjects )
+{
+this.reactorProjects = reactorProjects;

Review comment:
   ```suggestion
   this.reactorProjects = java.util.Collections.unmodifiableList( 
reactorProjects );
   ```





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org