[GitHub] [maven-wagon] michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar
michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar URL: https://github.com/apache/maven-wagon/pull/60#issuecomment-570775919 > > > What to say.. https://github.com/apache/maven-doxia/blob/04070b889a2489d9b976b5fc865fd4e4e863b5c8/doxia-modules/doxia-module-xhtml5/src/main/java/org/apache/maven/doxia/module/xhtml5/Xhtml5Sink.java .. :-))) True case, that code is really old. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-wagon] michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar
michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar URL: https://github.com/apache/maven-wagon/pull/60#issuecomment-570510345 Attention, this might require a JDK with X11 support because it is a Swing component. I'd rather throw unsupported operation exception. You can't implement something which is not specified. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-wagon] michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar
michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar URL: https://github.com/apache/maven-wagon/pull/60#issuecomment-570158981 Because if two reasons: * regex and HTML/XML don't play well * there is no guarantee that the listing will be in the format you assume This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-wagon] michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar
michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar URL: https://github.com/apache/maven-wagon/pull/60#issuecomment-552510892 I just grepped through code and resolver and `filelist` (ci) is not called. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-wagon] michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar
michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar URL: https://github.com/apache/maven-wagon/pull/60#issuecomment-552509259 > Just thinking out loud... > If @michael-o assumption is correct we could simply not bundle it on maven-core at all, if someone hits a ClassNotFoundException he can add the jsoup jar to the lib directory. I really like this idea! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-wagon] michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar
michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar URL: https://github.com/apache/maven-wagon/pull/60#issuecomment-552499958 @hboutemy, I did not test anything. The interface implies that the underlying protocol has a notion of directories and collections. HTTP has neither. Assuming that some server will deliver some collection is wrong because it breaks a basic principle: never do an assumption about an unknown environment. Having that said, the given implementation cannot work reliably on any type of HTML style listing. Also Wagon is not necessary limited for repository manager. All I am saying is that if a protocol does not define collections/directories, don't try to implement them by some crude means with some assumptions, simply return `UnimplementedException`. Since HTTP really does not, see RFC 7230+, deprecate and mark it for removal. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-wagon] michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar
michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar URL: https://github.com/apache/maven-wagon/pull/60#issuecomment-551985282 @hboutemy First of all, Maven Core does not rely on that. Can you search for method in our code case?! Second, HTTP does not provide any listing of files. The implementation is highly coupled to a 10+ y/o Apache HTTPd mod_userdir output. It was a misconception from the beginning. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [maven-wagon] michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar
michael-o commented on issue #60: [WAGON-574] advertise jsoup license for shaded jar URL: https://github.com/apache/maven-wagon/pull/60#issuecomment-551841799 I'd rather drop JSoup usage because of the reasons I have described on the mailing list. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
