[GitHub] eolivelli commented on a change in pull request #1: Allow scripting in files
eolivelli commented on a change in pull request #1: Allow scripting in files URL: https://github.com/apache/maven-scripting-plugin/pull/1#discussion_r245474960 ## File path: pom.xml ## @@ -35,7 +35,8 @@ under the License. Apache Maven Scripting Plugin -The Maven Scripting Plugin is a plugin that wrapped the Scripting API accoring to JSR223 +The Maven Scripting Plugin is a plugin that wrapped the Scripting API accoring to JSR223. Review comment: Now that you are fixing this file please fix this typo as well: "accoring" -> "according" This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on a change in pull request #1: Allow scripting in files
eolivelli commented on a change in pull request #1: Allow scripting in files URL: https://github.com/apache/maven-scripting-plugin/pull/1#discussion_r245474964 ## File path: pom.xml ## @@ -92,13 +93,6 @@ under the License. provided - - Review comment: @rpopov as we never released this plugin to the public I am fine with dropping the dependency now This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on a change in pull request #1: Allow scripting in files
eolivelli commented on a change in pull request #1: Allow scripting in files URL: https://github.com/apache/maven-scripting-plugin/pull/1#discussion_r244647780 ## File path: pom.xml ## @@ -30,12 +30,13 @@ under the License. maven-scripting-plugin - 3.0.0-SNAPSHOT Review comment: This will be change during release. Please revert This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] eolivelli commented on a change in pull request #1: Allow scripting in files
eolivelli commented on a change in pull request #1: Allow scripting in files URL: https://github.com/apache/maven-scripting-plugin/pull/1#discussion_r244648006 ## File path: pom.xml ## @@ -92,13 +93,6 @@ under the License. provided - - Review comment: This will be an important change for users, it should be another ticket, please create a separate patch. Btw why don't you want this one on the classpath? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
