[GitHub] maven-surefire issue #172: [SUREFIRE-1453] Allow to specify non existant cla...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/maven-surefire/pull/172
  
You are welcome!


---

[GitHub] maven-surefire issue #172: [SUREFIRE-1453] Allow to specify non existant cla...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/172
  
@eolivelli 
Thx for contributing. The PR was pushed to master and now it can be closed.


---

[GitHub] maven-surefire issue #172: [SUREFIRE-1453] Allow to specify non existant cla...

[eolivelli]

Github user eolivelli commented on the issue:

https://github.com/apache/maven-surefire/pull/172
  
@Tibor17 I have added some IT.
I found a bug in JUnit48TestCategoriesIT, actually 
testCategoriesABForkAlways did not call ".forkAlways()"

I have added an IT test for the case of no class matching the filter.
I have enhanced the testCategoriesAC in a way that it tests only using 
Simple Class Names and not Fully Qualified  Class Names.
In fact I saw that the original idea in was to let the use pass even 
suffixes:
`if ( name.endsWith( enabled ) )`
But actually could not work because the 'pattern' had to be a resolvable 
class name.

I did changed names in parameters in JUnit48TestCategoriesIT to make them 
more "consistent"


---

[GitHub] maven-surefire issue #172: [SUREFIRE-1453] Allow to specify non existant cla...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/172
  
Try to name the commit with brackets:
` [SUREFIRE-1453] Allow to specify non existant classes as groups`


---

[GitHub] maven-surefire issue #172: [SUREFIRE-1453] Allow to specify non existant cla...

[Tibor17]

Github user Tibor17 commented on the issue:

https://github.com/apache/maven-surefire/pull/172
  
@eolivelli 
Thx for your work. Try to prove it with integration test. We always have to 
do it if it technically can be tested.


---