[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-390888715 @hboutemy , looks good to me. Did you have a chance to run the new IT on? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-390731655 > I know that we have such a case with booleans, where we do not put the effective field type in the descriptor but String for more flexibility: in this boolean case, it was about inheritance, to make the difference between inheriting and overriding with a value. Then there is a hand-written getter to get the field as boolean (instead of the internal String) This is another issue with our interpolation. Can you point me to that handwritten spot? > I don't know if we have such cases in Maven core with ints, but the previous pattern hand-writing a typed getter to int should do the job. The core model does not use ints, but only booleans for activation. > switch back to String based interpolation instead of Object interpolation? I don't see any quality difference between those two, from user POV > change the field from int to String and add the hand-written getter? This is going to be hard because a lot of our code relies on the int #getPort(). If this PR breaks our approach w/o understanding previous motives, I'd stall it for 3.6.0 or later. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-386841740 As far as I understand this PR, you are interpolating the settings before it is fed to `SettingsXpp3Reader`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-386842019 Can you also provide an IT for that? @hboutemy, @rfscholte This is a very interesting case and I can confirm that our approach is incorrect. We need to interpolate the XML first and then unmarshal to objects and not the other way around. Everything, but `String` will be killed otherwise. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml
michael-o commented on issue #163: [MNG-6401] - Cannot interpolate property in proxy port of settings.xml URL: https://github.com/apache/maven/pull/163#issuecomment-386841740 As far as I understand this PR, you are interpolating the settings before it is fead to `SettingsXpp3Reader`? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
