[GitHub] michael-o commented on issue #74: [SCM-885] third implementation
michael-o commented on issue #74: [SCM-885] third implementation URL: https://github.com/apache/maven-scm/pull/74#issuecomment-390918449 I am aware of that, but it still remains bloat for the test. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michael-o commented on issue #74: [SCM-885] third implementation
michael-o commented on issue #74: [SCM-885] third implementation URL: https://github.com/apache/maven-scm/pull/74#issuecomment-390892686 The code looks way better now, I am fine adding a new repo for a test, but I don't hink we need to commit bloat. See the other test repos, they have a minimal set of files: no hooks or stuff. They aren't necessary. Also have a look at `config` it contains a local path from your computer. Please align and I will run tests, and merge. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] michael-o commented on issue #74: [SCM-885] third implementation
michael-o commented on issue #74: [SCM-885] third implementation URL: https://github.com/apache/maven-scm/pull/74#issuecomment-390320081 Why did you rename the test repo and have added a new one? What was actually wrong with the given one? The are a lot of sample hooks which aren't superfluous for the test (they may have existed in the previous repo also). This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
