Re: [PR] [MCOMPILER-584] Refresh page - Using Non-Javac Compilers [maven-compiler-plugin]

2024-03-14 Thread via GitHub


slawekjaranowski merged PR #231:
URL: https://github.com/apache/maven-compiler-plugin/pull/231


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MCOMPILER-584] Refresh page - Using Non-Javac Compilers [maven-compiler-plugin]

2024-03-13 Thread via GitHub


slawekjaranowski commented on code in PR #231:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/231#discussion_r1523756890


##
src/site/apt/non-javac-compilers.apt.vm:
##
@@ -46,7 +48,7 @@ Using Non-Javac Compilers
 
   * <<>> with artifactId <<>>.
 
-  * <<>> with artifactId <<>>.
+  * <<>>  with artifactId 
<<>>.

Review Comment:
   @CrazyHZM - requirements was added 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



Re: [PR] [MCOMPILER-584] Refresh page - Using Non-Javac Compilers [maven-compiler-plugin]

2024-03-13 Thread via GitHub


CrazyHZM commented on code in PR #231:
URL: 
https://github.com/apache/maven-compiler-plugin/pull/231#discussion_r1522826527


##
src/site/apt/non-javac-compilers.apt.vm:
##
@@ -46,7 +48,7 @@ Using Non-Javac Compilers
 
   * <<>> with artifactId <<>>.
 
-  * <<>> with artifactId <<>>.
+  * <<>>  with artifactId 
<<>>.

Review Comment:
   javac-with-errorprone requires JDK 11+. Do you think this needs a special 
explanation?
   
https://codehaus-plexus.github.io/plexus-compiler/plexus-compilers/plexus-compiler-javac-errorprone/



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[PR] [MCOMPILER-584] Refresh page - Using Non-Javac Compilers [maven-compiler-plugin]

2024-03-12 Thread via GitHub


slawekjaranowski opened a new pull request, #231:
URL: https://github.com/apache/maven-compiler-plugin/pull/231

   https://issues.apache.org/jira/browse/MCOMPILER-584


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org