Re: [PR] [MSKINS-245] Add code highlighting class to every combination [maven-fluido-skin]

[via GitHub]

asfgit closed pull request #58: [MSKINS-245] Add code highlighting class to 
every  combination
URL: https://github.com/apache/maven-fluido-skin/pull/58


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MSKINS-245] Add code highlighting class to every combination [maven-fluido-skin]

[via GitHub]

kwin commented on PR #58:
URL: https://github.com/apache/maven-fluido-skin/pull/58#issuecomment-2119370796

   > Should I rebase and merge this? I'd like to start the release
   
   Yes, please.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MSKINS-245] Add code highlighting class to every combination [maven-fluido-skin]

[via GitHub]

michael-o commented on PR #58:
URL: https://github.com/apache/maven-fluido-skin/pull/58#issuecomment-2119337386

   @kwin Should I rebase and merge this? I'd like to start the release.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MSKINS-245] Add code highlighting class to every combination [maven-fluido-skin]

[via GitHub]

michael-o commented on PR #58:
URL: https://github.com/apache/maven-fluido-skin/pull/58#issuecomment-2106023820

   This can now reduced to:
   ```patch
   diff --git a/src/main/resources/META-INF/maven/site.vm 
b/src/main/resources/META-INF/maven/site.vm
   index 5e0604f..26bb876 100644
   --- a/src/main/resources/META-INF/maven/site.vm
   +++ b/src/main/resources/META-INF/maven/site.vm
   @@ -242 +242 @@
   -#*  *#$bodyContent.replaceAll( '(\r?\n)?', '' ).replaceAll( 'class="bodyTable"', 'class="table 
table-striped"' ).replaceAll( 'class="bodyTable bodyTableBorder"', 
'class="table table-bordered table-striped"' )
   +#*  *#$bodyContent.replace( '', '' ).replace( 'class="bodyTable"', 'class="table 
table-striped"' ).replace( 'class="bodyTable bodyTableBorder"', 'class="table 
table-bordered table-striped"' )
   diff --git a/src/main/resources/css/maven-base.css 
b/src/main/resources/css/maven-base.css
   index 829ef71..5747cd6 100644
   --- a/src/main/resources/css/maven-base.css
   +++ b/src/main/resources/css/maven-base.css
   @@ -33 +33 @@ section > table.table,
   -section > div.verbatim {
   +section > pre {
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MSKINS-245] Add code highlighting class to every combination [maven-fluido-skin]

[via GitHub]

michael-o commented on code in PR #58:
URL: https://github.com/apache/maven-fluido-skin/pull/58#discussion_r1586012833


##
src/main/resources/META-INF/maven/site.vm:
##
@@ -239,7 +239,7 @@
 #**##set( $sourceStyle = "prettyprint" )
 #*  *##end
 ##
-#*  *#$bodyContent.replaceAll( '(\r?\n)?', '' ).replaceAll( 'class="bodyTable"', 'class="table 
table-striped"' ).replaceAll( 'class="bodyTable bodyTableBorder"', 
'class="table table-bordered table-striped"' )
+#*  *#$bodyContent.replaceAll( '', '' ).replaceAll( 'class="bodyTable"', 'class="table 
table-striped"' ).replaceAll( 'class="bodyTable bodyTableBorder"', 
'class="table table-bordered table-striped"' )

Review Comment:
   Since we don't need regex anymore, we can resort to just `replace()` here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Re: [PR] [MSKINS-245] Add code highlighting class to every combination [maven-fluido-skin]

[via GitHub]

kwin commented on PR #58:
URL: https://github.com/apache/maven-fluido-skin/pull/58#issuecomment-191720

   This also fixes the missing indentation for `` (broken 
in both Fluido 1.x and 2.x), which e.g. can be seen in 

   
   ![Screenshot 2024-03-15 at 17 08 
35](https://github.com/apache/maven-fluido-skin/assets/185025/f33b93f7-a3f0-404c-a90e-54c2d919ffae)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org